| *** coolsvap has joined #openstack-rpm-packaging | 02:59 | |
| *** coolsvap has quit IRC | 05:42 | |
| *** coolsvap has joined #openstack-rpm-packaging | 05:52 | |
| *** coolsvap has quit IRC | 06:20 | |
| *** coolsvap has joined #openstack-rpm-packaging | 06:21 | |
| *** coolsvap has quit IRC | 06:25 | |
| *** coolsvap has joined #openstack-rpm-packaging | 06:25 | |
| *** pcaruana has joined #openstack-rpm-packaging | 06:46 | |
| *** mpavone has joined #openstack-rpm-packaging | 06:51 | |
| *** jpena|off is now known as jpena | 07:15 | |
| openstackgerrit | Merged openstack/rpm-packaging: Add pymod2pkg v0.4.0 https://review.openstack.org/330527 | 07:35 |
|---|---|---|
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.log to 3.11.0 https://review.openstack.org/335933 | 07:38 |
| *** apevec has joined #openstack-rpm-packaging | 08:06 | |
| *** apevec has left #openstack-rpm-packaging | 08:07 | |
| *** rbowen has joined #openstack-rpm-packaging | 11:31 | |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.i18n to 3.7.0 https://review.openstack.org/335952 | 11:52 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.middleware to 3.14.0 https://review.openstack.org/335950 | 11:56 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.service to 1.12.0 https://review.openstack.org/335954 | 11:56 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.reports to 1.11.0 https://review.openstack.org/335936 | 11:56 |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging: Add initial spec for tempest-lib https://review.openstack.org/331492 | 11:57 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslosphinx to 4.5.0 https://review.openstack.org/336031 | 11:58 |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging: Add initial spec for oslo.versionedobjects https://review.openstack.org/331548 | 12:00 |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging: Remove flake8 dep https://review.openstack.org/333831 | 12:02 |
| *** openstackgerrit has quit IRC | 12:19 | |
| *** openstackgerrit has joined #openstack-rpm-packaging | 12:19 | |
| *** _prad_ has joined #openstack-rpm-packaging | 12:21 | |
| *** jpena is now known as jpena|lunch | 12:21 | |
| *** _prad_ is now known as _\prad | 12:38 | |
| *** _\prad has quit IRC | 12:38 | |
| *** pradk- has joined #openstack-rpm-packaging | 12:43 | |
| *** jpena|lunch is now known as jpena | 13:34 | |
| *** openstackgerrit has quit IRC | 15:33 | |
| *** openstackgerrit has joined #openstack-rpm-packaging | 15:34 | |
| *** pcaruana has quit IRC | 16:33 | |
| *** mpavone has quit IRC | 16:35 | |
| *** jpena is now known as jpena|off | 16:51 | |
| openstackgerrit | Haïkel Guémar proposed openstack/rpm-packaging: Use Source0 in os-testr https://review.openstack.org/336026 | 16:58 |
| astsmtl- | toabctl, number80, let's discuss https://review.openstack.org/#/c/336151/ | 17:16 |
| number80 | yes? | 17:17 |
| astsmtl- | toabctl, I don't understand what you mean by "No unittests". Should I write some? | 17:17 |
| number80 | yes | 17:17 |
| number80 | but I still don't see the point of that review | 17:17 |
| number80 | if you don't provide an epoch file, it just works | 17:18 |
| astsmtl- | That's the other question, lets discuss it first. | 17:18 |
| astsmtl- | The point is that I executed `renderspec` with wrong --epoch or --requirements and got some result instead of error. | 17:19 |
| astsmtl- | And I think it's a bad behaviour. | 17:19 |
| number80 | well, you're breaking the use case when you provide correct defaults | 17:19 |
| number80 | I think a better solution would be validating those files | 17:20 |
| astsmtl- | And defaults here are harmful, because default file name is relative. | 17:20 |
| astsmtl- | So the result of renderspec depends on current directory. | 17:21 |
| number80 | this can be changed | 17:21 |
| number80 | that's something I can agree with | 17:21 |
| number80 | checking /etc/renderspec then ~/.config/renderspec then user provided file | 17:21 |
| number80 | should be a more sensitive default | 17:21 |
| astsmtl- | Ok, do you agree that failing if user provided file doesn't exist is a good thing? | 17:22 |
| astsmtl- | If so, I can further improve this CR. | 17:22 |
| number80 | this case, yes | 17:22 |
| astsmtl- | Ok, now about unittests. | 17:26 |
| astsmtl- | Why do you expect me to write unittests for functions that were written by other peopele? | 17:27 |
| astsmtl- | *people | 17:28 |
| astsmtl- | I just changed it, and there were no unittests for it, and there is nothing to fix. | 17:29 |
| number80 | well, since we're changing how it works, adding unit tests still makes sense | 18:02 |
| number80 | even basic ones | 18:02 |
| astsmtl- | It always makes sense to add unittests, but IMO setting -1 in this case isn't appropriate. | 18:10 |
| astsmtl- | btw, I thought a bit about your proposal with multiple locations for configs and merge and I can't see any value in it. But maybe I don't see bigger picture here. | 18:12 |
| astsmtl- | IIUC the only place where epoch and requirements file reside is rpm-packaging repository. Which use cases will require this files to be placed in /etc/renderspec or ~/.config/renderspec? | 18:14 |
| *** coolsvap has quit IRC | 19:32 | |
| *** pradk- has quit IRC | 20:49 | |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging: Add initial spec for oslo.versionedobjects https://review.openstack.org/331548 | 21:22 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!