| *** bdemers has joined #openstack-rpm-packaging | 01:19 | |
| *** paragan has joined #openstack-rpm-packaging | 02:50 | |
| *** chandankumar has joined #openstack-rpm-packaging | 07:50 | |
| *** dguitarbite has joined #openstack-rpm-packaging | 08:10 | |
| *** mpavone has joined #openstack-rpm-packaging | 08:13 | |
| *** apevec has joined #openstack-rpm-packaging | 08:16 | |
| *** apevec has left #openstack-rpm-packaging | 08:17 | |
| *** openstackgerrit has quit IRC | 08:47 | |
| *** ihrachys has joined #openstack-rpm-packaging | 08:48 | |
| *** openstackgerrit has joined #openstack-rpm-packaging | 08:48 | |
| toabctl | IgorYozhikov, dirk, number80: can you have a look at https://review.openstack.org/#/c/290330/ ? | 08:48 |
|---|---|---|
| toabctl | this is to simplify the version handling for the spec files. | 08:49 |
| number80 | ack | 08:49 |
| openstackgerrit | Igor Yozhikov proposed openstack/rpm-packaging: Add initial spec file for python-glanceclient https://review.openstack.org/280246 | 08:51 |
| IgorYozhikov | toabctl, will look, test & comment | 08:53 |
| IgorYozhikov | btw, glanceclient was updated with new epoch syntax | 08:53 |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging-tools: Add rpm-packaging-status.py for generating reports https://review.openstack.org/281906 | 09:01 |
| number80 | toabctl: do you have a test failures due to oslosphinx? | 09:28 |
| number80 | (w/ renderspec) | 09:28 |
| toabctl | number80: ? where? what? | 09:29 |
| number80 | http://fpaste.org/336089/45751579/ | 09:30 |
| number80 | I had to explicitly avoid 4.3 as it freezes my laptop | 09:30 |
| number80 | looks like a pbr failure | 09:31 |
| toabctl | number80: so how does this happen? | 09:31 |
| toabctl | number80: when installing renderspec in a venv? | 09:31 |
| number80 | Same failure w/ tox or python setup.py test (either in venv or not) | 09:31 |
| toabctl | number80: tox -epy27 (and removing before .tox) works here | 09:33 |
| toabctl | with oslosphinx==4.3.0 | 09:34 |
| number80 | I need to investigate this | 09:34 |
| number80 | (had another freeze) | 09:34 |
| toabctl | number80: maybe http://stackoverflow.com/questions/21136266/typeerror-dist-must-be-a-distribution-instance-when-resolving-beautifulsoup-d ? | 09:35 |
| toabctl | I'm using setuptools 19.6.2 | 09:36 |
| *** paragan has quit IRC | 09:37 | |
| number80 | we have a slightly older one | 09:37 |
| number80 | ok, i managed to retrieve a decent backtrace before freeze, it seems that venv calls system distutils???? | 09:40 |
| number80 | that's the same issue, but for some reason, I get a much older setuptools | 09:44 |
| toabctl | number80: I'm getting setuptools 18.2 when I create a new virtualenv | 09:55 |
| toabctl | number80: maybe you need a newer virtualenv package? | 09:57 |
| *** chthon has joined #openstack-rpm-packaging | 09:58 | |
| *** chandankumar has quit IRC | 10:00 | |
| number80 | toabctl: maybe, I'm also finding issue with setuptools 20.something but less critical | 10:02 |
| number80 | funnily cleaning tox worked but with old setuptools 12.0.5 ... | 10:03 |
| number80 | well, I'll continue the review | 10:04 |
| number80 | gives me a good excuse to switch to F24 pre-alpha on laptop | 10:05 |
| toabctl | :) | 10:05 |
| *** bdemers has quit IRC | 10:17 | |
| *** bdemers has joined #openstack-rpm-packaging | 10:22 | |
| IgorYozhikov | https://review.openstack.org/#/c/284906/ - merge? | 10:32 |
| toabctl | IgorYozhikov: no. it doesn't build. | 10:32 |
| toabctl | IgorYozhikov: I#m looking into that currently | 10:32 |
| IgorYozhikov | how to recheck? | 10:32 |
| toabctl | IgorYozhikov: I'm testing locally currently | 10:32 |
| IgorYozhikov | ok, please let me know, also keystoneclient is on the way, mivanov is going to publish it today | 10:33 |
| toabctl | IgorYozhikov: commented for ostestr with a possible fix | 10:35 |
| *** paragan has joined #openstack-rpm-packaging | 10:36 | |
| *** paragan has joined #openstack-rpm-packaging | 10:36 | |
| *** chandankumar has joined #openstack-rpm-packaging | 11:13 | |
| openstackgerrit | Igor Yozhikov proposed openstack/rpm-packaging: Add initial spec for os-testr https://review.openstack.org/284906 | 11:21 |
| IgorYozhikov | toabctl, os-testr ^^^ | 11:21 |
| toabctl | IgorYozhikov: already commented :) | 11:22 |
| openstackgerrit | Igor Yozhikov proposed openstack/rpm-packaging: Add initial spec for os-testr https://review.openstack.org/284906 | 11:23 |
| IgorYozhikov | updated : | 11:23 |
| toabctl | IgorYozhikov: can you also mark the comments as done when they are done? makes reviewing easier (not in this case, but in general ) | 11:23 |
| IgorYozhikov | toabctl, sure, will do | 11:24 |
| *** mpavone has quit IRC | 11:50 | |
| *** mpavone has joined #openstack-rpm-packaging | 11:51 | |
| *** dguitarbite has quit IRC | 12:27 | |
| toabctl | IgorYozhikov: would be cool to get feedback for https://review.openstack.org/#/c/290330/ | 12:28 |
| toabctl | number80: still fine withj https://review.openstack.org/#/c/284906/ ? | 12:29 |
| IgorYozhikov | toabctl, going to check in 10 min | 12:32 |
| *** dguitarbite has joined #openstack-rpm-packaging | 12:41 | |
| *** jpena is now known as jpena|lunch | 13:39 | |
| *** IgorYozhikov has quit IRC | 13:41 | |
| *** dteselkin has quit IRC | 13:41 | |
| *** IgorYozhikov has joined #openstack-rpm-packaging | 14:16 | |
| *** dteselkin has joined #openstack-rpm-packaging | 14:18 | |
| *** chandankumar has quit IRC | 14:20 | |
| openstackgerrit | Mikhail Ivanov proposed openstack/rpm-packaging: Add initial spec file for python-keystoneclient https://review.openstack.org/290472 | 14:30 |
| openstackgerrit | Mikhail Ivanov proposed openstack/rpm-packaging: Add initial spec file for python-keystoneclient https://review.openstack.org/290472 | 14:31 |
| IgorYozhikov | toabctl, http://paste.openstack.org/show/489851/ | 14:37 |
| toabctl | IgorYozhikov: does it work for you? or is anything missing? I tested it with another spec and looks like it worked | 14:39 |
| IgorYozhikov | toabctl, doubling bounds | 14:40 |
| toabctl | IgorYozhikov: can you post your source spec.j2 file? | 14:40 |
| IgorYozhikov | toabctl, http://paste.openstack.org/show/489853/ - in old syntax, so, I believe that I need to retest it with something new, going to check | 14:44 |
| toabctl | yeah. but anyway that's broken. I'll add a test and fix it. thanks! | 14:45 |
| *** jpena|lunch is now known as jpena | 14:47 | |
| *** chandankumar has joined #openstack-rpm-packaging | 14:51 | |
| IgorYozhikov | toabctl, http://paste.openstack.org/show/489854/ | 14:53 |
| IgorYozhikov | with os-testr | 14:53 |
| toabctl | IgorYozhikov: can you post the spec.j2 as well? I guess the version is still hardcoded there. so if there's a version in py2pkg() then this version is used and the version from global-requirements is *not* used | 14:55 |
| IgorYozhikov | understood, os-testr spec.j2 is the same as on review - https://review.openstack.org/#/c/284906/ | 15:01 |
| *** pradk has joined #openstack-rpm-packaging | 15:09 | |
| toabctl | hm. so old-style filtering needs a special case. | 15:19 |
| toabctl | I may just go ahead and remove all currently used old-style stuff before we start to build workarounds for it. | 15:19 |
| IgorYozhikov | toabctl, right - unmanaged versions handled by renderspec via requirements - BuildRequires: python-pbr >= 1.9 | 15:21 |
| IgorYozhikov | so it works as was described in commmit message | 15:21 |
| IgorYozhikov | please, let men know when you will finish with small fixes 4 tests :) | 15:22 |
| openstackgerrit | Thomas Bechtold proposed openstack/renderspec: Support package versions from global requirements file https://review.openstack.org/290330 | 15:22 |
| toabctl | IgorYozhikov: updated the renderspec PR. should now still work with old-style filters | 15:22 |
| IgorYozhikov | I'm just unset version in spec.j2 for pbr and relaunch rendering - works | 15:22 |
| IgorYozhikov | going to check with old oslo | 15:24 |
| IgorYozhikov | still doesn't work with old syntax. renderspec --spec-style fedora --epoch epo.yaml --requirements /opt/oslo.i18n/requirements.txt rpm-packaging/openstack/oslo.i18n/oslo.i18n.spec.j2 -o - | grep pbr | 15:31 |
| IgorYozhikov | BuildRequires: python-pbr | 15:31 |
| IgorYozhikov | Requires:python-pbr | 15:31 |
| toabctl | yeah. with the old syntax, the version is not automatically filled. | 15:31 |
| IgorYozhikov | if it is as designed - I'm OK | 15:31 |
| toabctl | but imo that's not a problem | 15:31 |
| IgorYozhikov | sure, so +2 | 15:31 |
| IgorYozhikov | and going to prepare local update of renderspec.rpm | 15:32 |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging: Use py2pkg() contextfunction everywhere https://review.openstack.org/290619 | 16:03 |
| toabctl | IgorYozhikov: ^^ this removes all the filter usage | 16:03 |
| toabctl | for py2pkg | 16:03 |
| toabctl | number80, dirk: ^^ | 16:04 |
| *** mpavone has quit IRC | 16:30 | |
| IgorYozhikov | toabctl, please check BuildRequires: lower bounds (minimal versions) | 16:47 |
| toabctl | IgorYozhikov: where? | 16:51 |
| IgorYozhikov | toabctl, I'm about your last commit with sed | 16:54 |
| toabctl | ah. something wrong there? | 16:54 |
| toabctl | can you add a comment? | 16:54 |
| *** paragan has quit IRC | 16:54 | |
| toabctl | ah. you did :-) | 16:55 |
| toabctl | IgorYozhikov: well - I can't do that with sed. the goal of that commit is to get rid of the py2pkg filter usage | 16:55 |
| IgorYozhikov | I love sed magic, when use it, not every1 can even read the code :) | 16:55 |
| toabctl | so I wouldn't fix the missing versions here tbh | 16:56 |
| toabctl | let's do that cleanup in another commit | 16:56 |
| IgorYozhikov | toabctl, ok - sounds reasonable | 16:56 |
| toabctl | IgorYozhikov: if we agree on the global-requirements usage, we have to delete all versions anyway. | 16:57 |
| IgorYozhikov | toabctl, - done | 16:57 |
| toabctl | thx! | 16:57 |
| IgorYozhikov | toabctl, not sure that we need to do that. because of some projects have version requirements higher that set in requirements.txt | 16:58 |
| IgorYozhikov | pbr >= 1.8 for example from setup.py | cfg | 16:58 |
| IgorYozhikov | I suggest to update versions which are lower | older that set in requirements.txt | 16:59 |
| toabctl | hm. | 17:00 |
| IgorYozhikov | ie. flexibility with manual versions setup with automations | 17:00 |
| toabctl | usually all openstack projects follow the versions from https://github.com/openstack/requirements/blob/master/global-requirements.txt | 17:01 |
| IgorYozhikov | yes, I know that | 17:01 |
| toabctl | maybe pbr is a special case | 17:01 |
| IgorYozhikov | https://github.com/openstack/oslo.db/blob/4.5.0/setup.py#L28, https://github.com/openstack/oslo.i18n/blob/3.4.0/setup.py#L28 VS https://github.com/openstack/requirements/blob/master/global-requirements.txt#L135 | 17:02 |
| toabctl | IgorYozhikov: vs https://github.com/openstack/oslo.db/blob/4.5.0/requirements.txt | 17:04 |
| toabctl | it's somehow strange that in setup.py and requirements.txt are 2 different versions. imo that's a bug | 17:04 |
| IgorYozhikov | toabctl, I think that we should not cut ability to set up versions manually. :) | 17:05 |
| IgorYozhikov | keystoneclient has the same situation | 17:05 |
| toabctl | IgorYozhikov: sure. I don't want to do that. but I would try to minimize the manual handling | 17:05 |
| IgorYozhikov | https://github.com/openstack/python-keystoneclient/blob/master/setup.py | 17:05 |
| IgorYozhikov | toabctl, it will be cool if requirements file usage will override only outdated | old versions | 17:06 |
| IgorYozhikov | and of course absent version values | 17:06 |
| IgorYozhikov | and of course absent version values substitutions with values from requirements files | 17:07 |
| toabctl | but maybe you *want* to have a outdated version (because you know this version also works) | 17:07 |
| toabctl | hm. but if you *want* it, then you can just set it in the requirements.txt file for yourself. | 17:08 |
| toabctl | just thinking loud.... | 17:08 |
| IgorYozhikov | additional cli flag|param ? --keep-old-versions | 17:08 |
| IgorYozhikov | additional cli flag|param ? --update-old-versions | 17:08 |
| IgorYozhikov | one of them could be used as default behavior | 17:09 |
| IgorYozhikov | and if one of mentioned flags set - will be updated only entries without versions | 17:10 |
| toabctl | hm. still not sure why we really need this. if global-requirements.txt has pbr>=1.6 and we know we need >=1.8 , then we can just set >=1.8 in the global requirements | 17:10 |
| IgorYozhikov | and if you want to use automated things like Jenkins Jobs - how to handle such cases? | 17:11 |
| toabctl | and it's anyway not possible to have 2 different rpm's with different versions installed. so having the requirements globally make sense to me. | 17:11 |
| toabctl | you mean in the pbr example case? | 17:11 |
| IgorYozhikov | agree that within one OS release should be used same versions for all components | 17:12 |
| IgorYozhikov | we use pbr 1.8 and minimum requirements set as >= 1.6 - fits us | 17:14 |
| toabctl | yeah | 17:14 |
| toabctl | so my idea is to use the global-requirements.txt from upstream and if downstream (suse miratin redhat ...) needs different requirements they can adjust the file and use that when rendering the specs | 17:15 |
| IgorYozhikov | just want to be more flexible in setting up an automated environments | 17:15 |
| toabctl | we can discuss it tomorrow in the meeting again. maybe number80, dirk, ... have other input | 17:16 |
| IgorYozhikov | your point taken, will think on addition for special key for updates of old versions | 17:16 |
| IgorYozhikov | yep, good idea - discuss | 17:16 |
| *** chthon has quit IRC | 17:34 | |
| *** ihrachys has quit IRC | 18:10 | |
| *** jpena is now known as jpena|zzz | 18:14 | |
| *** chandankumar has quit IRC | 18:35 | |
| *** ihrachys has joined #openstack-rpm-packaging | 20:25 | |
| *** ihrachys has quit IRC | 20:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!