| gmann | smcginnis: prometheanfire around | 00:59 |
|---|---|---|
| smcginnis | Hey gmann. Kind of. What's up? | 00:59 |
| gmann | smcginnis: prometheanfire should not we revert this completely instead of blacklist? - https://review.opendev.org/#/c/727943/1 | 00:59 |
| gmann | we have pep8 and doc failure and pep8 fix is already up to have right hacking version but that is not landed for many projects yet and doc job started failing for few | 01:00 |
| smcginnis | That's blacklisted because a newer release came out that superceded it, so we just needed to block that one version. | 01:00 |
| gmann | but new version still failing right | 01:01 |
| smcginnis | I don't think so? | 01:02 |
| smcginnis | I know nova has some issues, but that seems to be a configuration issue specific to nova. | 01:02 |
| smcginnis | Other jobs are passing fine. | 01:02 |
| gmann | cinder also failed i think , let me recheck | 01:02 |
| smcginnis | There's a different docs job issue related to pdf builds. | 01:03 |
| smcginnis | Sorry, gotta run. moderating a virtual meetup. | 01:03 |
| gmann | cinder also failing with 2.1.1 - https://review.opendev.org/#/c/728281/ | 01:03 |
| prometheanfire | gmann: ya, the doc failure is new | 01:05 |
| prometheanfire | hitting us too | 01:05 |
| smcginnis | Requirements issues: https://review.opendev.org/#/c/728317/ | 01:05 |
| prometheanfire | ya, looking in infra now | 01:06 |
| *** brinzhang_ has joined #openstack-requirements | 01:31 | |
| *** brinzhang has quit IRC | 01:34 | |
| gmann | fast way to unblock can be moving openstackdocstheme to 2.0.2 for temporary, let pep8 fix in and then we bring back the new openstackdocstheme. because hacking is blacklist req so cannot be control in g-r side | 01:43 |
| gmann | smcginnis: prometheanfire what you suggest? ^^, at least nova, cinder are failing on doc + pep8, i have not checked other projects | 01:50 |
| melwitt | I'm +1 on reverting/pinning to 2.0.2 for now too given the docs jobs failures in nova and cinder | 02:00 |
| melwitt | the relevant docs job failure is "Package inputenc Error: Unicode char" https://zuul.opendev.org/t/openstack/build/9064efbab9734022ba08e0f8121f3bbf/log/job-output.txt#6737 | 02:02 |
| melwitt | which will happen in any project using unicode chars in their docs, with 2.1.0 and 2.1.1 | 02:03 |
| prometheanfire | melwitt: swich openstackdocstheme===2.0.2, then projects switch pep8 version? | 02:19 |
| prometheanfire | I'm not fully sure what needs to be done why | 02:20 |
| prometheanfire | and not sure what it has to do with hacking | 02:20 |
| gmann | prometheanfire: pepe8 job is also failing due to new hacking 3.1.0 and its fixed is blocked by doc job failure - example- https://review.opendev.org/#/c/727347/2 | 02:21 |
| melwitt | we have two separate problems. docs jobs failing for projects that have unicode chars in their docs, during pdf build. fail for that happens with openstackdocstheme >= 2.1.0 | 02:21 |
| gmann | and same for doc fix which is blocked by pep8 failure | 02:21 |
| melwitt | pep8 jobs failing for projects who happen to have code violations that are newly checked with flake8 3.8.1 which got brought in with the release of hacking 3.1.0 | 02:22 |
| prometheanfire | melwitt: https://review.opendev.org/#/c/728333/ | 02:22 |
| melwitt | prometheanfire: no that's an unrelated thing I was proposing | 02:22 |
| prometheanfire | https://review.opendev.org/#/c/728333/ doesn't solve the unicode pdf problem? | 02:22 |
| melwitt | no because the failure is earlier than that, jobs failing because of the default latex_engine 'pdflatex' doesn't support unicode chars well | 02:24 |
| prometheanfire | fun | 02:25 |
| melwitt | the change that went out in 2.1.1 intended to set latex_engine 'xelatex' https://review.opendev.org/#/c/727992/1/openstackdocstheme/ext.py but it didn't work because app.config.latex_engine must already be defaulted to 'pdflatex' by that point. so it skips setting it to 'xelatex' | 02:25 |
| melwitt | fun is right | 02:25 |
| prometheanfire | ok, I'm fine rolling things back | 02:25 |
| melwitt | now, once we get 'xelatex' set we may or may not need the font pack. things *used* to work with 2.0.2 without the font pack but I have no idea how | 02:27 |
| melwitt | but I found that after I set 'xelatex', the next failure I hit was absence of the font pack. so you may be right that we'll need that too. but I don't expect to need it given that 2.0.2 used to work | 02:27 |
| openstackgerrit | Matthew Thode proposed openstack/requirements master: roll back openstackdocstheme to 2.0.2 for pdf build issues https://review.opendev.org/728335 | 02:28 |
| prometheanfire | ok, try ^ | 02:28 |
| prometheanfire | I can't force merge, if that's needed | 02:28 |
| gmann | thanks | 02:31 |
| melwitt | testing here on our pep8 job fix patch https://review.opendev.org/727347 | 02:39 |
| melwitt | to see if it'll pass the docs job with depends-on the roll back | 02:40 |
| prometheanfire | yep | 02:41 |
| prometheanfire | thanks | 02:41 |
| melwitt | bah, it's still pulling 2.1.1 even with the depends-on, so job still fails | 03:15 |
| melwitt | prometheanfire, smcginnis: any idea why that would be? ^ | 03:18 |
| melwitt | like is that expected or no | 03:19 |
| gmann | i think that is because constraint used from https://releases.openstack.org/constraints/upper/master | 03:20 |
| melwitt | oh, ok. my bad | 03:21 |
| gmann | once prometheanfire merge this 728335 then we can recheck and should pass | 03:22 |
| melwitt | I see ok | 03:23 |
| gmann | i also did not realize that while adding depends-on | 03:24 |
| melwitt | heh sorry. I led you astray | 03:24 |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-requirements | 04:33 | |
| *** vishalmanchanda has joined #openstack-requirements | 04:55 | |
| *** udesale has joined #openstack-requirements | 05:25 | |
| *** ccamacho has joined #openstack-requirements | 05:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/728367 | 06:16 |
| openstackgerrit | Merged openstack/requirements master: roll back openstackdocstheme to 2.0.2 for pdf build issues https://review.opendev.org/728335 | 06:33 |
| openstackgerrit | Merged openstack/requirements master: Updated from generate-constraints https://review.opendev.org/725767 | 06:33 |
| openstackgerrit | Andreas Jaeger proposed openstack/requirements master: Blacklist openstackdocstheme 2.1.1 https://review.opendev.org/728373 | 07:03 |
| *** rpittau|afk is now known as rpittau | 07:12 | |
| *** tosky has joined #openstack-requirements | 07:35 | |
| *** e0ne has joined #openstack-requirements | 07:57 | |
| *** e0ne has quit IRC | 08:00 | |
| *** dtantsur|afk is now known as dtantsur | 08:17 | |
| *** e0ne has joined #openstack-requirements | 08:37 | |
| *** brinzhang_ has quit IRC | 09:24 | |
| *** brinzhang has joined #openstack-requirements | 09:30 | |
| *** brinzhang has quit IRC | 09:47 | |
| *** rpittau is now known as rpittau|bbl | 10:09 | |
| *** rpittau|bbl is now known as rpittau | 12:06 | |
| *** udesale_ has joined #openstack-requirements | 12:10 | |
| *** udesale has quit IRC | 12:13 | |
| *** panda|out is now known as panda | 12:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for openstackdocstheme to new release 2.1.2 https://review.opendev.org/728432 | 12:33 |
| *** e0ne has quit IRC | 13:40 | |
| *** e0ne has joined #openstack-requirements | 13:44 | |
| gmann | prometheanfire: smcginnis is it a good idea to keep hacking which is blacklist req in lower_constarints file? requirement check job cannot verify that constraint with what being updated manually in test-requirements file by projects, it is easy to go out of date. I think we should remove this blacklist req (including others like flake8 etc) from the lower-constraint file too as we do in upper-constraint. | 13:57 |
| gmann | https://github.com/openstack/nova/blob/575a91ff5be79ac35aef4b61d84c78c693693304/lower-constraints.txt#L36 | 13:57 |
| gmann | I think we should remove them and let test-requirement file handle lower as well as upper capping for that, what you suggest ? | 13:57 |
| smcginnis | Yeah, probably fine just removing that from lower-constraints since that's a blacklisted thing. | 14:24 |
| smcginnis | So good to just go off of requirements.txt. | 14:25 |
| *** bnemec is now known as beekneemech | 14:27 | |
| gmann | ok, thanks | 14:48 |
| *** udesale_ has quit IRC | 15:10 | |
| *** AJaeger has joined #openstack-requirements | 16:11 | |
| AJaeger | prometheanfire: openstackdocstheme 2.1.2 should be fine, the previous failing repos are passing docs again. so, I changed my -1 WIP to +1 on https://review.opendev.org/#/c/728432 | 16:12 |
| prometheanfire | nice | 16:12 |
| prometheanfire | smcginnis: mind reviewing ^ and https://review.opendev.org/728373 | 16:13 |
| smcginnis | Nice | 16:20 |
| *** kberger_ has joined #openstack-requirements | 16:31 | |
| *** KeithMnemonic has quit IRC | 16:31 | |
| *** kberger_ has quit IRC | 16:32 | |
| *** kberger_ has joined #openstack-requirements | 16:32 | |
| *** evrardjp has quit IRC | 16:33 | |
| *** evrardjp has joined #openstack-requirements | 16:33 | |
| smcginnis | prometheanfire: Assuming this will settle some things a bit, want to try to get that py2 patch ready? | 16:43 |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** rpittau is now known as rpittau|afk | 17:11 | |
| AJaeger | anybody an idea why the lower-constraints job fails on https://review.opendev.org/#/c/728272/ ? | 17:28 |
| AJaeger | "error in setup command: Error parsing /home/zuul/src/opendev.org/openstack/cinder/setup.cfg: ModuleNotFoundError: No module named 'certifi'" - see https://zuul.opendev.org/t/openstack/build/263c5b000c8e4bf0bed77b59d7653cd7 . help welcome, please | 17:29 |
| AJaeger | smcginnis, stephenfin, I see reno in the backtrace there, any idea? | 17:32 |
| prometheanfire | smcginnis: ya | 17:39 |
| smcginnis | AJaeger: Hmm, since that's lower-constraints, I wonder if that needs to be raised to a version while dulwich has dropped certifi. Or something like that, I don't know if that's actually the case. | 17:55 |
| AJaeger | smcginnis: yeah, so I removed now reno etc from lower-constriants as they are not needed. Let's see whether that helps... | 17:57 |
| AJaeger | thanks | 17:58 |
| smcginnis | Running locally too. | 17:58 |
| smcginnis | Testing, but we may need https://review.opendev.org/#/c/725370/ to land to get that openstackdocstheme update to work. | 18:00 |
| smcginnis | At least, I need some of that to get things to pass on my fedora machine. | 18:00 |
| AJaeger | smcginnis: Ah! good to know, thanks | 18:00 |
| smcginnis | And now that is failing for me too with an invalid syntax error in oslo.db. | 18:03 |
| AJaeger | Argh ;( | 18:04 |
| smcginnis | Weird that would fail. Lower constraints should be fairly static. | 18:04 |
| AJaeger | should ;( | 18:05 |
| *** iurygregory has quit IRC | 18:35 | |
| *** iurygregory has joined #openstack-requirements | 18:38 | |
| *** iurygregory has quit IRC | 18:45 | |
| *** kberger_ has quit IRC | 19:48 | |
| *** KeithMnemonic has joined #openstack-requirements | 19:48 | |
| *** e0ne has quit IRC | 20:42 | |
| *** iurygregory has joined #openstack-requirements | 20:42 | |
| *** ccamacho has quit IRC | 20:45 | |
| *** KeithMnemonic has quit IRC | 21:47 | |
| openstackgerrit | Merged openstack/requirements master: update constraint for openstackdocstheme to new release 2.1.2 https://review.opendev.org/728432 | 23:07 |
| openstackgerrit | Matthew Thode proposed openstack/requirements master: update requirements and constraints for py3 only Victoria https://review.opendev.org/720264 | 23:24 |
| prometheanfire | smcginnis: ^ see also: https://review.opendev.org/728591 | 23:38 |
| *** tosky has quit IRC | 23:39 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!