| opendevreview | Brian Rosmaita proposed openstack/releases master: Cinder stable branch releases for CVE-2022-47951 https://review.opendev.org/c/openstack/releases/+/871656 | 03:38 |
|---|---|---|
| *** blarnath is now known as d34dh0r53 | 07:01 | |
| *** dviroel_ is now known as dviroel | 11:21 | |
| *** amoralej is now known as amoralej|lunch | 11:58 | |
| *** amoralej|lunch is now known as amoralej | 13:26 | |
| opendevreview | Merged openstack/releases master: Release adjutant for stable/xena https://review.opendev.org/c/openstack/releases/+/870553 | 15:25 |
| *** dviroel is now known as dviroel|lunch | 16:08 | |
| opendevreview | Jon Bernard proposed openstack/releases master: Cinder stable branch releases for CVE-2022-47951 https://review.opendev.org/c/openstack/releases/+/871656 | 16:13 |
| rpittau | hello everyone, calling for help on the releasenotes job, we're seeing a weird error stating ValueError: Unknown reference 'stable/8.4' on master, here's the link to the job logs https://zuul.opendev.org/t/openstack/build/7cba54db7e634272b9688157361a1d6a | 16:22 |
| rpittau | any help would be greatly appreciated | 16:22 |
| ttx | weird, looking | 16:40 |
| *** gthiemon1e is now known as gthiemonge | 16:40 | |
| ttx | job has started failing between Jan 11 and Jan 17 | 16:41 |
| ttx | https://zuul.opendev.org/t/openstack/builds?job_name=build-openstack-releasenotes&project=openstack/ironic-python-agent | 16:41 |
| *** marios is now known as marios|out | 16:43 | |
| clarkb | JayF did cleanup of the fix branches recently. Could that be related? | 16:43 |
| JayF | stable/8.4 has never been a valid branch name for Ironic | 16:44 |
| rpittau | that's what I was going to say :) | 16:44 |
| JayF | let me get done with TC meeting and I'll look | 16:44 |
| ttx | yeah unclear where it picked up that ref | 16:45 |
| JayF | https://etherpad.opendev.org/p/IronicBugfixBranchCleanup I'll note we *did* cleanup ironic-python-agent bugfix/8.4 | 16:50 |
| JayF | and that happened on ... | 16:50 |
| JayF | IPA COMPLETED 1/11/23 UTC 2100 | 16:50 |
| JayF | aw no | 16:50 |
| JayF | hmm. I wonder if it's parsing tags | 16:51 |
| JayF | and the bugfix-8.4-eol is confusing it | 16:51 |
| ttx | there have been other such fails (see history above) and part of the solution seems to have been to remove the job https://review.opendev.org/c/openstack/ironic-python-agent/+/868065/3..4/zuul.d/project.yaml#b7 | 16:56 |
| ttx | or should I say "solution" | 16:57 |
| JayF | Does it make sense for bugfix branches to even run a releasenotes job? | 16:57 |
| JayF | What is the actual published artifact from that? | 16:57 |
| ttx | the error rpittau raised was on master | 16:57 |
| ttx | but it happened on bugfix/8.6 before | 16:58 |
| JayF | yeah; I think it may just be that it doesn't make sense to run it on a bugfix branch but in any event, we should fix this | 16:59 |
| rpittau | JayF: I'm slowly removing the job from bugfix branches | 16:59 |
| ttx | there is a bit of black magic with that reference | 16:59 |
| ttx | probably something reno pulls off the git tree | 17:00 |
| JayF | yep, this is totally the new tags breaking it | 17:00 |
| JayF | in reno | 17:00 |
| JayF | it's locally reproducable, too | 17:01 |
| JayF | so there's really no way out of this other than fixing reno | 17:01 |
| JayF | and this issue will occur/is occurring on other Ironic projects that have had bugfix branches retired | 17:01 |
| JayF | which would be IPA (example here), Ironic, and Ironic-Inspector | 17:01 |
| JayF | I suspect the best fix will be to have it not evaluate any tags that start with `bugfix-` | 17:02 |
| ttx | yeah reno is looking for -eol things for branches that have been removed | 17:02 |
| JayF | at least it reproduces locally so it should be fixible | 17:03 |
| JayF | here's my other question: what is the urgency on this | 17:03 |
| JayF | like, is something actively broken? or just release notes for changes to master on those projects won't get updated until it's fixed | 17:03 |
| rpittau | JayF: it breaks our CI on mater | 17:03 |
| rpittau | master* | 17:03 |
| JayF | oooh, check jobs are broken | 17:03 |
| JayF | I see | 17:03 |
| JayF | that is unfortunate | 17:04 |
| JayF | rpittau: I'll take this one, unless you want it, I have a fairly clear day | 17:04 |
| JayF | who are the cores on reno? Might wanna make sure they're onboard with whatever I cook up | 17:04 |
| ttx | At this point that would be the release team, but you probably know as much of reno as we do. But we can approve fixes alright | 17:05 |
| rpittau | JayF: I'm almost done for the day, closing in 5 minutes, please take it, and thanks! | 17:05 |
| ttx | JayF: the issue seems to be around "stable/8.4" so I'm not sure making it ignore bugfix/* will help? | 17:06 |
| JayF | ttx: that branch has never existed in Ironic. My current hypothesis is that it sees `bugfix-8.4-eol` and somehow is thinking that means a stable/8.4 does or did exist | 17:07 |
| JayF | s/Ironic/IPA/ | 17:07 |
| JayF | ooh, this might be configurable | 17:09 |
| ttx | that would be.. great | 17:09 |
| ttx | Have to drop for a meeting in 5.. keep us posted on progress! | 17:11 |
| *** dviroel|lunch is now known as dviroel | 17:14 | |
| JayF | I suspect if I can make closed_branch_tag_re exclude bugfix branches, we'll be in good shape | 17:16 |
| JayF | that worked in terms of making it pass; but I'm concerned it's breaking the output | 17:32 |
| *** amoralej is now known as amoralej|off | 17:38 | |
| opendevreview | Ghanshyam proposed openstack/releases master: [tempest] Tag wallaby-last https://review.opendev.org/c/openstack/releases/+/871746 | 17:39 |
| opendevreview | Ghanshyam proposed openstack/releases master: [tempest] Tag wallaby-last https://review.opendev.org/c/openstack/releases/+/871746 | 17:39 |
| JayF | yeah, that is absolutely breaking the output | 17:44 |
| JayF | causing a lot of [openstackdocstheme] could not determine last_updated for X and unable to find release notes file associated with unique id X, skipping | 17:45 |
| JayF | so I think I have to make reno aware of bugfix branches; I can't just exclude them | 17:45 |
| opendevreview | Elod Illes proposed openstack/releases master: EOL branch delete script speed up https://review.opendev.org/c/openstack/releases/+/871512 | 19:47 |
| opendevreview | Elod Illes proposed openstack/releases master: Allow delete branch if eol tag is not at HEAD https://review.opendev.org/c/openstack/releases/+/871514 | 19:47 |
| JayF | OK; so the bad log messages from reno I was getting after changing that | 20:52 |
| JayF | appear in the last good log: https://zuul.opendev.org/t/openstack/build/0c429885075f47109a83fd820bb54a8a/log/job-output.txt | 20:52 |
| JayF | so I think my re change might be all we need, and I can configure that on repo side | 20:52 |
| *** dviroel is now known as dviroel|out | 20:52 | |
| JayF | dhellmann: looking at https://github.com/openstack/reno/commit/b9cf9a7371eec7f20089f51bbd12e78963a10960 -- I have a case where I need to set closed_branch_tag_re in config; but AFAICT it may not be hooked up (looking at https://github.com/openstack/reno/blob/master/reno/sphinxext.py#L38 ) | 21:04 |
| JayF | Do you have any guidance? Is my understanding accurate? | 21:04 |
| JayF | hberaud: ^ perhaps, you might know? You have most recent commits on reno and IDK who else to ask | 21:10 |
| JayF | but I know adding to the opt list in sphinxext.py did not make it pick up the config opt | 21:10 |
| JayF | oooh! Docs, I should've read the dang docs | 21:11 |
| JayF | I have fixes in now, thank you ttx and rpittau for the help; https://review.opendev.org/c/openstack/ironic-python-agent/+/871786 + https://review.opendev.org/c/openstack/ironic/+/871787 + https://review.opendev.org/c/openstack/ironic-inspector/+/871788 | 21:27 |
| opendevreview | Ghanshyam proposed openstack/releases master: [octavia-tempest-plugin] Tag wallaby-last https://review.opendev.org/c/openstack/releases/+/868585 | 21:36 |
| opendevreview | Ghanshyam proposed openstack/releases master: [trove-tempest-plugin] Tag wallaby-last https://review.opendev.org/c/openstack/releases/+/868544 | 21:38 |
| opendevreview | Ghanshyam proposed openstack/releases master: [freezer-tempest-plugin] Tag wallaby-last https://review.opendev.org/c/openstack/releases/+/868588 | 21:39 |
| gmann | elodilles: As you might know, stable/wallaby is broken as it run tempest master. To fix that, I am pinning tempest and plugins compatible version to stable/wallaby and need these open releases patches to merge https://review.opendev.org/q/topic:wallaby-last+status:open | 21:40 |
| dhellmann | JayF : so, you have what you need? | 21:43 |
| JayF | dhellmann: yeah; didn't realize there were two config mechanisms for reno | 21:43 |
| dhellmann | the more the merrier, right? | 21:44 |
| JayF | dhellmann: you get a 5-year-late thank you for making that all configurable | 21:44 |
| JayF | lol | 21:44 |
| dhellmann | haha | 21:44 |
| * dhellmann sets a reminder to say thank you in 5 years | 21:44 | |
| opendevreview | Tobias Urdin proposed openstack/releases master: [xena][yoga][zed] Nova stable branch releases for CVE-2022-47951 https://review.opendev.org/c/openstack/releases/+/871802 | 22:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!