Friday, 2022-11-11

*** amoralej|off is now known as amoralej07:40
*** dviroel|afk is now known as dviroel11:43
opendevreviewDmitriy Rabotyagov proposed openstack/releases master: Last release of OSA Wallaby  https://review.opendev.org/c/openstack/releases/+/86426211:57
*** dviroel is now known as dviroel|doc_appt12:45
fungielodilles: regarding 864261, do you have any more detail on why the release announcement jobs need to install projects' bindep lists? what "garbage content" arises in them if you don't?12:50
elodillesfungi: there was a comment in the code that when building sdist some deliverables installs extra packages and that installation output would end up in the mail. let me search for the exact comment13:04
fungimainly wondering why the job would need to install the deliverable at all13:04
fungiis it for generating the release notes?13:07
funginevermind, the announcements don't include release notes, those are git logs13:07
fungiyeah, just looking at a few of the announcements, i don't see anything in there which should need the package installed to generate. that's all coming from other sources of data, right?13:08
fungithat's the main reason i'm asking, it seems like the release announcements job could be fixed by making it just not do unnecessary steps13:15
fungiahh, okay some of them do generate and include release notes. so the question becomes, should we have to install a project in order to generate its release notes?13:21
fungiand the answer is a definite "no"13:23
fungii have a completely separate reno install on my workstation, and can run `reno report` in the git repo of any project and get release notes generated that way, without installing the project at all13:23
fungiso i doubt the installation is for supporting release notes inclusion13:24
fungii see announce.sh runs `python setup.py --name` and `python setup.py --description` in the project... that doesn't require installation but we should replace that mechanism with something else anyway since setuptools has deprecated directly calling setup.py on the command line13:34
elodillesfungi: sorry, i was distracted with a downstream meeting :S so here is the comment: https://opendev.org/openstack/releases/src/branch/master/tools/announce.sh#L172-L17513:40
elodillesbut as i see you found the same code part13:42
*** amoralej is now known as amoralej|lunch13:47
elodillesi agree by the way: if the installation can be avoided then let's avoid it13:47
fungilooks like we could just remove https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/playbooks/release/pre.yaml#L3-L513:48
fungiat least my rudimentary local tests confirm that calling setup.py --name/--description doesn't install anything. but if we find places where it does try to, then we should probably look for a different solution than calling setup.py anyway13:49
elodillesbut in that case (according to the comment I linked) we should refactor the name and description retrieval from setup.py13:50
elodillesyepp13:51
elodillesso you suggest to drop the 'announce-release' job duplication patch i did and simply remove the bindep install part? I can accept that if it really works13:52
fungiand yeah, going through the entire log of an announcement i find no evidence the project being released is ever actually installed13:55
fungielodilles: yes, looking at the git history for that job, we were installing the project's bindep list when we first migrated it from zuul v2 job definitions, so it's quite likely that's just unnecessary cruft13:56
elodillesfungi: ack, then i'll create the patch in a minute :)13:56
elodillesbut let's start the meeting now!14:00
elodilles#startmeeting releaseteam14:00
opendevmeetMeeting started Fri Nov 11 14:00:30 2022 UTC and is due to finish in 60 minutes.  The chair is elodilles. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'releaseteam'14:00
elodillesPing list: hberaud armstrong elodilles14:00
elodilles#link https://etherpad.opendev.org/p/antelope-relmgt-tracking14:00
ttxo/14:01
elodilleso/14:01
elodilleswe are at line 7914:01
elodilleshberaud is on PTO, just as a reminder14:03
elodillesso let's start14:03
elodilles#topic Review task completion14:04
elodillesthe 1st 2 tasks are related to Wallaby's Extended Maintenance transition14:04
elodillesalmost every project have transitioned, i think ironic and swift patches can be merged (no PTL-approved though)14:05
ttxiirc there was a few leftovers yes14:05
elodilleshttps://review.opendev.org/q/topic:wallaby-em+is:open14:06
elodillespuppet openstack + openstack ansible want usually to transition last14:06
ttxhow aggressively do we need to process the leftovers?14:07
ttxCan we wait a bit more?14:07
elodillesthe final release for OSA is propsed, so that can be hopefully updated and merged14:07
elodillesttx: we don't need to aggressively push those, so we can wait14:08
ttxok14:08
ttxlet's place a remnidner in the following weeks to reassess?14:08
elodillesttx: em transition is not that strict but it is better not to postpone it too long14:08
elodillesttx: that's OK for me14:09
ttxlike in two weeks maybe14:09
ttxhmm skipped meeting, make that 3 weeks14:09
elodillesi'm optimistic and think that we can close the transition next week, anyway :)14:09
ttxadded14:10
elodilles(if the puppet openstack patch is sorted out... fingers crossed...)14:10
elodillesttx: thanks :)14:10
elodillesso let's move on to the next task:14:11
elodilles#info Review cycle-trailing projects to check which haven’t released yet (hberaud)14:11
elodillesmail was sent:14:11
elodilleshttps://lists.openstack.org/pipermail/openstack-discuss/2022-November/031095.html14:11
elodilleshberaud is not here, but anything to add here?14:12
ttxnono14:14
elodillesdouble negation? is that a yes? :)14:14
ttxnono14:14
elodillesanyway, move on :)14:14
elodilles#info move the announce job to focal for series older than antelope and keep jammy on master (elod)14:14
elodillesnow we have 3 solution for this :)14:15
elodilleshberaud started to clean up the old bindeps:14:15
elodilleshttps://review.opendev.org/q/topic:drop-python-dev-from-bindep14:15
elodillesi've created the patch we agreed last meeting:14:15
elodilleshttps://review.opendev.org/c/openstack/openstack-zuul-jobs/+/86426114:16
elodillesand fungi suggested an even better fix: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/86426714:16
fungii don't think the split job proposed in 864261 would have worked anyway. that job is triggered in the release pipeline for the project with the tag, but you're trying to filter on deliverables directories from the releases repo instead14:16
elodillesto simply remove the bindep installation14:16
elodillesfungi: oh, i see. then definitely the latter fix is the better14:17
fungiif you want to run different tag-triggered jobs on different platforms per branch, you need some way of guessing the branch associated with the tag14:17
fungiwhich is nontrivial14:18
elodillesi see14:18
*** amoralej|lunch is now known as amoralej14:19
elodillesfungi: i'll update the bindep removal patch based on your comment and then we are good to go14:19
elodilles* bindep task removal patch...14:19
fungiwell, then we're ready to do a release-test release and make sure my supposition isn't incorrect14:19
elodillesfungi: good idea, i'll do a release-test release14:20
elodillesanyhow, i think we are on track with this14:21
elodillesand this was the last task for the week14:21
elodillescan we move on to the next topic?14:22
fungiseems like it14:22
elodilles#topic Assign next week tasks14:23
elodilleshberaud already added his name for some tasks14:23
elodillesand all taken as i see14:24
elodillesthanks!14:24
elodilles#topic Review countdown email14:24
elodilleshttps://etherpad.opendev.org/p/relmgmt-weekly-emails14:24
elodillesplease review ^^^14:24
*** blarnath is now known as d34dh0r5314:26
ttxadded final release date so that Antelope-1 is not too lonely14:26
elodilles++14:27
ttxotherwise lgtm14:27
elodillescool, thanks!14:27
elodilles#topic Open Discussion14:27
elodillesanything to raise?14:27
ttxnothing here14:28
elodillesneither here14:29
elodillesso let's cut this meeting short then14:29
funginothing from me14:29
elodillesthanks for participating && next meetings chair will be hberaud14:30
elodillesas he volunteered last week :)14:30
elodilles#endmeeting14:30
opendevmeetMeeting ended Fri Nov 11 14:30:42 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:30
opendevmeetMinutes:        https://meetings.opendev.org/meetings/releaseteam/2022/releaseteam.2022-11-11-14.00.html14:30
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/releaseteam/2022/releaseteam.2022-11-11-14.00.txt14:30
opendevmeetLog:            https://meetings.opendev.org/meetings/releaseteam/2022/releaseteam.2022-11-11-14.00.log.html14:30
*** dviroel|doc_appt is now known as dviroel14:49
*** dviroel is now known as dviroel\LUNCH15:12
*** dviroel\LUNCH is now known as dviroel|lunch15:12
fungielodilles: the bindep removal worked, if you want to test15:25
fungier, s/worked/merged/15:25
opendevreviewElod Illes proposed openstack/releases master: release-test test release  https://review.opendev.org/c/openstack/releases/+/86429515:37
elodillesfungi: ack, let's see ^^^15:38
*** dviroel|lunch is now known as dviroel16:08
*** marios is now known as marios|out16:15
elodillesoh, rsync: connection unexpectedly closed :S let's recheck16:44
opendevreviewMerged openstack/releases master: release-test test release  https://review.opendev.org/c/openstack/releases/+/86429516:58
*** amoralej is now known as amoralej|off17:21
elodillesthe announce job succeeded: https://zuul.opendev.org/t/openstack/build/9ecded74d74b4134ac74652ea97ad4bb17:46
elodilles(though there were no reno generated as there were no entry for the release...)17:47
opendevreviewMerged openstack/releases master: [nova] Proposing EOL of Queens, Rocky and Stein  https://review.opendev.org/c/openstack/releases/+/86252018:01
elodillesso this seems to be OK, but maybe we should not approve only 1 release at a time, as soon as there will be a 'real' release patch, to check that the announce works well18:05
fungiyeah, makes sense18:07
fungiat least we can see it's not thoroughly broken anyway18:07
elodilles(...we *should* approve only 1 release patch at a time... to add some sense to my sentence :P)18:17
opendevreviewCarlos Eduardo proposed openstack/releases master: [manila][zed] Add project tracking schedule  https://review.opendev.org/c/openstack/releases/+/86431321:20

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!