| *** tkajinam is now known as Guest3966 | 00:09 | |
| *** tkajinam is now known as Guest3972 | 01:47 | |
| *** marios is now known as marios|ruck | 05:26 | |
| *** tkajinam is now known as Guest3986 | 05:43 | |
| *** tkajinam is now known as Guest3988 | 06:53 | |
| *** amoralej|off is now known as amoralej | 07:13 | |
| jpodivin | Hi. I'm having bit of a quandary on my hands and I need an advice. validations-libs has fallen behind on releasing upstream changes. Normally we would just cut a new version, but the difference is substantial enough that I wonder if it wouldn't be better to release several micros at once. | 07:57 |
|---|---|---|
| jpodivin | alternatively several in sequence ... but shortly after one another. | 07:57 |
| jpodivin | Bundling it together in one could still work. afaik there is nothing really problematic there. | 07:58 |
| jpodivin | but it's a big jump | 07:58 |
| elodilles | i think several in sequence could work, no problem at all | 08:02 |
| jpodivin | elodilles: ok, we'll go with that | 08:05 |
| jpodivin | thanks elodilles | 08:05 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.2 https://review.opendev.org/c/openstack/releases/+/862672 | 08:09 |
| elodilles | JayF: sushy-tools and virtualbmc releases look good to me, +2'd | 08:18 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.3 https://review.opendev.org/c/openstack/releases/+/862673 | 08:25 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.4 https://review.opendev.org/c/openstack/releases/+/862674 | 08:25 |
| elodilles | jpodivin: there is a version bump problem with the 1st release patch o:) see my comment on the patch | 08:52 |
| elodilles | jpodivin: oh, one more thing, i think the hashes are wrong as well. you should choose hashes always from the main branch (when a patch is merged with a 'Merge from' patch and the chosen hash is from that side-branch then it shows it's wrong) | 09:09 |
| jpodivin | elodilles: I'm getting the hashes from master log ... not sure how they could be wrong. | 09:14 |
| jpodivin | Patch is in the master. https://opendev.org/openstack/validations-libs/commit/8a69f95e0acf4b3acdff00b2094d476fa463bc81 | 09:17 |
| elodilles | for example a patch 'Title something' has a 'Merge "Title something"', then it shows that 'Title something is not the direct patch on master branch | 09:17 |
| elodilles | that means 'Merge "Title something"' was the point where "Title something" patch became part of master branch. | 09:19 |
| jpodivin | elodilles: I kind of assumed that if something is in the branch, it's in the branch. Like if I were to revert the merge commit the code wouldn't really change. | 09:20 |
| jpodivin | it seems odd that would be duplicated in the history | 09:21 |
| jpodivin | if there joined with merge that is. | 09:24 |
| jpodivin | ... reading up on the merge algo it makes sense now. https://git-scm.com/docs/git-merge#_true_merge | 09:27 |
| opendevreview | Merged openstack/releases master: Release for VirtualBMC https://review.opendev.org/c/openstack/releases/+/862642 | 09:29 |
| opendevreview | Merged openstack/releases master: Release for sushy-tools https://review.opendev.org/c/openstack/releases/+/862641 | 09:29 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.2 https://review.opendev.org/c/openstack/releases/+/862672 | 09:30 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.3 https://review.opendev.org/c/openstack/releases/+/862673 | 09:50 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.4 https://review.opendev.org/c/openstack/releases/+/862674 | 09:50 |
| elodilles | jpodivin: a 1 is missing from the end of the hash (on the 1st patch) o:) and also, my previous comments are still valid o:) | 10:02 |
| opendevreview | Jiri Podivin proposed openstack/releases master: Releasing validations-libs 1.7.2 https://review.opendev.org/c/openstack/releases/+/862672 | 10:04 |
| jpodivin | we can't really release a major version because of dependency change though. Major releases are for backwards incompatible changes. Afaik we are still backwards compatible with previous releases | 10:07 |
| elodilles | py36 & py37 support is dropped. that kind of backward incompatible change | 10:07 |
| elodilles | pypi won't list the new release for py36 versions | 10:08 |
| jpodivin | Hypothetically you can still run code on them, it's just not something we support. | 10:08 |
| jpodivin | why wouldn't it? | 10:08 |
| jpodivin | you mean because of the selectors? I guess that would be the case. | 10:10 |
| jpodivin | in any case semver does provide some leeway https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api | 10:12 |
| elodilles | for the record every deliverables that dropped the support of py36 & py37 bumped MAJOR version | 10:33 |
| *** amoralej is now known as amoralej|lunch | 10:55 | |
| jpodivin | elodilles: I guess we can't really break the common practice ... Ok, patches abandoned | 11:14 |
| *** dviroel|afk is now known as dviroel | 11:28 | |
| opendevreview | Merged openstack/releases master: [vitrage] Transition Wallaby to EM https://review.opendev.org/c/openstack/releases/+/862343 | 12:22 |
| *** amoralej|lunch is now known as amoralej | 12:31 | |
| opendevreview | Merged openstack/releases master: [murano] Transition Wallaby to EM https://review.opendev.org/c/openstack/releases/+/862332 | 12:31 |
| elodilles | hberaud ttx : it seems we have a release job failure: announce-release https://zuul.opendev.org/t/openstack/build/a970b3bf9bdc449f87e92ba7f77af60a : RETRY_LIMIT in 2m 07s | 12:59 |
| elodilles | the cause is the job try to install the bindeps | 12:59 |
| elodilles | and python-dev is a py2 package | 12:59 |
| elodilles | which is not in ubuntu-jammy | 12:59 |
| elodilles | * not available | 12:59 |
| elodilles | i guess announce-release uses the default nodeset, which was probably changed to jammy recently | 13:00 |
| elodilles | (i see only ubuntu-focal until some days ago) | 13:01 |
| elodilles | this is probably a relevant issue and can cause failed jobs in the future | 13:02 |
| elodilles | what is weird for me that why we need the bindep (of the released deliverable!) for the announce | 13:03 |
| hberaud | I see | 13:36 |
| frickler | the nodeset for the base job was switched to jammy yesterday, yes | 13:37 |
| hberaud | We faced something similar on oslo with another packages (qpid) on jammy | 13:37 |
| elodilles | frickler: ack, thanks for the info | 13:52 |
| elodilles | i'm trying to figure out why we need to install binary dependencies for the released deliverable | 13:54 |
| elodilles | anyway, maybe it is enough if projects fixes their bindep.txt to work with jammy | 13:54 |
| frickler | might be to extract name and description https://opendev.org/openstack/releases/src/branch/master/tools/announce.sh#L176-L179 | 14:00 |
| frickler | that might also need to be switched to invoke python3 instead of python on jammy | 14:01 |
| elodilles | frickler: yepp, probably that is the reason. i haven't found anything else beyond that either | 14:17 |
| elodilles | 'python' seems to be working | 14:18 |
| elodilles | (at least the announce-release job passed for sushy-tools: https://zuul.opendev.org/t/openstack/build/9b9aa6419d6341179120770cc3414070 ) | 14:19 |
| frickler | elodilles: ah, the script activates a venv, that has python in the path then, fine | 14:21 |
| elodilles | oh, cool, so that's the trick | 14:23 |
| *** dviroel is now known as dviroel|lunch | 15:08 | |
| opendevreview | Merged openstack/releases master: [solum] Transition Wallaby to EM https://review.opendev.org/c/openstack/releases/+/862337 | 15:25 |
| *** marios|ruck is now known as marios|out | 15:33 | |
| opendevreview | Merged openstack/releases master: [zaqar] Transition Wallaby to EM https://review.opendev.org/c/openstack/releases/+/862303 | 15:35 |
| *** dviroel|lunch is now known as dviroel | 16:26 | |
| *** amoralej is now known as amoralej|off | 16:43 | |
| *** dviroel is now known as dviroel|afk | 20:03 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!