Tuesday, 2017-08-22

*** thorst has quit IRC00:02
*** rajathagasthya has quit IRC00:16
*** yamamoto_ has joined #openstack-release00:18
*** yamamoto_ has quit IRC00:24
*** thorst has joined #openstack-release00:25
*** thorst has quit IRC00:26
*** zhurong has joined #openstack-release00:45
*** yamamoto_ has joined #openstack-release01:21
*** yamamoto_ has quit IRC01:26
*** thorst has joined #openstack-release01:26
*** thorst has quit IRC01:31
*** bobh has quit IRC01:32
*** hongbin has joined #openstack-release01:34
*** gcb has joined #openstack-release01:36
*** huats has quit IRC01:49
*** huats has joined #openstack-release01:50
*** thorst has joined #openstack-release01:51
*** thorst has quit IRC01:51
*** iyamahat has quit IRC02:03
*** liujiong has joined #openstack-release02:08
*** yamahata has quit IRC02:10
*** gcb has quit IRC02:12
*** gcb has joined #openstack-release02:15
*** yamamoto_ has joined #openstack-release02:22
*** yamamoto_ has quit IRC02:28
*** ekcs has quit IRC02:30
*** tellesnobrega has joined #openstack-release02:31
*** rosmaita has quit IRC02:39
*** hongbin has quit IRC02:48
*** thorst has joined #openstack-release02:52
*** hongbin has joined #openstack-release02:54
*** yamamoto has joined #openstack-release02:56
*** thorst has quit IRC02:57
*** yamamoto has quit IRC03:02
*** iyamahat has joined #openstack-release03:17
*** dave-mccowan has quit IRC03:40
*** udesale has joined #openstack-release03:42
ricolin_Hi is there any release core awake?:)03:45
*** thorst has joined #openstack-release03:53
*** hongbin has quit IRC03:56
*** hongbin has joined #openstack-release03:58
*** thorst has quit IRC03:59
*** yamamoto has joined #openstack-release04:03
*** hongbin has quit IRC04:04
*** yamamoto has quit IRC04:09
*** thorst has joined #openstack-release04:54
*** thorst has quit IRC04:58
*** ekcs has joined #openstack-release05:04
*** yamamoto has joined #openstack-release05:05
*** yamamoto has quit IRC05:10
*** ekcs has quit IRC05:11
*** gcb has quit IRC05:21
*** gcb has joined #openstack-release05:23
*** claudiub has joined #openstack-release05:27
*** ricolin_ has quit IRC05:31
*** ricolin has joined #openstack-release05:31
*** edmondsw has joined #openstack-release05:42
*** edmondsw has quit IRC05:47
*** thorst has joined #openstack-release05:55
*** thorst has quit IRC05:59
*** yamamoto has joined #openstack-release06:06
*** yamamoto has quit IRC06:12
*** shardy has joined #openstack-release06:27
*** yamahata has joined #openstack-release06:32
*** armax has quit IRC06:39
*** pcaruana has joined #openstack-release06:45
*** coolsvap has joined #openstack-release06:55
*** thorst has joined #openstack-release06:56
*** thorst has quit IRC07:00
*** csomerville has joined #openstack-release07:05
*** cody-somerville has quit IRC07:05
openstackgerritSpyros Trigazis (strigazi) proposed openstack/releases master: Release magnum-ui 3.0.0  https://review.openstack.org/49591807:08
*** tmorin has joined #openstack-release07:10
*** iyamahat has quit IRC07:18
*** jtomasek has joined #openstack-release07:18
*** amoralej|off is now known as amoralej07:29
*** edmondsw has joined #openstack-release07:30
*** yamahata has quit IRC07:31
*** jpich has joined #openstack-release07:34
*** edmondsw has quit IRC07:35
-openstackstatus- NOTICE: Gerrit is going to be restarted due to slow performance07:37
-openstackstatus- NOTICE: Gerrit has been restarted successfully07:41
*** iyamahat has joined #openstack-release07:54
*** thorst has joined #openstack-release07:57
*** thorst has quit IRC08:01
*** pbandark has joined #openstack-release08:07
*** alexchadin has joined #openstack-release08:09
*** liujiong_lj has joined #openstack-release08:13
*** liujiong has quit IRC08:14
*** iyamahat has quit IRC08:25
*** shardy has quit IRC08:25
*** liujiong has joined #openstack-release08:25
*** liujiong_lj has quit IRC08:26
*** liujiong_lj has joined #openstack-release08:28
*** liujiong has quit IRC08:30
*** yamamoto has joined #openstack-release08:35
*** dtantsur|afk is now known as dtantsur08:36
*** thorst has joined #openstack-release08:57
*** yamamoto has quit IRC08:59
*** yamamoto has joined #openstack-release08:59
*** yamamoto has quit IRC08:59
*** thorst has quit IRC09:02
*** electrofelix has joined #openstack-release09:03
*** shardy has joined #openstack-release09:18
*** liujiong_lj has quit IRC09:27
*** liujiong has joined #openstack-release09:31
*** csomerville has quit IRC09:50
*** thorst has joined #openstack-release09:58
*** yamamoto has joined #openstack-release10:00
*** thorst has quit IRC10:03
*** yamamoto has quit IRC10:05
*** alexchadin has quit IRC10:05
*** alexchadin has joined #openstack-release10:07
*** alexchadin has quit IRC10:10
*** alexchadin has joined #openstack-release10:11
*** alexchadin has quit IRC10:13
*** liujiong has quit IRC10:13
*** zhurong has quit IRC10:17
dimsricolin : pong10:29
*** yamamoto has joined #openstack-release10:30
ricolindims, Hi thanks for pong back, tonyb already provide me some very useful answers:)10:32
dimscool thx10:32
*** udesale has quit IRC10:36
*** dtantsur is now known as dtantsur|bbl10:40
*** shardy has quit IRC10:42
*** wolverineav has joined #openstack-release10:57
*** freerunner has quit IRC11:00
*** junbo has quit IRC11:01
*** Dinesh_Bhor has quit IRC11:01
*** stephenfin has quit IRC11:01
*** toabctl has quit IRC11:01
*** toabctl has joined #openstack-release11:04
*** vryzhenkin has joined #openstack-release11:04
*** Dinesh_Bhor has joined #openstack-release11:05
*** junbo has joined #openstack-release11:05
*** stephenfin has joined #openstack-release11:05
*** edmondsw has joined #openstack-release11:06
*** thorst has joined #openstack-release11:07
*** edmondsw has quit IRC11:10
*** thorst has quit IRC11:11
*** mburned has joined #openstack-release11:11
*** alexchadin has joined #openstack-release11:13
*** yamamoto has quit IRC11:18
*** yamamoto has joined #openstack-release11:30
openstackgerritSpyros Trigazis (strigazi) proposed openstack/releases master: Release magnum-ui 3.0.0  https://review.openstack.org/49591811:32
openstackgerritMerged openstack/releases master: New python-neutronclient stable releases  https://review.openstack.org/49598611:35
openstackgerritMerged openstack/releases master: ocata: release nova 15.0.7  https://review.openstack.org/49590311:35
*** edmondsw has joined #openstack-release11:45
*** yamamoto has quit IRC11:46
*** yamamoto has joined #openstack-release11:48
*** rosmaita has joined #openstack-release11:49
*** rosmaita has quit IRC11:50
*** rosmaita has joined #openstack-release11:51
*** tellesnobrega has quit IRC12:01
*** yamamoto has quit IRC12:03
*** rosmaita has quit IRC12:03
*** rosmaita has joined #openstack-release12:04
*** tmorin has left #openstack-release12:04
*** yamamoto has joined #openstack-release12:04
*** yamamoto has quit IRC12:10
*** thorst has joined #openstack-release12:11
*** yamamoto has joined #openstack-release12:12
*** amoralej is now known as amoralej|lunch12:14
dhellmanndims, smcginnis : o/12:20
openstackgerritMerged openstack/releases master: Release magnum-ui 3.0.0  https://review.openstack.org/49591812:21
dimsdhellmann : smcginnis : o/12:22
*** dave-mccowan has joined #openstack-release12:34
*** udesale has joined #openstack-release12:37
*** thorst is now known as thorst_afk12:49
smcginnisdims, dhellmann: o/12:49
*** tellesnobrega has joined #openstack-release12:49
*** alexchadin has quit IRC12:51
*** alexchadin has joined #openstack-release12:51
*** pkovar has joined #openstack-release12:53
*** zhurong has joined #openstack-release12:56
*** yamamoto has quit IRC13:12
*** yamamoto has joined #openstack-release13:14
*** yamamoto has quit IRC13:22
*** bobh has joined #openstack-release13:35
*** amoralej|lunch is now known as amoralej13:36
*** tellesnobrega has quit IRC13:40
*** shardy has joined #openstack-release13:49
*** pkovar has quit IRC13:53
*** tellesnobrega has joined #openstack-release13:53
*** alexchadin has quit IRC13:55
*** alexchadin has joined #openstack-release13:56
*** yamahata has joined #openstack-release13:56
*** hongbin has joined #openstack-release13:59
*** witek_ has joined #openstack-release13:59
*** witek has quit IRC13:59
*** iyamahat has joined #openstack-release14:07
*** armax has joined #openstack-release14:14
*** zhurong has quit IRC14:19
*** yamamoto has joined #openstack-release14:23
*** rosmaita has quit IRC14:24
otherwiseguydims, any word on library release timeframe for ovsdbapp? https://review.openstack.org/#/c/493235/14:25
smcginnisotherwiseguy: We are still trying to wrap up some final pike things. Once queens opens up we can get that through.14:26
otherwiseguysmcginnis, I have someone asking me every day for builds, so I just pass those on to you all. :D Got an updated estimate I can give them?14:27
*** yamamoto has quit IRC14:28
smcginnisotherwiseguy: I'm hoping within the next couple days.14:30
smcginnisdhellmann: We need to get those final trailing releases through first, right? ^T^14:30
dhellmannwe don't usually start doing releases for N+1 until after the final date for N14:31
dhellmannhttp://git.openstack.org/cgit/openstack/releases/tree/PROCESS.rst#n34314:32
*** rosmaita has joined #openstack-release14:32
otherwiseguydhellmann, the problem is libraries that are used by non-OS projects as well.14:32
otherwiseguyThe RHEV/oVirt folks are chomping at the bit.14:32
otherwiseguyOne reason I was pushing for an "independent" release cycle, but that got shot down.14:33
otherwiseguywhich I understand, it just has some trade offs.14:33
*** alexchadin has quit IRC14:34
dhellmannsmcginnis : how many stragglers are we waiting for?14:34
smcginnisdhellmann: There's still a few in the list from the R-1 missing: https://etherpad.openstack.org/p/pike-relmgt-tracking14:35
dhellmannhttp://paste.openstack.org/show/619048/14:35
smcginnisdhellmann: I hadn't used that one yet - nice!14:36
smcginnisdhellmann: I think at least the majority of them have been contacted.14:37
dhellmanntempest won't branch so we don't need to count that one14:37
dhellmannand none of those things use ovsdbapp14:38
otherwiseguydhellmann, I was just going to mention that. :D14:38
smcginnis:)14:38
dhellmannhttp://paste.openstack.org/show/619050/14:38
dhellmannso the remaining question is whether the release validation and announce scripts work properly for a "future" series14:39
smcginnisdhellmann: Shall we find out?14:39
dhellmannI think the announcement is likely to show up as coming for "pike" when it's not14:39
smcginnisdhellmann: Where is that data pulled from?14:39
dhellmannlooking14:40
dhellmannoh, maybe it's using the filename14:41
*** udesale has quit IRC14:44
* dims peeks14:45
smcginnisdhellmann: That would be good.14:45
dhellmannlooking at check_branch_sha in gitutils.py in the releases repo, I think we fixed the issue we had the last time something like this came up14:46
dhellmannI also think the "master" argument to that function isn't being used14:46
dhellmannsmcginnis , dims : I think it's probably safe to go ahead14:47
dhellmannsmcginnis , dims : we need the PTL or liaison to +114:48
dimsdhellmann : the ovsdbapp?14:48
dhellmannyes14:48
dimsotherwiseguy : can you get the PTL or liaison to +1 it please? looks like we can ship quickly14:49
otherwiseguydims, dhellmann smcginnis cool! thanks! pinging kevinbenton. :)14:53
otherwiseguyI think armax is release liaison?14:54
dhellmannyes14:54
* armax looks14:55
openstackgerritDoug Hellmann proposed openstack/releases master: remove unused master argument from check_branch_sha()  https://review.openstack.org/49627614:55
otherwiseguyarmax, basically just need to release the first "queens" ovsdbapp for an non-Openstack user since it has OVN stuff in it they need.14:56
dhellmannotherwiseguy : after this release, it would be good to start thinking about settling the API and releasing a 1.0.0 version14:56
otherwiseguyarmax, https://review.openstack.org/#/c/493235/14:56
otherwiseguydhellmann, absolutely.14:56
armaxotherwiseguy: ok14:57
otherwiseguyI *think* 0.5.0 will essentially become 1.0. Just hedging a bit since I now have a whole release cycle and want to convert networking-ovn over to using it. I don't think I'll find anything else that needs to change, though.14:57
dhellmannsounds good14:57
dhellmannsome folks get antsy about putting 0.y.z versions into production14:58
otherwiseguynew projects are a pain.14:58
armaxotherwiseguy: on a different note, do we test ovsdbapp against neutron?14:58
otherwiseguydhellmann, yeah, i intended to have 0.5.0 be 1.0...I just didn't seen that the library deadline was earlier than the rest of them. And some of the patches sat for review for like 3 weeks.14:58
armaxI can’t see anything of that sort either in the periodic or check queue14:59
otherwiseguyarmax, still working on making a gating test against master ovsdbapp.14:59
armaxOK14:59
openstackgerritEric Harney proposed openstack/releases master: Cinder stable/ocata 10.0.5 release  https://review.openstack.org/49628214:59
otherwiseguyThere is a periodic check.14:59
smcginnisarmax: While you're here - know anything about the status of neutron-fwaas-dashboard?14:59
armaxotherwiseguy: I don’t see it here: http://grafana.openstack.org/dashboard/db/neutron-failure-rate?panelId=4&fullscreen :)14:59
armaxsmcginnis: not on the top of my head, but I can try and help you nonetheless15:00
smcginnisarmax: It's one of the projects on the list that has not done a pike release and requested a pike branch.15:00
smcginnisarmax: So just looking for when that might be coming.15:00
armaxotherwiseguy: http://logs.openstack.org/periodic/periodic-neutron-py35-with-ovsdbapp-master/dd4a10b/console.html.gz15:00
armaxI see it ^15:00
otherwiseguyarmax, search for ovsdbapp :) There's something weird with the py35 check.15:00
armaxbut it looks busted15:00
armaxotherwise: how do we know if the release you’re asking doesn’t break the world :P?15:01
otherwiseguyperhaps tomorrow will be a improve testing day.15:01
armaxsmcginnis: I thought amotoki had taken care of that15:01
armaxsmcginnis: let me check15:01
amotokiarmax: smcginnis: I am taking care of it.15:02
otherwiseguyarmax, well, the release won't break anything. using it might, but I think the requirements change runs neutron tests.15:02
armaxotherwiseguy: right, once we bump the requirements, I mean15:02
smcginnisamotoki: Oh right, sorry. I think there was a note about that.15:02
otherwiseguyarmax, but yeah, absolutely testing improvements are a top priority right now.15:03
otherwiseguyI'm tired of running tons of tests manually to verify.15:03
*** cody-somerville has joined #openstack-release15:06
*** cody-somerville has quit IRC15:06
*** cody-somerville has joined #openstack-release15:06
otherwiseguyarmax, the failure in the periodic is "tox.ConfigError: ConfigError: substitution key '[py35]setenv' not found"15:06
armaxright15:06
otherwiseguywhy i don't quite understand yet15:07
*** tellesnobrega has quit IRC15:09
*** dtantsur|bbl is now known as dtantsur15:13
openstackgerritMatt Riedemann proposed openstack/releases master: newton: release nova 14.0.8  https://review.openstack.org/49628515:20
openstackgerritMerged openstack/releases master: Release ovsdbapp 0.5.0  https://review.openstack.org/49323515:23
*** tmorin has joined #openstack-release15:23
*** tmorin has left #openstack-release15:24
*** yamamoto has joined #openstack-release15:25
*** yamamoto has quit IRC15:30
otherwiseguydims, smcginnis dhellmann armax thanks for the rush on ovsdbapp. the oVirt people are happy. :)15:33
armaxnp15:33
smcginnisotherwiseguy: No problem, glad we could get it going.15:34
otherwiseguyOne group that is bugging me to get something done for them down, several more to go. :)15:35
smcginnisIt never ends. ;)15:37
*** csomerville has joined #openstack-release15:39
*** cody-somerville has quit IRC15:43
openstackgerritRob Cresswell proposed openstack/releases master: Tag Horizon Pike RC2  https://review.openstack.org/49629715:55
*** thorst_afk has quit IRC15:55
*** thorst_afk has joined #openstack-release15:57
*** thorst_afk has quit IRC16:01
*** thorst_afk has joined #openstack-release16:05
*** shardy has quit IRC16:06
*** rajathagasthya has joined #openstack-release16:14
*** iyamahat has quit IRC16:15
*** yamahata has quit IRC16:16
openstackgerritAkihiro Motoki proposed openstack/releases master: Release neutron-fwaas-dashboard 1.0.0 for Pike  https://review.openstack.org/49630716:18
lbragstadhey all - quick question on release notes16:21
lbragstadis this the best channel for that or should i ask somewhere else?16:21
smcginnislbragstad: This is probably good. What's up?16:23
lbragstadso - reno renders release notes, right16:23
lbragstadit looks like it renders release notes based on when they were touched in the $project/releasenotes/ directory16:24
smcginnislbragstad: I've seen some oddness there, but never had the time to track that down.16:24
smcginnisdhellmann: Are you aware of any open issues? ^^16:25
lbragstada lot of the projects also migrated their docs this release, and one of the action items in that was to update all references to links16:25
*** vryzhenkin is now known as freerunner16:25
lbragstadso - we had a contributor go through and do that for keystone - which included updating the contents of release notes for ocata or newton16:25
* smcginnis checks our updates to Cinder...16:25
lbragstadfor example - https://github.com/openstack/keystone/blob/master/releasenotes/notes/bp-shadow-mapping-06fc7c71a401d707.yaml16:25
amotokilbragstad: if you need to touch release notes for past releases, you need to edit release notes in stable branches.16:25
amotokilbragstad: if you touch them in the master, it will be considered as part of the current release.16:26
lbragstadi assume that's why things that went into ocata and newton are rendering in the pike release notes?16:26
*** yamamoto has joined #openstack-release16:26
smcginnisYeah, I think reno looks at where the commit happened relative to the tags.16:27
amotokilbragstad: you already landed a patch to touch older release notes and reverting it does not change the situaiton.16:27
amotokilbragstad: you need to use ignore-notes like https://github.com/openstack/horizon/blob/master/releasenotes/source/pike.rst16:28
amotokilbragstad: horizon did the similar thing and I did a workaround like ^16:28
lbragstadamotoki: ah - ok, that makes sense16:28
amotokilbragstad: this is the corresponding commit https://github.com/openstack/horizon/commit/85fe8f3b5fdf526302831107aee0c372ac5a9fec and16:29
lbragstadit sounds like there are two ways to fix it then? one is to write a patch for stable branches that update the doc urls and the other is to black list those release notes from pike16:29
amotokisee L.96-98 of http://paste.openstack.org/show/617310/ (which describes what I did)16:29
amotokilbragstad: i think you need both.16:29
lbragstadamotoki: aha - ok, that makes sense16:30
lbragstadI suppose this will require a new release candidate16:30
lbragstadfor pike16:31
lbragstadso that the release notes will render properly16:32
amotokiperhaps it does not need another RC as the release notes for pike is always generated from the latest commit of stable/pike16:32
*** yamamoto has quit IRC16:32
smcginnisamotoki: Oh nice, I wasn't aware of the ignore-notes.16:32
amotokismcginnis: I chatted with dhellmann on this topic and it turns out it is the only solution for this.16:33
lbragstadamotoki: ack - that's why I was curious :)16:33
dimsrobcresswell : would you need a RC3 or all done for pike? :)16:33
lbragstadsmcginnis: just to confirm - this change shouldn't require a new release candidate, should it?16:33
smcginnislbragstad: I don't believe so as the publish job is triggered on tagging, IIRC.16:34
smcginnisdims, dhellmann: I'd feel better if one of you confirmed that though. ^^ :)16:34
robcresswelldims: That should be it16:34
lbragstadand like amotoki said - it renders release notes based on stable branches16:34
dimsw00t robcresswell congrats!16:34
*** iyamahat has joined #openstack-release16:35
robcresswell\o/16:35
dhellmannlbragstad, smcginnis : you will need a new release candidate, because the final release is tagged from an existing candidate.16:35
*** yamahata has joined #openstack-release16:35
dhellmannotherwise things can end up in the final release that were never in a candidate16:35
smcginnisdhellmann: Oh right. Thanks for clearing that up.16:36
lbragstadok - that makes sense16:36
lbragstadlooks like that will be our priority today16:36
lbragstadkeystone is going to need an rc316:36
*** pcaruana has quit IRC16:37
openstackgerritMerged openstack/releases master: Tag Horizon Pike RC2  https://review.openstack.org/49629716:38
smcginnisdhellmann: So updates to past release notes should be done directly in those stable branches, and there's just going to be a mismatch of content in master, correct?16:42
dhellmannsmcginnis : yes, that's right16:43
dhellmannthe note files are only ever read out of the branch so it doesn't matter if the master file doesn't match16:43
smcginnisdhellmann: Alternatively, update in master for consistency and use the ignore parameter in the new release note page.16:43
smcginnisdhellmann: OK, got it. Thank you.16:43
dhellmannyeah, updating master is just extra work16:44
dhellmannif the file is updated on the branch, reno should correctly figure out that the note applies to the older release and not the latest16:44
smcginnisJust thinking if someone came across stale info looking through the repo, but I suppose that's a pretty poor way to read release notes. :)16:44
lbragstadi have fixes up for keystone here - https://review.openstack.org/#/q/topic:bug/171057216:56
lbragstadfor the ignore notes patch - it looks like that applies to unreleased notes16:57
lbragstaddo we write a patch directly against stable/pike for that?16:57
dhellmannlbragstad : I'm not sure I understand the question16:58
lbragstaddhellmann: looking at this change - https://review.openstack.org/#/c/490250/316:58
lbragstadit looks like we can opt specific notes out of being rendered for a release16:58
lbragstadhttps://review.openstack.org/#/c/490250/3/releasenotes/source/unreleased.rst16:58
dhellmannyes, that's right. that option was added to address this situation :-)16:59
lbragstaddo we write that patch directly against the stable branch or do we write it to master and somehow denote that "pike is suppose to ignore these" and backport it?16:59
lbragstad^ not sure if that makes any more sense :)16:59
dhellmannyou would put the patch on the branch where the notes are showing but where you don't want them to show16:59
lbragstadaha - ok16:59
*** pbandark has quit IRC16:59
dhellmannbranch(es)16:59
lbragstadso in my case, i need to write it against stable/pike for sure17:00
dhellmannyeah, it sounds like it17:00
dhellmannmaybe master, too? depending on if the note was backported after the branch was created17:00
dhellmannlbragstad : I have to run an errand but if you want me to help with reviews ping me here with URLs and I'll do that when I return17:01
lbragstaddhellmann: in that case - wouldn't we want the note to render?17:01
*** tellesnobrega has joined #openstack-release17:02
lbragstaddhellmann: will do, thank you for the help17:02
dhellmannif the note was originally part of newton or something and it got changed in master and backported to pike, you wouldn't want it to show in either pike or master so you'd need to block it in both places17:02
lbragstadgot it - ok, that makes sense17:04
smcginnisdhellmann: Thoughts? https://review.openstack.org/49631817:07
*** electrofelix has quit IRC17:12
*** thorst_afk has quit IRC17:13
*** eranrom_ has joined #openstack-release17:22
*** eranrom has quit IRC17:25
*** wolverineav has quit IRC17:26
*** wolverineav has joined #openstack-release17:26
*** jpich has quit IRC17:28
*** yamamoto has joined #openstack-release17:28
*** yamamoto has quit IRC17:35
*** rajathagasthya has quit IRC17:45
*** coolsvap has quit IRC17:45
*** ekcs has joined #openstack-release17:47
dhellmannsmcginnis : looking17:49
*** thorst_afk has joined #openstack-release17:49
dhellmannsmcginnis : good content. I wonder if it should go into the reno docs instead? then the ptg could link to that?17:50
dhellmannseems better than the other way around17:50
openstackgerritArmando Migliaccio proposed openstack/releases master: Neutron projects RC2  https://review.openstack.org/49405817:55
lbragstaddhellmann: https://review.openstack.org/#/c/496343/17:59
dhellmannlbragstad : lgtm. We'll see if that trailing comma confuses reno. :-)18:00
lbragstaddhellmann: good catch - updated18:01
dhellmannoh, I really wanted to see if it would confuse the parser :-)18:02
dhellmannI can test that out myself, though, so no worries18:02
*** rajathagasthya has joined #openstack-release18:03
*** dtantsur is now known as dtantsur|afk18:05
*** thorst_a_ has joined #openstack-release18:18
*** thorst_afk has quit IRC18:20
*** rmcall has joined #openstack-release18:21
*** amoralej is now known as amoralej|off18:27
*** bobh has quit IRC18:31
*** yamamoto has joined #openstack-release18:31
*** yamamoto has quit IRC18:37
*** amotoki has quit IRC18:53
smcginnisdhellmann: I was thinking reno docs first, but then thought there was some openstack specific info there that might be better in the ptg.19:11
smcginnisdhellmann: I can switch that over though and link to from the ptg to the reno docs and include that os specific info.19:12
dhellmannwhat part of that seems openstack-specific?19:12
dhellmannI guess the example has a series name19:12
smcginnisdhellmann: The notes about ignore and such.19:12
lbragstaddhellmann: kmalloc and i have a few other questions regarding reno19:12
dhellmannbut the idea of stable branches is pretty well baked into reno19:13
dhellmannlbragstad : ok19:13
kmallocit looks like changes on master are being reflected in stable/pike releases19:13
dhellmannreally? have an example I can look at?19:13
lbragstaddhellmann: even though we have https://review.openstack.org/#/c/492774/119:13
kmallocfiles were changed in master. do we need an ignore in stable/pike then? or in master?19:13
lbragstaddhellmann: https://docs.openstack.org/releasenotes/keystone/pike.html19:13
lbragstaddhellmann: https://docs.openstack.org/releasenotes/keystone/pike.html#id7 for example19:14
lbragstadwe implemented the allow-expired blueprint in ocata19:14
lbragstadbut that release note was also touched in https://review.openstack.org/#/c/493479/ (which merged 8 days ago(19:15
kmallocon master only, the pike change was -2'd today by me before landing19:15
lbragstaddoes the proposal bot propose the change to master to update the release notes, but require someone to backport it to stable/pike?19:15
dhellmannis the allow_expired note in 493479?19:15
lbragstadits not.... weird! let me find another exmple19:16
dhellmannlet me run the report command and see where it's pulling that info19:17
lbragstadah - here19:17
lbragstadhttps://docs.openstack.org/releasenotes/keystone/pike.html#id719:18
lbragstadthe shadow-mapping blueprint was implemented in ocata19:18
lbragstadit was also updated here - https://review.openstack.org/#/c/493479/19:18
lbragstad(but i'm still missing how allow-expired is included in the pike release notes when we didn't touch it)19:18
dhellmannthe shadow-mapping one makes sense, the other one doesn't19:18
kmalloc^^ that is concerning me.19:18
kmallocanyway, before we wedged ignores in, i wanted to make sure we're not also broken in some other way19:19
lbragstadit's like musical release notes :)19:19
lbragstadlet me pull this history on allow-expired and verify if it was updated in pike19:20
lbragstadaha - it was19:20
lbragstadhttps://github.com/openstack/keystone/commit/2fadadbb8c29be031396b5f8a47c72c7d2c3c1eb19:20
lbragstadwhich explains why bp-support-federated-attr is also being rendered, among others that weren't included in https://review.openstack.org/#/c/493479/19:21
dhellmannthis command will show you what file each note comes from and why it is picking up those files: .tox/releasenotes/bin/reno report --branch stable/pike19:21
dhellmannand the content it's going to use19:21
dhellmannin this case it reports:19:22
dhellmannf5d845b9601bc1ef: update to releasenotes/notes/bp-allow-expired-f5d845b9601bc1ef.yaml in commit 2fadadbb8c29be031396b5f8a47c72c7d2c3c1eb19:22
lbragstadyep - that's https://github.com/openstack/keystone/commit/2fadadbb8c29be031396b5f8a47c72c7d2c3c1eb19:22
lbragstadwhich was a wording clean up19:22
dhellmannI suppose I could try to make reno smart enough to notice that the note also appears on an older stable branch, and ignore it19:22
dhellmannbut that involves scanning the entire history of the project, which I was trying to avoid19:23
dhellmannbecause projects with a lot of history would take forever19:23
lbragstadyeah - or we could just have a better policy around not tinkering with wording in release notes19:23
smcginnisI wonder if we should have a convention of notes/[branch] to help make some of this more obvious.19:23
smcginnisEspecially with updating older notes.19:23
dhellmannsmcginnis : the problem with that is when you backport a fix, the filename is wrong19:23
lbragstadsmcginnis: yeah - that was an action item that came out of today's keystone meeting19:24
dhellmannbackporting is why we didn't just use filenames to begin with19:24
smcginnisdhellmann: Well, that's actually interesting. If a fix is backported with a release note, then it's going to show up in both the new and old release notes, right?19:24
dhellmannbecause if I fix something early in queens and backport to pike, then I have to change the patch as I backport it instead of being able to do a clean backport19:24
dhellmannyes, it will, that's by design19:24
smcginnisSo we want queens to have a note that something is fixed if it was already fixed in pike?19:25
smcginnisI suppose that makes sense for more stable releases, but we're in a weird phase for that right now.19:25
dhellmannyes, because it shows exactly what version the fix is in in both branches19:25
lbragstadwell - it must be fixed in queens before it can be backported to pike, right?19:25
dhellmannso if I'm on an early pike release without the fix, I may just wait and upgrade to queens19:25
smcginnislbragstad: Right.19:25
dhellmannbut not all fixes are backported19:26
dhellmannso we want the notes to reflect the real content of each release19:26
lbragstadthe problem we're running into is that we had some patches to trivial updates to various release notes but they are getting picked up in the pike notes19:27
lbragstadthe backport of a fix with a release note makes sense to me19:27
dhellmannI wonder if I make reno not show files that are only updated, but never have the "add" event, if this would go away19:27
kmallocdhellmann: that probably would do it19:27
lbragstadso - for that19:27
dhellmannI'll have to think about whether I can do that. I'm not sure if I have enough info in the scanner.19:27
lbragstadlet's say we backport a patch that updates a broken link19:28
lbragstadthe stable release notes will never render properly and you'll still need an .htaccess fix?19:28
kmalloclbragstad: it would be fine, because the reno would have an "add" event. if he has enough info19:28
kmallocit would render19:28
lbragstadwell - they will render, but it will ignore the backport because it was explicitly an add19:28
lbragstadwasn't*19:28
kmallocthe case where it's an update with no add, it wont be included19:28
lbragstadgot it19:29
dhellmannlbragstad : not quite. The scanner stops when it reaches the point on master where the previous branch was created. So when building the pike history, it looks all the way back to the point where stable/ocata was branched.19:29
dhellmannso if the note was indeed added on master before stable/pike but after stable/ocata and then it's updated in master *after* the branch is created and then that change is backported, it should work fine.19:30
dhellmannwithout any changes to reno, actually19:30
dhellmannthe issue is that we've been updating notes that are much older than that19:30
dhellmannand that "crosses the streams"19:30
lbragstadyes19:30
lbragstadso updating notes from stable/newton for example19:30
dhellmannbecause reno sees that edit and thinks "aha! a new note file!"19:30
dhellmannbut it should wait until it sees the file added, not modified19:31
dhellmannit can tell the difference based on the commit content, I think19:31
dhellmannit has been a few months since I've looked at the code, so it may take me a while to figure out the fix19:31
dhellmannbut I'll make a note of it and look after the ptg for sure19:31
lbragstadno worries - i think we can get by with the ignore-notes approach, right?19:32
dhellmannyes19:32
lbragstadand an .htaccess file19:32
*** yamamoto has joined #openstack-release19:33
kmalloclbragstad: reverted -2 on the pike change for ignore19:34
lbragstadkmalloc: awesome - thanks19:35
kmallocso,now +2/+A19:35
lbragstadi just saw that19:35
kmallocbut ugh.19:35
lbragstadyes - documentation19:35
lbragstadi feel like most of this needs to live in a common place, so i should probably review the patch smcginnis has up19:35
lbragstadbecause the things we're hitting here should be applicable to all projects using reno, and not just keystone19:36
smcginnislbragstad: Update coming to put some of that in the reno docs, some of it in the project team guide.19:36
lbragstadright?19:36
lbragstadsmcginnis: ack19:36
lbragstadsmcginnis: i'll watch for a new version19:36
dhellmannlbragstad : yes, I agree, common docs19:36
smcginnislbragstad: Yeah, I think we need docs somewhere because I think this will likely affect every project at some point.19:36
lbragstadok - i'm going to grab some coffee, thanks for all the help here kmalloc, dhellmann, smcginnis19:38
*** yamamoto has quit IRC19:38
lbragstadit's nice to have this untangled19:38
dhellmann++19:38
smcginnisdhellmann: Do you think https://github.com/openstack/reno/blob/master/doc/source/user/usage.rst would be the right place for this info?19:42
dhellmannsmcginnis : yes, that looks like a good page19:43
smcginnisdhellmann: OK, I'll just have to differentiate from the Edit Release Note for the intially created note and editing an historical note.19:43
*** armax has quit IRC19:52
openstackgerritSean McGinnis proposed openstack/reno master: Add user details for editing stable branch notes  https://review.openstack.org/49639120:02
smcginnislbragstad, dhellmann: ^^20:02
smcginnislbragstad: Any suggestions of what to add about avoiding updates?20:16
smcginnislbragstad: Don't mess up in the first place. :)20:17
lbragstad#waterfallforthewin20:17
smcginnisHah20:17
lbragstadi'm not sure - i know we're probably going to add a section to the keystone docs (if one isn't added to reno) that just says to be mindful of the format, wording, and follow the existing conventions20:19
lbragstadThe existing conventions being - https://docs.openstack.org/keystone/latest/contributor/release-notes.html for keystone20:20
smcginnisYeah, looks like a good place to add a warning of caution.20:24
openstackgerritDoug Hellmann proposed openstack/releases master: update handling of branches in list-changes  https://review.openstack.org/49640220:26
openstackgerritDoug Hellmann proposed openstack/releases master: show missing changes before included changes  https://review.openstack.org/49640320:29
*** claudiub has quit IRC20:30
*** rmcall has quit IRC20:30
*** rmcall has joined #openstack-release20:31
*** yamamoto has joined #openstack-release20:35
*** yamamoto has quit IRC20:38
*** yamamoto has joined #openstack-release20:38
*** yamamoto has quit IRC20:39
* dims peeks20:54
*** dave-mccowan has quit IRC20:58
*** dave-mccowan has joined #openstack-release21:02
*** armax has joined #openstack-release21:04
openstackgerritMerged openstack/releases master: update handling of branches in list-changes  https://review.openstack.org/49640221:08
*** yamamoto has joined #openstack-release21:10
*** yamamoto has quit IRC21:15
*** thorst_a_ has quit IRC21:21
*** thorst_afk has joined #openstack-release21:24
*** thorst_afk has quit IRC21:28
*** thorst_afk has joined #openstack-release22:02
*** thorst_afk has quit IRC22:06
*** thorst_afk has joined #openstack-release22:08
*** yamamoto_ has joined #openstack-release22:11
*** wolverineav has quit IRC22:15
*** wolverineav has joined #openstack-release22:16
*** wolverineav has quit IRC22:16
*** yamamoto_ has quit IRC22:17
*** wolverineav has joined #openstack-release22:17
*** edmondsw has quit IRC22:17
*** thorst_afk has quit IRC22:18
*** thorst_afk has joined #openstack-release22:18
*** wolverineav has quit IRC22:21
*** thorst_afk has quit IRC22:22
*** thorst_afk has joined #openstack-release23:00
*** hongbin has quit IRC23:13
*** yamamoto_ has joined #openstack-release23:13
*** yamamoto_ has quit IRC23:18
ianwtonyb: so as background, we run a slightly forked version of bandersnatch to mirror pypi.  changes have been integrated into it's 2.0 release, but it depends on python3.5.  which means we need to upgrade the pypi mirror host to xenial23:25
ianwit's not urgent, but also not something that will go away, so just want to make sure we don't do something right as someone is releasing something23:26
tonybianw: If it's a 'short' outage and you're mostly worried about someone on the release team hitting the +W then Monday or Friday are good days to do the work as we generally don't do releases on those days.  That doesn't stop Hosted projects from pushing a tag23:34
tonybI *think* most of the release tooling is fine for py27 or py3523:35
dhellmannI think the only release tool not currently running under python 3 is the one that updates launchpad bugs to indicate what release the fix is in.23:36
dhellmannThat does not work on 3 because one of the dependencies is not available to be installed on python 323:36
ianwtonyb: cool, i think a monday then is a good idea.  definitely should just be a cut-over situation23:37
tonybdhellmann: Right.23:37
tonybianw: Cool.  Give us a little notice and it shoudl be fine.23:38
ianwdhellmann: shouldn't affect release tools ... it's just we need to replace the host as it explicitly says "python3.5" required23:38
tonybianw: Would this be post PTG?23:38
tonybianw: We'd want to have a really good backout plan if we weer to do it befoer the pike release date23:39
ianwyeah, the theory is that with AFS we don't release the new volume until it's mirrored correctly23:40
ianwso the risk is we're just a bit slow23:40
*** efried has quit IRC23:42
tonybianw: okay cool.23:42
*** dave-mccowan has quit IRC23:48
*** edmondsw has joined #openstack-release23:55
*** efried has joined #openstack-release23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!