| *** huntxu has joined #openstack-qinling | 01:13 | |
| *** caoyuan has joined #openstack-qinling | 01:50 | |
| *** jiangyuan has joined #openstack-qinling | 02:00 | |
| *** openstackgerrit has joined #openstack-qinling | 02:09 | |
| openstackgerrit | Merged openstack/python-qinlingclient master: Updated from global requirements https://review.openstack.org/551632 | 02:09 |
|---|---|---|
| openstackgerrit | Hunt Xu proposed openstack/qinling master: kubeadm: make it also work on CentOS 7 https://review.openstack.org/551319 | 02:49 |
| kong | huntxu: are you around? | 03:07 |
| huntxu | kong: :) | 03:07 |
| kong | i'm looking at your patch https://review.openstack.org/#/c/550014 but before i look further into the patch, could you please update your patch to remove all the tests for private functions? | 03:08 |
| kong | actually, private functions are supposed to be changed at any time | 03:08 |
| kong | testing private functions will bring maintainance overhead in future | 03:08 |
| kong | we only need to test 'exposed' functions | 03:09 |
| kong | for 'private' functions, i mean the functions with prefix '_' in the file | 03:09 |
| huntxu | kong: I agree. If I remove those tests, should I add some more tests about the exposed ones to cover the branches/errors in the private ones? | 03:11 |
| kong | huntxu: it'd be great if you could do that :-) | 03:12 |
| kong | huntxu: btw, to make the patch easier to review and merge, you could break the big patch into small ones | 03:12 |
| kong | for example, one patch for just one function test | 03:12 |
| kong | but it's up to you | 03:13 |
| kong | that's fine at the current stage, we don't need to strictly follow the best practise :-) | 03:14 |
| huntxu | kong: understood. I will follow your suggestion and update it. That would require some time. | 03:15 |
| kong | huntxu: thanks! | 03:15 |
| kong | huntxu: no rush, you are doing great! | 03:15 |
| huntxu | kong: yeah, I'd like to have a good coverage so that other contributors can have a place to start with the UTs when adding/changing the behaviors. | 03:17 |
| kong | huntxu: agree with you | 03:17 |
| huntxu | With this one, now the coverage report shows a 78%, seems acceptable | 03:17 |
| kong | huntxu: yeah, i saw that, you are doing amazing job :-) | 03:18 |
| huntxu | kong: one more thing to ask, regarding the seperation of api and engine. Is qinling-engine supposed to be an agent-like stuff or something else? Because while reading the codes I find that the engine will also interact with the DB. | 03:36 |
| huntxu | If it is some kind of an agent, I guess it should only interact with the api using rpc/messaging, and only qinling-api will interact with DB. | 03:37 |
| kong | huntxu: it's just the 'engine' :-) it's responsible for creating pools or running functions under the hood, it needs db connection because it also needs to update the db status | 03:38 |
| kong | we need engine because we need to do things in async manner | 03:39 |
| huntxu | kong: I see. So it is supposed to also run on typical OpenStack controller nodes right? | 03:39 |
| kong | yes | 03:40 |
| huntxu | ok. That clarifies my question :) | 03:40 |
| *** huntxu has quit IRC | 04:01 | |
| *** huntxu has joined #openstack-qinling | 05:23 | |
| *** huntxu has quit IRC | 06:08 | |
| *** huntxu has joined #openstack-qinling | 06:09 | |
| *** caoyuan_ has joined #openstack-qinling | 06:22 | |
| *** caoyuan has quit IRC | 06:26 | |
| *** caoyuan has joined #openstack-qinling | 06:26 | |
| *** caoyuan_ has quit IRC | 06:29 | |
| *** huntxu has quit IRC | 06:30 | |
| *** huntxu has joined #openstack-qinling | 06:31 | |
| *** huntxu has quit IRC | 07:02 | |
| *** huntxu has joined #openstack-qinling | 07:02 | |
| *** jiangyuan has quit IRC | 07:12 | |
| *** jiangyuan has joined #openstack-qinling | 07:24 | |
| *** caoyuan_ has joined #openstack-qinling | 08:34 | |
| *** caoyuan has quit IRC | 08:38 | |
| *** caoyuan_ has quit IRC | 10:11 | |
| *** rbrady has quit IRC | 12:25 | |
| *** rbrady has joined #openstack-qinling | 12:29 | |
| *** jiangyuan has quit IRC | 12:48 | |
| openstackgerrit | Hunt Xu proposed openstack/qinling master: Make tempest check use devstack-tempest parent https://review.openstack.org/552033 | 14:22 |
| openstackgerrit | Hunt Xu proposed openstack/qinling master: Make tempest check use devstack-tempest parent https://review.openstack.org/552033 | 14:24 |
| *** huntxu has quit IRC | 15:17 | |
| -openstackstatus- NOTICE: Most jobs in zuul are currently failing due to a recent change to zuul; we are evaluating the issue and will follow up with a recommendation shortly. For the moment, please do not recheck. | 18:18 | |
| *** ChanServ changes topic to "Most jobs in zuul are currently failing due to a recent change to zuul; we are evaluating the issue and will follow up with a recommendation shortly. For the moment, please do not recheck." | 18:18 | |
| *** ChanServ changes topic to "Qinling uses StoryBoard for feature and bug tracking: https://storyboard.openstack.org/#!/project/927" | 18:41 | |
| -openstackstatus- NOTICE: Zuul has been restarted without the breaking change; please recheck any changes which failed tests with the error "Accessing files from outside the working dir ... is prohibited." | 18:41 | |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** liusheng has quit IRC | 21:45 | |
| *** liusheng has joined #openstack-qinling | 21:46 | |
| *** liusheng has quit IRC | 21:48 | |
| *** liusheng has joined #openstack-qinling | 21:49 | |
| *** blkart has quit IRC | 21:49 | |
| *** blkart has joined #openstack-qinling | 21:52 | |
| *** liusheng has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!