Thursday, 2018-11-01

efriededmondsw: You should have a look at at some point. It's merging already, but for your awareness. We also need to port it OOT, which I guess I can do rn.14:21
edmondswefried looking14:22
edmondswhow did both [1] and [2] merge? Shouldn't the second of those have failed to pass gate checks?14:25
efriedoh, because of the new param14:26
efriedno, because that kwarg is only added if upt raises ReshapeNeeded14:26
efriedwhich there was no test path for with the powervm driver.14:26
efriedbut this patch adds one14:27
edmondswI thought it would fail because the method signatures don't match14:28
edmondswregardless of whether anything actually tried to pass allocations to the method14:28
edmondswi.e., a subclass can't override a method in the parent without giving the same args, can it?14:28
efriedyou mean from a rules-of-python perspective? Sure it can. Duck typing, and all that.14:30
openstackgerritEric Fried proposed openstack/nova-powervm master: PowerVM upt parity for reshaper, DISK_GB reserved
efriedHere's the OOT patch ^14:30
efriedDid the same change-id thing.14:30
efried...which is why you always add kwargs at the end when you change a method signature :)14:32
edmondswnah, the reason you do that is to not break callers who didn't use kwarg form14:34
edmondsw(which they always should)14:34
edmondswat least that's the only reason I've ever heard14:34
edmondswI don't really see what duck typing has to do with it... but ok14:34
edmondswmdrabe see the new commit proposal when you get a chance ^14:35
efriededmondsw: Because the method isn't resolved until runtime. And there's absolutely nothing that cross-checks signatures. When the method runs, the call is against whatever version of the method was resolved. And as long as the form of the call gels with the form of the resolved method (in this case, the allocations kwarg omitted) it works just fine.14:56
edmondswI'm just surprised that there is nothing cross-checking signatures. I could have sworn there was15:00
*** chhagarw has joined #openstack-powervm16:12
efriededmondsw, mdrabe: One of y'all want to +W ? CI just passed.16:17
mdrabeefried: Done16:19
efriedmdrabe: thanks16:23
openstackgerritMerged openstack/nova-powervm master: PowerVM upt parity for reshaper, DISK_GB reserved
openstackgerritMerged openstack/nova-powervm master: Use tempfile for powervm config drive
*** chhagarw has quit IRC18:51

Generated by 2.15.3 by Marius Gedminas - find it at!