Monday, 2018-04-09

*** edmondsw has joined #openstack-powervm00:09
*** edmondsw has quit IRC00:14
*** apearson has joined #openstack-powervm00:23
*** AlexeyAbashkin has joined #openstack-powervm01:50
*** tonyb has joined #openstack-powervm01:50
*** AlexeyAbashkin has quit IRC01:54
*** edmondsw has joined #openstack-powervm01:57
*** edmondsw has quit IRC02:02
*** AlexeyAbashkin has joined #openstack-powervm02:50
*** AlexeyAbashkin has quit IRC02:55
*** apearson has quit IRC03:34
*** edmondsw has joined #openstack-powervm03:45
*** edmondsw has quit IRC03:50
*** chhagarw has joined #openstack-powervm04:07
*** edmondsw has joined #openstack-powervm05:33
*** edmondsw has quit IRC05:38
*** edmondsw has joined #openstack-powervm07:21
*** edmondsw has quit IRC07:26
*** edmondsw has joined #openstack-powervm09:10
*** edmondsw has quit IRC09:14
*** edmondsw has joined #openstack-powervm10:58
*** edmondsw has quit IRC11:03
*** edmondsw has joined #openstack-powervm12:04
openstackgerritChhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS
*** apearson has joined #openstack-powervm13:00
*** AlexeyAbashkin has joined #openstack-powervm13:01
*** AlexeyAbashkin has quit IRC13:10
*** AlexeyAbashkin has joined #openstack-powervm13:10
*** apearson has quit IRC13:12
*** AlexeyAbashkin has quit IRC13:17
*** AlexeyAbashkin has joined #openstack-powervm13:17
*** apearson has joined #openstack-powervm13:18
*** AlexeyAbashkin has quit IRC13:34
*** AlexeyAbashkin has joined #openstack-powervm13:37
*** esberglu has joined #openstack-powervm13:39
*** chhagarw has quit IRC13:48
*** apearson has quit IRC13:50
*** tjakobs has joined #openstack-powervm13:51
*** apearson has joined #openstack-powervm13:53
esbergluedmondsw: efried: Redeploying CI now since networking issues were resolved14:19
esbergluOkay if I set max to 1 and min to 0.05 there?14:44
edmondswmax 1 is fine. I'm not sure about min... 0.05 is the current min, but I'd kinda like to leave that up to validation at the lower level14:45
edmondswmin is actually 0.1 on some systems, and 0.05 on others, and who knows if the future will include a system where the min is something else14:45
edmondswI guess we could set min 0.05 and then change it later if we need to14:46
esbergluedmondsw: Would be consistent with
edmondswyeah, ok, go for it14:47
edmondswif we add min/max, I assume oslo.config does the validation and we don't need the validation that you added anymore?14:47
edmondswesberglu ^14:48
esbergluedmondsw: Yep14:48
*** AlexeyAbashkin has quit IRC14:54
*** tjakobs has quit IRC15:36
*** tjakobs has joined #openstack-powervm15:39
*** AlexeyAbashkin has joined #openstack-powervm16:18
esbergluedmondsw: New localdisk patch is up and has been live tested16:21
openstackgerritChhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS
esbergluefried: ^^16:22
esbergluNo localdisk snapshot live testing yet though16:23
openstackgerritChhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS
efriedesberglu: These in-tree driver patches are in a series - that's on purpose, right?16:26
edmondswefried yes, he recently changed them to be in a series16:32
edmondswI think he's at lunch now16:33
-openstackstatus- NOTICE: zuul was restarted to update to the latest code; please recheck any changes uploaded within the past 10 minutes16:52
efriedesberglu, edmondsw: Left a review on localdisk.  The rest are +2.16:59
edmondswefried tx. I need to look at localdisk again myself16:59
efriededmondsw: Looking at it with fresh eyes revealed some stuffs.17:00
edmondswno doubt17:00
*** AlexeyAbashkin has quit IRC17:02
*** AlexeyAbashkin has joined #openstack-powervm17:09
*** apearson has quit IRC17:32
openstackgerritChhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS
*** chhagarw has joined #openstack-powervm17:42
edmondswchhagarw I was looking at the test failure for ps14 of ^ and have a question17:43
edmondswwhere are 'fake-mini' and 'host1' coming from?17:43
edmondswand how... since there can only ever be one host here17:43
chhagarw'fake-mini' is the host name17:45
chhagarw        expected_output = {17:47
chhagarw            'fake-mini_1300C76F-9814-4A4D-B1F0-5B69352A7DEA': 'test_initiator',17:47
chhagarw            'fake-mini_7DBBE705-E4C4-4458-8223-3EBE07015CA9': 'test_initiator'17:47
chhagarw        }17:47
edmondswchhagarw I understand that... that's not what I mean17:49
edmondswwhere did the test get that fake-mini is the host name?17:49
edmondswI did a grep and can't find fake-mini anywhere17:49
edmondswand not only fake-mini, but the link I pasted shows that it also thinks there is a host named 'host1'17:49
edmondswwhere is that coming from... and why 2 different hosts?17:50
*** apearson has joined #openstack-powervm17:51
edmondswchhagarw ?17:52
chhagarwyes it is picking from the wrong feed file17:52
edmondswchhagarw is it though? I don't see either 'host1' or 'fake-mini' in any feed files17:54
chhagarwwhere are the feed files located ?17:58
*** AlexeyAbashkin has quit IRC18:01
*** apearson has quit IRC18:02
edmondswchhagarw I don't think this has anything to do with feed files18:03
*** apearson has joined #openstack-powervm18:03
edmondswhostname isn't in feed files18:05
chhagarwmock tests compares the data based on the feed file mocked, in the above test i am expecting the host name as fake-mini, which is getting returned as host118:05
edmondswhostname should come from CONF.host18:05
edmondswchhagarw not quite... you're getting 2 hosts somehow18:05
edmondswfake-mini AND host118:06
edmondswwhy are you expecting fake-mini?18:06
chhagarwhost is CONF.host18:06
edmondswdo you set to fake-mini somewhere? I'm not seeing that18:06
chhagarwno i didn't, the UT passed with the new submit18:09
*** apearson has quit IRC18:09
*** apearson has joined #openstack-powervm18:09
edmondswchhagarw I'm more concerned with understanding what's going on than just whether we got lucky and the UT passed this time18:10
edmondswit needs to pass all the time18:10
edmondswand we need to understand what it's oing18:10
esbergluefried: New conf group/option goes in features category for renos?18:18
esbergluAll the other conf related stuff is in upgrade, but I haven't found one for a new group yet, just moving existing groups18:18
efriedesberglu: I don't actually know; just echoing what takashin said.  Ask mriedem in -nova18:18
chhagarwedmondsw: I can explain, can you point me to the location of feed files18:19
edmondswesberglu I would assume that's a feature, yes18:19
edmondswbut doesn't hurt to check in nova18:20
edmondswchhagarw you already know the location of feed files.. you pinged it on slack18:20
edmondswbut again... this has nothing to do with feed files18:20
edmondswhost does not come from feed files, it comes from CONF.host18:20
chhagarwi did not changed conf file,18:22
chhagarwsomewhere it might be hardcoded18:23
chhagarwgot it its picking from conf fixtures.18:24
chhagarwhave to change the setup18:25
efriedFYI, use self.flags to change conf values18:25
*** AlexeyAbashkin has joined #openstack-powervm18:28
edmondswah, fake-mini comes from nova... that makes sense18:29
edmondswefried any idea what happened here?
edmondswoh, nm, I think I know...18:31
efriedokay, good.  Not looking...18:31
chhagarwtest_driver we are setting the flag to host118:31
chhagarwself.flags(host='host1', my_ip='')18:31
edmondswan earlier test must have used
chhagarwi suspect it must be coming from here18:31
edmondswand caused _ISCSI_INITIATORS global to get set for that18:31
edmondswchhagarw so I know how to fix this18:31
edmondswchhagarw stop including <host>_ in the key for _ISCSI_INITIATORS18:32
edmondswthere is only one host value, so it doesn't need to be included18:32
edmondswand it will prevent us from getting random gate failures if tests run in different orders18:32
chhagarwwe can just have vios_uuid as well18:32
edmondswright, just key by vios uuid18:32
chhagarwthey will be unique18:33
chhagarwalso do i need to add self.flags in the setup18:33
chhagarwit should not be needed ?18:33
chhagarwor better to add in the tet setup ?18:34
edmondswnot needed18:36
edmondswchhagarw see the comments I just posted18:38
esbergluedmondsw: See nova pls18:40
*** chhagarw has quit IRC18:45
*** chhagarw has joined #openstack-powervm18:58
*** AlexeyAbashkin has quit IRC19:09
chhagarwedmondsw: replied to comments19:25
edmondswchhagarw: replied again19:31
edmondswI haven't see a new patch set yet19:31
chhagarwno patch, some queries and clarification on your comments19:32
edmondswhope I covered it19:33
chhagarwyeah thanks19:35
chhagarwso if we do the proper handling of iSCSIDiscoveryFailed and return None, None this test will change and return the proper exception as VolumeAttachFailed20:05
chhagarwMultipleExceptionsInFeedTask exc was previously thrown since iscsdiscovery exceptions gets overridden with none type iterator exception20:06
edmondswchhagarw sounds good20:11
edmondswchhagarw does it also fix the method above that?20:12
edmondswI see it's also expecting MultipleExceptionsInFeedTask20:12
edmondswthat's what I thought... good20:12
openstackgerritChhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS
openstackgerritChhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS
*** esberglu has quit IRC20:27
*** esberglu has joined #openstack-powervm20:28
*** esberglu_ has joined #openstack-powervm20:30
*** esbergl__ has joined #openstack-powervm20:31
*** esbergl__ is now known as esberglu__20:32
*** esberglu has quit IRC20:33
*** esberglu_ has quit IRC20:34
*** esberglu__ is now known as esberglu20:37
*** chhagarw has quit IRC20:45
efriededmondsw: Do you think I should rip out the emulate business from VIOS-based storage types, per seroyer's comment, or just leave it alone?20:59
edmondswefried oh I missed that21:05
edmondswwhich ones would you rip it out of?21:05
edmondswI think VDisk is used for both? FileIO and RBD are only Linux. Not sure about PV and LU21:07
esbergluedmondsw: Want to make sure I have this proc_units_factor stuff straight21:07
esbergluIt will use the powervm:proc_units extra spec if specified21:08
esbergluOtherwise will use the conf value if specified, with default 0.1 if not specified21:08
edmondswesberglu powervm:proc_units is how many proc_units you want21:09
edmondswI believe powervm:min_proc_units and max are the min/max that you can resize it to later21:10
edmondswmdrabe is that right?21:10
edmondswesberglu so yes21:10
efriededmondsw: I think at least LU is a VIOS-only thing, because SSP-only.21:11
mdrabeYep that's it21:11
edmondswefried today, and that may change, or... ?21:11
edmondswI guess if it did change we could always add at that point21:12
efriedshrug.  Fact is, even for the places we've put it in, there's a bunch of code paths and permutations where it would be ignored/irrelevant.21:12
efriedSo having one more doesn't bother me a lot.21:12
edmondswI'm not sure I really have a strong opinion on this21:12
efriedEspecially if it means a tad more consistency in the interfaces.  Though that ship has sailed long ago.21:12
edmondswI'm fine merging as-is21:13
*** edmondsw has quit IRC21:22
*** edmondsw has joined #openstack-powervm21:24
*** edmondsw has quit IRC21:29
*** tjakobs has quit IRC21:43
efriedesberglu: Is it not called proc_units_factor ?22:19
efriedI thought proc_units was something different (number of proc units)22:20
esbergluefried: proc_units_factor doesn't exist in nova. I'm confused again now, just asked about this above22:22
efriedesberglu: When you say "in nova", where are you looking?22:22
efriedOh, I guess we must be doing the extra specs processing in the nova side of the code.22:22
efriedSo we probably have to port in the proc_units_factor processing from OOT for this to be sane.22:23
efriedWhich we've done.22:24
efriedWe just did it via **kwargs22:24
efriedSo yeah, other than the typo and the possible reno enhancement, what you've got is fine.22:25
*** apearson has quit IRC22:26
efriedesberglu: Sorry, no22:27
esbergluefried: I've really got to run, can you post whatever comments and I'll check it out tonight?22:27
*** esberglu has quit IRC22:27
*** esberglu has joined #openstack-powervm22:28
*** esberglu_ has joined #openstack-powervm22:29
*** esberglu has quit IRC22:33
*** esberglu_ has quit IRC22:34
*** esberglu has joined #openstack-powervm22:50

Generated by 2.15.3 by Marius Gedminas - find it at!