Tuesday, 2016-10-04

*** seroyer has quit IRC00:00
*** jwcroppe has joined #openstack-powervm00:03
*** jwcroppe has quit IRC00:10
*** clbush__ has joined #openstack-powervm00:14
*** thorst has quit IRC00:32
*** thorst has joined #openstack-powervm00:33
*** thorst has quit IRC00:42
*** seroyer has joined #openstack-powervm00:47
*** seroyer has quit IRC00:54
*** clbush__ has quit IRC01:14
*** jwcroppe has joined #openstack-powervm01:16
*** thorst has joined #openstack-powervm01:21
*** thorst has quit IRC01:21
*** thorst has joined #openstack-powervm01:22
*** thorst has quit IRC01:30
*** thorst has joined #openstack-powervm01:47
*** thorst has quit IRC01:48
*** esberglu has quit IRC02:35
*** thorst has joined #openstack-powervm02:48
*** thorst has quit IRC02:57
*** tjakobs has joined #openstack-powervm03:51
*** thorst has joined #openstack-powervm03:55
*** thorst has quit IRC04:02
*** shyama has joined #openstack-powervm04:03
*** thorst has joined #openstack-powervm05:01
*** thorst has quit IRC05:08
*** tjakobs has quit IRC05:18
*** thorst has joined #openstack-powervm06:05
*** thorst has quit IRC06:12
*** thorst has joined #openstack-powervm07:10
*** thorst has quit IRC07:16
*** k0da has joined #openstack-powervm07:44
*** viclarson has joined #openstack-powervm07:51
*** thorst has joined #openstack-powervm08:15
viclarsonтак зафига здесь две сетевухи?08:18
*** thorst has quit IRC08:22
*** jwcroppe has quit IRC09:06
*** thorst has joined #openstack-powervm09:20
*** thorst has quit IRC09:27
*** viclarson has quit IRC10:03
*** thorst has joined #openstack-powervm10:25
*** thorst has quit IRC10:32
*** shyama has quit IRC10:43
*** shyama has joined #openstack-powervm11:05
*** viclarson has joined #openstack-powervm11:21
*** seroyer has joined #openstack-powervm11:28
*** thorst has joined #openstack-powervm11:40
*** jwcroppe has joined #openstack-powervm11:42
viclarson<viclarson> padmin@novalink:~$ pvmctl vea list -i lpar_id=611:57
viclarson<viclarson> Virtual Ethernet Adapters11:57
viclarson<viclarson> +------+------------+------+--------------+------+-------+--------------+11:57
viclarson<viclarson> | PVID |  VSwitch   | LPAR |     MAC      | Slot | Trunk | Tagged VLANs |11:57
viclarson<viclarson> +------+------------+------+--------------+------+-------+--------------+11:57
viclarson<viclarson> | 604  | ETHERNET0  |  6   | FA163EA10B74 |  2   | False |              |11:57
viclarson<viclarson> | 4094 | MGMTSWITCH |  6   | 5661137C0F52 |  3   | False |              |11:57
viclarson<viclarson> +------+------------+------+--------------+------+-------+--------------+11:57
viclarson<viclarson> why we need two interfaces at client vm?11:57
viclarson<viclarson> root@ubuntu:~# cat /etc/network/interfaces11:57
viclarson<viclarson> # Injected by Nova on instance boot11:57
viclarson<viclarson> #11:57
viclarson<viclarson> # This file describes the network interfaces available on your system11:57
viclarson<viclarson> # and how to activate them. For more information, see interfaces(5).11:57
viclarson<viclarson> # The loopback network interface11:57
viclarson<viclarson> auto lo11:57
viclarson<viclarson> iface lo inet loopback11:57
viclarson<viclarson> auto eth111:57
viclarson<viclarson> iface eth1 inet static11:58
viclarson<viclarson>     hwaddress ether 56:61:13:7c:0f:5211:58
viclarson<viclarson>     address None11:58
viclarson<viclarson>     netmask None11:58
viclarson<viclarson>     broadcast None11:58
viclarson<viclarson> iface eth1 inet6 static11:58
viclarson<viclarson>     hwaddress ether 56:61:13:7c:0f:5211:58
viclarson<viclarson>     address fe80::5461:13ff:fe7c:0f5211:58
viclarson<viclarson>     netmask 6411:58
viclarson<viclarson> why eth0 is not configured?11:58
*** k0da has quit IRC12:03
*** edmondsw has joined #openstack-powervm12:18
*** kylek3h has joined #openstack-powervm12:18
*** seroyer has quit IRC12:24
*** k0da has joined #openstack-powervm12:33
thorstviclarson: are you using cloudinit or metadata?12:36
*** jwcroppe has quit IRC12:39
*** burgerk has joined #openstack-powervm12:41
viclarsonwe need cloudinit and metadata12:45
viclarsondefault way cloudinit obtain init script from metadata service12:46
viclarsonbut it doesnt have to be12:48
viclarsonif you asking about murano we d obtain config for murano config and apply it in every way12:51
viclarsonif you asking about murano we d obtain config for murano agent and apply it in every way12:51
*** tblakes has joined #openstack-powervm12:53
thorstviclarson: OK - do you see a cd-drive mounted on the system?  We have some issues currently with the mixed IPv4 and IPv6 configs12:55
*** seroyer has joined #openstack-powervm12:55
viclarsonroot@ubuntu:~# mount -l12:56
viclarsonproc on /proc type proc (rw,noexec,nosuid,nodev)12:56
viclarsonsysfs on /sys type sysfs (rw,noexec,nosuid,nodev)12:56
viclarsonnone on /sys/fs/cgroup type tmpfs (rw)12:56
viclarsonnone on /sys/fs/fuse/connections type fusectl (rw)12:56
viclarsonnone on /sys/kernel/debug type debugfs (rw)12:56
viclarsonnone on /sys/kernel/security type securityfs (rw)12:56
viclarsonudev on /dev type devtmpfs (rw,mode=0755)12:56
viclarsondevpts on /dev/pts type devpts (rw,noexec,nosuid,gid=5,mode=0620)12:56
viclarsontmpfs on /run type tmpfs (rw,noexec,nosuid,size=10%,mode=0755)12:56
viclarsonnone on /run/lock type tmpfs (rw,noexec,nosuid,nodev,size=5242880)12:56
viclarsonnone on /run/shm type tmpfs (rw,nosuid,nodev)12:56
viclarsonnone on /run/user type tmpfs (rw,noexec,nosuid,nodev,size=104857600,mode=0755)12:57
viclarsonnone on /sys/fs/pstore type pstore (rw)12:57
viclarsonsystemd on /sys/fs/cgroup/systemd type cgroup (rw,noexec,nosuid,nodev,none,name=systemd)12:57
viclarson *-cdrom12:57
viclarson             description: SCSI CD-ROM12:57
viclarson             product: VOPTA12:57
viclarson             vendor: AIX12:57
viclarson             physical id: 0.2.012:57
viclarson             bus info: scsi@1:0.2.012:57
viclarson             logical name: /dev/cdrom12:57
viclarson             logical name: /dev/sr012:57
viclarson             capabilities: removable audio12:57
viclarson             configuration: ansiversion=4 status=ready12:57
viclarson           *-medium12:57
viclarson                physical id: 012:57
viclarson                logical name: /dev/cdrom12:57
thorstyeah...but look through here.  This is applicable to your environment (it says PowerVC - but they use these drivers as well)12:58
thorstSection 1.2.2 is what I bet is wrong.  I'd like to wait for kriskend to join IRC as she and I have some patches around this that haven't gotten into nova yet...12:59
*** apearson has joined #openstack-powervm12:59
*** apearson_ has joined #openstack-powervm13:01
seroyerthorst, are you refering to the interfaces.template?13:02
thorstseroyer: yeah13:02
thorstI need to find that link..13:02
thorstefried adreznec seroyer apearson esberglu: https://review.openstack.org/#/c/381772/13:04
efriedthorst, any significant changes from the etherpad?13:04
*** apearson has quit IRC13:04
seroyerthorst, this the link you are looking for?  https://review.openstack.org/#/c/264157/5/nova/virt/interfaces.template13:04
thorstefried: yeah, please re-review13:04
efriedon it.13:04
thorstseroyer: yeah...thanks.  viclarson - recommend you patch the link that seroyer sent.  We need to get that into main nova...13:05
efriedthorst, is our CI providing non-gating votes for nova changes?13:06
thorstefried: yep  :-)13:06
thorstwell wait13:06
efriedOkay, so line 32-35?13:06
thorstits running against the nova change sets.  They don't want us voting.13:06
thorsteven if non-gating13:07
efriedOkay, so actually silent.13:07
thorstthat came from the last mid cycle13:07
viclarsoni dont understand all or nothing13:07
viclarsonwe have problem now13:07
thorstyeah, I think we publish the logs, but we don't have a link to them13:07
viclarsonvm cant access controllee because mac filtering at wswitch13:07
viclarsonis it possible to switch off mac filtering?13:08
thorstseroyer: I don't think so?13:08
viclarsonhttp://www.ibm.com/support/knowledgecenter/SSB27U_6.3.0/com.ibm.zvm.v630.hcpb7/setfvs.htm in this manner?13:08
viclarsonor using pvmctl13:09
viclarsoni dont have access to hmc13:09
viclarsononly novalink and not-fully funtion viosees13:09
*** mdrabe has joined #openstack-powervm13:09
thorstviclarson: you shouldn't need access to HMC...just novalink.  But I think its more a question whether or not PowerVM can turn off mac filtering...if it can, then you should be able to tweak it13:10
thorstbut I'm not sure we support it...13:10
seroyerA virtual Ethernet adapter can only send as self (single MAC address) and can only receive as self (no promiscuous support).  A trunk adapter can send as any MAC, but will receive only frames whose destination MAC does not exist on the same VLAN/vSwitch pair.  But you can only have a single active trunk on a VLAN at a time, so you can’t use SEA and another trunk at the same time.13:12
thorstso net is, unless the VM has a dedicated card you can't send.  The client VM (workload - the thing you deployed) shouldn't need more.  But the controller, the thing running the DHCP agent, L3, etc..., sounds like it needs a dedicated card.13:13
viclarsoncan dedicated card be attached to lpar by hmc?13:18
viclarsonor by pvmctl?13:18
viclarsonor i need to disassemble server?13:19
thorstpvmctl can do it13:21
thorstas long as you have a card that is plugged in, wired properly, etc...13:21
thorstyou still need one on your VIOS to host the Shared Ethernet for the VMs13:21
thorstbut this becomes a 'special' (pet) VM13:21
efriedthorst, https://review.openstack.org/#/c/380762/ - is there some procedural reason the change set needs to be a cherry-pick?13:22
thorstefried: I got yelled at once from the neutron guys for not cherry picking13:22
thorstso I think so13:22
efriedokay, I'll see what I can do.  gerrit wouldn't let me cherry-pick, so I'll have to do it manually, and I'm not positive the end result will actually look any different once it gets up to gerrit.13:23
apearson_viclarson - you would need to detach the slot from an existing lpar and attach it to another:  pvmctl ioslot list/attach/detach13:23
thorstviclarson: who is that why to?   Not sure as we had a couple convos in there.13:30
efriedthorst, I see the difference: the cherry-pick winds up with the same change ID.  It's done.13:32
viclarsonasked apearson: why reattach slot from existing lpar to another?13:32
thorstviclarson: well, you only have to detach from an existing lpar if it is assigned to one currently13:33
thorstif its not assigned to a LPAR yet, just attach to VM13:33
viclarsondetach what?)13:34
viclarsonexisting dedicated card?13:35
thorstviclarson: do you have multiple VIOSes or a single one?13:35
thorstOK, cool.  So each VIOS probably has a network card attached to it13:35
thorstand probably a FC card that hosts an SSP or something like that.13:35
apearson_viclarson - so you asked about how to pass through a dedicated NIC to your lpar.    You can get a list of the physical PCI slots on the system with 'pvmctl ioslot list'.  You can then assign the slot directly (pass through) to the lpar with 'pvmctl ioslot attach'.   however, more than likely it's already attached to an existing lpar - so you'll have to detach it from said lpar first.  If it's not currently assigned to anything, then you can s13:35
apearson_kip the detach step.13:35
thorstyou need to attach a network card (because we allow direct attach of the card to the LPAR) to your controller.13:36
thorstso pvmctl ioslot list - you will see all the cards13:36
thorstyou then need to find one you can attach to your lpar.  Without cutting from your VIOSes13:36
viclarsonpadmin@novalink:~$ pvmctl ioslot list13:37
viclarsonI/O Slots13:37
viclarson|   Loc Code (DRC Name)    |       LPAR       | Description                                           |13:37
viclarson| U78C9.001.WZS0FY6-P1-C10 |      vios1       | 1 Gigabit Ethernet (UTP) 4 Port Adapter PCIE-4x/Short |13:37
viclarson| U78C9.001.WZS0FY6-P1-C11 |                  | Empty slot                                            |13:37
viclarson| U78C9.001.WZS0FY6-P1-C12 |      vios2       | 1 Gigabit Ethernet (UTP) 4 Port Adapter PCIE-4x/Short |13:37
viclarson| U78C9.001.WZS0FY6-P1-C14 |      vios1       | SAS RAID Controller, PCIe2, Dual-port 6Gb             |13:37
viclarson| U78C9.001.WZS0FY6-P1-C15 |      vios2       | SAS RAID Controller, PCIe2, Dual-port 6Gb             |13:37
viclarson| U78C9.001.WZS0FY6-P1-C2  |      vios1       | PCIe2 4-port (10Gb FCoE & 1GbE) SR&RJ45 Adapter       |13:37
viclarson| U78C9.001.WZS0FY6-P1-C3  |      vios1       | PCIe2 16Gb 2-Port Fibre Channel Adapter               |13:37
viclarson| U78C9.001.WZS0FY6-P1-C4  |                  | Empty slot                                            |13:37
viclarson| U78C9.001.WZS0FY6-P1-C5  |                  | Empty slot                                            |13:37
viclarson| U78C9.001.WZS0FY6-P1-C6  |      vios2       | PCIe2 16Gb 2-Port Fibre Channel Adapter               |13:37
viclarson| U78C9.001.WZS0FY6-P1-C7  |      vios2       | PCIe2 4-port (10Gb FCoE & 1GbE) SR&RJ45 Adapter       |13:37
viclarson| U78C9.001.WZS0FY6-P1-C8  |                  | Empty slot                                            |13:37
viclarson| U78C9.001.WZS0FY6-P1-C9  |                  | Empty slot                                            |13:37
viclarson| U78C9.001.WZS0FY6-P1-T2  | novalink_2147CBW | Universal Serial Bus UHC Spec                         |13:37
viclarsoni like it U78C9.001.WZS0FY6-P1-C713:37
thorstviclarson: That may work...just make sure that isn't being used to host your SEA on your VIOS.13:39
viclarsond i attach it to controller vm?13:39
apearson_viclarson - I assume P1-C7 is indeed an Ethernet adapter and not a FC adapter (sometimes it's hard to tell from the description).  But yeah, make sure that device isn't in use on vios2 first.13:39
thorstapearson_: pvmctl won't let viclarson detach if its in use/13:39
viclarsondo you prefer this? U78C9.001.WZS0FY6-P1-C613:40
thorstviclarson: Not Fibre Channel...that's storage13:40
thorstC7, C12, C10, C2...those are all Ethernet adapters (I think)13:41
thorstat least two of those are in use on your vios13:41
thorstyou should only detach what is not in use.13:41
viclarsonand attach to controller?13:41
thorstviclarson: yes, I think so.  Based on what I think you're doing  :-)13:42
thorstand you need to of course make sure that card is plugged in, connected to a switch, etc...13:42
apearson_viclarson - you can check if it's in use with:  pvmctl sea list   That will give you the 'enX' values.  Then you can query the location codes with something like:  viosvrcmd --id 3 -c "lsdev -field name physloc" | grep ent13:42
viclarsonlets get novalink down second time13:46
*** burgerk has quit IRC13:46
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted to address performance degradation and should return momentarily14:01
*** esberglu has joined #openstack-powervm14:03
*** burgerk has joined #openstack-powervm14:13
viclarsonpadmin@novalink:~$ pvmctl ioslot attach --drc-names U78C9.001.WZS0FY6-P1-C12 -p id=414:14
viclarson[PVME01050402-0224] Partition communications not active on partition with ID 4 . Unable to run remote command.14:14
*** tjakobs has joined #openstack-powervm14:14
apearson_viclarson - you need 'rmc' to be active on that partition.  You need to have the 'rsct' packages installed to enable this (pvmctl lpar list -d name rmc_state).  If you don't have the rsct packages installed, you'll need to power off the lpar first, attach the slot, then power it back on.14:15
*** dwayne has quit IRC14:16
viclarsontarget os is ubuntu14:16
viclarsonis rsct package available for ubuntu?14:16
*** jwcroppe has joined #openstack-powervm14:21
apearson_viclarson - here's the repo:  deb http://ppa.launchpad.net/ibmpackages/rsct/ubuntu xenial main14:23
apearson_viclarson - that URL is out of date...it doesn't indicate that you can now get them directly from the PPA repo14:25
thorstapearson_: is there a marker debian that can be installed?14:25
apearson_thorst - what is a marker debian?  Not familiar with that terminology..14:26
viclarsonpadmin@novalink:~$ viosvrcmd --id 3 -c "lsdev -field name physloc" | grep ent14:27
viclarsonent0             U78C9.001.WZS0FY6-P1-C7-T114:27
viclarsonent1             U78C9.001.WZS0FY6-P1-C7-T214:27
viclarsonent2             U78C9.001.WZS0FY6-P1-C7-T314:27
viclarsonent3             U78C9.001.WZS0FY6-P1-C7-T414:27
viclarsonent4             U78C9.001.WZS0FY6-P1-C12-T114:27
viclarsonent5             U78C9.001.WZS0FY6-P1-C12-T214:27
viclarsonent6             U78C9.001.WZS0FY6-P1-C12-T314:27
viclarsonent7             U78C9.001.WZS0FY6-P1-C12-T414:27
viclarsonent8             U8286.42A.2147CBW-V3-C3-T114:27
viclarsonent9             U8286.42A.2147CBW-V3-C6-T114:27
viclarsonent11            U8286.42A.2147CBW-V3-C7-T114:27
viclarsonpadmin@novalink:~$ viosvrcmd --id 2 -c "lsdev -field name physloc" | grep ent14:27
viclarsonent0             U78C9.001.WZS0FY6-P1-C10-T114:27
viclarsonent1             U78C9.001.WZS0FY6-P1-C10-T214:27
viclarsonent2             U78C9.001.WZS0FY6-P1-C10-T314:27
viclarsonent3             U78C9.001.WZS0FY6-P1-C10-T414:27
viclarsonent4             U78C9.001.WZS0FY6-P1-C2-T114:27
viclarsonent5             U78C9.001.WZS0FY6-P1-C2-T214:27
viclarsonent6             U78C9.001.WZS0FY6-P1-C2-T314:27
viclarsonent7             U78C9.001.WZS0FY6-P1-C2-T414:27
viclarsonent8             U8286.42A.2147CBW-V2-C3-T114:27
viclarsonent9             U8286.42A.2147CBW-V2-C6-T114:27
viclarsonent11            U8286.42A.2147CBW-V2-C7-T114:28
viclarsonpadmin@novalink:~$ pvmctl sea list14:28
viclarsonNetwork Bridges14:28
viclarson| PVID |  VSwitch  |  VIOS | Back Dev |  SEA  | Ld Grp | Addl VLANs |14:28
viclarson| 604  | ETHERNET0 | vios1 |   ent6   | ent10 |  ent8  |            |14:28
viclarson|      |           | vios2 |   ent2   | ent10 |  ent8  |            |14:28
viclarsonfor any14:28
viclarsonpadmin@novalink:~$ pvmctl ioslot attach --drc-names U78C9.001.WZS0FY6-P1-C10 -p id=414:28
thorstapearson_: I guess, is there a single package someone can install to get all the necessary debians?14:28
viclarson[PVME010501A6-0402] I/O slot 2104001E is in use and cannot be removed.14:28
viclarsonpadmin@novalink:~$ pvmctl ioslot attach --drc-names U78C9.001.WZS0FY6-P1-C7 -p id=414:28
viclarson[PVME010501A6-0402] I/O slot 21010010 is in use and cannot be removed.14:28
viclarsonpadmin@novalink:~$ pvmctl ioslot attach --drc-names U78C9.001.WZS0FY6-P1-C6 -p id=414:28
viclarson[PVME010501A6-0402] I/O slot 21010018 is in use and cannot be removed.14:28
viclarsoncan be one port be detached?14:28
viclarsonT1, T2, ...14:28
thorstviclarson: can we use pastebin for those big dumps?14:28
apearson_viclarson - ok, so you are using P1-C7 for your SEA (ent2 is the backing device which is P1-C7-T3).  It appears then that P1-C12 is not in use...14:30
apearson_thorst - rsct.core.utils I think will make sure that rsct.core is also installed14:31
viclarsonapearson_ the same14:32
viclarsonpadmin@novalink:~$ pvmctl ioslot attach --drc-names U78C9.001.WZS0FY6-P1-C12 -p id=414:32
viclarson[PVME010501A6-0402] I/O slot 21020014 is in use and cannot be removed.14:32
viclarsonor d be detached before?14:32
apearson_the attach is trying a detach first automatically...(that's actually a bug :) ).  But it means that the device is in fact configured in the OS and you need to unconfigure it.  To do so...14:33
apearson_viosvrcmd --id 3 -c "rmdev -dev  ent4"   Then repeat for ent5, ent6, and ent7 (the 4 parts on C1214:33
apearson_that tells the OS to unconfigure the ports...the detach should work after that.14:34
openstackgerritEric Fried proposed openstack/networking-powervm: [WIP] Refactor, consolidate, and clean up agents  https://review.openstack.org/37800014:40
*** apearson_ has quit IRC14:43
*** apearson has joined #openstack-powervm14:44
*** burgerk_ has joined #openstack-powervm14:46
*** burgerk has quit IRC14:50
*** apearson has quit IRC15:02
*** apearson has joined #openstack-powervm15:03
*** dwayne has joined #openstack-powervm15:11
viclarsonapearson_ attached succesfully, but unfortunately it seems like card not connected to switch (NO-CARRIER)15:11
*** tblakes has quit IRC15:15
efriedapearson ^^15:17
viclarsonjfyi nothing to do i think15:18
*** tblakes has joined #openstack-powervm15:19
apearsonviclarson - bummer...  So your other option would be to:  1)  Tear down the redundant side of the SEA (so your vios1 would be the only one providing bridging for the ethernet).  Or 2)  Get that card patched in.  Or 3)  Try running the controller node on a separate system...15:19
apearsonYou could try the C10 card from vios1...see if that was patched...it doedsn't seem to be in use.  But my guess is probably not.15:20
viclarson2) 3) i dont have cables and separate systems, only first option, but i'm not ready yet15:26
viclarsoni believe c10 is not patched15:27
viclarsonapearson i think two ports of the same network adapter is used by vios itself. is idea of terminating second vios is good enough?15:36
apearsonYes - you could shutdown that second VIOS and use it's adapter.  Make sure that you have redundant I/O for your running lpars though... that is, that the vscsi storage fro your lpars is flowing through vios1  (pvmctl scsi list)15:37
viclarsonwill try)15:40
openstackgerritMatt Rabe proposed openstack/nova-powervm: Change get_vea_slot to get_vnet_slot to account for vNIC.  https://review.openstack.org/38193515:41
*** shyama has quit IRC15:41
openstackgerritMatt Rabe proposed openstack/nova-powervm: Change get_vea_slot to get_vnet_slot to account for vNIC.  https://review.openstack.org/38193515:44
*** mdrabe has quit IRC15:57
*** mdrabe has joined #openstack-powervm16:03
openstackgerritMatt Rabe proposed openstack/nova-powervm: Change get_vea_slot to get_vnet_slot to account for vNIC.  https://review.openstack.org/38193516:07
*** k0da has quit IRC16:13
*** viclarson has quit IRC16:26
*** openstackgerrit has quit IRC16:26
*** openstackgerrit has joined #openstack-powervm16:27
*** openstackgerrit has quit IRC16:28
*** openstackgerrit has joined #openstack-powervm16:29
*** openstackgerrit has quit IRC16:30
*** openstackgerrit has joined #openstack-powervm16:30
*** shyama has joined #openstack-powervm16:31
*** mdrabe has quit IRC16:33
*** mdrabe has joined #openstack-powervm16:33
*** viclarson has joined #openstack-powervm16:35
*** tblakes has quit IRC17:12
*** seroyer has quit IRC17:17
*** seroyer has joined #openstack-powervm17:18
thorstmdrabe: I just W+1'd that vnet slot change.  You mind proposing it back to newton?17:52
thorstefried: https://review.openstack.org/#/c/380761/2 -> Is that function that goes into stable/newton but NOT master?17:53
efriedCorrect - see my review comment.17:53
efriedon PS117:53
efriedthorst ^^17:54
thorstso, I don't think that's proper17:54
thorstwe need it in master and backported to newton17:54
thorstand the other needs to be rebased on top of it.17:54
thorsteverything needs to go in master first unless truly independent for that branch (like specific version updates that we've done in the past)17:55
openstackgerritMerged openstack/nova-powervm: Change get_vea_slot to get_vnet_slot to account for vNIC.  https://review.openstack.org/38193517:55
efriedthorst, say wha?18:06
efriedI mean, I hear your words.  But that's crazy, yo.18:06
openstackgerritEric Fried proposed openstack/networking-powervm: [WIP] Refactor, consolidate, and clean up agents  https://review.openstack.org/37800018:07
*** viclarson has quit IRC18:07
openstackgerritEric Fried proposed openstack/networking-powervm: Time out port update waiting for vif plug  https://review.openstack.org/38202618:09
efriedBut okay, crazy is my middle name.  ^^ thorst18:10
efriedgonna make 378000 a mess.18:10
*** tblakes_ has joined #openstack-powervm18:11
*** tblakes__ has joined #openstack-powervm18:11
*** tblakes__ is now known as tblakes18:15
*** tblakes_ has quit IRC18:16
mdrabeefried, thorst: cherry-picking the get_vnet_slot change back to stable/newton conflicts cuz the VIF plug/unplug UT never made in stable/newton: https://github.com/openstack/nova-powervm/commit/6452f460aa4e688cf49eb7e933ee3bc8a5fc5a9b. Should that UT be backported?18:18
efriedNot really bug-worthy.18:18
efriedBut you're not the first to run into that merge conflict.18:18
efriedWas kinda hoping it would be a one-and-done.18:18
mdrabeYea... it's a weird case18:19
efriedBut since it appears it's going to continue being a PITA, might as well.18:19
efriedYou gonna do that?18:19
mdrabeYea I can do that18:19
mdrabeHere's a question thogh18:19
efriedThanks.  Need a bug and all.18:19
efriedActually, yeah, you might as well fold it into your current cherry-pick18:19
mdrabethough*, should it be backported per the original commit or per my cherry pick?18:19
efriedup to you.18:19
efriedOh, wait, the process police will probably have a fit.18:19
efriedSo better do it by the book.18:20
efriedAnd in order.18:20
mdrabeWell the problem with backporting per the original commit is, then a bug report would be needed18:21
mdrabeUnless I associate the backport with the bug I opened...18:22
efriedmdrabe, Sure, open a bug.  "Cherry-picks and rebases are a pain in the ass."18:34
mdrabeSure I'll mark it perpetually opened18:35
mdrabeefried: I just backported the UT with the cherry-pick18:36
efriedmdrabe, You're either going to have to rebase it on top of https://review.openstack.org/#/c/381836/ or rip out test_plug_raises (and then have another merge conflict when that guy goes in).18:47
efriedmdrabe, oh, there's a change in that method - so yeah, rebase it on top of https://review.openstack.org/#/c/381836/18:49
efriedYou can do that from gerrit, probably.18:49
efriedPunch rebase, check the box that says change parent, and enter 38183618:49
mdrabeefried: yeap somebody's gonna have to rebase18:49
mdrabeyour's isn't merged yet?18:49
efriedNot the newton one.18:50
mdrabeMy master one is merged18:50
mdrabeSo I think you'll have to rebase your master one18:50
efriedNo, my master one was merged before you got started, so you were already okay there.18:50
mdrabeOh, maybe there's another review it was in conflict with18:51
mdrabeCould swear it was in conflict with something. Anyway for stable/newton one of us should get merged first, preferrably yours18:51
efriedYour newton one is in conflict with my newton one.18:51
efriedI'm agreeing with that, but you don't have to wait to rebase yours on mine.  You can do it from gerrit.18:52
efriedPunch rebase, check the box that says change parent, and enter 38183618:52
efriedAlthough I guess that'll probably give you a merge conflict.18:52
mdrabeYea it's a merge conflict18:53
mdrabeI'd have to workspace it18:53
mdrabeBest to wait for merge goshforbid you push up a new commit for that review18:53
*** thorst has quit IRC18:54
*** thorst has joined #openstack-powervm18:55
openstackgerritEric Fried proposed openstack/nova-powervm: Send custom vif plug/unplug event  https://review.openstack.org/37353218:55
efriedlaugh it up thorst ball.  This is all your fault anyway.18:57
efriedPrefer sitting in meetings to doing our code reviews.18:57
thorsto, preference isn't it.18:58
thorstI want to cooooode18:58
thorstspeaking of which...18:58
thorstseroyer: is it time for me to do another live migration?18:58
thorstI have 4 VMs ready18:58
seroyerthorst, Yes!18:58
seroyerReally ready to get this work item off of my queue.  :-)18:59
thorstyou and me both...19:01
thorstexcept I'll have a pile of UT to fix19:01
seroyerThis is my UT.  :-D19:01
thorstseroyer: I don't think you understand the meaning of UT19:01
seroyerNot having Mock as an option makes it hard.  And LPM is super non-trivial to decompose into small tests.19:03
thorsttrue dat19:03
thorstseroyer: its kicked off19:08
thorsthave the IPs and what not?19:08
efriedI used to love sitting in a presentation by Java developers telling me I should do test-driven development on the AIX kernel.19:09
seroyerDid test driven development in hypervisor.  Worked really well for my part of the hypervisor.  Fully automated.  Harder to do when you need to touch hardware though.19:10
thorstseroyer: done19:11
openstackgerritEric Fried proposed openstack/networking-powervm: [WIP] Refactor, consolidate, and clean up agents  https://review.openstack.org/37800019:19
*** k0da has joined #openstack-powervm19:22
*** shyama has quit IRC19:35
openstackgerritMerged openstack/nova-powervm: Send custom vif plug/unplug event  https://review.openstack.org/37353219:51
*** miltonm has quit IRC20:40
*** miltonm has joined #openstack-powervm20:56
*** thorst has quit IRC21:10
openstackgerritEric Fried proposed openstack/networking-powervm: [WIP] Refactor, consolidate, and clean up agents  https://review.openstack.org/37800021:19
*** thorst has joined #openstack-powervm21:19
*** thorst has quit IRC21:24
*** kylek3h has quit IRC21:29
*** burgerk__ has joined #openstack-powervm21:29
*** kylek3h has joined #openstack-powervm21:29
*** burgerk_ has quit IRC21:32
*** burgerk__ has quit IRC21:33
*** kylek3h has quit IRC21:34
*** jwcroppe has quit IRC21:40
*** jwcroppe has joined #openstack-powervm21:40
*** jwcroppe has quit IRC21:40
*** thorst has joined #openstack-powervm21:55
*** thorst has quit IRC22:00
*** mdrabe has quit IRC22:07
*** edmondsw has quit IRC22:10
openstackgerritEric Fried proposed openstack/networking-powervm: Refactor, consolidate, and clean up agents  https://review.openstack.org/37800022:13
*** apearson has quit IRC22:14
*** k0da has quit IRC22:15
*** tblakes has quit IRC22:17
*** tjakobs has quit IRC22:28
*** thorst has joined #openstack-powervm23:49

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!