| NaymulIslam[m] | ccokeke gouthamr : Hey I had created pr before in that pr some of those test are failing and I fixed the code in a new commit in my local machine how can pushed the changes in that pr? | 06:53 |
|---|---|---|
| tspyderboy[m] | NaymulIslam[m]: Hi Naymul Islam | 06:57 |
| tspyderboy[m] | Amend your commit: git commit -a --amend | 06:57 |
| tspyderboy[m] | Again push changes: git review | 06:57 |
| NaymulIslam[m] | Thanks tspyderboy | 06:57 |
| tspyderboy[m] | NaymulIslam[m]: Welcome | 06:58 |
| tspyderboy[m] | Do not change anything in your amended commit name, otherwise it will create issues when patching | 06:58 |
| NaymulIslam[m] | How can I exit the window, the window is like vim editor? | 06:59 |
| tspyderboy[m] | You are on which OS ? | 06:59 |
| NaymulIslam[m] | Windows | 06:59 |
| tspyderboy[m] | If its is Vim --> :q or :wq (for saving changes too) | 07:00 |
| tspyderboy[m] | Nano --> Ctrl-X | 07:00 |
| * NaymulIslam[m] uploaded an image: (16KiB) < https://matrix.org/_matrix/media/v3/download/matrix.org/CLwhhXxdOJAvyKJqFnVvxRMx/chat.png > | 07:01 | |
| NaymulIslam[m] | Here it is | 07:01 |
| tspyderboy[m] | You tried :q ? | 07:02 |
| NaymulIslam[m] | let me try | 07:02 |
| NaymulIslam[m] | None the wq q or ctrl x is working | 07:02 |
| tspyderboy[m] | : then q ? | 07:03 |
| NaymulIslam[m] | Oh I for got the :(colon)... | 07:03 |
| NaymulIslam[m] | It works | 07:03 |
| NaymulIslam[m] | Thanks a lot...:) | 07:04 |
| * NaymulIslam[m] uploaded an image: (15KiB) < https://matrix.org/_matrix/media/v3/download/matrix.org/YzTkIwGbMpNUBYuSRiEKzZMg/Screenshot_3.png > | 07:04 | |
| NaymulIslam[m] | Should I press yes? | 07:05 |
| NaymulIslam[m] | Its come after I call git review | 07:05 |
| tspyderboy[m] | Quick question- You didn't change anything in commit description, when you used git commit amend ? | 07:06 |
| NaymulIslam[m] | Not at all I didn't done it in the last commit also :( | 07:07 |
| NaymulIslam[m] | is that a problem? | 07:07 |
| tspyderboy[m] | It create multiple reviews, if you create new commits or change existing ones. | 07:09 |
| tspyderboy[m] | I think it would be fine then, you can push the changes, using git review. | 07:09 |
| NaymulIslam[m] | Great | 07:09 |
| NaymulIslam[m] | Let's try | 07:09 |
| NaymulIslam[m] | Oh no | 07:10 |
| NaymulIslam[m] | it created another pr :( | 07:10 |
| NaymulIslam[m] | not pushed in the main branch.... | 07:10 |
| tspyderboy[m] | I believe commits were created before, please make sure once you commit, then commits are amended, to make sure another review is not created. | 07:14 |
| tspyderboy[m] | Gerrit works in a little different way than Github PullRequest | 07:14 |
| NaymulIslam[m] | I have abandoned the changes and change the pr manually from the browser | 07:16 |
| tspyderboy[m] | What was your old pr review ? | 07:17 |
| NaymulIslam[m] | its here : https://review.opendev.org/c/openstack/manila/+/913210 | 07:17 |
| NaymulIslam[m] | Now its wroked. | 07:18 |
| tspyderboy[m] | In your terminal: | 07:18 |
| tspyderboy[m] | git review -d 913210 | 07:18 |
| tspyderboy[m] | This will bring your review changes back to your IDE | 07:18 |
| NaymulIslam[m] | tspyderboy[m]: > <@tspyderboy:matrix.org> In your terminal:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/GVjdnUGcDyAhEpNFXfACTBmv>) | 07:20 |
| NaymulIslam[m] | Btw thanks for your help....:) | 07:21 |
| tspyderboy[m] | NaymulIslam[m]: Yes, you can continue making changes again in your local after this. And again git commit amend, and push your changes... | 07:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
