| mbeas | hi Maari, hi Victoria! | 13:45 |
|---|---|---|
| mbeas | I am trying to find a bug to work on | 13:46 |
| vkmc | hi mbeas! | 13:46 |
| vkmc | ok, let's get that bug for you to fix | 13:46 |
| mbeas | thank you | 13:46 |
| maaritamm | mbeas: Hey! | 13:52 |
| vkmc | mbeas_, ok, we will go through the full process of spotting, reporting and fixing a bug | 14:03 |
| vkmc | mbeas_, the buggy code is here https://github.com/openstack/manila/blob/45f98a7d0a7d186cd46cd8da40715b87c029fe27/manila/utils.py | 14:03 |
| vkmc | mbeas_, precisely, is code that needs some update | 14:03 |
| vkmc | mbeas_, the issue is the usage of the six library | 14:03 |
| vkmc | mbeas_, we had that library when we were going from python2 to python3 | 14:04 |
| vkmc | nowadays we only support python3 | 14:04 |
| vkmc | so it makes sense to remove that | 14:04 |
| vkmc | mbeas_, you would need to report this as a bug in launchpad | 14:04 |
| vkmc | mbeas_, https://bugs.launchpad.net/manila | 14:05 |
| vkmc | subject can be something like "remove six from the utils module" | 14:05 |
| vkmc | description could be something like "checks made with the six library are not longer needed since we are not supporting py2 anymore" | 14:06 |
| vkmc | and then you can assign to that bug you reported | 14:07 |
| vkmc | and work on submitting a fix | 14:07 |
| vkmc | mbeas_, maaritamm, how does that sound? | 14:07 |
| mbeas | ok, so import six (45th line) should be removed? | 14:07 |
| mbeas | first i have to report it | 14:08 |
| mbeas | in the link you provided | 14:08 |
| maaritamm | vkmc: nice, that's a good bug, thanks! | 14:12 |
| vkmc | mbeas, yeah, exactly | 14:12 |
| maaritamm | mbeas: yes, first report it, then assign yourself to it | 14:12 |
| maaritamm | mbeas: yeah, you need to remove the import but also the usage of it | 14:14 |
| mbeas | I am now trying to figure out how to report the bug | 14:14 |
| mbeas | i am going to select Report a bug | 14:14 |
| mbeas | and try to find a good description first | 14:15 |
| mbeas | i reported the bug under title Remove six library import and usage from manila/utils.py | 14:35 |
| vkmc | can you share the link of the reported bug? | 14:38 |
| maaritamm | https://bugs.launchpad.net/manila/+bug/1948029 | 14:42 |
| maaritamm | here it is, nice! | 14:42 |
| vkmc | ++ | 14:44 |
| gouthamr | i <3 that you are picking this bug as a good first issue | 14:48 |
| gouthamr | six has band-aided us far longer than we needed it | 14:49 |
| francie | Good afternoon all | 14:49 |
| vkmc | francie, o/ | 14:49 |
| francie | My name is Franca, I am an Outreachy applicant for this cohort | 14:50 |
| vkmc | francie, maaritamm and gouthamr are also manila mentors | 14:50 |
| francie | Thanks vkmc | 14:50 |
| vkmc | and we are missing ashley who might join in a bit | 14:50 |
| vkmc | so this is a good place to make questions as needed | 14:50 |
| francie | Wow! Thank you very much! | 14:50 |
| francie | I feel welcomed already :) | 14:50 |
| maaritamm | francie: hi! :) | 14:51 |
| vkmc | mbeas, what is your name and where are you based? | 14:52 |
| mbeas_ | I am having trouble with the internet connection | 15:04 |
| mbeas_ | in order to work on the bug I have to open the file in an ide in my local environment? | 15:07 |
| vkmc | mbeas_, that's correct | 15:10 |
| vkmc | mbeas_, have you set up a development environment? | 15:10 |
| vkmc | maybe using devstack or cloning the repo you want to contribute ot | 15:10 |
| vkmc | to* | 15:10 |
| mbeas_ | yes i have set it up | 15:10 |
| mbeas_ | i have set up a dedicated virtual machine for the environment | 15:11 |
| vkmc | perfect! | 15:12 |
| vkmc | kafilat, o/ around? | 15:19 |
| kafilat | vkmc o/ | 15:20 |
| kafilat | hi | 15:20 |
| vkmc | kafilat, are you working on https://bugs.launchpad.net/python-manilaclient/+bug/1898311? | 15:21 |
| vkmc | not sure if that is fixed or if you are workng on it :) | 15:21 |
| kafilat | Not any more | 15:21 |
| vkmc | kafilat, is it ok if francie takes it as her first contribution? | 15:21 |
| kafilat | Sure! | 15:21 |
| vkmc | cool! | 15:22 |
| vkmc | francie, you can take https://bugs.launchpad.net/python-manilaclient/+bug/1898311 | 15:22 |
| vkmc | that's a nice bug in the client | 15:22 |
| maaritamm | mbeas_: do you need any more help to get started? Did you find the file in your environment? | 15:49 |
| maaritamm | if you want to connect you IDE to your VM, you'll need something that supports remote connections, I like VSCode and once upon a time I wrote down how I connect to my VM: https://maari.ee/how-to-connect-visual-studio-code-to-a-local-vm/ | 15:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!