| archanaserver | vkmc, hi o/ | 10:51 |
|---|---|---|
| vkmc | archanaserver, o/ | 10:51 |
| vkmc | hi there! | 10:51 |
| archanaserver | vkmc, about this patch https://review.opendev.org/c/openstack/manila/+/795990 | 10:51 |
| archanaserver | vkmc, i was following goutham comments, when i'm asserting the parent structure too in the tests | 10:53 |
| archanaserver | it throws me an assertion error, the same we faced during pair programming | 10:53 |
| archanaserver | vkmc, so what should i do here? | 10:53 |
| vkmc | archanaserver, really depends on the assertion error | 10:57 |
| vkmc | what error are you getting? | 11:02 |
| archanaserver | vkmc, ok this is the error http://paste.openstack.org/show/807376/ | 11:04 |
| archanaserver | this asking to pop share group object | 11:04 |
| vkmc | archanaserver, ok, you need to remove the share_group sqlalchemy object from the dicts you are comparing | 11:05 |
| vkmc | as we did on our pair programming session | 11:06 |
| archanaserver | http://paste.openstack.org/show/807377/ but this is what we are doing here right? | 11:09 |
| vkmc | archanaserver, yeah, but you have the two assertions | 11:19 |
| vkmc | let me see | 11:19 |
| vkmc | latest Goutham's comments | 11:19 |
| vkmc | I remember he told you to assert equality between the original dicts | 11:19 |
| vkmc | but we shouldn't do that | 11:19 |
| archanaserver | vkmc, yup sure see the latest comments, i might be not understanding something correctly | 11:21 |
| vkmc | yeah | 11:21 |
| vkmc | archanaserver, sorry haven't replied yet | 11:54 |
| vkmc | but I'm working on material we need for today osd | 11:54 |
| vkmc | let's sync up on this later today or tomorrow | 11:54 |
| archanaserver | vkmc, okie sure | 11:56 |
| archanaserver | vkmc, we already have osd openstack setup party today, can we sync up tomorrow for this? | 12:42 |
| vkmc | archanaserver, yes, tomorrow works for me | 12:43 |
| vkmc | I'll look for a slot in my agenda and we can do a pair programming | 12:43 |
| archanaserver | vkmc, okie! | 12:43 |
| vkmc | archanaserver, just sent you an invite so we have pair programming sessions on tuesdays | 15:12 |
| vkmc | hope the slot work | 15:12 |
| vkmc | we can change it is not | 15:12 |
| vkmc | if* | 15:12 |
| archanaserver | vkmc, yep it'll work | 15:13 |
| archanaserver | vkmc, ty :) | 15:14 |
| vkmc | cool :) | 15:15 |
| vkmc | and looking again at the patch gouthamr reviewed now | 15:15 |
| archanaserver | vkmc, okay | 15:16 |
| archanaserver | vkmc, i'm facing an error on dashboard page, i didn't get from where it's coming | 15:20 |
| vkmc | archanaserver, are you testing a change you made? | 15:20 |
| archanaserver | vkmc, sorry i think i didn't get your point | 15:22 |
| archanaserver | vkmc, for any specific patch? | 15:22 |
| archanaserver | vkmc, i'm talking about this error (attaching screenshot) | 15:23 |
| archanaserver | here https://usercontent.irccloud-cdn.com/file/GmxSyvJ2/Screenshot%202021-07-12%20at%208.53.55%20PM.png | 15:24 |
| vkmc | archanaserver, are you seeing that error with a patch you wrote? | 15:25 |
| vkmc | archanaserver, or is the base code for the dashboard? | 15:25 |
| archanaserver | vkmc, with the base code when i'm looking on ui side -> http://localhost:8080/dashboard/ | 15:26 |
| vkmc | ok, we can debug later | 15:26 |
| vkmc | let's focus on one thing at a time | 15:26 |
| vkmc | I'll review the assertion on manila patch | 15:27 |
| vkmc | so you can follow with that | 15:27 |
| archanaserver | vkmc, yes sure | 15:27 |
| vkmc | also, did you see the reviews I left on https://review.opendev.org/c/openstack/python-manilaclient/+/799997? | 15:28 |
| archanaserver | yes i saw those review, and i was trying to understand few things from code base so it's taking some time | 15:29 |
| archanaserver | vkmc, hope it'll be okay if i submit the latest patch by tomorrow on this patch? | 15:32 |
| vkmc | archanaserver, yeah, just looking for tasks to keep you going | 15:34 |
| vkmc | archanaserver, also, are you working on the python course? | 15:34 |
| archanaserver | vkmc, oh okie then | 15:35 |
| archanaserver | vkmc, yes i'm daily putting some hours into that | 15:35 |
| vkmc | archanaserver, very well :) | 15:36 |
| vkmc | that's key | 15:36 |
| archanaserver | vkmc, today i worked on string,s if statements and while loop stuffs | 15:36 |
| vkmc | archanaserver, very good | 15:37 |
| archanaserver | vkmc, ty :) | 15:37 |
| archanaserver | vkmc, also I published this blog yesterday https://archanaserver.in/2021-07-11-outreachy-week-7/ | 16:13 |
| archanaserver | vkmc, the outreachy task blogs(think about your audience) is still in my draft, need to add few more thing in there (i guess I'll publish it this tomorrow) I’ll share the update with you | 16:13 |
| vkmc | archanaserver, sounds good, great job! | 16:24 |
| gouthamr | kafilat: o/ noticed gtema's reviews on your patch :) i've added a couple of comments as response. feel free to fix only the other ones unless he insists | 16:34 |
| archanaserver | vkmc, thanks again and ttyt :) | 16:37 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/795990/9/manila/tests/db/sqlalchemy/test_api.py#1272 | 16:39 |
| gouthamr | i realize i was confused now; re-reading that code; you're indeed comparing the parent structures like i was suggesting, but not the objects you popped out | 16:40 |
| gouthamr | or not | 16:43 |
| gouthamr | get_sg_snap_source_group = dict(get_sg_snap).pop('share_group', {}) | 16:43 |
| gouthamr | here get_sg_snap_source_group is the "share_group" you just popped out of the "get_sg_snap" object's dict representation | 16:44 |
| gouthamr | added more comments to the review | 16:54 |
| kafilat | gouthamr: thanks, I've updated the patch. | 17:36 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
