| *** archanaserver has joined #openstack-outreachy | 04:29 | |
| archanaserver | hi @vkmc morning | 08:27 |
|---|---|---|
| archanaserver | i was working on this bug(https://bugs.launchpad.net/cinder/+bug/1646433), seems like this one is already fixed | 09:13 |
| archanaserver | as per the bug description my work is to replace assertDictMatch with assertDictEqual method in tests file but seems like this review(https://review.opendev.org/c/openstack/cinder/+/405258/) fixed this and it's merged too :/ | 09:13 |
| archanaserver | if i'm missing any important info, please help me with it. | 09:13 |
| opendevmeet | Launchpad bug 1646433 in OpenStack Shared File Systems Service (Manila) "Replace assertDictMatch with assertDictEqual method in tests" [Wishlist,In progress] - Assigned to Rajat Sharma (tajar29) | 09:13 |
| archanaserver | after i saw the fix, i'm confuse a little what my task is here? | 09:14 |
| archanaserver | and about the python-manilaclient fix, i'm working on resolving all the reviews. | 09:15 |
| vkmc | heyy archanaserver o/ | 09:21 |
| vkmc | feeling better today ? | 09:21 |
| archanaserver | yes feeling much better :) | 09:22 |
| vkmc | partially got your last message | 09:22 |
| vkmc | <archanaserver> and about the python-manilaclient fix, i'm working on resolving all the reviews. <- seems there is something previous | 09:22 |
| archanaserver | i sent it today ( a few mins ago) | 09:24 |
| archanaserver | with a few other updates | 09:24 |
| vkmc | yeah, which are the other updates? | 09:25 |
| vkmc | mind copy pasting for me? | 09:25 |
| archanaserver | yes | 09:25 |
| archanaserver | i was working on this bug(https://bugs.launchpad.net/cinder/+bug/1646433), seems like this one is already fixed | 09:26 |
| archanaserver | 2:43 PM | 09:26 |
| archanaserver | as per the bug description my work is to replace assertDictMatch with assertDictEqual method in tests file but seems like this review(https://review.opendev.org/c/openstack/cinder/+/405258/) fixed this and it's merged too :/ | 09:26 |
| archanaserver | 2:43 PM | 09:26 |
| archanaserver | if i'm missing any important info, please help me with it. | 09:26 |
| opendevmeet | Launchpad bug 1646433 in OpenStack Shared File Systems Service (Manila) "Replace assertDictMatch with assertDictEqual method in tests" [Wishlist,In progress] - Assigned to Rajat Sharma (tajar29) | 09:26 |
| archanaserver | after i saw the fix, i'm confuse a little what my task is here? | 09:26 |
| archanaserver | 2:45 PM | 09:26 |
| archanaserver | and about the python-manilaclient fix, i'm working on resolving all the reviews. | 09:26 |
| vkmc | oh cool | 09:26 |
| vkmc | so | 09:26 |
| vkmc | there is a cinder bug and a manila bug | 09:26 |
| vkmc | cinder is fixed | 09:26 |
| vkmc | manila is not | 09:26 |
| archanaserver | ah! i was looking into cinder one and thought it's already fixed | 09:26 |
| vkmc | someone proposed a fix for manila and then abandoned it | 09:27 |
| vkmc | https://review.opendev.org/c/openstack/manila/+/413867/ | 09:27 |
| vkmc | not very clear why | 09:27 |
| vkmc | if you can restore it | 09:27 |
| vkmc | and submit and update for it | 09:27 |
| vkmc | we can continue by reviewing that :) | 09:27 |
| archanaserver | yeah sure! | 09:27 |
| vkmc | feel free to assign yourself in launchpad as well | 09:28 |
| archanaserver | okie :) | 09:29 |
| vkmc | archanaserver, running late | 10:00 |
| archanaserver | ok, i'm there | 10:02 |
| archanaserver | hie, i was resolving all those issues by going through your review but facing this error. http://paste.openstack.org/show/806528/ | 12:41 |
| archanaserver | it's in different function so not able to get what it's saying (the error message) | 12:41 |
| archanaserver | yay 🥳 | 13:27 |
| archanaserver | just pass all the test cases and saw py36: commands succeeded congratulations :) | 13:28 |
| archanaserver | so happy right now, thank you so much Vicky for the brief review :) | 13:30 |
| archanaserver | everything looks good here, so i'm commiting it for our review | 13:32 |
| archanaserver | *your review | 13:38 |
| vkmc | archanaserver++ | 13:49 |
| vkmc | yaay | 13:49 |
| vkmc | well done! | 13:49 |
| archanaserver | thanks a lot, it's because you are helping me at every stages :) | 13:51 |
| archanaserver | @vkmc just done with fixing this bug https://bugs.launchpad.net/cinder/+bug/1646433 do i need to run any tests command before submitting patch | 14:11 |
| opendevmeet | Launchpad bug 1646433 in OpenStack Shared File Systems Service (Manila) "Replace assertDictMatch with assertDictEqual method in tests" [Wishlist,In progress] - Assigned to Archana Kumari (archanaserver) | 14:11 |
| gouthamr | archanaserver: have you done these? https://docs.openstack.org/manila/latest/contributor/development.environment.html#running-unit-tests | 14:12 |
| archanaserver | not in manila | 14:13 |
| gouthamr | archanaserver: i'd suggest running "tox -e pep8" (linting tests), "tox -epy3" (unit tests) locally --- you could just run "tox" if you'd like to run all the tests serially | 14:13 |
| archanaserver | okay got it! thanks @gouthamr | 14:14 |
| vkmc | archanaserver, just dropped the bug squash and joined the openinfra | 17:01 |
| vkmc | https://zoom.us/j/5153069380 | 17:02 |
| archanaserver | i'm joining in a min | 17:02 |
| vkmc | cool | 17:02 |
| vkmc | archanaserver++ | 17:21 |
| vkmc | we can work on a couple of questions and rehearse some comebacks | 17:21 |
| vkmc | :) | 17:21 |
| *** kafilat has joined #openstack-outreachy | 17:29 | |
| *** archanaserver has quit IRC | 19:48 | |
| *** kafilat has quit IRC | 19:48 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!