Monday, 2018-05-07

*** shardy has joined #openstack-oslo00:45
*** dave-mccowan has joined #openstack-oslo00:47
*** yamamoto has joined #openstack-oslo01:20
*** edmondsw has joined #openstack-oslo01:32
*** edmondsw has quit IRC01:36
*** yamamoto has quit IRC01:54
*** links has joined #openstack-oslo02:17
*** namnh has joined #openstack-oslo02:18
openstackgerritTovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend  https://review.openstack.org/48001802:28
*** bobh has joined #openstack-oslo02:31
openstackgerritTovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend  https://review.openstack.org/48001802:39
*** yamamoto has joined #openstack-oslo02:41
*** EvilienM is now known as EmilienM02:45
openstackgerritwangxiyuan proposed openstack/oslo.limit master: Init repo  https://review.openstack.org/55674403:07
*** shardy has quit IRC03:12
*** shardy has joined #openstack-oslo03:18
*** edmondsw has joined #openstack-oslo03:20
*** dave-mccowan has quit IRC03:23
*** edmondsw has quit IRC03:24
*** yamamoto has quit IRC03:25
*** yamamoto has joined #openstack-oslo03:37
*** shardy has quit IRC03:40
*** pooja_jadhav has joined #openstack-oslo03:45
*** bobh has quit IRC03:55
*** bobh has joined #openstack-oslo04:00
*** threestrands has joined #openstack-oslo04:04
*** jaosorior has joined #openstack-oslo04:05
*** bobh has quit IRC04:05
*** namnh has quit IRC04:08
*** namnh has joined #openstack-oslo04:09
*** gyankum has joined #openstack-oslo04:10
*** bobh has joined #openstack-oslo04:11
*** bobh has quit IRC04:16
*** bobh has joined #openstack-oslo04:23
*** bobh has quit IRC04:27
*** bobh has joined #openstack-oslo04:34
*** bobh has quit IRC04:39
*** bobh has joined #openstack-oslo04:50
*** Guest47185 has quit IRC04:52
*** bobh has quit IRC04:55
*** Guest47185 has joined #openstack-oslo04:57
*** bobh has joined #openstack-oslo05:02
*** bobh has quit IRC05:06
*** hoonetorg has quit IRC05:07
*** bobh has joined #openstack-oslo05:12
*** bobh has quit IRC05:17
*** hoonetorg has joined #openstack-oslo05:20
*** bobh has joined #openstack-oslo05:22
*** bobh has quit IRC05:27
*** bobh has joined #openstack-oslo05:33
*** bobh has quit IRC05:37
*** bobh has joined #openstack-oslo05:42
*** bobh has quit IRC05:47
*** jbadiapa has joined #openstack-oslo05:56
*** pcaruana has joined #openstack-oslo06:02
*** yamamoto has quit IRC06:03
*** bobh has joined #openstack-oslo06:10
*** yamamoto has joined #openstack-oslo06:14
*** bobh has quit IRC06:15
*** shardy has joined #openstack-oslo06:16
*** bobh has joined #openstack-oslo06:22
*** bobh has quit IRC06:27
*** bobh has joined #openstack-oslo06:39
*** bobh has quit IRC06:43
*** bobh has joined #openstack-oslo06:50
*** Guest47185 has quit IRC06:54
openstackgerritTovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend  https://review.openstack.org/48001806:54
*** bobh has quit IRC06:54
*** edmondsw has joined #openstack-oslo06:56
*** Guest47185 has joined #openstack-oslo06:58
*** edmondsw has quit IRC07:00
*** yamamoto has quit IRC07:04
*** bobh has joined #openstack-oslo07:05
*** bobh has quit IRC07:10
*** yamamoto has joined #openstack-oslo07:11
*** toabctl has quit IRC07:18
*** toabctl has joined #openstack-oslo07:22
*** shardy has quit IRC07:37
*** bobh has joined #openstack-oslo07:39
*** threestrands has quit IRC07:39
*** bobh has quit IRC07:43
*** bobh has joined #openstack-oslo07:44
*** bobh has quit IRC07:49
*** yamamoto has quit IRC08:04
*** yamamoto has joined #openstack-oslo08:07
*** bobh has joined #openstack-oslo08:20
*** bobh has quit IRC08:25
*** edmondsw has joined #openstack-oslo08:44
*** bobh has joined #openstack-oslo08:45
*** edmondsw has quit IRC08:49
*** pblaho has joined #openstack-oslo08:49
*** bobh has quit IRC08:50
*** bobh has joined #openstack-oslo08:50
*** bobh has quit IRC08:55
*** bobh has joined #openstack-oslo09:04
*** e0ne has joined #openstack-oslo09:07
*** bobh has quit IRC09:08
*** jaosorior has quit IRC09:17
*** bobh has joined #openstack-oslo09:18
*** jaosorior has joined #openstack-oslo09:19
*** bobh has quit IRC09:23
*** Guest47185 has quit IRC09:33
*** bobh has joined #openstack-oslo09:34
openstackgerritTovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend  https://review.openstack.org/48001809:36
*** bobh has quit IRC09:39
*** bobh has joined #openstack-oslo09:40
*** bobh has quit IRC09:45
*** Guest47185 has joined #openstack-oslo09:47
*** bobh has joined #openstack-oslo10:07
*** bobh has quit IRC10:12
*** namnh has quit IRC10:15
*** bobh has joined #openstack-oslo10:22
*** bobh has quit IRC10:27
*** edmondsw has joined #openstack-oslo10:32
*** bobh has joined #openstack-oslo10:36
*** edmondsw has quit IRC10:36
*** bobh has quit IRC10:40
*** bobh has joined #openstack-oslo10:42
*** bobh has quit IRC10:47
*** bobh has joined #openstack-oslo10:50
*** bobh has quit IRC10:55
openstackgerritClaudiu Belu proposed openstack/oslotest master: mock: Perform patch's autospec checks on __enter__  https://review.openstack.org/56158110:58
openstackgerritClaudiu Belu proposed openstack/oslotest master: mock: Perform patch's autospec checks on __enter__  https://review.openstack.org/56158110:59
*** dave-mccowan has joined #openstack-oslo11:14
*** bobh has joined #openstack-oslo11:15
*** bobh has quit IRC11:20
*** bobh has joined #openstack-oslo11:23
openstackgerritMoisés Guimarães de Medeiros proposed openstack/oslo.config master: Base class for a configuration driver  https://review.openstack.org/56002711:25
openstackgerritMoisés Guimarães de Medeiros proposed openstack/oslo.config master: ConfigurationSource base class  https://review.openstack.org/55938911:25
openstackgerritMoisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver.  https://review.openstack.org/56274611:25
*** dave-mccowan has quit IRC11:26
*** dave-mccowan has joined #openstack-oslo11:27
*** bobh has quit IRC11:28
*** bobh has joined #openstack-oslo11:32
*** bobh has quit IRC11:32
*** ansmith has quit IRC11:42
*** jaosorior has quit IRC11:49
*** jroll has quit IRC11:56
*** jroll has joined #openstack-oslo11:57
*** yamamoto has quit IRC11:59
*** yamamoto has joined #openstack-oslo12:02
*** raildo has joined #openstack-oslo12:04
*** nicolasbock has joined #openstack-oslo12:09
*** yamamoto has quit IRC12:29
*** edmondsw has joined #openstack-oslo12:32
*** edmondsw has quit IRC12:36
*** edmondsw has joined #openstack-oslo12:38
*** edmondsw has quit IRC12:42
openstackgerritMoisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver.  https://review.openstack.org/56274612:44
*** edmondsw has joined #openstack-oslo12:44
*** kgiusti has joined #openstack-oslo12:47
*** edmondsw has quit IRC12:48
*** edmondsw has joined #openstack-oslo12:49
*** yamamoto has joined #openstack-oslo12:52
*** jaosorior has joined #openstack-oslo12:54
*** ansmith has joined #openstack-oslo12:55
*** bhagyashri_s has joined #openstack-oslo13:01
*** jokke__ has joined #openstack-oslo13:05
*** links has quit IRC13:05
*** lbragstad has joined #openstack-oslo13:06
*** zigo_ has joined #openstack-oslo13:08
*** shardy has joined #openstack-oslo13:08
*** eck`` has joined #openstack-oslo13:08
*** cburgess_ has joined #openstack-oslo13:09
*** bhagyashris has quit IRC13:11
*** openstackgerrit has quit IRC13:11
*** cburgess has quit IRC13:11
*** zigo has quit IRC13:11
*** eck` has quit IRC13:11
*** rybridges has quit IRC13:11
*** jokke_ has quit IRC13:11
*** rybridges has joined #openstack-oslo13:17
*** AlexeyAbashkin has joined #openstack-oslo13:28
*** yamamoto has quit IRC13:35
*** yamamoto has joined #openstack-oslo13:36
*** superdan is now known as dansmith13:40
*** bobh has joined #openstack-oslo13:49
*** janzian has joined #openstack-oslo13:51
*** lpetrut has joined #openstack-oslo13:51
*** openstackgerrit has joined #openstack-oslo13:53
openstackgerritMoisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver.  https://review.openstack.org/56274613:53
*** chhagarw has joined #openstack-oslo13:53
*** shardy has quit IRC13:55
*** spilla has joined #openstack-oslo13:57
*** chhagarw has quit IRC14:00
*** chhagarw has joined #openstack-oslo14:00
moguimardhellmann: Hi Doug, thanks for the feedback, I think I have addressed and/or answered all your comments by now.14:03
*** gyankum has quit IRC14:05
*** chhagarw has quit IRC14:06
*** bobh has quit IRC14:23
*** AlexeyAbashkin has quit IRC14:36
*** yamamoto has quit IRC14:37
*** eck`` is now known as eck`gone14:39
openstackgerritKen Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3  https://review.openstack.org/56660314:40
*** eck`gone is now known as eck`14:41
*** pblaho has quit IRC14:48
*** yamamoto has joined #openstack-oslo14:49
*** lpetrut has quit IRC14:50
*** yamamoto has quit IRC14:52
*** yamamoto has joined #openstack-oslo14:53
*** yamamoto has quit IRC14:58
*** beekneemech is now known as bnemec15:00
bnemec#startmeeting oslo15:00
openstackMeeting started Mon May  7 15:00:55 2018 UTC and is due to finish in 60 minutes.  The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
*** openstack changes topic to " (Meeting topic: oslo)"15:00
openstackThe meeting name has been set to 'oslo'15:01
bnemeccourtesy ping for amotoki, amrith, ansmith, bnemec, dansmith, dhellmann, dims15:01
bnemeccourtesy ping for dougwig, e0ne, electrocucaracha, flaper87, garyk, gcb, haypo15:01
bnemeccourtesy ping for jd__, johnsom, jungleboyj, kgiusti, kragniz, lhx_, raildo15:01
bnemeccourtesy ping for redrobot, sileht, spamaps, sreshetnyak, stephenfin, stevemar, therve15:01
bnemeccourtesy ping for thinrichs, toabctl, zhiyan, zxy, zzzeek15:01
e0nehi15:01
ansmitho/15:01
kgiustio/15:01
jungleboyjo/15:01
dhellmanno/15:03
bnemec#topic Red flags for/from liaisons15:03
*** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)"15:03
bnemecI'm not aware of anything from the Oslo side.15:04
bnemecSeems pretty quiet, so we'll move on.15:05
bnemec#topic Releases for Rocky15:05
*** openstack changes topic to "Releases for Rocky (Meeting topic: oslo)"15:05
jungleboyjNothing from Cinder.  :-)15:05
bnemecBusiness as usual, except for an extra oslo.policy release last week for the multiple input/output files change.15:06
smcginnis./15:06
vstinneri'm sorry to spam the meeting, but if you would like to be pay to maintain Oslo, Red Hat is looking for someone to replace me ;-) https://global-redhat.icims.com/jobs/63064/senior-software-engineer---openstack-oslo-project/job?hub=715:06
vstinnerbe paid*15:06
bnemec#link https://global-redhat.icims.com/jobs/63064/senior-software-engineer---openstack-oslo-project/job?hub=715:07
bnemecvstinner: No problem, that's good to advertise.15:08
bnemecWe can always use more contributors. :-)15:08
*** bobh has joined #openstack-oslo15:08
bnemec#topic Action items from last meeting15:08
*** openstack changes topic to "Action items from last meeting (Meeting topic: oslo)"15:08
bnemec"bnemec to release Oslo stable branches"15:09
bnemecNot done, but still on my list.15:09
*** pcaruana has quit IRC15:09
bnemecI wrapped up some significant non-Oslo work last week so I'm hoping to have a little more time this week.15:09
bnemec"kgiusti remove pip-check-reqs from tox.ini"15:09
bnemecI saw a bunch of patches.15:10
kgiustihttps://etherpad.openstack.org/p/pip_(missing|check)_reqs15:10
kgiustiI think we're all set from the Oslo perspective15:10
kgiustistephenfin and tosky have jumped in too15:10
bnemecCool15:10
bnemecoslo.versionedobjects has no assignee, is that an oversight?15:11
kgiusti? one sec15:11
kgiustiwhoopsie - missed that one15:11
kgiustiI'll hit that up today - good catch.15:12
bnemecThat's the good thing about having a list. :-)15:12
bnemeckgiusti: Thanks for taking care of this.15:12
kgiustiYep, so says my wife.15:12
bnemec:-)15:13
kgiustimy pleasure (removing code is so relaxing....)15:13
bnemec"kgiusti to do a recruiting drive" <- Any bites?15:13
kgiustiWell stephenfin and tosky bit.15:14
kgiustiBut nothing from the other affected projects.15:14
bnemecOkay.  Hopefully some of the folks doing the other cross-project cleanup changes will jump in at some point.15:16
kgiustiyep15:16
bnemecIt's practically free commits for anyone judged on those metrics. ;-)15:16
* bnemec dangles the carrot enticingly15:16
bnemec"investigate if anyone is using oslo.service wsgi module"15:17
bnemecI didn't get to this either.  oslo.service is still on my todo list too though.15:17
bnemecDefinitely need to get that cleaned up.15:17
*** bobh has quit IRC15:18
bnemecThat's it for action items from last meeting.15:18
bnemec#topic Vancouver project update15:18
*** openstack changes topic to "Vancouver project update (Meeting topic: oslo)"15:18
bnemecSo this starts in two weeks.15:18
bnemecIf you have anything you worked on in Queens that you'd like included in the presentation, please let me know.15:19
*** yamamoto has joined #openstack-oslo15:19
bnemecHopefully I'm aware enough of what's going on in Rocky to come up with the future list myself, but I'm happy to take reminders for that too.15:20
bnemecI need to get together with gcb and discuss too.  I know he wanted to be involved since he was PTL last cycle.15:20
bnemec#action bnemec to sync up with gcb about Vancouver project update15:20
bnemecI guess I should action the other part too.15:21
kgiustibnemec: did you have an epad for the topics you plan to cover?  gcb would make one available for review/feedback15:21
bnemec#action Oslo contributors to contact bnemec with any project updates they'd like included15:21
bnemeckgiusti: Ah, good idea.15:22
kgiustigcb's actually... But I'm happy to take credit! :)15:22
*** shardy has joined #openstack-oslo15:22
bnemecOkay, let's use this:15:23
bnemec#link https://etherpad.openstack.org/p/oslo-project-update-rocky15:23
kgiustithanks15:24
kgiustigot a link to the scheduled time slot?15:25
bnemecI believe it was Wednesday.  Let me find it again.15:26
bnemec#link https://www.openstack.org/summit/vancouver-2018/summit-schedule/events/21617/oslo-project-update15:26
* bnemec notes that he needs to update his OpenStack profile15:26
* bnemec also notes that his profile picture was taken in Vancouver the last time15:27
smcginnis:)15:27
bnemecAlso a reminder that we have an onboarding session on Tuesday.15:27
bnemec#link https://www.openstack.org/summit/vancouver-2018/summit-schedule/events/21645/oslo-project-onboarding15:27
bnemecOkay, I think that's it for this topic.  We can circle back next week and see where it stands.15:29
bnemec#topic Open discussion15:29
*** openstack changes topic to "Open discussion (Meeting topic: oslo)"15:29
*** vstinner has left #openstack-oslo15:29
bnemecI guess a couple of quick notes from me:15:30
bnemec1) I started to re-review the config migrator, but didn't quite get all the way through. Will finish it up this week.15:30
bnemec2) I saw some more updates on the config plugin side, haven't had a chance to look at those patches yet though.15:30
*** pbourke has quit IRC15:30
*** pbourke has joined #openstack-oslo15:32
bnemecOkay, sounds like that's it for this week.  Thanks for joining everyone.15:34
bnemec#endmeeting15:35
*** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo"15:35
openstackMeeting ended Mon May  7 15:35:01 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:35
openstackMinutes:        http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-05-07-15.00.html15:35
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-05-07-15.00.txt15:35
openstackLog:            http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-05-07-15.00.log.html15:35
jungleboyjThanks!15:35
dhellmannbnemec : as the release liaison, I can take those stable releases off your todo list if you want15:45
dhellmannsorry, we had a small dishwasher emergency just as the meeting started so I missed most of it15:46
bnemecdhellmann: Oops.  As long as it didn't turn into a big dishwasher emergency, I guess. :-)15:48
bnemecdhellmann: If you want to propose them that's fine with me.15:49
bnemecI'm not even sure how many are needed.15:49
bnemecWe don't do a ton of backports, but the stable branches haven't been released in months either, from what I can tell.15:49
dhellmannbnemec : no leaks, just a bad smell. We think some vinegar will fix it.15:49
* dhellmann crosses his fingers15:49
dhellmannyeah, let me run the report15:49
bnemecdhellmann: Ah, I would Lysol the heck out of it too.15:52
bnemecI had a small fridge emergency a few years ago and none of the smell removal stuff helped until I got it good and disinfected.15:52
dhellmannah, good to know15:52
dhellmannif this doesn't work, we'll bring out the lysol15:52
dhellmannit looks like we're ok for ocata (ci changes but no bug fixes) http://paste.openstack.org/show/720496/15:53
dhellmannfor pike it looks like we want to release oslo.versionedobjects: http://paste.openstack.org/show/720498/15:54
dhellmannfor queens I think we want oslo.concurrency, oslo.db, and oslo.versionedobjects15:56
dhellmannoh, maybe tooz15:56
*** yamamoto has quit IRC16:06
*** e0ne has quit IRC16:13
*** yamamoto has joined #openstack-oslo16:19
*** openstackgerrit has quit IRC16:19
*** lpetrut has joined #openstack-oslo16:20
*** finucannot is now known as stephenfin16:20
*** bobh has joined #openstack-oslo16:32
*** shardy has quit IRC16:33
*** bobh has quit IRC16:43
*** spilla has quit IRC16:46
*** yamamoto has quit IRC16:46
*** openstackgerrit has joined #openstack-oslo16:47
openstackgerritKen Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3  https://review.openstack.org/56660316:47
openstackgerritKen Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3  https://review.openstack.org/56660316:52
openstackgerritKen Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3  https://review.openstack.org/56660316:54
*** spilla has joined #openstack-oslo16:56
openstackgerritBen Nemec proposed openstack-dev/cookiecutter master: Add support for storyboard  https://review.openstack.org/48226216:57
bnemec^ is a pretty simple change that has been open a very long time16:58
*** yamamoto has joined #openstack-oslo16:59
bnemecI only rebased it.16:59
openstackgerritKen Giusti proposed openstack/oslo.versionedobjects master: Remove stale pip-missing-reqs tox test  https://review.openstack.org/56668417:04
*** jaosorior has quit IRC17:26
*** jaosorior has joined #openstack-oslo17:28
*** e0ne has joined #openstack-oslo17:35
*** bobh has joined #openstack-oslo17:37
jrollso I seem to remember oslo.log doing some automatic log sanitization, but I can't find it now, am I remembering wrong and we just have strutils.mask_password available to use when projects need it?17:39
*** yamamoto has quit IRC17:50
*** bobh has quit IRC18:12
*** mvenesio has joined #openstack-oslo18:18
*** yamamoto has joined #openstack-oslo18:25
*** dave-mccowan has quit IRC18:36
*** dave-mcc_ has joined #openstack-oslo18:36
*** yamamoto has quit IRC18:39
*** dave-mccowan has joined #openstack-oslo19:05
*** e0ne_ has joined #openstack-oslo19:07
*** dave-mcc_ has quit IRC19:07
*** e0ne has quit IRC19:11
smcginnisjroll: Are you thinking with config options? https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L32619:27
jrollsmcginnis: nah, mask_password used to be directly in the log module, and somehow I had it in my head that it ran on logging, I'm pretty sure I'm wrong now19:30
openstackgerritZane Bitter proposed openstack/oslo.service master: Python 3: Fix eventlet wakeup after signal  https://review.openstack.org/56671419:32
smcginnisjroll: I think you are right (about being wrong) :)19:32
smcginnisJust based on what I've seen.19:32
jrollheh, ok :)19:32
jrollthanks smcginnis19:32
*** yamamoto has joined #openstack-oslo19:39
*** yamamoto has quit IRC19:49
openstackgerritZane Bitter proposed openstack/oslo.service master: Python 3: Fix eventlet wakeup after signal  https://review.openstack.org/56671419:53
*** lpetrut has quit IRC19:54
*** spilla has quit IRC20:26
*** raildo has quit IRC20:26
*** mvenesio has quit IRC20:38
*** mvenesio has joined #openstack-oslo20:39
*** NobodyCam_ has joined #openstack-oslo20:46
*** kgiusti has left #openstack-oslo20:46
*** vdrok_ has joined #openstack-oslo20:47
*** knikolla_ has joined #openstack-oslo20:47
*** HenryG_ has joined #openstack-oslo20:47
*** szaher_ has joined #openstack-oslo20:48
*** janzian has quit IRC20:49
*** mvenesio has quit IRC20:53
*** NobodyCam has quit IRC20:53
*** vdrok has quit IRC20:53
*** knikolla has quit IRC20:53
*** HenryG has quit IRC20:53
*** szaher has quit IRC20:53
*** vdrok_ is now known as vdrok20:53
*** knikolla_ is now known as knikolla20:53
*** NobodyCam_ is now known as NobodyCam20:53
*** ansmith has quit IRC20:56
dhellmannjroll : it looks like oslo.concurrency uses mask_password before logging some commands it was running, and I think oslo.messaging does something similar before sending notifications21:01
dhellmannmaybe those are what you were thinking of (since there's a logging notifier)?21:02
openstackgerritMerged openstack/oslo.versionedobjects master: Remove stale pip-missing-reqs tox test  https://review.openstack.org/56668421:05
*** edmondsw has quit IRC21:15
*** edmondsw has joined #openstack-oslo21:15
lbragstaddoes anyone know if this is a known issue with oslo.config and python3? https://bugs.launchpad.net/keystone/+bug/176849821:17
openstackLaunchpad bug 1768498 in oslo.config "config generation(yaml/json) broken with python3" [Undecided,New]21:17
dhellmannlbragstad : my guess is that would fail on python 2 as well unless somehow the json module there knows how to turn a HostAddress into a string21:19
lbragstadinteresting21:19
dhellmannalthough the reporter says it does work on 2, so who knows21:19
lbragstadright... i was able to recreate it with python321:20
dhellmannoh "unhashable type"21:20
dhellmannthat's not the error I was thinking of21:20
dhellmannI don't know what a HostAddress is so I'm not sure why it can't be hased21:20
dhellmannhashed21:20
*** edmondsw has quit IRC21:20
lbragstadhttp://paste.openstack.org/raw/720521/ yeah - that's the full paste i have21:21
lbragstadah...21:21
lbragstadi think it's because keystone is using https://github.com/openstack/keystone/blob/ac9c0dc03492dc71398ccab6aafa8eb0d966c899/keystone/conf/eventlet_server.py#L5321:22
lbragstadhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L156721:23
dhellmannah, that code is expecting a class and it's getting an instance21:23
dhellmannHostAddressOpt sets the type to a HostAddress() instance with the version (v6 or v4 I presume)21:24
lbragstadahh21:24
dhellmannif you give the HostAddress type a type_name attribute that should fix it21:25
lbragstadis keystone using that option wrong then?21:25
dhellmannno, it's just that they aren't widely used and we haven't seen this before21:25
dhellmannprobably because no one uses the generator under python 3 :-)21:26
lbragstadprobably21:26
dhellmannI don't know why the class is not hashable21:26
dhellmannit doesn't define a __hash__ method but it shouldn't have to21:26
dhellmannyou could make type_name a property method and fill in the version number21:27
lbragstadyeah - and other things subclass Opt, so nothing about HostAddressOpt looks out of the ordinary compared to the rest of the module21:27
dhellmannso we'd get "ipv4 address" or "ipv6 address"21:27
openstackgerritVipin Balachandran proposed openstack/oslo.vmware master: Refactor _start_transfer  https://review.openstack.org/56674321:28
lbragstadjudging by the example and default, we're assuming an ipv4 address21:28
dhellmannright, but the HostAddress class doesn't make that assumption21:28
dhellmannthat's the class in oslo.config that needs to be updated21:29
openstackgerritVipin Balachandran proposed openstack/oslo.vmware master: Refactor _start_transfer  https://review.openstack.org/56674321:29
dhellmannwe should probably have tests that verify all of our option types can be formatted properly21:30
lbragstadit looks like it defaults to a dummy string? https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L82121:31
lbragstadbut would expect a real ipv4 or ipv6 address when calling out to netaddr21:32
dhellmannlbragstad : but that value isn't being stored anywhere21:32
dhellmannwell, not in a valid way21:32
dhellmannit goes into the ip_address field but nothing looks for it there21:32
lbragstadhmm21:34
dhellmannI'm not sure why it's being passed to that class21:35
lbragstadit looks like  the version checking bits in IPAddress are storing boolean values?21:35
lbragstadbased on the naming of the variables?21:35
dhellmannIPAddress needs the value when it is used directly, but nothing about HostAddress does anything to pull the value out21:36
dhellmannI'm not sure what you mean by "the version checking bits"21:36
lbragstadhttps://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L709-L71521:36
lbragstadi was trying to parse that and figure out what it was doing21:37
dhellmannthat's a switch statement to decide which check method to use based on the version21:37
dhellmannsee line 71721:37
dhellmannthe whitespace in this code is confusing21:37
dhellmannoh!21:38
dhellmannthe base class for HostAddress is not being initialized21:38
dhellmannthat's the real issue21:38
dhellmannif that was in place, passing type_name down to it would resolve the problem21:38
lbragstadahhh21:39
dhellmannbut since it's not being initialized we don't even have a default21:39
dhellmannlbragstad : do you want to propose the fix so I can +2, or do you want me to do it and then we can train you up to be core on this library so you can +2 it?21:39
lbragstadoh - so self.version_checker isn't actually initialized?21:40
dhellmannHostAddress isn't derived from IPAddress, it contains one21:40
dhellmannHostAddress is derived directly from ConfigType, and does not initialize ConfigType in it's __init__21:40
dhellmannso around line 825 we need a super() call to do the rest of the initialization21:41
lbragstadoh!21:41
dhellmannthere's probably some other stuff we could clean up in there (__repr__ looks odd, as does __eq__)21:42
dhellmannbut one bug at a time21:43
openstackgerritVipin Balachandran proposed openstack/oslo.vmware master: Fix session re-establish failure with PBM APIs  https://review.openstack.org/56674621:44
lbragstaddoing some tests locally quick21:44
openstackgerritLance Bragstad proposed openstack/oslo.config master: WIP: Properly initialize HostAddress  https://review.openstack.org/56674821:46
lbragstadso - that fixes it for me locally when i install that with keystone21:47
lbragstadbut, i might need an idea on how to test it properly21:47
dhellmannyep, that's what I expect21:47
dhellmann(the fix that is)21:47
dhellmannfor testing, let me think21:47
dhellmannI wonder if you could instantiate an _OptFormatter() and ask it to format the help for 1 HostAddressOpt21:48
dhellmannit looks like that takes a writable stream as an argument, so you could use a StringIO21:48
dhellmannif you set up one test class with 1 method doing that, then we can extend it later with other types21:49
dhellmannwe could even file that as a low-hanging-fruit bug for a new contributor21:49
*** ansmith has joined #openstack-oslo21:49
*** e0ne_ has quit IRC21:50
lbragstad+++21:50
*** dave-mccowan has quit IRC22:01
dhellmannalright, that's enough for one day for me22:01
openstackgerritLance Bragstad proposed openstack/oslo.config master: Properly initialize HostAddress  https://review.openstack.org/56674822:05
lbragstaddhellmann: ^ really rough test.. but it recreates the unhashable type error22:05
dhellmannlbragstad : you caught me lingering, so I left 2 comments, but now I'm really going to see about dinner22:07
lbragstad#thanks dhellmann for helping fix a python3 bug with keystone config generation22:07
lbragstado/22:07
openstackstatuslbragstad: Added your thanks to Thanks page (https://wiki.openstack.org/wiki/Thanks)22:07
openstackgerritVipin Balachandran proposed openstack/oslo.vmware master: Fix session re-establish failure with PBM APIs  https://review.openstack.org/56674622:16
openstackgerritLance Bragstad proposed openstack/oslo.config master: Properly initialize HostAddress  https://review.openstack.org/56674822:21
*** rcernin has joined #openstack-oslo22:25
*** dave-mccowan has joined #openstack-oslo22:55
-openstackstatus- NOTICE: Any devstack job failure due to rsync errors related to tripleo-incubator can safely be rechecked now22:57
*** pooja_jadhav has quit IRC23:28
*** pooja_jadhav has joined #openstack-oslo23:28
*** shardy has joined #openstack-oslo23:45
*** shardy has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!