| *** k-s-dean has quit IRC | 00:01 | |
| *** mlavalle has quit IRC | 00:03 | |
| *** k_mouza has joined #openstack-nova | 00:05 | |
| *** vishalmanchanda has quit IRC | 00:09 | |
| *** k_mouza has quit IRC | 00:09 | |
| *** tosky has quit IRC | 00:14 | |
| brinzhang_ | bauzas: can you re recheck the bug 1917592's fix? https://review.opendev.org/c/openstack/nova/+/778440 | 00:19 |
|---|---|---|
| openstack | bug 1917592 in OpenStack Compute (nova) "Missed 'accel_uuids' when we the 'shelved_offload_time' time out in shelving instance periodic task" [Medium,In progress] https://launchpad.net/bugs/1917592 - Assigned to Brin Zhang (zhangbailin) | 00:19 |
| *** openstackgerrit has joined #openstack-nova | 00:25 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/c/openstack/nova/+/749052 | 00:25 |
| *** songwenping__ has joined #openstack-nova | 00:26 | |
| *** songwenping_ has quit IRC | 00:29 | |
| *** penick has joined #openstack-nova | 00:34 | |
| *** sapd1 has quit IRC | 00:37 | |
| *** penick has quit IRC | 00:59 | |
| *** penick has joined #openstack-nova | 01:00 | |
| *** k-s-dean has joined #openstack-nova | 01:03 | |
| *** penick has quit IRC | 01:05 | |
| *** zzzeek has quit IRC | 01:16 | |
| *** zzzeek has joined #openstack-nova | 01:17 | |
| *** jamesdenton has quit IRC | 01:34 | |
| *** jamesden_ has joined #openstack-nova | 01:35 | |
| *** hamalq has quit IRC | 01:39 | |
| *** k-s-dean has quit IRC | 01:43 | |
| *** lbragstad has quit IRC | 02:06 | |
| *** zzzeek has quit IRC | 02:52 | |
| *** songwenping_ has joined #openstack-nova | 02:53 | |
| *** zzzeek has joined #openstack-nova | 02:55 | |
| *** hemanth_n has joined #openstack-nova | 02:57 | |
| *** songwenping__ has quit IRC | 02:57 | |
| *** rcernin has quit IRC | 03:16 | |
| *** songwenping__ has joined #openstack-nova | 03:23 | |
| *** songwenping_ has quit IRC | 03:26 | |
| openstackgerrit | Merged openstack/nova stable/train: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758733 | 03:31 |
| *** psachin has joined #openstack-nova | 03:32 | |
| *** rcernin has joined #openstack-nova | 03:37 | |
| *** hemanth_n has quit IRC | 03:37 | |
| *** hemanth_n has joined #openstack-nova | 03:38 | |
| *** rcernin has quit IRC | 03:39 | |
| *** rcernin has joined #openstack-nova | 03:39 | |
| *** vishalmanchanda has joined #openstack-nova | 04:16 | |
| openstackgerrit | Rico Lin proposed openstack/nova master: [TEST][ARM64]Revert "libvirt: Add parsing of firmware metadata files" https://review.opendev.org/c/openstack/nova/+/781210 | 04:19 |
| *** jamesden_ has quit IRC | 04:24 | |
| *** jamesdenton has joined #openstack-nova | 04:24 | |
| *** penick has joined #openstack-nova | 04:35 | |
| *** gyee has quit IRC | 04:44 | |
| *** macz_ has joined #openstack-nova | 04:45 | |
| *** mkrai has joined #openstack-nova | 04:46 | |
| *** ratailor has joined #openstack-nova | 04:47 | |
| *** macz_ has quit IRC | 04:50 | |
| *** jamesdenton has quit IRC | 05:09 | |
| *** jamesdenton has joined #openstack-nova | 05:10 | |
| *** penick has quit IRC | 05:24 | |
| *** penick has joined #openstack-nova | 05:27 | |
| *** penick has quit IRC | 05:38 | |
| *** xinranwang has joined #openstack-nova | 05:41 | |
| openstackgerrit | Josephine Seifert proposed openstack/nova stable/victoria: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/781211 | 06:04 |
| *** Luzi has joined #openstack-nova | 06:04 | |
| *** khomesh24 has joined #openstack-nova | 06:23 | |
| *** khomesh24 has quit IRC | 06:29 | |
| *** elod is now known as elod_afk | 06:31 | |
| *** khomesh24 has joined #openstack-nova | 06:32 | |
| *** lpetrut has joined #openstack-nova | 06:42 | |
| *** links has joined #openstack-nova | 06:45 | |
| *** LinPeiWen has quit IRC | 07:08 | |
| *** LinPeiWen80 has joined #openstack-nova | 07:10 | |
| *** macz_ has joined #openstack-nova | 07:11 | |
| *** mkrai has quit IRC | 07:15 | |
| *** mkrai_ has joined #openstack-nova | 07:15 | |
| *** macz_ has quit IRC | 07:16 | |
| *** dklyle has quit IRC | 07:35 | |
| *** rcernin has quit IRC | 07:43 | |
| *** xinranwang has quit IRC | 07:51 | |
| *** brinzhang0 has joined #openstack-nova | 07:59 | |
| *** brinzhang_ has quit IRC | 08:01 | |
| *** k-s-dean has joined #openstack-nova | 08:03 | |
| *** mkrai_ has quit IRC | 08:07 | |
| *** macz_ has joined #openstack-nova | 08:11 | |
| *** macz_ has quit IRC | 08:16 | |
| *** zzzeek has quit IRC | 08:19 | |
| *** zzzeek has joined #openstack-nova | 08:21 | |
| *** mkrai has joined #openstack-nova | 08:22 | |
| *** rpittau|afk is now known as rpittau | 08:24 | |
| *** rcernin has joined #openstack-nova | 08:28 | |
| *** tesseract has joined #openstack-nova | 08:31 | |
| *** rcernin has quit IRC | 08:35 | |
| *** whoami-rajat_ has joined #openstack-nova | 08:36 | |
| *** whoami-rajat_ is now known as whoami-rajat | 08:44 | |
| lyarwood | gibi: so I managed to get out of dad taxi duty this morning when you're able to talk about the detach series | 08:45 |
| gibi | lyarwood: I've just replied to some of your comments in the series | 08:47 |
| gibi | lyarwood: so we can talk | 08:47 |
| gibi | I see you point about not raise when device is not in the live domain but try the detach from the persistent domain | 08:48 |
| *** elod_afk is now known as elod | 08:48 | |
| *** andrewbonney has joined #openstack-nova | 08:51 | |
| lyarwood | gibi: yeah it's just handles corner cases where things are in a weird state when a caller retries the detach | 08:52 |
| lyarwood | gibi: not attached to the live but still in the persistent somehow | 08:52 |
| *** tosky has joined #openstack-nova | 08:54 | |
| *** zzzeek has quit IRC | 08:55 | |
| gibi | lyarwood: give me 20 mins and I can make a proper conversation... | 08:56 |
| *** zzzeek has joined #openstack-nova | 08:57 | |
| lyarwood | gibi: yeah np I'll reply in the review | 08:57 |
| *** tesseract has quit IRC | 09:00 | |
| *** tesseract has joined #openstack-nova | 09:02 | |
| *** lucasagomes has joined #openstack-nova | 09:05 | |
| bauzas | brinzhang0: sure, will review https://review.opendev.org/c/openstack/nova/+/778440 | 09:06 |
| bauzas | as it's an important bugfix for Wallaby | 09:06 |
| brinzhang0 | bauzas: thanks | 09:06 |
| bauzas | brinzhang0: actually, can you please rebase it above https://review.opendev.org/c/openstack/nova/+/761452 ? | 09:06 |
| brinzhang0 | It seems not impact for your patch, right? | 09:08 |
| bauzas | brinzhang0: nevermind, I'll +W your patch and then I'll rebase my one | 09:09 |
| *** rcernin has joined #openstack-nova | 09:10 | |
| brinzhang0 | bauzas: thanks, there are not order ^ | 09:10 |
| bauzas | brinzhang0: unfortunately, yes | 09:10 |
| *** rcernin has quit IRC | 09:10 | |
| bauzas | see the merge conflicts | 09:10 |
| bauzas | but I'll rebase my patch | 09:10 |
| *** rcernin has joined #openstack-nova | 09:10 | |
| brinzhang0 | bauzas: thanks, may conflict the test case in compute_mgr | 09:11 |
| *** macz_ has joined #openstack-nova | 09:14 | |
| *** macz_ has quit IRC | 09:19 | |
| *** rcernin has quit IRC | 09:20 | |
| lucasagomes | hi, could somebody take a look at https://review.opendev.org/c/openstack/nova/+/776419, https://review.opendev.org/c/openstack/nova/+/776944 and https://review.opendev.org/c/openstack/nova/+/776934 ? | 09:22 |
| lucasagomes | they r small patches towards enabling OVN to be the default backend in DevStack at the beggining of the next release cycle | 09:22 |
| gibi | lyarwood: thanks for the reply. Is there anything else that I need to think about in the detach series? | 09:22 |
| lucasagomes | it makes sure the nova gate won't break once we flip it | 09:23 |
| *** ociuhandu has joined #openstack-nova | 09:26 | |
| *** derekh has joined #openstack-nova | 09:26 | |
| nautik | gibi: Hi! Following our chat the other day, I pushed the blueprint https://blueprints.launchpad.net/nova/+spec/allow-special-characters-in-keypair-name along with the merge request https://review.opendev.org/c/openstack/nova/+/781076 | 09:28 |
| *** rcernin has joined #openstack-nova | 09:29 | |
| nautik | gibi: reviews and comments are welcome, first time doing this and not yet so-much familiar with nova code; don't hesitate to tell me if you see missing tests for example | 09:29 |
| gibi | nautik: thanks | 09:31 |
| *** macz_ has joined #openstack-nova | 09:35 | |
| gibi | gmann, stephenfin, bauzas: can we extend accepted charachter set of keypair names without microversion? | 09:38 |
| gibi | see the bp above | 09:38 |
| gibi | the API ref and the json validation code in nova does not restrict a charset for the name but we have some custom code that rejectes @ for example | 09:39 |
| *** macz_ has quit IRC | 09:39 | |
| gibi | the custom check is You specified more local devices than the limit allows | 09:40 |
| gibi | sorry | 09:40 |
| gibi | the custom check is https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993 | 09:40 |
| gibi | strictly speaking there everyting that worked before will work after we extend the charset so we are not breaking existing clients | 09:43 |
| bauzas | gibi: looking | 09:43 |
| gibi | except for those clients that relied on getting http 400 with keypair names containing @ for example | 09:44 |
| bauzas | gibi: well, in between clouds, this would change, right? | 09:44 |
| bauzas | as a user, how could I know I could use specific chars ? | 09:44 |
| gibi | bauzas: yes, so for discoverability it would need a new microversion | 09:44 |
| bauzas | for interop, yes | 09:45 |
| bauzas | because when I'm creating my keypair, I want to make sure this works | 09:45 |
| bauzas | i could have scripts for creating such keypairs | 09:45 |
| gibi | today you have scripts to create keypairs without @ as @ is not allowed | 09:46 |
| bauzas | also, does the DB accept this, btw ? | 09:46 |
| gibi | this script will work in the future too | 09:46 |
| gibi | bauzas: good question about the db | 09:46 |
| gibi | looking | 09:46 |
| gibi | name = Column(String(255), nullable=False) | 09:46 |
| gibi | db will accept it | 09:46 |
| bauzas | so it's purely an API restriction ? | 09:47 |
| gibi | the thing that will not work is a script that relies on this proposed change using @ in the names, towards a cloud that does not have this change | 09:47 |
| bauzas | what this blueprint is trying to fix ? | 09:47 |
| *** ociuhandu has quit IRC | 09:47 | |
| bauzas | ah I see | 09:47 |
| bauzas | the arobase case | 09:47 |
| bauzas | and the dot one | 09:47 |
| gibi | it is common to have an email address or a domain name in the keypair name | 09:48 |
| bauzas | I see people wanting to use email adresses as keypair names :p | 09:48 |
| *** mkrai has quit IRC | 09:48 | |
| bauzas | that, after the instance name... | 09:48 |
| Corwin | bauzas: usually a public key will have a comment in the form of user@hostname | 09:48 |
| Corwin | and hostname can be a fqdn, with dots in it | 09:49 |
| bauzas | Corwin: you're working on clouds | 09:49 |
| bauzas | so users don't know the hosts | 09:49 |
| bauzas | this is irrelevant from this perspective | 09:49 |
| bauzas | hence the string | 09:49 |
| bauzas | and my ssh keynames don't have an arobase :) | 09:50 |
| Corwin | what I'm saying is that a lot of users will generate keypairs and name those after the comment in the public key | 09:50 |
| Corwin | or at least would want to | 09:50 |
| gibi | like when I upload my key to gerrit it also names after the comment | 09:51 |
| Corwin | github does this too | 09:51 |
| bauzas | for knowing where you created the key ? | 09:51 |
| bauzas | and from which user ? | 09:51 |
| *** ociuhandu has joined #openstack-nova | 09:51 | |
| Corwin | yes, it's the default behavior of a lot of services to pre-fill the name from the comment | 09:52 |
| bauzas | this comment comes from the fact ssh-keygen stupidely writes who created the key and where | 09:52 |
| bauzas | but that's stale information | 09:52 |
| bauzas | as you can create the key elsewhere and just use it for other things | 09:53 |
| Corwin | I know, but it doesn't really matter | 09:53 |
| bauzas | Corwin: you recognize that identifying a public key doesn't rely on matching the comment ? | 09:53 |
| Corwin | there is no reason to disable those characters though | 09:53 |
| bauzas | but rather on matching the key itself | 09:53 |
| Corwin | bauzas: I know how ssh works thanks | 09:54 |
| bauzas | as I could have N keys created with the same comment | 09:54 |
| gibi | bauzas: the machine protocol use the key itself but humans are bad at matching long strings by eye | 09:54 |
| bauzas | Corwin: sure, I'm just pointing that you could end up having multiple keys in Nova that would share the same name | 09:54 |
| bauzas | which doesn't help | 09:54 |
| Corwin | that would happen also without authorizing those 2 characters, it's still user input | 09:55 |
| bauzas | either way, we're digressing, I agree | 09:55 |
| bauzas | the question is not about the use case | 09:55 |
| bauzas | but whether this sounds interoperable | 09:55 |
| bauzas | and my guts tell me it's not so we need a microversion | 09:56 |
| Corwin | yep I think it would be better with a new microversion | 09:56 |
| gibi | OK I can accept the reasoning that the end user should know if the cloud support @ in the name and the way to publis that informatin is via the /version endpoint telling the max supported microversion | 09:57 |
| Corwin | a script should always work on one microversion regardless of the service provider | 09:57 |
| bauzas | gibi: I guess we unique index the keynames ? | 09:58 |
| bauzas | (I'm lazy and you already opened the code :p ) | 09:58 |
| gibi | __table_args__ = ( | 09:58 |
| gibi | schema.UniqueConstraint("user_id", "name", "deleted", | 09:58 |
| gibi | name="uniq_key_pairs0user_id0name0deleted"), | 09:58 |
| gibi | ) | 09:58 |
| bauzas | that will be fun | 09:58 |
| gibi | so yes | 09:58 |
| gibi | per user | 09:58 |
| bauzas | "I don't understand why Nova isn't accepting my keyname, boo" | 09:59 |
| gibi | bauzas: it is already like that | 09:59 |
| bauzas | I know | 09:59 |
| gibi | we dont change the uniqueness constraint | 09:59 |
| bauzas | but users had to name it explicitely | 09:59 |
| Corwin | that doesn't change | 09:59 |
| bauzas | here, we will open a way to automatically use the comment for creating the keypair | 09:59 |
| bauzas | but, heh | 09:59 |
| gibi | we allow more flexibility yes, but not ultimate flexibility | 10:00 |
| Corwin | that's a issue for the service provider, not nova | 10:00 |
| bauzas | sure | 10:00 |
| bauzas | provided we don't have some folks asking to automatically create the keypair by looking up the public key :) | 10:01 |
| gibi | that would be a separate bp :) | 10:01 |
| bauzas | oh sure and my -1 to it | 10:01 |
| *** rcernin has quit IRC | 10:01 | |
| *** ricolin has quit IRC | 10:01 | |
| bauzas | either way, looks like we're in violent agreement | 10:02 |
| gibi | nautik: so based on the above discussion your change will need a new API microversion | 10:02 |
| gibi | nautik: let me link to some documentation about it | 10:02 |
| gibi | nautik: and that also means you need to file a small specification document in the nova-specs repo | 10:02 |
| nautik | gibi: ok sure | 10:03 |
| gibi | bauzas: Corwin: thanks! | 10:03 |
| *** rcernin has joined #openstack-nova | 10:04 | |
| gibi | nautik: __table_args__ = ( | 10:04 |
| gibi | schema.UniqueConstraint("user_id", "name", "deleted", | 10:04 |
| gibi | name="uniq_key_pairs0user_id0name0deleted"), | 10:04 |
| gibi | ) | 10:04 |
| gibi | sorry | 10:04 |
| * gibi hates copy paste buffers | 10:04 | |
| gibi | nautik: https://docs.openstack.org/nova/latest/contributor/blueprints.html | 10:04 |
| bauzas | gibi: this could have been getting way worst :p | 10:04 |
| gibi | bauzas: yeah I know | 10:05 |
| *** lewo has joined #openstack-nova | 10:05 | |
| gibi | nautik: https://opendev.org/openstack/nova-specs/src/branch/master/specs/wallaby-template.rst | 10:05 |
| gibi | this is the spec template | 10:06 |
| gibi | bauzas: could you hit this patch creating the xena spec directory and template? https://review.opendev.org/c/openstack/nova-specs/+/772878 | 10:07 |
| gibi | nautik: after ^^ merges, there will be a directory for the xena specs | 10:07 |
| gibi | nautik: this helps about how to add a new microversion to nova https://docs.openstack.org/nova/latest/contributor/microversions.html | 10:08 |
| bauzas | gibi: /me clicks | 10:09 |
| nautik | gibi: thank you, will check this asap :) | 10:09 |
| gibi | nautik: if you get stuck with the spec template or hte implementation just ask here and we will help | 10:10 |
| gibi | once the spec is up on review you can ping me and bauzas to take a look | 10:10 |
| nautik | will do | 10:11 |
| bauzas | yup | 10:11 |
| openstackgerrit | Merged openstack/nova-specs master: Create specs directory for Xena https://review.opendev.org/c/openstack/nova-specs/+/772878 | 10:20 |
| *** rcernin has quit IRC | 10:24 | |
| lyarwood | gibi: sorry ssh dropped without me noticing, I don't think there was anything else, tbh my reason for chatting with you was to ensure you were still okay pushing it through ahead of rc | 10:30 |
| *** k_mouza has joined #openstack-nova | 10:30 | |
| *** Underknowledge has quit IRC | 10:31 | |
| *** Underknowledge1 has joined #openstack-nova | 10:31 | |
| gibi | lyarwood: if I get the time to fix up the thing then yes | 10:31 |
| gibi | lyarwood: it is a bit risk change though | 10:31 |
| gibi | lyarwood: so I could also accept if we wait until after the release | 10:31 |
| *** Underknowledge1 is now known as Underknowledge | 10:32 | |
| lyarwood | gibi: yeah it's really your call as author and PTL, we could backport it in the future once proven to work in X I guess? | 10:39 |
| gibi | lyarwood: how risky this change looks from your perspective? | 10:40 |
| lyarwood | gibi: on the face of it, not very risky but then we are so close to rc that I'm not sure it's worth any risk at the moment | 10:41 |
| lyarwood | gibi: given the alternative to wait until Xena opens up and we then have ~6 months to verify things | 10:42 |
| gibi | I think the backport from early Xena to W will be easy, backporting further could be harder | 10:43 |
| lyarwood | it's tough, I really want this rework but at the same time I don't want us to bork things just before the release | 10:43 |
| *** ociuhandu has quit IRC | 10:44 | |
| lyarwood | with my downstream hat on an upstream backport just to Wallaby would be awesome | 10:44 |
| lyarwood | additional backports would also be nice but that's something I can take on | 10:44 |
| lyarwood | if it's even possible obviously | 10:44 |
| gibi | OK, lets see if I can have time for finishing up the series today | 10:45 |
| lyarwood | gibi: sorry I thought we had talked ourselves into delaying until X | 10:46 |
| lyarwood | gibi: but I guess if you have time now we can get it ready ahead of that, but don't burn yourself with it if you have other more pressing work. | 10:47 |
| *** jraju__ has joined #openstack-nova | 10:47 | |
| *** links has quit IRC | 10:47 | |
| *** rcernin has joined #openstack-nova | 10:48 | |
| gibi | lyarwood: I lean towards delaying but if I have time I will make progress | 10:48 |
| *** ociuhandu has joined #openstack-nova | 10:50 | |
| *** dtantsur|afk is now known as dtantsur | 10:52 | |
| *** k_mouza has quit IRC | 11:12 | |
| *** ociuhandu has quit IRC | 11:25 | |
| *** k_mouza has joined #openstack-nova | 11:27 | |
| *** tesseract has quit IRC | 11:29 | |
| *** tesseract has joined #openstack-nova | 11:31 | |
| *** priteau has joined #openstack-nova | 11:38 | |
| *** rcernin has quit IRC | 11:39 | |
| *** rcernin has joined #openstack-nova | 11:41 | |
| *** k-s-dean has quit IRC | 11:42 | |
| *** kd has joined #openstack-nova | 11:42 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject requests to commit intermediary snapshot of an inactive instance https://review.opendev.org/c/openstack/nova/+/781138 | 11:43 |
| *** rcernin has quit IRC | 11:46 | |
| *** hemanth_n has quit IRC | 11:59 | |
| *** rcernin has joined #openstack-nova | 12:04 | |
| *** rcernin has quit IRC | 12:09 | |
| *** lbragstad has joined #openstack-nova | 12:22 | |
| *** tbachman has quit IRC | 12:22 | |
| *** tbachman has joined #openstack-nova | 12:23 | |
| *** rcernin has joined #openstack-nova | 12:41 | |
| *** macz_ has joined #openstack-nova | 12:43 | |
| *** rcernin has quit IRC | 12:46 | |
| *** macz_ has quit IRC | 12:48 | |
| *** jraju__ has quit IRC | 12:55 | |
| *** links has joined #openstack-nova | 13:03 | |
| *** links has quit IRC | 13:09 | |
| *** tbachman_ has joined #openstack-nova | 13:13 | |
| *** rcernin has joined #openstack-nova | 13:14 | |
| *** tbachman has quit IRC | 13:15 | |
| *** tbachman_ is now known as tbachman | 13:15 | |
| *** martinkennelly has joined #openstack-nova | 13:21 | |
| *** macz_ has joined #openstack-nova | 13:25 | |
| *** lucasagomes_ has joined #openstack-nova | 13:25 | |
| *** lbragstad_ has joined #openstack-nova | 13:25 | |
| *** k-s-dean has joined #openstack-nova | 13:26 | |
| *** janno_ has joined #openstack-nova | 13:28 | |
| *** macz_ has quit IRC | 13:29 | |
| *** brinzhang0 has quit IRC | 13:30 | |
| *** brinzhang0 has joined #openstack-nova | 13:31 | |
| *** ratailor has quit IRC | 13:31 | |
| *** lbragstad has quit IRC | 13:33 | |
| *** kd has quit IRC | 13:33 | |
| *** derekh has quit IRC | 13:33 | |
| *** lucasagomes has quit IRC | 13:33 | |
| *** zzzeek has quit IRC | 13:33 | |
| *** irclogbot_0 has quit IRC | 13:33 | |
| *** openstackgerrit has quit IRC | 13:33 | |
| *** janno has quit IRC | 13:34 | |
| *** irclogbot_0 has joined #openstack-nova | 13:36 | |
| *** jamesdenton has quit IRC | 13:36 | |
| *** purplerbot has quit IRC | 13:36 | |
| *** jamesdenton has joined #openstack-nova | 13:39 | |
| *** purplerbot has joined #openstack-nova | 13:44 | |
| gmann | gibi: bauzas stephenfin yes, this is changing 400->200 which break interopability and cross cloud migration., hence need microversion bump. | 13:55 |
| *** mlavalle has joined #openstack-nova | 13:58 | |
| *** jmlowe has quit IRC | 14:00 | |
| *** jmlowe has joined #openstack-nova | 14:03 | |
| *** lucasagomes_ is now known as lucasagomes | 14:04 | |
| *** ociuhandu has joined #openstack-nova | 14:10 | |
| kashyap | Gerrit bot is down? | 14:11 |
| *** jobewan has quit IRC | 14:12 | |
| kashyap | stephenfin: For later, since you asked so nicely on the original review: https://review.opendev.org/c/openstack/nova/+/781725 | 14:12 |
| stephenfin | ack | 14:12 |
| *** ociuhandu has quit IRC | 14:13 | |
| gibi | gmann: ack | 14:14 |
| *** ociuhandu has joined #openstack-nova | 14:14 | |
| stephenfin | Oh, this is fun https://review.opendev.org/c/openstack/nova/+/781210 | 14:23 |
| stephenfin | So we broke the Aarch64 CI, but I have no idea how | 14:23 |
| *** ociuhandu has quit IRC | 14:23 | |
| stephenfin | Hopefully ricolin will get back to us on that | 14:23 |
| stephenfin | I suspect the metadata files are missing for some reason | 14:24 |
| stephenfin | kashyap: FYI ^ | 14:24 |
| * kashyap clicks | 14:24 | |
| kashyap | stephenfin: Yeah, I don't have an AArch64 box; but 'hrw' (not here on IRC right now) did talk about AArch64 failures | 14:25 |
| kashyap | So I hope indeed ricolin gets back w/ more precise details of the nature of the failure | 14:25 |
| *** viks____ has joined #openstack-nova | 14:26 | |
| kashyap | stephenfin: BTW, aside: upstream libvirt began implementing your RFE. I was reviewing bits of this series: https://listman.redhat.com/archives/libvir-list/2021-March/msg00922.html | 14:28 |
| kashyap | (About firmware auto-selection) | 14:28 |
| stephenfin | aha, very good | 14:28 |
| stephenfin | if you're following that, some WIP patches for nova that implement the libvirt feature would be helpful to make sure we don't forget | 14:29 |
| *** ociuhandu has joined #openstack-nova | 14:29 | |
| kashyap | stephenfin: Yeah, but it still needs some more review. And I noticed a potential confusion in my review earlier today: https://listman.redhat.com/archives/libvir-list/2021-March/msg00982.html | 14:29 |
| jkulik | Any idea why `osc-placement` doesn't include versions after 1.28? | 14:29 |
| kashyap | stephenfin: But I agree | 14:30 |
| stephenfin | jkulik: Is there a version after 1.28 | 14:30 |
| stephenfin | ? | 14:30 |
| stephenfin | Genuine question :) | 14:30 |
| stephenfin | If there is, I suspect we simply haven't added it | 14:30 |
| jkulik | 1.28 was added for ussuri. 1.29 is supported in rocky ... O.o | 14:31 |
| jkulik | https://github.com/openstack/osc-placement/blob/master/osc_placement/version.py#L41 | 14:31 |
| jkulik | I cannot run "os --os-placement-api-version 1.30 allocation candidate list" because it only knows how to do versions 1.28 and below ... | 14:32 |
| jkulik | placement version 1.30 is not in supported versions: 1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 1.9, 1.10, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16, 1.17, 1.18, 1.19, 1.20, 1.21, 1.22, 1.28, 1.29 | 14:32 |
| stephenfin | In that case, I assume it's just a case that people haven't done it | 14:33 |
| jkulik | so no allocation requests with providers in trees with osc-placement | 14:33 |
| stephenfin | Due to lack of impetus | 14:33 |
| jkulik | hm ... makes sense. no real reason, then :D | 14:33 |
| *** ociuhandu has quit IRC | 14:34 | |
| jkulik | Is there any objection against always supporting the latest version available in placement? | 14:34 |
| viks____ | Hi, When a new instance is created, nova sets a random password. But this password does work. So how to make this work? I know a method where we set with `nova set-password` command and qemu agent running on instances, but then what is the use of the random password generated during instance creation? | 14:34 |
| gibi | jkulik: no objection. If pathces are proposed against osc-placement to add support for the newer versions then please ping me and I will try to review them | 14:34 |
| viks____ | Also if we rescue instance, it asks to set a password, but that also does not work? how to make rescue password work? | 14:34 |
| stephenfin | jkulik: I can't think of one, no | 14:34 |
| stephenfin | We probably have just been forgetting to bump things like we do in novaclient | 14:35 |
| jkulik | ok. I'll propose a patch for the latest versions. | 14:35 |
| stephenfin | jkulik: With that said, adding e.g. 1.29 to that list doesn't really do anything new | 14:35 |
| stephenfin | Unless you implement the functionality of that microversion | 14:35 |
| jkulik | stephenfin: it actually does | 14:36 |
| jkulik | it allows me to query allocation candidates that are in trees | 14:36 |
| jkulik | before, I don't get anything returned. with 1.29, I get the providers like I got on queens btw. | 14:36 |
| stephenfin | Doesn't that require changes to the client? | 14:36 |
| stephenfin | I assume the output from the server is different? | 14:36 |
| * stephenfin apologizes for not having loaded up on context on this yet | 14:37 | |
| jkulik | hm ... looks the same to me. we still have queens around and I compared the output right now. | 14:37 |
| jkulik | having the rocky code-base and an api-version below 1.29 returns nothing anymore. | 14:37 |
| jkulik | https://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers | 14:39 |
| *** ociuhandu has joined #openstack-nova | 14:40 | |
| jkulik | we could™ extend osc-placement to show the new "parent_provider_uuid" and "root_provider_uuid" | 14:40 |
| gibi | jkulik: I think you are correct. the two new things is are those^^ attributesd in the a_c response | 14:43 |
| gibi | the rest is just logic change in the placement server | 14:43 |
| gibi | but no structural change in the input or output | 14:43 |
| *** ociuhandu has quit IRC | 14:44 | |
| *** khomesh24 has quit IRC | 14:45 | |
| *** khomesh24 has joined #openstack-nova | 14:45 | |
| jkulik | gibi, stephenfin https://review.opendev.org/c/openstack/osc-placement/+/781749 | 14:51 |
| stephenfin | +2 from me | 14:52 |
| gibi | stephenfin: jkulik: gerrit now showed that there is already a patch for 1.29 and it is more widespread change that adds mutliple things that is missing from the client like support for 1.25 adding granular request https://review.opendev.org/c/openstack/osc-placement/+/696251 | 14:55 |
| *** Luzi has quit IRC | 14:55 | |
| stephenfin | I saw that conflict and skipped over it once I saw 1.25 in the commit message | 14:55 |
| stephenfin | I can review that now | 14:55 |
| gibi | jkulik: do you also need support for 1.25 and so on? | 14:56 |
| jkulik | gibi: 1.26 would be nice, yes | 14:57 |
| *** ociuhandu has joined #openstack-nova | 14:57 | |
| jkulik | shall I abandon my request in favor of the exiting one? | 14:58 |
| *** macz_ has joined #openstack-nova | 14:59 | |
| gibi | I think https://review.opendev.org/c/openstack/osc-placement/+/696251 would be better as it is a more complete solution than just enabling 1.29 | 15:02 |
| stephenfin | agreed | 15:02 |
| jkulik | I agree. abandoned my change. | 15:05 |
| *** rcernin has quit IRC | 15:05 | |
| *** ociuhandu has quit IRC | 15:07 | |
| *** rpittau is now known as rpittau|afk | 15:08 | |
| *** lbragstad_ is now known as lbragstad | 15:11 | |
| *** ociuhandu has joined #openstack-nova | 15:12 | |
| *** ociuhandu has quit IRC | 15:18 | |
| kashyap | stephenfin: I blame you for my slow-gaining rST obsession. In my reviews in libvirt rST docs upstream, I began typing out little rST tweaks they could do :D | 15:23 |
| stephenfin | Good :) It's got a learning curve but it is very powerful stuff | 15:23 |
| stephenfin | especially when you introduce extensions | 15:24 |
| kashyap | stephenfin: Yeah, I'm nowhere near your ability to spot all rST problems from a mile away...but still, now I feel like I should tackle this 8000+ line doc | 15:24 |
| kashyap | stephenfin: While you're here: | 15:24 |
| kashyap | stephenfin: Say, a project prefers at most 80 cols of text width. Do you care to adjust pre-formatted and tables which overflow 80 cols? | 15:25 |
| *** martinkennelly has quit IRC | 15:25 | |
| stephenfin | I try to wrap e.g. commands in code-blocks, but only because they don't wrap very well in PDF output | 15:26 |
| stephenfin | but obviously you can't do that for source code snippets | 15:26 |
| kashyap | Right | 15:26 |
| kashyap | stephenfin: A libvirt dev was asking me would you _do_ anything about it | 15:26 |
| *** martinkennelly has joined #openstack-nova | 15:26 | |
| stephenfin | Also, you can unusually replace literal tables with e.g. the '.. list-table' directive | 15:26 |
| kashyap | (Where "it" == long code snippets; or other similar pre-formatted stuff) | 15:27 |
| stephenfin | It's not as nice to read in the source, but it's far simpler to prepare and the output is identical | 15:27 |
| kashyap | stephenfin: Ah, nice | 15:27 |
| stephenfin | I'd keep those things as-is, personally | 15:27 |
| kashyap | stephenfin: I didn't know the ".. list-table" directive. Do we have an example of it in our docs? | 15:27 |
| *** ociuhandu has joined #openstack-nova | 15:28 | |
| kashyap | stephenfin: Okay, that's what I thought. It's less work too | 15:28 |
| stephenfin | loads of examples, yes | 15:28 |
| stephenfin | doc/source/cli/nova-manage.rst for one | 15:28 |
| kashyap | stephenfin: Thanks. And speaking of extensions, what extensions are recommended? Even if it's your subjective list | 15:29 |
| stephenfin | That's entirely doc specific | 15:29 |
| stephenfin | We use a load of custom ones for things like autodocumenting oslo.policy and oslo.config code that wouldn't make sense outside of OpenStack | 15:30 |
| kashyap | stephenfin: Ah, okay. I'll be modest and fix the obvious stuff for libvirt. I'm just adjusting some secure boot docs in libvirt, hence this chatter here | 15:30 |
| stephenfin | Once you start needing to cross-reference project-unique things or auto-generate some kind of docs, this stuff starts becoming useful | 15:31 |
| kashyap | They recently big-bang convereted HTML to rST an 8000-line file (this one, which we commonly refer to: https://libvirt.org/formatdomain.html) | 15:31 |
| kashyap | With `pandoc`: https://gitlab.com/pipo.sk/libvirt/-/commit/81e494bb5a3c442e875996beaed972904323d3cb | 15:32 |
| kashyap | Ignore the silly GitLab thing in the commit message. It converted :anchor: to ⚓ emoji :D | 15:32 |
| *** dklyle has joined #openstack-nova | 15:35 | |
| *** ociuhandu has quit IRC | 15:38 | |
| *** sapd1 has joined #openstack-nova | 15:38 | |
| stephenfin | gibi: melwitt: You think we can go ahead with https://review.opendev.org/c/openstack/osc-placement/+/743976 now? | 15:39 |
| stephenfin | I just got asked "why doesn't 'openstack resource provider inventory list' show usage" downstream and was like, aha, I'm not crazy! | 15:39 |
| jkulik | stephenfin: can you elaborate on that? | 15:42 |
| stephenfin | jkulik: On that patch? | 15:42 |
| jkulik | stephenfin: on not showing usage | 15:42 |
| *** openstackgerrit has joined #openstack-nova | 15:42 | |
| openstackgerrit | Merged openstack/osc-placement master: Support granular allocation candidate list https://review.opendev.org/c/openstack/osc-placement/+/696251 | 15:42 |
| stephenfin | oh, 'openstack resource provider inventory list' shows total available inventory for a resource provider | 15:43 |
| stephenfin | but it doesn't include usage information | 15:43 |
| jkulik | yes. we built our on little command to also see the usage next to it | 15:43 |
| jkulik | why isn't that included? | 15:43 |
| stephenfin | to get that, you need to use a separate command, 'openstack resource provider usage show' | 15:43 |
| stephenfin | jkulik: That's my argument: it should be :) | 15:43 |
| jkulik | oh :D | 15:43 |
| jkulik | I read your message wrong :D | 15:44 |
| stephenfin | So I'm adding it there and proposing we eventually deprecated the separate usage command | 15:44 |
| stephenfin | *deprecate | 15:44 |
| jkulik | should just have clicked the review link, thanks m) | 15:45 |
| *** ociuhandu has joined #openstack-nova | 15:45 | |
| *** psachin has quit IRC | 15:59 | |
| *** LinPeiWen80 has quit IRC | 16:00 | |
| gibi | stephenfin: I have to get back to this on Monday | 16:02 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466 | 16:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/778885 | 16:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base https://review.opendev.org/c/openstack/nova/+/778908 | 16:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909 | 16:04 |
| *** ociuhandu has quit IRC | 16:05 | |
| *** brinzhang0 has quit IRC | 16:14 | |
| *** brinzhang0 has joined #openstack-nova | 16:15 | |
| *** ociuhandu has joined #openstack-nova | 16:36 | |
| *** ociuhandu has quit IRC | 16:45 | |
| *** k-s-dean has quit IRC | 16:46 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base https://review.opendev.org/c/openstack/nova/+/778908 | 16:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909 | 16:46 |
| *** ociuhandu has joined #openstack-nova | 16:47 | |
| *** lpetrut has quit IRC | 16:47 | |
| *** ociuhandu has quit IRC | 16:53 | |
| *** ociuhandu has joined #openstack-nova | 16:54 | |
| *** k-s-dean has joined #openstack-nova | 16:55 | |
| *** lucasagomes has quit IRC | 16:56 | |
| *** ociuhandu has quit IRC | 16:58 | |
| *** tesseract has quit IRC | 17:04 | |
| *** ociuhandu has joined #openstack-nova | 17:12 | |
| *** ociuhandu has quit IRC | 17:12 | |
| *** ociuhandu has joined #openstack-nova | 17:12 | |
| *** ociuhandu_ has joined #openstack-nova | 17:20 | |
| *** dtantsur is now known as dtantsur|afk | 17:21 | |
| *** ociuhandu has quit IRC | 17:24 | |
| *** ociuhandu_ has quit IRC | 17:24 | |
| *** k_mouza has quit IRC | 17:26 | |
| *** k_mouza_ has joined #openstack-nova | 17:26 | |
| *** ociuhandu has joined #openstack-nova | 17:28 | |
| *** ociuhandu has quit IRC | 17:32 | |
| *** hamalq has joined #openstack-nova | 17:41 | |
| openstackgerrit | Merged openstack/nova stable/victoria: libvirt: Use specific user when probing encrypted rbd disks during extend https://review.opendev.org/c/openstack/nova/+/773443 | 17:48 |
| openstackgerrit | Merged openstack/nova master: doc: mark the max microversion for wallaby https://review.opendev.org/c/openstack/nova/+/780401 | 17:49 |
| *** andrewbonney has quit IRC | 17:50 | |
| *** k_mouza_ has quit IRC | 17:52 | |
| *** k_mouza has joined #openstack-nova | 18:14 | |
| *** khomesh24 has quit IRC | 18:16 | |
| *** k_mouza has quit IRC | 18:20 | |
| *** hamalq has quit IRC | 18:36 | |
| *** hamalq has joined #openstack-nova | 18:36 | |
| *** tbachman has quit IRC | 18:57 | |
| *** tbachman_ has joined #openstack-nova | 18:57 | |
| *** whoami-rajat has quit IRC | 19:00 | |
| openstackgerrit | Merged openstack/nova master: releasenotes: Fix typo https://review.opendev.org/c/openstack/nova/+/781725 | 19:02 |
| *** viks____ has quit IRC | 19:04 | |
| *** jamesdenton has quit IRC | 19:07 | |
| *** jamesdenton has joined #openstack-nova | 19:07 | |
| *** songwenping__ has quit IRC | 19:09 | |
| *** songwenping__ has joined #openstack-nova | 19:10 | |
| *** jamesdenton has quit IRC | 19:29 | |
| *** jamesdenton has joined #openstack-nova | 19:29 | |
| *** vishalmanchanda has quit IRC | 19:35 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781888 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781889 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781890 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/os-vif/+/781891 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781892 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781893 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894 | 19:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781895 | 19:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781896 | 19:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781897 | 19:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/python-novaclient/+/781898 | 19:49 |
| *** ociuhandu has joined #openstack-nova | 19:57 | |
| *** ociuhandu has quit IRC | 20:48 | |
| *** ociuhandu has joined #openstack-nova | 20:48 | |
| *** jobewan has joined #openstack-nova | 20:57 | |
| *** k-s-dean has quit IRC | 21:00 | |
| *** jobewan has quit IRC | 21:04 | |
| *** ociuhandu has quit IRC | 21:12 | |
| *** openstackgerrit has quit IRC | 21:22 | |
| *** jamesdenton has quit IRC | 21:30 | |
| *** jamesdenton has joined #openstack-nova | 21:31 | |
| *** k-s-dean has joined #openstack-nova | 21:39 | |
| *** rcernin has joined #openstack-nova | 22:03 | |
| *** dpawlik has quit IRC | 22:11 | |
| *** lbragstad has quit IRC | 22:11 | |
| *** mdbooth has quit IRC | 22:11 | |
| *** k-s-dean has quit IRC | 22:11 | |
| *** tbachman_ has quit IRC | 22:12 | |
| *** brinzhang_ has joined #openstack-nova | 22:12 | |
| *** lbragstad_ has joined #openstack-nova | 22:12 | |
| *** kd has joined #openstack-nova | 22:12 | |
| *** dpawlik9 has joined #openstack-nova | 22:12 | |
| *** dpawlik9 is now known as dpawlik | 22:13 | |
| *** rnoriega- has quit IRC | 22:13 | |
| *** martinkennelly has quit IRC | 22:13 | |
| *** brinzhang0 has quit IRC | 22:13 | |
| *** tobiash has quit IRC | 22:13 | |
| *** tobiash has joined #openstack-nova | 22:14 | |
| *** mgoddard has quit IRC | 22:16 | |
| *** rnoriega_ has joined #openstack-nova | 22:18 | |
| *** mgoddard has joined #openstack-nova | 22:19 | |
| *** amodi has quit IRC | 22:22 | |
| *** tbachman has joined #openstack-nova | 22:32 | |
| *** jamesdenton has quit IRC | 23:00 | |
| *** jamesdenton has joined #openstack-nova | 23:02 | |
| *** hamalq has quit IRC | 23:05 | |
| *** efried has quit IRC | 23:17 | |
| *** efried has joined #openstack-nova | 23:18 | |
| *** tkajinam has quit IRC | 23:27 | |
| *** jamesdenton has quit IRC | 23:30 | |
| *** jamesdenton has joined #openstack-nova | 23:30 | |
| *** mlavalle has quit IRC | 23:37 | |
| *** stand has quit IRC | 23:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!