Friday, 2019-10-11

*** brinzhang has joined #openstack-nova00:13
*** spatel has joined #openstack-nova00:15
*** brinzhang_ has quit IRC00:16
*** gyee has quit IRC00:40
*** brinzhang_ has joined #openstack-nova00:41
*** brinzhang has quit IRC00:45
*** kaisers has quit IRC00:45
*** tbachman has quit IRC00:56
*** kaisers has joined #openstack-nova00:57
*** mdbooth has quit IRC01:00
*** mdbooth has joined #openstack-nova01:01
*** slaweq has joined #openstack-nova01:11
*** brinzhang has joined #openstack-nova01:13
*** tbachman has joined #openstack-nova01:15
*** brinzhang_ has quit IRC01:16
*** slaweq has quit IRC01:16
*** yaawang has quit IRC01:28
*** yaawang has joined #openstack-nova01:28
*** dklyle has quit IRC01:35
*** spatel has quit IRC01:46
*** brinzhang_ has joined #openstack-nova01:49
*** dklyle has joined #openstack-nova01:50
*** brinzhang has quit IRC01:52
*** brinzhang has joined #openstack-nova01:57
*** brinzhang_ has quit IRC02:00
*** markvoelker has joined #openstack-nova02:11
*** brinzhang_ has joined #openstack-nova02:13
*** brinzhang has quit IRC02:16
*** markvoelker has quit IRC02:21
*** markvoelker has joined #openstack-nova02:22
*** markvoelker has quit IRC02:26
*** hongbin has joined #openstack-nova02:37
*** brinzhang has joined #openstack-nova02:39
*** brinzhang_ has quit IRC02:42
*** slaweq has joined #openstack-nova03:02
*** spatel has joined #openstack-nova03:06
*** slaweq has quit IRC03:06
*** spatel has quit IRC03:11
*** yaawang has quit IRC03:13
*** yaawang has joined #openstack-nova03:15
*** yaawang has quit IRC03:16
*** yaawang has joined #openstack-nova03:16
*** brinzhang_ has joined #openstack-nova03:19
*** brinzhang has quit IRC03:22
*** hongbin has quit IRC03:24
*** mkrai has joined #openstack-nova03:27
*** lbragstad_ has joined #openstack-nova03:31
*** lbragstad has quit IRC03:31
*** ociuhandu has joined #openstack-nova04:01
*** ociuhandu has quit IRC04:06
*** slaweq has joined #openstack-nova04:11
*** slaweq has quit IRC04:16
*** lbragstad has joined #openstack-nova04:25
*** abhishekk has joined #openstack-nova04:27
*** lbragstad_ has quit IRC04:28
openstackgerritBrin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id  https://review.opendev.org/67424304:32
*** lbragstad_ has joined #openstack-nova04:33
*** lbragstad has quit IRC04:34
*** boxiang has quit IRC04:36
*** boxiang has joined #openstack-nova04:36
openstackgerritBrin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id  https://review.opendev.org/67424304:36
openstackgerritBrin Zhang proposed openstack/nova master: Fix legacy issues in Filter migrations by user_id/project_id  https://review.opendev.org/68219804:37
openstackgerritBrin Zhang proposed openstack/nova master: Fix legacy issues in filter migrations by user_id/project_id  https://review.opendev.org/68219804:38
*** dave-mccowan has quit IRC04:39
*** lbragstad has joined #openstack-nova04:40
*** lbragstad_ has quit IRC04:41
*** pcaruana has joined #openstack-nova04:55
*** tkajinam has quit IRC05:01
*** tkajinam has joined #openstack-nova05:02
*** brinzhang_ has quit IRC05:08
*** brinzhang_ has joined #openstack-nova05:08
*** tkajinam has quit IRC05:23
*** tkajinam has joined #openstack-nova05:23
*** brinzhang has joined #openstack-nova05:28
*** brinzhang_ has quit IRC05:31
*** eandersson has quit IRC05:45
*** eandersson has joined #openstack-nova05:47
*** evrardjp_ has joined #openstack-nova05:49
*** tbarron has quit IRC05:54
*** Vek has quit IRC05:55
*** evrardjp has quit IRC05:55
*** antonym has quit IRC05:55
*** antonym has joined #openstack-nova05:55
*** udesale has joined #openstack-nova05:56
*** irclogbot_0 has quit IRC05:56
*** irclogbot_3 has joined #openstack-nova05:57
openstackgerritya.wang proposed openstack/nova master: libvirt: Change _compare_cpu to raise InternalError  https://review.opendev.org/68780806:00
*** lbragstad_ has joined #openstack-nova06:00
*** brinzhang has quit IRC06:00
*** brinzhang has joined #openstack-nova06:01
*** lbragstad has quit IRC06:01
*** lpetrut has joined #openstack-nova06:04
*** slaweq has joined #openstack-nova06:09
*** xek_ has joined #openstack-nova06:09
*** slaweq_ has joined #openstack-nova06:13
*** brinzhang_ has joined #openstack-nova06:14
*** slaweq has quit IRC06:14
*** brinzhang has quit IRC06:17
openstackgerritLuyao Zhong proposed openstack/nova master: support live migration with vpmems  https://review.opendev.org/68785606:20
*** jawad_axd has joined #openstack-nova06:21
*** jawad_axd has quit IRC06:21
*** jawad_axd has joined #openstack-nova06:22
*** jawad_axd has quit IRC06:25
*** jawad_axd has joined #openstack-nova06:26
*** mkrai has quit IRC06:30
*** mkrai_ has joined #openstack-nova06:30
*** SonPham has joined #openstack-nova06:41
*** SonPham has quit IRC06:42
openstackgerritBrin Zhang proposed openstack/nova-specs master: Change the primary assignee to the mainly contributor  https://review.opendev.org/68804206:45
*** brinzhang has joined #openstack-nova06:46
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891206:46
openstackgerritYongli He proposed openstack/nova master: clean up orphan instances  https://review.opendev.org/62776506:46
*** slaweq_ is now known as slaweq06:48
*** brinzhang_ has quit IRC06:49
*** trident has quit IRC06:53
*** trident has joined #openstack-nova06:55
*** damien_r has joined #openstack-nova06:55
*** cfriesen has quit IRC06:56
*** ttsiouts has joined #openstack-nova07:00
*** rcernin has quit IRC07:03
*** tesseract has joined #openstack-nova07:03
*** ccamacho has joined #openstack-nova07:04
*** tssurya has joined #openstack-nova07:09
*** lpetrut has quit IRC07:15
*** brinzhang_ has joined #openstack-nova07:18
*** tobberydberg has quit IRC07:20
*** brinzhang has quit IRC07:21
*** ttsiouts has quit IRC07:24
*** ttsiouts has joined #openstack-nova07:25
*** tobberydberg has joined #openstack-nova07:26
*** awalende has joined #openstack-nova07:28
*** brinzhang has joined #openstack-nova07:29
*** ttsiouts has quit IRC07:30
*** brinzhang_ has quit IRC07:33
*** lpetrut has joined #openstack-nova07:34
*** jaosorior has joined #openstack-nova07:38
*** Vek has joined #openstack-nova07:43
*** brinzhang_ has joined #openstack-nova07:47
*** brinzhang_ has quit IRC07:48
*** brinzhang_ has joined #openstack-nova07:49
*** brinzhang_ has quit IRC07:50
*** brinzhang has quit IRC07:50
*** rpittau|afk is now known as rpittau07:53
*** lpetrut has quit IRC07:53
*** ivve has joined #openstack-nova07:55
*** ralonsoh has joined #openstack-nova07:56
*** tkajinam has quit IRC07:58
*** ttsiouts has joined #openstack-nova08:00
openstackgerritMerged openstack/nova master: Fix exception translation when creating volume  https://review.opendev.org/67899108:07
openstackgerritMerged openstack/python-novaclient master: PDF documentation build  https://review.opendev.org/68796608:17
openstackgerritMerged openstack/nova master: Fix unit of hw_rng:rate_period  https://review.opendev.org/68305108:20
*** markvoelker has joined #openstack-nova08:25
*** markvoelker has quit IRC08:30
openstackgerritLee Yarwood proposed openstack/nova stable/stein: Stop sending bad values from libosinfo to libvirt  https://review.opendev.org/68806708:32
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Stop sending bad values from libosinfo to libvirt  https://review.opendev.org/68806808:33
*** mkrai_ has quit IRC08:33
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Stop sending bad values from libosinfo to libvirt  https://review.opendev.org/68806908:34
tridentAny thoughts on https://bugs.launchpad.net/nova/+bug/1741364 ?08:39
openstackLaunchpad bug 1741364 in OpenStack Compute (nova) "ceph ephemeral info not updated during live migrate" [Medium,Confirmed]08:39
openstackgerritFan Zhang proposed openstack/nova stable/train: Fix exception translation when creating volume  https://review.opendev.org/68807208:41
openstackgerritFan Zhang proposed openstack/nova stable/stein: Fix exception translation when creating volume  https://review.opendev.org/68807308:43
openstackgerritFan Zhang proposed openstack/nova stable/stein: Fix exception translation when creating volume  https://review.opendev.org/68807308:43
*** mkrai has joined #openstack-nova08:44
*** liuyulong has joined #openstack-nova08:48
*** mkrai has quit IRC08:48
*** takamatsu has joined #openstack-nova08:49
*** mkrai has joined #openstack-nova08:51
*** mkrai has quit IRC08:54
*** mkrai_ has joined #openstack-nova08:54
*** macz has joined #openstack-nova08:57
*** macz has quit IRC09:02
*** mkrai_ has quit IRC09:02
*** liuyulong has quit IRC09:03
openstackgerritTakashi NATSUME proposed openstack/nova stable/train: Fix unit of hw_rng:rate_period  https://review.opendev.org/68808309:03
openstackgerritya.wang proposed openstack/nova master: libvirt: Change _compare_cpu to raise InvalidCPUInfo  https://review.opendev.org/68780809:08
*** takashin has left #openstack-nova09:10
*** ivve has quit IRC09:10
*** ivve has joined #openstack-nova09:18
*** mkrai has joined #openstack-nova09:20
openstackgerritFan Zhang proposed openstack/nova stable/stein: Fix exception translation when creating volume  https://review.opendev.org/68807309:21
openstackgerritFan Zhang proposed openstack/nova stable/rocky: Fix exception translation when creating volume  https://review.opendev.org/68808909:26
openstackgerritNicolas Belouin proposed openstack/nova master: Add support for Xen PVH VM Mode in libvirt driver  https://review.opendev.org/68782709:31
stephenfindid we not have a meeting last night09:39
openstackgerritFan Zhang proposed openstack/nova stable/queens: Fix exception translation when creating volume  https://review.opendev.org/68809009:41
*** ociuhandu has joined #openstack-nova09:49
*** kaisers has quit IRC09:52
*** mvkr has quit IRC09:56
*** kaisers has joined #openstack-nova09:56
*** ttsiouts has quit IRC09:57
*** ttsiouts has joined #openstack-nova09:58
*** derekh has joined #openstack-nova09:58
*** mkrai has quit IRC10:02
*** mkrai_ has joined #openstack-nova10:02
*** ttsiouts has quit IRC10:02
*** brinzhang has joined #openstack-nova10:07
*** rcernin has joined #openstack-nova10:08
*** mvkr has joined #openstack-nova10:09
*** rpittau is now known as rpittau|bbl10:15
*** mkrai_ has quit IRC10:15
*** rcernin has quit IRC10:21
*** jmlowe has quit IRC10:24
*** ociuhandu has quit IRC10:25
*** jmlowe has joined #openstack-nova10:26
*** ivve has quit IRC10:28
*** tbachman has quit IRC10:29
*** tbachman has joined #openstack-nova10:30
*** ivve has joined #openstack-nova10:44
*** tbachman has quit IRC10:44
*** abhishekk has quit IRC10:50
*** mkrai has joined #openstack-nova10:52
*** dave-mccowan has joined #openstack-nova10:58
*** macz has joined #openstack-nova10:58
*** ttsiouts has joined #openstack-nova11:01
*** macz has quit IRC11:03
*** ociuhandu has joined #openstack-nova11:04
*** ociuhandu has quit IRC11:04
*** ttsiouts has quit IRC11:06
*** ttsiouts has joined #openstack-nova11:06
*** brinzhang_ has joined #openstack-nova11:16
*** ociuhandu has joined #openstack-nova11:17
*** mkrai has quit IRC11:18
*** brinzhang has quit IRC11:19
kashyapAny stable cores, mind having a look at this stable/queens thing?  It has also merged in other stable branches: https://review.opendev.org/#/c/668111/ (libvirt: Rework 'EBUSY' (SIGKILL) error handling code path11:20
kashyap)11:20
kashyap(It has merged in Rocky and Stein.)11:21
*** brinzhang has joined #openstack-nova11:21
*** brinzhang_ has quit IRC11:24
*** mkrai has joined #openstack-nova11:25
*** xek_ has quit IRC11:31
*** brinzhang_ has joined #openstack-nova11:31
lyarwoodkashyap: yup sorry looking now11:34
*** brinzhang has quit IRC11:34
kashyapGracias11:34
*** yoctozepto has joined #openstack-nova11:52
openstackgerritBalazs Gibizer proposed openstack/nova stable/pike: Error out interrupted builds  https://review.opendev.org/68791811:56
*** HagunKim has joined #openstack-nova11:56
kashyapNeeds a second stable core +2 here: https://review.opendev.org/#/c/668111/11:59
*** tbachman has joined #openstack-nova12:12
fricklerthis bug is targeted on tempest, but I'd like to know from nova ppl how valuable testing the hard reboot is to you, as I'm considering to propose dropping this test if it can't be made more reliable https://bugs.launchpad.net/tempest/+bug/184775912:21
openstackLaunchpad bug 1847759 in tempest "reboot_server_hard can trigger corrupted file system" [Undecided,New]12:21
*** yaawang has quit IRC12:23
lyarwoodfrickler: IMHO it's useful and that sounds worrying as a bug report12:25
fricklerlyarwood: I'm even more worried after seeing how many matches my logstash query has, though I haven't verified yet how many of those match the bug http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22self._test_reboot_server('HARD')%5C%2212:28
*** markvoelker has joined #openstack-nova12:28
lyarwoodfrickler: I wonder if we even need to boot an instance using an image to test hard reboot12:29
lyarwoodfrickler: if corruption of the image by the guest OS dying suddenly is the issue here12:30
*** markvoelker has quit IRC12:33
*** rpittau|bbl is now known as rpittau12:33
*** markvoelker has joined #openstack-nova12:34
fricklerlyarwood: o.k., I checked some of the failure logs. 2/3 seem to fail to connect to the instance on the initial boot already, 1/3 looks like fs corruption after the hard reboot, so still a relevant set. if you have any idea how to make that more stable, I think that would be pretty useful12:36
*** awalende has quit IRC12:40
*** awalende has joined #openstack-nova12:41
*** mkrai has quit IRC12:45
*** mkrai has joined #openstack-nova12:45
*** awalende has quit IRC12:46
bauzasstephenfin: nope, the nova meeting was cancelled, see ML12:57
*** macz has joined #openstack-nova12:59
*** macz has quit IRC13:03
*** nweinber_ has joined #openstack-nova13:04
*** mkrai has quit IRC13:08
*** dklyle has quit IRC13:11
*** BjoernT has joined #openstack-nova13:17
*** lbragstad_ is now known as lbragstad13:18
*** BjoernT_ has joined #openstack-nova13:21
stephenfinbauzas: ah, yes, thanks13:23
stephenfinbauzas: Would you do me the honours? https://review.opendev.org/#/c/684402/ https://review.opendev.org/#/c/685929/ https://review.opendev.org/#/c/687264// ?13:24
* bauzas clicks clicks clicks13:24
*** BjoernT has quit IRC13:24
*** READ10 has joined #openstack-nova13:24
openstackgerritMatthew Booth proposed openstack/nova master: Don't take a lock when fetching a cached cell mapping  https://review.opendev.org/68812213:25
*** ttsiouts has quit IRC13:25
*** dklyle has joined #openstack-nova13:26
*** lbragstad has quit IRC13:26
*** ttsiouts has joined #openstack-nova13:26
stephenfinbauzas: ta13:29
*** ttsiouts has quit IRC13:31
*** brinzhang_ has quit IRC13:32
*** brinzhang_ has joined #openstack-nova13:32
openstackgerritMerged openstack/nova master: api-guide: Fix available info in handling down cells  https://review.opendev.org/68652013:35
openstackgerritMerged openstack/nova-specs master: Change the primary assignee to the mainly contributor  https://review.opendev.org/68804213:41
openstackgerritMerged openstack/nova-specs master: Fix followup comments of policy-defaults-refresh spec  https://review.opendev.org/66919613:41
*** jawad_axd has quit IRC13:51
*** eharney has joined #openstack-nova13:52
mdboothlyarwood: Re https://code.engineering.redhat.com/gerrit/182841 GAH! and thanks. Mind if we don't wait for tempest after I update the commit message?13:54
lyarwoodmdbooth: wrong window but yeah of course13:54
*** ttsiouts has joined #openstack-nova13:55
mdboothlyarwood: Hah, so it is13:55
*** xek_ has joined #openstack-nova13:55
*** ociuhandu has quit IRC13:57
*** udesale has quit IRC13:57
*** udesale has joined #openstack-nova13:58
*** mlavalle has joined #openstack-nova13:58
*** gbarros has joined #openstack-nova13:59
*** lbragstad has joined #openstack-nova13:59
*** artom has joined #openstack-nova14:00
*** boxiang_ has joined #openstack-nova14:01
*** boxiang_ has quit IRC14:02
*** tssurya has quit IRC14:03
*** HagunKim has quit IRC14:07
*** jawad_axd has joined #openstack-nova14:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Avoid using image with kernel in BDM large request func test  https://review.opendev.org/68813214:11
*** liuyulong has joined #openstack-nova14:12
*** ociuhandu has joined #openstack-nova14:14
*** TxGirlGeek has joined #openstack-nova14:21
*** READ10 has quit IRC14:22
*** BjoernT_ is now known as BjoernT14:25
*** ociuhandu has quit IRC14:28
*** cfriesen has joined #openstack-nova14:29
*** ociuhandu has joined #openstack-nova14:34
*** READ10 has joined #openstack-nova14:38
*** macz has joined #openstack-nova14:38
*** munimeha1 has joined #openstack-nova14:39
gibistephenfin: quick question in https://review.opendev.org/#/c/686802/6//COMMIT_MSG@1814:40
*** jawad_axd has quit IRC14:42
*** awalende has joined #openstack-nova14:43
*** macz has quit IRC14:43
stephenfingibi: replied14:47
*** awalende has quit IRC14:47
gibistephenfin: +214:47
stephenfinta14:47
*** ivve has quit IRC14:50
stephenfingibi: If you're on a reviewing streak, I'd appreciate your eyes on the following patch too since it's NeutronFixture'y and you know that stuff, heh https://review.opendev.org/#/c/684344/14:55
stephenfinFeel free to chuck something my way too14:56
gibistephenfin: reviewing it right no14:56
gibiw14:56
stephenfinnice :D14:56
dansmithgibi: there are a few patches in this stack for which you reviewed the spec that you could +W if you want :)14:56
dansmithgibi: https://review.opendev.org/#/c/687137/414:56
gibidansmith: ack, I will look at it after stephenfin's patch14:57
*** KeithMnemonic has joined #openstack-nova14:57
dansmithgibi: thanks14:57
gibistephenfin: -1 due to https://review.opendev.org/#/c/684344/15/nova/tests/functional/api_sample_tests/test_floating_ips.py@15814:57
openstackgerritDan Smith proposed openstack/nova master: Add cache_images() to conductor  https://review.opendev.org/68713914:58
openstackgerritDan Smith proposed openstack/nova master: Add image caching API for aggregates  https://review.opendev.org/68714014:58
openstackgerritDan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates  https://review.opendev.org/68734814:58
stephenfingibi: Would a follow-up be okay? Can post that now14:58
gibistephenfin: sure14:59
gibilet me change my vote14:59
*** FlorianFa has quit IRC15:03
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Use deepcopy on value returned by NeutronFixture  https://review.opendev.org/68813915:03
*** lpetrut has joined #openstack-nova15:04
*** macz has joined #openstack-nova15:04
*** ttsiouts has quit IRC15:08
*** ociuhandu has quit IRC15:09
*** amodi has quit IRC15:16
*** udesale has quit IRC15:23
*** ociuhandu has joined #openstack-nova15:27
stephenfingibi: Back at you https://review.opendev.org/#/c/688132/15:29
*** damien_r has quit IRC15:29
gibistephenfin: thanks. Make sense. I need to get back to that15:30
*** jawad_axd has joined #openstack-nova15:30
*** READ10 has quit IRC15:32
*** jawad_axd has quit IRC15:35
*** ozzzo has quit IRC15:40
*** ozzzo has joined #openstack-nova15:41
*** bnemec has quit IRC15:43
*** rpittau is now known as rpittau|afk15:44
*** bnemec has joined #openstack-nova15:44
*** gbarros has quit IRC15:49
*** jangutter has quit IRC15:50
*** gbarros has joined #openstack-nova15:53
gibidansmith: reviewd the image chache series left some comments here and there15:53
dansmithgibi: so the return dict thing is leaving us some room for improvement in the future without having to bump the compute rpc version again15:55
*** jaosorior has quit IRC15:55
*** macz has quit IRC15:55
dansmithgibi: are you -1 on that or the logging asserts?15:55
*** tbachman has quit IRC15:55
dansmithoh you said, because the driver bit is unused15:55
gibidansmith: you mean that now the rpc returns a dict so later we can add whatever we want to that dict without rpc bump?15:56
dansmithgibi: no, it's returning that so that I could follow on with some stats logging in conductor.. not expecting to add stuff to the dict later, just expecting to use it15:56
dansmithgibi: there was some discussion in those patches (IIRC) but definitely some here about what we might do in the future to log some stats,15:56
dansmithgibi: like "image X seemed to fail on every host" or "34 new downloads, 127 existing", that kind of thing15:57
gibidansmith: if it will be used in the future then I'm OK with it15:57
dansmithgibi: yep, plan is to use it, just trying to keep the base functionality to these patches and then we can hem and haw over how to calculate some stats in a future patch15:57
*** boxiang has quit IRC15:59
*** zhubx has joined #openstack-nova15:59
*** zhubx has quit IRC16:00
*** zhubx has joined #openstack-nova16:01
gibidansmith: cool. changed my votes as the rest of my comments can be done in a fup16:01
dansmithgibi: roger, just saw as I was replying, I'll post a fup for the nits and get a WIP enqueued for the stats so I can point at that if the question comes up again :D16:01
gibidansmith: thanks16:02
dansmithgibi: oh, heh on that libvirt test name... it's totally opposite, I dunno how I did that :P16:04
*** lpetrut has quit IRC16:05
gibi:)16:05
dansmithI'll call it a "testing gibi's attention to detail" easter egg16:06
gibiit worked :)16:06
dansmithyeah you passed the test this time16:06
gibiI'm wondering was there other tests I did not even notice?!16:07
dansmithgibi: muahah :D16:09
gibistephenfin: do you want me to refactor the fake image service ? https://review.opendev.org/#/c/688132/1/nova/tests/functional/test_boot_from_volume.py@20316:09
*** med has joined #openstack-nova16:10
*** med is now known as medberry16:10
*** ivve has joined #openstack-nova16:11
gibistephenfin: https://github.com/openstack/nova/blob/ef6e49d5bc721840b331c87c6391a69309253ade/nova/tests/unit/image/fake.py#L4516:11
stephenfingibi: If you have time, but I won't block on that now16:12
gibistephenfin: I can do that later. making a todo...16:12
stephenfintbh, I'd like to stop using the 'stub_out_image_service' function entirely since it obscures things16:13
stephenfinI've a big functional test cleanup in-progress. Can include that16:13
gibistephenfin: OK, I will ping you when I reach my todo to see if you have already started on it16:15
stephenfin(y)16:15
stephenfin+216:16
gibiIm leaving for today. Have a nice weeked you all!16:18
*** medberry has quit IRC16:20
stephenfinO/16:22
*** ociuhandu has quit IRC16:23
*** tbachman has joined #openstack-nova16:26
*** ociuhandu has joined #openstack-nova16:26
*** bbowen has quit IRC16:29
*** markvoelker has quit IRC16:38
*** BjoernT_ has joined #openstack-nova16:39
*** BjoernT has quit IRC16:41
*** xek_ has quit IRC16:44
*** markvoelker has joined #openstack-nova16:48
*** derekh has quit IRC16:48
openstackgerritDan Smith proposed openstack/nova master: Fix up some feedback on image precache support  https://review.opendev.org/68817216:53
openstackgerritDan Smith proposed openstack/nova master: WIP: Log some stats for image pre-cache  https://review.opendev.org/68817316:53
*** gyee has joined #openstack-nova16:53
*** bnemec has quit IRC16:57
*** bnemec has joined #openstack-nova16:58
*** BjoernT_ has quit IRC17:00
*** dklyle has quit IRC17:14
*** markvoelker has quit IRC17:18
*** READ10 has joined #openstack-nova17:30
*** eharney has quit IRC17:34
*** ociuhandu_ has joined #openstack-nova17:34
openstackgerritDan Smith proposed openstack/nova master: Add image caching API for aggregates  https://review.opendev.org/68714017:37
openstackgerritDan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates  https://review.opendev.org/68734817:37
openstackgerritDan Smith proposed openstack/nova master: Fix up some feedback on image precache support  https://review.opendev.org/68817217:37
openstackgerritDan Smith proposed openstack/nova master: WIP: Log some stats for image pre-cache  https://review.opendev.org/68817317:37
*** ociuhandu has quit IRC17:37
*** ociuhandu_ has quit IRC17:42
*** ociuhandu has joined #openstack-nova17:43
*** ociuhandu has quit IRC17:48
*** dklyle has joined #openstack-nova17:49
*** dklyle has quit IRC17:56
*** ceryx has quit IRC17:58
*** slaweq has quit IRC18:00
*** dklyle has joined #openstack-nova18:02
*** gbarros has quit IRC18:06
openstackgerritStephen Finucane proposed openstack/nova master: setup.cfg: Cleanup  https://review.opendev.org/67796918:06
openstackgerritStephen Finucane proposed openstack/nova master: Stop testing Python 2  https://review.opendev.org/68795418:06
*** ivve has quit IRC18:09
*** ivve has joined #openstack-nova18:10
*** tbachman has quit IRC18:11
melwitto/18:13
*** gbarros has joined #openstack-nova18:14
*** eharney has joined #openstack-nova18:16
*** tbachman has joined #openstack-nova18:19
openstackgerritStephen Finucane proposed openstack/nova master: Stop testing Python 2  https://review.opendev.org/68795418:19
openstackgerritMerged openstack/nova master: Add cache_image() driver method and libvirt implementation  https://review.opendev.org/68713718:28
*** ganso has quit IRC18:40
openstackgerritMerged openstack/nova master: Add cache_image() support to the compute/{rpcapi,api,manager}  https://review.opendev.org/68713818:41
*** med_ has quit IRC18:43
melwittzzzeek: hey, are you around?18:52
zzzeekmelwitt: heya18:52
melwitto.18:52
melwitto/18:52
melwittquestion for you18:52
zzzeekyep18:53
melwittzzzeek: do you happen to know why if this write adds a record in a single request with project_id=NULL, a non-independent read of records matching project_id=NULL will return no rows? https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L410118:55
zzzeekmelwitt: well in SQL there is no "= NULL" that works, it has to be "is NULL"18:55
*** pcaruana has quit IRC18:55
zzzeekmelwitt: SQLAlchemy makes that conversion in most cases18:55
zzzeekmelwitt: however, sometimes it cant18:56
zzzeekmelwitt: depends on context18:56
melwittzzzeek: I did learn that recently and found that our query does make the conversion correctly. what I found is that if the insert of the record happens with "independent" and a read *without* independent happens in the same request looking for "is NULL" it will not find the record that was written. it behaves as though the inserted record is not reflected in the current session18:57
zzzeekmelwitt: im not seeing what the query is here but if you were to do query(Foo).with_parent(Bar(id=None)) you might see that this does not in fact return Foo with bar_id=NULL18:57
zzzeekmelwitt: ah well that is a transaction isolation issue18:58
melwittand if I use "independent" in the read, it _will_ find the record. that could make some sense if the session caches stuff it knows about in the current transaction18:58
*** ganso has joined #openstack-nova18:58
melwittthe weird thing is that it does not behave this way if it is not project=NULL. when project_id is not NULL, it will find the record fine without using "independent" on the read18:58
zzzeekmelwitt: OK so there are two levels to that.  the first is, if you want to assume your transaction is non-isolated, you can say query(MyObject).populate_existing().filter(...)...18:59
zzzeekmelwitt: that asusmes you already have MyObject loaded and some related part of it is not being updated18:59
zzzeekmelwitt: if it is straight up, query(MyObject) returns no row, and the row is there, then this would be like a repeatable read problem19:00
*** tbachman has quit IRC19:00
* melwitt googles19:01
zzzeekmelwitt: basically if transaction A starts, then you do sometihgn in transaction B, you can't rely that transaction A can see what you just committed in B19:01
melwittohhhh19:01
zzzeekmelwitt: with a list of caveats a mile long19:01
melwittso transaction A inserts the record, transaction B reads the record and doesn't see it, yet transaction C (if added) will see what A committed. is the behavior I'm observing19:03
*** xek_ has joined #openstack-nova19:03
zzzeekmelwitt: yes if transaction C started after A was finished doing its work.  transaction A would only have had to have committed if isolatoin level is serializable which it is not19:04
zzzeekmelwitt: it's mostly about, im a transaction, I read some data, now that data is part of a "version" that i will forever see until my transaction ends19:05
zzzeekif i didnt read that data yet, then i dont know anything about it and based on isolation i might see the work of other transations19:05
zzzeekalso my previous line about A not having to commit is incorrect.  it has to have committed unless isoaltion is read uncommitted, or if theres some quirky mysql behavior going on19:06
* zzzeek bah tries19:06
zzzeekmelwitt: yeah mysql is doing repeatable read by default over here.  transaction A runs INSERT, but hasnt committed, B can see nothing no matter when it was started19:08
zzzeekA then commits.  B can only see something if it hasn't tried to read that table already19:08
melwittzzzeek: that makes sense. it seems to work fine though when NULL are not involved in the where of the read. I would have thought it should act the same in both cases19:09
zzzeekmelwitt: Im not sure about the NULL part.  i would need to see the SQL conversation in detail19:10
* melwitt nods19:10
melwittoh you know what, it's because there's a unique constraint on the project_id, so the second insert won't go through19:11
melwitt(I keep mixing everything up in my head)19:11
melwitter, it will not read the newly inserted record, same as the NULL case. it's just that I can't detect on the surface that it did that, because the evidence was creation of a dupe project_id record19:12
melwitttl;dr it does act the same no matter the project_id19:13
*** zhubx has quit IRC19:14
*** tbachman has joined #openstack-nova19:14
*** zhubx has joined #openstack-nova19:14
zzzeekmelwitt: OK if it works for you :)19:15
*** eharney has quit IRC19:16
*** zhubx has quit IRC19:16
*** zhubx has joined #openstack-nova19:16
melwittzzzeek: haha :) well, it seems to resolve find if I do the read in a new transaction C, but based on what I understand that's not guaranteed to do what I want. if the insert doesn't commit by the time C tries to read, it will still get 0 rows yeah?19:17
*** zhubx has quit IRC19:18
*** markvoelker has joined #openstack-nova19:18
*** zhubx has joined #openstack-nova19:18
*** zhubx has quit IRC19:20
*** zhubx has joined #openstack-nova19:20
*** zhubx has quit IRC19:22
*** zhubx has joined #openstack-nova19:22
*** zhubx has quit IRC19:24
*** zhubx has joined #openstack-nova19:24
*** tbachman has quit IRC19:25
*** zhubx has quit IRC19:26
*** zhubx has joined #openstack-nova19:26
*** markvoelker has quit IRC19:30
*** READ10 has quit IRC19:32
*** markvoelker has joined #openstack-nova19:33
*** gbarros has quit IRC19:36
*** markvoelker has quit IRC19:41
*** gbarros has joined #openstack-nova19:42
*** gbarros has quit IRC19:52
*** bbowen has joined #openstack-nova19:58
*** nweinber_ has quit IRC20:06
*** eharney has joined #openstack-nova20:30
*** BjoernT has joined #openstack-nova20:31
*** zhubx has quit IRC20:33
*** zhubx has joined #openstack-nova20:33
*** zhubx has quit IRC20:34
*** BjoernT_ has joined #openstack-nova20:43
*** BjoernT has quit IRC20:45
*** markvoelker has joined #openstack-nova20:49
*** markvoelker has quit IRC20:53
*** bbowen_ has joined #openstack-nova21:17
*** bbowen has quit IRC21:18
*** tesseract has quit IRC21:18
*** munimeha1 has quit IRC21:22
*** eharney has quit IRC21:25
openstackgerritmelanie witt proposed openstack/nova master: Add regression test for bug 1824435  https://review.opendev.org/68820521:25
openstackbug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,Triaged] https://launchpad.net/bugs/182443521:25
openstackgerritmelanie witt proposed openstack/nova master: Use a separate transaction to read default security group  https://review.opendev.org/68820621:25
*** tbachman has joined #openstack-nova21:40
*** BjoernT_ has quit IRC21:42
*** BjoernT has joined #openstack-nova21:43
*** mdbooth has quit IRC22:02
*** mdbooth has joined #openstack-nova22:03
*** ralonsoh has quit IRC22:09
*** gbarros has joined #openstack-nova22:19
*** tbachman has quit IRC22:33
*** KeithMnemonic has quit IRC22:38
*** rcernin has joined #openstack-nova22:41
*** xek_ has quit IRC22:42
*** xek_ has joined #openstack-nova22:45
*** bbowen_ has quit IRC22:48
*** bbowen has joined #openstack-nova22:54
*** bbowen has quit IRC22:54
*** bbowen has joined #openstack-nova22:56
*** xek_ has quit IRC22:57
*** BjoernT has quit IRC23:01
*** BjoernT has joined #openstack-nova23:01
*** ivve has quit IRC23:07
*** gbarros has quit IRC23:08
*** artom has quit IRC23:12
*** BjoernT has quit IRC23:15
*** BjoernT has joined #openstack-nova23:16
*** BjoernT has quit IRC23:17
*** BjoernT has joined #openstack-nova23:18
*** BjoernT has quit IRC23:19
*** BjoernT has joined #openstack-nova23:21
*** tbachman has joined #openstack-nova23:21
*** BjoernT has quit IRC23:36
*** tbachman has quit IRC23:46
*** medberry has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!