| *** whoami-rajat has quit IRC | 00:00 | |
| *** markvoelker has joined #openstack-nova | 00:09 | |
| *** macza has joined #openstack-nova | 00:27 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Fix warnings in the document generation https://review.openstack.org/631150 | 00:29 |
|---|---|---|
| *** tbachman has quit IRC | 00:31 | |
| *** _alastor_ has quit IRC | 00:31 | |
| *** macza has quit IRC | 00:32 | |
| *** lbragstad has quit IRC | 00:38 | |
| *** lxkong has joined #openstack-nova | 00:41 | |
| *** gyee has quit IRC | 00:41 | |
| *** markvoelker has quit IRC | 00:42 | |
| lxkong | hi nova, how can a admin user create a vm using a normal user's port? | 00:43 |
| *** ileixe has joined #openstack-nova | 01:02 | |
| *** tiendc has joined #openstack-nova | 01:04 | |
| *** wolverineav has quit IRC | 01:08 | |
| *** wolverineav has joined #openstack-nova | 01:10 | |
| *** wolverineav has quit IRC | 01:15 | |
| *** tbachman has joined #openstack-nova | 01:15 | |
| openstackgerrit | yuanliu proposed openstack/nova master: Fix query method for nova compute services by compute_driver types https://review.openstack.org/637083 | 01:18 |
| *** brinzhang has joined #openstack-nova | 01:28 | |
| *** wolverineav has joined #openstack-nova | 01:32 | |
| *** _alastor_ has joined #openstack-nova | 01:33 | |
| *** _alastor_ has quit IRC | 01:38 | |
| *** markvoelker has joined #openstack-nova | 01:39 | |
| *** wolverineav has quit IRC | 01:48 | |
| *** wolverineav has joined #openstack-nova | 01:50 | |
| *** _fragatina has quit IRC | 01:54 | |
| *** wolverineav has quit IRC | 01:55 | |
| openstackgerrit | Merged openstack/nova master: Remove deprecated 'os-flavor-manage' policy https://review.openstack.org/633656 | 01:56 |
| openstackgerrit | Merged openstack/nova master: Fix a missing policy in test policy data https://review.openstack.org/633686 | 01:56 |
| *** hongbin has joined #openstack-nova | 01:56 | |
| *** cfriesen has quit IRC | 01:59 | |
| *** wolverineav has joined #openstack-nova | 02:02 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Fix a missing policy in test policy data https://review.openstack.org/637085 | 02:03 |
| openstackgerrit | Merged openstack/nova master: Change nova-next tempest test regex https://review.openstack.org/636459 | 02:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Fix a missing policy in test policy data https://review.openstack.org/637112 | 02:07 |
| *** erlon_ has quit IRC | 02:07 | |
| *** mriedem has quit IRC | 02:11 | |
| *** markvoelker has quit IRC | 02:12 | |
| *** sapd1 has joined #openstack-nova | 02:13 | |
| openstackgerrit | Merged openstack/nova master: Default zero disk flavor to RULE_ADMIN_API in Stein https://review.openstack.org/603910 | 02:18 |
| openstackgerrit | Merged openstack/nova master: Fix deps for api-samples tox env https://review.openstack.org/633620 | 02:18 |
| *** wolverineav has quit IRC | 02:32 | |
| *** wolverineav has joined #openstack-nova | 02:33 | |
| *** wolverineav has quit IRC | 02:37 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:39 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 02:44 |
| *** hongbin has quit IRC | 02:48 | |
| *** mlavalle has quit IRC | 02:53 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 02:54 |
| *** psachin has joined #openstack-nova | 02:56 | |
| *** markvoelker has joined #openstack-nova | 03:09 | |
| *** tbachman has quit IRC | 03:28 | |
| *** liumk2233 has joined #openstack-nova | 03:30 | |
| *** tbachman has joined #openstack-nova | 03:31 | |
| *** lbragstad has joined #openstack-nova | 03:42 | |
| *** markvoelker has quit IRC | 03:43 | |
| *** janki has joined #openstack-nova | 03:58 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.68: Remove 'forced' live migrations, evacuations https://review.openstack.org/635131 | 04:07 |
| openstackgerrit | Merged openstack/nova master: Remove get_config_vhostuser https://review.openstack.org/565471 | 04:34 |
| *** wolverineav has joined #openstack-nova | 04:36 | |
| *** markvoelker has joined #openstack-nova | 04:40 | |
| *** igordc has quit IRC | 04:40 | |
| *** cfriesen has joined #openstack-nova | 04:59 | |
| *** wolverineav has quit IRC | 05:04 | |
| *** wolverineav has joined #openstack-nova | 05:05 | |
| *** ratailor has joined #openstack-nova | 05:05 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 05:09 |
| *** markvoelker has quit IRC | 05:12 | |
| *** raghav has joined #openstack-nova | 05:15 | |
| *** rnoriega has quit IRC | 05:15 | |
| *** rnoriega has joined #openstack-nova | 05:16 | |
| *** janki has quit IRC | 05:18 | |
| *** janki has joined #openstack-nova | 05:18 | |
| openstackgerrit | Merged openstack/nova master: api-ref: Add descriptions for vol-backed snapshots https://review.openstack.org/615084 | 05:24 |
| *** psachin has quit IRC | 05:38 | |
| *** moshele has joined #openstack-nova | 05:38 | |
| *** wolverineav has quit IRC | 05:40 | |
| *** wolverineav has joined #openstack-nova | 05:53 | |
| *** wolverineav has quit IRC | 05:54 | |
| *** moshele has quit IRC | 05:55 | |
| melwitt | thanks gmann ++ | 06:05 |
| *** whoami-rajat has joined #openstack-nova | 06:08 | |
| *** markvoelker has joined #openstack-nova | 06:09 | |
| *** eandersson has quit IRC | 06:12 | |
| *** eandersson has joined #openstack-nova | 06:13 | |
| *** eandersson has quit IRC | 06:13 | |
| *** eandersson has joined #openstack-nova | 06:14 | |
| *** cfriesen has quit IRC | 06:17 | |
| *** lbragstad has quit IRC | 06:18 | |
| *** sridharg has joined #openstack-nova | 06:23 | |
| *** tkajinam_ has joined #openstack-nova | 06:33 | |
| *** tkajinam has quit IRC | 06:35 | |
| ileixe | Hi guys, I'm not sure it's right place to ask but wish someone to shed light on the newbie. | 06:37 |
| ileixe | Is there any way to change timezone (from UTC to any dfifrent) for nova? | 06:37 |
| *** dpawlik has joined #openstack-nova | 06:40 | |
| *** markvoelker has quit IRC | 06:43 | |
| *** psachin has joined #openstack-nova | 06:49 | |
| *** wolverineav has joined #openstack-nova | 06:53 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 06:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 06:57 |
| *** wolverineav has quit IRC | 06:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 06:58 |
| *** Luzi has joined #openstack-nova | 07:02 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:06 | |
| *** tkajinam_ has quit IRC | 07:14 | |
| *** pbing19 has joined #openstack-nova | 07:17 | |
| *** Dinesh_Bhor has quit IRC | 07:27 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:27 | |
| *** tkajinam has joined #openstack-nova | 07:28 | |
| *** tkajinam_ has joined #openstack-nova | 07:29 | |
| *** tkajinam has quit IRC | 07:32 | |
| *** markvoelker has joined #openstack-nova | 07:40 | |
| *** maciejjozefczyk has quit IRC | 07:40 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 07:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 07:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 07:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 07:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 07:42 |
| *** matoef1 has joined #openstack-nova | 07:47 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:55 | |
| *** pbing19 has quit IRC | 07:57 | |
| *** wolverineav has joined #openstack-nova | 07:58 | |
| *** bhagyashris has joined #openstack-nova | 07:58 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 07:59 |
| *** pbing19 has joined #openstack-nova | 08:00 | |
| *** rpittau has joined #openstack-nova | 08:04 | |
| matoef1 | Hi Folks, | 08:06 |
| matoef1 | After anabling SSL on all devstack endpoints. I'm unable to create cluster, because NOVA returns 400 HTTP status (user_data too long) to the HEAT. But my user_data size is under 64K. Message from NOVA: http://paste.openstack.org/show/745137/ | 08:06 |
| matoef1 | Event and resource lists and nova, heat versions: http://paste.openstack.org/show/745139/ | 08:06 |
| matoef1 | Thank you in advance for any help you can provide. | 08:06 |
| *** ade_lee_ has quit IRC | 08:08 | |
| *** ade_lee_ has joined #openstack-nova | 08:08 | |
| *** rchurch has quit IRC | 08:09 | |
| *** manjeets has quit IRC | 08:09 | |
| *** rchurch has joined #openstack-nova | 08:09 | |
| *** manjeets has joined #openstack-nova | 08:11 | |
| *** markvoelker has quit IRC | 08:12 | |
| *** awalende has joined #openstack-nova | 08:13 | |
| *** ade_lee_ has quit IRC | 08:14 | |
| *** ade_lee_ has joined #openstack-nova | 08:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 08:17 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 08:18 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 08:18 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 08:18 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 08:19 |
| *** tkajinam_ has quit IRC | 08:20 | |
| *** tesseract has joined #openstack-nova | 08:22 | |
| *** yikun has quit IRC | 08:25 | |
| *** tssurya has joined #openstack-nova | 08:39 | |
| *** mcgiggler has joined #openstack-nova | 08:45 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 08:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 08:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 08:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Add description of custom resource classes https://review.openstack.org/619125 | 08:53 |
| *** takashin has left #openstack-nova | 09:03 | |
| *** xek has joined #openstack-nova | 09:05 | |
| *** erlon_ has joined #openstack-nova | 09:06 | |
| *** markvoelker has joined #openstack-nova | 09:10 | |
| *** ccamacho has joined #openstack-nova | 09:10 | |
| *** priteau has joined #openstack-nova | 09:20 | |
| gibi | efried: nice catch about the lock copy. | 09:21 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507 | 09:24 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD https://review.openstack.org/632514 | 09:24 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Rewrite _create_pty_device() to be clearer https://review.openstack.org/637152 | 09:24 |
| gibi | efried: I read back your discussion with mriedem about the VCPU handling in the request_groups | 09:25 |
| gibi | efried: there is a note in the code where the field is initialized which is the place where the unnumbered group (VCPU and the rest) should be added | 09:26 |
| gibi | efried: I can add another note to the definition of the field but that note will be in a place that doesn't need to be changed when the actuall refactor adds the unnumbered group to the list so that note will be subject to drift | 09:27 |
| *** derekh has joined #openstack-nova | 09:28 | |
| *** zhanglong has joined #openstack-nova | 09:32 | |
| *** zhanglong has left #openstack-nova | 09:32 | |
| *** moshele has joined #openstack-nova | 09:41 | |
| *** markvoelker has quit IRC | 09:42 | |
| *** awalende has quit IRC | 09:45 | |
| *** bhagyashris has quit IRC | 09:47 | |
| *** awalende has joined #openstack-nova | 09:47 | |
| *** ccamacho has quit IRC | 09:48 | |
| *** ccamacho has joined #openstack-nova | 09:48 | |
| *** awalende has quit IRC | 09:52 | |
| *** awalende has joined #openstack-nova | 09:54 | |
| *** erlon_ has quit IRC | 09:56 | |
| *** Dinesh_Bhor has quit IRC | 09:58 | |
| *** ralonsoh has joined #openstack-nova | 10:07 | |
| *** dtantsur|afk is now known as dtantsur | 10:09 | |
| *** erlon has joined #openstack-nova | 10:24 | |
| *** ociuhandu has joined #openstack-nova | 10:24 | |
| *** liumk2233 has quit IRC | 10:30 | |
| *** liumk2233 has joined #openstack-nova | 10:30 | |
| *** erlon has quit IRC | 10:31 | |
| *** sridharg has quit IRC | 10:32 | |
| *** priteau has quit IRC | 10:33 | |
| *** moshele has quit IRC | 10:33 | |
| *** moshele has joined #openstack-nova | 10:34 | |
| *** cdent has joined #openstack-nova | 10:36 | |
| *** markvoelker has joined #openstack-nova | 10:39 | |
| *** sridharg has joined #openstack-nova | 10:46 | |
| *** erlon has joined #openstack-nova | 10:52 | |
| *** erlon has quit IRC | 10:52 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591 | 10:52 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | 10:52 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 10:52 |
| *** erlon has joined #openstack-nova | 10:53 | |
| *** erlon has quit IRC | 10:54 | |
| *** erlon has joined #openstack-nova | 10:54 | |
| *** erlon has quit IRC | 10:54 | |
| *** erlon has joined #openstack-nova | 10:55 | |
| *** moshele has quit IRC | 10:56 | |
| *** ileixe has quit IRC | 10:56 | |
| *** pbing19 has quit IRC | 11:00 | |
| *** pbing19 has joined #openstack-nova | 11:00 | |
| *** cdent has quit IRC | 11:02 | |
| *** cdent has joined #openstack-nova | 11:06 | |
| *** yan0s has joined #openstack-nova | 11:08 | |
| *** sridharg has quit IRC | 11:08 | |
| *** brinzhang has quit IRC | 11:10 | |
| *** wolverineav has quit IRC | 11:11 | |
| *** markvoelker has quit IRC | 11:13 | |
| gibi | jaypipes, efried: responded in https://review.openstack.org/#/c/616239 . I will respin the patch with some fixes you suggested | 11:13 |
| *** moshele has joined #openstack-nova | 11:17 | |
| rha | Is anybody here who could to a review on: https://review.openstack.org/#/c/420026 please? | 11:21 |
| *** tbachman has quit IRC | 11:22 | |
| *** moshele has quit IRC | 11:32 | |
| *** _alastor_ has joined #openstack-nova | 11:45 | |
| *** moshele has joined #openstack-nova | 11:45 | |
| *** _alastor_ has quit IRC | 11:50 | |
| *** tbachman has joined #openstack-nova | 11:52 | |
| *** liumk2233 has quit IRC | 11:55 | |
| *** moshele has quit IRC | 12:04 | |
| *** markvoelker has joined #openstack-nova | 12:10 | |
| *** tiendc has quit IRC | 12:10 | |
| *** janki has quit IRC | 12:16 | |
| *** tbachman has quit IRC | 12:22 | |
| *** avolkov has joined #openstack-nova | 12:22 | |
| *** pbing19 has quit IRC | 12:22 | |
| *** pbing19 has joined #openstack-nova | 12:25 | |
| *** Luzi has quit IRC | 12:29 | |
| *** pbing19 has quit IRC | 12:30 | |
| *** pbing19 has joined #openstack-nova | 12:33 | |
| *** lpetrut has joined #openstack-nova | 12:40 | |
| *** markvoelker has quit IRC | 12:42 | |
| *** raghav has quit IRC | 12:43 | |
| *** ratailor has quit IRC | 12:43 | |
| *** ccamacho has quit IRC | 12:55 | |
| *** ccamacho has joined #openstack-nova | 12:55 | |
| *** whoami-rajat has quit IRC | 12:57 | |
| openstackgerrit | hyunsik Yang proposed openstack/nova stable/pike: Manage Compute services in nova manual typos https://review.openstack.org/637178 | 12:58 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 13:03 |
| *** pbing19 has quit IRC | 13:11 | |
| *** thgcorrea has joined #openstack-nova | 13:16 | |
| *** dave-mccowan has joined #openstack-nova | 13:18 | |
| jaypipes | rha: wow, >2 year old patch... sure, I'll take a look. | 13:22 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:24 |
| rha | jaypipes: Yeah, it has quite a history already :). Thanks! | 13:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:24 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657 | 13:25 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 13:25 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add context.target_cell() stub to DownCellFixture https://review.openstack.org/637182 | 13:25 |
| jangutter | rha: Ah, SIGHUP and how it seems to screw everyone over.... | 13:25 |
| jaypipes | gibi: ok, cool. my recommendation made sense then? | 13:27 |
| gibi | jaypipes: renaming and func docing for sure, the actual algo change not so much | 13:28 |
| *** mriedem has joined #openstack-nova | 13:34 | |
| *** psachin has quit IRC | 13:36 | |
| *** efried is now known as fried_rice | 13:37 | |
| fried_rice | o/ | 13:37 |
| fried_rice | gibi: I agree about the drift in that comment, but I feel like it's a chance worth taking, since it's SO non-obvious. | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:38 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:38 |
| gibi | fried_rice: I've added a NOTE :) | 13:38 |
| fried_rice | thank you | 13:38 |
| fried_rice | Did you rebase on latest master by chance? | 13:38 |
| gibi | fried_rice: yes | 13:39 |
| fried_rice | nice | 13:39 |
| gibi | fried_rice: there was some merge conflict in the middle due to os-resource-classes | 13:39 |
| gibi | now everything is shiny | 13:39 |
| fried_rice | Sundar and I are working on cyborg stuff, and need to base it on your bottom couple of patches, and there was merge conflict on exactly that, so that'll clear it up for us. Thanks. | 13:39 |
| *** markvoelker has joined #openstack-nova | 13:39 | |
| gibi | fried_rice: yeah I saw that cyborg patches appeared on top of my series hope you can reuse some of my stuff | 13:40 |
| *** whoami-rajat has joined #openstack-nova | 13:41 | |
| fried_rice | gibi: that's the plan. I'm really glad you led the charge with that. | 13:41 |
| *** awaugama has joined #openstack-nova | 13:42 | |
| *** awaugama_ has joined #openstack-nova | 13:43 | |
| *** awaugama_ has quit IRC | 13:43 | |
| *** moshele has joined #openstack-nova | 13:44 | |
| *** awaugama has quit IRC | 13:45 | |
| *** awaugama has joined #openstack-nova | 13:45 | |
| gibi | fried_rice: cool | 13:45 |
| cdent | feels like a nice rush of progress lately. exciting. | 13:46 |
| *** moshele has quit IRC | 13:47 | |
| *** dpawlik has quit IRC | 13:49 | |
| gibi | let's break nova before the feature freeze ;) | 13:50 |
| *** dpawlik has joined #openstack-nova | 13:50 | |
| cdent | \o/ | 13:50 |
| cdent | breaking things is a great way to make things beter | 13:50 |
| bauzas | please, no. | 13:55 |
| *** sapd1 has quit IRC | 13:55 | |
| bauzas | I was off most of this cycle because $bugs | 13:55 |
| gibi | bauzas: we making your job security better :) | 13:56 |
| bauzas | remember, when you say "it's good to merge first and then see bugs", some people are actually doing bugs | 13:56 |
| bauzas | gibi: well, no | 13:56 |
| bauzas | gibi: being off upstream is bad for me :( | 13:56 |
| bauzas | of course, it's nice for our customers | 13:56 |
| bauzas | but tbh, I prefer to be conservative and not have bugs because we tried to merge very quickly without verifying | 13:57 |
| bauzas | so customers would be happy and *I* would be happy | 13:57 |
| gibi | bauzas: do you have an overall feeling that openstack produced more bugs lately than before? or what changed is that you are more involved with customer support | 13:57 |
| bauzas | for placement and instance groups ? surely | 13:58 |
| *** agopi_ is now known as agopi | 13:58 | |
| bauzas | what folks don't know if that most of our customers were using Newton until 6 months ago | 13:59 |
| bauzas | now they use Queens | 13:59 |
| cdent | so clearly any changes we are making now aren't really all that relevant | 13:59 |
| bauzas | cdent: until the next year, for sure | 13:59 |
| bauzas | but then ? | 13:59 |
| bauzas | unless you want me going to another company... /o\ | 13:59 |
| *** lbragstad has joined #openstack-nova | 14:00 | |
| gibi | bauzas: do you see some missing test coverage what OpenStack should add to avoid some of your painfull bugs? | 14:01 |
| bauzas | good question | 14:01 |
| *** mlavalle has joined #openstack-nova | 14:02 | |
| bauzas | what I know is that we have less people working on OpenStack | 14:02 |
| bauzas | so, for example, if we have a problem, only a few from our team could help to fixing it | 14:03 |
| bauzas | also, we have less operators testing OpenStack | 14:03 |
| bauzas | so, somehow, it means that when we merge something, we discover bugs later | 14:03 |
| bauzas | than previously | 14:03 |
| bauzas | now, the real question is : if we were having better test coverage, would that be better ? oh yes, of course | 14:04 |
| bauzas | but | 14:04 |
| bauzas | we would still miss bugs | 14:04 |
| bauzas | so at the end of the day, that would still impact us | 14:05 |
| gibi | yeah, I feel the less people part too. Unfortunately half of the reason I'm paid to work on OpenStack is doing features, so I cannot just say no to feature work :/ | 14:06 |
| *** dpawlik has quit IRC | 14:06 | |
| bauzas | of course | 14:07 |
| bauzas | we're all paid by customers | 14:07 |
| bauzas | I'm not saying no to features | 14:07 |
| bauzas | tbc, I just provided my opinion now because it was looking that we were not thinking about what means us quickly merging things | 14:08 |
| kashyap | bauzas: Not quite; less features, more on: maintainability, stability, robustness, performance (a feature) | 14:08 |
| bauzas | the reshape series is a good example | 14:08 |
| bauzas | I wish I could have worked earlier on it | 14:08 |
| kashyap | And ... "don't fall apart if you sneeze", so on | 14:08 |
| *** dpawlik has joined #openstack-nova | 14:08 | |
| * kashyap jumped in randomly on just the last point "not saying no to features", without reading the full context | 14:09 | |
| bauzas | so, now, I'm just triying to test a lot of things | 14:09 |
| bauzas | to make sure we don't have problems | 14:09 |
| cdent | I reckon things could be improved quite a bit if there was a closer tie between the code being worked on now and people using it so that there were more people making sure it was okay | 14:09 |
| bauzas | anyway, back to https://review.openstack.org/#/c/636591/3/nova/virt/libvirt/driver.py | 14:09 |
| cdent | that time-related disconnect is a problem | 14:10 |
| bauzas | cdent: I agree with you | 14:10 |
| gibi | cdent: true | 14:10 |
| cdent | but it is also a problem that our systems are so complex (much of the time) that they are hard to test and experiment with | 14:10 |
| bauzas | it's difficult since we have some time between the merge and the usage | 14:10 |
| cdent | it would be nice to figure out a way to change that | 14:10 |
| bauzas | cdent: heh, Nova is 2M LOCs AFAIK | 14:10 |
| *** eharney has joined #openstack-nova | 14:10 | |
| cdent | ouch | 14:10 |
| cdent | well I've done my part to make nova smaller, I hope someone else will too | 14:11 |
| cdent | brb | 14:11 |
| gibi | cdent: our downstream development switched from mitaka to pike recently and that already helped me to get actionable feedback from the downstream teams | 14:11 |
| bauzas | anyway, we're diverting a lot now from real work | 14:11 |
| bauzas | it's more an hallways discussion or a PTG one if you prefer | 14:11 |
| bauzas | but I'm very sad to not have time to help more Nova | 14:11 |
| bauzas | like for example, doing upstream bug triage | 14:12 |
| *** markvoelker has quit IRC | 14:12 | |
| *** _alastor_ has joined #openstack-nova | 14:19 | |
| *** maciejjozefczyk has quit IRC | 14:24 | |
| mriedem | dansmith: i'm +1 on the down cell series up through the api change https://review.openstack.org/#/c/591657/ just waiting on zuul results if you want to step through those today | 14:28 |
| belmoreira | mriedem: dansmith: does it make sense? https://bugs.launchpad.net/nova/+bug/1816034 or I'm missing something? | 14:29 |
| openstack | Launchpad bug 1816034 in OpenStack Compute (nova) "Ironic flavor migration and default resource classes" [Undecided,New] | 14:29 |
| dansmith | mriedem: cool, I meant to get to them yesterday and got distracted | 14:30 |
| dansmith | belmoreira: mriedem probably remembers better than I, but there was something recently about this | 14:31 |
| mriedem | belmoreira: and you have this enabled yes? https://review.openstack.org/#/c/609043/ | 14:38 |
| mriedem | which is probably why the ironic driver isn't reporting standard resource class inventory | 14:38 |
| *** lpetrut has quit IRC | 14:39 | |
| *** ociuhandu_ has quit IRC | 14:41 | |
| *** ociuhandu_ has joined #openstack-nova | 14:42 | |
| *** maciejjozefczyk has joined #openstack-nova | 14:43 | |
| mriedem | i wonder if we should just set IronicDriver.requires_allocation_refresh = not CONF.workarounds.report_ironic_standard_resource_class_inventory | 14:44 |
| mriedem | because if we're not going to report the standard inventory we shouldn't try to put allocations for those standard inventory resource classes | 14:45 |
| openstackgerrit | Merged openstack/nova master: Libvirt: do not set MAC when unplugging macvtap VF https://review.openstack.org/624842 | 14:46 |
| belmoreira | mriedem: is set to False | 14:46 |
| mriedem | yeah so i think simply setting IronicDriver.requires_allocation_refresh = not CONF.workarounds.report_ironic_standard_resource_class_inventory would fix the issue | 14:47 |
| mriedem | err, | 14:47 |
| mriedem | nix the 'not' | 14:47 |
| mriedem | that's probably easier than mucking with the _pike_flavor_migration code in stable branches since that code is all gone in stein | 14:48 |
| *** awalende has quit IRC | 14:49 | |
| belmoreira | mriedem: not sure if I'm following. What you are suggesting is to disable IronicDriver.requires_allocation_refresh | 14:49 |
| mriedem | correct, which is what you said you did as a workaround in the bug | 14:50 |
| *** thgcorrea has quit IRC | 14:51 | |
| mriedem | unless that will regress the fix for bug 1724589 somehow | 14:52 |
| openstack | bug 1724589 in OpenStack Compute (nova) pike "Unable to transition to Ironic Node Resource Classes in Pike" [High,Fix committed] https://launchpad.net/bugs/1724589 - Assigned to Matt Riedemann (mriedem) | 14:52 |
| *** dpawlik has quit IRC | 14:52 | |
| *** dpawlik has joined #openstack-nova | 14:53 | |
| belmoreira | mriedem: we are fixing this in our instances_extra because we will need to recreate the allocations/RP. To make sure RP will not not change uuid in a sharded nova-compute setup with ironic | 14:54 |
| belmoreira | otherwise allocations will not be recreated | 14:54 |
| mriedem | you mean for old instances | 14:54 |
| mriedem | otherwise the scheduler would create the allocations | 14:54 |
| belmoreira | yes, for old instances | 14:55 |
| belmoreira | because I would like to have https://review.openstack.org/#/c/571535/ | 14:57 |
| mriedem | and it looks like http://git.openstack.org/cgit/openstack/nova/tree/nova/scheduler/client/report.py#n136 will do the right thing and filter out any allocations from the flavor that are 0 | 14:58 |
| mriedem | so requires_allocation_refresh can remain true and only report the custom node resource class allocation | 14:58 |
| mriedem | and the driver will only report custom resource class inventory since CONF.workarounds.report_ironic_standard_resource_class_inventory=False | 14:58 |
| belmoreira | yes | 14:59 |
| mriedem | so i guess this whole thing was missed when the code was dropped | 14:59 |
| mriedem | https://github.com/openstack/nova/blob/stable/rocky/nova/virt/ironic/driver.py#L554 | 14:59 |
| mriedem | "This code can be removed in Queens, and will need to be updated to also alter extra_specs to zero-out the old-style standard resource classes of VCPU, MEMORY_MB, and DISK_GB." | 14:59 |
| mriedem | heh, "remove this code, but also change it" | 14:59 |
| belmoreira | I guess existing ironic deployments will hit this when they upgrade to rocky. The impact depends in their expectations and config | 15:00 |
| mriedem | yeah so CONF.workarounds.report_ironic_standard_resource_class_inventory=False actually causes a problem | 15:01 |
| mriedem | fixes one issue, exposes another | 15:01 |
| *** thgcorrea has joined #openstack-nova | 15:01 | |
| mriedem | dansmith: jaypipes: jroll: edleafe: do you remember why we didn't just zero out the standard resource classes on embedded instance.flavor for ironic instances in the first place? | 15:03 |
| mriedem | i.e. https://github.com/openstack/nova/blob/stable/rocky/nova/virt/ironic/driver.py#L554 | 15:03 |
| edleafe | mriedem: IIRC, it was for display purposes | 15:03 |
| edleafe | the flavor would show what the user would get | 15:04 |
| mriedem | but can't we still have that *and* override by setting resources:VCPU=0? | 15:04 |
| *** dpawlik has quit IRC | 15:05 | |
| *** matoef1 has quit IRC | 15:05 | |
| mriedem | https://docs.openstack.org/nova/latest/user/flavors.html | 15:05 |
| mriedem | "Custom resource classes and standard resource classes to override" | 15:05 |
| mriedem | yeah | 15:05 |
| mriedem | resources:CUSTOM_BAREMETAL_SMALL=1 resources:VCPU=0 | 15:05 |
| edleafe | That was how it was supposed to be done. Keep the values in the flavor, and zero out in extra_specs | 15:06 |
| mriedem | ok i don't know why that standard resource class 0 override wasn't done at the same time as the embedded instance.flavor migration once the node was reporting a custom resource class | 15:06 |
| mriedem | plus that's what the ironic docs tell operators to do https://docs.openstack.org/ironic/latest/install/configure-nova-flavors | 15:07 |
| edleafe | mriedem: https://docs.openstack.org/ironic/latest/install/configure-nova-flavors describes it pretty well | 15:07 |
| edleafe | jinx | 15:07 |
| dansmith | mriedem: yeah, for display and to avoid triggering any of our other magic behaviors with a value is zero, like root size | 15:08 |
| mriedem | sure but we can override via the extra spec | 15:09 |
| *** thgcorrea has quit IRC | 15:09 | |
| mriedem | that seems to be the missing piece | 15:09 |
| mriedem | now whether or not the code that's reporting allocations actually looks at that override... | 15:09 |
| dansmith | right, the point being.. leave the real values for display, override what we actually ask for in the resource overrides | 15:09 |
| *** markvoelker has joined #openstack-nova | 15:10 | |
| *** takamatsu has joined #openstack-nova | 15:10 | |
| mriedem | ok i think this is where the override happens https://github.com/openstack/nova/blob/stable/rocky/nova/scheduler/utils.py#L366 | 15:11 |
| *** thgcorrea has joined #openstack-nova | 15:14 | |
| *** bnemec is now known as bnemec-pto | 15:16 | |
| *** dpawlik has joined #openstack-nova | 15:17 | |
| *** mchlumsky has joined #openstack-nova | 15:18 | |
| *** ratailor has joined #openstack-nova | 15:18 | |
| *** lbragstad is now known as elbragstad | 15:19 | |
| *** cfriesen has joined #openstack-nova | 15:19 | |
| *** _alastor_ has quit IRC | 15:19 | |
| mriedem | belmoreira: ok i'm working on a patch which you can take a look at - knowing this isn't all totally fubar will require a functional test though given how tightly coupled all of this is between the virt driver, resource tracker and scheduler | 15:22 |
| *** dpawlik has quit IRC | 15:22 | |
| *** yan0s has quit IRC | 15:23 | |
| *** BlackDex_ is now known as BlackDex | 15:28 | |
| *** maciejjozefczyk has quit IRC | 15:28 | |
| *** ratailor has quit IRC | 15:30 | |
| *** jistr is now known as jistr|mtg | 15:32 | |
| *** kmalloc is now known as needscoffee | 15:32 | |
| belmoreira | mriedem: thanks | 15:37 |
| mriedem | the commit message on this is going to be fun | 15:38 |
| mriedem | "first belmiro lost a finger here, and then he blew off a toe here" | 15:38 |
| belmoreira | as you may noticed I upgraded nova-compute for ironic only today :) as been an interesting day | 15:39 |
| belmoreira | the next issue is: https://bugs.launchpad.net/nova/+bug/1816086 | 15:40 |
| openstack | Launchpad bug 1816086 in OpenStack Compute (nova) "Resource Tracker performance with Ironic driver" [Undecided,New] | 15:40 |
| fried_rice | uh oh | 15:41 |
| fried_rice | I thought I fixed that. belmoreira are you using latest master? | 15:41 |
| mriedem | he's upgrading ironic queens to rocky i assume | 15:42 |
| mriedem | for compute services | 15:42 |
| mriedem | so they would have had to backport your patches | 15:42 |
| fried_rice | oh, that'd do it | 15:42 |
| fried_rice | yeah | 15:42 |
| *** maciejjozefczyk has joined #openstack-nova | 15:42 | |
| *** markvoelker has quit IRC | 15:42 | |
| belmoreira | I'm using rocky (back ported the patches that we discussed in the past) | 15:42 |
| melwitt | 15:43 | |
| belmoreira | fried_rice: so what I'm saying in the bug doesn't make sense anymore? | 15:45 |
| fried_rice | belmoreira: Backported which patches, though? | 15:45 |
| belmoreira | we couldn't cherrypick the patches in a clean way, we may have missed something | 15:45 |
| fried_rice | belmoreira: Latest master has changes that made sure to only update the ironic node being touched. | 15:45 |
| fried_rice | let me find the patch that did that... | 15:46 |
| fried_rice | belmoreira: https://review.openstack.org/#/c/615677/ | 15:47 |
| fried_rice | belmoreira: I think if you picked that up prior to about PS17, you would have the ironic explosion behavior you're seeing. But after that it *should* be fixed. | 15:49 |
| jaypipes | gibi: hmm, couldn't my algorithm work if we just sorted the request groups in descending order of amount of resources being requested in the group? | 15:49 |
| jaypipes | gibi: then the "greedy" approach would work fine, no? | 15:49 |
| *** mrjk has joined #openstack-nova | 15:49 | |
| fried_rice | belmoreira: and I know you guys were picking up that series at various points along the way | 15:49 |
| gibi | jaypipes: if only one resource class would be used then yes, but if you have two resource classes requested then which one would sorted first? | 15:49 |
| fried_rice | jaypipes: I didn't feel strongly enough to say so in the review, but fwiw I liked gibi's algorithm as is. | 15:50 |
| jaypipes | gibi: do we have tests that show the behaviour or your algorithm is correct for such situations? | 15:50 |
| belmoreira | fried_rice: thanks, I'm checking | 15:50 |
| tssurya | fried_rice: porting was done after that patch got merged | 15:50 |
| jaypipes | fried_rice: it's difficult to read and understand, IMHO. | 15:50 |
| fried_rice | tssurya: roger that, thanks. | 15:50 |
| fried_rice | jaypipes: I don't disagree, but I'm not sure yours is more readable/understandable. (It is to you because you formulated it.) | 15:51 |
| jaypipes | fried_rice: as is most things around multiple use_single_provider request groups, FWIW | 15:51 |
| gibi | jaypipes: it worth to step through https://review.openstack.org/#/c/616239/26/nova/tests/unit/objects/test_request_spec.py@1305 | 15:51 |
| fried_rice | tssurya: How far up the series did you port? | 15:52 |
| gibi | jaypipes: there group1 could be fit first to 3 RPs but finally only the RP #3 leads to solution | 15:52 |
| jaypipes | fried_rice, gibi: this all just leaves an odd taste in my mouth. | 15:54 |
| jaypipes | fried_rice, gibi: a taste that says "oh, we're totally leaking the placement selection details out of the placement API" | 15:54 |
| gibi | jaypipes: totally agree | 15:54 |
| jaypipes | and yes, I understand this is a workaround | 15:54 |
| fried_rice | jaypipes: Yeah, it sucks, but is hopefully temporary, to be whacked when placement lets ... just so | 15:54 |
| jaypipes | until such point that the result of allocation_candidates contains an indicator of which request group "belongs" to which allocation provider | 15:55 |
| gibi | jaypipes: yes | 15:55 |
| fried_rice | So let's get that spec pushed through so we can implement it early in Train and get rid of this spaghetti. | 15:55 |
| jaypipes | ack, ok | 15:55 |
| gibi | fried_rice: unfortunately I cannot focus both on that spec and the bandwidth series at the same time (I'm limited) | 15:56 |
| gibi | fried_rice: but after feature freeze I can update the spec | 15:56 |
| fried_rice | gibi: Would you like me to take over that spec? | 15:56 |
| jaypipes | gibi, fried_rice: question for you... are different request groups containing same resource class requests guaranteed to land on different resource providers? | 15:56 |
| gibi | fried_rice: if it is OK to push it after the feature freeze then I'd like to keep the spec | 15:56 |
| jaypipes | (I can never remember...) | 15:56 |
| fried_rice | jaypipes: if group_policy=none, no | 15:56 |
| jaypipes | ah, yes, group_policy=isolate.. | 15:57 |
| jaypipes | gibi, fried_rice: is group_policy=isolate taken account of in this mapping patch? | 15:57 |
| fried_rice | gibi: okay. Yes, that should be fine. Just lmk if you want help (other than review) | 15:57 |
| fried_rice | jaypipes: oo, good question. | 15:57 |
| jaypipes | or does it even need to be? /shurg | 15:57 |
| gibi | fried_rice: thanks, I will need you review! :) | 15:57 |
| *** jangutter has quit IRC | 15:58 | |
| fried_rice | jaypipes: I think it might need to be, yes. | 15:58 |
| gibi | jaypipes, fried_rice: bahh, good question | 15:58 |
| belmoreira | fried_rice: what is taking time is the last for in the update_from_provider_tree | 15:58 |
| fried_rice | as is, gibi's algorithm takes the first of many possible matchups; but it assumes group_policy=none | 15:58 |
| jaypipes | yeah | 15:58 |
| belmoreira | https://github.com/openstack/nova/blob/d231a420d0d4865bb19da513af416cb8bc89010f/nova/scheduler/client/report.py#L1439 | 15:59 |
| gibi | fried_rice, jaypipes: if the request was made with isolate but the algo founds an overlapping solution then we are screwed | 15:59 |
| gibi | fried_rice: correct | 15:59 |
| gibi | fried_rice: so I have to enhance this algo | 15:59 |
| gibi | fried_rice: to handle isolate | 15:59 |
| gibi | fried_rice: and in that case throw away overlapping solutions | 15:59 |
| fried_rice | gibi: correct | 16:00 |
| jaypipes | gibi, fried_rice: well, maybe... maybe not. :) after all, we *KNOW* that the returned allocations properly meet the group_policy=isolate constraint because the placement service is shown to be correct in that. | 16:00 |
| * gibi needs to craft examples | 16:00 | |
| fried_rice | mm, nooo, I still think there's a hole | 16:00 |
| jaypipes | so we can assume that the provider that is assigned a particular amount of allocated resources does not have any "doubled up" allocations from multiple request groups, right? | 16:01 |
| gibi | in case of isolate, yes | 16:01 |
| fried_rice | belmoreira: noted | 16:01 |
| jaypipes | this is what's "eww" about this... :) it's essentially needing to re-implement the entire request group selection algorithm that's in the placement service already. :) | 16:01 |
| fried_rice | belmoreira: because new_uuids == {every ironic node} | 16:02 |
| fried_rice | jaypipes: Exactly. | 16:02 |
| gibi | jaypipes: you are totatlly right | 16:02 |
| belmoreira | fried_rice: correct | 16:02 |
| fried_rice | jaypipes: and we haven't even done forbidden traits and aggregates yet | 16:02 |
| gibi | fried_rice: and I hope we never have to in this algo | 16:02 |
| fried_rice | belmoreira: set_inventory_for_provider et al should be shorting out, not talking to the placement API, for any but the changed node. Are you seeing those hit placement? | 16:03 |
| gibi | so I need to found an example where there is two possible valid mapping one with overlap between groups and one without. If I can make such an example then I need to change the algo | 16:03 |
| fried_rice | belmoreira: Because https://github.com/openstack/nova/blob/d231a420d0d4865bb19da513af416cb8bc89010f/nova/scheduler/client/report.py#L920-L924 | 16:04 |
| fried_rice | gibi: ++. If anyone can do it... | 16:04 |
| * gibi wondering why these issues surface at Friday after 5 pm | 16:04 | |
| jaypipes | gibi, fried_rice: so, thinking through the group_policy=isolate case... as mentioned, we can assume that placement returned allocations of same-resource-class requests against *different* providers so I don't think we need to modify this algorithm to account for group_policy=isolate, because there's no way the algorithm *could* place amounts of the same resource class on the same provider. | 16:04 |
| *** jistr|mtg is now known as jistr | 16:04 | |
| jaypipes | gibi: sorry :( | 16:05 |
| gibi | jaypipes: don't be sorry, you found a deep question here | 16:05 |
| gibi | jaypipes: so I'm glad | 16:05 |
| jaypipes | gibi: I'm not sure it's actually a scenario we need to be concerned about. :) | 16:05 |
| gibi | jaypipes: it is just murphy's law | 16:05 |
| jaypipes | heh | 16:06 |
| gibi | isolate is global for the whole request, isn't it? | 16:06 |
| fried_rice | yes | 16:06 |
| gibi | so every group will have its own RP in the allocaton | 16:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: ironic: complete the flavor data migration started in pike https://review.openstack.org/637217 | 16:06 |
| mriedem | belmoreira: jaypipes: dansmith: edleafe: ^ probably the most detailed commit message ever | 16:06 |
| mriedem | jroll: ^ | 16:06 |
| gibi | and the size of the allocation is always the size of the request | 16:07 |
| gibi | so there is no way that in this allocation an overlapping mapping can be found | 16:07 |
| gibi | because overlap means the size of an allocation is at least the size of two request | 16:08 |
| gibi | so even if a partial solution found with overlap, the remaining RPs cannot fulfill the remaining groups | 16:08 |
| fried_rice | gibi: right, I think you would either end up short an allocation, or short a provider. | 16:09 |
| *** jaypipes is now known as leakypipes | 16:09 | |
| gibi | fried_rice: yeah, feels like it | 16:09 |
| mriedem | mgoddard: johnthetubaguy: you might also care about https://review.openstack.org/#/c/637217/ | 16:09 |
| * leakypipes hands mriedem a cookie (where's hansmoleman!?) | 16:09 | |
| fried_rice | so, maybe safe by serendipity | 16:09 |
| leakypipes | gibi: exactly my thoughts. | 16:10 |
| leakypipes | fried_rice: ya | 16:10 |
| mgoddard | mriedem: that looks like something I would care about, adding to review list | 16:10 |
| leakypipes | fried_rice: well, not necessarily serendipity. safe due to placement's alloc cands selection algorithm already working properly :) | 16:10 |
| gibi | leakypipes, fried_rice: OK, I still write up a partial overlap case to see that I'm right | 16:11 |
| *** takamatsu_ has joined #openstack-nova | 16:11 | |
| *** takamatsu has quit IRC | 16:12 | |
| gibi | https://etherpad.openstack.org/p/CdbhX84nKI | 16:13 |
| gibi | leakypipes, fried_rice: I think I rest my case now | 16:13 |
| belmoreira | fried_rice: yes, we have those changes. I think is simple the iteration... | 16:15 |
| fried_rice | belmoreira: I'm asking whether you're seeing 1700x3 calls to placement from that loop, or if all the thrashing is happening locally | 16:18 |
| mriedem | tssurya: you can drop your -W on https://review.openstack.org/#/c/635146/ | 16:18 |
| *** artom has quit IRC | 16:19 | |
| belmoreira | fried_rice: we don't see placement calls in the loop | 16:19 |
| fried_rice | belmoreira: I find it hard to imagine that 5100 local dict compares on the ProviderTree are taking 6h | 16:19 |
| fried_rice | wow | 16:19 |
| leakypipes | gibi: yep, the current algo in the mapping patch does indeed have the possibility of assigning the same RP to different groups erroneously. :( | 16:20 |
| leakypipes | Well, cool, I'm glad my rambling and injection of nonsense into this conversation has resulted in something of actual value. | 16:20 |
| fried_rice | belmoreira: Good thing ProviderTree isn't an ovo :P | 16:20 |
| leakypipes | job done. weekend awaits. | 16:20 |
| belmoreira | fried_rice: is not 5100 compares | 16:21 |
| tssurya | mriedem: thanks a lot! done | 16:22 |
| fried_rice | belmoreira: Based on: 1700 iterations of the loop; each loop is doing three set_*_for_provider()s; and each set_*_for_provider is asking ProviderTree.has_*_changed() | 16:23 |
| fried_rice | (ugh, my IRC client made a mess of that) | 16:23 |
| fried_rice | ohhh | 16:24 |
| fried_rice | So, here's a thing. | 16:24 |
| fried_rice | The roots are stored in a list | 16:24 |
| fried_rice | which we're iterating over to find the one we're asking about | 16:24 |
| fried_rice | O(N) just to find the provider to do the compare on. | 16:24 |
| fried_rice | So O(N^2) for that loop. | 16:24 |
| fried_rice | Times three. | 16:25 |
| *** takamatsu_ has quit IRC | 16:25 | |
| fried_rice | belmoreira: You have a way to shove in a patch and test this easily? | 16:25 |
| tssurya | dansmith, mriedem: yes !!! thanks a lot for the reviews on the API changes :) and sorry for giving such a hard time on that series :D but I am seriously happy that's done. I will respin something for the nits | 16:25 |
| gibi | leakypipes, fried_rice: thanks | 16:25 |
| belmoreira | fried_rice: I just did it... in the | 16:25 |
| mriedem | tssurya: no problem, it's a complicated change | 16:25 |
| mriedem | now just figure out how to not grind the API on startup when there is a down cell | 16:26 |
| mriedem | :) | 16:26 |
| tssurya | haha yea | 16:26 |
| dansmith | tssurya: np, thanks for your persistence | 16:27 |
| belmoreira | efried_rice: for the "updated_from_provider_tree" I'm also passing the compute_node and removed the last "for". It only to update/check that resource provider | 16:28 |
| *** takamatsu_ has joined #openstack-nova | 16:28 | |
| *** TxGirlGeek has joined #openstack-nova | 16:28 | |
| *** maciejjozefczyk has quit IRC | 16:28 | |
| fried_rice | belmoreira: That would be one way to do it. | 16:29 |
| fried_rice | belmoreira: care to push that patch? | 16:29 |
| fried_rice | belmoreira: But I don't think that's a generic solution long-term. I think it's going to break as soon as we have shared storage providers, for example. | 16:30 |
| fried_rice | belmoreira: Let me play with the efficiency of ProviderTree itself and see if I can't get that loop a lot tighter... | 16:30 |
| belmoreira | fried_rice: ohh no! this was emergency mode :) just to keep Ironic alive | 16:31 |
| fried_rice | Code blue, get a crash cart in here, got it. | 16:31 |
| *** dims has joined #openstack-nova | 16:34 | |
| melwitt | le sigh, the ceph job is consistently timing out taking too long to run. not sure what could have changed | 16:36 |
| *** wwriverrat has joined #openstack-nova | 16:37 | |
| *** dims has quit IRC | 16:38 | |
| *** macza has joined #openstack-nova | 16:39 | |
| *** markvoelker has joined #openstack-nova | 16:39 | |
| fried_rice | belmoreira: are you running py2 or py3? | 16:40 |
| belmoreira | fried_rice: py2 | 16:41 |
| fried_rice | ight | 16:41 |
| *** ociuhandu_ has quit IRC | 16:41 | |
| *** ociuhandu_ has joined #openstack-nova | 16:42 | |
| belmoreira | v | 16:42 |
| melwitt | dansmith: your review on the spec amendment for detach boot volume would be appreciated https://review.openstack.org/619161 | 16:42 |
| dansmith | melwitt: appreciated how much? | 16:43 |
| * dansmith is looking for cash prizes or .. candy | 16:43 | |
| melwitt | I have chicago style popcorn | 16:43 |
| * dansmith googles | 16:44 | |
| *** ociuhandu_ has quit IRC | 16:44 | |
| dansmith | yeah, alright. | 16:44 |
| *** dims has joined #openstack-nova | 16:45 | |
| melwitt | lol | 16:45 |
| *** mcgiggler has quit IRC | 16:46 | |
| *** _fragatina has joined #openstack-nova | 16:48 | |
| openstackgerrit | Merged openstack/nova master: Make VolumeAttachmentsSampleV249 test other methods https://review.openstack.org/633621 | 16:48 |
| belmoreira | I need to leave, thanks for all the help | 16:49 |
| *** belmoreira has quit IRC | 16:51 | |
| *** tssurya has quit IRC | 16:51 | |
| *** dims has quit IRC | 16:53 | |
| openstackgerrit | Merged openstack/nova-specs master: Amend the detach-boot-volume design https://review.openstack.org/619161 | 16:54 |
| *** dims has joined #openstack-nova | 16:55 | |
| *** eharney has quit IRC | 16:59 | |
| mriedem | melwitt: for the same reasons the tempest-full job times out | 17:00 |
| mriedem | http://status.openstack.org/elastic-recheck/#1783405 | 17:00 |
| mriedem | https://review.openstack.org/#/q/topic:bug/1783405+(status:open+OR+status:merged) | 17:00 |
| mriedem | {1} tempest.scenario.test_network_advanced_server_ops.TestNetworkAdvancedServerOps.test_server_connectivity_reboot [278.769116s] ... ok | 17:01 |
| mriedem | {1} tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_volume_boot_pattern [231.855718s] ... ok | 17:01 |
| mriedem | {2} tempest.api.compute.volumes.test_attach_volume.AttachVolumeTestJSON.test_attach_detach_volume [224.248984s] ... ok | 17:01 |
| *** dpawlik has joined #openstack-nova | 17:01 | |
| mriedem | {0} tempest.scenario.test_minimum_basic.TestMinimumBasicScenario.test_minimum_basic_scenario [266.396758s] ... ok | 17:01 |
| *** gyee has joined #openstack-nova | 17:01 | |
| melwitt | oh, I see. thank you. I didn't know the test times are on the tests | 17:02 |
| mriedem | actually it would be worse | 17:02 |
| * melwitt embarrassed | 17:02 | |
| mriedem | because tempest-full skips slow tests | 17:02 |
| mriedem | but the ceph job doesn't | 17:03 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP Use migration_status during volume migrating and retyping https://review.openstack.org/637224 | 17:03 |
| mriedem | and the ceph job is also running cinder tempest plugin tests | 17:03 |
| melwitt | the ceph job does it all! | 17:03 |
| mriedem | http://git.openstack.org/cgit/openstack/devstack-plugin-ceph/tree/.zuul.yaml#n16 | 17:03 |
| mriedem | ^ should be increased probably | 17:03 |
| melwitt | it was fine until recently, now it's timing out constantly | 17:03 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Perf: Use dicts for ProviderTree roots https://review.openstack.org/637225 | 17:03 |
| fried_rice | belmoreira, tssurya: ^ try that out, if you please. | 17:04 |
| mriedem | well, skipping slow tests would help quite a bit | 17:04 |
| mriedem | at the sacrifice of coverage | 17:05 |
| *** dpawlik has quit IRC | 17:05 | |
| melwitt | yeah, that's what I was about to say. a separate ceph slow tests job comes to mind but "yet another job" | 17:05 |
| mriedem | compare to the timeout on the tempest-slow job which only runs slow tests | 17:05 |
| mriedem | http://git.openstack.org/cgit/openstack/tempest/tree/.zuul.yaml#n276 | 17:05 |
| mriedem | that timeout is 3 hours rather than 2 | 17:05 |
| mriedem | the easy fix is bumping the timeout | 17:06 |
| mriedem | but if that job is consistently taking over 2 hours, that means all nova changes are waiting at least that long in the check queue for results from a non-voting job | 17:06 |
| melwitt | hm, yeah | 17:07 |
| mriedem | so if we're going to wait that long for that job, i think it needs to be voting | 17:07 |
| mriedem | and if it's going to take that long and be non-voting, i think it's place is in the experimental queue | 17:07 |
| melwitt | yeah, that's fair | 17:07 |
| mriedem | probably something to be brought up in the ML since it likely also affects other projects (cinder/glance at least) | 17:07 |
| smcginnis | ++ | 17:08 |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| melwitt | the job was as stable as the normal tempest-full (I need to get the graph again) for quite a while, but I never got around to trying to make it voting again | 17:09 |
| melwitt | yeah, ok. I'll grab the data and post to the ML | 17:09 |
| mriedem | speaking of jobs, it looks like while i fixed legacy-grenade-dsvm-neutron-multinode-live-migration the zuul.yaml change on irrelevant-files means it's not running on nova changes now... | 17:10 |
| mriedem | https://review.openstack.org/#/c/634962/5/.zuul.yaml@242 | 17:11 |
| *** markvoelker has quit IRC | 17:13 | |
| melwitt | ? | 17:15 |
| mriedem | e.g. that job isn't running on https://review.openstack.org/#/c/591657/ | 17:15 |
| mriedem | it's now only running if there are changes to nova/tests/live_migration/ | 17:16 |
| melwitt | oh.... oops | 17:16 |
| mriedem | nova/tests/live_migration/ should probably move under nova/gate/ | 17:16 |
| *** tesseract has quit IRC | 17:17 | |
| *** artom has joined #openstack-nova | 17:17 | |
| *** artom has quit IRC | 17:18 | |
| *** artom has joined #openstack-nova | 17:18 | |
| melwitt | that's weird, I thought we've used that regex before to run on nova/tests/live_migration in addition to non-test nova changes | 17:18 |
| *** rpittau has quit IRC | 17:20 | |
| mriedem | i've got a fix | 17:20 |
| *** TxGirlGeek has quit IRC | 17:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix irrelevant-files for legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/637231 | 17:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Trim fake_deserialize_context in test_conductor https://review.openstack.org/635859 | 17:29 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Cleanup inflight rpc messages between test cases https://review.openstack.org/637233 | 17:29 |
| gibi | mriedem: fyi, I think I got the fkr ^^ | 17:29 |
| * gibi leave the computer for the weekend | 17:30 | |
| mriedem | dansmith: maybe we were too hasty https://review.openstack.org/#/c/635146/10/nova/api/openstack/compute/views/servers.py@114 | 17:30 |
| mriedem | https://review.openstack.org/#/c/635147/13/api-guide/source/down_cells.rst@28 | 17:31 |
| *** igordc has joined #openstack-nova | 17:32 | |
| dansmith | mriedem: hmm, is that going to refer to links in other apis that we won't support? | 17:33 |
| dansmith | like /servers/uuid/somethingelse ? | 17:33 |
| mriedem | no it's a ref back to itself | 17:33 |
| mriedem | so nova show | 17:33 |
| dansmith | I thought there were a couple of links, like to self, flavor, etc | 17:33 |
| mriedem | flavor links would be under the flavor dict in the response | 17:33 |
| mriedem | self is just GET /servers/{server_id} | 17:33 |
| mriedem | "href": "http://openstack.example.com/v2/6f70656e737461636b20342065766572/servers/22c91117-08de-4894-9aa9-6ef382400985" | 17:34 |
| dansmith | okay | 17:34 |
| dansmith | hmm, she's not around and it's friday.. perhaps someone else should just fix it up for her? | 17:38 |
| mriedem | yeah first thing is pulling it from the gate | 17:38 |
| mriedem | so i guess i'll jack the commit message | 17:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 17:39 |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.69 https://review.openstack.org/637234 | 17:39 |
| *** ccamacho has quit IRC | 17:42 | |
| *** TxGirlGeek has joined #openstack-nova | 17:43 | |
| *** eharney has joined #openstack-nova | 17:46 | |
| *** igordc has quit IRC | 17:46 | |
| mriedem | alright then, looks like i'm going to have lunch and then i'll add the links and such, and probably also fix up my comments in the docs patch at the end | 17:52 |
| mriedem | so much for cross-cell resize fun today | 17:53 |
| *** ccamacho has joined #openstack-nova | 18:00 | |
| *** derekh has quit IRC | 18:04 | |
| *** ociuhandu_ has joined #openstack-nova | 18:06 | |
| *** ociuhandu has quit IRC | 18:09 | |
| *** markvoelker has joined #openstack-nova | 18:10 | |
| *** ociuhandu_ has quit IRC | 18:10 | |
| *** pbing19 has joined #openstack-nova | 18:16 | |
| *** mriedem has quit IRC | 18:18 | |
| *** ralonsoh has quit IRC | 18:20 | |
| *** mriedem has joined #openstack-nova | 18:24 | |
| *** ociuhandu has joined #openstack-nova | 18:24 | |
| *** tssurya has joined #openstack-nova | 18:25 | |
| *** ociuhandu has quit IRC | 18:28 | |
| *** awalende has joined #openstack-nova | 18:30 | |
| *** awalende has quit IRC | 18:31 | |
| *** awalende has joined #openstack-nova | 18:31 | |
| *** awalende has quit IRC | 18:36 | |
| *** mchlumsky has quit IRC | 18:42 | |
| *** mrjk_ has joined #openstack-nova | 18:43 | |
| *** mchlumsky has joined #openstack-nova | 18:43 | |
| *** markvoelker has quit IRC | 18:43 | |
| *** mrjk has quit IRC | 18:44 | |
| *** psachin has joined #openstack-nova | 18:52 | |
| *** thgcorrea has quit IRC | 18:56 | |
| *** erlon has quit IRC | 18:57 | |
| *** moshele has joined #openstack-nova | 19:04 | |
| *** TxGirlGeek has quit IRC | 19:07 | |
| *** TxGirlGe_ has joined #openstack-nova | 19:07 | |
| *** moshele has quit IRC | 19:09 | |
| *** moshele has joined #openstack-nova | 19:10 | |
| *** wolverineav has joined #openstack-nova | 19:12 | |
| *** wolverineav has quit IRC | 19:16 | |
| *** wolverineav has joined #openstack-nova | 19:18 | |
| *** moshele has quit IRC | 19:23 | |
| *** gyee has quit IRC | 19:32 | |
| mriedem | dansmith: here it comes | 19:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 19:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add context.target_cell() stub to DownCellFixture https://review.openstack.org/637182 | 19:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657 | 19:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 19:35 |
| dansmith | mriedem: omg -1 so hard | 19:37 |
| mriedem | here it comes | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add context.target_cell() stub to DownCellFixture https://review.openstack.org/637182 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657 | 19:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 19:39 |
| *** markvoelker has joined #openstack-nova | 19:41 | |
| dansmith | mriedem: and the ones above are unchanged so I can stamp them? | 19:41 |
| *** wolverineav has quit IRC | 19:42 | |
| mriedem | minor changes | 19:42 |
| mriedem | the api samples had to change b/c of the links key in the response | 19:42 |
| dansmith | sure, but I see other stuff too | 19:44 |
| dansmith | anyway, looks okay | 19:45 |
| mriedem | cdent: you want to propose for stable/rocky and friends? https://review.openstack.org/#/c/636701/ | 19:45 |
| mriedem | or send out the gary signal? | 19:45 |
| *** gyee has joined #openstack-nova | 19:46 | |
| mriedem | dansmith: i'm +2 on the docs change at the end if you want to flush it all | 19:46 |
| mriedem | i think you do | 19:46 |
| *** wolverineav has joined #openstack-nova | 19:48 | |
| dansmith | 420 lines.. | 19:48 |
| mriedem | you live in portland, you can get down with that | 19:49 |
| dansmith | heh | 19:49 |
| *** wolverineav has quit IRC | 19:53 | |
| *** psachin has quit IRC | 19:58 | |
| openstackgerrit | Corey Bryant proposed openstack/nova master: add python 3.7 unit test job https://review.openstack.org/610694 | 19:59 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | 19:59 |
| dansmith | mriedem: comments on the docs patch.. I could just +2 and we could discuss/fix later, but probably not as much of a rush on that one I'm thinking | 20:01 |
| *** awalende has joined #openstack-nova | 20:01 | |
| -openstackstatus- NOTICE: The StoryBoard service on storyboard.openstack.org is offline momentarily for maintenance: http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002666.html | 20:04 | |
| tssurya | mriedem, dansmith: you had to respin for the links part ? sorry about that and again my never-ending list of "thank you"'s | 20:04 |
| openstackgerrit | Corey Bryant proposed openstack/python-novaclient master: add python 3.7 unit test job https://review.openstack.org/637290 | 20:07 |
| *** zer0c00l has joined #openstack-nova | 20:07 | |
| mriedem | dansmith: tssurya: i also just thought about this https://review.openstack.org/#/c/591657/44/nova/api/openstack/compute/services.py@78 | 20:11 |
| *** TxGirlGe_ has quit IRC | 20:11 | |
| *** markvoelker has quit IRC | 20:13 | |
| tssurya | mriedem: hmm so you want it to be false if those filters are passed ? | 20:13 |
| *** TxGirlGeek has joined #openstack-nova | 20:13 | |
| mriedem | dansmith: yeah i'm ok with those docs changes | 20:14 |
| mriedem | tssurya: idk, hence the question | 20:14 |
| mriedem | tssurya: if we were being consistent, we'd set cell_down_support=False if there were any filters on the request | 20:14 |
| dansmith | I don't really have an opinion on the servers stuff | 20:14 |
| dansmith | er, services | 20:14 |
| mriedem | but like i said, we're not filtering in the db query, we're doing it in python once we get results | 20:14 |
| mriedem | so *shrug*? | 20:14 |
| tssurya | yea | 20:16 |
| tssurya | besides technically the edge cases are only for "listing servers" :D | 20:16 |
| tssurya | at least in the docs and everywhere its only for the server details | 20:17 |
| mriedem | oh well if the docs say so... | 20:19 |
| mriedem | anyway i'm fine with the way it is, not really worth losing sleep over it | 20:20 |
| *** wolverineav has joined #openstack-nova | 20:21 | |
| *** wolverineav has quit IRC | 20:27 | |
| *** itlinux has joined #openstack-nova | 20:30 | |
| mriedem | looks like a whole bunch of 3rd party CIs are failing on this | 20:31 |
| mriedem | ConnectionError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/ed/39/15045ae46f2a123019aa968dfcba0396c161c20f855f11dea6796bcaae95/PyMySQL-0.9.3-py2.py3-none-any.whl (Caused by ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)) | 20:31 |
| *** agopi is now known as agopi|bbiab | 20:32 | |
| *** itlinux has quit IRC | 20:34 | |
| *** ccamacho has quit IRC | 20:36 | |
| *** agopi|bbiab has quit IRC | 20:37 | |
| *** itlinux has joined #openstack-nova | 20:39 | |
| *** agopi|bbiab has joined #openstack-nova | 20:43 | |
| fried_rice | okay, but cmon, do we actually *need* PyMySQL? | 20:43 |
| melwitt | nah | 20:43 |
| fried_rice | tssurya: Did you see the patch I proposed to improve the ironic ufpt thing? | 20:44 |
| fried_rice | gibi: Is it too late to make the bw part of the binding profile look more like the resource request syntax in extra specs? | 20:44 |
| tssurya | fried_rice: saw the WIP, but didn't review it yet | 20:45 |
| *** TxGirlGeek has quit IRC | 20:45 | |
| fried_rice | tssurya: Less about review, more about trying it in your env and seeing if it takes the 6h processing ironic nodes down to something sane. | 20:45 |
| tssurya | haha we kind of hacked the bit of code that tries to do the N^2 thing already got the node up | 20:46 |
| tssurya | for now | 20:46 |
| tssurya | I will be able to try your patch only on Monday :( | 20:46 |
| fried_rice | tssurya: yeah, IIUC you're only processing the one node, but that's not a long term solution. | 20:46 |
| fried_rice | okay | 20:46 |
| tssurya | but trust me getting that to work properly is our priority | 20:47 |
| fried_rice | gibi: IMO that's a more consistent user experience; and then also we would get to use common code for parsing into RequestGroup etc. | 20:47 |
| tssurya | your concern is for provider sharing right ? | 20:47 |
| fried_rice | tssurya: That's one example. It's really a question of why that code is there in the first place: it's because upt is allowed to muck with anything in the ProviderTree object. | 20:48 |
| fried_rice | tssurya: Like what if ironic actually *wanted* to dork with more than one node at a time? | 20:48 |
| tssurya | fried_rice: since we are talking about why that code exists, can you give me a ore concrete example of when ironic would want that ? | 20:53 |
| tssurya | like I am trying to understand more use cases for this whole thing | 20:53 |
| tssurya | since I am pretty sure we don't need them for now right ? | 20:53 |
| tssurya | or maybe I am missing some documentation | 20:53 |
| fried_rice | tssurya: Yeah, I don't have a specific use case; I could only contrive hypothetical ones. It's just that update_provider_tree is a generic method which passes the *whole* ProviderTree object down to the virt driver for modification, and then update_from_provider_tree is responsible for flushing any changes back to placement. | 20:54 |
| fried_rice | I really didn't want upt/ufpt to be tightly bound to specific virt drivers' implementations or needs in that regard. | 20:54 |
| fried_rice | and it's specifically designed to be future-looking to when we have nested providers, sharing providers, etc. | 20:55 |
| fried_rice | ...just like the code that broke your Queens performance :) | 20:55 |
| tssurya | yea I get that, its just that for ironic I don't know how this would scale with the more nodes that we would keep adding in future | 20:55 |
| fried_rice | ...which wasn't actually going to be used until... I think stein actually. | 20:55 |
| cdent | mriedem: i'll either get to it or get gary, but yeah | 20:55 |
| fried_rice | tssurya: Well, let's see how this does. | 20:55 |
| fried_rice | tssurya: Note that there are already a number of anticipatory optimizations in that code. | 20:56 |
| fried_rice | tssurya: Like the fact that we do local compares and only call out to placement if something has changed. | 20:56 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 20:57 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 20:57 |
| tssurya | fried_rice: yea I mean as far as most of the things we do right now the flushes to placement are very less | 20:57 |
| fried_rice | tssurya: I just didn't anticipate that iterating through a list would bring the service to its knees. Even if you had told me the list was going to be a couple thousand long. | 20:57 |
| tssurya | fried_rice: of course yea we didn't know this as well until we timed this, our test env is not exactly the size of our actual prod env | 20:58 |
| *** cdent has quit IRC | 21:00 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 21:03 |
| mriedem | sounds like someone needs their nova-computes running on s390x mainframes | 21:03 |
| mriedem | or Power9! | 21:03 |
| *** wolverineav has joined #openstack-nova | 21:03 | |
| tssurya | fried_rice: just saw your patch, so basically you are saving on the lookup time instead of iterating.. We will try this first thing Monday and let you know | 21:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 21:04 |
| fried_rice | tssurya: Yes. We already have the list of UUIDs. Now instead of that loop taking O(N) to look up each node's provider object, it'll take O(1). | 21:05 |
| tssurya | yeap nice | 21:05 |
| fried_rice | tssurya: now, it's possible that that lookup wasn't the problem: it's possible that what's killing us is 1700 ProviderTree.data() calls (which copies the guts of the ProviderTree) plus 5100 compares of that information. | 21:06 |
| fried_rice | that may be a tad harder to optimize. | 21:06 |
| fried_rice | (...guts of the individual _Provider in the ProviderTree, that is) | 21:08 |
| *** wolverineav has quit IRC | 21:08 | |
| *** markvoelker has joined #openstack-nova | 21:10 | |
| tssurya | yea you mean this part here (https://github.com/openstack/nova/blob/880327cc31fea7328d23355730d5458f3b74662b/nova/scheduler/client/report.py#L1440) | 21:15 |
| tssurya | and then the set aggregates and inventories comparisions | 21:15 |
| *** mchlumsky has quit IRC | 21:17 | |
| *** wolverineav has joined #openstack-nova | 21:23 | |
| melwitt | mriedem: if I'm trying to remove the console-auth workaround in stein and nova-status upgrade check has the check for console auths, where it warns if compute services older than rocky are found and advises to set the [workarounds] option if so. if I'm removing the workaround, it seems like I should remove the upgrade check. is that right? | 21:24 |
| *** wolverineav has quit IRC | 21:25 | |
| *** wolverineav has joined #openstack-nova | 21:28 | |
| mriedem | does the upgrade check just warn today? | 21:30 |
| melwitt | yes | 21:30 |
| mriedem | and is that upgrade check in stable/rocky? | 21:30 |
| mriedem | i think you'd either remove the upgrade check in stein or change it to a hard failure | 21:30 |
| *** whoami-rajat has quit IRC | 21:30 | |
| mriedem | and then maybe mark it for removal in Train | 21:30 |
| melwitt | yes the check is in stable/rocky | 21:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 21:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 21:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 21:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 21:31 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 21:31 |
| mriedem | off the top of my head i think i'd go conservative and make the upgrade check a hard failure in stein and remove it in train | 21:31 |
| melwitt | ok, I considered changing it to a hard failure if any computes older than rocky are found. I guess the action would be "upgrade your computes | 21:31 |
| mriedem | because someone could run the stein upgrade checks against a rocky deployment from a venv/container | 21:31 |
| mriedem | dansmith might have an opinion | 21:32 |
| melwitt | I was struggling a bit with what the action item is for something that generic. all of the other failures say, "run this command" | 21:32 |
| mriedem | yeah i think the only recent upgrade check we removed was the one for placement resource providers because of the extracted placement | 21:32 |
| mriedem | we could have re-worked that to hit the placement API rather than the nova_api db, but it had been around since ocata so figured it was ok to just drop it | 21:32 |
| mriedem | this consoleauth one seems to have really confused some people and caught them off guard | 21:33 |
| mriedem | so dropping the check with the workaround in the same release might be too aggressive | 21:33 |
| melwitt | I wondered that too, because of how problematic it's been. whether to just keep the workaround around another cycle | 21:34 |
| mriedem | if it's not hurting anything that might be fine | 21:34 |
| mriedem | safer than sorryier | 21:34 |
| melwitt | I was thinking to follow through with TODOs before they get too old and forgettable but this seems like one of those where it's best not | 21:35 |
| melwitt | yeah, it doesn't hurt anything | 21:35 |
| melwitt | ok, well, that's easy then | 21:35 |
| mriedem | we've still got lots of todos to remove things from several releases ago | 21:37 |
| mriedem | hell we've still got nova-net and cells v1 | 21:37 |
| *** artom has quit IRC | 21:37 | |
| melwitt | oh I know. I was thinking instead, I should propose one of the old TODOs. I think the instance group migration to API database that I worked on is still around :( | 21:38 |
| melwitt | oh, looks like you removed that last year. heh | 21:41 |
| *** markvoelker has quit IRC | 21:43 | |
| *** awalende has quit IRC | 21:56 | |
| *** awaugama has quit IRC | 21:56 | |
| *** awalende has joined #openstack-nova | 21:57 | |
| mriedem | you still have to write the API side changes for the counting quotas from placement thing right? | 21:59 |
| mriedem | s/quotas/usage/ | 21:59 |
| *** awalende has quit IRC | 22:01 | |
| *** wolverineav has quit IRC | 22:09 | |
| *** wolverineav has joined #openstack-nova | 22:09 | |
| melwitt | mriedem: right. I'm trying to debug why my online data migration does an infinite loop in grenade, at the moment :( | 22:11 |
| *** itlinux has quit IRC | 22:12 | |
| *** awalende has joined #openstack-nova | 22:18 | |
| *** agopi|bbiab has quit IRC | 22:22 | |
| mriedem | looks like you're mostly just copying populate_queued_for_delete | 22:23 |
| mriedem | the only major difference i see is you're using filter_by and that other uses filter() | 22:24 |
| mriedem | that shouldn't really matter though | 22:24 |
| melwitt | yeah. I did that because I was thinking that's a better approach than what I was originally planning, to get all instance mappings where user_id=None and then lookup cell by project_id and get instance | 22:26 |
| *** wolverineav has quit IRC | 22:27 | |
| melwitt | tssurya mentioned to me that when she was working on queued_for_delete, the loop happened for that because originally she didn't have a default for InstanceMapping.create(), so it was creating NULL fields that would get found again by the migration (creates must have been happening also in the online data migrations, I guess) | 22:27 |
| *** wolverineav has joined #openstack-nova | 22:28 | |
| melwitt | so I added a default for create(), also added setting of user_id for save() in conductor, in case any instance builds are in-flight during an upgrade, where instance mapping was created with cell=None before upgrade and then before scheduling during upgrade, it gets scheduled, set the user_id | 22:29 |
| melwitt | I don't know what case grenade is hitting. it's looping not in the initial online migration run before starting services, but in the second online migration after starting services | 22:29 |
| melwitt | I added a print statement to the online migration to help with debugging in the next gate run | 22:30 |
| mriedem | i don't see anything obviously wrong | 22:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.openstack.org/637058 | 22:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.openstack.org/637070 | 22:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize conductor RPC method https://review.openstack.org/637075 | 22:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Confirm cross-cell resize from the API https://review.openstack.org/637316 | 22:30 |
| mriedem | dansmith: and we've got confirm ^ | 22:30 |
| melwitt | thanks for taking a look | 22:30 |
| mriedem | plus functional | 22:30 |
| *** wolverineav has quit IRC | 22:33 | |
| *** markvoelker has joined #openstack-nova | 22:40 | |
| melwitt | I think I need to take a break | 22:41 |
| *** itlinux has joined #openstack-nova | 22:42 | |
| *** dave-mccowan has quit IRC | 22:45 | |
| *** awalende has quit IRC | 22:46 | |
| *** awalende has joined #openstack-nova | 22:47 | |
| *** awalende has quit IRC | 22:51 | |
| *** pbing19 has quit IRC | 22:53 | |
| *** itlinux has quit IRC | 22:54 | |
| *** itlinux has joined #openstack-nova | 22:55 | |
| *** wolverineav has joined #openstack-nova | 22:59 | |
| *** wolverineav has quit IRC | 23:04 | |
| *** markvoelker has quit IRC | 23:13 | |
| *** wolverineav has joined #openstack-nova | 23:13 | |
| *** wolverineav has quit IRC | 23:16 | |
| *** itlinux has quit IRC | 23:17 | |
| *** wolverineav has joined #openstack-nova | 23:20 | |
| *** xek has quit IRC | 23:21 | |
| *** tssurya has quit IRC | 23:22 | |
| *** wolverineav has quit IRC | 23:25 | |
| *** panda is now known as panda|off | 23:28 | |
| *** takamatsu_ has quit IRC | 23:29 | |
| *** betherly has quit IRC | 23:45 | |
| *** wolverineav has joined #openstack-nova | 23:47 | |
| *** gyee has quit IRC | 23:50 | |
| *** wolverineav has quit IRC | 23:52 | |
| *** gyee has joined #openstack-nova | 23:54 | |
| *** moshele has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!