Friday, 2018-12-14

*** tetsuro has joined #openstack-nova00:03
*** wolverineav has quit IRC00:09
*** wolverineav has joined #openstack-nova00:09
*** slaweq has joined #openstack-nova00:11
*** awaugama has quit IRC00:12
*** igordc has joined #openstack-nova00:13
*** wolverineav has quit IRC00:14
*** tbachman has quit IRC00:14
*** slaweq has quit IRC00:16
*** igordc has quit IRC00:18
*** erlon has joined #openstack-nova00:33
*** wolverineav has joined #openstack-nova00:34
*** wolverineav has quit IRC00:36
*** wolverineav has joined #openstack-nova00:38
*** wolverineav has quit IRC00:38
*** wolverineav has joined #openstack-nova00:38
*** rambo_li has joined #openstack-nova00:39
*** cdent has quit IRC00:39
*** brinzhang has joined #openstack-nova00:48
*** Swami has quit IRC00:49
*** gyee has quit IRC00:58
*** jcosmao has quit IRC01:04
openstackgerritMerged openstack/nova master: Only construct SchedulerReportClient on first access from API  https://review.openstack.org/62324601:06
openstackgerritMerged openstack/nova master: DRY up SchedulerReportClient init  https://review.openstack.org/62324701:06
openstackgerritMerged openstack/nova stable/rocky: Note the aggregate allocation ratio restriction in scheduler docs  https://review.openstack.org/62354601:06
*** tbachman has joined #openstack-nova01:09
*** slaweq has joined #openstack-nova01:10
*** slaweq has quit IRC01:15
*** takashin has joined #openstack-nova01:17
*** psachin has joined #openstack-nova01:30
*** takashin has quit IRC01:35
*** takashin has joined #openstack-nova01:37
*** Dinesh_Bhor has joined #openstack-nova01:39
*** rodolof has quit IRC01:40
*** Dinesh_Bhor has quit IRC01:43
*** macza has quit IRC01:44
*** tiendc has joined #openstack-nova01:46
*** takashin has left #openstack-nova02:00
*** Dinesh_Bhor has joined #openstack-nova02:01
*** mrsoul has quit IRC02:07
*** cfriesen has quit IRC02:07
*** bhagyashris has joined #openstack-nova02:11
*** munimeha1 has quit IRC02:25
*** mhen has quit IRC02:26
*** sapd1_ has joined #openstack-nova02:27
*** sapd1 has quit IRC02:29
*** mhen has joined #openstack-nova02:30
*** dave-mccowan has joined #openstack-nova02:38
*** itlinux has joined #openstack-nova02:39
*** naichuans has joined #openstack-nova02:50
openstackgerritDave McCowan proposed openstack/nova stable/rocky: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350702:54
openstackgerritDave McCowan proposed openstack/nova stable/queens: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350902:55
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Don't persist RequestSpec.requested_destination  https://review.openstack.org/61194502:57
*** wolverineav has quit IRC03:03
*** wolverineav has joined #openstack-nova03:04
*** wolverineav has quit IRC03:08
*** slaweq has joined #openstack-nova03:11
*** hongbin has joined #openstack-nova03:14
*** hongbin has quit IRC03:15
*** slaweq has quit IRC03:15
*** hongbin has joined #openstack-nova03:16
*** Hazelesque has quit IRC03:43
*** lbragstad has joined #openstack-nova03:50
*** Hazelesque has joined #openstack-nova03:51
*** lbragstad has quit IRC03:51
*** Dinesh_Bhor has quit IRC03:52
*** READ10 has joined #openstack-nova03:52
*** brinzh has joined #openstack-nova04:02
*** dave-mccowan has quit IRC04:03
*** liuyulong has quit IRC04:04
*** brinzhang has quit IRC04:06
*** udesale has joined #openstack-nova04:10
*** psachin has quit IRC04:10
*** slaweq has joined #openstack-nova04:11
*** lbragstad has joined #openstack-nova04:13
*** Dinesh_Bhor has joined #openstack-nova04:14
*** rambo_li has quit IRC04:14
*** slaweq has quit IRC04:16
*** psachin has joined #openstack-nova04:29
*** diga has joined #openstack-nova04:30
*** READ10 has quit IRC04:30
*** hongbin has quit IRC04:34
*** _alastor_ has quit IRC04:54
*** rambo_li has joined #openstack-nova05:00
*** bhagyashris has quit IRC05:01
openstackgerritMerged openstack/nova stable/queens: Refix disk size during live migration with disk over-commit  https://review.openstack.org/60247805:01
*** Dinesh_Bhor has quit IRC05:01
*** _alastor_ has joined #openstack-nova05:02
*** wolverineav has joined #openstack-nova05:08
*** slaweq has joined #openstack-nova05:11
*** slaweq has quit IRC05:16
openstackgerritMerged openstack/nova stable/queens: Fix stacktraces with redis caching backend  https://review.openstack.org/60689605:16
openstackgerritMerged openstack/nova stable/queens: Add regression test for bug 1797580  https://review.openstack.org/61194405:17
openstackbug 1797580 in OpenStack Compute (nova) queens "NoValidHost during live migration after cold migrating to a specified host" [High,In progress] https://launchpad.net/bugs/1797580 - Assigned to Matt Riedemann (mriedem)05:17
openstackgerritMerged openstack/nova stable/queens: Not set instance to ERROR if set_admin_password failed  https://review.openstack.org/60817905:17
openstackgerritMerged openstack/nova stable/queens: Ignore VirtDriverNotReady in _sync_power_states periodic task  https://review.openstack.org/60773005:17
*** rambo_li has quit IRC05:22
*** Dinesh_Bhor has joined #openstack-nova05:23
*** _alastor_ has quit IRC05:34
*** dklyle has joined #openstack-nova05:38
*** ratailor has joined #openstack-nova05:51
*** wolverineav has quit IRC05:51
*** izza_ has joined #openstack-nova06:06
izza_hi...i created instance with VGPU flavor in  Openstack TripleO rocky version with Windows Server 2012 R2 guest OS,but as checked, graphics dirver is not visible in the guest OS06:07
izza_we're using the tesla P10006:07
izza_can someone here help us about my issue06:07
openstackgerritSujeet Banerjee proposed openstack/nova master: Hot fix for RMQ failures causing nova out of sync  https://review.openstack.org/62515006:10
*** rambo_li has joined #openstack-nova06:12
*** lpetrut has joined #openstack-nova06:13
*** izza_ has quit IRC06:18
*** sridharg has joined #openstack-nova06:25
*** bhagyashris_ has joined #openstack-nova06:34
openstackgerritYikun Jiang proposed openstack/nova master: Add live migration timeout action  https://review.openstack.org/61914306:59
*** rcernin has quit IRC07:03
*** slaweq has joined #openstack-nova07:11
*** pcaruana has joined #openstack-nova07:12
*** Luzi has joined #openstack-nova07:13
*** slaweq has quit IRC07:16
openstackgerritYikun Jiang proposed openstack/nova master: Add live migration timeout action  https://review.openstack.org/61914307:20
openstackgerritYikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config  https://review.openstack.org/61914207:20
*** erlon has quit IRC07:23
*** dpawlik has joined #openstack-nova07:38
*** slaweq has joined #openstack-nova07:41
*** slaweq has quit IRC07:47
*** Dinesh_Bhor has quit IRC07:48
*** psachin has quit IRC07:48
*** sum12 has joined #openstack-nova07:50
*** slaweq has joined #openstack-nova07:51
sum12Hello, I wanted to understand node discovery for cell_v2, so should a hostmapping be already created when nova-manage discover_hosts is run ?07:51
openstackgerritYikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config  https://review.openstack.org/61914207:55
*** lpetrut has quit IRC07:58
*** jangutter has joined #openstack-nova08:04
*** sahid has joined #openstack-nova08:07
*** maciejjozefczyk has joined #openstack-nova08:08
*** rambo_li has quit IRC08:12
*** markvoelker has joined #openstack-nova08:16
*** Shadowphax has joined #openstack-nova08:20
*** imacdonn has quit IRC08:24
*** imacdonn has joined #openstack-nova08:24
*** tssurya has joined #openstack-nova08:32
*** Dinesh_Bhor has joined #openstack-nova08:33
*** rambo_li has joined #openstack-nova08:34
*** tetsuro has quit IRC08:37
*** rambo_li_ has joined #openstack-nova08:37
*** rambo_li_ has quit IRC08:38
*** priteau has joined #openstack-nova08:39
*** cdent has joined #openstack-nova08:50
*** brinzh has quit IRC09:06
openstackgerritSurya Seetharaman proposed openstack/nova master: Add DownCellFixture  https://review.openstack.org/61481009:10
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells  https://review.openstack.org/59165709:10
*** erlon has joined #openstack-nova09:13
*** k_mouza has joined #openstack-nova09:13
tssurya gibi: good morning! Whenever you have the time could you have a look at https://review.openstack.org/#/c/614810 (after the CI passes)? I have added more comments, thanks!09:16
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350709:20
*** ccamacho has joined #openstack-nova09:20
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350909:20
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62351009:21
*** k_mouza has quit IRC09:21
*** k_mouza has joined #openstack-nova09:22
*** erlon has quit IRC09:22
openstackgerritzhangyujun proposed openstack/nova master: Should not raise while restore power on failed  https://review.openstack.org/62485409:30
*** yan0s has joined #openstack-nova09:40
*** ttsiouts has joined #openstack-nova09:45
*** Dinesh_Bhor has quit IRC09:46
*** rodolof has joined #openstack-nova09:48
*** rodolof has quit IRC09:56
*** rodolof has joined #openstack-nova09:56
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir when using rbd  https://review.openstack.org/61847810:11
openstackgerritLee Yarwood proposed openstack/nova master: fixtures: Return a mocked class instead of method within fake_imagebackend  https://review.openstack.org/61980410:18
lyarwoodmdbooth: ^ rebased this away from either of our work as neither requires it anymore, can you hit it and let me know if it's still useful?10:18
lyarwoodthat's just the fixtures change FWIW10:19
lyarwoodthe other workaround hasn't really changed but reviews still welcome10:19
mdboothlyarwood: ack10:19
*** erlon has joined #openstack-nova10:21
openstackgerritVlad Gusev proposed openstack/nova stable/pike: libvirt: Reduce calls to qemu-img during update_available_resource  https://review.openstack.org/60403910:24
openstackgerritVlad Gusev proposed openstack/nova stable/pike: libvirt: Use os.stat and os.path.getsize for RAW disk inspection  https://review.openstack.org/60754410:24
lyarwood^ LGTM btw.10:29
mdboothlyarwood: I was just looking at my very similar fake_imagebackend patch10:29
mdboothI commented:10:29
mdbooth+        # NOTE(mdbooth): we spec a subclass of imagebackend.Image here because10:30
mdbooth+        # the subclass constructors have a different signature.10:30
mdbooth+        fake_image_class = mock.create_autospec(imagebackend.Flat)10:30
mdbooth+        fake_image_class.side_effect = image_init10:30
mdboothlyarwood: I assume I hit some particular issue to cause me to do that, because my first attempt would almost certainly have been what you did10:30
mdboothlyarwood: It makes sense, though, because they do have different signatures.10:31
lyarwoodmdbooth: hmm yeah but we only use the returned mock as a class remember10:33
lyarwoodmdbooth: the side_effect then provides the same signature as the subclass constructor10:33
mdboothlyarwood: I can't remember why I did this. I just assume there was a reason for it, because it doesn't seem like the first thing I'd have thought of.10:34
lyarwoodyeah indeed10:34
*** Dinesh_Bhor has joined #openstack-nova10:35
mdboothlyarwood: Anyway, assuming all *current* tests pass I'm happy to put my +1 on your patch as it. Future problems can be addressed if they arise.10:35
lyarwoodmdbooth: ack thanks10:36
*** markvoelker has quit IRC10:36
*** Dinesh_Bhor has quit IRC10:36
*** markvoelker has joined #openstack-nova10:37
*** markvoelker has quit IRC10:41
lyarwoodhttps://review.openstack.org/#/q/topic:bug/1785827+(status:open+OR+status:merged) - if any stable cores are online this series is almost finished, just the Pike changes to +W10:44
egonzalezhi, did something get merged in the last few hours (maybe yesterday evening UTC) which can cause the following error?10:58
egonzalezhttp://paste.openstack.org/show/737292/10:59
egonzalezError gathering result from cell 00000000-0000-0000-0000-000000000000: ProgrammingError: (pymysql.err.ProgrammingError) (1146, u"Table 'nova_cell0.services' doesn't exist")10:59
*** bhagyashris_ has quit IRC10:59
egonzalezadded other log at http://paste.openstack.org/show/737293/ while executing nova-api command11:02
*** rambo_li has quit IRC11:04
*** cdent has quit IRC11:09
*** diga has quit IRC11:09
mdboothlyarwood: I don't understand the revert_resize problem, btw, and without the instance.host check the workaround executes on _hard_reboot11:14
mdboothlyarwood: So the revert_resize thing is that we execute cleanup on the dest, right?11:15
lyarwoodmdbooth: argh yeah we'd lose console.log with hard_reboot, the directory is recreated however.11:15
lyarwoodmdbooth: yes, revert resize cleanup is on the dest11:16
mdboothconsole.log, kernel, and ramdisk, but yeah11:16
lyarwoodmdbooth: it should recreate kernel and ramdisk no?11:16
*** markvoelker has joined #openstack-nova11:16
mdboothlyarwood: Unless they've been deleted in glance.11:16
lyarwoodtrue11:17
*** derekh has joined #openstack-nova11:17
mdboothlyarwood: So, is the revert_resize thing a different bug?11:17
mdboothBecause your workaround wouldn't trigger on revert_resize.11:18
lyarwoodmdbooth: with the host check removed it should11:18
lyarwoodmdbooth: we call cleanup with destroy_disks=False and no migrate_data11:18
mdboothlyarwood: Right, but it didn't before.11:18
mdboothSo is that a separate latent bug?11:19
lyarwoodmdbooth: yeah, ah crap I didn't add the bug to the commit did I11:19
lyarwoodmdbooth: yes, it's listed in the conf change11:19
lyarwoodmdbooth: I'll respin the commit message now11:19
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Support native TLS for migration and disks over NBD  https://review.openstack.org/62521611:21
kashyapmdbooth: lyarwood: ^ I surely went overboard with the long commit message (that I spent 2 hours writing)11:22
kashyapBut I made sure they're in readable chunks.11:22
openstackgerritzhangyujun proposed openstack/nova master: Should not raise while restore power on failed  https://review.openstack.org/62485411:24
kashyapOh, it is WIP!11:24
lyarwoodmdbooth: kernel, ramdisk etc are set against the flavor right?11:26
lyarwoodah, image props, my bad11:27
mdboothlyarwood: Right. I think they can also be specified on the command line.11:27
mdboothI don't think anybody actually uses them, but we probably shouldn't assume that, especially not for a backport.11:28
mdbooths/command line/api/11:28
lyarwoodmdbooth: yeah, adding a note about it now.11:32
mdboothlyarwood: How about... changing revert_resize?11:33
lyarwoodmdbooth: to pass migrate_data?11:34
mdboothlyarwood: Put the migration check back in, then turn the cleanup in revert_resize into a migration cleanup by moving it after revert_migration_context()11:34
lyarwoodmdbooth: iirc the migration data in resize doesn't have is_shared_block_storage set11:34
mdboothThen it doesn't execute during _hard_reboot() so we don't need to think ourselves in knots about the potential implications of that.11:34
lyarwoodmdbooth: that's only used in the live migration flows11:34
mdboothlyarwood: If you move the destroy() call after revert_migration_context(), your workaround would execute for revert_resize()11:35
mdboothWhich is what you want.11:35
*** gary_perkins has quit IRC11:37
lyarwoodmdbooth: you'd also need to move terminate_connection then as well11:37
lyarwoodthat opens up another can of worms tbh11:37
mdboothI drew a diagram of Nova's cleanup workflows: http://www.cartoonaday.com/images/cartoons/2017/05/rube-goldberg-machine-cartoon-A.jpg11:38
lyarwoodlol11:39
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir when using rbd  https://review.openstack.org/61847811:39
lyarwood-2 - I can't see any gaffer tape in that diagram.11:40
mdboothHehe. That's v211:40
lyarwoodbut seriously for this workaround I'm not going to move things around in the compute layer, the whole point is that this is an opt-in self contained backportable hack for operators.11:41
*** tbachman has quit IRC11:42
*** Luzi has quit IRC11:44
lyarwoodkashyap: ack btw, looks pretty straight forward, happy to help write the missing tests and land this while you're out if it would help.11:46
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state  https://review.openstack.org/56647311:48
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir when using rbd  https://review.openstack.org/61847811:48
*** gary_perkins has joined #openstack-nova11:51
lyarwoodkashyap: and by straight forward I was just talking about the openstack/nova change, not the actions required to actually use this (ie changes in TripleO). Nice work with the commit and documentation in general for this.11:54
*** ttsiouts has quit IRC12:05
*** ttsiouts has joined #openstack-nova12:05
kashyaplyarwood: Unless there's a big rush to land this, I'd just like to get back and write the tests, as a practise.12:09
kashyapAnd, thanks!12:10
*** ttsiouts has quit IRC12:10
*** udesale has quit IRC12:11
*** ttsiouts has joined #openstack-nova12:16
*** pcaruana has quit IRC12:21
*** pcaruana has joined #openstack-nova12:22
*** pcaruana is now known as pcaruana|intw|12:25
*** k_mouza_ has joined #openstack-nova12:25
*** k_mouza has quit IRC12:28
*** k_mouza_ has quit IRC12:30
*** k_mouza has joined #openstack-nova12:30
*** ratailor has quit IRC12:34
*** _alastor_ has joined #openstack-nova12:35
*** rodolof has quit IRC12:40
*** rodolof has joined #openstack-nova12:41
*** tbachman has joined #openstack-nova12:53
*** tbachman has quit IRC13:00
gibitssurya: the DownCellFixtur patch looks good to me13:04
tssuryagibi: thanks :)13:05
*** k_mouza has quit IRC13:05
*** tbachman has joined #openstack-nova13:06
*** kaisers_ has joined #openstack-nova13:08
*** dave-mccowan has joined #openstack-nova13:09
*** _alastor_ has quit IRC13:14
*** Shadowphax has quit IRC13:15
*** dave-mccowan has quit IRC13:15
*** mlavalle has joined #openstack-nova13:26
*** derekh has quit IRC13:47
*** tiendc has quit IRC13:53
*** mriedem has joined #openstack-nova13:56
*** pcaruana|intw| has quit IRC14:05
*** k_mouza has joined #openstack-nova14:12
*** derekh has joined #openstack-nova14:24
*** udesale has joined #openstack-nova14:27
*** pcaruana has joined #openstack-nova14:31
*** dave-mccowan has joined #openstack-nova14:32
mdboothDo we have a shelve/unshelve test on rbd currently?14:33
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726814:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend RequestGroup object for mapping  https://review.openstack.org/61952714:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping  https://review.openstack.org/61623914:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule  https://review.openstack.org/61952814:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api  https://review.openstack.org/61624014:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule  https://review.openstack.org/61952914:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding  https://review.openstack.org/56945914:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request  https://review.openstack.org/57331714:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Reject interface attach with QoS aware port  https://review.openstack.org/57007814:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Reject networks with QoS policy  https://review.openstack.org/57007914:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove port allocation during detach  https://review.openstack.org/62242114:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor PortResourceRequestBasedSchedulingTestBase  https://review.openstack.org/62408014:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Ensure that allocated PF matches the used PF  https://review.openstack.org/62354314:37
*** tbachman has quit IRC14:38
*** dave-mccowan has quit IRC14:43
*** jmlowe has quit IRC14:48
*** panda|off is now known as panda14:50
*** psachin has joined #openstack-nova14:51
mriedemmdbooth: we have a ceph job which runs tempest tests,14:51
mriedemand tempest has shelve/unshelve tests,14:51
mriedemso yes we should14:51
mriedemthe ceph job has been broken since the summit though14:52
mriedemoh maybe that was fixed and just encrypted volumes are broken14:52
mriedemah, so, the encrypted volume tests were just recently enabled in the ceph job14:53
mriedemhttps://github.com/openstack/devstack-plugin-ceph/commit/7728027cdd575f7d43c97b4b7a9345c69898c26f14:53
*** adrianc has quit IRC14:57
*** awaugama has joined #openstack-nova14:58
*** cfriesen has joined #openstack-nova14:58
*** kaisers_ is now known as kaisers_away14:58
*** adrianc has joined #openstack-nova14:59
mdboothmriedem: Just about to join a meeting, but I have a suspicion it might be broken if we're using ceph clone for glance images15:00
mdboothBecause when you go to delete the image on unshelve it fails because the backing image is still in use.15:00
*** mchlumsky has joined #openstack-nova15:00
janguttermriedem: thanks very much for your review on https://review.openstack.org/#/c/607610/ ... at the risk of really messing up your Friday, would you have a few minutes to chat about things no-one wants to chat about?15:02
*** jmlowe has joined #openstack-nova15:04
*** ivve has joined #openstack-nova15:05
*** tbachman has joined #openstack-nova15:05
*** markvoelker has quit IRC15:06
mriedemmdbooth: like this? https://review.openstack.org/#/c/473897/15:11
mriedemhttps://bugs.launchpad.net/devstack-plugin-ceph/+bug/169793515:12
openstackLaunchpad bug 1697935 in devstack-plugin-ceph "re-enable compute shelve tests" [Undecided,In progress] - Assigned to Eric Harney (eharney)15:12
mriedemmdbooth: probably want to talk to eharney15:12
mriedemjangutter: sure15:12
janguttermriedem: thanks! I am trying to make the "upgrade" sequence less vague.15:13
janguttermriedem: os-vif's two bits, the plug-in and the object model, has Nova between them.15:14
janguttermriedem: so the only sane way I see to adopt the interfaced added in the object model, would be to do three updates, or two with compat code in the middle that's hard to test.15:15
janguttermriedem: os-vif object model -> nova -> os-vif plugin15:15
mdboothmriedem: Thanks15:15
*** rambo_li has joined #openstack-nova15:18
openstackgerritMerged openstack/nova master: Add DownCellFixture  https://review.openstack.org/61481015:19
*** psachin has quit IRC15:21
mriedemjangutter: i'm not sure that clears up anything for me15:23
mriedemmy understanding is,15:23
mriedemwe're going to ignore backward compat for os-vif object versions,15:23
mriedemmake some changes to add the base reference/profile stuff in os-vif,15:23
mriedemrelease with a major version,15:23
mriedemmake nova depend on that major version and start using new code from the library,15:24
mriedemand then....?15:24
mriedemsomething in train?15:24
mriedemmeanwhile kuryr-kubernetes just eats it?15:24
*** dpawlik has quit IRC15:24
janguttermriedem: for now, the new interfaces will not break backwards compatibility just yet, they're additive...15:25
janguttermriedem: you're 100% right that the problem comes when _existing_ plugins transition to use them.15:26
janguttermriedem: the spec does not cover the actual process of doing the backwards-incompatible changes.15:27
mriedemand kuryr-k8s has a problem b/c they have plugins https://github.com/openstack/kuryr-kubernetes/blob/master/setup.cfg#L2615:27
mriedemas does the agilio one15:27
mriedemooo does kuryr-k8s actually do vif translation too? https://github.com/openstack/kuryr-kubernetes/blob/master/setup.cfg#L3615:28
mriedemhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/os_vif_util.py#L30315:28
*** psachin has joined #openstack-nova15:29
mriedemwell, maybe that's closer to our os_vif_util15:29
mriedemhttps://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py15:29
janguttermriedem: The plan, during Stein is to use the new interfaces only for new plugins. (If I understand correctly).15:30
mriedemwill there be a new plugin as of https://review.openstack.org/#/c/567148/ ?15:32
janguttermriedem: in fact, enforcing the new interfaces on existing plugins (with the hairy backlevel code) is something I tried and Jay said "let's don't do that".15:32
janguttermriedem: yes and no - that plugin will be the os-vif yank out of the vrouter vif type.15:32
janguttermriedem: and no, the dominoes have not fallen, and the tag has not gotten applied to https://github.com/Juniper/contrail-nova-vif-driver/ yet.15:33
mriedemby vrouter you mean this? https://github.com/Juniper/contrail-nova-vif-driver/blob/208f0d51b6e0c1c44771e96c062588a40491b09d/setup.py#L3015:34
janguttermriedem: yep - the very same.15:34
mriedemso that's going to move into it's own plugin repo or something?15:34
mriedemi don't know what "yank out" means here15:34
janguttermriedem: nope, it's going to be in-tree there.15:34
*** ivve has quit IRC15:34
mriedemand why was jay opposed to backward compat15:34
mriedem?15:34
janguttermriedem: https://blueprints.launchpad.net/nova/+spec/vrouter-os-vif-conversion15:35
mriedemb/c it's trouble for the sake of a versioned interface that isn't going over the wire?15:35
janguttermriedem: https://review.openstack.org/#/c/572081/8/os_vif/objects/vif.py@27215:36
mriedemoh i see so vrouter is still legacy15:36
*** k_mouza has quit IRC15:36
mriedemhttps://review.openstack.org/#/c/571325/6/nova/virt/libvirt/vif.py15:36
mriedemunless contrail? confused...15:36
janguttermriedem: YOU ARE NOT THE ONLY CONFUSED PERSON!15:36
janguttermriedem: from what I could piece together, vrouter used to be there, then they gained vhost-user support and added ANOTHER vif.15:37
janguttermriedem: that VIF got added as an os-vif plugin.15:37
janguttermriedem: and 'vrouter' was left behind.15:37
janguttermriedem: alone and unloved.15:37
mriedemso the vrouter stuff in nova legacy vif code is unused b/c if you have the contrail plugin loaded, we'll load that up first and *not* need to fallback to the legacy vif code,15:38
mriedemif you do'nt have the contrail os-vif plugin installed on the system, we will use the legacy vrouter fallback15:38
janguttermriedem: the contrail plugin (as is) only does vhost-user (DPDK) plugging, not tap plugging that 'vrouter' needs.15:39
janguttermriedem: current contrail / tungsten / kernel solutions _still_ use the Nova path :-(15:40
mriedemso, in stien, os-vif will add the new composable object model things, do a major release,15:44
mriedemnova depends on that and starts to use it for new plugin support,15:44
mriedemthere will be the old and new os-vif interfaces for a full release (S->T)15:45
mriedemin that time,15:45
mriedemexisting plugins will need to move over to the new model,15:45
mriedemand then the old stuff will be dropped sometime in T with a major release of os-vif,15:45
mriedemand kuryr-k8s is ok with that plan?15:45
*** rambo_li has quit IRC15:45
mriedemand hopefully no one is storing a serialized version of these things with the old model in a db somewhere...15:46
mriedemi.e. the object model will always be recalculated at the time it's needed15:46
janguttermriedem: I don't think os-vif is needs to do a major release until we've ironed out the upgrade path -> sean-k-mooney and jaypipes will likely assign some fun stuff to me.15:46
janguttermriedem: pinning object version numbers would not break backwards compatibility?15:48
*** dpawlik has joined #openstack-nova15:48
aspiersmriedem: Have made some progress on your questions. More detail soon but quick summary for now is that q35 machine type doesn't support IDE which means we'll have to jump through an extra hoop or two in certain cases (configdrive defaults to iso9660 which currently means ide bus on x86_64), but given the existing virtio-scsi support I'm optimistic this won't be a big hurdle (to mix metaphors). It will15:49
mriedempinning how? where?15:49
aspiersalmost certainly require extra documentation though, and possibly extra requirements on any images which need to work with SEV+configdrive.15:49
aspiersI think similar caveats will apply for volumes attached via IDE too15:50
janguttermriedem: i.e. not incrementing the version numbers of the objects.15:50
aspiersbut these caveats already apply when q35 machine type is requested via image metadata, so it's not an entirely new limitation15:50
mriedemaspiers: yeah i saw that yesterday, thanks. if we're already documenting things for sev limitations, i guess saying "config drive will require vfat" which, since that's per-host today, means you'd have sev instances restricted to certain hosts - which people would probably do anyway given the reserved memory restrictions,15:51
mriedemi had thought there was an image property to tell nova which config drive format to use, but i only see img_config_drive to tell nova to use config drive or not15:51
mriedemmaybe it's just not documented...15:51
aspiersmriedem: yeah exactly, there's also the hardware requirement for SEV support they already have to consider :-)15:52
mriedemi guess there isn't an image property for the config drive format,15:52
aspiersI didn't see one15:52
mriedemwe could certainly add that, seems weird that it's per-host config and not per-instance15:52
aspiersit looks hardcoded to me15:52
*** dpawlik has quit IRC15:52
mriedemit's a config option15:53
aspiersright15:53
mriedemi'd like to avoid conditional logic on the type by adding things like "if SEV use vfat" etc15:53
aspiersyes I agree15:53
aspiersdon't want to introduce any more snowflake code than strictly necessary15:54
aspiersmriedem: but it made me wonder, is there any good reason why x86_64 is the only architecture still using ide for configdrive?15:54
mriedemjangutter: i thought the spec said that for the new composable interface stuff there wouldn't be version changes on the object model15:54
aspiersI looked at the git commit history and it seemed to be just a legacy thing15:55
mriedemaspiers: idk, it could just be really old code15:55
mriedemi'm not really familiar with that though, mdbooth might be more help15:55
aspiersoriginally it was x86_64 only, and later other archs were added which couldn't use ide15:55
aspiersso yeah, I think it's just really old code15:55
aspiersbut even if so, I'm guessing changing it would break some guests which are maybe expecting the config drive to be IDE15:56
mriedemmaybe,15:56
aspiersone of our qemu/libvirt gurus recommends virtio-scsi15:56
mriedemif the guest knows what it wants for the config drive format, we should really have an image property or flavor extra spec for that15:56
aspiersthat sounds like a good idea ot me15:57
aspiersBTW I also found https://blueprints.launchpad.net/nova/+spec/virtio-scsi-by-default15:57
aspierswhich is per-host15:57
aspiersso maybe that could help15:57
aspierswell, I guess that wouldn't affect configdrive15:57
janguttermriedem: as far as I understand (and that's a follow-on question later), changing the object hash means you _should_ bump the version. we'll be changing the hash, but deciding not to bump the version.15:57
mriedem"2) VMs will be able to have more than 26 volumes attached, up to 255."15:57
mriedemthat overlaps with a bp melwitt is working on15:58
aspiersoh, interesting15:58
mriedemhttps://blueprints.launchpad.net/nova/+spec/conf-max-attach-volumes15:58
melwittdid someone say... volumes15:58
aspiers:D15:58
aspiersI also found caveats here https://access.redhat.com/solutions/1758693 but not sure if they still apply15:58
aspiersI don't have access to the rest of that article ;-P15:58
mriedemjangutter: yes you should bump the versoin whenever you change the object model15:59
mriedemlike new fields, new methods, method signature changes, etc15:59
mriedemhowever, if nothing is using the os-vif objects over the wire, it's mostly just a best practice16:00
mriedemso like i said on the spec, it's not the end of the world if the rules are bent during a transition here for hte library16:00
aspiersmriedem: any other configdrive experts I should poll on this? just mdbooth?16:00
mriedemi.e. ultimately we get the same thing from os-vif as we do from os-brick, and os-brick is just random dicts16:00
mriedemwe take a thing from cinder, pass it to brick, get a dict back, pass that to cinder,16:01
mriedemand the vendor backends all understand what is in their special dict16:01
janguttermriedem: yes - and Jay keeps trying to get me to say that out loud in our open-plan office.16:01
mriedemsame thing with os-vif16:01
mriedemif this channel is our open plan office, i just said it out loud16:01
mriedemit makes upgrades extremely brittle,16:01
mriedemand really can/should only support N-1 at most lockstep upgrades between nova/cinder and nova/neutron,16:02
aspiersIf the only clean way to solve this is adding a per-image property for configdrive bus, I could submit a bp/spec for that. I guess we'd also have to decide whether that's a strict dependency on the critical path to the SEV MVP, or something which can proceed in parallel.16:02
mriedembut no one has cared enough yet to take that on16:02
mriedemaspiers: mikal has historically been the goto config drive person16:02
aspiersgotcha, thanks16:02
mriedembut you would likely have to email him16:02
melwittaspiers: fwiw there's not additional caveats on the article beyond what shows in that "preview"16:02
janguttermriedem: yes - and the trouble is that os-vif, even though it's pretty new, has already gotten some crufty bits Sean and Jay wants to clean up.16:03
aspiersmelwitt: thanks!16:03
mriedemaspiers: that doesn't need it's own bp, it would just be a work item in your existing sev spec16:03
mriedemi.e. you have two options as a deployer:16:03
mriedem1. config the host(s) to use vfat for everything, and use host aggregates to pin sev instances to those hosts (you might do this anyway as noted)16:04
mriedem2. if you mix instances on hosts (sev and non-sev), then you can add an image property to control the config drive format for the sev instances16:04
aspiersyup, that makes sense16:05
mriedemjay is always looking to clean up crufty bits, with fire usually16:05
janguttermriedem: so the core question is - should I cut down that section (saying - the adoption plan for these interfaces will be ironed out. Promise!)16:05
janguttermriedem: or scale up -> this is the twelve-point plan for world domination, we have everything in hand.16:06
mriedemjangutter: so going back to what i asked earlier http://paste.openstack.org/show/737315/ - is that correctly capturing the plan?16:06
aspiersmriedem: beginning to sound like we need yet another patchset then... I feel increasingly guilty each time I submit a new one ;-/16:06
mriedemjangutter: it doesn't need to be either extreme,16:06
mriedemit can be "here is the proposed high-level plan, details will be ironed out during implementation"16:06
mriedembut if http://paste.openstack.org/show/737315/ is the high level plan, then throw that in the spec16:06
janguttermriedem: I think, the last line is probably going to be - we'll work with kuryr to help them during the transition.16:06
mriedemok16:07
mriedemthen shoot the moon i guess16:07
*** dklyle has quit IRC16:07
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec  https://review.openstack.org/57020116:07
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Add instance hard delete  https://review.openstack.org/57020216:07
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: [WIP] Enable rebuild for instances in cell0  https://review.openstack.org/57020316:07
*** dklyle has joined #openstack-nova16:07
aspiersmriedem: regarding IDE attached volumes I'm thinking that this could just be a documented limitation, similarly to the boot disk limitation against virtio-blk16:07
*** efried has joined #openstack-nova16:08
aspiersI don't think there are any other limitations re. volumes but still confirming that16:08
janguttermriedem: many, many, many thanks. And one more indulgence.16:08
janguttermriedem: Looking at ovo I didn't find good docs describing the effects of inheritance and composition on object versions....16:09
*** jobewan has joined #openstack-nova16:09
mriedemjangutter: they probably don't exist16:09
janguttermriedem: composition's always been "use a map" or something.16:09
mriedemjangutter: i will have to defer to dansmith on that16:09
janguttermriedem: before I forget all of this and have to relearn it -> where would the best place be to commit it, onto the ovo docs?16:10
mriedemprobably yeah16:10
mriedemhttps://docs.openstack.org/oslo.versionedobjects/latest/user/index.html16:10
janguttermriedem: thanks, I'll jot up my notes, fall into a Christmas coma, wake up and try to figure out what this madman wrote. Thanks very very very much for braving the madness.16:11
*** dklyle has quit IRC16:13
mriedemjangutter: so, are you going to update the spec at all today? or should i just approve and you'll follow up or...?16:15
*** tbachman has quit IRC16:15
mriedemb/c i'm here next week but gone the week of xmas, and then back the first week of jan but out the week of jan 1016:15
mriedemjan 10 is spec freeze16:15
mriedemjangutter: if you're just going to follow up on the spec with clarifications and cleanups, but no major technical changes in direction, i'll just approve now and you can follow up16:16
janguttermriedem: I'm respinning today with the changes, even in a coma I have some limited brain function.16:16
mriedemok16:16
janguttermriedem: I'm not going to disappear, but I won't be on 24/7.16:17
*** pcaruana has quit IRC16:20
*** spatel has joined #openstack-nova16:22
spatelsean-k-mooney: morning..16:23
mriedemmy enthusiasm for this spec will disappear however :)16:23
mriedemi want to be this lady when i grow up https://deadspin.com/phoenix-woman-dunks-on-suns-owner-robert-sarver-at-city-183108457616:23
spatelsean-k-mooney: I am seeing these errors in my nova.log on compute node: every minute duration..16:23
spatelostack-compute-sriov-01 nova-compute:2018-12-14 11:22:22.161 40288 WARNING nova.pci.utils [req-0d87b5e4-6ece-4beb-880c-51c7c5835a66 - - - - -] No net device was found for VF 0000:03:09.0: PciDeviceNotFoundById: PCI device 0000:03:09.0 not found16:23
*** ivve has joined #openstack-nova16:24
*** dklyle has joined #openstack-nova16:24
spatelEverything working great just trying to understand WARNING mesg..16:24
*** jmlowe has quit IRC16:27
aspiersmriedem: BTW thanks a lot again for your continued patience and help :) I can probably submit an updated patchset in the next few hours if you think that makes sense?16:32
*** igordc has joined #openstack-nova16:33
*** kaisers_away is now known as kaisers_16:37
*** gyee has joined #openstack-nova16:37
*** rodolof has quit IRC16:38
mriedemaspiers: sure, but you're still waiting on volume-backed support test results or...?16:38
lyarwoodmriedem / melwitt ; https://review.openstack.org/#/c/618478/ - quick question about this workaround, is it going to need a releasenote and if so which section should I use? I'm assuming `issues` but the docs suggest that's only used towards GA.16:39
mriedemother16:39
*** rodolof has joined #openstack-nova16:39
lyarwoodkk, I'll sort that out now.16:39
aspiersmriedem: not test results - just confirmation that there are no other bus-related limitations with q3516:39
mriedemlyarwood: note that my responding to you does not imply me wanting that change :)16:40
aspiersmriedem: we've already proven the ide issue (although that hardly required proof)16:40
*** dklyle has quit IRC16:41
lyarwoodmriedem: yeah I know, I know, it's garbage...16:41
mriedemlyarwood: it doesn't mean *you're* garbage though!16:41
lyarwoodmriedem: awww thanks16:41
* mriedem hugs lee16:41
melwittlol16:42
*** Shilpa has quit IRC16:42
*** wolverineav has joined #openstack-nova16:44
dansmithmriedem: splattered some more comments on your spec if you want to try to read those before I fade into holiday16:45
*** rodolof has quit IRC16:45
dansmithmriedem: I guess at this point, the plan just needs to try like real hard to get that merged the first week in january before you disappear and the spec deadline comes eh?16:45
*** rodolof has joined #openstack-nova16:45
*** belmoreira has quit IRC16:47
*** igordc has quit IRC16:48
*** igordc has joined #openstack-nova16:48
mriedemdansmith: yeah16:51
dansmithwell, if I don't come back next year, I wish you luck16:51
mriedemthank you16:51
*** kaisers_ is now known as kaisers_away16:52
openstackgerritBalazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF  https://review.openstack.org/62354316:53
openstackgerritBalazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest  https://review.openstack.org/62531016:53
openstackgerritBalazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist  https://review.openstack.org/62531116:53
mriedemdansmith: i think you will very much enjoy this bug fix while you're here https://review.openstack.org/#/c/619061/16:56
mriedemfixes the pg job,16:56
mriedemshould improve our cell mapping query by project_id code16:56
mriedemsigned off by zzzeek himself16:56
melwittmriedem, dansmith: should we... adjust the spec deadline because of the holidays? it kinda sucks that there's so much unactionable time between now and the deadline16:56
dansmithmriedem: I think you very much don't know what I enjoy, apparently16:56
*** mdbooth has quit IRC16:56
mriedemdansmith: oh but there is stuff about camping and dirty cartoons in it16:56
dansmithmelwitt: the holidays come the same time every year, so I don't think this is much of a surprise16:56
dansmithmriedem: ORLY16:56
melwittI don't think it's a surprise, but anyway, was just a thought16:57
mriedemmelwitt: i say leave it - people have plenty of actionable time for months leading up to the freeze16:57
dansmithmelwitt: and we've had a lot of time open for spec review, I'm not sure that extending the deadline is going to change that16:57
melwittok, fair enough16:58
mriedemmelwitt: what you could do is sort out what from the bucket is stuff we should actually focus on before the freeze, and then get that out to the ML16:58
mriedembecause there is likely lots of cruft, but a few that just need another +2 or are things we should focus on in stein yet16:58
dansmithmelwitt: sorry I should have thrown a smiley on the end of that.. meant to sound snarky, not dickly :)16:58
dansmithmriedem: ++16:59
dansmithhelp focus the last week of reviews in jan16:59
mriedemat this point i'm mostly looking to get the amd sev and jan's thing in16:59
mriedemi mean for things i'm actively reviewing16:59
melwittok, that's good feedback. I'll do that16:59
mriedemthere are a couple of other specs that have had lots of review and just need a push over the line16:59
*** kaisers_away is now known as kaisers_17:00
* melwitt nods17:00
*** kaisers_ is now known as kaisers_away17:00
kashyapHeay folks, so I was reading the scrollback here.  I have posted a "simple thing" -- https://review.openstack.org/#/c/625216/ (libvirt: Support native TLS for migration and disks over NBD)17:01
*** kaisers_away is now known as kaisers_17:01
kashyapSee the commit message (I spent full 2 hours fiddling with it) for the "essay" :D17:01
*** ttsiouts has quit IRC17:02
mriedemdoesn't sound simple17:02
melwittthat looks like that should be at least a blueprint, if not a spec17:02
kashyap:-)17:02
mriedemlive migration + tls + anything = doom17:02
kashyapTruer words were never said17:02
*** k_mouza has joined #openstack-nova17:03
mriedem"oh you're on/not on shared storage and/or volume-backed? sorry!"17:03
kashyapmriedem: Ha!  _That_ is what is fixed17:03
kashyapThis whole week I (almost) singuarly focused on it17:03
kashyapEven wrote this detailed doc, with a start, middle, and an end: https://kashyapc.fedorapeople.org/Native-TLS/Setup-for-NBD-and-migration-streams-over-TLS.rst.txt17:03
kashyapYou can do a "TLS journey" if you follow that doc with concentration and focus.17:04
mriedemcan i do *anything* else?17:04
kashyapWhat more ... I even have evidence files (yet to upload) that shows precisely what to find :D17:04
kashyapmriedem: You are free to do anything you fancy.  You know that17:04
mriedemi'm just joking of course17:04
kashyap:D17:04
* mriedem hugs kashyap17:04
mriedemi'm real fucking huggy today17:05
kashyapI see mriedem is giving free hugs all around17:05
kashyapmriedem: See -- you didn't take up my offer to get you that drink (damned if I'll remember the name) you wanted17:05
kashyapBut _of course_ ... when you're with SO in Europe17:05
mriedemroot beer17:05
*** tssurya has quit IRC17:05
openstackgerritMatt Riedemann proposed openstack/nova master: Migrate upgrade checks to oslo.upgradecheck  https://review.openstack.org/60349917:05
kashyapNot even the last thing you want to do is hang out with me :D17:05
mriedemor "rooted beer" as an EU might call it17:06
kashyapAh, yes.17:06
kashyapmriedem: So the nice thing is that: now Nova guests can have encryption (*without* the penalty of "libvirtd tunnelling") for all migration streams17:06
kashyapNamely: Instance guest RAM, device state + disks over NDB17:07
* kashyap stops with the marketing 17:07
*** udesale has quit IRC17:07
*** wolverineav has quit IRC17:07
kashyapAnd goes to upload his "evidence files"17:07
kashyapOh ... the fly in the ointment is I'll be on PTO next week  (if I don't take them, they'll disappear).  So only be back in 1st week of Jan to come back to write tests17:08
kashyapSo ... saying: "No, you wretch, I will not even click on the URL without tests" is perfectly reasonable17:09
mriedemi seem to remember something about nbd + the tunneling thing years ago from danpb17:09
mriedembut it's very hazy now17:10
mriedemor maybe it was markmc17:10
mriedemidk17:10
* mriedem goes to lunch17:10
*** mriedem is now known as mriedem_lunch17:10
*** erlon_ has joined #openstack-nova17:10
kashyapmriedem_lunch: When you get back from lunch, as of today:17:10
kashyap - Nova has 'live_migration_tunnelled' -- but if you use that, you can't do "block migration"17:11
*** dklyle has joined #openstack-nova17:11
kashyapThat is one of the major cases we fix.  Thus, having encryption for all streams17:11
kashyap(By "streams", migration stream + NBD stream)17:12
kashyapAnd going forward, we will deprecate the 'live_migration_tunnelled', because it has _awful_ performance impact and latency17:13
kashyapAs there'll be no compelling reason to use it.17:13
kashyapmelwitt: Hi, forgot to address your comment17:14
*** erlon has quit IRC17:14
kashyapmelwitt: I _thought_ I posted a spec, but only settled with "bug", as it's technically a "bug": https://bugs.launchpad.net/nova/+bug/179879617:14
openstackLaunchpad bug 1798796 in OpenStack Compute (nova) "libvirt: Use VIR_MIGRATE_TLS to get QEMU's native TLS support for migration and NBD" [Medium,In progress] - Assigned to Kashyap Chamarthy (kashyapc)17:14
kashyapBut, I know what you mean.17:15
melwittcalling that a bug is a stretch IMO, if you need a commit message that long and at least a certain version of QEMU etc17:15
melwittbut maybe that's just me17:16
kashyapNo, you're fully right.  Given the length of the commit message17:16
kashyapI might as well just put it in a spec17:16
kashyapWhat do you suggest: a spec-less Blueprint, or a spec?17:17
* kashyap goes to register a BP to begin with17:17
melwittI usually say, start with a specless blueprint (you need a blueprint either way) and then usually we discuss in the nova meeting and decide whether a spec is needed17:17
dansmithI agree with melwitt, and I think it's a spec given the commit message is already nearly a spec17:17
dansmithwell, I agree with melwitt as of 30s ago :P17:17
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir when using rbd  https://review.openstack.org/61847817:17
kashyapdansmith: Okido.  As you know, I'm not averse to (efficient and useful!) words17:18
*** efried has quit IRC17:18
kashyapSorry for being a lazy pig and not writing it until the last moment17:18
dansmithin said meeting, I would just say "if you need a spec in the commit message it should probably be a spec" :)17:18
kashyapI accept any penalty you may incur on me.17:18
kashyapdansmith: No...that's too quippy17:18
kashyapOkay, before the my brain cache gets flushed, might as well just do it.  Here we go.17:19
melwittheh. well, true if it were specless it would have to be like, literally the commit message was enough to explain it and no one had further questions and no additional details were needed17:19
melwittwhich is unlikely17:20
kashyapmelwitt: Did you read the commit message? :-)17:20
dansmiththe code is really simple,17:20
dansmithso it seems overkill for a spec, but the commit message is long, and there's apparently another tome of reference material from kashyap17:20
dansmithso I dunno17:20
kashyapYeah, except the part about _which_ of the 4 flags go together, and _which_ I shold not mix17:20
melwittkashyap: yes :) it is a mini spec17:21
kashyapdansmith: From enabling point of view, it's straight-forward17:21
kashyapmelwitt: LOL17:21
kashyapYeah, I spent a whole 2 hours to write.  I'm a slow-as-molasses with writing down thoghts17:21
dansmithso i could be maybe persuaded that it should just be a BP, if the commit message was trimmed down to non-kashyap standards and the patch included docs changes to explain what the commit message is17:22
melwittanother advantage of the spec is it goes into our docs as nice reference place17:22
dansmithyes, the commit message is documenting usage, which isn't right, IMHO17:22
kashyapdansmith: The TODO will be gone from the commit.  Isn' it quite trimmed?17:22
kashyapYeah, I agree with both of you17:22
dansmithkashyap: no17:23
kashyapThis is so frelling fiddly because it took me the whole dammed WEEK to set it up!17:23
dansmithkashyap: if you need rst formatting and section headers in your commit message, you're doing it wrong17:23
melwitthaha17:23
kashyapdansmith: I dare you:17:23
dansmithmelwitt: amirite? :)17:23
kashyapNo17:23
melwittdansmith: yup17:24
kashyapdansmith: So long as the commit message is _useful_, readable, conveys meaningful information, the format doesn't matter17:24
kashyapYou've seen kernel commit messages, they go longer :D17:24
kashyapNews at 11: "This is not the kernel"17:24
dansmithkashyap: they use them for a totally different purpose17:24
kashyapdansmith: All the while I was writing that commit, I thought: "A cover letter would be nice" ... which is the "spec" :-)17:25
kashyapdansmith: And yes: as you asked earlier: I of course want to write docs with the patch.17:26
melwittkashyap: yeah, I think you have great info there, just better in a design doc rather than commit message, IMHO17:27
kashyapYeah, agreed.  I just wrote that to not lose the context in the head.17:27
kashyapWill move it around.17:27
melwittand commit message refers to that design doc (blueprint) so we can get to it17:27
melwittyeah, I understand17:27
kashyapAt the risk of being banned from the channel, if I might say ... I'm a bit old-fashioned in the sense that: A commit should explain without requiring network access :-)17:28
melwittheh17:28
kashyapSorry, it's a habit I learnt from the "mailing list" folks.17:29
melwittthese days it feels like there's nothing you can do without network access17:29
kashyapThat's why I try to not "break people's flow of reading" by saying: here you must click on this link, and then, get distrated by the Reddit tab next to it17:29
kashyapAnd then forget that you were reading the commit message :D17:29
*** markvoelker has joined #openstack-nova17:31
melwittI'll put this bp (after you create it) on the "first week of jan" list since it sounds like the code change is simple, just a matter of docs and capturing details17:32
kashyapThanks, one messy thing (even the libvirt storage folks said) is the item I noted in the 1023434th line on the commit:17:33
kashyap"Figure out _which_ combination of migration flags are valid. E.g. VIR_MIGRATE_NON_SHARED_INC + VIR_MIGRATE_TLS: To migrate the NBD stream over TLS. And what about VIR_MIGRATE_NON_SHARED_DISK?"17:33
kashyapI need to carefully re-review what flags Nova uses, and what combinations we allow.17:33
kashyapIt's actually not "messy"; just a logic thing I need to work out.17:34
*** k_mouza_ has joined #openstack-nova17:34
melwittok17:35
*** markvoelker has quit IRC17:35
*** bnemec is now known as beekneemech17:37
*** k_mouza has quit IRC17:38
kashyapmelwitt: When you get a minute: one comment on benchmarks17:38
*** psachin has quit IRC17:39
kashyapBenchmarks of non-native TLS vs. "native TLS", i.e.   DanPB did some of it when he was doing the QEMU work17:39
kashyapBut I don't have the URL ready; I'll check w/ him and add that details in the "Q&A" with the reviewers17:39
*** k_mouza_ has quit IRC17:39
kashyapHope it's not a "hard requirement"17:39
*** macza has joined #openstack-nova17:45
openstackgerritBalazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest  https://review.openstack.org/62531017:45
openstackgerritBalazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist  https://review.openstack.org/62531117:45
openstackgerritBalazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF  https://review.openstack.org/62354317:45
melwittkashyap: I don't think so, since it's opt-in via conf option17:45
*** macza has quit IRC17:45
*** derekh has quit IRC17:47
openstackgerritJan Gutter proposed openstack/nova-specs master: Spec to implement os-vif generic datapath offloads  https://review.openstack.org/60761017:50
*** dklyle has quit IRC17:51
*** kaisers_ is now known as kaisers_away17:51
*** wolverineav has joined #openstack-nova17:52
*** wolverineav has quit IRC17:52
*** wolverineav has joined #openstack-nova17:52
kashyapmelwitt: Okido, noted.17:52
melwittwould be certainly nice to include in the docs and/or spec when you find it17:53
jangutterdansmith: so... I'm looking for a place to jot down the stuff I learned about ovo and versioning before I forget it and have to rediscover it.17:55
jangutterdansmith: mostly the things about the great "composition vs inheritance" debate of 2018.17:55
dansmithjangutter: yeah, I'm not sure what to tell you, but it seems like somewhere in ovo is the right place17:56
jangutterdansmith: even if it ends up being an abandoned doc review, want to do something in January or so...17:57
dansmithjangutter: january sounds god :)17:57
dansmith*good17:57
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add workaround to cleanup instance dir when using rbd  https://review.openstack.org/61847817:58
jangutterdansmith: I was half-afraid that "just do it as a blog post" would be the go-to thing, but I'll try to make it generic enough that it's not a pain to update.17:59
*** yan0s has quit IRC17:59
*** dklyle has joined #openstack-nova18:00
dansmithjangutter: yeah docs somewhere would be better I think, even if it has to start in nova, but just a text file in ovo would be better than nothing18:00
kashyapmelwitt: When you have a moment, as promised: https://blueprints.launchpad.net/nova/+spec/support-qemu-native-tls-for-live-migration18:00
melwittthanks18:00
melwittaw, I was expecting a paste of your commit message in there18:01
kashyapmelwitt: Does it make sense?  My eyes are weary from reading my own sentences18:01
kashyapmelwitt: I thought it's not "allowed"?18:01
melwittwhy not?18:01
kashyapCan post the rest of it there as well.  As the Blueprint says "this is shown in feature texts"18:02
kashyapImplying: "be mindful what you post"18:02
kashyapOkay, let me go post the rest18:02
melwittoh, I didn't know that. it's not shown in any of our docs18:02
kashyapAh, okay, then.18:03
melwittwe use launchpad just for the milestone tracking and such, for organizing things18:03
*** jangutter has quit IRC18:05
*** kaisers_away is now known as kaisers_18:06
*** kaisers_ is now known as kaisers_away18:07
kashyapYep, noted.18:11
kashyapmelwitt: When you can, please refresh and see if it's better18:11
* kashyap hopes mriedem_lunch won't get tarred and feathered by mriedem_lunch for writing a "mini spec" in a Blueprint18:12
kashyapNo ... he is a good mood today; I even got the Christmas present of a hug from him18:12
kashyapErr, that "/me" sentence got borked.  Let me rewrite18:12
*** igordc has quit IRC18:13
*** itlinux has quit IRC18:13
* kashyap hopes _he_ won't get tarred and feathered by mriedem_lunch for writing a "mini spec" in a Blueprint :D18:13
*** itlinux has joined #openstack-nova18:13
melwittkashyap: looks fine to me. I didn't think anyone would have a problem with it, so if someone does, sorry for leading you astray. tell them it's my fault :)18:16
kashyapHehe18:16
kashyapmelwitt: No problem.  If people ask me questions  & convince me to write a spec, and I can't defend myself, I will of course write one without making excuses :-)18:16
kashyapOkay, I'll make dinner, then18:17
melwittkashyap: yeah, I think the thought is, either way we want the details documented somewhere. so you can either add docs changes to your patch that explains all the version needed, flags to use, benchmark link, reference material link, etc. or, you can put that stuff in a spec. for now, I thought since you wrote that commit message, why not paste it in the blueprint for a starting point18:18
melwittyou'll need a release note too, in your patch18:19
kashyapYeah, absolutely18:20
kashyapWas just writing that in the TODO :-)18:21
*** sridharg has quit IRC18:21
*** sahid has quit IRC18:21
*** wolverineav has quit IRC18:23
*** dklyle has quit IRC18:25
*** Swami has joined #openstack-nova18:26
*** wolverineav has joined #openstack-nova18:26
*** rodolof has quit IRC18:27
*** wolverineav has quit IRC18:28
*** wolverineav has joined #openstack-nova18:28
*** mlavalle has quit IRC18:35
*** kaisers_away is now known as kaisers_18:37
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Support native TLS for migration and disks over NBD  https://review.openstack.org/62521618:38
*** kaisers_ has quit IRC18:42
*** N3l1x has joined #openstack-nova18:42
*** N3l1x has quit IRC18:42
*** N3l1x has joined #openstack-nova18:43
*** dklyle has joined #openstack-nova18:46
*** mriedem_lunch is now known as mriedem18:49
*** tbachman has joined #openstack-nova18:51
*** mriedem has quit IRC18:52
*** spatel has quit IRC18:53
*** dklyle has quit IRC18:54
*** mriedem has joined #openstack-nova18:56
*** igordc has joined #openstack-nova18:59
openstackgerritMerged openstack/nova stable/queens: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62350919:07
*** dklyle has joined #openstack-nova19:11
*** dklyle has quit IRC19:21
*** wolverineav has quit IRC19:25
*** wolverineav has joined #openstack-nova19:25
*** ttsiouts has joined #openstack-nova19:28
*** wolverineav has quit IRC19:30
openstackgerritMatt Riedemann proposed openstack/nova master: Fail to live migration if instance has a NUMA topology  https://review.openstack.org/61108819:31
*** jmlowe has joined #openstack-nova19:32
*** wolverineav has joined #openstack-nova19:38
*** burt has joined #openstack-nova19:40
*** dklyle has joined #openstack-nova19:42
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: add live migration timeout action  https://review.openstack.org/61914319:50
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: remove live_migration_progress_timeout config  https://review.openstack.org/61914219:50
*** dklyle has quit IRC19:55
*** macza has joined #openstack-nova20:01
*** ttsiouts has quit IRC20:04
*** ttsiouts has joined #openstack-nova20:04
*** betherly has joined #openstack-nova20:09
*** betherly has quit IRC20:13
melwittstarted the "first week of jan" etherpad here https://etherpad.openstack.org/p/nova-stein-blueprint-spec-freeze20:15
melwittwill send it to the ML when I have more filled out20:16
openstackgerritMatt Riedemann proposed openstack/nova master: Fix up force live migration completion docs  https://review.openstack.org/62533920:16
mriedemdansmith: so i want to test triggering a post-copy in the gate, but the problem is these tiny cirros instances live migrate in less than a second, and our completion timeout is in seconds (integers) so i need it to take at least a second. wondering if you're aware of any libvirt guest APIs where I can inject something into the guest to basically stall the live migration and force the timeout and switch to post-copy20:27
mriedemi know sahid had that bandwidth thing...20:27
mriedemhey we even have a config option for this... live_migration_bandwidth20:30
*** igordc has quit IRC20:31
*** ttsiouts has quit IRC20:33
dansmithmriedem: the only thing you can do to stall it from the inside is to dirty memory like a banshee20:33
dansmithiirc, danpb had a little C program that would behave badly20:33
dansmithbut it'd be pretty dependent on how fast the machine was that you're testing on20:34
dansmithbut no, not aware of anything libvirty to help with that20:34
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: test for force complete live migrate with post-copy  https://review.openstack.org/62534320:35
openstackgerritMerged openstack/nova master: Remove lock on SchedulerReportClient._create_client  https://review.openstack.org/62477020:35
openstackgerritMerged openstack/nova stable/pike: Add secret=true to fixed_key configuration parameter  https://review.openstack.org/62351020:35
mriedemyeah ok maybe that won't work then20:36
mriedembut i tried!20:36
*** priteau has quit IRC20:37
*** wolverineav has quit IRC20:43
*** wolverineav has joined #openstack-nova20:44
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Spec to implement os-vif generic datapath offloads  https://review.openstack.org/60761020:44
*** dtrainor has quit IRC20:45
*** wolverineav has quit IRC20:49
*** betherly has joined #openstack-nova20:50
*** tbachman has quit IRC20:50
*** betherly has quit IRC20:55
*** wolverineav has joined #openstack-nova20:58
*** pbandark has joined #openstack-nova20:59
*** mchlumsky has quit IRC21:01
pbandarkhi.. i am facing issue while creating instance on openstack. the instance is getting created. but, when I check the console logs of the vm, i can see kernel panic. https://pastebin.com/dZ2uTuFa any suggestion would be really helpful.21:02
*** ttsiouts has joined #openstack-nova21:03
openstackgerritMerged openstack/nova-specs master: Spec to implement os-vif generic datapath offloads  https://review.openstack.org/60761021:07
*** aloga has quit IRC21:11
*** aloga has joined #openstack-nova21:11
*** jobewan has quit IRC21:16
*** dklyle has joined #openstack-nova21:27
*** dklyle has quit IRC21:32
*** dklyle has joined #openstack-nova21:33
*** mchlumsky has joined #openstack-nova21:35
*** N3l1x has quit IRC21:38
openstackgerritBen Nemec proposed openstack/nova master: Migrate upgrade checks to oslo.upgradecheck  https://review.openstack.org/60349921:46
mriedembeekneemech: heh forgot about the functional test21:51
mriedemdansmith: replied to your replies and new questions in the cross-cell resize spec https://review.openstack.org/#/c/616037/ - good things in there again, thanks. good news is since i wrote that, i think quite a bit of this is at least more clear, so some of the open questions are closing, which is nice.21:52
beekneemechmriedem: Yeah, looks like it just got moved so it wouldn't have shown up in the conflict list.21:52
mriedemdansmith: so you can exit for the year knowing it's sort of coming together21:52
mriedemprobably hairiest issue is how much existing code do we want to hack vs just writing something entirely new from scratch21:53
*** mchlumsky has quit IRC21:53
mriedemi'm not sure i'll have the energy to poc an alternative next week, but maybe21:53
mriedemi have already split a bunch of shit out21:53
*** rodolof has joined #openstack-nova21:54
*** dklyle has quit IRC21:54
*** igordc has joined #openstack-nova21:56
*** dklyle has joined #openstack-nova21:56
*** ttsiouts has quit IRC22:00
mriedemcalling it quits o/22:01
*** mriedem has quit IRC22:01
*** dklyle has quit IRC22:02
*** awaugama has quit IRC22:03
*** ttsiouts has joined #openstack-nova22:07
*** igordc has quit IRC22:08
*** igordc has joined #openstack-nova22:10
*** dklyle has joined #openstack-nova22:13
*** betherly has joined #openstack-nova22:14
*** k_mouza has joined #openstack-nova22:15
*** dklyle has quit IRC22:18
*** rodolof has quit IRC22:18
*** betherly has quit IRC22:18
*** ttsiouts has quit IRC22:19
*** k_mouza has quit IRC22:23
*** betherly has joined #openstack-nova22:24
*** betherly has quit IRC22:29
*** ivve has quit IRC22:29
*** slaweq has quit IRC22:33
*** dklyle has joined #openstack-nova22:37
*** dklyle has quit IRC22:41
*** dklyle has joined #openstack-nova22:42
*** wolverineav has quit IRC22:51
openstackgerritKrzysztof Opasiak proposed openstack/nova master: Fix server IPs with non-unique network names  https://review.openstack.org/62537122:53
*** macza has quit IRC22:56
*** dklyle has quit IRC22:57
*** wolverineav has joined #openstack-nova22:59
*** wolverineav has quit IRC23:03
*** wolverineav has joined #openstack-nova23:06
*** k_mouza has joined #openstack-nova23:07
*** lbragstad has quit IRC23:08
*** k_mouza has quit IRC23:08
*** lbragstad has joined #openstack-nova23:17
*** lbragstad has quit IRC23:22
openstackgerritMerged openstack/nova master: Remove GROUP BY clause from CellMapping.get_by_project_id  https://review.openstack.org/61906123:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!