| *** sree has joined #openstack-nova | 00:01 | |
| *** yamamoto has joined #openstack-nova | 00:02 | |
| *** sree has quit IRC | 00:06 | |
| *** yamamoto has quit IRC | 00:08 | |
| *** Swami has quit IRC | 00:09 | |
| *** hshiina|afk is now known as hshiina | 00:14 | |
| *** salv-orlando has joined #openstack-nova | 00:23 | |
| *** salv-orlando has quit IRC | 00:28 | |
| *** gyankum has joined #openstack-nova | 00:32 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:32 | |
| *** zhurong has joined #openstack-nova | 00:32 | |
| *** hemna_ has quit IRC | 00:34 | |
| *** _ix has quit IRC | 00:34 | |
| *** priteau has joined #openstack-nova | 00:36 | |
| *** gjayavelu has quit IRC | 00:39 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552 | 00:40 |
|---|---|---|
| *** priteau has quit IRC | 00:40 | |
| *** yingjun has joined #openstack-nova | 00:42 | |
| *** gyankum has quit IRC | 00:44 | |
| *** Zames has joined #openstack-nova | 00:48 | |
| *** Zames has quit IRC | 00:51 | |
| *** odyssey4me has quit IRC | 00:53 | |
| *** odyssey4me has joined #openstack-nova | 00:53 | |
| *** hongbin has joined #openstack-nova | 00:57 | |
| *** chyka has joined #openstack-nova | 01:01 | |
| *** yamamoto has joined #openstack-nova | 01:04 | |
| *** chyka has quit IRC | 01:05 | |
| *** tiendc has joined #openstack-nova | 01:07 | |
| *** fragatina has quit IRC | 01:08 | |
| *** AlexeyAbashkin has joined #openstack-nova | 01:08 | |
| *** yamamoto has quit IRC | 01:09 | |
| *** fragatina has joined #openstack-nova | 01:10 | |
| *** r-daneel has quit IRC | 01:11 | |
| *** dikonoo has joined #openstack-nova | 01:12 | |
| *** gyankum has joined #openstack-nova | 01:12 | |
| *** AlexeyAbashkin has quit IRC | 01:13 | |
| *** fragatina has quit IRC | 01:14 | |
| *** yangyapeng has joined #openstack-nova | 01:19 | |
| *** fragatina has joined #openstack-nova | 01:20 | |
| Spaz-Home | Annnnd weekend over | 01:21 |
| *** salv-orlando has joined #openstack-nova | 01:24 | |
| *** suresh12 has quit IRC | 01:24 | |
| *** fragatina has quit IRC | 01:25 | |
| *** yingjun has quit IRC | 01:28 | |
| *** salv-orlando has quit IRC | 01:29 | |
| openstackgerrit | Jake Yip proposed openstack/nova master: Add --before option to db archive_deleted_rows https://review.openstack.org/556751 | 01:29 |
| *** yassine has quit IRC | 01:33 | |
| *** dikonoo has quit IRC | 01:33 | |
| *** dikonoor has joined #openstack-nova | 01:33 | |
| *** tbachman has joined #openstack-nova | 01:34 | |
| *** yassine has joined #openstack-nova | 01:35 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 01:37 |
| openstackgerrit | Merged openstack/nova stable/queens: Change compute mgr placement check to region_name https://review.openstack.org/555901 | 01:37 |
| *** tbachman_ has joined #openstack-nova | 01:40 | |
| *** tbachman has quit IRC | 01:40 | |
| *** tbachman_ is now known as tbachman | 01:40 | |
| *** takashin has joined #openstack-nova | 01:41 | |
| *** dikonoor has quit IRC | 01:42 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 01:47 |
| *** suresh12 has joined #openstack-nova | 01:59 | |
| *** suresh12 has quit IRC | 02:03 | |
| *** yamamoto has joined #openstack-nova | 02:05 | |
| *** fragatina has joined #openstack-nova | 02:06 | |
| *** liverpooler has joined #openstack-nova | 02:08 | |
| *** yamamoto has quit IRC | 02:11 | |
| *** bkopilov has quit IRC | 02:12 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove ec2 in service and cmd https://review.openstack.org/556778 | 02:14 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 02:14 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove db ec2 https://review.openstack.org/557572 | 02:14 |
| *** _ix has joined #openstack-nova | 02:19 | |
| *** sdeath has joined #openstack-nova | 02:19 | |
| *** salv-orlando has joined #openstack-nova | 02:25 | |
| *** fragatina has quit IRC | 02:25 | |
| *** Spazmotic has joined #openstack-nova | 02:29 | |
| *** salv-orlando has quit IRC | 02:31 | |
| *** Spaz-Work has quit IRC | 02:32 | |
| *** cheran has joined #openstack-nova | 02:32 | |
| *** priteau has joined #openstack-nova | 02:37 | |
| *** yingjun has joined #openstack-nova | 02:38 | |
| *** priteau has quit IRC | 02:41 | |
| *** itlinux has joined #openstack-nova | 02:43 | |
| *** gongysh has joined #openstack-nova | 02:45 | |
| *** yamamoto has joined #openstack-nova | 02:47 | |
| *** sdeath has quit IRC | 02:53 | |
| *** sdeath has joined #openstack-nova | 02:54 | |
| *** sdeath has quit IRC | 02:55 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152 | 02:56 |
| *** amodi has quit IRC | 02:58 | |
| *** sdeath has joined #openstack-nova | 02:59 | |
| openstackgerrit | Jianle He proposed openstack/nova-specs master: Back up volume-backed-instance https://review.openstack.org/530214 | 03:00 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Fix endpoint URI /allocation_requests https://review.openstack.org/557580 | 03:01 |
| *** tbachman has quit IRC | 03:02 | |
| *** psachin has joined #openstack-nova | 03:02 | |
| *** sdeath has quit IRC | 03:06 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 03:07 |
| openstackgerrit | Merged openstack/nova stable/queens: Allow force-delete even if task_state is not None https://review.openstack.org/543343 | 03:07 |
| openstackgerrit | Merged openstack/nova stable/queens: Ensure the JSON-Schema covers the legacy v2 API https://review.openstack.org/543490 | 03:12 |
| *** links has joined #openstack-nova | 03:12 | |
| *** wxy has left #openstack-nova | 03:14 | |
| *** fragatina has joined #openstack-nova | 03:20 | |
| *** takashin has quit IRC | 03:23 | |
| *** harlowja has quit IRC | 03:24 | |
| *** yangyapeng has quit IRC | 03:26 | |
| *** yangyapeng has joined #openstack-nova | 03:27 | |
| *** salv-orlando has joined #openstack-nova | 03:27 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 03:28 |
| *** cheran has quit IRC | 03:29 | |
| *** udesale has joined #openstack-nova | 03:29 | |
| openstackgerrit | Merged openstack/nova stable/queens: [placement] Add sending global request ID in get https://review.openstack.org/543116 | 03:31 |
| *** _ix has quit IRC | 03:31 | |
| *** salv-orlando has quit IRC | 03:31 | |
| openstackgerrit | Merged openstack/nova stable/queens: docs: Disable smartquotes https://review.openstack.org/554188 | 03:31 |
| openstackgerrit | Merged openstack/nova stable/queens: Return 400 when compute host is not found https://review.openstack.org/550661 | 03:31 |
| *** yangyapeng has quit IRC | 03:33 | |
| *** bkopilov has joined #openstack-nova | 03:35 | |
| melwitt | tonyb: thanks for all the stable reviews | 03:47 |
| *** nicolasbock has quit IRC | 03:47 | |
| tonyb | melwitt: np sorry I'm so sporadic | 03:48 |
| *** tbachman has joined #openstack-nova | 03:48 | |
| melwitt | no worries | 03:49 |
| *** FL1SK has quit IRC | 03:49 | |
| *** annp has quit IRC | 03:49 | |
| openstackgerrit | Merged openstack/nova stable/pike: Remove osprofiler tests https://review.openstack.org/548886 | 03:49 |
| *** psachin` has joined #openstack-nova | 03:50 | |
| *** patriciadomin has quit IRC | 03:50 | |
| *** psachin has quit IRC | 03:50 | |
| *** patriciadomin has joined #openstack-nova | 03:51 | |
| *** udesale has quit IRC | 03:51 | |
| *** takashin has joined #openstack-nova | 03:56 | |
| *** dave-mccowan has quit IRC | 03:56 | |
| openstackgerrit | Merged openstack/nova stable/pike: Handle spawning error on unshelving https://review.openstack.org/548526 | 03:57 |
| *** dave-mccowan has joined #openstack-nova | 03:58 | |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: mask InjectionInfo.admin_pass https://review.openstack.org/548312 | 03:58 |
| *** harlowja has joined #openstack-nova | 03:59 | |
| *** liverpooler has quit IRC | 04:00 | |
| *** yingjun has quit IRC | 04:02 | |
| *** germs has quit IRC | 04:04 | |
| *** germs has joined #openstack-nova | 04:04 | |
| *** germs has quit IRC | 04:04 | |
| *** germs has joined #openstack-nova | 04:04 | |
| *** germs has quit IRC | 04:04 | |
| *** _ix has joined #openstack-nova | 04:04 | |
| *** fragatina has quit IRC | 04:05 | |
| *** germs has joined #openstack-nova | 04:05 | |
| *** germs has quit IRC | 04:05 | |
| *** germs has joined #openstack-nova | 04:05 | |
| *** germs has quit IRC | 04:09 | |
| *** AlexeyAbashkin has joined #openstack-nova | 04:09 | |
| *** phuongnh has joined #openstack-nova | 04:10 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Fix endpoint URI /allocation_requests https://review.openstack.org/557580 | 04:12 |
| *** hongbin has quit IRC | 04:12 | |
| *** sticker has quit IRC | 04:12 | |
| *** AlexeyAbashkin has quit IRC | 04:14 | |
| *** dave-mcc_ has joined #openstack-nova | 04:16 | |
| *** sree has joined #openstack-nova | 04:16 | |
| *** dave-mccowan has quit IRC | 04:16 | |
| *** janki has joined #openstack-nova | 04:17 | |
| *** yamahata has joined #openstack-nova | 04:17 | |
| *** bhujay has joined #openstack-nova | 04:21 | |
| *** hoangcx has quit IRC | 04:25 | |
| *** abhishekk has joined #openstack-nova | 04:25 | |
| *** dklyle has quit IRC | 04:26 | |
| *** hoangcx has joined #openstack-nova | 04:28 | |
| *** tiendc has quit IRC | 04:28 | |
| *** phuongnh has quit IRC | 04:28 | |
| *** tiendc has joined #openstack-nova | 04:28 | |
| *** phuongnh has joined #openstack-nova | 04:28 | |
| *** Tom-Tom has joined #openstack-nova | 04:29 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 04:34 |
| *** suresh12 has joined #openstack-nova | 04:34 | |
| *** chyka has joined #openstack-nova | 04:37 | |
| *** FL1SK has joined #openstack-nova | 04:39 | |
| *** chyka has quit IRC | 04:41 | |
| *** dave-mcc_ has quit IRC | 04:46 | |
| *** ratailor has joined #openstack-nova | 04:48 | |
| *** hoangcx has quit IRC | 04:50 | |
| *** tiendc has quit IRC | 04:50 | |
| *** phuongnh has quit IRC | 04:50 | |
| *** tiendc has joined #openstack-nova | 04:51 | |
| *** hoangcx has joined #openstack-nova | 04:51 | |
| *** phuongnh has joined #openstack-nova | 04:51 | |
| *** rcernin_ has joined #openstack-nova | 04:59 | |
| *** rcernin has quit IRC | 05:00 | |
| *** _ix has quit IRC | 05:03 | |
| *** udesale has joined #openstack-nova | 05:04 | |
| *** zhurong has quit IRC | 05:04 | |
| *** salv-orlando has joined #openstack-nova | 05:08 | |
| *** bhujay has quit IRC | 05:08 | |
| *** claudiub has joined #openstack-nova | 05:11 | |
| *** priya__ has quit IRC | 05:14 | |
| *** yangyapeng has joined #openstack-nova | 05:17 | |
| *** gjayavelu has joined #openstack-nova | 05:18 | |
| *** yangyapeng has quit IRC | 05:21 | |
| *** bhujay has joined #openstack-nova | 05:23 | |
| *** belmoreira has joined #openstack-nova | 05:30 | |
| *** suresh12 has quit IRC | 05:30 | |
| *** tbachman has quit IRC | 05:33 | |
| *** moshele has joined #openstack-nova | 05:35 | |
| *** r-daneel has joined #openstack-nova | 05:38 | |
| *** moshele has quit IRC | 05:42 | |
| *** r-daneel has quit IRC | 05:42 | |
| *** Eran_Kuris has joined #openstack-nova | 05:43 | |
| *** zhurong has joined #openstack-nova | 05:47 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova-specs master: Disallow rotation parameter 0 for 'createBackup' API https://review.openstack.org/511825 | 05:48 |
| *** kholkina has joined #openstack-nova | 05:52 | |
| takashin | 05:53 | |
| *** suresh12 has joined #openstack-nova | 05:59 | |
| *** yingjun has joined #openstack-nova | 06:00 | |
| *** moshele has joined #openstack-nova | 06:01 | |
| *** Tom-Tom has quit IRC | 06:02 | |
| *** Tom-Tom has joined #openstack-nova | 06:03 | |
| *** yangyapeng has joined #openstack-nova | 06:03 | |
| *** suresh12 has quit IRC | 06:04 | |
| *** germs has joined #openstack-nova | 06:05 | |
| *** germs has quit IRC | 06:05 | |
| *** germs has joined #openstack-nova | 06:05 | |
| *** harlowja has quit IRC | 06:06 | |
| *** sree_ has joined #openstack-nova | 06:07 | |
| *** Tom-Tom has quit IRC | 06:07 | |
| *** sree_ is now known as Guest90515 | 06:07 | |
| *** shaohe_feng has joined #openstack-nova | 06:07 | |
| *** germs has quit IRC | 06:10 | |
| *** sree has quit IRC | 06:10 | |
| *** udesale_ has joined #openstack-nova | 06:13 | |
| *** rcernin_ has quit IRC | 06:14 | |
| *** sahid has joined #openstack-nova | 06:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 06:16 |
| *** udesale has quit IRC | 06:16 | |
| *** rcernin has joined #openstack-nova | 06:17 | |
| *** yamahata has quit IRC | 06:18 | |
| *** Tom-Tom has joined #openstack-nova | 06:22 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 06:22 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 06:26 |
| *** moshele has quit IRC | 06:27 | |
| *** trozet has quit IRC | 06:27 | |
| *** trozet_ has joined #openstack-nova | 06:28 | |
| *** lajoskatona has joined #openstack-nova | 06:28 | |
| *** gjayavelu has quit IRC | 06:29 | |
| *** gjayavelu has joined #openstack-nova | 06:29 | |
| *** andreas_s has joined #openstack-nova | 06:32 | |
| *** udesale_ has quit IRC | 06:38 | |
| *** udesale has joined #openstack-nova | 06:39 | |
| *** moshele has joined #openstack-nova | 06:41 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova stable/queens: add check before adding cpus to cpuset_reserved https://review.openstack.org/557621 | 06:48 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova stable/pike: add check before adding cpus to cpuset_reserved https://review.openstack.org/557622 | 06:50 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 06:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 06:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 06:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 06:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 06:57 |
| *** salv-orlando has quit IRC | 06:58 | |
| *** salv-orlando has joined #openstack-nova | 06:59 | |
| *** moshele has quit IRC | 06:59 | |
| *** sree has joined #openstack-nova | 07:01 | |
| *** rcernin has quit IRC | 07:03 | |
| *** abhishekk_ has joined #openstack-nova | 07:03 | |
| *** udesale_ has joined #openstack-nova | 07:03 | |
| *** gyan_ has joined #openstack-nova | 07:03 | |
| *** ratailor_ has joined #openstack-nova | 07:03 | |
| *** Guest90515 has quit IRC | 07:04 | |
| *** gyankum has quit IRC | 07:04 | |
| *** ratailor has quit IRC | 07:04 | |
| *** abhishekk has quit IRC | 07:04 | |
| *** gyan__ has joined #openstack-nova | 07:05 | |
| *** links has quit IRC | 07:05 | |
| *** udesale__ has joined #openstack-nova | 07:05 | |
| *** ratailor__ has joined #openstack-nova | 07:05 | |
| *** links has joined #openstack-nova | 07:06 | |
| *** stakeda has joined #openstack-nova | 07:07 | |
| *** udesale has quit IRC | 07:07 | |
| *** priteau has joined #openstack-nova | 07:08 | |
| *** ratailor_ has quit IRC | 07:08 | |
| *** abhishekk_ has quit IRC | 07:08 | |
| *** gyan_ has quit IRC | 07:09 | |
| *** udesale_ has quit IRC | 07:09 | |
| *** ragiman has joined #openstack-nova | 07:16 | |
| *** salv-orlando has quit IRC | 07:20 | |
| *** salv-orlando has joined #openstack-nova | 07:20 | |
| *** abhishekk_ has joined #openstack-nova | 07:20 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152 | 07:22 |
| *** yamamoto has quit IRC | 07:22 | |
| *** tesseract has joined #openstack-nova | 07:22 | |
| *** yamamoto has joined #openstack-nova | 07:23 | |
| *** salv-orlando has quit IRC | 07:24 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Fix issue for pep8 on py3 https://review.openstack.org/557633 | 07:25 |
| *** tssurya has joined #openstack-nova | 07:26 | |
| *** gjayavelu has quit IRC | 07:30 | |
| *** alexchadin has joined #openstack-nova | 07:31 | |
| *** yamamoto_ has joined #openstack-nova | 07:32 | |
| *** yamamoto has quit IRC | 07:34 | |
| *** diga has joined #openstack-nova | 07:36 | |
| openstackgerrit | do3meli proposed openstack/nova-specs master: Adds resize on shared storage without ssh keys https://review.openstack.org/551927 | 07:36 |
| *** udesale has joined #openstack-nova | 07:45 | |
| bauzas | good morning stackers | 07:45 |
| *** phuongnh has quit IRC | 07:46 | |
| *** hoangcx has quit IRC | 07:46 | |
| *** tiendc has quit IRC | 07:46 | |
| openstackgerrit | licanwei proposed openstack/nova master: Make nova-manage capable of syncing all cell databases https://review.openstack.org/519275 | 07:46 |
| *** tiendc has joined #openstack-nova | 07:46 | |
| *** phuongnh has joined #openstack-nova | 07:46 | |
| *** hoangcx has joined #openstack-nova | 07:46 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova stable/pike: Allow force-delete even if task_state is not None https://review.openstack.org/543345 | 07:47 |
| *** udesale__ has quit IRC | 07:47 | |
| Spazmotic | Morning bauzas | 07:47 |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** salv-orlando has joined #openstack-nova | 07:56 | |
| *** avolkov has joined #openstack-nova | 08:00 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:00 | |
| *** janki has quit IRC | 08:02 | |
| *** germs has joined #openstack-nova | 08:06 | |
| *** germs has quit IRC | 08:06 | |
| *** germs has joined #openstack-nova | 08:06 | |
| *** AlexeyAbashkin has quit IRC | 08:07 | |
| *** bhujay has quit IRC | 08:07 | |
| *** trinaths has joined #openstack-nova | 08:09 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:10 | |
| *** germs has quit IRC | 08:11 | |
| *** chyka has joined #openstack-nova | 08:12 | |
| *** lucas-afk is now known as lucasagomes | 08:14 | |
| *** mdbooth has joined #openstack-nova | 08:16 | |
| *** chyka has quit IRC | 08:17 | |
| *** mdnadeem has joined #openstack-nova | 08:17 | |
| gibi | morning folks | 08:21 |
| *** jichen has joined #openstack-nova | 08:21 | |
| *** cdent has joined #openstack-nova | 08:22 | |
| jichen | hi sahid: regarding https://review.openstack.org/#/c/523387/, for singleton, if we want to keep | 08:22 |
| jichen | it, we need take something like 'http://127.0.0.1' as array key, do you think that's reasonable ? | 08:22 |
| *** zhaochao has joined #openstack-nova | 08:28 | |
| *** rgerganov has joined #openstack-nova | 08:33 | |
| *** derekh has joined #openstack-nova | 08:33 | |
| *** tetsuro has joined #openstack-nova | 08:34 | |
| *** bhujay has joined #openstack-nova | 08:35 | |
| *** rmart04 has joined #openstack-nova | 08:38 | |
| *** mdnadeem is now known as openstack-cinder | 08:38 | |
| *** openstack-cinder is now known as mdnadeem | 08:38 | |
| *** rcernin has joined #openstack-nova | 08:48 | |
| *** bhujay has quit IRC | 08:49 | |
| *** bkopilov has quit IRC | 08:52 | |
| *** Alexey_Abashkin has joined #openstack-nova | 08:52 | |
| sahid | jichen: oh i see what you mean, that's because of the parameters | 08:54 |
| jichen | sahid; yes, so that's why I want to avoid the singleton , you ok with that? | 08:54 |
| *** AlexeyAbashkin has quit IRC | 08:54 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 08:54 | |
| sahid | jichen: but you told me that, if we don't do a singleton we are going to create multipl connection, no? | 08:55 |
| *** AlexeyAbashkin has quit IRC | 08:55 | |
| sahid | jichen: so my thinking is that, only Hypervisor is handling call and you pass an instance of Hypervisor to your Guest class | 08:57 |
| *** ratailor__ is now known as ratailor | 08:57 | |
| sahid | jichen: i will write my thinking on your patches soon | 08:58 |
| *** AlexeyAbashkin has joined #openstack-nova | 08:58 | |
| gibi | jaypipes: I don't know if you saw the latest development in the bandwidth spec. I added a summary of the 3 open issues to PS22 https://review.openstack.org/#/c/502306/22 | 08:59 |
| *** zhurong has quit IRC | 09:00 | |
| *** takashin has left #openstack-nova | 09:03 | |
| jichen | sahid: ok, got it thanks for the info and help , I will take a look at that patch :) | 09:03 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 09:03 |
| sahid | jichen: but wait i will think a bit more about all of that | 09:03 |
| jichen | sure , thanks , sahid | 09:04 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041 | 09:07 |
| *** moshele has joined #openstack-nova | 09:07 | |
| *** diga has quit IRC | 09:09 | |
| *** kukacz_ has joined #openstack-nova | 09:10 | |
| *** bhujay has joined #openstack-nova | 09:10 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 09:18 |
| sahid | jichen: what is returned by zvm when calling example 'guest_list' | 09:23 |
| sahid | how zvm is representing a guest? | 09:23 |
| *** Dinesh_Bhor has quit IRC | 09:23 | |
| jichen | sahid: a guest is defined by a plain text such as following (xxxx is device, memory etc) | 09:25 |
| jichen | USER TEST0004 1024M 1024M | 09:25 |
| jichen | xxxx | 09:25 |
| jichen | xxxx | 09:25 |
| jichen | guest_list will return an array such as ['test0001', 'test0002'] which is a list of guest name managed by openstack | 09:25 |
| sahid | i see | 09:26 |
| sahid | jichen: i commented on two of your patches | 09:26 |
| *** bhujay has quit IRC | 09:27 | |
| sahid | let me know your thinking | 09:27 |
| jichen | sahid, thank you ,let me take a look | 09:27 |
| *** bhujay has joined #openstack-nova | 09:27 | |
| *** hshiina has quit IRC | 09:29 | |
| *** hshiina has joined #openstack-nova | 09:29 | |
| *** moshele has quit IRC | 09:31 | |
| *** mvk has quit IRC | 09:34 | |
| *** rmart04 has quit IRC | 09:35 | |
| *** tuanla____ has joined #openstack-nova | 09:35 | |
| *** rmart04 has joined #openstack-nova | 09:35 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557377 | 09:37 |
| *** kukacz_ has quit IRC | 09:41 | |
| *** kukacz_ has joined #openstack-nova | 09:42 | |
| *** jichen has quit IRC | 09:47 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 09:48 |
| *** trinaths has quit IRC | 09:49 | |
| *** yingjun has quit IRC | 09:50 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 09:51 |
| *** rmart04_ has joined #openstack-nova | 09:52 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 09:52 |
| *** rmart04 has quit IRC | 09:52 | |
| *** rmart04_ is now known as rmart04 | 09:52 | |
| *** kukacz_ is now known as kukacz | 09:52 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Set error state after failed evacuation https://review.openstack.org/518733 | 09:56 |
| openstackgerrit | Merged openstack/nova stable/queens: Handle EndpointNotFound when building image_ref_url in notifications https://review.openstack.org/554963 | 09:57 |
| openstackgerrit | Merged openstack/nova stable/queens: Always deallocate networking before reschedule if using Neutron https://review.openstack.org/555418 | 09:57 |
| openstackgerrit | Merged openstack/nova stable/queens: Migrate tempest-dsvm-cells job to an in-tree job definition https://review.openstack.org/556656 | 09:58 |
| *** germs has joined #openstack-nova | 10:07 | |
| *** germs has quit IRC | 10:07 | |
| *** germs has joined #openstack-nova | 10:07 | |
| *** gyan__ has quit IRC | 10:09 | |
| *** bkopilov has joined #openstack-nova | 10:10 | |
| *** janki has joined #openstack-nova | 10:11 | |
| *** germs has quit IRC | 10:12 | |
| *** Tom-Tom has quit IRC | 10:17 | |
| *** alexchadin has quit IRC | 10:22 | |
| *** moshele has joined #openstack-nova | 10:25 | |
| *** alexchadin has joined #openstack-nova | 10:27 | |
| *** moshele has quit IRC | 10:31 | |
| *** nicolasbock has joined #openstack-nova | 10:32 | |
| *** abhishekk_ has quit IRC | 10:33 | |
| *** Zames has joined #openstack-nova | 10:35 | |
| *** alexchadin has quit IRC | 10:36 | |
| *** rmart04 has quit IRC | 10:36 | |
| *** Zames has quit IRC | 10:39 | |
| *** Kumar has joined #openstack-nova | 10:46 | |
| *** Tom-Tom has joined #openstack-nova | 10:47 | |
| *** trinaths has joined #openstack-nova | 10:49 | |
| *** stakeda has quit IRC | 10:49 | |
| *** Kumar has quit IRC | 10:51 | |
| *** Kumar has joined #openstack-nova | 10:51 | |
| *** Tom-Tom has quit IRC | 10:51 | |
| *** AlexeyAbashkin has quit IRC | 10:53 | |
| *** rmart04 has joined #openstack-nova | 10:54 | |
| *** dtantsur|afk is now known as dtantsur | 10:55 | |
| *** voelzmo has joined #openstack-nova | 10:55 | |
| *** phuongnh has quit IRC | 10:55 | |
| *** ratailor has quit IRC | 10:56 | |
| *** ratailor has joined #openstack-nova | 10:57 | |
| *** sambetts|afk is now known as sambetts | 10:58 | |
| *** alexchadin has joined #openstack-nova | 10:58 | |
| *** voelzmo has quit IRC | 11:01 | |
| *** yamamoto has joined #openstack-nova | 11:01 | |
| *** voelzmo has joined #openstack-nova | 11:01 | |
| *** andreas_s has quit IRC | 11:02 | |
| *** andreas_s has joined #openstack-nova | 11:03 | |
| *** alexchadin has quit IRC | 11:03 | |
| *** yamamoto_ has quit IRC | 11:05 | |
| *** mvk has joined #openstack-nova | 11:05 | |
| *** andreas_s has quit IRC | 11:07 | |
| *** lucasagomes is now known as lucas-hungry | 11:07 | |
| *** alexchadin has joined #openstack-nova | 11:10 | |
| *** Zames has joined #openstack-nova | 11:18 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:18 | |
| *** Zames has quit IRC | 11:20 | |
| *** Zames has joined #openstack-nova | 11:23 | |
| sean-k-mooney[m] | sahid: hi, i just saw your comments on my mtu patch. ill respin with the extra unit tests hopefully today. i have a few minutes before my next meeting so ill see how much i can get done before 1 | 11:24 |
| *** Zames has quit IRC | 11:25 | |
| *** tuanla____ has quit IRC | 11:30 | |
| *** edmondsw has joined #openstack-nova | 11:30 | |
| sahid | sean-k-mooney[m]: ok, once i can see the change i will update my review | 11:31 |
| *** chyka has joined #openstack-nova | 11:34 | |
| *** Zames has joined #openstack-nova | 11:34 | |
| *** tiendc has quit IRC | 11:35 | |
| *** Zames has quit IRC | 11:36 | |
| *** stvnoyes has quit IRC | 11:37 | |
| *** belmoreira has quit IRC | 11:37 | |
| *** chyka has quit IRC | 11:39 | |
| *** belmoreira has joined #openstack-nova | 11:41 | |
| *** tetsuro has left #openstack-nova | 11:45 | |
| *** udesale has quit IRC | 11:46 | |
| openstackgerrit | Merged openstack/nova stable/pike: Allow force-delete even if task_state is not None https://review.openstack.org/543345 | 11:46 |
| *** ratailor has quit IRC | 11:46 | |
| *** ratailor has joined #openstack-nova | 11:46 | |
| *** udesale has joined #openstack-nova | 11:46 | |
| *** Kumar has quit IRC | 11:48 | |
| *** ratailor_ has joined #openstack-nova | 11:48 | |
| *** stvnoyes has joined #openstack-nova | 11:49 | |
| *** links has quit IRC | 11:49 | |
| *** andreas_s has joined #openstack-nova | 11:51 | |
| *** ratailor has quit IRC | 11:51 | |
| *** gongysh has quit IRC | 11:53 | |
| *** ratailor__ has joined #openstack-nova | 11:53 | |
| *** links has joined #openstack-nova | 11:53 | |
| *** nicolasbock has quit IRC | 11:54 | |
| *** ratailor_ has quit IRC | 11:55 | |
| *** lucas-hungry is now known as lucasagomes | 11:55 | |
| *** andreas_s has quit IRC | 11:56 | |
| *** trinaths has quit IRC | 11:57 | |
| *** vivsoni has quit IRC | 11:57 | |
| *** vivsoni has joined #openstack-nova | 11:58 | |
| *** rcernin has quit IRC | 12:05 | |
| *** danpawlik has joined #openstack-nova | 12:07 | |
| *** germs has joined #openstack-nova | 12:08 | |
| *** germs has quit IRC | 12:08 | |
| *** germs has joined #openstack-nova | 12:08 | |
| *** germs has quit IRC | 12:12 | |
| *** hshiina is now known as hshiina|afk | 12:13 | |
| *** udesale_ has joined #openstack-nova | 12:14 | |
| alex_xu_ | efried: jaypipes are you around? a question about multi-function fpga | 12:16 |
| *** udesale has quit IRC | 12:16 | |
| *** udesale_ has quit IRC | 12:19 | |
| edmondsw | efried I replied to your question in https://review.openstack.org/#/c/546713 | 12:22 |
| *** mdbooth has quit IRC | 12:22 | |
| *** mdbooth has joined #openstack-nova | 12:22 | |
| *** Kumar has joined #openstack-nova | 12:25 | |
| *** eharney has joined #openstack-nova | 12:26 | |
| *** alexchadin has quit IRC | 12:35 | |
| *** alexchadin has joined #openstack-nova | 12:35 | |
| *** alexchadin has quit IRC | 12:36 | |
| *** alexchadin has joined #openstack-nova | 12:36 | |
| *** alexchadin has quit IRC | 12:36 | |
| *** alexchadin has joined #openstack-nova | 12:37 | |
| *** alexchadin has quit IRC | 12:37 | |
| *** alexchadin has joined #openstack-nova | 12:38 | |
| *** liverpooler has joined #openstack-nova | 12:38 | |
| *** alexchadin has quit IRC | 12:38 | |
| *** alexchadin has joined #openstack-nova | 12:39 | |
| *** alexchadin has quit IRC | 12:39 | |
| *** alexchadin has joined #openstack-nova | 12:39 | |
| *** voelzmo has quit IRC | 12:42 | |
| *** alexchadin has quit IRC | 12:43 | |
| *** sapd has joined #openstack-nova | 12:45 | |
| efried | alex_xu_: hello | 12:49 |
| *** sahid has quit IRC | 12:50 | |
| *** sahid has joined #openstack-nova | 12:50 | |
| *** alexchadin has joined #openstack-nova | 12:50 | |
| alex_xu_ | efried: good morning | 12:52 |
| efried | alex_xu_: Not sure I'm the person to answer questions about FPGAs, but I'll give it a shot :) | 12:52 |
| alex_xu_ | efried: in the ptg, we only think about a fpga device only has one function, then we said create resource class for a whole device | 12:52 |
| alex_xu_ | efried: but now, a device can support multi funciton, and each function can be assigned to different VM | 12:53 |
| alex_xu_ | efried: actually it is placement question :) | 12:53 |
| alex_xu_ | efried: so we should create RP for a device, and resource class is function, just like SRIOV device, a device provides multiple function | 12:54 |
| alex_xu_ | does make sense | 12:54 |
| *** alexchadin has quit IRC | 12:54 | |
| *** lyan has joined #openstack-nova | 12:55 | |
| efried | alex_xu_: Yes, that is my understanding of how it will need to work. However, as you've seen from the dev ML, it can be more complicated than that. | 12:56 |
| *** lyan is now known as Guest84540 | 12:56 | |
| efried | alex_xu_: For example, there seem to be FPGAs where, once you decide they're going to have a particular function on them, they can no longer have a different one. bauzas is running into the same thing for his VGPUs. | 12:57 |
| *** odyssey4me has quit IRC | 12:57 | |
| *** odyssey4me has joined #openstack-nova | 12:57 | |
| bauzas | right | 12:57 |
| *** edmondsw has quit IRC | 12:58 | |
| *** edmondsw has joined #openstack-nova | 12:59 | |
| *** mgiles_ has joined #openstack-nova | 12:59 | |
| alex_xu_ | efried: bauzas yes, that is why i also think about we only support pre-programmed mode for the multi functions device | 12:59 |
| alex_xu_ | and same type in the all the functions in a device | 13:00 |
| alex_xu_ | if we want to support different function, we can create multiple RP for different type | 13:00 |
| efried | alex_xu_: Based on a config file or a user command. You're essentially talking about preconfiguring the physical function and locking down what virtual functions it's capable of. | 13:00 |
| efried | Which I think is probably an acceptable interim solution. | 13:01 |
| alex_xu_ | efried: yea | 13:01 |
| efried | Though ultimately it would be nice to be dynamic | 13:01 |
| *** andreas_s has joined #openstack-nova | 13:01 | |
| alex_xu_ | yes, at least for now, that is what we can have | 13:01 |
| alex_xu_ | efried: bauzas another problem is cyborg want to own some inventory info in his db and has filter to second level scheduling | 13:02 |
| alex_xu_ | in cyborg db, the usage of functions and the fuction is record | 13:02 |
| alex_xu_ | s/fuction/function type/ | 13:03 |
| *** mgiles_ has left #openstack-nova | 13:03 | |
| *** edmondsw has quit IRC | 13:03 | |
| alex_xu_ | for the usage of functions, that can be resolved by function as resource class | 13:03 |
| alex_xu_ | for the function type we can use trait | 13:03 |
| alex_xu_ | and I'm thinking tag the traits after cyborg burn bitstream to the fpga | 13:04 |
| alex_xu_ | that is only support for single function device | 13:04 |
| *** edmondsw has joined #openstack-nova | 13:05 | |
| *** andreas_s has quit IRC | 13:05 | |
| efried | alex_xu_: If we're doing that via a "preconfigure" step, I can see it being acceptable. What I'm worried about jaypipes and dansmith having a cow about is if we do it e.g. based on the first time an allocation is made against the device. | 13:08 |
| *** fragatina has joined #openstack-nova | 13:09 | |
| alex_xu_ | efried: for single function device, we will have RP for the device, the inventory is always 1 | 13:10 |
| *** alexchadin has joined #openstack-nova | 13:10 | |
| *** mriedem has joined #openstack-nova | 13:10 | |
| alex_xu_ | that is different with GPU case | 13:10 |
| *** damien_r has quit IRC | 13:12 | |
| cdent | just a heads up to anyone listening; I'm pretty sure that the move of the placement related db tests into the placement hierarchy has tweaked something with the management of trait syncing, such that sometimes (only sometimes) a databsase reset is happening but the reset of the trait sync flag is not happening | 13:12 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: PowerVM Driver: Network interface attach/detach https://review.openstack.org/546813 | 13:12 |
| cdent | I'm fixing it (and will make bug etc) | 13:12 |
| mriedem | cdent: thanks | 13:13 |
| *** belmoreira has quit IRC | 13:13 | |
| *** vivsoni has quit IRC | 13:14 | |
| *** vivsoni has joined #openstack-nova | 13:14 | |
| *** alexchadin has quit IRC | 13:14 | |
| efried | edmondsw: Thanks for fixing that up. | 13:15 |
| alex_xu_ | efried: are you saying the race case for the GPU tweak trait in the fly, just as you said in the ML. I see that case. But we won't have problem for the RP always has only 1 inventory | 13:15 |
| edmondsw | efried np | 13:15 |
| efried | mriedem: Sorry about that, I was in a hurry. Haste makes waist, or something. | 13:15 |
| *** artom has quit IRC | 13:16 | |
| efried | alex_xu_: I don't care about the race. We can't avoid that (I'm composing an answer to Sundar on that topic). | 13:16 |
| efried | alex_xu_: I don't think splitting into one RP per virtual function is going to help us. | 13:16 |
| mriedem | efried: what about your size 32 waist? | 13:16 |
| efried | mriedem: I haven't been a 32 since college. Probably because of haste. | 13:17 |
| edleafe | alex_xu_: efried: I think that this is similar to the discussion about NUMA configuration | 13:17 |
| alex_xu_ | efried: you mean you don't care the reason of two level scheduling. or you mean you don't care the race for tweak inventory/traits in the fly? | 13:17 |
| efried | edleafe: Yes it is. | 13:17 |
| alex_xu_ | I think sundar mix that two race in single email | 13:17 |
| edleafe | IOW, decide what it will be, and set inventory appropriately | 13:17 |
| efried | alex_xu_: Hold on, let me send this note, it summarizes my position. | 13:18 |
| *** salv-orlando has quit IRC | 13:18 | |
| edleafe | If an FPGA can never change its functions, then the resource class is the function. The device is not inventory, it's an RP | 13:18 |
| efried | edleafe: Right, decide up front how you're going to allow it to be configured. Which is limiting, but much simplifying. | 13:18 |
| alex_xu_ | edleafe: right | 13:18 |
| *** salv-orlando has joined #openstack-nova | 13:18 | |
| edleafe | Same as with NUMA - limiting but simplifying | 13:18 |
| edleafe | If we don't set limits, we'll be back in the "nova will take care of everything for you" business | 13:19 |
| edleafe | We'll spend 90% of our effort on the 5% use cases | 13:19 |
| alex_xu_ | I totally agree with that. actually I'm saying another race which is due to Cyborg will do second-level scheduling... | 13:19 |
| alex_xu_ | oops, maybe I didn't say clear | 13:20 |
| alex_xu_ | efried: actually I want to attach trait as function type is for re-use previously burn function | 13:21 |
| alex_xu_ | and for the device only support single function | 13:21 |
| edleafe | alex_xu_: you mean trait like CUSTOM_CAN_RUN_FUNCTION_X ? | 13:22 |
| alex_xu_ | edleafe: yes | 13:22 |
| alex_xu_ | edleafe: sorry, no | 13:22 |
| alex_xu_ | just CUSTOM_FUCNTION_X, not can run, attach trait after cyborg burn the function x into the device | 13:23 |
| *** salv-orlando has quit IRC | 13:23 | |
| edleafe | alex_xu_: so a request for a VM with that function comes in. How will find that device if the trait isn't present initially? | 13:24 |
| alex_xu_ | edleafe: a fpga can burn any function | 13:24 |
| *** efried has quit IRC | 13:24 | |
| *** alexchadin has joined #openstack-nova | 13:24 | |
| *** awaugama has joined #openstack-nova | 13:25 | |
| *** efried has joined #openstack-nova | 13:25 | |
| alex_xu_ | edleafe: we only tell cyborg we need function x, please burn that into the any available device. | 13:25 |
| edleafe | alex_xu_: sure, so why do we need to add the trait? | 13:25 |
| alex_xu_ | edleafe: after the VM is destroy, there is use-case, we want to reuse that device which already burn function x, so that is why I want to attach that trait. | 13:26 |
| *** ratailor__ has quit IRC | 13:26 | |
| *** abhi89 has joined #openstack-nova | 13:26 | |
| edleafe | alex_xu_: Cyborg is supposed to keep track of that - not placement | 13:26 |
| *** abhi89 has quit IRC | 13:26 | |
| edleafe | that's what they want to do with a weigher | 13:26 |
| edleafe | prefer hosts that already have that function available | 13:27 |
| alex_xu_ | edleafe: cyborg is responsible for attach trait to the fpga RP | 13:27 |
| *** Tom-Tom has joined #openstack-nova | 13:27 | |
| alex_xu_ | edleafe: and that need 'preferred trait' which we don't have today... | 13:27 |
| edleafe | ...which is a weigher | 13:28 |
| alex_xu_ | yes | 13:28 |
| *** esberglu has joined #openstack-nova | 13:28 | |
| dansmith | efried: you needn't corral all of my future reactions into "have a cow" territory just because there have been a few significant disagreements lately | 13:29 |
| edleafe | it would be much cleaner to not have them mess with these traits, and just have the weigher make a call to Cyborg to prefer those hosts that have the function available | 13:29 |
| dansmith | I don't birth bovine for pleasure | 13:29 |
| efried | dansmith: It's not that, it's about previously-had cows on this exact topic. | 13:29 |
| alex_xu_ | jaypipes said he is ok to have a 'preferred trait' in flavor extra, and has a nova scheduler weigher to weigh the traits. not a weigher inside placement | 13:30 |
| efried | alex_xu_, edleafe: Right, but jaypipes and dansmith have had a pretty firm stance from the start that we can't do traits like THIS_FPGA_HAS_FUNCTION_A_ON_IT_RIGHT_NOW. | 13:30 |
| edleafe | efried: ++ | 13:31 |
| efried | Even when we're talking about "preferred" traits. | 13:31 |
| alex_xu_ | efried, why? | 13:31 |
| edleafe | that's why all that logic needs to be in Cyborg | 13:31 |
| alex_xu_ | sorry for asking people repeat the thing people already said in PTG... | 13:31 |
| efried | alex_xu_: The statement is that "traits are capability, not state". | 13:31 |
| efried | alex_xu_: TBH, I've never understood the "why" of that. | 13:32 |
| *** voelzmo has joined #openstack-nova | 13:32 | |
| dansmith | efried: I'm not sure I've taken a hard stance against that, but let me say: | 13:32 |
| alex_xu_ | dansmith: ^ :) | 13:32 |
| dansmith | flipping a trait at high speed to indicate something like "cpu load appears low right now" | 13:32 |
| dansmith | seems like a really bad idea to me | 13:32 |
| dansmith | however, | 13:32 |
| dansmith | if cyborg is managing resources, and it decides when to remove a function from a device, like a cache manager kind of thing, | 13:33 |
| dansmith | I can see it committing a resource (so it knows it's claimed/committed) and then leaving a trait on it, | 13:33 |
| dansmith | and then deciding six hours after the last instance is gone that "okay, this should go back to generic empty" or something like that | 13:34 |
| dansmith | it's not great, and it could certainly be abused past my tolerance level, | 13:34 |
| dansmith | but I'm not sure it's the worst thing | 13:34 |
| dansmith | now, I don't think jaypipes agrees with me there, but.. | 13:34 |
| jaypipes | dansmith: I do. | 13:35 |
| cdent | people are going to "abuse" traits no matter what anyone says, so there's a part of me that thinks we should let it happen | 13:35 |
| efried | this ^ | 13:35 |
| alex_xu_ | I agree with that. | 13:35 |
| jaypipes | disagree. | 13:35 |
| *** belmoreira has joined #openstack-nova | 13:35 | |
| efried | Well, I'm not sure how we can stop 'em. | 13:35 |
| edleafe | dansmith: cyborg can set all the traits they want. The problem is expecting Nova to act on them outside of the normal flow of placement/scheduler | 13:35 |
| jaypipes | efried: by not encouraging it. | 13:35 |
| alex_xu_ | I only think about burn that image, and don't change it anymore... | 13:35 |
| edleafe | jaypipes: and not supporting it | 13:36 |
| dansmith | edleafe: right, we control how much of nova tries to obsess over the traits being set | 13:36 |
| jaypipes | traits != status changes | 13:36 |
| efried | jaypipes: Would you mind expostulating a bit on the reasoning behind that in the ML thread? | 13:36 |
| efried | jaypipes: "[nova] [cyborg] Race condition in the Cyborg/Nova flow" | 13:37 |
| efried | jaypipes: Though it seems like this conversation happens at least once a quarter, so maybe a permadoc somewhere would be expedient. | 13:37 |
| jaypipes | alex_xu_: I'm fine with a trait that means "this FPGA is capable of doing X". What I don't want to see is a precedence set for traits that mean "this foo is on at this moment or off at this moment" and have that trait be used by virt drivers or external agents as a poor-man's servicegroup API. | 13:37 |
| *** psachin` has quit IRC | 13:38 | |
| alex_xu_ | jaypipes: I see that, I think we can use trait for the pre-programmed fpga device | 13:38 |
| jaypipes | efried: yes, I will comment on the ML thread. not sure about expostulating, though. | 13:38 |
| edleafe | efried: another problem is we spent a lot of time in Dublin discussing these things and agreeing on boundaries. The current discussion seems to ignore all of that | 13:38 |
| alex_xu_ | and pre-programmed fpga device doesn't allow to re-program | 13:38 |
| alex_xu_ | jaypipes: in that case, does make sense? | 13:39 |
| dansmith | alex_xu_: jaypipes: let me restate what I think is a legit use, again using cyborg | 13:39 |
| edleafe | alex_xu_: pre-programmed functions are resource classes | 13:39 |
| efried | edleafe: How ignoring? I've been saying it ain't gonna fly. | 13:39 |
| edleafe | efried: not you | 13:39 |
| edleafe | sundar primarily | 13:39 |
| alex_xu_ | edleafe: I also think about that... | 13:39 |
| * jaypipes listens for dansmith's synopsis | 13:39 | |
| alex_xu_ | pre-programmed is normal accelerator device... | 13:39 |
| dansmith | I think it's legit for blazar to pre-provision images into FPGAs via cyborg according to upcoming schedule, set traits on them for the image, and de-provision/trait them at the end of the 24-hour reservation window | 13:40 |
| edleafe | if it's programmed for X and can't be changed, then it has an inventory on that function. That's a resource class | 13:40 |
| jaypipes | hold up, let dansmith finish his synopsis for a sec | 13:40 |
| dansmith | that's it.. just another example of pre-provisioned images getting traits so we can schedule to them by function | 13:40 |
| jaypipes | ok | 13:41 |
| edleafe | dansmith: that sounds like using traits as resource class proxies | 13:41 |
| alex_xu_ | dansmith: what's different with cyborg cache manager... | 13:41 |
| jaypipes | and frankly, that's what I *thought* the agreement was in Dublin, but granted, I only made the tail end of the discussion. | 13:41 |
| dansmith | I don't think that programming in a dynamic device needs to be resource class | 13:41 |
| *** alexchadin has quit IRC | 13:41 | |
| dansmith | jaypipes: same | 13:41 |
| dansmith | alex_xu_: it's not, as I said above in the earlier example | 13:42 |
| *** alexchadin has joined #openstack-nova | 13:42 | |
| jaypipes | dansmith: it *could* be done via a custom resource class, but then again, I find a nice simplicity in just having a standard resource class called FPGA_CONTEXT (or something like that) and decorating those pre-programmed slots (providers) with particular traits | 13:42 |
| dansmith | sure it could, I said "need" | 13:43 |
| efried | edleafe: The RC-vs-trait discussion is a tangent. The issue is whether/when it's okay to modify RPs "on the fly". And how on-the-fly is "on the fly"? | 13:43 |
| dansmith | jaypipes: it needs to be class per type of device, but yeah | 13:43 |
| edleafe | efried: I don't agree it's a tangent. If you model your resources correctly, the whole discussion goes away | 13:43 |
| *** eharney has quit IRC | 13:43 | |
| dansmith | efried: if you have a preferred trait of HAS_SSL, you get one without it, you claim it in scheduling, it's cool IMHO for cyborg to trait it up when it does the programming | 13:44 |
| alex_xu_ | dansmith: I must misunderstand this words "it's not great, and it could certainly be abused past my tolerance level," It means yes... or no.. | 13:44 |
| efried | dansmith: That would be cool. jaypipes are you on board with that? | 13:44 |
| dansmith | alex_xu_: that was referring to people doing other things, not this | 13:44 |
| *** fragatina has quit IRC | 13:45 | |
| jaypipes | I'm cool with what dansmith just said, yes. | 13:45 |
| edleafe | dansmith: that's a totally legit use case | 13:45 |
| jaypipes | here are the things I do *not* want to see: | 13:45 |
| *** felipemonteiro_ has joined #openstack-nova | 13:46 | |
| jaypipes | 1) agents, including the virt driver, using the traits API as a servicegroup/status API. | 13:46 |
| dansmith | alex_xu_: sorry I see why that was confusing I mixed that into other thoughts when I re-read | 13:46 |
| *** fragatina has joined #openstack-nova | 13:46 | |
| jaypipes | 2) *Consumer requests* causing traits to be set against a provider. | 13:46 |
| dansmith | jaypipes: 2 meaning something like nova setting traits on providers of has-instances or has-10-instances, or something like that yeah? | 13:47 |
| *** abhishekk has joined #openstack-nova | 13:47 | |
| dansmith | or has-some-volumes-attached-to-host-right-now-yo | 13:47 |
| mriedem | bottom 6 patches in the placement-req-filter series have a +2 https://review.openstack.org/#/c/544730/ | 13:47 |
| jaypipes | It is that latter point that I am afraid of, since it means we essentially throw out all the scheduling heuristics that are now made in placement (since we would no longer be able to filter on providers having a trait but would need to add some mechanism to detect providers that *could have* a trait on them, if certain conditions apply) | 13:47 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes Multiple GPU types https://review.openstack.org/557065 | 13:48 |
| efried | jaypipes: #2 is a bit sticky, though, innit? The consumer requests an instance with FPGA with function X, cyborg finds a previously-unfettered device suitable for use and flashes it with function X, then sets a trait saying it's got function X on it now. Is that "consumer requests causing traits to be set"? | 13:48 |
| dansmith | jaypipes: yup | 13:48 |
| *** salv-orlando has joined #openstack-nova | 13:48 | |
| dansmith | efried: it has given that device capability | 13:48 |
| bauzas | jaypipes: dansmith: very simple spec about providing a config option for defining a list of pGPUs a specific type would be supported https://review.openstack.org/557065 | 13:48 |
| *** yangyapeng has quit IRC | 13:48 | |
| dansmith | it has changed the device in some meaningful way that means it can do things | 13:48 |
| efried | dansmith: tbc, *I* am fine with that scenario. I'm asking if it violates jaypipes' #2 | 13:48 |
| jaypipes | efried: it would, yes. | 13:49 |
| bauzas | dansmith: jaypipes: if you can review it quickly, that would unblock me from using n-r-p for libvirt vGPUs | 13:49 |
| dansmith | jaypipes: o.O | 13:49 |
| *** hongbin has joined #openstack-nova | 13:49 | |
| bauzas | mriedem: dansmith: I'll sponsor https://review.openstack.org/#/c/544730/ and above | 13:50 |
| * bauzas looking | 13:50 | |
| dansmith | jaypipes: now I'm confused :) | 13:50 |
| jaypipes | efried: if cyborg configures its inventory/traits dynamically *at the time and due to a specific request from a consumer*, I have an issue with that | 13:50 |
| dansmith | jaypipes: heh, that's what you just said you were okay with | 13:50 |
| mriedem | alex_xu_: interesting idea to deprecate the backup API in https://review.openstack.org/#/c/511825/ - you should probably start a ML thread on that if you want wider input | 13:50 |
| jaypipes | dansmith: it's a difference in timing. | 13:50 |
| dansmith | jaypipes: no, I said above "sets the trait when programming" | 13:51 |
| alex_xu_ | mriedem: will do that later | 13:51 |
| jaypipes | dansmith: when is the programming done. | 13:51 |
| jaypipes | dansmith: that was a question, sorry.. when is the programming of the slots done? | 13:51 |
| *** _ix has joined #openstack-nova | 13:51 | |
| *** felipemonteiro_ has quit IRC | 13:51 | |
| jaypipes | dansmith: if it's done after GET /allocation_candidates, then that won't work. | 13:52 |
| dansmith | jaypipes: sure it will | 13:52 |
| jaypipes | dansmith: since clearly the trait won't be useful in filtering out destination providers. | 13:52 |
| alex_xu_ | jaypipes: dansmith note, for programmable fpga, it inventory always 1 | 13:52 |
| dansmith | jaypipes: it would be preferred | 13:52 |
| alex_xu_ | there is no race like we tweak traits in the fly for gpu | 13:52 |
| dansmith | jaypipes: hangout? | 13:53 |
| jaypipes | dansmith: sdure | 13:53 |
| jaypipes | sure | 13:53 |
| jaypipes | set it up. I will coffee up. | 13:53 |
| *** udesale has joined #openstack-nova | 13:53 | |
| jaypipes | let me grab a pug for emotional support. | 13:53 |
| dansmith | https://hangouts.google.com/call/vBep88lVuQCIThVzSqUZAAEE | 13:53 |
| mriedem | powervm interface attach/detach bp patch needs another +2 https://review.openstack.org/#/c/546813/ | 13:54 |
| dansmith | e'yone's invited of course | 13:54 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 13:56 |
| *** eharney has joined #openstack-nova | 13:58 | |
| *** mlavalle has joined #openstack-nova | 13:58 | |
| *** r-daneel has joined #openstack-nova | 13:58 | |
| bauzas | dansmith: just for sanity, left some comments on https://review.openstack.org/#/c/544730/16 but +W'd it | 13:59 |
| *** udesale has quit IRC | 13:59 | |
| *** dave-mccowan has joined #openstack-nova | 14:03 | |
| *** r-daneel_ has joined #openstack-nova | 14:04 | |
| *** yassine has quit IRC | 14:04 | |
| *** r-daneel has quit IRC | 14:04 | |
| *** r-daneel_ is now known as r-daneel | 14:04 | |
| *** andreas_s has joined #openstack-nova | 14:04 | |
| *** yassine has joined #openstack-nova | 14:05 | |
| *** Kumar has quit IRC | 14:06 | |
| *** _ix has quit IRC | 14:06 | |
| *** amodi has joined #openstack-nova | 14:06 | |
| *** _ix has joined #openstack-nova | 14:08 | |
| *** germs has joined #openstack-nova | 14:09 | |
| *** germs has quit IRC | 14:09 | |
| *** germs has joined #openstack-nova | 14:09 | |
| *** lajoskatona has quit IRC | 14:09 | |
| *** andreas_s has quit IRC | 14:10 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 14:10 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 14:10 |
| mriedem | bhagyashris: at least one more update in here i think https://review.openstack.org/#/c/511825/ | 14:11 |
| *** vladikr has quit IRC | 14:12 | |
| *** germs has quit IRC | 14:13 | |
| *** jlvillal has quit IRC | 14:15 | |
| *** _ix_ has joined #openstack-nova | 14:17 | |
| *** damien_r has joined #openstack-nova | 14:17 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Fix bad management of _TRAITS_SYNCED flag https://review.openstack.org/557722 | 14:17 |
| cdent | mriedem: that ^ fixes it in my tests | 14:17 |
| mriedem | let's recheck it a few times | 14:18 |
| *** _ix has quit IRC | 14:19 | |
| bhagyashris | mriedem: ok thank you for review. you mean to depricate the create backup api and newly introduce deleteBackup api will delete the backup using the rotation parameter | 14:20 |
| *** gjayavelu has joined #openstack-nova | 14:21 | |
| mriedem | claudiub: can you update this quick? https://review.openstack.org/#/c/557377/ | 14:21 |
| mriedem | bhagyashris: no, the alternative is to simply deprecate the createBackup API, and not introduce a new deleteBackups API | 14:21 |
| mriedem | since createBackup can all be done using orchestration of existing nova/glance APIs | 14:22 |
| *** itlinux has quit IRC | 14:22 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 14:22 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db https://review.openstack.org/556660 | 14:22 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings https://review.openstack.org/556819 | 14:22 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 14:22 |
| jaypipes | mriedem: amen, brother. | 14:24 |
| mriedem | makes me curious when/why createBackup was added | 14:25 |
| mriedem | but was likely so long ago that any blueprint for it has little to no detail | 14:25 |
| jaypipes | mriedem: correct. | 14:25 |
| *** kholkina has quit IRC | 14:25 | |
| *** vladikr has joined #openstack-nova | 14:25 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557377 | 14:26 |
| *** links has quit IRC | 14:26 | |
| bhagyashris | mriedem: ok i am not getting this: cleanup the backups using a rotation value controlled client-side | 14:27 |
| mriedem | bhagyashris: createBackup can be totally done using existing compute and image APIs today, without the actual createBackup API, | 14:27 |
| mriedem | i can snapshot an instance with specific metadata to indicate it's a backup | 14:28 |
| dansmith | alex_xu_: if that "what are you saying" was a joke, that was excellent :P | 14:28 |
| *** Spazmotic has quit IRC | 14:28 | |
| mriedem | and then i can, as a tenant user, delete older backup snapshots in glance | 14:28 |
| *** yangyapeng has joined #openstack-nova | 14:28 | |
| mriedem | bhagyashris: my point being, you as the tenant (or script, or external service, whatever) can do all of the createBackup stuff without the compute API (nova) doing it for you | 14:28 |
| alex_xu_ | dansmith: I'm good at pretend to not understand what you guys saying | 14:29 |
| *** danpawlik has quit IRC | 14:29 | |
| dansmith | haha | 14:29 |
| bauzas | dansmith: again, one comment on https://review.openstack.org/#/c/544729/16 but not holding me to +W | 14:29 |
| bauzas | dansmith: tl;dr: I guess we're talking of aggregate UUIDs, not names | 14:29 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 14:30 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 14:30 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | 14:30 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs. https://review.openstack.org/556459 | 14:30 |
| mriedem | bauzas: good point | 14:30 |
| bauzas | I don't want to throw the whole series | 14:31 |
| bauzas | since the code will still work | 14:31 |
| bauzas | at least until that point | 14:31 |
| mriedem | if we wanted to use a ListOfUUIDsField, we'd want to do that now | 14:31 |
| dansmith | bauzas: list of uuids is not enough | 14:31 |
| bauzas | mriedem: not really | 14:31 |
| dansmith | bauzas: which is why I didn't create one | 14:31 |
| bauzas | mriedem: because of the AND OR | 14:31 |
| *** Spazmotic has joined #openstack-nova | 14:32 | |
| bauzas | dansmith: yeah, I know | 14:32 |
| dansmith | we need a list of list of uuids, | 14:32 |
| bauzas | for me, it's just a docstring correction to make | 14:32 |
| dansmith | which I think is kinda nuts | 14:32 |
| mriedem | oh right, the comma | 14:32 |
| bauzas | I'm fine with keeping a list of strings as of noxw | 14:32 |
| dansmith | so these are "aggregate requests" and depend on the placement schema (which is strict) to handle it | 14:32 |
| bauzas | but the fact that we will have strings made of UUIDs and commas | 14:32 |
| bauzas | so, I just want to clarify the docstring, that's it | 14:32 |
| dansmith | bauzas: yeah, fair neough | 14:34 |
| dansmith | bauzas: the names make it easier to reason about the example, but I can make a point of explaining what they are | 14:34 |
| *** READ10 has joined #openstack-nova | 14:37 | |
| bhagyashris | mriedem: But giving provision through nova API to createBackup of server backup is more user friendly | 14:38 |
| mriedem | bhagyashris: well, it is because that's what is available today :) | 14:39 |
| mriedem | bhagyashris: to be clear, i'm not -2 on your spec, i'm just saying that the alternative to deprecate should be mentioned in there | 14:39 |
| *** fragatina has quit IRC | 14:40 | |
| *** Swami has joined #openstack-nova | 14:41 | |
| *** sree has quit IRC | 14:41 | |
| *** sree has joined #openstack-nova | 14:42 | |
| mriedem | claudiub: can you also propose a stable/queens backport for https://review.openstack.org/#/c/557377/ ? | 14:42 |
| mriedem | i've got a queens 17.0.2 release patch waiting and can hold it up for this | 14:42 |
| mriedem | since it was a regression in queens 17.0.1 | 14:43 |
| openstackgerrit | Claudiu Belu proposed openstack/nova stable/queens: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557727 | 14:43 |
| *** moshele has joined #openstack-nova | 14:44 | |
| bhagyashris | mriedem: yeah... still waiting for others opinion but deprecation will lose the user friendly and that most imp IMO. | 14:44 |
| *** zhaochao has quit IRC | 14:45 | |
| *** david-lyle has joined #openstack-nova | 14:45 | |
| *** hamzy has quit IRC | 14:46 | |
| bhagyashris | johnthetubaguy: Hi waiting for opinion on same ^ (https://review.openstack.org/#/c/511825/) | 14:47 |
| *** sree has quit IRC | 14:47 | |
| johnthetubaguy | bhagyashris: I like the idea of documenting the alternative, even if we decide against it | 14:47 |
| bhagyashris | mriedem: ok i will add this as alternative in spec and will go with proposed solution. | 14:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508 | 14:49 |
| bhagyashris | johnthetubaguy: ok i will add this as alternative in spec and will go with proposed solution. | 14:50 |
| *** artom has joined #openstack-nova | 14:51 | |
| *** tbachman has joined #openstack-nova | 14:52 | |
| bhagyashris | johnthetubaguy: continuing implementation as per the proposed solution I will push the patch soon | 14:52 |
| *** _ix_ has quit IRC | 14:52 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information https://review.openstack.org/312626 | 14:52 |
| *** sree has joined #openstack-nova | 14:52 | |
| efried | alex_xu_, dansmith, edleafe, jaypipes, cdent, bauzas: https://etherpad.openstack.org/p/placement-dynamic-traiting for a start | 14:53 |
| stephenfin | jaypipes, mriedem: Could one of you send this through? https://review.openstack.org/#/c/555000/ | 14:53 |
| *** moshele has quit IRC | 14:54 | |
| *** danpawlik has joined #openstack-nova | 14:55 | |
| *** bhujay has quit IRC | 14:56 | |
| mriedem | stephenfin: would prefer if jaypipes or bauzas did that since i didn't review that series | 14:57 |
| stephenfin | ack | 14:57 |
| *** sree has quit IRC | 14:57 | |
| *** chyka has joined #openstack-nova | 14:58 | |
| jaypipes | stephenfin: would you mind updating the commit message summary as cdent requests? | 14:58 |
| mriedem | if someone is looking for what appears to be a low-hanging fruit bug that just needs a rev of the patch, https://review.openstack.org/#/c/541660/ | 14:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Update 'share-pci-between-numa-nodes' spec to reflect reality https://review.openstack.org/555000 | 14:58 |
| stephenfin | jaypipes: done | 14:58 |
| jaypipes | stephenfin: done | 15:00 |
| stephenfin | ta :) | 15:00 |
| *** danpawlik has quit IRC | 15:00 | |
| dansmith | efried: I added a few notes, I gotta jump on a call now | 15:02 |
| jaypipes | cdent: btw, have you started on an os-resource-classes lib? if not, I was going to hop on that... | 15:02 |
| *** rmart04 has quit IRC | 15:02 | |
| *** chyka has quit IRC | 15:02 | |
| efried | dansmith: ack | 15:02 |
| cdent | jaypipes: go for it. I'd been trying to lay it out as bait for $random_person, but if you're keen go for it | 15:03 |
| jaypipes | alex_xu_: see my question to Intel folks on line 13 of the etherpad... | 15:03 |
| *** abhishekk has quit IRC | 15:05 | |
| alex_xu_ | jaypipes: yes, I think we should say it is 'pre-programmed' or 'static' compare to 'fully dynamic' | 15:06 |
| *** Kumar has joined #openstack-nova | 15:07 | |
| cdent | jaypipes, efried, others: watching that etherpad it appears that the conversation from the hangout is continuing rather than being summarized? | 15:08 |
| *** felipemonteiro_ has joined #openstack-nova | 15:09 | |
| edleafe | cdent: exactly. IOW, we can't summarize our conclusions if we didn't reach consensus | 15:09 |
| efried | cdent: Sorry, got pulled away as soon as I posted that. Will look in a couple minutes. | 15:09 |
| *** gjayavelu has quit IRC | 15:09 | |
| jaypipes | cdent: yes :( | 15:10 |
| *** cfriesen has joined #openstack-nova | 15:11 | |
| efried | mriedem: The fix https://review.openstack.org/#/c/557508/ works. But I think the hacking check fix isn't right just yet. I will revise. | 15:11 |
| *** jlvillal has joined #openstack-nova | 15:12 | |
| efried | mriedem: (The assertion that it works is based on internal discussions - I've asked them to update the bug accordingly to make it official.) | 15:12 |
| mriedem | efried: pep8 passes | 15:12 |
| efried | mriedem: But pyXX won't. | 15:12 |
| mriedem | oh, i didn't run those... | 15:12 |
| efried | I didn't either, just assuming based on how mock.patch works... | 15:12 |
| mriedem | if you change the hacking check, it likely should be a separate patch before that cinder fix | 15:12 |
| mriedem | i was just being lazy and expediant | 15:13 |
| efried | mriedem: Yeah, I'll fix the hacking check totally separately. I'll tweak the fix you did on this patch cause we want it quickish. | 15:13 |
| alex_xu_ | jaypipes: dansmith to avoid program a pre-programmed device, we need 'OR' logic in allocation candidates, I commented at line 30 | 15:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508 | 15:15 |
| efried | mriedem: ^ | 15:15 |
| *** salv-orlando has quit IRC | 15:15 | |
| *** sree has joined #openstack-nova | 15:16 | |
| *** salv-orlando has joined #openstack-nova | 15:16 | |
| mriedem | oh right i screwed up the order of the args to the test metohd | 15:17 |
| mriedem | oops | 15:17 |
| mriedem | ok i see "@efried, patch seems to be working fine with vm deploy/delete, volume attach/delete flows" in the bug | 15:18 |
| efried | mriedem: Oh, yeah, they did comment on the bug. Cool. | 15:18 |
| *** janki has quit IRC | 15:19 | |
| mriedem | +2 | 15:19 |
| *** itlinux has joined #openstack-nova | 15:19 | |
| mriedem | i know this has to go back to queens but not sure if it's also needed in pike, will have to check | 15:19 |
| *** salv-orlando has quit IRC | 15:20 | |
| openstackgerrit | Merged openstack/nova-specs master: Update 'share-pci-between-numa-nodes' spec to reflect reality https://review.openstack.org/555000 | 15:21 |
| *** sree has quit IRC | 15:21 | |
| *** vladikr has quit IRC | 15:22 | |
| *** hamzy has joined #openstack-nova | 15:22 | |
| kashyap | mriedem: I changed the exception here to a warning (locally) & fixed all the other things you pointed out; is _another_ test still required here: https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py@3875 | 15:23 |
| *** Kumar__ has joined #openstack-nova | 15:23 | |
| * kashyap goes to write a test anyway; was asking only in the context of keeping the overall change size to reasonably small.) | 15:25 | |
| efried | sdague: You seem like a likely candidate to +A https://review.openstack.org/#/c/557508/ -- got a minute for that? | 15:25 |
| *** itlinux has quit IRC | 15:26 | |
| *** imacdonn has quit IRC | 15:27 | |
| *** imacdonn has joined #openstack-nova | 15:27 | |
| *** Kumar has quit IRC | 15:27 | |
| *** tssurya has quit IRC | 15:27 | |
| mriedem | kashyap: you asked dansmith that question yesterday | 15:28 |
| mriedem | i remember the answer | 15:28 |
| kashyap | mriedem: Heh, not trying to "circumvent" anything! | 15:28 |
| kashyap | Wanted to double-confirm. Something about "assume good intent"? | 15:28 |
| bauzas | to the audience, keep in mind that if you tell to a French folk "I like you, but you're bad", there is a very strong meaning https://review.openstack.org/#/c/547990/16/nova/scheduler/client/report.py@341 | 15:29 |
| bauzas | tl;dr: the "but" litterally cancels what you just said before | 15:29 |
| mriedem | that means the same thing in english | 15:29 |
| mriedem | "i like you, but we're breaking up" | 15:30 |
| mriedem | "you're a valuable member of the team, but...." | 15:30 |
| *** alexchadin has quit IRC | 15:31 | |
| dansmith | kashyap: keeping the patch small is good, but not generally at the expense of tests | 15:31 |
| dansmith | kashyap: when in doubt, cut down the four-page release notes :) | 15:31 |
| kashyap | dansmith: Okido; I'll shut up and get that going. :-) | 15:31 |
| kashyap | dansmith: Actually, most of that info belongs in the config option help text | 15:31 |
| kashyap | dansmith: But, yes. I trimmed it | 15:31 |
| kashyap | dansmith: Wonder if you could cut some slack, English is my 3rd language, much as I love it :P | 15:32 |
| bauzas | mriedem: what's interesting is that 'but' in english can mean "except that one" | 15:32 |
| bauzas | mriedem: while we don't have that one in French | 15:32 |
| bauzas | it's another word | 15:33 |
| edleafe | alex_xu_: jaypipes: sorry, meeting time. Would love to continue our etherpad conversation, but... | 15:33 |
| bauzas | hah | 15:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix N332 api_version decorator hacking check https://review.openstack.org/557743 | 15:33 |
| efried | mriedem: ^ | 15:33 |
| bauzas | edleafe: good usage of "but" :p | 15:33 |
| kashyap | bauzas: Speaking of French and English; do you know this: "How a Mistake Gave Us the Word 'Cherry'" -- https://www.merriam-webster.com/words-at-play/cherry-history-origin | 15:33 |
| bauzas | right on time | 15:33 |
| alex_xu_ | edleafe: np, my brain doesn't work also | 15:33 |
| *** chyka has joined #openstack-nova | 15:33 | |
| *** danpawlik has joined #openstack-nova | 15:34 | |
| jaypipes | alex_xu_, edleafe: do we have something that can be standardized in os-traits that represents the things that an FPGA is *capable* of programming? For example, in vGPU land, we have the VGPU_RESOLUTION_XXX traits and VGPU_MAX_DISPLAY_HEAD traits etc. | 15:34 |
| edleafe | jaypipes: dunno - that would be a good question for the FPGA vendors | 15:34 |
| efried | bauzas: Would you mind casting your eye upon https://review.openstack.org/#/c/557508/ ? | 15:36 |
| bauzas | if that's only one eye | 15:36 |
| bauzas | I can blink | 15:36 |
| bauzas | efried: CC'd | 15:37 |
| efried | acceptable | 15:37 |
| bauzas | efried: just focusing on dansmith's series | 15:37 |
| bauzas | but then I can help | 15:37 |
| efried | thanks | 15:37 |
| mriedem | bauzas: ever word in english has at least 3 different meanings | 15:37 |
| *** itlinux has joined #openstack-nova | 15:37 | |
| mriedem | *every even | 15:37 |
| efried | holy shit, I just looked back at that etherpad. | 15:37 |
| bauzas | efried: food for thoughts too https://review.openstack.org/#/c/557065/ | 15:37 |
| bauzas | efried: since you asked me about that | 15:37 |
| efried | bauzas: ack | 15:38 |
| efried | brb... | 15:38 |
| *** sree has joined #openstack-nova | 15:38 | |
| bauzas | I'm not a big fan of a nova-manage command just for that | 15:38 |
| bauzas | if one day libvirt provides the API to set this, then we would deprecate the conf option | 15:38 |
| bauzas | while a nova-manage command for a very specific libvirt hack makes me worried by the precedence | 15:38 |
| *** danpawlik has quit IRC | 15:39 | |
| * gibi is leaving for two weeks. Back on 16th of April. | 15:42 | |
| bauzas | gibi: happy travels | 15:42 |
| *** sree has quit IRC | 15:42 | |
| cdent | happy honeymoon gibi | 15:43 |
| *** moshele has joined #openstack-nova | 15:44 | |
| *** damien_r has quit IRC | 15:44 | |
| melwitt | o/ gibi | 15:45 |
| *** moshele has quit IRC | 15:47 | |
| alex_xu_ | jaypipes: FPGA_FUNCTION_X,y,z, I guess | 15:49 |
| alex_xu_ | jaypipes: and I thought we should have a trait FPGA_DEVICE_PRE_PROGRAMMED | 15:49 |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559 | 15:49 |
| *** ragiman has quit IRC | 15:51 | |
| dansmith | mriedem: to use osc-placement do I have to tell osc to use a specific microversion? | 15:53 |
| dansmith | getting "Operation or argument is not supported with version 1.0" | 15:54 |
| *** links has joined #openstack-nova | 15:54 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Fix bad management of _TRAITS_SYNCED flag https://review.openstack.org/557722 | 15:54 |
| openstackgerrit | Merged openstack/nova stable/queens: add check before adding cpus to cpuset_reserved https://review.openstack.org/557621 | 15:55 |
| mriedem | dansmith: yup | 15:55 |
| mriedem | osc doesn't default to latest like nova cli does | 15:56 |
| dansmith | yeah I found it | 15:56 |
| jaypipes | gibi: congrats again and have a great time on your honeymoon, man :) | 15:56 |
| *** Swami has quit IRC | 15:56 | |
| * mriedem thinks of something witty to say to gibi about marriage | 15:57 | |
| mriedem | get used to always being wrong | 15:57 |
| *** voelzmo has quit IRC | 15:57 | |
| *** voelzmo has joined #openstack-nova | 15:57 | |
| *** vladikr has joined #openstack-nova | 15:58 | |
| *** belmoreira has quit IRC | 16:02 | |
| *** voelzmo has quit IRC | 16:02 | |
| *** itlinux has quit IRC | 16:03 | |
| *** yamamoto has quit IRC | 16:04 | |
| *** danpawlik has joined #openstack-nova | 16:06 | |
| *** itlinux has joined #openstack-nova | 16:06 | |
| *** yamamoto has joined #openstack-nova | 16:07 | |
| *** germs has joined #openstack-nova | 16:09 | |
| *** germs has quit IRC | 16:09 | |
| *** germs has joined #openstack-nova | 16:09 | |
| *** sambetts is now known as sambetts|afk | 16:09 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 16:10 |
| dansmith | mriedem: wanna glance at this ^ before I shut down my devstack node I used to generate the command outputs? | 16:10 |
| *** danpawlik has quit IRC | 16:10 | |
| *** Tom-Tom has quit IRC | 16:13 | |
| *** germs has quit IRC | 16:14 | |
| *** _ix has joined #openstack-nova | 16:15 | |
| *** amodi has quit IRC | 16:16 | |
| mriedem | please hold | 16:18 |
| efried | dansmith, jaypipes, edleafe, cdent, bauzas, alex_xu_: I'm caught up on the etherpad now. I think there's actually agreement on the salient points. The discussion of "capable of X" versus "flashed with X" is orthogonal. (Still relevant, still needing discussion, but the outcome doesn't affect the rest.) Good if I summarize and respond on the ML? | 16:18 |
| mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/hypervisor.html#hypervisor-list | 16:18 |
| mriedem | dansmith: let's use osc | 16:18 |
| dansmith | mriedem: it doesn't show id | 16:18 |
| mriedem | --os-compute-api-version 2.53 | 16:19 |
| dansmith | I also thought we were still recommending novaclient for admin things? | 16:19 |
| edleafe | efried: the problem was that jaypipes strongly objected to the "capable of X" traits | 16:19 |
| dansmith | also the long --foo-version things really muck up the output, just by the way | 16:19 |
| mriedem | i've got a guy here for some stuff so need to be afk for a bit | 16:19 |
| jaypipes | efried: I'm fine with you summarizing on the ML, though it does seem from the etherpad that there are still a number of things that are still not agreed on. | 16:20 |
| mriedem | you can set an env var early if you want | 16:20 |
| efried | edleafe: I'm saying that discussion is tangential | 16:20 |
| mriedem | export OS_COMPUTE_API_VERSION=2.53 | 16:20 |
| dansmith | well, that makes them less copy/pasteable in isolation | 16:20 |
| dansmith | just saying, it's annoyiung | 16:20 |
| *** links has quit IRC | 16:22 | |
| melwitt | lyarwood: can you pls remove the -W on this? https://review.openstack.org/#/c/550498/ queens change merged | 16:23 |
| lyarwood | melwitt: done | 16:23 |
| melwitt | woot thanks | 16:23 |
| *** yamamoto has quit IRC | 16:24 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 16:26 |
| dansmith | mriedem: like that ^ ? | 16:26 |
| *** yamamoto has joined #openstack-nova | 16:29 | |
| *** lucasagomes is now known as lucas-pto | 16:33 | |
| *** yamamoto has quit IRC | 16:34 | |
| *** mdbooth has quit IRC | 16:37 | |
| *** fghaas has joined #openstack-nova | 16:38 | |
| *** yangyapeng has quit IRC | 16:43 | |
| *** danpawlik has joined #openstack-nova | 16:43 | |
| efried | edleafe, jaypipes: You'll notice I neatly sidestepped the issue of "capable-of-X" vs "has-X" traits :P | 16:43 |
| *** yangyapeng has joined #openstack-nova | 16:43 | |
| *** Tom-Tom has joined #openstack-nova | 16:44 | |
| edleafe | efried: in meeting - will read soon | 16:45 |
| jaypipes | efried: still trying to get through all the reading... | 16:47 |
| jaypipes | efried: on the ML post. | 16:47 |
| *** danpawlik has quit IRC | 16:48 | |
| *** Tom-Tom has quit IRC | 16:48 | |
| dansmith | I'm not sure what to comment on at this point, maybe we need to re-summarize at the top again with the feedback and iterate? | 16:49 |
| *** gyee has joined #openstack-nova | 16:49 | |
| * dansmith runs out for a few | 16:51 | |
| *** gjayavelu has joined #openstack-nova | 16:51 | |
| *** AlexeyAbashkin has quit IRC | 16:53 | |
| *** danpawlik has joined #openstack-nova | 16:53 | |
| *** derekh has quit IRC | 16:55 | |
| *** jaosorior has quit IRC | 16:56 | |
| *** mvk has quit IRC | 16:57 | |
| *** itlinux has quit IRC | 16:57 | |
| *** yangyapeng has quit IRC | 16:58 | |
| *** danpawlik has quit IRC | 16:58 | |
| *** Kumar__ has quit IRC | 17:04 | |
| *** mdnadeem_ has joined #openstack-nova | 17:09 | |
| *** mdnadeem has quit IRC | 17:10 | |
| mriedem | dansmith: yup, thanks. comments inline | 17:10 |
| *** ttsiouts has quit IRC | 17:11 | |
| *** danpawlik has joined #openstack-nova | 17:14 | |
| *** Tom-Tom has joined #openstack-nova | 17:14 | |
| *** mdnadeem_ has quit IRC | 17:14 | |
| *** david-lyle has quit IRC | 17:15 | |
| *** cheran has joined #openstack-nova | 17:15 | |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| efried | dansmith: If you're talking about the etherpad, I summarized on the ML already. | 17:17 |
| *** salv-orlando has joined #openstack-nova | 17:18 | |
| *** Tom-Tom has quit IRC | 17:18 | |
| *** ralonsoh has quit IRC | 17:19 | |
| melwitt | nice job on those, good stuff | 17:19 |
| *** danpawlik has quit IRC | 17:19 | |
| *** abhishekk has joined #openstack-nova | 17:20 | |
| *** trozet_ has quit IRC | 17:20 | |
| *** kiwi_46 has joined #openstack-nova | 17:21 | |
| *** salv-orlando has quit IRC | 17:22 | |
| *** armaan has joined #openstack-nova | 17:24 | |
| *** mdnadeem_ has joined #openstack-nova | 17:26 | |
| *** Tom-Tom has joined #openstack-nova | 17:27 | |
| *** fragatina has joined #openstack-nova | 17:28 | |
| jmlowe_ | I'm hunting down kind of a strange problem, the initial symptom is that the addFixedIp server action returns 202 but the fixed ip is never really added, I go digging and I find "Network could not be found for instance" in the logs of the compute node, further digging reveals that the device_owner of the port is compute:zone-r7 and it is filtered because the availability zone of the instance is zone-r2 leaving an empty list | 17:30 |
| jmlowe_ | of ports and a no network found error | 17:30 |
| *** felipemonteiro__ has joined #openstack-nova | 17:30 | |
| *** yamamoto has joined #openstack-nova | 17:30 | |
| *** Tom-Tom has quit IRC | 17:32 | |
| jmlowe_ | I'm left with 3 questions, why isn't the port device_owner updated during unshelve, why does the port have to match the AZ of the instance and not just the instance and network id, are there any open bugs for this because this is nearly impossible to search for | 17:32 |
| *** sahid has quit IRC | 17:33 | |
| efried | jmlowe_: The only part of that I can address is the 202, which means "I understand your request; now I'm going to go away and process it asynchronously." So it's not a bug that you got 202 but the thingy ultimately failed. | 17:34 |
| *** felipemonteiro_ has quit IRC | 17:34 | |
| jmlowe_ | That's what I figured, in a perfect world the application would move on to higher microversions and interact with neutron | 17:35 |
| *** amodi has joined #openstack-nova | 17:37 | |
| *** yamamoto has quit IRC | 17:37 | |
| jmlowe_ | The quick and dirty patch would be to eliminate device owner as a search opt leaving device_id and network_id, but I don't understand the logic of having it so I may be missing some subtlety about why it's there | 17:37 |
| jmlowe_ | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1459 | 17:39 |
| mriedem | jmlowe_: it's likely an old ass bug in shelve where the device_owner isn't cleared | 17:40 |
| jmlowe_ | Yea! | 17:40 |
| mriedem | when you unshelve, the instance is re-created on a new compute node | 17:40 |
| mriedem | which could be in some other AZ | 17:40 |
| *** chyka_ has joined #openstack-nova | 17:41 | |
| *** mdnadeem_ has quit IRC | 17:41 | |
| jmlowe_ | correct, I believe that's what I'm seeing, I haven't followed the code to find the place where it should be updating | 17:41 |
| melwitt | jmlowe_: congrats, you got shelved | 17:41 |
| mriedem | heh | 17:41 |
| mriedem | shelving at the speed of business | 17:42 |
| *** kiwi_46 has quit IRC | 17:42 | |
| *** armaan has quit IRC | 17:42 | |
| fghaas | Hi everyone. I have a question about enabling nested KVM, or for that matter passing in any required CPU features to an instance, in combination with using a "custom" cpu-mode. My compute nodes (Ocata) are configured to run with cpu_mode=custom, cpu_model=IvyBridge. They are also configured for nested KVM per the kvm_intel nested=Y module parameter. virsh capabilities on any compute node correctly yields <feature name='vmx'/> for the host CPU. | 17:42 |
| fghaas | Now, when I schedule an instance to that compute node, it ends up with a CPU configuration as shown in http://paste.openstack.org/show/717923/, which means it is not capable of doing any nested KVM. If I then log onto the compute node, and hack the libvirt domain config with virsh edit, and I fix up the CPU configuration to match http://paste.openstack.org/show/717934/, then I can virsh shutdown/virsh start the domain and when it comes back up, voil | 17:42 |
| fghaas | So my question is, do I have any way to inject that <feature policy='require' name='vmx'/> bit into an instance from Nova? Way-back around the Essex release we had a libvirt.xml.template (https://blog.dachary.org/2012/09/26/openstack-nested-virtual-machines/), but that was dropped somewhere along the way — is there a contemporary way to do this? | 17:42 |
| jmlowe_ | It's a cloud for researchers, so there's a lot of "wait I need that" 6 months later | 17:42 |
| *** armaan has joined #openstack-nova | 17:43 | |
| mriedem | jmlowe_: there is no network deallocation on the compute that happens during shelve offload because the point of shelve is that the ports and volumes are still attached to the instance so they can be re-attached on unshelve, | 17:43 |
| mriedem | jmlowe_: but chances are, https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4837 is the place we'd want to clear the device_owner on any ports attached to the instance during shelve offload | 17:43 |
| *** chyka has quit IRC | 17:43 | |
| jmlowe_ | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L2584 | 17:44 |
| mriedem | cleanup_instance_network_on_host today is a no-op for neutron in nova | 17:44 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L2517 | 17:44 |
| melwitt | fghaas: cfriesen might be the person to ask about that | 17:44 |
| jmlowe_ | I was really hoping somebody just forgot to slip in a _update_port_binding_for_instance call | 17:45 |
| *** germs has joined #openstack-nova | 17:45 | |
| *** germs has quit IRC | 17:45 | |
| *** germs has joined #openstack-nova | 17:45 | |
| mriedem | you're looking at the wrong method | 17:45 |
| mriedem | the binding stuff is called from setup_instance_network_on_host | 17:45 |
| *** germs has quit IRC | 17:45 | |
| *** danpawlik has joined #openstack-nova | 17:46 | |
| mriedem | setup is called on unshelve | 17:46 |
| mriedem | b/c you're on a new host | 17:46 |
| *** germs has joined #openstack-nova | 17:46 | |
| *** germs has quit IRC | 17:46 | |
| *** germs has joined #openstack-nova | 17:46 | |
| mriedem | cleanup is called from shelve offload b/c you're leaving that host | 17:46 |
| mriedem | jmlowe_: so likely all we need to do is in https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L2517, get the ports for the instance, and clear their device_owner | 17:46 |
| mriedem | since that's tied to the az which is tied to the host | 17:47 |
| fghaas | melwitt: thanks, I'll keep my eyes peeled for cfriesen's thoughts then :) | 17:47 |
| mriedem | jmlowe_: what i'm not sure about, is if that will screw with neutron if the device_owner is null but the binding:host_id is still set | 17:47 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L515 | 17:47 |
| mriedem | we basically want ^ but we want to retain the port.device_id | 17:48 |
| cdent | mriedem: why is it when you find and fix a race that race starts showing up all over the damn place (when it wasn't beore)? | 17:48 |
| mriedem | because software is terrible | 17:49 |
| mriedem | why doesn't shelve work after 7 years? | 17:49 |
| mriedem | jmlowe_: report a bug and we can go from there | 17:49 |
| jmlowe_ | ok, will do | 17:50 |
| mriedem | jmlowe_: as noted, the other solution is changing _update_port_binding_for_instance to update the device_owner when the host binding changes | 17:51 |
| mriedem | couple ways to skin this cat | 17:51 |
| *** danpawlik has quit IRC | 17:51 | |
| *** r-daneel_ has joined #openstack-nova | 17:51 | |
| mriedem | jmlowe_: kind of need to know if the instance.availability_zone also changed when you unshelved it | 17:52 |
| mriedem | looks like it must have? | 17:52 |
| jmlowe_ | it did | 17:52 |
| *** r-daneel has quit IRC | 17:52 | |
| *** r-daneel_ is now known as r-daneel | 17:52 | |
| mriedem | ok yeah, then _update_port_binding_for_instance is probably all we need to update | 17:52 |
| mriedem | which is called on unshelve | 17:52 |
| jmlowe_ | I really don't care what it used to be, I need to be damn sure on startup it overwrites whatever the value is null, old, whatever with what nova now knows to be true | 17:53 |
| mriedem | yup | 17:54 |
| * cdent hopes jmlowe_ is going to vancouver | 17:54 | |
| mriedem | my point being, i don't think we need to also worry about cleanup_instance_network_on_host | 17:54 |
| mriedem | i'm asking in -neutron if we should/could unbind the port while the instance is shelved but leave it attached | 17:55 |
| mriedem | since that seems like sane book keeping | 17:55 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration https://review.openstack.org/552722 | 17:55 |
| jmlowe_ | I am, will try to resist the inevitable air rage as I walk past Jeremy in his first class seats | 17:55 |
| artom | jaypipes ^^ since you were so close, I feel comfortable bugging you on IRC ;) | 17:56 |
| *** Tom-Tom has joined #openstack-nova | 17:56 | |
| jaypipes | artom: absolutely. lemme re-review right quick. | 17:56 |
| *** itlinux has joined #openstack-nova | 17:56 | |
| jaypipes | artom: yikes. whitespace! :P | 17:56 |
| *** r-daneel has quit IRC | 17:56 | |
| artom | Eh? | 17:56 |
| artom | Did failing to run pep8 in my impatience come back to bite me? | 17:57 |
| mriedem | https://review.openstack.org/#/c/552722/10/specs/rocky/approved/numa-aware-live-migration.rst@173 | 17:57 |
| *** r-daneel has joined #openstack-nova | 17:57 | |
| jaypipes | artom: hold up on pushing again.. I have other comments | 17:57 |
| cdent | jmlowe_: that jeremy fellow should be regularly shunned | 17:57 |
| * artom squints at the little red square | 17:57 | |
| artom | An evil squit, to be clear | 17:57 |
| mriedem | artom: feel free to bug me about that spec (later) since i want to check the mechanics on the conductor / mixed compute version negotiation stuff | 17:57 |
| artom | mriedem, sure, thanks :) Do you mean the implementation though? The spec doesn't really spell it out, other than "the conductor is going to do it" | 17:58 |
| dansmith | efried: ...oh | 17:58 |
| * fungi expects it's a different jeremy, since he clies steerage | 17:58 | |
| fungi | er, flies | 17:58 |
| jmlowe_ | whack the underside of his tray to send his early drink flying | 17:59 |
| mriedem | artom: i'll see | 17:59 |
| dansmith | oh in the thread, that's why I didn't see it | 17:59 |
| *** yangyapeng has joined #openstack-nova | 17:59 | |
| *** Tom-Tom has quit IRC | 18:00 | |
| jaypipes | artom: k, reviewd. | 18:00 |
| *** sapd has quit IRC | 18:01 | |
| *** harlowja has joined #openstack-nova | 18:01 | |
| cfriesen | dansmith: do we currently have a mechanism to purge entries from the nova_cell0 db? | 18:02 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration https://review.openstack.org/552722 | 18:03 |
| *** suresh12 has joined #openstack-nova | 18:03 | |
| cdent | fungi: jmlowe_ works with one of my oldest friends, who happens to travel a lot, and thus is not in the cheap seats | 18:03 |
| artom | jaypipes, thank you! And right back to you :D | 18:03 |
| *** yangyapeng has quit IRC | 18:04 | |
| mriedem | cfriesen: yes | 18:05 |
| dansmith | cfriesen: yes, nova-manage db purge --all-cells, or without that and pointing at something with just cell0 configured | 18:05 |
| dansmith | s/something/a config/ | 18:05 |
| *** david-lyle has joined #openstack-nova | 18:05 | |
| mriedem | https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-database | 18:05 |
| mriedem | you have to archive first | 18:05 |
| openstackgerrit | Merged openstack/nova master: Fix issue for pep8 on py3 https://review.openstack.org/557633 | 18:05 |
| cfriesen | mriedem: thx | 18:05 |
| mriedem | cfriesen: note that purge CLI is new in rocky | 18:06 |
| mriedem | wonder if we should have a 'since' tag on our CLI docs | 18:07 |
| fungi | cdent: i figured. i tend not to even track airline miles because it depresses me to think about how much i travel (and i don't even travel that much compared to a lot of people in this community) | 18:08 |
| *** moshele has joined #openstack-nova | 18:08 | |
| openstackgerrit | Merged openstack/nova master: VMware: add log message for VIF info details https://review.openstack.org/557256 | 18:10 |
| openstackgerrit | Merged openstack/nova master: Start untangling network utilities. https://review.openstack.org/557542 | 18:10 |
| openstackgerrit | Merged openstack/nova master: Move two more generic network utilities to a move obvious place. https://review.openstack.org/557543 | 18:10 |
| *** moshele has quit IRC | 18:13 | |
| openstackgerrit | Merged openstack/nova master: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557377 | 18:13 |
| kashyap | dansmith: When you get a moment, unit test question: this "works", but can you tell if that deceptively "simple" 'mock_warn' is correct: http://paste.openstack.org/show/717935/ | 18:15 |
| kashyap | (Catching this warning: https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py@3871) | 18:16 |
| *** danpawlik has joined #openstack-nova | 18:17 | |
| jaypipes | artom: back at ya ;) | 18:17 |
| dansmith | mriedem: yawna nak my version argument in the doc so I can update or not and resubmit | 18:17 |
| dansmith | / | 18:17 |
| dansmith | / | 18:17 |
| *** salv-orlando has joined #openstack-nova | 18:18 | |
| dansmith | kashyap: that works and is done elsewhere, but I also don't care that you assert that the warn was called, but that you executed that code. If you had a typo in anything inside that if, you wouldn't hit it in your tests unless you cause the if to be true, which is the real goal | 18:18 |
| *** AlexeyAbashkin has joined #openstack-nova | 18:18 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration https://review.openstack.org/552722 | 18:19 |
| kashyap | dansmith: Yep; the typo inside the 'if' is taken care by the config "choices", right | 18:19 |
| dansmith | kashyap: no | 18:19 |
| kashyap | That's why we moved it there | 18:19 |
| dansmith | no | 18:19 |
| kashyap | Err, I mean, let me rephrase | 18:20 |
| dansmith | if condition: LOG.warrrrrning('foo') | 18:20 |
| dansmith | that would not fail tests unless you cause condition to be true | 18:20 |
| jaypipes | artom: aaaaannndddd... +2. :) | 18:20 |
| artom | jaypipes, yey! Thank you | 18:20 |
| dansmith | kashyap: no failure: https://pastebin.com/A2muKWxU | 18:21 |
| * kashyap clicks | 18:21 | |
| mriedem | dansmith: is that "you want to" or "you going to"? | 18:21 |
| artom | I was worried we'd "hit" an asymptote and never get there ;) | 18:21 |
| mriedem | i can't parse that southern drawl | 18:21 |
| kashyap | dansmith: Okido; noted. | 18:21 |
| dansmith | mriedem: you want to, although I assume you're going to | 18:21 |
| *** Tom-Tom has joined #openstack-nova | 18:22 | |
| mriedem | dansmith: i already -1ed for the other stuff | 18:22 |
| mriedem | oh you replied | 18:22 |
| mriedem | sec | 18:22 |
| *** danpawlik has quit IRC | 18:22 | |
| *** salv-orlando has quit IRC | 18:23 | |
| *** AlexeyAbashkin has quit IRC | 18:23 | |
| *** voelzmo has joined #openstack-nova | 18:24 | |
| kashyap | dansmith: Alright; to make you double-happy, I'll slap in another test for the 'host-passthrough'. As we have two conditions there | 18:24 |
| dansmith | kashyap: if it's not related to your change, then save it for another patch | 18:24 |
| dansmith | kashyap: but yes as I noted, we don't have tests for the other conditions there | 18:25 |
| kashyap | dansmith: It's actually related, because: | 18:25 |
| mriedem | dansmith: replied in the docs patch | 18:25 |
| dansmith | mriedem: tanks | 18:25 |
| *** voelzmo_ has joined #openstack-nova | 18:25 | |
| mriedem | that's also why i called out my specific points for the -1 | 18:25 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 18:25 |
| mriedem | since the other was just discussion | 18:25 |
| kashyap | dansmith: I wasn't sure if you wanted to me to test for *both* 'host-model' + 'host-passthrough' in this conditional: | 18:25 |
| mriedem | coffee talk | 18:25 |
| kashyap | + elif ((mode == "host-model" or mode == "host-passthrough" or | 18:25 |
| kashyap | + model is None) and extra_flags): | 18:26 |
| dansmith | mriedem: heh | 18:26 |
| kashyap | dansmith: The second test would just identical, with the difference being: s/host-mode/host-passthrough/ | 18:26 |
| dansmith | kashyap: oh I see, I mostly care that the condition is true (there's only one condition) so you run the stuff in the body of the if.. that's all | 18:26 |
| *** abhishekk has quit IRC | 18:26 | |
| kashyap | Okido; I'll stick with one test | 18:26 |
| *** Tom-Tom has quit IRC | 18:26 | |
| kashyap | And I get to write more tests when we lift the choices in future. | 18:26 |
| dansmith | kashyap: it doesn't matter that you check that == works a second time, we can trust python on that :) | 18:26 |
| kashyap | LOL | 18:26 |
| dansmith | kashyap: although mriedem is a stickler, he might want both flags checked, so it's not wrong to do both | 18:27 |
| kashyap | One more: a preference question -- do you care betwee assertTrue vs assert_called_with | 18:27 |
| dansmith | assertTrue only for booleans | 18:27 |
| kashyap | I apprecite his stickliness (is it a word?). Because he did caught somethings I didn't like in my phrasing | 18:27 |
| kashyap | And I was getting sick of reading my own text again and again | 18:27 |
| dansmith | assertTrue(foo.called) is okay with me for LOG.warning just to make sure it was called, | 18:27 |
| dansmith | but mriedem tends to do a looooot of string compare assertions that I do not | 18:28 |
| dansmith | so he would do assert_called_with | 18:28 |
| * kashyap nods; thanks for the (non-null) pointers. | 18:28 | |
| *** voelzmo has quit IRC | 18:28 | |
| * kashyap will just put in test for both the modes, as it's "more correct" | 18:30 | |
| mriedem | assertTrue(foo.called) is so 2015 | 18:30 |
| mriedem | foo.assert_called() | 18:30 |
| mriedem | foo.assert_not_called() | 18:30 |
| mriedem | just because i commented on the release note, does that mean you expect me to go back and re-review this all again?! | 18:31 |
| *** tesseract has quit IRC | 18:31 | |
| kashyap | mriedem: No. I'll actually nicely summarize in the main comment as to what all I addressed. | 18:31 |
| mriedem | that can't be trusted | 18:31 |
| kashyap | LOL | 18:32 |
| kashyap | E.g. | 18:32 |
| kashyap | PS21: | 18:32 |
| kashyap | - Undid the whitespace change in driver.py | 18:32 |
| kashyap | - Changed the 'exception' to a LOG.warning in driver.py | 18:32 |
| kashyap | - Added an additional test in test_driver.py | 18:32 |
| kashyap | - Clarify the release note that we're talking about libvirt where appropriate | 18:32 |
| kashyap | - Remove the confusing comment about a future change & instead update the 'conf' file | 18:32 |
| kashyap | [...] | 18:32 |
| mriedem | omg | 18:32 |
| kashyap | Of course you should review, and not trust me | 18:32 |
| mriedem | you know you can diff patch sets in gerrit right? | 18:32 |
| *** rmcall has joined #openstack-nova | 18:32 | |
| kashyap | I know; just kidding | 18:32 |
| mriedem | i'm not sure you are, | 18:32 |
| mriedem | you're used to the ML style reviews in qemu | 18:32 |
| kashyap | mriedem: Damn | 18:32 |
| kashyap | You caught me | 18:32 |
| *** yamamoto has joined #openstack-nova | 18:33 | |
| kashyap | As you caught me, that's indeed a thing in ML land; that goes under the three dashes below a patch (---): which *won't* go into Git commit, obviously | 18:34 |
| kashyap | s/below a patch/below the main commit message/ | 18:34 |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 18:35 |
| melwitt | stephenfin: I've been meaning to ask you if you could take a look at this https://bugs.launchpad.net/nova/+bug/1750672 it's a failure to be able to generate nova docs under py3. something to do with sphinx and we couldn't tell if it's a blockdiag bug or if it's something we need to fix on our side | 18:35 |
| openstack | Launchpad bug 1750672 in OpenStack Compute (nova) "failure to generate Nova's doc in Python 3.6" [Medium,Confirmed] | 18:35 |
| mriedem | dansmith: now that looks pretty http://logs.openstack.org/90/557490/8/check/build-openstack-sphinx-docs/413d6d9/html/admin/configuration/schedulers.html#aggregates-in-placement | 18:36 |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Document Rocky review priorities https://review.openstack.org/557796 | 18:36 |
| dansmith | mriedem: hell to the yeah | 18:37 |
| *** yamamoto has quit IRC | 18:38 | |
| dansmith | fwiw, | 18:39 |
| *** Tom-Tom has joined #openstack-nova | 18:40 | |
| dansmith | runways are doing a good job of keeping me jumpin' | 18:40 |
| melwitt | like, jumpin' for joy? | 18:40 |
| dansmith | like jumpin' busy responding to all the feedback firehose | 18:40 |
| *** priteau has quit IRC | 18:40 | |
| melwitt | ah yeah | 18:40 |
| jmlowe_ | mriedem: looks like _update_ports_for_instance does update device_owner while _update_port_binding_for_instance doesn't | 18:41 |
| jmlowe_ | no chance of confusion there! | 18:41 |
| *** avolkov has quit IRC | 18:43 | |
| mriedem | jmlowe_: get familiar enough with the nova.network.neutronv2.api.API code, and you'll find there are at least 3 similarly named methods for about every operation that all do slightly different things and are all called in tightly-coupled ways from different places in nova | 18:43 |
| *** gouthamr has joined #openstack-nova | 18:43 | |
| mriedem | it's, great | 18:43 |
| *** esberglu has quit IRC | 18:43 | |
| *** Tom-Tom has quit IRC | 18:44 | |
| mriedem | see the amount of talking-to-myself i've done in https://review.openstack.org/#/c/551371/ | 18:44 |
| jmlowe_ | bug 1759924 is away | 18:46 |
| openstack | bug 1759924 in OpenStack Compute (nova) "Port device owner isn't updated with new host availability zone during unshelve" [Undecided,New] https://launchpad.net/bugs/1759924 | 18:46 |
| mriedem | thanks | 18:46 |
| jmlowe_ | I need about 6 more cups of coffee before I can muster the strength to propose a half assed copy and paste patch | 18:48 |
| jmlowe_ | very tempted to just do the one line search opts fix because why do it the right way when you can do it with sed | 18:49 |
| kashyap | mriedem: That's nice, "consciousness stream" writing on the review. (If only there's an easier for people to "discover" easily all the sluething you've done.) | 18:50 |
| kashyap | (Barring you having to mention here on IRC, live.) | 18:50 |
| openstackgerrit | Merged openstack/nova stable/pike: Save admin password to sysmeta in libvirt driver https://review.openstack.org/550498 | 18:50 |
| openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1746509 https://review.openstack.org/555058 | 18:50 |
| openstack | bug 1746509 in OpenStack Compute (nova) pike "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [High,In progress] https://launchpad.net/bugs/1746509 - Assigned to melanie witt (melwitt) | 18:50 |
| openstackgerrit | Merged openstack/nova stable/pike: Move _make_instance_list call outside of DB transaction context https://review.openstack.org/555923 | 18:50 |
| melwitt | yaaaay | 18:50 |
| mriedem | jmlowe_: i left notes in the bug, i think it's a one line fix | 18:53 |
| *** claudiub has quit IRC | 18:53 | |
| *** danpawlik has joined #openstack-nova | 18:53 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 18:55 |
| mriedem | cfriesen: you might enjoy https://bugs.launchpad.net/nova/+bug/1759924/comments/2 | 18:56 |
| openstack | Launchpad bug 1759924 in OpenStack Compute (nova) "Port device owner isn't updated with new host availability zone during unshelve" [Medium,Triaged] | 18:56 |
| mriedem | when we shelve, we don't cleanup any pci stuff | 18:56 |
| cfriesen | mriedem: for certain values of "enjoy" | 18:58 |
| cfriesen | can't we just drop shelve yet? | 18:58 |
| *** voelzmo_ has quit IRC | 18:59 | |
| *** danpawlik has quit IRC | 18:59 | |
| melwitt | cfriesen: I dunno if you saw I invoked your name earlier when fghaas was asking about nested virt and cpu policy 'require' stuff | 18:59 |
| cfriesen | melwitt: whoops, missed it. | 19:00 |
| mriedem | cfriesen requires at least one goat sacrifice if you invoke his name | 19:00 |
| fghaas | you're being awesome melwitt :) But I figured everyone including cfriesen was rightfully busy so I posted this to the mailing list (http://lists.openstack.org/pipermail/openstack/2018-March/046313.html) — but I'll be happy to follow up with a writeup from whatever we discuss here! | 19:00 |
| melwitt | a-ha, cool | 19:01 |
| cfriesen | fghaas: the Intel CPU models in libvirt/qemu generally do not include the "vmx" flag, as you have discovered. The functionality that you're looking for is exposed in kashyap's feature ("https://review.openstack.org/#/c/534384/ ") which is currently under review. | 19:03 |
| *** salv-orlando has joined #openstack-nova | 19:03 | |
| kashyap | fghaas: Hi :-) | 19:03 |
| melwitt | I wondered if kashyap's patch would be the answer. noyce | 19:04 |
| * kashyap reads the scroll a bit | 19:04 | |
| cfriesen | fghaas: note that I've experienced instability with nested kvm, but kashyap says it's good with more recent kernel/qemu/libvirt | 19:04 |
| *** voelzmo has joined #openstack-nova | 19:05 | |
| kashyap | Yes; cfriesen -- let's not repeat "unstability" without data :-). I recall participating in an email thread w/ fghaas on KVM list about :-) | 19:05 |
| kashyap | cfriesen: BTW -- Paolo (one of the KVM maintainers) said he's going the toggle the 'nested' flag to default for Intel in the upstream kernel "soon" | 19:05 |
| kashyap | (It's on for AMD in the upstream kernel; but amusingly enough ... AMD is more instable w/ 'nested' than Intel!) | 19:06 |
| cfriesen | kashyap: isn't it on for the AMD cpu models too? | 19:06 |
| kashyap | cfriesen: See my previous comment. It *is* on for AMD. But not for Intel. At this moment. | 19:07 |
| cfriesen | kashyap: I meant in libvirt/qemu, not kernel | 19:07 |
| *** AlexeyAbashkin has joined #openstack-nova | 19:08 | |
| kashyap | cfriesen: What do you mean? There's no such thing as "enabling nested in libvirt / QEMU". As you know, you can configure Kernel, then tell libvirt, which inturn tells QEMU to use it. | 19:09 |
| *** Tom-Tom has joined #openstack-nova | 19:09 | |
| * kashyap bbiab | 19:10 | |
| cfriesen | kashyap: I meant that the "svm" flag is included in the AMD cpu models | 19:10 |
| kashyap | cfriesen: Ah, that's true. | 19:11 |
| kashyap | It's late here, /me is losing ability to parse text messages | 19:12 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: tests for alloc candidates with nested and traits https://review.openstack.org/531899 | 19:12 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: resource requests for nested providers https://review.openstack.org/554529 | 19:12 |
| *** suresh12 has quit IRC | 19:12 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559 | 19:13 |
| *** AlexeyAbashkin has quit IRC | 19:13 | |
| *** Tom-Tom has quit IRC | 19:14 | |
| *** r-daneel_ has joined #openstack-nova | 19:14 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 19:14 |
| *** suresh12 has joined #openstack-nova | 19:15 | |
| *** r-daneel has quit IRC | 19:16 | |
| *** r-daneel_ is now known as r-daneel | 19:16 | |
| *** moshele has joined #openstack-nova | 19:17 | |
| *** Tom-Tom has joined #openstack-nova | 19:20 | |
| fghaas | cfriesen, yes kashyap and I discussed the pros and cons at length recently, but this is really a generic question about cpu feature flags | 19:21 |
| *** voelzmo has quit IRC | 19:21 | |
| fghaas | not so much passing in the "vmx" flag specifically | 19:21 |
| *** bkopilov has quit IRC | 19:21 | |
| fghaas | but yeah that patch looks excellent :) | 19:22 |
| *** moshele has quit IRC | 19:23 | |
| melwitt | yeah, feature is being added this cycle https://blueprints.launchpad.net/nova/+spec/libvirt-cpu-model-extra-flags but the backports are going to be restricted to only the 'pcid' flag to address the meltdown/spectre perf mitigation. we weren't intending to backport a brand new feature in a free-form way | 19:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Migrate old style volume attachments on nova-compute startup https://review.openstack.org/549130 | 19:24 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move get_stashed_volume_connector to compute.utils https://review.openstack.org/557810 | 19:24 |
| *** cdent has quit IRC | 19:24 | |
| *** Tom-Tom has quit IRC | 19:25 | |
| melwitt | (to not add unknown instability to branches that are supposed to be considered quite stable) | 19:25 |
| *** weshay is now known as weshay_brb | 19:30 | |
| *** weshay_brb is now known as weshay | 19:31 | |
| *** READ10 has quit IRC | 19:32 | |
| *** danpawlik has joined #openstack-nova | 19:33 | |
| *** suresh12 has quit IRC | 19:33 | |
| *** salv-orlando has quit IRC | 19:34 | |
| *** salv-orlando has joined #openstack-nova | 19:35 | |
| *** yamamoto has joined #openstack-nova | 19:35 | |
| *** danpawlik has quit IRC | 19:38 | |
| *** salv-orlando has quit IRC | 19:39 | |
| *** yamamoto has quit IRC | 19:40 | |
| *** Tom-Tom has joined #openstack-nova | 19:41 | |
| mriedem | wolfenstein | 19:43 |
| mriedem | comin' for ya | 19:43 |
| *** salv-orlando has joined #openstack-nova | 19:43 | |
| *** gouthamr has quit IRC | 19:44 | |
| *** eharney has quit IRC | 19:45 | |
| *** Tom-Tom has quit IRC | 19:45 | |
| *** Tom-Tom has joined #openstack-nova | 19:50 | |
| *** suresh12 has joined #openstack-nova | 19:51 | |
| *** mvk has joined #openstack-nova | 19:53 | |
| *** Tom-Tom has quit IRC | 19:55 | |
| openstackgerrit | Merged openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 19:57 |
| openstackgerrit | Merged openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 20:07 |
| openstackgerrit | Merged openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 20:07 |
| openstackgerrit | Merged openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | 20:07 |
| *** danpawlik has joined #openstack-nova | 20:12 | |
| *** liverpooler has quit IRC | 20:16 | |
| *** danpawlik has quit IRC | 20:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541 | 20:20 |
| *** suresh12 has quit IRC | 20:21 | |
| *** artom has quit IRC | 20:22 | |
| *** Tom-Tom has joined #openstack-nova | 20:23 | |
| openstackgerrit | Merged openstack/nova stable/queens: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557727 | 20:24 |
| fghaas | melwitt: bummer, I'd love to see a backport for both pcid and vmx, but I realize I'm the nutcase here (as kashyap can attest, I'm sure) :) | 20:26 |
| *** Tom-Tom has quit IRC | 20:27 | |
| melwitt | fghaas: from what I understand, it's not too risky but we really don't ever backport full-fledged features to stable branches. stable is reserved for bug fixes. the reason we're making an exception and backporting the necessary bits for meltdown/spectre situation is because it would make a significant difference in reducing the performance degradation | 20:30 |
| fghaas | Sure, I do follow that reasoning. | 20:31 |
| *** hemna_ has joined #openstack-nova | 20:31 | |
| cfriesen | fghaas: if you want to experiment, you can locally remove the couple lines of code in the backport limiting it to "pcid" and restart nova-compute. But if it causes problems, it's officially unsupported. | 20:35 |
| fghaas | Entirely understood. But great to know that this will be an easy stop to pull, figuratively speaking | 20:37 |
| *** yamamoto has joined #openstack-nova | 20:37 | |
| melwitt | true that | 20:37 |
| *** yamamoto has quit IRC | 20:42 | |
| fghaas | ok, thanks everyone (particularly melwitt, cfriesen and kashyap), that's been extremely helpful information! | 20:44 |
| melwitt | np | 20:45 |
| *** suresh12 has joined #openstack-nova | 20:46 | |
| *** edmondsw has quit IRC | 20:47 | |
| *** edmondsw has joined #openstack-nova | 20:47 | |
| *** danpawlik has joined #openstack-nova | 20:48 | |
| efried | melwitt: Feel like pushing https://review.openstack.org/#/c/557508/ ? "Customer" is buggin me :) | 20:48 |
| efried | jaypipes: Easy reviews in the upt bp (but outside the series so you mighta missed 'em): https://review.openstack.org/#/c/553475/ and (less critical) https://review.openstack.org/#/c/553476/ | 20:50 |
| melwitt | it has been tab'd | 20:50 |
| efried | melwitt: Thanks! | 20:50 |
| melwitt | nova meeting in 10 minutes | 20:50 |
| *** hamzy has quit IRC | 20:50 | |
| *** tssurya has joined #openstack-nova | 20:51 | |
| *** suresh12 has quit IRC | 20:51 | |
| *** takashin has joined #openstack-nova | 20:52 | |
| *** edmondsw has quit IRC | 20:52 | |
| *** danpawlik has quit IRC | 20:53 | |
| *** pchavva has joined #openstack-nova | 20:55 | |
| *** esberglu has joined #openstack-nova | 20:55 | |
| *** esberglu has quit IRC | 21:00 | |
| melwitt | gdi my irc client is freaking out. sorry | 21:01 |
| *** burt has quit IRC | 21:02 | |
| *** Guest84540 has quit IRC | 21:07 | |
| *** pchavva has quit IRC | 21:08 | |
| *** awaugama has quit IRC | 21:11 | |
| *** rmcall has quit IRC | 21:12 | |
| fghaas | whoa melwitt you beat me to the ML writeup — thanks again! | 21:14 |
| *** esberglu has joined #openstack-nova | 21:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: add check before adding cpus to cpuset_reserved https://review.openstack.org/557622 | 21:18 |
| *** danpawlik has joined #openstack-nova | 21:19 | |
| *** suresh12 has joined #openstack-nova | 21:19 | |
| *** esberglu has quit IRC | 21:22 | |
| *** esberglu has joined #openstack-nova | 21:23 | |
| *** danpawlik has quit IRC | 21:23 | |
| *** suresh12 has quit IRC | 21:24 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 21:27 |
| *** esberglu has quit IRC | 21:28 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506 | 21:30 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module. https://review.openstack.org/557552 | 21:31 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move create_tap_dev to the new utility method. https://review.openstack.org/557835 | 21:31 |
| *** elmaciej has joined #openstack-nova | 21:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506 | 21:35 |
| *** suresh12 has joined #openstack-nova | 21:36 | |
| *** takashin has left #openstack-nova | 21:37 | |
| *** felipemonteiro__ has quit IRC | 21:37 | |
| *** yamamoto has joined #openstack-nova | 21:38 | |
| *** yamahata has joined #openstack-nova | 21:38 | |
| *** suresh12 has quit IRC | 21:42 | |
| *** yamamoto has quit IRC | 21:44 | |
| *** amodi has quit IRC | 21:48 | |
| *** archit has joined #openstack-nova | 21:48 | |
| *** archit is now known as amodi | 21:48 | |
| *** suresh12 has joined #openstack-nova | 21:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541 | 21:53 |
| *** fanzhang has quit IRC | 21:54 | |
| *** fanzhang has joined #openstack-nova | 21:54 | |
| openstackgerrit | Eric Fried proposed openstack/nova stable/queens: Use ksa session for cinder microversion check https://review.openstack.org/557837 | 21:55 |
| *** tssurya has quit IRC | 21:55 | |
| efried | mriedem, melwitt: queens cherry-pick ^ | 21:55 |
| efried | Thanks for the prompt reviews, y'all. | 21:55 |
| *** danpawlik has joined #openstack-nova | 21:56 | |
| melwitt | lol, I was about to say, that's a lightning fast backport proposal | 21:56 |
| efried | melwitt: I cheated a teeny bit | 21:57 |
| efried | but I have pressure | 21:57 |
| *** suresh12 has quit IRC | 21:57 | |
| *** itlinux has quit IRC | 21:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550555 | 21:59 |
| edleafe | efried: just for you: https://www.youtube.com/watch?v=nxxSIX3fmmo | 22:00 |
| *** danpawlik has quit IRC | 22:00 | |
| mriedem | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+label:Code-Review=2 is happy, but needs a non-tony person | 22:00 |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 22:01 |
| melwitt | cool, will find someone to bug for the rest. thanks | 22:02 |
| *** suresh12 has joined #openstack-nova | 22:04 | |
| mriedem | efried: looking at the history of that microversion check, it was added in pike, and it's used if we actually created attachments in pike, but we don't | 22:08 |
| mriedem | so don't think we need to fix anything in pike there | 22:08 |
| efried | mriedem: Okay, cool. Thanks for tracking that down. | 22:09 |
| efried | mriedem: Wait, is that just the one in the attach flow? Cause we also do the microversion check when we're just creating the client from nothing. | 22:09 |
| *** suresh12 has quit IRC | 22:09 | |
| mriedem | is_microversion_supported isn't in pike | 22:10 |
| efried | mriedem: But does the cinderclient() method have the _check_microversion call? | 22:10 |
| mriedem | https://review.openstack.org/#/c/469579/3/nova/volume/cinder.py doesn't do anything unless the microversion arg is passed in | 22:10 |
| mriedem | and the only things that pass that in, attachment create/update/delete, | 22:10 |
| mriedem | aren't going to get used in pike | 22:10 |
| mriedem | b/c we don't attach volumes the new way until queens | 22:11 |
| mriedem | so there is some plumbing in pike but it's not used | 22:11 |
| efried | mriedem: So... there was no reason for that code to go into pike? | 22:11 |
| mriedem | well, | 22:11 |
| mriedem | you're talking about a series of changes over 2 years | 22:11 |
| mriedem | so we got in what we could get in when we could get it in | 22:11 |
| *** Tom-Tom has joined #openstack-nova | 22:11 | |
| efried | Hindsight, and all that. | 22:12 |
| mriedem | my hindsight is 30/40 | 22:12 |
| efried | Anyway, cool beans. I guess if it is broke, someone will yell. | 22:12 |
| efried | hopefully before EOL. | 22:12 |
| mriedem | there is no more eol | 22:12 |
| mriedem | remember | 22:12 |
| efried | I haven't really been following that. | 22:12 |
| efried | But great, so we have all the time in the world :) | 22:12 |
| melwitt | EOL is EOL | 22:13 |
| melwitt | cacao to cacao | 22:13 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2018-March/128862.html | 22:13 |
| *** salv-orlando has quit IRC | 22:15 | |
| *** salv-orlando has joined #openstack-nova | 22:15 | |
| *** Tom-Tom has quit IRC | 22:16 | |
| *** suresh12 has joined #openstack-nova | 22:17 | |
| *** salv-orlando has quit IRC | 22:19 | |
| *** edmondsw has joined #openstack-nova | 22:20 | |
| *** _ix has quit IRC | 22:21 | |
| *** suresh12 has quit IRC | 22:22 | |
| *** edmondsw has quit IRC | 22:25 | |
| efried | mriedem: Is series https://review.openstack.org/#/c/526753/ approved for rocky? | 22:26 |
| efried | looks like not yet, but spec is up. | 22:27 |
| *** danpawlik has joined #openstack-nova | 22:28 | |
| *** fghaas has left #openstack-nova | 22:29 | |
| mriedem | spec isn't approved | 22:31 |
| mriedem | oh we nacked that at the ptg | 22:31 |
| *** suresh12 has joined #openstack-nova | 22:32 | |
| mriedem | if i'm thinking of the same thing | 22:32 |
| *** danpawlik has quit IRC | 22:33 | |
| *** hongbin has quit IRC | 22:34 | |
| *** yamahata has quit IRC | 22:35 | |
| *** yamamoto has joined #openstack-nova | 22:40 | |
| *** tbachman has quit IRC | 22:42 | |
| efried | TheJulia: Sorry for the delay on https://review.openstack.org/#/c/554762/ | 22:44 |
| efried | TheJulia: I remember pawing through the client code and thinking there was a clean way to send down a microversion per request so you didn't have to clone the client objects. | 22:44 |
| efried | TheJulia: I'm looking again. If I can't suss it, I'll remove my objections (grudgingly, because still ugly, but if that's how we have to move forward...) | 22:45 |
| *** yamamoto has quit IRC | 22:45 | |
| *** chyka has joined #openstack-nova | 22:45 | |
| efried | jroll, dtantsur|afk: FYI ^^ | 22:46 |
| TheJulia | efried: It is one of those things that really we should just replace the guts of.... :( | 22:46 |
| TheJulia | One day :) | 22:46 |
| efried | TheJulia: But can't, because... too much at once? | 22:46 |
| *** Tom-Tom has joined #openstack-nova | 22:46 | |
| efried | ocean boiling, kind of thing | 22:46 |
| TheJulia | yeah | 22:46 |
| TheJulia | kind of at least :( | 22:47 |
| *** chyka_ has quit IRC | 22:48 | |
| *** Tom-Tom has quit IRC | 22:51 | |
| *** r-daneel has quit IRC | 22:52 | |
| Spaz-Home | Morning | 22:53 |
| TheJulia | Good morning | 22:53 |
| *** andreas_s has joined #openstack-nova | 22:53 | |
| *** vladikr has quit IRC | 22:56 | |
| *** andreas_s has quit IRC | 22:58 | |
| efried | TheJulia: So yeah, it looks like on a per-request basis you can pass in a `headers` dict. | 23:01 |
| efried | ...with the X-OpenStack-Version-Whatever thingy. | 23:01 |
| *** danpawlik has joined #openstack-nova | 23:02 | |
| efried | All the layers between there and the wire appear to use setdefault correctly, so it *should* make it through. | 23:02 |
| efried | bbiab... | 23:02 |
| TheJulia | hmmm | 23:02 |
| TheJulia | yeah, same problem though | 23:04 |
| TheJulia | we bypass all of our microversion logic then | 23:04 |
| TheJulia | at least client side | 23:04 |
| *** danpawlik has quit IRC | 23:07 | |
| *** AlexeyAbashkin has joined #openstack-nova | 23:08 | |
| *** itlinux has joined #openstack-nova | 23:10 | |
| TheJulia | Well, looks like we would also re-negotiate with what was provided upon the client being called originally | 23:11 |
| *** AlexeyAbashkin has quit IRC | 23:12 | |
| TheJulia | and I think we would have to add code to handle that this it would be a user defined override | 23:15 |
| jroll | not to mention, then you're leaking implementation details out to the caller | 23:17 |
| * jroll notes we still haven't changed to the 'standard' microversion header | 23:17 | |
| TheJulia | yeah.... | 23:17 |
| openstackgerrit | Merged openstack/nova master: [placement] Fix bad management of _TRAITS_SYNCED flag https://review.openstack.org/557722 | 23:18 |
| jroll | TheJulia: like dmitry, I'd also commit to reviewing client changes to accept that per method, but I don't have any problems with keeping a couple copies of the client | 23:18 |
| jroll | especially if we plan to fix that later | 23:19 |
| *** Tom-Tom has joined #openstack-nova | 23:19 | |
| *** chyka_ has joined #openstack-nova | 23:19 | |
| * TheJulia wonders what has the most value | 23:22 | |
| *** itlinux has quit IRC | 23:22 | |
| *** chyka has quit IRC | 23:23 | |
| *** chyka_ has quit IRC | 23:23 | |
| *** Tom-Tom has quit IRC | 23:24 | |
| efried | Let me work something up right quick. Maybe you'll fall in love with the idea when you see it in action :) | 23:24 |
| efried | melwitt: Oh, another thought I had was putting core reviewer names next to runway slots. Volunteers & SMEs first; then... | 23:26 |
| efried | TheJulia, jroll: Okay, never mind; the (bizarrely resolved through _multi_getattr) target methods don't even take kwargs. | 23:31 |
| TheJulia | heh | 23:31 |
| TheJulia | I think I looked at that a couple of weeks ago pondering something similar | 23:32 |
| TheJulia | of of similar use I should say | 23:32 |
| *** andreas_s has joined #openstack-nova | 23:33 | |
| efried | TheJulia: I removed my -1. Thanks for bearing with me. | 23:36 |
| *** jroll has quit IRC | 23:37 | |
| TheJulia | efried: no, thank you for looking and thinking | 23:37 |
| *** andreas_s has quit IRC | 23:38 | |
| *** danpawlik has joined #openstack-nova | 23:39 | |
| *** yamamoto has joined #openstack-nova | 23:41 | |
| *** danpawlik has quit IRC | 23:45 | |
| *** mlavalle has quit IRC | 23:45 | |
| *** ediardo has joined #openstack-nova | 23:45 | |
| *** yamamoto has quit IRC | 23:47 | |
| *** tetsuro has joined #openstack-nova | 23:47 | |
| *** takashin has joined #openstack-nova | 23:48 | |
| openstackgerrit | Tony Breeds proposed openstack/nova stable/ocata: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550560 | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!