| *** hshiina has joined #openstack-nova | 00:00 | |
| *** zhurong has joined #openstack-nova | 00:02 | |
| *** jackie-truong has quit IRC | 00:03 | |
| *** owalsh_ has joined #openstack-nova | 00:05 | |
| *** owalsh has quit IRC | 00:06 | |
| *** penick has joined #openstack-nova | 00:07 | |
| *** owalsh_ has quit IRC | 00:11 | |
| *** owalsh has joined #openstack-nova | 00:16 | |
| *** tetsuro has joined #openstack-nova | 00:19 | |
| *** zhurong has quit IRC | 00:20 | |
| *** oanson has quit IRC | 00:22 | |
| *** oanson has joined #openstack-nova | 00:24 | |
| *** yangyapeng has quit IRC | 00:25 | |
| *** yangyapeng has joined #openstack-nova | 00:25 | |
| *** artom has joined #openstack-nova | 00:26 | |
| *** takashin has quit IRC | 00:28 | |
| *** takashin has joined #openstack-nova | 00:28 | |
| *** acormier has joined #openstack-nova | 00:29 | |
| *** yangyapeng has quit IRC | 00:30 | |
| *** penick has quit IRC | 00:30 | |
| *** mlavalle has quit IRC | 00:31 | |
| *** yingjun has joined #openstack-nova | 00:32 | |
| *** penick has joined #openstack-nova | 00:32 | |
| *** acormier has quit IRC | 00:33 | |
| *** Nil_ has quit IRC | 00:34 | |
| *** acormier has joined #openstack-nova | 00:37 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:38 | |
| *** sdague has joined #openstack-nova | 00:39 | |
| *** acormier has quit IRC | 00:41 | |
| *** liuzz has joined #openstack-nova | 00:42 | |
| *** chyka has quit IRC | 00:43 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - List/Show all server migration types https://review.openstack.org/430839 | 00:48 |
|---|---|---|
| *** Dinesh_Bhor has quit IRC | 00:49 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:50 | |
| *** mariusv__ has quit IRC | 00:51 | |
| *** mariusv has joined #openstack-nova | 00:53 | |
| *** mariusv has quit IRC | 00:53 | |
| *** mariusv has joined #openstack-nova | 00:53 | |
| takashin | 00:55 | |
| Spazmotic | 00:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | 00:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094 | 00:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (resource_provider) https://review.openstack.org/528629 | 00:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225 | 00:58 |
| *** zhurong has joined #openstack-nova | 00:58 | |
| *** penick has quit IRC | 00:58 | |
| *** nicolasbock has quit IRC | 00:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 00:58 |
| *** amodi has quit IRC | 00:59 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 01:01 |
| *** r-daneel has quit IRC | 01:01 | |
| *** mdnadeem has joined #openstack-nova | 01:06 | |
| *** zhaochao has joined #openstack-nova | 01:10 | |
| *** phuongnh has joined #openstack-nova | 01:11 | |
| *** tiendc has joined #openstack-nova | 01:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/537093 | 01:14 |
| *** stakeda has joined #openstack-nova | 01:14 | |
| *** crushil has joined #openstack-nova | 01:15 | |
| *** Dinesh_Bhor has quit IRC | 01:15 | |
| *** salv-orlando has joined #openstack-nova | 01:15 | |
| *** eandersson has quit IRC | 01:16 | |
| *** eandersson_ has joined #openstack-nova | 01:16 | |
| *** yangyapeng has joined #openstack-nova | 01:17 | |
| *** armax has quit IRC | 01:18 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:19 | |
| *** salv-orlando has quit IRC | 01:20 | |
| *** Tom-Tom has joined #openstack-nova | 01:21 | |
| *** david-lyle has quit IRC | 01:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-traits master: Updated from global requirements https://review.openstack.org/533994 | 01:23 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | 01:23 |
| *** Tom-Tom_ has joined #openstack-nova | 01:24 | |
| *** Tom-Tom has quit IRC | 01:25 | |
| *** yangyapeng has quit IRC | 01:26 | |
| *** yangyapeng has joined #openstack-nova | 01:26 | |
| *** inara has quit IRC | 01:27 | |
| *** armax has joined #openstack-nova | 01:29 | |
| *** inara has joined #openstack-nova | 01:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/537171 | 01:31 |
| *** takashin has quit IRC | 01:34 | |
| *** oanson has quit IRC | 01:38 | |
| *** sdague has quit IRC | 01:40 | |
| *** oanson has joined #openstack-nova | 01:41 | |
| *** hieulq_ has quit IRC | 01:42 | |
| *** jackie-truong has joined #openstack-nova | 01:54 | |
| jackie-truong | If anyone has a free moment to review this patch, it would be much appreciated: https://review.openstack.org/#/c/486204/ | 01:56 |
| *** hieulq_ has joined #openstack-nova | 01:59 | |
| *** Guest87011 has quit IRC | 02:00 | |
| *** yassine has joined #openstack-nova | 02:00 | |
| *** yassine is now known as Guest50651 | 02:00 | |
| Spazmotic | Thanks jianghuaw, I will spin up that bug report tomorrow night when I am at my dev machine and can pull some XenAPI logs for it :) | 02:00 |
| jianghuaw | Spazmotic, good:-) | 02:01 |
| Spazmotic | Also should go ahead and rebase and fix that inline while i'm at it tomorrow. | 02:01 |
| *** dikonoor has joined #openstack-nova | 02:03 | |
| *** esberglu has joined #openstack-nova | 02:03 | |
| *** esberglu has quit IRC | 02:06 | |
| *** chyka has joined #openstack-nova | 02:07 | |
| *** chyka has quit IRC | 02:08 | |
| *** gcb has joined #openstack-nova | 02:09 | |
| *** zhaochao has quit IRC | 02:11 | |
| *** armax_ has joined #openstack-nova | 02:12 | |
| *** yamamoto has joined #openstack-nova | 02:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-traits master: Updated from global requirements https://review.openstack.org/533994 | 02:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | 02:15 |
| *** armax has quit IRC | 02:15 | |
| *** armax_ is now known as armax | 02:15 | |
| *** Dinesh_Bhor has quit IRC | 02:15 | |
| *** Dinesh__Bhor has joined #openstack-nova | 02:15 | |
| *** hongbin has joined #openstack-nova | 02:16 | |
| *** salv-orlando has joined #openstack-nova | 02:17 | |
| *** harlowja has quit IRC | 02:20 | |
| *** salv-orlando has quit IRC | 02:21 | |
| *** dikonoo has joined #openstack-nova | 02:22 | |
| *** dikonoor has quit IRC | 02:22 | |
| alex_xu | mriedem: dansmith good news is we have allocation_req_version in Selection obj, then I can convert the alloc_req dict to consistent format in the begining of claim method probably | 02:24 |
| alex_xu | mriedem: dansmith here is https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L629 | 02:25 |
| *** zhaochao has joined #openstack-nova | 02:25 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 02:31 |
| *** gyee has quit IRC | 02:31 | |
| sean-k-mooney | stephenfin: https://review.openstack.org/#/c/449257/ now uses objects. ill be in around lunch tomorow if you have any questions. | 02:32 |
| *** wxy has joined #openstack-nova | 02:33 | |
| *** gongysh has joined #openstack-nova | 02:35 | |
| *** lyan has quit IRC | 02:47 | |
| *** jackie-truong has quit IRC | 02:52 | |
| *** zhurong has quit IRC | 02:57 | |
| *** vladikr has quit IRC | 03:02 | |
| *** vladikr has joined #openstack-nova | 03:02 | |
| *** damien_r has quit IRC | 03:08 | |
| *** damien_r has joined #openstack-nova | 03:08 | |
| *** crushil has quit IRC | 03:09 | |
| openstackgerrit | Dao Cong Tien proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 03:10 |
| *** tuanla____ has joined #openstack-nova | 03:14 | |
| *** smatzek has joined #openstack-nova | 03:17 | |
| *** salv-orlando has joined #openstack-nova | 03:17 | |
| *** salv-orlando has quit IRC | 03:22 | |
| *** sree has joined #openstack-nova | 03:22 | |
| *** sree_ has joined #openstack-nova | 03:25 | |
| *** sree_ is now known as Guest62420 | 03:25 | |
| *** sree has quit IRC | 03:29 | |
| *** lyan has joined #openstack-nova | 03:31 | |
| *** lyan has quit IRC | 03:31 | |
| *** david-lyle has joined #openstack-nova | 03:31 | |
| *** fragatina has quit IRC | 03:32 | |
| *** david-lyle has quit IRC | 03:32 | |
| *** david-lyle has joined #openstack-nova | 03:33 | |
| *** david-lyle has quit IRC | 03:39 | |
| *** felipemonteiro_ has joined #openstack-nova | 03:41 | |
| *** smatzek has quit IRC | 03:41 | |
| *** felipemonteiro__ has joined #openstack-nova | 03:42 | |
| *** hshiina has quit IRC | 03:42 | |
| *** tbachman has quit IRC | 03:44 | |
| *** felipemonteiro_ has quit IRC | 03:45 | |
| *** bhujay has joined #openstack-nova | 03:46 | |
| *** abhishekk has joined #openstack-nova | 03:47 | |
| *** lyan has joined #openstack-nova | 03:47 | |
| *** annp has joined #openstack-nova | 03:48 | |
| *** brault has quit IRC | 03:49 | |
| *** BenderRodriguez has left #openstack-nova | 03:50 | |
| *** psachin` has joined #openstack-nova | 03:52 | |
| *** psachin has joined #openstack-nova | 03:52 | |
| *** hshiina has joined #openstack-nova | 03:54 | |
| *** bhujay has quit IRC | 04:00 | |
| *** tovin07 has quit IRC | 04:00 | |
| *** tiendc has quit IRC | 04:00 | |
| *** tuanla____ has quit IRC | 04:00 | |
| *** tiendc has joined #openstack-nova | 04:01 | |
| *** tovin07 has joined #openstack-nova | 04:01 | |
| *** tuanla____ has joined #openstack-nova | 04:01 | |
| openstackgerrit | Deepak Mourya proposed openstack/nova master: Handle TZ change in iso8601 >=0.1.12 https://review.openstack.org/535700 | 04:06 |
| *** yingjun has quit IRC | 04:06 | |
| *** gongysh has quit IRC | 04:07 | |
| *** Tom-Tom_ has quit IRC | 04:10 | |
| *** jaianshu has joined #openstack-nova | 04:11 | |
| *** liverpooler has quit IRC | 04:11 | |
| *** lyan has quit IRC | 04:12 | |
| *** mdnadeem has quit IRC | 04:18 | |
| *** salv-orlando has joined #openstack-nova | 04:18 | |
| *** janki has joined #openstack-nova | 04:22 | |
| *** salv-orlando has quit IRC | 04:22 | |
| *** mdnadeem has joined #openstack-nova | 04:25 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 04:25 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 04:25 |
| openstackgerrit | sean mooney proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051 | 04:25 |
| *** dave-mccowan has quit IRC | 04:27 | |
| *** gongysh has joined #openstack-nova | 04:29 | |
| *** felipemonteiro__ has quit IRC | 04:31 | |
| *** tuanla____ has quit IRC | 04:33 | |
| *** tovin07 has quit IRC | 04:33 | |
| *** annp has quit IRC | 04:33 | |
| *** annp has joined #openstack-nova | 04:34 | |
| *** tuanla____ has joined #openstack-nova | 04:34 | |
| *** tovin07 has joined #openstack-nova | 04:34 | |
| *** Tom-Tom has joined #openstack-nova | 04:36 | |
| *** pramodrj07 has quit IRC | 04:39 | |
| *** Dinesh__Bhor has quit IRC | 04:40 | |
| *** Tom-Tom has quit IRC | 04:40 | |
| *** Dinesh__Bhor has joined #openstack-nova | 04:40 | |
| *** masber has joined #openstack-nova | 04:42 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: using the dict format for the allocation in claim_resources https://review.openstack.org/536083 | 04:47 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 04:48 |
| *** vladikr has quit IRC | 04:52 | |
| *** sridharg has joined #openstack-nova | 04:52 | |
| *** hongbin has quit IRC | 04:54 | |
| *** ratailor has joined #openstack-nova | 04:56 | |
| *** dikonoo has quit IRC | 05:12 | |
| *** blkart has joined #openstack-nova | 05:14 | |
| *** salv-orlando has joined #openstack-nova | 05:19 | |
| openstackgerrit | Merged openstack/nova master: Set server status to ERROR if rebuild failed https://review.openstack.org/536268 | 05:19 |
| *** harlowja has joined #openstack-nova | 05:19 | |
| *** salv-orlando has quit IRC | 05:23 | |
| *** dikonoor has joined #openstack-nova | 05:29 | |
| *** links has joined #openstack-nova | 05:32 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: using the dict format for the allocation in claim_resources https://review.openstack.org/536083 | 05:37 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 05:37 |
| *** lajoskatona has joined #openstack-nova | 05:39 | |
| *** Sandy619 has joined #openstack-nova | 05:41 | |
| *** salv-orlando has joined #openstack-nova | 05:45 | |
| *** Sandy619 has quit IRC | 05:46 | |
| *** Tom-Tom has joined #openstack-nova | 05:48 | |
| *** chyka has joined #openstack-nova | 05:50 | |
| *** dikonoor has quit IRC | 05:51 | |
| *** dikonoor has joined #openstack-nova | 05:52 | |
| *** Guest62420 has quit IRC | 05:53 | |
| *** sree has joined #openstack-nova | 05:54 | |
| *** chyka has quit IRC | 05:55 | |
| *** bhujay has joined #openstack-nova | 05:58 | |
| *** clayton has quit IRC | 05:58 | |
| *** sree has quit IRC | 05:59 | |
| *** Dinesh__Bhor has quit IRC | 05:59 | |
| *** Eran_Kuris has joined #openstack-nova | 06:03 | |
| *** rcernin_ has joined #openstack-nova | 06:03 | |
| *** rcernin has quit IRC | 06:03 | |
| *** clayton has joined #openstack-nova | 06:04 | |
| *** dikonoor has quit IRC | 06:06 | |
| *** dikonoor has joined #openstack-nova | 06:06 | |
| *** armax has quit IRC | 06:07 | |
| *** Eran_Kuris has quit IRC | 06:08 | |
| *** sree has joined #openstack-nova | 06:08 | |
| *** Dinesh__Bhor has joined #openstack-nova | 06:08 | |
| *** Eran_Kuris has joined #openstack-nova | 06:10 | |
| *** sree has quit IRC | 06:12 | |
| *** fragatina has joined #openstack-nova | 06:13 | |
| *** fragatina has quit IRC | 06:14 | |
| *** acormier has joined #openstack-nova | 06:14 | |
| *** fragatina has joined #openstack-nova | 06:14 | |
| *** tbachman has joined #openstack-nova | 06:15 | |
| *** dikonoor has quit IRC | 06:15 | |
| *** tbachman has quit IRC | 06:15 | |
| ameeda | Morning :) | 06:18 |
| ameeda | can you please check this code to detach volumes "http://paste.openstack.org/show/651488/" and let me know if that need to fix or anything else | 06:18 |
| *** acormier has quit IRC | 06:18 | |
| *** tbachman has joined #openstack-nova | 06:18 | |
| *** gcb has quit IRC | 06:22 | |
| *** slaweq has joined #openstack-nova | 06:26 | |
| *** slaweq has quit IRC | 06:28 | |
| *** sridharg has quit IRC | 06:28 | |
| *** dikonoor has joined #openstack-nova | 06:30 | |
| *** threestrands has joined #openstack-nova | 06:39 | |
| *** slaweq has joined #openstack-nova | 06:44 | |
| *** Dinesh__Bhor has quit IRC | 06:46 | |
| *** slaweq has quit IRC | 06:49 | |
| *** blkart has quit IRC | 06:49 | |
| *** threestrands has quit IRC | 06:49 | |
| *** Dinesh__Bhor has joined #openstack-nova | 06:50 | |
| *** Dinesh__Bhor has quit IRC | 06:52 | |
| *** Dinesh__Bhor has joined #openstack-nova | 06:52 | |
| *** tbachman has quit IRC | 06:54 | |
| *** slaweq has joined #openstack-nova | 07:03 | |
| *** annp has quit IRC | 07:10 | |
| alex_xu | gibi: hi, I update the patch and addressed a upgrade case which pointed by Matt https://review.openstack.org/#/c/536083 | 07:10 |
| *** pcaruana has joined #openstack-nova | 07:10 | |
| *** rcernin has joined #openstack-nova | 07:12 | |
| *** rcernin_ has quit IRC | 07:12 | |
| *** slaweq has quit IRC | 07:14 | |
| *** Dinesh__Bhor has quit IRC | 07:17 | |
| *** janki has quit IRC | 07:18 | |
| *** pcaruana has quit IRC | 07:21 | |
| *** pcaruana has joined #openstack-nova | 07:22 | |
| *** markvoelker has quit IRC | 07:25 | |
| *** markvoelker has joined #openstack-nova | 07:27 | |
| *** jdurgin has quit IRC | 07:28 | |
| *** edand__ has joined #openstack-nova | 07:29 | |
| *** markvoelker has quit IRC | 07:32 | |
| *** chyka has joined #openstack-nova | 07:39 | |
| *** slaweq has joined #openstack-nova | 07:40 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Do not normalize allocation_ratios https://review.openstack.org/532924 | 07:42 |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Do not normalize allocation_ratios https://review.openstack.org/532924 | 07:43 |
| *** chyka has quit IRC | 07:44 | |
| *** slaweq has quit IRC | 07:45 | |
| *** jdurgin has joined #openstack-nova | 07:45 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342 | 07:46 |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Do not normalize allocation_ratios https://review.openstack.org/532924 | 07:54 |
| *** itlinux has joined #openstack-nova | 07:56 | |
| *** brault has joined #openstack-nova | 08:01 | |
| *** pcaruana has quit IRC | 08:01 | |
| *** rgerganov|away is now known as rgerganov | 08:02 | |
| *** matrohon has joined #openstack-nova | 08:02 | |
| *** alexchadin has joined #openstack-nova | 08:10 | |
| *** sgordon has quit IRC | 08:17 | |
| kashyap | dmsimard: Hey, I'm fully occupied with something more urgent until 04-Feb, I'm afraid. But I've added that to my TODO queue. | 08:20 |
| *** sahid has joined #openstack-nova | 08:20 | |
| *** ragiman has joined #openstack-nova | 08:20 | |
| *** amoralej|off is now known as amoralej | 08:22 | |
| *** sgordon has joined #openstack-nova | 08:23 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:23 | |
| *** itlinux has quit IRC | 08:24 | |
| *** lpetrut has joined #openstack-nova | 08:25 | |
| *** tesseract has joined #openstack-nova | 08:27 | |
| *** alexchadin has quit IRC | 08:28 | |
| *** alexchadin has joined #openstack-nova | 08:29 | |
| *** lpetrut has quit IRC | 08:32 | |
| *** mdnadeem has quit IRC | 08:36 | |
| *** alexchadin has quit IRC | 08:36 | |
| *** mdnadeem has joined #openstack-nova | 08:36 | |
| *** mdnadeem is now known as mdnadeem|lunch | 08:36 | |
| *** alexchadin has joined #openstack-nova | 08:36 | |
| *** lpetrut has joined #openstack-nova | 08:38 | |
| *** pcaruana has joined #openstack-nova | 08:39 | |
| *** alexchad_ has joined #openstack-nova | 08:40 | |
| *** diegows has quit IRC | 08:41 | |
| *** dikonoo has joined #openstack-nova | 08:41 | |
| *** dikonoor has quit IRC | 08:42 | |
| *** alexchadin has quit IRC | 08:42 | |
| *** rcernin has quit IRC | 08:44 | |
| *** jpena|off is now known as jpena | 08:45 | |
| *** diegows has joined #openstack-nova | 08:46 | |
| *** Guest50651 has quit IRC | 08:49 | |
| *** Guest50651 has joined #openstack-nova | 08:52 | |
| gibi | alex_xu: looking... | 08:52 |
| alex_xu | gibi: thanks | 08:52 |
| *** matrohon has quit IRC | 08:53 | |
| *** yamamoto has quit IRC | 08:53 | |
| *** tesseract has quit IRC | 08:54 | |
| ameeda | please please please, can anyone approve my gerrit here ? https://review.openstack.org/#/c/526900/ | 08:59 |
| *** jaianshu_ has joined #openstack-nova | 09:03 | |
| *** tesseract has joined #openstack-nova | 09:03 | |
| *** jaianshu has quit IRC | 09:05 | |
| *** harlowja has quit IRC | 09:07 | |
| *** lpetrut_ has joined #openstack-nova | 09:08 | |
| *** yamahata has quit IRC | 09:10 | |
| *** yamamoto has joined #openstack-nova | 09:10 | |
| *** lpetrut has quit IRC | 09:10 | |
| *** cdent has joined #openstack-nova | 09:11 | |
| *** itlinux has joined #openstack-nova | 09:12 | |
| *** purplerbot has quit IRC | 09:12 | |
| *** ilyashakhat has quit IRC | 09:15 | |
| *** alexchad_ is now known as alexchadin | 09:15 | |
| *** ilyashakhat has joined #openstack-nova | 09:21 | |
| mdbooth | stephenfin: You were holding off on a +2 for melwitt ? https://review.openstack.org/#/c/523958/18 | 09:23 |
| *** psachin` has quit IRC | 09:24 | |
| *** lpetrut_ has quit IRC | 09:25 | |
| *** psachin has quit IRC | 09:25 | |
| *** purplerbot has joined #openstack-nova | 09:25 | |
| *** purplerbot has quit IRC | 09:26 | |
| *** purplerbot has joined #openstack-nova | 09:26 | |
| *** ralonsoh has joined #openstack-nova | 09:27 | |
| *** markvoelker has joined #openstack-nova | 09:28 | |
| *** psachin has joined #openstack-nova | 09:32 | |
| *** ratailor_ has joined #openstack-nova | 09:34 | |
| *** ratailor has quit IRC | 09:35 | |
| *** ragiman has quit IRC | 09:39 | |
| *** derekh has joined #openstack-nova | 09:39 | |
| *** stakeda has quit IRC | 09:39 | |
| *** sridharg has joined #openstack-nova | 09:49 | |
| *** yangyapeng has quit IRC | 09:50 | |
| *** sdague has joined #openstack-nova | 09:50 | |
| *** yangyapeng has joined #openstack-nova | 09:51 | |
| *** matrohon has joined #openstack-nova | 09:53 | |
| *** ragiman has joined #openstack-nova | 09:53 | |
| *** yangyapeng has quit IRC | 09:55 | |
| *** tuanla____ has quit IRC | 09:58 | |
| bauzas | morning folks | 09:58 |
| maciejjozefczyk | bauzas: hiho | 09:58 |
| bauzas | my presence is a bit off, given I'm in a conference | 09:58 |
| bauzas | just ping me directly if you need me | 09:58 |
| maciejjozefczyk | bauzas: good to know cause I have something for you | 09:59 |
| *** yamamoto has quit IRC | 09:59 | |
| *** ralonsoh_ has joined #openstack-nova | 10:01 | |
| *** maciejjozefczyk is now known as maciejjozefczyk| | 10:01 | |
| *** maciejjozefczyk| is now known as maciejjozefczykb | 10:01 | |
| *** maciejjozefczykb is now known as maciejjozefczyk_ | 10:01 | |
| *** markvoelker has quit IRC | 10:02 | |
| *** lajoskatona has quit IRC | 10:03 | |
| *** ralonsoh has quit IRC | 10:04 | |
| openstackgerrit | nalini proposed openstack/nova master: Modify show aggregate to display 'updated_at' value https://review.openstack.org/537334 | 10:08 |
| *** avolkov has joined #openstack-nova | 10:11 | |
| Spazmotic | morning | 10:11 |
| *** slaweq has joined #openstack-nova | 10:11 | |
| *** jcosmao has left #openstack-nova | 10:14 | |
| *** acormier has joined #openstack-nova | 10:16 | |
| *** yamamoto has joined #openstack-nova | 10:16 | |
| *** jaosorior has quit IRC | 10:16 | |
| *** jcosmao has joined #openstack-nova | 10:17 | |
| *** jaosorior has joined #openstack-nova | 10:17 | |
| *** lajoskatona has joined #openstack-nova | 10:19 | |
| *** dtantsur|afk is now known as dtantsur | 10:19 | |
| *** acormier has quit IRC | 10:20 | |
| *** sambetts|afk is now known as sambetts | 10:20 | |
| *** dikonoo has quit IRC | 10:21 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Avoid suspending guest with attached vGPUs https://review.openstack.org/535693 | 10:23 |
| *** Tom-Tom has quit IRC | 10:24 | |
| *** jaianshu__ has joined #openstack-nova | 10:29 | |
| *** jaianshu_ has quit IRC | 10:32 | |
| *** lucas-afk is now known as lucasagomes | 10:33 | |
| *** dikonoo has joined #openstack-nova | 10:33 | |
| *** abhishekk has quit IRC | 10:34 | |
| *** rcernin has joined #openstack-nova | 10:34 | |
| *** gszasz has joined #openstack-nova | 10:35 | |
| *** matrohon has quit IRC | 10:37 | |
| *** edand__ has quit IRC | 10:37 | |
| *** yangyapeng has joined #openstack-nova | 10:39 | |
| *** phuongnh has quit IRC | 10:40 | |
| *** yankcrime has quit IRC | 10:41 | |
| *** slaweq has quit IRC | 10:42 | |
| *** slaweq has joined #openstack-nova | 10:43 | |
| *** slaweq has quit IRC | 10:48 | |
| *** dikonoo has quit IRC | 10:48 | |
| *** _nick has joined #openstack-nova | 10:49 | |
| *** _nick is now known as yankcrime | 10:49 | |
| *** mdnadeem|lunch has quit IRC | 10:50 | |
| Spazmotic | Too full.. will die | 10:53 |
| Spazmotic | or burp.. one of those things | 10:53 |
| *** AlexeyAbashkin has quit IRC | 10:53 | |
| *** AlexeyAbashkin has joined #openstack-nova | 10:54 | |
| *** ragiman has quit IRC | 10:55 | |
| *** alexchadin has quit IRC | 10:56 | |
| *** yangyapeng has quit IRC | 10:58 | |
| *** markvoelker has joined #openstack-nova | 10:58 | |
| *** liuzz has quit IRC | 10:59 | |
| *** yangyapeng has joined #openstack-nova | 10:59 | |
| *** alexchadin has joined #openstack-nova | 10:59 | |
| *** gaoyan has joined #openstack-nova | 11:01 | |
| *** gaoyan has quit IRC | 11:06 | |
| *** gaoyan_ has joined #openstack-nova | 11:06 | |
| *** ragiman has joined #openstack-nova | 11:07 | |
| *** chyka has joined #openstack-nova | 11:15 | |
| *** gongysh has quit IRC | 11:16 | |
| *** dtantsur is now known as dtantsur|brb | 11:19 | |
| *** sapd_ has quit IRC | 11:19 | |
| *** sapd_ has joined #openstack-nova | 11:19 | |
| *** psachin has quit IRC | 11:19 | |
| *** chyka has quit IRC | 11:20 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: using the dict format for the allocation in claim_resources https://review.openstack.org/536083 | 11:21 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 11:21 |
| alex_xu | gibi: stephenfin, ^ sorry for I missed that two unittests, just fix them | 11:22 |
| stephenfin | (y) | 11:22 |
| *** itlinux has quit IRC | 11:23 | |
| *** gaoyan_ has quit IRC | 11:23 | |
| *** gaoyan_ has joined #openstack-nova | 11:23 | |
| *** gaoyan_ has quit IRC | 11:23 | |
| gibi | alex_xu: no worries, I was pulled into something internally so I have to go back to your patches | 11:24 |
| alex_xu | gibi: no problem, thanks for your time | 11:25 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Fix nits in support traits on allocation candidates API https://review.openstack.org/537351 | 11:25 |
| *** gszasz has quit IRC | 11:29 | |
| *** markvoelker has quit IRC | 11:32 | |
| *** edand__ has joined #openstack-nova | 11:34 | |
| *** bhujay has quit IRC | 11:37 | |
| *** itlinux has joined #openstack-nova | 11:38 | |
| *** bhujay has joined #openstack-nova | 11:39 | |
| rgerganov | cdent, the issue I had yesterday: https://review.openstack.org/#/c/533821/7/nova/scheduler/client/report.py | 11:44 |
| rgerganov | cdent, you were right that the problem is in update_from_provider_tree :) | 11:44 |
| *** mvenesio has joined #openstack-nova | 11:45 | |
| cdent | rgerganov: ah, interesting, nice sleuthing. Was the trait failure because you were using a not-allowed trait? | 11:48 |
| rgerganov | yes :) | 11:49 |
| rgerganov | speaking of that, how do I add a new trait? | 11:49 |
| cdent | rgerganov: are you wanting to establish a new official trait, or set a CUSTOM trait in the local deployment? | 11:52 |
| cdent | if the latter: https://developer.openstack.org/api-ref/placement/#update-traits | 11:52 |
| cdent | if the former: https://github.com/openstack/os-traits | 11:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't filter out sibling sets with one core https://review.openstack.org/537361 | 11:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Update tests to set 'NUMACell.siblings' https://review.openstack.org/537362 | 11:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure emulator threads are always calculated https://review.openstack.org/537363 | 11:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Always pass 'NUMACell.siblings' to _pack_instance_onto_cores' https://review.openstack.org/537364 | 11:53 |
| stephenfin | sahid: Fancy taking a look at those ^ ? | 11:53 |
| rgerganov | cdent, thanks, I believe it is the latter | 11:53 |
| *** jaianshu__ has quit IRC | 11:56 | |
| *** dave-mccowan has joined #openstack-nova | 12:09 | |
| *** zhurong has joined #openstack-nova | 12:10 | |
| *** smatzek has joined #openstack-nova | 12:17 | |
| *** mvk has quit IRC | 12:19 | |
| *** slaweq has joined #openstack-nova | 12:24 | |
| *** ratailor_ has quit IRC | 12:28 | |
| *** slaweq has quit IRC | 12:29 | |
| *** lpetrut_ has joined #openstack-nova | 12:29 | |
| *** markvoelker has joined #openstack-nova | 12:29 | |
| *** mvk has joined #openstack-nova | 12:31 | |
| *** blkart has joined #openstack-nova | 12:34 | |
| *** jpena is now known as jpena|lunch | 12:36 | |
| *** stvnoyes has joined #openstack-nova | 12:36 | |
| *** gszasz has joined #openstack-nova | 12:39 | |
| *** lajoskatona has quit IRC | 12:55 | |
| *** mvk has quit IRC | 12:56 | |
| efried_back_wed | rgerganov Haven't caught up fully; what news? | 12:57 |
| *** efried_back_wed is now known as efried | 12:58 | |
| *** lajoskatona has joined #openstack-nova | 12:58 | |
| *** READ10 has joined #openstack-nova | 12:58 | |
| rgerganov | efried, hi, I found why the local tree was missing the nested RP, see my comment here: https://review.openstack.org/#/c/533821/7/nova/scheduler/client/report.py | 12:58 |
| rgerganov | efried, my driver was trying to create an incorrect trait and update_from_provider_tree silently removed the nested RP | 12:59 |
| *** gszasz has quit IRC | 13:02 | |
| efried | rgerganov Hum, yeah, that code will remove the entire sub-branch from the tree (but only remove its root from the association cache - yet another leak in that cache, though it's resolved a couple patches up the series). | 13:02 |
| *** markvoelker has quit IRC | 13:03 | |
| efried | rgerganov But that's *supposed* to be okay, because we should wind up restoring it next time we refresh_associations | 13:03 |
| *** acormier has joined #openstack-nova | 13:04 | |
| rgerganov | efried, this is not the case, we don't restore the nested RP and when we try to recreate it, we fail | 13:04 |
| *** acormier has quit IRC | 13:05 | |
| *** acormier has joined #openstack-nova | 13:05 | |
| efried | rgerganov So the bug we need to track down is *why* we don't restore it in the cache. | 13:05 |
| efried | rgerganov Oh, is all of this happening in a single invocation of update_from_provider_tree ? | 13:05 |
| *** lpetrut_ has quit IRC | 13:05 | |
| rgerganov | efried, yes | 13:06 |
| efried | Aha | 13:06 |
| *** lpetrut_ has joined #openstack-nova | 13:06 | |
| rgerganov | efried, in one invocation we create the nested RP in placement and mess up the local tree | 13:06 |
| rgerganov | and on the invocation we try to create it again and then fail | 13:06 |
| rgerganov | and on the next invocation we try to create it again and then fail | 13:06 |
| efried | Wellll | 13:07 |
| efried | I would have expected us to refresh at some point before that second invocation | 13:07 |
| rgerganov | that's why I was thinking that https://review.openstack.org/#/c/536902 is a good idea | 13:07 |
| *** lpetrut_ has quit IRC | 13:07 | |
| rgerganov | even if the root node exists, refresh the tree before calling the virt driver for changes | 13:08 |
| *** acormier_ has joined #openstack-nova | 13:08 | |
| *** lpetrut_ has joined #openstack-nova | 13:08 | |
| *** chyka has joined #openstack-nova | 13:08 | |
| efried | rgerganov As written, that change will *not* refresh the tree, though | 13:09 |
| *** lpetrut_ has quit IRC | 13:09 | |
| efried | If you want a simple try-out, change to force=True | 13:10 |
| *** lpetrut_ has joined #openstack-nova | 13:10 | |
| rgerganov | efried, this loop doesn't run at all: for u in self._provider_tree.get_provider_uuids(uuid): | 13:11 |
| *** lpetrut_ has quit IRC | 13:11 | |
| rgerganov | because there are no children in the local tree | 13:11 |
| efried | rgerganov That call should at least return `uuid` itself. | 13:11 |
| rgerganov | ah, correct | 13:11 |
| *** lpetrut_ has joined #openstack-nova | 13:11 | |
| rgerganov | my bad | 13:11 |
| efried | And then the _refresh_associations call should re-grab all the tree-associated providers | 13:12 |
| efried | But possibly only if the cache timeout has occurred. | 13:12 |
| *** acormier has quit IRC | 13:12 | |
| efried | Which may actually be the issue. | 13:12 |
| efried | So we'll refresh the root there, but then on the recursive part of the call, we'll check the cache timeout map | 13:12 |
| efried | ...which will still have stale entries because we only removed the nodes from the ProviderTree; we didn't remove the cache timeout entry for the descendants. | 13:13 |
| *** chyka has quit IRC | 13:13 | |
| efried | So force=True as mentioned above would work; but the more correct solution would be to remove all those other association refresh times when we invalidate that root from the cache. | 13:14 |
| rgerganov | efried, do you want me to try it? | 13:14 |
| efried | rgerganov If you've got a setup all ready to go, please do. It would take me some time to get to that point. | 13:14 |
| efried | rgerganov Meanwhile, let me come up with the other solution real quick... | 13:14 |
| rgerganov | ok | 13:14 |
| *** acormier_ has quit IRC | 13:15 | |
| *** acormier has joined #openstack-nova | 13:15 | |
| rgerganov | efried, with force=True it refreshed the associations for the root provider but it didn't add the nested RP in the tree | 13:17 |
| *** amoralej is now known as amoralej|lunch | 13:19 | |
| efried | rgerganov At a glance, I don't see (and I don't offhand remember) how tree-associated providers get refreshed. While I poke at that, would you please try this: https://review.openstack.org/#/c/533821/7/nova/scheduler/client/report.py@1381 | 13:20 |
| *** liverpooler has joined #openstack-nova | 13:20 | |
| rgerganov | efried, ok, trying | 13:21 |
| efried | Okay, that's not gonna work either. | 13:21 |
| efried | But try it anyway, for grins. | 13:21 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | 13:21 |
| *** tiendc has quit IRC | 13:21 | |
| *** edmondsw has joined #openstack-nova | 13:21 | |
| *** edmondsw_ has joined #openstack-nova | 13:22 | |
| efried | rgerganov https://review.openstack.org/#/c/526541/19/nova/scheduler/client/report.py@631 and @639 are the things that *should* be repopulating the _provider_tree from placement. | 13:24 |
| rgerganov | efried, AttributeError: 'SchedulerReportClient' object has no attribute 'association_refresh_time' | 13:25 |
| efried | rgerganov Oh, are you sitting on the very top of the series? | 13:25 |
| efried | Or did I forget the underscore :) | 13:25 |
| *** lajoskatona has quit IRC | 13:25 | |
| *** edmondsw has quit IRC | 13:26 | |
| openstackgerrit | Gao Fei proposed openstack/nova master: Update VMWare vSphere link address https://review.openstack.org/535244 | 13:27 |
| rgerganov | efried, my patches are based on top of "Move refresh time from report client to prov tree" | 13:27 |
| gibi | is it only me or gerrit is slow like hell today | 13:27 |
| gibi | ? | 13:28 |
| rgerganov | gibi, yes, it's really slow | 13:28 |
| efried | gibi Not just you. Slow as hell. Started grinding yesterday. | 13:28 |
| efried | Maybe ask -infra to bounce it. | 13:28 |
| gibi | thanks for the info | 13:28 |
| efried | rgerganov Okay, that patch got rid of _association_refresh_time in the report client, and would have made my suggested fix moot anyway. | 13:28 |
| efried | rgerganov So what I can't figure out is why, in _ensure_resource_provider, the _get_providers_in_tree => populate_from_iterable isn't restoring the descendants to the cache. | 13:29 |
| efried | Are you pdb'ing? | 13:30 |
| rgerganov | efried, yes | 13:30 |
| *** lpetrut_ has quit IRC | 13:30 | |
| efried | Can you break at https://review.openstack.org/#/c/536902/1/nova/scheduler/client/report.py@626 at make sure rps_to_refresh contains all the descendants? | 13:30 |
| rgerganov | with or without my patch? | 13:31 |
| efried | Shouldn't matter. | 13:31 |
| *** alexchadin has quit IRC | 13:31 | |
| rgerganov | ok, tracing | 13:31 |
| efried | Because as it turns out, _refresh_associations isn't where we pick up tree-associated providers. It's in fact in this chunk of _ensure_resource_provider. | 13:32 |
| *** sean-k-mooney has quit IRC | 13:32 | |
| rgerganov | efried, it does matter because without my patch we don't get there | 13:33 |
| efried | Oh, because 'return uuid'... | 13:34 |
| rgerganov | correct | 13:34 |
| efried | ...but that .exists(uuid) should be False! | 13:34 |
| efried | Because we removed that guy. | 13:34 |
| *** Tom-Tom has joined #openstack-nova | 13:34 | |
| rgerganov | no, we pass the parent uuid here | 13:34 |
| rgerganov | and it is there | 13:34 |
| artom | Am I doing this right? http://logstash.openstack.org/#dashboard/file/logstash.json?query=libvirtError%3A%20Cannot%20recv%20data | 13:35 |
| rgerganov | efried, _ensure_resource_provider is called with the uuid of the root RP | 13:35 |
| artom | It says 0 hits, but we clearly got some here: http://logs.openstack.org/97/536897/2/check/legacy-tempest-dsvm-cells/fc9986a/logs/screen-n-cpu.txt.gz?level=ERROR#_Jan_23_23_16_41_428802 | 13:35 |
| efried | rgerganov I see, and you were trying to add the bogus trait to the child? | 13:35 |
| rgerganov | efried, correct | 13:36 |
| efried | So we invalidated the child, but not the root. | 13:36 |
| rgerganov | yup | 13:36 |
| efried | Okay, it's coming together. | 13:36 |
| rgerganov | could you please tell why my patch won't refresh the tree? | 13:36 |
| efried | rgerganov No I can't. It should. | 13:37 |
| efried | oh | 13:38 |
| *** jpena|lunch is now known as jpena | 13:38 | |
| *** Tom-Tom has quit IRC | 13:39 | |
| *** bhujay has quit IRC | 13:39 | |
| *** alexchadin has joined #openstack-nova | 13:40 | |
| *** Tom-Tom has joined #openstack-nova | 13:40 | |
| *** alexchadin has quit IRC | 13:41 | |
| efried | rgerganov So with your patch, is rps_to_refresh populated at that breakpoint? | 13:42 |
| rgerganov | efried, yes | 13:43 |
| efried | rgerganov And after populate_from_iterable, is the _provider_tree populated properly? | 13:43 |
| rgerganov | it contains both parent and child | 13:43 |
| rgerganov | as far as I can see, yes | 13:44 |
| mvenesio | Hi guys i'm trying to set nova to use SSL for the database connection, i set the mysql connection as well as i set it for the rest of the projects like cinder and glance, but for nova it does not work and i got an OperationalError. Any idea about how to set it right ? | 13:44 |
| efried | mvenesio I think that's a better question for #openstack (see channel topic). | 13:45 |
| efried | rgerganov So if the child is in the cache... where do we run into a problem? | 13:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: flatten images when creating/unshelving an instance https://review.openstack.org/457886 | 13:46 |
| *** pchavva has joined #openstack-nova | 13:46 | |
| *** ragiman has quit IRC | 13:46 | |
| lyarwood | melwitt: https://review.openstack.org/#/c/457886/ ^ I wonder if this is something we could land by the rc | 13:46 |
| *** AlexeyAbashkin has quit IRC | 13:47 | |
| mvenesio | efried: ok i'll do it, thanks | 13:47 |
| rgerganov | efried, the child gets in the cache with my patch and then we don't have a problem (at least not now :) ) | 13:47 |
| *** acormier has quit IRC | 13:47 | |
| *** rcernin has quit IRC | 13:47 | |
| efried | rgerganov I must have misunderstood "could you please tell why my patch won't refresh the tree?" | 13:48 |
| *** acormier has joined #openstack-nova | 13:48 | |
| rgerganov | efried, I asked that because you said "As written, that change will *not* refresh the tree, though" | 13:49 |
| rgerganov | nevermind | 13:49 |
| efried | rgerganov Okay, yeah, I was wrong. I had missed the 'return uuid' part and was misunderstanding my own code :( | 13:50 |
| efried | rgerganov So your solution will work, but it's skipping a nontrivial optimization that I would like to keep if possible. | 13:51 |
| efried | rgerganov One possible alternative would be for that cache invalidation to in fact kill the whole tree. But the implications of that are probably too far-reaching to be practical. | 13:52 |
| *** acormier has quit IRC | 13:52 | |
| efried | rgerganov Other than that patch, do you have any local code on the series? | 13:52 |
| efried | rgerganov In particular, we should definitely commit whatever test case you're running to hit this problem. | 13:53 |
| *** yamamoto has quit IRC | 13:53 | |
| openstackgerrit | Merged openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/482557 | 13:53 |
| efried | rgerganov Though I would like to do it as part of the update_from_provider_tree patch. | 13:53 |
| rgerganov | efried, so basically the test case should be virt driver adding an incorrect trait | 13:54 |
| efried | rgerganov ...to a child | 13:54 |
| *** dtantsur|brb is now known as dtantsur | 13:54 | |
| efried | right? | 13:54 |
| rgerganov | yes | 13:54 |
| efried | rgerganov How close to your EOD are you? | 13:55 |
| rgerganov | efried, I will head out in 2 hours | 13:55 |
| *** mvk has joined #openstack-nova | 13:56 | |
| *** esberglu has joined #openstack-nova | 13:56 | |
| *** esberglu has quit IRC | 13:56 | |
| efried | rgerganov So I've *almost* got this code path in my test_report_client work in progress. | 13:57 |
| *** vladikr has joined #openstack-nova | 13:57 | |
| *** alexchadin has joined #openstack-nova | 13:57 | |
| efried | rgerganov I've got one piece setting a bogus trait on the root. And another setting inventory in a bogus *resource class* on a descendant. The latter of which should *probably* have the same effect. | 13:57 |
| efried | rgerganov But since we've identified this exact issue, it wouldn't go amiss to have a small, isolated test case that's separate from that big one. | 13:58 |
| efried | rgerganov Do you have the time/inclination/know-how to write that test case before you leave? | 13:58 |
| *** eharney has quit IRC | 13:58 | |
| rgerganov | efried, I will give it a try | 13:58 |
| efried | rgerganov Thanks! | 13:59 |
| rgerganov | efried, do you want me to update an existing patch or start a new patch? | 13:59 |
| *** lpetrut_ has joined #openstack-nova | 13:59 | |
| *** markvoelker has joined #openstack-nova | 14:00 | |
| *** weshay|rover is now known as weshay|mtg | 14:00 | |
| *** AlexeyAbashkin has joined #openstack-nova | 14:00 | |
| mriedem | alex_xu: i'm fine with checking the version in the Selection object or just checking if the allocation request is the list or dict format and adjusting properly, up to you, but i think we have to handle both cases in queens, we can then probably remove that check later in rocky | 14:00 |
| artom | mriedem, 'morning - did we figure out if the libvirt connection reset errors were a real bug or not? | 14:02 |
| efried | rgerganov New one. We can always slot it into the series, or squash it into the existing commit. | 14:02 |
| efried | rgerganov And that way I can continue working on these test cases locally in parallel. | 14:02 |
| artom | Also - I think I'm using logstash wrong - http://logstash.openstack.org/#dashboard/file/logstash.json?query=Connection%20reset%20by%20peer is turning up nothing for the past month | 14:03 |
| rgerganov | efried, ok cool | 14:03 |
| bauzas | mriedem: when you said "sneaky" in https://review.openstack.org/#/c/535693/, you meant okay for that or not ? | 14:03 |
| Roamer` | actually, yeah, I've been meaning to ask - is there some documentation on using logstash somewhere? I've seen people compose nice queries, like "a message that looks almost like this in this set of files", but I'd like to know more :) | 14:04 |
| mriedem | artom: message:"Connection reset by peer" AND tags:"screen-n-cpu.txt" | 14:04 |
| mriedem | bauzas: it's ok | 14:04 |
| mriedem | just sneaky | 14:04 |
| Roamer` | ah... that's more or less exactly it | 14:04 |
| artom | mriedem, cheers :) | 14:04 |
| *** jaosorior has quit IRC | 14:05 | |
| mriedem | Roamer`: artom: http://lucene.apache.org/core/4_0_0/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#package_description | 14:05 |
| Roamer` | mriedem, thanks! | 14:05 |
| alex_xu | mriedem: for handle both cases in queens, do you means check both the list or dict and version at sametime? | 14:05 |
| alex_xu | mriedem: for checking version, i have done today, it looks like this https://review.openstack.org/#/c/536083/7/nova/scheduler/client/report.py@1161 | 14:05 |
| mriedem | alex_xu: we do'nt need to check the version and the type, just one or the other | 14:05 |
| Roamer` | mriedem, and thanks again for the +2 yesterday; unfortunately 140733 has had a bad case of "the same spurious totally unrelated test failure showing in a different job on every recheck" all day today :( | 14:06 |
| alex_xu | mriedem: ok, I done that, I choice checking the version | 14:06 |
| *** krtaylor has quit IRC | 14:07 | |
| *** krtaylor has joined #openstack-nova | 14:08 | |
| artom | Hrmm, so it started all of a sudden on Jan 16th | 14:09 |
| artom | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22libvirtError%3A%20Cannot%20recv%20data%3A%20Connection%20reset%20by%20peer%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22 | 14:09 |
| bauzas | I'm around for reviewing | 14:09 |
| bauzas | mriedem: which priority changes should I be doing ? | 14:09 |
| mriedem | artom: keep in mind that logstash only holds 10 days worth of logs, so that's getting close to the cutoff | 14:10 |
| bauzas | nested RPs ? | 14:10 |
| *** yamamoto has joined #openstack-nova | 14:10 | |
| mriedem | bauzas: actually i'd really like to get a few more osc-placement changes merged before we do the first 1.0.0 release this week, | 14:10 |
| mriedem | i've got a +2 on a change here https://review.openstack.org/#/c/505643/ | 14:10 |
| mriedem | and there is an easy cleanup and docs series starting here https://review.openstack.org/#/c/536870/ | 14:10 |
| mriedem | stephenfin: ^ | 14:10 |
| mriedem | this change had a +2 from jaypipes before a rebase https://review.openstack.org/#/c/525505/ | 14:11 |
| stephenfin | mriedem: Sure, I can take a look | 14:11 |
| mriedem | bauzas: and this is an easy libvirt volume driver add https://review.openstack.org/#/c/140733/ | 14:11 |
| stephenfin | Speaking of jaypipes, wonder where he's at. I'd like some eyes on https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1744965 | 14:12 |
| mriedem | "work conference" i was told | 14:12 |
| stephenfin | Vegas it is | 14:12 |
| mriedem | heh maybe | 14:12 |
| bauzas | okay looking | 14:13 |
| *** sapd has joined #openstack-nova | 14:13 | |
| bauzas | FWIW, I'm also in a conference now for the next 3 days | 14:13 |
| bauzas | organizing it, so I have time :p | 14:13 |
| bauzas | http://snowcamp.io | 14:14 |
| *** amoralej|lunch is now known as amoralej | 14:14 | |
| *** lyan has joined #openstack-nova | 14:14 | |
| *** yamahata has joined #openstack-nova | 14:14 | |
| *** links has quit IRC | 14:15 | |
| *** avolkov has quit IRC | 14:15 | |
| mriedem | didn't that ski conference already happen a couple of weeks ago? | 14:16 |
| mriedem | is that a monthly conference? | 14:16 |
| *** hshiina has quit IRC | 14:17 | |
| *** smatzek has quit IRC | 14:17 | |
| *** esberglu has joined #openstack-nova | 14:17 | |
| *** zhurong has quit IRC | 14:18 | |
| artom | mriedem, ah - heh, it's kinda misleading that you can search for a month back though | 14:18 |
| artom | Well, 16th is 8 days | 14:19 |
| artom | Hrmpf | 14:19 |
| mriedem | artom: fwiw, some other stuff start randomly exploding around the 16th too in the ironic multinode grenade job | 14:20 |
| edleafe | alex_xu: commented on https://review.openstack.org/#/c/536083/ | 14:20 |
| mriedem | jroll was investigating that - random segfaults | 14:20 |
| artom | mriedem, ah, interesting | 14:20 |
| edleafe | alex_xu: I am concerned that the change you made could break if placement changes in the future | 14:20 |
| bauzas | mriedem: huh, unfortunately not, only every year ;) | 14:21 |
| bauzas | we need snow | 14:21 |
| stephenfin | mriedem: Done. Only have comments for https://review.openstack.org/#/c/536858/ | 14:22 |
| *** acormier has joined #openstack-nova | 14:23 | |
| mriedem | stephenfin: thanks | 14:24 |
| *** yamahata has quit IRC | 14:24 | |
| alex_xu | edleafe: if we change the allocation_request format in the future, we must do another patch just like 536083. that parameter 'version=allocation_request_version' can't do a magic let us upgrade to the new format | 14:24 |
| alex_xu | edleafe: we can say: the reason for including the allocation_request_version in the selection obj is so that claim_resources can know how to handle alloc_reqs. | 14:25 |
| mriedem | "the reason for including the allocation_request_version in the selection obj is so that claim_resources can know how to handle alloc_reqs." - not exactly, but that is a side effect | 14:26 |
| *** markvoelker has quit IRC | 14:27 | |
| mriedem | since we have client side code that needs to know what format the thing is in | 14:27 |
| *** markvoelker has joined #openstack-nova | 14:27 | |
| mriedem | the point of the version in the selection object, though, is so the client on a reschedule makes the same PUT /allocations request in the version/format that the scheduler initially created the allocation request (from GET /allocation_candidates) | 14:27 |
| *** crushil has joined #openstack-nova | 14:27 | |
| edleafe | alex_xu: if placement is upgraded to a new version that changes the AR format, the way you changed it will force it to be posted to placement as 1.12, which would be wrong | 14:30 |
| mriedem | alex_xu: edleafe: "if we change the allocation_request format in the future" - if that happens, i think we'll have to add an AllocationRequest versioned object to nova to deal with the version differences getting passed over rpc | 14:30 |
| alex_xu | mriedem: edleafe yes, but I don't want to implement the claim_resources method and the sub method to support two version format, that makes the code hard to read, I want to convert the format to consistent in the begining of claim_resources method | 14:30 |
| mriedem | edleafe: if placement is upgraded to a new version, it shouldn't affect the client side code since the client side code is requesting a specific microversion | 14:30 |
| mriedem | which shouldn't change | 14:30 |
| edleafe | mriedem: allocation requests are *supposed* to be opaque | 14:30 |
| edleafe | mriedem: we are violating that here to fix a bug | 14:30 |
| edleafe | Once we are in Rocky, the need for this modification goes away | 14:31 |
| mriedem | i agree once we are in rocky this can go away, | 14:31 |
| mriedem | the modification here is for upgrades | 14:31 |
| edleafe | and all this doubling code can be removed | 14:31 |
| edleafe | I understand | 14:31 |
| alex_xu | edleafe: when placement upgrade, our client won't use the lastest version, we have specified the version in the client https://review.openstack.org/#/c/536083/7/nova/scheduler/client/report.py@338 | 14:32 |
| edleafe | I just don't want all requests to be posted at 1.12 | 14:32 |
| *** jackie-truong has joined #openstack-nova | 14:32 | |
| edleafe | alex_xu: the client should pass the AR and AR_version without inspecting the contents | 14:32 |
| alex_xu | and that is the rule of using micorverion in the client, never use the latest version, and specified a version explicitly | 14:32 |
| mriedem | edleafe: you said, "it would be better if you also modified the allocation_request_version to 1.12 when you modify the allocation_request in the block starting on L1163." - if you change allocation_request_version='1.12' anywhere it's going to post all requests at 1.12 regardless | 14:33 |
| mriedem | we have to inspect the contents in this case | 14:33 |
| *** AlexeyAbashkin has quit IRC | 14:33 | |
| mriedem | and to do that, we need to know what format it's in | 14:33 |
| openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 14:33 |
| edleafe | mriedem: no, that would be inside the 'if' block on L1162, so only <1.12 would be affected | 14:34 |
| mriedem | edleafe: true, like i said in the comment, i'm fine with that | 14:34 |
| mriedem | and i think makes sense | 14:34 |
| edleafe | mriedem: if it's >=1.12, then it won't get changed | 14:34 |
| mriedem | sure i'm ok with that | 14:34 |
| mriedem | alex_xu: ^ want to just make that change? | 14:34 |
| *** lucasagomes is now known as lucas-hungry | 14:35 | |
| alex_xu | mriedem: make the version=allocation_request_version? | 14:35 |
| mriedem | if the version is < 1.12 and you modify ar, then set allocation_request_version='1.12' | 14:35 |
| alex_xu | mriedem: ok, no problem | 14:35 |
| mriedem | and use allocation_request_version as before when claim_resources does it's PUT reuest | 14:35 |
| mriedem | *request | 14:35 |
| *** avolkov has joined #openstack-nova | 14:36 | |
| alex_xu | mriedem: edleafe got the point, will update soon, thanks | 14:36 |
| *** gszasz has joined #openstack-nova | 14:36 | |
| edleafe | alex_xu: thanks | 14:37 |
| edleafe | alex_xu: and don't forget my nit on https://review.openstack.org/#/c/536083/7/nova/scheduler/manager.py@146 while you're at it :) | 14:37 |
| alex_xu | edleafe: yes sir! | 14:38 |
| *** acormier has quit IRC | 14:39 | |
| edleafe | alex_xu: :) | 14:39 |
| mriedem | artom: jroll: one thing i was wondering was if there was a new package version of something in the Pike UCA around 1/16 | 14:39 |
| mriedem | i'm not sure if there is a package change log somewhere for the pike UCA though | 14:39 |
| *** Eran_Kuris has quit IRC | 14:40 | |
| *** crushil has quit IRC | 14:42 | |
| mriedem | coreycb: ^? | 14:42 |
| *** cleong has joined #openstack-nova | 14:42 | |
| coreycb | mriedem: artom: i can check. nova package right? | 14:43 |
| mriedem | coreycb: no, just looking for a changelog for the pike cloud archive | 14:43 |
| mriedem | CI results started going wonky since ~1/16 | 14:44 |
| *** eharney has joined #openstack-nova | 14:44 | |
| mriedem | so wondering about changes to distro packages for things like qemu/libvirt/httpd, et | 14:44 |
| coreycb | mriedem: i don't know if anything is available externally but i can at least check dates internally | 14:44 |
| *** zhaochao has quit IRC | 14:45 | |
| *** Tom-Tom has quit IRC | 14:47 | |
| *** jobewan has joined #openstack-nova | 14:47 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: Add update_from_provider_tree() negative test https://review.openstack.org/537406 | 14:48 |
| rgerganov | efried, ^^^ | 14:48 |
| efried | rgerganov Looking (if gerrit will ever load) | 14:48 |
| coreycb | mriedem: for pike specifically we haven't had anything go into pike-updates since december. it's possible though that something in the base xenial packages changed though. | 14:49 |
| coreycb | mriedem: for base xenial packages you can find dates on Launchpad if you know the package name, ie. https://launchpad.net/ubuntu/+source/apache2 | 14:51 |
| mriedem | ok was trying to find just a global list like in https://wiki.ubuntu.com/XenialXerus/ReleaseNotes/16.04 but no dice | 14:51 |
| *** slaweq has joined #openstack-nova | 14:51 | |
| ameeda | jaypipes: please don't forget to check this https://review.openstack.org/#/c/526900/ for me | 14:52 |
| coreycb | mriedem: yeah unfortunately i don't think there's a list for stable updates | 14:52 |
| mriedem | don't see any changes in 2018 to libvirt or qemu though so it's not that | 14:52 |
| mriedem | thanks anyway | 14:52 |
| mriedem | OH SNAP | 14:53 |
| mriedem | https://launchpad.net/ubuntu/+source/python2.7 | 14:53 |
| mriedem | jroll: ^ | 14:53 |
| mriedem | https://launchpad.net/ubuntu/+source/python2.7/2.7.12-1ubuntu0~16.04.3 | 14:53 |
| mriedem | released 1/18 | 14:54 |
| *** avolkov has quit IRC | 14:54 | |
| *** acormier has joined #openstack-nova | 14:54 | |
| *** markvoelker has quit IRC | 14:55 | |
| mriedem | should compare the versions of the python2.7 package in the failing ironic CI jobs | 14:55 |
| *** slaweq has quit IRC | 14:56 | |
| mriedem | bauzas: thanks for hitting those osc-placement changes | 14:57 |
| *** tbachman_ has joined #openstack-nova | 14:58 | |
| *** markvoelker has joined #openstack-nova | 14:59 | |
| *** awaugama has joined #openstack-nova | 14:59 | |
| *** sridharg has quit IRC | 14:59 | |
| efried | rgerganov So as written, this test will fail? | 14:59 |
| rgerganov | efried, yes | 14:59 |
| *** AlexeyAbashkin has joined #openstack-nova | 15:00 | |
| efried | rgerganov Good deal. If you don't mind, as I work through this today, I think I'm going to incorporate your test and (some version of) your fix into the update_from_provider_tree patch. You'll get co-author credit, of course :) | 15:01 |
| *** edand__ has quit IRC | 15:01 | |
| *** tbachman_ is now known as tbachman | 15:01 | |
| rgerganov | efried, fine with me :) | 15:02 |
| cdent | efried: I tried to do another recheck run through your changes this morning (and some others) but I'm not sure how much impact it had | 15:04 |
| *** acormier has quit IRC | 15:05 | |
| efried | cdent Seen and appreciated sir. Silver lining: it takes *some* of the pressure off getting the top of the series perfect. | 15:05 |
| *** acormier has joined #openstack-nova | 15:06 | |
| efried | At this rate, even things +W'd by FF will take a week to merge. | 15:06 |
| *** kwathore has quit IRC | 15:07 | |
| *** slaweq has joined #openstack-nova | 15:07 | |
| *** Nil_ has joined #openstack-nova | 15:08 | |
| *** kwathore has joined #openstack-nova | 15:08 | |
| *** felipemonteiro has joined #openstack-nova | 15:08 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: using the dict format for the allocation in claim_resources https://review.openstack.org/536083 | 15:09 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 15:09 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Fix nits in support traits on allocation candidates API https://review.openstack.org/537351 | 15:09 |
| *** amodi has joined #openstack-nova | 15:09 | |
| alex_xu | edleafe: mriedem stephenfin, thanks for the review, ^ addressed all the comments | 15:09 |
| *** felipemonteiro_ has joined #openstack-nova | 15:10 | |
| *** yangyapeng has quit IRC | 15:11 | |
| *** avolkov has joined #openstack-nova | 15:11 | |
| *** armax has joined #openstack-nova | 15:11 | |
| edleafe | alex_xu: thanks - will review soon | 15:11 |
| alex_xu | edleafe: thanks | 15:12 |
| *** yangyapeng has joined #openstack-nova | 15:12 | |
| mriedem | alex_xu: were you going to put up a patch for the placement api-ref docs changes? https://github.com/openstack/nova/blob/master/placement-api-ref/source/allocation_candidates.inc#L27 | 15:12 |
| efried | cdent mriedem Sorry for not understanding how placement version lockstepping works; are we now ready to address these comments? https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L902-L904 https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1117-L1119 | 15:13 |
| *** smatzek has joined #openstack-nova | 15:13 | |
| *** rgerganov has quit IRC | 15:13 | |
| cdent | efried: https://review.openstack.org/#/c/528794/ | 15:13 |
| *** felipemonteiro has quit IRC | 15:13 | |
| cdent | that may be out of date by now, since it's been sitting there for quite a while | 15:14 |
| efried | cdent Thanks, at least it's on the radar. | 15:14 |
| * efried adds self | 15:14 | |
| mriedem | efried: yeah we require >=1.14 now really, or that's what nova-status is checking for and the compute requires for root providers, | 15:15 |
| mriedem | efried: but at this point might as well hold that off until rocky - the cleanup i mean | 15:15 |
| mriedem | dansmith: that reminds me - we havent bumped major compute rpc api versions in a few years; that's historically something you've been the master of, are you interested in doing one of those, since i think it has to happen shortly before RC1 yeah? | 15:16 |
| *** itlinux has quit IRC | 15:16 | |
| mriedem | we have a lot of "drop this compat code when we bump major versions" | 15:16 |
| *** gszasz has quit IRC | 15:16 | |
| efried | okay. I must also not have a good handle on what kind of patch will be accepted after FF. This isn't a feature, so...? | 15:17 |
| *** yangyapeng has quit IRC | 15:17 | |
| *** lucas-hungry is now known as lucas-brb | 15:17 | |
| dansmith | mriedem: yeah I should probably do that | 15:17 |
| *** itlinux has joined #openstack-nova | 15:18 | |
| *** edand__ has joined #openstack-nova | 15:19 | |
| *** alexchadin has quit IRC | 15:19 | |
| mriedem | Roamer`: looking at the latest cells job failure on your patch http://logs.openstack.org/33/140733/19/check/legacy-tempest-dsvm-cells/3e2f79f/ | 15:20 |
| mriedem | it's timing out waiting for a volume backup to complete, | 15:20 |
| mriedem | looking at the node it's running on: http://logs.openstack.org/33/140733/19/check/legacy-tempest-dsvm-cells/3e2f79f/zuul-info/inventory.yaml | 15:20 |
| mriedem | provider: rax-dfw | 15:20 |
| mriedem | those have been really really slow since the intel kernel patcharoo | 15:20 |
| *** dave-mccowan has quit IRC | 15:22 | |
| openstackgerrit | Merged openstack/osc-placement master: CLI for aggregates (v1.1) https://review.openstack.org/505643 | 15:22 |
| *** stvnoyes has left #openstack-nova | 15:23 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'NUMATopologyLimits.obj_from_db_obj' https://review.openstack.org/537412 | 15:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_to_dict' functions https://review.openstack.org/537413 | 15:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.openstack.org/537414 | 15:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | 15:23 |
| -openstackstatus- NOTICE: gerrit has been suffering from a full disk, some mails may have been lost in the last couple of hours. we will now restart gerrit to address ongoing slowness, too | 15:24 | |
| *** tidwellr has joined #openstack-nova | 15:26 | |
| *** slaweq has quit IRC | 15:26 | |
| edmondsw_ | gibi here's your requested daily reminder to look at https://review.openstack.org/#/c/526094/ if you get a chance :) | 15:27 |
| *** bhujay has joined #openstack-nova | 15:28 | |
| *** mvenesio has quit IRC | 15:29 | |
| *** Guest28399 is now known as mgagne | 15:33 | |
| *** mgagne has joined #openstack-nova | 15:33 | |
| gibi | edmondsw_: thanks :) | 15:33 |
| efried | cdent edleafe Not loving the fact that DELETE RP inventory returns 204 and the client code is assuming the RP generation can just be incremented by one. | 15:34 |
| *** edmondsw_ is now known as edmondsw | 15:34 | |
| cdent | if you've deleted an RP why would you need to know it's generation? | 15:34 |
| cdent | it's gone | 15:34 |
| openstackgerrit | Merged openstack/osc-placement master: Add missing runtime requirements https://review.openstack.org/536870 | 15:34 |
| *** hongbin has joined #openstack-nova | 15:34 | |
| efried | cdent Deleted its inventory, not the RP itself. | 15:35 |
| edleafe | efried: what would you love more? | 15:35 |
| cdent | then GET the /rp/{uuid}, that's what it's there for | 15:35 |
| cdent | this notion that it is bad to make requests is unproven. just make requests | 15:36 |
| efried | edleafe Either DELETE returns a payload, which would look like { 'resource_provider_generation': N, 'inventories': {} }, or we always use PUT with {} | 15:36 |
| efried | ...which does that | 15:36 |
| efried | cdent It's not quite that simple. | 15:37 |
| openstackgerrit | Merged openstack/osc-placement master: Address comments from original inventory patch https://review.openstack.org/521578 | 15:37 |
| efried | cdent The point of getting the generation in the response is that I know it's the generation right after the inventory was deleted. | 15:37 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Usage docs and initial release note for osc-placement https://review.openstack.org/536858 | 15:37 |
| mriedem | stephenfin: done ^ | 15:37 |
| cdent | If you are depenendent on that, you're not rally making a very resilient system? | 15:37 |
| efried | cdent Whereas if I do a subsequent GET, I don't know if an intervening operation incremented the generation as well. | 15:37 |
| cdent | yes that's _always_ the case | 15:37 |
| cdent | whether you did the the GET or not | 15:38 |
| efried | cdent No, not when I get the generation in the response. | 15:38 |
| cdent | you have no idea, ever, what any other client or thread might be doing with the same resource provider | 15:38 |
| Roamer` | mriedem, yes, I saw it was rax-dfw on the previous runs, too, that's why I haven't complained to -infra (I guessed somebody else with more authority would complain again sooner or later), but thanks for raising it in -infra right now | 15:38 |
| cdent | when you get the generation in the response, something else, immediately, might have changed it | 15:38 |
| cdent | that's always true | 15:38 |
| cdent | what ever mechanism you are using to track generations | 15:38 |
| efried | cdent Yes, but I don't need to care about that until the next time I go to update something. | 15:38 |
| cdent | which should always be the case | 15:39 |
| cdent | you should always be prepared to get a 409 | 15:39 |
| cdent | and act accordingly | 15:39 |
| edleafe | gotta agree - I don't see what getting the generation in the response buys you | 15:39 |
| efried | I need to be able to get a 409 reliably, though. | 15:39 |
| efried | Look look. | 15:39 |
| cdent | the generation should be utterly meaningless | 15:39 |
| cdent | sorry, I gotta go fetch the cat, will catch up in 30' | 15:40 |
| efried | That's exactly why I shouldn't be assuming it gets incremented by 1 | 15:40 |
| efried | (the meaningless thing, not the cat thing) | 15:40 |
| *** itlinux has quit IRC | 15:40 | |
| edleafe | if the delete succeeds, then it will be incremented by 1. You can certainly assume that | 15:40 |
| mriedem | Roamer`: see -cinder | 15:40 |
| Roamer` | mriedem, yes, looking | 15:40 |
| efried | edleafe No way. | 15:40 |
| Roamer` | I mean watching | 15:40 |
| mriedem | looks like cinder made a change in the last 24 hours that is slowing down volume backup | 15:40 |
| edleafe | What you can't assume is that the next time you do something, it won't have been changed by something else | 15:41 |
| efried | edleafe That's not part of the contract. It just happens to be the way placement is implemented. | 15:41 |
| efried | This is exactly my point | 15:41 |
| Roamer` | mriedem, ah, you even figured out which one! I just mentioned it a couple of times there, but it seemed nobody was awake yet... | 15:41 |
| *** bhujay has quit IRC | 15:41 | |
| efried | It is crucial that the generation I have in my local cache matches the data I have in my local cache. | 15:41 |
| edleafe | efried: do you mean if generation was a hash of the current state, you wouldn't be able to make any assumption? | 15:42 |
| efried | edleafe Or any other implementation that's not a monotonically increasing integer. | 15:42 |
| efried | edleafe I mean that the format of the generation is not part of the API contract at all, and the client side should be assuming absolutely nothing about it. | 15:42 |
| edleafe | So what would getting the generation buy you? It *still* could have been changed by the time you go to use it | 15:43 |
| efried | Yes, in which case I will legitimately get a 409 and need to refresh/redrive my change. That's the good path. | 15:43 |
| efried | The bad path is this: | 15:43 |
| *** mlavalle has joined #openstack-nova | 15:44 | |
| edleafe | efried: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/schemas/inventory.py#L20-L25 | 15:45 |
| efried | I have generation 5. I do my DELETE. Then you do a GET (so you have generation 5) and a PUT to create some inventory. You're now at gen 6. Now I do my GET as cdent suggested and find out the gen is 6. So I think gen 6 corresponds with empty inventory when in fact it does not. Now I decide to add some inventory back. I do a PUT with that new inventory and gen 6, which will *succeed* because the server has gen 6. But | 15:45 |
| efried | I just blew away your inventory update. | 15:45 |
| mriedem | Roamer`: https://bugs.launchpad.net/cinder/+bug/1745168 for rechecks i guess | 15:46 |
| openstack | Launchpad bug 1745168 in Cinder "volume backup tests timing out since 1/23" [Undecided,New] | 15:46 |
| mriedem | melwitt: dansmith: et al ^ if you see gate timeouts | 15:46 |
| dansmith | ack | 15:46 |
| *** dave-mccowan has joined #openstack-nova | 15:46 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/485553 | 15:47 |
| efried | edleafe Great, it's defined as an integer, in the schema, for the current microversion. There's still nothing in the contract that tells me it's monotonically increasing starting from zero. | 15:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology https://review.openstack.org/485554 | 15:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology https://review.openstack.org/466030 | 15:47 |
| edleafe | efried: "Then you do a GET (so you have generation 5)" - that's not correct. You'd get 6 in that case, since the DELETE succeeded | 15:47 |
| Roamer` | mriedem, thanks, I'll use it if needed... let's hope it's not needed much longer, because there's not much time left till... what, tomorrow? :) | 15:48 |
| efried | edleafe Sorry, right, add 1 to all the gen numbers after the first one. | 15:48 |
| efried | edleafe Or whatever. The logic is the same. | 15:48 |
| mriedem | Roamer`: eod tomorrow yeah | 15:48 |
| edleafe | efried: so you'd think you're at 6, but meanwhile someone did an update to move it to 7. You then PUT the inventory at 6 (since you don't know it's been changed), and get a 409 | 15:48 |
| edleafe | Nothing blown away | 15:49 |
| Roamer` | mriedem, aaaaand if failed again.... and I can't do a recheck before it finishes failing... | 15:49 |
| efried | edleafe No, I don't think I'm at 6 unless I assume the generation increments by 1 | 15:49 |
| efried | edleafe I'll think I'm at 7 because I did my GET (to discover the "correct" generation) after you did your PUT. | 15:49 |
| dansmith | bauzas: are you around today to address my minor comments here? https://review.openstack.org/#/c/535693/5 | 15:49 |
| dansmith | bauzas: if not I can do it, but I'd like to retain my impartiality to be able to vote on it :) | 15:49 |
| edleafe | efried: Huh? I thought you said "Then you do a GET" after the delete | 15:50 |
| mriedem | Roamer`: i'll recheck it throughout the day | 15:50 |
| edleafe | Where are you assuming anything | 15:50 |
| edleafe | ? | 15:50 |
| *** mriedem has quit IRC | 15:50 | |
| *** david-lyle has joined #openstack-nova | 15:50 | |
| efried | edleafe Just so. | 15:50 |
| Roamer` | mriedem, so yeah, I'll keep on rechecking... oh? You will? Thanks a lot! (again... it seems that I'm thanking you on every other line...) | 15:50 |
| *** bhujay has joined #openstack-nova | 15:51 | |
| efried | edleafe If I'm not assuming the generation increments by 1, and I have to do a GET to discover what the generation is after I do my DELETE, that's broken. | 15:51 |
| *** mriedem has joined #openstack-nova | 15:51 | |
| edleafe | efried: I still don't see the issue | 15:51 |
| *** gszasz has joined #openstack-nova | 15:51 | |
| efried | Here it is again with the correct generations: | 15:52 |
| edleafe | efried: you can make the assumption, and if something else changes it, you get a 409 and *then* do the GET to see what the current state is | 15:52 |
| efried | I have generation 5. I do my DELETE. Server has gen 6, I have gen 5 still. Then you do a GET (so you have generation 6) and a PUT to create some inventory. You and server are now at gen 7. Now I do my GET and find out the gen is 7. So I think gen 7 corresponds with empty inventory when in fact it does not. Now I decide to add some inventory back. I do a PUT with that new inventory and gen 7, which will *succeed* bec | 15:52 |
| efried | ause the server has gen 7. But I just blew away your inventory update. | 15:52 |
| efried | edleafe Perhaps the disconnect is where I'm doing that GET to discover the generation. At that point I'm only doing a GET /resource_provider/{uuid} - I really *don't* want to go getting its traits, aggs, and inventories as well. | 15:53 |
| edleafe | efried: if you do a GET and ignore that there is now inventory and then proceed to blow it away, that's not placement's fault | 15:53 |
| *** yangyapeng has joined #openstack-nova | 15:53 | |
| efried | Then there's no point having a cache. | 15:54 |
| efried | We have this cache that we're using successfully for most of the operations, but if we run any DELETE API, we have to blow it away and start over? That seems not okay. | 15:54 |
| edleafe | efried: especially if you have two different systems claiming to be authoritative on what the inventory for an RP is | 15:54 |
| *** jose-phillips has quit IRC | 15:54 | |
| *** jose-phi_ has joined #openstack-nova | 15:55 | |
| efried | That's the entire reason we have this generation business in the first place. To manage sync issues when more than one thread claims authority over a provider. | 15:55 |
| efried | And I'm not saying it's placement's fault that this happens. It's a matter of cache management by the client. Which IMO we're not doing correctly in this scenario. | 15:56 |
| edleafe | efried: yes, but it is to prevent *accidental* conflicts. If you know you have a conflict and proceed ahead anyway, there isn't a system that will make that OK | 15:56 |
| efried | But I don't know I have a conflict. | 15:57 |
| efried | Put another way, a client shouldn't use DELETE for inventories (or traits or aggs if it comes to that) if there's no response containing the generation. | 15:57 |
| edleafe | efried: your cache has RP, generation, and inventory. You go to update that and get a 409. It is now important that you invalidate the cache before you proceed | 15:57 |
| efried | I don't get a 409. That's the crux of the problem. | 15:58 |
| edleafe | efried: you don't do the GET *before* trying to update | 15:58 |
| efried | How else do I discover the "new" generation? | 15:59 |
| efried | (the one I think is post-DELETE, but which is in fact post-my-DELETE-and-your-PUT) | 15:59 |
| edleafe | You update based on what the cache says. If the cache is current, the generation it has will work. If something else has changed in placement, you invalidate the cache, and do a GET to refresh it | 15:59 |
| efried | and how do I know "something else has changed in placement"? | 15:59 |
| edleafe | that's where the assumption that after the delete, the generation is original gen + 1 | 16:00 |
| efried | Right. Which works, today, because we're dirtily exploiting what we know to be the internals of the placement service. | 16:00 |
| edleafe | "dirtily" - heh | 16:01 |
| edleafe | it's documented | 16:01 |
| edleafe | Give me a second to write up the flow as I understand it. | 16:01 |
| efried | edleafe Where is it documented? | 16:01 |
| *** bhujay has quit IRC | 16:02 | |
| efried | edleafe In the API ref, all we get is: "A consistent view marker that assists with the management of concurrent resource provider updates." and "409 Conflict if the resource_provider_generation doesn’t match with the server side." <== note "match" | 16:04 |
| efried | And it's not mentioned in the overview doc (https://docs.openstack.org/nova/latest/user/placement.html) at all | 16:05 |
| *** bhujay has joined #openstack-nova | 16:05 | |
| *** AlexeyAbashkin has quit IRC | 16:05 | |
| edleafe | efried: I'll have to do some doc digging, but I'm sure it's there | 16:05 |
| edleafe | efried: here's the flow I see for your inventory delete/update: | 16:06 |
| edleafe | You have a cached RP with generation 5. You call DELETE for the inventory, and it succeeds. You now update your cache with generation 6, and no inventory. | 16:06 |
| edleafe | You now want to PUT some inventory. So you send the PUT with the data and generation 6. Something else has changed the RP in the meantime, so your PUT returns 409. At that point, your cache is not accurate. You don't know what has changed, so you get rid of anything for that RP, and call GET with the rp_uuid to refresh everything in your cache for that RP. You then compare the inventory you | 16:06 |
| edleafe | expected with what is there (which you would have done before the original PUT), and if it is still correct to update inventory, you re-PUT the inventory with the new generation. Rinse and repeat. | 16:06 |
| efried | edleafe That's a good flow, but it's not the one I described. | 16:06 |
| *** bhujay has quit IRC | 16:07 | |
| efried | edleafe But before we go on, how does "You now update your cache with generation 6" happen? | 16:07 |
| *** bhujay has joined #openstack-nova | 16:07 | |
| edleafe | that was the assume that if your DELETE succeeds at gen5, it is now at gen6 | 16:07 |
| efried | Assuming gen+1? | 16:07 |
| melwitt | mriedem: ack | 16:08 |
| edleafe | efried: yes. | 16:08 |
| efried | Okay, then I agree it works, but is illegal API consumption. Because the API doesn't tell us we can assuming monotonically increasing generation counter per operation. | 16:08 |
| *** bhujay has quit IRC | 16:09 | |
| edleafe | efried: if it doesn't, then that's a doc bug | 16:09 |
| *** bhujay has joined #openstack-nova | 16:09 | |
| efried | This is how we do it today. Which is (part of) the reason we don't have a "bug" per se. (The other part is that we don't actually have any paths that do concurrent updates yet.) | 16:09 |
| efried | edleafe I don't agree with that. | 16:10 |
| edleafe | efried: let's get jaypipes and cdent to weigh in on this | 16:11 |
| efried | edleafe But maybe. We should find out what Jay thinks. If we add words to those DELETE 204s along the lines of, "You may now assume the resource provider generation has been incremented by 1," I'll stfu. | 16:11 |
| efried | yeah, what you said. | 16:11 |
| edleafe | I think we understand each other, and are not in agreement | 16:11 |
| efried | Does dansmith have skin in this game? | 16:12 |
| dansmith | um | 16:12 |
| edleafe | I think dansmith is pretty busy with other things :) | 16:12 |
| efried | k | 16:12 |
| edleafe | efried: the assumption is that after anything that modifies anything about a RP, the generation is +1 from what it was | 16:13 |
| edleafe | not just DELETE | 16:13 |
| dansmith | client-side ever predicting the generation is wrong | 16:14 |
| dansmith | you would never do gen+=1 locally | 16:14 |
| efried | ++ | 16:14 |
| dansmith | you have no idea if your generation 6 is the same as the server side | 16:14 |
| efried | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L927 | 16:14 |
| dansmith | you think so because you posted with 5 and it succeeded, but you don't know | 16:14 |
| edleafe | dansmith: which is why you always need to expect a 409 | 16:15 |
| edleafe | otherwise, what's the point of caching anything? | 16:16 |
| efried | Which is actually another good point. DELETE /rp/{u}/inventories doesn't accept a generation (because doesn't accept a payload). | 16:16 |
| *** lpetrut_ has quit IRC | 16:17 | |
| edleafe | efried: ah, now *that's* a problem | 16:17 |
| *** jobewan has quit IRC | 16:17 | |
| efried | Here's the other place we're making assumptions: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L552 -- that a newly-created provider has gen 0. | 16:19 |
| efried | Because the POST /resource_providers responds 201 with no content. | 16:20 |
| edleafe | efried: that's the same assumption as earlier. generation starts at 0, and each change increases it by one | 16:21 |
| edleafe | if you just created it, it's at zero | 16:21 |
| efried | edleafe Right. Which isn't a good assumption, unless it's a documented part of the API, which today it ain't. | 16:22 |
| *** slaweq has joined #openstack-nova | 16:22 | |
| edleafe | It's sounding more and more like a doc bug | 16:22 |
| efried | If in fact we want it to be part of the API. Which I'm not convinced of. | 16:23 |
| *** lucas-brb is now known as lucasagomes | 16:23 | |
| *** tidwellr_ has joined #openstack-nova | 16:27 | |
| *** tidwellr has quit IRC | 16:27 | |
| *** slaweq has quit IRC | 16:27 | |
| efried | I'm gonna say we definitely have a doc shortage with respect to how to *use* the generation in any case. Other than that one spot in the API ref, there's not even anything that tells you you're supposed to send down the same generation you GET. | 16:29 |
| *** felipemonteiro_ has quit IRC | 16:33 | |
| *** felipemonteiro_ has joined #openstack-nova | 16:34 | |
| cdent | efried, edleafe: I definitely agree (with dansmith) that _in the presence of the provider tree caching mechanism_ we should never gen += 1 on the client side. Instead we should always be prepared to invalidate the _entire_ cache when a 409 happens. This is the reason for creating the PlacementAPIConflict base class: so any gen conflict can cause a complete reset. | 16:35 |
| *** pcaruana has quit IRC | 16:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: CLI for resource classes (v1.2) https://review.openstack.org/511182 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: RP delete inventories (v1.5) https://review.openstack.org/514642 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: CLI for traits (v1.6) https://review.openstack.org/514643 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Resource class set (v1.7) https://review.openstack.org/514644 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647 | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: [WIP] Get resource provider by uuid or name https://review.openstack.org/527791 | 16:35 |
| jackie-truong | mriedem: During the 1/4 meeting, you said that you weren't sure who should be reviewing the certificate validation feature and that you expect a lot of blueprints to get deferred. jaypipes has been reviewing the patch series since that meeting, but seems to be out this week. Do you think it's reasonable to try to get this patch series through before the feature freeze? | 16:36 |
| efried | cdent No arguments there. | 16:36 |
| efried | In the scenario at hand, we don't get a 409, even though we should. | 16:36 |
| cdent | efried, edleafe; Another option is for the provider tree to do a full reset after any finished operation | 16:36 |
| edleafe | cdent: so the cache will *always* be invalid, as we will never have agreement with the rp's data and its generation | 16:36 |
| mriedem | jackie-truong: i'm not going to be able to context switch to an entirely new thing the day before FF | 16:36 |
| cdent | edleafe: yeah, which is why I've always wondered why we have a cache? | 16:36 |
| edleafe | cdnet: jinx-ish | 16:36 |
| efried | cdent At some point you started work on the "updating generation when aggregates changed" - where is that? | 16:37 |
| edleafe | cdent, not cdnet | 16:37 |
| efried | cdent I thought you started writing a spec, but it must not have been in nova-specs. | 16:37 |
| mriedem | jackie-truong: unfortunately it's probably going to get deferred to rocky | 16:37 |
| *** fanzhang has quit IRC | 16:37 | |
| *** fanzhang has joined #openstack-nova | 16:37 | |
| cdent | efried: the scenario at hand is using logic that pre-dates the provider tree and was an acknowledged hack that was deemed safe-ish in the world of _not_ nested | 16:37 |
| mriedem | jackie-truong: i'd like it if we could do some version of the 'slots' or 'runways' concept so these blueprints that keep getting deferred from release to release actually become a review priority early in the next cycle before we take on new work | 16:38 |
| cdent | efried: mriedem told me that wasn't going to get considered until rocky, so I lowered it off my priority list in favor of rechecking lots of things over and over | 16:38 |
| cdent | that == aggregates with generations | 16:38 |
| mriedem | especially before the people grinding that contribution don't burn out and move on | 16:38 |
| *** janki has joined #openstack-nova | 16:38 | |
| jackie-truong | mriedem: Yeah, that'd be nice | 16:38 |
| efried | cdent Okay, did you not already start writing words about it, though? | 16:38 |
| mriedem | jackie-truong: i'll add something to the dublin ptg agenda for discussion | 16:39 |
| jackie-truong | mriedem: If I can find jaypipes, I'll see if he has any time to look at the patches. Otherwise, I'll plan to wait for rocky | 16:39 |
| *** janki has quit IRC | 16:39 | |
| efried | cdent I think we need a launchpad-something (bug? blueprint?) for that. | 16:39 |
| *** janki has joined #openstack-nova | 16:39 | |
| efried | cdent And I want to point to it from the bug I'm opening now, titled "Placement client cache consistency is broken" | 16:40 |
| cdent | efried: https://blueprints.launchpad.net/nova/+spec/placement-aggregate-generation | 16:40 |
| edleafe | cdent: did you see my comments starting here? http://p.anticdent.org/4liQ | 16:40 |
| *** slaweq has joined #openstack-nova | 16:40 | |
| edleafe | That's my understanding how caching was supposed to work with generations | 16:40 |
| cdent | efried: I hope you'll revise that to say ProviderTree cache consistency, not Placement. Placement is fine. | 16:40 |
| cdent | edleafe: looking. I tried to read the whole backlog but am way sick, so faking having a brain | 16:41 |
| efried | cdent "Placement client" not "Placement". | 16:41 |
| cdent | it's not even a placement client, it's the provider tree | 16:41 |
| cdent | which uses a placement client | 16:41 |
| edleafe | cdent: so IOW, normal for you :-P | 16:41 |
| cdent | edleafe: yes | 16:41 |
| cdent | if the day of the week ending in 'y': chris sick | 16:41 |
| efried | p'tayta p'tata, but okay. | 16:42 |
| mriedem | jackie-truong: L102 https://etherpad.openstack.org/p/nova-ptg-rocky | 16:42 |
| efried | Any placement client wishing to use a cache is broken | 16:42 |
| cdent | I disagree | 16:43 |
| cdent | Any placement client wishing to use a unified cache is broken | 16:43 |
| cdent | I dispute the need for a cache | 16:43 |
| mriedem | gibi: have time to go over this again before your eod? https://review.openstack.org/#/c/536083/ | 16:43 |
| jackie-truong | mriedem: Awesome. Thanks for adding that | 16:44 |
| cdent | efried: but it is the road we went down | 16:44 |
| cdent | and I think we can make it work | 16:44 |
| cdent | the things edleafe says at [l 4liQ] seem sane | 16:44 |
| purplerbot | http://p.anticdent.org/4liQ | 16:44 |
| efried | cdent That part has never been under dispute. | 16:45 |
| edleafe | cdent: we seem to have an underwhelming amount of docs about using the generation | 16:45 |
| cdent | I don't doubt that | 16:45 |
| cdent | efried: which part is "that part"? | 16:45 |
| efried | Where we should get a 409 if we PUT something with a generation that's not the latest. | 16:46 |
| cdent | the problems that seem possible from edleafe's flow is that appears to assume a granularity of interaction that it's not clear if the provider tree enables? | 16:47 |
| edleafe | cdent: re: generation doc amount: https://www.youtube.com/watch?v=Ydpablsm7f0 | 16:47 |
| *** slaweq has quit IRC | 16:48 | |
| efried | cdent I didn't follow that. | 16:48 |
| * cdent loves me some EC | 16:48 | |
| *** yamamoto has quit IRC | 16:49 | |
| cdent | What is it that we want/need the generation docs to say? | 16:50 |
| *** damien_r has quit IRC | 16:50 | |
| efried | cdent Certainly they need to say, "You need to include whatever generation came in your GET when you do your PUT. If something else updated the provider in between your GET and your PUT, you'll get a 409." | 16:51 |
| efried | cdent One part of the doc says sort of the second half of that, for one API. | 16:51 |
| edleafe | Basically that it is a monotonically-increasing integer, and is increased with each modification of an RP | 16:51 |
| cdent | do we _want_ people to know it is monotonic? | 16:51 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Address review comments from allocations patch https://review.openstack.org/536871 | 16:51 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Usage docs and initial release note for osc-placement https://review.openstack.org/536858 | 16:51 |
| cdent | that point seems to not have agreeement | 16:52 |
| mriedem | stephenfin: ok updated the docs one more time to fix a link and to include the resource class stuff which is approved ^ | 16:52 |
| efried | cdent Beyond that, they *either* need to say, "We start at zero and increment by 1 whenever something changes about the provider," *or*, "You can't count on how we deal with the generation; it's an opaque value that you need to turn around and send back to us." | 16:52 |
| efried | cdent Yes, I agree that point does not have agreement. | 16:52 |
| efried | If we document the former, then the code as it sits is (almost) okay. | 16:53 |
| cdent | efried why would we want to say the first point above? I think of it as the second. | 16:53 |
| efried | cdent I'm with you. | 16:53 |
| efried | edleafe is on the other side. | 16:53 |
| efried | We don't know what jaypipes thinks | 16:53 |
| cdent | I think edleafe is being pragmatic, more than anything? edleafe ? | 16:53 |
| efried | And I *think* dansmith is also on the "opaque" side. | 16:53 |
| edleafe | if our code makes that assumption, we should document that | 16:53 |
| efried | whoah, we should document something about the API because of something our client code assumes? That's cray-cray. | 16:54 |
| dansmith | efried: yes | 16:54 |
| dansmith | efried: in fact, we could use some random sequence of numbers if we had one and that should be fine. or a uuid. "here is my proof that I'm making a change to the most recent copy" is all we should assume from the client side about the meaning of the generation field, IMHO | 16:55 |
| efried | I'd be willing to bet the client assumptions were made out of expediency to get function merged. At the time it didn't matter because a) single point of control, b) no nested, c) no traits/aggs to complicate. | 16:55 |
| edleafe | efried: the code uses it because it was understood to be the case. If it is going to be the case, it should be documented. If it isn't, the code that assumes that should change | 16:55 |
| efried | dansmith ++ | 16:55 |
| efried | edleafe ++ | 16:55 |
| cdent | efried: yes, expediency is what I said above | 16:55 |
| cdent | generation are ints because jay likes ints in databases | 16:56 |
| edleafe | We went with a monotonic integer scheme, even though there were better options available. I don't recall why it won out | 16:56 |
| cdent | but that they are ints is incidental | 16:56 |
| efried | So we need to make a call. Course, Jay should be included in the "vote" (if it's a democracy in the first place). | 16:56 |
| * edleafe thinks that assumption is cute | 16:57 | |
| efried | "opaque" will require some nontrivial redesign and rework | 16:57 |
| cdent | Is the call as narrow as "should we += 1 in the client" or something more broad than that? | 16:57 |
| efried | cdent The call is, do we document +1 behavior or do we document opacity. What flows from the former is fairly narrow. What flows from the latter is broad. | 16:58 |
| *** gyee has joined #openstack-nova | 16:59 | |
| efried | And not to distract, but we still definitely have a problem with DELETE not sending a generation down, no matter which way we decide to go. | 16:59 |
| dansmith | efried: I'm not sure we fully have a problem with delete | 17:00 |
| dansmith | efried: I should be able to delete allocations without a generation without being in violation of anything | 17:00 |
| dansmith | because I know the thing I'm deleting for is never coming back | 17:00 |
| dansmith | what else do we delete for? inventory maybe, but I bet the same argument works for that | 17:00 |
| cdent | efried: I think we can continue to fake on +1 in the ProviderTree if that's what we need to do, and _not_ document it. Other (to be developed) clients won't need to care and should respond to documentation that says what it already says "A consistent view marker" | 17:01 |
| efried | dansmith Inventory, yeah, and agree it's the same argument. | 17:01 |
| dansmith | efried: same argument, but you think we _do_ need a generation on delete right? | 17:02 |
| efried | dansmith Considering the multiple-points-of-control thing, if I think I'm ready to delete the RP's inventory, but you think you're happily editing it... | 17:02 |
| dansmith | efried: but inventory is and should only be managed by the thing owning the inventory | 17:03 |
| *** gszasz has quit IRC | 17:03 | |
| efried | dansmith If that's the case, we don't need generations at all. | 17:03 |
| dansmith | efried: I guess the only case that we might hit would be: | 17:03 |
| efried | dansmith I think the problem comes in when deleting the whole inventory is actually a result of "I want to remove inventory in this resource class, but that happens to be the last resource class". | 17:03 |
| dansmith | efried: I'm going to _allocate_ against a RP, right when the RP is deleting the inventory | 17:03 |
| efried | dansmith I think yours is okay. The DELETE will bounce if the allocations happened first; and the allocations will bounce if the DELETE happened first. | 17:04 |
| *** dhellmann has joined #openstack-nova | 17:05 | |
| *** jackie-truong has quit IRC | 17:05 | |
| dhellmann | sdague : are you interested in this testing patch for the nova doc redirects? https://review.openstack.org/#/c/516385/ | 17:05 |
| efried | dansmith But for mine: let's say for whatever reason two threads own inventory in different resource classes on the same RP. Thread A decides there's no longer any CUSTOM_FOO, so he goes to remove all the CUSTOM_FOO. He does a GET and sees that the inventory comprises *only* CUSTOM_FOO, so he gets ready to do a DELETE. | 17:05 |
| *** yamamoto has joined #openstack-nova | 17:05 | |
| cdent | efried: I thought the point of the provider tree itself was to lock over that kind of operation? | 17:06 |
| cdent | the tree can only be manipulated by one thread at a time | 17:06 |
| efried | dansmith Meanwhile, thread B decides it's time to add some CUSTOM_BAR. He does his GET, sees some CUSTOM_FOO in there, adds his CUSTOM_BAR, and PUTs the whole shebang back. Now on the server, there's CUSTOM_FOO and CUSTOM_BAR. | 17:06 |
| dansmith | efried: but nothing other than the thing that owns the inventory should collapse a PUT to a DELETE because it thinks it's the last thing, right? | 17:06 |
| dansmith | efried: and the PUT in your case would have included a generation which is wrong now because the DELETE bumped it, no? | 17:07 |
| *** yamamoto has quit IRC | 17:07 | |
| *** yamamoto has joined #openstack-nova | 17:07 | |
| *** yamamoto has quit IRC | 17:07 | |
| efried | No, because the PUT happens first. | 17:07 |
| efried | That's the point. | 17:07 |
| dansmith | no I meant the second case | 17:07 |
| dansmith | in the first case, the non-owner is collapsing a PUT to a DELETE which isn't legit It hink | 17:08 |
| cdent | efried: is [t 1zzs] not true? | 17:08 |
| purplerbot | <cdent> the tree can only be manipulated by one thread at a time [2018-01-24 17:06:26.123234] [n 1zzs] | 17:08 |
| dansmith | cdent: it doesn't matter, | 17:08 |
| efried | dansmith I don't disagree. But that's what the code is doing today. | 17:08 |
| dansmith | there could be multiple trees on multiple hosts I think is his point | 17:08 |
| dansmith | efried: I'm saying that's probably wrong, for the non-owner | 17:09 |
| cdent | dansmith: I though we were concluding that the compute node owns the inventory | 17:09 |
| efried | dansmith https://github.com/openstack/nova/blob/b214dfc41928d9e05199263301f8e5b23555c170/nova/scheduler/client/report.py#L982-L985 | 17:09 |
| cdent | but I guess some things might share nested bits | 17:09 |
| cdent | which is | 17:09 |
| cdent | awkward | 17:09 |
| *** tidwellr_ has quit IRC | 17:09 | |
| *** chyka has joined #openstack-nova | 17:09 | |
| dansmith | cdent: we do, I'm just saying I think efried is talking about a more general case of multiple external actors needing to interact with one set of inventory or allocations, using generations as the locking mechanism | 17:10 |
| efried | sean-k-mooney has been coming up with all sorts of interesting use cases where it may very well be the case that e.g. nova owns the VFs, neutron owns the VIFs, and some other thing owns the bandwidth - all on the same RP. | 17:10 |
| dansmith | I'm only half paying attention to this conversation so maybe I should keep quiet :) | 17:10 |
| *** tidwellr has joined #openstack-nova | 17:10 | |
| dansmith | efried: I'm not sure I agree that such a case is legit | 17:11 |
| efried | dansmith So far you've only been reaffirming my position, so by all means continue half paying attention. | 17:11 |
| cdent | efried: in which case a cache that is local the compute node is going to fraught with challenges beyond the one you have identified today | 17:11 |
| efried | dansmith Once you start disagreeing, then yeah... | 17:11 |
| dansmith | hah | 17:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't filter out sibling sets with one core https://review.openstack.org/537361 | 17:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Update tests to set 'NUMACell.siblings' https://review.openstack.org/537362 | 17:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure emulator threads are always calculated https://review.openstack.org/537363 | 17:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Always pass 'NUMACell.siblings' to _pack_instance_onto_cores' https://review.openstack.org/537364 | 17:12 |
| *** bhujay has quit IRC | 17:14 | |
| *** bhujay has joined #openstack-nova | 17:14 | |
| *** gyee has quit IRC | 17:15 | |
| cdent | efried: are you blocked in the immediate sense, or "merely" the medium term sense? | 17:17 |
| efried | cdent I'm not blocked, other than the fact that I'm discussing and writing up this issue rather than working on the update_from_provider_tree patch. | 17:18 |
| efried | I think we're broken long-term, but again, it's not going to matter until we have real-world situations that can do concurrent updates to the same RPs. | 17:18 |
| efried | Which won't be Q. | 17:18 |
| cdent | is "broken if we want a cache" or "broken"? | 17:19 |
| cdent | What I mean is, if later we decided "screw it, let's strip out the cache", would that be a thing? | 17:19 |
| cdent | (just trying to make sure I'm grokking) | 17:20 |
| mriedem | alex_xu: some comments in https://review.openstack.org/#/c/536085/ which can be addressed in the follow up nit cleanup patch - and also a request for a functional test, which would be done in a follow up patch | 17:20 |
| efried | cdent If we get rid of the cache, and never DELETE allocations/inventories unless we know we're the sole owner thereof, then I think we would be okay. | 17:20 |
| efried | cdent I don't think the placement API is broken. I just think it has some holes for consumers wishing to do good caching. | 17:21 |
| efried | cdent And certainly some holes in documentation. | 17:22 |
| cdent | for allocations that's (sole owner thereof, when deleting by consumer id) supposed to be true, but for inventories there's probably work to do | 17:22 |
| mriedem | "And certainly some holes in documentation." - i will say, all things aside to this discussion, the placement stuff has a lot of good documentation compared to what we've historically had for stuff in nova | 17:22 |
| cdent | From my perspective placement wasn't designed for caching. It was designed to be capable of tell you the truth, right now. | 17:23 |
| cdent | efried: if it can't do that fast enough, that's the bug | 17:23 |
| cdent | fast -> effectively, efficiently, low latency, reliably | 17:23 |
| efried | cdent I continue to be vehemently not on board with the theory that it's okay to do lots of calls to placement if that can be avoided. | 17:24 |
| cdent | we can agree to disagree on that and I respect your opinion. | 17:24 |
| efried | cdent Because I don't care how fast we get it, it's still a "call over the wire" (even if localhost). | 17:24 |
| *** slaweq has joined #openstack-nova | 17:24 | |
| *** sapd has quit IRC | 17:24 | |
| efried | ...which is always going to be an order of magnitude higher overhead than a local cache index. | 17:24 |
| cdent | efried: if you want to avoid calls over the wire I'd suggest looking at RPC :) | 17:25 |
| cdent | which is ripe for adjustments | 17:25 |
| efried | Even RPC | 17:25 |
| efried | oh, that's not what you meant. | 17:25 |
| edleafe | and what good is a local cache if you aren't sure it's current? | 17:25 |
| efried | edleafe Or more precisely, you can't detect reliably when it's not. | 17:25 |
| edleafe | that's what the 409 handling is about | 17:26 |
| efried | which is what started me off on this whole thing. | 17:26 |
| cdent | efried: we can (and perhaps should) put a placement web service (with a memcached) near the compute nodes | 17:26 |
| efried | I don't know what that means. | 17:26 |
| cdent | have hundreds of them | 17:26 |
| efried | But it's still ultimately socket(), nah? | 17:26 |
| efried | Hell, even if that socket() is to a fifo, it's still an order of magnitude heavier than talking to the cache. | 17:27 |
| cdent | sure, but a) that's such the example of early optimization, b) if talking to placement turns out to be the consistent high expense in spawning a server, I'd be surprised. | 17:27 |
| cdent | Since we don't know that b is or is not a problem | 17:27 |
| cdent | it is | 17:27 |
| cdent | too soon | 17:27 |
| cdent | to be optimizig | 17:27 |
| efried | yet here we are. | 17:27 |
| cdent | indeed, wtf? | 17:27 |
| edleafe | I was just typing the same thing - optimizing when we don't know that that's the problem | 17:28 |
| cdent | but the great thing is: it mostly works, we have a temporary workaround, and we can keep on improving stuff | 17:28 |
| efried | so now on the table is a third option, even broader. | 17:28 |
| efried | for the long term | 17:28 |
| efried | which is: rip out the cache | 17:28 |
| *** felipemonteiro_ has quit IRC | 17:29 | |
| cdent | efried, edleafe: so fairly productive conversation to some extent; more pages shared | 17:30 |
| mriedem | this reminds me, we're GETing aggregates twice per update_available_resource periodic for 0 reason :) | 17:30 |
| cdent | yes _that_ is a bug | 17:30 |
| cdent | but I think efried fixes it in ProviderTree? | 17:31 |
| mriedem | i was going to push a simple backportable patch to remove that unnecessary callin | 17:31 |
| efried | I'm actually not sure any of the stuff I've done touches the legacy update_available_resource code paths. | 17:31 |
| mriedem | like just remove the shit, and leave a comment saying "revert git hash xyz once aggregates are a thing the client cares about" | 17:31 |
| mriedem | the ever growing todo list | 17:32 |
| cdent | mriedem: is it enough of a concern to do anything? I seem to recall someone reporting it as a problem? | 17:32 |
| cdent | oh, I get you, take it all out | 17:32 |
| mriedem | klindgren__ at godaddy was just noticing the number of placement REST API calls in a single periodic run w/o no changes otherwise | 17:32 |
| efried | mriedem If aggregates were only useful for sharing providers, maybe. Also, it won't be as simple as "revert this commit". That's gonna be merge conflict central on the patch series in flight right now. | 17:32 |
| mriedem | i assume to start planning for the scale reqiurements | 17:32 |
| mriedem | efried: i realize, but it would be a breadcrumb to look at what existed before, | 17:33 |
| mriedem | idk, could just be simpler / better to remove it all and when needed, add the stuff back in fresh as needed | 17:33 |
| *** slaweq has quit IRC | 17:33 | |
| cdent | I gotta go before getting sucked into another thing, I feel like ass. | 17:33 |
| efried | mriedem On what time frame? Before FF? Or between now and when we cut Q? | 17:33 |
| mriedem | efried: i should be backported, so whenever | 17:34 |
| * cdent waves | 17:34 | |
| mriedem | *it | 17:34 |
| mriedem | o/ | 17:34 |
| efried | Bye cdent, thanks for the talk. | 17:34 |
| *** cdent has quit IRC | 17:34 | |
| efried | mriedem So that backport is gonna be very different for Q and pre-Q, just sayin. | 17:35 |
| *** mvk has quit IRC | 17:35 | |
| mriedem | melwitt: want to hit this cleanup patch and the docs one after it? https://review.openstack.org/#/c/536871/ - i've got the osc-placement 1.0.0 release dependent on this series | 17:35 |
| mriedem | efried: because the provider tree stuff changed everything? | 17:35 |
| melwitt | mriedem: sure thing | 17:35 |
| mriedem | i haven't looked at things there in 2 weeks | 17:36 |
| efried | mriedem Yes, changed some things, and added lots of things. | 17:36 |
| mriedem | anyway, whatever, it should be pretty straight-forward | 17:36 |
| mriedem | melwitt: thanks | 17:36 |
| *** pramodrj07 has joined #openstack-nova | 17:37 | |
| * mriedem goes to get osc-placement release notes published | 17:37 | |
| melwitt | mriedem: will this link be working after the change merges or does it need to be corrected now? https://review.openstack.org/#/c/536858/4/releasenotes/notes/commands-v1.0.0-894ea659825b3757.yaml@36 | 17:42 |
| *** slaweq has joined #openstack-nova | 17:43 | |
| mriedem | melwitt: it'll work as a result of this change | 17:43 |
| mriedem | and once the docs get published | 17:43 |
| melwitt | k | 17:43 |
| mriedem | bauzas: what do you need from me wrt the libvirt gpu series? | 17:44 |
| dansmith | mriedem: : | 17:47 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid suspending guest with attached vGPUs https://review.openstack.org/535693 | 17:47 |
| dansmith | mriedem: I just fixed up all the things we commented on | 17:47 |
| mriedem | ack | 17:47 |
| mriedem | reviewing | 17:48 |
| dansmith | mriedem: I can try to find someone else to be the second +2 if my hands are too dirty.. I'll let you make that call | 17:48 |
| *** gouthamr has joined #openstack-nova | 17:49 | |
| *** gouthamr has quit IRC | 17:49 | |
| *** slaweq has quit IRC | 17:49 | |
| *** mvenesio has joined #openstack-nova | 17:49 | |
| *** tidwellr has quit IRC | 17:51 | |
| *** Tahvok has quit IRC | 17:51 | |
| *** doude has joined #openstack-nova | 17:51 | |
| *** Tahvok has joined #openstack-nova | 17:52 | |
| *** mdrabe has quit IRC | 17:53 | |
| *** mdrabe has joined #openstack-nova | 17:53 | |
| *** bhujay has quit IRC | 17:54 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid suspending guest with attached vGPUs https://review.openstack.org/535693 | 17:54 |
| dansmith | mriedem: sorry, I forgot to replace one line in the test ^ | 17:54 |
| *** edand__ has quit IRC | 17:54 | |
| *** tidwellr has joined #openstack-nova | 17:54 | |
| *** gouthamr has joined #openstack-nova | 17:56 | |
| dansmith | lbragstad: hey, mriedem told me you fixed the copious warnification about policy deprecativity recently | 17:59 |
| dansmith | but I still experience said pain | 17:59 |
| dansmith | is there something we're doing that blocks us from experiencing intended test euphoria? | 18:00 |
| *** xinliang has quit IRC | 18:00 | |
| lbragstad | dansmith: oh - really? | 18:01 |
| dansmith | lbragstad: yah | 18:01 |
| lbragstad | i had a few patches in flight for a couple different issues, let me check to see where they are at | 18:01 |
| *** sahid has quit IRC | 18:01 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-traits master: Update reno for stable/queens https://review.openstack.org/537512 | 18:02 |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Update reno for stable/queens https://review.openstack.org/537514 | 18:02 |
| lbragstad | dansmith: what version of oslo.policy are you experiencing this with? | 18:03 |
| dansmith | lbragstad: I just tox -r'd, but let me look | 18:03 |
| dansmith | (r/s/b/add-suppo)% grep policy requirements.txt | 18:04 |
| dansmith | oslo.policy>=1.30.0 # Apache-2.0 | 18:04 |
| mriedem | dansmith: +2 on https://review.openstack.org/#/c/535693/ - i think you're ok to +W | 18:04 |
| lbragstad | https://review.openstack.org/#/c/531497/ is the patch that should have fixed the issue you're seeing | 18:04 |
| dansmith | mriedem: rr thanks | 18:04 |
| *** david-lyle has quit IRC | 18:04 | |
| *** xinliang has joined #openstack-nova | 18:04 | |
| lbragstad | and that *should* be in oslo.policy 1.33.1 | 18:04 |
| lbragstad | which looks good here - https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L446 | 18:05 |
| dansmith | lbragstad: hmm, but I've got 1.30 in requirements.. am I missing how g-r overrides that or something? | 18:06 |
| *** derekh is now known as derekh_afk | 18:07 | |
| lbragstad | that's a good question | 18:07 |
| *** yamamoto has joined #openstack-nova | 18:07 | |
| mriedem | dansmith: upper-constraints should pull in 1.33.1 | 18:07 |
| lbragstad | dansmith: do you know exactly which version of oslo.policy you have in your env? | 18:08 |
| *** sambetts is now known as sambetts|afk | 18:08 | |
| melwitt | mriedem: can you remind me if you know if anything is unique to the cells v1 tempest job? in looking at the libvirt errors on stable, it's both stable branches and only the cells v1 job | 18:08 |
| mriedem | he's got 1.30 | 18:08 |
| dansmith | lbragstad: above I quoted what is in requirements.txt | 18:08 |
| *** janki has quit IRC | 18:08 | |
| mriedem | melwitt: cellsv1 job shouldn't have anything unique about the compute / virt setup | 18:08 |
| lbragstad | mriedem: i thought he had >=1.30 in requirements | 18:08 |
| mriedem | oh, | 18:08 |
| *** tesseract has quit IRC | 18:08 | |
| mriedem | pip freeze your tox venv | 18:08 |
| dansmith | I hacked my requirements.txt, tox -r, and still get it | 18:08 |
| mriedem | 1.33.1 is in u-c | 18:08 |
| melwitt | mriedem: thanks | 18:09 |
| dansmith | (r/s/b/add-suppo)% .tox/py27/bin/pip freeze | grep policy | 18:09 |
| dansmith | oslo.policy==1.33.1 | 18:09 |
| dansmith | after my hack | 18:09 |
| lbragstad | ah | 18:09 |
| mriedem | bauzas: is this the final piece of the vgpu puzzle for libvirt https://review.openstack.org/#/c/535693/ ? i don't see any other libvirt patches for vgpu - so assuming we're done once that merges | 18:10 |
| dansmith | trying again without the hack, but assume I'll get that same thing again | 18:10 |
| mriedem | do we have any patch that has a feature support matrix update for vgpu support? | 18:10 |
| lbragstad | dansmith: do you have a policy file you're testing with locally, or are you just running nova tests? | 18:11 |
| dansmith | lbragstad: just nova tests | 18:12 |
| mriedem | dansmith: if it's always a handful of rules, it could be something in the policy fixture or a specific test | 18:12 |
| *** jpena is now known as jpena|off | 18:12 | |
| lbragstad | the fix in 1.33.1 just makes it so a warning is logged iff a policy is deprecated *and* you're specifying it in a policy file or somewhere on disk | 18:13 |
| dansmith | mriedem: there are 11 warnings, seemingly regardless of what tests I run | 18:13 |
| * lbragstad wonders if a fixture is setting up a policy on disk for those tests | 18:14 | |
| mriedem | nova.tests.unit.policy_fixture.PolicyFixture maybe? | 18:15 |
| mriedem | loads things up from some fake rules | 18:15 |
| mriedem | from nova.tests.unit.fake_policy | 18:15 |
| dansmith | mriedem: wouldn't that only affect me if I'm running those tests though? | 18:15 |
| dansmith | I get this if I run a single-shot test | 18:15 |
| lbragstad | so - it is writing them to disk https://github.com/openstack/nova/blob/master/nova/tests/unit/policy_fixture.py#L97 | 18:17 |
| mriedem | dansmith: i think the base test case class loads up the policy fixture | 18:17 |
| mriedem | for all tests | 18:17 |
| lbragstad | which would trip this case - https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L610-L625 | 18:17 |
| mriedem | yup self.policy = self.useFixture(policy_fixture.PolicyFixture()) | 18:17 |
| mriedem | it's loaded for all tests | 18:18 |
| mriedem | dansmith: so you'd have to try and remove the deprecated policy rules from the fake fixture data | 18:18 |
| *** yamamoto has quit IRC | 18:18 | |
| lbragstad | because oslo.policy thinks it needs to inform an operator about a policy override that is deprecated (i assume https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_policy.py contains some deprecated policies) | 18:18 |
| dansmith | mriedem: it doesn't seem to have a set of rules in the fixture though | 18:19 |
| *** stvnoyes has joined #openstack-nova | 18:20 | |
| mriedem | dansmith: what's one of the ones it's complaining about? | 18:20 |
| dansmith | os_compute_api:os-extended-volumes | 18:20 |
| dansmith | maybe it's in fake_policy.py? | 18:20 |
| mriedem | os_compute_api:os-extended-volumes | 18:20 |
| mriedem | yes | 18:20 |
| mriedem | that's the problem, | 18:20 |
| lbragstad | https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_policy.py#L50 | 18:20 |
| lbragstad | ^ that one is deprecated | 18:20 |
| mriedem | it's writing the fixture data to a temp file | 18:20 |
| mriedem | and read in by the policy fixture | 18:20 |
| dansmith | what does that mean though? there's no value set for that | 18:21 |
| dansmith | or do you mean I just need to delete it? | 18:21 |
| mriedem | "" means all i think | 18:21 |
| mriedem | delete those entries | 18:21 |
| *** jafeha__ has joined #openstack-nova | 18:21 | |
| lbragstad | i'm working on a patch now | 18:21 |
| mriedem | i'm not sure why we actually even have that fake_policy file anymore | 18:21 |
| mriedem | lbragstad has grown bored with keystone | 18:22 |
| *** jafeha has quit IRC | 18:24 | |
| dansmith | lbragstad: I've got one already | 18:24 |
| dansmith | about to push | 18:24 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated policy items from fake_policy https://review.openstack.org/537600 | 18:24 |
| dansmith | lbragstad: mriedem ^ | 18:24 |
| *** avolkov has quit IRC | 18:24 | |
| dansmith | hmm | 18:25 |
| dansmith | I think I still get something | 18:25 |
| dansmith | /dan/nova/.tox/py27/lib/python2.7/site-packages/oslo_policy/policy.py:623: UserWarning: Policy "os_compute_api:os-extended-volumes":"rule:admin_or_owner" was deprecated for removal in 17.0.0. Reason: Nova API extension concept has been removed in Pike. Those extensions have their own policies enforcement. As there is no extensions now, "os_compute_api:os-extended-volumes" policy which was added for extensions is not needed any more. | 18:25 |
| dansmith | Its value may be silently ignored in the future | 18:25 |
| dansmith | I think the rule:admin_or_owner bit is new now | 18:25 |
| *** imacdonn has joined #openstack-nova | 18:26 | |
| *** imacdonn has quit IRC | 18:26 | |
| *** imacdonn has joined #openstack-nova | 18:26 | |
| lbragstad | dansmith: oh nice | 18:26 |
| dansmith | hmm, actually, no | 18:26 |
| dansmith | I backed out the change and I get the same exact thing | 18:27 |
| lbragstad | weird - that's still emitting https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L615-L625 | 18:28 |
| lbragstad | huh... | 18:29 |
| lbragstad | actually... | 18:29 |
| lbragstad | it looks like it's writing everything to disk | 18:30 |
| lbragstad | regardless of it being in fake_policy or not | 18:30 |
| lbragstad | https://github.com/openstack/nova/blob/master/nova/tests/unit/policy_fixture.py#L96 | 18:30 |
| *** andrewbogott has quit IRC | 18:30 | |
| *** andrewbogott has joined #openstack-nova | 18:30 | |
| dansmith | yup | 18:30 |
| dansmith | per sdague's comment above I assume | 18:30 |
| lbragstad | yeah | 18:30 |
| *** ralonsoh_ has quit IRC | 18:30 | |
| lbragstad | this must have been around before the default in code efforts | 18:31 |
| dansmith | I feel like it cropped up between when I left last year and popped up this year | 18:31 |
| *** pramodrj07 has quit IRC | 18:31 | |
| *** Pramod has joined #openstack-nova | 18:31 | |
| lbragstad | https://github.com/openstack/nova/commit/eacdbc3d8e9042c584c751d599da59ddcaf98a1c | 18:31 |
| *** fragatina has quit IRC | 18:32 | |
| lbragstad | dansmith: trying a workaround hack with http://paste.openstack.org/raw/652502/ | 18:36 |
| lbragstad | checking if i can recreate locally | 18:36 |
| dansmith | ah that seems nice | 18:36 |
| lbragstad | ^ that fixes it for me | 18:37 |
| lbragstad | http://paste.openstack.org/show/652509/ without the fix... | 18:38 |
| lbragstad | er... "fix", no idea if that's how we want to work around it | 18:39 |
| lbragstad | with the workaround http://paste.openstack.org/show/652513/ | 18:39 |
| *** tssurya_ has joined #openstack-nova | 18:40 | |
| openstackgerrit | Lance Bragstad proposed openstack/nova master: Remove deprecated policies from fake_policy https://review.openstack.org/537602 | 18:40 |
| openstackgerrit | Lance Bragstad proposed openstack/nova master: WIP: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | 18:40 |
| *** tssurya_ has quit IRC | 18:41 | |
| openstackgerrit | Lance Bragstad proposed openstack/nova master: WIP: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | 18:42 |
| dansmith | lbragstad: remove the WIP? | 18:42 |
| lbragstad | done | 18:43 |
| openstackgerrit | Lance Bragstad proposed openstack/nova master: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | 18:43 |
| dansmith | lbragstad: thanks! | 18:43 |
| lbragstad | dansmith: no problem - thanks for the heads up... not sure if all those policies need to be there, but at least it doesn't spam as bad | 18:44 |
| *** ralonsoh has joined #openstack-nova | 18:45 | |
| mriedem | dansmith: do we still need https://review.openstack.org/#/c/537600/ ? | 18:45 |
| mriedem | oh i guess so | 18:45 |
| *** tssurya_ has joined #openstack-nova | 18:49 | |
| mriedem | stephenfin: melwitt: umm https://review.openstack.org/#/c/523958/ | 18:56 |
| mriedem | could we not have red hat cores approving red hat changes? | 18:56 |
| *** Pramod has quit IRC | 18:56 | |
| *** felipemonteiro has joined #openstack-nova | 19:00 | |
| melwitt | mriedem: sorry about that. I have asked red hatters not to approve red hat changes that I've +2ed so I think this was just an oversight. downgrading my vote to +1 | 19:01 |
| melwitt | er, I guess that doesn't help because I'm not the approver | 19:01 |
| *** felipemonteiro_ has joined #openstack-nova | 19:02 | |
| dansmith | yeah, it won't help :( | 19:02 |
| *** tssurya_ has quit IRC | 19:02 | |
| dansmith | a -2 will, but.. | 19:02 |
| dansmith | it will also reset the gate if it's already there | 19:02 |
| *** jackie-truong has joined #openstack-nova | 19:02 | |
| mriedem | we do'nt need to pull it out, | 19:02 |
| mriedem | i'm not going to review it in depth at this point | 19:03 |
| mriedem | the commit message obviously shows there was thought put into it | 19:03 |
| dansmith | lol | 19:03 |
| artom | It's that suave British accent, isn't it? | 19:04 |
| mriedem | who wrote the commit message, lee or booth? | 19:04 |
| mriedem | anywho, | 19:04 |
| mriedem | btw, | 19:05 |
| mriedem | the live migration job runs with ceph i think, | 19:05 |
| mriedem | but i guess we don't enable volume-backed live migratoin do we, | 19:05 |
| mriedem | and even if we did, we don't have a tempest test for encrypted volume-backed live migration to run with ceph | 19:05 |
| mriedem | but we do have new enough libvirt and qemu in the pike UCA to test this | 19:05 |
| mriedem | heh https://review.openstack.org/#/c/536177/ | 19:06 |
| *** felipemonteiro has quit IRC | 19:06 | |
| *** tssurya_ has joined #openstack-nova | 19:06 | |
| melwitt | mriedem: I have a patch up to enable it but it looks like it's hitting legit problems https://review.openstack.org/#/c/528104/ | 19:09 |
| *** lucasagomes is now known as lucas-afk | 19:10 | |
| mriedem | melwitt: is there supposed to be at least even a release note anywhere in this series? | 19:10 |
| *** tidwellr has quit IRC | 19:10 | |
| mriedem | because given the commit message, it seems pretty complicated | 19:10 |
| mriedem | or some kind of advertisement anywhere about 'hey you can do this thing now with libvirt and encrypted volumes' | 19:10 |
| openstackgerrit | Merged openstack/osc-placement master: CLI for resource classes (v1.2) https://review.openstack.org/511182 | 19:10 |
| *** tidwellr has joined #openstack-nova | 19:10 | |
| melwitt | mriedem: I think there's no release note because it's automatic, that is, operators don't have to do anything, it will use native luks decryption if available. but now that you mention it, it might be helpful to mention that it will use native decryption if qemu and libvirt version combination support it | 19:14 |
| *** mlavalle has quit IRC | 19:15 | |
| mriedem | right, i mean, unless this is totally rock solid, and shit starts randomly failing, operators are probably going to want to know that something new is going on here | 19:15 |
| melwitt | yeah, I agree with that | 19:16 |
| artom | Heh, we talked about this in the spec: https://review.openstack.org/#/c/490824/5/specs/queens/approved/libvirt-qemu-native-luks.rst@98 | 19:17 |
| artom | And then promptly forgot about it :( | 19:17 |
| *** david-lyle has joined #openstack-nova | 19:17 | |
| *** mlavalle has joined #openstack-nova | 19:18 | |
| dhellmann | mriedem : is https://review.openstack.org/516385 of any interest or should I just abandon that? | 19:20 |
| mriedem | dhellmann: it is of the utmost interest | 19:23 |
| dhellmann | mriedem : ok. I'll leave it open then until someone has a minute to review it. | 19:23 |
| mriedem | dhellmann: already did | 19:24 |
| mriedem | :) | 19:24 |
| dhellmann | :-) | 19:24 |
| dhellmann | thanks | 19:24 |
| mriedem | melwitt: didn't lee say he was going to be out a bit this week? do you think you could take a stab at a release note? | 19:24 |
| mriedem | since you know the change | 19:24 |
| mriedem | as a patch on top of course | 19:24 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add unit test for non-placement resize https://review.openstack.org/537614 | 19:24 |
| mriedem | edleafe: thanks for that | 19:24 |
| edleafe | mriedem: np | 19:25 |
| melwitt | mriedem: sure, will do | 19:25 |
| mriedem | melwitt: thanks | 19:25 |
| mriedem | then i guess we can close that one out for queens | 19:25 |
| openstackgerrit | Merged openstack/osc-placement master: Address review comments from allocations patch https://review.openstack.org/536871 | 19:26 |
| openstackgerrit | Merged openstack/osc-placement master: Usage docs and initial release note for osc-placement https://review.openstack.org/536858 | 19:27 |
| *** pcaruana has joined #openstack-nova | 19:27 | |
| *** pcaruana has quit IRC | 19:27 | |
| mriedem | the cinder gate fix has been promoted btw | 19:28 |
| mriedem | so hopefully stuff starts merging again soon | 19:28 |
| *** ralonsoh has quit IRC | 19:28 | |
| *** Guest50651 has quit IRC | 19:29 | |
| *** felipemonteiro_ has quit IRC | 19:32 | |
| *** muttley has joined #openstack-nova | 19:32 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:34 | |
| *** jackie-truong has quit IRC | 19:35 | |
| melwitt | that's super news ++ | 19:35 |
| *** suresh12 has joined #openstack-nova | 19:36 | |
| *** harlowja has joined #openstack-nova | 19:38 | |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Unplug all VIFs from ironic nodes during tear down https://review.openstack.org/537626 | 19:38 |
| *** yamahata has joined #openstack-nova | 19:38 | |
| *** AlexeyAbashkin has quit IRC | 19:38 | |
| *** fragatina has joined #openstack-nova | 19:40 | |
| *** slaweq has joined #openstack-nova | 19:45 | |
| *** dtantsur is now known as dtantsur|afk | 19:46 | |
| *** amoralej is now known as amoralej|off | 19:46 | |
| *** muttley has quit IRC | 19:48 | |
| *** tssurya_ has quit IRC | 19:49 | |
| dansmith | melwitt: mriedem tssurya: do we need to have a cells meeting today? I've got nothing new to talk abotu | 19:49 |
| *** archit has joined #openstack-nova | 19:50 | |
| archit | msg amodi identify titanic123 | 19:50 |
| dansmith | whoopsie :) | 19:51 |
| archit | lol | 19:51 |
| *** tssurya_ has joined #openstack-nova | 19:51 | |
| archit | yep .:( | 19:51 |
| *** amodi has quit IRC | 19:51 | |
| melwitt | dansmith: I don't have anything new either | 19:51 |
| efried | swhy I always do those in the status channel | 19:51 |
| mriedem | dansmith: there are no major new bugs that i'm aware of, | 19:51 |
| mriedem | and the resize + alternate hosts change is approved | 19:51 |
| efried | Is this cinder bug going to affect all patches? | 19:51 |
| mriedem | efried: anything that runs tempest api tests | 19:51 |
| mriedem | so all dsvm jobs | 19:52 |
| *** slaweq has quit IRC | 19:52 | |
| efried | so all my nova patches | 19:52 |
| * efried is going for record number of rechecks | 19:52 | |
| mriedem | it's #13 in the gate right now | 19:52 |
| mriedem | dansmith: melwitt: so only other thing would be ptg topics, but that can wait until after FF | 19:53 |
| dansmith | cool | 19:53 |
| *** archit is now known as amodi | 19:53 | |
| mriedem | tssurya: tssurya_: do you have any status updates from cern's migration to cells v2? | 19:53 |
| tssurya_ | mriedem : actually belmiro was going to participate in the cells meeting today, not sure though; but yea we are going to be doing in at the end of Feb | 19:54 |
| dansmith | drat! :) | 19:54 |
| mriedem | tssurya_: doing it in prod? but you're all clear in pre-prod testing? | 19:55 |
| tssurya_ | migrating to Ocata during the last days of this month | 19:55 |
| dansmith | tssurya: can you find out if he's going to be around? | 19:55 |
| tssurya_ | and we will have to move to Pike in a few weeks | 19:55 |
| mriedem | ok; would be good to know as soon as possible if there are blockers *before* rocky | 19:55 |
| tssurya_ | yes in prod | 19:55 |
| mriedem | because i think we still plan on dropping cellsv1 and nova-net in rocky | 19:55 |
| tssurya_ | dansmith : yea will ping him and see if he will be joining | 19:56 |
| dansmith | tssurya_: okay thanks | 19:56 |
| tssurya_ | mriedem : yea we have half out cloud on neutron | 19:56 |
| tssurya_ | and trying to scale it to move out ot nova-net | 19:56 |
| tssurya_ | out of * | 19:56 |
| tssurya_ | our * | 19:56 |
| *** amodi has quit IRC | 19:56 | |
| *** amodi has joined #openstack-nova | 19:57 | |
| *** tidwellr has quit IRC | 19:58 | |
| *** dave-mccowan has quit IRC | 19:58 | |
| mriedem | this needs another +2 - https://review.openstack.org/#/c/533210/ - moves the nova-tox-functional job in-tree so we can define our own files blacklist, so we don't have gate issues again with notification samples only patches not getting test | 20:01 |
| mriedem | *tested | 20:01 |
| *** tidwellr has joined #openstack-nova | 20:01 | |
| *** jangutter has joined #openstack-nova | 20:03 | |
| *** jangutter has quit IRC | 20:05 | |
| *** jangutter has joined #openstack-nova | 20:05 | |
| *** matrohon has joined #openstack-nova | 20:06 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 20:11 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 20:11 |
| openstackgerrit | sean mooney proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051 | 20:11 |
| openstackgerrit | sean mooney proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/507481 | 20:11 |
| *** sean-k-mooney has joined #openstack-nova | 20:13 | |
| *** jaypipes has joined #openstack-nova | 20:15 | |
| sean-k-mooney | stephenfin: if you have time tomorow rodoflos nic feature based schduling patch series is now all rebased with versioned objects https://review.openstack.org/#/q/topic:bp/enable-sriov-nic-features+(status:Open) | 20:16 |
| *** slaweq has joined #openstack-nova | 20:17 | |
| *** amodi has quit IRC | 20:20 | |
| *** dtruong has joined #openstack-nova | 20:20 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add release note for QEMU native LUKS decryption https://review.openstack.org/537642 | 20:24 |
| *** gouthamr has quit IRC | 20:26 | |
| *** READ10 has quit IRC | 20:26 | |
| *** slaweq has quit IRC | 20:29 | |
| mriedem | melwitt: some questions in that reno | 20:32 |
| *** dhellmann has left #openstack-nova | 20:32 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624 | 20:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | 20:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 20:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 20:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 20:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 20:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 20:32 |
| *** cleong has quit IRC | 20:37 | |
| *** slaweq has joined #openstack-nova | 20:39 | |
| *** slaweq has quit IRC | 20:39 | |
| *** slaweq has joined #openstack-nova | 20:40 | |
| *** dave-mccowan has joined #openstack-nova | 20:41 | |
| *** itlinux has joined #openstack-nova | 20:44 | |
| *** slaweq_ has joined #openstack-nova | 20:45 | |
| dansmith | tssurya_: any word from belmiro? | 20:46 |
| *** tidwellr has quit IRC | 20:47 | |
| *** slaweq has quit IRC | 20:47 | |
| tssurya_ | dansmith: no, nothing yet | 20:47 |
| dansmith | okay I guess we'll just go forward with it, see if he shows up and if not, bail :) | 20:48 |
| tssurya_ | we had a couple of things to discuss, but nothing urgent; | 20:48 |
| *** jangutter has quit IRC | 20:48 | |
| tssurya_ | in case he doesn't show up, we will just ask in the channel tomorrow | 20:49 |
| *** slaweq_ has quit IRC | 20:50 | |
| *** belmoreira has joined #openstack-nova | 20:51 | |
| tssurya_ | oh cool he is here | 20:51 |
| dansmith | well, lookie there | 20:51 |
| dansmith | belmoreira: we were going to cancel the cells meeting to focus on other things, but tssurya_ rained on our parade and said you were coming with things to talk about | 20:52 |
| *** jaypipes has quit IRC | 20:53 | |
| *** jackie-truong has joined #openstack-nova | 20:54 | |
| belmoreira | hi dansmith. We will move to Ocata next week. Then start preparing Pike and cellsV2 | 20:54 |
| *** tidwellr has joined #openstack-nova | 20:54 | |
| mriedem | but ocata requires cellsv2...? | 20:54 |
| mriedem | i'm confused | 20:54 |
| dansmith | ocata being single cell I assume | 20:55 |
| belmoreira | I'm interested about the progress in listing instances if a cell goes down and the quota issue | 20:55 |
| belmoreira | mriedem: in Ocata we define only one cell but continue to use cellsV1 | 20:55 |
| mriedem | belmoreira: there hasn't been any progress on that, | 20:55 |
| dansmith | belmoreira: tssurya_ was going to put up a straw man for us to discuss with api people | 20:55 |
| mriedem | it's a discussion item for the ptg | 20:56 |
| jackie-truong | mriedem: The cert validation patch series has been +2'd :-) Can I move it to the "Needs final +2 to complete blueprint" section in the nova-queens-blueprint-status etherpad? | 20:56 |
| dansmith | which I don't think has been posted, or at least that I saw | 20:56 |
| mriedem | jackie-truong: go for it | 20:56 |
| jackie-truong | mriedem: *\o/* | 20:56 |
| tssurya_ | dansmith : we have been working on it and have some ideas/questions on how to proceed | 20:57 |
| belmoreira | tssurya_ and I started to check for some alternatives. The PTG for us may be to late | 20:57 |
| mriedem | jackie-truong: i don't understand why this isn't in the series before the API change? https://review.openstack.org/#/c/479949/ | 20:57 |
| dansmith | tssurya_: okay cool | 20:57 |
| belmoreira | I would like to move to Pike in few weeks after Ocata. Meaning that we will need to cook something even it's only internal | 20:58 |
| *** tidwellr has quit IRC | 20:59 | |
| jackie-truong | mriedem: That patch implements the the certificate_utils module, but doesn't make any changes to the API. So it basically adds the functionality with no way to use it. | 20:59 |
| jackie-truong | mriedem: The API change adds the usability part | 20:59 |
| mriedem | jackie-truong: so technically here, | 20:59 |
| mriedem | we could merge the API, | 21:00 |
| mriedem | w/o the utils merged to do the things the api says you can do, right? | 21:00 |
| mriedem | adding functionality that is eventually exposed out of the rest api is kind of how all new things work | 21:00 |
| *** liverpooler has quit IRC | 21:00 | |
| jackie-truong | The API change works with the trusted_certs object added in https://review.openstack.org/#/c/489408/ | 21:01 |
| jackie-truong | So, techincally | 21:01 |
| jackie-truong | We could merge the API change (which would require the trusted_certs object change to be merged) | 21:01 |
| jackie-truong | which would result in you being able to create and pass around a TrustedCerts object | 21:02 |
| mriedem | what does the cert utils module do then? | 21:02 |
| jackie-truong | Without making use of it | 21:02 |
| mriedem | if i can't make use of the thing, what's the point of having the api before said thing works? | 21:02 |
| jackie-truong | the cert utils module takes in the TrustedCerts object (which gets turned into a list of strings) | 21:02 |
| jackie-truong | I realize that it technically makes sense to have the dependencies work: TrustedCerts object -> API -> cert_utils module | 21:03 |
| jackie-truong | But technically, that isn't necessary | 21:03 |
| jackie-truong | Since the API can be updated to pass around a useless object | 21:04 |
| mriedem | no i was saying object > util (make things do something) > API (expose the things that do something) | 21:04 |
| jackie-truong | Yeah, that timeline makes sense too. Basically, both util and API changes depend on the object change | 21:05 |
| jackie-truong | but util and API don't have any dependency on each other | 21:05 |
| jackie-truong | So we used the depends-on tag to indicate what dependencies needed to build | 21:06 |
| mriedem | jackie-truong: i think you're asserting like code deps, and i'm asserting functionality deps | 21:06 |
| melwitt | mriedem: replied | 21:06 |
| jroll | mriedem: our jobs are no longer segfaulting n-cond as of this morning, so nfi what was causing it :/ | 21:06 |
| *** tidwellr has joined #openstack-nova | 21:06 | |
| mriedem | jroll: huh | 21:06 |
| mriedem | success! | 21:06 |
| jroll | ikr | 21:07 |
| jroll | proves "have a beer and try again tomorrow" is always a good plan | 21:07 |
| jackie-truong | mriedem: Correct. Should the depends-on tag be used for functionality deps, too? | 21:07 |
| *** bpoulos has joined #openstack-nova | 21:07 | |
| *** esberglu has quit IRC | 21:08 | |
| *** esberglu has joined #openstack-nova | 21:09 | |
| sean-k-mooney | jroll: hum well it works. kind of hoped you would get to the bottom of that one | 21:09 |
| jroll | sean-k-mooney: yeah, me too, but is nice to have it off my back | 21:10 |
| mriedem | jackie-truong: you don't need a depends-on when it's in the same repo, just stack the changes in a series | 21:10 |
| mriedem | object > utils > API | 21:10 |
| mriedem | the API changes should always be the last thing to go | 21:11 |
| sean-k-mooney | mriedem: logic being dont expose the feature at the api until its fully done right | 21:11 |
| mriedem | sean-k-mooney: yes that's generally how things should work | 21:12 |
| *** awaugama has quit IRC | 21:12 | |
| mriedem | because we support CD, | 21:12 |
| mriedem | so that API can be in the wild once it's merged | 21:12 |
| mriedem | and we have to support it | 21:12 |
| *** suresh12 has quit IRC | 21:14 | |
| *** matrohon has quit IRC | 21:14 | |
| jackie-truong | mriedem: Got it. bpoulos will fix shortly | 21:14 |
| bpoulos | mriedem: I'll update the API order. I think we chose the way we did because that was the order it was listed in in the spec (at http://specs.openstack.org/openstack/nova-specs/specs/queens/approved/nova-validate-certificates.html ) | 21:14 |
| *** suresh12 has joined #openstack-nova | 21:14 | |
| *** suresh12 has quit IRC | 21:19 | |
| *** jangutter has joined #openstack-nova | 21:21 | |
| *** smatzek has quit IRC | 21:21 | |
| *** yamahata has quit IRC | 21:21 | |
| *** slaweq has joined #openstack-nova | 21:21 | |
| *** slaweq has quit IRC | 21:22 | |
| *** dave-mccowan has quit IRC | 21:25 | |
| *** jangutter has quit IRC | 21:26 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 21:28 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:28 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:28 |
| *** pchavva has quit IRC | 21:33 | |
| *** weshay|mtg is now known as weshay|rover | 21:34 | |
| *** threestrands has joined #openstack-nova | 21:41 | |
| *** threestrands_ has joined #openstack-nova | 21:44 | |
| *** threestrands_ has quit IRC | 21:44 | |
| *** threestrands_ has joined #openstack-nova | 21:44 | |
| *** threestrands has quit IRC | 21:47 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 21:49 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:53 |
| *** arvindn051 has joined #openstack-nova | 21:54 | |
| *** eharney has quit IRC | 21:54 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:54 |
| *** eharney has joined #openstack-nova | 21:56 | |
| *** smatzek has joined #openstack-nova | 21:56 | |
| *** eharney has quit IRC | 21:59 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 21:59 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 22:00 |
| *** belmoreira has quit IRC | 22:00 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 22:00 |
| mriedem | tssurya_: dansmith: melwitt: L74 https://etherpad.openstack.org/p/nova-ptg-rocky | 22:01 |
| *** smatzek has quit IRC | 22:01 | |
| mriedem | updated to summarize some of the meeting notes | 22:01 |
| dansmith | awesome | 22:01 |
| melwitt | thanks for doing that | 22:01 |
| * dansmith has to run off now | 22:02 | |
| tssurya_ | mriedem : thanks for putting it all in one place, | 22:04 |
| *** tssurya_ has quit IRC | 22:05 | |
| *** mvenesio has quit IRC | 22:05 | |
| jackie-truong | mriedem: dependency orders are now fixed. sorry about that | 22:07 |
| *** lyan has quit IRC | 22:11 | |
| *** amodi has joined #openstack-nova | 22:11 | |
| *** rcernin has joined #openstack-nova | 22:14 | |
| *** jangutter has joined #openstack-nova | 22:15 | |
| *** yangyapeng has quit IRC | 22:16 | |
| *** suresh12 has joined #openstack-nova | 22:18 | |
| mriedem | lyarwood: is the native luks swap volume thing b/c of blockRebase? and if so, is that then also an issue for guest-assisted snapshot of encrypted volumes for volumes like NFS/gluster? | 22:19 |
| *** jangutter has quit IRC | 22:19 | |
| mriedem | i don't know if we even have a tempest test for creating a snapshot of an instance with an encrypted volume attached, probably not | 22:20 |
| mriedem | and if we did, it would only be run in the NFS CI | 22:20 |
| *** suresh12 has quit IRC | 22:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move remaining uses of parted to privsep. https://review.openstack.org/519483 | 22:26 |
| *** amodi has quit IRC | 22:27 | |
| *** rcernin has quit IRC | 22:29 | |
| mriedem | gmann: do you plan on doing anything with these WIP changes? https://review.openstack.org/#/q/topic:bp/api-extensions-merge-queens+status:open | 22:31 |
| *** rcernin has joined #openstack-nova | 22:31 | |
| mriedem | gmann: otherwise once the 2 patches from alex_xu are merged i'm going to complete the blueprint for queens | 22:31 |
| *** jackie-truong has quit IRC | 22:31 | |
| mriedem | or i can just defer to rocky | 22:32 |
| mriedem | efried: i assume we'll just defer this to rocky https://review.openstack.org/#/c/508345/ | 22:33 |
| efried | mriedem Yeah. I deemed nrp more important and didn't spend the cycles to investigate why that one's... "special". | 22:34 |
| mriedem | that's fine | 22:34 |
| *** suresh12 has joined #openstack-nova | 22:35 | |
| bpoulos | mriedem lyarwood: the latest encrypted volume tempest tests are at https://github.com/openstack/barbican-tempest-plugin/blob/master/barbican_tempest_plugin/tests/scenario/test_volume_encryption.py and don't involve any snapshots | 22:36 |
| *** jaypipes has joined #openstack-nova | 22:39 | |
| mriedem | #success osc-placement 1.0.0 released; you can now do things with resource providers/classes via OSC CLI now | 22:39 |
| openstackstatus | mriedem: Added success to Success page | 22:39 |
| mriedem | mnaser: ^ | 22:39 |
| mriedem | you don't have to hack the db directly as much! | 22:39 |
| melwitt | "as much" \o/ | 22:41 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement master: Update reno for stable/queens https://review.openstack.org/537698 | 22:42 |
| *** acormier has quit IRC | 22:43 | |
| *** edmondsw has quit IRC | 22:47 | |
| *** acormier has joined #openstack-nova | 22:49 | |
| *** bpoulos has quit IRC | 22:49 | |
| *** claudiub has quit IRC | 22:50 | |
| *** itlinux has quit IRC | 22:51 | |
| *** esberglu has quit IRC | 22:56 | |
| *** yangyapeng has joined #openstack-nova | 23:01 | |
| *** tidwellr has quit IRC | 23:02 | |
| *** itlinux has joined #openstack-nova | 23:03 | |
| *** suresh12 has quit IRC | 23:05 | |
| *** eharney has joined #openstack-nova | 23:08 | |
| *** jangutter has joined #openstack-nova | 23:09 | |
| *** jangutter has quit IRC | 23:13 | |
| *** yamahata has joined #openstack-nova | 23:17 | |
| *** mlavalle has quit IRC | 23:23 | |
| *** itlinux has quit IRC | 23:23 | |
| *** acormier has quit IRC | 23:24 | |
| *** acormier has joined #openstack-nova | 23:24 | |
| *** takashin has joined #openstack-nova | 23:28 | |
| *** suresh12 has joined #openstack-nova | 23:29 | |
| *** derekh_afk has quit IRC | 23:33 | |
| *** acormier has quit IRC | 23:40 | |
| efried | jaypipes Hi, didn't see you come in. | 23:40 |
| *** armax has quit IRC | 23:43 | |
| openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | 23:46 |
| *** suresh12 has quit IRC | 23:50 | |
| *** suresh12 has joined #openstack-nova | 23:51 | |
| jaypipes | efried: sorry been out of network access for a while | 23:52 |
| efried | jaypipes You missed a rather hearty debate on the extent to which the internals of generation management should be a part of the placement API spec. | 23:53 |
| efried | jaypipes TL;DR: does the client get to know that the generation is a monotonically increasing integer starting at zero; or should the generation be completely opaque to the client? | 23:54 |
| *** yassine has joined #openstack-nova | 23:54 | |
| *** yassine is now known as Guest14094 | 23:55 | |
| *** hongbin has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!