| *** AlexeyAbashkin has joined #openstack-nova | 00:01 | |
| *** AlexeyAbashkin has quit IRC | 00:05 | |
| *** penick has quit IRC | 00:09 | |
| *** claudiub has quit IRC | 00:10 | |
| *** yangyapeng has quit IRC | 00:27 | |
| *** yangyapeng has joined #openstack-nova | 00:27 | |
| *** yangyapeng has quit IRC | 00:31 | |
| *** liuzz has joined #openstack-nova | 00:34 | |
| *** andymccr has quit IRC | 00:36 | |
| *** mlavalle has quit IRC | 00:38 | |
| *** FL1SK has quit IRC | 00:39 | |
| *** felipemonteiro has quit IRC | 00:40 | |
| *** chyka has quit IRC | 00:40 | |
| *** andymccr has joined #openstack-nova | 00:40 | |
| *** FL1SK has joined #openstack-nova | 00:41 | |
| *** markvoelker has joined #openstack-nova | 00:43 | |
| *** corvus has quit IRC | 00:44 | |
| *** markvoelker has quit IRC | 00:45 | |
| *** markvoelker has joined #openstack-nova | 00:49 | |
| *** markvoelker has quit IRC | 00:50 | |
| *** andymccr has quit IRC | 00:51 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:52 | |
| *** andymccr has joined #openstack-nova | 00:55 | |
| *** tidwellr has joined #openstack-nova | 00:57 | |
| *** david-lyle has joined #openstack-nova | 00:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix comment in MigrationSortContext https://review.openstack.org/532368 | 00:59 |
|---|---|---|
| *** yangyapeng has joined #openstack-nova | 01:00 | |
| mriedem | alex_xu: need another reviewer on https://review.openstack.org/#/c/330406/ - we have +2s on the 2 changes below it | 01:01 |
| *** Dinesh_Bhor has quit IRC | 01:02 | |
| *** jichen has joined #openstack-nova | 01:05 | |
| *** yangyapeng has quit IRC | 01:06 | |
| *** dave-mccowan has joined #openstack-nova | 01:08 | |
| *** markvoelker has joined #openstack-nova | 01:08 | |
| *** markvoelker has quit IRC | 01:09 | |
| mriedem | efried: i think you're wrong about https://bugs.launchpad.net/nova/+bug/1742311 | 01:11 |
| openstack | Launchpad bug 1742311 in OpenStack Compute (nova) "AttributeError in report client error path" [Undecided,Invalid] | 01:11 |
| mriedem | because https://github.com/requests/requests/blob/v2.18.4/requests/models.py#L663 | 01:11 |
| *** yangyapeng has joined #openstack-nova | 01:13 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:14 | |
| *** hoangcx has quit IRC | 01:16 | |
| *** hieulq has quit IRC | 01:16 | |
| *** hieulq has joined #openstack-nova | 01:17 | |
| *** hoangcx has joined #openstack-nova | 01:17 | |
| *** yangyapeng has quit IRC | 01:18 | |
| *** yangyapeng has joined #openstack-nova | 01:22 | |
| *** hongbin has joined #openstack-nova | 01:24 | |
| *** zhurong has joined #openstack-nova | 01:24 | |
| *** mdnadeem has joined #openstack-nova | 01:25 | |
| *** felipemonteiro has joined #openstack-nova | 01:25 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 01:25 |
| *** phuongnh has joined #openstack-nova | 01:29 | |
| *** sbezverk has left #openstack-nova | 01:31 | |
| *** tidwellr has quit IRC | 01:41 | |
| *** dave-mccowan has quit IRC | 01:42 | |
| *** Eran_Kuris has quit IRC | 01:42 | |
| *** Eran_Kuris has joined #openstack-nova | 01:42 | |
| *** Apoorva_ has joined #openstack-nova | 01:43 | |
| *** Apoorva has quit IRC | 01:46 | |
| *** felipemonteiro_ has joined #openstack-nova | 01:47 | |
| *** Apoorva_ has quit IRC | 01:47 | |
| *** felipemonteiro__ has joined #openstack-nova | 01:51 | |
| *** felipemonteiro_ has quit IRC | 01:51 | |
| *** felipemonteiro has quit IRC | 01:51 | |
| *** jafeha__ has joined #openstack-nova | 01:52 | |
| *** jafeha has quit IRC | 01:54 | |
| *** felipemonteiro__ has quit IRC | 01:55 | |
| *** penick has joined #openstack-nova | 01:57 | |
| *** penick_ has joined #openstack-nova | 02:00 | |
| *** sdague has quit IRC | 02:01 | |
| *** penick has quit IRC | 02:01 | |
| *** Tom-Tom has quit IRC | 02:03 | |
| *** Tom-Tom has joined #openstack-nova | 02:03 | |
| *** felipemonteiro__ has joined #openstack-nova | 02:07 | |
| *** david-lyle has quit IRC | 02:07 | |
| alex_xu | mriedem: got it, will get it done today | 02:09 |
| *** slaweq has joined #openstack-nova | 02:09 | |
| *** liuzz has quit IRC | 02:09 | |
| *** liverpooler has joined #openstack-nova | 02:10 | |
| *** liuzz has joined #openstack-nova | 02:10 | |
| *** chyka has joined #openstack-nova | 02:12 | |
| *** slaweq has quit IRC | 02:13 | |
| *** dave-mccowan has joined #openstack-nova | 02:15 | |
| *** mriedem has quit IRC | 02:16 | |
| *** chyka has quit IRC | 02:17 | |
| *** felipemonteiro__ has quit IRC | 02:18 | |
| *** harlowja has quit IRC | 02:24 | |
| *** jeblair has joined #openstack-nova | 02:24 | |
| *** jeblair has quit IRC | 02:24 | |
| *** hiro-kobayashi has joined #openstack-nova | 02:26 | |
| *** Apoorva has joined #openstack-nova | 02:29 | |
| gmann | alex_xu: if you can check this simple one,we can close the BP - https://review.openstack.org/#/c/531061/ | 02:31 |
| alex_xu | gmann: got it | 02:32 |
| gmann | alex_xu: thanks | 02:32 |
| alex_xu | gmann: np | 02:32 |
| *** penick_ has quit IRC | 02:32 | |
| takashin | 02:35 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156 | 02:39 |
| *** mordred has quit IRC | 02:42 | |
| *** Dinesh_Bhor has quit IRC | 02:43 | |
| *** mordred has joined #openstack-nova | 02:43 | |
| *** dave-mccowan has quit IRC | 02:47 | |
| *** liverpooler has quit IRC | 02:47 | |
| *** Apoorva has quit IRC | 02:52 | |
| *** lbragstad has quit IRC | 02:54 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094 | 02:58 |
| *** tuanla____ has joined #openstack-nova | 02:59 | |
| *** tetsuro has joined #openstack-nova | 03:00 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:02 | |
| *** Dinesh_Bhor has quit IRC | 03:02 | |
| *** liverpooler has joined #openstack-nova | 03:08 | |
| *** annp has joined #openstack-nova | 03:20 | |
| *** zhurong has quit IRC | 03:23 | |
| *** Tom-Tom has quit IRC | 03:28 | |
| *** Apoorva has joined #openstack-nova | 03:30 | |
| *** jistr has quit IRC | 03:31 | |
| *** takashin has quit IRC | 03:31 | |
| *** zhurong has joined #openstack-nova | 03:32 | |
| *** hshiina has quit IRC | 03:36 | |
| *** takashin has joined #openstack-nova | 03:39 | |
| *** jeblair has joined #openstack-nova | 03:40 | |
| *** jeblair has quit IRC | 03:41 | |
| *** liverpooler has quit IRC | 03:42 | |
| *** DinaBelova has quit IRC | 03:44 | |
| *** andreykurilin has quit IRC | 03:44 | |
| *** andreykurilin has joined #openstack-nova | 03:44 | |
| *** DinaBelova has joined #openstack-nova | 03:46 | |
| *** abhishekk has joined #openstack-nova | 03:47 | |
| *** lyarwood has quit IRC | 03:49 | |
| *** lyarwood has joined #openstack-nova | 03:50 | |
| *** AlexeyAbashkin has joined #openstack-nova | 03:52 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:55 | |
| *** AlexeyAbashkin has quit IRC | 03:57 | |
| *** udesale has joined #openstack-nova | 03:59 | |
| *** hshiina has joined #openstack-nova | 03:59 | |
| *** tbh_ has joined #openstack-nova | 04:00 | |
| *** digambar has joined #openstack-nova | 04:02 | |
| *** sree has joined #openstack-nova | 04:07 | |
| *** sree has quit IRC | 04:11 | |
| *** jeblair has joined #openstack-nova | 04:12 | |
| *** jeblair has quit IRC | 04:24 | |
| *** AlexeyAbashkin has joined #openstack-nova | 04:25 | |
| *** sree has joined #openstack-nova | 04:26 | |
| *** AlexeyAbashkin has quit IRC | 04:29 | |
| *** hshiina2 has joined #openstack-nova | 04:30 | |
| *** hshiina has quit IRC | 04:33 | |
| *** vladikr has quit IRC | 04:34 | |
| *** Dinesh_Bhor has quit IRC | 04:34 | |
| *** links has joined #openstack-nova | 04:37 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:37 | |
| *** Dinesh_Bhor has quit IRC | 04:38 | |
| *** hongbin has quit IRC | 04:38 | |
| *** itlinux has quit IRC | 04:39 | |
| *** zhurong has quit IRC | 04:40 | |
| *** links has quit IRC | 04:40 | |
| *** gouthamr has quit IRC | 04:41 | |
| *** janki has joined #openstack-nova | 04:41 | |
| *** Tom-Tom has joined #openstack-nova | 04:43 | |
| *** namnh has joined #openstack-nova | 04:44 | |
| *** david-lyle has joined #openstack-nova | 04:46 | |
| *** links has joined #openstack-nova | 04:46 | |
| *** david-lyle has quit IRC | 04:53 | |
| *** Tom-Tom has quit IRC | 04:55 | |
| *** Tom-Tom has joined #openstack-nova | 04:55 | |
| *** kumarmn has joined #openstack-nova | 04:57 | |
| *** Apoorva has quit IRC | 04:58 | |
| *** yamamoto has joined #openstack-nova | 04:58 | |
| *** Tom-Tom has quit IRC | 05:00 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:00 | |
| *** hoonetorg has quit IRC | 05:00 | |
| *** kumarmn has quit IRC | 05:02 | |
| *** kumarmn has joined #openstack-nova | 05:06 | |
| *** sree has quit IRC | 05:10 | |
| *** brad[] has quit IRC | 05:10 | |
| *** karthiks has joined #openstack-nova | 05:10 | |
| *** sree has joined #openstack-nova | 05:10 | |
| *** kumarmn has quit IRC | 05:11 | |
| *** artom_ has quit IRC | 05:11 | |
| *** sree has quit IRC | 05:12 | |
| *** sree has joined #openstack-nova | 05:12 | |
| *** hoonetorg has joined #openstack-nova | 05:14 | |
| *** jeblair has joined #openstack-nova | 05:14 | |
| *** sree has quit IRC | 05:15 | |
| *** sridharg has joined #openstack-nova | 05:17 | |
| *** sree has joined #openstack-nova | 05:17 | |
| *** jeblair has quit IRC | 05:20 | |
| *** jeblair has joined #openstack-nova | 05:21 | |
| *** jeblair is now known as corvus | 05:21 | |
| *** sree has quit IRC | 05:23 | |
| *** harlowja has joined #openstack-nova | 05:24 | |
| *** ratailor has joined #openstack-nova | 05:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform rescue/unrescue instance notifications https://review.openstack.org/385644 | 05:25 |
| *** hshiina3 has joined #openstack-nova | 05:26 | |
| *** yamamoto_ has joined #openstack-nova | 05:29 | |
| *** chyka has joined #openstack-nova | 05:29 | |
| *** hshiina2 has quit IRC | 05:30 | |
| *** Tom-Tom has joined #openstack-nova | 05:30 | |
| *** gouthamr has joined #openstack-nova | 05:32 | |
| *** takashin has left #openstack-nova | 05:33 | |
| *** chyka has quit IRC | 05:33 | |
| *** yamamoto has quit IRC | 05:33 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334 | 05:34 |
| *** gyee has quit IRC | 05:36 | |
| *** artom has joined #openstack-nova | 05:37 | |
| *** markvoelker has joined #openstack-nova | 05:39 | |
| *** psachin has joined #openstack-nova | 05:40 | |
| *** sree has joined #openstack-nova | 05:42 | |
| *** yamamoto has joined #openstack-nova | 05:46 | |
| *** yamamoto_ has quit IRC | 05:49 | |
| *** sree_ has joined #openstack-nova | 05:50 | |
| *** sree_ is now known as Guest40634 | 05:50 | |
| *** sree has quit IRC | 05:50 | |
| *** sandanar has joined #openstack-nova | 05:51 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 05:51 |
| *** Dinesh_Bhor has quit IRC | 05:59 | |
| *** edmondsw has joined #openstack-nova | 06:00 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | 06:00 |
| *** karthiks has quit IRC | 06:04 | |
| *** edmondsw has quit IRC | 06:04 | |
| *** claudiub has joined #openstack-nova | 06:05 | |
| *** oanson has joined #openstack-nova | 06:06 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 06:11 |
| *** tbachman_ has joined #openstack-nova | 06:16 | |
| *** zhurong has joined #openstack-nova | 06:16 | |
| *** oanson has quit IRC | 06:18 | |
| *** tbachman has quit IRC | 06:18 | |
| *** tbachman_ is now known as tbachman | 06:18 | |
| *** oanson has joined #openstack-nova | 06:22 | |
| *** moshele has joined #openstack-nova | 06:23 | |
| *** gouthamr has quit IRC | 06:23 | |
| *** pcaruana has joined #openstack-nova | 06:27 | |
| *** licanwei has joined #openstack-nova | 06:29 | |
| *** avolkov has joined #openstack-nova | 06:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:33 | |
| *** pcaruana has quit IRC | 06:33 | |
| *** pcaruana has joined #openstack-nova | 06:34 | |
| *** karthiks has joined #openstack-nova | 06:34 | |
| *** lajoskatona has joined #openstack-nova | 06:35 | |
| *** fragatina has quit IRC | 06:36 | |
| *** sree has joined #openstack-nova | 06:40 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | 06:40 |
| *** Guest40634 has quit IRC | 06:41 | |
| *** sree has quit IRC | 06:44 | |
| *** sree has joined #openstack-nova | 06:44 | |
| *** sree has quit IRC | 06:50 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 06:50 |
| *** gcb has quit IRC | 06:55 | |
| *** udesale__ has joined #openstack-nova | 06:57 | |
| *** udesale has quit IRC | 06:59 | |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | 07:04 |
| *** tuanla____ has quit IRC | 07:04 | |
| *** tuanla____ has joined #openstack-nova | 07:05 | |
| *** masber has quit IRC | 07:08 | |
| *** damien_r has joined #openstack-nova | 07:08 | |
| *** slaweq has joined #openstack-nova | 07:09 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | 07:14 |
| *** slaweq has quit IRC | 07:14 | |
| *** rcernin has quit IRC | 07:15 | |
| *** sree has joined #openstack-nova | 07:19 | |
| *** udesale has joined #openstack-nova | 07:19 | |
| *** fnordahl has quit IRC | 07:20 | |
| *** udesale has quit IRC | 07:20 | |
| *** udesale__ has quit IRC | 07:21 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 07:22 |
| *** kumarmn has joined #openstack-nova | 07:22 | |
| *** fnordahl has joined #openstack-nova | 07:22 | |
| *** sree has quit IRC | 07:23 | |
| *** kumarmn has quit IRC | 07:27 | |
| *** sree has joined #openstack-nova | 07:29 | |
| *** moshele has quit IRC | 07:29 | |
| *** moshele has joined #openstack-nova | 07:31 | |
| *** sree has quit IRC | 07:34 | |
| *** armax has quit IRC | 07:35 | |
| *** threestrands has quit IRC | 07:36 | |
| *** sree has joined #openstack-nova | 07:38 | |
| *** Dinesh_Bhor has quit IRC | 07:39 | |
| *** sree has quit IRC | 07:43 | |
| openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | 07:44 |
| *** sree has joined #openstack-nova | 07:44 | |
| *** armax has joined #openstack-nova | 07:47 | |
| *** digambar has quit IRC | 07:47 | |
| *** harlowja has quit IRC | 07:49 | |
| *** sree has quit IRC | 07:49 | |
| *** hoonetorg has quit IRC | 07:50 | |
| *** kholkina has joined #openstack-nova | 07:55 | |
| *** ameeda has joined #openstack-nova | 07:57 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:57 | |
| ameeda | Morning :) | 07:59 |
| ameeda | please review my code here "https://review.openstack.org/#/c/526900/" and let me know if I need to write microversions. | 07:59 |
| ameeda | Yikun Jiang (Kero) asked me to write microversions since he said that I changed a status code on a particular response. | 07:59 |
| ameeda | Thanks ! | 08:00 |
| *** kumarmn has joined #openstack-nova | 08:00 | |
| *** armax has quit IRC | 08:01 | |
| *** matrohon has joined #openstack-nova | 08:05 | |
| yikun | @ameeda, actually, I'm not sure we should add a new micro version in this change or not. | 08:05 |
| yikun | yeah, we change the status code and API behaviour when "Metadata property value > 255".(400 ---> 200) | 08:05 |
| yikun | but as @jichen mentioned: we don't accept 255 before and now we accept it , no impact to end user ? | 08:06 |
| yikun | I think you maybe can get some help from @alex_xu or @takashi. | 08:06 |
| *** kumarmn has quit IRC | 08:07 | |
| *** hoonetorg has joined #openstack-nova | 08:07 | |
| *** armax has joined #openstack-nova | 08:08 | |
| ameeda | yikun: thanks alot :) | 08:10 |
| ameeda | alex_xu: are you around ? | 08:10 |
| ameeda | takashi: also ? | 08:10 |
| alex_xu | ameeda: I added it into my review list, will try it asap | 08:12 |
| *** Dinesh_Bhor has quit IRC | 08:13 | |
| ameeda | alex_xu: thank you very much :) | 08:13 |
| *** tesseract has joined #openstack-nova | 08:14 | |
| *** sree has joined #openstack-nova | 08:16 | |
| *** ralonsoh has joined #openstack-nova | 08:16 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:17 | |
| *** Dinesh_Bhor has quit IRC | 08:19 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:20 | |
| *** damien_r has quit IRC | 08:20 | |
| *** karthiks has quit IRC | 08:20 | |
| *** tbh_ has quit IRC | 08:20 | |
| *** sree has quit IRC | 08:20 | |
| *** sree has joined #openstack-nova | 08:21 | |
| *** zhaochao has joined #openstack-nova | 08:23 | |
| *** alexchadin has joined #openstack-nova | 08:24 | |
| *** sahid has joined #openstack-nova | 08:26 | |
| *** alex_xu has quit IRC | 08:28 | |
| *** alex_xu has joined #openstack-nova | 08:29 | |
| *** karthiks has joined #openstack-nova | 08:32 | |
| gmann | ameeda: alex_xu we are all good in term of microversion, this does not change the API behavior | 08:36 |
| gmann | need to check whether it fix the reported bug or not | 08:37 |
| *** tetsuro has quit IRC | 08:39 | |
| *** sree has quit IRC | 08:39 | |
| *** ragiman has joined #openstack-nova | 08:40 | |
| *** sree has joined #openstack-nova | 08:41 | |
| *** karthiks has quit IRC | 08:44 | |
| *** jpena|off is now known as jpena | 08:45 | |
| *** damien_r has joined #openstack-nova | 08:45 | |
| *** sree has quit IRC | 08:45 | |
| *** hiro-kobayashi has quit IRC | 08:51 | |
| gmann | ameeda: left comment there | 08:52 |
| *** Dinesh_Bhor has quit IRC | 08:53 | |
| *** jaosorior has joined #openstack-nova | 08:54 | |
| openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | 08:55 |
| *** jistr has joined #openstack-nova | 08:57 | |
| *** sree has joined #openstack-nova | 08:59 | |
| bauzas | morning Novaers | 08:59 |
| *** karthiks has joined #openstack-nova | 08:59 | |
| gmann | morning | 09:01 |
| ameeda | gmann: Thank you for review, so I need to return the master code, this restrict the length of the value, I removed the limitations for that ? I will change the reno. also add a functional regression test. | 09:01 |
| gmann | ameeda: you mean this? - https://review.openstack.org/#/c/526900/17/nova/compute/api.py | 09:03 |
| ameeda | gmann: yes | 09:04 |
| *** sree has quit IRC | 09:04 | |
| gmann | ameeda: i checked and it should not have impact but let me confirm again. | 09:04 |
| *** moshele has quit IRC | 09:04 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:04 | |
| ameeda | gmann: thanks :) | 09:05 |
| gmann | ameeda: np! | 09:05 |
| *** Dinesh_Bhor has quit IRC | 09:06 | |
| *** tommylikehu has quit IRC | 09:07 | |
| *** markvoelker has quit IRC | 09:08 | |
| *** tommylikehu has joined #openstack-nova | 09:08 | |
| *** moshele has joined #openstack-nova | 09:08 | |
| *** owalsh has quit IRC | 09:09 | |
| *** owalsh has joined #openstack-nova | 09:10 | |
| *** hshiina3 has quit IRC | 09:11 | |
| *** slaweq_ has joined #openstack-nova | 09:11 | |
| *** diga has joined #openstack-nova | 09:12 | |
| *** slaweq_ has quit IRC | 09:15 | |
| gmann | ameeda: i still not find if that code truncated the value in case of system metadata | 09:22 |
| gmann | ameeda: any failure link etc? | 09:22 |
| *** gnuoy has joined #openstack-nova | 09:24 | |
| ameeda | gmann: I am not sure. I still beginner with nova and openstack, so you guess that I need to restore the original code ? | 09:24 |
| gmann | ameeda: np!. let's not change that and see whether bug is fixed or not. you can check locally also and by adding functional tests also | 09:25 |
| gmann | ameeda: if something compute/api.py change needs to do we can do later. but i am sure changing DB field and util function should work | 09:26 |
| ameeda | gmann: what about functional tests. its important ? if so, how I can do that ? | 09:27 |
| *** Dinesh_Bhor has joined #openstack-nova | 09:29 | |
| *** andreas_s has joined #openstack-nova | 09:30 | |
| *** sree has joined #openstack-nova | 09:30 | |
| *** lucas-afk is now known as lucasagomes | 09:31 | |
| *** licanwei has quit IRC | 09:31 | |
| gmann | ameeda: yea it is imp to see bug is fixed and it does not regress . example is like these tests - https://github.com/openstack/nova/tree/master/nova/tests/functional/regressions | 09:31 |
| ameeda | gmann: thanks for your help and your time. | 09:32 |
| gmann | ameeda: with that we can get to know whether bug is actually fixed and no more hidden restriction/truncation etc | 09:32 |
| gmann | ameeda: np! | 09:32 |
| *** Dinesh_Bhor has quit IRC | 09:32 | |
| *** sree has quit IRC | 09:35 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/497457 | 09:35 |
| *** sandanar has quit IRC | 09:42 | |
| *** derekh has joined #openstack-nova | 09:42 | |
| *** sandanar has joined #openstack-nova | 09:43 | |
| *** tianhui has quit IRC | 09:44 | |
| *** liuzz has quit IRC | 09:49 | |
| *** liuzz_ has joined #openstack-nova | 09:49 | |
| *** lpetrut has joined #openstack-nova | 09:50 | |
| openstackgerrit | caishan proposed openstack/nova master: Unit testing test_driver.py indent issue https://review.openstack.org/532473 | 09:53 |
| openstackgerrit | caishan proposed openstack/nova master: Unit testing test_driver.py indent issue https://review.openstack.org/532473 | 09:57 |
| *** diga has quit IRC | 10:01 | |
| *** kumarmn has joined #openstack-nova | 10:03 | |
| *** sridharg has quit IRC | 10:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix typo in release note https://review.openstack.org/531854 | 10:07 |
| *** kumarmn has quit IRC | 10:07 | |
| *** yamamoto has quit IRC | 10:11 | |
| *** mdnadeem has quit IRC | 10:13 | |
| *** sambetts|afk is now known as sambetts | 10:13 | |
| *** diga has joined #openstack-nova | 10:15 | |
| *** kumarmn has joined #openstack-nova | 10:18 | |
| *** jichen has quit IRC | 10:20 | |
| *** threestrands has joined #openstack-nova | 10:21 | |
| *** kumarmn has quit IRC | 10:22 | |
| mdbooth | lyarwood: Could you take a look at https://review.openstack.org/#/c/531524/ ? I'd like to encourage the author to resurrect your stable rescue series instead. | 10:24 |
| *** dtantsur|afk is now known as dtantsur | 10:24 | |
| lyarwood | mdbooth: sure, there's a spec up for review for this, might provide the feedback there - https://review.openstack.org/#/c/532410/3/specs/rocky/approved/volume-backed-server-rescue.rst | 10:26 |
| mdbooth | Hmm. I didn't see that linked from the bp. | 10:27 |
| lyarwood | mdbooth: it isn't, it's on the gerrit topic. | 10:28 |
| mdbooth | Eurgh. | 10:28 |
| stephenfin | lyarwood: Small question here https://review.openstack.org/#/c/460243/13/nova/virt/libvirt/driver.py@1273 | 10:29 |
| mdbooth | I reviewed the patch anyway, which had issues. I pointed out your series as a much more thorough alternative which was also previously nearly across the line. | 10:29 |
| *** alexchadin has quit IRC | 10:32 | |
| *** alexchadin has joined #openstack-nova | 10:33 | |
| *** annp has quit IRC | 10:34 | |
| *** gszasz has joined #openstack-nova | 10:34 | |
| *** phuongnh has quit IRC | 10:34 | |
| mdbooth | stephenfin: I answered for him :) | 10:36 |
| stephenfin | mdbooth: Ta! | 10:38 |
| stephenfin | That's done now, as promised | 10:38 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | 10:45 |
| *** ebbex has quit IRC | 10:49 | |
| lyarwood | stephenfin / mdbooth ; yup thanks, context is still required for attach | 10:50 |
| *** cdent has joined #openstack-nova | 10:50 | |
| *** namnh has quit IRC | 10:51 | |
| *** matrohon has quit IRC | 10:54 | |
| *** tuanla____ has quit IRC | 10:55 | |
| *** yamamoto has joined #openstack-nova | 10:55 | |
| *** zhurong has quit IRC | 10:56 | |
| *** abhishekk has quit IRC | 10:57 | |
| *** Tom-Tom has quit IRC | 10:59 | |
| *** Tom-Tom has joined #openstack-nova | 11:00 | |
| *** alexchadin has quit IRC | 11:06 | |
| *** alexchadin has joined #openstack-nova | 11:06 | |
| *** Tom-Tom has quit IRC | 11:07 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | 11:07 |
| *** andreas_s has quit IRC | 11:08 | |
| *** markvoelker has joined #openstack-nova | 11:08 | |
| *** alexchadin has quit IRC | 11:09 | |
| *** andreas_s has joined #openstack-nova | 11:09 | |
| openstackgerrit | Liam Young proposed openstack/nova master: Add exception to no-upcall note of cells doc https://review.openstack.org/532491 | 11:11 |
| *** yangyapeng has quit IRC | 11:12 | |
| sean-k-mooney | did they upgrade gerrit recently? i just commented on a patch set 15 of someting and it included old draft comment i had on patchset 4 also... | 11:14 |
| sean-k-mooney | granted it did at least include them on the patchset 4 version but still that annoying when you cant see that they are there | 11:15 |
| gibi | sean-k-mooney: yeah, this is a new feature from the last gerrit upgrade | 11:17 |
| gibi | sean-k-mooney: but the upgrade happened couple of months ago | 11:17 |
| *** AlexeyAbashkin has quit IRC | 11:18 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:18 | |
| *** yamahata has quit IRC | 11:22 | |
| *** andreas_s has quit IRC | 11:23 | |
| *** andreas_s has joined #openstack-nova | 11:23 | |
| *** yangyapeng has joined #openstack-nova | 11:25 | |
| *** sree has joined #openstack-nova | 11:25 | |
| sean-k-mooney | gibi: oh really i guess i have just been lucky enough not to hit it till now. if i start a review and there are new revions in between i normally start again and copy the comments but dont always delete the old ones since they were ignored | 11:30 |
| *** breton has left #openstack-nova | 11:30 | |
| *** sree has quit IRC | 11:30 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 11:30 |
| *** andreas_s has quit IRC | 11:37 | |
| *** andreas_s has joined #openstack-nova | 11:38 | |
| *** alexchadin has joined #openstack-nova | 11:39 | |
| *** moshele has quit IRC | 11:39 | |
| *** moshele has joined #openstack-nova | 11:40 | |
| *** alexchadin has quit IRC | 11:41 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/nova stable/pike: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/532504 | 11:42 |
| hrw | as it went to master it would be good to have it in pike too ;D | 11:42 |
| *** markvoelker has quit IRC | 11:42 | |
| *** moshele has quit IRC | 11:42 | |
| openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | 11:44 |
| *** sridharg has joined #openstack-nova | 11:48 | |
| *** andreas_s has quit IRC | 11:48 | |
| *** andreas_s has joined #openstack-nova | 11:49 | |
| *** diga has quit IRC | 11:50 | |
| mdbooth | lyarwood: Sorry :/ https://review.openstack.org/#/c/460243/ | 11:53 |
| *** purplerbot has quit IRC | 11:53 | |
| openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | 11:54 |
| *** yamamoto has quit IRC | 11:55 | |
| *** abalutoiu has joined #openstack-nova | 11:57 | |
| *** nicolasbock has joined #openstack-nova | 11:57 | |
| *** sdague has joined #openstack-nova | 11:58 | |
| *** alexchadin has joined #openstack-nova | 12:00 | |
| *** yamamoto has joined #openstack-nova | 12:00 | |
| *** ratailor has quit IRC | 12:04 | |
| *** Eran_Kuris has quit IRC | 12:09 | |
| *** yamamoto has quit IRC | 12:11 | |
| *** smatzek has joined #openstack-nova | 12:20 | |
| *** Rambo has joined #openstack-nova | 12:22 | |
| *** purplerbot has joined #openstack-nova | 12:23 | |
| Rambo | Hi,everyone ,Can you help me to review the spec ?The link is https://review.openstack.org/#/c/532410/ | 12:24 |
| Rambo | Another is :https://review.openstack.org/#/c/532407/ | 12:25 |
| Rambo | Thank you very much | 12:25 |
| *** yamamoto has joined #openstack-nova | 12:26 | |
| *** lucasagomes is now known as lucas-hungry | 12:27 | |
| *** janki has quit IRC | 12:27 | |
| sean-k-mooney | melwitt: stephenfin bauzas o/ do any of ye know the url to the ptg etherpad matt started. ill grab it from the irc logs if not so noworries if you dont have it to hand. | 12:29 |
| *** brad[] has joined #openstack-nova | 12:29 | |
| sean-k-mooney | melwitt: stephenfin bauzas found it https://etherpad.openstack.org/p/nova-ptg-rocky | 12:30 |
| *** sdague has quit IRC | 12:31 | |
| lyarwood | mdbooth: np, fired back, I really don't like that comment with the encryptor.detach_volume call removed | 12:31 |
| lyarwood | mdbooth: it should be pretty obvious that you can't disconnect a volume before detaching it from the guest tbh | 12:32 |
| lyarwood | mdbooth: and the tests should catch anyone trying to do this | 12:32 |
| *** yamamoto has quit IRC | 12:32 | |
| kashyap | lyarwood: Sometimes explicit is better than implicit. What is obvious to you would be a far cry from it for a fresh pair of eyes trying to get up2speed. | 12:33 |
| kashyap | I'm personally a fan of documenting in comments, even if sometimes it's a bit obvious if you're in the know | 12:34 |
| *** moshele has joined #openstack-nova | 12:35 | |
| *** sean-k-mooney has quit IRC | 12:35 | |
| *** ygl has joined #openstack-nova | 12:36 | |
| ygl | hi all | 12:36 |
| ygl | can someone help me with my issue | 12:36 |
| *** ygl has left #openstack-nova | 12:37 | |
| *** markvoelker has joined #openstack-nova | 12:39 | |
| openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | 12:43 |
| *** gcb has joined #openstack-nova | 12:43 | |
| *** dtruong has quit IRC | 12:44 | |
| *** dtruong has joined #openstack-nova | 12:44 | |
| *** jpena is now known as jpena|lunch | 12:48 | |
| lyarwood | *sigh* | 12:51 |
| lyarwood | kashyap: so how would the comment help someone reviewing that method for the first time? | 12:52 |
| lyarwood | kashyap: given that the call to detach the encryptor is now hidden from them in _disconnect_volume | 12:52 |
| lyarwood | kashyap: I'm all for helping first time readers through code but it makes the entire thing more confusing IMHO | 12:53 |
| *** vivsoni has quit IRC | 12:54 | |
| *** Rambo has quit IRC | 12:54 | |
| *** vivsoni has joined #openstack-nova | 12:54 | |
| kashyap | lyarwood: Hmm, if you think it'll confuse more, I'll defer to you. | 12:55 |
| kashyap | lyarwood: I noticed what you said is missing in your review comment | 12:55 |
| kashyap | lyarwood: Then maybe you'd want to note that the call to detach the encryptor is elsewhere :-) | 12:56 |
| *** sean-k-mooney has joined #openstack-nova | 12:56 | |
| *** takashin has joined #openstack-nova | 12:58 | |
| *** links has quit IRC | 12:58 | |
| takashin | alex_xu: Are you aroud? | 13:01 |
| *** edmondsw has joined #openstack-nova | 13:01 | |
| alex_xu | takashin: yea | 13:02 |
| takashin | alex_xu: Is there API meeting today? | 13:02 |
| alex_xu | takashin: yes, but passed few weeks, there is no people show up, then I didn't run it, is there anything you want to discuss, we can discussed at here I think | 13:03 |
| takashin | alex_xu: Okay. I have 2 patches for reviews. | 13:03 |
| takashin | api-ref: Parameter verification for servers.inc: https://review.openstack.org/#/c/528201/ | 13:04 |
| gmann | alex_xu: takashin i was away too since 2-3 weeks. we can resume from next week may be | 13:04 |
| takashin | api-ref: Example verification for servers.inc: https://review.openstack.org/#/c/529520/ | 13:04 |
| takashin | gmann: thanks. | 13:04 |
| takashin | alex_xu: gmann: Would you review the patches? | 13:05 |
| alex_xu | gmann: cool, we will run it | 13:05 |
| alex_xu | takashin: I add them to my review list, will try to reach them | 13:05 |
| gmann | takashin: ywa, i remember to review those half way last week, ll do tomorrow for sure | 13:05 |
| takashin | alex_xu: gmann: Thank you. | 13:05 |
| takashin | That's all. | 13:06 |
| *** yikun_ has joined #openstack-nova | 13:06 | |
| alex_xu | takashin: did you see my comment https://review.openstack.org/#/c/459483/, I think that is thing we should keep consistent, and I think that isn't worth another microversion | 13:06 |
| takashin | alex_xu: I saw your comment. I will fix it tomorrow. | 13:07 |
| alex_xu | takashin: thanks | 13:07 |
| alex_xu | takashin: gmann btw, there is API patch closed to merge https://review.openstack.org/#/c/330406, I'm reviewing it, but still still found something, it will be great you guys can help review it also, the API patch is really huge :) | 13:08 |
| mdbooth | lyarwood: Anyway, like I said the patch is a huge improvement, I don't see any issues in the code. It's simpler and it fixes at least 3 bugs. I'm just cautious about removing context from a driver which is already plenty opaque in places. | 13:08 |
| gmann | alex_xu: sure, added in my tomorrow list | 13:09 |
| takashin | alex_xu: okay. I will review it tomorrow. | 13:09 |
| *** smatzek has quit IRC | 13:09 | |
| alex_xu | gmann: takashin thanks! | 13:10 |
| *** markvoelker has quit IRC | 13:12 | |
| *** smatzek has joined #openstack-nova | 13:14 | |
| kashyap | mdbooth: Do you recall top off your head, in what scenarios Nova calls 'qemu-img info' for _running_ guests? | 13:14 |
| *** mvk has quit IRC | 13:14 | |
| kashyap | If not, don't worry, I'll go look into code | 13:14 |
| mdbooth | kashyap: Not off the top of my head, but pretty sure there are some. | 13:15 |
| *** janki has joined #openstack-nova | 13:15 | |
| *** takashin has left #openstack-nova | 13:15 | |
| mdbooth | Look at live migration. Maybe imagecache reaper. | 13:16 |
| kashyap | mdbooth: Okido, I'm in a discussion w/ the QEMU Block folks, and they're asking this. | 13:19 |
| kashyap | I'm sure we do, just have to audit | 13:19 |
| efried | mgoddard Where's set_traits_for_provider (https://review.openstack.org/#/c/532290/1/nova/compute/resource_tracker.py@890) defined? I can't find it in master or in your series. | 13:19 |
| efried | mgoddard I ask because I'm actually in the process of implementing that method right now. | 13:20 |
| *** moshele has quit IRC | 13:20 | |
| efried | mgoddard Want to avoid duplication of effort if possible. | 13:20 |
| *** yamamoto has joined #openstack-nova | 13:21 | |
| *** ttx has quit IRC | 13:21 | |
| *** lucas-hungry is now known as lucasagomes | 13:22 | |
| *** ttx has joined #openstack-nova | 13:23 | |
| *** andreas_s has quit IRC | 13:27 | |
| *** sree has joined #openstack-nova | 13:30 | |
| mgoddard | efried: hi. I'm still implementing that one. I can submit what I have for review if you'd like to see it | 13:31 |
| efried | mgoddard I would, yes. I'll show you mine if you show me yours :) | 13:32 |
| *** andreas_s has joined #openstack-nova | 13:32 | |
| mgoddard | efried: well I don't usually do this, but go on then | 13:33 |
| efried | mgoddard You're probably a little further along BUT one of the key things I'm doing there is exposing a new exception base class for placement API conflicts and raising subclasses thereof from this method and its brethren (e.g. set_aggregates_for_provider, tbd) when they encounter 409s. | 13:34 |
| efried | mgoddard It's in the middle of a rather messy restack, won't be ready to show for a little while yet. | 13:34 |
| efried | mgoddard But now that I know you're also wanting it for the ironic traits bp, seems it needs to be peeled out of that series. | 13:35 |
| efried | which is probably not super hard. Though at the moment it's based on a change that raises a conflict exception for RP creation, which I think *is* tied pretty heavily into that series. | 13:36 |
| *** andreas_s has quit IRC | 13:37 | |
| *** alexchadin has quit IRC | 13:38 | |
| *** andreas_s has joined #openstack-nova | 13:38 | |
| *** andreas_s has quit IRC | 13:40 | |
| *** andreas_s has joined #openstack-nova | 13:40 | |
| *** andreas__ has joined #openstack-nova | 13:41 | |
| *** sree has quit IRC | 13:43 | |
| kashyap | mdbooth: Just noting for the record, looked for the past few minutes: | 13:44 |
| kashyap | _rebase_with_qemu_img() , _live_snapshot() and _get_instance_disk_info_from_config() [from nova/virt/libvirt/driver.py] | 13:44 |
| kashyap | nova/virt/libvirt/imagebackend.py: | 13:44 |
| kashyap | - cache() --> fetch_func_sync() --> get_disk_size() --> qemu_img_info() | 13:44 |
| sean-k-mooney | efried: QQ is there a top level api for placement aggregates? e.g. can i list all aggregates or list all resocue providers in an aggregate given the aggregate uuid? | 13:45 |
| *** andreas_s has quit IRC | 13:45 | |
| efried | sean-k-mooney sec... | 13:45 |
| *** moshele has joined #openstack-nova | 13:45 | |
| efried | sean-k-mooney Hum, I thought there was, cause I'm gonna need it. Still looking... | 13:46 |
| *** ameeda_ has joined #openstack-nova | 13:46 | |
| sean-k-mooney | efried: no rush. you can get teh aggregates a resouce provider is part of but at least looking at the master docs the recprical api does not appear to exist | 13:46 |
| cdent | you can use member_of to get all rps in a given aggregate | 13:46 |
| efried | Ahh, that's it, thanks cdent | 13:47 |
| cdent | https://developer.openstack.org/api-ref/placement/#list-resource-providers | 13:47 |
| cdent | It's not clear how you're supposed to discovery an aggregate, though, other than by looking at https://developer.openstack.org/api-ref/placement/#list-resource-provider-aggregates | 13:47 |
| cdent | or knowing the uuid prior | 13:48 |
| *** pchavva has joined #openstack-nova | 13:48 | |
| mdbooth | kashyap: I'm not convinced cache() would be called on a running instance. As always with that code, though, it's far from obvious without checking carefully. | 13:48 |
| mdbooth | kashyap: cache() mostly means 'create' | 13:48 |
| kashyap | mdbooth: Yeah, I should've been careful in pointing that out | 13:48 |
| efried | cdent Yeah. That said, is there a use case for that? | 13:48 |
| *** sree has joined #openstack-nova | 13:48 | |
| sean-k-mooney | cdent: ah yes cool. that still leaves me with one question. how do i create the aggreate in the first place with out a top level aggregates api? | 13:48 |
| cdent | efried: not that I'm aware, but just as I was thinking of it I stumbled on "How do I know the aggregates" | 13:49 |
| cdent | sean-k-mooney: it gets created when you use it | 13:49 |
| *** yamamoto has quit IRC | 13:49 | |
| kashyap | mdbooth: I didn't do a thorough audit, though. Taking notes as I find instances of it & then see where they're called on a running guest | 13:49 |
| kashyap | For live snapshot we do for sure | 13:49 |
| cdent | so if you PUT to /resource_provider/{uuid}/aggregates with a new uuid there ya go | 13:50 |
| efried | sean-k-mooney You "create" it by assigning it to a provider via PUT /rp/{uuid}/aggs | 13:50 |
| sean-k-mooney | cdent: so the first time i add a resouce provider to an agregate it creates the uuid | 13:50 |
| efried | yeah, what he said. | 13:50 |
| cdent | yes | 13:50 |
| mdbooth | kashyap: Did you look in the imagecache periodic task? | 13:50 |
| kashyap | mdbooth: Not yet; so far I'm just noting down instances where it's called. E.g: | 13:50 |
| kashyap | nova/virt/libvirt/imagebackend.py | 13:50 |
| kashyap | - cache() --> fetch_func_sync() | 13:50 |
| kashyap | --> get_disk_size() [from nova/virt/libvirt/driver.py] | 13:50 |
| kashyap | --> qemu_img_info() [from nova/virt/images.py] | 13:50 |
| kashyap | - verify_base_size() --> get_disk_size() | 13:50 |
| kashyap | - class LVM() --> create_image() --> create_lvm_image() --> get_disk_size() --> qemu_img_info() | 13:50 |
| sean-k-mooney | cdent: so the problem of determining an un used uuid for the aggregate is left to the client | 13:51 |
| cdent | yes | 13:51 |
| efried | sean-k-mooney I knew I wrote that code: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L431 | 13:51 |
| kashyap | (And then see the calls for the live guest.) | 13:51 |
| *** jpena|lunch is now known as jpena | 13:51 | |
| sean-k-mooney | cdent: ok cool. more reading for me to do :) | 13:51 |
| cdent | sean-k-mooney: there's some stuff in the very early rp specs about such things | 13:51 |
| efried | sean-k-mooney There shouldn't be any such thing as an "unused" aggregate UUID. Unless you mean "used only for one provider", which is pointless. | 13:51 |
| *** moshele has quit IRC | 13:51 | |
| cdent | but if I remember right, the thinking was that the client would already have some identifier in min | 13:52 |
| cdent | d | 13:52 |
| *** alexchadin has joined #openstack-nova | 13:52 | |
| efried | ...because when you remove the last association, placement ought to get rid of that agg ID. | 13:52 |
| efried | cdent Yeah, that's a weird one. In the PowerVM SSP case, the only thing that makes sense is to give the agg the same UUID as the shared storage pool | 13:53 |
| efried | Though I *suppose* I could give the agg the UUID of the cluster instead. It's effectively the same thing in powervm land. | 13:53 |
| *** sree has quit IRC | 13:53 | |
| sean-k-mooney | efried: well what i mean is if i am createing a set of recouse providers and i want to make them part of a aggregate to group them i need to choose a uuid that is not useed by anyone else. | 13:53 |
| cdent | placement does not clean up the unused agg uuids. that was an early design decision, sort of resulting from how the tables were being normalized to not use uuid keys (and a few others things, it's so long ago) | 13:54 |
| efried | sean-k-mooney Yes, which one would normally do by generating one randomly, BUT that breaks down quickly if you have more than one point of control for that agg. | 13:54 |
| efried | cdent Whoah, so how do they get cleaned up? | 13:54 |
| cdent | they don't | 13:54 |
| cdent | at least not last I checked | 13:55 |
| efried | They just... leak? | 13:55 |
| mgoddard | efried: I have some concerns with the storage of the generation in the provider tree | 13:55 |
| mgoddard | efried: there is a single generation per-provider that covers inventory, traits, and aggregates | 13:55 |
| mgoddard | efried: but if we call e.g. pt.update_inventory() with a new generation, the traits or aggregates for that provider may not necessarily correspond to the generation that gets set | 13:55 |
| mgoddard | efried: I can't see anything that's using the tree's stored generations currently, but presumably they're in there for some future purpose? | 13:55 |
| efried | mgoddard That's precisely what I'm working on right now. | 13:55 |
| cdent | sean-k-mooney: selecting an unused uuid is kind of the easy part of why use uuids? | 13:56 |
| *** sree has joined #openstack-nova | 13:56 | |
| cdent | but you can always check it, with member_of | 13:56 |
| efried | cdent Except for the multi-source sync issue, aforementioned. | 13:56 |
| cdent | link? | 13:57 |
| efried | mgoddard The client code should never be setting/incrementing the generation directly. It should be blindly passing the generation from the API response into those ProviderTree methods. | 13:57 |
| *** vladikr has joined #openstack-nova | 13:57 | |
| sean-k-mooney | cdent: oh yes i know i can just gen a new one. the reson i brought this up is i knind of have a usecase where really i would like to have a resouce provider have two parents but alternively i could use an aggregate to model the second relationship | 13:57 |
| efried | cdent Word salad on that review we discussed in the sched mtg, stand by... | 13:57 |
| mdbooth | kashyap: Ah, looks like I removed qemu-img from that task. | 13:58 |
| cdent | efried: I think in that context were assuming that we're "choosing" a know uuid from some authority | 13:58 |
| cdent | known | 13:58 |
| sean-k-mooney | cdent: yes | 13:58 |
| efried | cdent Which would be fine, if that's what we're doing, AND the multiple control points understand the semantics of the provider having multiple aggs associated or not. | 13:59 |
| cdent | sean-k-mooney: I will keep you in beverages of your choice for the duration of dublin if you promise me to never bring up multi-parents again :) | 13:59 |
| *** sdague has joined #openstack-nova | 14:00 | |
| sean-k-mooney | cdent: efried so in the case of vhost-vfio interfaces i was considering them to be owned by neutron not nova yes i want to model numa relationship too | 14:00 |
| efried | mgoddard Which is what report client should be doing, but isn't yet, but I'm working on it. | 14:00 |
| kashyap | mdbooth: I see, stopped the audit for a bit; will get back. | 14:00 |
| kashyap | mdbooth: https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00845.html -- [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U | 14:00 |
| sean-k-mooney | cdent:hehe yes i know we dont want to have multiple parent so im exploing other options. | 14:00 |
| kashyap | (The "-U" == '--force-share') | 14:01 |
| efried | mgoddard It also sends the generation - whatever was the last value it got when it retrieved the RP record - whenever it updates the RP or associations (traits, aggs*, etc.). And then the placement API bounces with a 409 if that's not the same as the generation it thinks that RP should have. | 14:01 |
| efried | mgoddard The client can/should respond to that by re-GETting the provider/associations, redriving the change, and re-PUTting with the new generation. | 14:01 |
| sean-k-mooney | cdent: basically i want to model the resouce is a sub resouce of a numa node(eventully) and have an easy way to associate them with the neutron agent that manages them | 14:02 |
| sean-k-mooney | cdent: without the numa aspect i had originally considerd modeling the neutron agent as a resouce providers and making it the parent of the sub resouce | 14:02 |
| cdent | that sounds a bit like the model of shared provider where the neutron agent is a resource provider | 14:02 |
| efried | sean-k-mooney Placement won't stop you from doing that, but it would be highly irregular for neutron to own (create/modify/control) a provider in the middle of a tree that's otherwise owned by compute. | 14:03 |
| cdent | I think we've already talked in the past about considering being able to parent neutron rps into a compute generated tree, as leafs | 14:03 |
| sean-k-mooney | efried: well the resoce for this design is i dont think nova long term should be respocible for tracking networking resouces in placement | 14:03 |
| efried | sean-k-mooney It would be preferable if you found a way to model it such that the provider(s) owned by neutron were sharing providers associated by aggregate with ones in the compute's tree. | 14:04 |
| cdent | there was some of that in denver. not that we _will_ do it, but might be able to do it | 14:04 |
| *** sree has quit IRC | 14:04 | |
| *** stvnoyes has joined #openstack-nova | 14:05 | |
| *** ttsiouts has joined #openstack-nova | 14:05 | |
| cdent | I have some vague concerns that the provider tree model in compute is going to make it harder to manage rps from multiple places, which was an original goal | 14:05 |
| *** sree has joined #openstack-nova | 14:05 | |
| efried | I mean, I guess, as long as compute and the neutron agent both agree on how that dance is done. It worries me, though, because different vendors' drivers have to talk to the same neutron agent sometimes. | 14:06 |
| cdent | I need to unvague those concerns, but at the moment I can't even get devstack to do the right things for my simple experiments, so... | 14:06 |
| * cdent nods at efried | 14:06 | |
| sean-k-mooney | cdent: well the issue is i dont think nova should own the root node of the tree. i think we should considerd the root node to be something earch service can create subtree from | 14:07 |
| *** Tom-Tom has joined #openstack-nova | 14:07 | |
| efried | sean-k-mooney What do you call that root node? | 14:08 |
| efried | Is it a host? | 14:08 |
| efried | a "cloud"? | 14:08 |
| efried | some nebulous as-yet-unnamed entity that exists solely as an anchor point for this multi-owner provider tree? | 14:08 |
| efried | ...but doesn't correspond to anything in the real world? | 14:09 |
| cdent | sean-k-mooney: That's kind of related to why I disputed that root provider be a thing in the data struture or representation. I think we should be able to access a tree of providers anywhere in whatever trees people like, and declare subtrees to be whole if that's what suits them. That is, if we're gonna have trees, let's have _trees_. | 14:09 |
| cdent | (I'd rather just not have trees, but that ship sailed) | 14:09 |
| *** lyan has joined #openstack-nova | 14:09 | |
| *** markvoelker has joined #openstack-nova | 14:10 | |
| *** sree has quit IRC | 14:10 | |
| sean-k-mooney | efried: in the case of a nova created tree i was assuming a compute node. e.g. a host yes | 14:11 |
| efried | sean-k-mooney Right, I was referring to what you said earlier about "i dont think nova should own the root node of the tree" and "the root node [is] something each service can create subtree from" | 14:12 |
| sean-k-mooney | yep i think we are violently agreeing on that point :) | 14:12 |
| mgoddard | efried: so with your change, will a generation change in the provider tree cause inventory, traits, and aggregates to be updated, and checked that all those responses contain the same generation? | 14:12 |
| efried | In that picture, who owns the root node, and what does it represent? | 14:12 |
| *** ameeda_ has quit IRC | 14:13 | |
| sean-k-mooney | efried: everyone owns it. i think we just need to agree on how the root node is create for example by saying that the node is idenfied by the host_id which default to the hostname | 14:14 |
| efried | sean-k-mooney But if the root node represents a compute host, doesn't it make sense for compute to own/create it? | 14:14 |
| sean-k-mooney | efried: not in a converged deployment | 14:14 |
| sean-k-mooney | for example if you have cinder running on the same physical server then its also a storage node not just a compute node | 14:15 |
| sean-k-mooney | if cinder and nova agree on how to create/select that root node then can boot create subtrees for that phyical server | 14:16 |
| efried | mgoddard At the report client level, the plan for set_traits_for_provider is: If PUT /rp/{uuid}/traits succeeds (200), I'll update_traits on the ProviderTree, setting the generation based on what's in the PUT response. (The generation is an attribute of the provider, so updating it via update_traits updates it for anything else associated with that provider.) | 14:16 |
| *** gouthamr has joined #openstack-nova | 14:17 | |
| efried | mgoddard If the PUT fails 409, set_traits_for_provider will raise (a subclass of) this new conflict exception. | 14:17 |
| sean-k-mooney | s/ then can boot/ then both can/ | 14:17 |
| efried | mgoddard The report client consumer (i.e. resource tracker) should then redrive the overarching operation, which should entail first asking report client to refresh its cached representation of that provider in the ProviderTree. | 14:18 |
| efried | mgoddard Which means reGETting the provider and all its associated bits (traits, aggs, etc.) and calling the appropriate ProviderTree methods to update them all. | 14:19 |
| efried | mgoddard Then the consumer (resource tracker) would make whatever change again (in this example setting the traits). Rinse, repeat. | 14:19 |
| efried | mgoddard Not sure if I'm explaining this particularly well. | 14:20 |
| sean-k-mooney | efried: cdent anyway that when a little off topic but i think one design would be for neutorn to create its resouces under the numa nodes create by nova and add the resouces it creates to an aggreate using the neutron agent uuid as the aggreate uuid. | 14:20 |
| efried | sean-k-mooney Why do you need the aggregate in that picture? | 14:21 |
| efried | sean-k-mooney Are the neutron resources common to multiple hosts? | 14:21 |
| efried | sean-k-mooney If so, they should *not* be created as providers in the tree under the numa nodes. | 14:21 |
| sean-k-mooney | efried: no they are specific to that compute but i want a simple way to look up all the resocurce providers created by the neutron agent on that host | 14:22 |
| *** smatzek has quit IRC | 14:22 | |
| *** mvk has joined #openstack-nova | 14:22 | |
| *** smatzek has joined #openstack-nova | 14:22 | |
| efried | sean-k-mooney Ahhh, that makes sense. | 14:22 |
| efried | sean-k-mooney So the aggregate is really just saying "neutron owns these". It's not associating the providers with any shared providers. | 14:23 |
| efried | sean-k-mooney Which is a crucial distinction, because you wouldn't want an allocation candidate request to bleed across compute trees. | 14:23 |
| efried | sean-k-mooney So in this scenario, the providers are associated with an aggregate, but nobody in that aggregate has the MISC_SHARES_VIA_AGGREGATE trait. | 14:24 |
| *** smatzek has quit IRC | 14:24 | |
| sean-k-mooney | efried: yes exactly | 14:25 |
| efried | mgoddard But note that report client is the pinch point for everything. You can't directly change the report client's cached ProviderTree from outside the report client. Conversely and more importantly, you can't effect a change to placement by changing that cached ProviderTree. You can only do that by calling report client methods like set_*_on_provider etc. | 14:26 |
| efried | mgoddard Where it gets confusing is that ComputeDriver.update_provider_tree *sounds* like it's doing just that (effecting a change to placement by changing the cached ProviderTree). | 14:27 |
| efried | mgoddard Which is almost but not quite the case. | 14:27 |
| efried | mgoddard RT will ask RC for the provider tree; RC will return a *copy*. RT will then ask ComputeDriver to update_provider_tree. RT will then ask RC to diff and flush any changes back to placement, which will update RC's cached ProviderTree in the process. | 14:28 |
| efried | sean-k-mooney Is there any reason that agg ID has to be the same across all the computes for which that neutron instance is handling the network providers? | 14:30 |
| efried | sean-k-mooney I guess I can see the benefits either way. | 14:30 |
| sean-k-mooney | efried: in this case i was assuming the aggregate would not span multiple computes | 14:30 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add support to scheduler client for setting traits https://review.openstack.org/532539 | 14:31 |
| sean-k-mooney | i am considering if aggregates can be used to group resouce providres in a singel compute that are releated in some way | 14:31 |
| sean-k-mooney | efried: do you rememebr https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst effectivly im wondering how best to remove the agent resouce providers so that we can also model numa affinity of networking resources | 14:32 |
| mgoddard | efried: Ah, I think I see now. We can only get a 200 back if no other changes have occurred other than those we just PUT, therefore our provider tree must be up to date. Thanks for explaining | 14:32 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Collocate encryptor and volume driver calls https://review.openstack.org/460243 | 14:33 |
| lyarwood | mdbooth / stephenfin ; ^ one final respin with the comment and nits taken care of | 14:33 |
| *** hongbin has joined #openstack-nova | 14:34 | |
| *** Eran_Kuris has joined #openstack-nova | 14:35 | |
| efried | mgoddard Just so. Given that report client is the pinch point for placement in nova, and there's only one report client, and it's running on one compute node, under only one thread, we shouldn't actually see these conflicts if nova is the only thingy managing all the providers. But as you can see from the conversation above, there are plans to potentially have multiple sources of ownership for a given provider. | 14:36 |
| sean-k-mooney | efried: https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst was assumign numa would either be a trait or we would have multiple parents. i like haveing numa nodes be resouce provider but that means neutron agent cant be if tehre sub resouce have numa affinity. | 14:36 |
| efried | mgoddard BTW, I put a * above: today aggregates aren't included in the generation thing. cdent is working on fixing that. It's unclear whether that's going to get deferred to Rocky. IMO sean-k-mooney just described a non-sharing-RP use case where we need it. | 14:37 |
| efried | sean-k-mooney Multiple parents, eh? How so? | 14:38 |
| *** mriedem has joined #openstack-nova | 14:38 | |
| efried | sean-k-mooney I *think* the best way to model NUMA affinity is going to be using a numbered group with granular syntax. | 14:38 |
| *** lbragstad has joined #openstack-nova | 14:38 | |
| mriedem | yikun: if you wanted to start looking at something, this part of the spec hasn't been started https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/neutron-new-port-binding-api.html | 14:38 |
| mriedem | yikun: "Prior to the RPC call from live_migration on the source host to pre_live_migration on the dest host, start a wait thread for the vif-plugged event from Neutron, similar to during initial spawn." | 14:38 |
| *** jmlowe has quit IRC | 14:39 | |
| sean-k-mooney | efried: if resouce are allowed to have 1+ parents tehn one parent is the numa node and the other the neutron agent but that makes the trees a graph which we dont whant in general | 14:39 |
| *** armax has quit IRC | 14:41 | |
| *** sahid has quit IRC | 14:41 | |
| ameeda | anyone can help me to write functional regression test for this review.openstack.org/#/c/526900/ ? | 14:41 |
| *** READ10 has joined #openstack-nova | 14:42 | |
| *** Guest20076 has quit IRC | 14:42 | |
| efried | sean-k-mooney Agree. The tree should be a tree (to quote cdent), the neutron agent can control the providers (at least the inventories thereof, if not the RP records themselves), and we can use aggregates to "tag" those providers as being controlled thusly. | 14:42 |
| efried | sean-k-mooney An alternative approach for such tagging would be to use a trait. | 14:42 |
| *** markvoelker has quit IRC | 14:43 | |
| sean-k-mooney | efried: ya that was the other thing i was going to explore | 14:43 |
| efried | sean-k-mooney Which might engender less confusion wrt sharing providers (which these ain't) as well as remove the requirement for the agg generation thing cdent is working. | 14:43 |
| *** alexchadin has quit IRC | 14:43 | |
| sean-k-mooney | e.g. CUSTOM_AGENT_<uuid goes here> | 14:43 |
| cdent | efried: you're welcome to quote me efried, but you're taking me out of context. the implication i was trying to make there is that the trees should be big and anything can be a root | 14:43 |
| efried | cdent Sorry, I take it back. Just didn't want to plagiarize :) | 14:44 |
| *** yassine has joined #openstack-nova | 14:44 | |
| *** yassine is now known as Guest83 | 14:44 | |
| efried | sean-k-mooney Or just CUSTOM_MANAGED_BY_NEUTRON. Why would you need a UUID in the trait? | 14:44 |
| cdent | my utterances here are cca | 14:44 |
| efried | I'll quote you on that. | 14:45 |
| efried | (but not give you credit) | 14:45 |
| sean-k-mooney | efried: again so i have a singel api call i can make to retrive all resouce provders that are managed by that agent | 14:45 |
| sean-k-mooney | both aggreates via memberof and traits with the uuid give me that within the existing model | 14:46 |
| efried | sean-k-mooney Isn't the scope of one neutron in this scenario the same as the scope of one placement service? | 14:46 |
| *** cleong has joined #openstack-nova | 14:46 | |
| sean-k-mooney | one placement service? is someone suggesting there would be more then one placement service? | 14:47 |
| cdent | efried: sean's assertion was neutron agent, not neutron | 14:47 |
| sean-k-mooney | oh yes what cdent said | 14:48 |
| cdent | sean-k-mooney: in the dark corners of the universe there has been talk of nested placement services | 14:48 |
| *** eharney has joined #openstack-nova | 14:48 | |
| efried | (cdent that's not what I was talking about) | 14:48 |
| efried | cdent sean-k-mooney In that case, there's one neutron agent per compute host, yah? | 14:48 |
| sean-k-mooney | cdent: beyond one per cell that sound like i need something stronger then the coffee im drinking | 14:48 |
| cdent | sean-k-mooney: yeah, it's the sort of thing where you should keep _me_ in drinks in dublin to not raise again | 14:49 |
| *** burt has joined #openstack-nova | 14:49 | |
| sean-k-mooney | efried: actully you could have several per compute node. e.g. sriov + ovs on the same node though in practice yes | 14:49 |
| *** yamamoto has joined #openstack-nova | 14:50 | |
| efried | sean-k-mooney But not one agent for multiple computes. | 14:50 |
| efried | sean-k-mooney So my point is, you can ask for providers (having CUSTOM_MANAGED_BY_NEUTRON) && (in tree <compute RP UUID>) | 14:50 |
| sean-k-mooney | efried: :( well for agent based neutron no. but this is odl.... | 14:50 |
| sean-k-mooney | * there is | 14:50 |
| efried | cdent I thought GET /resource_providers had a queryparam for "having traits". I don't see it at a glance. | 14:51 |
| *** markvoelker has joined #openstack-nova | 14:51 | |
| *** awaugama has joined #openstack-nova | 14:51 | |
| cdent | i'm not sure that got merged (yet) | 14:52 |
| cdent | I do think code to do it somewhere though | 14:52 |
| efried | cdent Oh, okay, in flight | 14:52 |
| efried | It would be somewhere in that fabulous placement update email summary... | 14:53 |
| mriedem | alex_xu: i'm still +2 on https://review.openstack.org/#/c/330406/ - i think the migration_links thing is correct; it's consistent with other APIs that support paging. you have a good point about the changes-since before 2.59 though, but that could be addressed in a follow up. | 14:54 |
| mriedem | since it assumes people would actually do that | 14:54 |
| sean-k-mooney | efried: worst comes worse neuron can jsut get teh whole tree and walk it to see if the inventries it creates exist or not. | 14:54 |
| cdent | efried: I think it is something that alex_xu was working on but a lot of his trait related stuff got abandoned | 14:54 |
| efried | cdent Yah, I can't find any such thing in open state (assuming it would have 'trait' somewhere in the title/description) | 14:55 |
| efried | mgoddard So at a glance, it looks like what you've done here is modeled after the inventory updating stuff. | 14:56 |
| mgoddard | efried: Correct | 14:56 |
| cdent | efriend I suspect that quite a few query style things, on /resource_providers, got dropped when /allocation_candidates took the focus, especially if the use cases on /resource_providers werent yet fully formed | 14:57 |
| *** kumarmn has joined #openstack-nova | 14:57 | |
| efried | mgoddard I haven't fully synthesized this stance yet, but I *think* I'm going to come to the conclusion that that's unnecessarily complicated (even for inventory) - and even incorrect in that it does retries at this low level rather than at the consumer level. | 14:57 |
| *** felipemonteiro__ has joined #openstack-nova | 14:57 | |
| *** yamamoto has quit IRC | 14:58 | |
| -openstackstatus- NOTICE: Gerrit is being restarted due to slowness and to apply kernel patches | 14:58 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:59 | |
| efried | cdent GET /resource_providers?having_all=T1,T2 and/or ?having_any=T3,T4 seems like a fairly natural thing to expect, but of course there needs to be a real use case for it. What sean-k-mooney described could count as such. | 14:59 |
| sean-k-mooney | efried: one of the other issue is that nova uses the nova compute node uuid of the host_id(hostname by default) which is sotre in the name filed of the compute node RP i think so we cant uses in_tree in this case and need to use name | 14:59 |
| efried | I believe in_tree accepts name or UUID, doesn't it? | 15:00 |
| *** abalutoiu_ has joined #openstack-nova | 15:00 | |
| efried | no, never mind. | 15:00 |
| sean-k-mooney | got to run to a meeting but efried did you not have a systax for this discribed also in your generic device management proposal. | 15:01 |
| sean-k-mooney | be back in 30 mins | 15:01 |
| *** openstackgerrit has quit IRC | 15:01 | |
| efried | sean-k-mooney Syntax for what? And I doubt it, I don't recall getting to a 'syntax' level of detail in the generic device management discussions. | 15:02 |
| mriedem | alex_xu: makes me wonder if we've added other query strings in higher microversions to apis that allowed additionalProperties before :) | 15:03 |
| *** felipemonteiro__ has quit IRC | 15:03 | |
| *** markvoelker has quit IRC | 15:03 | |
| *** abalutoiu has quit IRC | 15:04 | |
| efried | mgoddard I think we got away with retries at the report client level for inventory because at the time inventory was the only thing that could affect generation, AND we were guaranteed to be the only thing messing with that provider, AND there were no trees or sharing providers. dansmith cdent and Jay should check me on this, but I think we're going to want to pull those retries outta there (at least for 409s) and subsume t | 15:04 |
| efried | hem in the wholesale retries from the resource tracker level. | 15:04 |
| cdent | that's probably right and aligns with what was said monday | 15:04 |
| *** smatzek has joined #openstack-nova | 15:05 | |
| kashyap | mriedem: A heads-up: Given your Nova commit 8075797, https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00845.html -- [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U ['--force-share'] | 15:05 |
| kashyap | I (& DanPB too) pointed out that Nova already added support to it | 15:05 |
| kashyap | Where the QEMU folks were asking if Nova / other management tools use it -- https://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg01816.html | 15:06 |
| *** smatzek_ has joined #openstack-nova | 15:06 | |
| *** smatzek has quit IRC | 15:08 | |
| *** archit has joined #openstack-nova | 15:08 | |
| *** dave-mccowan has joined #openstack-nova | 15:09 | |
| mriedem | kashyap: so they are talking about deprecating and removing the locking thing because everyone is just bypassing it to get their code working again? | 15:09 |
| alex_xu | efried: cdent anything I can help on trait? | 15:10 |
| mriedem | i think nova hits qemu-info from a lot of places | 15:10 |
| *** sahid has joined #openstack-nova | 15:10 | |
| kashyap | mriedem: The discussion is still in flux. I don't think they're going to _remove_ it. | 15:10 |
| mriedem | so auditing when we can just ignore it and bypass the lock would be difficult | 15:10 |
| kashyap | The aim of the locking change is to not let users shoot themselves in the foot | 15:10 |
| mriedem | yeah i realize | 15:10 |
| kashyap | But that WILl cause some inconvenience, in terms of usage behaviour | 15:10 |
| cdent | alex_xu: I don't think we need to do anything immediately but we were discussing needing to be able to get a list of resource providers that have a particular trait | 15:11 |
| kashyap | Trying to get a sense of what is the behaviour across versions | 15:11 |
| alex_xu | mriedem: so...after that patch merge, we have a window the order version API is broken | 15:11 |
| mriedem | kashyap: so for the shareable disk thing in libvirt 3.10, does that just bypass the lock in qemu 2.10? | 15:11 |
| kashyap | mriedem: Also, I was just adding a TODO item is that, we should investigate using the run-time command 'query-block' | 15:11 |
| mriedem | kashyap: or is it telling qemu, 'this is intentionally a shared thing, so be cool with it'? | 15:11 |
| cdent | it occurs to me now, after thinking about it a bit, that we can probably use the 'resources' param for that, and pass in the one single trait we care about ( <- efried ) | 15:11 |
| kashyap | Instead of 'qemu-img' in a loop every few seconds; as 'query-block' will give more consistent results | 15:11 |
| kashyap | mriedem: Yep | 15:11 |
| mriedem | alex_xu: i wouldn't say the older API version is broken | 15:12 |
| *** moshele has joined #openstack-nova | 15:12 | |
| mriedem | alex_xu: it's assuming someone actually passes changes_since, something that wasn't supported before the new microversion | 15:12 |
| efried | cdent How do you specify traits to ?resources ? | 15:12 |
| kashyap | mriedem: So the upcoming behaviour (not set in stone) is that: *even* if you _don't_ specify '--force-share', it'll go ahead with the run, but will print a warning, so as to prime your brain | 15:12 |
| efried | cdent I should know that answer, shouldn't I | 15:12 |
| mriedem | kashyap: we won't see those warnings most likely | 15:12 |
| kashyap | mriedem: Just noticed your other question about shareable thing | 15:12 |
| alex_xu | mriedem: yes.... | 15:12 |
| cdent | efried: i'm not certain, and i'm not certain we do, yet | 15:12 |
| *** dave-mcc_ has joined #openstack-nova | 15:12 | |
| efried | cdent It's in flight, yeah. | 15:13 |
| kashyap | mriedem: Did you see Peter's comment here, to your question: https://bugzilla.redhat.com/show_bug.cgi?id=1378242#c21 | 15:13 |
| openstack | bugzilla.redhat.com bug 1378242 in libvirt "QEMU image file locking (libvirt)" [Unspecified,On_qa] - Assigned to pkrempa | 15:13 |
| cdent | was generalizing that that's how it _should_ work | 15:13 |
| mriedem | alex_xu: if you're really concerned about it, i can make the quick change to check for it if version<2.59 and just pop it off the req.GET | 15:13 |
| cdent | and it should work for both /rp and /ac | 15:13 |
| kashyap | mriedem: Yep, we won't see, because Nova already baked in (correctly so) the '--force-share' with your commit | 15:13 |
| mriedem | alex_xu: i'm just trying to get done as much as i can before i'm out next week | 15:13 |
| mriedem | kashyap: i meant nova won't see b/c it would be in the qemu/libvirtd logs, | 15:13 |
| mriedem | and we don't look there unless it's an error | 15:13 |
| efried | cdent Ah, that's it, actually the code I have up is only applying it to /ac. https://review.openstack.org/#/c/517757/1 | 15:14 |
| kashyap | Ah, like that. | 15:14 |
| *** armax has joined #openstack-nova | 15:14 | |
| cdent | efried: thus my comment on line 23 on https://etherpad.openstack.org/p/nova-ptg-rocky | 15:14 |
| *** dave-mccowan has quit IRC | 15:14 | |
| alex_xu | mriedem: got it, you can have my promise to review that patch again tomorrow | 15:14 |
| mriedem | alex_xu: ok i'll update it today then | 15:15 |
| mriedem | thanks for the solid review as always | 15:15 |
| alex_xu | mriedem: thanks | 15:15 |
| simondodsley | Hi - hope I'm on the correct channel to ask these questions... | 15:15 |
| simondodsley | What I’m trying to find out is when and if Nova supported/supports the use of the ```virsh –-unsafe``` switch when ```cachemode != none```? | 15:15 |
| simondodsley | I can see that this switch was added in libvirt 0.9.11 back in 2012, but I’m struggling in finding references to it or VIR_MIGRATE_UNSAFE as valid options in Kilo or later releases of OpenStack (other than just comments) | 15:15 |
| simondodsley | Any idea when it became a valid option to add to the ```live_migration_flags``` parameter in ```nova.conf``` and since this parameter was deprecated in Mitaka does Nova now automatically use ‘unsafe’ or is there something else that needs to be set to force the ‘unsafe’ switch? | 15:15 |
| mriedem | cdent: efried: dansmith: klindgren_ pinged me last night about the number of REST calls from the compute to placement during the update_available_resource periodic task which runs by default every minute, | 15:16 |
| alex_xu | cdent: efried, for the trait, the only left thing is expose 'required' parameter intthe 'GET /allocation_candidates' API | 15:16 |
| simondodsley | sorry about the format there :) | 15:16 |
| mriedem | from his pike deployment it's 5 calls https://paste.ubuntu.com/26356656/ | 15:16 |
| mriedem | at least | 15:16 |
| mriedem | per compute | 15:16 |
| mriedem | cdent: efried: dansmith: the thing i noted was the 2 calls for aggregates, | 15:16 |
| cdent | mriedem: yes, you remember that post i made mid year about such things ? | 15:16 |
| mriedem | which if you look at the code, the provider aggregate map is there in the report client but not used, | 15:16 |
| mriedem | b/c we don't support shared providers yet | 15:17 |
| mriedem | cdent: not the detalis no | 15:17 |
| *** hrw has quit IRC | 15:17 | |
| mriedem | cdent: can you summarize? | 15:17 |
| mriedem | we might be on the same page | 15:17 |
| dansmith | two hits to inventories? | 15:17 |
| *** moshele has quit IRC | 15:17 | |
| mriedem | dansmith: i wondered about that too | 15:17 |
| mriedem | for the aggregates ones, i told him the obvious thing to do is just comment out that code as it's totally unused | 15:18 |
| cdent | it was also five, iirc, and I was able to do some tricks to trim it but they were deemed risky. agree that one way to cut is to reduce is not make the agg map | 15:18 |
| cdent | let me find the message, because I think it had something to say about the double inventory | 15:18 |
| mriedem | _get_inventory is only called by _get_inventory_and_update_provider_generation which is only called to check if we need to update inventory (if things changed), or delete inventory | 15:19 |
| mriedem | i wonder if he's on baremetal | 15:21 |
| mriedem | because there are cases where the driver.get_inventory call for ironic will return an empty dict which is an indication to delete the inventory for the provider | 15:21 |
| mriedem | klindgren_: ^ | 15:21 |
| mriedem | were you seeing those inventory calls to placement on libvirt or ironic computes? | 15:21 |
| *** hrw has joined #openstack-nova | 15:22 | |
| *** psachin has quit IRC | 15:22 | |
| *** jaypipes has joined #openstack-nova | 15:25 | |
| *** lajoskatona has quit IRC | 15:26 | |
| *** openstackgerrit has joined #openstack-nova | 15:27 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Fix resource provider delete https://review.openstack.org/529519 | 15:27 |
| cdent | sigh, took me forever to find http://lists.openstack.org/pipermail/openstack-dev/2017-January/110953.html | 15:27 |
| mriedem | oh i see, | 15:27 |
| mriedem | _update_inventory_attempt is called in a loop | 15:27 |
| cdent | not yet clear if it will be any use | 15:27 |
| mriedem | so if we get a 409 trying to update inventory we try again | 15:28 |
| mriedem | that's why there are multiple GETs for inventory | 15:28 |
| sean-k-mooney | efried: syntaks for traits to resouces. there was discusstion of a resouce_1=<class x>,required1=<trait y>,<trait z> query arg syntaks for get allocation candiates | 15:28 |
| cdent | mriedem: that may not be right, have a look at point B1 in the list posting above | 15:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | 15:29 |
| cdent | (it maybe also be right, though, but without logs, hard to say) | 15:29 |
| sean-k-mooney | efried: i dont think we have a similar fuctionality for the resouce providres api however. | 15:29 |
| *** kholkina has quit IRC | 15:30 | |
| mriedem | cdent: yeah, you might be right, because if we hit an inventory conflict, we delete the rp_uuid from the cache and then get the resource provider again to update the generation, but i don't see a GET to just /resource_providers in klindgren_'s output | 15:31 |
| mriedem | so likely hitting something that's not a 409, but would need logs | 15:31 |
| *** felipemonteiro_ has quit IRC | 15:33 | |
| efried | sean-k-mooney Correct. | 15:33 |
| *** felipemonteiro_ has joined #openstack-nova | 15:34 | |
| efried | mriedem FYI, I'm trying to rework all of this atm | 15:34 |
| *** Tom-Tom has quit IRC | 15:34 | |
| efried | mriedem But are you looking for a way to get this "fixed" in pike? | 15:34 |
| *** matrohon has joined #openstack-nova | 15:34 | |
| *** kumarmn has left #openstack-nova | 15:35 | |
| *** Apoorva has joined #openstack-nova | 15:37 | |
| *** markvoelker has joined #openstack-nova | 15:37 | |
| mriedem | efried: well, kind of depends on how much operators that are rolling up to ocata and pike are going to be complaining about the new load their computes are making becaues of a lot of http traffic to placement every minute | 15:38 |
| mriedem | i think klindgren_ is working around it by turning down the update_available_resource report interval so it doesn't run every minute | 15:38 |
| efried | Okay, well, keep me posted. I'll be interested in contributing to (or at least reviewing) the code if we go there. | 15:39 |
| mriedem | cdent: ha "After that every 60s or so, five requests are made:" | 15:41 |
| mriedem | right on | 15:41 |
| mriedem | tracking here btw https://bugs.launchpad.net/nova/+bug/1742467 | 15:41 |
| openstack | Launchpad bug 1742467 in OpenStack Compute (nova) "Compute unnecessarily gets resource provider aggregates during every update_available_resource run" [Undecided,New] | 15:41 |
| cdent | mriedem: in your thinking just now did you get any clearer picture on the why of double inventory GET? | 15:43 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116 | 15:43 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532287 | 15:43 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add has_any_traits() to provider tree https://review.openstack.org/532289 | 15:43 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 15:43 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add support to scheduler client for setting traits https://review.openstack.org/532539 | 15:43 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Call get_traits() in the resource tracker https://review.openstack.org/532290 | 15:43 |
| *** david-lyle has joined #openstack-nova | 15:43 | |
| mriedem | cdent: yes it's the RT | 15:43 |
| mriedem | _update_available_resource is the call from the compute periodic task, | 15:44 |
| mriedem | which calls _init_compute_node | 15:44 |
| mriedem | when we already have the compute node, it calls _update | 15:44 |
| mriedem | which eventually does the update_inventory_attempt stuff in the report client | 15:44 |
| mriedem | then at the end of _update_available_resource, | 15:44 |
| mriedem | we call _update again | 15:44 |
| mriedem | so that's your 2 inventory updates | 15:44 |
| mriedem | which, johnthetubaguy changed in queens | 15:45 |
| mriedem | or wait,no | 15:45 |
| *** janki has quit IRC | 15:45 | |
| mriedem | https://review.openstack.org/#/c/520024/ | 15:45 |
| *** sandanar has quit IRC | 15:45 | |
| mriedem | that would fix the double GET inventories | 15:45 |
| *** yamahata has joined #openstack-nova | 15:47 | |
| *** zhaochao has quit IRC | 15:47 | |
| mriedem | maciejjozefczyk: have you figured out anything more about https://review.openstack.org/#/c/520024/ ? | 15:48 |
| maciejjozefczyk | mriedem: hah! | 15:49 |
| maciejjozefczyk | mriedem: aready working on this | 15:49 |
| maciejjozefczyk | and yes, I found something strange, but I need big prove about it | 15:49 |
| maciejjozefczyk | I'll post it today in review | 15:49 |
| maciejjozefczyk | mriedem: basically: each time self._provider_tree.has_inventory_changed() returns False here: | 15:52 |
| maciejjozefczyk | https://github.com/openstack/nova/blob/cf33de28b15bb445d34bbdda1897130812e3b5c5/nova/scheduler/client/report.py#L696 | 15:52 |
| maciejjozefczyk | without my change | 15:52 |
| maciejjozefczyk | with my change: It tries to update inventory_data to placement and then placement raises this strange Exception | 15:53 |
| maciejjozefczyk | so for now in upstream we update only DB (once with faulty values, second time with proper ones) | 15:54 |
| *** Eran_Kuris has quit IRC | 15:54 | |
| mriedem | so it's failing this check? https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L231 | 15:54 |
| maciejjozefczyk | mriedem: exactly | 15:55 |
| *** abalutoiu__ has joined #openstack-nova | 15:55 | |
| *** abalutoiu__ has quit IRC | 15:55 | |
| mriedem | do you see this debug message with the PUT inventory request body in it when this fails? https://github.com/openstack/nova/blob/cf33de28b15bb445d34bbdda1897130812e3b5c5/nova/scheduler/client/report.py#L765 | 15:56 |
| maciejjozefczyk | mriedem: yes | 15:57 |
| maciejjozefczyk | WARNING nova.scheduler.client.report [None req-89e951da-7283-473f-9de0-53854741839a None None] [req-b6f884cd-883a-4964-8e99-a8f0 f754c0df] Failed to update inventory for resource provider 52559824-5fb1-424b-a4cf-79da9199447d: 400 {"errors": [{"status": 400, "request_id": "req-b6f884cd-883a-4964-8e99-a8f0f754c0df", "detail": "The server could not comply with the request since it is e ither | 15:57 |
| maciejjozefczyk | malformed or otherwise incorrect.\n\n Unable to update inventory for resource provider 52559824-5fb1-424b-a4cf-79da9199447 d: Invalid inventory for 'VCPU' on resource provider '52559824-5fb1-424b-a4cf-79da9199447d'. The reserved value is greater than or equal to total. ", "title": "Bad Request"}]} | 15:57 |
| *** felipemonteiro__ has joined #openstack-nova | 15:57 | |
| mriedem | that's the warning, do you have this debug log? https://github.com/openstack/nova/blob/cf33de28b15bb445d34bbdda1897130812e3b5c5/nova/scheduler/client/report.py#L765 | 15:58 |
| *** abalutoiu_ has quit IRC | 15:59 | |
| mriedem | i want to see if the request body has "The reserved value is greater than or equal to total." in it | 15:59 |
| cdent | greater than empty value? | 15:59 |
| maciejjozefczyk | mriedem: checking | 15:59 |
| *** tidwellr has joined #openstack-nova | 16:00 | |
| *** jmlowe has joined #openstack-nova | 16:00 | |
| *** moshele has joined #openstack-nova | 16:00 | |
| *** felipemonteiro_ has quit IRC | 16:01 | |
| mriedem | cdent: so, we can likely at least turn down the 5 calls per periodic to 2 if we nix the 2 aggregate calls and turn the 2 inventory calls to 1; and then i think the GET /allocations in here is only if you have ocata computes or are using the ironic driver | 16:02 |
| *** moshele has quit IRC | 16:02 | |
| cdent | that makes sense | 16:02 |
| *** dklyle has joined #openstack-nova | 16:04 | |
| *** david-lyle has quit IRC | 16:04 | |
| melwitt | lyarwood: thanks for the stable/pike reviews, could you please hit these stable/ocata versions too? https://review.openstack.org/531422 and https://review.openstack.org/#/c/523911 | 16:05 |
| lyarwood | melwitt: ack np, I'll get to them tonight | 16:06 |
| *** mkoderer_6 has joined #openstack-nova | 16:07 | |
| *** mfisch` has joined #openstack-nova | 16:07 | |
| melwitt | thanks | 16:07 |
| *** yikun_ has quit IRC | 16:08 | |
| maciejjozefczyk | mriedem: debug log: DEBUG nova.scheduler.client.report [None req-ad586aa8-27d1-494d-9c4d-bb8f15439fca None None] [req-a4ea518f-1da0-43fd-8348-64704210cb49] Failed inventory update request for resource provider 52559824-5fb1-424b-a4cf-79da9199447d with body: {'resource_provider_generation': 4, 'inventories': {'VCPU': {'allocation_ratio': 0.0, 'total': 2, 'reserved': 0, 'step_size': 1, 'min_unit': 1, | 16:09 |
| maciejjozefczyk | 'max_unit': 2}, 'MEMORY_MB': {'allocation_ratio': 0.0, 'total': 29449, 'reserved': 512, 'ste p_size': 1, 'min_unit': 1, 'max_unit': 29449}, 'DISK_GB': {'allocation_ratio': 0.0, 'total': 193, 'reserved': 0, 'step_size': 1, 'min_unit': 1, 'max_unit': 193}}} {{(pid=19609) _update_inventory_attempt /opt/stack/nova/nova/scheduler/cli ent/report.py:765}} | 16:09 |
| cdent | allocation_ratio being 0 is not supposed to happen | 16:09 |
| *** mfisch has quit IRC | 16:10 | |
| *** itlinux has joined #openstack-nova | 16:10 | |
| cdent | we've had bug fixes for that since then | 16:10 |
| mriedem | reserved < total in all of those | 16:10 |
| cdent | but capacity is a calculation that involved allocation_ratio as a multiplier | 16:11 |
| cdent | if it is 0 | 16:11 |
| cdent | ... | 16:11 |
| mriedem | yeah | 16:11 |
| mriedem | recheck gerrit restart | 16:11 |
| mriedem | ooops | 16:11 |
| cdent | I suspect we've got bad exception trapping happening | 16:11 |
| mriedem | return int((self.total - self.reserved) * self.allocation_ratio) | 16:11 |
| mriedem | maciejjozefczyk: is that from master with your patch? or pike/ocata? | 16:12 |
| maciejjozefczyk | master, I think from 20 DEC 2017~ when I worked on that | 16:12 |
| maciejjozefczyk | should I pull? | 16:12 |
| mriedem | cdent: BASE_INVENTORY_SCHEMA shows only a max for allocation_ratio, not a min | 16:13 |
| mriedem | in pike anyway | 16:13 |
| maciejjozefczyk | Im on 04c8fa469109098a0ba8e8774f6176c43b7ed19a | 16:13 |
| cdent | mriedem: that's still true, I checked | 16:13 |
| cdent | where things got changed was on the resource tracker side | 16:13 |
| cdent | where it was possible to default to 0, but that was changed, but I'm not sure when/where | 16:13 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 16:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 16:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 16:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise conflict exception on RP create 409 https://review.openstack.org/532563 | 16:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | 16:14 |
| mriedem | cdent: _normalize_inventory_from_cn_obj ? | 16:14 |
| cdent | not sure, but sounds likely | 16:14 |
| efried | mgoddard WIP: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 is where I was planning to go. | 16:14 |
| mriedem | that's the thing in the RT that sets the allocation_ratio in the inventory payload if the driver.get_inventory() method didn't include allocation ratios | 16:15 |
| mriedem | and all 3 of those default to 0.0 in config :) | 16:15 |
| mriedem | so yeah...we're always sending an inventory update with a capacity that's not going to be accepted | 16:15 |
| efried | ouch | 16:16 |
| maciejjozefczyk | mriedem: yes | 16:17 |
| *** john51 has quit IRC | 16:17 | |
| mriedem | left notes in https://review.openstack.org/#/c/520024/ | 16:18 |
| mriedem | so how does this work today? | 16:18 |
| maciejjozefczyk | today, you mean without my patch? | 16:19 |
| cdent | i swear we've seen this before and changed it | 16:19 |
| mriedem | maciejjozefczyk: yeah | 16:19 |
| maciejjozefczyk | mriedem: https://github.com/openstack/nova/blob/cf33de28b15bb445d34bbdda1897130812e3b5c5/nova/scheduler/client/report.py#L696 always pass | 16:19 |
| *** markvoelker has quit IRC | 16:19 | |
| maciejjozefczyk | so we dont send anything to scheduler | 16:19 |
| maciejjozefczyk | pff, placement* | 16:19 |
| maciejjozefczyk | only DB is updated | 16:19 |
| ameeda | Hello novaers, when I try to deploy overcloud on baremetal using undercloud "installed at vm" I got this error "No compute node record for host undercloud: ComputeHostNotFound_Remote: Compute host undercloud could not be found." from nova-compute.log file | 16:20 |
| cfriesen | mriedem: reading your "working towards feature freeze" email...given reviewer resources is there any point in trying to refresh the live-migration resource tracking patches for Q or is that now basically an R thing? | 16:20 |
| mriedem | live migration resource tracking patches? | 16:20 |
| mriedem | maciejjozefczyk: but at some point we have to set the initial inventory for the provider | 16:21 |
| cfriesen | mriedem: yeah, the ones that have been around forever to fix pinned cpus, hugepages, etc. on live migration | 16:21 |
| mriedem | cfriesen: i didn't realize you were trying to get those into Q | 16:21 |
| cfriesen | mriedem: I haven't actively | 16:21 |
| cfriesen | mriedem: sfinucan refreshed one of them in November | 16:22 |
| *** mlavalle has joined #openstack-nova | 16:22 | |
| *** markvoelker has joined #openstack-nova | 16:22 | |
| mriedem | maciejjozefczyk: so i'm trying to figure out why the initial PUT for inventories for that compute node doesn't fail | 16:22 |
| mriedem | like, the first time the compute is created | 16:23 |
| maciejjozefczyk | mriedem: Im curious too | 16:23 |
| maciejjozefczyk | mriedem: also looking | 16:23 |
| *** john51 has joined #openstack-nova | 16:23 | |
| mriedem | on the first PUT we'd get here https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L371 | 16:24 |
| mriedem | which also checks capacity https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L200 | 16:24 |
| cdent | at create time is the inventory constructed by something else, which does not set allocation_ratio in the request? If so, the server side will default to 1.0 | 16:25 |
| mriedem | i don't think so, should be the same code, | 16:25 |
| mriedem | calls driver.get_inventory() | 16:25 |
| mriedem | which for libvirt doesn't return allocation_ratio | 16:25 |
| *** markvoelker has quit IRC | 16:27 | |
| *** jamiec has quit IRC | 16:29 | |
| *** andreas__ has quit IRC | 16:30 | |
| cdent | mriedem: I think maybe it just busted but in our functional tests and tempest we always set those config values | 16:30 |
| cdent | tempest has allocation_ratio conf defaults | 16:30 |
| cdent | and the gabbi test fixture for function does too | 16:30 |
| *** chyka has joined #openstack-nova | 16:31 | |
| mriedem | tempest? you mean devstack? | 16:31 |
| mriedem | i don't see allocation_ratio set in nova.conf http://logs.openstack.org/24/520024/6/check/legacy-tempest-dsvm-neutron-full/255f8c4/logs/etc/nova/nova-cpu.conf.txt.gz | 16:31 |
| cdent | yeah, sorry | 16:31 |
| mriedem | http://logs.openstack.org/24/520024/6/check/legacy-tempest-dsvm-neutron-full/255f8c4/logs/screen-n-cpu.txt.gz#_Dec_15_15_20_27_560214 | 16:31 |
| cdent | (I'm simultaneously working on some tempest stuff) | 16:32 |
| *** andreas_s has joined #openstack-nova | 16:32 | |
| melwitt | I've noticed the test_live_migration_actions functional test has been intermittently failing in the gate again http://logs.openstack.org/90/333990/22/check/openstack-tox-functional/24eeb2b/testr_results.html.gz | 16:32 |
| mriedem | cdent: in this test run, this is the first inventory update after the compute node RP is created http://logs.openstack.org/24/520024/6/check/legacy-tempest-dsvm-neutron-full/255f8c4/logs/screen-n-cpu.txt.gz#_Dec_15_15_20_29_162934 | 16:33 |
| melwitt | gibi ^ | 16:33 |
| *** andreas__ has joined #openstack-nova | 16:33 | |
| cdent | mriedem: presumably the set to 0.0 here shouldn't be? http://logs.openstack.org/24/520024/6/check/legacy-tempest-dsvm-neutron-full/255f8c4/logs/screen-n-cpu.txt.gz#_Dec_15_15_20_27_560214 | 16:33 |
| mriedem | cdent: 0.0 is the default in the configs | 16:34 |
| cdent | I get that. | 16:34 |
| cdent | But one wouldn't expect that work, would one? | 16:35 |
| cdent | unless 0 is meant to mean 1 | 16:35 |
| cdent | and that's the conversation I seem to remember having, but can't find the thread of | 16:35 |
| mriedem | i don't see how it works with the capacity checks on the placement side for updating inventory | 16:35 |
| mriedem | for this ci run, this is the first inventory update http://logs.openstack.org/24/520024/6/check/legacy-tempest-dsvm-neutron-full/255f8c4/logs/screen-placement-api.txt.gz#_Dec_15_15_20_29_138893 | 16:36 |
| mriedem | but doesn't tell us much | 16:36 |
| gibi | melwitt: thanks for the heads up, I will look into it | 16:36 |
| *** andreas_s has quit IRC | 16:36 | |
| melwitt | thanks gibi | 16:36 |
| cdent | mriedem: ah, it is the compute node object that does some jiggery pokery if it is doesn't like the values of the allocation ratios: see _from_db_object in class ComputeNode | 16:37 |
| *** aloga_ has joined #openstack-nova | 16:37 | |
| mriedem | yup i just found that | 16:37 |
| mriedem | maciejjozefczyk: | 16:37 |
| cdent | some presumably somewhere in the first step that pokery is happening, but then getting ruined in the second | 16:37 |
| * cdent 's brain melts | 16:38 | |
| mriedem | maciejjozefczyk: https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L198 | 16:38 |
| maciejjozefczyk | mriedem: mmmmm | 16:40 |
| *** READ10 has quit IRC | 16:41 | |
| *** andreas__ has quit IRC | 16:41 | |
| maciejjozefczyk | mriedem: and yes, I dont have it specified in config at all | 16:41 |
| *** READ10 has joined #openstack-nova | 16:41 | |
| *** tidwellr has quit IRC | 16:43 | |
| mriedem | i don't really understand why the inventory request wouldn't have the allocation_ratio values from the compute node object though | 16:43 |
| mriedem | because in your patch, _update is called after the compute node record is created, | 16:43 |
| mriedem | and ComputeNode.create() eventually calls _from_db_object to set the 'default' allocation ratios on the object itself | 16:43 |
| cfriesen | just stumbled over something odd...if the os_type isn't set, then in some scenarios the ephemeral disks are formated vfat. if the ephemeral size is too big for vfat, this chokes. Should we default to something else in the code or just not format it at all if a default isn't specified in the config file? | 16:43 |
| *** tidwellr has joined #openstack-nova | 16:43 | |
| mriedem | which will be used in _normalize_inventory_from_cn_obj | 16:44 |
| cfriesen | mdbooth: ^ | 16:44 |
| *** jaosorior has quit IRC | 16:47 | |
| mriedem | maciejjozefczyk: if you have a recreate of that failure, try logging the compute node record in _update() before calling reportclient.set_inventory_for_provider | 16:48 |
| *** felipemonteiro__ has quit IRC | 16:48 | |
| *** felipemonteiro__ has joined #openstack-nova | 16:48 | |
| *** clarkb has quit IRC | 16:53 | |
| *** gyee has joined #openstack-nova | 16:54 | |
| *** ragiman has quit IRC | 16:54 | |
| *** AlexeyAbashkin has quit IRC | 16:55 | |
| maciejjozefczyk | mriedem: ok | 16:57 |
| *** moshele has joined #openstack-nova | 16:57 | |
| *** liverpooler has joined #openstack-nova | 16:57 | |
| *** diga has joined #openstack-nova | 17:00 | |
| diga | jaypipes: Hi | 17:01 |
| diga | jaypipes: have you seen my mail on this bug - https://bugs.launchpad.net/nova/+bug/1719933 | 17:01 |
| openstack | Launchpad bug 1719933 in OpenStack Compute (nova) "placement server needs to retry allocations, server-side" [Medium,Triaged] - Assigned to Jay Pipes (jaypipes) | 17:01 |
| *** Apoorva has quit IRC | 17:01 | |
| *** dklyle has quit IRC | 17:03 | |
| cdent | diga: twitter suggests that jay is rather ill today | 17:03 |
| diga | cdent: ohh | 17:04 |
| *** archit has quit IRC | 17:05 | |
| *** yamahata has quit IRC | 17:05 | |
| maciejjozefczyk | mriedem: Ok, I'll paste it tomorrow, need to go | 17:05 |
| mdbooth | cfriesen: The behaviour of that formatting is lost in the depths of time. That sounds like a bona fide bug, though. | 17:05 |
| diga | cdent: do you have sometime, can you help me ? | 17:06 |
| mriedem | maciejjozefczyk: o/ | 17:06 |
| cdent | diga: I might be able to yeah, what's up? | 17:06 |
| mdbooth | cfriesen: Do other clouds format blank ephemeral disks for you? It seems like such a weird thing to do in Nova. | 17:06 |
| maciejjozefczyk | first sight, strange, https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L763 gives me https://pastebin.com/skR0X0Mm (at init) | 17:07 |
| mdbooth | cfriesen: I don't think we can change that behaviour without at least a microversion bump, btw. Probably a cycle of ops discussion, a prominent release note, and a microversion bump. | 17:07 |
| maciejjozefczyk | mriedem: and cpu_allocation_ratio is set as 16.0 | 17:07 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 17:08 |
| mriedem | maciejjozefczyk: that's because it pulls the object from the db and runs it through ComputeNode._from_db_object which sets the 'default' allocation ratios (hardcoded in code) if not set in config | 17:08 |
| mdbooth | cfriesen: When the ephemeral disk is too big, does the mkfs choke causing the spawn to fail? | 17:08 |
| maciejjozefczyk | mriedem: I'll check it tomorrow why then it is changed to 0 | 17:09 |
| maciejjozefczyk | mriedem: thats the real cause, yes? | 17:09 |
| mriedem | yeah i don't know what is changing it to 0.0 before we hit placement | 17:09 |
| maciejjozefczyk | mriedem: I'll find it for you ;) bb | 17:10 |
| mriedem | godspeed | 17:10 |
| *** dave-mcc_ has quit IRC | 17:11 | |
| *** damien_r has quit IRC | 17:11 | |
| *** pcaruana has quit IRC | 17:11 | |
| diga | cdent: | 17:11 |
| * cdent listens | 17:11 | |
| diga | cdent: - Here I got the error after adding scenarios - http://paste.openstack.org/show/641294/ | 17:11 |
| *** lpetrut has quit IRC | 17:12 | |
| diga | cdent: changes are made in git diff - http://paste.openstack.org/show/641293/ | 17:12 |
| cdent | diga: do you have a work in progress that you post up to gerrit so there's code to look at? | 17:12 |
| diga | cdent: I have submit the patch yet, Let me submit the patch then | 17:13 |
| diga | s/have/haven't | 17:13 |
| diga | cdent: yes, I am working on this as per jaypipes suggestions | 17:14 |
| cdent | diga: note that DbDeadLock is already handled, what's not handled is ConcurrentUpdate | 17:14 |
| diga | cdent: okay | 17:15 |
| cdent | _set_allocations method already has the retry handing on it | 17:15 |
| cdent | but it is only set up for handling db api exceptions, which ConcurrentUpdate is not | 17:16 |
| *** moshele has quit IRC | 17:16 | |
| mriedem | sdague: this is the novaclient change for the file injection deprecation and userdata + rebuild stuff https://review.openstack.org/#/c/528128/ - closes out that bp and unblocks the next novaclient change in the series for the next microversion; client release freeze is creeping up so i'd like to get some reviews on this stuff | 17:16 |
| *** harlowja has joined #openstack-nova | 17:16 | |
| *** david-lyle has joined #openstack-nova | 17:16 | |
| diga | okk, I will work on it then | 17:16 |
| cdent | diga: let me know if/how I can help | 17:17 |
| diga | cdent: currently main challenge in nova is to reproduce the issue, db part is reproduced, but how to reproduce ConcurrentUpdate | 17:17 |
| diga | cdent: some pointers can be helpful | 17:18 |
| mriedem | diga: i have a devstack patch that reproduces it... | 17:18 |
| *** chyka has quit IRC | 17:18 | |
| cdent | diga: I think you can probably do something similar to what you've done in your existing test, but put the side effect on the method that increase the generation | 17:18 |
| mriedem | https://review.openstack.org/#/c/507918/ | 17:18 |
| cdent | diga: _increment_provider_generation | 17:19 |
| *** chyka has joined #openstack-nova | 17:19 | |
| *** tidwellr has quit IRC | 17:19 | |
| *** dave-mccowan has joined #openstack-nova | 17:19 | |
| *** lucasagomes is now known as lucas-afk | 17:19 | |
| diga | cdent: okay | 17:19 |
| diga | mriedem: I will take a look at it | 17:20 |
| mriedem | it's probably not very helpful though for recreating a concurrent update failure in a unit test | 17:20 |
| mriedem | it was just something i think i noticed while investigating failures in that devstack patch | 17:21 |
| *** vivsoni__ has joined #openstack-nova | 17:21 | |
| diga | mriedem: but it needs to rerun devstack with this change | 17:21 |
| *** matrohon has quit IRC | 17:21 | |
| diga | mriedem: ok, got it | 17:21 |
| *** mfisch` has quit IRC | 17:23 | |
| *** sree has joined #openstack-nova | 17:23 | |
| *** tidwellr has joined #openstack-nova | 17:24 | |
| *** jamiec has joined #openstack-nova | 17:29 | |
| *** tidwellr has quit IRC | 17:29 | |
| *** egonzalez has joined #openstack-nova | 17:29 | |
| stephenfin | artom: https://review.rdoproject.org/r/#/c/11283/ | 17:29 |
| * stephenfin heads home | 17:29 | |
| diga | mriedem: Thanks for sharing the link, it will be certainly helpful | 17:34 |
| diga | cdent: thanks for your help | 17:34 |
| diga | cdent: mriedem : will ping you if I need any help, will update you by tomorrow | 17:35 |
| *** itlinux has quit IRC | 17:35 | |
| *** jaypipes has quit IRC | 17:35 | |
| cfriesen | mdbooth: sorry, was off in a meeting. Yes, the initial spawn fails when the ephemeral disk is too big. I wonder if we could change the default based on size, to either use something else or just not format it instead of choking. | 17:38 |
| *** sree_ has joined #openstack-nova | 17:39 | |
| mdbooth | cfriesen: I think it has to be considered part of the api. I think the only change we can make to it without a microversion bump is a minimal change to make it not fail. | 17:39 |
| *** sree_ is now known as Guest48418 | 17:40 | |
| mdbooth | cfriesen: So we could, for eg, not format it at all, but only in the case that we know it would cause a failure to build. | 17:40 |
| *** itlinux has joined #openstack-nova | 17:41 | |
| cfriesen | mdbooth: agreed. I'll open a bug and maybe propose a fix. | 17:41 |
| *** Guest48418 has quit IRC | 17:42 | |
| *** sree has quit IRC | 17:42 | |
| *** penick has joined #openstack-nova | 17:43 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:43 | |
| *** egonzalez has quit IRC | 17:46 | |
| *** felipemonteiro__ has quit IRC | 17:46 | |
| *** sahid has quit IRC | 17:49 | |
| *** diga has quit IRC | 17:51 | |
| *** sree has joined #openstack-nova | 17:53 | |
| *** sree has quit IRC | 17:58 | |
| *** derekh has quit IRC | 18:00 | |
| *** Apoorva has joined #openstack-nova | 18:00 | |
| *** Apoorva has quit IRC | 18:00 | |
| *** Apoorva has joined #openstack-nova | 18:01 | |
| *** vivsoni__ has quit IRC | 18:02 | |
| *** moshele has joined #openstack-nova | 18:03 | |
| *** archit has joined #openstack-nova | 18:05 | |
| *** david-lyle has quit IRC | 18:07 | |
| *** moshele has quit IRC | 18:09 | |
| *** gouthamr has quit IRC | 18:09 | |
| *** karthiks has quit IRC | 18:12 | |
| *** jpena is now known as jpena|off | 18:14 | |
| *** felipemonteiro_ has quit IRC | 18:19 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:19 | |
| *** hemna_ has joined #openstack-nova | 18:25 | |
| *** openstack has joined #openstack-nova | 18:31 | |
| *** ChanServ sets mode: +o openstack | 18:31 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:31 | |
| *** AlexeyAbashkin has quit IRC | 18:35 | |
| *** jackie-truong has joined #openstack-nova | 18:35 | |
| *** tesseract has quit IRC | 18:36 | |
| *** avolkov has quit IRC | 18:37 | |
| *** harlowja has quit IRC | 18:37 | |
| *** jmlowe has quit IRC | 18:40 | |
| *** jmlowe has joined #openstack-nova | 18:41 | |
| *** gouthamr has joined #openstack-nova | 18:47 | |
| *** gszasz has quit IRC | 18:50 | |
| *** xinliang has quit IRC | 18:53 | |
| *** gouthamr has quit IRC | 18:53 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Detach volume after deleting instance with no host https://review.openstack.org/340614 | 18:53 |
| *** xinliang has joined #openstack-nova | 18:54 | |
| *** tidwellr has joined #openstack-nova | 18:54 | |
| *** READ10 has quit IRC | 18:54 | |
| mriedem | stvnoyes: finally got that multiattach snapshot test to pass http://logs.openstack.org/86/531386/7/check/tempest-full/2f25c03/job-output.txt.gz#_2018-01-10_02_15_35_840008 | 18:55 |
| *** READ10 has joined #openstack-nova | 18:55 | |
| stvnoyes | excellent. I've been working on libvirt 3.10. Finally got past the dependency issues working on getting stack up now | 18:56 |
| mriedem | for the tempest patch, it's getting big, so i might need to think about splitting it up | 18:56 |
| mriedem | mtreinish: how do you feel about this? https://review.openstack.org/#/c/266605/25/tempest/api/compute/volumes/test_attach_volume.py | 18:56 |
| melwitt | is anyone willing to please review the local delete patch ^ if an instance with attached volumes etc goes into error state, when it's deleted the volumes and networks aren't disconnected from the instance and have to be manually disconnected in order to be used again | 18:56 |
| mriedem | should i do the first patch with the config option and 1 test, then add the other tests in subsequent patches? | 18:56 |
| *** mvk has quit IRC | 18:57 | |
| *** david-lyle has joined #openstack-nova | 18:59 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 19:01 |
| *** moshele has joined #openstack-nova | 19:02 | |
| *** felipemonteiro__ has joined #openstack-nova | 19:03 | |
| *** aloga_ has quit IRC | 19:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 19:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table. https://review.openstack.org/531132 | 19:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix comment in MigrationSortContext https://review.openstack.org/532368 | 19:04 |
| ameeda | Hello, when I try to deploy overcloud on baremetal using undercloud "installed at vm" I got this error "No compute node record for host undercloud: ComputeHostNotFound_Remote: Compute host undercloud could not be found." from nova-compute.log file | 19:05 |
| ameeda | what can I do with that ? | 19:05 |
| *** felipemonteiro_ has quit IRC | 19:06 | |
| *** moshele has quit IRC | 19:07 | |
| openstackgerrit | Mark Goddard proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116 | 19:10 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532287 | 19:10 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Add support to scheduler client for setting traits https://review.openstack.org/532539 | 19:10 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Call get_traits() in the resource tracker https://review.openstack.org/532290 | 19:10 |
| openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 19:10 |
| *** sambetts is now known as sambetts|afk | 19:10 | |
| *** sridharg has quit IRC | 19:10 | |
| rybridges | Hey guys. Got another question for you today. Is there a way to update the user-data on an instance after it is in the build state during the boot flow? I have a hunch that it is not possible because once the instance is in the build state, the user-data and config driver stuff have already been written out onto the that instance's partition on the hypervisor. Meaning in order to update the user data | 19:10 |
| rybridges | on the instance after it is built, we would need some api capable of modifying user data on the instance. does something like that exist? | 19:10 |
| *** harlowja has joined #openstack-nova | 19:13 | |
| *** hemna_ has quit IRC | 19:16 | |
| *** harlowja_ has joined #openstack-nova | 19:16 | |
| *** jobewan has joined #openstack-nova | 19:18 | |
| melwitt | I'm not sure if it's done yet but the plan was to allow user data to be provided during a rebuild | 19:19 |
| *** harlowja has quit IRC | 19:19 | |
| rybridges | hmm | 19:19 |
| rybridges | i am talking more from a coding point of view rather than from a user's point of view | 19:19 |
| rybridges | like in the code of the boot flow | 19:19 |
| rybridges | is there a way to update that user data after the instance has already been built | 19:20 |
| *** READ10 has quit IRC | 19:20 | |
| rybridges | so for example | 19:21 |
| rybridges | if you update the user data at this point https://github.com/OpenStack/nova/blob/stable/ocata/nova/compute/api.py#L944 | 19:22 |
| rybridges | which is before the instance is actually created on the HV | 19:22 |
| rybridges | then when the instance is actually created on the HV, it will get your user data | 19:22 |
| rybridges | but if you do it after that... I am thinking it wont update because updating would involve rewriting a file on the hypervisor | 19:22 |
| *** Apoorva_ has joined #openstack-nova | 19:32 | |
| *** mvk has joined #openstack-nova | 19:33 | |
| melwitt | rybridges: so you're saying you want to modify the user data after it's been provided by the end user? | 19:34 |
| melwitt | but it's not the end user themselves who want to update it? | 19:34 |
| *** Apoorva has quit IRC | 19:34 | |
| melwitt | it sounds like what you want is the vendor data stuff | 19:35 |
| *** jackie-truong has quit IRC | 19:40 | |
| melwitt | https://docs.openstack.org/nova/latest/user/vendordata.html | 19:41 |
| *** penick has quit IRC | 19:43 | |
| *** hemna_ has joined #openstack-nova | 19:45 | |
| *** moshele has joined #openstack-nova | 19:45 | |
| *** cdent has quit IRC | 19:48 | |
| rybridges | eh.. not quite. That's okay. Thanks melwitt | 19:48 |
| *** moshele has quit IRC | 19:49 | |
| *** aloga_ has joined #openstack-nova | 19:50 | |
| mriedem | he's looking for the server create hook | 19:52 |
| mriedem | which has been deprecated forever | 19:52 |
| *** dtantsur is now known as dtantsur|afk | 19:53 | |
| *** nicolasbock has quit IRC | 19:56 | |
| mtreinish | mriedem: what do you want me to look at there? | 20:01 |
| *** cleong has quit IRC | 20:03 | |
| mriedem | mtreinish: so i've got the 3 tests in there passing, | 20:04 |
| mriedem | but, that patch also has some setup stuff so it's getting large, | 20:04 |
| mriedem | was thinking about changing that to just be the first test, and then put 1 patch per new test on top of that in a series | 20:04 |
| mriedem | since there are a bunch of TODOs in there for more tests, i didn't want to hold that single patch for all of the tests | 20:04 |
| mtreinish | mriedem: sure, that sounds like a sane way to handle it | 20:05 |
| mriedem | ok | 20:05 |
| mriedem | just wanted to make sure since it's going to be a bit of work | 20:05 |
| mtreinish | I did quickly look at the tests the other day when you linked me to them and they seemed fine to me | 20:05 |
| mtreinish | mriedem: I mean it's not that long a patch with the 3 tests in one. I'd be fine reviewing it as is too | 20:06 |
| mriedem | the two patches below that one are ready to go | 20:06 |
| mtreinish | it's really your call | 20:06 |
| mriedem | yeah i knew you would probably, but for others | 20:06 |
| mriedem | i'll split it up | 20:06 |
| mriedem | plus then it will rock my tempest stats! | 20:06 |
| mtreinish | heh, got to maintain your top 10 committer status :) | 20:07 |
| mriedem | you know it | 20:07 |
| mriedem | heh i didn't know that was still a thing http://stackalytics.com/?release=all&module=tempest&metric=commits | 20:08 |
| mriedem | soon i can catch up with old man dague | 20:08 |
| *** slaweq has joined #openstack-nova | 20:09 | |
| *** ralonsoh has quit IRC | 20:09 | |
| mtreinish | mriedem: heh, nice | 20:09 |
| sdague | mriedem: yeh, well... you youngins | 20:20 |
| mriedem | i can hear your fist shaking from here | 20:20 |
| *** tidwellr_ has joined #openstack-nova | 20:24 | |
| *** tidwellr has quit IRC | 20:24 | |
| *** dave-mccowan has quit IRC | 20:27 | |
| *** imacdonn has quit IRC | 20:32 | |
| *** imacdonn has joined #openstack-nova | 20:33 | |
| *** archit has quit IRC | 20:34 | |
| *** dave-mccowan has joined #openstack-nova | 20:38 | |
| *** awaugama has quit IRC | 20:45 | |
| *** chyka has quit IRC | 20:49 | |
| *** chyka has joined #openstack-nova | 20:50 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM driver: ovs vif https://review.openstack.org/422512 | 20:52 |
| *** Jeffrey4l has quit IRC | 20:52 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: SEA https://review.openstack.org/523216 | 20:53 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 20:53 |
| mriedem | this was added in 2014: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1022 | 20:57 |
| mriedem | seems it might be time to remove the get() | 20:57 |
| mriedem | since the dfeault in cinder for new volumes is bootable=False | 20:57 |
| *** chyka has quit IRC | 20:59 | |
| *** chyka_ has joined #openstack-nova | 20:59 | |
| *** AlexeyAbashkin has joined #openstack-nova | 21:00 | |
| *** Jeffrey4l has joined #openstack-nova | 21:03 | |
| *** eharney has quit IRC | 21:03 | |
| *** felipemonteiro__ has quit IRC | 21:03 | |
| *** felipemonteiro__ has joined #openstack-nova | 21:04 | |
| *** Guest83 has quit IRC | 21:04 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 21:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt : Force a specificly static UUID for a mediated device https://review.openstack.org/531752 | 21:04 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Use only existing mdevs if kernel race https://review.openstack.org/531853 | 21:04 |
| *** AlexeyAbashkin has quit IRC | 21:04 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 21:04 |
| *** Guest83 has joined #openstack-nova | 21:07 | |
| *** yamahata has joined #openstack-nova | 21:12 | |
| *** moshele has joined #openstack-nova | 21:13 | |
| *** Apoorva_ has quit IRC | 21:15 | |
| *** Apoorva has joined #openstack-nova | 21:16 | |
| *** moshele has quit IRC | 21:16 | |
| *** kylek3h has joined #openstack-nova | 21:16 | |
| *** smatzek_ has quit IRC | 21:19 | |
| *** smatzek has joined #openstack-nova | 21:20 | |
| *** felipemonteiro_ has joined #openstack-nova | 21:20 | |
| *** smatzek_ has joined #openstack-nova | 21:22 | |
| *** felipemonteiro__ has quit IRC | 21:23 | |
| *** smatzek has quit IRC | 21:24 | |
| *** smatzek_ has quit IRC | 21:26 | |
| *** awaugama has joined #openstack-nova | 21:28 | |
| *** dave-mccowan has quit IRC | 21:29 | |
| *** felipemonteiro_ has quit IRC | 21:32 | |
| *** gouthamr has joined #openstack-nova | 21:32 | |
| *** felipemonteiro_ has joined #openstack-nova | 21:33 | |
| *** gouthamr_ has joined #openstack-nova | 21:35 | |
| *** gouthamr has quit IRC | 21:37 | |
| *** kylek3h has quit IRC | 21:38 | |
| mriedem | ildikov: on the multiattach api patch, i've got the rest api controller tests done, added a happy path functoinal test for boot from volume and attach to an existing server, and now working on negative tests for the error conditions in the API code - that should wrap it up | 21:39 |
| mriedem | then ill split up the tempest test patch tomorrow probably | 21:39 |
| ildikov | mriedem: ack | 21:40 |
| ildikov | mriedem: is there anything stvnoyes or me should/could do? | 21:40 |
| mriedem | yeah, something on my todo list is we're going to need a CI job defined for multiattach, probably in the nova experimental queue | 21:41 |
| mriedem | based on the devstack patches i have | 21:41 |
| mriedem | https://review.openstack.org/#/c/531386/ | 21:41 |
| *** pcaruana has joined #openstack-nova | 21:42 | |
| mriedem | i'm not sure if that job definition should live in nova with zuulv3, or if it should live in openstack-zuul-jobs since we'd want to run it on nova/cinder/tempest/devstack patches | 21:42 |
| *** jmlowe has quit IRC | 21:42 | |
| mriedem | mordred: ^ is there guidance on where a job should live if it's going to be run by multiple projects? | 21:42 |
| *** pcaruana has quit IRC | 21:43 | |
| ildikov | mriedem: ok | 21:43 |
| stvnoyes | mriedem: i am testing multiattach on libvirt 3.10.. so far it's working ok. But I just noticed that one of the libvirt modules, libvirt-bin, is at 3.6. The Debian site says "This is a transitional package." Do you think it matters? | 21:43 |
| stvnoyes | I'm having trouble finding a 3.10 version of that. | 21:44 |
| mriedem | i don't know what a transitional package is | 21:44 |
| mriedem | would probably have to ask zigo | 21:44 |
| ildikov | stvnoyes: do you have bandwidth to look into the CI job too? | 21:45 |
| mordred | mriedem: in general the idea is to have it live as close to the people who would be the most natural 'owners' | 21:45 |
| stvnoyes | I left out the import note that followed - "This is a transitional package. You can safely remove it." That's why I was thinking it might not matter. | 21:46 |
| mriedem | mordred: hmm, ok, i guess that is probably nova... | 21:46 |
| mriedem | or...devstack | 21:47 |
| *** dr_gogeta86 has quit IRC | 21:47 | |
| mordred | mriedem: it's perfectly acceptable to make a nova-devstack-multiattach in the nova repo and then have cinder, devstack, tempest repos add it to their .zuul.yaml files | 21:47 |
| mriedem | yeah i guess we'll just start with it in nova | 21:47 |
| mordred | or it could totally go in devstack, or tempest :) | 21:47 |
| mriedem | since the only tests so far are compute api tests in tempest | 21:47 |
| mriedem | ildikov: stvnoyes: if one of you do start on that, the first nova patch for zuulv3 layout is https://review.openstack.org/#/c/514309/ so you'd likely build on that | 21:48 |
| stvnoyes | mriedem ildikov: as for the CI job, I can take a look. I haven't played around with CI jobs before, but I can see how far I get | 21:48 |
| stvnoyes | ok I'll take a look at that | 21:48 |
| mriedem | stvnoyes: it's mostly copy and tweak | 21:48 |
| mriedem | we just need it to set this devstack variable https://review.openstack.org/#/c/531386/7/stackrc | 21:48 |
| mgagne | mriedem: when deprecating a rule name in oslo.policy, will the generator create an alias for the old name? My concern is with Horizon which might/will still use the legacy name until updated. | 21:48 |
| mordred | mriedem: this could be your first nova zuulv3-native job :) | 21:49 |
| mriedem | like https://review.openstack.org/#/c/514309/10/playbooks/legacy/nova-lvm/run.yaml@33 | 21:49 |
| stvnoyes | mriedem: kk, btw, is there any specific test you'd like to see with libvirt 3.10? So far, attach & detach are working ok. Was their a particular scenario that was failing? | 21:49 |
| mriedem | mordred: that i did? | 21:49 |
| mriedem | stvnoyes: the tempest patch is testing attach/detach to 2 servers, boot from volume with 1 server, and boot from volume and snapshot that volume-backed server | 21:50 |
| ildikov | stvnoyes: thanks much! | 21:50 |
| mriedem | stvnoyes: i think we also need testing for resize/cold migrate and swap volume | 21:50 |
| stvnoyes | all manual for now I presume? | 21:50 |
| mriedem | stvnoyes: sure, until we write tempest patches | 21:50 |
| mriedem | stvnoyes: if you want to add a resize test on top of the tempest patch https://review.openstack.org/#/c/266605/ go ahead | 21:51 |
| mriedem | should be pretty simple | 21:51 |
| stvnoyes | kk I'll do that | 21:51 |
| mriedem | swap volume gets tricky b/c that's an admin-only operation so i think that has to live in a different tree structure in tempest | 21:51 |
| mriedem | tempest/api/compute/admin/ | 21:51 |
| *** takashin has joined #openstack-nova | 21:51 | |
| *** threestrands_ has joined #openstack-nova | 21:52 | |
| *** threestrands_ has joined #openstack-nova | 21:52 | |
| mriedem | would live in here somewhere https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_volume_swap.py | 21:52 |
| mriedem | new test class to use the new microversion | 21:52 |
| *** threestrands_ has quit IRC | 21:53 | |
| *** threestrands_ has joined #openstack-nova | 21:53 | |
| *** threestrands_ has quit IRC | 21:53 | |
| *** threestrands_ has joined #openstack-nova | 21:53 | |
| *** threestrands has quit IRC | 21:54 | |
| mriedem | mgagne: not sure, lbragstad might know | 21:56 |
| mriedem | lbragstad: "when deprecating a rule name in oslo.policy, will the generator create an alias for the old name? My concern is with Horizon which might/will still use the legacy name until updated." | 21:56 |
| * lbragstad goes digging | 21:56 | |
| *** chyka_ has quit IRC | 21:57 | |
| *** jackie-truong has joined #openstack-nova | 21:58 | |
| *** archit has joined #openstack-nova | 21:59 | |
| *** smatzek has joined #openstack-nova | 22:00 | |
| *** matrohon has joined #openstack-nova | 22:00 | |
| lbragstad | mriedem: mgagne yeah - oslo.policy supports that case | 22:00 |
| lbragstad | mriedem: mgagne https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L590-L609 | 22:01 |
| lbragstad | it takes the new policy and adds an OrCheck to it with the deprecated one | 22:01 |
| mgagne | lbragstad: this is about the check string, not the rule name | 22:01 |
| mgagne | no? | 22:01 |
| lbragstad | yes - for the check string | 22:01 |
| lbragstad | not the name | 22:01 |
| mgagne | ok, I'm asking about name | 22:02 |
| lbragstad | sorry - misread the question | 22:02 |
| mgagne | because I got caught with Horizon still reading legacy name | 22:02 |
| mgagne | I used oslo policy generator to get a policy file and used that in horizon, big mistake | 22:02 |
| *** masber has joined #openstack-nova | 22:02 | |
| *** yamahata has quit IRC | 22:03 | |
| *** yamahata has joined #openstack-nova | 22:04 | |
| mgagne | so now what I'm trying to do is create a mapping file (still testing atm): https://gist.github.com/mgagne/c98982290ed72aecf668e5291b5ee027 | 22:04 |
| lbragstad | mgagne: so you're interested in this case - https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L1143-L1160 | 22:04 |
| *** smatzek has quit IRC | 22:05 | |
| lbragstad | hmm - we might have some work todo there | 22:05 |
| *** gouthamr_ has quit IRC | 22:06 | |
| mgagne | ok so there is nothing in place for that, legacy v2 got replaced by v2.1 (with new policy names) but never got some form of deprecation period or mapping | 22:07 |
| lbragstad | mgagne: today we iterate through all the policies, but the rule is only registered with the non-deprecated name https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L627 | 22:07 |
| mgagne | I think that if a policy name is deprecated and replaced by something else, sample file shouldn't include the literal string check in the legacy one but an alias to the new policy name so you can update the check string once | 22:08 |
| lbragstad | i suppose we could register another entry in that process with the deprecated name and check string iff that policy is deprecated | 22:08 |
| mgagne | basically, what I'm trying to test above | 22:09 |
| lbragstad | this is only the case when the policy *name* is changing, right? | 22:09 |
| mgagne | yes | 22:09 |
| *** yamahata has quit IRC | 22:09 | |
| mgagne | I'm sure there is more use cases but that's the one that seems to not be handled right now | 22:10 |
| mgagne | and which is causing some issues with horizon which expects to find the legacy names (well, the version of horizon I'm using) | 22:11 |
| lbragstad | this is because horizon uses the policy file to customize UI | 22:11 |
| mgagne | (ocata) | 22:11 |
| *** rcernin has joined #openstack-nova | 22:11 | |
| mgagne | if I generate a sample file for Nova, update it to fit my needs and then use it for Nova, Horizon will mostly read the "default" rule because it can't find the "legacy rules" | 22:12 |
| mgagne | and default is not included anymore iirc | 22:12 |
| mgagne | will have to double check on that one | 22:12 |
| lbragstad | wouldn't the problem be that horizon is looking for a policy name that no longer exists? | 22:13 |
| mgagne | yep, no default | 22:13 |
| lbragstad | so wouldn't you need an entry for each? | 22:13 |
| lbragstad | the deprecate option and the new option? | 22:13 |
| mlavalle | mriedem: have you seen the way the substring query is done in https://review.openstack.org/#/c/521683/? | 22:13 |
| lbragstad | in the generated policy file? | 22:13 |
| mlavalle | I want to make sure you are happy with it | 22:13 |
| mgagne | sure but... this also means you need to install the same version as Nova? can't install Horizon Ocata with Nova Newton? | 22:13 |
| mgagne | lbragstad: yes | 22:14 |
| mgagne | that's what I will end up with | 22:14 |
| mgagne | because I need to satisfy Horizon | 22:14 |
| lbragstad | so you'd need an ocata nova policy file... right? | 22:14 |
| mriedem | mlavalle: hmm, | 22:17 |
| mgagne | Current use case: Nova Newton with Horizon Ocata. Horizon Ocata still expects legacy policy names while generated policy file by Nova Newton does not content legacy names. | 22:18 |
| mriedem | '%s%%' | 22:18 |
| mriedem | mlavalle: not sure why it's not just '%%%s%%' | 22:18 |
| mriedem | so the substring could be anywhere within the IP address | 22:18 |
| mgagne | lbragstad: even if I had ocata policy file, it will never content legacy names ever again, they got removed and no mapping was created, even in-code. | 22:19 |
| mriedem | mlavalle: like this http://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/api.py#n709 | 22:19 |
| lbragstad | mgagne: well - one thing we could do is emit deprecated policies if we detect one | 22:20 |
| mgagne | lbragstad: this also means that even if Horizon got updated, in future, you would need to update Horizon and Nova in lockstep which I suspect is something we don't want to encourage or promote | 22:20 |
| mlavalle | mriedem: exactly. I want to make sure we deliver what you need on the Nova side. Thanks! | 22:20 |
| mriedem | hongbin: ^ | 22:21 |
| * lbragstad finds an example | 22:21 | |
| lbragstad | mgagne: ok - let's say we're doing this https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L1143-L1160 | 22:21 |
| *** corvus is now known as jeblair | 22:21 | |
| *** jackie-truong has quit IRC | 22:21 | |
| lbragstad | renaming foo:post_bar to foo:create_bar | 22:22 |
| hongbin | o/ | 22:22 |
| *** jeblair is now known as corvus | 22:22 | |
| mriedem | hongbin: see the questions about the IP substring filtering in neutron | 22:22 |
| mgagne | lbragstad: if you end up with: "foo:post_bar": "rule:foo:create_bar", that would be great I guess | 22:22 |
| lbragstad | or if you have "foo:post_bar": "role:fizz" and "foo:create_bar": "role"fizz" | 22:23 |
| lbragstad | even though they are the same thing | 22:23 |
| -openstackstatus- NOTICE: The zuul system is being restarted to apply security updates and will be offline for several minutes. It will be restarted and changes re-equeued; changes approved during the downtime will need to be rechecked or re-approved. | 22:23 | |
| mgagne | lbragstad: so I need to update 2 rules if I change a check string? | 22:23 |
| lbragstad | ah - right, i see what you mean | 22:24 |
| mgagne | but we need to determine for how long you want to support legacy names | 22:24 |
| hongbin | mriedem: mlavalle : the patch was originally proposed to support full substring (%%%s%%), zhenyu commented on it to give preference to a right hand substring (%s%%), so i made the revision | 22:24 |
| lbragstad | mgagne: i think that would depend in how long you want to support a deprecated policy | 22:25 |
| lbragstad | when it is removed, it's no longer rendered in the policy file | 22:25 |
| mgagne | because do you want to be able to run Horizon on release Xylophone but with Nova Mitaka? | 22:25 |
| mriedem | hongbin: hmm, ok we should ask Kevin_Zheng then probably | 22:25 |
| mriedem | when he's awake | 22:25 |
| lbragstad | mgagne: that's a good question - but i'm not sure i'm qualified to answer it :) | 22:25 |
| mgagne | yea, just something to consider | 22:25 |
| hongbin | mriedem: sure, i will send the email | 22:26 |
| mgagne | but the one major release deprecation period might not be enough in that case | 22:26 |
| lbragstad | would you expect to run deprecated configuration options from Mitaka in Xylophone/ | 22:26 |
| mgagne | because the* | 22:26 |
| mgagne | current, that's what I'm doing | 22:26 |
| mgagne | was Nova Kilo with Horizon Ocata until very recently. | 22:26 |
| mgagne | now Mitaka/Ocata | 22:27 |
| lbragstad | ack | 22:27 |
| mgagne | but also... Horizon should use new names... | 22:27 |
| lbragstad | right - i also expect this issue to be limited to horizon feeding off a generated policy file | 22:27 |
| * bauzas raises fist at devstack | 22:27 | |
| mgagne | lbragstad: afaik, there is no way to consume policy through API so there might be some 3rd party softwares consuming policy files too | 22:28 |
| bauzas | any idea why it sticks my oslo.policy version to be 1.28.1 while I'm upgrading the package before ? | 22:28 |
| lbragstad | because if nova deprecates a policy name, they are likely going to start using the new policy name in the service around the same time they deprecate it | 22:28 |
| *** jmlowe has joined #openstack-nova | 22:28 | |
| bauzas | because it raises an exception when running nova api_db sync | 22:28 |
| *** felipemonteiro__ has joined #openstack-nova | 22:29 | |
| mlavalle | hongbin, mriedem: thanks! | 22:29 |
| mgagne | lbragstad: would need to find a way to detect legacy policy names usage in horizon | 22:29 |
| lbragstad | mgagne: yeah | 22:29 |
| mgagne | lbragstad: policy names got updated in Horizon Pike | 22:29 |
| mgagne | https://github.com/openstack/horizon/commit/c61ae4f0834253e523c4443cecb3ce5eb06bf89b | 22:29 |
| mgagne | but issue still remain, can't update a policy name without breaking horizon | 22:30 |
| lbragstad | this is neither here nor there, but i'm hoping to have a PoC of a capabilities API that removes the need for rendered policy files by dublin | 22:31 |
| bauzas | oh snap, I need to git pull my requirements directotyu | 22:32 |
| lbragstad | mgagne: would you want to open a bug against oslo.policy for this? | 22:33 |
| *** felipemonteiro_ has quit IRC | 22:33 | |
| mgagne | lbragstad: project is using LP? | 22:33 |
| lbragstad | yes | 22:33 |
| mgagne | cool cool | 22:33 |
| mgagne | will do | 22:33 |
| lbragstad | https://launchpad.net/oslo.policy | 22:33 |
| mgagne | sure, just wanted to make sure it's not storyboard =) | 22:34 |
| lbragstad | fwiw - i think we should be able to support rendering deprecated policy names pretty easy | 22:34 |
| lbragstad | but getting horizon to figure out if a policy name is deprecated is going to require a bit more work | 22:35 |
| *** gouthamr has joined #openstack-nova | 22:37 | |
| *** threestrands_ has quit IRC | 22:41 | |
| *** tidwellr_ has quit IRC | 22:41 | |
| *** tidwellr has joined #openstack-nova | 22:41 | |
| *** gouthamr has quit IRC | 22:42 | |
| *** matrohon has quit IRC | 22:44 | |
| *** lyan has quit IRC | 22:45 | |
| *** slaweq has quit IRC | 22:47 | |
| *** lyan has joined #openstack-nova | 22:47 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM driver: ovs vif https://review.openstack.org/422512 | 22:47 |
| *** lyan has quit IRC | 22:48 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: SEA https://review.openstack.org/523216 | 22:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 22:50 |
| *** archit has quit IRC | 22:50 | |
| mriedem | ildikov: johnthetubaguy: stvnoyes: ^ done with the API change, ready for review | 22:51 |
| mriedem | tests are done | 22:51 |
| mriedem | and gibi ^ | 22:51 |
| mriedem | stvnoyes: i'll work on the zuulv3 job if you didn't start on that yet | 22:52 |
| *** jmlowe has quit IRC | 22:52 | |
| ildikov | mriedem: looks great, thanks! | 22:52 |
| mriedem | sdague: if you're looking for an easy patch, this undumbifies our USE_NEUTRON usage in the functional tests https://review.openstack.org/#/c/529456/ | 22:53 |
| *** threestrands has joined #openstack-nova | 22:55 | |
| *** threestrands has quit IRC | 22:55 | |
| *** threestrands has joined #openstack-nova | 22:55 | |
| lbragstad | mgagne: we might be able to do something like - https://review.openstack.org/#/c/532685/ | 22:56 |
| lbragstad | mgagne: let me know if that helps you work around the issue | 22:57 |
| *** edmondsw has quit IRC | 22:59 | |
| mgagne | lbragstad: looks mostly good, commented already. I think the other issue is that Nova didn't register the legacy names and I needed to dig in code to find the expected name. | 23:01 |
| lbragstad | mgagne: responded - yeah the deprecation bits in oslo.policy are pretty new | 23:02 |
| lbragstad | i'm not sure if nova had a pre-existing deprecation implementation in nova | 23:02 |
| mgagne | none that I'm aware of | 23:02 |
| *** aloga_ has quit IRC | 23:04 | |
| *** burt has quit IRC | 23:05 | |
| *** awaugama has quit IRC | 23:06 | |
| mgagne | lbragstad: ok, finally tested gist I posted above. the alias thing works fine. | 23:07 |
| mgagne | => "compute:create": "rule:os_compute_api:servers:create" | 23:07 |
| lbragstad | sweet | 23:08 |
| mgagne | so legacy policy name "compute:create" becomes an alias of "os_compute_api:servers:create" | 23:08 |
| lbragstad | nice - that makes sense | 23:08 |
| *** tidwellr has quit IRC | 23:09 | |
| lbragstad | mgagne: pushed a new patch | 23:10 |
| *** felipemonteiro__ has quit IRC | 23:10 | |
| mgagne | this works for me. only use case I'm not sure about is if both name and check string are deprecated. =) | 23:11 |
| *** threestrands has quit IRC | 23:11 | |
| mgagne | like you get a new name AND a new check string :D | 23:11 |
| lbragstad | in that case, the policy is being removed all together, right? | 23:11 |
| *** jmlowe has joined #openstack-nova | 23:12 | |
| lbragstad | or it can be the name and the check_str is changing at the same time... | 23:12 |
| mgagne | I don't know tbh. but it would still be a supported use case by oslo policy, won't fail with: can't deprecate both name and check string. | 23:12 |
| mgagne | yes, that's what I'm referring to | 23:13 |
| mgagne | lbragstad: I'm super bad with bug description, feel free to update =) https://bugs.launchpad.net/oslo.policy/+bug/1742569 | 23:17 |
| openstack | Launchpad bug 1742569 in oslo.policy "Including deprecated policy names in sample file" [Undecided,New] | 23:17 |
| lbragstad | mgagne: looks good - thanks for the report | 23:18 |
| lbragstad | mgagne: i'm sure we'll be able to get that addressed before library freeze | 23:18 |
| mgagne | cool, thanks! =) | 23:19 |
| mgagne | for now, will use my legacy mapping, looks to work fine with Horizon Ocata and Nova Newton | 23:20 |
| *** threestrands has joined #openstack-nova | 23:20 | |
| *** hongbin has quit IRC | 23:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the nova-multiattach experimental queue job https://review.openstack.org/532689 | 23:27 |
| mriedem | ildikov: stvnoyes: the new multiattach job ^ | 23:27 |
| ildikov | mriedem: I owe you | 23:29 |
| *** armax has quit IRC | 23:36 | |
| gmann | mriedem: we can mark this complete now -https://blueprints.launchpad.net/nova/+spec/api-extensions-policy-removal | 23:39 |
| mriedem | gmann: cool thanks | 23:40 |
| *** efried has quit IRC | 23:44 | |
| *** liverpooler has quit IRC | 23:44 | |
| *** jmlowe has quit IRC | 23:44 | |
| *** jmlowe has joined #openstack-nova | 23:46 | |
| *** sdague has quit IRC | 23:47 | |
| *** kumarmn has joined #openstack-nova | 23:47 | |
| *** pchavva has quit IRC | 23:50 | |
| *** andreykurilin has quit IRC | 23:52 | |
| *** kumarmn has quit IRC | 23:52 | |
| *** andreykurilin has joined #openstack-nova | 23:53 | |
| *** edmondsw has joined #openstack-nova | 23:55 | |
| *** yamamoto has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!