Friday, 2017-12-22

*** salv-orlando has quit IRC00:00
*** suresh12 has quit IRC00:04
*** takashin has left #openstack-nova00:04
*** derekh has joined #openstack-nova00:06
openstackgerritMatt Riedemann proposed openstack/nova master: Fix functional tests for USE_NEUTRON  https://review.openstack.org/52945600:06
*** suresh12 has joined #openstack-nova00:06
*** penick_ has quit IRC00:08
*** penick has joined #openstack-nova00:08
*** penick has quit IRC00:08
openstackgerritMatt Riedemann proposed openstack/nova master: Fix functional tests for USE_NEUTRON  https://review.openstack.org/52945600:12
*** david-lyle has quit IRC00:12
*** david-lyle has joined #openstack-nova00:12
*** huanxie has quit IRC00:19
*** huanxie has joined #openstack-nova00:19
*** harlowja has quit IRC00:23
*** chyka has quit IRC00:25
*** jobewan has quit IRC00:27
*** tuanla____ has joined #openstack-nova00:27
*** derekh has quit IRC00:27
*** yangyapeng has quit IRC00:28
*** hiro-kobayashi has joined #openstack-nova00:30
*** derekh has joined #openstack-nova00:32
*** AlexeyAbashkin has joined #openstack-nova00:33
*** mlavalle has quit IRC00:37
*** AlexeyAbashkin has quit IRC00:37
*** gongysh has joined #openstack-nova00:49
*** huanxie has quit IRC00:50
*** huanxie has joined #openstack-nova00:51
*** edmondsw has joined #openstack-nova00:52
*** gongysh has quit IRC00:55
*** kumarmn has quit IRC00:56
*** salv-orlando has joined #openstack-nova00:56
*** edmondsw has quit IRC00:57
*** phuongnh has joined #openstack-nova00:58
*** markvoelker has quit IRC00:58
yikunhttps://launchpad.net/bugs/1739571 and https://review.openstack.org/#/c/529519/00:59
openstackLaunchpad bug 1739571 in OpenStack Compute (nova) "Can't delete root resource provider because of the self foreign key" [Undecided,In progress] - Assigned to Yikun Jiang (yikunkero)01:00
yikunhello, morning or evening, ^^^ I found a bug, but this bug only reproduced in MySQL environment.01:00
yikunbut seems our testcases only run in SQLite, so, is there some apporach to test it?01:00
*** chyka has joined #openstack-nova01:01
*** salv-orlando has quit IRC01:02
*** claudiub has quit IRC01:02
*** chyka has quit IRC01:06
*** derekh has quit IRC01:07
*** markvoelker has joined #openstack-nova01:10
*** daidv has quit IRC01:25
*** tuanla____ has quit IRC01:25
*** hieulq has quit IRC01:25
*** daidv has joined #openstack-nova01:25
*** hieulq has joined #openstack-nova01:25
*** tuanla____ has joined #openstack-nova01:25
*** Tom-Tom has quit IRC01:25
*** Apoorva has quit IRC01:29
*** psachin has joined #openstack-nova01:32
*** yangyapeng has joined #openstack-nova01:32
*** AlexeyAbashkin has joined #openstack-nova01:34
*** marst has quit IRC01:38
*** AlexeyAbashkin has quit IRC01:38
*** Tom-Tom has joined #openstack-nova01:40
openstackgerritMinho Ban proposed openstack/nova master: prevent removing numa_topology usage info from DB  https://review.openstack.org/52923601:44
*** lei-zh has joined #openstack-nova01:45
*** gyee has quit IRC01:48
*** liverpooler has joined #openstack-nova01:54
*** salv-orlando has joined #openstack-nova01:58
*** salv-orlando has quit IRC02:03
alex_xumriedem: oomichi do you like using the 'controller' instead of 'extension'?02:06
*** gongysh has joined #openstack-nova02:09
*** zhenguo has joined #openstack-nova02:13
*** linkmark has quit IRC02:19
*** liverpooler has quit IRC02:20
*** yikun_ has quit IRC02:22
*** suresh12 has quit IRC02:26
*** huanxie has quit IRC02:27
*** Apoorva has joined #openstack-nova02:30
mriedemalex_xu: i'll do either02:31
mriedemyikun: there is a trick to make foreign keys work with sqlite,02:32
*** itlinux has quit IRC02:32
mriedemsec02:32
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Fix error when deleting any root resource provider  https://review.openstack.org/52951902:33
mriedemsqlite 3.7+ should work with foreign keys02:33
mriedemsee TestDatabaseArchive02:33
*** suresh12 has joined #openstack-nova02:33
mriedemengine.connect().execute("PRAGMA foreign_keys = ON")02:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test allocation candidates: multiple aggregates  https://review.openstack.org/51863302:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898202:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix accumulated nits in refactor series  https://review.openstack.org/52118902:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation candidates  https://review.openstack.org/52240702:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates  https://review.openstack.org/52240902:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs  https://review.openstack.org/49873702:33
*** AlexeyAbashkin has joined #openstack-nova02:34
yikuno? I will take a look, and try it in my local env, thanks. : )02:34
yikunmriedem,02:34
mriedemyw02:34
*** Apoorva has quit IRC02:35
*** suresh12 has quit IRC02:38
*** AlexeyAbashkin has quit IRC02:38
mriedemyikun: fyi https://review.openstack.org/#/c/529672/02:38
mriedemturns out we needed that after all02:38
*** psachin has quit IRC02:40
*** mriedem has quit IRC02:40
yikunmriedem, emm, yes, +1, the deadlock on action event start is possible,02:42
yikunbecause action and event doesn't have some relation ship, so sqlalchemy session mechanism can't ensure the update order.02:42
yikunsome ref: http://www.aosabook.org/en/sqlalchemy.html   # 20.9. Unit of Work02:43
Kevin_Zhengconsider add relationship?02:45
openstackgerritMerged openstack/nova master: Fix unit test failures when direct IO not supported  https://review.openstack.org/52956802:45
Kevin_Zhengmriedem we were thinking about a full scan about these kind of things in Nova02:46
Kevin_Zhenghttps://review.openstack.org/#/c/527362/02:46
*** yikun_ has joined #openstack-nova02:47
Kevin_Zheng^ the deadlock retry method is not perfect, so we might be able to improve performance here02:47
*** yamahata has quit IRC02:53
*** psachin has joined #openstack-nova02:55
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test allocation candidates: multiple aggregates  https://review.openstack.org/51863302:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898202:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix accumulated nits in refactor series  https://review.openstack.org/52118902:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation candidates  https://review.openstack.org/52240702:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates  https://review.openstack.org/52240902:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs  https://review.openstack.org/49873702:58
*** salv-orlando has joined #openstack-nova02:59
*** salv-orlando has quit IRC03:03
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/52978303:04
*** zhurong has joined #openstack-nova03:09
*** xinliang has quit IRC03:19
*** Guest98938 has quit IRC03:20
*** itlinux has joined #openstack-nova03:22
*** crushil has joined #openstack-nova03:29
*** yamahata has joined #openstack-nova03:33
*** crushil has quit IRC03:33
openstackgerritTetsuro Nakamura proposed openstack/nova master: trivial: use cn instead of rp  https://review.openstack.org/52978603:37
*** Tom-Tom has quit IRC03:47
*** Tom-Tom has joined #openstack-nova03:48
*** Tom-Tom has quit IRC04:00
*** salv-orlando has joined #openstack-nova04:00
*** Tom-Tom has joined #openstack-nova04:01
*** salv-orlando has quit IRC04:04
*** Tom-Tom has quit IRC04:05
*** archit is now known as amodi04:09
*** markvoelker has quit IRC04:13
*** lei-zh has quit IRC04:20
*** rcernin has quit IRC04:26
*** rcernin has joined #openstack-nova04:27
*** edmondsw has joined #openstack-nova04:28
*** threestrands_ has quit IRC04:29
*** zhurong has quit IRC04:32
*** edmondsw has quit IRC04:33
*** yamamoto has joined #openstack-nova04:39
*** udesale has joined #openstack-nova04:39
*** amodi has quit IRC04:43
*** links has joined #openstack-nova04:43
*** gmann has joined #openstack-nova04:46
*** rcernin has quit IRC04:47
*** gongysh has quit IRC04:48
*** rcernin has joined #openstack-nova04:49
*** hshiina has joined #openstack-nova04:51
*** Apoorva has joined #openstack-nova04:56
*** sridharg has joined #openstack-nova04:56
*** salv-orlando has joined #openstack-nova04:58
*** lbragstad has quit IRC04:59
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node  https://review.openstack.org/52334205:03
*** yangyapeng has quit IRC05:17
*** yangyapeng has joined #openstack-nova05:17
*** daidv has quit IRC05:26
*** tuanla____ has quit IRC05:26
*** daidv has joined #openstack-nova05:26
*** tuanla____ has joined #openstack-nova05:26
*** sridharg has quit IRC05:32
*** janki has joined #openstack-nova05:34
*** yangyapeng has quit IRC05:36
*** yangyapeng has joined #openstack-nova05:37
*** yangyapeng has quit IRC05:41
*** Apoorva has quit IRC05:43
*** gcb has quit IRC05:44
*** ejat has quit IRC05:52
*** armax has quit IRC05:54
*** vivsoni has joined #openstack-nova05:56
*** gongysh has joined #openstack-nova05:57
*** sridharg has joined #openstack-nova05:59
*** ejat has joined #openstack-nova06:00
*** ejat has joined #openstack-nova06:00
*** ejat has quit IRC06:00
*** ejat has joined #openstack-nova06:01
*** ejat has quit IRC06:01
*** ejat has joined #openstack-nova06:01
*** gouthamr has quit IRC06:07
*** yangyapeng has joined #openstack-nova06:07
*** ratailor has joined #openstack-nova06:07
*** markvoelker has joined #openstack-nova06:14
*** edmondsw has joined #openstack-nova06:16
*** Tom-Tom has joined #openstack-nova06:19
*** edmondsw has quit IRC06:20
*** yikun_ has quit IRC06:22
*** tetsuro_ has quit IRC06:29
*** alexchadin has joined #openstack-nova06:31
*** Tom-Tom_ has joined #openstack-nova06:32
*** felipemonteiro__ has joined #openstack-nova06:35
*** Tom-Tom has quit IRC06:35
-openstackstatus- NOTICE: Zuul.openstack.org is currently under heavy load and not starting new jobs. We're waiting for an admin to restart Zuul.06:44
*** sridharg has quit IRC06:44
*** heyongli has joined #openstack-nova06:48
*** markvoelker has quit IRC06:49
*** sridharg has joined #openstack-nova06:52
*** heyongli has quit IRC06:53
*** heyongli has joined #openstack-nova06:54
*** hemna_ has quit IRC06:56
*** heyongli has quit IRC07:04
*** heyongli has joined #openstack-nova07:04
*** rcernin has quit IRC07:04
*** hiro-kobayashi has quit IRC07:10
*** jdurgin has quit IRC07:11
*** heyongli has quit IRC07:14
*** heyongli has joined #openstack-nova07:14
*** heyongli has quit IRC07:24
*** heyongli has joined #openstack-nova07:24
*** heyongli has quit IRC07:34
*** heyongli has joined #openstack-nova07:35
*** claudiub has joined #openstack-nova07:40
*** hui has quit IRC07:44
*** heyongli has quit IRC07:45
*** heyongli has joined #openstack-nova07:45
*** AlexeyAbashkin has joined #openstack-nova07:53
*** heyongli has quit IRC07:55
*** heyongli has joined #openstack-nova07:55
*** sahid has joined #openstack-nova07:57
*** edmondsw has joined #openstack-nova08:04
*** heyongli has quit IRC08:05
*** heyongli has joined #openstack-nova08:05
*** edmondsw has quit IRC08:09
*** AlexeyAbashkin has quit IRC08:15
*** heyongli has quit IRC08:15
*** heyongli has joined #openstack-nova08:16
*** AlexeyAbashkin has joined #openstack-nova08:21
*** tuanla____ has quit IRC08:22
*** daidv has quit IRC08:22
*** hieulq has quit IRC08:22
*** daidv has joined #openstack-nova08:22
*** tuanla____ has joined #openstack-nova08:22
*** hieulq has joined #openstack-nova08:22
*** pcaruana has joined #openstack-nova08:24
*** AlexeyAbashkin has quit IRC08:25
*** heyongli has quit IRC08:26
*** AlexeyAbashkin has joined #openstack-nova08:26
*** phuongnh has quit IRC08:26
*** hoangcx has quit IRC08:26
*** heyongli has joined #openstack-nova08:26
*** phuongnh has joined #openstack-nova08:26
*** hoangcx has joined #openstack-nova08:26
*** abhishekk has joined #openstack-nova08:27
*** damien_r has joined #openstack-nova08:32
*** heyongli has quit IRC08:36
*** heyongli has joined #openstack-nova08:36
*** yamamoto has quit IRC08:36
*** kholkina has joined #openstack-nova08:44
*** jpena|off is now known as jpena08:45
*** fragatina has joined #openstack-nova08:45
*** markvoelker has joined #openstack-nova08:46
*** heyongli has quit IRC08:46
*** heyongli has joined #openstack-nova08:46
*** yamamoto has joined #openstack-nova08:47
*** yamamoto has quit IRC08:48
*** yamamoto has joined #openstack-nova08:49
*** zhurong has joined #openstack-nova08:55
*** nore__ has quit IRC08:56
*** heyongli has quit IRC08:56
*** heyongli has joined #openstack-nova08:57
*** Tom-Tom_ has quit IRC09:04
*** Tom-Tom has joined #openstack-nova09:04
*** heyongli has quit IRC09:07
*** heyongli has joined #openstack-nova09:07
*** Tom-Tom has quit IRC09:07
*** Tom-Tom has joined #openstack-nova09:08
*** karthiks has joined #openstack-nova09:09
*** heyongli has quit IRC09:17
*** heyongli has joined #openstack-nova09:17
*** derekh has joined #openstack-nova09:18
*** markvoelker has quit IRC09:19
*** Tom-Tom has quit IRC09:19
*** felipemonteiro__ has quit IRC09:21
*** heyongli has quit IRC09:27
*** heyongli has joined #openstack-nova09:27
*** lucas-afk is now known as lucasagomes09:31
openstackgerritMaciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource  https://review.openstack.org/52002409:33
openstackgerritMaciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource  https://review.openstack.org/52002409:37
*** heyongli has quit IRC09:37
*** heyongli has joined #openstack-nova09:38
*** Jack_Iv has joined #openstack-nova09:43
*** Jack_Iv has quit IRC09:45
*** Jack_Iv has joined #openstack-nova09:45
*** ralonsoh has joined #openstack-nova09:45
*** heyongli has quit IRC09:48
*** heyongli has joined #openstack-nova09:48
*** edmondsw has joined #openstack-nova09:52
*** chyka has joined #openstack-nova09:56
*** hshiina has quit IRC09:56
*** edmondsw has quit IRC09:57
*** heyongli has quit IRC09:58
*** heyongli has joined #openstack-nova09:58
*** owalsh_ is now known as owalsh10:00
*** chyka has quit IRC10:01
*** zhurong has quit IRC10:04
*** heyongli has quit IRC10:08
*** heyongli has joined #openstack-nova10:08
*** gongysh has quit IRC10:10
*** daidv has quit IRC10:10
*** psachin has quit IRC10:12
ralonsohstephenfin: hi, about https://review.openstack.org/#/c/449257/52/nova/pci/request.py@9310:14
*** markvoelker has joined #openstack-nova10:16
*** tuanla____ has quit IRC10:17
-openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate10:17
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field  https://review.openstack.org/44925710:18
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot  https://review.openstack.org/50748110:18
*** heyongli has quit IRC10:18
*** heyongli has joined #openstack-nova10:19
*** heyongli has quit IRC10:29
*** heyongli has joined #openstack-nova10:29
*** hoangcx has quit IRC10:35
*** heyongli has quit IRC10:39
*** heyongli has joined #openstack-nova10:39
*** cdent has joined #openstack-nova10:46
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance  https://review.openstack.org/52883210:49
*** heyongli has quit IRC10:49
*** heyongli has joined #openstack-nova10:49
*** markvoelker has quit IRC10:50
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API  https://review.openstack.org/47661210:55
*** abhishekk has quit IRC10:57
*** heyongli has quit IRC10:59
*** heyongli has joined #openstack-nova11:00
*** udesale has quit IRC11:00
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API  https://review.openstack.org/47661211:01
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API  https://review.openstack.org/48222611:05
*** heyongli has quit IRC11:10
*** heyongli has joined #openstack-nova11:10
*** AlexeyAbashkin has quit IRC11:13
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2'  https://review.openstack.org/48438611:16
*** itlinux has quit IRC11:16
*** heyongli has quit IRC11:20
*** heyongli has joined #openstack-nova11:20
*** phuongnh has quit IRC11:20
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache  https://review.openstack.org/47277311:22
*** heyongli has quit IRC11:30
*** heyongli has joined #openstack-nova11:30
*** AlexeyAbashkin has joined #openstack-nova11:31
openstackgerritrahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique  https://review.openstack.org/52792211:33
*** xinliang has joined #openstack-nova11:33
*** xinliang has quit IRC11:33
*** xinliang has joined #openstack-nova11:33
*** heyongli has quit IRC11:40
*** edmondsw has joined #openstack-nova11:41
*** heyongli has joined #openstack-nova11:41
*** janki has quit IRC11:41
*** edmondsw has quit IRC11:45
*** markvoelker has joined #openstack-nova11:47
*** heyongli has quit IRC11:51
*** heyongli has joined #openstack-nova11:51
*** vladikr has quit IRC11:54
*** vladikr has joined #openstack-nova11:56
*** alexchadin has quit IRC11:58
*** ratailor has quit IRC12:00
*** karthiks has quit IRC12:01
*** heyongli has quit IRC12:01
*** ratailor has joined #openstack-nova12:01
*** heyongli has joined #openstack-nova12:01
*** alexchad_ has joined #openstack-nova12:02
*** alexchad_ has quit IRC12:06
*** alexchadin has joined #openstack-nova12:08
*** smatzek has joined #openstack-nova12:10
*** heyongli has quit IRC12:11
*** yamamoto has quit IRC12:11
*** heyongli has joined #openstack-nova12:11
*** alexchadin has quit IRC12:13
*** yamamoto has joined #openstack-nova12:19
*** markvoelker has quit IRC12:20
*** heyongli has quit IRC12:21
*** heyongli has joined #openstack-nova12:22
*** chyka has joined #openstack-nova12:22
*** tbachman has quit IRC12:26
*** chyka has quit IRC12:27
*** Lingwu has quit IRC12:29
*** Lingwu has joined #openstack-nova12:31
*** heyongli has quit IRC12:32
*** heyongli has joined #openstack-nova12:32
*** gmann has quit IRC12:33
*** lucasagomes is now known as lucas-hungry12:38
*** heyongli has quit IRC12:42
*** heyongli has joined #openstack-nova12:42
*** takedakn has joined #openstack-nova12:43
*** Jack_Iv has quit IRC12:46
*** linkmark has joined #openstack-nova12:47
*** Jack_Iv has joined #openstack-nova12:47
*** Jack_Iv has quit IRC12:52
*** heyongli has quit IRC12:52
*** heyongli has joined #openstack-nova12:52
*** jpena is now known as jpena|lunch12:53
jaypipesgood morning nova comrades.12:55
*** dave-mccowan has joined #openstack-nova12:56
cdentmorning jaypipes12:57
cdentget your dishwasher and dinner sorted?12:58
jaypipesno and yes.12:58
jaypipescdent: friggin electricians hooked up the dishwasher's electric but said they could touch the plumbing. so I hooked up the plumbing and there's a leak. so my wife's uncle is out grabbing plumber's tape and we're going to pull it out and have a look at where the leak is. the saga continues.12:59
cdentargh12:59
jaypipescdent: cost me almost as much for the 1.25 hours of electrician as for the new dishwasher :(12:59
jaypipes$400...12:59
cdentjeebus12:59
jaypipesya.13:00
*** ratailor has quit IRC13:00
jaypipesso after dinner, the eleven of us just made a Hobbit-dwarf-esque factory line and polished off the dish cleanup team-style.13:00
cdentwell if it makes you feel any better, one christmas at my parents, where they had no dishwasher, I was responsible for peeling the potatoes and somehow managed to completely screwn up the garbage disposal such that the sink wouldn't drain13:00
cdentwe did the dishes in the bathtub13:01
cdentdid you sing?13:01
*** heyongli has quit IRC13:02
*** heyongli has joined #openstack-nova13:03
*** vladikr has quit IRC13:06
jaypipescdent: heh, that's... awesome. :) and no, I did not sign.13:06
jaypipessing13:06
*** Jack_Iv has joined #openstack-nova13:08
*** Jack_Iv has quit IRC13:10
*** Jack_Iv has joined #openstack-nova13:11
maciejjozefczykjaypipes: good morning13:12
jaypipesmaciejjozefczyk: mornin!13:12
jaypipesmaciejjozefczyk: or afternoon for you I suppose :)13:12
*** jaypipes is now known as leakypipes13:13
*** heyongli has quit IRC13:13
leakypipescdent: my nick actually reflects current status today.13:13
*** ygl has joined #openstack-nova13:13
*** heyongli has joined #openstack-nova13:13
cdentwoot13:13
maciejjozefczykjaypipes: here in PL - yes, afternoon, but also good ;)13:13
leakypipesmaciejjozefczyk: are you in Poznan or Gdansk?13:14
maciejjozefczykleakypipes: sorry for saying that but this change https://review.openstack.org/#/c/520024 breaks resource tracking in placement :) I need to dig more13:14
maciejjozefczykleakypipes: Wroclaw13:14
leakypipesah13:14
*** Jack_Iv has quit IRC13:15
leakypipesmaciejjozefczyk: k, I'll take a look at that patch again (on the resource provider issue) shortly.13:15
*** dave-mcc_ has joined #openstack-nova13:16
leakypipesmaciejjozefczyk: what you can try in the meantime is just replacing each of those calls to self._update() one by one and see which specific one causes the invalid inventory exception to go away...13:17
openstackgerritrahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique  https://review.openstack.org/52792213:17
maciejjozefczykleakypipes: I found that its in _update_inventory_for_provider /opt/stack/nova/nova/objects/resource_provider.py(23213:17
*** markvoelker has joined #openstack-nova13:17
leakypipesmaciejjozefczyk: yes, I see that. but I'm wondering which of the locations in https://review.openstack.org/#/c/520024/8/nova/compute/resource_tracker.py where you removed the call to self._update() causes that exception to be hit.13:18
leakypipesmaciejjozefczyk: so you might try replacing (one by one) those call locations of self._update() in the resource tracker and determining which of those calls fixes the reserved inventory invalid exception.13:19
leakypipesthat's all I was saying :)13:19
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2'  https://review.openstack.org/48438613:19
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands  https://review.openstack.org/48740513:19
*** dave-mccowan has quit IRC13:19
*** tetsuro has joined #openstack-nova13:20
*** owalsh is now known as owalsh_afk13:23
*** Jack_Iv has joined #openstack-nova13:23
*** heyongli has quit IRC13:23
maciejjozefczykleakypipes: I found that because I've removed duplications the self._resource_change(compute_node) always says false (yeah, thats right) so the ComputeNode object is not updated directly (I mean with cn.save()), and without this call the exceptions is raised by placement13:23
maciejjozefczykhttps://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L85413:23
*** heyongli has joined #openstack-nova13:23
maciejjozefczykleakypipes: anyway, need to switch context because of other tasks... We'll dig it later ;)13:23
maciejjozefczyks/we/I/ :)13:24
leakypipesk, no prob13:24
bauzashola, folks13:24
bauzas(yeah, it seems weird that I'm looking to be in an US TZ, but no worries, I was not looking at the IRC this morning :p)13:24
leakypipesbauzas: where are ya?13:26
bauzasjust still in Le Versoud, FR :p13:26
bauzaswed, I was off because $skiing13:27
bauzasso, I needed to work off the IRC by this morning for other things :(13:27
bauzasoh, and Friday, right13:28
*** bauzas is now known as bauwser13:28
*** Jack_Iv has quit IRC13:30
*** ralonsoh has quit IRC13:30
*** Jack_Iv has joined #openstack-nova13:31
openstackgerritMerged openstack/nova master: Don't try to delete build request during a reschedule  https://review.openstack.org/52883513:33
*** heyongli has quit IRC13:33
*** heyongli has joined #openstack-nova13:33
*** edleafe is now known as figleaf13:36
*** yangyapeng has quit IRC13:36
*** yangyapeng has joined #openstack-nova13:37
*** Jack_Iv has quit IRC13:37
*** Jack_Iv has joined #openstack-nova13:38
*** mriedem has joined #openstack-nova13:38
*** tetsuro has quit IRC13:38
*** markvoelker has quit IRC13:40
*** markvoelker has joined #openstack-nova13:40
*** yangyapeng has quit IRC13:42
*** stephenfin is now known as finucannot13:42
mriedemmdbooth: ping me once https://review.openstack.org/#/c/242602/ is fixed up and i'll +213:42
mdboothmriedem: Thanks, will do.13:43
bauwsermriedem: today is my last day for 2017, how can I help for today ?13:43
*** heyongli has quit IRC13:43
*** heyongli has joined #openstack-nova13:44
bauwsermriedem: I worked most of the time off IRC because *VGPU, but in case you need stable reviews or anything else13:44
*** links has quit IRC13:45
mriedembauwser: we have these ocata and newton backports yet https://review.openstack.org/#/q/I214a44f0eee7d90be5cd89f32f6e0017b19a3fd613:45
bauwserah right, I saw the email13:46
bauwsermriedem: thanks for helping on that bug, btw.13:46
*** jpena|lunch is now known as jpena13:46
mriedembauwser: and these https://review.openstack.org/#/q/I0b3ec6bb098ca32ffd32a61d4f9dcf426c3faf4613:46
mriedemthis is my last day for 2017 also13:46
*** dtantsur|afk is now known as dtantsur13:47
*** kumarmn has joined #openstack-nova13:47
finucannotbauwser: Polite reminder to take a second look at https://review.openstack.org/#/q/topic:bp/share-pci-between-numa-nodes+status:open too, please :)13:49
bauwsermriedem: also, note I'll be off until Jan 8th13:49
finucannotI'm hoping leakypipes will come around on the middle one. I'm almost certain I'm correct in what I'm saying13:49
* finucannot is around Wed-Fri of next week, fwiw13:50
* bauwser trying to give more visibility on his agenda :)13:50
bauwserfinucannot: I did, and I saw you answered to leakypipes13:50
bauwserI need a bit more time to think about the concern13:50
leakypipesfinucannot: currently trying to diagnose https://bugs.launchpad.net/nova/+bug/173951713:50
openstackLaunchpad bug 1739517 in OpenStack Compute (nova) "TestNovaMigrationsMySQL randomly fails with "sqlalchemy.exc.ResourceClosedError: This result object does not return rows. It has been closed automatically."" [High,Confirmed]13:50
*** lucas-hungry is now known as lucasagomes13:51
finucannotOh, that beauty13:51
figleafleakypipes: it would have been cheaper to fly me to FLA and install your dishwasher for you13:51
leakypipesfigleaf: yeah, no shit..13:51
*** mlavalle has joined #openstack-nova13:51
openstackgerritMatt Riedemann proposed openstack/nova master: Document testing guide for new API contributions  https://review.openstack.org/52961813:52
* mriedem goes to fight with a 6 year old about getting out of bed13:53
*** sridharg has quit IRC13:53
*** heyongli has quit IRC13:54
*** heyongli has joined #openstack-nova13:54
bauwsermriedem: tell him some children in the world are still awake for already like 9 hours and that's his time13:55
mriedemi just run in screaming that the house is on fire and we have to get out13:56
bauwserlooks like it's an universal NP-problem then13:58
*** takedakn has quit IRC13:59
openstackgerritRyota MIBU proposed openstack/nova master: vif: look up 'ovs_interfaceid' in vif_details  https://review.openstack.org/52983114:00
bauwserfinucannot: leakypipes: remember me, what happens if we want to add a new item for an o.vo Enum field type, do we need to bump the object version using that field type ?14:02
bauwserfinucannot: leakypipes: context being https://review.openstack.org/#/c/527470/4/nova/objects/instance_pci_requests.py14:02
finucannotbauwser: You mean if we change 'numa_policy' at a future date?14:02
bauwserif we change the Enum field type, yes14:03
bauwsernot the field itself14:03
bauwserlike, removing the 'legacy' choice from the enum14:03
bauwser(because I guess that's the direction we want)14:03
*** heyongli has quit IRC14:04
*** heyongli has joined #openstack-nova14:04
*** lyan has joined #openstack-nova14:09
Roamer`hm, no response in #openstack, so let me butt in here :)  Does anybody know of a tool that reads devstacklog.txt, splits it into phases, and lets me know how long each phase took?  Trying to figure out why my latest stack.sh runs take about twice as long as before14:12
openstackgerritMatt Riedemann proposed openstack/nova master: Use volume shared_targets to lock during attach/detach  https://review.openstack.org/52969514:12
finucannotbauwser: tbh, I've no idea. We haven't done that yet (that I know of), so it depends14:12
Roamer`of course it would be trivial to write such a tool once I know what phases there are, but I haven't looked so deeply into stack.sh yet... has anybody else?14:13
mriedemRoamer`: i'd ask in #openstack-qa14:13
Roamer`mriedem, thanks, that might work14:13
*** stvnoyes has joined #openstack-nova14:13
mriedemsdague is the person to ask but he's out for the year, so maybe mtreinish14:13
leakypipesfinucannot: we've done that with the ResourceClassField enum.14:13
bauwserfinucannot: I guess the problem is more about removing the legacy option14:13
leakypipesfinucannot: and I don't believe we've incremented the version for objects that use it...14:13
bauwsersay we could just deprecate that option, that's it14:14
leakypipesfinucannot: then again, we don't use objects over RPC for placement..14:14
*** heyongli has quit IRC14:14
bauwserleakypipes: well, the ResourceClassFieldType is specific because indeed we don't pass it thru RPC14:14
*** heyongli has joined #openstack-nova14:14
bauwserwe just use o.vo to have a coercing14:15
bauwserfinucannot: leakypipes: FWIW, I just +W'd that change because I think it's not a problem14:17
*** jobewan has joined #openstack-nova14:18
cdentleakypipes: have you seen this and the associated bug: https://review.openstack.org/#/c/529397/14:21
cdentthere was a lot of associated irc discussion about other options, but that was the simplest14:21
cdentwanted to be sure you saw it before I leave to do some dreaded shopping14:21
*** cdent has quit IRC14:24
*** heyongli has quit IRC14:24
*** heyongli has joined #openstack-nova14:25
leakypipesfinucannot: it's not that I don't like your code. I'm just having a hard time with the whole cascading policy loop thing... I agree with you that pools != filtered_pools and that my original complaint about coupling is not valid. however it still feels a bit clever for my taste. I'll remove my -1 and leave it to bauzas and gibi to +W14:25
*** ygl has quit IRC14:25
*** yangyapeng has joined #openstack-nova14:25
*** yangyapeng has quit IRC14:26
*** yangyapeng has joined #openstack-nova14:26
*** smatzek has quit IRC14:29
*** smatzek has joined #openstack-nova14:30
*** smatzek has quit IRC14:30
leakypipesmriedem: morning.14:33
*** heyongli has quit IRC14:35
*** heyongli has joined #openstack-nova14:35
openstackgerritMatthew Booth proposed openstack/nova master: Add uuid column to BlockDeviceMapping  https://review.openstack.org/24260214:39
openstackgerritMatthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid  https://review.openstack.org/24260314:39
openstackgerritMatthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid  https://review.openstack.org/52559914:39
openstackgerritMatthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr  https://review.openstack.org/52416714:39
openstackgerritMatthew Booth proposed openstack/nova master: Expose BDM uuid to drivers  https://review.openstack.org/52903714:39
*** kholkina has quit IRC14:41
mdboothmriedem: Updated ^^^ I haven't completely re-run all tests locally, though. Just the obvious ones. Been bitten by that a couple of times recently, but I'm being optimistic anyway.14:42
*** heyongli has quit IRC14:45
*** heyongli has joined #openstack-nova14:45
*** fragatina has quit IRC14:45
*** fragatina has joined #openstack-nova14:46
*** heyongli has quit IRC14:55
*** heyongli has joined #openstack-nova14:55
*** edmondsw has joined #openstack-nova14:56
*** edmondsw has quit IRC14:57
*** sridharg has joined #openstack-nova14:59
*** smatzek has joined #openstack-nova15:00
cfriesenwhat do we expect to happen if you do a resize/migrate, and after completion but before confirmation the dest node dies and we do an evacuate?  Should the resize/migrate revert, should the evacuation pass without error, or something else?15:01
*** bjolo has joined #openstack-nova15:05
*** heyongli has quit IRC15:05
*** heyongli has joined #openstack-nova15:06
*** Jack_Iv has quit IRC15:08
*** burt has joined #openstack-nova15:12
*** heyongli has quit IRC15:16
*** heyongli has joined #openstack-nova15:16
*** marst has joined #openstack-nova15:17
*** armax has joined #openstack-nova15:18
*** tbachman has joined #openstack-nova15:19
*** sambetts|afk is now known as sambetts15:20
*** mriedem has quit IRC15:21
finucannotleakypipes: Let me take a second shot at it. If it's too clever for you, it's going to be too clever for others too15:23
leakypipesfinucannot: maybe. I'm pretty dumb, though.15:23
*** kumarmn has quit IRC15:23
finucannotAh, so am I. All the more reason15:23
finucannotleakypipes: I assume you're gone next week?15:23
leakypipesfinucannot: nope, I'm working all next week. I got no vacation this year when i joined Verizon...15:24
finucannotOuch :(15:24
* finucannot volunteered to work so he wouldn't have to spend a whole week at home :D15:25
finucannotfour days is _more_ than enough for all involved15:25
leakypipesheh15:25
*** heyongli has quit IRC15:26
finucannotI had a look at that bug you mentioned too. Totally out of my area of expertise, I'm afraid, so best of luck with that, heh15:26
*** heyongli has joined #openstack-nova15:26
leakypipesfinucannot: yeah, it's a weird one alright...15:27
finucannotand intermittent too. The worst kind of bug :(15:28
*** kumarmn has joined #openstack-nova15:30
*** itlinux has joined #openstack-nova15:36
*** heyongli has quit IRC15:36
*** heyongli has joined #openstack-nova15:36
*** mriedem has joined #openstack-nova15:38
mriedemcfriesen: you can't evacuate an instance in VERIFY_RESIZE state can you?15:38
mriedemleakypipes: hi15:38
mriedemleakypipes: did your xmas dinner party turn out ok?15:38
mriedemcfriesen:     @check_instance_state(vm_state=[vm_states.ACTIVE, vm_states.STOPPED,15:39
mriedem                                    vm_states.ERROR])15:39
mriedem    def evacuate(self, context, instance, host, on_shared_storage,15:39
mriedemcfriesen: you'd likely want to revert the resize to get the instance back to the source host15:39
mriedemmdbooth: +2 on https://review.openstack.org/#/c/242602/15:41
mriedemdespite that terrible blank space15:41
mdboothmriedem: Thank you, Sir!15:42
*** tbachman has quit IRC15:42
mdboothHah! I do that when I want to comment branches separately. Hadn't really thought about it too hard, tbh.15:43
mdboothI guess the comments can also live inside the block15:43
mdboothartom: So, that concurrency test15:46
mriedemefried_cya_jan: how does one recheck the powervm CI? it's not on the wiki https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI15:46
artommdbooth, right15:46
*** heyongli has quit IRC15:46
*** heyongli has joined #openstack-nova15:47
mriedem"recheck powervm" i guess15:47
mdboothIt sounded like I hadn't convinced you, yet. I could be persuaded to simplify it, but I'm still thinking about that.15:47
artommdbooth, so, I grok the Python threads stuff - they don't run concurrently, one will run when another yields to do IO or whatever15:47
artommdbooth, it's not so much convincing, as explaining :)15:48
artommdbooth, what's not clear to me, and it may be ignorance of Python's internals on my part, is how your code makes sure there are two threads15:48
mdboothartom: Well your point is around whether the complexity is worth it, right?15:48
mdboothI'm confident it's a valid test. I could be persuaded that a simpler test might be better, though.15:48
mdboothThere aren't 2 threads.15:49
mdboothThere's only 1 thread, but it acts like 2 threads.15:49
mdboothWe use mock to intercept a function call in the 'main' thread.15:49
mdboothWhen the main thread executes that function call, we interrupt it and do something else first, before continuing.15:50
*** damien_r has quit IRC15:50
mdboothDoes that make more sense?15:50
mriedemseems pretty paranoid for something that we've already established a pattern of in several other objects15:50
mriedemor are you actually seeing this race happening with something like the cellsv1 job?15:51
artommdbooth, let me look at the code again15:51
artomI still can't wrap my head around how purely sequential execution can test a race15:51
mdboothmriedem: It's more that I can see the bug and I fixed it, and it's not *that* complicated.15:51
mdboothmriedem: artom is trying to get his head round the test, and I've never yet managed to write a unit test for a race which was easy to read.15:52
artomIf it's just about calling _create_uuid twice, surely can do that without the whole flip/race thing15:52
mdboothartom: That's where I could be persuaded. Except that my test is 1 step up from that.15:53
mdboothMy test asserts that if the race happens whilst reading the bdm object, it will work fine.15:54
mdboothYour test would be much simpler, and we could possibly agree it's sufficient.15:54
artomBut... the race can only happen when writing15:54
artomI guess if you go up one stop from that, it two reads happen at the same time on the same uuid-less BDM, both will attempt to write a UUID15:54
artom*if two15:54
mdboothNo, this is weird. If we *read* a bdm object with no uuid we create one before returning it.15:55
mdboothSo it's a read operation, but we might have to migrate a legacy object during it.15:55
artomRight, but the actual race is the writing part15:55
mdboothYes15:55
artomThat's what the code, does, right? Read, if there's no UUID, create one and save it, then return15:56
mdboothMy test is at the level of the read operation15:56
mdboothYour test would just be on the write bit15:56
*** gouthamr has joined #openstack-nova15:56
*** tojuvone has quit IRC15:56
mdboothartom: Yep. Notice there's a compare-and-swap in there, which avoids a race.15:56
*** tojuvone has joined #openstack-nova15:56
*** heyongli has quit IRC15:57
mdboothI guess the most important thing is to test the compare-and-swap, which simply executing _create_uuid manually twice would do.15:57
*** heyongli has joined #openstack-nova15:57
mdboothThe test would also be easier to read.15:57
artomAh, right, compare and swap is atomic at the DB level, right?15:57
mdboothYes15:57
mdboothThere are a couple of db-related hoops in that function which ensure it's atomic.15:58
*** suresh12 has joined #openstack-nova15:58
openstackgerritMerged openstack/nova stable/ocata: Use instance.project_id when creating request specs for old instances  https://review.openstack.org/52938715:58
artomSo if there are two of more getting compare_and_swaps getting to the DB at the same time, only the first one will succeed15:58
artomSo, the DB-write race is handled for us15:58
artomI may have been thinking about this wrong15:58
mdboothCorrect.15:58
artomSo is there actually a race then? If we try a compare_and_swap and it fails, if we read after that, we're guaranteed to get the correct UUID15:59
artomA read race, I should say15:59
mdboothThere is no read race.15:59
mdboothNot in this patch, anyway.15:59
artom...16:00
artomSo what are we testing then?16:00
mdboothHowever, I think the original one just wrote the uuid to the db.16:00
mdboothThat is a race, and if you executed my test against that version, it would fail.16:00
openstackgerritStephen Finucane proposed openstack/nova master: Add PCI NUMA policies  https://review.openstack.org/52747216:00
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs  https://review.openstack.org/52747316:00
*** tbachman has joined #openstack-nova16:01
finucannotleakypipes, bauwser: VoilĂ  ^^16:01
mdboothIn fact, I think the original version didn't write it immediately at all, just generated it.16:01
leakypipesmriedem: yeah, dinner was great. dishwasher is leaking, though...16:01
mdboothSo there was a delay of unknown size between generation of the value and writing it to the db without a compare-and-swap.16:01
mriedemleakypipes: "dishwasher" isn't code for one of the pugs is it?16:01
leakypipesmriedem: so after $400 electrician bill I now have another $200 bill for the installers from Lowe's to come day after christmas to fix it.16:01
finucannotleakypipes: I assume the irony of that has already been pointed out multiple times16:01
leakypipesfinucannot: yes sir.16:01
leakypipesmriedem: no.16:02
artommdbooth, oh, so you're not testing that your code in the latest patchset handles a race properly16:02
mdboothartom: Yes.16:02
mdboothErm...16:02
artomYes you're not?16:02
mriedemleakypipes: oh lowes installers huh? i had to have lowes guys come back to fix our washing machine install which sprayed water all over the (thankfully unfinished) storage room in our basement16:02
mdboothNo, that's exactly what I'm testing.16:02
mriedemturns out zip ties are important for the drain hose16:02
artomBut you said there's no race in this patch16:02
mdboothThe test asserts that the code correctly handles the situation where 2 threads both read a NULL uuid from the db, and both then try to populate it.16:03
mdboothThe test passes.16:03
mdboothThat doesn't mean there's no reason for the test, though.16:03
mdboothAs it happens, the code will also work if the race happens during the db transaction, or on commit because both transactions occurred on different masters of a multi-master galera cluster.16:04
artomSO I guess step one would be to remove all mentions of race from that test16:05
mdboothI didn't write tests for those, though, because....16:05
mdboothI would only understand them very briefly myself.16:05
mdboothartom: No, because it's a race ;)16:05
mdboothIt simulates a race16:05
* finucannot disappears for 20 minutes to catch a bus16:05
mdboothIt simulates 2 threads with 1 thread.16:06
artomI'm going to look up the definition of race, I swear to God ;)16:06
mdboothA race is a bug caused by execution timing.16:06
mdboothIt doesn't require real concurrency.16:07
*** heyongli has quit IRC16:07
artomRight, when the outcome is determined by the order in which things are executed16:07
*** heyongli has joined #openstack-nova16:07
artomThe code is written so as to *not have that*16:07
*** fragatina has quit IRC16:08
artomBecause 1. compare_and_swap 2. if it fails, we handle it gracefully and read the correct value16:08
mdboothYes, although order may be A->B, B->A, or A(a bit)->B(all of it)->A(the rest)16:08
*** fragatina has joined #openstack-nova16:08
figleafmriedem: not zip ties. Use these: https://images-na.ssl-images-amazon.com/images/I/71%2BzOxf-hBL._SX425_.jpg16:08
artomSo given two reads A and B, we need a test that makes sure that, regardless of the sequence in which they're (partially) executed, the UUID read at the end is the same for both16:09
mdboothHowever, I could be convinced to test only the simpler consecutives calls to _create_uuid()16:09
mdboothWith a note that this simulates a race in the calling code, as this will only ever happen if there was a race.16:09
mdboothRather than creating the race itself with fancy mocks.16:10
mriedemfigleaf: i used this https://s7d1.scene7.com/is/image/BedBathandBeyond/45894242895794p?$478$ to call lowes and tell them to get their guys out to fix the shit16:10
mriedemooo btw, where is my xmas list?16:10
mriedemhttps://www.saksfifthavenue.com/main/ProductDetail.jsp?PRODUCT%3C%3Eprd_id=845524447125273&site_refer=CSE_GGLPRADS001&gclid=Cj0KCQiA9_LRBRDZARIsAAcLXjfz8bCutBnNrpZ-bKlG_1RRPKyVGX4G1WC1vjzOtoO6K81rPpJXYrgaAuXkEALw_wcB&gclsrc=aw.ds16:10
mdboothartom: Think of it like this. We've got code that does: if uuid is not populated: populate_uuid()16:11
mriedemif i were a corporation with some sweet tax cuts i could buy that phone16:11
mriedemoh it's not an actual phone16:11
mriedemit's a makeup thingy16:11
mdboothartom: We're simulating the case where the above code is interrupted mid flow, so by the time populate_uuid is called, it's actually already populated.16:11
mdboothEven though we just checked that it wasn't.16:11
artommdbooth, ok, point me to the "interrupted mid flow" bit - how does it happen in the test?16:12
*** itlinux has quit IRC16:12
*** tbachman has quit IRC16:13
mdboothartom: The first time we call _create_uuid() (populate_uuid in my example above), we interrupt the flow by calling race(). race() reads the bdm itself, which populates the uuid, then continues execution of the main thread by calling orig_create_uuid().16:14
mdboothSo we have a main thread of execution, which is interrupted by another thread of execution.16:15
*** armax has quit IRC16:16
mdboothartom: You have absolutely convinced me to simplify that test ;)16:17
artommdbooth, I really am just trying to understand, honest :)16:17
mdboothThe most important aspect of it was to test that the compare-and-swap works. I can do that without the mocking.16:17
*** heyongli has quit IRC16:17
*** heyongli has joined #openstack-nova16:17
artommdbooth, think of it as teaching me :)16:17
*** Jack_Iv has joined #openstack-nova16:18
*** fragatina has quit IRC16:18
figleafmriedem: you can't remove a zip tie without cutting it (and usually the hose)16:19
artommdbooth, a mock side_effect...16:20
artomMaybe that's the part I'm not getting16:20
artomDoes it still call the original function?16:20
artomAnd call the side_effect before/after/at the same time?16:20
mdboothIt calls the side effect both times16:20
mdboothThat's why flip is required16:20
artommdbooth, no, in general I mean16:20
mdboothflip makes it call the race first time only16:21
mdboothThat prevents infinite recursion by the race functino16:21
artomLike, if I mock foo() and mock.side_effect = bar, and I call foo(), does the real foo() still get called, or only bar()?16:21
mdboothNo, only the side effect is called16:21
mdboothIt's a bad name16:21
mriedemfigleaf: found a problem in our devstack setup for the alternate hosts stuff :)16:21
artommdbooth, So it's effectively replacing the mocked object16:21
figleafoh joy!16:21
mdboothIt's replacing the mocked function in this case16:22
mdboothThat's why we explicitly store a reference to the original16:22
artommdbooth, gotcha. Back to looking at the code16:22
mdboothSo we can still call it.16:22
mdboothartom: I'm really going to simplify it.16:22
mdboothI no longer think it's worth it myself ;)16:22
artommdbooth, sure, but I still want to understand this16:22
mriedemfigleaf: pretty simple16:22
mriedemhttp://logs.openstack.org/89/527289/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode/570a3c9/logs/screen-n-cond-cell1.txt.gz#_Dec_21_23_49_28_81393416:22
*** Jack_Iv has quit IRC16:23
mriedemfigleaf: the ironic job failed the first node and was rescheduling, but the cell conductor couldn't talk to placement b/c placement isn't configured in nova_cell1.conf in devstack16:23
artommdbooth, I shall wear your down with the stubbornness of my ignorance ;)16:23
mriedemfigleaf: working on a devstack patch16:23
figleafmriedem: yeah, that would hose things16:24
*** derekh has quit IRC16:25
*** heyongli has quit IRC16:27
artommdbooth, maybe it'd be easier if you point out the error in http://paste.openstack.org/show/629605/ ?16:27
*** heyongli has joined #openstack-nova16:28
mdboothartom: The error is that the invocations of get_by_instance_uuid overlap16:29
mdboothThe one top left goes all the way to top right16:29
mdboothThere's another invocation of get_by_instance_uuid in the middle of it16:30
mdboothIOW, they are executing 'concurrently'16:30
artomHeh, maybe discussing ASCII art pseudo sequence diagrams on IRC wasn't the best idea16:31
artomA debugger then...16:31
artomConfessions: I have never used a Python debugger16:32
mdboothSo we've got a big call to get_by_instance_uuid()16:32
mdboothWe stick a mock somewhere in the middle of it which interrupts the flow to call get_by_instance_uuid() again, before continuing with the original call, which still hasn't finished.16:32
artomSo far so good.16:34
*** heyongli has quit IRC16:38
*** heyongli has joined #openstack-nova16:38
*** AlexeyAbashkin has quit IRC16:39
openstackgerritMerged openstack/nova master: objects: Add PCI NUMA policy fields  https://review.openstack.org/52747016:40
mriedemfigleaf: i think this should do the trick https://review.openstack.org/52985716:42
*** sambetts is now known as sambetts|afk16:42
*** Apoorva has joined #openstack-nova16:44
artommdbooth, is that all we're testing? That if one get_by_uuid starts up, but while it's running another get_by_uuid is called, they're get the same value in the end?16:47
mdboothartom: Yep16:47
artommdbooth, christ16:47
artommdbooth, ok no, please get rid of it :)16:47
openstackgerritMerged openstack/nova master: Make conductor pass and use host_lists  https://review.openstack.org/51135816:47
mriedemwoot ^16:47
mriedem#success nova merged alternate hosts support for server build16:48
openstackstatusmriedem: Added success to Success page16:48
artommdbooth, I'd see the point if we let them both run to completion in different processes16:48
*** heyongli has quit IRC16:48
artommdbooth, but in the end, all your test does it call _create_uuid twice in successions16:48
mdboothartom: They do both run to completion!16:48
mdboothIn effectively different processes.16:48
*** heyongli has joined #openstack-nova16:48
artom...16:48
*** bpoulos has joined #openstack-nova16:48
artommdbooth, but when the second one is called via the mock, the first's flow is interreupted16:49
artomUntil the second one returns16:49
artomNo?16:49
mdboothBy mocking _create_uuid specifically, it triggers an execution order which causes a race16:49
figleafmriedem: It's a xmas miracle!16:49
openstackgerritMerged openstack/nova master: doc: update supported drivers for cpu topology  https://review.openstack.org/52929416:49
*** chyka has joined #openstack-nova16:49
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Add support for the 2.57 microversion  https://review.openstack.org/52812816:49
mdboothartom: Yes. That's an execution order which would cause incorrect behaviour if we didn't handle it.16:50
openstackgerritMatthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid  https://review.openstack.org/24260316:50
openstackgerritMatthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid  https://review.openstack.org/52559916:50
openstackgerritMatthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr  https://review.openstack.org/52416716:50
openstackgerritMatthew Booth proposed openstack/nova master: Expose BDM uuid to drivers  https://review.openstack.org/52903716:50
mdboothartom: However, it's gone ^^^ ;)16:50
artommdbooth, dammit16:50
artommdbooth, I still want to understand you16:51
mdboothartom: It's a good test, but a totally agree that it's more complicated that it needs to be16:51
mdboothAnyway, I'm going to run for the hills!16:52
mdboothMerry Christmas, all! See you in the New Year.16:52
* mdbooth -> hills16:52
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance  https://review.openstack.org/52883216:55
artommdbooth, enjoy your ugly sweaters ;)16:57
*** heyongli has quit IRC16:58
*** heyongli has joined #openstack-nova16:58
*** itlinux has joined #openstack-nova17:00
*** dtantsur is now known as dtantsur|afk17:02
*** itlinux has quit IRC17:05
*** itlinux has joined #openstack-nova17:05
*** sahid has quit IRC17:05
*** sahid has joined #openstack-nova17:06
*** heyongli has quit IRC17:08
*** heyongli has joined #openstack-nova17:09
*** imacdonn has quit IRC17:12
*** imacdonn has joined #openstack-nova17:12
mriedemfigleaf: heh my bash fu always fails the first few times17:12
*** yamamoto has quit IRC17:13
*** trinaths has joined #openstack-nova17:14
*** trinaths has left #openstack-nova17:14
figleafmriedem: don't feel bad - I felt uneasy +1'ing that because my bash-fu is so weak17:14
figleafit looked logical, thougn17:14
figleafthough17:14
mriedemit does do the correct thing for nova_cell1.conf17:15
mriedemso that's good17:15
*** heyongli has quit IRC17:19
mriedemsomeone was mentioning issues with the NumInstances filter yesterday, and i got thinking about that one, if you ran multiple filter scheduler processes, that filter would be totally racey17:19
*** heyongli has joined #openstack-nova17:19
mriedemdepending on which process gets a request, or if both are processing requests at the same time for the same host17:19
*** yamamoto has joined #openstack-nova17:20
mriedemif the limit is 10 and you've got 9 on a host already, and both workers get a request at the same time, they'd both think there is room for one more and could choose it17:20
mriedemplacement doesn't fix that17:20
mriedemonly reschedules would fix that17:20
mriedemseems like a totally useless filter anyway assuming you have any non-trivial number of flavors17:21
kashyapmriedem: Hey, when you have a moment, you know why this is failing?  (I know it's coming from my change) -- http://logs.openstack.org/11/529611/3/check/openstack-tox-py27/f611b46/job-output.txt.gz#_2017-12-21_17_29_32_01187617:21
kashyap( https://review.openstack.org/#/c/529611/ )17:21
kashyapIt's just doing something super simple; adding a config class & test that XML element17:22
kashyapAh, I see it17:22
kashyapMy test is trying to do it as:17:22
kashyap2017-12-21 17:29:32.012197 | ubuntu-xenial |     <smm>17:22
kashyap2017-12-21 17:29:32.012215 | ubuntu-xenial |       <smm state="on"/>17:22
kashyap2017-12-21 17:29:32.012231 | ubuntu-xenial |     </smm>17:22
kashyapHowever, it should be:17:22
kashyap        ...17:23
kashyap        <features>17:23
kashyap          <acpi/>17:23
kashyap          <apic/>17:23
kashyap          <smm state='on'/>17:23
kashyap        </features>17:23
kashyap        ...17:23
kashyapmriedem: Disregard me.  I'll rework the tests17:23
mriedemlooks like it doesn't like <smm state="on"/>17:24
*** lucasagomes is now known as lucas-afk17:24
mriedemhttp://logs.openstack.org/11/529611/3/check/openstack-tox-py27/f611b46/job-output.txt.gz#_2017-12-21_17_29_32_01216517:24
kashyapmriedem: But if you see, the test is trying to do:17:24
kashyap<smm>17:24
kashyap  <smm state="on">17:24
kashyap</smm>17:24
kashyapBut there's no top-level 'smm' attribute17:24
kashyapIt is _one_ of the sub elements of the 'features' attribute17:24
*** yamamoto has quit IRC17:25
* kashyap clicks the links from Matt17:25
*** Apoorva has quit IRC17:26
mriedemcommented in the patch17:28
*** heyongli has quit IRC17:29
kashyapThat's fast.  /me clicks17:29
*** heyongli has joined #openstack-nova17:29
kashyapmriedem: Thanks.  You could actually -1 it, don't be so polite.17:30
kashyap:P17:30
mriedemthere you go17:31
kashyapHeh, you (-)one-upped it :-)17:34
*** heyongli has quit IRC17:39
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Sanity check for NumInstancesFilter  https://review.openstack.org/52986617:39
*** heyongli has joined #openstack-nova17:39
bauwserfolks, bailing out for vacations17:40
bauwsersee you in 2018 \o17:40
* bauwser back on Jan 8th17:40
*** bauwser is now known as bauzas17:40
*** bauzas is now known as bauzas|pto17:40
*** mriedem is now known as bauzas17:40
bauzashaha17:40
bauzasi'm back!17:40
kashyapmriedem: Hmm, I actually modelled it just like other features, the class -- LibvirtConfigGuestFeatureAPIC() or LibvirtConfigGuestFeaturePAE()17:41
bauzasdonne moi du fromage savoureux17:41
kashyapMore appropriate one is - LibvirtConfigGuestFeatureKvmHidden().  Because it also as sub-element17:41
* kashyap looks closer17:41
*** bauzas is now known as mriedem17:42
kashyapNo, I'm wrong, the KvmHidden() thing has its own element.17:44
*** sridharg has quit IRC17:44
*** sahid has quit IRC17:45
mriedemkashyap: more inline17:47
mriedemfor your subelement woes17:47
* kashyap goes to read17:47
mriedemyour root element is the smm element,17:47
mriedemyou are adding a sub-element to that, which is wrong,17:48
mriedemyou need to set an attribute on the smm element17:48
mriedemwhich is your root17:48
mriedemxml is f'ing awesome17:48
kashyapYeah, I should model it something like LibvirtConfigGuestSMBIOS()17:48
kashyapI know, XML...17:48
kashyapFrom what I recall about why libvirt chose XML was...17:49
*** heyongli has quit IRC17:49
kashyapThe initial author of libvirt Daniel Veillard was on W3C standards, and 'libxml' maintainer...17:50
*** heyongli has joined #openstack-nova17:50
kashyapNot sure JSON was there at that time yet17:50
kashyapSo now they're (we) stuck with it...17:50
mriedemi worked on a project for 6 years dealing with https://www.oasis-open.org/committees/sdd/17:51
mriedemso i'm familiar17:51
* kashyap clicks17:51
mriedemyou'd think i'd actually know something about tosca and heat and nfv stuff, but...17:52
kashyapWauw.  Yeah, I knnow OSAIS standards; the 'virtio' documentation also is hosted there17:52
kashyapBut at the recent KVM Forum in Prague, I saw users of virtio, who want to implement devices complaining of the super dense documentation / standards.17:52
mriedemmaybe they would prefer CIM17:52
*** artom has quit IRC17:52
kashyapHeh17:52
* mriedem lunches17:53
kashyapmriedem: When you're back, I have a small future spec topic, for design discussion17:53
kashyapIf you're busy after lunch, and can't get to it; it's fine.  This can wait17:54
* kashyap also needs to cook dinner17:54
*** bpoulos has quit IRC17:58
*** AlexeyAbashkin has joined #openstack-nova17:59
*** heyongli has quit IRC18:00
*** heyongli has joined #openstack-nova18:00
*** burt has quit IRC18:01
*** artom has joined #openstack-nova18:02
*** AlexeyAbashkin has quit IRC18:03
*** heyongli has quit IRC18:10
*** heyongli has joined #openstack-nova18:10
*** suresh12 has quit IRC18:15
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Introduce SMM (System Management Mode) config class  https://review.openstack.org/52961118:16
*** claudiub has quit IRC18:19
*** heyongli has quit IRC18:20
*** heyongli has joined #openstack-nova18:20
*** tbachman has joined #openstack-nova18:23
*** jpena is now known as jpena|off18:28
*** heyongli has quit IRC18:30
*** heyongli has joined #openstack-nova18:31
*** jgriffith is now known as jgriffith-merryC18:34
*** jgriffith-merryC is now known as jgriffith18:34
*** gyee has joined #openstack-nova18:37
f10d4re18:39
*** chyka has quit IRC18:40
*** chyka has joined #openstack-nova18:41
*** heyongli has quit IRC18:41
openstackgerritMerged openstack/nova master: Add retry_on_deadlock decorator to action_event_start  https://review.openstack.org/52967218:41
*** armax has joined #openstack-nova18:41
*** heyongli has joined #openstack-nova18:41
*** dave-mcc_ has quit IRC18:41
*** chyka_ has joined #openstack-nova18:44
*** suresh12 has joined #openstack-nova18:46
*** chyka has quit IRC18:46
*** suresh12 has quit IRC18:47
*** suresh12 has joined #openstack-nova18:48
*** felipemonteiro__ has joined #openstack-nova18:48
*** heyongli has quit IRC18:51
*** heyongli has joined #openstack-nova18:51
*** harlowja has joined #openstack-nova19:01
*** heyongli has quit IRC19:01
*** heyongli has joined #openstack-nova19:01
*** harlowja has quit IRC19:04
openstackgerritMerged openstack/nova master: Remove extensions module  https://review.openstack.org/52920619:09
openstackgerritMerged openstack/nova master: Remove the LoadedExtensionInfo object  https://review.openstack.org/52920719:09
*** heyongli has quit IRC19:11
*** heyongli has joined #openstack-nova19:12
*** suresh12 has quit IRC19:15
*** suresh12 has joined #openstack-nova19:15
*** gouthamr has quit IRC19:20
*** heyongli has quit IRC19:22
*** heyongli has joined #openstack-nova19:22
*** yamamoto has joined #openstack-nova19:24
*** felipemonteiro__ has quit IRC19:27
*** chyka_ has quit IRC19:28
*** chyka has joined #openstack-nova19:28
*** heyongli has quit IRC19:32
*** heyongli has joined #openstack-nova19:32
*** armax has quit IRC19:32
*** READ10 has joined #openstack-nova19:32
*** AlexeyAbashkin has joined #openstack-nova19:33
*** mgariepy has quit IRC19:33
*** yamamoto has quit IRC19:35
*** AlexeyAbashkin has quit IRC19:37
*** mgariepy has joined #openstack-nova19:38
*** dave-mccowan has joined #openstack-nova19:40
*** gouthamr has joined #openstack-nova19:40
*** heyongli has quit IRC19:42
*** heyongli has joined #openstack-nova19:42
openstackgerritMerged openstack/nova stable/newton: Use instance.project_id when creating request specs for old instances  https://review.openstack.org/52938919:48
*** heyongli has quit IRC19:52
*** heyongli has joined #openstack-nova19:53
*** salv-orlando has quit IRC19:54
*** salv-orlando has joined #openstack-nova19:55
*** vivsoni has quit IRC19:56
*** salv-orlando has quit IRC19:59
*** gouthamr has quit IRC20:00
*** suresh12 has quit IRC20:02
*** heyongli has quit IRC20:03
*** suresh12 has joined #openstack-nova20:03
*** heyongli has joined #openstack-nova20:03
*** gaurangt has quit IRC20:13
*** heyongli has quit IRC20:13
*** heyongli has joined #openstack-nova20:13
*** pcaruana has quit IRC20:13
*** fragatina has joined #openstack-nova20:13
*** mvk has quit IRC20:17
*** gaurangt has joined #openstack-nova20:19
*** fanzhang has quit IRC20:21
*** fanzhang has joined #openstack-nova20:21
*** heyongli has quit IRC20:23
*** heyongli has joined #openstack-nova20:23
*** edmondsw has joined #openstack-nova20:25
*** fragatina has quit IRC20:25
*** fragatina has joined #openstack-nova20:29
*** heyongli has quit IRC20:33
*** heyongli has joined #openstack-nova20:34
*** suresh12 has quit IRC20:37
*** suresh12 has joined #openstack-nova20:38
*** heyongli has quit IRC20:44
*** heyongli has joined #openstack-nova20:44
*** heyongli has quit IRC20:54
*** heyongli has joined #openstack-nova20:54
*** salv-orlando has joined #openstack-nova20:55
*** suresh12 has quit IRC20:56
*** edmondsw has quit IRC20:58
*** fragatina has quit IRC20:59
*** salv-orlando has quit IRC21:00
*** heyongli has quit IRC21:04
*** heyongli has joined #openstack-nova21:04
*** suresh12 has joined #openstack-nova21:10
*** tbachman has quit IRC21:12
*** tbachman has joined #openstack-nova21:14
*** heyongli has quit IRC21:14
*** heyongli has joined #openstack-nova21:15
*** markvoelker has quit IRC21:20
*** jobewan has quit IRC21:22
*** READ10 has quit IRC21:22
*** smatzek has quit IRC21:23
*** smatzek has joined #openstack-nova21:24
*** heyongli has quit IRC21:25
*** heyongli has joined #openstack-nova21:25
*** gyee has quit IRC21:25
*** suresh12 has quit IRC21:26
*** suresh12 has joined #openstack-nova21:28
mriedemmelwitt: in https://review.openstack.org/#/c/334614/ the commit message says, "We cannot store the entire access_url in the database because it contains the token, but we can keep the base part of the url and generate the full access_url on demand."21:28
mriedembut the spec talks quite a bit about storing a token in the db21:28
mriedem"Because the new tokens will go in the database we need to consider cells v2."21:28
*** smatzek has quit IRC21:29
mriedemmaybe that's in a later change, the one that adds the ConsoleConnection object and db model?21:31
*** heyongli has quit IRC21:35
*** heyongli has joined #openstack-nova21:35
mriedemmaybe this just means we don't store the token in the url in the db because the token would make the url too long?21:37
mriedemor it's not hashed?21:37
*** heyongli has quit IRC21:45
*** heyongli has joined #openstack-nova21:45
*** salv-orlando has joined #openstack-nova21:50
*** heyongli has quit IRC21:55
*** heyongli has joined #openstack-nova21:56
*** lyan has quit IRC22:01
*** heyongli has quit IRC22:06
*** heyongli has joined #openstack-nova22:06
*** edmondsw has joined #openstack-nova22:12
efried_cya_janmriedem It's 'powervm: recheck'.  I'll send a note to esberglu to add it to the wiki22:12
mriedemefried_cya_jan: already did22:13
mriedemnow get back to pantsless friday22:13
efried_cya_janmriedem As in, you sent the email?22:13
mriedemi updated the wiki22:13
efried_cya_janoh, okay.  Thanks :)22:13
efried_cya_janmriedem If you run 'recheck powervm' it'll recheck *everything*.  It needs to be 'powervm:recheck' (with or without a space) to recheck just powervm.22:14
*** heyongli has quit IRC22:16
efried_cya_janmriedem I updated it.22:16
*** heyongli has joined #openstack-nova22:16
*** edmondsw has quit IRC22:17
*** efried_cya_jan has quit IRC22:19
*** heyongli has quit IRC22:26
*** heyongli has joined #openstack-nova22:26
*** tbachman has quit IRC22:30
mriedemmelwitt: this will need a follow up https://review.openstack.org/#/c/320063/ but won't block on the stuff i mentioned in ther22:30
mriedem*there22:30
*** suresh12 has quit IRC22:32
*** itlinux has quit IRC22:35
*** dave-mccowan has quit IRC22:35
*** heyongli has quit IRC22:36
*** heyongli has joined #openstack-nova22:37
*** salv-orlando has quit IRC22:40
*** stvnoyes has quit IRC22:40
mriedemhttps://review.openstack.org/#/c/325381/ -1 on that one, and that's where i stop for the year22:44
mriedemtoodle-oo22:44
*** heyongli has quit IRC22:47
*** heyongli has joined #openstack-nova22:47
*** figleaf is now known as edleafe22:48
*** heyongli has quit IRC22:57
*** heyongli has joined #openstack-nova22:57
*** heyongli has quit IRC23:07
*** heyongli has joined #openstack-nova23:07
*** artom has quit IRC23:15
*** jeblair is now known as corvus23:15
*** heyongli has quit IRC23:17
*** heyongli has joined #openstack-nova23:18
*** claudiub has joined #openstack-nova23:21
*** markvoelker has joined #openstack-nova23:21
*** heyongli has quit IRC23:28
*** heyongli has joined #openstack-nova23:28
*** david_9 has quit IRC23:35
*** carthaca_ has quit IRC23:35
*** david_ has joined #openstack-nova23:35
*** carthaca_ has joined #openstack-nova23:35
*** heyongli has quit IRC23:38
*** heyongli has joined #openstack-nova23:38
*** salv-orlando has joined #openstack-nova23:41
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060823:42
*** salv-orlando has quit IRC23:46
*** suresh12 has joined #openstack-nova23:46
*** tbachman has joined #openstack-nova23:47
*** marst has quit IRC23:48
*** heyongli has quit IRC23:48
*** heyongli has joined #openstack-nova23:48
*** suresh12 has quit IRC23:50
*** tbachman has quit IRC23:51
*** tbachman has joined #openstack-nova23:52
*** markvoelker has quit IRC23:55
*** heyongli has quit IRC23:58
*** heyongli has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!