| ildikov | mriedem_away: ok, I'll look into those, thanks! | 00:00 |
|---|---|---|
| *** cdent has quit IRC | 00:02 | |
| *** Guest35678 has quit IRC | 00:07 | |
| *** _pewp_ has quit IRC | 00:20 | |
| *** yamahata has quit IRC | 00:20 | |
| *** sdague has quit IRC | 00:20 | |
| *** _pewp_ has joined #openstack-nova | 00:21 | |
| *** jmlowe has quit IRC | 00:22 | |
| *** takashin has joined #openstack-nova | 00:24 | |
| *** threestrands has quit IRC | 00:25 | |
| *** sdague has joined #openstack-nova | 00:26 | |
| *** chyka_ has quit IRC | 00:31 | |
| *** gmann_afk is now known as gmann | 00:36 | |
| *** mlavalle has quit IRC | 00:37 | |
| *** TuanLA has joined #openstack-nova | 00:44 | |
| *** hongbin has quit IRC | 00:49 | |
| *** hieulq has joined #openstack-nova | 00:50 | |
| *** yassine has joined #openstack-nova | 01:00 | |
| *** yassine is now known as Guest18930 | 01:00 | |
| *** itlinux has quit IRC | 01:00 | |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395 | 01:02 |
| *** esberglu has joined #openstack-nova | 01:02 | |
| *** tbachman has joined #openstack-nova | 01:06 | |
| *** esberglu has quit IRC | 01:07 | |
| *** jichen has joined #openstack-nova | 01:07 | |
| *** tristanC has quit IRC | 01:08 | |
| *** phuongnh has joined #openstack-nova | 01:09 | |
| *** tristanC has joined #openstack-nova | 01:09 | |
| *** frickler has quit IRC | 01:09 | |
| *** frickler has joined #openstack-nova | 01:10 | |
| *** gyee has quit IRC | 01:10 | |
| *** yikun has joined #openstack-nova | 01:11 | |
| *** yangyapeng has joined #openstack-nova | 01:14 | |
| *** yamahata has joined #openstack-nova | 01:25 | |
| *** auggy has joined #openstack-nova | 01:25 | |
| *** psachin has joined #openstack-nova | 01:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:31 | |
| *** liusheng has quit IRC | 01:32 | |
| *** Eran_Kuris_ has quit IRC | 01:32 | |
| *** _pewp_ has quit IRC | 01:33 | |
| *** Dinesh_Bhor has quit IRC | 01:35 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:35 | |
| *** _pewp_ has joined #openstack-nova | 01:36 | |
| *** markvoelker has quit IRC | 01:38 | |
| *** liusheng has joined #openstack-nova | 01:46 | |
| *** zhurong has joined #openstack-nova | 01:50 | |
| *** mriedem_away has quit IRC | 01:50 | |
| *** namnh has joined #openstack-nova | 01:53 | |
| *** hshiina has joined #openstack-nova | 01:56 | |
| *** chyka has joined #openstack-nova | 02:00 | |
| *** chyka has quit IRC | 02:04 | |
| *** Tom-Tom has joined #openstack-nova | 02:05 | |
| *** Tom-Tom has quit IRC | 02:06 | |
| *** Tom-Tom has joined #openstack-nova | 02:06 | |
| *** mriedem has joined #openstack-nova | 02:10 | |
| mriedem | edleafe: i led you astray on the compute rpcapi conversion stuff from https://review.openstack.org/#/c/516707/ | 02:10 |
| mriedem | you need that isinstance check in the rpcapi client to convert the SchedulerLimits object to a dict before sending to compute, that's why the functional tests are failing, | 02:11 |
| mriedem | we can't send the object form until the computes are upgraded to handle that, which would be an rpc api version change | 02:11 |
| *** oanson has quit IRC | 02:12 | |
| *** hongbin has joined #openstack-nova | 02:12 | |
| *** oanson has joined #openstack-nova | 02:12 | |
| *** mriedem has quit IRC | 02:23 | |
| *** fragatin_ has quit IRC | 02:27 | |
| *** hieulq has quit IRC | 02:32 | |
| *** hongbin_ has joined #openstack-nova | 02:33 | |
| *** Apoorva_ has joined #openstack-nova | 02:33 | |
| *** hieulq has joined #openstack-nova | 02:34 | |
| *** Apoorva has quit IRC | 02:36 | |
| *** hongbin has quit IRC | 02:37 | |
| *** Apoorva_ has quit IRC | 02:37 | |
| *** markvoelker has joined #openstack-nova | 02:39 | |
| *** itlinux has joined #openstack-nova | 02:45 | |
| *** dave-mccowan has joined #openstack-nova | 02:45 | |
| *** esberglu has joined #openstack-nova | 02:51 | |
| *** esberglu has quit IRC | 02:52 | |
| *** esberglu has joined #openstack-nova | 02:52 | |
| *** itlinux has quit IRC | 02:53 | |
| *** esberglu has quit IRC | 02:57 | |
| *** Tom-Tom has quit IRC | 02:59 | |
| *** Tom-Tom has joined #openstack-nova | 02:59 | |
| *** Tom-Tom has quit IRC | 03:00 | |
| *** Tom-Tom has joined #openstack-nova | 03:00 | |
| *** moshele has joined #openstack-nova | 03:01 | |
| *** zhurong has quit IRC | 03:02 | |
| *** gongysh has joined #openstack-nova | 03:04 | |
| *** zhurong has joined #openstack-nova | 03:10 | |
| *** takashin has quit IRC | 03:12 | |
| *** takashin has joined #openstack-nova | 03:12 | |
| *** sree_ has joined #openstack-nova | 03:16 | |
| *** takashin has quit IRC | 03:16 | |
| *** sree_ is now known as Guest50935 | 03:16 | |
| *** takashin has joined #openstack-nova | 03:16 | |
| *** takashin has quit IRC | 03:18 | |
| *** takashin has joined #openstack-nova | 03:19 | |
| *** sree has joined #openstack-nova | 03:20 | |
| *** takashin has quit IRC | 03:20 | |
| *** takashin has joined #openstack-nova | 03:20 | |
| *** Guest50935 has quit IRC | 03:22 | |
| *** takashin has quit IRC | 03:22 | |
| *** takashin has joined #openstack-nova | 03:23 | |
| *** Tom-Tom has quit IRC | 03:28 | |
| *** Tom-Tom has joined #openstack-nova | 03:29 | |
| *** abhishekk has joined #openstack-nova | 03:29 | |
| *** Tom-Tom has quit IRC | 03:29 | |
| *** Tom-Tom has joined #openstack-nova | 03:29 | |
| *** sridharg has joined #openstack-nova | 03:31 | |
| *** Tom-Tom has quit IRC | 03:34 | |
| *** takashin has quit IRC | 03:34 | |
| *** takashin has joined #openstack-nova | 03:34 | |
| *** annp has joined #openstack-nova | 03:37 | |
| *** gongysh has quit IRC | 03:45 | |
| *** hshiina has quit IRC | 03:48 | |
| *** Tom-Tom has joined #openstack-nova | 03:53 | |
| *** hshiina has joined #openstack-nova | 03:53 | |
| *** Tom-Tom has quit IRC | 03:53 | |
| *** links has joined #openstack-nova | 03:58 | |
| *** cfriesen_ has joined #openstack-nova | 03:59 | |
| *** takashin has quit IRC | 03:59 | |
| *** cfriesen has quit IRC | 03:59 | |
| *** takashin has joined #openstack-nova | 04:00 | |
| *** links has quit IRC | 04:01 | |
| *** links has joined #openstack-nova | 04:01 | |
| *** sdague has quit IRC | 04:05 | |
| *** coreywright has quit IRC | 04:05 | |
| *** takashin has quit IRC | 04:09 | |
| *** takashin has joined #openstack-nova | 04:09 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 04:11 |
| *** yamamoto has joined #openstack-nova | 04:12 | |
| *** Apoorva has joined #openstack-nova | 04:12 | |
| *** takashin has quit IRC | 04:16 | |
| *** takashin has joined #openstack-nova | 04:16 | |
| *** takashin has quit IRC | 04:18 | |
| *** takashin has joined #openstack-nova | 04:19 | |
| *** Tom-Tom has joined #openstack-nova | 04:20 | |
| *** takashin has quit IRC | 04:21 | |
| *** zhurong has quit IRC | 04:21 | |
| *** takashin has joined #openstack-nova | 04:21 | |
| *** coreywright has joined #openstack-nova | 04:23 | |
| *** takashin has quit IRC | 04:23 | |
| *** dave-mccowan has quit IRC | 04:23 | |
| *** takashin has joined #openstack-nova | 04:23 | |
| *** gongysh has joined #openstack-nova | 04:24 | |
| *** Tom-Tom has quit IRC | 04:24 | |
| *** sree_ has joined #openstack-nova | 04:26 | |
| *** sree_ is now known as Guest14002 | 04:27 | |
| *** moshele has quit IRC | 04:28 | |
| *** sree has quit IRC | 04:28 | |
| *** diga has joined #openstack-nova | 04:29 | |
| *** gbarros_ has joined #openstack-nova | 04:29 | |
| *** gbarros has quit IRC | 04:30 | |
| *** sree has joined #openstack-nova | 04:31 | |
| *** Guest14002 has quit IRC | 04:32 | |
| *** takashin has quit IRC | 04:32 | |
| *** david-lyle has joined #openstack-nova | 04:32 | |
| *** takashin has joined #openstack-nova | 04:32 | |
| *** kalyan has joined #openstack-nova | 04:33 | |
| *** janki has joined #openstack-nova | 04:33 | |
| *** takashin has quit IRC | 04:34 | |
| *** takashin has joined #openstack-nova | 04:35 | |
| *** gouthamr has quit IRC | 04:36 | |
| *** hamzy has joined #openstack-nova | 04:40 | |
| *** trungnv has quit IRC | 04:41 | |
| *** namnh has quit IRC | 04:41 | |
| *** TuanLA has quit IRC | 04:41 | |
| *** hoangcx has quit IRC | 04:41 | |
| *** annp has quit IRC | 04:41 | |
| *** takashin has quit IRC | 04:41 | |
| *** phuongnh has quit IRC | 04:41 | |
| *** trungnv has joined #openstack-nova | 04:42 | |
| *** annp has joined #openstack-nova | 04:42 | |
| *** takashin has joined #openstack-nova | 04:42 | |
| *** hoangcx has joined #openstack-nova | 04:42 | |
| *** TuanLA has joined #openstack-nova | 04:42 | |
| *** phuongnh has joined #openstack-nova | 04:42 | |
| *** namnh has joined #openstack-nova | 04:42 | |
| *** david-lyle has quit IRC | 04:42 | |
| *** sree has quit IRC | 04:45 | |
| *** udesale has joined #openstack-nova | 04:46 | |
| *** sapd_ has quit IRC | 04:48 | |
| *** sree has joined #openstack-nova | 04:49 | |
| *** sree_ has joined #openstack-nova | 04:50 | |
| *** sree_ is now known as Guest76573 | 04:50 | |
| *** sapd has joined #openstack-nova | 04:50 | |
| *** sree has quit IRC | 04:53 | |
| *** janki has quit IRC | 04:54 | |
| *** Apoorva_ has joined #openstack-nova | 04:54 | |
| *** gbarros_ has quit IRC | 04:55 | |
| *** Apoorva has quit IRC | 04:57 | |
| *** ratailor has joined #openstack-nova | 04:58 | |
| *** Dinesh_Bhor has quit IRC | 05:01 | |
| *** janki has joined #openstack-nova | 05:01 | |
| *** ratailor has quit IRC | 05:05 | |
| *** zhurong has joined #openstack-nova | 05:08 | |
| *** ratailor has joined #openstack-nova | 05:08 | |
| *** threestrands has joined #openstack-nova | 05:09 | |
| *** threestrands has quit IRC | 05:09 | |
| *** diga has quit IRC | 05:10 | |
| *** Alex_Staf has joined #openstack-nova | 05:17 | |
| *** chyka has joined #openstack-nova | 05:19 | |
| *** chyka has quit IRC | 05:24 | |
| *** liverpooler has quit IRC | 05:27 | |
| *** gongysh has quit IRC | 05:30 | |
| *** esberglu has joined #openstack-nova | 05:33 | |
| *** hongbin_ has quit IRC | 05:34 | |
| openstackgerrit | jichenjc proposed openstack/nova master: remove glance usage inside compute https://review.openstack.org/511392 | 05:35 |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove direct usage of glance.generate_image_url https://review.openstack.org/511397 | 05:35 |
| *** esberglu has quit IRC | 05:38 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove 'nova-manage host' and 'nova-manage agent' https://review.openstack.org/521837 | 05:41 |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove 'nova-manage shell' command https://review.openstack.org/521835 | 05:41 |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove 'nova-manage account' and 'nova-manage project' https://review.openstack.org/521833 | 05:41 |
| openstackgerrit | jichenjc proposed openstack/nova master: Remove 'nova-manage logs' command https://review.openstack.org/522133 | 05:41 |
| *** mdnadeem has joined #openstack-nova | 05:43 | |
| *** janki has quit IRC | 05:44 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Don't use nicira-iface-id for XenServer VIF https://review.openstack.org/451641 | 05:46 |
| *** karthiks has quit IRC | 05:48 | |
| *** yamamoto_ has joined #openstack-nova | 05:50 | |
| *** fragatina has joined #openstack-nova | 05:53 | |
| openstackgerrit | wanghongxu proposed openstack/nova master: Update cinder info when attach volume that attached https://review.openstack.org/525540 | 05:53 |
| *** yamamoto has quit IRC | 05:53 | |
| *** sree has joined #openstack-nova | 05:54 | |
| *** janki has joined #openstack-nova | 05:56 | |
| *** Guest76573 has quit IRC | 05:57 | |
| *** rocky-shiyan has joined #openstack-nova | 05:59 | |
| *** Apoorva_ has quit IRC | 05:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:00 | |
| *** yamamoto has joined #openstack-nova | 06:04 | |
| frickler | could someone take a look at https://bugs.launchpad.net/bugs/1733933 and possibly give it some increased importance? seems it is masking any error happening on the compute side towards the user | 06:05 |
| openstack | Launchpad bug 1733933 in OpenStack Compute (nova) "nova-conductor is masking error when rescheduling" [Undecided,Confirmed] | 06:05 |
| *** Tom-Tom has joined #openstack-nova | 06:05 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:07 | |
| *** yamamoto_ has quit IRC | 06:07 | |
| *** udesale__ has joined #openstack-nova | 06:10 | |
| *** AlexeyAbashkin has quit IRC | 06:11 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795 | 06:12 |
| *** udesale has quit IRC | 06:12 | |
| *** karthiks has joined #openstack-nova | 06:14 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Fix case-sensitivity for metadata keys https://review.openstack.org/504885 | 06:19 |
| *** Rambo has joined #openstack-nova | 06:19 | |
| Rambo | hello!everyone,I am new to this,please correct me! | 06:21 |
| *** nmathew has joined #openstack-nova | 06:21 | |
| *** AlexeyAbashkin has quit IRC | 06:26 | |
| *** xinliang has quit IRC | 06:27 | |
| *** sree_ has joined #openstack-nova | 06:31 | |
| *** moshele has joined #openstack-nova | 06:32 | |
| *** sree_ is now known as Guest78058 | 06:32 | |
| *** bkopilov has quit IRC | 06:35 | |
| *** sree has quit IRC | 06:35 | |
| *** janki has quit IRC | 06:36 | |
| *** janki has joined #openstack-nova | 06:38 | |
| *** xinliang has joined #openstack-nova | 06:40 | |
| *** diga has joined #openstack-nova | 06:51 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Refactor placement version check https://review.openstack.org/512497 | 06:55 |
| *** udesale has joined #openstack-nova | 06:58 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334 | 07:00 |
| *** udesale__ has quit IRC | 07:00 | |
| *** Eran_Kuris has joined #openstack-nova | 07:00 | |
| *** rcernin has quit IRC | 07:02 | |
| *** lajoskatona has joined #openstack-nova | 07:04 | |
| *** andreas__ has joined #openstack-nova | 07:12 | |
| *** diga has quit IRC | 07:14 | |
| *** sshwarts has joined #openstack-nova | 07:20 | |
| *** esberglu has joined #openstack-nova | 07:23 | |
| *** sahid has joined #openstack-nova | 07:24 | |
| *** karthiks has quit IRC | 07:26 | |
| *** esberglu has quit IRC | 07:28 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for snapshot instances https://review.openstack.org/525921 | 07:28 |
| *** hshiina has quit IRC | 07:29 | |
| *** gongysh has joined #openstack-nova | 07:31 | |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395 | 07:31 |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395 | 07:34 |
| *** karthiks has joined #openstack-nova | 07:39 | |
| *** rcernin has joined #openstack-nova | 07:39 | |
| *** yamamoto_ has joined #openstack-nova | 07:42 | |
| *** yamamoto has quit IRC | 07:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix a description for 'guest_format' https://review.openstack.org/525928 | 07:47 |
| *** slaweq_ has joined #openstack-nova | 07:47 | |
| *** kalyan has quit IRC | 07:49 | |
| *** ildikov has quit IRC | 08:03 | |
| *** samueldmq has quit IRC | 08:04 | |
| *** ildikov has joined #openstack-nova | 08:04 | |
| *** samueldmq has joined #openstack-nova | 08:05 | |
| *** knikolla has quit IRC | 08:06 | |
| *** knikolla has joined #openstack-nova | 08:07 | |
| *** yamahata has quit IRC | 08:07 | |
| *** mnaser has quit IRC | 08:08 | |
| *** csatari has quit IRC | 08:09 | |
| *** gmann has quit IRC | 08:09 | |
| *** gongysh has quit IRC | 08:10 | |
| *** mnaser has joined #openstack-nova | 08:11 | |
| *** Yingxin has quit IRC | 08:12 | |
| *** csatari has joined #openstack-nova | 08:12 | |
| *** alexchadin has joined #openstack-nova | 08:14 | |
| *** Yingxin has joined #openstack-nova | 08:16 | |
| *** tesseract has joined #openstack-nova | 08:19 | |
| *** Rambo__ has joined #openstack-nova | 08:19 | |
| Rambo__ | Now the boot from volume 's instance of rebuild operation has a problem.For example,after the rebuild operation,the instance 's root disk is not replace. | 08:20 |
| Rambo__ | I found the reason is that when we use the "_build_resources" function to prepare source,it obtains the block devices according to the previous instance 's uuid and attaches them to instance.So boot from volume 's instance of rebuild operation doesn't update data. | 08:20 |
| Rambo__ | To solve it,I plan to use CLI 's "metadata" option,to increase a key name "source_type".The "source_type" includes "snapshot" and "image".We can judge from "source_type".If the "source_type" is "snapshot",we can transform the given snapshot to a volume and attach this volume to instance.If the "source_type" is "image",we don't handle it. | 08:20 |
| Rambo__ | Can you give me some advice?Help in troubleshooting this issue will be appreciated. | 08:20 |
| *** takashin has left #openstack-nova | 08:20 | |
| *** ralonsoh has joined #openstack-nova | 08:24 | |
| openstackgerrit | wanghongxu proposed openstack/nova master: Update cinder info when attach volume that attached https://review.openstack.org/525540 | 08:25 |
| *** ragiman has joined #openstack-nova | 08:30 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:32 | |
| *** zhurong has quit IRC | 08:33 | |
| *** Rambo has quit IRC | 08:34 | |
| *** diga has joined #openstack-nova | 08:34 | |
| *** diga has quit IRC | 08:38 | |
| *** AlexeyAbashkin has quit IRC | 08:38 | |
| *** imacdonn has quit IRC | 08:39 | |
| *** imacdonn has joined #openstack-nova | 08:40 | |
| *** udesale has quit IRC | 08:42 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 08:43 |
| *** damien_r has joined #openstack-nova | 08:44 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:44 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 08:49 |
| *** AlexeyAbashkin has quit IRC | 08:49 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [WIP] POC to use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 08:51 |
| *** zhurong has joined #openstack-nova | 08:53 | |
| *** slaweq has joined #openstack-nova | 08:55 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | 08:55 |
| *** qsyqian has joined #openstack-nova | 08:55 | |
| *** yamamoto_ has quit IRC | 08:56 | |
| *** slaweq has quit IRC | 09:00 | |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395 | 09:00 |
| *** hieulq_ has joined #openstack-nova | 09:01 | |
| *** yamamoto has joined #openstack-nova | 09:04 | |
| *** hieulq_ has quit IRC | 09:04 | |
| *** hieulq has quit IRC | 09:04 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [WIP] POC to use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 09:05 |
| openstackgerrit | Gyorgy Szombathelyi proposed openstack/nova stable/ocata: Use proper user and tenant in the owner section of libvirt.xml. https://review.openstack.org/525997 | 09:05 |
| *** hieulq has joined #openstack-nova | 09:06 | |
| *** hieulq_ has joined #openstack-nova | 09:07 | |
| *** hieulq has quit IRC | 09:08 | |
| *** hieulq_ has quit IRC | 09:08 | |
| *** Dinesh_Bhor has quit IRC | 09:09 | |
| *** hieulq has joined #openstack-nova | 09:10 | |
| *** esberglu has joined #openstack-nova | 09:11 | |
| *** esberglu has quit IRC | 09:12 | |
| *** esberglu has joined #openstack-nova | 09:12 | |
| *** esberglu has quit IRC | 09:12 | |
| *** esberglu has joined #openstack-nova | 09:13 | |
| *** vishwanathj has quit IRC | 09:13 | |
| *** vishwanathj has joined #openstack-nova | 09:14 | |
| *** AlexeyAbashkin has joined #openstack-nova | 09:14 | |
| *** esberglu has quit IRC | 09:17 | |
| openstackgerrit | zhurong proposed openstack/nova master: Remove the unused request_id filter from api-paste.ini https://review.openstack.org/526001 | 09:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | 09:30 |
| *** lucas-afk is now known as lucasagomes | 09:31 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | 09:32 |
| *** derekh has joined #openstack-nova | 09:39 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: test: Store the OutputStreamCapture fixture https://review.openstack.org/515146 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename 'policy_check' -> 'policy' https://review.openstack.org/515148 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-status: Migrate to cliff https://review.openstack.org/515147 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-policy: Migrate to cliff https://review.openstack.org/515149 | 09:51 |
| *** andreas_s has joined #openstack-nova | 09:53 | |
| *** jichen has quit IRC | 09:54 | |
| *** andreas__ has quit IRC | 09:56 | |
| *** linkmark has joined #openstack-nova | 09:57 | |
| *** rmart04 has joined #openstack-nova | 09:57 | |
| *** sdague has joined #openstack-nova | 09:59 | |
| *** yamamoto has quit IRC | 10:05 | |
| *** gmann has joined #openstack-nova | 10:05 | |
| *** yamamoto has joined #openstack-nova | 10:08 | |
| openstackgerrit | Merged openstack/python-novaclient master: Avoid tox_install.sh for constraints support https://review.openstack.org/524837 | 10:12 |
| *** yamamoto has quit IRC | 10:13 | |
| *** annp has quit IRC | 10:14 | |
| *** andreas_s has quit IRC | 10:14 | |
| *** andreas_s has joined #openstack-nova | 10:15 | |
| *** andreas_s has quit IRC | 10:15 | |
| *** andreas_s has joined #openstack-nova | 10:15 | |
| *** Tom-Tom has quit IRC | 10:24 | |
| *** Tom-Tom has joined #openstack-nova | 10:25 | |
| *** namnh has quit IRC | 10:25 | |
| *** TuanLA has quit IRC | 10:27 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.56 - Enable cold migration with target host https://review.openstack.org/406707 | 10:30 |
| *** sambetts|afk is now known as sambetts | 10:32 | |
| *** Tom-Tom has quit IRC | 10:33 | |
| *** zhurong has quit IRC | 10:37 | |
| *** gszasz has joined #openstack-nova | 10:38 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 10:43 |
| *** chyka has joined #openstack-nova | 10:43 | |
| *** alexchadin has quit IRC | 10:48 | |
| *** chyka has quit IRC | 10:48 | |
| *** Tom-Tom has joined #openstack-nova | 10:49 | |
| openstackgerrit | Merged openstack/nova master: Fail fast if changing image on a volume-backed server rebuild https://review.openstack.org/520660 | 10:49 |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/525386 | 10:49 |
| *** andreas_s has quit IRC | 10:52 | |
| *** mvk has quit IRC | 10:52 | |
| *** andreas_s has joined #openstack-nova | 10:53 | |
| *** Tom-Tom has quit IRC | 10:53 | |
| *** udesale has joined #openstack-nova | 10:55 | |
| *** abhishekk has quit IRC | 11:00 | |
| *** coreywright has quit IRC | 11:00 | |
| *** esberglu has joined #openstack-nova | 11:00 | |
| *** yamamoto has joined #openstack-nova | 11:01 | |
| *** andreas_s has quit IRC | 11:01 | |
| *** andreas_s has joined #openstack-nova | 11:03 | |
| *** esberglu has quit IRC | 11:04 | |
| *** andreas_s has quit IRC | 11:11 | |
| *** coreywright has joined #openstack-nova | 11:17 | |
| *** Tom-Tom has joined #openstack-nova | 11:17 | |
| *** andreas_s has joined #openstack-nova | 11:18 | |
| *** yamamoto has quit IRC | 11:19 | |
| *** cdent has joined #openstack-nova | 11:19 | |
| *** udesale has quit IRC | 11:20 | |
| *** Tom-Tom has quit IRC | 11:21 | |
| *** lpetrut has joined #openstack-nova | 11:22 | |
| *** qsyqian has quit IRC | 11:27 | |
| *** andreas_s has quit IRC | 11:32 | |
| *** andreas_s has joined #openstack-nova | 11:32 | |
| *** links has quit IRC | 11:34 | |
| *** andreas_s has quit IRC | 11:35 | |
| *** andreas_s has joined #openstack-nova | 11:36 | |
| *** yangyapeng has quit IRC | 11:36 | |
| *** yangyapeng has joined #openstack-nova | 11:36 | |
| *** rcernin has quit IRC | 11:39 | |
| *** qsyqian has joined #openstack-nova | 11:39 | |
| *** Rambo__ has quit IRC | 11:42 | |
| *** BryanS68 has joined #openstack-nova | 11:44 | |
| *** BryanS68 has quit IRC | 11:46 | |
| *** Rambo__ has joined #openstack-nova | 11:46 | |
| *** diga has joined #openstack-nova | 11:47 | |
| *** ratailor has quit IRC | 11:47 | |
| *** links has joined #openstack-nova | 11:47 | |
| *** andreas_s has quit IRC | 11:48 | |
| *** Rambo__ has quit IRC | 11:48 | |
| *** andreas_s has joined #openstack-nova | 11:48 | |
| *** alexchadin has joined #openstack-nova | 11:49 | |
| *** BryanS68 has joined #openstack-nova | 11:49 | |
| *** qsyqian has quit IRC | 11:51 | |
| *** janki has quit IRC | 11:52 | |
| *** smatzek has joined #openstack-nova | 11:53 | |
| *** dtantsur|afk is now known as dtantsur | 11:53 | |
| *** nmathew has quit IRC | 11:54 | |
| *** ankit_ has quit IRC | 11:54 | |
| *** Rambo has joined #openstack-nova | 11:55 | |
| *** Rambo has quit IRC | 11:57 | |
| *** AlexeyAbashkin has quit IRC | 11:58 | |
| *** Rambo has joined #openstack-nova | 12:02 | |
| *** qsyqian has joined #openstack-nova | 12:02 | |
| *** openstackgerrit has quit IRC | 12:03 | |
| *** phuongnh has quit IRC | 12:05 | |
| *** yamamoto has joined #openstack-nova | 12:05 | |
| *** links has quit IRC | 12:08 | |
| *** qsyqian has quit IRC | 12:09 | |
| *** dave-mccowan has joined #openstack-nova | 12:13 | |
| *** links has joined #openstack-nova | 12:13 | |
| *** alexchadin has quit IRC | 12:16 | |
| *** alexchadin has joined #openstack-nova | 12:16 | |
| *** yangyapeng has quit IRC | 12:18 | |
| *** yangyapeng has joined #openstack-nova | 12:18 | |
| *** yangyapeng has quit IRC | 12:25 | |
| *** openstackgerrit has joined #openstack-nova | 12:31 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 12:31 |
| *** pchavva has joined #openstack-nova | 12:32 | |
| *** rambo__ has joined #openstack-nova | 12:33 | |
| *** mvk has joined #openstack-nova | 12:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.57 - List/Show all server migration types https://review.openstack.org/430839 | 12:42 |
| openstackgerrit | Merged openstack/nova master: Genericify the instance_list stuff https://review.openstack.org/524253 | 12:43 |
| openstackgerrit | Merged openstack/nova master: Split instance_list into instance and multi_cell https://review.openstack.org/524302 | 12:43 |
| *** lucasagomes is now known as lucas-hungry | 12:44 | |
| *** slaweq_ has quit IRC | 12:45 | |
| *** efried_cya_wed is now known as efried | 12:46 | |
| *** janki has joined #openstack-nova | 12:46 | |
| *** AlexeyAbashkin has joined #openstack-nova | 12:46 | |
| *** yangyapeng has joined #openstack-nova | 12:50 | |
| *** tesseract has quit IRC | 12:53 | |
| *** nmathew has joined #openstack-nova | 12:55 | |
| *** tesseract has joined #openstack-nova | 12:57 | |
| *** rambo__ has quit IRC | 13:01 | |
| efried | Greetings cdent. How goes the grenade sleuthing? | 13:04 |
| cdent | some progress at: https://review.openstack.org/#/c/525605/ | 13:04 |
| cdent | gist is that grenade and devstack’s handing of placemen a bit out of wack: no stop from grenade, important config being erased by devstack | 13:05 |
| *** gmann is now known as gmann_afk | 13:05 | |
| efried | grisly. | 13:05 |
| sean-k-mooney2 | bauzas: johnthetubaguy ye are both on the nova satable matainance team correct? can ye take a look at this trival change in os-vif https://review.openstack.org/#/c/488670/ we dont have a seperate release team so we use nova's | 13:05 |
| cdent | efried: I think that because placement went wsgi before everything else, some later learnings didn’t get incorporated into its devstack handkling | 13:06 |
| cdent | and because placement is managed in grenade as part of nova, despite being its own thing in devstack, caused some packet drops | 13:06 |
| *** takedakn has joined #openstack-nova | 13:09 | |
| *** Rambo has quit IRC | 13:10 | |
| *** diga has quit IRC | 13:10 | |
| *** maciejjo1 has quit IRC | 13:13 | |
| *** Tom-Tom has joined #openstack-nova | 13:16 | |
| bauzas | sean-k-mooney2: lemme look | 13:17 |
| *** dtantsur is now known as dtantsur|lunch | 13:18 | |
| mdbooth | Folks, has anybody else encountered MySQL-python FTB on Fedora 27? | 13:19 |
| sean-k-mooney2 | bauzas: its just an update to the .gitreview but its been open for a few months now so would be good to merge | 13:19 |
| mdbooth | This django bug shows the issue I hit: https://github.com/OWASP/django-DefectDojo/issues/407 | 13:20 |
| bauzas | sean-k-mooney2: +2 | 13:20 |
| sean-k-mooney2 | bauzas: thanks | 13:20 |
| *** links has quit IRC | 13:23 | |
| *** markvoelker has quit IRC | 13:24 | |
| *** markvoelker has joined #openstack-nova | 13:25 | |
| jaypipes | efried: welcome back | 13:28 |
| jaypipes | cdent: any prog on that bug? | 13:29 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: archive_deleted_instances is not atomic for insert/delete https://review.openstack.org/526065 | 13:30 |
| cdent | jaypipes: yeah, it has fixes that need be merged, the tests underneath this are passing: https://review.openstack.org/#/c/525605/ there’s a dependent devstack change and a backport of that devstack change | 13:30 |
| cdent | sdague, dansmith ^ | 13:30 |
| cdent | jaypipes: it was a bit of an onion | 13:30 |
| jaypipes | cdent: sounds like it indeed :( | 13:31 |
| *** READ10 has joined #openstack-nova | 13:32 | |
| sdague | cdent: I approved the 2 devstack changes, I guess we are waiting on grenade results to come in? | 13:34 |
| efried | jaypipes Howdy, thanks. I'm poring over emails to see where you got to with those patches. | 13:34 |
| cdent | sdague: Yeah, I’ve been watrching zuul and the two main grenade changes have passed | 13:34 |
| efried | jaypipes I didn't intend for you to have to do that stuff - I realized it had gotten pretty ugly at this point with all the stuff that changed underneath it. | 13:34 |
| cdent | heat (non-voting) has vailed and ironic is being slow | 13:34 |
| jaypipes | efried: well, I had to give up after f**king up the series in a failed rebase. | 13:35 |
| cdent | vailed is a word I will use to mean something like “veiled in failure” | 13:35 |
| jaypipes | efried: heh | 13:36 |
| efried | cdent Or a verb related to an overpriced ski resort. | 13:36 |
| jaypipes | efried: https://review.openstack.org/#/c/385693/ is where I stopped after a revert of the rebase attempt. | 13:36 |
| cdent | that fails to satisfy | 13:36 |
| jaypipes | I'm also at my wit's end w.r.t the REST API patch for nested resource providers. | 13:37 |
| jaypipes | so much for trying to merge things quickly and tweak afterwards. | 13:37 |
| * efried notices the singular possessive - jaypipes only has one wit | 13:37 | |
| sdague | cdent: is the heat one normally passing? | 13:37 |
| jaypipes | let's bikeshed on shit some more, just for fun. | 13:37 |
| efried | jaypipes What's the rub there? Are we just bikeshedding tree vs in_tree? | 13:37 |
| jaypipes | efried: that, yes, and placement-api-ref weirdness. | 13:38 |
| jaypipes | efried: I'm tired of the placement api ref docs crap, frankly. | 13:39 |
| cdent | sdague: it’s hard to tell, there haven’t been many changes to grenade since zuul | 13:39 |
| jaypipes | efried: in particular, these comments: https://review.openstack.org/#/c/384807/85/placement-api-ref/source/resource_provider.inc | 13:39 |
| *** takedakn has quit IRC | 13:39 | |
| jaypipes | efried: the parameters are not required. they are optional. | 13:39 |
| cdent | sdague: but this recent change passes: https://review.openstack.org/#/c/525720/ | 13:39 |
| jaypipes | efried: but takashi wants to indicate that the *response* attributes will always be there, so insists I put required: true in the parameters file. | 13:39 |
| efried | So I agree that in_tree would be clearer; else we're sorta giving the impression that a tree is an entity in its own right with a UUID. But super-meh. This is an API, and people are going to have to read the docs to figure out what it means regardless of whether it's called `tree` or `in_tree`. | 13:40 |
| *** dtantsur|lunch is now known as dtantsur | 13:40 | |
| efried | WRT the docs, my *strong* preference at this point would be to merge what we have so we can get *code* going, and then follow up with docs tweaks. | 13:40 |
| jaypipes | efried: that was my preference as well, but I've now attempted to comply with the review requests on the docs stuff and broken the api-ref build. | 13:41 |
| *** mriedem has joined #openstack-nova | 13:41 | |
| *** takedakn has joined #openstack-nova | 13:41 | |
| efried | jaypipes Let me catch up on the review comments. I can take over fixing up the api-ref build if you're getting burned out. | 13:42 |
| *** nmathew- has joined #openstack-nova | 13:42 | |
| jaypipes | efried: I'm way burned out on this, yes. | 13:42 |
| jaypipes | efried: and other than not wanting to go with "tree_member", I don't care about tree vs. in_tree. | 13:42 |
| efried | jaypipes What's it at right now in the patch? | 13:43 |
| jaypipes | tree | 13:43 |
| *** esberglu has joined #openstack-nova | 13:44 | |
| jaypipes | efried: I'll fix it. gimme 10 mins | 13:44 |
| efried | jaypipes cdent edleafe bauzas can we take a quick vote? Sounds like jaypipes is +1 on tree/in_tree and -1 on tree_member; I'm the same. | 13:44 |
| jaypipes | efried: but you can do the rebase for your WIP patches above it. | 13:44 |
| efried | jaypipes ight. | 13:45 |
| *** nmathew has quit IRC | 13:45 | |
| *** alexchadin has quit IRC | 13:45 | |
| jaypipes | efried: I'm +1 on just get this friggin done. | 13:45 |
| efried | ++ | 13:45 |
| *** psachin has quit IRC | 13:45 | |
| efried | You have to respin the patch anyway; but renaming that query param is slightly nontrivial compared to fixing the doc build. | 13:45 |
| cdent | -1 on tree_member, slight preference for in_tree over tree, but not enough to be upset if tree is the result | 13:45 |
| *** gbarros has joined #openstack-nova | 13:46 | |
| cdent | brb | 13:47 |
| *** esberglu has quit IRC | 13:48 | |
| *** lucas-hungry is now known as lucasagomes | 13:49 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:49 | |
| bauzas | jaypipes: I agree with you on the fact it's just a verbiage problem, so a nit, but honestly, given it would be an API parameter, I prefer to make sure we discuss that | 13:50 |
| jaypipes | bauzas: this patch is >1 year old. let's make a decision and do this. | 13:52 |
| bauzas | exactly | 13:52 |
| bauzas | so | 13:52 |
| bauzas | tree, -1 for me | 13:52 |
| bauzas | in_tree : +0 | 13:52 |
| maciejjozefczyk | Hello Guys, im trying to debug why I've faced a problem with scheduling. My instances stucks in 'scheduling' state. After enabling debug on nova-scheduler I've found that a host was selected. On nova-compute side there were 0 info about building an instance. It could be possible that the failure point is nova-conductor? | 13:53 |
| bauzas | tree_member : +1 | 13:53 |
| bauzas | or tree_node | 13:53 |
| jaypipes | alex_xu: around? your vote on tree, in_tree or tree_member please. | 13:53 |
| efried | in_tree has it by a whisker. | 13:57 |
| efried | You know, assuming it's a democracy in the first place | 13:57 |
| efried | and the need to delta what's there isn't being factored in. | 13:57 |
| sean-k-mooney2 | :) in_tree would be my choice out of those too | 13:58 |
| *** lyan has joined #openstack-nova | 13:59 | |
| sean-k-mooney2 | tree_member almost seams like a boolean to me. e.g. is that resouce a tree member or standalone | 14:00 |
| *** nmathew- has quit IRC | 14:01 | |
| *** liverpooler has joined #openstack-nova | 14:01 | |
| sean-k-mooney2 | but as cdent said between tree and in_tree i dont have a stong enough preference to mind which was used | 14:02 |
| *** hamzy has quit IRC | 14:02 | |
| efried | jaypipes How far up the stack are you rebasing currently? | 14:07 |
| *** kuzko has quit IRC | 14:07 | |
| jaypipes | efried: only to the update client to set parent provider patch (third from the bottom) | 14:08 |
| jaypipes | efried: since when I tried to rebase all the way up to your WIP patches, I failed miserably | 14:08 |
| *** sree has joined #openstack-nova | 14:08 | |
| efried | jaypipes k. I just started looking, but in particular I think this delta is wrong, please confirm: https://review.openstack.org/#/c/520643/8..9/nova/scheduler/client/report.py | 14:09 |
| efried | That reverts the exception handling bugfix. | 14:09 |
| *** kuzko has joined #openstack-nova | 14:09 | |
| efried | It's like an un-rebase | 14:09 |
| jaypipes | efried: yeah, I messed it up. totally. :( | 14:09 |
| *** mdnadeem has quit IRC | 14:09 | |
| efried | but I need to wait until you've published the bottom three to start rebasing on top. | 14:10 |
| jaypipes | efried: I ended up having to "revert" the rebase for the three patches at the bottom using clarkb's trick of git review -d XXXXX,N-1 && git commit --amend | 14:10 |
| jaypipes | efried: yes | 14:10 |
| jaypipes | efried: I'm just running tests now. | 14:10 |
| efried | k, I shall stop distracting you :) | 14:10 |
| jaypipes | efried: gimme another ten minutes to complete. | 14:10 |
| efried | rgr | 14:10 |
| *** udesale has joined #openstack-nova | 14:12 | |
| *** Guest78058 has quit IRC | 14:12 | |
| *** slaweq_ has joined #openstack-nova | 14:13 | |
| *** david-lyle has joined #openstack-nova | 14:13 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Check if interface belongs to a Linux Bridge before removing https://review.openstack.org/526079 | 14:14 |
| kashyap | mdbooth: Have you resolved your MySQL-Python on F27 thing? I'm on F27 | 14:15 |
| * kashyap is surprised that MySQL is still being used | 14:15 | |
| mdbooth | kashyap: I think so... by not building it :) | 14:15 |
| kashyap | Ah, then something somewhere still has stale deps file | 14:16 |
| *** armax has quit IRC | 14:17 | |
| *** dave-mccowan has quit IRC | 14:17 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | 14:18 |
| *** takedakn has quit IRC | 14:18 | |
| efried | cdent Would it be feasible/appropriate/relevant for jaypipes to put Depends-On to https://review.openstack.org/#/c/525605/ (grenade fix) from https://review.openstack.org/#/c/385693/ in his current spin? | 14:20 |
| cdent | efried: Maybe, I’m never quite sure well depends-on _to_ a grenade change works. It might be just fine. mriedem ? | 14:21 |
| efried | I know certain projects don't pick up Depends-Ons to certain other projects. | 14:21 |
| efried | I'm also pretty sure some of those rules changed (for the better IIRC) when we went to zuulv3 | 14:21 |
| efried | So - no idea at this point. | 14:22 |
| efried | Guess it couldn't hurt. If it winds up being a no-op, we haven't lost anything; but if it winds up going green, we know it works. | 14:22 |
| mriedem | it's valid for nova to depend on a grenade fix yes | 14:23 |
| mriedem | cdent: questions in https://review.openstack.org/#/c/521639/ | 14:24 |
| *** sree_ has joined #openstack-nova | 14:24 | |
| cdent | mriedem: roger, working on the contributor doc stuff now | 14:25 |
| *** sree_ is now known as Guest31633 | 14:25 | |
| mriedem | melwitt: lyarwood: i went over https://review.openstack.org/#/c/400384/ - only thing of note is that power_on (start API) is now going to do this full hard reboot, and i'm not sure if that's an intended side effect or not | 14:25 |
| mriedem | definitely feels like one of those changes that will break something else we aren't aware of, so i'll definitely want to avoid backporting that too far too fast until it has some time to sink in | 14:26 |
| sdague | cdent: can you let me know if you feel the heat fail on https://review.openstack.org/#/c/525605/ is valid or not | 14:26 |
| sdague | if not, I'm happy to get it merged | 14:26 |
| *** sree has quit IRC | 14:26 | |
| *** smatzek has quit IRC | 14:26 | |
| *** esberglu has joined #openstack-nova | 14:27 | |
| cdent | sdague: I was unable to trace the failure to anything related to placement, it looked like a timeout, but it’s hard to tell: the (single) test that failed doesn’t make what it’s doing all that obvious | 14:27 |
| cdent | so I’d say go for it | 14:27 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 14:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 14:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 14:29 |
| jaypipes | efried: et voila. ^ | 14:29 |
| efried | jaypipes Merci bien. | 14:29 |
| *** Guest31633 has quit IRC | 14:29 | |
| jaypipes | efried: changed to in_tree and also added that additional func test you wanted for the in_tree=CHILD_RP_UUID and returned grandchild RP with resources query | 14:29 |
| efried | jaypipes beaut. | 14:30 |
| jaypipes | efried: and fixed (hopefully?) the placement-api-ref shit. | 14:30 |
| mriedem | sdague: failopotamus might be busted on something with the zuulv3 move | 14:30 |
| mriedem | can't get any data on the grenade-heat job | 14:30 |
| *** andreas_s has quit IRC | 14:31 | |
| *** david-lyle has quit IRC | 14:31 | |
| *** andreas_s has joined #openstack-nova | 14:31 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: archive_deleted_instances is not atomic for insert/delete https://review.openstack.org/526065 | 14:32 |
| *** _ix has joined #openstack-nova | 14:32 | |
| mdbooth | mriedem: That's not a bug, that's a feature! https://review.openstack.org/#/c/400384/20 | 14:35 |
| *** salv-orlando has joined #openstack-nova | 14:35 | |
| *** andreas_s has quit IRC | 14:36 | |
| _ix | Good morning folks. I was curious if it were possible to take an existing hypervisor from one Openstack implementation and join it to a different one. | 14:36 |
| mriedem | define "join" | 14:36 |
| _ix | Basically, repoint the hypervisor to start using a different controller and attendant services. | 14:37 |
| _ix | But have that controller aware of the VMs running on it. | 14:37 |
| *** tesseract has quit IRC | 14:37 | |
| mriedem | no | 14:38 |
| mriedem | you can probably make a different controller aware of and manage the compute node, | 14:38 |
| mriedem | but not the existing VMs | 14:38 |
| mriedem | that would be like creating VMs in virsh directly and expecting nova to start managing them | 14:38 |
| mriedem | which won't happen | 14:38 |
| _ix | A man can dream, can't he? | 14:38 |
| mdbooth | _ix: Only approved dreams. | 14:39 |
| efried | _ix There are orchestrators (that live on top of nova) that can do "discovery" like that. | 14:39 |
| mdbooth | efried: orly? | 14:39 |
| * mdbooth should probably know about this already | 14:39 | |
| _ix | Yes, do tell, efried. | 14:39 |
| efried | mdbooth _ix I'm not necessarily talking about OpenStack projects. I just happen to know PowerVC does that. | 14:40 |
| mdbooth | efried: How would you create db entries without creating the guest? | 14:40 |
| mdbooth | Ah, ok | 14:40 |
| efried | mdbooth Yeah, we don't create 'em in nova. Just let you manage 'em whether they were created in nova or not. | 14:41 |
| _ix | Are there any other concepts of having an existing kvm vm and giving OS control over it? | 14:41 |
| _ix | Maybe by creating an image? | 14:41 |
| mdbooth | _ix: In the general case, Nova is very opinionated not only about having various metadata (mostly in the db) about an instance, but also exactly how that instance exists on the hypervisor. | 14:42 |
| *** hamzy has joined #openstack-nova | 14:42 | |
| efried | _ix It sounds like something that's possible. I don't know of an example of any turnkey tools to do it, but that doesn't mean they don't exist. | 14:42 |
| *** andreas_s has joined #openstack-nova | 14:42 | |
| mdbooth | Importing a guest which was created by something else is an open-ended problem with countless edge cases | 14:42 |
| _ix | I can appreciate that, and I don't mind doing the work. | 14:43 |
| efried | You could certainly create a disk image from a non-Nova VM and stuff it in Glance and use it to create Nova VMs. That's how you bootstrap Nova VMs in the first place, nah? | 14:43 |
| mdbooth | The guest would have to already be something which nova can describe exactly | 14:43 |
| mdbooth | And then you'd have to create its metadata | 14:44 |
| *** tesseract has joined #openstack-nova | 14:44 | |
| efried | yeah, you'd have to specify the metadata... | 14:44 |
| *** slaweq_ has quit IRC | 14:44 | |
| efried | jaypipes FYI, built the placement-api-ref locally for that patch and it passes. | 14:44 |
| mdbooth | It would be a pretty hard problem, anyway. | 14:44 |
| *** esberglu has quit IRC | 14:44 | |
| jaypipes | efried: cool. | 14:44 |
| mdbooth | _ix: Incredibly useful, though. | 14:44 |
| efried | jaypipes Oh, maybe I built it for the wrong patch. Pretend I didn't say that, but stay tuned. | 14:45 |
| _ix | Maybe this isn't as edgey of an edge case as I had thought. The requirement was to create a new openstack deployment while leaving the previous one largely intact. | 14:45 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add info about last-modified to contrib docs https://review.openstack.org/526084 | 14:45 |
| *** gouthamr has joined #openstack-nova | 14:46 | |
| _ix | Now that the new deployment is starting to outpace the old deployment in maturity, I'd like to cut over to the new one. But cutting over isn't that simple with existing VMs. | 14:46 |
| sdague | mriedem: it might be, I haven't tried to use it lately | 14:46 |
| mriedem | _ix: does "largely intact" include keep the ports and volumes connected to the old VMs? | 14:47 |
| mriedem | if the new thing should look like the old thing, then you have a problem with ports and volumes too | 14:47 |
| mriedem | i.e. the IP will change | 14:47 |
| _ix | Fortunately, there are no volumes to be concerned with, and the ports aren't as important with dns. | 14:48 |
| *** andreas_s has quit IRC | 14:48 | |
| mriedem | if that's not a problem, just snapshot the vms from the old deployment and create new vms from those snapshot images in the new deployment, | 14:48 |
| _ix | Largely intact would really just mean running and reachable. | 14:48 |
| mriedem | if you don't care about downtime | 14:48 |
| efried | jaypipes If https://review.openstack.org/#/c/384807/ was the docs-broken one -- that one passes now :) | 14:48 |
| bauzas | dansmith: jaypipes: question about libvirt VGPU, given we recreate the XML when migrating or hard rebooting an instance, we don't have passed allocations, so the new XML wouldn't know about the existing VGPUs | 14:48 |
| mriedem | if you care about downtime, use live snapshot | 14:48 |
| _ix | Downtime isn't an issue. | 14:48 |
| bauzas | dansmith: jaypipes: so I wonder if we should persist that | 14:48 |
| bauzas | for spawning it's not a problem | 14:49 |
| bauzas | given we pass the allocations | 14:49 |
| dansmith | bauzas: we can look them up easily right? | 14:49 |
| bauzas | dansmith: you mean about the change ? | 14:49 |
| mriedem | _ix: so your old cloud is running juno and you want to move to pike, but aren't doing upgrades, right? | 14:49 |
| _ix | Thanks for the discussion mriedem mdbooth efried. I've got some work to do. | 14:49 |
| efried | enjoy, | 14:49 |
| mriedem | _ix: in that case, easiest thing is just the snapshot move to the new cloud | 14:49 |
| _ix | It's newton to pike. | 14:49 |
| bauzas | dansmith: I can upload it soon yeah | 14:49 |
| *** armax has joined #openstack-nova | 14:49 | |
| bauzas | dansmith: oh, you mean about the allocations ? | 14:50 |
| _ix | I think that's what I'm planning on now. | 14:50 |
| mriedem | hell you could share glance between deployments to make the image move easier | 14:50 |
| _ix | That's a really good idea. | 14:50 |
| dansmith | bauzas: I'm not sure what you mean, but we can now easily look up the _new_ allocations intended for the live migration from placement | 14:51 |
| *** andreas_s has joined #openstack-nova | 14:52 | |
| bauzas | dansmith: mmm, yeah | 14:52 |
| mriedem | edleafe: are you going to handle https://review.openstack.org/#/c/516707/ soonish or would you like me to? i'd like to see a passing run through the stack on the functional tests and then skim the top patch and if nothing major, we can start merging early stuff in the series | 14:52 |
| *** hamzy has quit IRC | 14:53 | |
| bauzas | dansmith: anyway, just uploading my change and we'll be discussing | 14:53 |
| *** andreas_s has quit IRC | 14:53 | |
| *** andreas_s has joined #openstack-nova | 14:54 | |
| *** mlavalle has joined #openstack-nova | 14:54 | |
| *** huanxie has joined #openstack-nova | 14:54 | |
| edleafe | mriedem: I'm currently mired in fixing all the broken unit tests for the resize changes | 14:54 |
| edleafe | But I can get to that in a little while | 14:55 |
| mriedem | ok, i'll start skimming the top patch in the series then | 14:55 |
| *** hamzy has joined #openstack-nova | 14:55 | |
| ildikov | mriedem: morning :) | 14:57 |
| ildikov | mriedem: checked the comments and answered to a couple | 14:57 |
| *** tidwellr has joined #openstack-nova | 14:57 | |
| *** hamzy has quit IRC | 14:58 | |
| ildikov | mriedem: do you plan to touch that chain or should I start updating the virt/block_device changes? | 14:58 |
| *** esberglu has joined #openstack-nova | 14:59 | |
| huanxie | Hi jaypipes, I have a patch https://review.openstack.org/#/c/451641/ to remove using of nicira-iface-id for XenServer VIF, could you please review it when you are available? This is a follow up patch as my previous patch in Pike has deprecated the using of nicira-iface-id. | 14:59 |
| *** hamzy has joined #openstack-nova | 15:00 | |
| mriedem | ildikov: i'll handle the block_device.py changes in a bit - i think we definitely want to rollback if attachment_complete fails, just like in the old flow | 15:00 |
| mriedem | i just needed some time away from the series to think about that | 15:00 |
| ildikov | mriedem: yeah, we did when the call was first added | 15:00 |
| ildikov | it got uncovered when I moved, forgot to add another try-except block... :/ | 15:01 |
| ildikov | my bad | 15:01 |
| mriedem | i'm less sure about when we call save() before doing the driver attach, but i think we want to do similar to what we did before - only save() the connection_info after we've attached on the driver | 15:01 |
| *** awaugama has joined #openstack-nova | 15:01 | |
| mriedem | otherwise we're not actually connected | 15:01 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094 | 15:02 |
| ildikov | mriedem: the save() calls were put there a while ago and I removed the second one when johnthetubaguy pointed it out | 15:02 |
| ildikov | I'm a bit confused all the time when I get those parts that what gets saved to where and when... | 15:02 |
| *** salv-orlando has quit IRC | 15:03 | |
| ildikov | I think we ended up with two calls to be extra sure we have everything as at least on the Cinder side we got into trouble due to missing save() calls | 15:03 |
| *** owalsh_ has joined #openstack-nova | 15:03 | |
| *** huanxie has quit IRC | 15:04 | |
| ildikov | and my brain is definitely too small for keeping both code bases in it :) | 15:04 |
| *** huanxie has joined #openstack-nova | 15:04 | |
| dansmith | cdent: that patch to grenade makes sense to me, but I haven't gone digging to see if it actually makes sense | 15:05 |
| dansmith | cdent: but sdague will know, so let him +2 it first and then I'll hit it | 15:05 |
| *** owalsh has quit IRC | 15:05 | |
| cdent | many are the layers to sense | 15:05 |
| *** hamzy has quit IRC | 15:06 | |
| sdague | dansmith / cdent the change looks good to me conceptually, I just want to make sure that the heat fail seems unrelated. cdent: you able to take a look and give an assessment? | 15:07 |
| dansmith | I thought he said he did, and couldn't | 15:07 |
| dansmith | maybe a recheck to see? | 15:07 |
| *** tidwellr has quit IRC | 15:07 | |
| cdent | sdague: I’ve responded to you twice about that already, last one was [t 3ahR] | 15:07 |
| purplerbot | <cdent> sdague: I was unable to trace the failure to anything related to placement, it looked like a timeout, but it’s hard to tell: the (single) test that failed doesn’t make what it’s doing all that obvious [2017-12-06 14:27:39.279804] [n 3ahR] | 15:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 15:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | 15:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407 https://review.openstack.org/526095 | 15:09 |
| openstack | bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer) | 15:09 |
| efried | jaypipes cdent ^ Removed some test stuff that got accidentally re-introduced at PS86; and added that Depends-On. | 15:09 |
| jaypipes | efried: tyvm | 15:09 |
| sdague | oh, sorry, apparently I missed that last message | 15:09 |
| *** amodi has joined #openstack-nova | 15:09 | |
| *** salv-orlando has joined #openstack-nova | 15:10 | |
| *** tidwellr has joined #openstack-nova | 15:10 | |
| cdent | sdague: no worries, that’s pretty much exactly the reason I made that [t stuff | 15:10 |
| *** lajoskatona has quit IRC | 15:11 | |
| *** belmoreira has joined #openstack-nova | 15:12 | |
| *** emccormick has quit IRC | 15:12 | |
| *** salv-orlando has quit IRC | 15:13 | |
| *** hamzy has joined #openstack-nova | 15:13 | |
| *** hamzy has quit IRC | 15:14 | |
| *** huanxie has quit IRC | 15:16 | |
| *** jmlowe has joined #openstack-nova | 15:16 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Object changes to support last-modified headers https://review.openstack.org/521639 | 15:16 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add cache headers to placement api requests https://review.openstack.org/521640 | 15:16 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add info about last-modified to contrib docs https://review.openstack.org/526084 | 15:16 |
| *** huanxie has joined #openstack-nova | 15:16 | |
| *** janki has quit IRC | 15:17 | |
| cdent | mriedem: that ^ tries to address your comments | 15:17 |
| *** hamzy has joined #openstack-nova | 15:17 | |
| *** huanxie has quit IRC | 15:18 | |
| *** hamzy has quit IRC | 15:18 | |
| mriedem | sdague: cdent: fwiw i looked at the grenade heat failure too, there is a test timing out as chris mentioned, no failures in the heat logs that i could see, but without a history of runs on that job it's hard to know if it's just always unstable | 15:18 |
| *** huanxie has joined #openstack-nova | 15:19 | |
| mriedem | since it's non-voting and heat, i'm assuming it's just unstable | 15:19 |
| mriedem | as i recall, we removed heat from tempest full runs because of random timeouts | 15:19 |
| dansmith | I've sent it to its destiny | 15:20 |
| * cdent will be back later to look at the nrp stack | 15:23 | |
| *** cdent has quit IRC | 15:23 | |
| belmoreira | mriedem dansmith Quick question. Ocata requires cells mappings to be defined (it needs at least one cell defined). With cellsV1 are these mappings used in anyway? | 15:25 |
| mriedem | edleafe: comments in https://review.openstack.org/#/c/511358/ | 15:26 |
| dansmith | belmoreira: yeah, but they're not the same cells | 15:26 |
| *** david-lyle has joined #openstack-nova | 15:26 | |
| *** rmart04 has quit IRC | 15:26 | |
| dansmith | belmoreira: meaning, the mappings should just be straight-through to whatever the regular nova db for each cell is | 15:27 |
| *** rmart04 has joined #openstack-nova | 15:27 | |
| *** huanxie has quit IRC | 15:27 | |
| *** huanxie has joined #openstack-nova | 15:28 | |
| belmoreira | the cells DBs endpoints are actually used? | 15:28 |
| belmoreira | I mean, with cellsV1 and no conductor on top cell | 15:28 |
| dansmith | belmoreira: they are, yeah, but for you, each api db will have one cell mapping pointing at the corresponding cell db | 15:29 |
| dansmith | belmoreira: remember, cellsv2 is fully woven into the main code.. there is no way to separate it.. no mode where the cell mappings aren't used | 15:29 |
| *** smatzek has joined #openstack-nova | 15:30 | |
| *** smatzek has quit IRC | 15:30 | |
| *** smatzek has joined #openstack-nova | 15:30 | |
| belmoreira | dansmith: but I continue to have a global api_db | 15:31 |
| dansmith | belmoreira: I thought you were doing separate api dbs? | 15:31 |
| *** owalsh_ is now known as owalsh | 15:32 | |
| *** huanxie has quit IRC | 15:32 | |
| dansmith | I thought the question was over separate/global placement | 15:32 |
| belmoreira | dansmith yes, but I still need to have a global (top cell in cellsV1). local nova_apis (in each child cell) are basically for placement | 15:33 |
| *** yikun has quit IRC | 15:33 | |
| dansmith | I think we've always assumed that api_db would be replicated in each cellsv1 cell | 15:33 |
| *** liusheng has quit IRC | 15:33 | |
| *** huanxie has joined #openstack-nova | 15:33 | |
| dansmith | belmoreira: well, the api db at the top isn't global though, right? it just has all instances in it because of the fact that the top-level cell does too... | 15:34 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407 https://review.openstack.org/526095 | 15:34 |
| openstack | bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer) | 15:34 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | 15:34 |
| *** david-lyle has quit IRC | 15:34 | |
| *** gbarros has quit IRC | 15:35 | |
| *** moshele has quit IRC | 15:35 | |
| belmoreira | I didn't test everything yet, but was expecting to have instances, build_request, request_spec, aggregates, flavors... everything defined there. Without need to define it again in the locals nova_api DBs | 15:36 |
| *** tidwellr has quit IRC | 15:36 | |
| *** udesale has quit IRC | 15:36 | |
| dansmith | well, the bit of compute/api that gets re-run in the child cells will need to talk to an api database, | 15:36 |
| dansmith | but perhaps that will be okay for it to be global | 15:37 |
| * dansmith is thinking | 15:37 | |
| *** huanxie has quit IRC | 15:37 | |
| *** Apoorva has joined #openstack-nova | 15:37 | |
| efried | jaypipes If I ask for ?tree=<uuid that doesn't exist>, should I get an empty list or a 404? | 15:37 |
| dansmith | belmoreira: regardless, in that top-level nova_api db, I think you just want the one cell mapping to the api cell's nova db | 15:37 |
| jaypipes | efried: empty list | 15:37 |
| *** salv-orlando has joined #openstack-nova | 15:37 | |
| efried | jaypipes is that The Right Thing? | 15:37 |
| jaypipes | efried: ask cdent. | 15:37 |
| edleafe | mriedem: ok; still cleaning up the functional tests in https://review.openstack.org/#/c/516707 | 15:37 |
| *** hemna_ has joined #openstack-nova | 15:37 | |
| * efried waits patiently for cdent... | 15:38 | |
| *** huanxie has joined #openstack-nova | 15:38 | |
| *** tidwellr has joined #openstack-nova | 15:39 | |
| belmoreira | dansmith: hummm... I was not thinking about that cell mapping (top level nova DB). | 15:40 |
| mriedem | efried: jaypipes: i think empty list is the right thing | 15:41 |
| mriedem | 404 is for a specific resource not being found | 15:41 |
| mriedem | e.g. GET /resource_providers/{id} where the RP for {id} isn't found | 15:41 |
| mriedem | something not found in a body is a 400, but this is a filter parameter | 15:42 |
| mriedem | filtering on something which doesn't exist gets you nothing back | 15:42 |
| *** huanxie has quit IRC | 15:42 | |
| mriedem | i seem to remember this same quandary in another spec, maybe for the traits stuff | 15:42 |
| belmoreira | dansmith: I need to test it. But still not sure why it's required. | 15:42 |
| dansmith | belmoreira: not sure why the cell mapping is required? | 15:43 |
| *** lpetrut has quit IRC | 15:43 | |
| efried | mriedem jaypipes okay, that makes sense, thanks. | 15:43 |
| belmoreira | dansmith: I understood that you said that in nova_api global I need to have a mapping to the nova DB (father cell) | 15:44 |
| dansmith | right | 15:44 |
| *** lpetrut has joined #openstack-nova | 15:44 | |
| edleafe | efried: what mriedem said. Empty list is correct. | 15:45 |
| *** salv-orlando has quit IRC | 15:45 | |
| efried | thanks | 15:46 |
| belmoreira | dansmith: I completely forgot to do that mapping. And in my early tests I haven't seen any problem | 15:46 |
| dansmith | belmoreira: cellsv1 will probably side-step some things that would make things continue to work without that mapping, but not all | 15:46 |
| dansmith | belmoreira: just because it overrides certain code paths that we're not updating for cellsv2 | 15:47 |
| *** egonzalez has joined #openstack-nova | 15:47 | |
| belmoreira | dansmith: fair enough. Must be that | 15:47 |
| dansmith | belmoreira: I wouldn't think it would override enough to make it seem like things are really working, but I'd have to test, as you say | 15:47 |
| *** dave-mccowan has joined #openstack-nova | 15:47 | |
| mriedem | in ocata, | 15:48 |
| mriedem | it looks like the only things that use cell mappings are the api when listing instances, and conductor when burying an instance that fails to shedule in cell0 | 15:48 |
| mriedem | for cellsv1, are those things that only happen in the child api? | 15:48 |
| *** mvk has quit IRC | 15:48 | |
| dansmith | no, that's the thing, | 15:48 |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Don't use nicira-iface-id for XenServer VIF https://review.openstack.org/451641 | 15:48 |
| dansmith | listing instances should be mostly the same, | 15:48 |
| dansmith | althouuuuugh... | 15:48 |
| dansmith | we do have some "if cellsv1: then do_old_thing()" escapes in that listing logic | 15:49 |
| dansmith | so maybe that's it | 15:49 |
| mriedem | oh wait, | 15:49 |
| mriedem | yup | 15:49 |
| dansmith | yeah, okay | 15:49 |
| mriedem | when listing instances, if cellsv1 we do the old thing | 15:49 |
| mriedem | we do look in cell0 though | 15:49 |
| dansmith | yeah | 15:49 |
| mriedem | so you'll need the cell0 mapping at the top yes? | 15:49 |
| mriedem | ok | 15:49 |
| dansmith | yes | 15:49 |
| mriedem | belmoreira: ^ | 15:49 |
| dansmith | belmoreira: you will want the record there anyway, at some point | 15:49 |
| mriedem | scheduler and api don't use cell mappings until pike | 15:49 |
| dansmith | belmoreira: also, while you're here.. this fix is tanking the cellsv1 job: https://review.openstack.org/#/c/523187/ | 15:50 |
| dansmith | which is, like, not a good sign, | 15:50 |
| belmoreira | yeah, cell0 I defined | 15:50 |
| dansmith | but I'm not sure why, especially since you said it works | 15:50 |
| dansmith | like, 100% fail on anything that hits nova | 15:50 |
| dansmith | which seems hard to believe | 15:50 |
| *** edand has joined #openstack-nova | 15:51 | |
| *** huanxie has joined #openstack-nova | 15:52 | |
| belmoreira | dansmith: I'm running this patch already. Haven't detected any issue yet. However, the functionality that we expose is very limited. Maybe that's why. | 15:55 |
| huanxie | Hi jaypipes, I have updated the reno to make it precise and please help review it again https://review.openstack.org/#/c/451641/ Thanks a lot :) | 15:55 |
| mriedem | belmoreira: can't even build an instance it looks like | 15:55 |
| jaypipes | huanxie: already +2d. | 15:55 |
| dansmith | belmoreira: I dunno, this seems to fail everything all the time, but I can't really see any errors in the logs | 15:55 |
| mriedem | times out waiting to go to ACTIVE | 15:55 |
| huanxie | Many thanks jaypipes :) | 15:56 |
| belmoreira | dansmith: but, as you said, not a good sign :) Will keep eyes open on this | 15:56 |
| *** awaugama has quit IRC | 15:56 | |
| *** huanxie has quit IRC | 15:56 | |
| dansmith | well, anyway, I don't want to spend too much time on it, but unless we figure that out, we can't merge it | 15:56 |
| *** emccormick has joined #openstack-nova | 15:57 | |
| belmoreira | dansmith: definitely create/delete instances is working for us with this patch | 15:57 |
| dansmith | although that's ocata I guess | 15:57 |
| belmoreira | but I'm running newton | 15:57 |
| dansmith | oh, newton | 15:57 |
| dansmith | well, still, I'd expect to see an error somewhere if this was actually blowing something up | 15:58 |
| belmoreira | in pike I will not need this patch | 15:58 |
| openstackgerrit | Merged openstack/nova master: Add a new check to volume attach https://review.openstack.org/525622 | 15:59 |
| mriedem | dansmith: looking at the instance create flow, if cellsv1 the api will create the instance before casting to build_instances in conductor, | 15:59 |
| mriedem | build_instances in conductor creates the instance mapping | 15:59 |
| mriedem | well, api creates the instance mapping | 16:00 |
| mriedem | conductor gets the host mapping for the chosen host and pulls the cell mapping from that host mapping to set on the instance mapping | 16:00 |
| mriedem | then deletes the build request | 16:00 |
| mriedem | ah, | 16:00 |
| mriedem | and if the build request is already destroyed when conductor tries to do it, | 16:01 |
| mriedem | conductor deletes the instance mapping | 16:01 |
| mriedem | which the api relies on i think | 16:01 |
| *** awaugama has joined #openstack-nova | 16:01 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L599-L605 | 16:01 |
| dansmith | oh you think we're deleting the build request early enough that it just nukes the instance when it tries because it assumes the user did it? | 16:01 |
| *** lpetrut has quit IRC | 16:02 | |
| mriedem | maybe | 16:02 |
| mriedem | and when getting the instance from the api, we'll pull it from the top cell https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2221 | 16:02 |
| dansmith | the update at top thing should really happen pretty late, after the cell sync, so I didn't think that was a problem | 16:02 |
| mriedem | update at top happens for any state change doesn't it? | 16:03 |
| *** emccormick has quit IRC | 16:03 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L573 | 16:03 |
| mriedem | so ^ should trigger an update at the top | 16:03 |
| mriedem | which will delete the build request | 16:03 |
| mriedem | and then later we'll get build request not found which will make conductor delete the instance mapping https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L604 | 16:04 |
| mriedem | thinking the instance was deleted by the user during build | 16:04 |
| mriedem | yup, and https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L605 means we don't cast to the compute to build the instance | 16:04 |
| dansmith | yeah, but I expected it to happen late enough | 16:04 |
| mriedem | i think i get a cookie now | 16:05 |
| mriedem | frosted sugar with sprinkles please | 16:06 |
| dansmith | weyl.. I'm not sure what to do, other than to weaken conductor's interpretation of the BR being missing if cellsv1 | 16:06 |
| mriedem | can we conditionally delete the build request in cells/messaging based on the instance state? | 16:06 |
| dansmith | well, which state? | 16:07 |
| ildikov | mriedem: I'm at a place selling cupcakes one of which is called 'Uniporn & Rainho', sucks I can't send over one through IRC :/ | 16:07 |
| mriedem | dansmith: is ACTIVE too late? | 16:07 |
| dansmith | I would think, | 16:07 |
| dansmith | since we might not even make it to ACTIVE | 16:07 |
| mriedem | i'm not even sure why we need this | 16:08 |
| dansmith | what if we do it only if save() succeeded | 16:08 |
| mriedem | given https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L597 | 16:08 |
| dansmith | mriedem: I think it's because that might've happened in a separate api db | 16:08 |
| *** andreas_s has quit IRC | 16:08 | |
| mriedem | we could alternatively check if we've set the cell mapping on the instance mapping, meaning we've picked a host, https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L509 but that's racy | 16:08 |
| mriedem | because then conductor and cells/messaging are racing to delete the build request | 16:09 |
| *** andreas_s has joined #openstack-nova | 16:09 | |
| mriedem | but cells/messaging will only do it on the next update at top | 16:09 |
| mriedem | which presumably would come after conductor has set the mapping and already deleted the build request | 16:09 |
| dansmith | if they're sharing an api db, but not the cell db, | 16:09 |
| mriedem | hmm, so the thing conductor deletes isn't necessarily the same thing that cells/messaging deletes? | 16:10 |
| dansmith | then an update will delete the BR in the shared api db, which will then make conductor delete from the cell db, which will sync back up as a delete to the top level db | 16:10 |
| dansmith | but if they're separate api dbs, | 16:10 |
| dansmith | then you have to sync the BR delete up or you shadow the actual instance | 16:10 |
| *** andreaf_ has joined #openstack-nova | 16:10 | |
| dansmith | since we were in the cell db when we did the BR delete | 16:10 |
| dansmith | mriedem: you wanna borrow my rusty spoon when I'm done with it? | 16:11 |
| mriedem | for your eyeballs? | 16:11 |
| dansmith | yes | 16:11 |
| mriedem | sure | 16:11 |
| mriedem | send'er over | 16:11 |
| dansmith | heh | 16:11 |
| mriedem | pre-gooped please | 16:11 |
| *** gbarros has joined #openstack-nova | 16:12 | |
| *** andreas_s has quit IRC | 16:13 | |
| *** erlon has joined #openstack-nova | 16:13 | |
| *** andreas_s has joined #openstack-nova | 16:13 | |
| *** rmart04 has quit IRC | 16:14 | |
| dansmith | mriedem: anyway, I want to fix this, but I can't really justify spending time on it ahead of other stuff on my plate | 16:14 |
| dansmith | the patch is there for people to apply if they need it for that scenario, and maybe I can circle back after FF or something | 16:14 |
| belmoreira | dansmith: +1, for me this patch makes sense in older versions (newton, ocata). Not sure how useful it will be in Pike, Queens. | 16:17 |
| belmoreira | dansmith mriedem thanks. I will keep you posted | 16:17 |
| *** andreaf has quit IRC | 16:17 | |
| *** andreaf_ is now known as andreaf | 16:17 | |
| mriedem | dansmith: edleafe: so after careful contemplation in the last 5 minutes, | 16:19 |
| mriedem | i think we can unpin the Selection object patch | 16:19 |
| *** faridda has joined #openstack-nova | 16:19 | |
| dansmith | okay | 16:19 |
| mriedem | my concerns in the top patch in the series about filtering out the hosts that have already been tried can be done in other ways using the filter_properties retry list of hosts | 16:19 |
| mriedem | i.e. knowing what's already been claims | 16:19 |
| mriedem | *claimed | 16:19 |
| bauzas | I need to look at those Selection changes me too | 16:20 |
| dansmith | gdi gerrit | 16:20 |
| mriedem | jaypipes: https://review.openstack.org/#/c/495854/ if you will +W | 16:21 |
| *** belmoreira has quit IRC | 16:22 | |
| mriedem | or i can just re-approve, it was a rebase plus some minor changes | 16:23 |
| mriedem | i'll just re-approve :) | 16:23 |
| *** damien_r has quit IRC | 16:23 | |
| *** gouthamr has quit IRC | 16:23 | |
| *** andreas_s has quit IRC | 16:24 | |
| *** cdent has joined #openstack-nova | 16:24 | |
| *** andreas_s has joined #openstack-nova | 16:24 | |
| gibi | mriedem: I proposed a fix for bug 1735407 but I feel that it only solves part of the race. | 16:25 |
| openstack | bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:25 |
| cdent | efried: jaypipes, mriedem and edleafe are all correct | 16:25 |
| mriedem | efried: per your earlier question about empty vs 404 ,this was the spec discussion i was thinking of https://review.openstack.org/#/c/497713/9/specs/queens/approved/add-trait-support-in-allocation-candidates.rst@78 | 16:25 |
| gibi | mriedem: I would appreciate your view about the possible solution I drafted in the bug report (see my last 3 comments there) | 16:25 |
| efried | cdent mriedem ack | 16:26 |
| cdent | the only time a 404 should happen on a collection resource is if the URL doesn’t exist (in which case it’s not a collection resource) | 16:26 |
| mriedem | gibi: in general i think reducing the window is a positive step forward, despite other known limitations as pointed out | 16:27 |
| mdbooth | jaypipes: Pretty sure that anywhere that uses retry without creating a transaction context would be a bug, no? | 16:27 |
| *** andreas__ has joined #openstack-nova | 16:27 | |
| mriedem | gibi: #3 in comment 11 would be a further improvement in case we still have issues | 16:28 |
| *** andreas_s has quit IRC | 16:28 | |
| gibi | mriedem: I agree. We have to see if the current fix solves the problem in the environment it was found earlier | 16:29 |
| gibi | mriedem: if yes then we are OK, if no then I can try to implement option #3 | 16:29 |
| sean-k-mooney2 | mriedem: dansmith when ye have a second could ye take alook at this trival update to the .gitreview file for stable/pike in os-vif https://review.openstack.org/#/c/488670/ | 16:30 |
| *** ragiman has quit IRC | 16:30 | |
| dansmith | snagged | 16:31 |
| mriedem | gibi: there is an issue in your patch | 16:31 |
| mriedem | gibi: the compute can't up-call to get the request spec | 16:31 |
| mriedem | b/c the reqspec is in the api db | 16:31 |
| mriedem | and the compute should be isolated fromthat | 16:31 |
| *** andreas__ has quit IRC | 16:32 | |
| gibi | mriedem: that is bad | 16:32 |
| mriedem | :) | 16:32 |
| * gibi going back to the drawing board | 16:32 | |
| mriedem | it just means that you would have to plumb the request_spec through to the compute rebuild_instance method | 16:32 |
| mriedem | using rpc api parms | 16:32 |
| gibi | mriedem: would that mean an rpc version bump as well? | 16:32 |
| mriedem | yes | 16:32 |
| mriedem | granted, _validate_instance_group_policy is already doing an up-call to the api db | 16:32 |
| mriedem | by getting the server groups | 16:32 |
| mriedem | and that's why we have CONF.workarounds.disable_group_policy_check_upcall | 16:33 |
| gibi | would it make sense doing the request spec upcall in the _validate_instance_group_policy ? | 16:34 |
| gibi | in _do_validation | 16:34 |
| mriedem | no, | 16:34 |
| mriedem | we need fewer up-calls, not more | 16:35 |
| gibi | true | 16:35 |
| mriedem | https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#caveats-of-a-multi-cell-deployment | 16:35 |
| mriedem | ^ that list needs to shrink | 16:35 |
| gibi | this would be inside the 'The late anti-affinity check' item in that list, but I agree to look at the other option instead | 16:36 |
| gibi | so, if the rpc version is bumped, can I still backport the fix to stable branches? | 16:36 |
| mriedem | no | 16:36 |
| mriedem | gibi: given the super latent nature of this bug, | 16:37 |
| gibi | it seems this bug exists from at least Mitaka | 16:38 |
| mriedem | i don't think we need to add more up-calls within the validate method just to backport | 16:38 |
| mriedem | the bug has existed since evacuate i assume | 16:38 |
| gibi | could be | 16:38 |
| gibi | so we say we only fix it in master and not on any stable | 16:39 |
| mriedem | i think so | 16:39 |
| *** nmathew- has joined #openstack-nova | 16:39 | |
| gibi | OK, I will do the rpc change | 16:39 |
| openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | 16:40 |
| gibi | mriedem: thanks for feedback on the fix | 16:40 |
| mriedem | np | 16:40 |
| *** gbarros has quit IRC | 16:40 | |
| *** nmathew has joined #openstack-nova | 16:41 | |
| jaypipes | mdbooth: the transaction context is automatically managed by the engine facade. I'm saying there's no need to do the secondary independent transaction context thing | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Scheduler set_inventory_for_provider does nested https://review.openstack.org/520643 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._get_providers_in_tree https://review.openstack.org/520663 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._get_providers_in_aggregates https://review.openstack.org/521097 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:43 |
| efried | jaypipes cdent edleafe ^ The bottom three are just rebases onto latest master. The rest that aren't WIP ought to be clear and ready for reviews. | 16:44 |
| jaypipes | efried: cool. hopefully you didn't leave the same carnage as I did trying to rebase those... | 16:44 |
| cdent | efried: roger. just header into that stack now | 16:44 |
| *** nmathew- has quit IRC | 16:44 | |
| mdbooth | jaypipes: But it's not managed by the retry, right? So if you retry without an enginefacade call at the same scope, you'll still have an aborted transaction. | 16:44 |
| efried | jaypipes I am also hopeful :) | 16:44 |
| *** nmathew- has joined #openstack-nova | 16:44 | |
| efried | jaypipes I think I mainly undid carnage | 16:45 |
| mdbooth | jaypipes: That is, all your retries will fail. | 16:45 |
| *** nmathew- has quit IRC | 16:45 | |
| jaypipes | mdbooth: no. | 16:45 |
| jaypipes | mdbooth: the retry decorator is designed to work with the enginefacade's transaction context... | 16:45 |
| jaypipes | zzzeek: you around? need your expert opinion on something. | 16:46 |
| mdbooth | jaypipes: Ah... lemme check that. I may have missed that. | 16:46 |
| efried | jaypipes Argh, found a pep8 error in your REST API change. | 16:46 |
| efried | jaypipes in_tree pushed a docstring line over 80c :( | 16:46 |
| jaypipes | efried: that I did or that you did? :) | 16:47 |
| zzzeek | jaypipes: gotta leave in about 3 minutes but whats up | 16:47 |
| jaypipes | efried: ah | 16:47 |
| jaypipes | zzzeek: sec, grabbing link | 16:47 |
| efried | jaypipes You did. But let me fix it, since I've got the stack right here. | 16:47 |
| *** egonzalez has quit IRC | 16:47 | |
| mriedem | cdent: done https://review.openstack.org/#/c/521639/ thanks | 16:47 |
| jaypipes | zzzeek: line 123, my comment here: https://review.openstack.org/#/c/242603/25/nova/objects/block_device.py | 16:47 |
| cdent | mriedem: cool, yeah on the IRON_NFV cleanup, I didn’t want to disrupt the entire functional test | 16:48 |
| jaypipes | zzzeek: AFAIK, there's no need to do that | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 16:48 |
| *** nmathew has quit IRC | 16:48 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 16:48 |
| jaypipes | zzzeek: i.e. no need for the txtct.using(context) thing on line 125 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Scheduler set_inventory_for_provider does nested https://review.openstack.org/520643 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._get_providers_in_tree https://review.openstack.org/520663 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._get_providers_in_aggregates https://review.openstack.org/521097 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 16:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:48 |
| *** jangutter has quit IRC | 16:48 | |
| efried | jaypipes Fixed. Very bottom of the stack, of course. | 16:48 |
| *** gyee has joined #openstack-nova | 16:48 | |
| jaypipes | efried: ack | 16:48 |
| jaypipes | ty | 16:48 |
| mdbooth | jaypipes: I'm looking at the code for wrap_db_retry, and I don't see anything which would create a new transaction. | 16:48 |
| mdbooth | We normally use this decorator on a function which also has a decorator to create a transaction context, though. | 16:49 |
| jaypipes | mdbooth: the whole *point* of the retry decorator is to catch the ROLLBACK and restart a transaction :) | 16:49 |
| mdbooth | I don't think so, no. | 16:49 |
| mdbooth | I think it just retries. | 16:49 |
| *** lpetrut has joined #openstack-nova | 16:50 | |
| mdbooth | And the way we always use it is that we also create a transaction. | 16:50 |
| zzzeek | jaypipes: i belive your comment is accurate but the method itself has to be called before there's some larger transaction going on , unless the retry decorators know to propagate all the way up to the top one | 16:50 |
| efried | bauzas gibi Would you please re-+A https://review.openstack.org/377215 (rebase & trivial pep8 change) | 16:50 |
| mdbooth | There's no nested context stuff going on with the retry decorator | 16:51 |
| *** Alex_Staf has quit IRC | 16:51 | |
| bauzas | efried: did | 16:51 |
| efried | bauzas Merci | 16:51 |
| mdbooth | jaypipes: I'm looking at the code: it just runs it again | 16:51 |
| dansmith | the transaction is in the decorator, so if the retry is above that, it'll do another transaction | 16:52 |
| *** syjulian has quit IRC | 16:52 | |
| mdbooth | dansmith: Right. | 16:52 |
| mdbooth | They're 2 separate things, but we normally use them together. | 16:52 |
| zzzeek | jaypipes mdbooth i dont see the point of the retry decorator if you have a context manager inside to handle the thing anyway | 16:52 |
| mdbooth | zzzeek: Well the context manager always has to be inside the retry decorator | 16:53 |
| jaypipes | zzzeek: me neither, which is why I wrote that comment. | 16:53 |
| *** jangutter has joined #openstack-nova | 16:53 | |
| mdbooth | However, we normally put it inside the retry decorator using another decorator | 16:53 |
| mdbooth | So: | 16:53 |
| mdbooth | @retry | 16:53 |
| mdbooth | @transaction | 16:53 |
| mdbooth | def my_foo(): | 16:53 |
| *** hamzy has joined #openstack-nova | 16:53 | |
| zzzeek | mdbooth jaypipes haven't looked at this stuff in awhile, the context manager looks unfamiliar to me, would want to see other places the rerty decorator is used and see if a. they also have a nested trans or b. they dont, and then how do these work? | 16:54 |
| * zzzeek has to run | 16:54 | |
| *** hongbin has joined #openstack-nova | 16:54 | |
| *** AlexeyAbashkin has quit IRC | 16:54 | |
| gibi | efried: done | 16:54 |
| efried | gibi Thanks! | 16:54 |
| *** chyka has joined #openstack-nova | 16:54 | |
| mdbooth | jaypipes: Let me think again if there's a good enough reason not to use the decorator there. | 16:54 |
| *** fragatina has quit IRC | 16:55 | |
| dansmith | sales meeting in 5 | 16:55 |
| jaypipes | mdbooth: I'm not saying don't use the decorator. I'm saying no need to use the inner tctxt.using() thing. | 16:55 |
| mdbooth | jaypipes: So I'm also entirely sure we must have an enginefacade transaction scope there | 16:56 |
| mdbooth | Which we normally do at function scope using a decorator | 16:56 |
| mdbooth | I'm actually being super-defensive there, I think | 16:56 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407 https://review.openstack.org/526095 | 16:57 |
| openstack | bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:57 |
| mdbooth | If the transaction fails on commit, it'll trigger a retry | 16:57 |
| mdbooth | When we retry, we want a new transaction | 16:57 |
| mdbooth | So we need to create one somehow | 16:57 |
| mdbooth | I'm explicitly using an independent transaction | 16:58 |
| mdbooth | So I'm explicitly *not* using any enclosing transaction scope | 16:58 |
| jaypipes | mdbooth: ahhhh... sorry, yeah, I didn't realize there was no enginefacade decorator being used on any of these object entrypoints (BlockDeviceMapping.create()/save(), etc) | 16:58 |
| mdbooth | So it definitely looks weird because I'm being super-defensive. | 16:58 |
| *** salv-orlando has joined #openstack-nova | 16:58 | |
| mriedem | ildikov: replied in https://review.openstack.org/#/c/525787/ | 16:59 |
| jaypipes | mdbooth: my presumption was that there was an enginefacade trx context decorator on one of the BDM object methods. :( | 16:59 |
| mriedem | ildikov: if you agree, i'll start on those changes after my next meeting | 16:59 |
| jaypipes | mdbooth: and I see now there isn't... | 16:59 |
| mdbooth | Actually, when I originally wrote that I was less defensive and jsut wrote a comment about how this might fail on multi-master galera | 16:59 |
| mdbooth | But we don't care, because it almost definitely won't | 16:59 |
| mdbooth | And that version looked more normal | 16:59 |
| jaypipes | mdbooth: instead of using that independent context using() thing, I believe you can instead just decorate the _create_uuid() method with the @writer enginefacade decorator, in addition to the @wrap_db_retry decorator. | 17:00 |
| melwitt | mriedem: replied on the review about power_on | 17:00 |
| mdbooth | (but it failed safely) | 17:00 |
| mdbooth | jaypipes: Note the 'independent' in there | 17:00 |
| *** tssurya_ has joined #openstack-nova | 17:00 | |
| mdbooth | That's so a race there wouldn't cause a failure of the encompassing transaction | 17:01 |
| mdbooth | jaypipes: Again, I could be convinced to roll back to my big comment explaining why this might fail sometimes. | 17:01 |
| jaypipes | mdbooth: *what* encompassing trx though? I had originally thought there was an encompassing transaction managed by an enginefacade transaction context manager, but I see now there isn't any enginefacade decorator being used on any of the BDM object methods like create(), save(), etc | 17:02 |
| mdbooth | jaypipes: Not today, no. | 17:02 |
| jaypipes | mdbooth: you're implying there will be? :) | 17:03 |
| mdbooth | jaypipes: The design of the enginefacade encourages it, and we have no way of knowing. | 17:03 |
| mdbooth | e.g. if the thing *calling* save had its own transaction | 17:03 |
| mdbooth | we'd be in an encompassing scope | 17:03 |
| mdbooth | Do we ever call save() within a transaction scope? | 17:04 |
| mdbooth | We never used to, because they were confined to db.api() | 17:04 |
| mdbooth | However, they've been moving out of there for a while. | 17:05 |
| mdbooth | jaypipes: Anyway, this is very defensive. I wrote it such that it shouldn't fail however you call it. That makes it look different, so it's a tossup whether it's worth it. | 17:06 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/python-novaclient master: CommandError is raised for invalid server fields https://review.openstack.org/525110 | 17:06 |
| jaypipes | mdbooth: commented on the patch again... | 17:06 |
| jaypipes | mdbooth: lemme know if that code makes more sense. | 17:06 |
| jaypipes | mdbooth: sorry, I originally had missed the fact that no enginefacade trx context decorators were in use for BDM object | 17:07 |
| bauzas | quick question for privsep specialists | 17:07 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/python-novaclient master: CommandError is raised for invalid server fields https://review.openstack.org/525110 | 17:07 |
| mdbooth | jaypipes: Yeah, I think the only reason I didn't do that was to have an independent transaction | 17:07 |
| *** Guest18930 has quit IRC | 17:07 | |
| bauzas | given I need to open a file for write attributes, do I need to use a privsep method doing os.open() or can I just call it directly? | 17:07 |
| mdbooth | jaypipes: i.e. a transaction which is explicitly divorced from any encompassing scope | 17:08 |
| *** itlinux has joined #openstack-nova | 17:08 | |
| mdbooth | Because if that was called from within an encompassing scope, it would still fail on retry, as well as failing the encompassing scope | 17:08 |
| mdbooth | But as I said, this is super-unlikely. | 17:08 |
| bauzas | AFAICT, I can see in the libvirt driver some os.open calls that write directly | 17:08 |
| *** hamzy has quit IRC | 17:08 | |
| mdbooth | So a comment might suffice. | 17:09 |
| sean-k-mooney2 | bauzas: if you dont need elevated privlages to open the file in the mode you need then you dont need privsep | 17:09 |
| *** hamzy has joined #openstack-nova | 17:09 | |
| *** salv-orlando has quit IRC | 17:09 | |
| bauzas | sean-k-mooney2: well, it's a sysfs call | 17:09 |
| bauzas | I need to open("/sys/class/mdev_bus/<device>/mdev_supported_types/<type>/create", O_WRITE) | 17:10 |
| *** salv-orlando has joined #openstack-nova | 17:10 | |
| mdbooth | jaypipes: It's an interesting point, btw. I think everywhere that we use the retry decorator would be broken unless it's guaranteed to be a top-level transaction scope. | 17:10 |
| sean-k-mooney2 | bauzas: oh are you working a lib for that beacues we are planning to write one soon | 17:10 |
| *** david-lyle has joined #openstack-nova | 17:10 | |
| bauzas | sean-k-mooney2: no, I'm implementing the libvirt side for creating a VGPU | 17:11 |
| bauzas | but for that, nova needs to instanciate a mediated device | 17:11 |
| bauzas | then, once that done, it needs to update the guest XML using that UUID it just created | 17:11 |
| sean-k-mooney2 | bauzas: or libvirt could | 17:11 |
| bauzas | sean-k-mooney2: libvirt doesn't do that atm | 17:11 |
| bauzas | call it experimental :) | 17:12 |
| *** hamzy has quit IRC | 17:12 | |
| bauzas | sean-k-mooney2 https://libvirt.org/drvnodedev.html#MDEV (bottom page) | 17:12 |
| bauzas | you'll see the lovely sysfs call I need to make | 17:12 |
| sean-k-mooney2 | bauzas: i know that is why we where planning on writing a singel file pytyon wrapper around sysfs to do it | 17:12 |
| jaypipes | mdbooth: certainly something to chat with zzzeek about at some later time. | 17:12 |
| *** hamzy has joined #openstack-nova | 17:12 | |
| sean-k-mooney2 | and in our case call it for os-vif | 17:12 |
| bauzas | hum | 17:12 |
| bauzas | sean-k-mooney2: okay, so that's definitely a privsep decoy then | 17:13 |
| sean-k-mooney2 | so i would assume that /sys/class/mdev_bus/<device>/mdev_supported_types/<type>/create is owned by root | 17:13 |
| *** sdague has quit IRC | 17:13 | |
| openstackgerrit | Merged openstack/os-vif stable/pike: Update .gitreview for stable/pike https://review.openstack.org/488670 | 17:13 |
| bauzas | sean-k-mooney2: zactly, so I'll just make a public method in the nova.privsep helper module | 17:13 |
| bauzas | call it tech debt if you wish | 17:13 |
| *** salv-orlando has quit IRC | 17:14 | |
| bauzas | if the libvirt API was supporting to do such things like creating a mediated device without asking to use sysfs, then I wouldn't need to do such crap things in nova | 17:14 |
| sean-k-mooney2 | bauzas: yep but the real question is what capablitis do you need? | 17:14 |
| *** damien_r has joined #openstack-nova | 17:14 | |
| *** fragatina has joined #openstack-nova | 17:14 | |
| bauzas | sean-k-mooney2: AFAIK, nova privsep uses the global ones | 17:15 |
| ildikov | mriedem: agree, replied, thanks | 17:15 |
| *** lucasagomes is now known as lucas-afk | 17:15 | |
| sean-k-mooney2 | bauzas: well my point is there are two parts to this. the mode of the file e.g. is it globally writeabe or do you have to be a specific user/group and second do you need cap_sys_admin for exampel to write to it ignoring the filesystem mode | 17:16 |
| bauzas | sean-k-mooney2: for the first question, I'm supposing to use the uid 0 for opening and writing the file | 17:17 |
| bauzas | so the basic nova.privsep context | 17:17 |
| sean-k-mooney2 | bauzas: so you will reuse this one https://github.com/openstack/nova/blob/2af92486b2dff6eb50c2e1f52e23eeae50d4bf98/nova/privsep/__init__.py#L21 | 17:18 |
| bauzas | sean-k-mooney2 : what I need is actually pretty identical to https://github.com/openstack/nova/blob/master/nova/privsep/libvirt.py#L117 | 17:19 |
| bauzas | sean-k-mooney2 yup that's what I meant | 17:19 |
| sean-k-mooney2 | bauzas: CAP_DAC_OVERRIDE allow you to ignore filesystem permissions | 17:19 |
| bauzas | sean-k-mooney2: nevermind, I'll basically copy/shame the hairpin cut sysfs call | 17:20 |
| bauzas | I need to bail out | 17:20 |
| sean-k-mooney2 | bauzas: yes just reuse @nova.privsep.sys_admin_pctxt.entrypoint | 17:20 |
| bauzas | Christmas tree implementation time | 17:20 |
| sean-k-mooney2 | cool enjoy | 17:21 |
| bauzas | sean-k-mooney2: I knew how to use privsep, I was just wondering whether it was needed | 17:21 |
| bauzas | but yeah, since it's a sysfs call, I need it, so... | 17:21 |
| bauzas | ++ | 17:21 |
| *** damien_r has quit IRC | 17:23 | |
| *** yamamoto has quit IRC | 17:23 | |
| cdent | here’s a question I’ve been wondering about for a long time: How do people decide when a comment is a NOTE and when it is just a comment? | 17:24 |
| sean-k-mooney2 | bauzas: i do feel i might end up duplicating your work so can you add me to the review if you push it up. im working on using mdev's for netwoking currently though it wont be pushed upstream until rocky at the earliset as the qemu changes arent even submitted upstream yet | 17:24 |
| mdbooth | jaypipes: As for creating null uuids in a test, I still think that my 1-liner is better than 22 lines. | 17:24 |
| jaypipes | mdbooth: and adding a testing-only kwarg to a public API? nah... | 17:25 |
| mdbooth | jaypipes: It's not a public api | 17:25 |
| jaypipes | mdbooth: close enough to a public API in my book... | 17:25 |
| mdbooth | And it's clearly called out | 17:25 |
| mdbooth | It's got test_ in the name ;) | 17:26 |
| *** salv-orlando has joined #openstack-nova | 17:26 | |
| *** salv-orlando has quit IRC | 17:26 | |
| jaypipes | mdbooth: sorry, I just disagree on that. from a style and a code structure perspective, I think it's better to explicitly create test fixtures and expectations within the test itself. | 17:26 |
| mdbooth | jaypipes: We've also similar in a bunch of places. | 17:27 |
| mdbooth | jaypipes: Meh, ok. | 17:27 |
| jaypipes | mdbooth: can you point me to something similar please? | 17:27 |
| *** salv-orlando has joined #openstack-nova | 17:27 | |
| *** Apoorva has quit IRC | 17:27 | |
| mdbooth | jaypipes: I'm thinking class reset methods | 17:27 |
| mdbooth | functions which only exist so they can be unit tested | 17:28 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova master: Volume detach should have instance uuid https://review.openstack.org/511804 | 17:28 |
| mdbooth | functions which only exist so that can be mocked | 17:28 |
| jaypipes | mdbooth: that's a separate function. it's not changing a real function just for the purpose of testing. | 17:28 |
| mdbooth | I'm pretty sure I've also seen test only args | 17:28 |
| jaypipes | mdbooth: and we also discourage creating functions that exist only to be mocked. | 17:28 |
| dansmith | I too am interested, | 17:28 |
| mdbooth | It's a wart, but it allows code reuse. | 17:29 |
| dansmith | because I don't think that we do that anywhere I'm familiar with | 17:29 |
| sean-k-mooney2 | mdbooth: test only args kindo of defets the reason for testing | 17:29 |
| dansmith | yeah | 17:29 |
| mdbooth | Otherwise we just have to duplicate code | 17:29 |
| sean-k-mooney2 | mdbooth: you are not testing what runs in production | 17:29 |
| mdbooth | sean-k-mooney2: The use is to create something only for use in testing | 17:29 |
| mdbooth | So no, it doesn't run in production :) | 17:29 |
| mdbooth | sean-k-mooney2: In this case, it's to tweak a function to not default something which was formally not defaulted. | 17:30 |
| * mdbooth thinks it's a pragmatic wart | 17:30 | |
| mdbooth | Anyway, if it's not going to pass muster I'll change it | 17:30 |
| *** sambetts is now known as sambetts|afk | 17:31 | |
| *** ralonsoh has quit IRC | 17:31 | |
| *** salv-orlando has quit IRC | 17:32 | |
| sean-k-mooney2 | mdbooth: can you send me a link? | 17:32 |
| *** david-lyle has quit IRC | 17:32 | |
| mdbooth | https://review.openstack.org/#/c/242603/25/nova/db/sqlalchemy/api.py | 17:32 |
| *** hamzy has quit IRC | 17:32 | |
| *** david-lyle has joined #openstack-nova | 17:32 | |
| *** dtantsur is now known as dtantsur|afk | 17:33 | |
| mdbooth | That function is small enough the cut/pasting it into a test isn't entirely evil | 17:33 |
| sean-k-mooney2 | and why do you want to not see the uuid automatically? | 17:35 |
| mdbooth | sean-k-mooney2: So as to test upgrade of legacy objects which don't have it | 17:35 |
| sean-k-mooney2 | and you cant mock the call to uuidutils.generate_uuid() in that case to retrun None? | 17:36 |
| mdbooth | sean-k-mooney2: Cut/paste is less evil than that. | 17:36 |
| *** tssurya_ has quit IRC | 17:37 | |
| *** sshwarts has quit IRC | 17:41 | |
| *** gouthamr has joined #openstack-nova | 17:44 | |
| *** david-lyle has quit IRC | 17:45 | |
| *** rmart04 has joined #openstack-nova | 17:46 | |
| *** Kevin_Zheng has quit IRC | 17:46 | |
| *** tssurya_ has joined #openstack-nova | 17:47 | |
| mdbooth | dansmith: jaypipes So, I'm going to recut that second patch. No happy faces for https://review.openstack.org/#/c/242602/24, though ? | 17:47 |
| mdbooth | While I'm respinning anyway, that is. | 17:47 |
| *** rmart04 has left #openstack-nova | 17:47 | |
| mdbooth | It's the patch immediately before. | 17:48 |
| *** tssurya_ has quit IRC | 17:52 | |
| jaypipes | mdbooth: gimme a few | 17:52 |
| mdbooth | jaypipes: Thanks. | 17:53 |
| mdbooth | jaypipes: That patch version is mostly dansmith with some stuff deleted that we don't need any more. | 17:53 |
| jaypipes | mdbooth: in that case, automatic -2 from me | 17:53 |
| mdbooth | jaypipes: Understood. | 17:53 |
| jaypipes | hehe | 17:54 |
| mdbooth | Probably for the best. | 17:54 |
| jaypipes | :) | 17:54 |
| *** abhishekk has joined #openstack-nova | 17:54 | |
| *** abhishekk has quit IRC | 17:54 | |
| *** abhishekk has joined #openstack-nova | 17:58 | |
| *** derekh has quit IRC | 18:01 | |
| *** moshele has joined #openstack-nova | 18:04 | |
| mdbooth | Speaking of anti-patterns, btw: functions which modify their input parameters. I ran across a unit test last week which only passed because the method it called modified the dict it was given as well as its output, so the later assertion that the 2 were equal passed coincidentally. | 18:06 |
| mdbooth | If it had actually mattered, that would be pretty obtuse. | 18:06 |
| *** tesseract has quit IRC | 18:07 | |
| mdbooth | Common culprit is popping values from input dicts. | 18:07 |
| *** jroll has joined #openstack-nova | 18:10 | |
| *** salv-orlando has joined #openstack-nova | 18:10 | |
| sean-k-mooney2 | mdbooth: that depends on the fucntion. if the fucntion returned nothing the modifying the inpu arguments may be correct. like a sort fuction there are other exampels though | 18:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | 18:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 18:10 |
| edleafe | mriedem: ^^ Got these working. Now starting on your comments on https://review.openstack.org/#/c/511358/ | 18:11 |
| mdbooth | sean-k-mooney2: Right, if the purpose of the function is to modify its input parameters, that's different. | 18:11 |
| sean-k-mooney2 | mdbooth: though i do agreee that in general a fucntion should retrun someting or have sideefect but not both | 18:11 |
| *** david-lyle has joined #openstack-nova | 18:13 | |
| *** Apoorva has joined #openstack-nova | 18:15 | |
| *** Apoorva has quit IRC | 18:15 | |
| *** BryanS68 has quit IRC | 18:15 | |
| *** Apoorva has joined #openstack-nova | 18:15 | |
| *** BryanS68 has joined #openstack-nova | 18:16 | |
| mdbooth | jaypipes: So, I just realised that another reason to use an independent transaction in _create_uuid is that if it were ever called in the future in the context of a read transaction (because the caller is just reading from the db), it's going to be a failure because we can't promote a read transaction to a write transaction. | 18:17 |
| mdbooth | So basically, this only works robustly as long as we continue not using enginefacade | 18:17 |
| *** david-lyle has quit IRC | 18:18 | |
| *** david-lyle has joined #openstack-nova | 18:18 | |
| jaypipes | mdbooth: all the more reason to use enginefacade, no? :) | 18:18 |
| mdbooth | jaypipes: No, the exact opposite | 18:18 |
| mdbooth | If we were using enginefacade the way it was intended, i.e. to create larger-scoped transactionss | 18:19 |
| mdbooth | We'd be hitting bugs here | 18:19 |
| mdbooth | We're only relatively safe because we don't do that | 18:19 |
| mdbooth | Ideally something which might read a few bdms would have its own read transaction | 18:20 |
| mdbooth | Which covered all of them | 18:20 |
| mdbooth | Then suddenly one of them doesn't have a uuid and we need to do a write | 18:20 |
| mdbooth | This would fail, because we're in a read transaction. | 18:20 |
| *** dave-mccowan has quit IRC | 18:20 | |
| *** damien_r has joined #openstack-nova | 18:20 | |
| mdbooth | If we always do the write in an independent transaction, that doesn't matter | 18:21 |
| *** salv-orlando has quit IRC | 18:21 | |
| mdbooth | Actually, I wonder if we'd hit that in practise... | 18:21 |
| * mdbooth audits | 18:21 | |
| *** salv-orlando has joined #openstack-nova | 18:21 | |
| *** burt has joined #openstack-nova | 18:21 | |
| *** abhishekk has quit IRC | 18:22 | |
| *** yamamoto has joined #openstack-nova | 18:24 | |
| mdbooth | No, we currently still have separate micro-transactions everywhere | 18:24 |
| *** salv-orlando has quit IRC | 18:26 | |
| _ix | Hello again. I was curious about how to best segment my deployment. I'd like some hypervisors running off of rados block devices, and others running off of local ssd. Are availabiltiy zones what I'm looking for? | 18:26 |
| mdbooth | But if, for eg, we annotated BlockDeviceMapping.get_by_volume_id with @reader so that it fetched the joined instance in the same transaction as the bdm, that would be a bug. It would be pretty obtuse, though, because it's not at all obvious that _from_db_object can write | 18:27 |
| *** yamamoto has quit IRC | 18:30 | |
| _ix | I must be looking for host aggregates. | 18:30 |
| *** damien_r has quit IRC | 18:30 | |
| mdbooth | jaypipes: Nah, the comments are longer than the code. | 18:31 |
| mdbooth | s/code/code to fix the problems requiring comments/ | 18:31 |
| *** david-lyle has quit IRC | 18:33 | |
| sean-k-mooney2 | every time i read bdms i keep wanting to change it to dbms as i assume i reversed the letter because of my dyslexia | 18:33 |
| *** sahid has quit IRC | 18:36 | |
| *** gbarros has joined #openstack-nova | 18:38 | |
| jeblair | hi, we're looking at having nodepool ask nova for its quota periodically to make it more responsive to changes. does nova cache limit information for users (cores, ram, instances)? if so, what's a typical cache period? | 18:38 |
| melwitt | jeblair: I don't think limit info is cached | 18:40 |
| sean-k-mooney2 | melwitt: is limit info still stored in nova or is that contolled by keystone now for cores,ram and insances? | 18:42 |
| jaypipes | mdbooth: actually, decorating the _from_db_object() with the @writer context is actually a very *explicit* way of saying the expectations of that method. https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L902 | 18:42 |
| jaypipes | mdbooth: and functional tests of the data online migration will blow up nicely if it's set to @reader instead of @writer. | 18:43 |
| jaypipes | mdbooth: and blowing up is a good thing in this case... | 18:43 |
| mdbooth | jaypipes: Absolutely, but it's unnecessary except in this really weird edge case. | 18:43 |
| jaypipes | mdbooth: agreed | 18:43 |
| mdbooth | Which will go away... | 18:44 |
| jaypipes | mdbooth: thus the comments saying so :) | 18:44 |
| mdbooth | Except that now everything above it was unnecessarily promoted to writer | 18:44 |
| jaypipes | mdbooth: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L904-L905 | 18:44 |
| mdbooth | And now you have to go audit all the things to find out after the fact which ones were really supposed to be writers. | 18:44 |
| jaypipes | yeah, that's the tradeoff I suppose | 18:45 |
| *** hamzy has joined #openstack-nova | 18:45 | |
| *** moshele has quit IRC | 18:45 | |
| dansmith | sean-k-mooney2: still in our db | 18:45 |
| *** hamzy has quit IRC | 18:46 | |
| mdbooth | jaypipes: That races, btw | 18:46 |
| sean-k-mooney2 | dansmith: oh ok was i imagining that we wanted to move it to keystone at some point? | 18:46 |
| *** hamzy has joined #openstack-nova | 18:46 | |
| mdbooth | jaypipes: Concurrent reads can create different uuids | 18:47 |
| jeblair | melwitt: thanks, that's easy then :) | 18:47 |
| sean-k-mooney2 | mdbooth in which case it needs to be a writer lock no? | 18:49 |
| mdbooth | sean-k-mooney2: Doesn't matter, unless both prior reads are done with 'for update' (or equivalent) | 18:49 |
| mdbooth | Which I don't think they are | 18:50 |
| *** damien_r has joined #openstack-nova | 18:50 | |
| mdbooth | You'll get 2 reads of 2 null values. They'll race to update. The first will write a value and block the second one. When the first commits, the second will write its own different value. | 18:50 |
| mdbooth | Both functions will return objects with different uuids. | 18:51 |
| sean-k-mooney2 | mdbooth: what you effectivly want to do is have a cas so only one updates the record | 18:51 |
| sean-k-mooney2 | mdbooth: im guessing thats what 'for update' will give you | 18:52 |
| mdbooth | cas? | 18:52 |
| jaypipes | compare and swap | 18:52 |
| mdbooth | Ah, yeah | 18:52 |
| jaypipes | but we're overthinking this I think. | 18:52 |
| mdbooth | That's what I wrote | 18:52 |
| jaypipes | yeah, the update_with_match thing is the compare and swap | 18:52 |
| jaypipes | regardless... | 18:52 |
| mdbooth | https://review.openstack.org/#/c/242603/25/nova/objects/block_device.py | 18:52 |
| mdbooth | jaypipes: Thing is, if you overthink the building blocks, it means you don't need to overthink everything else. Not so much, anyway. | 18:54 |
| mdbooth | The caller doesn't need to be concerned with all these weird edge cases. It just works. | 18:54 |
| *** rmart04 has joined #openstack-nova | 18:56 | |
| *** esberglu has quit IRC | 18:56 | |
| *** sridharg has quit IRC | 18:59 | |
| openstackgerrit | Merged openstack/nova master: Fix doubling allocations on rebuild https://review.openstack.org/521662 | 19:00 |
| zzzeek | mdbooth / jaypipes the retry decorartor is wanting, IMO | 19:01 |
| zzzeek | there was originally some idea to integrate one into enginefacade itself so that it knows how to nest | 19:02 |
| mdbooth | zzzeek: Could you use a savepoint for this, btw? | 19:02 |
| * mdbooth isn't entirely sure how they work | 19:02 | |
| zzzeek | mdbooth: not if you're looking to respond to other transactions also making changes b.c. isolation may prevent you from seeing those changes | 19:03 |
| zzzeek | for an UPDATE i think repeatable read would mean you can't see another transactions updates | 19:03 |
| mdbooth | zzzeek: Anyway, my approach was to use an independent transaction context explicitly. I figured this would always be safe. | 19:05 |
| *** gbarros has quit IRC | 19:05 | |
| mdbooth | Then I was convinced it wasn't worth writing slight weird code for an extremely obtuse edge case where failure was safe. | 19:06 |
| zzzeek | mdbooth: i think you are correct assuming that record is not part of the external tranasction. pre-enginefacade nova was all independent transactions. | 19:06 |
| mdbooth | But then I flipped again because I figured this is a read transaction which only needs to write in an edge case (migrating a legacy record). | 19:06 |
| mdbooth | So having an independent transaction is useful to avoid forcing the enclosing transaction and all its potential parents to become writers. | 19:07 |
| *** READ10 has quit IRC | 19:07 | |
| mdbooth | And that's where I am now. | 19:08 |
| *** sree has joined #openstack-nova | 19:09 | |
| zzzeek | mdbooth: i think leave it and goad me into working up a better retry situation for enginefacade | 19:10 |
| mdbooth | zzzeek: So all of the above is in the context of code we'd want to delete next cycle anyway, as it's only for a migration :) | 19:11 |
| mdbooth | Well cycle +1, because the online migration runs it too. | 19:11 |
| zzzeek | mdbooth: nova's magical migrations...sure | 19:11 |
| zzzeek | mdbooth: sure | 19:11 |
| zzzeek | mdbooth: this is not the most concerning thing to me :) | 19:12 |
| mdbooth | I think it's fine, tbh. I also doubt that many of nova's uses of the retry wrapper are a problem today, because we don't nest many transactions. | 19:13 |
| mdbooth | It would be a bigger problem if we made wider use of the enginefacade | 19:13 |
| *** sree has quit IRC | 19:13 | |
| * mdbooth has to run | 19:14 | |
| mdbooth | jaypipes: Thanks again | 19:14 |
| *** erlon has quit IRC | 19:17 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 19:22 |
| *** esberglu has joined #openstack-nova | 19:24 | |
| *** dave-mccowan has joined #openstack-nova | 19:25 | |
| *** yamamoto has joined #openstack-nova | 19:26 | |
| *** gbarros has joined #openstack-nova | 19:30 | |
| *** faridda has quit IRC | 19:30 | |
| *** yamamoto has quit IRC | 19:31 | |
| *** harlowja has quit IRC | 19:32 | |
| cdent | can someone besides mriedem put some eyes on https://review.openstack.org/#/c/523403/ is an auth config error that would be useful to backport. dansmith, jaypipes ? | 19:33 |
| efried | cdent Patches are passing with your grenade fix - thanks for that. | 19:33 |
| cdent | huzzah | 19:34 |
| mriedem | cdent: i think melwitt enjoys auth config bug fixes | 19:34 |
| melwitt | I totally do | 19:34 |
| cdent | ah yes melwitt would be a fine choice | 19:35 |
| cdent | apologies had not hear you around recently | 19:35 |
| *** moshele has joined #openstack-nova | 19:35 | |
| cdent | whereas dansmith and jaypipes … | 19:35 |
| efried | cdent Is the kwarg really called oslo_config_config? | 19:35 |
| cdent | yeah, isn’t that awesome, there are a few different olso_config_* | 19:36 |
| *** harlowja has joined #openstack-nova | 19:36 | |
| efried | whee | 19:36 |
| cdent | I think it is to try to be explicit about the fact that it can also accept keyword arguments which are configuration keys and values | 19:37 |
| cdent | a sort of namespacing | 19:38 |
| * cdent seems to recall writing at least some of that code, from way back in the ceilometer days | 19:38 | |
| *** mvk has joined #openstack-nova | 19:39 | |
| sean-k-mooney2 | cdent: we were going to do something similar with networking-ovs-dpdk devstack setting then reallised that would haver ment setting OVS_DPDK_OVS_REPO AND OVS_DPDK_DPDK_REPO so decided not to prepend everyting with OVS_DPDK | 19:41 |
| cdent | oh my | 19:42 |
| sean-k-mooney2 | we still have pretty verbose setting without that https://github.com/openstack/networking-ovs-dpdk/blob/master/devstack/settings | 19:42 |
| efried | cdent Left a comment on that patch. Is there a reason we would need to keep that arg? | 19:42 |
| cdent | efried: because we don’t know who might have use the deploy() method in the past | 19:43 |
| cdent | that’s how you build a custom wsgi application, if you’re so inclined | 19:44 |
| efried | cdent Is it somehow public? | 19:44 |
| cdent | it is public by virtue of being python | 19:44 |
| efried | What I mean is, is it used by some known external entity that we care about? | 19:44 |
| cdent | and in the early days of placement was the entry point to the wsgi application stack until sean added the stuff in wsgi.py | 19:44 |
| cdent | the point is that we don’t know | 19:44 |
| efried | But we care? | 19:45 |
| cdent | yes, of course | 19:45 |
| efried | Oh, not of course. | 19:45 |
| cdent | the whole point of a wsgi application is to be able to integrate it in whatever way you want | 19:45 |
| efried | Nova changes "public APIs" like ComputeDriver all the time without worrying about external consumption. | 19:45 |
| sean-k-mooney2 | was it ever the entrypoint in a version of the placement api that shipped in a release | 19:45 |
| efried | And when I've asked about that before, it was basically explained away to "we don't care". | 19:46 |
| efried | So in this case, why do we care? | 19:46 |
| cdent | sean-k-mooney2: a) I _think_ so but am not certain, b) it has always been my intent that deploy be available as a public interface | 19:46 |
| cdent | because placement is not nova? | 19:46 |
| cdent | it has a _much_ different attitude towards building the wsgi application than the nova-api ever did | 19:46 |
| sean-k-mooney2 | cdent: well if that was the intent then we should treat it as public and document that fact. | 19:47 |
| cdent | I think I probably made the mistake of assuming that was somehow obvious, by virtue of its position in the wsgi stack, but I think I may be one of the few people around here who think of the wsgi stack in that fashion | 19:48 |
| cdent | we can certainly document it as such | 19:48 |
| cdent | efried: would your preference be that I add that documentation to that patch now, or is it cool to worry about it later? | 19:49 |
| efried | Later is fine. | 19:49 |
| efried | cdent Changed sides. | 19:50 |
| cdent | thanks, I’ll do the documenting likely tomorrow, I think I’m out of code mode for today | 19:51 |
| cdent | also, all my promises to myself to not work late tonight seem to be for naught | 19:51 |
| sean-k-mooney2 | cdent: your based in the uk right? | 19:52 |
| cdent | yeah | 19:52 |
| cdent | and I often work this late, but last night I worked past midnight | 19:52 |
| cdent | so was going to give myself a break | 19:52 |
| cdent | but everybody here was just too interesting today | 19:52 |
| sean-k-mooney2 | i have a daily reminder to head home at 8 so im normally here till around now too. | 19:53 |
| cdent | as it is 5 to 8 I think I’ll go, have a good night every one | 19:56 |
| *** cdent has quit IRC | 19:56 | |
| *** Sandy619 has joined #openstack-nova | 19:56 | |
| *** smatzek has quit IRC | 20:08 | |
| melwitt | mriedem: in case you didn't see, I had posted a follow up for the old quotas code removal that we talked about some days ago https://review.openstack.org/#/c/524234 | 20:09 |
| *** smatzek has joined #openstack-nova | 20:10 | |
| *** smatzek_ has joined #openstack-nova | 20:12 | |
| melwitt | although I think I just realized an issue with it and commented | 20:12 |
| mriedem | lgtm | 20:12 |
| mriedem | oh right | 20:13 |
| mriedem | gawd | 20:13 |
| melwitt | yeah. guh | 20:14 |
| *** smatzek has quit IRC | 20:14 | |
| mriedem | https://review.openstack.org/#/c/400384/ | 20:15 |
| melwitt | I need to add some kind of equivalent test to the API tests somewhere. the api samples test cover the presence of the 'reserved' key but not the expected value if no-op quotas | 20:15 |
| mriedem | well, | 20:16 |
| mriedem | easiest is probably an api samples test with the noop quota driver and it's own samples | 20:16 |
| melwitt | lemme see if I can do that | 20:23 |
| openstackgerrit | Hongbin Lu proposed openstack/nova master: Add support for listing hosts in cellv2 https://review.openstack.org/524755 | 20:25 |
| *** smatzek_ has quit IRC | 20:27 | |
| *** yamamoto has joined #openstack-nova | 20:27 | |
| *** smatzek has joined #openstack-nova | 20:29 | |
| *** smatzek has quit IRC | 20:29 | |
| *** smatzek has joined #openstack-nova | 20:30 | |
| *** pchavva has quit IRC | 20:31 | |
| *** dtantsur|afk has quit IRC | 20:31 | |
| *** ttsiouts has quit IRC | 20:31 | |
| *** brault has quit IRC | 20:31 | |
| *** mhenkel has quit IRC | 20:31 | |
| *** purplerbot has quit IRC | 20:31 | |
| *** Anticime1 has quit IRC | 20:31 | |
| *** jdurgin has quit IRC | 20:31 | |
| *** fmccrthy has quit IRC | 20:31 | |
| *** fyxim has quit IRC | 20:31 | |
| *** zhenguo has quit IRC | 20:31 | |
| *** dgonzalez has quit IRC | 20:31 | |
| *** khappone has quit IRC | 20:31 | |
| *** raorn has quit IRC | 20:31 | |
| *** sgordon has quit IRC | 20:31 | |
| *** moshele has quit IRC | 20:31 | |
| *** dave-mccowan has quit IRC | 20:31 | |
| *** chyka has quit IRC | 20:31 | |
| *** hongbin has quit IRC | 20:31 | |
| *** gyee has quit IRC | 20:31 | |
| *** awaugama has quit IRC | 20:31 | |
| *** jmlowe has quit IRC | 20:31 | |
| *** Eran_Kuris has quit IRC | 20:31 | |
| *** xinliang has quit IRC | 20:31 | |
| *** rocky-shiyan has quit IRC | 20:31 | |
| *** ekhugen_alt has quit IRC | 20:31 | |
| *** pprokop has quit IRC | 20:31 | |
| *** MasterofJOKers has quit IRC | 20:31 | |
| *** larainema has quit IRC | 20:31 | |
| *** FL1SK has quit IRC | 20:31 | |
| *** jroll has quit IRC | 20:31 | |
| *** yamamoto has quit IRC | 20:32 | |
| *** syjulian has joined #openstack-nova | 20:38 | |
| *** mikal has quit IRC | 20:38 | |
| *** itlinux has quit IRC | 20:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add new style volume attachment support to block_device.py https://review.openstack.org/525787 | 20:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 20:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 20:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 20:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid stashed connector lookup for new style detach https://review.openstack.org/526182 | 20:41 |
| *** mikal has joined #openstack-nova | 20:43 | |
| *** lpetrut has quit IRC | 20:45 | |
| efried | jaypipes I seem to have flubbed https://review.openstack.org/#/c/521605/ which was supposed to be two separate commits (one to add agg stuff to ProviderTree, one to add traits stuff). | 20:46 |
| efried | jaypipes I was about to split it up, but thought I should ask you whether it's worth bothering | 20:47 |
| *** pchavva has joined #openstack-nova | 20:47 | |
| *** dtantsur|afk has joined #openstack-nova | 20:47 | |
| *** ttsiouts has joined #openstack-nova | 20:47 | |
| *** brault has joined #openstack-nova | 20:47 | |
| *** mhenkel has joined #openstack-nova | 20:47 | |
| *** purplerbot has joined #openstack-nova | 20:47 | |
| *** Anticime1 has joined #openstack-nova | 20:47 | |
| *** jdurgin has joined #openstack-nova | 20:47 | |
| *** fyxim has joined #openstack-nova | 20:47 | |
| *** fmccrthy has joined #openstack-nova | 20:47 | |
| *** zhenguo has joined #openstack-nova | 20:47 | |
| *** dgonzalez has joined #openstack-nova | 20:47 | |
| *** khappone has joined #openstack-nova | 20:47 | |
| *** raorn has joined #openstack-nova | 20:47 | |
| *** sgordon has joined #openstack-nova | 20:47 | |
| efried | jaypipes i.e. should I just do both in one change set? | 20:47 |
| *** moshele has joined #openstack-nova | 20:47 | |
| *** dave-mccowan has joined #openstack-nova | 20:47 | |
| *** jroll has joined #openstack-nova | 20:47 | |
| *** chyka has joined #openstack-nova | 20:47 | |
| *** hongbin has joined #openstack-nova | 20:47 | |
| *** gyee has joined #openstack-nova | 20:47 | |
| *** jmlowe has joined #openstack-nova | 20:47 | |
| *** Eran_Kuris has joined #openstack-nova | 20:47 | |
| *** xinliang has joined #openstack-nova | 20:47 | |
| *** rocky-shiyan has joined #openstack-nova | 20:47 | |
| *** ekhugen_alt has joined #openstack-nova | 20:47 | |
| *** pprokop has joined #openstack-nova | 20:47 | |
| *** MasterofJOKers has joined #openstack-nova | 20:47 | |
| *** larainema has joined #openstack-nova | 20:47 | |
| *** FL1SK has joined #openstack-nova | 20:47 | |
| *** faridda has joined #openstack-nova | 20:50 | |
| *** moshele has quit IRC | 20:51 | |
| *** itlinux has joined #openstack-nova | 20:53 | |
| *** harlowja has quit IRC | 21:00 | |
| *** liverpooler has quit IRC | 21:02 | |
| *** harlowja has joined #openstack-nova | 21:03 | |
| mriedem | ildikov: ok, final comments in https://review.openstack.org/#/c/330285/173 | 21:03 |
| mriedem | ildikov: easy things to address and then i'm ready to go on that | 21:03 |
| ildikov | mriedem: ok | 21:04 |
| mriedem | we'll have to decide if we hold it for the shared_targets microversion in cinder | 21:04 |
| *** smatzek has quit IRC | 21:04 | |
| ildikov | mriedem: let me ask Jay about the client | 21:04 |
| *** smatzek has joined #openstack-nova | 21:04 | |
| *** smatzek has quit IRC | 21:04 | |
| ildikov | mriedem: as for the new attach patch, did you mean I should take over on those? | 21:05 |
| mriedem | ildikov: i was thinking, in the api change to support multiattach, if/when we check the volume to see if it's multiattach=True, couldn't we just check the cinder microversion at that point if the volume already has >0 attachments? | 21:05 |
| ildikov | mriedem: I haven't touched the API patch in almost years now | 21:05 |
| mriedem | basically, nova api can't attach a multiattach volume to >1 instance until we are sure we can get shared_targets info | 21:05 |
| ildikov | mriedem: so I will take a look shortly and figure out | 21:05 |
| mriedem | ok | 21:05 |
| ildikov | I didn't want to keep those checks, those are from the ancient times | 21:06 |
| mriedem | i can update https://review.openstack.org/#/c/330285/173 quick | 21:06 |
| mriedem | and then i'm done with it i think | 21:06 |
| ildikov | another question is whether it's ok to do the lock for detach in a separate patch? | 21:06 |
| ildikov | so we could land the libvirt change and then the lock and then the API | 21:06 |
| mriedem | if it's a separate patch, it has to come before we start multiattaching things | 21:06 |
| mriedem | oh, | 21:06 |
| ildikov | also, we will bump a microversion for this, right? | 21:06 |
| mriedem | as long as we don't turn on multiattach until the parts in the compute are ready | 21:07 |
| mriedem | i think we can do that | 21:07 |
| mriedem | i think we will bump a microversion as an indication of multiattach yes | 21:07 |
| *** dtruong has joined #openstack-nova | 21:07 | |
| mriedem | i thought we updated the spec about that | 21:07 |
| ildikov | ok, so we will need an API level check whether the volume is attached already or not independently from Cinder | 21:07 |
| mriedem | oh it's a todo https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/cinder-volume-multi-attach.html#rest-api-impact | 21:07 |
| mriedem | "Whether or not a new compute API microversion is needed will be determined during implementation and code review. API users will need some way to discover if they can perform volume multiattach and a microversion might be the signal, but it is unclear if Nova would block those requests on a lower microversion, e.g. 2.1. It probably makes sense to do a microversion like 2.49 for tagged attach capabilities." | 21:08 |
| *** salv-orlando has joined #openstack-nova | 21:08 | |
| ildikov | yeah, we were a bit hesitant | 21:08 |
| ildikov | and it'll kinda require another check_attach too as basically that's what turns multi-attach on on the Nova side | 21:09 |
| ildikov | every other check is in CInder | 21:09 |
| ildikov | the libvirt change is supposed to be harmless as it plays with things only for multi-attach volumes on intention, but it doesn't do any attaching related stuff | 21:10 |
| *** yamahata has joined #openstack-nova | 21:10 | |
| *** inara has quit IRC | 21:10 | |
| *** sree has joined #openstack-nova | 21:10 | |
| ildikov | just turns on the shareable flag and adds the capabilities info | 21:10 |
| *** inara has joined #openstack-nova | 21:10 | |
| *** itlinux has quit IRC | 21:13 | |
| *** sree has quit IRC | 21:14 | |
| *** salv-orlando has quit IRC | 21:16 | |
| *** salv-orlando has joined #openstack-nova | 21:17 | |
| *** salv-orlando has quit IRC | 21:21 | |
| *** rmart04 has quit IRC | 21:22 | |
| *** edand has quit IRC | 21:22 | |
| ildikov | mriedem: so will you upload any more versions, or it's on me now? I got lost on that one. | 21:25 |
| *** itlinux has joined #openstack-nova | 21:26 | |
| *** yamahata has quit IRC | 21:27 | |
| mriedem | i'm doing it | 21:28 |
| *** yamamoto has joined #openstack-nova | 21:28 | |
| ildikov | mriedem: cool, tnx | 21:29 |
| ildikov | mriedem: replied to your comments | 21:29 |
| *** liusheng has joined #openstack-nova | 21:30 | |
| *** pchavva has quit IRC | 21:30 | |
| ildikov | mriedem: as we're adding a new API microversion I think we can land this and deal with the new Cinder microversion in the multi-attach change | 21:30 |
| *** yikun has joined #openstack-nova | 21:31 | |
| ildikov | mriedem: as we will need to do some extra checks for that anyway therefore we might as well add the new Cinder microversion to that one | 21:31 |
| mriedem | i tend to agree, | 21:31 |
| ildikov | mriedem: we can do a version check now independently from the attachment_create call so that's not an issue either | 21:31 |
| mriedem | especially since the point of microversions is that the client can opt into whatever they want when it's available (or not) | 21:31 |
| mriedem | and in this case, nova is the client | 21:31 |
| *** harlowja has quit IRC | 21:32 | |
| mriedem | so we just won't support a multiattach volume to >1 instance if the new cinder microversion for shared_targets isn't htere | 21:32 |
| mriedem | because we won't be able to safely detach | 21:32 |
| ildikov | yeah, true, I just wanted to avoid the check_attach-like checks as much as possible, but the API microversion in Nova will require that anyway | 21:32 |
| *** tidwellr has quit IRC | 21:32 | |
| ildikov | yep | 21:32 |
| mriedem | well, the compute microversoin is mainly just a signal | 21:33 |
| *** tidwellr has joined #openstack-nova | 21:33 | |
| ildikov | I mean the Nova API microversion | 21:33 |
| mriedem | 'i want to attach this multiattach volume to >1 instance and i'm opting into that, but i know it might not work too' | 21:33 |
| *** yamamoto has quit IRC | 21:33 | |
| mriedem | might not work b/c (1) old cinder (2) old computes (3) policy (4) virt driver doesn't support it (5) volume type doens't support it, etc | 21:34 |
| mriedem | (6) uranus is not aligned with pluto | 21:34 |
| ildikov | yeah, if Cinder is mid-old then they will not be able to create a multi-attach volume on the first place | 21:34 |
| ildikov | lol | 21:34 |
| ildikov | I hope I | 21:34 |
| ildikov | 'll never need to debug (6) :) | 21:35 |
| ildikov | anyway, so if we don't want to hold the new attach patch now we can just check whether the volume is already attached and continue if the Cinder microversion is high enough | 21:36 |
| *** gouthamr has quit IRC | 21:36 | |
| *** abalutoiu has joined #openstack-nova | 21:36 | |
| ildikov | however the new flow currently doesn't allow multi-attach in general so we might not need that check | 21:38 |
| *** sdague has joined #openstack-nova | 21:38 | |
| *** AlexeyAbashkin has joined #openstack-nova | 21:38 | |
| *** openstackgerrit has quit IRC | 21:38 | |
| *** _pewp_ has quit IRC | 21:38 | |
| *** tlbr has quit IRC | 21:38 | |
| *** SamYaple has quit IRC | 21:38 | |
| *** lyarwood has quit IRC | 21:38 | |
| *** gryf has quit IRC | 21:38 | |
| *** ericyoung has quit IRC | 21:38 | |
| *** lifeless has quit IRC | 21:38 | |
| *** mfisch has quit IRC | 21:38 | |
| *** afazekas has quit IRC | 21:38 | |
| *** diegows has quit IRC | 21:38 | |
| *** antonym has quit IRC | 21:38 | |
| *** david-lyle has joined #openstack-nova | 21:39 | |
| ildikov | I need to think about it, but the point is still that I think we all had enough of this patch by now... | 21:39 |
| mriedem | incoming | 21:41 |
| mriedem | or not | 21:41 |
| mriedem | anyway, new patches are up | 21:41 |
| mriedem | https://review.openstack.org/#/c/330285/174/releasenotes/notes/bp-cinder-new-attach-apis-eca854e27a255e3e.yaml is the reno i added | 21:41 |
| ildikov | mriedem: looks good to me | 21:43 |
| ildikov | not that I would've worded anything so far good enough to judge, but still :) | 21:43 |
| *** liverpooler has joined #openstack-nova | 21:44 | |
| mriedem | +2 on the new attach flow patch | 21:45 |
| mriedem | i think johnthetubaguy is on paternity leave | 21:45 |
| mriedem | so we'll likely need gibi and/or melwitt to go through this | 21:45 |
| ildikov | mriedem: wow, we haven't even reach 200... :) | 21:46 |
| edleafe | so it looks like I need to rebase my series. Will that kill the patches that are in the gate? | 21:46 |
| mriedem | edleafe: i can re-approve | 21:46 |
| ildikov | mriedem: gibi is familiar with the patch, but he might not familiar with the whole Cinder-side new flow to +A this | 21:47 |
| *** david-lyle has quit IRC | 21:47 | |
| mriedem | ildikov: i don't think anyone from nova besides john will be | 21:47 |
| ildikov | mriedem: can check with him tomorrow or look at melwitt with cat eyes from Shrek :) | 21:47 |
| ildikov | mriedem: I know, I'm here if anyone wants to ask questions | 21:48 |
| mriedem | at this point i think i can answer any questions on the nova patches | 21:48 |
| edleafe | mriedem: sure, but won't that mean restarting the whole CI process? They are mostly through the gate now. | 21:48 |
| mriedem | edleafe: yes if they are rebased | 21:48 |
| *** SamYaple has joined #openstack-nova | 21:49 | |
| edleafe | ok, then I'll wait | 21:49 |
| ildikov | mriedem: if I could have just 1/10 of your brain :) | 21:50 |
| *** gszasz has quit IRC | 21:54 | |
| *** smatzek has joined #openstack-nova | 21:55 | |
| melwitt | ildikov: if gibi is already familiar with the patch, check with him first. if he won't be able to look, let me know and I'll look at it | 21:55 |
| *** damien_r has quit IRC | 21:55 | |
| mriedem | melwitt: the bottom 2 patches in the series are non-destructive. | 21:55 |
| mriedem | i.e. they lay some groundwork but aren't run through until the 3rd in the series | 21:56 |
| mriedem | turns it all on | 21:56 |
| mriedem | the first patch is a straight up simple refactor, no functional change | 21:56 |
| melwitt | ah, okay | 21:56 |
| ildikov | melwitt: I will check with him tomorrow on the Implement new attach Cinder flow patch | 21:56 |
| ildikov | melwitt: if you can look into the two under it that mriedem mentioned that would be pretty great | 21:57 |
| melwitt | k, can do | 21:57 |
| *** itlinux has quit IRC | 21:59 | |
| melwitt | grrr something weird is going on in the api sample tests I'm trying to do for noop quotas. when I set the noop driver in a derived test class, it seems to leak into the parent class tests where I didn't set it | 21:59 |
| *** smatzek has quit IRC | 21:59 | |
| ildikov | melwitt: I had that with a mocked value earlier... | 22:01 |
| *** openstackgerrit has joined #openstack-nova | 22:01 | |
| *** _pewp_ has joined #openstack-nova | 22:01 | |
| *** tlbr has joined #openstack-nova | 22:01 | |
| *** lyarwood has joined #openstack-nova | 22:01 | |
| *** gryf has joined #openstack-nova | 22:01 | |
| *** ericyoung has joined #openstack-nova | 22:01 | |
| *** lifeless has joined #openstack-nova | 22:01 | |
| *** mfisch has joined #openstack-nova | 22:01 | |
| *** afazekas has joined #openstack-nova | 22:01 | |
| *** diegows has joined #openstack-nova | 22:01 | |
| *** antonym has joined #openstack-nova | 22:01 | |
| *** rcernin has joined #openstack-nova | 22:01 | |
| ildikov | not 100% sure on the reason still, setting up the mock in a different way helped there | 22:02 |
| *** rcernin has quit IRC | 22:03 | |
| *** rcernin has joined #openstack-nova | 22:03 | |
| *** smatzek has joined #openstack-nova | 22:08 | |
| *** moshele has joined #openstack-nova | 22:10 | |
| *** takashin has joined #openstack-nova | 22:11 | |
| *** smatzek has quit IRC | 22:13 | |
| *** BryanS68 has quit IRC | 22:24 | |
| *** yassine has joined #openstack-nova | 22:26 | |
| *** salv-orlando has joined #openstack-nova | 22:27 | |
| *** yassine is now known as Guest99196 | 22:27 | |
| *** gouthamr has joined #openstack-nova | 22:28 | |
| *** yamamoto has joined #openstack-nova | 22:30 | |
| *** salv-orlando has quit IRC | 22:32 | |
| _ix | Hello again. I'm having some trouble creating a larger node on my new pike deployment. | 22:35 |
| *** yamamoto has quit IRC | 22:35 | |
| _ix | Any tips on where I ought to look to get around this dreadful 'No valid host was found. There are not enough hosts available' error? | 22:35 |
| *** harlowja has joined #openstack-nova | 22:36 | |
| _ix | It's a 10vcpu 112gb 20gb root and 3000gb machine. I've definitely got the resources. | 22:36 |
| efried | _ix The compute log is where I would start. | 22:36 |
| *** tidwellr has quit IRC | 22:36 | |
| _ix | The request doesn't seem to be making it to the compute log. | 22:37 |
| efried | okay, have you checked the sched or conductor logs? | 22:37 |
| melwitt | in that case, I suggest turning on log level debug on the scheduler node, restart scheduler, try it again and check the scheduler log to see which filter is blocking the request out | 22:37 |
| *** lyan has quit IRC | 22:38 | |
| _ix | Thanks. I'll give that a shot. | 22:38 |
| *** AlexeyAbashkin has quit IRC | 22:43 | |
| *** Tom-Tom has quit IRC | 22:43 | |
| _ix | I'm trying to force the build on a single host... but it says it can't find it. | 22:48 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Traits ops on ProviderTree https://review.openstack.org/521605 | 22:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move aggregates from report client to ProviderTree https://review.openstack.org/521685 | 22:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track provider traits in report client https://review.openstack.org/521686 | 22:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Aggregate ops on ProviderTree https://review.openstack.org/526216 | 22:49 |
| _ix | I'll keep plugging away at this. Thanks again for the suggestions. | 22:52 |
| *** gouthamr has quit IRC | 22:53 | |
| *** faridda has quit IRC | 22:55 | |
| *** gouthamr has joined #openstack-nova | 22:56 | |
| *** salv-orlando has joined #openstack-nova | 22:57 | |
| melwitt | _ix: how are you forcing to a host? like this? https://ask.openstack.org/en/question/47877/how-to-launch-an-instance-on-specific-host/ | 23:00 |
| _ix | Just like that, only with the openstack server create instead. | 23:01 |
| _ix | I found my issue. It's me. It's always me. | 23:01 |
| mriedem | yikun: you might consider splitting the DB API and object changes out of this https://review.openstack.org/#/c/326326/ into a separate patch so the patch with the API changes is not so big | 23:02 |
| melwitt | _ix: okay. I was just gonna say that doing that bypasses the scheduler so the scheduler log might not show much if anything | 23:02 |
| *** salv-orlando has quit IRC | 23:05 | |
| *** burt has quit IRC | 23:05 | |
| _ix | Haven't looked into this just yet... A CPU model name should not be set when a host CPU model is requested | 23:05 |
| _ix | Oh well, I've got to detach for a few. Have a pleasant day! | 23:05 |
| *** salv-orlando has joined #openstack-nova | 23:05 | |
| *** mriedem has quit IRC | 23:10 | |
| *** salv-orlando has quit IRC | 23:10 | |
| *** tbachman has quit IRC | 23:15 | |
| openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | 23:17 |
| *** mlavalle has quit IRC | 23:21 | |
| *** amodi has quit IRC | 23:21 | |
| *** david-lyle has joined #openstack-nova | 23:22 | |
| *** _ix has quit IRC | 23:22 | |
| *** Sandy619 has quit IRC | 23:25 | |
| *** _ix has joined #openstack-nova | 23:27 | |
| *** openstack has joined #openstack-nova | 23:29 | |
| *** ChanServ sets mode: +o openstack | 23:29 | |
| *** takedakn has joined #openstack-nova | 23:30 | |
| *** yamamoto has joined #openstack-nova | 23:32 | |
| *** gmann_afk is now known as gmann | 23:33 | |
| *** takedakn has quit IRC | 23:34 | |
| *** moshele has quit IRC | 23:36 | |
| *** yamamoto has quit IRC | 23:37 | |
| *** edmondsw has joined #openstack-nova | 23:42 | |
| *** sdague has quit IRC | 23:42 | |
| *** tbachman has joined #openstack-nova | 23:44 | |
| *** david-lyle has quit IRC | 23:44 | |
| *** armax has quit IRC | 23:45 | |
| *** salv-orlando has joined #openstack-nova | 23:46 | |
| *** Tom-Tom has joined #openstack-nova | 23:47 | |
| *** tbachman_ has joined #openstack-nova | 23:48 | |
| *** tbachman has quit IRC | 23:49 | |
| *** tbachman_ is now known as tbachman | 23:49 | |
| *** salv-orlando has quit IRC | 23:50 | |
| *** salv-orlando has joined #openstack-nova | 23:51 | |
| *** salv-orlando has quit IRC | 23:55 | |
| *** david-lyle has joined #openstack-nova | 23:57 | |
| *** esberglu has quit IRC | 23:57 | |
| *** salv-orlando has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!