| *** dave-mccowan has quit IRC | 00:00 | |
| *** catintheroof has quit IRC | 00:00 | |
| *** catintheroof has joined #openstack-nova | 00:00 | |
| *** dave-mccowan has joined #openstack-nova | 00:01 | |
| *** chyka has quit IRC | 00:04 | |
| *** catintheroof has quit IRC | 00:04 | |
| *** yangyapeng has quit IRC | 00:07 | |
| *** yangyapeng has joined #openstack-nova | 00:07 | |
| *** baoli has quit IRC | 00:08 | |
| *** yangyapeng has quit IRC | 00:08 | |
| *** yangyapeng has joined #openstack-nova | 00:08 | |
| *** yangyapeng has quit IRC | 00:13 | |
| *** edmondsw has joined #openstack-nova | 00:13 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | 00:14 |
|---|---|---|
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 00:14 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 00:14 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | 00:14 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 00:14 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Make conductor pass and use host_lists https://review.openstack.org/511358 | 00:14 |
| *** salv-orlando has joined #openstack-nova | 00:17 | |
| *** markvoelker_ has quit IRC | 00:17 | |
| *** edmondsw has quit IRC | 00:18 | |
| *** wasmum has quit IRC | 00:19 | |
| *** salv-orlando has quit IRC | 00:22 | |
| *** yamamoto has joined #openstack-nova | 00:24 | |
| *** markvoelker has joined #openstack-nova | 00:25 | |
| *** yingjun has joined #openstack-nova | 00:26 | |
| *** yamamoto has quit IRC | 00:29 | |
| *** markvoelker has quit IRC | 00:29 | |
| *** vladikr has quit IRC | 00:29 | |
| *** esberglu has joined #openstack-nova | 00:30 | |
| *** markvoelker has joined #openstack-nova | 00:34 | |
| *** psachin has joined #openstack-nova | 00:38 | |
| *** markvoelker has quit IRC | 00:39 | |
| openstackgerrit | Merged openstack/nova master: Regenerate context during targeting https://review.openstack.org/511651 | 00:42 |
| *** markvoelker has joined #openstack-nova | 00:43 | |
| *** Swami has quit IRC | 00:43 | |
| *** Apoorva_ has joined #openstack-nova | 00:44 | |
| *** esberglu has quit IRC | 00:45 | |
| *** markvoelker has quit IRC | 00:48 | |
| *** Apoorva has quit IRC | 00:48 | |
| *** huanxie has joined #openstack-nova | 00:48 | |
| *** AlexeyAbashkin has joined #openstack-nova | 00:48 | |
| *** Apoorva_ has quit IRC | 00:48 | |
| *** jichen has joined #openstack-nova | 00:51 | |
| *** AlexeyAbashkin has quit IRC | 00:52 | |
| *** markvoelker has joined #openstack-nova | 00:52 | |
| *** jichen_ has joined #openstack-nova | 00:53 | |
| *** mriedem1 has joined #openstack-nova | 00:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Regenerate context during targeting https://review.openstack.org/512456 | 00:55 |
| mriedem1 | dansmith: ^ | 00:55 |
| *** mriedem has quit IRC | 00:55 | |
| *** mriedem1 is now known as mriedem | 00:55 | |
| *** jichen has quit IRC | 00:56 | |
| *** jichen_ is now known as jichen | 00:56 | |
| *** markvoelker has quit IRC | 00:57 | |
| jichen | mriedem: hi, could you please let us know whether we need additional work for https://review.openstack.org/#/c/464915/? almost deadline for spec now..... thanks | 00:59 |
| *** edmondsw has joined #openstack-nova | 01:00 | |
| *** markvoelker has joined #openstack-nova | 01:01 | |
| *** Shunli has joined #openstack-nova | 01:03 | |
| *** sree has joined #openstack-nova | 01:04 | |
| *** phuongnh has joined #openstack-nova | 01:04 | |
| *** tbachman has joined #openstack-nova | 01:05 | |
| *** markvoelker has quit IRC | 01:06 | |
| *** jwcroppe has quit IRC | 01:08 | |
| *** sree has quit IRC | 01:08 | |
| mriedem | jichen: comments inline | 01:08 |
| jichen | mriedem: ok, thanks, I will update it right now | 01:09 |
| *** markvoelker has joined #openstack-nova | 01:11 | |
| *** jwcroppe has joined #openstack-nova | 01:11 | |
| *** markvoelker has quit IRC | 01:15 | |
| *** yangyapeng has joined #openstack-nova | 01:17 | |
| *** salv-orlando has joined #openstack-nova | 01:18 | |
| *** catintheroof has joined #openstack-nova | 01:19 | |
| *** markvoelker has joined #openstack-nova | 01:20 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs master: add z/VM Driver https://review.openstack.org/464915 | 01:20 |
| *** catintheroof has quit IRC | 01:21 | |
| jichen | mriedem: hi, thanks for the review, I just uploaded another version | 01:22 |
| *** salv-orlando has quit IRC | 01:22 | |
| mriedem | jichen: is there anything weird about the zvm driver like does it have a 1:M host:node mapping like baremetal? | 01:23 |
| *** yamahata has quit IRC | 01:23 | |
| mriedem | in other words, will get_available_nodes() only return 1 entry? | 01:23 |
| jichen | mriedem: no, every compute node has 1:1 relation to one hypervisor , I think powerVM used to have this problem and they modify the arch and now they have 1:1 relation? | 01:23 |
| *** yamamoto has joined #openstack-nova | 01:24 | |
| mriedem | i think neo / novalink was always 1:1 | 01:24 |
| jichen | ok, maybe I remember wrong thing about powerVM | 01:24 |
| jichen | we request one compute service running to represent a hypervisor , so if you have 5 z/VM to be managed , you have to create 5 compute service and each service running with nova.conf point to the z/VM to be managed | 01:25 |
| *** ijw has joined #openstack-nova | 01:25 | |
| *** ijw has quit IRC | 01:25 | |
| *** ijw has joined #openstack-nova | 01:27 | |
| *** AlexeyAbashkin has joined #openstack-nova | 01:28 | |
| *** AlexeyAbashkin has quit IRC | 01:32 | |
| openstackgerrit | Merged openstack/nova-specs master: add z/VM Driver https://review.openstack.org/464915 | 01:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Send Allocations to spawn https://review.openstack.org/511879 | 01:38 |
| mriedem | jichen: is there a blueprint in launchpad? | 01:38 |
| jichen | mriedem: I will create a new one right now, thanks for the reminder | 01:38 |
| *** suresh12 has quit IRC | 01:40 | |
| *** bjolo has joined #openstack-nova | 01:41 | |
| *** zsli_ has joined #openstack-nova | 01:41 | |
| *** links has joined #openstack-nova | 01:44 | |
| *** Shunli has quit IRC | 01:45 | |
| *** mriedem has quit IRC | 01:45 | |
| *** links is now known as Jaison|away | 01:45 | |
| *** hongbin has joined #openstack-nova | 01:49 | |
| *** deikiyoch has joined #openstack-nova | 01:52 | |
| *** deikiyoch has left #openstack-nova | 01:52 | |
| *** markvoelker has quit IRC | 01:53 | |
| openstackgerrit | Merged openstack/nova master: doc: Fix command output in scheduler document https://review.openstack.org/511839 | 01:56 |
| *** markvoelker has joined #openstack-nova | 01:59 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API https://review.openstack.org/506030 | 01:59 |
| *** markvoelker has quit IRC | 02:03 | |
| *** hongbin_ has joined #openstack-nova | 02:04 | |
| *** masber has quit IRC | 02:07 | |
| *** markvoelker has joined #openstack-nova | 02:08 | |
| *** markvoelker has quit IRC | 02:12 | |
| *** bkopilov_ has quit IRC | 02:12 | |
| *** bkopilov has quit IRC | 02:13 | |
| *** markvoelker has joined #openstack-nova | 02:17 | |
| *** trungnv has quit IRC | 02:18 | |
| *** salv-orlando has joined #openstack-nova | 02:18 | |
| *** markvoelker has quit IRC | 02:21 | |
| *** salv-orlando has quit IRC | 02:23 | |
| *** markvoelker has joined #openstack-nova | 02:26 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:27 | |
| *** markvoelker has quit IRC | 02:30 | |
| *** ijw has quit IRC | 02:31 | |
| *** AlexeyAbashkin has quit IRC | 02:31 | |
| *** sree has joined #openstack-nova | 02:34 | |
| *** sean-k-mooney has quit IRC | 02:34 | |
| *** avolkov has quit IRC | 02:35 | |
| *** sean-k-mooney has joined #openstack-nova | 02:35 | |
| *** markvoelker has joined #openstack-nova | 02:35 | |
| *** jhesketh has quit IRC | 02:35 | |
| *** suresh12 has joined #openstack-nova | 02:35 | |
| *** tonyb has quit IRC | 02:36 | |
| *** avolkov has joined #openstack-nova | 02:37 | |
| *** tonyb has joined #openstack-nova | 02:37 | |
| *** jhesketh has joined #openstack-nova | 02:38 | |
| *** Lehtu has quit IRC | 02:38 | |
| *** Lehtu has joined #openstack-nova | 02:38 | |
| *** suresh12 has quit IRC | 02:40 | |
| *** markvoelker has quit IRC | 02:40 | |
| *** liuyulong has joined #openstack-nova | 02:41 | |
| *** TuanLA has joined #openstack-nova | 02:44 | |
| *** markvoelker has joined #openstack-nova | 02:44 | |
| *** TuanLA has quit IRC | 02:44 | |
| *** lbragstad has joined #openstack-nova | 02:45 | |
| *** Bryan__ has quit IRC | 02:46 | |
| *** masber has joined #openstack-nova | 02:49 | |
| *** coreywright has quit IRC | 02:49 | |
| *** markvoelker has quit IRC | 02:49 | |
| *** hongbin_ has quit IRC | 02:51 | |
| *** TuanLA has joined #openstack-nova | 02:52 | |
| *** markvoelker has joined #openstack-nova | 02:53 | |
| *** Tom_ has joined #openstack-nova | 02:55 | |
| *** zsli_ is now known as Shunli | 03:03 | |
| *** coreywright has joined #openstack-nova | 03:07 | |
| *** udesale has joined #openstack-nova | 03:08 | |
| *** trungnv has joined #openstack-nova | 03:17 | |
| *** jmlowe has joined #openstack-nova | 03:17 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190 | 03:18 |
| *** salv-orlando has joined #openstack-nova | 03:19 | |
| *** Jaison|away is now known as links | 03:23 | |
| *** salv-orlando has quit IRC | 03:24 | |
| *** dave-mccowan has quit IRC | 03:24 | |
| *** AlexeyAbashkin has joined #openstack-nova | 03:26 | |
| *** markvoelker has quit IRC | 03:27 | |
| *** AlexeyAbashkin has quit IRC | 03:31 | |
| openstackgerrit | Merged openstack/nova master: Fix nova-manage commands that do not exist https://review.openstack.org/512324 | 03:33 |
| *** hongbin has quit IRC | 03:37 | |
| *** sridharg has joined #openstack-nova | 03:38 | |
| *** bkopilov has joined #openstack-nova | 03:39 | |
| *** bkopilov_ has joined #openstack-nova | 03:40 | |
| *** nicolasbock has quit IRC | 03:41 | |
| *** mtreinish has quit IRC | 03:42 | |
| *** mtreinish has joined #openstack-nova | 03:42 | |
| *** TuanLA has quit IRC | 03:45 | |
| *** hieulq has quit IRC | 03:45 | |
| *** phuongnh has quit IRC | 03:45 | |
| *** yamahata has joined #openstack-nova | 03:45 | |
| *** TuanLA has joined #openstack-nova | 03:46 | |
| *** phuongnh has joined #openstack-nova | 03:46 | |
| *** masber has quit IRC | 03:46 | |
| *** hieulq has joined #openstack-nova | 03:46 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova-specs master: Add pagination and changes since filter support for os-instance-action API https://review.openstack.org/507762 | 03:46 |
| *** udesale has quit IRC | 03:47 | |
| *** yangyapeng has quit IRC | 03:49 | |
| *** udesale has joined #openstack-nova | 03:50 | |
| *** mdnadeem has joined #openstack-nova | 03:50 | |
| *** yangyapeng has joined #openstack-nova | 03:50 | |
| *** jmlowe has quit IRC | 03:52 | |
| *** udesale has quit IRC | 03:52 | |
| *** udesale has joined #openstack-nova | 03:53 | |
| *** lbragstad has quit IRC | 03:58 | |
| *** Hazelesque has quit IRC | 03:59 | |
| *** gouthamr has quit IRC | 03:59 | |
| *** BenderRodriguez has joined #openstack-nova | 04:00 | |
| BenderRodriguez | Help! | 04:00 |
| BenderRodriguez | I'm getting http 500 errors when attempting to run "openstack hypervisor list" | 04:00 |
| BenderRodriguez | The error is shown to be this: EmptyCatalog: The service catalog is empty. | 04:00 |
| BenderRodriguez | http://controller:8774/v2.1/os-hypervisors/detail returned with HTTP 500 | 04:00 |
| *** jmlowe has joined #openstack-nova | 04:01 | |
| BenderRodriguez | nova is listed as a compute service in "openstack service list" | 04:01 |
| BenderRodriguez | so I'm not sure what's going wrong | 04:01 |
| BenderRodriguez | any ideas? | 04:01 |
| *** phuongnh has quit IRC | 04:05 | |
| *** phuongnh has joined #openstack-nova | 04:05 | |
| *** Hazelesque has joined #openstack-nova | 04:05 | |
| *** sbezverk has quit IRC | 04:06 | |
| *** sridharg has quit IRC | 04:06 | |
| *** trungnv has quit IRC | 04:10 | |
| *** claudiub has joined #openstack-nova | 04:11 | |
| *** suresh12 has joined #openstack-nova | 04:15 | |
| *** huanxie has quit IRC | 04:15 | |
| *** markvoelker has joined #openstack-nova | 04:17 | |
| *** salv-orlando has joined #openstack-nova | 04:20 | |
| *** markvoelker has quit IRC | 04:22 | |
| *** salv-orlando has quit IRC | 04:25 | |
| *** AlexeyAbashkin has joined #openstack-nova | 04:26 | |
| *** markvoelker has joined #openstack-nova | 04:27 | |
| *** sridharg has joined #openstack-nova | 04:28 | |
| *** AlexeyAbashkin has quit IRC | 04:31 | |
| *** sridharg has quit IRC | 04:32 | |
| *** markvoelker has quit IRC | 04:33 | |
| *** markvoelker has joined #openstack-nova | 04:34 | |
| *** jwcroppe has quit IRC | 04:35 | |
| *** sridharg has joined #openstack-nova | 04:38 | |
| *** jmlowe has quit IRC | 04:48 | |
| *** crushil has quit IRC | 04:52 | |
| *** huanxie has joined #openstack-nova | 04:59 | |
| *** claudiub has quit IRC | 05:05 | |
| priya_ | BenderRodriguez - check openstack --debug hypervisor list | 05:06 |
| *** esberglu has joined #openstack-nova | 05:09 | |
| *** esberglu has quit IRC | 05:09 | |
| *** avolkov` has joined #openstack-nova | 05:10 | |
| *** cfriesen has quit IRC | 05:10 | |
| *** avolkov has quit IRC | 05:11 | |
| *** priya_ has quit IRC | 05:14 | |
| *** edmondsw has quit IRC | 05:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix missing metavar in aggregate-update https://review.openstack.org/512485 | 05:19 |
| *** salv-orlando has joined #openstack-nova | 05:21 | |
| *** salv-orlando has quit IRC | 05:25 | |
| *** suresh12 has quit IRC | 05:32 | |
| *** salv-orlando has joined #openstack-nova | 05:34 | |
| *** slaweq has joined #openstack-nova | 05:35 | |
| *** slaweq has quit IRC | 05:47 | |
| *** yangyapeng has quit IRC | 05:49 | |
| *** liusheng has quit IRC | 05:49 | |
| *** edand has joined #openstack-nova | 05:50 | |
| *** Tom__ has joined #openstack-nova | 05:52 | |
| *** slaweq has joined #openstack-nova | 05:52 | |
| *** slaweq has quit IRC | 05:54 | |
| *** trinaths has joined #openstack-nova | 05:54 | |
| *** markvoelker has quit IRC | 05:54 | |
| *** jwcroppe has joined #openstack-nova | 05:55 | |
| *** Tom_ has quit IRC | 05:56 | |
| alex_xu | efried: I think the case you talk about can be supported by non-numbered request | 05:56 |
| alex_xu | efried: but the current code doesn't work for that case, that isn't the trait implementation problem, it is the current code implementation problem | 05:57 |
| *** yangyapeng has joined #openstack-nova | 05:59 | |
| *** jwcroppe has quit IRC | 05:59 | |
| *** karthiks has joined #openstack-nova | 06:02 | |
| *** josecastroleon has joined #openstack-nova | 06:07 | |
| *** Oku_OS-away is now known as Oku_OS | 06:08 | |
| *** gabor_antal has quit IRC | 06:17 | |
| *** hferenc has quit IRC | 06:17 | |
| *** gcb has joined #openstack-nova | 06:18 | |
| *** sahid has joined #openstack-nova | 06:18 | |
| *** sahid has quit IRC | 06:19 | |
| *** sahid has joined #openstack-nova | 06:19 | |
| *** chyka has joined #openstack-nova | 06:20 | |
| *** liusheng has joined #openstack-nova | 06:21 | |
| *** masber has joined #openstack-nova | 06:21 | |
| *** yikun has joined #openstack-nova | 06:24 | |
| *** yikun_ has joined #openstack-nova | 06:25 | |
| *** armax has quit IRC | 06:25 | |
| *** chyka has quit IRC | 06:25 | |
| *** yikun_ has quit IRC | 06:25 | |
| *** armax has joined #openstack-nova | 06:25 | |
| *** armax has quit IRC | 06:25 | |
| *** abhi89 has joined #openstack-nova | 06:27 | |
| *** slaweq has joined #openstack-nova | 06:37 | |
| *** slaweq_ has joined #openstack-nova | 06:38 | |
| *** psachin has quit IRC | 06:38 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Refactor placement version check https://review.openstack.org/512497 | 06:40 |
| *** slaweq has quit IRC | 06:41 | |
| *** andreas_s has joined #openstack-nova | 06:42 | |
| *** markus_z has joined #openstack-nova | 06:44 | |
| *** pcaruana has joined #openstack-nova | 06:44 | |
| *** andreas_s has quit IRC | 06:45 | |
| *** vks1 has joined #openstack-nova | 06:45 | |
| *** claudiub has joined #openstack-nova | 06:46 | |
| *** Oku_OS is now known as Oku_OS-away | 06:46 | |
| *** andreas_s has joined #openstack-nova | 06:47 | |
| *** Oku_OS-away is now known as Oku_OS | 06:50 | |
| *** andreas_s has quit IRC | 06:50 | |
| *** markvoelker has joined #openstack-nova | 06:50 | |
| *** psachin has joined #openstack-nova | 06:51 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Improve the performance of filtering instances by IP. https://review.openstack.org/509326 | 06:52 |
| *** andreas__ has joined #openstack-nova | 06:52 | |
| *** gabor_antal has joined #openstack-nova | 06:57 | |
| *** hferenc has joined #openstack-nova | 06:58 | |
| *** edmondsw has joined #openstack-nova | 07:01 | |
| *** andreas_s has joined #openstack-nova | 07:02 | |
| *** bkopilov_ has quit IRC | 07:02 | |
| *** diga has joined #openstack-nova | 07:04 | |
| openstackgerrit | Dai Dang Van proposed openstack/python-novaclient master: Use generic user for both zuul v2 and v3 https://review.openstack.org/512515 | 07:04 |
| *** andreas__ has quit IRC | 07:05 | |
| *** lajoskatona has joined #openstack-nova | 07:05 | |
| *** edmondsw has quit IRC | 07:06 | |
| *** avolkov` has quit IRC | 07:07 | |
| *** avolkov` has joined #openstack-nova | 07:07 | |
| *** sshwarts has joined #openstack-nova | 07:08 | |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** gjayavelu has joined #openstack-nova | 07:11 | |
| openstackgerrit | Dai Dang Van proposed openstack/python-novaclient master: Use generic user for both zuul v2 and v3 https://review.openstack.org/512515 | 07:13 |
| *** slaweq has quit IRC | 07:15 | |
| *** tesseract has joined #openstack-nova | 07:16 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190 | 07:19 |
| *** acormier has joined #openstack-nova | 07:22 | |
| *** acormier has quit IRC | 07:27 | |
| *** ragiman has joined #openstack-nova | 07:29 | |
| *** ttsiouts has joined #openstack-nova | 07:31 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:34 | |
| *** ygl has joined #openstack-nova | 07:36 | |
| *** ygl has left #openstack-nova | 07:36 | |
| *** josecastroleon has quit IRC | 07:37 | |
| *** jpena|off is now known as jpena | 07:43 | |
| *** trungnv has joined #openstack-nova | 07:43 | |
| *** mhenkel has quit IRC | 07:47 | |
| *** fragatina has joined #openstack-nova | 07:48 | |
| *** fragatina has quit IRC | 07:49 | |
| *** ralonsoh has joined #openstack-nova | 07:49 | |
| *** fragatina has joined #openstack-nova | 07:49 | |
| *** ralonsoh_ has joined #openstack-nova | 07:50 | |
| *** mhenkel has joined #openstack-nova | 07:53 | |
| *** ralonsoh has quit IRC | 07:54 | |
| *** ralonsoh_ is now known as ralonsoh | 07:55 | |
| *** acormier has joined #openstack-nova | 07:57 | |
| *** acormier has quit IRC | 07:58 | |
| *** acormier has joined #openstack-nova | 07:58 | |
| *** acormier_ has joined #openstack-nova | 08:02 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101 | 08:02 |
| *** gjayavelu has quit IRC | 08:03 | |
| *** salv-orlando has quit IRC | 08:05 | |
| *** salv-orlando has joined #openstack-nova | 08:05 | |
| *** takashin has left #openstack-nova | 08:05 | |
| *** acormier has quit IRC | 08:06 | |
| gmann | alex_xu: ^^ updated the spec for policy things | 08:06 |
| *** chyka has joined #openstack-nova | 08:10 | |
| *** chyka has quit IRC | 08:14 | |
| alex_xu | gmann: thanks, will reach to it before the end of day | 08:19 |
| *** acormier_ has quit IRC | 08:20 | |
| gmann | alex_xu: thanks. also BPs are separated out with policy change and other extensions merge things. mriedem has approved the specless BP for extensions merge things | 08:21 |
| alex_xu | gmann: cool! | 08:24 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for inventories https://review.openstack.org/457533 | 08:25 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534 | 08:25 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for usages https://review.openstack.org/457535 | 08:25 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for aggregates https://review.openstack.org/505643 | 08:25 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes https://review.openstack.org/511182 | 08:25 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters https://review.openstack.org/511183 | 08:25 |
| *** yamahata has quit IRC | 08:26 | |
| *** lucas-afk is now known as lucasagomes | 08:33 | |
| *** derekh has joined #openstack-nova | 08:34 | |
| *** rabel has joined #openstack-nova | 08:38 | |
| rabel | hi there, can we finally merge https://review.openstack.org/#/c/494169/ ? | 08:38 |
| rabel | and could someone help me with https://review.openstack.org/#/c/402632/ ? zuul does not seem to be rechecking for a week | 08:39 |
| *** priteau has joined #openstack-nova | 08:43 | |
| *** dtantsur|afk is now known as dtantsur | 08:43 | |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for inventories https://review.openstack.org/457533 | 08:45 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534 | 08:45 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for usages https://review.openstack.org/457535 | 08:45 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for aggregates https://review.openstack.org/505643 | 08:45 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes https://review.openstack.org/511182 | 08:45 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters https://review.openstack.org/511183 | 08:45 |
| gibi | rabel: as http://zuulv3.openstack.org/ does not show that your patch is handled by zuul right now you can simply recheck https://review.openstack.org/#/c/402632/ again | 08:45 |
| *** sridharg has quit IRC | 08:45 | |
| rabel | gibi: thanks for the hint. i did so a week ago, but nothing has happened. do you know why? | 08:46 |
| *** zen369 has joined #openstack-nova | 08:46 | |
| *** yamamoto has quit IRC | 08:47 | |
| gibi | rabel: in the past weeks infra tried to migrate from zuul v2 to zuul v3 and that resulted several restart of zuul. I guess your patch was affected by such a restart | 08:47 |
| rabel | gibi: ah ok. thank you! | 08:48 |
| *** edmondsw has joined #openstack-nova | 08:50 | |
| *** edmondsw has quit IRC | 08:54 | |
| *** yamamoto has joined #openstack-nova | 08:55 | |
| *** yamamoto has quit IRC | 08:55 | |
| *** cdent has joined #openstack-nova | 08:55 | |
| *** rodolof has joined #openstack-nova | 08:57 | |
| *** yikun_jiang has joined #openstack-nova | 09:01 | |
| *** rodolof has quit IRC | 09:03 | |
| *** markvoelker has quit IRC | 09:03 | |
| *** rodolof has joined #openstack-nova | 09:03 | |
| *** yikun has quit IRC | 09:03 | |
| *** yikun_jiang is now known as yikun | 09:04 | |
| *** markvoelker has joined #openstack-nova | 09:04 | |
| jichen | cdent: hi ,may I ask a placement rest api question? | 09:04 |
| *** esberglu has joined #openstack-nova | 09:04 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190 | 09:05 |
| cdent | jichen: yes, sure. what’s up? | 09:05 |
| jichen | cdent: we have some code like : req.response.location = util.resource_class_url(req.environ, rc) | 09:06 |
| jichen | but I didn't see any response in the output | 09:06 |
| jichen | I think nova compute api has something like Location: xxxx ? | 09:06 |
| jichen | Date: Tue, 17 Oct 2017 08:49:01 GMT | 09:06 |
| jichen | Server: Apache/2.4.18 (Ubuntu) | 09:06 |
| jichen | Content-Length: 62 | 09:06 |
| jichen | Content-Type: application/json | 09:06 |
| jichen | OpenStack-API-Version: placement 1.10 | 09:06 |
| jichen | vary: OpenStack-API-Version | 09:06 |
| jichen | x-openstack-request-id: req-d638ece0-f12d-4d06-8f04-1f68c8a21650 | 09:06 |
| jichen | Connection: close | 09:06 |
| jichen | this is what I got from a 'curl xxx' to placement | 09:06 |
| jichen | I mean, in the response header, do we plan to have a header about Location or not? | 09:07 |
| cdent | jichen: what request were you making? | 09:07 |
| *** josecastroleon has joined #openstack-nova | 09:08 | |
| jichen | curl -g -i -X PUT "http://192.168.122.243/placement/resource_providers/929b0597-e4e0-47f7-b4af-9a8c2c8f61d0/traits?nameith:CUSTOM" -H "OpenStack-API-Version: compute 2.53" -H "Content-Type: application/json" -H "OpenStack-API-Version: placement 1.10" -H "X-Auth-Token: gAAAAABZ5cPl6wpCFyQIbl2-JLuKEEOiUSNaeu7OGtcqoBRz-mDwP8bGS6IfdA139oVqv4AGKSGHpCBklbx6seqrsNPwUB_yZY5kmUAXxg5B_FB7V99RJV_Db3ovJu2xHlk | 09:08 |
| jichen | YJ5sn9mo3di0kzJtl5AT0dxaL_iCR8GVp1rEEajIwvg0DSk3E8Eo" -d '{"resource_provider_generation": 17, "traits": ["CUSTOM_ABC"]}' | 09:08 |
| *** esberglu has quit IRC | 09:09 | |
| cdent | location will show up in response to only some requests: post to create one inventory, post to create a resource class, put to create a resource class, post to create a resource provider, put to create a trait | 09:09 |
| cdent | so in that example you’ve done a PUT to a resource provider, which does not support location header | 09:09 |
| cdent | as written at least | 09:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move restart_compute_service to a common place https://review.openstack.org/512551 | 09:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552 | 09:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | 09:09 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,New] https://launchpad.net/bugs/1724172 | 09:09 |
| jichen | stack@ubuntu1:~$ curl -g -i -X PUT "http://192.168.122.243/placement/resource_providers/929b0597-e4e0-47f7-b4af-9a8c2c8f61d0/traits" -H ack-API-Version: compute 2.53" -H "Content-Type: application/json" -H "OpenStack-API-Version: placement 1.10" -H "X-Auth-Token: gAAAAABZ5cPl6wpCFyQIbl2-JLuKEEOiUSNaeu7OGtcqoBRz-mDwP8bGS6IfdA139oVqv4AGKSGHpCBklbx6seqrsNPwUB_yZY5kmUAXxg5B_FB7V99RJV_Db3ovJu2xHlkYJ5sn | 09:10 |
| jichen | 9mo3di0kzJtl5AT0dxaL_iCR8GVp1rEEajIwvg0DSk3E8Eo" -d '{"resource_provider_generation": 18, "traits": ["CUSTOM_ABC"]}' | 09:10 |
| jichen | HTTP/1.1 200 OK | 09:10 |
| jichen | Date: Tue, 17 Oct 2017 09:09:54 GMT | 09:10 |
| jichen | Server: Apache/2.4.18 (Ubuntu) | 09:10 |
| jichen | Content-Length: 62 | 09:10 |
| jichen | Content-Type: application/json | 09:10 |
| jichen | OpenStack-API-Version: placement 1.10 | 09:10 |
| jichen | vary: OpenStack-API-Version | 09:10 |
| jichen | x-openstack-request-id: req-4ce20136-afb8-405e-86ff-2397a21cc1c2 | 09:10 |
| cdent | jichen: you’re right that we should probably be consistent about it, but it looks like we weren’t. I think the logic that was used is that a location header is a good idea if the response is empty | 09:10 |
| jichen | Connection: close | 09:10 |
| jichen | {"traits": ["CUSTOM_ABC"], "resource_provider_generation": 19} | 09:10 |
| jichen | sorry, wrong lURL | 09:10 |
| jichen | 2nd URL I used is to PUT traits | 09:11 |
| cdent | jichen: for long pastes like that it is better to use a pastebin like http://paste.openstack.org/ | 09:11 |
| jichen | ok, right now | 09:11 |
| cdent | that’s put to add traits to a resource provider, not to create a trait | 09:11 |
| *** sahid has quit IRC | 09:11 | |
| jichen | cdent: http://paste.openstack.org/show/623800/ | 09:11 |
| *** sahid has joined #openstack-nova | 09:12 | |
| *** priya__ has joined #openstack-nova | 09:13 | |
| priya__ | hi ..could somebody review the commit - https://review.openstack.org/#/c/508533/ | 09:14 |
| cdent | jichen: right, so that request corresponds with this handler: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/trait.py#L217-L248 which does not set the header | 09:14 |
| cdent | jichen: do you think it should? | 09:14 |
| *** yamamoto has joined #openstack-nova | 09:15 | |
| jichen | cdent: I guess I used wrong URL ... I think we should not add a header as this is a just 'associate' | 09:16 |
| *** sree has quit IRC | 09:16 | |
| jichen | so I will update the document of placement api ref.. it doesn't have the info about this header | 09:16 |
| *** sdague has joined #openstack-nova | 09:17 | |
| masber | good afternoon all, I am having an issue resizing nodes. My hardware runs NUMA and I pin my vcpus for better performance. I could not resize the instance because it could not fit any NUMA node so what I did was to shutdown the vms on that node so the kvm could relocate them and make more space for the extra resources | 09:18 |
| cdent | I think we didn’t end up adding the info about headers because there’s no clear use case for them. When I wrote the first bits of the code that did add a location header, I did it because it is standard form: create something? then put a location header in the response. We don’t necessarily need to cloud the documentation with that except perhaps in the case of POST /resource_providers (because that tells you wha | 09:18 |
| cdent | was created) | 09:18 |
| cdent | jichen: in everything else there are other ways | 09:19 |
| masber | I resized the node while it was shutdown, and then I tried to confirm the resize but confirmation failed saying "cannot resize instance while it is in vm_state resized" | 09:19 |
| *** mdnadeem has quit IRC | 09:19 | |
| *** udesale__ has joined #openstack-nova | 09:19 | |
| *** sree has joined #openstack-nova | 09:19 | |
| masber | since then I can even start resizing the node as state stays as active | 09:19 |
| masber | *can't | 09:19 |
| *** udesale has quit IRC | 09:19 | |
| masber | is this a bug or am I doing something stupid? | 09:20 |
| *** sambetts|afk is now known as sambetts | 09:20 | |
| *** andreas_s has quit IRC | 09:21 | |
| jichen | cdent: ok, I can live with that, I thought we return location for every thing we created like you mentioned; and you are right, seems no clear use case for that, thanks for your guide | 09:21 |
| cdent | jichen: you’re welcome, and thank you for trying to make sure we are consistent, we can probalby do better on that. | 09:21 |
| *** udesale__ has quit IRC | 09:22 | |
| jichen | cdent: yes, I will make more analysis on that :), thanks | 09:22 |
| *** udesale has joined #openstack-nova | 09:22 | |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534 | 09:22 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for usages https://review.openstack.org/457535 | 09:22 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI for aggregates https://review.openstack.org/505643 | 09:22 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes https://review.openstack.org/511182 | 09:22 |
| openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters https://review.openstack.org/511183 | 09:22 |
| *** liusheng has quit IRC | 09:22 | |
| *** liusheng has joined #openstack-nova | 09:23 | |
| *** sree has quit IRC | 09:23 | |
| *** yikun has quit IRC | 09:25 | |
| *** Tom__ has quit IRC | 09:28 | |
| *** liusheng has quit IRC | 09:28 | |
| *** liusheng has joined #openstack-nova | 09:28 | |
| *** Shunli has quit IRC | 09:29 | |
| *** andreas_s has joined #openstack-nova | 09:30 | |
| *** slaweq has joined #openstack-nova | 09:30 | |
| *** yingjun has quit IRC | 09:30 | |
| priya__ | cdent : Could you please review https://review.openstack.org/#/c/508533/ | 09:31 |
| cdent | priya__: yes, will put it on my list for today | 09:32 |
| priya__ | thank you ! | 09:33 |
| *** mdnadeem has joined #openstack-nova | 09:34 | |
| *** slaweq has quit IRC | 09:35 | |
| *** yikun has joined #openstack-nova | 09:35 | |
| *** mdnadeem has quit IRC | 09:44 | |
| *** salv-orlando has quit IRC | 09:50 | |
| *** ociuhandu has quit IRC | 09:50 | |
| *** salv-orlando has joined #openstack-nova | 09:50 | |
| *** yassine has quit IRC | 09:52 | |
| *** priya__ has quit IRC | 09:55 | |
| *** salv-orlando has quit IRC | 09:55 | |
| *** jichen has quit IRC | 09:59 | |
| *** esberglu has joined #openstack-nova | 09:59 | |
| *** esberglu has quit IRC | 09:59 | |
| *** mdnadeem has joined #openstack-nova | 10:00 | |
| *** sree has joined #openstack-nova | 10:02 | |
| *** andreas_s has quit IRC | 10:02 | |
| *** TuanLA has quit IRC | 10:05 | |
| *** trungnv has quit IRC | 10:05 | |
| *** sree has quit IRC | 10:06 | |
| *** kuzko has quit IRC | 10:06 | |
| *** gmann is now known as gmann_afk | 10:09 | |
| *** kuzko has joined #openstack-nova | 10:14 | |
| *** yamamoto has quit IRC | 10:18 | |
| *** mvk has quit IRC | 10:19 | |
| *** priteau has quit IRC | 10:19 | |
| *** acormier has joined #openstack-nova | 10:21 | |
| *** priteau has joined #openstack-nova | 10:21 | |
| *** gszasz has joined #openstack-nova | 10:21 | |
| *** cdent has quit IRC | 10:22 | |
| *** Jeffrey4l has quit IRC | 10:24 | |
| *** Jeffrey4l has joined #openstack-nova | 10:24 | |
| *** acormier has quit IRC | 10:25 | |
| *** zqfan has joined #openstack-nova | 10:25 | |
| *** yamamoto has joined #openstack-nova | 10:25 | |
| *** cdent has joined #openstack-nova | 10:26 | |
| *** zqfan has quit IRC | 10:27 | |
| *** ociuhandu has joined #openstack-nova | 10:27 | |
| *** vvargaszte has joined #openstack-nova | 10:28 | |
| *** cdent has quit IRC | 10:29 | |
| *** yamamoto has quit IRC | 10:30 | |
| *** liusheng has quit IRC | 10:32 | |
| *** salv-orlando has joined #openstack-nova | 10:32 | |
| *** liusheng has joined #openstack-nova | 10:32 | |
| *** slaweq has joined #openstack-nova | 10:32 | |
| *** Jeffrey4l has quit IRC | 10:33 | |
| *** openstackgerrit has quit IRC | 10:33 | |
| *** Jeffrey4l has joined #openstack-nova | 10:33 | |
| *** andreas_s has joined #openstack-nova | 10:35 | |
| *** slaweq has quit IRC | 10:37 | |
| *** edmondsw has joined #openstack-nova | 10:38 | |
| *** edmondsw has quit IRC | 10:42 | |
| *** tesseract has quit IRC | 10:43 | |
| *** tesseract has joined #openstack-nova | 10:43 | |
| *** openstackgerrit has joined #openstack-nova | 10:45 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580 | 10:45 |
| *** tbachman has quit IRC | 10:45 | |
| *** bkopilov has quit IRC | 10:46 | |
| *** mvk has joined #openstack-nova | 10:50 | |
| *** priteau has quit IRC | 10:52 | |
| *** esberglu has joined #openstack-nova | 10:52 | |
| *** vvargaszte has quit IRC | 10:55 | |
| *** sree has joined #openstack-nova | 10:55 | |
| *** yangyapeng has quit IRC | 10:55 | |
| *** esberglu has quit IRC | 10:57 | |
| *** nicolasbock has joined #openstack-nova | 11:02 | |
| *** zhuli has joined #openstack-nova | 11:08 | |
| *** zhuli has left #openstack-nova | 11:10 | |
| *** yassine has joined #openstack-nova | 11:11 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 11:11 |
| *** sridharg has joined #openstack-nova | 11:12 | |
| *** lucasagomes is now known as lucas-hungry | 11:13 | |
| ralonsoh | alex_xu: hi, if you have time, can you take a look at https://review.openstack.org/#/c/502306/? | 11:16 |
| ralonsoh | alex_xu: BTW, this one was approved last cycle. Half of the code is already merged. I would like to have it approved this cycle to continue the work: https://review.openstack.org/#/c/504895/ | 11:17 |
| *** huanxie has quit IRC | 11:20 | |
| *** nicolasbock has quit IRC | 11:23 | |
| openstackgerrit | edan david proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613 | 11:24 |
| *** yamamoto has joined #openstack-nova | 11:26 | |
| *** dtantsur is now known as dtantsur|brb | 11:28 | |
| *** yamamoto has quit IRC | 11:32 | |
| *** cdent has joined #openstack-nova | 11:34 | |
| *** Tom_ has joined #openstack-nova | 11:34 | |
| *** nicolasbock has joined #openstack-nova | 11:35 | |
| *** udesale has quit IRC | 11:38 | |
| *** smatzek has joined #openstack-nova | 11:39 | |
| *** Tom_ has quit IRC | 11:39 | |
| *** yamamoto has joined #openstack-nova | 11:41 | |
| *** yamamoto_ has joined #openstack-nova | 11:42 | |
| *** udesale has joined #openstack-nova | 11:44 | |
| *** yamamoto has quit IRC | 11:46 | |
| *** chyka has joined #openstack-nova | 11:46 | |
| *** chyka has quit IRC | 11:51 | |
| *** salv-orlando has quit IRC | 11:54 | |
| *** markus_zz has joined #openstack-nova | 11:54 | |
| *** yamamoto_ has quit IRC | 11:56 | |
| *** vks1 has quit IRC | 11:56 | |
| *** markus_z has quit IRC | 11:57 | |
| *** phuongnh has quit IRC | 12:01 | |
| *** udesale has quit IRC | 12:01 | |
| *** liusheng has quit IRC | 12:02 | |
| *** liusheng has joined #openstack-nova | 12:03 | |
| *** jpena is now known as jpena|lunch | 12:04 | |
| *** Tom__ has joined #openstack-nova | 12:08 | |
| *** edmondsw has joined #openstack-nova | 12:09 | |
| *** jmlowe has joined #openstack-nova | 12:09 | |
| *** liverpooler has joined #openstack-nova | 12:10 | |
| *** vladikr has joined #openstack-nova | 12:13 | |
| *** READ10 has joined #openstack-nova | 12:14 | |
| *** pchavva has joined #openstack-nova | 12:15 | |
| *** liverpooler has quit IRC | 12:16 | |
| *** liverpooler has joined #openstack-nova | 12:17 | |
| *** yamamoto has joined #openstack-nova | 12:19 | |
| *** lucas-hungry is now known as lucasagomes | 12:19 | |
| *** bkopilov has joined #openstack-nova | 12:20 | |
| cdent | alex_xu: if you didn’t see this bit of irc chat yesterday, it covers some of the issues with shared providers and traits: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-10-16.log.html#t2017-10-16T18:37:18 | 12:21 |
| cdent | it took quite a while to figure out what efried was talking about but we finally figured it out in that chat | 12:21 |
| *** dave-mccowan has joined #openstack-nova | 12:21 | |
| * efried rolls eyes | 12:24 | |
| efried | That's me. It can take a while to figure out wtf I'm talking about. | 12:25 |
| efried | I'd like to think it's because they're such advanced concepts, I have to explain them carefully to lesser mortals. | 12:25 |
| efried | (In case you're just joining us, naw, that ain't it.) | 12:25 |
| cdent | that ^^ was driven by alex’s latest comment on your spec, on the principle of more context is better | 12:26 |
| efried | cdent I know, and I appreciate it. I'm just ribbin ya. | 12:27 |
| *** diga has quit IRC | 12:29 | |
| cdent | I know, I’m giving you context on the context giving, for sake of contextualizing the people in our context, contextually | 12:29 |
| alex_xu | ralonsoh: yea, add it to my review list | 12:29 |
| cdent | soon the ai which is learning human behavior from the log of this channel will achieve consciousness, and presumably wipe us from the face of the earth | 12:30 |
| alex_xu | cdent: efried yea, I read that today | 12:30 |
| alex_xu | cdent: efried, the current trait implement supports that case | 12:30 |
| alex_xu | the current trait implement will try to collect the traits from the RP and sharing RP which in the same aggregates | 12:31 |
| efried | alex_xu The case where RAID5 and SSD are split across the compute RP and the shared storage RP? | 12:31 |
| alex_xu | the problem is the current implementation of https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L2453 doesn't return the correct PRs | 12:32 |
| alex_xu | _get_all_with_shared only return that root RP once. | 12:33 |
| cdent | alex_xu: root is a bad term in this context :) | 12:33 |
| efried | alex_xu My contention is that it *can't* return the correct RPs for this scenario under the current semantics. | 12:33 |
| cdent | efried: your forthcoming test will make it all clear :D | 12:33 |
| alex_xu | for that case, actually we expect return that root RP twoice, and then we should generate two combinations: #1 root RP with local disk, #2 root RP with shared disk | 12:34 |
| alex_xu | cdent: forgive me, let me use root rp first :) that pain for me also | 12:34 |
| efried | alex_xu Actually, it won't return the compute+localdisk combination, because that wouldn't satisfy the RAID5 trait. | 12:34 |
| alex_xu | and then, the trait implementation will find out #1 and #2 which have enough trait | 12:34 |
| efried | But it *will* return the compute+shared combination, even though it *shouldn't*. | 12:35 |
| efried | It shouldn't because the shared storage doesn't satisfy the SSD trait. But placement has no way of knowing that RAID & SSD were both supposed to apply to the storage, whereas the HW_CPU... trait wasn't. | 12:36 |
| *** gabor_antal_ has joined #openstack-nova | 12:37 | |
| *** peter-hamilton has joined #openstack-nova | 12:37 | |
| alex_xu | efried: I didn't have test it, but I think the current code will return compute+local | 12:37 |
| alex_xu | and it never return the compute+shared combination | 12:38 |
| efried | alex_xu Because of that bug? Maybe. | 12:38 |
| *** gabor_antal has quit IRC | 12:38 | |
| alex_xu | because the implement of _get_all_with_shared | 12:38 |
| alex_xu | but that still doesn't correct, you are expecting _get_all_with_shared return two combinations | 12:39 |
| efried | _get_all_with_shared is the piece that doesn't yet take traits into account? | 12:39 |
| *** salv-orlando has joined #openstack-nova | 12:40 | |
| alex_xu | and then the trait implement will filter out the correct one | 12:40 |
| alex_xu | efried: yes | 12:40 |
| efried | Right, gotcha. So you're right: _get_all_with_shared *should* return *both* combinations. (If it's not, that's a bug.) | 12:40 |
| efried | And then the code you're writing *should* filter *both* of them out and yield zero candidates. | 12:40 |
| alex_xu | efried: because this https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L895 | 12:40 |
| efried | But there's no way to write your code to do that. | 12:41 |
| alex_xu | that condition assumes that there only have the one case in (local and shared) | 12:41 |
| alex_xu | efried: but the first thing we should figure out is that whether we want to support that case | 12:41 |
| efried | ohh, you're missing a LEFT JOIN | 12:41 |
| efried | Well, I contend we can't *not* support that case. | 12:42 |
| efried | At least not long term. | 12:42 |
| cdent | I’m going to save [t 3Vz8] because it is probably useful to whip out just about any time | 12:42 |
| purplerbot | <efried> ohh, you're missing a LEFT JOIN [2017-10-17 12:41:57.325623] [n 3Vz8] | 12:42 |
| efried | (c) 2017 | 12:43 |
| efried | So alex_xu, if we were going to say we don't support that scenario, how would that be worded? | 12:44 |
| alex_xu | at least, currently the nova doesn't support the case we have local disk and shared disk | 12:44 |
| alex_xu | actually nova doesn't know about the disk is local or shared, it just create the instance image in a directory | 12:45 |
| alex_xu | under that directory, it maybe local or a NFS... | 12:45 |
| efried | alex_xu What about local ephemeral (boot) plus volumes? | 12:45 |
| alex_xu | and I didn't have any real world case similar to that in my mind | 12:46 |
| alex_xu | efried: the resource class DISK_GB is only about local ephemeral disk | 12:46 |
| alex_xu | s/local ephemeral disk/ephemeral disk/ | 12:46 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575 | 12:47 |
| efried | alex_xu fixed nit ^ | 12:48 |
| *** mriedem has joined #openstack-nova | 12:49 | |
| efried | cdent Did you want me to rename that 'p' var ^ ? | 12:49 |
| efried | cdent I don't think we can afford to sweep this under the rug now and just hope it doesn't rear its head later. | 12:50 |
| efried | Sorry, that was meant for alex_xu | 12:50 |
| efried | (I *totally* think we can sweep a terse variable name under the rug) | 12:50 |
| *** jpena|lunch is now known as jpena | 12:51 | |
| efried | ('p' for 'precedent'.) | 12:51 |
| efried | So let's try this again. | 12:51 |
| efried | alex_xu I don't think we can afford to sweep this under the rug now and just hope it doesn't rear its head later. | 12:51 |
| efried | alex_xu At the moment, the scope of where this code is used is very contained, and possibly never even makes its way to where the user can see it. | 12:52 |
| *** esberglu has joined #openstack-nova | 12:52 | |
| *** vvargaszte has joined #openstack-nova | 12:52 | |
| alex_xu | efried: sorry, I still didn't get you :), maybe...not use the 'rug', I didn't get what rug is reference to after search the dictionary.. | 12:52 |
| efried | alex_xu But once we start allowing drivers to model their RPs and operators to specify their resources generically, this will wind up being a nontrivial bug we'll have to scramble to fix. | 12:53 |
| *** yangyapeng has joined #openstack-nova | 12:53 | |
| cdent | efried: I’ve lost the fight on terse variable names, and surrender graciously to fight other battles another day. | 12:53 |
| efried | alex_xu Sorry, idiom. "Sweep under the rug" means "ignore it for now and hope nobody notices" | 12:53 |
| mriedem | johnthetubaguy: can i get you to take a look at this file injection deprecation spec? has a +2 from sdague, looking for another +2 https://review.openstack.org/#/c/509013/ | 12:53 |
| *** vvargaszte has quit IRC | 12:54 | |
| *** yamamoto has quit IRC | 12:54 | |
| alex_xu | efried: ok, you mean the shared RP case, right? we can file a bug for it | 12:55 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575 | 12:57 |
| alex_xu | I should read the 'sweep this under the rug', not just panic on the single 'rug'. | 12:57 |
| *** trinaths has left #openstack-nova | 12:59 | |
| *** vivsoni has quit IRC | 12:59 | |
| efried | alex_xu I can't find an equivalent Chinese idiom, but perhaps 掩饰 gets close. | 13:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Rename add-zvm-driver spec https://review.openstack.org/512606 | 13:00 |
| *** mdnadeem has quit IRC | 13:02 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | 13:02 |
| alex_xu | efried: hehe, i get that | 13:03 |
| *** jmlowe has quit IRC | 13:04 | |
| efried | alex_xu Fixed that other docstring; cdent renamed the variable, just for you :) | 13:05 |
| alex_xu | efried: cool, thanks | 13:06 |
| *** andreas_s has quit IRC | 13:07 | |
| *** andreas_s has joined #openstack-nova | 13:07 | |
| alex_xu | efried: also leaved a question in https://review.openstack.org/#/c/510244/ | 13:07 |
| *** jmlowe has joined #openstack-nova | 13:09 | |
| *** lyan has joined #openstack-nova | 13:09 | |
| alex_xu | ralonsoh: fyi first, I don't have +2 for the nova-spec :) | 13:10 |
| ralonsoh | alex_xu: no problem! thanks for your time | 13:10 |
| cdent | efried: the setUp in these compute manager related tests are … wow. Not the stuff you’ve added, but what was already there. | 13:12 |
| *** liuyulong has quit IRC | 13:12 | |
| efried | cdent I don't disagree. | 13:13 |
| efried | I've got two more UTs to fix, btw. | 13:13 |
| efried | But thanks for looking. | 13:13 |
| *** vivsoni has joined #openstack-nova | 13:13 | |
| *** thorst has joined #openstack-nova | 13:14 | |
| cdent | efried: yeah, I know it’s not complete, I just went by because I wanted to understand the point of it all | 13:14 |
| efried | cdent Hopefully the latest commit message makes it clear why we need this; let me know if not. | 13:15 |
| cdent | yeah, it does | 13:17 |
| *** baoli has joined #openstack-nova | 13:20 | |
| *** dtantsur|brb is now known as dtantsur | 13:21 | |
| *** andreas_s has quit IRC | 13:21 | |
| *** jmlowe has quit IRC | 13:21 | |
| *** lbragstad has joined #openstack-nova | 13:22 | |
| efried | alex_xu Responded to that comment - let me know if you want to discuss. | 13:25 |
| *** sree has quit IRC | 13:25 | |
| efried | alex_xu The code for looking stuff up in nested RPs - I'm not sure if that's part of Jay's series yet. | 13:25 |
| *** sree has joined #openstack-nova | 13:26 | |
| *** andreas_s has joined #openstack-nova | 13:26 | |
| alex_xu | efried: yea, I also want to ask the nested RP support for non-numbered request is implemented by which BP | 13:27 |
| alex_xu | efried: I check the Jay's spec about nested RP, looks like that isn't included in the spec | 13:27 |
| efried | alex_xu I remember talking about it - specifically about trait propagation - in some spec or other. | 13:28 |
| efried | alex_xu Oh! It was *your* spec :) | 13:28 |
| alex_xu | efried: for the question in your spec, is there any way we can try to find SRIOV_NET_VF and NET_EGRESS_BYTES_SEC from the same RPs for the non-numbered request? | 13:28 |
| alex_xu | ok... | 13:28 |
| alex_xu | sounds like we are missing one more spec? | 13:29 |
| efried | alex_xu I don't see how that would work. Because then you would be ignoring the relationship between RPs in a tree. | 13:29 |
| bauzas | sahid: there could be some regression in Pike for CPU pinning when you evacuate https://bugs.launchpad.net/nova/+bug/1723005 | 13:29 |
| openstack | Launchpad bug 1723005 in OpenStack Compute (nova) "CPUPinningInvalid exception occurred when evacuate one instance repeatedly." [High,Confirmed] | 13:29 |
| *** sree has quit IRC | 13:30 | |
| efried | alex_xu In other words, if you made it work that way, there would be all the "normal" cases that wouldn't yield any results. | 13:30 |
| openstackgerrit | edan david proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613 | 13:30 |
| alex_xu | efried: why | 13:31 |
| openstackgerrit | Merged openstack/nova-specs master: Rename add-zvm-driver spec https://review.openstack.org/512606 | 13:31 |
| sahid | bauzas: not sure we have supported that at some point | 13:31 |
| *** smatzek has quit IRC | 13:31 | |
| efried | alex_xu Okay, can we agree that we would *not* want to get a candidate like { RP1: { SRIOV_NET_VF: 1 }, RP2: { NET_EGRESS_BW: 10000 } } ? | 13:32 |
| bauzas | sahid: you mean evacuating an instance that was pinning a CPU ? | 13:32 |
| bauzas | sahid: or any move ops ? | 13:33 |
| alex_xu | efried: yes | 13:33 |
| efried | alex_xu Then in order for that to work, you have to do your selection to make sure those inventories come from the *same* RP. | 13:34 |
| efried | alex_xu So let's extend the model to include VCPU and MEMORY_MB. Those would be in the root RP. But the VF resources are still in the child RPs. | 13:35 |
| alex_xu | efried: or to say try the best, if the RP doesn't have all resources, then looking for the child or shared | 13:35 |
| *** vks1 has joined #openstack-nova | 13:35 | |
| *** andreas_s has quit IRC | 13:36 | |
| sahid | bauzas: pinned instances... there were a patch serie pushed by nikola long time ago but never get merged unfortunatly | 13:36 |
| bauzas | sahid: if you speak of live-migration claims, it's unrelated | 13:36 |
| sahid | i think it never get merged because the work on-going with resource providers and placement :) | 13:36 |
| efried | alex_xu Mm... that *could* work. | 13:37 |
| bauzas | sahid: because we already claim on rebuilds | 13:37 |
| openstackgerrit | Merged openstack/nova-specs master: Deprecate file injection https://review.openstack.org/509013 | 13:37 |
| alex_xu | efried: and how the request with CPU and MEMORY_MB and SRIOV_NET_VF works? it try to the best? get CPU and MEMORY_MB from the root RP, and then try the child? | 13:38 |
| sahid | bauzas: yes but that need to be checked whether we buil a new domain xml based on that new claim or not | 13:38 |
| sahid | if it not so we o not support that | 13:38 |
| alex_xu | that I feel no-one is talking about how the non-numbered request works for the nested RP... | 13:39 |
| efried | alex_xu But if e.g. RP1 is exhausted of VFs and RP2 is exhausted of bandwidth, I think you would wind up giving me a candidate with { COMPUTE_RP: { VCPU, MEMORY_MB }, RP1 { NET_EGRESS_BW }, RP2 { SRIOV_NET_VF } } | 13:39 |
| alex_xu | efried: for that case, we shouldn't return any condidates | 13:39 |
| efried | alex_xu Shouldn't, I agree. But that's going to be tricky to code. | 13:40 |
| alex_xu | so the logic is try the best on the same node or child node or shared node | 13:40 |
| alex_xu | s/node/RP/ | 13:40 |
| bauzas | sahid: so technically, we can't move or rebuild a pinned instance, I see | 13:40 |
| *** xyang1 has joined #openstack-nova | 13:40 | |
| *** andreas_s has joined #openstack-nova | 13:41 | |
| efried | alex_xu If you think that through, though, I don't think you can get it to work in the general case. | 13:41 |
| *** andreas_s has quit IRC | 13:41 | |
| *** andreas_s has joined #openstack-nova | 13:41 | |
| sahid | yes, but only if the pinning of domain xml is updated which was addressed in one of the patch from nikola | 13:41 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova-specs master: Add multiattach support to Nova https://review.openstack.org/499777 | 13:41 |
| *** sree has joined #openstack-nova | 13:41 | |
| *** cdent has quit IRC | 13:41 | |
| alex_xu | efried: sorry, try the best on the same node, then child, then shared, I should use 'then' | 13:42 |
| ildikov | johnthetubaguy: mriedem: new version of the multi-attach spec ^^ | 13:42 |
| sahid | for cold you might have right, if we do build a new domain from scratch so we are OK | 13:42 |
| *** tbachman has joined #openstack-nova | 13:42 | |
| efried | alex_xu Let's look at another scenario: the compute RP is empty (or let's say it has just the local DISK_GB resource). Then we have two NUMA nodes which each contain VCPU & MEMORY_MB resources. Then we also have two PF RPs which each contain VF and EGRESS_BW resources. | 13:42 |
| ildikov | johnthetubaguy: mriedem: a question there is about delete_on_termination as there is one case where an exception gets raised when the volume couldn't be deleted | 13:42 |
| *** gouthamr has joined #openstack-nova | 13:43 | |
| *** tbachman_ has joined #openstack-nova | 13:43 | |
| ildikov | johnthetubaguy: mriedem: discussion about it is here: https://review.openstack.org/#/c/499777/4/specs/queens/approved/cinder-volume-multi-attach.rst | 13:43 |
| *** felipemonteiro_ has joined #openstack-nova | 13:43 | |
| bauzas | sahid: in other words, any move operation that is not regenerating the domain XML is not working if you have pinned instances, I see | 13:43 |
| ildikov | johnthetubaguy: mriedem: please let me know what would be the preference on keeping this as an allowed action or disable it | 13:43 |
| efried | alex_xu We've agreed you can't just look for everything in the same RP. So *either* [you're looking for all the resources in the same "branch"] *or* [you're allowing them to be spread out across all RPs in the tree]. | 13:44 |
| *** felipemonteiro__ has joined #openstack-nova | 13:44 | |
| ildikov | johnthetubaguy: mriedem: I would say keep what we agreed on earlier, but open to new suggestions | 13:44 |
| sahid | yes, or you need to have on the destination node the same CPU topology and more of that have the pCPUs free | 13:44 |
| efried | alex_xu In this scenario, I want to make sure my VCPU & MEMORY_MB come from the same RP; and my VF & BW come from the same RP. | 13:44 |
| efried | (I'm assuming the PF doesn't belong to a NUMA node) | 13:45 |
| *** gcb has quit IRC | 13:45 | |
| mriedem | melwitt: jbernard: assuming this works https://review.openstack.org/512622 we'll need that to unblock nova changes in stable < pike | 13:45 |
| dansmith | mriedem: melwitt: Is this known? http://logs.openstack.org/56/512456/1/check/legacy-tempest-dsvm-multinode-live-migration/5c3869e/job-output.txt.gz#_2017-10-17_01_30_14_509196 | 13:45 |
| dansmith | py3 rados packages missing on pike | 13:46 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 13:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552 | 13:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | 13:46 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,New] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 13:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623 | 13:46 |
| mriedem | dansmith: see ^ | 13:46 |
| mriedem | :) | 13:46 |
| *** sree has quit IRC | 13:46 | |
| dansmith | mriedem: you said < pike | 13:46 |
| *** tbachman has quit IRC | 13:46 | |
| *** tbachman_ is now known as tbachman | 13:46 | |
| mriedem | i was told python3 packages were in the pike UCA | 13:46 |
| mriedem | maybe they arent | 13:46 |
| mriedem | dansmith: same problem though | 13:46 |
| dansmith | okay | 13:47 |
| *** gcb has joined #openstack-nova | 13:47 | |
| mriedem | https://review.openstack.org/#/c/512622/ should fix it | 13:47 |
| *** felipemonteiro_ has quit IRC | 13:48 | |
| alex_xu | efried: yes, for that case, we defintely need the numbered request. I think the case we only request VCPU & MEMORY_MB and VF, this case whether can work for non-numbered request | 13:48 |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: Use neutron's new port binding API https://review.openstack.org/375580 | 13:51 |
| efried | alex_xu But you're right - it sounds like we need to write up some scenarios for the non-numbered group. Not sure where it would be appropriate to do that. Perhaps a delta to your traits-in-allocations spec? | 13:51 |
| *** psachin has quit IRC | 13:52 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Add attachment_get to refresh_connection_info https://review.openstack.org/512626 | 13:53 |
| *** catintheroof has joined #openstack-nova | 13:53 | |
| *** esberglu has quit IRC | 13:54 | |
| *** acormier has joined #openstack-nova | 13:54 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: update live migration to use v3 cinder api https://review.openstack.org/463987 | 13:54 |
| *** esberglu has joined #openstack-nova | 13:54 | |
| alex_xu | efried: yea, i'm not sure it should be in the trait spec, but I feel it should be at somewhere | 13:54 |
| *** yamamoto has joined #openstack-nova | 13:55 | |
| efried | alex_xu I covered some of it in passing in the granular request syntax spec, but dansmith will eviscerate me if I put more words in that one. | 13:56 |
| dansmith | efried: not only that, | 13:56 |
| dansmith | efried: but I'm reserving my +2 until you remove some :) | 13:56 |
| *** Jeffrey4l has quit IRC | 13:56 | |
| efried | vay, really? Sigh, okay. | 13:56 |
| efried | I read "just a tip" as "do better next time" | 13:57 |
| dansmith | efried: the two use cases you call out and then say are out of scope really need to go, IMHO | 13:57 |
| dansmith | the just a tip bit was a suggestion, and I think you should | 13:58 |
| alex_xu | learned a new word 'eviscerate', that is terrible | 13:58 |
| dansmith | lol | 13:58 |
| dansmith | alex_xu: his word not mine :) | 13:58 |
| *** armax has joined #openstack-nova | 13:58 | |
| alex_xu | okay.. | 13:58 |
| *** awaugama has joined #openstack-nova | 13:58 | |
| *** acormier has quit IRC | 13:58 | |
| mriedem | dansmith: if you're looking at stuff for pike, we need to get this fix in and backported to pike https://review.openstack.org/#/c/510938/ | 13:59 |
| *** Jeffrey4l has joined #openstack-nova | 13:59 | |
| *** smatzek has joined #openstack-nova | 13:59 | |
| mriedem | otherwise restart after evacuate blows up | 13:59 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Send Allocations to spawn https://review.openstack.org/511879 | 13:59 |
| *** esberglu has quit IRC | 13:59 | |
| dansmith | mriedem: I was just looking at your backport of my context fix when I saw that | 13:59 |
| efried | dansmith This ^ oughtta be passing now, I believe. | 13:59 |
| dansmith | efried: I was just getting ready to respond to cdent on that | 13:59 |
| *** smatzek has quit IRC | 14:00 | |
| mriedem | bauzas: you want to look at this then? https://review.openstack.org/#/c/510938/ | 14:00 |
| mriedem | need to wrangle our pike fixes for a release | 14:00 |
| mriedem | since we have several high severity ones that are unreleased | 14:01 |
| *** smatzek has joined #openstack-nova | 14:01 | |
| *** cfriesen has joined #openstack-nova | 14:01 | |
| efried | dansmith I'll wait to respond until I see what you have to say, then. | 14:01 |
| *** sbezverk has joined #openstack-nova | 14:01 | |
| *** cleong has joined #openstack-nova | 14:02 | |
| bauzas | mriedem: sure, will look | 14:02 |
| gibi | mriedem: there is another bug 1724172 with fix top of https://review.openstack.org/#/c/510938/ | 14:03 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 14:03 |
| bauzas | edmondsw: sdague: does that https://bugs.launchpad.net/nova/+bug/1716344 ring a bell to you ? (tl;dr: the fact that we only lookup the public endpoint when querying the SC) | 14:03 |
| openstack | Launchpad bug 1716344 in OpenStack Compute (nova) "Nova-API uses Keystone's public endpoint for project id verification" [Undecided,New] | 14:03 |
| johnthetubaguy | edmondsw: very late but I found that patch you were asking me about that the PTG, at least I think you asked me: https://review.openstack.org/#/c/434870 | 14:04 |
| *** yamamoto has quit IRC | 14:05 | |
| *** jwcroppe has joined #openstack-nova | 14:06 | |
| *** slaweq has joined #openstack-nova | 14:06 | |
| mriedem | ildikov: reading | 14:07 |
| sdague | bauzas: so, we might be missing an option there | 14:07 |
| *** thingee has quit IRC | 14:07 | |
| sdague | that being said, this is definitely never called in vm crate | 14:07 |
| sdague | create | 14:07 |
| sdague | the only places this path is called is quota updates and flavor access calls | 14:08 |
| dansmith | efried: left you a suggestion about the actual method, and one about cdent's retry | 14:09 |
| dansmith | efried: the retry could be a follow-on since it really isn't related to this if you use the common method | 14:09 |
| *** esberglu has joined #openstack-nova | 14:09 | |
| ildikov | mriedem: tnx | 14:09 |
| efried | dansmith Roger wilco, and thanks. | 14:09 |
| ildikov | mriedem: as the spec deadline is coming up I'm trying to clean this one up so we can merge it and update later on specifics if needed | 14:10 |
| efried | dansmith Did you mean report.SchedulerReportClient.get_allocations_for_instance? | 14:10 |
| dansmith | efried: rebase | 14:11 |
| efried | dansmith ah, beaut. | 14:11 |
| *** slaweq has quit IRC | 14:11 | |
| dansmith | efried: https://review.openstack.org/#/c/511306/ | 14:11 |
| mriedem | bauzas: replied in that bug | 14:11 |
| bauzas | sdague: you mean, calling verify_project_id is just made by quota updates and flavor calls? | 14:11 |
| mriedem | efried: your new ksa adapter stuff defaults to the internal interface right? | 14:11 |
| mriedem | it goes internal and then public? | 14:11 |
| *** catintheroof has quit IRC | 14:11 | |
| mriedem | bauzas: correct | 14:11 |
| mriedem | it wouldn't make vm create fail | 14:11 |
| efried | mriedem Yes | 14:12 |
| *** Nil_ has joined #openstack-nova | 14:12 | |
| efried | mriedem nova.conf.utils.py L47 | 14:12 |
| mriedem | ok, just checking. we can't rely on that for fixing this anyway. | 14:12 |
| mriedem | since the fix here would have to be backported | 14:12 |
| bauzas | mriedem: okay, so I'll triage it as Wontfix if that bug is punted by efried's KSA rework | 14:13 |
| mriedem | bauzas: i don't think that's the right way to handle this | 14:13 |
| bauzas | open to ideas :) | 14:13 |
| mriedem | you can't backport the ksa fixes | 14:13 |
| bauzas | so we at least need to idenfify the impact | 14:14 |
| mriedem | and we effectively made a backward incompatible change in pike to those apis | 14:14 |
| mriedem | you can't update quota or flavor access if nova can't access keystone's public endpoint | 14:14 |
| bauzas | so it was a design decision to use the public endpoint for such calls ? | 14:14 |
| bauzas | I'm having trouble understanding your sentence about ^ | 14:15 |
| mriedem | yes, but the same design decision was made with placement and we later changed that when someone said it broke their deployment | 14:15 |
| bauzas | I mean "There was a conscious decision to hard-code the public endpoint as the interface when this change was made, but we changed that hard-coding for nova talking to the placement endpoint so I don't see why we wouldn't also allow different endpoints for talking to keystone. " | 14:15 |
| bauzas | ah gotcha | 14:15 |
| bauzas | mriedem: there are 2 possibilities honestly | 14:15 |
| mriedem | https://review.openstack.org/#/c/435010/6/nova/identity.py@34 | 14:16 |
| bauzas | mriedem: either we say it's a bug that is backportable, and I'm tagging the bug as Confirmed | 14:16 |
| edmondsw | johnthetubaguy thanks! Looking at it now | 14:16 |
| sdague | mriedem: what is your concern here? | 14:17 |
| bauzas | mriedem: or we just consider it's more a new design rearchitecture, and in that case, that would make the changes very difficult to backport | 14:17 |
| *** edand has quit IRC | 14:17 | |
| mriedem | "Keystone's public endpoint should only visible to external clients. All internal OpenStack services should use the internalURL for authentication purposes. I think my configuration is correct. The "auth_url" point to Keystone's internal URL, whereas "auth_uri" points to Keystone's public endpoint. I want to avoid https based communication for my internal cloud services." | 14:17 |
| *** burt has joined #openstack-nova | 14:18 | |
| sdague | mriedem: yes, I've read the bug. I don't understand the backwards incompatibility concern | 14:19 |
| *** yamahata has joined #openstack-nova | 14:19 | |
| mriedem | asking for clarification in the bug | 14:20 |
| mriedem | it's not clear to me if the apis fail, or if they just dump errors | 14:20 |
| sdague | I think it's a real fail | 14:20 |
| sdague | but not on the API call they stated | 14:20 |
| mriedem | yes it's not instance create | 14:21 |
| *** dave-mccowan has quit IRC | 14:21 | |
| mriedem | they later said it was the flavor access project id verification | 14:21 |
| mriedem | "It took some time to narrow down the problem. The issue was introduced with the Pike release, where project id verification for flavor access and quota modification got added." | 14:21 |
| *** gongysh has joined #openstack-nova | 14:22 | |
| gongysh | hi | 14:22 |
| mriedem | i don't think the api actually fails, they hit this: https://github.com/openstack/nova/blob/master/nova/api/openstack/identity.py#L57 | 14:22 |
| gongysh | it seems the nested-quota is not implemented yet. right? | 14:22 |
| mriedem | which dumps a stacktrace and returns True | 14:22 |
| mriedem | gongysh: correct | 14:22 |
| gongysh | mriedem, do you if there is alter option? | 14:23 |
| sdague | mriedem: it might b | 14:23 |
| mriedem | gongysh: not in nova no | 14:23 |
| *** crushil has joined #openstack-nova | 14:23 | |
| mriedem | gongysh: see the unified limits effort in keystone | 14:23 |
| mriedem | gongysh: https://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/unified-limits.html | 14:23 |
| *** lajoskatona has left #openstack-nova | 14:26 | |
| *** zen369 has quit IRC | 14:26 | |
| mriedem | ildikov: johnthetubaguy: replied in https://review.openstack.org/#/c/499777/4 about delete_on_termination | 14:29 |
| mriedem | tl;dr is that if we fail to delete a volume we handle the error and log a warning, everywhere | 14:30 |
| johnthetubaguy | mriedem: so you think we just allow delete_on_termination for multi-attach volumes? | 14:30 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 14:30 |
| mriedem | so if you boot from volume with a multi-attach volume and specify delete_on_termination=True, and that volume is attached to another instance when the first is deleted, it won't prevent the deletion on the first instance, it will just log a warning in the logs about being unable to delete the volume | 14:30 |
| *** gongysh has quit IRC | 14:31 | |
| johnthetubaguy | I guess it would just be deleted by the last detach, probably | 14:31 |
| mriedem | johnthetubaguy: i'm not sure there is a great reason to not allow it | 14:31 |
| mriedem | johnthetubaguy: well, not necessarily | 14:31 |
| mriedem | if instance A and B are attached to volume X, and A.delete_on_termination=True and B.delete_on_termination=False, then deleting A won't delete X and deleting B won't either | 14:32 |
| johnthetubaguy | I think its a race for the delete, like it could delete it | 14:32 |
| johnthetubaguy | yeah | 14:32 |
| *** slaweq_ has quit IRC | 14:32 | |
| johnthetubaguy | I should have defined my "probably" bit better | 14:32 |
| mriedem | if B is deleted before A, then yes X would be deleted | 14:32 |
| mriedem | ultimately the lock is supposed to be on the cinder side | 14:33 |
| johnthetubaguy | ++ | 14:33 |
| *** edand has joined #openstack-nova | 14:33 | |
| mriedem | and i think it's just something a user would have to understand if they are attaching a multi-attach volume to an instance with delete_on_termination, that nova can't actually delete that volume if it's attached to another instance | 14:33 |
| johnthetubaguy | OK, my thinking was, seems odd to delete a multi-attach volume on delete, gonna be racey, lets just not allow that flag to be set. | 14:33 |
| ildikov | so the conclusion is to allow it, right? | 14:33 |
| ildikov | mriedem: +1 | 14:34 |
| mriedem | ildikov: i don't see a reason not to | 14:34 |
| ildikov | mriedem: cool, my thinking as well | 14:34 |
| johnthetubaguy | OK, so you are both thinking that way, willing to go with that | 14:34 |
| ildikov | johnthetubaguy: thank you :) | 14:34 |
| *** hongbin has joined #openstack-nova | 14:34 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Send Allocations to spawn https://review.openstack.org/511879 | 14:35 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 14:35 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | 14:35 |
| *** yangyapeng has quit IRC | 14:35 | |
| *** yangyapeng has joined #openstack-nova | 14:36 | |
| *** dave-mccowan has joined #openstack-nova | 14:37 | |
| *** shaner has quit IRC | 14:37 | |
| *** artom has quit IRC | 14:38 | |
| *** pwiltsey has joined #openstack-nova | 14:38 | |
| *** namnh has joined #openstack-nova | 14:40 | |
| *** josecastroleon has quit IRC | 14:40 | |
| *** links has quit IRC | 14:41 | |
| *** tonygunk has joined #openstack-nova | 14:41 | |
| *** josecastroleon has joined #openstack-nova | 14:42 | |
| *** sree has joined #openstack-nova | 14:44 | |
| *** shaner has joined #openstack-nova | 14:47 | |
| *** karthiks has quit IRC | 14:47 | |
| *** yamamoto has joined #openstack-nova | 14:47 | |
| *** yamamoto has quit IRC | 14:47 | |
| *** tbachman has quit IRC | 14:50 | |
| *** catintheroof has joined #openstack-nova | 14:51 | |
| johnthetubaguy | mriedem: if you get a moment, I attempted pseudo code for the shared connection locking, that feels like the last bit of detail we need in there: https://review.openstack.org/#/c/499777/5/specs/queens/approved/cinder-volume-multi-attach.rst@53 | 14:56 |
| sean-k-mooney | johnthetubaguy: cfriesen am i remebering correctly that ye were both interested in bandwidth based scheduling at the ptg | 14:58 |
| johnthetubaguy | sean-k-mooney: I was probably incorrectly interested, snowed up with other things honestly | 14:58 |
| sean-k-mooney | johnthetubaguy: ack ok i was just going to flag https://review.openstack.org/#/c/502306/12 to you if you cared to review | 14:59 |
| *** sdague has quit IRC | 14:59 | |
| *** cdent has joined #openstack-nova | 14:59 | |
| johnthetubaguy | sean-k-mooney: cool, can't promise I will get to that I am afraid, chasing a few other things | 15:00 |
| sean-k-mooney | johnthetubaguy: no worries | 15:00 |
| *** rabel has quit IRC | 15:01 | |
| mriedem | sean-k-mooney: i know huawei is interested in that | 15:01 |
| mriedem | but i haven't had a chance to review the spec yet | 15:01 |
| *** sahid has quit IRC | 15:02 | |
| *** sahid has joined #openstack-nova | 15:02 | |
| sean-k-mooney | mriedem: ralonsoh is getting a little concerned that it may get caught by the spec approval deadline on thrusday? | 15:02 |
| *** catintheroof has quit IRC | 15:03 | |
| mriedem | everyone is getting concerned about that for their specs | 15:03 |
| melwitt | mriedem: the py3 packages are definitely in the pike uca. how does checking for the py3 env protect against packages missing < pike? | 15:03 |
| mriedem | melwitt: because the jobs that this is breaking aren't running with py3 | 15:03 |
| mriedem | that check is based on a localrc flag set by devstack-gate which is set by the job config | 15:03 |
| mriedem | our live migration job which uses ceph does not run under py3 | 15:04 |
| sean-k-mooney | efried: bauzas ye both previously reviewed https://review.openstack.org/#/c/502306/12 is it on your backlog to re review in the next few days? | 15:04 |
| melwitt | mriedem: ack | 15:04 |
| bauzas | sean-k-mooney: thanks for the ping, sure I'll do | 15:04 |
| *** aloga has quit IRC | 15:04 | |
| mriedem | johnthetubaguy: reading - not sure how the lock fixes things when the instances attached to the volume are on different compute hosts and we're not using a DLM | 15:04 |
| *** aloga has joined #openstack-nova | 15:04 | |
| mriedem | but i know we've been over that | 15:04 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 15:05 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | 15:05 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 15:05 |
| sean-k-mooney | mriedem: ack, that is fair i just said i would flag it again incase anyone was interested. | 15:05 |
| johnthetubaguy | mriedem: there is no conflict there, AFAIK, I thought it was just on the operations os-brick does on the hypervisor (and the operations cinder does on delete_attachment and update_attachment) | 15:06 |
| *** ragiman has quit IRC | 15:06 | |
| efried | sean-k-mooney Can do; though I'm not sure I'm qualified to +1 it. | 15:06 |
| johnthetubaguy | mriedem: although I think I see what you mean now | 15:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552 | 15:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | 15:07 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 15:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623 | 15:07 |
| johnthetubaguy | mriedem: I guess we must have assumed a separate connection from each hypervisor, which doesn't seem quite correct | 15:08 |
| sean-k-mooney | efried: well if you have concers about the proposal or the wording others probably do too so adressing those in the spec makes it better in general | 15:08 |
| efried | sean-k-mooney Agree. I'll give it a full pass later today. | 15:08 |
| ericyoung | the scaleio imagebackend patch has been updated and gotten through CI if anyone wants to take a look | 15:08 |
| ericyoung | https://review.openstack.org/#/c/407440/ | 15:08 |
| *** artom has joined #openstack-nova | 15:10 | |
| cdent | edleafe-: I don’t understand you caffeine comment. So I tried to clarify. | 15:11 |
| *** penick has joined #openstack-nova | 15:13 | |
| *** edleafe- is now known as edleafe | 15:14 | |
| edleafe | cdent: "Is this a candidate for on the Selection object?" | 15:15 |
| edleafe | "for on" was the confusing bit | 15:15 |
| *** tssurya has quit IRC | 15:15 | |
| cdent | “Is this method a candidate for on the selection object?” | 15:16 |
| cdent | but yes, the caffeine is broken today | 15:16 |
| cdent | bad vintage or something | 15:16 |
| edleafe | To answer your clarification, there was pushback on adding too much stuff to the Selection object. It could easily be there instead of the scheduler manager. The only preference is that it would never be used outside of the scheduler manager. | 15:16 |
| *** tbachman has joined #openstack-nova | 15:17 | |
| *** markvoelker has quit IRC | 15:17 | |
| *** markvoelker has joined #openstack-nova | 15:18 | |
| *** Oku_OS is now known as Oku_OS-away | 15:18 | |
| *** josecastroleon has quit IRC | 15:19 | |
| *** gongysh has joined #openstack-nova | 15:20 | |
| *** gongysh has quit IRC | 15:20 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax https://review.openstack.org/510244 | 15:21 |
| cdent | edleafe: if it’s only ever used the scheduler manager then yeah, there seems fine. | 15:22 |
| efried | dansmith -10% ^ | 15:22 |
| * cdent is not down with OOP | 15:22 | |
| *** markvoelker has quit IRC | 15:22 | |
| *** sshwarts has quit IRC | 15:23 | |
| *** chyka has joined #openstack-nova | 15:23 | |
| dansmith | efried: standard negotiation tactic is expect being able to knock 10% off, so that seems substantial | 15:23 |
| *** josecastroleon has joined #openstack-nova | 15:23 | |
| dansmith | efried: on a call now but I'll look in a bit | 15:23 |
| efried | nod, thx | 15:23 |
| *** tbachman has quit IRC | 15:27 | |
| *** tssurya has joined #openstack-nova | 15:27 | |
| mriedem | ildikov: johnthetubaguy: ok my comments inline https://review.openstack.org/#/c/499777/ | 15:28 |
| bauzas | mriedem: gibi: I have some concerns by seeing duplicate code in https://review.openstack.org/#/c/510938/5/nova/compute/manager.py | 15:29 |
| mriedem | bauzas: duplicate with what? | 15:29 |
| mriedem | the RT? | 15:29 |
| bauzas | mriedem: yup | 15:29 |
| mriedem | that's intentional | 15:29 |
| bauzas | delete_alloc_for_moved() | 15:29 |
| bauzas | I know | 15:29 |
| bauzas | but that's still duplicate | 15:29 |
| *** psachin has joined #openstack-nova | 15:29 | |
| bauzas | even if intentional :p | 15:30 |
| mriedem | bauzas: see PS2 | 15:30 |
| *** AlexeyAbashkin has quit IRC | 15:30 | |
| bauzas | mriedem: I agree with your point to not call the RT method | 15:30 |
| *** AlexeyAbashkin has joined #openstack-nova | 15:30 | |
| bauzas | mriedem: but we have a compute.utils helper module AFAIK | 15:30 |
| bauzas | my main concern is that a modification would require two places | 15:31 |
| mriedem | the only duplication is L698-L706 https://review.openstack.org/#/c/510938/5/nova/compute/manager.py | 15:32 |
| bauzas | I agree | 15:32 |
| mriedem | whch is also in _delete_allocation_after_move now | 15:32 |
| mriedem | :) | 15:32 |
| mriedem | and _rollback_live_migration | 15:33 |
| bauzas | mriedem: but what if someone wants to add another call ? | 15:33 |
| mriedem | so how about we do the consolidation into a util in a follow up? | 15:33 |
| bauzas | I'm fine with that | 15:33 |
| mriedem | hell, we could just do a private method inthe compute manager itself | 15:33 |
| bauzas | I haven't reviewed the change | 15:33 |
| mriedem | if you don't want to touch the RT | 15:33 |
| bauzas | I just wanted to open a discussion | 15:34 |
| mriedem | i'm cool with refactoring out the duplication, but not in this change since it has to be backported | 15:34 |
| bauzas | but yeah, if we were doing the consolidation, would be worth doing all of it in a single patch | 15:34 |
| *** jobewan has joined #openstack-nova | 15:34 | |
| bauzas | that's a good point | 15:34 |
| bauzas | ok, I'll leave a comment and +W | 15:34 |
| *** tbachman has joined #openstack-nova | 15:35 | |
| *** sree has quit IRC | 15:37 | |
| *** tbachman_ has joined #openstack-nova | 15:37 | |
| *** sree has joined #openstack-nova | 15:37 | |
| *** markus_zz has quit IRC | 15:37 | |
| *** sree has quit IRC | 15:38 | |
| *** sree has joined #openstack-nova | 15:38 | |
| *** sree has quit IRC | 15:39 | |
| *** sree has joined #openstack-nova | 15:39 | |
| *** tbachman has quit IRC | 15:40 | |
| *** tbachman_ is now known as tbachman | 15:40 | |
| *** AlexeyAbashkin has quit IRC | 15:41 | |
| *** sree has quit IRC | 15:43 | |
| *** sdague has joined #openstack-nova | 15:44 | |
| mriedem | bauzas: if you've got the time, we also need these stable/pike backports https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+topic:bug/1715182 | 15:45 |
| *** chyka_ has joined #openstack-nova | 15:45 | |
| mriedem | lyarwood: ^ | 15:45 |
| bauzas | mriedem: lyarwood is off sick | 15:45 |
| mriedem | too much volume encryption will do that | 15:45 |
| bauzas | I have an internal meeting until 4pm UTC, so I guess I have 13 mins of free time now :) | 15:47 |
| *** chyka has quit IRC | 15:47 | |
| *** jwcroppe_ has joined #openstack-nova | 15:47 | |
| *** yamamoto has joined #openstack-nova | 15:48 | |
| *** sdague has quit IRC | 15:48 | |
| *** sridharg has quit IRC | 15:49 | |
| *** jwcroppe has quit IRC | 15:49 | |
| *** andreas_s has quit IRC | 15:52 | |
| *** gouthamr has quit IRC | 15:54 | |
| *** yamamoto has quit IRC | 15:55 | |
| *** gouthamr_ has joined #openstack-nova | 15:55 | |
| *** owalsh_ is now known as owalsh | 15:59 | |
| *** slaweq has joined #openstack-nova | 15:59 | |
| *** yassine has quit IRC | 15:59 | |
| *** abhi89 has quit IRC | 15:59 | |
| melwitt | mriedem: I'm okay with this libvirt driver change now, to detach and reattach volumes during reboot. apparently there have been summit and PTG discussions about doing that in hard reboot for some time, so if that's the plan anyway, it seems fine to me https://review.openstack.org/#/c/400384 | 16:00 |
| mriedem | i don't remember those discussions | 16:00 |
| *** pcaruana has quit IRC | 16:01 | |
| *** namnh has quit IRC | 16:02 | |
| dansmith | I do, it was around the need to re-fresh the connection info for monitor ip changes, IIRC | 16:02 |
| mriedem | that's not this though | 16:02 |
| *** josecastroleon has quit IRC | 16:03 | |
| dansmith | I haven't looked at the patch, but okay | 16:04 |
| dansmith | we did talk about re-building the storage connections on reboot for that reason though | 16:04 |
| *** namnh has joined #openstack-nova | 16:04 | |
| *** vladikr has quit IRC | 16:04 | |
| *** vladikr has joined #openstack-nova | 16:05 | |
| mriedem | yeah i remember that, and have the todo for it still | 16:05 |
| *** sdague has joined #openstack-nova | 16:05 | |
| *** josecastroleon has joined #openstack-nova | 16:07 | |
| mriedem | ok so we have an encrypted volume test in tempest, i could just modify that to hard reboot the instance after an ecrypted volume is attached and it should blow up the instance right? | 16:08 |
| dansmith | efried: did alex_xu get everything resolved that he was concerned about on that spec? I saw a bunch of discussion here | 16:08 |
| melwitt | mriedem: I think so, yes | 16:08 |
| mriedem | melwitt: ok in that case i'm going to tweak tempest to recreate the failure and then make it depend on the nova fix | 16:09 |
| mriedem | melwitt: jbernard: https://review.openstack.org/#/c/512622/ is passing | 16:09 |
| mriedem | we need to get that in asap to unblock nova stable | 16:09 |
| mriedem | jdurgin: ^ | 16:09 |
| melwitt | mriedem: sounds like a good idea | 16:09 |
| *** lucasagomes is now known as lucas-afk | 16:10 | |
| melwitt | mriedem: you did a Depends-On to see it pass on stable? | 16:10 |
| mriedem | melwitt: i can quick | 16:10 |
| melwitt | okay, just wanted to make sure that's going to work for you | 16:11 |
| *** Apoorva has joined #openstack-nova | 16:11 | |
| efried | dansmith Not really. We need another writeup. OTP, give me a few mins. | 16:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: libvirt: add check for VIR_DOMAIN_BLOCK_REBASE_COPY_DEV https://review.openstack.org/512406 | 16:11 |
| mriedem | melwitt: ^ | 16:11 |
| dansmith | efried: more in this spec? i thought he was suggesting another spec.. but sure, np | 16:12 |
| efried | dansmith Which spec are we talking about? | 16:13 |
| dansmith | efried: your granular request word-a-palooza | 16:14 |
| efried | dansmith Oh, no, that should be solid as is. Whatever else needs to come out of that will have to go... somewhere else. | 16:16 |
| dansmith | efried: okay that's what I thought, but wanted to clarify | 16:16 |
| dansmith | so I was going to drop my +2 on there, but didn't want to if alex_xu had more things implied from his +0 earlier | 16:17 |
| *** namnh has quit IRC | 16:19 | |
| *** namnh has joined #openstack-nova | 16:20 | |
| *** sambetts is now known as sambetts|afk | 16:26 | |
| *** psachin has quit IRC | 16:27 | |
| *** josecastroleon has quit IRC | 16:29 | |
| *** salv-orl_ has joined #openstack-nova | 16:29 | |
| *** tbachman has quit IRC | 16:30 | |
| *** salv-orlando has quit IRC | 16:32 | |
| *** josecastroleon has joined #openstack-nova | 16:32 | |
| jbernard | mriedem, melwitt: +A'd, thanks ya'll | 16:33 |
| *** ralonsoh has quit IRC | 16:33 | |
| melwitt | jbernard: awesome, thanks | 16:33 |
| mriedem | sean-k-mooney: comments inline https://review.openstack.org/#/c/502306/ | 16:33 |
| *** yamahata has quit IRC | 16:34 | |
| mriedem | sean-k-mooney: honestly i think that's going to be a very tough mountain to climb at this point given all of the dependencies | 16:34 |
| mriedem | sean-k-mooney: there seems to be a fundamental mistaken assertion in there that nova creates ports before a host is chosen | 16:34 |
| mriedem | which is not the case | 16:34 |
| mriedem | jbernard: thanks | 16:34 |
| sean-k-mooney | mriedem: i taught nova called the create_or_get port api before calling placement? | 16:35 |
| *** gszasz has quit IRC | 16:35 | |
| sean-k-mooney | mriedem: but thank for reviewing. yes this does have a lot of dependncies | 16:35 |
| mriedem | sean-k-mooney: no, ports are created during allocate_for_instance in the compute service | 16:35 |
| mriedem | after a host is chosen by the scheduler | 16:35 |
| mriedem | johnthetubaguy has an older spec to move port creation to conductor, which might be another dependency for this | 16:36 |
| mriedem | sean-k-mooney: isn't the qos policy applied to the port? | 16:36 |
| sean-k-mooney | mriedem: but how will it know if it should be creating a sriov port or normal port if it only did it at the compute node | 16:36 |
| mriedem | sean-k-mooney: nova doesn't create sriov ports | 16:36 |
| mriedem | nova creates regular old boring ports | 16:36 |
| mriedem | if you need a fancy nfv port, you create it in neutron and provide it when creating the server | 16:37 |
| mriedem | if the qos policy is applied to the port, and nova creates the port, then i think we assert that nova-created ports don't have minimum bandwidth guarantees | 16:37 |
| mriedem | easy peasy | 16:37 |
| sean-k-mooney | mriedem: yes the qos policy is on the port but it can also be on the network which adds it to the port automatically | 16:37 |
| mriedem | if you want the fancy, you precreate the port | 16:37 |
| mriedem | ok then that gets complicated, | 16:37 |
| sean-k-mooney | mriedem: yes you are right sriov or qos implies you precreate the port | 16:38 |
| mriedem | because you can create a server with a nic uuid and nova will create the port in that network | 16:38 |
| *** penick_ has joined #openstack-nova | 16:38 | |
| johnthetubaguy | that sounds a lot like the routed network case that triggered the move to conductor thingy | 16:38 |
| mriedem | and if the qos policy on the network doesn't match the compute host i guess you have problems | 16:38 |
| mriedem | johnthetubaguy: yes | 16:38 |
| *** mvk has quit IRC | 16:38 | |
| *** suresh12 has joined #openstack-nova | 16:39 | |
| johnthetubaguy | sean-k-mooney: if you want to take on the refactor it is now I think just a case of moving the code, we create missing ports (the conductor bit), then update all the ports (the compute bit) | 16:40 |
| mriedem | the spec also doesn't really mention any details about move operations, which we know are the hairiest thing to deal with | 16:40 |
| *** tonygunk has quit IRC | 16:40 | |
| *** penick has quit IRC | 16:40 | |
| mriedem | because during a move the allocations have to be made on the target host and eventually removed from the source host - is the neutron agent going to screwed up by that? | 16:41 |
| mriedem | *to get | 16:41 |
| sean-k-mooney | mriedem: it should not as neutron will not be doing allocations from placement iteself | 16:41 |
| sean-k-mooney | mriedem: but that said we have not gone into details of the move operations in the spec | 16:42 |
| melwitt | stephenfin: I refactored the unit tests to address your comment https://review.openstack.org/#/c/498983 | 16:42 |
| mriedem | sean-k-mooney: that was another thing, the spec loosely talked about modifying the nova resource tracker, i think to create allocations for these bandwidth things, but we want the scheduler to create allocations, not the compute (RT) | 16:43 |
| mriedem | because when you move the instance, the source host RT might overwrite the allocations for the instance which are meant for the dest host | 16:44 |
| mriedem | because of periodic task race window wackiness | 16:44 |
| *** abalutoiu has joined #openstack-nova | 16:44 | |
| sean-k-mooney | mriedem: yes in the future we defiently want to move the allocation out of the compute node the sepc was assuming the workflow we have today where the compute node does the allocation but i dont think it would break if the allocation was done earlier | 16:45 |
| *** hieulq_ has joined #openstack-nova | 16:46 | |
| mriedem | sean-k-mooney: if today is >= pike, we don't create allocatoins in the computes anymore | 16:46 |
| mriedem | allocations in the computes is soooooo 2 months ago :) | 16:46 |
| sean-k-mooney | mriedem: oh did that land in pike cool | 16:46 |
| mriedem | yeah i linked to the change in the spec | 16:46 |
| mriedem | as a result of that change we've been doing a lot of cleanup of places where we dont cleanup allocations | 16:47 |
| sean-k-mooney | mriedem: so is that now done in the conductor/scheduler | 16:47 |
| mriedem | still working on getting those fixes into stable/pike | 16:47 |
| mriedem | the scheduler claims yes | 16:47 |
| mriedem | for VCPUS/MEMORY_MB/DISK_GB | 16:47 |
| mriedem | if you have NUMATopologyLimits, those get claimed in the compute still, | 16:47 |
| mriedem | since we don't model NUMA via nested RPs in placement yet | 16:47 |
| sean-k-mooney | pci device im guessing are still on compute node too for same reason | 16:48 |
| mriedem | yeah | 16:48 |
| sean-k-mooney | to do the claim for the bandwidth in the scheduler we would also have to bind the port in the scheduler | 16:49 |
| mriedem | pci request claims are handled differently from numa limits somehow, i can't remember the details | 16:49 |
| mriedem | sean-k-mooney: why? | 16:49 |
| mriedem | scheduler picks a host, makes the bandwidth allocation against that host, and the port is later bound to the host in the compute | 16:50 |
| sean-k-mooney | to know which network backend to claim the bandwitdh form | 16:50 |
| mriedem | if we fail on the compute, we deallocate | 16:50 |
| sean-k-mooney | e.g. sriov and ovs on same host | 16:50 |
| mriedem | so we don't know the network backend until we bind the host and get a binding:profile from neutron? | 16:50 |
| sean-k-mooney | correct. | 16:51 |
| mriedem | well shit balls | 16:51 |
| mriedem | that's what i call a catch-2 | 16:51 |
| mriedem | *catch-22 | 16:51 |
| sean-k-mooney | that is why we assumed the current workflow in the spec | 16:51 |
| mriedem | yeah... | 16:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Reproduce bug 1721652 in the functional test env https://review.openstack.org/511759 | 16:53 |
| openstack | bug 1721652 in OpenStack Compute (nova) "Evacuate cleanup fails at _delete_allocation_for_moved_instance" [High,In progress] https://launchpad.net/bugs/1721652 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: fix cleaning up evacuated instances https://review.openstack.org/512716 | 16:53 |
| sean-k-mooney | before ovs offload we could have used the vnic type to differenciate sriov and ovs/linuxbirdge/vpp... but now we cant since vnic type direct is valid for both | 16:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: fix cleaning up evacuated instances https://review.openstack.org/512716 | 16:53 |
| gibi | mriedem, bauzas: sorry I was away from the computer. I can do the suggested refactor of https://review.openstack.org/#/c/510938/ in a follow up | 16:54 |
| *** edand has quit IRC | 16:55 | |
| *** vvargaszte has joined #openstack-nova | 16:57 | |
| *** suresh12 has quit IRC | 16:58 | |
| sean-k-mooney | mriedem: anyway thanks for reviewing it. one spec that is hopefully less contoversial since it was approved last cycle is https://review.openstack.org/#/c/504895/ i think all the code for that has been up for a few months also | 16:58 |
| sean-k-mooney | mriedem: johnthetubaguy oh by the way was this https://review.openstack.org/#/c/499777/5 the cinder attach work you were suggesting emultating for the multiple port binding in relation to how upgrades should work | 17:00 |
| mriedem | sean-k-mooney: no | 17:00 |
| mriedem | sec | 17:00 |
| mriedem | sean-k-mooney: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/cinder-new-attach-apis.html | 17:00 |
| *** vks1 has quit IRC | 17:00 | |
| sean-k-mooney | mriedem: ah ok i have basically added johnthetubaguy suggestions to the latest version but ill go read that now | 17:01 |
| sean-k-mooney | mriedem: thanks | 17:01 |
| *** tesseract has quit IRC | 17:02 | |
| mriedem | i need to read the updates on the portbinding spec too | 17:02 |
| edleafe | dansmith: Here's the scenario: cell conductor gets a list of alternates after the initial build attempt fails. Assume that all of these alternates are stale, and no longer have enough resources. Should the cell conductor just log it and do nothing, or should it raise an exception? | 17:02 |
| edleafe | And if an exception, what kind? | 17:02 |
| mriedem | NoValidHost? | 17:03 |
| mriedem | cell conductor raising NoValidHost is something that can already happen today when you run out of alternatives | 17:03 |
| mriedem | it will log a fault | 17:03 |
| mriedem | instance goes to ERROR state | 17:03 |
| mriedem | easy peasy | 17:03 |
| dansmith | edleafe: it should do whatever would happen if we had no retries left in the current path | 17:03 |
| dansmith | yeah | 17:03 |
| dansmith | that | 17:03 |
| edleafe | mriedem: that was my assumption, but I wanted to be sure there wasn't some other action | 17:03 |
| openstackgerrit | Jan Zerebecki proposed openstack/nova master: Fix wording of debug message for future releases https://review.openstack.org/508261 | 17:04 |
| *** slaweq has quit IRC | 17:04 | |
| edleafe | ah, so that should be the same as what happens in compute when there are no retries left. | 17:04 |
| dansmith | right | 17:04 |
| *** penick_ has quit IRC | 17:05 | |
| *** tbachman has joined #openstack-nova | 17:06 | |
| *** penick has joined #openstack-nova | 17:07 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: WIP: Transform scheduler.select_destinations notification https://review.openstack.org/508506 | 17:08 |
| *** hieulq_ has quit IRC | 17:09 | |
| *** derekh has quit IRC | 17:09 | |
| *** yamahata has joined #openstack-nova | 17:11 | |
| *** ociuhandu has quit IRC | 17:11 | |
| dansmith | edleafe: so, looking at your third patch, | 17:12 |
| dansmith | edleafe: we have limits in the reqspec, | 17:12 |
| dansmith | oh, | 17:13 |
| *** jwcroppe_ has quit IRC | 17:13 | |
| dansmith | the selection limits are really just for the return value from the rpc call to continue to include them is that right? | 17:13 |
| dansmith | I was thinking we had to have them for communicating to the compute, but that is in reqspec | 17:13 |
| dansmith | is that right? | 17:13 |
| edleafe | dansmith: the caching scheduler needs them | 17:13 |
| dansmith | the caching scheduler _sets_ them | 17:14 |
| dansmith | the compute _needs_ them | 17:14 |
| *** weshay|ruck is now known as weshay|afk_see_r | 17:14 | |
| edleafe | ok, I thought it was needed in the filters | 17:14 |
| dansmith | my point is, we really just need them in Selection so that the return from select_destinations(), which is now a bunch of Selections, can include the limits back to conductor, | 17:15 |
| edleafe | but yeah, the compute will need them too | 17:15 |
| dansmith | which will populate the reqspec | 17:15 |
| dansmith | the filters don't need them, the filters are what put things into limits | 17:15 |
| edleafe | ok, I guess I misunderstood mriedem's concerns | 17:15 |
| dansmith | compute can get them from the reqspec | 17:15 |
| mriedem | the limits are stored in the reqspec? | 17:18 |
| mriedem | tbc, we pass a reqspec down to build_and_run_instance in compute and it's *totally* ignored | 17:19 |
| mriedem | we pass the limits dict separately | 17:19 |
| *** dtantsur is now known as dtantsur|afk | 17:19 | |
| *** jpena is now known as jpena|off | 17:19 | |
| mriedem | ok i see the SchedulerLimits field in the request spec | 17:19 |
| mriedem | i just don't think compute is using that today | 17:20 |
| dansmith | mriedem: right, so this will be passing limits N more times than we currently pass it | 17:20 |
| dansmith | I'm thinking maybe we just have select_destinations return (reqspec, alternates) with reqspec updated with limits, | 17:20 |
| dansmith | and then we can avoid putting them into the selection | 17:20 |
| dansmith | aside from numa, they'll be the same for num_instances, right? | 17:21 |
| mriedem | need to see what actually populates RequestSpec.limits today | 17:21 |
| dansmith | I think it's populate_filter_properties | 17:21 |
| *** AlexeyAbashkin has joined #openstack-nova | 17:22 | |
| dansmith | https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L367 | 17:23 |
| mriedem | yeah looking at what calls that | 17:24 |
| dansmith | conductor | 17:24 |
| *** AlexeyAbashkin has quit IRC | 17:24 | |
| dansmith | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1110-L1110 | 17:24 |
| mriedem | god what a weird mess | 17:25 |
| dansmith | yeah | 17:25 |
| dansmith | it's also still in the half-uncleaned-up reqspec object | 17:25 |
| dansmith | the only problem is, | 17:25 |
| dansmith | I think numa limits will be per-host, | 17:25 |
| dansmith | although,hmm | 17:25 |
| dansmith | maybe the regular limits won't because of the allocation ratios or something? | 17:26 |
| *** mvk has joined #openstack-nova | 17:26 | |
| dansmith | yeah, toast | 17:26 |
| mriedem | we also aren't doing this trick for evacuate | 17:26 |
| dansmith | gdi | 17:26 |
| mriedem | not really sure why we have RequestSpec.limits at all since it's not used anywhere, i guess because RequestSpec was supposed to replace filter_properties | 17:27 |
| dansmith | the thing that goes into limits for things like ramfilter varies per host | 17:27 |
| dansmith | mriedem: yeah, all that is unfinished | 17:27 |
| *** penick_ has joined #openstack-nova | 17:27 | |
| dansmith | mriedem: so we pass it in reqspec, and as an arg, and now in N alternates | 17:28 |
| dansmith | oh and we pass filter_properties too | 17:28 |
| *** salv-orlando has joined #openstack-nova | 17:28 | |
| mriedem | to build_and_run_instance | 17:28 |
| dansmith | so reqspec, filter_properties, limits, and N*selection | 17:28 |
| mriedem | yeah heh | 17:28 |
| dansmith | I wonder if that's enough redundancy | 17:28 |
| mriedem | RAID-4? | 17:28 |
| mriedem | for limits | 17:29 |
| *** bastimalo has joined #openstack-nova | 17:29 | |
| dansmith | this is like raid 50 | 17:29 |
| mriedem | ok yeah so the allocation ratios are per host, | 17:29 |
| mriedem | so the limits are per host | 17:29 |
| mriedem | so they go into the selection object yeah? | 17:29 |
| *** bastimalo has left #openstack-nova | 17:30 | |
| dansmith | yeah, have to | 17:30 |
| *** penick has quit IRC | 17:30 | |
| mriedem | and RequestSpec.limits is i guess just the same as the first host chosen | 17:30 |
| dansmith | and filter properties | 17:30 |
| dansmith | and limits | 17:30 |
| *** salv-orl_ has quit IRC | 17:32 | |
| *** salv-orlando has quit IRC | 17:32 | |
| mriedem | maybe this is an appropriate time to drop this in here https://review.openstack.org/#/c/499799/ | 17:33 |
| mriedem | removes 5% of the request spec TODOs | 17:33 |
| *** penick_ has quit IRC | 17:36 | |
| *** ociuhandu has joined #openstack-nova | 17:39 | |
| *** vvargaszte has quit IRC | 17:41 | |
| *** ijw has joined #openstack-nova | 17:41 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 17:43 |
| *** ijw has quit IRC | 17:45 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Send Allocations to spawn https://review.openstack.org/511879 | 17:46 |
| efried | dansmith gibi I think I hit your concerns ^ | 17:46 |
| *** gjayavelu has joined #openstack-nova | 17:47 | |
| *** ijw has joined #openstack-nova | 17:48 | |
| *** mvk has quit IRC | 17:48 | |
| *** josecastroleon has quit IRC | 17:49 | |
| *** mvk has joined #openstack-nova | 17:49 | |
| *** ijw has quit IRC | 17:50 | |
| *** ijw has joined #openstack-nova | 17:50 | |
| *** shaner has quit IRC | 17:50 | |
| *** josecastroleon has joined #openstack-nova | 17:52 | |
| *** gouthamr_ is now known as gouthamr | 17:52 | |
| *** gabor_antal_km has joined #openstack-nova | 17:53 | |
| *** gabor_antal_ has quit IRC | 17:53 | |
| *** fragatina has quit IRC | 17:53 | |
| *** slaweq has joined #openstack-nova | 17:57 | |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.54 - Add trusted_image_certificates https://review.openstack.org/500396 | 17:59 |
| *** penick has joined #openstack-nova | 18:00 | |
| *** abhi89 has joined #openstack-nova | 18:00 | |
| *** baoli has quit IRC | 18:00 | |
| *** baoli has joined #openstack-nova | 18:01 | |
| *** slaweq has quit IRC | 18:02 | |
| *** Apoorva_ has joined #openstack-nova | 18:02 | |
| *** Apoorva has quit IRC | 18:05 | |
| *** suresh12 has joined #openstack-nova | 18:06 | |
| *** yassine has joined #openstack-nova | 18:07 | |
| openstackgerrit | Merged openstack/nova master: fix cleaning up evacuated instances https://review.openstack.org/510938 | 18:08 |
| dansmith | efried: sorry if I wasn't clear, but I don't think adding a whole new fixture just to mock that one thing makes sense, | 18:09 |
| dansmith | I just wanted you to use MonkeyPatch in there instead of mock.start() and addCleanup() | 18:10 |
| *** MVenesio has joined #openstack-nova | 18:11 | |
| dansmith | efried: like this for example: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_virt_drivers.py#L96 | 18:11 |
| *** Tom__ has quit IRC | 18:12 | |
| *** suresh12 has quit IRC | 18:13 | |
| *** namnh has quit IRC | 18:15 | |
| *** abalutoiu_ has joined #openstack-nova | 18:15 | |
| *** suresh12 has joined #openstack-nova | 18:17 | |
| *** abalutoiu has quit IRC | 18:19 | |
| *** shaner has joined #openstack-nova | 18:19 | |
| gregwork | is there a way to pass custom options to qemu via nova ? | 18:22 |
| gregwork | such that when a guest starts up it starts with those extra options | 18:22 |
| *** suresh12 has quit IRC | 18:27 | |
| *** shaner has quit IRC | 18:27 | |
| *** baoli has quit IRC | 18:27 | |
| *** shaner has joined #openstack-nova | 18:28 | |
| artom | gregwork, like literally custom qemu command line options? No. | 18:28 |
| mriedem | artom: do you care about updating this newton change? https://review.openstack.org/#/c/467321/ | 18:28 |
| mriedem | artom: looks like it would need to cherry pick from https://review.openstack.org/#/c/482219/ in ocata | 18:29 |
| mriedem | newton eol is tomorrow | 18:29 |
| artom | mriedem, aha, thanks for the heads up | 18:29 |
| artom | Yeah, lemme do that now | 18:29 |
| *** penick has quit IRC | 18:30 | |
| *** suresh12 has joined #openstack-nova | 18:31 | |
| *** suresh12 has quit IRC | 18:31 | |
| efried | dansmith okay. | 18:31 |
| *** suresh12_ has joined #openstack-nova | 18:31 | |
| mriedem | dansmith: want to put this in? https://review.openstack.org/#/c/507557/ - the change on stable/ocata is merged, which is what i think tony was waiting for | 18:33 |
| melwitt | mriedem, dansmith: I've got a change up to remove a lot of old quotas code. the only thing I'm not 100% about is the Quotas object methods, I assume they can't be removed until a major version bump. https://review.openstack.org/#/c/511689 | 18:34 |
| *** hemna_ has quit IRC | 18:34 | |
| mriedem | i've got that one starred, hadn't been through it yet though | 18:34 |
| dansmith | mriedem: ack | 18:34 |
| gregwork | artom: im trying to get qemu to spawn the guest with -mem-path /dev/hugetlbfs and -mem-prealloc as per my mellanox dpdk guide | 18:35 |
| mriedem | and yeah i suppose you can't remove the versioned object methods w/o a major bump | 18:35 |
| dansmith | yup | 18:35 |
| melwitt | yeah, I wasn't sure if that's true only for remotables or all | 18:35 |
| dansmith | if they're remotable, that is | 18:35 |
| gregwork | artom: not sure how to pull this off | 18:35 |
| dansmith | melwitt: non-remotables can be removed | 18:35 |
| dansmith | melwitt: you'll know because the hash won't change | 18:35 |
| *** josecastroleon has quit IRC | 18:35 | |
| *** baoli has joined #openstack-nova | 18:36 | |
| mriedem | what if the quota engine code behind the remotable object method is removed? | 18:36 |
| melwitt | dansmith: ah, cool. I put TODO remove in 2.0 on all of them but I could straight up remove the non-remotables | 18:36 |
| mriedem | thus breaking it? | 18:36 |
| melwitt | I put pass in | 18:36 |
| artom | gregwork, not really my area of expertise, but what's this mellanox dpdk guide you speak of? | 18:36 |
| *** ttsiouts has quit IRC | 18:36 | |
| mriedem | melwitt: ok | 18:36 |
| dansmith | melwitt: which is only one of them, AFAICT | 18:36 |
| melwitt | but yeah, I guess that would be bad if the other side expected a returned thing so nevermind | 18:36 |
| *** ttsiouts has joined #openstack-nova | 18:37 | |
| dansmith | mriedem: yeah, can't break a remotable method, so you can't just gut it, unless gutting it is the proper new behavior or something | 18:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: libvirt: add check for VIR_DOMAIN_BLOCK_REBASE_COPY_DEV https://review.openstack.org/512406 | 18:37 |
| mriedem | artom: we're going to need ^ if you want to get https://review.openstack.org/#/c/471356/ into newton | 18:37 |
| melwitt | dansmith: hm, so I wondered that, and I thought that's why we might have to keep all of the old quotas code until version 2.0 of the object? | 18:37 |
| dansmith | efried: idk about monkey vs. mock.. I had never seen mockpatch before until you used it | 18:38 |
| artom | mriedem, you mean the thing I said "lemme do that now"? ;) | 18:38 |
| dansmith | melwitt: it just depends on what you're removing | 18:38 |
| mriedem | artom: no, this is different | 18:38 |
| mriedem | artom: another one of your waylaid newton backports | 18:38 |
| *** josecastroleon has joined #openstack-nova | 18:38 | |
| artom | But I have so many | 18:38 |
| melwitt | dansmith: for example, the reserve() method passes straight through to the quota engine code and then onto the DB API code. so to prevent breaking the contract, we have to keep all of that no? | 18:39 |
| melwitt | I had thought I could just put "pass" in them. maybe we can since reserve() didn't return anything IIRC | 18:39 |
| dansmith | melwitt: well it depends.. if the side effects of the code are no longer desired, and the older remote can't tell a difference, then it doesn't matter | 18:40 |
| dansmith | that's the point of the isolation | 18:40 |
| dansmith | you're not breaking the contract by changing the behavior of the remotable, only if you change the remotely-visible behavior | 18:40 |
| dansmith | just like we make save() do new things like generate uuids even though older clients don't expect that | 18:40 |
| melwitt | yeah. I'm trying to think if the other side can or can't tell the difference. reserve() currently sets the 'reservations' attribute | 18:40 |
| dansmith | that's the new behavior, we just have to make sure we honor what they're expecting | 18:40 |
| dansmith | but not if NoOp is used right? | 18:41 |
| melwitt | yeah not if NoOp is used | 18:41 |
| artom | mriedem, ah, OK, the rebase thing. So your fix should merge before we merge the backport, which would squash your fix | 18:41 |
| *** vishwanathj has joined #openstack-nova | 18:41 | |
| melwitt | so it should already be resilient to that | 18:41 |
| mriedem | artom: yes | 18:41 |
| dansmith | so presumably we can keep the interface stable but neuter the new-side code so it's not doing anything right? | 18:41 |
| artom | Honestly, we can do internal backport to newton, so no massive rush | 18:41 |
| gregwork | artom: http://www.mellanox.com/related-docs/prod_software/MLNX_DPDK_Quick_Start_Guide_v16.11_1.5.pdf | 18:41 |
| artom | But upstream would obviously be appreciated :) | 18:42 |
| gregwork | artom: section 3.2 is the recommended settings for starting a kvm guest | 18:42 |
| melwitt | dansmith: yeah. looks like we can safely do that for any method overloaded by NoOp since NoOp does a pass for those | 18:42 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/newton: Catch InstanceNotFound exception https://review.openstack.org/467321 | 18:42 |
| *** cleong has quit IRC | 18:42 | |
| dansmith | melwitt: you'd think yeah | 18:42 |
| artom | mriedem, ^^ that's the tenant usage instancenotfound thing | 18:42 |
| artom | mriedem, I guess I can give you the +1 on your fix, but that's about the extent of my helping to push it through | 18:42 |
| *** Apoorva_ has quit IRC | 18:43 | |
| melwitt | dansmith: yeah, not guaranteed. some code out there might be assuming only the default driver and thus assume something like 'reservations' attribute would be set. I'm not sure if we need to account for that | 18:43 |
| mriedem | i need a stable hero to review these: https://review.openstack.org/#/c/493206/ https://review.openstack.org/#/c/506323/ https://review.openstack.org/#/c/509441/ https://review.openstack.org/#/c/508902/ | 18:43 |
| artom | With great power comes great responsibility, with no power you just sorta chill | 18:43 |
| *** Apoorva has joined #openstack-nova | 18:43 | |
| dansmith | melwitt: you can probably just make sure reservations is set to something that will make it not choke right? | 18:44 |
| *** suresh12_ has quit IRC | 18:44 | |
| melwitt | dansmith: yeah, maybe empty list would be good enough. hopefully no one could assume non-empty list | 18:44 |
| artom | gregwork, ah, OK. So they're not saying "in your openstack instance, make sure this command line is present" | 18:45 |
| *** suresh12 has joined #openstack-nova | 18:45 | |
| dansmith | melwitt: I don't have the usage of that field in my head so I'd have to look, but AFAIR, it's just passed back to commit or something | 18:45 |
| artom | gregwork, you just happen to be using openstack, whereas the doc is written for bare kvm/qemu | 18:45 |
| gregwork | artom: right | 18:45 |
| melwitt | commit() used to set reservations = None too, so that's a thing that's considered valid | 18:45 |
| artom | gregwork, nova does do hugepages and CPU pinning | 18:45 |
| melwitt | dansmith: yeah, I think only the object itself uses it. or at least that's the intention. but ppl could access it if they wanted, I don't know why they would tho | 18:46 |
| gregwork | artom: i am getting a qemu error trying to initialize the network with dpdk, i am trying to troubleshoot by making sure qemu-kvm is being invoked correctly | 18:46 |
| artom | gregwork, I dunno what version you're on, for for pike the docs are https://docs.openstack.org/nova/pike/admin/huge-pages.html and https://docs.openstack.org/nova/pike/admin/cpu-topologies.html | 18:46 |
| dansmith | melwitt: fwiw, I think you're overthinking this.. just set it to something and grep around for the uses of .reservations and make sure it'll be happy.. should be easy I think :) | 18:47 |
| mriedem | artom: +2 | 18:47 |
| melwitt | dansmith: I was getting confused by the idea of accounting for code that isn't in nova | 18:47 |
| dansmith | melwitt: eh? no need to do that, like always | 18:47 |
| dansmith | melwitt: what are you thinking of specifically? | 18:48 |
| artom | mriedem, woothanks | 18:48 |
| gregwork | artom: working with ocata atm | 18:48 |
| artom | gregwork, wait, you're getting a qemu error while spawning a VM through nova? | 18:48 |
| artom | That's... bad | 18:48 |
| gregwork | artom: yeah :/ | 18:48 |
| melwitt | dansmith: I thought that was what you were getting at. nothing calls these methods anymore as of queens, so I thought it didn't matter what they return or not. but I knew I couldn't remove them if they were remotable | 18:48 |
| artom | gregwork, and is most likely a nova and/or libvirt bug | 18:49 |
| artom | Because that should never happen | 18:49 |
| *** tbachman has quit IRC | 18:49 | |
| dansmith | melwitt: no, I'm saying we should keep the contract until we bump, but not for out-of-nova uses, just in case someone has an ocata compute running by accident or something so we do our best to not just cause it to break in weird ways | 18:49 |
| artom | Well, assuming the hardware actually supports what you're trying to do, and you've configured nova correctly | 18:49 |
| *** suresh12 has quit IRC | 18:49 | |
| gregwork | artom: i dont think so, i believe this is related to ovs being configured to use mellanox dpdk poll mode driver, and kvm is not setting up the guest correctly to plumb the networking | 18:49 |
| *** suresh12 has joined #openstack-nova | 18:50 | |
| artom | But even a misconfiguration shouldn't go all the way down to a qemu error | 18:50 |
| dansmith | melwitt: since it's all conductor-side for those actions, just attempt to fake the result that won't cause any of our code in the last few cycles to choke and call it good | 18:50 |
| mriedem | sdague: can i get you to poke through these stable/newton changes? https://review.openstack.org/#/c/493206/ https://review.openstack.org/#/c/506323/ https://review.openstack.org/#/c/509441/ https://review.openstack.org/#/c/508902/ | 18:50 |
| mriedem | tomorrow is newton-eol | 18:50 |
| gregwork | artom: eg. https://paste.fedoraproject.org/paste/GWEv1HyVo1y9sekJbZFBeQ | 18:50 |
| melwitt | dansmith: oh, gotcha. I understand now. I'll go over it again and look for those possibilities and update it. thanks | 18:51 |
| *** cdent has quit IRC | 18:51 | |
| melwitt | I at least can remove the non-remotable one in a new PS | 18:51 |
| artom | gregwork, you're very rapidly bringing my out of my (admittedly limited) comfort zone :/ | 18:52 |
| gregwork | artom: so i am testing vnf's on my openstack, where the compute nodes are running ovs in dpdk mode, with a poll mode driver (the nic is not managed by the kernel) | 18:52 |
| artom | gregwork, sorry I can't be of more help, but I'm out of my league here | 18:54 |
| mriedem | gregwork: sean-k-mooney might be able to help with dpdk questions | 18:55 |
| artom | We have some folks from mellanox who hang out here, but they're (I think) on Israel time | 18:55 |
| mriedem | moshe is yeah | 18:55 |
| sean-k-mooney | mriedem: gregwork sure let me read back | 18:55 |
| *** suresh12 has quit IRC | 18:56 | |
| sean-k-mooney | gregwork: so yes you have a coumpute node with ovs-dpdk. what is the question? | 18:56 |
| sean-k-mooney | gregwork: ah you dont have hugepages requested for the vm | 18:57 |
| *** peter-hamilton has quit IRC | 18:58 | |
| sdague | mriedem: done. I was a little surprised you wanted some of those back to newton, but that's fine | 18:58 |
| gregwork | sean-k-mooney: have you seen that error before ? | 18:58 |
| gregwork | the one i posted in the pastebin | 18:58 |
| mriedem | sdague: the bfv one was needed for another thing someone was reporting in newton but w/o better debug couldn't be determined | 18:58 |
| sdague | mriedem: ok | 18:59 |
| gregwork | sean-k-mooney: im using the mellanox rhosp11 plugin which has configured ofed on my nodes and we are pushing a nutron dpdk config | 18:59 |
| gregwork | sean-k-mooney: the deploy works great, but when i spawn instances i get that error in qemu-kvm on the compute node | 18:59 |
| gregwork | sean-k-mooney: networking doesnt appear to be working (most likely due to that error) | 19:00 |
| gregwork | vm boots and all but is an island | 19:00 |
| sean-k-mooney | gregwork: the one you posted is indicating that the guest memory is not backed by file descriptor backed memory that is mapped shared | 19:00 |
| gregwork | sean-k-mooney: yar | 19:00 |
| sean-k-mooney | vhost user requires file decriptor backed shared memeory that is preallocated and locked to work | 19:01 |
| sean-k-mooney | in ocata that means the guest must use hugepage backed memory or it will boot but have no networking | 19:01 |
| *** slaweq has joined #openstack-nova | 19:02 | |
| gregwork | what am i missing from a flavor pov? im reading about some keys i need to set | 19:02 |
| *** suresh12 has joined #openstack-nova | 19:02 | |
| sean-k-mooney | yes you need to add hw:mem_page_size=large | 19:02 |
| mriedem | gregwork: https://docs.openstack.org/nova/pike/admin/huge-pages.html | 19:03 |
| dansmith | efried: I assume you're good with this since you pushed the latest edit? https://review.openstack.org/#/c/470575 | 19:04 |
| *** dave-mccowan has quit IRC | 19:04 | |
| dansmith | efried: no +1 so just wanted to make sure before I sent it to oblivio | 19:04 |
| dansmith | *oblivion | 19:04 |
| efried | dansmith oblivio away | 19:04 |
| dansmith | efried: are you going to rebase the rest? | 19:04 |
| efried | I could, if they need it. Do they need it? | 19:05 |
| sean-k-mooney | mriedem: sfinucan wrote a section about vhost-user/dpdk also in the docs im trying to find that | 19:05 |
| dansmith | I think so | 19:05 |
| efried | ight. | 19:05 |
| dansmith | efried: I think your edit(s) orphaned them | 19:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Send Allocations to spawn https://review.openstack.org/511879 | 19:05 |
| efried | dansmith On it. Meanwhile ^ | 19:05 |
| dansmith | efried: no, meanwhile lunch | 19:06 |
| mriedem | sean-k-mooney: probably in the networking guide | 19:06 |
| efried | dansmith Enjoy | 19:06 |
| *** cjvolzka has joined #openstack-nova | 19:06 | |
| mriedem | https://docs.openstack.org/ocata/networking-guide/config-ovs-dpdk.html | 19:06 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921 | 19:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 19:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 19:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 19:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 19:07 |
| efried | dansmith Done ^ | 19:08 |
| sean-k-mooney | mriedem: gregwork yep https://docs.openstack.org/ocata/networking-guide/config-ovs-dpdk.html was what i was looking for | 19:08 |
| *** hemna_ has joined #openstack-nova | 19:10 | |
| gregwork | reading now | 19:10 |
| sean-k-mooney | gregwork: that rather crypti libvirt warning + the complete lack of networking are the only signs that this requirement was not met | 19:10 |
| sean-k-mooney | gregwork: by the way if you are on ubuntu you might need to aslo need to run sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.libvirtd and restart libvirtd | 19:12 |
| *** suresh12 has quit IRC | 19:12 | |
| sean-k-mooney | the reason for this is apparmor may block acess to /var/run/openvswitch when qemu tries to create/connect to the vhost user socket | 19:12 |
| *** jamesdenton has quit IRC | 19:13 | |
| sean-k-mooney | if you request hugepages and it fails to boot check dmesg to see if app armor blocked it and remove teh libvirt prfile and restart the libvirt service if it did | 19:14 |
| *** suresh12 has joined #openstack-nova | 19:14 | |
| *** namnh has joined #openstack-nova | 19:16 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 19:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 19:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 19:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799 | 19:20 |
| *** namnh has quit IRC | 19:20 | |
| *** jwcroppe has joined #openstack-nova | 19:21 | |
| gregwork | sean-k-mooney: on rhel7 with rhosp11 | 19:21 |
| sean-k-mooney | gregwork: ah ok. selinux might complain in a similar way but i think that issue only happens on ubuntu | 19:22 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Reformat _get_all_with_shared https://review.openstack.org/512799 | 19:22 |
| sean-k-mooney | you can set selinux to permmissive if it dose as a workaround | 19:22 |
| gregwork | sean-k-mooney: what hardware are you using | 19:22 |
| gregwork | sean-k-mooney: we are testing connect x-5 100gbe dual qsfp cards | 19:23 |
| dansmith | efried: thanks | 19:23 |
| efried | yahyoubetcha. | 19:23 |
| efried | Also addressed cdent -1 in the middle of that series | 19:23 |
| dansmith | gregwork: sean-k-mooney: your discussion seems unrelated to nova dev (see topic), maybe you could take it to #openstack? | 19:23 |
| dansmith | efried: cool | 19:24 |
| sean-k-mooney | gregwork: i have tested i350,e1000,x520 and xl70(both 4*10 and 2*40G) | 19:24 |
| gregwork | dansmith: sure | 19:24 |
| sean-k-mooney | dansmith: sure :) | 19:24 |
| efried | dansmith You should eat slower. Gonna give yourself indigestion. | 19:24 |
| *** slaweq has quit IRC | 19:24 | |
| gregwork | actually ill just msg you directly if you dont mind | 19:24 |
| dansmith | efried: I'm parallelizing | 19:24 |
| efried | efficient | 19:24 |
| *** markvoelker has joined #openstack-nova | 19:26 | |
| *** sahid has quit IRC | 19:29 | |
| *** dave-mccowan has joined #openstack-nova | 19:29 | |
| *** mlavalle has joined #openstack-nova | 19:30 | |
| mlavalle | johnthetubaguy, mriedem: any chance you could take a look again on https://review.openstack.org/#/c/375580/? | 19:31 |
| mriedem | 0 chance miguel | 19:31 |
| mriedem | i've had the tab open all morning :) | 19:31 |
| mriedem | should be able to get to it before parent / teacher conferences this afternoon, which are not going to go well | 19:33 |
| mriedem | dansmith: ^ you know why | 19:33 |
| dansmith | lol | 19:33 |
| dansmith | wish I could go | 19:33 |
| mlavalle | mriedem: thanks. good luck with the parent / teacher conference :-) I remember those days | 19:34 |
| *** awaugama has quit IRC | 19:35 | |
| * melwitt wonders what thing happened this time | 19:36 | |
| efried | sean-k-mooney Took another swing at the bandwidth spec | 19:37 |
| *** slaweq has joined #openstack-nova | 19:38 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:40 | |
| *** slaweq has quit IRC | 19:40 | |
| *** READ10 has quit IRC | 19:40 | |
| *** slaweq has joined #openstack-nova | 19:41 | |
| *** weshay|afk_see_r is now known as weshay|ruck | 19:42 | |
| *** tbachman has joined #openstack-nova | 19:43 | |
| melwitt | mriedem: I wonder if the problem is with cryptsetup and not luks (in your recreate patch). in the bug report lisali mentioned dmcrypt which would imply cryptsetup IIUC | 19:43 |
| melwitt | the hard reboot is only in the luks test | 19:43 |
| sean-k-mooney | efried: cool thanks ill review it with rodolfo tomorow when im back in the office | 19:43 |
| *** AlexeyAbashkin has quit IRC | 19:44 | |
| melwitt | mriedem: ah but I see in the bug summary he uses LUKS in the repro steps. nvm | 19:44 |
| mriedem | melwitt: i'll check the logs when they are available to make sure it's not something like reboot failed but the instance wasn't put into ERROR state | 19:44 |
| * melwitt nods | 19:44 | |
| *** jwcroppe has quit IRC | 19:45 | |
| *** penick has joined #openstack-nova | 19:45 | |
| mriedem | mlavalle: before you scamper off, | 19:47 |
| *** MasterOfBugs has joined #openstack-nova | 19:47 | |
| mriedem | i have a question for you | 19:47 |
| *** pramodrj07 has joined #openstack-nova | 19:47 | |
| mriedem | https://bugs.launchpad.net/neutron/+bug/1718605 | 19:48 |
| openstack | Launchpad bug 1718605 in neutron "[RFE] Support regex matching when filtering port with IP address" [Wishlist,Triaged] - Assigned to Zhenyu Zheng (zhengzhenyu) | 19:48 |
| mriedem | mlavalle: would ^ be exposed via a new networking API extension? | 19:48 |
| mriedem | i want to assert that it would be | 19:48 |
| mriedem | so nova can tell if neutron is new enough to filter ports by an ip regex | 19:48 |
| *** catintheroof has joined #openstack-nova | 19:49 | |
| mlavalle | mriedem: yes, that makes sense | 19:49 |
| mriedem | ok cool | 19:49 |
| mlavalle | otherwise you don't know who you are talking about | 19:50 |
| mlavalle | talking to^^^^ | 19:50 |
| mlavalle | good thing you left a comment in the RFE | 19:50 |
| mriedem | \o/ | 19:50 |
| mlavalle | I'll make sure we talk about it in the drivers meeting | 19:50 |
| mriedem | ok | 19:51 |
| * mlavalle scampering off | 19:51 | |
| *** gregwork has quit IRC | 19:54 | |
| *** suresh12 has quit IRC | 19:54 | |
| *** gregwork has joined #openstack-nova | 19:54 | |
| *** fragatina has joined #openstack-nova | 19:55 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Improve the performance of filtering instances by IP. https://review.openstack.org/509326 | 19:59 |
| melwitt | mriedem: looks like reboot succeeded, weird http://logs.openstack.org/60/512760/1/check/legacy-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend/b6880f6/logs/screen-n-cpu.txt.gz#_Oct_17_19_08_20_972474 | 20:00 |
| *** armax has quit IRC | 20:01 | |
| mriedem | are you sure that's the right request? | 20:02 |
| melwitt | not totally sure but it's the only hard reboot in nova-api | 20:02 |
| *** jwcroppe has joined #openstack-nova | 20:02 | |
| melwitt | I'm missing how to tie these to specific tests | 20:03 |
| melwitt | not seeing any test ids or names | 20:03 |
| *** slaweq has quit IRC | 20:04 | |
| mriedem | i think cbdc84d2-2f34-4868-8058-4c5503f5d815 is the volume id | 20:05 |
| *** fragatina has quit IRC | 20:08 | |
| openstackgerrit | Merged openstack/nova stable/newton: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507557 | 20:09 |
| mriedem | Stderr: u'Device /dev/sda is not a valid LUKS device.\nCommand failed with code 22: Device /dev/sda is not a valid LUKS device.\n' | 20:09 |
| *** suresh12 has joined #openstack-nova | 20:09 | |
| mriedem | oh i guess that's maybe normal | 20:09 |
| mriedem | "/dev/sda is not a valid LUKS device; formatting device for first use" | 20:09 |
| *** suresh12 has quit IRC | 20:10 | |
| *** suresh12_ has joined #openstack-nova | 20:10 | |
| melwitt | I saw those errors too but they're not part of the reboot request (assuming the reboot request I found was the one you added) | 20:10 |
| melwitt | there was only one so I assumed it had to be it | 20:10 |
| mriedem | they aren't, they are part of the attach volume operation | 20:11 |
| mriedem | req-b88ac35a-19f9-4aaa-8186-75028e85d14f is the reboot request | 20:11 |
| melwitt | yeah, that's the one I found | 20:11 |
| mriedem | ew why do we process all of the cpu/numa topology stuff again on reboot? | 20:12 |
| mriedem | is that necessary? | 20:12 |
| melwitt | it might be part of mdbooth's "redo all the things in reboot". I dunno | 20:12 |
| *** smatzek has quit IRC | 20:13 | |
| mriedem | it's part of building the guest config after we destroyed it i guess | 20:13 |
| *** smatzek has joined #openstack-nova | 20:14 | |
| *** markvoelker_ has joined #openstack-nova | 20:15 | |
| *** pwiltsey has quit IRC | 20:16 | |
| *** tbachman has quit IRC | 20:18 | |
| *** markvoelker has quit IRC | 20:18 | |
| *** smatzek has quit IRC | 20:19 | |
| openstackgerrit | Marco Chiappero proposed openstack/nova master: [WIP] Add a communication channel for power management support https://review.openstack.org/512815 | 20:20 |
| mriedem | melwitt: yeah i came to the same conclusion http://logs.openstack.org/60/512760/1/check/legacy-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend/b6880f6/logs/screen-n-cpu.txt.gz#_Oct_17_19_08_20_972474 | 20:21 |
| *** acormier has joined #openstack-nova | 20:21 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:22 | |
| *** pwiltsey has joined #openstack-nova | 20:22 | |
| *** ijw has quit IRC | 20:24 | |
| mriedem | +2 on Kevin_Zheng's spec to proxy IP filtering to neutron as a way forward https://review.openstack.org/#/c/509326/ | 20:24 |
| mriedem | for that perf thing | 20:25 |
| *** tbachman has joined #openstack-nova | 20:25 | |
| *** pchavva has quit IRC | 20:25 | |
| *** acormier has quit IRC | 20:26 | |
| *** abalutoiu_ has quit IRC | 20:26 | |
| *** AlexeyAbashkin has quit IRC | 20:27 | |
| *** pwiltsey has quit IRC | 20:27 | |
| *** tonygunk has joined #openstack-nova | 20:27 | |
| *** vvargaszte has joined #openstack-nova | 20:29 | |
| *** vvargaszte has quit IRC | 20:30 | |
| *** suresh12_ has quit IRC | 20:31 | |
| openstackgerrit | Merged openstack/nova stable/newton: neutron: handle binding:profile=None during migration https://review.openstack.org/506323 | 20:33 |
| *** suresh12 has joined #openstack-nova | 20:34 | |
| *** crushil has quit IRC | 20:35 | |
| *** jwcroppe has quit IRC | 20:35 | |
| *** catintheroof has quit IRC | 20:35 | |
| *** crushil has joined #openstack-nova | 20:36 | |
| *** catintheroof has joined #openstack-nova | 20:36 | |
| *** armax has joined #openstack-nova | 20:36 | |
| *** catintheroof has quit IRC | 20:36 | |
| openstackgerrit | Merged openstack/nova stable/pike: neutron: handle binding:profile=None during migration https://review.openstack.org/506319 | 20:39 |
| openstackgerrit | Merged openstack/nova stable/ocata: neutron: handle binding:profile=None during migration https://review.openstack.org/506320 | 20:39 |
| openstackgerrit | Merged openstack/nova stable/ocata: Provide original fault message when BFV fails https://review.openstack.org/493141 | 20:39 |
| openstackgerrit | melanie witt proposed openstack/nova stable/newton: DNM: Test hard reboot with encrypted volumes attached https://review.openstack.org/512852 | 20:40 |
| openstackgerrit | melanie witt proposed openstack/nova stable/newton: DNM: Test hard reboot with encrypted volumes attached https://review.openstack.org/512852 | 20:42 |
| *** namnh has joined #openstack-nova | 20:43 | |
| *** artom has quit IRC | 20:46 | |
| *** namnh has quit IRC | 20:47 | |
| *** dave-mccowan has quit IRC | 20:48 | |
| *** ijw has joined #openstack-nova | 20:52 | |
| *** sapd__ has joined #openstack-nova | 20:53 | |
| *** sapd_ has quit IRC | 20:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API https://review.openstack.org/506030 | 20:54 |
| mriedem | dansmith: i think this migrations paging spec is ready to go ^ | 20:55 |
| mriedem | has the multi-cell stuff in it | 20:55 |
| *** xyang1 has quit IRC | 20:56 | |
| *** david-lyle has quit IRC | 20:57 | |
| *** MVenesio has quit IRC | 20:57 | |
| *** tonygunk has quit IRC | 21:00 | |
| *** ijw has quit IRC | 21:01 | |
| openstackgerrit | Merged openstack/nova stable/newton: Provide original fault message when BFV fails https://review.openstack.org/493206 | 21:01 |
| dansmith | mriedem: why descending order? | 21:03 |
| dansmith | I mean, I know we do that in instance list but I don't know why that's good | 21:04 |
| dansmith | it just means that pages are in the reverse order of display in a text screen, which annoys me | 21:04 |
| mriedem | was just being consistent with the instance list | 21:04 |
| mriedem | defaults | 21:04 |
| *** shaner has quit IRC | 21:05 | |
| mriedem | in some earlier patch sets we were talking about what to do and just settled on following what instance list does by default, | 21:05 |
| dansmith | ugh | 21:05 |
| mriedem | and that's only with the new microversion. the spec doesn't call it out, but if the request is < new microversion, we don't enforce any sort key/direction | 21:05 |
| mriedem | so leave it to the natural order that we get today | 21:05 |
| openstackgerrit | Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613 | 21:06 |
| dansmith | mriedem: which file in the api is this? not compute/migration.py right? | 21:06 |
| mriedem | where the default order is? | 21:06 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L142 | 21:07 |
| dansmith | er, hmm, maybe it is | 21:07 |
| mriedem | is what i was basing it on | 21:07 |
| *** sdague has quit IRC | 21:08 | |
| *** crushil has quit IRC | 21:08 | |
| *** gouthamr has quit IRC | 21:08 | |
| *** vladikr has quit IRC | 21:11 | |
| dansmith | mriedem: so, this changes id from an int to a uuid string | 21:12 |
| dansmith | mriedem: which seems like unnecessary breakage for people | 21:12 |
| dansmith | is that what we did on services, et al as well? | 21:12 |
| mriedem | same as 2.53 | 21:12 |
| mriedem | yes | 21:12 |
| dansmith | bummer | 21:12 |
| mriedem | it was either that, or return a new uuid key in the response like we did for aggregates | 21:13 |
| mriedem | in 2.41 | 21:13 |
| *** david-lyle has joined #openstack-nova | 21:13 | |
| mriedem | doesn't matter too much to me either way we go, as long as it's one of those two options | 21:13 |
| mriedem | he originally was going to drop the id key and only return a uuid key | 21:13 |
| dansmith | right, returning a new uuid seems better to me, | 21:13 |
| mriedem | which would be a new 3rd way of doing that | 21:13 |
| dansmith | although you do end up with duplicate id fields, which is likely to be confusing if people assume that's an identifier | 21:14 |
| mriedem | i told him i preferred what we did in 2.53 | 21:14 |
| mriedem | which was more consistent with instances just have a single id key | 21:14 |
| mriedem | also because then when you do GET /services/{service_id} do you pass the id or the uuid? | 21:14 |
| dansmith | yeah but that's been a uuid forever (or almost) | 21:15 |
| mriedem | yeah i know - i was really leaning more the direction of the 2.53 changes | 21:15 |
| mriedem | we don't have a GET /os-migrations/{migration_id} so it's less of an issue | 21:15 |
| mriedem | we do, however, have GET /servers/{server_id}/migrations/{migration_id} :) | 21:16 |
| mriedem | which is the int id | 21:16 |
| dansmith | yeah | 21:16 |
| mriedem | and DELETE /servers/{server_id}/migrations/{migration_id} | 21:16 |
| *** edmondsw has quit IRC | 21:16 | |
| mriedem | so i'd be fine with adding a new uuid key to the response for os-migrations like we did in 2.41 | 21:16 |
| dansmith | but presumably you're doing /servers/id/migrations/ to get that id | 21:16 |
| mriedem | yeah, presumably | 21:16 |
| mriedem | but... | 21:16 |
| dansmith | well, I already +Wd but lodged by discontent | 21:16 |
| dansmith | *my | 21:17 |
| mriedem | like i said, i'd be fine with just returning a new uuid key if yo'ure worried about breaking people, or making it confusing | 21:17 |
| *** edmondsw_ has joined #openstack-nova | 21:18 | |
| dansmith | it's just unnecessary breakage which I think we should try to avoid unless we need to | 21:18 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 21:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 21:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 21:19 |
| dansmith | but it's +Wd | 21:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 21:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799 | 21:19 |
| mriedem | dansmith: we can amend | 21:20 |
| dansmith | I leave it to you, your highness | 21:20 |
| mriedem | gdi | 21:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add pagination and timestamp filtering support for os-migrations API https://review.openstack.org/506030 | 21:21 |
| *** tssurya has quit IRC | 21:21 | |
| dansmith | mriedem: I meant leave the decision to you | 21:22 |
| *** edmondsw_ has quit IRC | 21:22 | |
| mriedem | yeah i agree with your point, | 21:22 |
| mriedem | i hadn't thought about the lack of GET /os-migratoins/{migration_id} or PUT etc | 21:23 |
| mriedem | i will say, the api-ref docs changes for communicating the id->uuid thing in 2.53 sucked | 21:23 |
| mriedem | so i'd like to avoid that again | 21:23 |
| dansmith | so, another way to decide would be: | 21:23 |
| dansmith | assuming we update the instance-scoped one to be the same, | 21:23 |
| dansmith | would you prefer that one to just be id:$uuid because of the GET/ ? | 21:24 |
| dansmith | if so, then maybe they should both be the same and just put the uuid in the id | 21:24 |
| mriedem | we don't need to return the uuid out of the instance-scoped one, because when we lookup the instance we know which cell the migration record is in | 21:24 |
| dansmith | I don't know tbh | 21:24 |
| mriedem | ^ is why i didn't have to handle returning a uuid for the instance-scoped migrations in 2.53 | 21:24 |
| dansmith | the least amount of total breakage would be just a new uuid field on the global one | 21:24 |
| *** thorst has quit IRC | 21:25 | |
| *** thorst has joined #openstack-nova | 21:26 | |
| dansmith | mriedem: well, I have to run off and do something else in a few | 21:26 |
| dansmith | mriedem: so you choose and either proxy my +2 on there or I'll hit it later on when I'm back | 21:26 |
| mriedem | i -1ed, yikun can update tonight, we'll +W tomorrow | 21:27 |
| mriedem | i have to see ms engle soon | 21:27 |
| dansmith | okay | 21:27 |
| dansmith | haha | 21:27 |
| mriedem | laura will dress up of course and i'll look the slob | 21:27 |
| dansmith | same old story every time I leave the house | 21:27 |
| *** thorst has quit IRC | 21:30 | |
| *** fragatina has joined #openstack-nova | 21:30 | |
| mriedem | mtreinish: can you hit these 3 newton changes that have a +2 in them? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton trying to flush these out before eol | 21:31 |
| *** flanders_ has joined #openstack-nova | 21:31 | |
| *** josecastroleon has quit IRC | 21:34 | |
| *** josecastroleon has joined #openstack-nova | 21:37 | |
| mtreinish | mriedem: sure, I'll look in a sec | 21:39 |
| melwitt | mriedem: tempest.scenario.test_encrypted_cinder_volumes.TestEncryptedCinderVolumes.test_encrypted_cinder_volumes_luks [234.382405s] ... FAILED on the newton DNM patch | 21:40 |
| melwitt | will dig in once logs are available | 21:41 |
| *** burt has quit IRC | 21:41 | |
| *** salv-orlando has joined #openstack-nova | 21:42 | |
| mriedem | melwitt: aha | 21:44 |
| *** salv-orlando has quit IRC | 21:44 | |
| *** salv-orlando has joined #openstack-nova | 21:44 | |
| melwitt | I guess the question will still be something like, did os-brick fix the problem as a side effect and we should still do the nova change or did os-brick legit fix something | 21:44 |
| mriedem | idk, would have to figure out what the actual root failure was and what was changed in os-brick that makes it no longer a problem | 21:45 |
| mriedem | in that case the fix might be backporting something in os-brick | 21:45 |
| melwitt | yeah. if os-brick did something to legit fix it, we would backport that instead | 21:46 |
| melwitt | but if it's a side effect, we may still want the nova change to not rely on a side effect, if that makes sense | 21:46 |
| mriedem | sean-k-mooney: mlavalle: comments inline https://review.openstack.org/#/c/375580/ | 21:46 |
| mriedem | gotta run | 21:47 |
| mlavalle | mriedem: thanks | 21:47 |
| *** fragatina has quit IRC | 21:48 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove old-style quotas code https://review.openstack.org/511689 | 21:49 |
| *** erlon has quit IRC | 21:50 | |
| *** thorst has joined #openstack-nova | 21:50 | |
| *** edmondsw has joined #openstack-nova | 21:51 | |
| *** shaner has joined #openstack-nova | 21:51 | |
| *** thorst has quit IRC | 21:54 | |
| *** edmondsw has quit IRC | 21:55 | |
| *** esberglu has quit IRC | 21:55 | |
| *** esberglu has joined #openstack-nova | 21:56 | |
| *** Apoorva_ has joined #openstack-nova | 21:59 | |
| *** esberglu has quit IRC | 22:00 | |
| *** Apoorva has quit IRC | 22:03 | |
| *** shaner has quit IRC | 22:08 | |
| *** baoli has quit IRC | 22:10 | |
| *** shaner has joined #openstack-nova | 22:12 | |
| *** ijw has joined #openstack-nova | 22:16 | |
| *** felipemonteiro__ has quit IRC | 22:17 | |
| *** ijw has quit IRC | 22:20 | |
| *** penick has quit IRC | 22:22 | |
| *** rodolof has quit IRC | 22:24 | |
| *** lyan has quit IRC | 22:25 | |
| *** suresh12 has quit IRC | 22:33 | |
| *** suresh12 has joined #openstack-nova | 22:34 | |
| *** suresh12 has quit IRC | 22:35 | |
| *** suresh12 has joined #openstack-nova | 22:35 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | 22:36 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 22:36 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 22:36 |
| *** dave-mccowan has joined #openstack-nova | 22:36 | |
| *** lbragstad has quit IRC | 22:36 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/newton: DNM: libvirt: Fully destroy instances during a hard reboot https://review.openstack.org/512896 | 22:42 |
| *** catintheroof has joined #openstack-nova | 22:43 | |
| *** salv-orlando has quit IRC | 22:45 | |
| *** salv-orlando has joined #openstack-nova | 22:46 | |
| *** suresh12 has quit IRC | 22:46 | |
| *** oanson has quit IRC | 22:50 | |
| *** salv-orlando has quit IRC | 22:51 | |
| *** oanson has joined #openstack-nova | 22:52 | |
| *** suresh12 has joined #openstack-nova | 22:58 | |
| *** suresh12 has quit IRC | 22:58 | |
| *** suresh12 has joined #openstack-nova | 22:59 | |
| *** gjayavelu has quit IRC | 23:01 | |
| *** gjayavelu has joined #openstack-nova | 23:01 | |
| *** mlavalle has quit IRC | 23:10 | |
| *** chyka_ has quit IRC | 23:11 | |
| *** Apoorva_ has quit IRC | 23:11 | |
| *** Apoorva has joined #openstack-nova | 23:11 | |
| *** ijw has joined #openstack-nova | 23:17 | |
| *** catintheroof has quit IRC | 23:17 | |
| *** jobewan has quit IRC | 23:20 | |
| *** ijw has quit IRC | 23:22 | |
| *** gmann_afk is now known as gmann | 23:24 | |
| *** esberglu has joined #openstack-nova | 23:31 | |
| *** hongbin has quit IRC | 23:32 | |
| *** yikun_ has joined #openstack-nova | 23:35 | |
| *** crushil has joined #openstack-nova | 23:36 | |
| *** claudiub has quit IRC | 23:36 | |
| *** salv-orlando has joined #openstack-nova | 23:46 | |
| *** takashin has joined #openstack-nova | 23:47 | |
| *** jmlowe has joined #openstack-nova | 23:47 | |
| *** artom has joined #openstack-nova | 23:49 | |
| *** salv-orlando has quit IRC | 23:52 | |
| openstackgerrit | Merged openstack/nova stable/pike: Enable custom certificates for keystone communication https://review.openstack.org/505546 | 23:57 |
| openstackgerrit | Merged openstack/nova stable/newton: Add live.migration.force.complete to the legacy notification whitelist https://review.openstack.org/508902 | 23:57 |
| openstackgerrit | Merged openstack/nova stable/newton: Account for compute.metrics.update in legacy notification whitelist https://review.openstack.org/509441 | 23:58 |
| openstackgerrit | Merged openstack/nova stable/newton: Catch InstanceNotFound exception https://review.openstack.org/467321 | 23:58 |
| *** ijw has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!