| *** ducttape_ has quit IRC | 00:01 | |
| dansmith | mriedem: passed the cells job but failed something else, probably unrelatedly | 00:02 |
|---|---|---|
| *** tbachman has quit IRC | 00:07 | |
| *** FL1SK has joined #openstack-nova | 00:10 | |
| *** aslezil_ has quit IRC | 00:11 | |
| *** annegentle has joined #openstack-nova | 00:14 | |
| *** tbachman has joined #openstack-nova | 00:14 | |
| *** hfu has joined #openstack-nova | 00:16 | |
| *** mriedem has quit IRC | 00:19 | |
| *** mriedem has joined #openstack-nova | 00:20 | |
| *** jwcroppe has joined #openstack-nova | 00:22 | |
| *** CristinaPauna has quit IRC | 00:25 | |
| *** CristinaPauna has joined #openstack-nova | 00:37 | |
| *** rfolco has joined #openstack-nova | 00:37 | |
| *** rfolco has quit IRC | 00:37 | |
| mriedem | so apparently my foundation membership has lapsed b/c i haven't been voting in board of directors elections, | 00:39 |
| mriedem | is there an easy way to get my membership back or i just need to do the initial sign up stuff all over again? | 00:39 |
| mriedem | can i be ptl if i'm not a foundation member? i'm pretty sure i'm breaking some laws right now. | 00:41 |
| *** swamireddy has joined #openstack-nova | 00:45 | |
| *** hfu has quit IRC | 00:46 | |
| *** hfu has joined #openstack-nova | 00:47 | |
| *** chyka has quit IRC | 00:48 | |
| mriedem | ooo i'm back in | 00:48 |
| mriedem | EmilienM: https://review.openstack.org/419217 | 00:49 |
| *** jamielennox is now known as jamielennox|away | 00:50 | |
| *** annegentle has quit IRC | 00:51 | |
| *** zz_dimtruck is now known as dimtruck | 00:51 | |
| *** thorst_ has joined #openstack-nova | 00:53 | |
| *** thorst_ has quit IRC | 00:58 | |
| *** hoangcx has joined #openstack-nova | 01:00 | |
| *** phuongnh has joined #openstack-nova | 01:05 | |
| *** sdague has quit IRC | 01:05 | |
| *** mtanino has quit IRC | 01:11 | |
| *** rama_y_ has quit IRC | 01:11 | |
| *** tuanluong has joined #openstack-nova | 01:12 | |
| *** dtp has quit IRC | 01:14 | |
| *** jose-phillips has quit IRC | 01:15 | |
| *** thorst_ has joined #openstack-nova | 01:17 | |
| *** jamielennox|away is now known as jamielennox | 01:21 | |
| *** kevinz has joined #openstack-nova | 01:22 | |
| *** Jinxing has joined #openstack-nova | 01:25 | |
| *** Jinxing has quit IRC | 01:26 | |
| *** yuntongjin has joined #openstack-nova | 01:31 | |
| *** ducttape_ has joined #openstack-nova | 01:33 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Deny invalid flavor extraspec for cpu_policy https://review.openstack.org/406377 | 01:36 |
| *** gouthamr has quit IRC | 01:36 | |
| *** dimtruck is now known as zz_dimtruck | 01:42 | |
| *** gcb has joined #openstack-nova | 01:43 | |
| *** tovin07_ is now known as tovin07 | 01:45 | |
| *** browne has quit IRC | 01:48 | |
| *** zz_dimtruck is now known as dimtruck | 01:49 | |
| *** jaypipes has quit IRC | 01:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Hyper-V: Adds vNUMA implementation https://review.openstack.org/282407 | 01:55 |
| *** zayro_ has joined #openstack-nova | 01:57 | |
| *** yuntongjin has quit IRC | 01:58 | |
| tovin07 | johnthetubaguy, mriedem, could you review this one https://review.openstack.org/#/c/254703/ ? patch in novaclient is OK now. Thank you! | 01:59 |
| *** yuntongjin has joined #openstack-nova | 02:01 | |
| *** zayro_ has quit IRC | 02:02 | |
| *** tovin07_ has joined #openstack-nova | 02:02 | |
| *** unicell has quit IRC | 02:02 | |
| EmilienM | mriedem: thanks! | 02:03 |
| *** zayro has joined #openstack-nova | 02:03 | |
| *** tbachman has quit IRC | 02:04 | |
| mriedem | tovin07: probably not tonight | 02:13 |
| *** kaisers has quit IRC | 02:13 | |
| mriedem | but it's on the list | 02:13 |
| *** kaisers1 has quit IRC | 02:13 | |
| mriedem | dansmith: looks like my series of backports for the scheduler report client in newton are going to be needed after all for ironic https://review.openstack.org/#/c/416734/ | 02:14 |
| mriedem | ^ was failing before the depends-on | 02:14 |
| tovin07 | mriedem, thanks! | 02:14 |
| mriedem | which pulls in this whole series https://review.openstack.org/#/c/416762/ | 02:14 |
| *** ducttape_ has quit IRC | 02:16 | |
| *** ducttape_ has joined #openstack-nova | 02:17 | |
| *** ijw has quit IRC | 02:18 | |
| *** yingjun has joined #openstack-nova | 02:21 | |
| *** kaisers_ has quit IRC | 02:21 | |
| *** kaisers has joined #openstack-nova | 02:30 | |
| *** kaisers1 has joined #openstack-nova | 02:30 | |
| *** gouthamr has joined #openstack-nova | 02:32 | |
| *** hongbin_ has joined #openstack-nova | 02:33 | |
| *** markvoelker has quit IRC | 02:38 | |
| *** thorst_ has quit IRC | 02:38 | |
| *** thorst_ has joined #openstack-nova | 02:39 | |
| *** _ducttape_ has joined #openstack-nova | 02:40 | |
| *** raunak has quit IRC | 02:40 | |
| *** markvoelker_ has joined #openstack-nova | 02:41 | |
| *** ducttape_ has quit IRC | 02:43 | |
| *** yamahata has quit IRC | 02:43 | |
| *** thorst_ has quit IRC | 02:43 | |
| *** zayro has quit IRC | 02:45 | |
| *** zayro has joined #openstack-nova | 02:46 | |
| *** tovin07 has quit IRC | 02:52 | |
| *** markvoelker_ has quit IRC | 02:56 | |
| *** tovin07 has joined #openstack-nova | 02:56 | |
| *** _ducttape_ has quit IRC | 03:07 | |
| *** ducttape_ has joined #openstack-nova | 03:08 | |
| *** ijw has joined #openstack-nova | 03:08 | |
| *** tovin07 has quit IRC | 03:09 | |
| *** hoangcx_ has joined #openstack-nova | 03:10 | |
| *** tovin07 has joined #openstack-nova | 03:10 | |
| *** hieulq has quit IRC | 03:10 | |
| *** tuanluong_ has joined #openstack-nova | 03:10 | |
| *** tuanluong has quit IRC | 03:10 | |
| *** hoangcx has quit IRC | 03:10 | |
| *** tovin07_ has quit IRC | 03:11 | |
| *** phuongnh has quit IRC | 03:11 | |
| *** phuongnh has joined #openstack-nova | 03:11 | |
| *** hoangcx_ is now known as hoangcx | 03:12 | |
| *** ducttape_ has quit IRC | 03:12 | |
| *** dimtruck is now known as zz_dimtruck | 03:12 | |
| *** zz_dimtruck is now known as dimtruck | 03:12 | |
| *** ijw has quit IRC | 03:13 | |
| *** ijw_ has joined #openstack-nova | 03:13 | |
| *** bkopilov has quit IRC | 03:13 | |
| *** jamesdenton has joined #openstack-nova | 03:14 | |
| alex_xu | diana_clarke: yea, agree with you , we need better error message. At least the "query parameter 0" confuse user. I guess "0" due to the input are array type. | 03:14 |
| *** ijw_ has quit IRC | 03:14 | |
| *** phuongnh has quit IRC | 03:17 | |
| *** ijw has joined #openstack-nova | 03:17 | |
| *** phuongnh has joined #openstack-nova | 03:17 | |
| *** ijw has quit IRC | 03:18 | |
| *** jamesdenton has quit IRC | 03:18 | |
| *** baoli has joined #openstack-nova | 03:20 | |
| *** ijw has joined #openstack-nova | 03:22 | |
| *** ijw_ has joined #openstack-nova | 03:23 | |
| *** tlian has quit IRC | 03:24 | |
| *** tovin07_ has joined #openstack-nova | 03:24 | |
| *** hieulq has joined #openstack-nova | 03:25 | |
| *** tlian has joined #openstack-nova | 03:25 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Better black list for py35 tests https://review.openstack.org/419250 | 03:25 |
| *** ijw has quit IRC | 03:27 | |
| mriedem | dansmith: we should talk to vladikr about this tomorrow https://review.openstack.org/#/c/405948/ | 03:32 |
| mriedem | i don't want to forget about that one | 03:32 |
| *** yuntongjin has quit IRC | 03:35 | |
| vladikr | mriedem, I'm here - I'm try to re-implement it all with storing the vlan in info_cache - having some issues with that though.. that's why I didn't update yet | 03:35 |
| mriedem | vladikr: ok yeah i assumed you'd need to see how that change makes the rest of the series behave | 03:35 |
| *** links has joined #openstack-nova | 03:39 | |
| *** pbandark has joined #openstack-nova | 03:39 | |
| *** ducttape_ has joined #openstack-nova | 03:54 | |
| *** hongbin_ has quit IRC | 03:55 | |
| *** baoli has quit IRC | 03:57 | |
| *** markvoelker has joined #openstack-nova | 03:57 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | 04:01 |
| *** madhu_ak has joined #openstack-nova | 04:03 | |
| *** sree has joined #openstack-nova | 04:04 | |
| *** sree has joined #openstack-nova | 04:04 | |
| *** psachin has joined #openstack-nova | 04:05 | |
| *** tlian has quit IRC | 04:09 | |
| *** madhu_ak has quit IRC | 04:10 | |
| *** ducttape_ has quit IRC | 04:11 | |
| *** Jeffrey4l__ has joined #openstack-nova | 04:11 | |
| *** nicolasbock has quit IRC | 04:11 | |
| *** ducttape_ has joined #openstack-nova | 04:11 | |
| *** Jeffrey4l_ has quit IRC | 04:14 | |
| *** aslezil_ has joined #openstack-nova | 04:14 | |
| *** ducttape_ has quit IRC | 04:16 | |
| *** mdnadeem has joined #openstack-nova | 04:18 | |
| *** hongbin_ has joined #openstack-nova | 04:21 | |
| *** diga has joined #openstack-nova | 04:21 | |
| *** amotoki has quit IRC | 04:22 | |
| *** amotoki has joined #openstack-nova | 04:22 | |
| *** ratailor has joined #openstack-nova | 04:29 | |
| *** sudipto has joined #openstack-nova | 04:29 | |
| *** sudipto_ has joined #openstack-nova | 04:29 | |
| *** bkopilov has joined #openstack-nova | 04:38 | |
| openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | 04:39 |
| *** karthiks has joined #openstack-nova | 04:40 | |
| *** zayro has quit IRC | 04:40 | |
| *** zayro has joined #openstack-nova | 04:41 | |
| openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | 04:43 |
| *** karthiks has quit IRC | 04:46 | |
| *** dikonoor has joined #openstack-nova | 04:48 | |
| openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | 04:49 |
| *** pbandark has quit IRC | 04:53 | |
| *** unicell has joined #openstack-nova | 04:55 | |
| *** pbandark has joined #openstack-nova | 04:59 | |
| *** jamespage has quit IRC | 05:00 | |
| *** karthiks has joined #openstack-nova | 05:06 | |
| *** armax has quit IRC | 05:06 | |
| *** voelzmo has joined #openstack-nova | 05:07 | |
| *** aslezil_ has quit IRC | 05:11 | |
| *** armax has joined #openstack-nova | 05:11 | |
| *** voelzmo has quit IRC | 05:11 | |
| *** hongbin_ has quit IRC | 05:13 | |
| *** prateek has joined #openstack-nova | 05:13 | |
| *** sudipto has quit IRC | 05:14 | |
| *** sudipto_ has quit IRC | 05:14 | |
| *** adisky_ has joined #openstack-nova | 05:18 | |
| *** sc68cal has quit IRC | 05:18 | |
| *** sc68cal has joined #openstack-nova | 05:20 | |
| *** yamahata has joined #openstack-nova | 05:21 | |
| *** sacharya has quit IRC | 05:25 | |
| *** salv-orlando has joined #openstack-nova | 05:26 | |
| *** salv-orlando has quit IRC | 05:31 | |
| *** thorst_ has joined #openstack-nova | 05:40 | |
| *** yuntongjin has joined #openstack-nova | 05:44 | |
| *** thorst_ has quit IRC | 05:44 | |
| *** khushbu has joined #openstack-nova | 05:52 | |
| *** ayogi has joined #openstack-nova | 05:55 | |
| *** ayogi has quit IRC | 05:56 | |
| *** sudipto has joined #openstack-nova | 05:58 | |
| *** sudipto_ has joined #openstack-nova | 05:58 | |
| *** moshele has joined #openstack-nova | 06:03 | |
| *** slaweq has joined #openstack-nova | 06:03 | |
| *** andrewbogott has quit IRC | 06:04 | |
| *** andrewbogott has joined #openstack-nova | 06:04 | |
| *** tbachman has joined #openstack-nova | 06:05 | |
| khushbu | Hi | 06:07 |
| *** armax has quit IRC | 06:07 | |
| *** armax has joined #openstack-nova | 06:07 | |
| *** armax has quit IRC | 06:08 | |
| khushbu | Hi! I am working on this https://bugs.launchpad.net/oslo.concurrency/+bug/1630575 trying to recreate the issue can ayone send the doc link to run tests for oslo.concurrency | 06:08 |
| openstack | Launchpad bug 1630575 in oslo.concurrency "python3 memoryview error" [Undecided,New] - Assigned to Khushbuparakh (khushbuparakh) | 06:08 |
| khushbu | https://launchpadlibrarian.net/288351147/nova-py34-fail.log these are log file | 06:08 |
| *** tbachman has quit IRC | 06:10 | |
| *** tbachman has joined #openstack-nova | 06:10 | |
| *** unicell1 has joined #openstack-nova | 06:16 | |
| *** tbachman_ has joined #openstack-nova | 06:17 | |
| *** unicell has quit IRC | 06:17 | |
| *** tbachman has quit IRC | 06:18 | |
| *** tbachman_ is now known as tbachman | 06:18 | |
| *** karthiks has quit IRC | 06:19 | |
| *** unicell1 has quit IRC | 06:21 | |
| *** unicell has joined #openstack-nova | 06:21 | |
| *** mdnadeem has quit IRC | 06:22 | |
| *** sacharya has joined #openstack-nova | 06:25 | |
| *** lpetrut has joined #openstack-nova | 06:27 | |
| *** salv-orlando has joined #openstack-nova | 06:28 | |
| openstackgerrit | Hussain Chachuliya proposed openstack/nova: Deny volume swapping with non-bootable volume https://review.openstack.org/407346 | 06:28 |
| *** sridharg has joined #openstack-nova | 06:29 | |
| *** sacharya has quit IRC | 06:30 | |
| *** salv-orlando has quit IRC | 06:32 | |
| *** mdnadeem has joined #openstack-nova | 06:34 | |
| *** karthiks has joined #openstack-nova | 06:34 | |
| *** huanxie has joined #openstack-nova | 06:36 | |
| *** thorst_ has joined #openstack-nova | 06:40 | |
| *** mjura has joined #openstack-nova | 06:42 | |
| *** nkrinner_afk is now known as nkrinner | 06:45 | |
| *** thorst_ has quit IRC | 06:45 | |
| *** satyar has joined #openstack-nova | 06:46 | |
| openstackgerrit | Zhihai Song proposed openstack/nova: Enable functional.test_servers on Python 3 https://review.openstack.org/419299 | 06:48 |
| gokhan | hi team, I have a question about nova-lxd . I have openstack mitaka installation. I created container with lxd. it is running but network is unreacheable. I am using linux bridge . These are logs http://paste.openstack.org/show/594656/. what can be reason of this. Which settings must be done with lxdbridge ? | 06:51 |
| openstackgerrit | zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683 | 06:51 |
| *** kaisers_ has joined #openstack-nova | 06:57 | |
| *** salv-orlando has joined #openstack-nova | 06:57 | |
| *** hoangcx_ has joined #openstack-nova | 06:57 | |
| *** hoangcx has quit IRC | 07:00 | |
| openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | 07:02 |
| openstackgerrit | Huan Xie proposed openstack/nova: XenAPI: Fix vif plug problem during VM rescue/unrescue https://review.openstack.org/413469 | 07:02 |
| *** ayogi has joined #openstack-nova | 07:04 | |
| *** tjones has quit IRC | 07:09 | |
| openstackgerrit | Huan Xie proposed openstack/nova: Fix class type error in attach_interface() function https://review.openstack.org/419308 | 07:12 |
| *** khushbu has quit IRC | 07:13 | |
| *** nkrinner is now known as nkrinner_afk | 07:14 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| *** tbachman has quit IRC | 07:15 | |
| *** raunak has joined #openstack-nova | 07:17 | |
| *** mnestratov has joined #openstack-nova | 07:17 | |
| *** andreas_s has joined #openstack-nova | 07:18 | |
| *** prateek_ has joined #openstack-nova | 07:22 | |
| *** prateek has quit IRC | 07:22 | |
| *** lpetrut has quit IRC | 07:24 | |
| *** mdnadeem has quit IRC | 07:24 | |
| *** ayogi has quit IRC | 07:25 | |
| *** mdnadeem has joined #openstack-nova | 07:25 | |
| *** psachin has quit IRC | 07:27 | |
| *** pbandark has quit IRC | 07:27 | |
| *** tovin07 has quit IRC | 07:28 | |
| *** psachin has joined #openstack-nova | 07:29 | |
| *** lpetrut has joined #openstack-nova | 07:32 | |
| *** pbandark has joined #openstack-nova | 07:33 | |
| *** sudipto has quit IRC | 07:36 | |
| *** sudipto_ has quit IRC | 07:36 | |
| *** nherciu has joined #openstack-nova | 07:38 | |
| openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(3): Introduce base PowerVM driver (console) https://review.openstack.org/409402 | 07:38 |
| *** ttx has quit IRC | 07:40 | |
| *** ttx has joined #openstack-nova | 07:40 | |
| *** gouthamr has quit IRC | 07:42 | |
| *** ttx has quit IRC | 07:47 | |
| *** ttx has joined #openstack-nova | 07:47 | |
| *** logan- has quit IRC | 07:47 | |
| *** tiendc has joined #openstack-nova | 07:48 | |
| *** hoangcx has joined #openstack-nova | 07:49 | |
| *** nherciu_ has joined #openstack-nova | 07:49 | |
| *** hoangcx_ has quit IRC | 07:51 | |
| *** ralonsoh has joined #openstack-nova | 07:52 | |
| *** nherciu has quit IRC | 07:52 | |
| *** logan- has joined #openstack-nova | 07:56 | |
| *** lpetrut has quit IRC | 08:00 | |
| *** sacharya has joined #openstack-nova | 08:01 | |
| *** raunak has quit IRC | 08:01 | |
| *** sapcc-bot has joined #openstack-nova | 08:05 | |
| *** carthaca_ has joined #openstack-nova | 08:05 | |
| *** mkoderer_ has joined #openstack-nova | 08:05 | |
| *** haplo37_ has quit IRC | 08:05 | |
| *** sacharya has quit IRC | 08:06 | |
| *** mkoderer_ has quit IRC | 08:07 | |
| *** carthaca_ has quit IRC | 08:07 | |
| *** mfeoktistov has joined #openstack-nova | 08:08 | |
| *** haplo37_ has joined #openstack-nova | 08:09 | |
| *** aloga has quit IRC | 08:12 | |
| *** aloga has joined #openstack-nova | 08:15 | |
| *** hongbin has quit IRC | 08:16 | |
| *** zenoway has joined #openstack-nova | 08:18 | |
| *** mfeoktistov has left #openstack-nova | 08:21 | |
| *** mfeoktistov has joined #openstack-nova | 08:21 | |
| *** dimtruck is now known as zz_dimtruck | 08:22 | |
| *** diga has quit IRC | 08:26 | |
| *** markus_z has joined #openstack-nova | 08:26 | |
| *** sudipto_ has joined #openstack-nova | 08:31 | |
| *** sudipto has joined #openstack-nova | 08:31 | |
| *** moshele has quit IRC | 08:32 | |
| *** moshele has joined #openstack-nova | 08:33 | |
| *** omnipresent has joined #openstack-nova | 08:34 | |
| *** yamahata has quit IRC | 08:35 | |
| mfeoktistov | Hello! I would like to add a new filter to etc/nova/rootwrap.d/compute.filters | 08:36 |
| mfeoktistov | string like "ploop: RegExpFilter, ploop, root, ploop, init, -s, .*, .*" | 08:36 |
| mfeoktistov | I can see that we use oslo.privsep now. | 08:36 |
| mfeoktistov | And I have a question. How to use it? | 08:36 |
| *** yuntongjin has quit IRC | 08:36 | |
| *** zenoway has quit IRC | 08:36 | |
| *** databus23_ has joined #openstack-nova | 08:39 | |
| openstackgerrit | zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880 | 08:39 |
| *** kberger has quit IRC | 08:41 | |
| *** jwcroppe has quit IRC | 08:41 | |
| *** moshele has quit IRC | 08:41 | |
| *** thorst_ has joined #openstack-nova | 08:41 | |
| *** jwcroppe has joined #openstack-nova | 08:42 | |
| *** moshele has joined #openstack-nova | 08:42 | |
| *** salv-orl_ has joined #openstack-nova | 08:43 | |
| *** salv-orlando has quit IRC | 08:43 | |
| *** nkrinner_afk is now known as nkrinner | 08:44 | |
| *** jwcroppe has quit IRC | 08:46 | |
| *** thorst_ has quit IRC | 08:46 | |
| *** ratailor has quit IRC | 08:46 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | 08:51 |
| *** lyarwood is now known as lyarwood_ | 08:54 | |
| *** lyarwood_ is now known as lyarwood | 08:54 | |
| *** tojuvone has quit IRC | 08:58 | |
| *** manasm has joined #openstack-nova | 08:59 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| *** yingjun has quit IRC | 09:00 | |
| *** david-lyle has quit IRC | 09:01 | |
| *** sacharya has joined #openstack-nova | 09:01 | |
| *** yassine has joined #openstack-nova | 09:02 | |
| *** yassine is now known as Guest29822 | 09:02 | |
| *** khushbu has joined #openstack-nova | 09:02 | |
| *** zenoway has joined #openstack-nova | 09:05 | |
| *** sacharya has quit IRC | 09:06 | |
| *** omnipresent has quit IRC | 09:08 | |
| *** ratailor has joined #openstack-nova | 09:08 | |
| *** roeyc has joined #openstack-nova | 09:10 | |
| *** khushbu has quit IRC | 09:12 | |
| *** mvk has quit IRC | 09:18 | |
| *** lucas-afk is now known as lucasagomes | 09:22 | |
| *** david-lyle has joined #openstack-nova | 09:24 | |
| *** sapcc-bot has quit IRC | 09:25 | |
| *** databus23_ has quit IRC | 09:25 | |
| *** mkoderer_ has joined #openstack-nova | 09:25 | |
| *** carthaca_ has joined #openstack-nova | 09:25 | |
| *** sapcc-bot has joined #openstack-nova | 09:25 | |
| *** databus23_ has joined #openstack-nova | 09:25 | |
| *** salv-orl_ has quit IRC | 09:26 | |
| *** mkoderer_ has quit IRC | 09:27 | |
| *** carthaca_ has quit IRC | 09:27 | |
| *** omnipresent has joined #openstack-nova | 09:32 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix a parameter in os-availability-zone.inc https://review.openstack.org/417233 | 09:33 |
| *** abalutoiu has joined #openstack-nova | 09:34 | |
| gibi | jo | 09:35 |
| gibi | sorry | 09:35 |
| *** zenoway has quit IRC | 09:35 | |
| *** CristinaPauna has quit IRC | 09:35 | |
| *** zhangyujun has quit IRC | 09:36 | |
| *** aloga has quit IRC | 09:37 | |
| *** aloga has joined #openstack-nova | 09:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978 | 09:41 |
| *** zenoway has joined #openstack-nova | 09:43 | |
| *** avolkov has joined #openstack-nova | 09:44 | |
| *** lpetrut has joined #openstack-nova | 09:46 | |
| *** omnipresent has quit IRC | 09:46 | |
| *** owalsh-afk has joined #openstack-nova | 09:47 | |
| *** mfedosin has joined #openstack-nova | 09:47 | |
| *** hfu has quit IRC | 09:48 | |
| *** owalsh-afk is now known as owalsh | 09:49 | |
| *** aloga has quit IRC | 09:50 | |
| *** aloga has joined #openstack-nova | 09:51 | |
| *** mvk has joined #openstack-nova | 09:51 | |
| *** abalutoiu has quit IRC | 09:55 | |
| *** zenoway has quit IRC | 09:56 | |
| *** zayro has quit IRC | 09:58 | |
| *** tiendc has quit IRC | 10:00 | |
| alex_xu | gmann: johnthetubaguy Kevin_Zheng, another idea, we write a new formatter which always reject the validation. Then the schema may looks like this {"system_metadata": {"type": "string", "format": "reject_always"}}, then when user input system_metadata in the query, 400 returned. And we have a way to custom the error message returned from formatter. | 10:00 |
| *** zhangyujun has joined #openstack-nova | 10:02 | |
| *** abalutoiu has joined #openstack-nova | 10:08 | |
| *** derekh has joined #openstack-nova | 10:08 | |
| gmann | alex_xu: i see. | 10:10 |
| gmann | alex_xu: i like to idea but worrying if it make json schema confusing but format name is conveying that anyways | 10:11 |
| *** kevinz has quit IRC | 10:11 | |
| alex_xu | gmann: yea, benefits are we needn't python code to raise badrequest, less hacky in other places, no need one more decorator | 10:12 |
| gmann | alex_xu: but one issue, format will not work if it is not string | 10:12 |
| alex_xu | gmann: the query string in the url, always string :) | 10:13 |
| gmann | alex_xu: yea better than python code doing that | 10:13 |
| gmann | alex_xu: ah yea | 10:13 |
| alex_xu | Kevin_Zheng will give a try, to see how that looks like | 10:15 |
| gmann | alex_xu: but when it comes to schema it will be list of values right | 10:16 |
| * gmann checking | 10:16 | |
| *** moshele has quit IRC | 10:16 | |
| *** ralonsoh_ has joined #openstack-nova | 10:17 | |
| *** moshele has joined #openstack-nova | 10:17 | |
| alex_xu | gmann: yea | 10:18 |
| gmann | so "system_metadata" value will be in list while doing validation | 10:18 |
| alex_xu | gmann: I think the key reason for this trouble was there is no way to express "I want to some specific properties, but I don't want some specific properites, and others just ignore" in the jsonschema | 10:18 |
| *** moshele has quit IRC | 10:19 | |
| alex_xu | gmann: yes | 10:19 |
| *** moshele has joined #openstack-nova | 10:19 | |
| alex_xu | gmann: and we still need to use patternProperties for internal attributes, the regex is "^_" | 10:19 |
| gmann | alex_xu: yea, that is missing in json schema lib, they should provide any way to restrict few known properties | 10:20 |
| *** ralonsoh has quit IRC | 10:20 | |
| gmann | alex_xu: true | 10:20 |
| johnthetubaguy | alex_xu: I quite like that | 10:21 |
| alex_xu | johnthetubaguy: cool \o/ | 10:21 |
| johnthetubaguy | alex_xu: but yeah, I guess you still have to keep the regex thing | 10:21 |
| johnthetubaguy | alex_xu: what about type: "reject_always"? | 10:22 |
| johnthetubaguy | or is that not allowed | 10:22 |
| gmann | alex_xu: johnthetubaguy but will it work as values will not be string | 10:22 |
| alex_xu | probably "patternProperties": {"^_": {"type": "string", "format": reject_always"}} | 10:22 |
| gmann | https://github.com/openstack/nova/blob/master/nova/api/validation/__init__.py#L160 | 10:23 |
| *** dgonzalez_ has joined #openstack-nova | 10:23 | |
| *** carthaca_ has joined #openstack-nova | 10:23 | |
| alex_xu | johnthetubaguy: i'm not sure json-schema have a way to extend the type, I need to check that | 10:23 |
| *** owalsh is now known as owalsh-brb | 10:24 | |
| johnthetubaguy | I mean they are all strings in query string params anyways | 10:24 |
| *** carthaca_ has quit IRC | 10:25 | |
| *** dgonzalez_ has quit IRC | 10:25 | |
| gmann | but we do convert those into list of values for validation, so they are array for schema | 10:25 |
| johnthetubaguy | well, I guess I mean everything is a list of strings | 10:26 |
| gmann | yea but json schema just ignore format validation and pass if instance is not string | 10:27 |
| *** hoangcx has quit IRC | 10:27 | |
| *** sree has quit IRC | 10:28 | |
| *** phuongnh has quit IRC | 10:28 | |
| *** sree has joined #openstack-nova | 10:28 | |
| alex_xu | johnthetubaguy: gmann we can add new type. but I guess there is no way to change the error message. User will get a message about "this isn't a type of reject_always" | 10:28 |
| johnthetubaguy | doh | 10:29 |
| johnthetubaguy | good point | 10:29 |
| johnthetubaguy | why are we moving away from the decorator approach? | 10:29 |
| alex_xu | johnthetubaguy: probably avoid one more decorator, and we put all the info into the schema: it is not part of in the schema and part of in the decorator | 10:30 |
| alex_xu | johnthetubaguy: and Kevin_Zheng show me this https://review.openstack.org/#/c/419256/2/nova/api/validation/__init__.py, I feel the change is bigger than I thought | 10:30 |
| alex_xu | But I guess there can be some code sharing, but another worry is another refactor for the code | 10:31 |
| johnthetubaguy | we don't really need min and max though | 10:31 |
| johnthetubaguy | I thought | 10:31 |
| johnthetubaguy | not yet anyways | 10:31 |
| alex_xu | it needs a version control | 10:32 |
| *** sree has quit IRC | 10:32 | |
| alex_xu | in the future we may add new filter before we reject all? | 10:32 |
| gmann | yea version things we can avoid as of not and do when microversion bump | 10:32 |
| alex_xu | oops, sorry, that isn't the case | 10:32 |
| Kevin_Zheng | yeah, otherwise we can just do it in schema with additional=false | 10:32 |
| gmann | not->now | 10:32 |
| openstackgerrit | zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880 | 10:34 |
| *** satyar has quit IRC | 10:35 | |
| *** mvk has quit IRC | 10:36 | |
| *** owalsh-brb is now known as owalsh | 10:37 | |
| alex_xu | when we reject all, that decorator still can be there. | 10:37 |
| *** abalutoiu has quit IRC | 10:37 | |
| alex_xu | emm...so, yes, sounds like no version is ok | 10:39 |
| *** thorst_ has joined #openstack-nova | 10:42 | |
| alex_xu | johnthetubaguy: gmann Kevin_Zheng I guess the only different is we want to put all the info together, or just split that special case out of schema? is that question we should answer? | 10:43 |
| *** CristinaPauna has joined #openstack-nova | 10:43 | |
| *** JoseMello has joined #openstack-nova | 10:43 | |
| *** cdent has joined #openstack-nova | 10:44 | |
| *** huanxie has quit IRC | 10:45 | |
| *** thorst_ has quit IRC | 10:47 | |
| gmann | alex_xu: you mean in case we add in schema with new formatter ? | 10:48 |
| *** mvk has joined #openstack-nova | 10:48 | |
| alex_xu | gmann: yes | 10:48 |
| gmann | alex_xu: but 'format' only work if instance going to be validated is string and in our case it is list of values right | 10:49 |
| alex_xu | gmann: we have macro function 'multi_params', that works for list | 10:49 |
| *** abalutoiu has joined #openstack-nova | 10:50 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Better black list for py35 tests https://review.openstack.org/419250 | 10:51 |
| gmann | alex_xu: yea but instance (values) will be list and we would not be able to define like {"system_metadata": {"type": "string", "format": "reject_always"}} | 10:52 |
| alex_xu | gmann: here is https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L38 | 10:52 |
| gmann | we have to do like this - {"system_metadata": {multi_params, "format": "reject_always"}} | 10:52 |
| alex_xu | gmann: sorry, it should be {"system_metadata": multi_params({"type": "string", "format": "reject_always"})} | 10:52 |
| gmann | alex_xu: ahh i see, so that each item will be validated against "reject_always" | 10:54 |
| alex_xu | gmann: yea | 10:54 |
| *** sapcc-bot has quit IRC | 10:54 | |
| *** databus23_ has quit IRC | 10:54 | |
| alex_xu | but have to say reject_always format is another hacky thing. is it decorator more explicitly? | 10:54 |
| alex_xu | s/is it decorator/ is decorator/ | 10:55 |
| *** carthaca_ has joined #openstack-nova | 10:55 | |
| *** dgonzalez_ has joined #openstack-nova | 10:55 | |
| *** databus23_ has joined #openstack-nova | 10:55 | |
| *** sapcc-bot has joined #openstack-nova | 10:55 | |
| *** claudiub|2 has joined #openstack-nova | 10:55 | |
| *** gszasz has joined #openstack-nova | 10:55 | |
| alex_xu | s/explicitly/explicity/... | 10:55 |
| gmann | humm, another issue may be error message otherwise i like new formatter way | 10:56 |
| *** amotoki has quit IRC | 10:56 | |
| gmann | alex_xu: but we can catch and format error message which will be other hack but wotrks | 10:56 |
| *** carthaca_ has quit IRC | 10:57 | |
| *** dgonzalez_ has quit IRC | 10:57 | |
| alex_xu | gmann: yea, we already have one case https://github.com/openstack/nova/blob/master/nova/api/validation/validators.py#L264, then probably add another one | 10:57 |
| gmann | johnthetubaguy: i think string thing solved here as alex_xu mentioned we can validate against each item of list and 'format' works | 10:57 |
| gmann | alex_xu: :) aboout to give that example | 10:58 |
| *** Jeffrey4l__ is now known as Jeffrey4l | 10:58 | |
| gmann | alex_xu: i am +1 with new formatter. | 10:58 |
| alex_xu | gmann: :) | 10:58 |
| gmann | alex_xu: johnthetubaguy have to rush for train. ll see log later | 10:58 |
| alex_xu | gmann: yea, I have to go home also, back later | 10:59 |
| *** tojuvone has joined #openstack-nova | 11:00 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | 11:02 |
| *** sacharya has joined #openstack-nova | 11:02 | |
| *** amotoki has joined #openstack-nova | 11:06 | |
| *** sacharya has quit IRC | 11:07 | |
| *** databus23_ has quit IRC | 11:15 | |
| *** sapcc-bot has quit IRC | 11:15 | |
| *** sapcc-bot has joined #openstack-nova | 11:16 | |
| *** databus23_ has joined #openstack-nova | 11:16 | |
| *** carthaca_ has joined #openstack-nova | 11:16 | |
| *** dgonzalez_ has joined #openstack-nova | 11:16 | |
| *** carthaca_ has quit IRC | 11:18 | |
| *** dgonzalez_ has quit IRC | 11:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | 11:20 |
| openstackgerrit | zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683 | 11:21 |
| *** rfolco has joined #openstack-nova | 11:21 | |
| *** sudipto has quit IRC | 11:22 | |
| *** sudipto_ has quit IRC | 11:22 | |
| *** cdent has quit IRC | 11:23 | |
| *** manasm has quit IRC | 11:32 | |
| *** nicolasbock has joined #openstack-nova | 11:34 | |
| *** smatzek has joined #openstack-nova | 11:36 | |
| openstackgerrit | Zhihai Song proposed openstack/nova: Update py35 functional tests blacklist https://review.openstack.org/415149 | 11:38 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 11:39 |
| *** voelzmo has joined #openstack-nova | 11:41 | |
| *** ralonsoh_ is now known as ralonsoh | 11:42 | |
| *** sree has joined #openstack-nova | 11:46 | |
| *** voelzmo has quit IRC | 11:47 | |
| *** prateek has joined #openstack-nova | 11:47 | |
| *** voelzmo has joined #openstack-nova | 11:48 | |
| openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(4): Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404 | 11:49 |
| *** ociuhandu has quit IRC | 11:50 | |
| *** sree has quit IRC | 11:50 | |
| *** voelzmo has quit IRC | 11:52 | |
| *** amotoki has quit IRC | 11:53 | |
| *** ralonsoh_ has joined #openstack-nova | 11:55 | |
| *** masber has quit IRC | 11:56 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | 11:57 |
| *** amotoki has joined #openstack-nova | 11:58 | |
| *** ralonsoh has quit IRC | 11:59 | |
| *** abalutoiu_ has joined #openstack-nova | 11:59 | |
| *** bkopilov has quit IRC | 11:59 | |
| openstackgerrit | Zhihai Song proposed openstack/nova: Enable tests.functional.db.api.test_migrations for py35 https://review.openstack.org/419435 | 11:59 |
| *** voelzmo has joined #openstack-nova | 12:00 | |
| *** ducttape_ has joined #openstack-nova | 12:01 | |
| *** ducttape_ has quit IRC | 12:01 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | 12:02 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 12:02 |
| *** abalutoiu has quit IRC | 12:02 | |
| *** amotoki_ has joined #openstack-nova | 12:03 | |
| *** cdent has joined #openstack-nova | 12:03 | |
| *** abalutoiu_ has quit IRC | 12:04 | |
| *** voelzmo has quit IRC | 12:05 | |
| *** abalutoiu has joined #openstack-nova | 12:05 | |
| *** amotoki has quit IRC | 12:05 | |
| *** tuanluong_ has quit IRC | 12:06 | |
| *** sahid has joined #openstack-nova | 12:08 | |
| *** abalutoiu has quit IRC | 12:09 | |
| *** amotoki_ has quit IRC | 12:10 | |
| *** rtheis has joined #openstack-nova | 12:11 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_detach notification https://review.openstack.org/408676 | 12:13 |
| *** links has quit IRC | 12:13 | |
| *** dave-mccowan has joined #openstack-nova | 12:13 | |
| *** sree has joined #openstack-nova | 12:13 | |
| *** baoli has joined #openstack-nova | 12:14 | |
| *** baoli has quit IRC | 12:15 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova: Reduce code duplication https://review.openstack.org/270911 | 12:15 |
| *** baoli has joined #openstack-nova | 12:15 | |
| *** derekh has quit IRC | 12:16 | |
| *** derekh has joined #openstack-nova | 12:16 | |
| *** manasm has joined #openstack-nova | 12:19 | |
| *** mdnadeem has quit IRC | 12:19 | |
| *** sheel has joined #openstack-nova | 12:19 | |
| *** baoli has quit IRC | 12:21 | |
| *** bvanhav__ has joined #openstack-nova | 12:21 | |
| openstackgerrit | Istvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | 12:21 |
| *** voelzmo has joined #openstack-nova | 12:22 | |
| openstackgerrit | Zhihai Song proposed openstack/nova: Update py35 functional tests blacklist https://review.openstack.org/415149 | 12:24 |
| *** owalsh is now known as owalsh-lunch | 12:25 | |
| *** voelzmo has quit IRC | 12:26 | |
| *** lucasagomes is now known as lucas-hungry | 12:26 | |
| *** abalutoiu has joined #openstack-nova | 12:29 | |
| dims | mriedem : bauzas : the review for the py35 functional test blacklist is ready - https://review.openstack.org/#/c/419250/ | 12:31 |
| *** yuntongjin has joined #openstack-nova | 12:32 | |
| *** ociuhandu has joined #openstack-nova | 12:33 | |
| *** Prophidys has quit IRC | 12:35 | |
| *** yuntongjin has quit IRC | 12:35 | |
| *** zhangyujun has quit IRC | 12:36 | |
| *** manasm has quit IRC | 12:37 | |
| *** pbandark has quit IRC | 12:38 | |
| *** tommylikehu has quit IRC | 12:39 | |
| *** tommylikehu has joined #openstack-nova | 12:40 | |
| *** Prophidys has joined #openstack-nova | 12:40 | |
| openstackgerrit | Chris Dent proposed openstack/nova: Small improvements to placement.rst https://review.openstack.org/403811 | 12:42 |
| *** sdague has joined #openstack-nova | 12:43 | |
| *** thorst_ has joined #openstack-nova | 12:46 | |
| cdent | mriedem, bauzas : can we get that merged or otherwise reviewed? Or if not, let me know so I can abandon it. | 12:46 |
| *** gcb has quit IRC | 12:49 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova: Reduced the complexity of the _init_instance method https://review.openstack.org/374661 | 12:50 |
| *** gongysh has joined #openstack-nova | 12:52 | |
| *** manasm has joined #openstack-nova | 12:52 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance https://review.openstack.org/418512 | 12:53 |
| *** voelzmo has joined #openstack-nova | 12:54 | |
| *** voelzmo has quit IRC | 12:58 | |
| *** dgonzalez has quit IRC | 12:58 | |
| *** mdnadeem has joined #openstack-nova | 13:00 | |
| bauzas | cdent: looking | 13:02 |
| cdent | thanks | 13:02 |
| *** lucas-hungry is now known as lucasagomes | 13:02 | |
| bauzas | cdent: +2d | 13:03 |
| cdent | more thanks! | 13:03 |
| bauzas | cdent: I'll abandon my doc patch changing the port number | 13:03 |
| *** sacharya has joined #openstack-nova | 13:03 | |
| *** salv-orlando has joined #openstack-nova | 13:04 | |
| *** dgonzalez has joined #openstack-nova | 13:05 | |
| *** gongysh has quit IRC | 13:07 | |
| *** sacharya has quit IRC | 13:08 | |
| *** mdnadeem has quit IRC | 13:09 | |
| *** edmondsw has joined #openstack-nova | 13:10 | |
| gibi | hi nova! | 13:13 |
| gibi | I have a question about lazy-loaded fields | 13:13 |
| cdent | hi gibi ! | 13:13 |
| cdent | (someone has had their coffee today) | 13:14 |
| gibi | cdent: :) | 13:14 |
| gibi | Do I see correctly that instance.flavor.projects access is a double lazy-load? | 13:14 |
| gibi | and that it will not work | 13:14 |
| gibi | as when the flavor is loaded into the instance | 13:14 |
| gibi | then the Flavor object is orphaned | 13:15 |
| *** alexpilo_ has joined #openstack-nova | 13:15 | |
| gibi | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L315 | 13:15 |
| *** efried has joined #openstack-nova | 13:15 | |
| * cdent has not had enough coffee today to parse that | 13:16 | |
| gibi | so I have an instance object | 13:16 |
| gibi | and I access instance.flavor | 13:16 |
| gibi | which will lazy load the Falvor object | 13:16 |
| gibi | and then I try to access the projects field of that Flavor object that is again a lazy load | 13:17 |
| gibi | then that is fails as the Falvor object is orphaned | 13:17 |
| *** alexpilotti has quit IRC | 13:17 | |
| *** aunnam has quit IRC | 13:17 | |
| *** gokhan has quit IRC | 13:17 | |
| *** kylek3h has quit IRC | 13:18 | |
| *** gokhan has joined #openstack-nova | 13:18 | |
| gibi | I started here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5031 | 13:18 |
| gibi | with an instance | 13:18 |
| gibi | then that notification sending first access instance.flavor and that is OK as the instance is not orphaned | 13:19 |
| gibi | but after that the code needs instance.flavor.projects and that fails | 13:19 |
| cdent | gibi: this is the sort of question I'd love to see on the mailing list so that the response is preserved somewhere more readable by more people than IRC. Also I don't know the answer :) | 13:19 |
| gibi | OrphanedObjectError: Cannot call _load_projects on orphaned Flavor object | 13:19 |
| *** aunnam has joined #openstack-nova | 13:19 | |
| gibi | cdent: OK, I post to ML | 13:19 |
| cdent | it looks like those flavor objects being created never get a context? | 13:21 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add some code to reject known bad filters. https://review.openstack.org/419256 | 13:22 |
| gibi | yes, it seems to me the context is missingf | 13:22 |
| cdent | which presumably means someone wanted to make sure you can't do what you're trying to do? :) | 13:23 |
| *** ralonsoh_ is now known as ralonsoh | 13:23 | |
| gibi | I'm not sure about that | 13:24 |
| gibi | I think it is more likely that we forgot the context there | 13:25 |
| *** kberger has joined #openstack-nova | 13:25 | |
| Dinesh_Bhor | cdent: Hi, do you have some time? I am not much clear about 'Content-Type' in response so thought to ask you few doubts. | 13:25 |
| *** links has joined #openstack-nova | 13:25 | |
| cdent | Dinesh_Bhor: I can try. What's up? | 13:26 |
| *** aarefiev_afk is now known as aarefiev | 13:26 | |
| Dinesh_Bhor | cdent: Is it compulsory that all openstack services should return 'Content-Type' in response header? | 13:26 |
| Dinesh_Bhor | cdent: I have seen most of the openstack services returning 'Content-Type' in response header. | 13:26 |
| cdent | Dinesh_Bhor: that's a requirement of HTTP, not just openstack | 13:28 |
| cdent | if there is a body in the response there needs to be a content-type header to identify what media type it is | 13:28 |
| cdent | Dinesh_Bhor: there's some extensive information in the RFC: https://tools.ietf.org/html/rfc7231#section-3.1 | 13:29 |
| *** claudiub has joined #openstack-nova | 13:30 | |
| cdent | Dinesh_Bhor: does that help? | 13:31 |
| Dinesh_Bhor | cdent: yes, thank you so much | 13:31 |
| cdent | the same thing is true of a request: if it has a body it needs a content-type header too | 13:32 |
| *** claudiub|2 has quit IRC | 13:33 | |
| *** ralonsoh_ has joined #openstack-nova | 13:33 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova: Reduced the complexity of the _init_instance method (2) https://review.openstack.org/419463 | 13:35 |
| *** ralonsoh has quit IRC | 13:36 | |
| *** sree_ has joined #openstack-nova | 13:36 | |
| dims | bauzas : you may have missed my ping :) https://review.openstack.org/#/c/419250/ | 13:36 |
| *** gongysh has joined #openstack-nova | 13:36 | |
| bauzas | dims: heh, oops :) | 13:36 |
| *** sree_ is now known as Guest67009 | 13:36 | |
| dims | no worries :) | 13:36 |
| *** sudipto_ has joined #openstack-nova | 13:37 | |
| *** sudipto has joined #openstack-nova | 13:37 | |
| openstackgerrit | Julian proposed openstack/nova: Create script that prints JSON Schema of Notification Payload Classes https://review.openstack.org/411836 | 13:37 |
| *** manasm has quit IRC | 13:38 | |
| *** sree has quit IRC | 13:39 | |
| *** salv-orlando has quit IRC | 13:39 | |
| *** bkopilov has joined #openstack-nova | 13:39 | |
| *** sree has joined #openstack-nova | 13:39 | |
| Dinesh_Bhor | cdent: sry to disturb you again. agree that If the request contains body then there must have content-type but if service returns an http exception then in response will that content-type be available? | 13:41 |
| efried | mriedem: Can we add a PowerVM section in https://etherpad.openstack.org/p/ocata-nova-priorities-tracking ? | 13:41 |
| *** voelzmo has joined #openstack-nova | 13:41 | |
| *** Guest67009 has quit IRC | 13:41 | |
| cdent | Dinesh_Bhor: the content-type header should always say what the media type of the body is, even when returning an exception. If the exception has been formatted to JSON then the content-type should be application/json. If it is html, then text/html. If it is straight text then text/plain | 13:42 |
| *** takashin has joined #openstack-nova | 13:42 | |
| Dinesh_Bhor | cdent: ok, explains a lot | 13:43 |
| *** sree has quit IRC | 13:43 | |
| cdent | Dinesh_Bhor: just out of curiosity what are you working on that raised these questions? | 13:43 |
| Dinesh_Bhor | cdent: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/exc.py#L156 this one | 13:45 |
| Dinesh_Bhor | cdent: here all logic is based on content-type | 13:45 |
| * cdent looks | 13:45 | |
| *** voelzmo has quit IRC | 13:46 | |
| *** owalsh-lunch is now known as owalsh | 13:46 | |
| *** sree has joined #openstack-nova | 13:47 | |
| Dinesh_Bhor | cdent: and I am trying to solve bug in openstacksdk by refering that logic | 13:47 |
| * cdent nods | 13:47 | |
| *** eharney has quit IRC | 13:49 | |
| *** efried has quit IRC | 13:50 | |
| *** sridharg has quit IRC | 13:51 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_detach notification https://review.openstack.org/408676 | 13:51 |
| *** efried has joined #openstack-nova | 13:52 | |
| mriedem | efried: yea | 13:54 |
| *** kylek3h has joined #openstack-nova | 13:54 | |
| dims | mriedem : please bless this https://review.openstack.org/#/c/419250/ | 13:55 |
| *** pradk has joined #openstack-nova | 13:55 | |
| mriedem | dims: done | 13:56 |
| dims | thanks mriedem | 13:56 |
| mriedem | lyarwood: fyi the placement job on stable/newton should be fixed now | 13:57 |
| mriedem | bauzas: ^ | 13:57 |
| bauzas | cool | 13:57 |
| mriedem | jroll: now that https://review.openstack.org/#/c/364420/ is merged are you good to do an ironicclient release? | 13:58 |
| *** lamt has joined #openstack-nova | 13:58 | |
| *** tblakes has joined #openstack-nova | 13:58 | |
| dims | mriedem : yep, added the failing ones, then sort and uniq, that's it | 13:59 |
| *** ratailor has quit IRC | 13:59 | |
| efried | mriedem: done (etherpad update) | 13:59 |
| *** prateek_ has quit IRC | 14:03 | |
| *** bvanhav_ has joined #openstack-nova | 14:03 | |
| *** prateek has quit IRC | 14:03 | |
| *** mdrabe has joined #openstack-nova | 14:04 | |
| *** bvanhav__ has quit IRC | 14:04 | |
| bauzas | mriedem: nova meeting ? :) | 14:05 |
| *** burt has joined #openstack-nova | 14:05 | |
| *** amotoki has joined #openstack-nova | 14:09 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260 | 14:10 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261 | 14:10 |
| *** lpetrut has quit IRC | 14:11 | |
| *** gouthamr has joined #openstack-nova | 14:11 | |
| *** huanxie has joined #openstack-nova | 14:11 | |
| *** eharney has joined #openstack-nova | 14:11 | |
| openstackgerrit | Tanvir Talukder proposed openstack/nova-specs: Support sub-admin roles in Nova https://review.openstack.org/419474 | 14:15 |
| openstackgerrit | Tanvir Talukder proposed openstack/nova-specs: Support sub-admin roles in Nova https://review.openstack.org/419474 | 14:16 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 14:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec.numa_topology https://review.openstack.org/419479 | 14:19 |
| *** liverpooler has quit IRC | 14:20 | |
| *** mlavalle has joined #openstack-nova | 14:22 | |
| *** bvanhav_ is now known as bvanhav | 14:22 | |
| jroll | mriedem: yep, will be doing that today | 14:23 |
| *** baoli has joined #openstack-nova | 14:23 | |
| *** amotoki has quit IRC | 14:24 | |
| openstackgerrit | Tanvir Talukder proposed openstack/nova-specs: Support sub-admin roles in Nova https://review.openstack.org/419474 | 14:26 |
| *** psachin has quit IRC | 14:28 | |
| *** mriedem has quit IRC | 14:28 | |
| *** amotoki has joined #openstack-nova | 14:29 | |
| *** ducttape_ has joined #openstack-nova | 14:29 | |
| *** satyar has joined #openstack-nova | 14:30 | |
| *** smatzek has quit IRC | 14:30 | |
| *** amotoki has quit IRC | 14:31 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509 | 14:32 |
| *** amotoki has joined #openstack-nova | 14:33 | |
| *** cdent has quit IRC | 14:34 | |
| *** cmartin has joined #openstack-nova | 14:34 | |
| *** tlian has joined #openstack-nova | 14:34 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 14:36 |
| *** sridharg has joined #openstack-nova | 14:37 | |
| *** tblakes has quit IRC | 14:37 | |
| *** salv-orlando has joined #openstack-nova | 14:39 | |
| *** prateek_ has joined #openstack-nova | 14:40 | |
| artom | mdbooth, around? Feel like weighing in on a debate between vladikr and I? We're discussing what's the best way to match block devices between the BDM object (in the DB) and the instance XML in libvirt. It used to be done with device name, and I'm changing it to serial (aka volume uuid). Here's the review: https://review.openstack.org/#/c/418100/4 | 14:41 |
| *** prateek has joined #openstack-nova | 14:41 | |
| *** salv-orlando has quit IRC | 14:41 | |
| mdbooth | artom: Looking | 14:41 |
| *** salv-orlando has joined #openstack-nova | 14:41 | |
| *** xinliang has quit IRC | 14:42 | |
| *** liverpooler has joined #openstack-nova | 14:43 | |
| *** baoli has quit IRC | 14:46 | |
| *** aslezil_ has joined #openstack-nova | 14:47 | |
| *** gongysh has quit IRC | 14:48 | |
| *** dikonoor has quit IRC | 14:48 | |
| *** tbachman has joined #openstack-nova | 14:50 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: remove libvirt imagecache https://review.openstack.org/378497 | 14:50 |
| *** takashin has left #openstack-nova | 14:55 | |
| *** xinliang has joined #openstack-nova | 14:55 | |
| *** sapcc-bot has quit IRC | 14:56 | |
| *** databus23_ has quit IRC | 14:56 | |
| *** sapcc-bot has joined #openstack-nova | 14:56 | |
| *** databus23_ has joined #openstack-nova | 14:56 | |
| *** carthaca_ has joined #openstack-nova | 14:56 | |
| *** yingjun has joined #openstack-nova | 14:56 | |
| openstackgerrit | Istvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | 14:57 |
| *** gcb has joined #openstack-nova | 14:58 | |
| *** smatzek has joined #openstack-nova | 14:58 | |
| *** carthaca_ has quit IRC | 14:58 | |
| *** hongbin has joined #openstack-nova | 14:59 | |
| *** lucasagomes has quit IRC | 14:59 | |
| *** lucasagomes has joined #openstack-nova | 15:00 | |
| *** lamt has quit IRC | 15:02 | |
| *** mriedem has joined #openstack-nova | 15:02 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova: Update all instances when their AZ is renamed https://review.openstack.org/419502 | 15:02 |
| *** sree has quit IRC | 15:02 | |
| mriedem | bauzas: thanks for running the meeting - i had to get my daughter ready for school so the 8am meeting always throws me off | 15:02 |
| bauzas | mriedem: I have the exact same problem for the scheduler meeting | 15:02 |
| bauzas | mriedem: so I understand you | 15:02 |
| bauzas | my proposal to stop scholarizing my daughter unfortunately got a NACK from my wife :/ | 15:03 |
| *** lamt has joined #openstack-nova | 15:03 | |
| bauzas | don't understand why... | 15:03 |
| mriedem | heh | 15:03 |
| *** sacharya has joined #openstack-nova | 15:04 | |
| mriedem | just send her out during the day and let her learn the lessons of the wild | 15:04 |
| *** cleong has joined #openstack-nova | 15:04 | |
| bauzas | at 6, yeah | 15:04 |
| *** amotoki has quit IRC | 15:05 | |
| edleafe | mriedem: drop her off early. That'll toughen her up in Minnesota winters! | 15:05 |
| *** tblakes has joined #openstack-nova | 15:05 | |
| bauzas | I should have a dog by april, I'll teach my daughter how to dog sled | 15:05 |
| mriedem | i had to walk to school at her age in the winter... | 15:05 |
| mriedem | so back in my day... | 15:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec.numa_topology https://review.openstack.org/419479 | 15:06 |
| jroll | she'll literally get buried trying to walk in the snow up there, that seems unwise | 15:06 |
| *** tlian has quit IRC | 15:06 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove the Allocation.create() method. https://review.openstack.org/416751 | 15:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add check for invalid allocation amounts https://review.openstack.org/416752 | 15:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Fix missing RP generation update https://review.openstack.org/419137 | 15:06 |
| *** sheel has quit IRC | 15:07 | |
| *** huanxie has quit IRC | 15:07 | |
| mriedem | lyarwood: just fyi before you see it, i've got a series of backports for newton to make this pass https://review.openstack.org/#/c/416734/ | 15:08 |
| mriedem | i.e. ironic in newton will fail if placement is enabled w/o that series of fixes | 15:08 |
| *** rama_y has joined #openstack-nova | 15:08 | |
| mriedem | https://review.openstack.org/#/c/416762/ is the target fix, but there are several dependent patches before it to keep the diff sane | 15:08 |
| *** rama_y_ has joined #openstack-nova | 15:09 | |
| *** sacharya has quit IRC | 15:09 | |
| mriedem | some aren't bug fixes, they are refactors, but not new features so shouldn't be too concerning | 15:09 |
| mriedem | wznoinsk: the intel nfv ci job tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial seems to always fail on stable/newton changes - is there something we need to backport to fix that or is it even worth running that job on newton? | 15:10 |
| *** yingjun has quit IRC | 15:11 | |
| mriedem | e.g. http://intel-openstack-ci-logs.ovh/25/408725/2/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/2aa0563/console.html | 15:11 |
| *** yingjun has joined #openstack-nova | 15:11 | |
| mriedem | johnthetubaguy: this is ready for you https://review.openstack.org/#/c/397399/ | 15:12 |
| mriedem | raj_singh: i left a comment in https://review.openstack.org/#/c/410394/ but i'm not sure what, if anything, to do about testing that | 15:12 |
| *** mfeoktistov has quit IRC | 15:12 | |
| *** jamesdenton has joined #openstack-nova | 15:13 | |
| mriedem | raj_singh: it seems like we should at least have a unit test that sets send_service_user_token=True and makes the neutronclient non-admin connection | 15:13 |
| *** zz_dimtruck is now known as dimtruck | 15:14 | |
| *** tlian has joined #openstack-nova | 15:15 | |
| *** claudiub|2 has joined #openstack-nova | 15:16 | |
| lyarwood | mriedem: ack thanks, I'll try to get to them tomorrow if that's okay, currently stuck downstream fighting fires | 15:17 |
| mriedem | lyarwood: yeah that's fine, just giving you a heads up | 15:18 |
| lyarwood | mriedem: cheers, likewise there's a few from me with +2 from tonyb if you have a chance | 15:18 |
| *** claudiub has quit IRC | 15:19 | |
| mriedem | ok | 15:19 |
| *** aslezil_ has quit IRC | 15:19 | |
| *** yamahata has joined #openstack-nova | 15:20 | |
| raj_singh | mriedem: Ok, Let me look into that. Also the Glance patch I can split into 2, but service token change is just 1 line code change, so I figure to do it in just one patch. | 15:21 |
| *** cfriesen has joined #openstack-nova | 15:22 | |
| raj_singh | mriedem: https://review.openstack.org/#/c/412634/ | 15:22 |
| *** jaosorior has joined #openstack-nova | 15:22 | |
| *** yingjun has quit IRC | 15:23 | |
| *** mtanino has joined #openstack-nova | 15:24 | |
| *** roeyc has quit IRC | 15:25 | |
| *** markvoelker has quit IRC | 15:27 | |
| dansmith | mriedem: I think bauzas wants you to +W this: https://review.openstack.org/#/c/409890/ | 15:28 |
| mriedem | oy | 15:28 |
| *** jwcroppe has joined #openstack-nova | 15:28 | |
| mriedem | have to run to a meeting | 15:28 |
| *** yingjun has joined #openstack-nova | 15:29 | |
| *** yingjun has quit IRC | 15:29 | |
| mriedem | dansmith: on the placement reconnect backport, there is a change beneath it too | 15:29 |
| *** yingjun has joined #openstack-nova | 15:29 | |
| dansmith | mriedem: oh okay | 15:29 |
| *** mdrabe has quit IRC | 15:32 | |
| *** mtanino has quit IRC | 15:36 | |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 15:37 |
| *** mdrabe has joined #openstack-nova | 15:39 | |
| *** sacharya has joined #openstack-nova | 15:41 | |
| *** marst has joined #openstack-nova | 15:41 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: Add CPUWeigher https://review.openstack.org/379525 | 15:42 |
| *** Tryn00 has joined #openstack-nova | 15:42 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 15:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | 15:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 15:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: API support for tagged device attachment https://review.openstack.org/376021 | 15:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | 15:43 |
| mdbooth | artom: Is the user able to see 'serial' as known to cinder? | 15:43 |
| *** mvk has quit IRC | 15:44 | |
| artom | mdbooth, it's the volume uuid | 15:44 |
| mdbooth | Because if so, they can already find that that volume | 15:44 |
| mdbooth | http://libvirt.org/formatdomain.html#elementsDevices | 15:45 |
| mdbooth | serial | 15:45 |
| mdbooth | If present, this specify serial number of virtual hard drive. For example, it may look like <serial>WD-WMAP9A966149</serial>. Not supported for scsi-block devices, that is those using disk type 'block' using device 'lun' on bus 'scsi'. Since 0.7.1 | 15:45 |
| mdbooth | Am I missing something? | 15:45 |
| mdbooth | The user doesn't have to look up the hardware address in metadata, because they can just look for the disk with the given serial | 15:46 |
| *** yingjun has quit IRC | 15:46 | |
| *** raj_singh_ has joined #openstack-nova | 15:46 | |
| artom | mdbooth, heh, good point... | 15:46 |
| artom | I don't have an answer for that, but I have another question - can we trust the device name to at least match between instance XML and block_device_mapping in the db? | 15:47 |
| mdbooth | artom: That's what I've been looking at | 15:47 |
| mdbooth | Short answer is no, we can't | 15:48 |
| artom | The way our current Tempest test for that is written, we can | 15:48 |
| artom | But the test definitely doens't cover all possible weird cases | 15:48 |
| artom | And I know for volume attachment it didn't match | 15:48 |
| mdbooth | e.g. I believe the following will bork it: | 15:49 |
| mdbooth | Create instance with config disk | 15:49 |
| *** jaypipes has joined #openstack-nova | 15:49 | |
| mdbooth | attach volume | 15:49 |
| mdbooth | reboot/migrate | 15:49 |
| mdbooth | After reboot/migrate, xml will be rewritten and iirc config disk will be last again | 15:49 |
| mdbooth | So volume name will have changed | 15:50 |
| *** sridharg has quit IRC | 15:51 | |
| artom | That doesn't sound like it's fixable... | 15:51 |
| mdbooth | In this patch we're entirely rewriting device_metadata if we attach a tagged volume, right? | 15:51 |
| artom | mdbooth, yeah | 15:52 |
| mdbooth | Any chance of not doing that? | 15:52 |
| artom | You're thinking we just add the new bdm tag without recalculating everything? | 15:52 |
| mdbooth | e.g. just updating it | 15:52 |
| mdbooth | Yeah | 15:52 |
| *** markvoelker has joined #openstack-nova | 15:52 | |
| mdbooth | We only created it on line 1212, and we've still got the conf it was created from | 15:53 |
| mdbooth | Do we really need to reparse the whole xml? | 15:53 |
| mdbooth | Hmm, _prepare_device_bus reads assigned hw address... | 15:53 |
| mdbooth | So I guess the answer is yes | 15:54 |
| artom | Glad that worked out without me having to answer ;) | 15:54 |
| shaner | in kilo, when performing a live-migration, it's not showing up when doing a 'migration-list' | 15:54 |
| shaner | but, doesn't happen in mitaka | 15:54 |
| mdbooth | However, in this specific case all we need to do is match a single device, which we just added, and parse its assigned hw address | 15:54 |
| *** gszasz has quit IRC | 15:55 | |
| artom | mdbooth, would that actually solve the bdm <-> xml match problem though? | 15:55 |
| mdbooth | I agree with vladikr that relying on the contents of connection_info is unpleasant, though | 15:55 |
| mdbooth | Although in this case, if it's not set we do at least have the opportunity to set it | 15:56 |
| *** bkopilov has quit IRC | 15:56 | |
| *** cdent has joined #openstack-nova | 15:56 | |
| *** aslezil_ has joined #openstack-nova | 15:58 | |
| *** pcaruana has joined #openstack-nova | 15:58 | |
| mdbooth | artom: Still thinking. Will comment on the review | 15:59 |
| *** gszasz has joined #openstack-nova | 15:59 | |
| artom | mdbooth, many thanks :) From what I'm gathering, we have two ways to perform that bdm <-> xml matching (serial and device name), and both won't work 100% of the time | 15:59 |
| artom | So the question becomes, which one is easier to "fix"? | 16:00 |
| mriedem | mnestratov: can someone from VZ fix up this comment quick? https://review.openstack.org/#/c/355805/18/nova/virt/libvirt/driver.py@684 | 16:00 |
| mriedem | mnestratov: otherwise i'm +2 on that change | 16:00 |
| mriedem | mnestratov: nevermind, i'll just update that myself | 16:01 |
| *** cmartin has quit IRC | 16:03 | |
| *** sudipto has quit IRC | 16:05 | |
| *** sudipto_ has quit IRC | 16:05 | |
| *** sudipto_ has joined #openstack-nova | 16:05 | |
| *** sudipto has joined #openstack-nova | 16:05 | |
| *** nkrinner is now known as nkrinner_afk | 16:06 | |
| *** armax has joined #openstack-nova | 16:06 | |
| mriedem | +2 on https://review.openstack.org/#/c/355805/ now | 16:08 |
| mriedem | needs another core | 16:08 |
| *** rtheis has quit IRC | 16:10 | |
| *** sacharya_ has joined #openstack-nova | 16:11 | |
| *** Zealoussnow_ has quit IRC | 16:13 | |
| *** sacharya has quit IRC | 16:14 | |
| mriedem | dansmith: done on https://review.openstack.org/#/c/409890/ - created a bug for the map_cell0 thing | 16:14 |
| dansmith | mriedem: ack thanks | 16:14 |
| mriedem | dansmith: are you going to make https://review.openstack.org/#/c/416585/ depend on https://review.openstack.org/#/c/418141/ ? | 16:15 |
| mriedem | it seems it has to | 16:15 |
| mriedem | if you're busy i can make that change | 16:15 |
| *** pradk has quit IRC | 16:16 | |
| dansmith | mriedem: no, I was just hoping we'd merge the nova change and then poke sdague | 16:16 |
| dansmith | but I can if you want | 16:16 |
| sdague | what's up? | 16:16 |
| mriedem | i think we should use the depends-on | 16:17 |
| dansmith | okay | 16:17 |
| *** lpetrut has joined #openstack-nova | 16:17 | |
| dansmith | it doesn't get us any testing and probably isn't in danger of merging without us noticing, | 16:17 |
| dansmith | but .. done | 16:17 |
| dansmith | sdague: this is ready and blocked on the nova change that is required for us to merge it: https://review.openstack.org/#/c/416585/ | 16:18 |
| dansmith | it has survived quite a bit of abuse thus far, so pretty confident :) | 16:18 |
| *** rama_y_ has quit IRC | 16:19 | |
| *** rama_y has quit IRC | 16:19 | |
| mriedem | claudiub|2: unless you want to make a case for it, i'm going to defer https://blueprints.launchpad.net/nova/+spec/hyper-v-pci-passthrough to pike | 16:19 |
| sdague | yeh, I had an old +2 on it | 16:19 |
| *** annegentle has joined #openstack-nova | 16:19 | |
| sdague | how soon do we need a merge for it? | 16:19 |
| mriedem | sdague: no rush i don't think | 16:19 |
| mriedem | bauzas: i'm going to move https://blueprints.launchpad.net/nova/+spec/request-spec-use-by-compute to pike | 16:20 |
| sdague | ok, mtreinish is on a plane to .au today, I'll see if other devstack folks pop up on it | 16:20 |
| dansmith | mriedem: it's not like amazingly urgent, | 16:20 |
| dansmith | but it certainly helps me get stuff done before I disappear | 16:20 |
| claudiub|2 | mriedem: thati is what i'm currently testing at the moment. i'm setting up an environment for it, and i'll try to run the intel pci tempest tests | 16:20 |
| mriedem | claudiub|2: ok, i'll hold off then | 16:20 |
| mriedem | dansmith: ok | 16:20 |
| mriedem | i think we could get it in by eod then | 16:20 |
| *** Tryn00 has quit IRC | 16:21 | |
| *** READ10 has joined #openstack-nova | 16:21 | |
| *** manasm has joined #openstack-nova | 16:21 | |
| *** salv-orl_ has joined #openstack-nova | 16:23 | |
| *** cmartin has joined #openstack-nova | 16:24 | |
| *** _ducttape_ has joined #openstack-nova | 16:24 | |
| *** prateek_ has quit IRC | 16:24 | |
| *** prateek has quit IRC | 16:25 | |
| cmartin | Hey could somebody unabandon this patch for me so I can work on it? https://review.openstack.org/#/c/342061/ | 16:25 |
| mriedem | cmartin: done | 16:25 |
| *** salv-orlando has quit IRC | 16:26 | |
| cmartin | mriedem: thanks | 16:26 |
| *** ducttape_ has quit IRC | 16:27 | |
| openstackgerrit | Christopher Martin proposed openstack/nova: Stop using mox in unit/virt/disk/test_api.py https://review.openstack.org/342061 | 16:28 |
| mriedem | sean-k-mooney: fyi that os-vif 1.4.0 breaks the nova unit tests, seen here https://review.openstack.org/#/c/418421/ : http://logs.openstack.org/21/418421/4/check/gate-cross-nova-python27-db-ubuntu-xenial/376a0f3/console.html#_2017-01-11_10_21_37_885392 | 16:30 |
| *** prateek has joined #openstack-nova | 16:30 | |
| *** prateek_ has joined #openstack-nova | 16:30 | |
| mriedem | looks like 'vif_name': u'nicdc065497-3c' is new | 16:31 |
| mriedem | this https://review.openstack.org/#/c/390225/ | 16:32 |
| *** markus_z has quit IRC | 16:33 | |
| *** bkopilov has joined #openstack-nova | 16:33 | |
| *** _ducttape_ has quit IRC | 16:34 | |
| mriedem | hmmm, so the nova unit test is going to need to transform the object to it's known good version, which would be 1.0 | 16:34 |
| *** ducttape_ has joined #openstack-nova | 16:35 | |
| *** links has quit IRC | 16:37 | |
| *** ociuhandu has quit IRC | 16:38 | |
| mnestratov | mriedem: hi | 16:39 |
| mnestratov | mriedem: sorry, just saw your message | 16:39 |
| *** mtanino has joined #openstack-nova | 16:39 | |
| mriedem | np | 16:40 |
| *** tojuvone has quit IRC | 16:40 | |
| *** tojuvone has joined #openstack-nova | 16:41 | |
| mnestratov | mriedem: thanks for fixing the review for us ) | 16:42 |
| *** aslezil_ has quit IRC | 16:43 | |
| *** rama_y_ has joined #openstack-nova | 16:44 | |
| *** rama_y has joined #openstack-nova | 16:44 | |
| *** andreas_s has quit IRC | 16:44 | |
| mdbooth | artom: It occurs to me that we don't call _build_device_metadata often enough | 16:47 |
| mdbooth | We need to call it every time we regenerate libvirt domain xml, because all hw address will change every time we do that | 16:47 |
| *** sneti has joined #openstack-nova | 16:51 | |
| *** bvanhav has quit IRC | 16:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: WIP: Make unit tests work with os-vif 1.4.0 https://review.openstack.org/419558 | 16:52 |
| mriedem | dansmith: jaypipes: i've got a problem with ^ because of http://paste.openstack.org/show/594736/ | 16:52 |
| mriedem | i'm backporting the VIFHostUser object to 1.0 but it's nested 'network' object isn't getting backported recursively | 16:53 |
| mriedem | well, i think it's trying, but there is no rule for it | 16:53 |
| mriedem | i do see this though https://github.com/openstack/os-vif/blob/1.4.0/os_vif/objects/network.py#L51 | 16:54 |
| *** dtp has joined #openstack-nova | 16:54 | |
| *** sneti has quit IRC | 16:54 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 16:55 |
| dtp | dansmith | 16:57 |
| dansmith | dtp | 16:58 |
| dansmith | mriedem: is it calling super in make compatible? | 16:59 |
| mriedem | dansmith: yup | 16:59 |
| dtp | do i understand your comment on https://review.openstack.org/#/c/418141 that instead of relying on the mapping being there, we need to rely instead on cells.enable setting? | 16:59 |
| mriedem | looks like _obj_relationships_for doesn't have a manifest on the thing i'm backporting | 16:59 |
| dansmith | mriedem: does the manifest call for the older version/ | 16:59 |
| *** abalutoiu has quit IRC | 16:59 | |
| mriedem | where does the manifest get set on the object? | 17:00 |
| *** gszasz has quit IRC | 17:00 | |
| mriedem | oh i see it doesn't have a manifest | 17:00 |
| mriedem | so it tries to use the old school self.obj_relationships[field] | 17:00 |
| dansmith | dtp: which comment? | 17:00 |
| mriedem | and we don't have a rule for it | 17:00 |
| dtp | dansmith the commit message at the top | 17:00 |
| dansmith | mriedem: yeah, manifest is just passed into the call, not stored anywhere | 17:00 |
| dansmith | dtp: we need to ignore the fact that the mapping is in place, if we're still on cellsv1, so that we don't bypass the replication and go straight to the cell database, which might have not-yet-replicated stuff in it | 17:01 |
| dtp | ok, thank you | 17:01 |
| mriedem | ok so i need to call obj_make_compatible_from_manifest() instead and provide my own manifest on how to handle this nested field? | 17:02 |
| dansmith | dtp: cells.enable is really cellsv1.enable | 17:02 |
| dtp | yeah i have that burned to my brain roms :D | 17:02 |
| dtp | +1! | 17:02 |
| dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_objects.py#L886-L956 | 17:02 |
| *** manasm has quit IRC | 17:03 | |
| mdbooth | artom: Replied. | 17:03 |
| * mdbooth has to go get his car before the garage shuts. | 17:03 | |
| *** mjura has quit IRC | 17:05 | |
| *** unicell has quit IRC | 17:07 | |
| *** mtani____ has joined #openstack-nova | 17:07 | |
| *** sudswas__ has joined #openstack-nova | 17:07 | |
| *** mtanino has quit IRC | 17:07 | |
| *** sudipto_ has quit IRC | 17:07 | |
| *** xek has quit IRC | 17:07 | |
| *** sudipto has quit IRC | 17:08 | |
| *** xek has joined #openstack-nova | 17:08 | |
| *** sudipto has joined #openstack-nova | 17:08 | |
| edleafe | Can someone explain the failure here: http://logs.openstack.org/51/416751/6/check/gate-nova-tox-db-functional-ubuntu-xenial/fec7ddc/testr_results.html.gz | 17:10 |
| *** bvanhav has joined #openstack-nova | 17:10 | |
| *** medberry has quit IRC | 17:10 | |
| edleafe | It seems all the tests passed, but the returncode was 1 | 17:10 |
| *** sheel has joined #openstack-nova | 17:11 | |
| mriedem | edleafe: this looks odd http://logs.openstack.org/51/416751/6/check/gate-nova-tox-db-functional-ubuntu-xenial/fec7ddc/console.html#_2017-01-12_15_25_20_540113 | 17:11 |
| mriedem | 2017-01-12 15:25:20.506 4337 INFO nova.osapi_compute.wsgi.server [req-471b1e60-9717-479e-a053-06834d8fe63f fake fake - - -] (4337) wsgi exited, is_accepting=True | 17:11 |
| jaypipes | mriedem: lookin... | 17:12 |
| *** aloga has quit IRC | 17:12 | |
| *** aloga has joined #openstack-nova | 17:12 | |
| *** ralonsoh_ has quit IRC | 17:13 | |
| *** browne has joined #openstack-nova | 17:13 | |
| *** raunak has joined #openstack-nova | 17:13 | |
| edleafe | mriedem: odd is a good word | 17:13 |
| *** med_ has joined #openstack-nova | 17:14 | |
| *** med_ is now known as Guest87783 | 17:14 | |
| *** Swami has joined #openstack-nova | 17:14 | |
| *** chyka has joined #openstack-nova | 17:15 | |
| jaypipes | mriedem: ah, yeah... I ran into similar recently when trying to add a UUID field to the NUMACell object. Objects that had their versions changed but never got an obj_make_compatible() method run into this failure. To fix, you need to manually set the obj_relationships class attribute on the object in osvif :( | 17:18 |
| mriedem | what's really crazy, | 17:18 |
| mriedem | when this test was added to nova https://review.openstack.org/#/c/334048/11/nova/tests/unit/network/test_os_vif_util.py@575 | 17:19 |
| jaypipes | mriedem: we aren't yet sending osvif objects over the wire, though, so it may be we could do a hack of the object manifests with dansmith's help? | 17:19 |
| mriedem | it's setting the vif_name which passed even though vif_name wasn't a field on that type in os-vif 1.3.0 which is what we were testing against | 17:19 |
| mriedem | so...i guess when the test converts it to a primitive, | 17:19 |
| mriedem | because vif_name wasn't a 'registered' field it just excluded it? | 17:19 |
| mriedem | so the equality check was ok? | 17:20 |
| mriedem | if that's the case, i'm not sure why vif_name isn't showing up on the actual object when we do the compare with os-vif 1.4.0 http://logs.openstack.org/21/418421/4/check/gate-cross-nova-python27-db-ubuntu-xenial/376a0f3/console.html#_2017-01-11_10_21_37_885392 | 17:20 |
| jaypipes | mriedem: vif_name is a field: https://github.com/openstack/os-vif/blob/master/os_vif/objects/vif.py#L65 | 17:21 |
| mriedem | jaypipes: these have obj_make_compatible methods | 17:21 |
| dansmith | jaypipes: obj_relationships should not be used anymore | 17:21 |
| jaypipes | https://github.com/openstack/os-vif/blob/master/os_vif/objects/vif.py#L77 | 17:21 |
| mriedem | jaypipes: vif_name wasn't a field in VIFHostUser until 1.1 | 17:21 |
| jaypipes | dansmith: yeah, I know, but I found no other way to fix that bug. | 17:22 |
| mriedem | and ^ was just released in os-vif 1.4.0 | 17:22 |
| jaypipes | mriedem: ah.' | 17:22 |
| mriedem | https://review.openstack.org/#/c/390225/7/os_vif/objects/vif.py | 17:22 |
| jaypipes | mriedem: you sure about that? https://github.com/openstack/os-vif/commit/11af752a5af8a58a4f8fd5af196d1fce7729463d | 17:22 |
| jaypipes | mriedem: shows added in 2015. | 17:22 |
| mriedem | jaypipes: on which object? | 17:23 |
| mriedem | we're not dealing with vif generic or bridge, | 17:23 |
| mriedem | it's VIFHostUser | 17:23 |
| mriedem | see https://review.openstack.org/#/c/390225/7/os_vif/objects/vif.py | 17:23 |
| mriedem | that adds the vif_name field to VIFHostUser and bumps it's version to 1.1, and that change is released in os-vif 1.4.0, which is now breaking nova unit tests | 17:24 |
| mriedem | http://logs.openstack.org/21/418421/4/check/gate-cross-nova-python27-db-ubuntu-xenial/376a0f3/console.html#_2017-01-11_10_21_37_885392 | 17:24 |
| mriedem | because vif_name is in our expected object on the nova side, but it's not in the actual obj we're getting from os-vif for some reason | 17:24 |
| jaypipes | mriedem: hmm, yes, you're totally correct. | 17:25 |
| mriedem | even though both primitives are showing | 17:25 |
| mriedem | 'versioned_object.name': 'VIFVHostUser', | 17:25 |
| mriedem | 'versioned_object.version': '1.1'} | 17:25 |
| jaypipes | yup you're right. | 17:25 |
| *** rama_y has quit IRC | 17:26 | |
| *** rama_y_ has quit IRC | 17:26 | |
| jaypipes | mriedem: weird... I wonder how https://github.com/openstack/os-vif/commit/345ff074b5dadc965b2298583124f32fc29dd2e4#diff-a2fd3d05a3b0a72438d0399e19c04469R152 ever worked then? | 17:26 |
| mriedem | well that seems straight forward | 17:27 |
| jaypipes | mriedem: sorry, I mean how the nova side didn't break when that was merged... | 17:28 |
| mriedem | you mean when vif_name didn't exist in VIFHostUser? | 17:28 |
| mriedem | i assume because it's not a registered field so the obj_to_primitive() ignored the field | 17:28 |
| *** mnestratov|2 has joined #openstack-nova | 17:28 | |
| mriedem | so it wasn't in the primitive | 17:28 |
| mriedem | you can set random attributes on versioned objects | 17:28 |
| dansmith | correct | 17:28 |
| mriedem | but the only thing that goes into the primitive is the fields | 17:29 |
| mriedem | which in VIFHostUser 1.0 when that test was written didn't have a vif_name field | 17:29 |
| mriedem | so it wouldn't be in the primitive and the nova test passed | 17:29 |
| jaypipes | that are in the manifest for that version, yes. | 17:29 |
| mriedem | unless i'm mistaken there isn't a manifest used in any of these tests | 17:29 |
| *** moshele has quit IRC | 17:30 | |
| *** mnestratov has quit IRC | 17:31 | |
| mriedem | i think i have an easier fix than what i was trying | 17:33 |
| jaypipes | mriedem: so I'm looking at that output in the console log from the unit test failure. really weird that the actual object has a version of 1.1 but doesn't include the vif_name field... | 17:33 |
| jaypipes | mriedem: I mean, version 1.1 added the vif_name field and nothing else, no? so if it knows of the 1.1 object version, there should be a vif_name field. | 17:34 |
| mriedem | jaypipes: right | 17:34 |
| mriedem | i don't get that at all | 17:34 |
| *** pradk has joined #openstack-nova | 17:34 | |
| *** gouthamr has quit IRC | 17:35 | |
| mriedem | unless it's somehow thinking it needs to backport to 1.0 for some reason | 17:35 |
| mriedem | but i don't see anything telling it to do that | 17:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Make unit tests work with os-vif 1.4.0 https://review.openstack.org/419558 | 17:38 |
| mriedem | so ^ should fix the nova test, but i'm kind of worried about what's actually going on on the os-vif side | 17:39 |
| *** BobBall is now known as BobBall_AWOL | 17:40 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978 | 17:40 |
| jaypipes | mriedem: will try to look into this further in a bit. have meetings currently.. | 17:41 |
| mriedem | ok, i'm going to get some lunch | 17:41 |
| *** tlian has quit IRC | 17:42 | |
| *** tlian has joined #openstack-nova | 17:42 | |
| *** yamahata has quit IRC | 17:43 | |
| *** derekh has quit IRC | 17:43 | |
| *** claudiub has joined #openstack-nova | 17:46 | |
| *** sahid has quit IRC | 17:47 | |
| *** karthiks has quit IRC | 17:48 | |
| *** gouthamr has joined #openstack-nova | 17:49 | |
| *** lucasagomes is now known as lucas-afk | 17:50 | |
| *** claudiub|2 has quit IRC | 17:50 | |
| *** owalsh has quit IRC | 17:51 | |
| armax | mriedem: hi | 17:54 |
| armax | mriedem: do you happen to know if these types of errors are expected? | 17:54 |
| armax | http://logs.openstack.org/08/418108/4/gate/gate-tempest-dsvm-neutron-src-neutron-lib-ubuntu-xenial/dafcfca/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-01-12_16_59_40_818 | 17:54 |
| armax | or maybe jaypipes? | 17:55 |
| dansmith | armax: they are early in the run yeah | 17:56 |
| dansmith | I mean, they shouldn't be making a big fuss like they are, but... | 17:56 |
| armax | dansmith: ok | 17:56 |
| dansmith | armax: but | 17:57 |
| dansmith | armax: a bit down, it says placement isn't responding, which should't be right unless placement isn't configured for this test, just a sec | 17:57 |
| dansmith | armax: ah yeah no placement in that test, which is why you see the warnings | 17:58 |
| *** nic has joined #openstack-nova | 17:58 | |
| mriedem | armax: it's because placement isn't up yet | 17:58 |
| armax | dansmith: I haven’t looked much deeper than this log file | 17:58 |
| mriedem | devstack starts n-cpu before placement | 17:58 |
| *** jose-phillips has joined #openstack-nova | 17:58 | |
| armax | mriedem: I see | 17:58 |
| mriedem | there is placement in this job http://logs.openstack.org/08/418108/4/gate/gate-tempest-dsvm-neutron-src-neutron-lib-ubuntu-xenial/dafcfca/logs/apache/placement-api.txt.gz | 17:58 |
| mriedem | it's on by default in all jobs in master | 17:58 |
| mriedem | it's just the startup order of the services | 17:58 |
| dansmith | oh it's not in a screen, right | 17:58 |
| mriedem | yeah | 17:59 |
| dansmith | didn't see the log, but forgot it was under apache | 17:59 |
| mriedem | armax: what i did notice yesterday was this http://logs.openstack.org/08/418108/4/gate/gate-tempest-dsvm-neutron-src-neutron-lib-ubuntu-xenial/dafcfca/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-01-12_17_05_25_623 | 17:59 |
| mriedem | armax: ^ has started showing up a lot, it's not new either apparently | 17:59 |
| dansmith | mriedem: but there are warnings much later in the run about not being able to contact placement | 17:59 |
| armax | um | 17:59 |
| dansmith | I guess it's only a minute later | 18:00 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22NeutronAdminCredentialConfigurationInvalid%3A%20Networking%20client%20is%20experiencing%20an%20unauthorized%20exception.%5C%22%20AND%20message%3A%5C%22deallocate_for_instance%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22%20AND%20voting%3A1&from=7d | 18:00 |
| mriedem | http://logs.openstack.org/08/418108/4/gate/gate-tempest-dsvm-neutron-src-neutron-lib-ubuntu-xenial/dafcfca/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-01-12_17_05_25_061 | 18:01 |
| openstackgerrit | John Garbutt proposed openstack/nova: Extract preallocate_for_instance https://review.openstack.org/418876 | 18:01 |
| openstackgerrit | John Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance https://review.openstack.org/418513 | 18:01 |
| openstackgerrit | John Garbutt proposed openstack/nova: Stop passing network when you only need dns_domain https://review.openstack.org/419577 | 18:01 |
| mriedem | Neutron client was not able to generate a valid admin token, please verify Neutron admin credential located in nova.conf | 18:02 |
| armax | mriedem: let me look into that | 18:02 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 18:02 |
| mriedem | armax: ok i'll report a bug for it too just to track it | 18:02 |
| armax | mriedem: cool | 18:03 |
| *** prateek_ has quit IRC | 18:05 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1656056 | 18:06 |
| openstack | Launchpad bug 1656056 in OpenStack Compute (nova) "NeutronAdminCredentialConfigurationInvalid all over n-cpu logs in successful gate runs during network teardown" [High,Confirmed] | 18:06 |
| *** lpetrut has quit IRC | 18:06 | |
| *** unicell has joined #openstack-nova | 18:07 | |
| mriedem | armax: https://review.openstack.org/#/q/b8a05333ddc4e248e18080750e3cfa9cbedbca53 ? | 18:08 |
| *** mvk has joined #openstack-nova | 18:09 | |
| *** ociuhandu has joined #openstack-nova | 18:09 | |
| mriedem | nvm that's not released yet | 18:10 |
| *** roeyc has joined #openstack-nova | 18:11 | |
| *** efried has quit IRC | 18:11 | |
| mriedem | could also be this https://review.openstack.org/#/c/407147/ | 18:13 |
| *** rama_y_ has joined #openstack-nova | 18:13 | |
| *** rama_y has joined #openstack-nova | 18:13 | |
| *** weshay is now known as weshay_bbiab | 18:13 | |
| *** efried has joined #openstack-nova | 18:14 | |
| openstackgerrit | Rafael Folco proposed openstack/nova: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 18:14 |
| *** sacharya has joined #openstack-nova | 18:17 | |
| *** sacharya_ has quit IRC | 18:17 | |
| *** slaweq has quit IRC | 18:17 | |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124 | 18:18 |
| openstackgerrit | John Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method. https://review.openstack.org/418881 | 18:18 |
| *** slaweq has joined #openstack-nova | 18:19 | |
| *** yamahata has joined #openstack-nova | 18:22 | |
| *** ijw_ has quit IRC | 18:24 | |
| *** raj_singh_ has quit IRC | 18:26 | |
| *** raj_singh_ has joined #openstack-nova | 18:27 | |
| *** efried has quit IRC | 18:28 | |
| *** bvanhav_ has joined #openstack-nova | 18:30 | |
| *** bvanhav has quit IRC | 18:30 | |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | 18:30 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 18:30 |
| *** liangy has quit IRC | 18:31 | |
| *** openstackgerrit has quit IRC | 18:33 | |
| sean-k-mooney | mriedem: regarding the os-vif 1.4 release are the only failing test in https://review.openstack.org/#/c/385061/7 or are there others | 18:33 |
| mriedem | sean-k-mooney: i'm trying to fix it here https://review.openstack.org/#/c/419558/ | 18:34 |
| sean-k-mooney | if its just effecting https://review.openstack.org/#/c/385061/7 that is because the upperconstraits is not allowing 1.4 to be used | 18:34 |
| mriedem | but that's failing with something different now: http://logs.openstack.org/21/418421/5/check/gate-cross-nova-python27-db-ubuntu-xenial/5b2478f/console.html#_2017-01-12_17_50_19_015480 | 18:34 |
| *** pcaruana has quit IRC | 18:34 | |
| *** lpetrut has joined #openstack-nova | 18:34 | |
| sean-k-mooney | looking at you fix | 18:34 |
| mriedem | sean-k-mooney: there is some earlier scrollback conversation between myself and jaypipes where i don't really understand what's going on in the original failure, i.e. we're getting a 1.1 VIFHostUser object from os-vif but it doesn't have the vif_name field set in the primitive | 18:35 |
| mriedem | which doesn't make any sense to me | 18:36 |
| sean-k-mooney | that is strange. does it only get added if it is used? | 18:36 |
| sean-k-mooney | we are not currently using the vif_name field as we havent gone to 1.4 yet | 18:37 |
| mriedem | sean-k-mooney: ah yeah | 18:37 |
| mriedem | if self.obj_attr_is_set(name): | 18:37 |
| mriedem | primitive[name] = field.to_primitive(self, name, | 18:37 |
| mriedem | getattr(self, name)) | 18:37 |
| *** READ10 has quit IRC | 18:38 | |
| sean-k-mooney | mriedem: the issue is even with the version bump in nova in that change the upperconstrains is downgrading to 1.3.0 | 18:39 |
| sean-k-mooney | http://logs.openstack.org/61/385061/7/check/gate-nova-python27-db-ubuntu-xenial/3f6ab1c/console.html.gz#_2016-12-29_09_57_59_936076 | 18:39 |
| sean-k-mooney | so untill the upper-constraints patch merges the tests wont pass | 18:40 |
| sean-k-mooney | the upper-constratins is downgrading below the minium set in nova's requirements.txt | 18:40 |
| sean-k-mooney | if we merge teh upperconstraints change the test should pass then we can raise the minium in the global requirements | 18:41 |
| mriedem | sean-k-mooney: i really thought the u-c and g-r changes would be in the same patch | 18:41 |
| sean-k-mooney | the were in my patch | 18:41 |
| sean-k-mooney | but i abandoned it becase francesco had one open too | 18:42 |
| sean-k-mooney | his just raised the gloabl requirements patch and there was a seperate patch for upper constraints | 18:42 |
| sean-k-mooney | mriedem: global reques https://review.openstack.org/#/c/415660/ upper constraitns https://review.openstack.org/#/c/418421/ | 18:44 |
| mriedem | yeah i know, which now depends on the nova fix | 18:44 |
| *** efried has joined #openstack-nova | 18:44 | |
| mriedem | which fails http://logs.openstack.org/21/418421/5/check/gate-cross-nova-python27-db-ubuntu-xenial/5b2478f/console.html#_2017-01-12_17_50_19_015480 | 18:44 |
| mriedem | oslo_versionedobjects.exception.ObjectActionError: Object action obj_make_compatible failed because: No rule for port_profile | 18:44 |
| *** sajeesh has joined #openstack-nova | 18:44 | |
| *** efried has quit IRC | 18:45 | |
| mriedem | i'm not sure where ^ is coming from | 18:45 |
| mriedem | i assume it's VIFBase | 18:45 |
| sean-k-mooney | neither am i i dont recall any changes related to the port_profile | 18:46 |
| mriedem | i could just be i need to pass a manifest in for the backport conversion | 18:46 |
| sean-k-mooney | i still think merging https://review.openstack.org/#/c/418421/ would resolve the conflict but ill dig a little deeper | 18:46 |
| dansmith | mriedem: see that test example I pointed you to? | 18:46 |
| mriedem | dansmith: i couldn't really make heads or tails of that | 18:47 |
| dansmith | mriedem: it passes in a manifest of what it wants the system to think the remote looks like | 18:47 |
| mriedem | sean-k-mooney: it's a chicken and egg, we can't merge https://review.openstack.org/#/c/418421/ | 18:47 |
| mriedem | because the nova unit tests are failing in that chnage | 18:47 |
| dansmith | mriedem: in that test it mocks get_versions or whatever, but there are others in there that just pass a manifest with one or two object versions | 18:47 |
| sean-k-mooney | your right hum ok im just trying to figure out what is different between them. | 18:49 |
| sean-k-mooney | ah the 'vif_name': u'nicdc065497-3c' | 18:50 |
| mriedem | sean-k-mooney: yeah :) | 18:50 |
| mriedem | it's in the expected object from the nova test, but not in the actual object from the os-vif side | 18:50 |
| mriedem | which is weird because it's version on the object is 1.1 | 18:50 |
| mriedem | which was the version when vif_name was added to VIFHostUser | 18:51 |
| mriedem | oh but you said, | 18:51 |
| *** lpetrut has quit IRC | 18:51 | |
| sean-k-mooney | the expect result is incorrect as before os-vif 1.4 that field did not exist | 18:51 |
| mriedem | we don't use that yet? | 18:51 |
| mriedem | sean-k-mooney: yeah that's another thing i noted earlier | 18:51 |
| mriedem | and removed in my fix patch, | 18:51 |
| mriedem | but maybe that's just the fix? | 18:51 |
| *** tesseract has quit IRC | 18:51 | |
| mriedem | i'll try that out as i have a recreate locally | 18:52 |
| sean-k-mooney | https://review.openstack.org/#/c/410737/2 is the change that should add the vif_name to the unit test | 18:52 |
| mriedem | farq | 18:52 |
| mriedem | ok, well just removing vif_name makes it work | 18:52 |
| mriedem | so i'll cleanup my patch | 18:52 |
| sean-k-mooney | yes | 18:52 |
| sean-k-mooney | so if you remove it now it can be reintoduce in https://review.openstack.org/#/c/410737/2 when the filed actully exists in the os-vif object | 18:53 |
| sean-k-mooney | this is related to a previous conversation i had with danile berange about the fact that oslo versioned objects allows you to set filds in objecst that are not in the defined set of fields | 18:54 |
| mriedem | yeah...i remember that | 18:56 |
| mriedem | we use it to our advantage at times in nova, | 18:56 |
| mriedem | for fields we want to set in the nova-net layer for example and then those are used in the nova-api layer, but aren't persisted in the nova db | 18:56 |
| mriedem | i think i had mentioned at some point about changing ovo to add a flag to be strict about which attributes can be set | 18:57 |
| *** openstackgerrit has joined #openstack-nova | 18:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Make unit tests work with os-vif 1.4.0 https://review.openstack.org/419558 | 18:57 |
| sean-k-mooney | yes you had. by the way i just book my ptg flights/hotel. one thing i would like to add to os-vif is a dsvm gate to increase the level of testing. | 18:57 |
| *** slaweq has quit IRC | 18:58 | |
| mriedem | want to throw that in https://etherpad.openstack.org/p/nova-ptg-pike ? | 18:58 |
| sean-k-mooney | im not sure it would have caught this but it would be better to have some intergration testing of os-vif | 18:58 |
| *** dtp has quit IRC | 18:58 | |
| sean-k-mooney | am sure. should i add a generic os-vif section or just os-vif gateing | 18:59 |
| sean-k-mooney | there is also the topic of neutron intergration | 18:59 |
| sean-k-mooney | i would like to complete that in pike also | 18:59 |
| *** ijw has joined #openstack-nova | 18:59 | |
| *** ijw has quit IRC | 19:00 | |
| mriedem | sean-k-mooney: i think there is a job in the nova experimental queue that already does that | 19:00 |
| *** ijw has joined #openstack-nova | 19:00 | |
| mriedem | sean-k-mooney: https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L12513 | 19:00 |
| sean-k-mooney | mriedem: perhaps. i would like to add a job to os-vif though that tested with the head of nova/neutron master too with the os-vif change | 19:01 |
| mriedem | i think that's what that job does | 19:01 |
| *** lpetrut has joined #openstack-nova | 19:01 | |
| mriedem | https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L462 | 19:02 |
| mriedem | export PROJECTS="openstack/os-vif $PROJECTS" export DEVSTACK_LOCAL_CONFIG+=$'\n'"LIBS_FROM_GIT=os-vif" | 19:02 |
| sean-k-mooney | yes but that only runs on chnage to nova | 19:02 |
| *** dharinic is now known as dharinic|lunch | 19:02 | |
| mriedem | sean-k-mooney: you just have to add that job to the os-vif template in layouts.yaml then | 19:02 |
| sean-k-mooney | i would like to basically add that jobe to the check pipeline for os-vif | 19:02 |
| mriedem | if you want to run that job on os-vif | 19:02 |
| mriedem | then make it so :) | 19:02 |
| sean-k-mooney | yep | 19:02 |
| mriedem | honestly i don't know why danpb didn't do that originally | 19:02 |
| mriedem | you can cancel your PTG flight and hotel now, problem solved :) | 19:03 |
| sean-k-mooney | ok i will, should i add it to check experimental first to make sure it works. | 19:03 |
| mriedem | in os-vif? that's probably not a bad idea | 19:03 |
| sean-k-mooney | mriedem: i have some other things to adress too :) but that is one less item | 19:03 |
| mriedem | goes in here somewhere https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L13748 | 19:04 |
| sean-k-mooney | mriedem: ok ill submit a patch to add it to check experimental and then do some testing. if it works ill move it to the main check pipeline for os-vif | 19:04 |
| mriedem | cool | 19:04 |
| *** sudipto has quit IRC | 19:05 | |
| *** sudswas__ has quit IRC | 19:05 | |
| *** ociuhandu has quit IRC | 19:05 | |
| mriedem | jroll: i just remembered https://review.openstack.org/#/c/247904/ | 19:06 |
| mriedem | you might want to get that in before you request an ironicclient release, or just know you'll have to do two | 19:06 |
| jroll | mriedem: yep, it's on my list | 19:07 |
| mriedem | sean-k-mooney: http://logs.openstack.org/21/418421/5/check/gate-cross-nova-python27-db-ubuntu-xenial/a12bd2b/ is happy now | 19:07 |
| mriedem | so u-c should be good soon | 19:08 |
| sean-k-mooney | cool glad the solution was found before any of the requirements go bumped. | 19:08 |
| mriedem | melwitt: i'm +2 on dan's bottom change now for cells v1 glory https://review.openstack.org/#/c/418141/ | 19:11 |
| EmilienM | dansmith, mriedem: I have a good news | 19:12 |
| mriedem | there is a nit in one of the code comments that could be addressed on top of that change | 19:12 |
| EmilienM | the patch in nova that fixed the placement retry thing, works very well | 19:12 |
| mriedem | 0 days without a TripleO incident?! | 19:12 |
| EmilienM | you can see it in the logs | 19:12 |
| EmilienM | first it fails http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/nova/nova-compute.txt.gz#_2017-01-12_18_54_42_715 | 19:12 |
| EmilienM | then it works http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/nova/nova-compute.txt.gz#_2017-01-12_18_55_46_155 | 19:12 |
| EmilienM | (thx again) | 19:12 |
| mriedem | cool | 19:13 |
| mriedem | on a side note, http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/nova/nova-compute.txt.gz#_2017-01-12_18_53_43_459 | 19:13 |
| EmilienM | mriedem: mhh, is it placement endpoint not reachable from creds in [placement] ? | 19:15 |
| EmilienM | oh no I know | 19:15 |
| EmilienM | let me confirm, a sec | 19:15 |
| mriedem | my guess is bad auth_plugin? | 19:16 |
| mriedem | placement.auth_type = password | 19:16 |
| mriedem | i guess i don't know | 19:16 |
| EmilienM | mriedem: http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/puppet-20170112_185646.txt.gz#_2017-01-12_18_55_40 | 19:16 |
| EmilienM | the keystone stuff were created *after* starting nova compute | 19:16 |
| EmilienM | but thanks to the retry, we don't care | 19:17 |
| EmilienM | because it retries and works a few min later | 19:17 |
| mriedem | yeah we just don't want the stacktrace | 19:17 |
| mriedem | anyway it's a low-priority bug for nova to handle that https://bugs.launchpad.net/nova/+bug/1656075 | 19:17 |
| openstack | Launchpad bug 1656075 in OpenStack Compute (nova) "DiscoveryFailure when trying to get resource providers from the scheduler report client" [Low,Confirmed] | 19:17 |
| EmilienM | mriedem: "Created resource provider record via placement API for resource provider with UUID 5c4bb2d9-60bd-46e3-bb2a-eb6730932c63 and name centos-7-osic-cloud1-s3500-6631948." | 19:17 |
| * jaypipes reading back... | 19:17 | |
| EmilienM | mriedem: I think this ^ means keystone auth worked at some point | 19:18 |
| mriedem | EmilienM: yes it did | 19:18 |
| EmilienM | cool | 19:18 |
| mriedem | we handle some known KSA failures when trying to make a connection to the placement endpoint, | 19:18 |
| *** efried has joined #openstack-nova | 19:18 | |
| mriedem | but there are many ways KSA can fail and we don't handle them all apparently | 19:18 |
| mriedem | jaypipes: dansmith: https://review.openstack.org/#/c/419558/ is good to go | 19:19 |
| mriedem | the upper-constraints job passed on that http://logs.openstack.org/21/418421/5/check/gate-cross-nova-python27-db-ubuntu-xenial/a12bd2b/ | 19:19 |
| *** rama_y has quit IRC | 19:19 | |
| *** rama_y_ has quit IRC | 19:19 | |
| *** sajeesh has quit IRC | 19:20 | |
| dansmith | nice | 19:20 |
| mriedem | sdague: you said mtreinish is en route to AU? | 19:21 |
| mriedem | sdague: because we're good with https://review.openstack.org/#/c/416585/ now | 19:21 |
| sdague | mriedem: yeh | 19:21 |
| mriedem | time to rassle up some other devstack cores | 19:21 |
| jaypipes | mriedem: wallaby'd. amazing how simple a fix was in the end.. | 19:22 |
| mriedem | jaypipes: yeah, plus stepping away for lunch helped | 19:22 |
| sdague | mriedem: honestly, it's a really small straight forward change. I'll just approve | 19:22 |
| mriedem | sc68cal: you know you're my favorite person in the world right? https://review.openstack.org/#/c/416585/ | 19:22 |
| jaypipes | mriedem: was it really just a matter of the expected and actual being reversed in the console.log test output and that confusing us? | 19:22 |
| mriedem | jaypipes: no that wasn't it | 19:22 |
| dansmith | sdague: plus it's me, so it's obviously bug-free | 19:23 |
| mriedem | jaypipes: it was in the expected because the nova test put it in there explicitly | 19:23 |
| jaypipes | hehe | 19:23 |
| mriedem | jaypipes: it was'nt in the actual because the field wasn't set on the actual object | 19:23 |
| jaypipes | mriedem: gotcha. | 19:23 |
| mriedem | so it was omitted from the actual primitive | 19:23 |
| mriedem | and kablammo | 19:23 |
| jaypipes | mriedem: strange about the version being 1.1 in both actual and expected, though, no? | 19:23 |
| mriedem | jaypipes: in this case it was using the latest object so i think 1.1 is expected, | 19:24 |
| jaypipes | or do I just need to re-caffeinate? | 19:24 |
| mriedem | jaypipes: no it was this https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L554 | 19:24 |
| mriedem | nothing in nova was setting that field yet | 19:24 |
| mriedem | so ovo didn't include it in the actual primitive | 19:25 |
| *** weshay_bbiab is now known as weshay | 19:25 | |
| mriedem | sdague: if you're feeling saucy you could hit the dependent nova change too https://review.openstack.org/#/c/418141/ | 19:25 |
| * dansmith steps back so as not to get splashed on | 19:27 | |
| jaypipes | saucy. | 19:27 |
| * jaypipes goes back to rebasing yet another resource providers patch | 19:27 | |
| sean-k-mooney | jaypipes: it was a sutble bug but mriedem fix resolves it. the nova tests should not have been setting the vif_name when it was not a field in the ovo | 19:28 |
| *** nicolasbock has quit IRC | 19:28 | |
| sean-k-mooney | jaypipes: mriedem i just opend the reviews for adding gate-tempest-dsvm-nova-os-vif-ubuntu-xenial-nv to the experimental and then check pipelines for os-vif | 19:29 |
| sean-k-mooney | jaypipes: mriedem https://review.openstack.org/419618 and https://review.openstack.org/419619 | 19:30 |
| sean-k-mooney | ill set the workflow to - one on moveing it to check untill i have tested it. | 19:30 |
| *** nicolasbock has joined #openstack-nova | 19:31 | |
| *** tbachman has quit IRC | 19:34 | |
| *** roeyc has quit IRC | 19:35 | |
| bauzas | jaypipes: given https://review.openstack.org/#/c/392569/25..26/nova/api/openstack/placement/handlers/resource_provider.py maybe you could just +2/+W ? | 19:36 |
| *** tbachman has joined #openstack-nova | 19:37 | |
| *** satyar has quit IRC | 19:37 | |
| *** rama_y has joined #openstack-nova | 19:38 | |
| *** rama_y_ has joined #openstack-nova | 19:38 | |
| *** migi has quit IRC | 19:39 | |
| mriedem | bauzas: i'm going to get that one this afternoon | 19:39 |
| mriedem | sorry it's taking awhile, i keep getting distracted | 19:40 |
| bauzas | mriedem: <3 | 19:40 |
| *** lucas-afk has quit IRC | 19:41 | |
| sdague | mriedem: done | 19:42 |
| *** lucasagomes has joined #openstack-nova | 19:44 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509 | 19:45 |
| mriedem | sdague: thanks | 19:45 |
| *** dtp has joined #openstack-nova | 19:51 | |
| *** dharinic|lunch is now known as dharinic | 19:54 | |
| *** salv-orl_ has quit IRC | 19:54 | |
| jaypipes | bauzas: I told mriedem yesterday I didn't feel comfortable +2/W'ing that one because I co-authored it... | 19:56 |
| jaypipes | bauzas: was hoping either mriedem or dansmith might have a chance to review it. | 19:56 |
| bauzas | ack | 19:56 |
| bauzas | no worries | 19:56 |
| *** liangy has joined #openstack-nova | 20:01 | |
| *** artom has quit IRC | 20:01 | |
| *** artom has joined #openstack-nova | 20:01 | |
| *** salv-orlando has joined #openstack-nova | 20:01 | |
| *** liangy has quit IRC | 20:01 | |
| *** raj_singh_ has quit IRC | 20:02 | |
| *** raj_singh has left #openstack-nova | 20:03 | |
| *** raj_singh has joined #openstack-nova | 20:03 | |
| *** kaisers_ has quit IRC | 20:05 | |
| mriedem | i've got a fresh cup of coffee | 20:05 |
| mriedem | so it's time | 20:05 |
| -openstackstatus- NOTICE: Gerrit will be offline between now and 20:30 for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html | 20:08 | |
| *** ChanServ changes topic to "Gerrit will be offline between now and 20:30 for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html" | 20:08 | |
| mriedem | ha saved by the project rename bell | 20:10 |
| *** tjones has joined #openstack-nova | 20:12 | |
| *** slaweq has joined #openstack-nova | 20:12 | |
| openstackgerrit | Mario Villaplana proposed openstack/nova: Add ironic security group support to support matrix doc https://review.openstack.org/419634 | 20:13 |
| melwitt | dansmith: thanks for reviewing the quota objects migration. I hadn't seen an online migration done in a transaction before. how is it done? by passing a session to the methods? | 20:15 |
| *** Sukhdev has joined #openstack-nova | 20:18 | |
| *** abalutoiu has joined #openstack-nova | 20:19 | |
| mriedem | melwitt: i believe he's en route | 20:25 |
| mriedem | to the great white north | 20:25 |
| mriedem | melwitt: can't that be done by using the @db_api.pick_context_manager_writer decorator? | 20:27 |
| melwitt | mriedem: oh, thanks. I didn't know he left already | 20:27 |
| melwitt | mriedem: I think so, if all the calls stay under one decorator. I have a loop that calls a method that is already decorated, so I guess if I break that out into a separate undecorated function, I could decorate the loop one and a non-loop one separately | 20:30 |
| cfriesen | I'm in the great white north, it's -18F right now. Looking forward to Atlanta. | 20:30 |
| melwitt | yikes -18F | 20:32 |
| sean-k-mooney | melwitt: you can have multple decorators on the same fuction/class | 20:32 |
| sean-k-mooney | melwitt: unless you ment it is allready decoated with @db_api.pick_context_manager_writer | 20:33 |
| -openstackstatus- NOTICE: Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated): http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html | 20:33 | |
| *** ChanServ changes topic to "Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated): http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html" | 20:33 | |
| *** kaisers_ has joined #openstack-nova | 20:34 | |
| melwitt | sean-k-mooney: yeah, I mean the "create in db" method is already decorated with @db_api.pick_context_manager_writer and there's a loop doing several "create in db". so to do all of them in one transaction, I thought I have to move the decorator, or can they be nested? I hadn't seen nesting before | 20:36 |
| sean-k-mooney | i dont know. if the decorate is opening the transation then it will do so when you enter the fucntion so all the actions in the loop should be in one transation | 20:38 |
| sean-k-mooney | that said i have not read the code you are refering too | 20:38 |
| sean-k-mooney | and gerrit is currently down so that is just a guess | 20:38 |
| melwitt | sean-k-mooney: yeah, that's my understanding. I was thinking I can't just slap another decorator on the outside of the loop when there's one already on the method I'm calling (so that they nest). I'm not sure though | 20:40 |
| sean-k-mooney | ah ok can you apply decoratos to loops directly? i have never tried that before | 20:41 |
| melwitt | so I was thinking I would have to create a small wrapper function with the decorator for when I want to call it non-loop and move the decorator there | 20:41 |
| melwitt | no, sorry, I meant apply the decorator to the outer function. the one that is doing a loop | 20:42 |
| mriedem | melwitt: i'd ask rpodolyaka | 20:42 |
| sean-k-mooney | ah ok. ya without seeing the code or trying it im not sure either | 20:43 |
| mriedem | i see some stuff in the transaction factory code that looks like it can pull an existing session from the context | 20:43 |
| *** bvanhav_ has quit IRC | 20:44 | |
| melwitt | this is what it looks like, snippet http://paste.openstack.org/show/594765/ | 20:44 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Add service_token for nova-neutron interaction https://review.openstack.org/410394 | 20:45 |
| melwitt | I haven't seen any nesting in db/sqlalchemy/api before, so I thought it wasn't a thing | 20:45 |
| rpodolyaka | melwitt: they can be nested - the inner calls will participate in the ongoing transaction | 20:46 |
| melwitt | rpodolyaka: ah, thank you. that makes it easy then | 20:46 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: DNM: Test service token https://review.openstack.org/413232 | 20:46 |
| rpodolyaka | melwitt: they only thing you can't do is to go from async to writer, writer -> writer is fine | 20:47 |
| rpodolyaka | np! | 20:47 |
| rpodolyaka | *the | 20:47 |
| mriedem | https://github.com/openstack/oslo.db/blob/4.15.0/oslo_db/sqlalchemy/enginefacade.py#L556 | 20:47 |
| melwitt | gotcha, learned something new | 20:48 |
| sean-k-mooney | ok cool so each of the _create_limit_in_db will inherit the transaction from migrate_quota_limits_to_api_db and unless they all complete succefully they will all be rolled back | 20:49 |
| melwitt | yeah, that was the suggestion in the review | 20:51 |
| rpodolyaka | ah, there is one catch, though | 20:51 |
| sean-k-mooney | well the outer trasaction will not be commited unless all the inner creates that inherit it complete sucessfully rather then rolling back if it fails | 20:51 |
| sean-k-mooney | rpodolyaka: :) and that is? | 20:51 |
| rpodolyaka | when is raised db_exc.DBDuplicateEntry the transaction must be rolled back | 20:51 |
| mriedem | gerrit is back btw | 20:52 |
| rpodolyaka | so I guess what you want in http://paste.openstack.org/show/594765/ is SAVEPOINT's | 20:52 |
| rpodolyaka | or independent transactions | 20:52 |
| sean-k-mooney | ok so in migrate_quota_limits_to_api_db you need to catch db_exc.DBDuplicateEntry and roleback? | 20:53 |
| melwitt | here's the actual review now that gerrit is back https://review.openstack.org/#/c/410946/6/nova/objects/quotas.py@463 | 20:53 |
| *** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Ocata_Release_Schedule" | 20:53 | |
| rpodolyaka | sean-k-mooney: you can, but you'd effectively roll back limits saved for previous iterations of the loop | 20:54 |
| rpodolyaka | you could use the savepoint() modifier -https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/enginefacade.py#L860 | 20:56 |
| rpodolyaka | to create a SAVEPOINT for each iteration of the loop | 20:56 |
| rpodolyaka | so that ROLLBACK happens only for the one that caused DuplicateError | 20:56 |
| melwitt | oh, cool | 20:57 |
| sean-k-mooney | is that the intended behavior or if you have a duplicatate shoudl they all be roled back? | 20:59 |
| sean-k-mooney | e.g. is a partal migration with removal of duplicate the desired outcome | 20:59 |
| melwitt | duplicate should just be passed over/ignored | 21:01 |
| *** jwcroppe has quit IRC | 21:01 | |
| *** david-lyle has quit IRC | 21:01 | |
| sean-k-mooney | ok cool just checking :) | 21:01 |
| melwitt | ignored for writing to the api db, and should be deleted from the main db if present | 21:01 |
| *** david-lyle has joined #openstack-nova | 21:02 | |
| *** prateek has quit IRC | 21:04 | |
| *** browne has quit IRC | 21:05 | |
| dansmith | melwitt: what mriedem said yeah | 21:14 |
| *** eharney has quit IRC | 21:15 | |
| dansmith | melwitt: just a method that is "take this list of stuff and jam it into place" that is wrapped in one decorator will ensure that they all get applied or none do | 21:15 |
| ildikov | mriedem: hi | 21:15 |
| *** tbachman has quit IRC | 21:16 | |
| ildikov | mriedem: I'm trying to test the new Cinder API with Nova and experiencing odd things, which might be because of API microversioning in Cinder in the sense of something might be missing on the Nova side | 21:16 |
| *** openstackgerrit has quit IRC | 21:18 | |
| ildikov | mriedem: I'm less familiar with how microversioning works between OpenStack services. Is there anything I should theoretically set up in Nova to have the calls towards the latest Cinder API microversion work? | 21:18 |
| mriedem | bauzas: cdent: jaypipes: edleafe: posted some comments in the resource providers handler code for https://review.openstack.org/#/c/392569/ | 21:18 |
| mriedem | the -1 is really about the fact that i think we're making a backward incompatible change | 21:19 |
| *** adisky_ has quit IRC | 21:19 | |
| *** avolkov has quit IRC | 21:19 | |
| mriedem | ildikov: i'd expect cinderclient to be passing any microversion header to cinder api when using the v3 client | 21:19 |
| melwitt | rpodolyaka: do I need savepoint considering DBDuplicateEntry is caught and ignored in the loop? or does it still cause some sort of rollback to happen? | 21:20 |
| ildikov | mriedem: the same call succeeds if I call it from the Cinderclient and fails if I call it from Nova | 21:20 |
| *** ducttape_ has quit IRC | 21:20 | |
| mriedem | ildikov: do you have the cinderclient call output with --debug? | 21:21 |
| *** ducttape_ has joined #openstack-nova | 21:21 | |
| mriedem | to see the headers? | 21:21 |
| rpodolyaka | melwitt: it still does - the fact that it was raised in the first place means that a DB query failed with an integrity error - you need to rollback a transaction at this point | 21:21 |
| melwitt | rpodolyaka: oh, I see. thanks | 21:22 |
| rpodolyaka | the only way to avoid that is to create a SAVEPOINT before the potential fail | 21:22 |
| ildikov | mriedem: I have now :) | 21:23 |
| bauzas | mriedem: you mean https://review.openstack.org/#/c/392569/26/nova/api/openstack/placement/handlers/resource_provider.py@a170 ? | 21:24 |
| mriedem | bauzas: yup | 21:24 |
| *** dimtruck is now known as zz_dimtruck | 21:24 | |
| bauzas | mriedem: accepted | 21:25 |
| ildikov | mriedem: that contains the API microversion | 21:25 |
| dansmith | rpodolyaka: but we want it to roll back all the way in this case | 21:25 |
| mriedem | ildikov: can you put it into a paste? | 21:25 |
| dansmith | rpodolyaka: so no savepoint, as you said | 21:25 |
| *** hamzy has quit IRC | 21:25 | |
| melwitt | dansmith: I thought we just wanted to skip duplicates? and commit all the non-duplicates in one transaction | 21:25 |
| bauzas | mriedem: so, about the member_of query | 21:26 |
| dansmith | melwitt: sure, but if something else happens you want to unwind all of them | 21:26 |
| melwitt | oh | 21:26 |
| bauzas | mriedem: we first added the member_of field in allowed_filters without microversing it | 21:26 |
| *** smatzek has quit IRC | 21:27 | |
| dansmith | melwitt: otherwise you've got some moved and not others, which will make the code start to look at just the subset, instead of going back to the main db while you figure out what to do | 21:27 |
| ildikov | mriedem: here it is: http://paste.openstack.org/show/594772/ | 21:27 |
| bauzas | mriedem: so, before that, we were not accepting member_of and then we accepted it | 21:27 |
| *** browne has joined #openstack-nova | 21:27 | |
| melwitt | dansmith: yeah, I guess I'm confused about what happens then if we don't use a savepoint and get a duplicate, that it would rollback the entire transaction? | 21:27 |
| *** openstackgerrit has joined #openstack-nova | 21:27 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 21:27 |
| bauzas | mriedem: for both 1.0 and 1.1 | 21:27 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 21:28 |
| dansmith | melwitt: you're ignoring duplicates, right? | 21:28 |
| melwitt | dansmith: yeah, but rpodolyaka said it would still roll back everything? | 21:28 |
| bauzas | mriedem: and then, cdent added the v1.3 microversion for still accepting member_of even if that was not this version | 21:28 |
| *** ducttape_ has quit IRC | 21:28 | |
| dansmith | melwitt: no, he said it would roll back everything if you allow an exception to be raised, | 21:28 |
| bauzas | which is IMO terrible but okay | 21:28 |
| dansmith | which is what we want for everything other than dupes, which you catch and swallow | 21:28 |
| cdent | we discussed it at length and decide that it impacted approximately zero real people | 21:29 |
| *** ducttape_ has joined #openstack-nova | 21:29 | |
| rpodolyaka | dansmith: the problem is that you can't have one transcation and swallow duplicate errors | 21:29 |
| melwitt | dansmith: yeah, I actually asked if I still need savepoint considering I'm catching and ignoring DBDuplicateEntry and the answer was yes. maybe there's a misunderstanding | 21:29 |
| ildikov | mriedem: this is the n-api log for the same attachment-create call: http://paste.openstack.org/show/594773/ | 21:29 |
| rpodolyaka | unless you use savepoints | 21:29 |
| rpodolyaka | but the rollback in the outer transcation will still rollback everything | 21:29 |
| bauzas | cdent: mriedem: anyway, I'll -W it and work tomorow morning my time for a next PS | 21:30 |
| dansmith | rpodolyaka: I don't know why that is | 21:30 |
| *** jose-phillips has quit IRC | 21:30 | |
| mriedem | bauzas: yeah so up until 1.4 we always accepted member_of, | 21:30 |
| mriedem | but if < 1.3 we don't filter on member_of | 21:30 |
| smcginnis | ildikov: I don't see "Openstack-Api-Version: volume 3.24" in there. | 21:31 |
| bauzas | mriedem: not really but yeah | 21:31 |
| mriedem | but it's not an error to put it in the query string, because of the aforementioned missing of the versioning | 21:31 |
| bauzas | mriedem: for example, Newton is not accepting it for 1.0 | 21:31 |
| bauzas | AFAIK | 21:31 |
| ildikov | smcginnis: me neither, but I also don't know what should put it there :) | 21:31 |
| rpodolyaka | dansmith: lemme give it a try on a small snippet | 21:31 |
| smcginnis | ildikov: :) | 21:31 |
| mriedem | bauzas: oh because member_of wasn't in allowed_filters until ocata | 21:31 |
| bauzas | zactly | 21:32 |
| bauzas | just verifying it | 21:32 |
| bauzas | for stable/newton | 21:32 |
| mriedem | https://github.com/openstack/nova/blob/stable/newton/nova/objects/resource_provider.py#L413 | 21:32 |
| jaypipes | mriedem: responded to your review comments on the patch. | 21:32 |
| bauzas | mriedem: yup that | 21:32 |
| *** rama_y_ has quit IRC | 21:32 | |
| *** rama_y has quit IRC | 21:32 | |
| *** jose-phillips has joined #openstack-nova | 21:33 | |
| bauzas | jaypipes: lemme work on a next patchset tomorrow | 21:33 |
| dansmith | rpodolyaka: my understanding is that an insert will still fail with DBDuplicate when you do it, and the thing that does the abort/commit of the transaction is the top-level facade decorator, | 21:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 21:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: explicitly pass compute node to _update() https://review.openstack.org/398472 | 21:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | 21:33 |
| bauzas | jaypipes: given it's the end of your afternoon :) | 21:33 |
| jaypipes | bauzas: no problemo. I'm flying all day :) | 21:33 |
| dansmith | rpodolyaka: so if you appear to exit your function cleanly, it will commit and you save anything you successfully inserted, unless you hit *another* dupe because you raced with another transaction | 21:33 |
| bauzas | jaypipes: heh, seems terrible :) | 21:33 |
| bauzas | mriedem: so, confirmed, stable/newton is not accepting member_of https://github.com/openstack/nova/blob/stable/newton/nova/api/openstack/placement/handlers/resource_provider.py#L187 | 21:34 |
| *** Jeffrey4l has quit IRC | 21:34 | |
| rpodolyaka | dansmith: the problem is that it's the very same transaction - once you have an integrity error you must roll it back at this point | 21:34 |
| bauzas | cdent: ^ see that | 21:34 |
| mriedem | yeah ok... | 21:34 |
| *** JoseMello has quit IRC | 21:35 | |
| dansmith | rpodolyaka: why must you roll back? | 21:35 |
| cdent | bauzas: what are you trying to tell me? | 21:35 |
| mriedem | so it might be fine to bend the rules and make the schema validation strict again | 21:35 |
| bauzas | cdent: I think that if we silently accept member_of, it's not zero folks impacted | 21:35 |
| mriedem | i.e. we didn't allow it, then we allowed it for a short window, then we didn't again | 21:35 |
| mriedem | and the only user is internal to nova right now | 21:35 |
| mriedem | excluding whatever mlavalle is doing | 21:35 |
| dansmith | rpodolyaka: we did another migration like this that I think we've since purged, so if this doesn't work then that didn't either | 21:35 |
| rpodolyaka | dansmith: mysql will tell you the transaction is invalid and must be rolled back. just like with any other error in a transaction | 21:35 |
| rpodolyaka | you sure that were not independent transactions? | 21:36 |
| bauzas | mriedem: either way, you have lots of other comments, will respond to those | 21:36 |
| dansmith | rpodolyaka: yeah | 21:36 |
| rpodolyaka | hmm | 21:36 |
| dansmith | rpodolyaka: well, I don't know anything about mysql making you do that, but surely willing to believe you know more than me | 21:36 |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Refactor _post_live_migratiion https://review.openstack.org/413021 | 21:37 |
| bauzas | anyway, calling it a end of day | 21:37 |
| rpodolyaka | dansmith: heh, I'm a bit sleepy, so maybe I'm missing something obvious :P | 21:37 |
| dansmith | rpodolyaka: not sure we were filtering for dupes before, which I guess is the wrinkle | 21:37 |
| dansmith | melwitt: either way, if rpodolyaka is right, a save point before each insert and a revert in a generic handler is not hard right? | 21:37 |
| melwitt | yeah, I couldn't find a current migration that does a loop in one transaction, to use as an example | 21:38 |
| dansmith | melwitt: also, do you need the dupe handling if you apply them in a transaction? | 21:38 |
| mriedem | jaypipes: what do you mean this is unreadable?! (?:[A-Z0-9_]+\:[0-9]+),? | 21:38 |
| melwitt | dansmith: hm, I dunno. maybe not | 21:39 |
| *** zz_dimtruck is now known as dimtruck | 21:39 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Add service_token for nova-glance interaction https://review.openstack.org/419662 | 21:40 |
| mlavalle | mriedem, bauzas: I am not using any filters with resource providers in my core. Feel free to go ahead | 21:42 |
| mlavalle | code^^^ | 21:42 |
| mriedem | bauzas: jaypipes: ok i replied to the replies. :) i still think that we can enforce the format of the uuid parameter to be a uuid, as it's not being used with in: | 21:47 |
| mriedem | "in:" is only used with member_of | 21:47 |
| *** sheel has quit IRC | 21:47 | |
| mriedem | https://review.openstack.org/#/c/392569/26/nova/api/openstack/placement/handlers/resource_provider.py@289 | 21:48 |
| *** eharney has joined #openstack-nova | 21:48 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: DNM: Test service token in Glance https://review.openstack.org/419666 | 21:48 |
| mriedem | ildikov: ok so "-H "OpenStack-API-Version: volume 3.24"" | 21:49 |
| dansmith | rpodolyaka: okay, I found some references to what you're describing | 21:49 |
| rpodolyaka | dansmith: shit, it works on mysql - but fails on postgresql without savepoints... http://paste.openstack.org/show/594775/ | 21:49 |
| dansmith | hah | 21:49 |
| dansmith | rpodolyaka: seems like enginefacade could manage this for us.. automatically doing savepoints or something, if we nest calls | 21:50 |
| mriedem | ildikov: yeah so the "OpenStack-API-Version" header isn't in the paste from the nova-api call | 21:50 |
| dansmith | rpodolyaka: but regardless, gotta handle it for now I guess | 21:50 |
| mriedem | ildikov: but i don't think nova is supposed to be picking the microversion is it, cinderclient is, at least by default it would be 3.0 | 21:50 |
| mriedem | ildikov: is there a difference in how cinderclient's shell creates the client object and makes requests for v3 vs how nova is doing it? | 21:51 |
| *** lpetrut has quit IRC | 21:51 | |
| mriedem | smcginnis: cinder is up to microversion 3.24 already? | 21:51 |
| smcginnis | mriedem: Sounds right. | 21:51 |
| rpodolyaka | dansmith: yeah, it's just that we do not create a SAVEPOINT for each nested call - so we've got a modifier - https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/enginefacade.py#L860 | 21:51 |
| rpodolyaka | which should be used in such cases | 21:51 |
| mriedem | smcginnis: where do you guys document your REST API version history? | 21:51 |
| mriedem | not finding it here http://docs.openstack.org/developer/cinder/ | 21:52 |
| rpodolyaka | although, we don't probably use it anywhere in nova | 21:52 |
| smcginnis | Document? | 21:52 |
| ildikov | mriedem: that's an amazing question, I have no clue :) | 21:52 |
| smcginnis | mriedem: Kidding. One moment. | 21:52 |
| mriedem | smcginnis: i guess here http://docs.openstack.org/developer/cinder/devref/api_microversion_history.html | 21:52 |
| smcginnis | mriedem: Beat me to it. | 21:52 |
| ildikov | mriedem: it's 3.23, I test jgriffith's new attach API patch, which adds the 3.24 | 21:52 |
| jgriffith | 3.24 | 21:53 |
| jgriffith | as of an hour ago | 21:53 |
| melwitt | rpodolyaka: there are use of the savepoint modifier in nova/db/sqlalchemy/api for several things that catch/expect DBDuplicateEntry | 21:53 |
| mriedem | ildikov: so my guess is, | 21:53 |
| rpodolyaka | melwitt: ah, then I missed those | 21:53 |
| mriedem | the cinderclient shell code does some version discovery with the cinder api and gets the latest available microversion from the server and negotiates that with what the client understands, | 21:53 |
| mriedem | that's how novaclient works | 21:54 |
| dansmith | rpodolyaka: cool, thanks | 21:54 |
| mriedem | and right now the max version in cinderclient is 3.15 i guess? https://github.com/openstack/python-cinderclient/blob/master/cinderclient/api_versions.py#L32 | 21:54 |
| rpodolyaka | np! | 21:54 |
| ildikov | mriedem: that sounds reasonable | 21:54 |
| mriedem | not sure how that works if you're getting it to use 3.24 | 21:54 |
| *** cleong has quit IRC | 21:55 | |
| ildikov | mriedem: I'm setting OS_VOLUME_API_VERSION=3.24 | 21:55 |
| * dansmith notes not to argue with rpodolyaka | 21:55 | |
| ildikov | mriedem: that's the only magic on the Cinder side to make it work | 21:56 |
| *** yamahata has quit IRC | 21:56 | |
| rpodolyaka | dansmith: lol :) | 21:56 |
| *** yamahata has joined #openstack-nova | 21:56 | |
| mriedem | wtf where is cinderclient.API_MIN_VERSION set? | 21:57 |
| *** thorst_ has quit IRC | 21:57 | |
| mriedem | and cinderclient.API_MAX_VERSION | 21:58 |
| *** stewie925 has joined #openstack-nova | 21:58 | |
| ildikov | mriedem: you're checking the cinderclient code now? | 21:59 |
| stewie925 | hello guys | 21:59 |
| mriedem | ildikov: yes | 22:00 |
| ildikov | mriedem: ok, I've just started with that, maybe scottda can help us | 22:00 |
| stewie925 | I'm setting up openstack (controller, compute) and I am following the setup steps to set up the nova compute component on the controller node. | 22:01 |
| *** amotoki has joined #openstack-nova | 22:01 | |
| stewie925 | so far so good... but when the step calls for 'service nova-api restart' I am getting a 'nova-api:unrecognized service' | 22:02 |
| *** annegentle has quit IRC | 22:02 | |
| mriedem | ildikov: if api_version and api_version.ver_minor != 0: | 22:02 |
| mriedem | headers["OpenStack-API-Version"] = "volume " + api_version.get_string() | 22:02 |
| mriedem | nova is constructing a base cinderclient.v3.client.Client class | 22:02 |
| mriedem | which from the entry point is going to just have api_version set to '3.0' | 22:03 |
| mriedem | so looking at that cinderclient code, it's not going to send the header for 3.0 | 22:03 |
| mriedem | and kaboom | 22:03 |
| mriedem | ildikov: so nova is going to create the client object using this https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/client.py#L711 | 22:04 |
| mriedem | actually, | 22:04 |
| mriedem | nova would be using this https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/client.py#L656 | 22:04 |
| scottda | ildikov: are you using this patch? https://review.openstack.org/#/c/385682/3/nova/volume/cinder.py | 22:04 |
| mriedem | ildikov: note that does " return importutils.import_class(client_path)" | 22:04 |
| mriedem | which doesn't pass in the api_version kwarg | 22:05 |
| mriedem | compared to https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/client.py#L735 which does pass in the api_version kwarg | 22:05 |
| ildikov | scottda: no, I'm depending on another one already | 22:05 |
| mriedem | and ^ is going to be using 3.0 | 22:05 |
| mriedem | anyway that gets us here https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/v3/client.py#L72 | 22:06 |
| mriedem | and then https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/v3/client.py#L112 | 22:06 |
| scottda | ildikov: Does your patch call api_versions.get_highest_version(client) ? | 22:06 |
| mriedem | and then we create a session client here https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/client.py#L607 | 22:06 |
| *** stewie925_ has joined #openstack-nova | 22:06 | |
| mriedem | because nova is using a session | 22:06 |
| scottda | ildikov: or point me to your patch(es) | 22:07 |
| mriedem | when session client makes a request it updates the headers here https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/client.py#L109 | 22:07 |
| mriedem | which gets us here https://github.com/openstack/python-cinderclient/blob/1.10.0/cinderclient/api_versions.py#L310 | 22:07 |
| ildikov | scottda: I don't touch the client part in my patch | 22:07 |
| mriedem | and for whatever reason, that only sets the header if the minor version is > 0 | 22:07 |
| mriedem | which seems like a bug | 22:07 |
| ildikov | scottda: so I don't call get_highest_version either | 22:07 |
| scottda | Well, the cinderclient doesn't auto-negotiate to the highest mutually supported version (yet) | 22:08 |
| mriedem | i bet you $100 that that's just a copy/paste from the novaclient update_headers code | 22:08 |
| mriedem | because 2.0 is legacy compute api, 2.1 is new hotness with microversions | 22:08 |
| mriedem | there is no nova 3.0 | 22:08 |
| *** stewie925 has quit IRC | 22:08 | |
| mriedem | but cinder decided to jump from 2.0 to 3.0 | 22:08 |
| mriedem | scottda: ildikov: so yeah your client is busted | 22:09 |
| *** darrenc is now known as darrenc_afk | 22:09 | |
| mriedem | i'll take the $100 consulting fee in cash or check | 22:09 |
| smcginnis | mriedem: Nova auto-negotiates to the highest? Don't you consider that a risk? | 22:10 |
| mriedem | smcginnis: for the shell, | 22:10 |
| ildikov | mriedem: does that contain the figuring out the endpoint not found issue too? :) | 22:10 |
| mriedem | not the python API | 22:10 |
| mriedem | ildikov: no | 22:10 |
| mriedem | that's ksa | 22:10 |
| smcginnis | mriedem: Still seems like a risk. | 22:10 |
| mriedem | smcginnis: if you're coding to the shell...well... | 22:10 |
| ildikov | mriedem: fair enough | 22:10 |
| mriedem | if you're coding to the shell you deserve to get broken | 22:11 |
| *** gabor_antal has quit IRC | 22:11 | |
| *** gabor_antal_ has joined #openstack-nova | 22:11 | |
| smcginnis | Well, if you're just running commands from the CLI, that seems a risk that suddenly you could get different behavior. | 22:11 |
| *** jamesdenton has quit IRC | 22:13 | |
| ildikov | mriedem: thanks much for the help/explanation of the pain I'm experiencing with testing :) | 22:13 |
| mriedem | ildikov: https://bugs.launchpad.net/python-cinderclient/+bug/1656105 | 22:14 |
| openstack | Launchpad bug 1656105 in python-cinderclient "api_versions.update_headers doesn't set the microversion header if version is 3.0" [Undecided,New] | 22:14 |
| ildikov | mriedem: thanks much! | 22:14 |
| scottda | I'll put up a patch for that ^^^..When I get back from the bus stop. | 22:15 |
| ildikov | scottda: sounds great, thanks | 22:15 |
| mriedem | smcginnis: if you're coding to the shell you can override with --os-compute-api-version | 22:15 |
| mriedem | to opt in or pin the version | 22:15 |
| mriedem | which is exactly what you have to do if you're requesting specific microversions via the python API | 22:15 |
| scottda | ildikov: But why are you using 3.0? You'll still need the version with the new APIs | 22:15 |
| mriedem | microversions in the python API bindings is opt-in, | 22:16 |
| mriedem | the shell is a convenience to use the latest available that the client understands and the server can provide, | 22:16 |
| scottda | BBIAB | 22:16 |
| mriedem | if you're coding to the shell and worry about changes with microversions, then you also have to pin with --os-compute-api-version | 22:16 |
| *** unicell has quit IRC | 22:16 | |
| ildikov | scottda: I'm trying to make Nova pick up the new Cinder APIs and I kind of got stuck with how to do that and hence the questions on every relevant channel | 22:17 |
| *** jose-phillips has quit IRC | 22:19 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | 22:21 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 22:21 |
| *** gabor_antal_ has quit IRC | 22:23 | |
| *** salv-orl_ has joined #openstack-nova | 22:23 | |
| *** gabor_antal has joined #openstack-nova | 22:23 | |
| *** edmondsw has quit IRC | 22:24 | |
| *** edmondsw has joined #openstack-nova | 22:24 | |
| *** jose-phillips has joined #openstack-nova | 22:25 | |
| *** unicell has joined #openstack-nova | 22:25 | |
| *** salv-orlando has quit IRC | 22:25 | |
| *** jwcroppe has joined #openstack-nova | 22:26 | |
| *** annegentle has joined #openstack-nova | 22:26 | |
| cdent | #success edleafe found narrowed down an important bug in gabbi | 22:26 |
| openstackstatus | cdent: Added success to Success page | 22:26 |
| cdent | huh | 22:26 |
| cdent | I've wanted to try that for a while | 22:27 |
| mriedem | found narrowed down? | 22:27 |
| *** cmartin has quit IRC | 22:28 | |
| cdent | both | 22:28 |
| cdent | english, when typed, is my 6th language | 22:28 |
| mriedem | heh | 22:28 |
| *** edmondsw has quit IRC | 22:29 | |
| cdent | sadly, I'm a total fail at solving the bug | 22:31 |
| cdent | I guess that'll have to be tomorrow | 22:31 |
| *** thorst_ has joined #openstack-nova | 22:32 | |
| mriedem | just mark the bug as low-hanging-fruit | 22:32 |
| mriedem | you'll have 10 new contributors lined up to fix it | 22:33 |
| stewie925_ | hello all, hopefully a quick question - I have set up compute on my openstack and then I tried "sudo service nova-api restart" - it returned "nova-api stop/waiting nova-api start/running, process 4383" | 22:33 |
| stewie925_ | is that a confirmation that the nova-api restarted successfully? | 22:33 |
| mriedem | stewie925_: i know you're not new to this channel, but see the channel topic | 22:33 |
| cdent | mriedem: that explains it. I haven't been tagging the bugs. | 22:34 |
| mriedem | how you're deploying it on which distro and what packages etc etc isn't really for this channel | 22:34 |
| stewie925_ | sorry | 22:34 |
| mriedem | np - you'll know it's running if there are logs somewhere | 22:34 |
| *** nherciu_ has quit IRC | 22:35 | |
| *** thorst_ has quit IRC | 22:37 | |
| *** annegentle has quit IRC | 22:40 | |
| *** darrenc_afk is now known as darrenc | 22:41 | |
| *** Swami has quit IRC | 22:43 | |
| *** jaypipes has quit IRC | 22:46 | |
| *** tbachman has joined #openstack-nova | 22:50 | |
| *** _ducttape_ has joined #openstack-nova | 22:50 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP][py35] Trying to get cinder+rally working https://review.openstack.org/419476 | 22:51 |
| dims | mriedem : i think i am very close to nova boot a vm with this https://review.openstack.org/#/c/419476/ | 22:53 |
| *** ducttape_ has quit IRC | 22:54 | |
| *** _ducttape_ has quit IRC | 22:55 | |
| mriedem | [WIP][py35] Trying to get cinder+rally working ? | 22:56 |
| mriedem | wrong title? | 22:56 |
| dims | mriedem : actually i am watching gate-rally-dsvm-py35-cinder-nv over at https://review.openstack.org/#/c/418643/ and debugging nova started from a rally test | 22:57 |
| *** annegentle has joined #openstack-nova | 22:59 | |
| *** mdrabe has quit IRC | 23:00 | |
| *** owalsh has joined #openstack-nova | 23:00 | |
| *** databus23_1 has joined #openstack-nova | 23:02 | |
| *** sapcc-bot1 has joined #openstack-nova | 23:02 | |
| *** sapcc-bot has quit IRC | 23:02 | |
| *** databus23_ has quit IRC | 23:02 | |
| mriedem | jroll: fyi https://review.openstack.org/#/c/415867/ | 23:07 |
| mriedem | just updated that thing | 23:07 |
| jroll | mriedem: u-c already landed, and I put up https://review.openstack.org/#/c/419630/ this morning | 23:08 |
| * jroll didn't see that one | 23:08 | |
| mriedem | jroll: https://review.openstack.org/#/c/415867/ is the one that the nova change depends on | 23:08 |
| jroll | yeah, I see that now | 23:08 |
| mriedem | https://review.openstack.org/#/c/364413/ depends on ^ | 23:08 |
| * jroll abandons | 23:08 | |
| mriedem | and is therefore infinitely more important :) | 23:08 |
| jroll | ya | 23:09 |
| *** kylek3h has quit IRC | 23:09 | |
| *** yamahata has quit IRC | 23:10 | |
| *** stewie925_ is now known as stewie925 | 23:12 | |
| *** yamahata has joined #openstack-nova | 23:12 | |
| *** dave-mccowan has quit IRC | 23:17 | |
| *** jaosorior has quit IRC | 23:22 | |
| *** tblakes has quit IRC | 23:27 | |
| *** marst has quit IRC | 23:28 | |
| *** rama_y has joined #openstack-nova | 23:29 | |
| *** rama_y_ has joined #openstack-nova | 23:29 | |
| *** rama_y_ has quit IRC | 23:31 | |
| *** rama_y has quit IRC | 23:31 | |
| *** mriedem has quit IRC | 23:33 | |
| *** thorst_ has joined #openstack-nova | 23:33 | |
| *** kberger has quit IRC | 23:35 | |
| *** haplo37_ has quit IRC | 23:36 | |
| *** Jeffrey4l has joined #openstack-nova | 23:37 | |
| *** thorst_ has quit IRC | 23:37 | |
| *** haplo37_ has joined #openstack-nova | 23:39 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove the Allocation.create() method. https://review.openstack.org/416751 | 23:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add check for invalid allocation amounts https://review.openstack.org/416752 | 23:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Fix missing RP generation update https://review.openstack.org/419137 | 23:46 |
| *** annegentle has quit IRC | 23:46 | |
| *** stewie925 has quit IRC | 23:48 | |
| *** salv-orl_ has quit IRC | 23:48 | |
| *** owalsh has quit IRC | 23:51 | |
| *** Swami has joined #openstack-nova | 23:54 | |
| *** Swami_ has joined #openstack-nova | 23:54 | |
| dims | nova.boot_server/attach_volume/detach_volume works! http://logs.openstack.org/43/418643/2/check/gate-rally-dsvm-py35-cinder-nv/c48f74a/rally-plot/results.html.gz#/CinderVolumes.create_and_attach_volume/details | 23:54 |
| dims | (py35) | 23:54 |
| *** tjones has quit IRC | 23:55 | |
| *** lamt has quit IRC | 23:55 | |
| *** cdent has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!