| *** zz_dimtruck is now known as dimtruck | 00:02 | |
| *** frewtc4ke has left #openstack-nova | 00:05 | |
| boris-42 | dansmith: hi | 00:05 |
|---|---|---|
| boris-42 | dansmith: are you around? | 00:05 |
| *** annegentle has quit IRC | 00:06 | |
| *** lucas-dinner has quit IRC | 00:06 | |
| *** salv-orlando has quit IRC | 00:07 | |
| *** Jeffrey4l has joined #openstack-nova | 00:07 | |
| *** lucasagomes has joined #openstack-nova | 00:11 | |
| *** salv-orlando has joined #openstack-nova | 00:13 | |
| *** pradk has quit IRC | 00:14 | |
| *** amotoki has quit IRC | 00:14 | |
| *** eil397 has joined #openstack-nova | 00:15 | |
| *** diogogmt has quit IRC | 00:15 | |
| *** dslevin_ has joined #openstack-nova | 00:17 | |
| *** dslevin_ has quit IRC | 00:17 | |
| *** otter768 has quit IRC | 00:18 | |
| *** dslevin has quit IRC | 00:18 | |
| *** salv-orlando has quit IRC | 00:18 | |
| *** dslevin has joined #openstack-nova | 00:18 | |
| *** haomaiwang has joined #openstack-nova | 00:22 | |
| *** amotoki has joined #openstack-nova | 00:26 | |
| prometheanfire | jroll: not all the same :P | 00:26 |
| *** mgoddard__ has joined #openstack-nova | 00:26 | |
| jroll | prometheanfire: :D | 00:27 |
| *** haomaiwang has quit IRC | 00:27 | |
| *** mtanino_ has joined #openstack-nova | 00:27 | |
| *** tjones has joined #openstack-nova | 00:28 | |
| *** zenoway has joined #openstack-nova | 00:29 | |
| *** dimtruck is now known as zz_dimtruck | 00:29 | |
| *** mtanino has quit IRC | 00:29 | |
| *** mgoddard_ has quit IRC | 00:29 | |
| *** annegentle has joined #openstack-nova | 00:32 | |
| *** zenoway has quit IRC | 00:33 | |
| *** pratikmallya has joined #openstack-nova | 00:35 | |
| *** dslevin has quit IRC | 00:35 | |
| *** dslevin has joined #openstack-nova | 00:38 | |
| *** jschlueter has joined #openstack-nova | 00:38 | |
| *** akshai_ has joined #openstack-nova | 00:40 | |
| *** achanda has joined #openstack-nova | 00:41 | |
| *** achanda has quit IRC | 00:43 | |
| *** akshai has quit IRC | 00:43 | |
| *** achanda has joined #openstack-nova | 00:43 | |
| *** achanda has quit IRC | 00:44 | |
| *** davideagnello has quit IRC | 00:44 | |
| *** achanda has joined #openstack-nova | 00:45 | |
| *** shyama has quit IRC | 00:46 | |
| *** ljxiash has quit IRC | 00:47 | |
| *** achanda has quit IRC | 00:47 | |
| *** Sukhdev has quit IRC | 00:48 | |
| *** ducttape_ has joined #openstack-nova | 00:48 | |
| *** dslevin has quit IRC | 00:48 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass attachment_id to Cinder when detach a volume https://review.openstack.org/193134 | 00:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: comp: Allow volume multiattach https://review.openstack.org/267587 | 00:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass host when call attach to Cinder https://review.openstack.org/256273 | 00:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 00:50 |
| *** jnclyz12483 has joined #openstack-nova | 00:50 | |
| *** achanda has joined #openstack-nova | 00:50 | |
| *** dslevin has joined #openstack-nova | 00:51 | |
| ildikov | jaypipes: fixes are up :) ^ | 00:51 |
| *** ducttape_ has quit IRC | 00:52 | |
| jaypipes | ildikov: cool. will rereview in a bit. thx! | 00:55 |
| *** achanda has quit IRC | 00:55 | |
| ildikov | jaypipes: cool, tnx | 00:56 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 00:57 |
| *** diogogmt has joined #openstack-nova | 00:58 | |
| *** fawadkhaliq has joined #openstack-nova | 01:00 | |
| *** achanda has joined #openstack-nova | 01:00 | |
| *** fawadkhaliq has quit IRC | 01:00 | |
| *** achanda has quit IRC | 01:01 | |
| *** yamahata has quit IRC | 01:01 | |
| *** Jeffrey4l has quit IRC | 01:01 | |
| *** dims has quit IRC | 01:01 | |
| *** angdraug has quit IRC | 01:03 | |
| *** eil397 has quit IRC | 01:03 | |
| *** pratikmallya has quit IRC | 01:03 | |
| *** achanda has joined #openstack-nova | 01:05 | |
| *** jinxing has joined #openstack-nova | 01:05 | |
| *** vishwanathj has joined #openstack-nova | 01:06 | |
| *** jacky-zhang has joined #openstack-nova | 01:06 | |
| *** vishwanathj has quit IRC | 01:07 | |
| *** eil397 has joined #openstack-nova | 01:09 | |
| *** ivase has joined #openstack-nova | 01:09 | |
| *** thorst has joined #openstack-nova | 01:11 | |
| *** vishwanathj has joined #openstack-nova | 01:12 | |
| *** jacky-zhang_ has joined #openstack-nova | 01:12 | |
| *** jnclyz12483 has quit IRC | 01:12 | |
| *** ZZelle_ has quit IRC | 01:12 | |
| *** thorst_ has joined #openstack-nova | 01:13 | |
| *** jacky-zhang has quit IRC | 01:13 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Expose quiesce/unquiesce API https://review.openstack.org/248989 | 01:13 |
| *** jacky-zhang_ is now known as jacky-zhang | 01:13 | |
| *** ivase has quit IRC | 01:14 | |
| *** markvoelker has quit IRC | 01:14 | |
| ildikov | jaypipes: if you can check it now I can fix if there's anything, otherwise that will be tomorrow, I need some sleep :) | 01:16 |
| *** thorst has quit IRC | 01:16 | |
| jaypipes | ildikov: it will take time, plus need to wait for a clean bill of health. let's touch base in my morning (EST timezone around 7:30am) | 01:16 |
| ildikov | jaypipes: ok, cool, thanks much | 01:17 |
| *** achanda has quit IRC | 01:17 | |
| jaypipes | ildikov: sleep tight :) | 01:17 |
| ildikov | jaypipes: have a nice evening :) | 01:18 |
| *** ljxiash has joined #openstack-nova | 01:19 | |
| *** achanda has joined #openstack-nova | 01:21 | |
| *** pradk has joined #openstack-nova | 01:23 | |
| *** haomaiwa_ has joined #openstack-nova | 01:23 | |
| *** dims has joined #openstack-nova | 01:23 | |
| *** liverpoo1er has joined #openstack-nova | 01:24 | |
| *** baoli has joined #openstack-nova | 01:24 | |
| *** liverpooler has quit IRC | 01:26 | |
| *** achanda has quit IRC | 01:26 | |
| *** haomaiwa_ has quit IRC | 01:28 | |
| *** baoli has quit IRC | 01:29 | |
| *** dslevin has quit IRC | 01:31 | |
| *** ljxiash_ has joined #openstack-nova | 01:35 | |
| *** thorst_ has quit IRC | 01:35 | |
| *** rfolco has joined #openstack-nova | 01:36 | |
| *** dslevin has joined #openstack-nova | 01:36 | |
| *** baoli has joined #openstack-nova | 01:38 | |
| *** ljxiash has quit IRC | 01:38 | |
| *** ccard_ has quit IRC | 01:42 | |
| openstackgerrit | Tracy Jones proposed openstack/nova: Stop using mox stubs in test_configdrive https://review.openstack.org/265476 | 01:42 |
| *** baoli has quit IRC | 01:43 | |
| *** lyanchih has joined #openstack-nova | 01:43 | |
| *** zhangjn has joined #openstack-nova | 01:45 | |
| openstackgerrit | Tracy Jones proposed openstack/nova: change set_stubs to use stub_out in vmwareapi/stubs.py https://review.openstack.org/266060 | 01:45 |
| *** rfolco has quit IRC | 01:46 | |
| *** ccard_ has joined #openstack-nova | 01:46 | |
| *** eil397 has quit IRC | 01:47 | |
| *** sc68cal has quit IRC | 01:49 | |
| *** sc68cal has joined #openstack-nova | 01:54 | |
| *** Jeffrey4l has joined #openstack-nova | 01:56 | |
| *** dslevin has quit IRC | 01:56 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type https://review.openstack.org/262584 | 01:58 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr https://review.openstack.org/262585 | 01:58 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs https://review.openstack.org/262586 | 01:58 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 01:58 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver https://review.openstack.org/262583 | 01:58 |
| *** apoorvad has quit IRC | 02:00 | |
| *** diogogmt has quit IRC | 02:00 | |
| *** xiexs has quit IRC | 02:01 | |
| *** unicell has joined #openstack-nova | 02:04 | |
| *** unicell1 has quit IRC | 02:04 | |
| *** mtanino_ has quit IRC | 02:04 | |
| *** vladikr has joined #openstack-nova | 02:05 | |
| *** diogogmt has joined #openstack-nova | 02:06 | |
| *** dslevin has joined #openstack-nova | 02:07 | |
| *** dslev has joined #openstack-nova | 02:08 | |
| *** sc68cal has quit IRC | 02:09 | |
| *** sc68cal has joined #openstack-nova | 02:12 | |
| *** unicell has quit IRC | 02:17 | |
| *** otter768 has joined #openstack-nova | 02:18 | |
| *** unicell has joined #openstack-nova | 02:20 | |
| *** liverpooler has joined #openstack-nova | 02:22 | |
| *** david-lyle has joined #openstack-nova | 02:22 | |
| *** liverpoo1er has quit IRC | 02:23 | |
| *** otter768 has quit IRC | 02:23 | |
| *** haomaiwa_ has joined #openstack-nova | 02:26 | |
| *** tjones has quit IRC | 02:29 | |
| *** dslev has quit IRC | 02:31 | |
| *** thorst has joined #openstack-nova | 02:36 | |
| *** houming has joined #openstack-nova | 02:43 | |
| *** thorst has quit IRC | 02:44 | |
| *** davideagnello has joined #openstack-nova | 02:45 | |
| *** burgerk has joined #openstack-nova | 02:45 | |
| *** zhangjn has quit IRC | 02:46 | |
| *** mdnadeem has joined #openstack-nova | 02:48 | |
| *** ducttape_ has joined #openstack-nova | 02:48 | |
| *** davideagnello has quit IRC | 02:51 | |
| *** markvoelker has joined #openstack-nova | 02:52 | |
| *** ducttape_ has quit IRC | 02:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: WIP-Enable all extension for server API sample tests https://review.openstack.org/243396 | 02:54 |
| *** burgerk has quit IRC | 02:54 | |
| *** markvoelker_ has joined #openstack-nova | 02:56 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: config options: Centralise floating ip options https://review.openstack.org/257087 | 02:56 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: WIP-Enable all extension for server API sample tests https://review.openstack.org/269404 | 02:58 |
| *** e0ne has quit IRC | 02:59 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for Flavor API sample tests https://review.openstack.org/243396 | 03:00 |
| *** otter768 has joined #openstack-nova | 03:00 | |
| *** e0ne has joined #openstack-nova | 03:00 | |
| *** markvoelker has quit IRC | 03:00 | |
| *** markvoelker_ has quit IRC | 03:01 | |
| *** e0ne has quit IRC | 03:01 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Expose quiesce/unquiesce API https://review.openstack.org/248989 | 03:01 |
| *** ducttape_ has joined #openstack-nova | 03:04 | |
| *** markvoelker has joined #openstack-nova | 03:06 | |
| *** Marga_ has joined #openstack-nova | 03:10 | |
| *** vishwanathj has quit IRC | 03:10 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add expected_task_state for instance.save() used by block_device_mapping https://review.openstack.org/245038 | 03:12 |
| *** ljxiash_ has quit IRC | 03:14 | |
| *** ljxiash has joined #openstack-nova | 03:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 03:16 |
| *** ljxiash has quit IRC | 03:19 | |
| *** dims has quit IRC | 03:20 | |
| *** achanda has joined #openstack-nova | 03:21 | |
| *** Sukhdev has joined #openstack-nova | 03:22 | |
| *** baoli has joined #openstack-nova | 03:24 | |
| *** links has joined #openstack-nova | 03:27 | |
| *** ccard_ has quit IRC | 03:31 | |
| *** tjones has joined #openstack-nova | 03:31 | |
| *** ccard_ has joined #openstack-nova | 03:32 | |
| *** ducttape_ has quit IRC | 03:34 | |
| *** sixdoublefive321 has joined #openstack-nova | 03:36 | |
| *** liverpoo1er has joined #openstack-nova | 03:36 | |
| *** mragupat has joined #openstack-nova | 03:37 | |
| *** liverpooler has quit IRC | 03:38 | |
| *** zhangjn has joined #openstack-nova | 03:38 | |
| *** vladikr has quit IRC | 03:41 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Libvirt: Move graphics checking and console verify early when LM https://review.openstack.org/265042 | 03:41 |
| *** ljxiash has joined #openstack-nova | 03:41 | |
| *** ljxiash has quit IRC | 03:42 | |
| *** thorst has joined #openstack-nova | 03:42 | |
| *** ljxiash has joined #openstack-nova | 03:42 | |
| *** ducttape_ has joined #openstack-nova | 03:43 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova: Use stevedore for scheduler host manager https://review.openstack.org/246476 | 03:45 |
| *** sixdoublefive321 has quit IRC | 03:45 | |
| *** ljxiash has quit IRC | 03:47 | |
| *** davideagnello has joined #openstack-nova | 03:48 | |
| *** zhangjn has quit IRC | 03:49 | |
| *** thorst has quit IRC | 03:50 | |
| *** yamahata has joined #openstack-nova | 03:52 | |
| *** davideagnello has quit IRC | 03:52 | |
| *** zz_dimtruck is now known as dimtruck | 03:52 | |
| *** ducttape_ has quit IRC | 03:54 | |
| *** tjones has quit IRC | 03:54 | |
| *** achanda has quit IRC | 04:00 | |
| *** jacky-zhang has quit IRC | 04:01 | |
| *** dimtruck is now known as zz_dimtruck | 04:03 | |
| *** shyama has joined #openstack-nova | 04:03 | |
| *** lyanchih has quit IRC | 04:04 | |
| *** cfarquhar has quit IRC | 04:13 | |
| *** ljxiash has joined #openstack-nova | 04:14 | |
| *** cfarquhar has joined #openstack-nova | 04:14 | |
| *** cfarquhar has quit IRC | 04:14 | |
| *** cfarquhar has joined #openstack-nova | 04:14 | |
| *** yamahata has quit IRC | 04:15 | |
| *** ljxiash has quit IRC | 04:18 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server PUT API sample tests https://review.openstack.org/269426 | 04:19 |
| *** diana_clarke has quit IRC | 04:24 | |
| *** [1]Thelo has joined #openstack-nova | 04:29 | |
| *** Marga_ has quit IRC | 04:30 | |
| *** achanda has joined #openstack-nova | 04:30 | |
| *** Marga_ has joined #openstack-nova | 04:30 | |
| *** jacky-zhang has joined #openstack-nova | 04:31 | |
| *** baoli has quit IRC | 04:31 | |
| *** zz_dimtruck is now known as dimtruck | 04:32 | |
| *** Thelo has quit IRC | 04:32 | |
| *** [1]Thelo is now known as Thelo | 04:32 | |
| *** zhangjn has joined #openstack-nova | 04:33 | |
| *** diana_clarke has joined #openstack-nova | 04:34 | |
| *** achanda has quit IRC | 04:38 | |
| *** achanda has joined #openstack-nova | 04:39 | |
| *** markvoelker has quit IRC | 04:39 | |
| *** markvoelker has joined #openstack-nova | 04:40 | |
| *** dimtruck is now known as zz_dimtruck | 04:41 | |
| *** ljxiash has joined #openstack-nova | 04:42 | |
| *** Marga_ has quit IRC | 04:44 | |
| *** chhavi has joined #openstack-nova | 04:44 | |
| *** annegentle has quit IRC | 04:45 | |
| *** ljxiash has quit IRC | 04:46 | |
| *** thorst has joined #openstack-nova | 04:49 | |
| *** akshai_ has quit IRC | 04:51 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Fix/implement revert-resize for RBD-backed images https://review.openstack.org/187395 | 04:52 |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 04:52 |
| *** thorst has quit IRC | 04:55 | |
| *** pradk has quit IRC | 04:58 | |
| *** haomaiwa_ has quit IRC | 04:59 | |
| *** zhangjn has quit IRC | 05:05 | |
| *** haomaiwang has joined #openstack-nova | 05:05 | |
| *** SridharG has joined #openstack-nova | 05:07 | |
| *** ljxiash has joined #openstack-nova | 05:07 | |
| *** mragupat has quit IRC | 05:07 | |
| *** vilobhmm11 has joined #openstack-nova | 05:07 | |
| *** teju has joined #openstack-nova | 05:08 | |
| *** lyanchih has joined #openstack-nova | 05:21 | |
| *** gongysh has joined #openstack-nova | 05:23 | |
| *** zhangjn has joined #openstack-nova | 05:23 | |
| *** lyanchih has quit IRC | 05:29 | |
| *** EinstCra_ has joined #openstack-nova | 05:30 | |
| *** Jeffrey4l has quit IRC | 05:31 | |
| *** ljxiash has quit IRC | 05:32 | |
| *** EinstCr__ has joined #openstack-nova | 05:32 | |
| *** EinstCrazy has quit IRC | 05:32 | |
| *** baoli has joined #openstack-nova | 05:32 | |
| *** ljxiash has joined #openstack-nova | 05:32 | |
| *** EinstCra_ has quit IRC | 05:34 | |
| *** ljxiash_ has joined #openstack-nova | 05:35 | |
| *** ljxiash has quit IRC | 05:37 | |
| *** ljxiash_ has quit IRC | 05:37 | |
| *** ljxiash has joined #openstack-nova | 05:37 | |
| *** otter768 has quit IRC | 05:38 | |
| *** amotoki has quit IRC | 05:39 | |
| *** liverpooler has joined #openstack-nova | 05:40 | |
| *** liverpoo1er has quit IRC | 05:42 | |
| *** salv-orlando has joined #openstack-nova | 05:42 | |
| *** amotoki has joined #openstack-nova | 05:44 | |
| *** jaosorior has joined #openstack-nova | 05:45 | |
| *** zhangjn has quit IRC | 05:46 | |
| *** EinstCr__ is now known as EinstCrazy | 05:47 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 05:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass attachment_id to Cinder when detach a volume https://review.openstack.org/193134 | 05:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: comp: Allow volume multiattach https://review.openstack.org/267587 | 05:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 05:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass host when call attach to Cinder https://review.openstack.org/256273 | 05:48 |
| *** vivekd has joined #openstack-nova | 05:49 | |
| *** Jeffrey4l has joined #openstack-nova | 05:52 | |
| *** thorst has joined #openstack-nova | 05:53 | |
| *** edtubill has joined #openstack-nova | 05:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: WIP-Enable all extension for server actions sample tests https://review.openstack.org/269441 | 05:57 |
| *** ildikov has quit IRC | 05:58 | |
| *** edtubill has quit IRC | 05:58 | |
| *** lyanchih has joined #openstack-nova | 05:59 | |
| *** jamielennox is now known as jamielennox|away | 05:59 | |
| *** thorst has quit IRC | 06:00 | |
| openstackgerrit | Abhishek Kekane proposed openstack/nova: Python3: Replace dict.iteritems with six.iteritems https://review.openstack.org/268018 | 06:03 |
| *** yangyapeng has joined #openstack-nova | 06:05 | |
| *** esracelik has joined #openstack-nova | 06:07 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Add new DB API method to retrieve migration for instance https://review.openstack.org/257270 | 06:11 |
| *** SridharG has quit IRC | 06:13 | |
| *** takashin has joined #openstack-nova | 06:14 | |
| *** vivekd has quit IRC | 06:15 | |
| *** salv-orlando has quit IRC | 06:15 | |
| *** liverpoo1er has joined #openstack-nova | 06:15 | |
| *** liverpooler has quit IRC | 06:17 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server PUT API sample tests https://review.openstack.org/269426 | 06:17 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: WIP-Enable all extension for server actions sample tests https://review.openstack.org/269441 | 06:18 |
| *** liverpoo1er has quit IRC | 06:20 | |
| *** liverpooler has joined #openstack-nova | 06:20 | |
| *** haomaiwang has quit IRC | 06:21 | |
| *** 6A4ABP35J has joined #openstack-nova | 06:24 | |
| *** salv-orlando has joined #openstack-nova | 06:24 | |
| *** achanda_ has joined #openstack-nova | 06:25 | |
| *** achanda has quit IRC | 06:28 | |
| *** sahid has joined #openstack-nova | 06:29 | |
| *** ljxiash has quit IRC | 06:30 | |
| *** amotoki_ has joined #openstack-nova | 06:32 | |
| *** ljxiash has joined #openstack-nova | 06:33 | |
| *** amotoki has quit IRC | 06:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/265601 | 06:35 |
| *** amotoki_ has quit IRC | 06:35 | |
| *** EinstCrazy has quit IRC | 06:37 | |
| *** EinstCrazy has joined #openstack-nova | 06:37 | |
| *** davideagnello has joined #openstack-nova | 06:37 | |
| *** davideagnello has quit IRC | 06:38 | |
| *** vivekd has joined #openstack-nova | 06:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server actions sample tests https://review.openstack.org/269441 | 06:41 |
| *** achanda_ has quit IRC | 06:43 | |
| *** atuvenie has joined #openstack-nova | 06:44 | |
| *** liverpooler has quit IRC | 06:44 | |
| *** amotoki has joined #openstack-nova | 06:44 | |
| *** liverpooler has joined #openstack-nova | 06:44 | |
| *** SridharG has joined #openstack-nova | 06:45 | |
| *** nkrinner has joined #openstack-nova | 06:45 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova: Use stevedore for scheduler driver https://review.openstack.org/254768 | 06:45 |
| *** annegentle has joined #openstack-nova | 06:46 | |
| *** snikitin has joined #openstack-nova | 06:46 | |
| *** lpetrut has joined #openstack-nova | 06:48 | |
| *** annegentle has quit IRC | 06:50 | |
| *** Jeffrey4l has quit IRC | 06:52 | |
| *** thorst has joined #openstack-nova | 06:57 | |
| *** amotoki has quit IRC | 07:00 | |
| *** thorst has quit IRC | 07:04 | |
| *** salv-orlando has quit IRC | 07:05 | |
| openstackgerrit | sahid proposed openstack/nova: hardware: check whether realtime capable in API https://review.openstack.org/264165 | 07:07 |
| *** 6A4ABP35J has quit IRC | 07:09 | |
| *** haomaiwang has joined #openstack-nova | 07:09 | |
| *** paul-carlton2 has joined #openstack-nova | 07:10 | |
| *** markvoelker_ has joined #openstack-nova | 07:11 | |
| *** diana_clarke has quit IRC | 07:14 | |
| *** markvoelker has quit IRC | 07:15 | |
| *** ljxiash_ has joined #openstack-nova | 07:15 | |
| *** ljxiash_ has quit IRC | 07:15 | |
| *** shyama has quit IRC | 07:15 | |
| *** ljxiash_ has joined #openstack-nova | 07:15 | |
| *** mjura has joined #openstack-nova | 07:15 | |
| *** shyama has joined #openstack-nova | 07:16 | |
| *** tdurakov_ has joined #openstack-nova | 07:16 | |
| *** amotoki has joined #openstack-nova | 07:17 | |
| *** scheuran has joined #openstack-nova | 07:17 | |
| *** zenoway has joined #openstack-nova | 07:18 | |
| *** ljxiash has quit IRC | 07:18 | |
| openstackgerrit | LisaLi proposed openstack/nova: Attach/detach encryptors during swap_volume https://review.openstack.org/252809 | 07:18 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server PUT API sample tests https://review.openstack.org/269426 | 07:18 |
| *** tdurakov_ has quit IRC | 07:19 | |
| *** idonotknow has joined #openstack-nova | 07:20 | |
| idonotknow | quit | 07:20 |
| *** zenoway has quit IRC | 07:21 | |
| *** zenoway has joined #openstack-nova | 07:22 | |
| openstackgerrit | Wen Zhi Yu proposed openstack/nova: Add exception handling in _cleanup_allocated_network https://review.openstack.org/269462 | 07:24 |
| *** zhangjn has joined #openstack-nova | 07:25 | |
| *** shyama has quit IRC | 07:25 | |
| *** shyama has joined #openstack-nova | 07:26 | |
| *** zenoway has quit IRC | 07:26 | |
| *** cfriesen has quit IRC | 07:26 | |
| *** cfriesen has joined #openstack-nova | 07:27 | |
| *** sshen_ has quit IRC | 07:27 | |
| *** sshen has joined #openstack-nova | 07:27 | |
| *** mpavone has joined #openstack-nova | 07:28 | |
| *** haomaiwang has quit IRC | 07:34 | |
| *** haomaiwang has joined #openstack-nova | 07:36 | |
| *** ptm_away has joined #openstack-nova | 07:38 | |
| *** EinstCrazy has quit IRC | 07:39 | |
| *** EinstCrazy has joined #openstack-nova | 07:39 | |
| *** otter768 has joined #openstack-nova | 07:39 | |
| *** PaulMurray has quit IRC | 07:42 | |
| *** ptm_away is now known as PaulMurray | 07:42 | |
| *** Jeffrey4l has joined #openstack-nova | 07:42 | |
| *** tdurakov_ has joined #openstack-nova | 07:43 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server actions sample tests https://review.openstack.org/269441 | 07:44 |
| *** otter768 has quit IRC | 07:44 | |
| PaulMurray | pkoniszewski, Hi are you around? | 07:46 |
| *** jlanoux has joined #openstack-nova | 07:46 | |
| PaulMurray | Morning jlanoux | 07:47 |
| jlanoux | hi PaulMurray | 07:47 |
| PaulMurray | jlanoux, its most likely I can't make the live migration meeting this afternoon | 07:49 |
| jlanoux | PaulMurray: ok | 07:49 |
| PaulMurray | jlanoux, would you ask pkoniszewski or tdurakov to chair it for me please? | 07:50 |
| *** amotoki has quit IRC | 07:50 | |
| *** lpetrut has quit IRC | 07:50 | |
| *** ajayaa has joined #openstack-nova | 07:51 | |
| PaulMurray | I can check back later, but I want to make sure I catch one of them this morning | 07:51 |
| eliqiao_ | PaulMurray: jlanoux I will attend the meeting, I can check it with pknoiszewski or tdurakov_ | 07:52 |
| *** eliqiao_ is now known as eliqiao | 07:52 | |
| PaulMurray | eliqiao, thanks - that's very helpful | 07:52 |
| jlanoux | PaulMurray: eliqiao sorted out! | 07:53 |
| tdurakov_ | PaulMurray, jlanoux, eliqiao, hi | 07:54 |
| eliqiao | That's great, tdurakov_ is here. :) | 07:54 |
| *** zhangjn has quit IRC | 07:55 | |
| *** Jeffrey4l has quit IRC | 07:56 | |
| *** garyk has quit IRC | 07:56 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Split-network-plane-for-live-migration https://review.openstack.org/245005 | 07:56 |
| tdurakov_ | read doc about meeting infra, guess I could manage with meeting | 07:57 |
| *** markvoelker_ has quit IRC | 07:57 | |
| *** yangyapeng has quit IRC | 07:57 | |
| *** EinstCrazy has quit IRC | 07:57 | |
| *** jinxing has quit IRC | 07:57 | |
| *** garyk has joined #openstack-nova | 07:58 | |
| *** vilobhmm11 has quit IRC | 07:58 | |
| *** jinxing has joined #openstack-nova | 08:00 | |
| *** rcernin has joined #openstack-nova | 08:01 | |
| *** EinstCrazy has joined #openstack-nova | 08:02 | |
| *** EinstCrazy has quit IRC | 08:02 | |
| *** EinstCrazy has joined #openstack-nova | 08:02 | |
| *** tdurakov_ is now known as tdurakov | 08:04 | |
| *** jacky-zhang_ has joined #openstack-nova | 08:04 | |
| *** jacky-zhang has quit IRC | 08:05 | |
| *** jacky-zhang_ is now known as jacky-zhang | 08:05 | |
| *** thorst has joined #openstack-nova | 08:05 | |
| *** salv-orlando has joined #openstack-nova | 08:06 | |
| *** zhangjn has joined #openstack-nova | 08:06 | |
| *** lpetrut has joined #openstack-nova | 08:06 | |
| *** mdnadeem has quit IRC | 08:08 | |
| *** ildikov has joined #openstack-nova | 08:09 | |
| *** PaulMurray has quit IRC | 08:09 | |
| *** thorst has quit IRC | 08:10 | |
| *** markus_z has joined #openstack-nova | 08:10 | |
| *** salv-orlando has quit IRC | 08:11 | |
| *** rdopiera has joined #openstack-nova | 08:12 | |
| openstackgerrit | Wang Bo proposed openstack/nova: Fix codes using dict.iteritems() for python3 https://review.openstack.org/269485 | 08:13 |
| *** rgerganov has joined #openstack-nova | 08:13 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add wrapper classes for return-request-id-to-caller https://review.openstack.org/258802 | 08:14 |
| *** Jeffrey4l has joined #openstack-nova | 08:14 | |
| *** paul-carlton2 has quit IRC | 08:14 | |
| gongysh | alex_xu, hi | 08:17 |
| alex_xu | gongysh: hi | 08:17 |
| *** irenab has joined #openstack-nova | 08:18 | |
| *** jichen has joined #openstack-nova | 08:19 | |
| gongysh | alex_xu, i am recommit that patch | 08:20 |
| alex_xu | gongysh: yea, but just found it merge conflict | 08:20 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Libvirt: Move graphics checking and console verify early when LM https://review.openstack.org/265042 | 08:22 |
| alex_xu | gongysh: anyway I will check that later | 08:23 |
| *** jianghuaw_ has joined #openstack-nova | 08:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add wrapper classes for return-request-id-to-caller https://review.openstack.org/258802 | 08:25 |
| gongysh | alex_xu, I am looking for the reason that causes the jekin failure. but I don't know why. so I recheck that patch | 08:26 |
| *** paul-carlton2 has joined #openstack-nova | 08:27 | |
| *** matrohon has joined #openstack-nova | 08:27 | |
| *** lpetrut has quit IRC | 08:28 | |
| *** zakora has joined #openstack-nova | 08:30 | |
| *** zhangjn has quit IRC | 08:30 | |
| *** lyanchih has quit IRC | 08:32 | |
| *** vivekd has quit IRC | 08:32 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add way to pause VM during live migration https://review.openstack.org/245921 | 08:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications https://review.openstack.org/263788 | 08:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 08:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Generate doc for versioned notifications https://review.openstack.org/265151 | 08:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 08:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 08:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 08:33 |
| *** zhangjn has joined #openstack-nova | 08:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server actions sample tests https://review.openstack.org/269441 | 08:36 |
| *** mdnadeem has joined #openstack-nova | 08:36 | |
| *** markvoelker has joined #openstack-nova | 08:38 | |
| *** davideagnello has joined #openstack-nova | 08:38 | |
| *** zhangjn has quit IRC | 08:39 | |
| *** daemontool has joined #openstack-nova | 08:41 | |
| *** vivekd has joined #openstack-nova | 08:42 | |
| *** Sukhdev has quit IRC | 08:43 | |
| *** markvoelker has quit IRC | 08:43 | |
| *** davideagnello has quit IRC | 08:44 | |
| *** lyanchih has joined #openstack-nova | 08:46 | |
| *** markvoelker has joined #openstack-nova | 08:46 | |
| *** tdurakov has quit IRC | 08:50 | |
| *** dedery has joined #openstack-nova | 08:50 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add way to pause VM during live migration https://review.openstack.org/245921 | 08:51 |
| *** tdurakov has joined #openstack-nova | 08:52 | |
| *** irenab has quit IRC | 08:52 | |
| *** zhangjn has joined #openstack-nova | 08:52 | |
| *** irenab has joined #openstack-nova | 08:53 | |
| *** zhangjn has quit IRC | 08:54 | |
| *** dedery has quit IRC | 08:55 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Object: Make object target version check sorted https://review.openstack.org/269500 | 08:58 |
| openstackgerrit | Tang Chen proposed openstack/nova: Add a REST API to trigger crash dump in an instance. https://review.openstack.org/202617 | 08:59 |
| *** irenab has quit IRC | 08:59 | |
| *** vivekd has quit IRC | 08:59 | |
| eliqiao | hi tdurakov, there? | 09:01 |
| tdurakov | eliqiao, yep | 09:01 |
| *** markvoelker has quit IRC | 09:02 | |
| *** daemontool has quit IRC | 09:02 | |
| eliqiao | tdurakov: it's re https://review.openstack.org/#/c/252283/87, most of the patch seems good to me, thanks for you efforts | 09:02 |
| eliqiao | tdurakov: but I'd like to know where can I get the live-migration experimental test results? | 09:03 |
| *** e0ne has joined #openstack-nova | 09:03 | |
| markus_z | johnthetubaguy: Is mitaka-2 still open? This blueprint could be finished easily. It has two small changes pushed since 6 weeks. https://blueprints.launchpad.net/nova/+spec/libvirt-aio-mode | 09:03 |
| eliqiao | tdurakov: I don't find it after last 'check experimental' | 09:03 |
| *** daemontool has joined #openstack-nova | 09:03 | |
| *** vivekd has joined #openstack-nova | 09:04 | |
| *** irenab has joined #openstack-nova | 09:04 | |
| *** ankit_ag has joined #openstack-nova | 09:05 | |
| tdurakov | eliqiao, here is the problem, job is skipped by infra, as it's doesn't changed any nova code, only tests. I've pushed patch to change this: https://review.openstack.org/#/c/267669/ | 09:05 |
| *** efoley has joined #openstack-nova | 09:06 | |
| tdurakov | so, if you change smth in nova package, except tests everything works fine | 09:06 |
| eliqiao | tdurakov: ah, thanks, good to know it. | 09:07 |
| *** thorst has joined #openstack-nova | 09:07 | |
| tdurakov | eliqiao, thank you for +1 | 09:09 |
| *** efoley_ has joined #openstack-nova | 09:09 | |
| eliqiao | tdurakov: yw, thanks for your hard work. we need your patch. | 09:09 |
| *** yassine__ has joined #openstack-nova | 09:11 | |
| *** amotoki has joined #openstack-nova | 09:11 | |
| *** efoley has quit IRC | 09:11 | |
| *** dedery has joined #openstack-nova | 09:12 | |
| openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 09:13 |
| *** efoley_ is now known as efoley | 09:13 | |
| chhavi | ildikov: regarding https://review.openstack.org/#/c/193135/ | 09:13 |
| ildikov | chhavi: hi | 09:13 |
| chhavi | in this we are setting the multiattach property in the connectioninfo | 09:13 |
| chhavi | for any nova drivers to support multiattach do we need this property to be set in connection-info | 09:14 |
| chhavi | and also te virt_driver.capabilities or this is only required for libvirt | 09:14 |
| ildikov | chhavi: as I saw it's not the only volume info that is passed via connection_info | 09:14 |
| BobBall | mriedem_away: That seems to be a race condition we're struggling to track down... Will have a look at your logs to see if there are clues... | 09:15 |
| *** thorst has quit IRC | 09:15 | |
| ildikov | currently only Libvirt supports multiattach, but the plan would be to enable it for other drivers too | 09:15 |
| chhavi | yeah i am looking to enable this for our drivers so want to understand | 09:15 |
| ildikov | chhavi: the capabilities is needed to discover which driver supports multiattach and which does not as we don't have a full coverage | 09:15 |
| ildikov | chhavi: I got a comment that connection_info is not the best place, but to be honest I don't know what would be better | 09:16 |
| *** rotbeard has joined #openstack-nova | 09:16 | |
| chhavi | why we need to store this in connection info, can't we directly fetch from the cinder volume | 09:17 |
| *** zenoway has joined #openstack-nova | 09:18 | |
| chhavi | and does virt driver has any impact if the volume is multiattach ? | 09:18 |
| *** ndipanov has quit IRC | 09:18 | |
| *** irenab has quit IRC | 09:19 | |
| openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 09:19 |
| *** markvoelker has joined #openstack-nova | 09:19 | |
| *** jistr has joined #openstack-nova | 09:20 | |
| *** matrohon has quit IRC | 09:20 | |
| chhavi | just trying to understand how virt driver will be using this property | 09:20 |
| ildikov | chhavi: I don't think that in the virt driver we should call out to Cinder, when we have the info where we call to the virt driver | 09:20 |
| ildikov | the information is needed as you usually need to disable caching in the hypervisor to support multiattach, if that's possible | 09:21 |
| chhavi | just thinking since we already did the check in the manager layer, before we pass the call to driver for attach/detach | 09:21 |
| chhavi | then do we really need to again verify in the virt driver | 09:21 |
| ildikov | like iin case of Libvirt you need to add the shareable flag to the disk config3 | 09:21 |
| *** ndipanov has joined #openstack-nova | 09:21 | |
| *** irenab has joined #openstack-nova | 09:21 | |
| ildikov | *config | 09:21 |
| ildikov | it's not about verification, but to add the required config to the hypervisor setup for the instance | 09:22 |
| ildikov | otherwise it will mess up the volume | 09:22 |
| ildikov | or it might | 09:22 |
| chhavi | ok so thats specific to libvirt, since some hypervisor does not care about and allows multiattach | 09:23 |
| markus_z | bauzas: Good morning, do you have a minute? I don't quit get the config option "scheduler_json_config_location". | 09:23 |
| *** markvoelker has quit IRC | 09:24 | |
| markus_z | bauzas: Is that an additional way to configure the scheduler? Does it have a specific structure? | 09:25 |
| ildikov | chhavi: if it does not allow, then you will not be able to implement that support for it | 09:26 |
| ildikov | chhavi: if it enables you will most probably need to set an extra config option to enable it | 09:27 |
| ildikov | otherwise the optimization that the hypervisor is doing will mess up the write operations on your volume from the multiple instances, which tries to access it in parallel | 09:27 |
| ildikov | you will need to triple check the hypervisor you want to add support for | 09:28 |
| *** danpb has joined #openstack-nova | 09:28 | |
| *** Marga_ has joined #openstack-nova | 09:29 | |
| *** jacky-zhang has quit IRC | 09:29 | |
| *** e0ne has quit IRC | 09:34 | |
| chhavi | has these been updated in the hypervisor support matrix doc | 09:36 |
| *** matrohon has joined #openstack-nova | 09:36 | |
| johnthetubaguy | markus_z: technically still open, but the feature freeze is separate, that happens on Thursday, independently of mitaka-2 | 09:37 |
| *** jacky-zhang has joined #openstack-nova | 09:37 | |
| *** aix has joined #openstack-nova | 09:39 | |
| *** daemontool has quit IRC | 09:39 | |
| *** daemontool has joined #openstack-nova | 09:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(1/5) https://review.openstack.org/261399 | 09:40 |
| *** haomaiwang has quit IRC | 09:40 | |
| *** markvoelker has joined #openstack-nova | 09:40 | |
| *** otter768 has joined #openstack-nova | 09:40 | |
| markus_z | johnthetubaguy: ah, I thought it goes hand in hand. | 09:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(2/5) https://review.openstack.org/261401 | 09:40 |
| markus_z | johnthetubaguy: What can I do to get attention to that libvirt change? Adding it to the priorities tracking etherpad looks wrong imo. | 09:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(3/5) https://review.openstack.org/261405 | 09:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(4/5) https://review.openstack.org/261407 | 09:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(5/5) https://review.openstack.org/261410 | 09:42 |
| johnthetubaguy | markus_z: there is a libvirt sub group in there I thought, thats correct ish | 09:42 |
| ildikov | chhavi: it is updated here: https://review.openstack.org/#/c/193135/86/doc/source/support-matrix.ini | 09:42 |
| *** lpetrut has joined #openstack-nova | 09:43 | |
| chhavi | ok | 09:43 |
| tdurakov | johnthetubaguy, hi, last week we were talking about https://review.openstack.org/#/c/252283/ so, could we merge it? | 09:43 |
| *** haomaiwang has joined #openstack-nova | 09:43 | |
| *** derekh has joined #openstack-nova | 09:43 | |
| markus_z | johnthetubaguy: ok, I'll try it there, thanks | 09:43 |
| *** boris-42 has quit IRC | 09:43 | |
| *** jacky-zhang has quit IRC | 09:43 | |
| *** irenab has quit IRC | 09:44 | |
| *** aix_ has joined #openstack-nova | 09:44 | |
| *** markvoelker has quit IRC | 09:45 | |
| *** otter768 has quit IRC | 09:45 | |
| *** irenab has joined #openstack-nova | 09:45 | |
| johnthetubaguy | tdurakov: if you be great if we could have a live-migrate CI run against that patch, maybe make a folow on patch that triggers that test by some change of a comment in the main body of the code? | 09:45 |
| johnthetubaguy | tdurakov: this week I am going to have to focus on the release, and the feature freeze, so its unlikley I will get to that I am afraid | 09:46 |
| johnthetubaguy | bauzas: are you around today, to help getting the release sorted? | 09:46 |
| bauzas | markus_z: hi | 09:46 |
| tdurakov | johnthetubaguy, i understand, have you seen sdague recently? | 09:46 |
| bauzas | johnthetubaguy: heya | 09:46 |
| *** aix_ has quit IRC | 09:46 | |
| johnthetubaguy | tdurakov: no, been out yesterday | 09:46 |
| bauzas | johnthetubaguy: et al. I'll be off for tomorrow since I'll be teaching an OpenStack class | 09:46 |
| bauzas | off tomorrow I mean | 09:47 |
| *** rmart04 has joined #openstack-nova | 09:47 | |
| BobBall | johnthetubaguy: I've identified another race in the logconsole code which is very hard to avoid: xapi uses libxc to start a domain, which can start to write to the console log before XAPI returns that the domain has started (and we can identify the domain ID so we can explicitly preserve the console log). The only way I can think of avoiding the race is to only delete logs that haven't been modified for the last 5 minutes, to | 09:47 |
| johnthetubaguy | bauzas: ah, no worries, I was out yesterday cause I was traveling back from a contest, and needed some shut eye | 09:47 |
| bauzas | and then, Thurs and Frid, I'll be available but will be following a conf | 09:47 |
| johnthetubaguy | bauzas: gotcha | 09:47 |
| bauzas | johnthetubaguy: sure, np, I was about to ping you about the above | 09:47 |
| tdurakov | johnthetubaguy, my patch in project config(which fixes this skip) waits for sdague review | 09:48 |
| bauzas | given that we cut m2 | 09:48 |
| bauzas | johnthetubaguy: so, when do you want to cut ? | 09:48 |
| bauzas | johnthetubaguy: have you seen mriedem_away's patch for stable point release ? | 09:48 |
| johnthetubaguy | bauzas: the main thing I was thinking, is lets try work out what blockers we have, and what release notes we might be missing | 09:48 |
| *** amotoki has quit IRC | 09:48 | |
| johnthetubaguy | bauzas: I haven't | 09:48 |
| *** e0ne has joined #openstack-nova | 09:48 | |
| bauzas | sec | 09:48 |
| bauzas | johnthetubaguy: I agree with you, we should look at the UpgradeImpact, DocImpact and features | 09:49 |
| bauzas | for the notes | 09:49 |
| bauzas | we had a CI issue with reno, but my fix was merged, so it should be back okay | 09:49 |
| bauzas | johnthetubaguy: stable point release patch https://review.openstack.org/#/c/268709/ | 09:50 |
| BobBall | mriedem_away: FYI https://bugs.launchpad.net/nova/+bug/1535616 | 09:51 |
| openstack | Launchpad bug 1535616 in OpenStack Compute (nova) "XenAPI: Console logging race condition" [Undecided,New] | 09:51 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags controller https://review.openstack.org/128940 | 09:51 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/268932 | 09:51 |
| markus_z | bauzas: wrt reno: There is this ML post about DocImpact statements in Nova. I did a short analysis back then, maybe it helps: http://lists.openstack.org/pipermail/openstack-dev/2016-January/083738.html | 09:51 |
| *** pbrooko has joined #openstack-nova | 09:52 | |
| bauzas | markus_z: yeah I saw that thread but I missed the outcome | 09:52 |
| johnthetubaguy | BobBall: seems worth a try, that stuff always scared me | 09:53 |
| bauzas | markus_z: assuming you already know http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed | 09:53 |
| markus_z | bauzas: yepp, I know that, thanks. | 09:54 |
| pkholkin | johnthetubaguy, sdague, alaski: Hello guys! Please review these patches when you have time https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/new-oslodb-enginefacade, the bp seems to be implemented :) | 09:54 |
| bauzas | so, I said about DocImpact "some specific changes that have a DocImpact tag but require further action from an deployer perspective" | 09:54 |
| pkholkin | feel free to ask me and snikitin any questions | 09:54 |
| pkholkin | mdbooth: you too) | 09:55 |
| bauzas | markus_z: I agree with the thread which is that not all the DocImpact need a reno file | 09:55 |
| markus_z | bauzas: yepp, true | 09:55 |
| markus_z | bauzas: have to go to a meeting, will take a while, can talk about that later | 09:56 |
| *** markus_z is now known as markus_z_meeting | 09:56 | |
| *** e0ne has quit IRC | 09:57 | |
| bauzas | markus_z_meeting: sure, I have a few things | 09:57 |
| johnthetubaguy | markus_z: bauzas: those look like for most of those things we should add a reno note | 09:58 |
| bauzas | johnthetubaguy: fair to say | 09:58 |
| bauzas | johnthetubaguy: could you please also see which BPs are landed in M2 so we would need a reno file ? | 09:59 |
| bauzas | (meaning the ones impacting the REST API) | 09:59 |
| bauzas | johnthetubaguy: that should match the DocImpact | 09:59 |
| *** Jeffrey4l has quit IRC | 10:00 | |
| johnthetubaguy | bauzas: did that already, launchpad should be up to date | 10:02 |
| johnthetubaguy | bauzas: at least it was on friday just gone | 10:02 |
| johnthetubaguy | bauzas: totally just realised I have to be in london today, and well, I am not right now... | 10:03 |
| *** salv-orlando has joined #openstack-nova | 10:07 | |
| *** daemontool has quit IRC | 10:08 | |
| *** daemontool has joined #openstack-nova | 10:08 | |
| *** mdavidson has joined #openstack-nova | 10:08 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server actions sample tests https://review.openstack.org/269441 | 10:11 |
| *** daemontool has quit IRC | 10:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server PUT API sample tests https://review.openstack.org/269426 | 10:11 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for Flavor API sample tests https://review.openstack.org/243396 | 10:11 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Enable all extension for server API tests part-1 https://review.openstack.org/269533 | 10:11 |
| *** daemontool has joined #openstack-nova | 10:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: WIP-Enable all extension for server API sample tests https://review.openstack.org/269404 | 10:12 |
| *** thorst has joined #openstack-nova | 10:12 | |
| *** kbyrne has quit IRC | 10:12 | |
| *** salv-orlando has quit IRC | 10:13 | |
| snikitin | alex_xu: Alex, thanks for comments in instance tags patches! Glad to see that someone still review it :) | 10:13 |
| *** markvoelker has joined #openstack-nova | 10:16 | |
| *** daemontool has quit IRC | 10:17 | |
| *** ankit_ag has quit IRC | 10:17 | |
| *** daemontool has joined #openstack-nova | 10:17 | |
| *** ankit_ag has joined #openstack-nova | 10:17 | |
| openstackgerrit | Bob Ball proposed openstack/nova: XenAPI: Fix race on rotate_xen_guest_logs https://review.openstack.org/269536 | 10:17 |
| *** Marga_ has quit IRC | 10:18 | |
| *** amotoki has joined #openstack-nova | 10:18 | |
| *** Jeffrey4l has joined #openstack-nova | 10:18 | |
| *** daemontool has quit IRC | 10:19 | |
| *** daemontool has joined #openstack-nova | 10:19 | |
| *** thorst has quit IRC | 10:20 | |
| *** ociuhandu has quit IRC | 10:21 | |
| *** markvoelker has quit IRC | 10:21 | |
| dedery | hi all, can this fix https://review.openstack.org/#/c/262341 - Fix create snapshot failure on VMs with SRIOV - be reviewed? thanks! | 10:23 |
| *** aix has quit IRC | 10:23 | |
| *** aix has joined #openstack-nova | 10:26 | |
| *** jinxing has quit IRC | 10:29 | |
| *** Jeffrey4l has quit IRC | 10:31 | |
| *** atuvenie has quit IRC | 10:32 | |
| rgerganov | johnthetubaguy: hi, could you approve https://review.openstack.org/#/c/228778/ ? it has a lot of +1 and it's essentially a bug fix | 10:36 |
| *** daemontool has quit IRC | 10:38 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova: Ignore Cinder exceptions when terminating a volume's connection https://review.openstack.org/269172 | 10:38 |
| *** davideagnello has joined #openstack-nova | 10:40 | |
| *** daemontool has joined #openstack-nova | 10:42 | |
| *** shyama has quit IRC | 10:43 | |
| *** shyama has joined #openstack-nova | 10:44 | |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 10:44 |
| *** ildikov has quit IRC | 10:44 | |
| *** atuvenie has joined #openstack-nova | 10:44 | |
| *** markvoelker has joined #openstack-nova | 10:44 | |
| *** davideagnello has quit IRC | 10:46 | |
| *** aix has quit IRC | 10:46 | |
| dedery | ndipanov: thanks. I'll change according to the comment. I take it that you agree with the basic change from detach_interface to detach_pci_device? | 10:48 |
| *** dims has joined #openstack-nova | 10:48 | |
| *** rfolco has joined #openstack-nova | 10:48 | |
| dedery | ndipanov: I didn't see any risk there so i'm quite comfortable with this change. | 10:48 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Object: Make object target version check sorted https://review.openstack.org/269500 | 10:48 |
| gibi | johnthetubaguy: Hi! I lost couple of +2 form the versioned notification chain due to merge conflicts, could you please check them again? | 10:49 |
| *** markvoelker has quit IRC | 10:49 | |
| ndipanov | dedery, I think so - will look more closely before +2 ing though | 10:50 |
| *** shihanzhang has quit IRC | 10:50 | |
| *** vishalcdac07 has joined #openstack-nova | 10:50 | |
| *** shihanzhang has joined #openstack-nova | 10:51 | |
| gibi | nova cores: the versioned notification commit chain already has +2 from johnthetubaguy so It needs a second +2. Could you check it please? The chain starts here: https://review.openstack.org/#/c/247024/ | 10:52 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Split-network-plane-for-live-migration https://review.openstack.org/245005 | 10:53 |
| *** Marga_ has joined #openstack-nova | 10:53 | |
| *** shyama has quit IRC | 10:53 | |
| *** shyama has joined #openstack-nova | 10:54 | |
| *** ihrachys has joined #openstack-nova | 10:54 | |
| *** lyanchih has quit IRC | 10:55 | |
| *** yassine__ has quit IRC | 10:56 | |
| *** aix has joined #openstack-nova | 10:56 | |
| *** tdurakov has quit IRC | 10:56 | |
| *** vishalcdac07 has quit IRC | 10:57 | |
| *** erlon has joined #openstack-nova | 11:00 | |
| *** irenab has quit IRC | 11:02 | |
| *** irenab has joined #openstack-nova | 11:03 | |
| *** zakora has quit IRC | 11:04 | |
| *** zakora has joined #openstack-nova | 11:06 | |
| *** aysyd has joined #openstack-nova | 11:06 | |
| chhavi | ildikov | 11:07 |
| chhavi | check_attach: should also check for the attaching state | 11:08 |
| chhavi | in case multiattach there are chances of user sending the concurrent request | 11:09 |
| *** ildikov has joined #openstack-nova | 11:10 | |
| ildikov | chhavi: sorry, networking issues | 11:10 |
| alex_xu | snikitin: np :) | 11:10 |
| chhavi | ildikov: https://review.openstack.org/#/c/267587/8/nova/volume/cinder.py | 11:11 |
| chhavi | in this check_attach should also check for the attaching status | 11:11 |
| ildikov | chhavi: if you ask from multiattach perspective it doesn't matter | 11:14 |
| ildikov | it's either 'attached' or 'detached', but in case of multiattach both are valid | 11:14 |
| *** markvoelker has joined #openstack-nova | 11:14 | |
| *** Marga_ has quit IRC | 11:15 | |
| chhavi | it does, if the volume status is 'attaching' it will fail | 11:15 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter https://review.openstack.org/189279 | 11:15 |
| chhavi | consider if the user sends 2 simultaneous request then for the first request it will pass, and when the second request comes there are chances that volume status changed to 'attaching' then the second request will fail | 11:16 |
| ildikov | this is why it has to be 'available' or 'available' or 'in-use' | 11:16 |
| ildikov | so that check is correct | 11:16 |
| *** tdurakov has joined #openstack-nova | 11:16 | |
| ildikov | in all the other cases, like 'attaching' or error the check will fail | 11:17 |
| *** thorst has joined #openstack-nova | 11:17 | |
| *** zakora has quit IRC | 11:19 | |
| *** markvoelker has quit IRC | 11:20 | |
| *** sfinucan has joined #openstack-nova | 11:20 | |
| *** vishalcdac07 has joined #openstack-nova | 11:21 | |
| chhavi | ildikov: multiattach should allow 'attaching' state, because now the volume can be attached to multiple instances | 11:21 |
| *** jaosorior has quit IRC | 11:22 | |
| *** zakora has joined #openstack-nova | 11:22 | |
| ildikov | chhavi: as the outcome of the 'attaching' state can be error too IIRC I would not be 100% comfortable with allowing that | 11:22 |
| vishalcdac07 | what is current status of blueprint https://blueprints.launchpad.net/nova/+spec/bulk-delete-servers | 11:22 |
| *** jaosorior has joined #openstack-nova | 11:22 | |
| ildikov | chhavi: if we face with issues because of not allowing to attach in that state we can modify the check as optimization | 11:23 |
| chhavi | ildikov: we have seen this issue during our unit test while performing concurrent operations | 11:23 |
| chhavi | ildikov: is there a way to pull all the multiattach nova blueprint changes | 11:24 |
| chhavi | instead of pulling them separately | 11:24 |
| vishalcdac07 | It is showing the status "Complete" on launchpad but could not find respective API reference in http://developer.openstack.org/api-ref-compute-v2.1.html | 11:24 |
| *** thorst has quit IRC | 11:25 | |
| ildikov | chhavi: if you checkout the last patch in the chain it will download the full chain for you if that's the question | 11:25 |
| chhavi | ildikov: do u mean this one | 11:26 |
| chhavi | https://review.openstack.org/#/c/193134/ | 11:26 |
| ildikov | chhavi: it's the best to checkout this one: https://review.openstack.org/#/c/193135/ | 11:28 |
| ildikov | the last one is really in WIP | 11:28 |
| chhavi | ok let me try | 11:28 |
| *** rvasilets has joined #openstack-nova | 11:28 | |
| rvasilets | Hi, guys. please help me to find information about what nova compute, scheduler, conductor, api are doing. I mean i don't understand architecture of nova. Is it possible to understand without reading the code? | 11:31 |
| *** markvoelker has joined #openstack-nova | 11:32 | |
| rvasilets | I have found like this http://docs.openstack.org/kilo/config-reference/content/section_conductor.html But its to small information here | 11:32 |
| * danpb would suggest this architecture diagram, but is sceptical that it has ever helped anyone understand openstack http://docs.openstack.org/icehouse/training-guides/content/figures/5/a/figures/openstack-arch-havana-logical-v1.jpg | 11:32 | |
| *** pbrooko has quit IRC | 11:32 | |
| rvasilets | Ok. But diagram wouldn't help me to understand what is doing scheduler or how it works with queue | 11:34 |
| rvasilets | etc | 11:34 |
| rvasilets | As I see its old architecture from havana) | 11:35 |
| danpb | at a high level, the api service accepts REST requests from clients | 11:35 |
| danpb | it puts data into the database and/or RPC calls onto the message bus | 11:36 |
| *** ericksonsantos has joined #openstack-nova | 11:36 | |
| danpb | schedular handles RPC calls for booting VMs and decides which hosts to run them on | 11:36 |
| danpb | compute runs on each virtualization host and actually manages the hypervisor & vms on that host | 11:36 |
| *** markvoelker has quit IRC | 11:36 | |
| danpb | conductor is responsible for updating the DB on behalf of the compute service | 11:37 |
| *** ociuhandu has joined #openstack-nova | 11:37 | |
| *** gszasz has joined #openstack-nova | 11:38 | |
| *** e0ne has joined #openstack-nova | 11:38 | |
| *** cdent has joined #openstack-nova | 11:39 | |
| *** pbrooko has joined #openstack-nova | 11:41 | |
| *** otter768 has joined #openstack-nova | 11:41 | |
| alex_xu | gongysh: looks like just need rebase. I see the merge conflict from gerrit | 11:42 |
| *** smatzek has joined #openstack-nova | 11:43 | |
| markus_z_meeting | rvasilets: That one is a recent architecture diagram: http://docs.openstack.org/developer/nova/architecture.html | 11:44 |
| *** otter768 has quit IRC | 11:46 | |
| markus_z_meeting | rvasilets: Also some information here: http://docs.openstack.org/developer/nova/index.html#architecture-concepts | 11:48 |
| rvasilets | markus_z_meeting, looks like the last link is the best) | 11:49 |
| *** markus_z_meeting is now known as markus_z | 11:49 | |
| *** ljxiash_ has quit IRC | 11:50 | |
| markus_z | rvasilets: Just repeat this mantra multiple times a day: "there is no easy way to understand nova" ;) | 11:50 |
| markus_z | danpb: Do you see a chance to have a look at the libvirt AIO mode changes https://review.openstack.org/#/q/topic:bp/libvirt-aio-mode,n,z ? | 11:51 |
| markus_z | danpb: These are two (small) changes to an approved bp but they got little attention in the last weeks. | 11:51 |
| danpb | markus_z: ok | 11:52 |
| markus_z | thanks | 11:52 |
| *** irenab has quit IRC | 11:53 | |
| *** gmann_ has joined #openstack-nova | 11:53 | |
| markus_z | bauzas: wrt the DocImpact discussion we started, I personally don't have questions for that as I think I understood it. | 11:55 |
| *** jlanoux has quit IRC | 11:55 | |
| markus_z | bauzas: The mentioned reviews in the ML post happened in the transitioning phase when we introduce reno in Nova. | 11:56 |
| markus_z | bauzas: And IIUC some of them need a follow up patch with a reno file to be consistent in this release. | 11:56 |
| *** yassine__ has joined #openstack-nova | 11:57 | |
| *** irenab has joined #openstack-nova | 11:57 | |
| * alex_xu reminders api meeting in 2mins | 11:58 | |
| *** tdurakov has quit IRC | 12:00 | |
| *** irenab has quit IRC | 12:03 | |
| *** daemontool has quit IRC | 12:05 | |
| *** daemontool has joined #openstack-nova | 12:06 | |
| *** aix has quit IRC | 12:06 | |
| *** EinstCrazy has quit IRC | 12:06 | |
| *** gongysh has quit IRC | 12:07 | |
| *** baoli has quit IRC | 12:07 | |
| *** salv-orlando has joined #openstack-nova | 12:08 | |
| *** vivekd_ has joined #openstack-nova | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:11 | |
| *** vivekd has quit IRC | 12:11 | |
| *** vivekd_ is now known as vivekd | 12:11 | |
| *** vivekd_ has joined #openstack-nova | 12:12 | |
| *** salv-orlando has quit IRC | 12:13 | |
| *** vivekd has quit IRC | 12:16 | |
| *** vivekd_ is now known as vivekd | 12:16 | |
| *** markvoelker has quit IRC | 12:16 | |
| markus_z | dims: IIUC we don't use "fix comitted" anymore in bug reports. See https://bugs.launchpad.net/nova/+bug/1533678 for example. | 12:18 |
| openstack | Launchpad bug 1533678 in OpenStack Compute (nova) "Jenkins py34 gate failing with 'wmi is not defined' error" [Undecided,Fix released] | 12:18 |
| markus_z | dims: JFYI | 12:18 |
| *** aix has joined #openstack-nova | 12:18 | |
| dims | markus_z : ack | 12:19 |
| dims | thanks | 12:19 |
| markus_z | thanks for making it cleaner! | 12:19 |
| *** rgerganov has quit IRC | 12:19 | |
| openstackgerrit | Tomoki Sekiyama proposed openstack/nova: libvirt: Make behavior of os_require_quiesce consistent https://review.openstack.org/167819 | 12:19 |
| *** ljxiash has joined #openstack-nova | 12:22 | |
| *** ljxiash has quit IRC | 12:22 | |
| *** ljxiash has joined #openstack-nova | 12:22 | |
| dims | sdague : johnthetubaguy : for those dhcp lease failures, this review seems to help (https://review.openstack.org/#/c/268796/1/nova/cmd/dhcpbridge.py) the theory was that if the dhcp script was already running then dnsmasq then it does not get run (see "The script is not invoked concurrently" in http://www.thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html) | 12:23 |
| dims | sdague : johnthetubaguy : i still see occasional failures in say "gate-grenade-dsvm" which seems to be because the "new" nova-cpu recomputes the mac for some reason and tries to use that for dhcp_release and the mac that was used to lease the dhcp on the old side is not used for some reason | 12:24 |
| dims | so that's a valid failure | 12:26 |
| *** raildo-afk is now known as raildo | 12:27 | |
| *** tdurakov has joined #openstack-nova | 12:27 | |
| sdague | dims: nice find | 12:28 |
| sdague | so the theory is that dnsmasq will only ever run the script once, and the fact that it takes a while means things will get lost? | 12:29 |
| tdurakov | sdague, hi Sean, got time to discuss live-migration job? | 12:29 |
| openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266687 | 12:31 |
| *** takashin has left #openstack-nova | 12:31 | |
| sdague | tdurakov: in an hour or so | 12:31 |
| tdurakov | sdague, ok, I'll ping you in an hour | 12:32 |
| *** jacky-zhang has joined #openstack-nova | 12:32 | |
| *** ildikov has quit IRC | 12:35 | |
| *** pbrooko has quit IRC | 12:35 | |
| sdague | dims: that fix means there is still a race right, now it's just smaller? | 12:36 |
| *** pbrooko has joined #openstack-nova | 12:36 | |
| sdague | I almost wonder if we should replace dhcpbridge.py in config with a shell script that spins that off, to reduce the race further | 12:37 |
| *** lpetrut has quit IRC | 12:39 | |
| *** davideagnello has joined #openstack-nova | 12:42 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Make project_id optional in v2.1 urls https://review.openstack.org/233076 | 12:43 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications https://review.openstack.org/263788 | 12:45 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Generate doc for versioned notifications https://review.openstack.org/265151 | 12:45 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 12:45 |
| *** links has quit IRC | 12:46 | |
| *** davideagnello has quit IRC | 12:47 | |
| sdague | dims: is it actually dropping actions, or are they backing up? | 12:47 |
| *** thorst has joined #openstack-nova | 12:48 | |
| *** markvoelker has joined #openstack-nova | 12:49 | |
| dims | sdague : from what i can tell, it's dropping actions | 12:50 |
| *** houming has quit IRC | 12:50 | |
| dims | sdague : if you see my review, i just fork() to get the same effect | 12:50 |
| sdague | right | 12:50 |
| sdague | so the docs seem to indicate the activity will be queued up | 12:50 |
| *** haomaiwang has quit IRC | 12:51 | |
| *** mdnadeem has quit IRC | 12:51 | |
| sdague | could we print out sys.argv ? | 12:52 |
| *** mpavone has quit IRC | 12:52 | |
| dims | sdague : ack will update the review | 12:53 |
| sdague | I kind of wonder if we're scrubbing away content there | 12:53 |
| sdague | I bet the nova objects code changes here slowed things down a bit, which is why this got worse | 12:53 |
| dims | y and the switch from db to conductor too | 12:54 |
| *** markvoelker has quit IRC | 12:54 | |
| sdague | yeh, though that was a long time ago | 12:54 |
| dims | right | 12:54 |
| *** gmann_ has quit IRC | 12:54 | |
| sdague | yeh, I'm really curious now if we are getting a more complicated sys.argv | 12:55 |
| sdague | I think that needs to be a different patch than your fork patch | 12:56 |
| sdague | because we need to expose the collision | 12:56 |
| sdague | maybe even add a sleep in there to force it | 12:56 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Avoid blocking dnsmasq by forking off RPC calls https://review.openstack.org/268796 | 12:57 |
| *** ildikov has joined #openstack-nova | 12:58 | |
| *** mpavone has joined #openstack-nova | 13:01 | |
| *** mpavone has quit IRC | 13:01 | |
| *** jlanoux has joined #openstack-nova | 13:02 | |
| johnthetubaguy | alex_xu: sdague: sorry, was on a train so missed the api meeting (again), looks like good discussion, let me know if you need anything from me, especially around mitaka-2 | 13:02 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Trying to force failures in dhcp leases https://review.openstack.org/269616 | 13:02 |
| johnthetubaguy | bauzas: sorry, I am back online now, hows it looking so far? | 13:03 |
| *** irenab has joined #openstack-nova | 13:03 | |
| bauzas | johnthetubaguy: I'm just beginning to look at all the changes | 13:03 |
| alex_xu | johnthetubaguy: thanks :) | 13:03 |
| * bauzas working with Pomodora :) | 13:03 | |
| sdague | johnthetubaguy: mostly just https://review.openstack.org/233076 which is the no_project_id patch | 13:04 |
| sdague | PS21 has a pretty comprehensive set of notes on it | 13:04 |
| *** atuvenie has quit IRC | 13:06 | |
| *** lpetrut has joined #openstack-nova | 13:06 | |
| ccarmack | alex_xu: was the API meeting today? | 13:06 |
| eliqiao | ccarmack: just finished | 13:07 |
| alex_xu | ccarmack: yes, it just finished | 13:07 |
| johnthetubaguy | bauzas: :) | 13:07 |
| alex_xu | ccarmack: people agree to change rebuild | 13:07 |
| johnthetubaguy | ndipanov: that PCI bug, I guess we should try get that into mitaka-2 if we can, given its a nasty regression? | 13:07 |
| alex_xu | ccarmack: it probably need spec also, but I guess that will be quick update. | 13:07 |
| alex_xu | s/need spec/need update spec/ | 13:07 |
| ccarmack | alex_xu: so, when someone does rebuild, they need to change the description? | 13:08 |
| johnthetubaguy | bauzas: I am listing blockers in the usual location in here: https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking | 13:08 |
| alex_xu | ccarmack: if the name changed, I guess the meaning of description will be changed also. in that case, I think user have requirement change the description when name changed. | 13:08 |
| alex_xu | ccarmack: does sounds make sense? | 13:09 |
| johnthetubaguy | cdent: are you OK with being the cross project liaison, I added you into the wiki, I think | 13:09 |
| *** mdnadeem has joined #openstack-nova | 13:10 | |
| *** ducttape_ has joined #openstack-nova | 13:10 | |
| *** markvoelker has joined #openstack-nova | 13:10 | |
| *** daemontool_ has joined #openstack-nova | 13:10 | |
| sfinucan | markus_z: got a moment? | 13:10 |
| ildikov | jaypipes: good morning | 13:10 |
| markus_z | sfinucan: one sec, writing a review comment to your vnc change :) | 13:10 |
| *** daemontool has quit IRC | 13:11 | |
| alex_xu | sdague: just +2 for project_id | 13:11 |
| sfinucan | markus_z: If it's about 'novnc.py' then we can talk here. If not, carry on ;) | 13:11 |
| *** lpetrut1 has joined #openstack-nova | 13:11 | |
| ildikov | jaypipes: I fixed your comment and I hope finally Jenkins will be nice to me too, the patch ran into a few known issues | 13:11 |
| *** lpetrut has quit IRC | 13:11 | |
| *** lpetrut1 is now known as lpetrut | 13:11 | |
| markus_z | sfinucan: It's the "vnc.py". What's up? | 13:11 |
| ccarmack | alex_xu: I'm not sure, maybe the name changes to "myinstance-rebuild" or something | 13:12 |
| cdent | johnthetubaguy: yup | 13:12 |
| sfinucan | markus_z: quick one. You suggested also centralizing these options https://github.com/openstack/nova/blob/master/nova/cmd/novncproxy.py | 13:12 |
| markus_z | sfinucan: ah, yes, I remember | 13:12 |
| sfinucan | what about these? https://github.com/openstack/nova/blob/master/nova/cmd/novnc.py | 13:12 |
| markus_z | sfinucan: uaah, what's this again. Let me check it. | 13:13 |
| *** alejandrito has joined #openstack-nova | 13:14 | |
| johnthetubaguy | cdent: awesome thank you, I noticed you made the meeting last week, thanks for that :) | 13:14 |
| *** markvoelker has quit IRC | 13:15 | |
| cdent | johnthetubaguy: yup, I've put it in my list of things to make a habit | 13:15 |
| alex_xu | ccarmack: if the new name is meanful, the description should be changed to match the new name. that is the case I thought | 13:15 |
| cdent | johnthetubaguy: and have openstack-specs in my review queue | 13:15 |
| alex_xu | s/meanful/meaningful/? | 13:15 |
| johnthetubaguy | cdent: sweet, let me know if you need anything for that, I will try do the reverse also :) | 13:15 |
| cdent | roger, will do | 13:16 |
| ccarmack | alex_xu: ok | 13:16 |
| alex_xu | ccarmack: if we didn't support change that in rebuild, user need another request to update description | 13:16 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter https://review.openstack.org/189279 | 13:17 |
| markus_z | sfinucan: These options are common to all proxys: https://github.com/openstack/nova/blob/master/nova/cmd/baseproxy.py | 13:17 |
| ccarmack | alex_xu, ok, but we are requiring the user to change the description, right? | 13:17 |
| markus_z | sfinucan: They are in a module which suggest they are solely for vnc, but they aren't. | 13:17 |
| openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 13:18 |
| markus_z | sfinucan: I would expect them in a "nova/conf/proxy.py" module or similar | 13:18 |
| alex_xu | ccarmack: optional to change | 13:18 |
| *** ekarlso has quit IRC | 13:18 | |
| *** ekarlso has joined #openstack-nova | 13:18 | |
| ccarmack | alex_xu: ah, now I understand | 13:18 |
| sfinucan | markus_z: Sounds about right | 13:18 |
| markus_z | sfinucan: cool :) | 13:19 |
| alex_xu | ccarmack: thanks | 13:19 |
| sfinucan | I won't move those now (there are enough items in the backlog) but I can put it into the 'for consideration' section? | 13:19 |
| sfinucan | i.e. to move them | 13:19 |
| ccarmack | alex_xu, johnthetubaguy: Is there a code freeze tomorrow for non-priority patches? | 13:19 |
| markus_z | sfinucan: What would be the reasoning for that? | 13:19 |
| markus_z | sfinucan: Ah, you mean to its own [group]? | 13:20 |
| alex_xu | ccarmack: Thursday | 13:20 |
| sfinucan | markus_z: yes, exactly | 13:20 |
| alex_xu | ccarmack: we still have chance to cache the freeze | 13:20 |
| jaypipes | ildikov: k, will look into it. | 13:20 |
| sfinucan | and into 'nova/conf/proxy.py' instead of 'nova/conf/vnc.py' | 13:20 |
| alex_xu | as it isn't big change | 13:20 |
| jaypipes | ildikov: and good morning to you :) | 13:20 |
| openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 13:20 |
| ildikov | jaypipes: cool, tnx much | 13:20 |
| markus_z | sfinucan: Yes, that's fair. Just add it to the etherpad and leave a reasoning. | 13:21 |
| sdague | dims: if you are busy, I can also crank out the testing patch, I'm really curious now | 13:21 |
| ildikov | jaypipes: well, after 4 hours of sleep it still feels like morning :) | 13:21 |
| jaypipes | ildikov: :) | 13:21 |
| ccarmack | alex_xu: ok, I'll upload the spec update today | 13:21 |
| alex_xu | ccarmack: thanks | 13:21 |
| alex_xu | ccarmack: ping me if that ready | 13:21 |
| ildikov | jaypipes: time schedule is not really my strong skill nowadays... | 13:21 |
| ccarmack | alex_xu: starting now | 13:22 |
| markus_z | sfinucan: Let me know if my comment here makes sense to you: https://review.openstack.org/#/c/266273/2 | 13:22 |
| alex_xu | ccarmack: gmann suggest add other bit about update will return description | 13:22 |
| jaypipes | ildikov: I hear ya. | 13:22 |
| ccarmack | alex_xu: yes, I didn't know about that when I wrote the spec | 13:23 |
| ndipanov | johnthetubaguy, sorry was away | 13:23 |
| ndipanov | so there are 2 pci bugs atm | 13:23 |
| sfinucan | markus_z: It does, yes. I'm still not entirely sure what that 'xvpvncproxy_base_url' option is really for, however. | 13:23 |
| *** rgerganov has joined #openstack-nova | 13:23 | |
| sfinucan | which means I probably shouldn't be writing the docs for it, but oh well :) | 13:23 |
| sfinucan | I'll try find the owner of that code and ping them for clarification | 13:23 |
| ndipanov | one that was there but got exposed by the PF code, and one that we introduced | 13:23 |
| markus_z | sfinucan: That's the URL each compute node returns when the REST API call happens. | 13:24 |
| ndipanov | both of them are killing the PCI CI | 13:24 |
| ndipanov | johnthetubaguy, I'll post a patch for both today - yes it would be awesome to get those in m-2 | 13:24 |
| *** shakamunyi has joined #openstack-nova | 13:24 | |
| markus_z | sfinucan: http://developer.openstack.org/api-ref-compute-v2.1.html#getSPICEConsole | 13:24 |
| johnthetubaguy | ndipanov: cools, I added one of those patches to here: https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking will try track them, the best we can | 13:25 |
| markus_z | sfinucan: The token is added by the nova-console-auth service | 13:25 |
| openstackgerrit | Sean Dague proposed openstack/nova: Make project_id optional in v2.1 urls https://review.openstack.org/233076 | 13:26 |
| sdague | alex_xu: there was a reno issue, fixed | 13:26 |
| markus_z | sfinucan: The default which has the localhost address only makes sense when you have an all-in-one machine and try to establish a SPICE connection also on that machine. | 13:26 |
| alex_xu | sdague: oops..my fault | 13:27 |
| sdague | gmann: how does - https://review.openstack.org/#/c/243396 work with the legacy v2 code? | 13:27 |
| dims | sdague : sure, please go ahead | 13:27 |
| ndipanov | johnthetubaguy, cool | 13:27 |
| *** ducttape_ has quit IRC | 13:27 | |
| dims | sdague : i had this up if you want to weak that (https://review.openstack.org/#/c/269616/) | 13:28 |
| dims | s/weak/tweak/ | 13:28 |
| ansiwen | rgerganov: hi | 13:28 |
| rgerganov | ansiwen, hi | 13:28 |
| openstackgerrit | Bo Chi proposed openstack/nova: Disassociate floating ip when remove fixed ip https://review.openstack.org/257339 | 13:28 |
| flip214 | I'd appreciate some feedback (and/or +2's ;) on https://review.openstack.org/#/c/256292. All dependencies are already merged, and this is small, too. | 13:28 |
| *** ivase has joined #openstack-nova | 13:29 | |
| *** ivase has joined #openstack-nova | 13:29 | |
| ansiwen | rgerganov: there is a CI problem with https://review.openstack.org/#/c/168024 | 13:30 |
| *** dslev has joined #openstack-nova | 13:30 | |
| ansiwen | rgerganov: is it a glitch or a real problem? | 13:30 |
| rgerganov | ansiwen, yeah, I think it is intermittent, waiting for the next run | 13:30 |
| ansiwen | rgerganov: has it been retriggered? | 13:30 |
| sfinucan | markus_z: Hmmm. Looking at this documentation from IBM, it seems _host + _port + a path => _base_url https://goo.gl/UlmabQ | 13:30 |
| *** edmondsw has joined #openstack-nova | 13:30 | |
| markus_z | sfinucan: And lastly, one of the many possible REST API consumers for that is Horizon, which happens to be usually on the same node as the vncproxy service. Which means "localhost" is a valid value there. | 13:30 |
| openstackgerrit | Sean Dague proposed openstack/nova: DNM: see what dhcp args look like with collisions https://review.openstack.org/269626 | 13:31 |
| ansiwen | rgerganov: not sure if "vmware-recheck-patch" works, never saw that | 13:31 |
| rgerganov | ansiwen, vmware-recheck-patch should work | 13:31 |
| sdague | dims: ok, I did a thing a little different didn't realize that ws up | 13:31 |
| sfinucan | In which case, back to why that's not autogenerated instead. I don't want to state something I don't know to be true | 13:31 |
| ansiwen | rgerganov: ok, cool. is it possible to the the queue? | 13:32 |
| *** ankit_ag has quit IRC | 13:33 | |
| markus_z | sfinucan: that link is odd, it wants me to download a html, which I'd rather not do. | 13:33 |
| ildikov | jaypipes: and the tests are green \o/, I hope I have at least a few hours before the next merge conflict... :) | 13:33 |
| rgerganov | ansiwen, the CI queue is not publicly visible | 13:33 |
| ansiwen | rgerganov: ok | 13:33 |
| sfinucan | markus_z: Yeah, I don't know what's happening there :S (Found via 'xvpvncproxy_host site:ibm.com' search) | 13:34 |
| sfinucan | But the main point is the two are _very_ closely related and I don't get why the distinction was necessary. Perhaps different services use different values or something... | 13:35 |
| markus_z | sfinucan: http://ibm.co/1ZJO0E2 (some day in the future we will provide permalinks with slugs... hope dies last) | 13:37 |
| markus_z | sfinucan: ok, got it. Yeah, the setup described there is valid but not the only possible one. | 13:38 |
| tdurakov | sdague, are you around? | 13:38 |
| sdague | tdurakov: yeh, what's up? | 13:38 |
| tdurakov | sdague, could you review https://review.openstack.org/#/c/267669/ | 13:39 |
| bauzas | johnthetubaguy: FWIW just created a new etherpad for checking all patches needing a reno file https://etherpad.openstack.org/p/nova-milestone-reno | 13:41 |
| bauzas | johnthetubaguy: now, I'll look at each of those and see if a reno file is there | 13:42 |
| *** otter768 has joined #openstack-nova | 13:42 | |
| *** vivekd_ has joined #openstack-nova | 13:42 | |
| *** vivekd has quit IRC | 13:45 | |
| *** vivekd_ is now known as vivekd | 13:45 | |
| sdague | tdurakov: +2 | 13:45 |
| *** ababich has joined #openstack-nova | 13:45 | |
| *** EinstCrazy has joined #openstack-nova | 13:46 | |
| tdurakov | thank you sdague, so this should work, right?) | 13:46 |
| sfinucan | markus_z: OK, I've taken the middle ground and said which options are related but not why. If you (or anyone else) has input here I'm good with either suggestions or you just changing it yourself :) | 13:46 |
| sdague | tdurakov: I think so | 13:46 |
| sfinucan | seems safer than saying something I don't know to be true | 13:46 |
| sdague | I don't seen Andreas on right now, we should circle with him | 13:46 |
| *** rvasilets has left #openstack-nova | 13:46 | |
| johnthetubaguy | bauzas: cool, thanks | 13:47 |
| tdurakov | sdague, acked, will ping him in openstack-infra | 13:47 |
| *** otter768 has quit IRC | 13:47 | |
| bauzas | johnthetubaguy: so, I'm just iterating over those and creating patches if needed | 13:47 |
| bauzas | markus_z: you could be interested in ^ | 13:47 |
| *** jaosorior has quit IRC | 13:48 | |
| *** jaosorior has joined #openstack-nova | 13:48 | |
| *** daemontool__ has joined #openstack-nova | 13:49 | |
| *** daemontool_ has quit IRC | 13:50 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/266160 | 13:51 |
| *** haomaiwang has joined #openstack-nova | 13:51 | |
| *** markvoelker has joined #openstack-nova | 13:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/269645 | 13:52 |
| *** idonotknow has quit IRC | 13:52 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Reno for Xen rename https://review.openstack.org/269647 | 13:53 |
| *** daemontool__ is now known as daemontool | 13:54 | |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Make sure that we always have a parent_addr set https://review.openstack.org/269650 | 13:54 |
| ndipanov | lennyb, any luck testing my patch yesterday? | 13:54 |
| ndipanov | lennyb, I realize there is another failure | 13:54 |
| *** burgerk has joined #openstack-nova | 13:55 | |
| *** liusheng has quit IRC | 13:55 | |
| ababich | sdague: Hi, couldn't you look at https://review.openstack.org/#/c/255855/3 , have a little comment for you | 13:56 |
| tdurakov | PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski jlanoux yuntongjin mdbooth kashyap kmartin claudiub mikal live-migration meeting will start in 4 minutes | 13:56 |
| *** Marga_ has joined #openstack-nova | 13:57 | |
| *** markvoelker has quit IRC | 13:57 | |
| *** mdrabe has joined #openstack-nova | 13:57 | |
| *** nelsnelson has joined #openstack-nova | 13:58 | |
| *** amotoki has quit IRC | 13:58 | |
| sdague | ababich: ok, commented again | 13:58 |
| *** markvoelker has joined #openstack-nova | 14:00 | |
| *** nelsnels_ has quit IRC | 14:00 | |
| ababich | sdague: Thanks! Will add a proper comment now | 14:00 |
| *** markvoelker_ has joined #openstack-nova | 14:01 | |
| *** EinstCrazy has quit IRC | 14:02 | |
| *** efoley_ has joined #openstack-nova | 14:02 | |
| *** EinstCrazy has joined #openstack-nova | 14:02 | |
| *** efoley has quit IRC | 14:04 | |
| *** markvoelker has quit IRC | 14:05 | |
| *** daemontool has quit IRC | 14:06 | |
| *** daemontool has joined #openstack-nova | 14:07 | |
| *** rlrossit has joined #openstack-nova | 14:07 | |
| *** irenab_ has joined #openstack-nova | 14:07 | |
| *** ccesario has joined #openstack-nova | 14:08 | |
| *** irenab has quit IRC | 14:08 | |
| *** irenab_ is now known as irenab | 14:08 | |
| *** annegentle has joined #openstack-nova | 14:09 | |
| *** doug-fish has joined #openstack-nova | 14:10 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (1) https://review.openstack.org/255512 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Clean up nova/conf/scheduler.py https://review.openstack.org/255383 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (2) https://review.openstack.org/255513 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (3) https://review.openstack.org/255514 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (4) https://review.openstack.org/255515 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (5) https://review.openstack.org/255516 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (6) https://review.openstack.org/255517 | 14:10 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add better help text to scheduler options (7) https://review.openstack.org/255518 | 14:10 |
| *** EinstCrazy has quit IRC | 14:10 | |
| *** EinstCrazy has joined #openstack-nova | 14:10 | |
| *** akshai has joined #openstack-nova | 14:10 | |
| *** ctrath has joined #openstack-nova | 14:11 | |
| *** shyama has quit IRC | 14:13 | |
| *** shyama has joined #openstack-nova | 14:14 | |
| *** tpatzig has joined #openstack-nova | 14:14 | |
| markus_z | bauzas: I was afk, which one could be interesting for me? | 14:15 |
| *** shyama has quit IRC | 14:15 | |
| bauzas | markus_z: since we discussed on reno, I created an etherpad for tracking which patches need a reno file | 14:15 |
| bauzas | https://etherpad.openstack.org/p/nova-milestone-reno | 14:16 |
| *** vivekd has quit IRC | 14:16 | |
| *** shyama has joined #openstack-nova | 14:16 | |
| bauzas | I'm just adding new changes in a fix_reno_13b2 branch | 14:16 |
| *** vivekd has joined #openstack-nova | 14:16 | |
| *** lucasagomes is now known as lucas-afk | 14:16 | |
| *** EinstCrazy has quit IRC | 14:17 | |
| openstackgerrit | Anna Babich proposed openstack/python-novaclient: Functional tests for flavors with public and non-public access https://review.openstack.org/260066 | 14:17 |
| markus_z | bauzas: ah, ok, I take a quick look | 14:17 |
| edleafe | alex_xu: sorry I missed the meeting. Too early for me! But I've read the scrollback, and will help review the patches you mentioned. | 14:17 |
| *** EinstCrazy has joined #openstack-nova | 14:18 | |
| tpatzig | johnthetubaguy: as already shortly discussed in the last meeting: https://review.openstack.org/#/c/267673/ | 14:18 |
| *** EinstCrazy has quit IRC | 14:18 | |
| openstackgerrit | Chuck Carmack proposed openstack/nova-specs: REST API changes for user settable server description https://review.openstack.org/269664 | 14:18 |
| tpatzig | i can also move it to newton | 14:18 |
| *** EinstCrazy has joined #openstack-nova | 14:18 | |
| alex_xu | edleafe: thanks | 14:18 |
| markus_z | bauzas: If you find time, the "scheduler config options help text" series looks ready to merge from my point of view. https://review.openstack.org/#/c/255518/5 | 14:19 |
| ccarmack | alex_xu: updated spec ^ | 14:19 |
| bauzas | heh :) | 14:19 |
| alex_xu | ccarmack: checking now | 14:19 |
| *** ljxiash has quit IRC | 14:19 | |
| *** ljxiash_ has joined #openstack-nova | 14:19 | |
| bauzas | markus_z: like I said previously, I'm mostly just have time for the milestone cut, not for other reviews honestly :( | 14:20 |
| *** Daisy has joined #openstack-nova | 14:20 | |
| markus_z | bauzas: totally fair | 14:20 |
| bauzas | markus_z: but that's something we can review f2f during the midcycle | 14:20 |
| bauzas | markus_z: I'd love to help those patches be merged quickly | 14:20 |
| markus_z | milestone cut has priority, just wanted to make you aware of it | 14:21 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Make sure that we always have a parent_addr set https://review.openstack.org/269191 | 14:22 |
| bauzas | markus_z: you will be at the midcycle ? | 14:22 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Reno for lock policy https://review.openstack.org/269667 | 14:22 |
| markus_z | bauzas: yepp, finally got the approval :) | 14:22 |
| bauzas | \o/ | 14:23 |
| *** jichen has quit IRC | 14:23 | |
| bauzas | markus_z: so, don't worry, we could just take time to do a review time | 14:23 |
| *** baoli has joined #openstack-nova | 14:23 | |
| markus_z | bauzas: yepp, cool | 14:23 |
| dims | sdague : no worries | 14:25 |
| openstackgerrit | Daniel Berrange proposed openstack/os-vif: Add formal classes for each of the types of VIF backend config https://review.openstack.org/269670 | 14:27 |
| openstackgerrit | Daniel Berrange proposed openstack/os-vif: Fix definition of subnet object to not be untyped strings https://review.openstack.org/269671 | 14:27 |
| *** annegentle has quit IRC | 14:27 | |
| alex_xu | sdague: johnthetubaguy would you like take a look at this https://review.openstack.org/269664 it adds one more bit enable update description in rebuild action. As I think if the name is changed when rebuild, a meaningful description which matching new name may required by user | 14:27 |
| *** pratikmallya has joined #openstack-nova | 14:27 | |
| ccarmack | alex_xu: does the spec look ok? | 14:27 |
| ansiwen | rgerganov: can you explain teruhisa, why you wanted to merge your patch first? | 14:27 |
| sdague | alex_xu: honestly, I'd leave that up to the user | 14:27 |
| *** diogogmt has quit IRC | 14:28 | |
| alex_xu | ccarmack: yea, looks like ok, I just add one comment if we can make more clear usecase for it | 14:28 |
| *** baoli_ has joined #openstack-nova | 14:28 | |
| sdague | alex_xu: yeh, your wording is good | 14:28 |
| sdague | I'm reading now, and it does make it more clear | 14:28 |
| markus_z | bauzas: The git queries you did in the milestone etherpad start from the mitaka-1 milestone, right? | 14:28 |
| alex_xu | sdague: ok, thanks :) | 14:28 |
| *** vladikr has joined #openstack-nova | 14:29 | |
| bauzas | markus_z: yup | 14:29 |
| *** pratikma_ has joined #openstack-nova | 14:29 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: WIP: network: add helper module for converting to os-vif object model https://review.openstack.org/269672 | 14:29 |
| markus_z | bauzas: https://review.openstack.org/#/c/165750/ for example was merged until mitaka-1 but doesn't have a reno file | 14:29 |
| *** daemontool_ has joined #openstack-nova | 14:30 | |
| *** [1]Thelo has joined #openstack-nova | 14:30 | |
| markus_z | bauzas: I would expect a reno file with a follow up patch now, or is that wrong? | 14:31 |
| *** baoli has quit IRC | 14:31 | |
| *** mriedem_away is now known as mriedem | 14:31 | |
| *** daemontool has quit IRC | 14:31 | |
| *** pbrooko has quit IRC | 14:31 | |
| bauzas | markus_z: meh | 14:32 |
| *** pratikmallya has quit IRC | 14:32 | |
| bauzas | markus_z: does that sound my revision range is wrong ? | 14:32 |
| rlrossit | not sure if someone more knowledgable than I can answer, but... is there any reason why numa_topology in the compute node object (https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L74) is a string and not a NUMATopology (or NUMATopologyLimits) object? | 14:32 |
| bauzas | rlrossit: old story | 14:32 |
| bauzas | rlrossit: tl;dr it was a mistake | 14:33 |
| *** Thelo has quit IRC | 14:33 | |
| *** [1]Thelo is now known as Thelo | 14:33 | |
| ndipanov | bauzas, no that's not true | 14:33 |
| ndipanov | because it's quite difficult to migrate fields in objects | 14:33 |
| markus_z | bauzas: It would be right if the changes which merged before mitaka-1 had all the proper reno files I guess. | 14:33 |
| ndipanov | before we have objects used everywhere for a certain model | 14:33 |
| alex_xu | ccarmack: would you mind update that a little bit, that goods for other review to understand the use-case | 14:33 |
| rlrossit | ndipanov: so did NUMATopology come after numa_topology? | 14:33 |
| ccarmack | alex_xu: yup, doing it now | 14:34 |
| rlrossit | and the obj_make_compatible of that would be a nightmare? | 14:34 |
| ndipanov | rlrossit, so it came before all code used objects to access compute_node | 14:34 |
| markus_z | bauzas: Right now it excludes those and the ops don't get any notification for them | 14:34 |
| alex_xu | ccarmack: thanks | 14:34 |
| *** daemontool_ has quit IRC | 14:34 | |
| bauzas | markus_z: it was probably down under the radar when I looked at those | 14:34 |
| *** daemontool_ has joined #openstack-nova | 14:34 | |
| openstackgerrit | Chuck Carmack proposed openstack/nova-specs: REST API changes for user settable server description https://review.openstack.org/269664 | 14:35 |
| ndipanov | and as you know rlrossit we can't easily change the type of fields | 14:35 |
| ndipanov | on objects | 14:35 |
| ndipanov | so put those 2 together | 14:35 |
| rlrossit | ndipanov: +1 yup | 14:35 |
| ccarmack | sdague, alex_xu ^ | 14:35 |
| rlrossit | ndipanov: so should I add a note in there saying 1) why it's a string, and 2) put a TODO to change that over to numa_topology if ComputeNode ever makes its way to 2.0? | 14:35 |
| ndipanov | rlrossit, yeah taht would make sense | 14:36 |
| markus_z | bauzas: So maybe just a new section with the range of mitaka-0 to mitaka-1? | 14:36 |
| bauzas | ndipanov: well, I remember that story you know | 14:36 |
| alex_xu | ccarmack: done | 14:36 |
| openstackgerrit | Anna Babich proposed openstack/python-novaclient: Functional tests for os-services https://review.openstack.org/255855 | 14:36 |
| bauzas | ndipanov: it doesn't really explain why we provided a string initially | 14:36 |
| bauzas | but that's old story | 14:36 |
| *** daemontool_ has quit IRC | 14:37 | |
| ndipanov | bauzas, what are you talking about? string is a good decision (as opposed to a different table) | 14:37 |
| *** pbrooko has joined #openstack-nova | 14:37 | |
| ndipanov | what is bad that it's a string field and not an object field | 14:37 |
| ccarmack | mriedem wants me to update the change log, one more update | 14:37 |
| rlrossit | ndipanov: I would expect to see a DictField | 14:37 |
| *** daemontool_ has joined #openstack-nova | 14:37 | |
| bauzas | ndipanov: a string in the DB model is fine, a string as an object field is another point | 14:38 |
| ndipanov | right | 14:38 |
| *** teju has quit IRC | 14:38 | |
| *** vivekd_ has joined #openstack-nova | 14:39 | |
| *** baoli_ has quit IRC | 14:39 | |
| ndipanov | that might have been because the first version of the patches was not using objects at all | 14:39 |
| ndipanov | that may have been a mistake... | 14:40 |
| openstackgerrit | Jacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli https://review.openstack.org/266687 | 14:40 |
| ndipanov | and by the time we realized that's a mistake - object changes were merged already | 14:41 |
| *** busterswt has joined #openstack-nova | 14:41 | |
| *** vivekd has quit IRC | 14:42 | |
| *** vivekd_ is now known as vivekd | 14:42 | |
| rlrossit | ndipanov: is that field supposed to be a NUMATopology, or a NUMATopologyLimits? I'm changing over https://review.openstack.org/#/c/265521/7/nova/tests/unit/compute/test_resource_tracker.py and it's yelling at me saying numa_topology is coming across as NUMATopologyLimits | 14:42 |
| *** davideagnello has joined #openstack-nova | 14:43 | |
| ndipanov | NUMATopology | 14:43 |
| *** pbrooko_ has joined #openstack-nova | 14:43 | |
| mriedem | ccarmack: so you're just updating the spec to add the rebuilt api - i'm assuming that came up when reviewing the actual code change? | 14:44 |
| markus_z | mriedem: Would you maybe take a look at the libvirt AIO mode changes? https://review.openstack.org/#/q/topic:bp/libvirt-aio-mode,n,z | 14:44 |
| ccarmack | mriedem: yes | 14:44 |
| mriedem | markus_z: i'll add it to the queue | 14:45 |
| ccarmack | mriedem: I'm ready to commit the spec with the revision table update | 14:45 |
| markus_z | thanks | 14:46 |
| *** burt has joined #openstack-nova | 14:46 | |
| *** pbrooko has quit IRC | 14:46 | |
| *** PaulMurray has joined #openstack-nova | 14:46 | |
| *** thangp has joined #openstack-nova | 14:47 | |
| rlrossit | dims: I don't want to be pushy, but could you take a look at https://review.openstack.org/#/c/266960/ and let me know what you think? I want to use that as reference for pushing Neutron on it, and I want to get it in M still | 14:47 |
| PaulMurray | tdurakov, thanks | 14:47 |
| tdurakov | PaulMurray, np | 14:47 |
| openstackgerrit | Chuck Carmack proposed openstack/nova-specs: REST API changes for user settable server description https://review.openstack.org/269664 | 14:48 |
| *** davideagnello has quit IRC | 14:48 | |
| ccarmack | mriedem, alex_xu ^ | 14:48 |
| *** jacky-zhang has quit IRC | 14:48 | |
| *** mrkz has joined #openstack-nova | 14:49 | |
| *** jacky-zhang has joined #openstack-nova | 14:50 | |
| *** notmorgan has quit IRC | 14:51 | |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Add note to ComputeNode.numa_topology https://review.openstack.org/269685 | 14:52 |
| rlrossit | ndipanov: ^ let me know what you think | 14:52 |
| *** ducttape_ has joined #openstack-nova | 14:53 | |
| ndipanov | rlrossit, looks good | 14:54 |
| *** eharney has quit IRC | 14:54 | |
| *** diogogmt has joined #openstack-nova | 14:54 | |
| *** knikolla has joined #openstack-nova | 14:55 | |
| alex_xu | ccarmack: yea, thanks mriedem point that out. | 14:55 |
| * alex_xu end the work of day, will review the code tomorrow | 14:55 | |
| *** esracelik has quit IRC | 14:56 | |
| bauzas | rlrossit: +2'd, mriedem you could be interested in this nit https://review.openstack.org/#/c/269685/1 | 14:58 |
| mriedem | -1000 | 14:58 |
| bauzas | oh snap | 14:58 |
| rlrossit | wow everyone loves it | 14:58 |
| bauzas | jinxed again by mriedem | 14:58 |
| bauzas | I have a curse on me ! | 14:58 |
| *** akshai has quit IRC | 14:59 | |
| *** jacky-zhang has quit IRC | 14:59 | |
| *** akshai has joined #openstack-nova | 15:00 | |
| *** notmorgan has joined #openstack-nova | 15:00 | |
| *** notmorgan has quit IRC | 15:01 | |
| *** notmorgan has joined #openstack-nova | 15:01 | |
| *** notmorgan has quit IRC | 15:01 | |
| *** notmorgan has joined #openstack-nova | 15:01 | |
| mriedem | ndipanov: +2 on https://review.openstack.org/#/c/269191/ | 15:02 |
| ildikov | ndipanov: hi. friendly reminder: https://review.openstack.org/#/c/193134/ :) | 15:02 |
| mriedem | with grumblings inline about why object fields that are nullable=True aren't also default=None | 15:02 |
| *** baoli has joined #openstack-nova | 15:03 | |
| *** tdurakov has quit IRC | 15:03 | |
| *** Daisy has quit IRC | 15:03 | |
| *** baoli has quit IRC | 15:03 | |
| *** pumaranikar has joined #openstack-nova | 15:03 | |
| *** annegentle has joined #openstack-nova | 15:04 | |
| *** baoli has joined #openstack-nova | 15:04 | |
| mriedem | dims: rlrossit: question about object fields, is there any good reason why we shouldn't make the default value on a field None when nullable=True? | 15:04 |
| *** nkrinner has quit IRC | 15:04 | |
| mriedem | to avoid lazy-load failures? | 15:04 |
| *** annegent_ has joined #openstack-nova | 15:04 | |
| *** mragupat has joined #openstack-nova | 15:04 | |
| mriedem | jaypipes: ^ | 15:05 |
| *** tdurakov has joined #openstack-nova | 15:06 | |
| *** baoli has quit IRC | 15:07 | |
| *** spinderbok has joined #openstack-nova | 15:07 | |
| *** rgerganov has quit IRC | 15:07 | |
| *** spinderbok has quit IRC | 15:07 | |
| *** baoli has joined #openstack-nova | 15:08 | |
| *** annegentle has quit IRC | 15:08 | |
| bauzas | mriedem: I remember some convo with dansmith | 15:10 |
| bauzas | mriedem: about defaulting attributes | 15:10 |
| mriedem | uh oh, you invoked his name who must not be spoken while on vacatoin | 15:11 |
| bauzas | mriedem: IIRC, he was pretty against defaulting if not needed | 15:11 |
| *** dslev has quit IRC | 15:11 | |
| mriedem | bauzas: i assume there is a good reason, i'd just like to know what it is | 15:11 |
| bauzas | mriedem: oh man, hopefully I didn't said that in front of a mirror 5 times | 15:11 |
| mriedem | it's 3 times in a dark bathroom | 15:11 |
| mriedem | so you're probably ok | 15:12 |
| bauzas | meh | 15:12 |
| *** diogogmt has quit IRC | 15:12 | |
| bauzas | anyway, I'd bet the answer is in the logs :) | 15:12 |
| *** daemontool_ has quit IRC | 15:12 | |
| bauzas | that helps, heh ? | 15:12 |
| *** eharney has joined #openstack-nova | 15:13 | |
| bauzas | nah, enough kidding, IIRC it's because nullifying a field doesn't mean it's set | 15:13 |
| bauzas | it's just for coercing | 15:13 |
| *** tdurakov has quit IRC | 15:13 | |
| ndipanov | mriedem, thanks! | 15:13 |
| *** vivekd has quit IRC | 15:13 | |
| *** tonytan4ever has joined #openstack-nova | 15:14 | |
| *** PaulMurray has quit IRC | 15:14 | |
| *** PaulMurray has joined #openstack-nova | 15:14 | |
| *** zz_dimtruck is now known as dimtruck | 15:14 | |
| *** tdurakov has joined #openstack-nova | 15:14 | |
| mriedem | bauzas: sure, but | 15:14 |
| mriedem | if it's nullable, it's optional, which means do we care if it's set? | 15:15 |
| mriedem | it's like calling dict.get() and getting None back if the key isn't in the dict | 15:15 |
| mriedem | saves us from shooting ourselves in the foot | 15:15 |
| bauzas | I see your point | 15:16 |
| mriedem | i'm assuming the reason is we fail in obvious ways if the field isn't set, which is better than failing in non-obvious ways when the field isn't set and defaults to None | 15:16 |
| *** tdurakov has quit IRC | 15:16 | |
| bauzas | yeah, I agree there are 2 things : defaulting fields automatically, and defaulting a field which can be nullable | 15:16 |
| *** annegent_ is now known as annegentle | 15:16 | |
| bauzas | while I disagree the former, I tend to agree the latter | 15:17 |
| *** tdurakov has joined #openstack-nova | 15:17 | |
| bauzas | mriedem: happy with patching that and CC me ? | 15:17 |
| *** dslevin has quit IRC | 15:18 | |
| mriedem | in o.vo? | 15:18 |
| mriedem | i'll just add it to my todo list for things to talk to superdan about | 15:19 |
| *** edtubill has joined #openstack-nova | 15:19 | |
| *** mdnadeem has quit IRC | 15:19 | |
| mriedem | right after who is our favorite twilight hunk | 15:19 |
| *** lucas-afk is now known as lucasagomes | 15:19 | |
| bauzas | mriedem: yeah in o.vo | 15:20 |
| *** ijw has joined #openstack-nova | 15:21 | |
| *** ijw has quit IRC | 15:21 | |
| *** ijw has joined #openstack-nova | 15:21 | |
| * tonyb isn't sure he wants to read the scrollback | 15:24 | |
| *** daemontool_ has joined #openstack-nova | 15:24 | |
| *** annegentle has quit IRC | 15:26 | |
| *** annegentle has joined #openstack-nova | 15:26 | |
| *** jinxing has joined #openstack-nova | 15:27 | |
| *** salv-orlando has joined #openstack-nova | 15:27 | |
| *** pradk has joined #openstack-nova | 15:27 | |
| *** EinstCrazy has quit IRC | 15:27 | |
| *** PaulMurray has quit IRC | 15:28 | |
| *** burgerk has quit IRC | 15:28 | |
| *** EinstCrazy has joined #openstack-nova | 15:28 | |
| *** achanda has joined #openstack-nova | 15:29 | |
| ndipanov | mriedem, so the problem was that default kwarg doesn't really work on fields afair | 15:29 |
| *** EinstCrazy has quit IRC | 15:30 | |
| mriedem | ildikov: i have meetings but put some comments in https://review.openstack.org/#/c/193134/ - i'm not done reviewing that yet though | 15:30 |
| ndipanov | because you can't really do it in the constructor since there is nothing stopping you from creating an object in python, setting a few values and calling save() | 15:30 |
| *** angdraug has joined #openstack-nova | 15:30 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Add tag column to vifs and bdm https://review.openstack.org/264014 | 15:30 |
| mriedem | however, the changes to the api response w/o a microversion are concerning | 15:30 |
| *** knikolla has quit IRC | 15:31 | |
| ildikov | mriedem: thanks for checking | 15:31 |
| ndipanov | which would overwrite whatever is in the db with defaults | 15:31 |
| ildikov | mriedem: changes to the api response? | 15:31 |
| *** SridharG has quit IRC | 15:32 | |
| *** akshai has quit IRC | 15:32 | |
| openstackgerrit | Tomi Juvonen proposed openstack/python-novaclient: Added support for Nova microversion 2.16 https://review.openstack.org/258270 | 15:32 |
| *** efoley__ has joined #openstack-nova | 15:32 | |
| *** efoley_ has quit IRC | 15:35 | |
| sdague | dims: can you respin https://review.openstack.org/#/c/268796/ without the WIP? | 15:38 |
| sdague | we probably need some explanation as to why we're doing that | 15:39 |
| dims | sdague : ack, will add detailed commit message | 15:39 |
| dims | yep | 15:39 |
| sdague | yeh, as well as comments in the code | 15:39 |
| sdague | it's super non obvious | 15:39 |
| openstackgerrit | Daniel Berrange proposed openstack/os-vif: Fix definition of subnet object to not be untyped strings https://review.openstack.org/269671 | 15:39 |
| *** achanda has quit IRC | 15:40 | |
| *** tdurakov has quit IRC | 15:40 | |
| *** READ10 has joined #openstack-nova | 15:40 | |
| *** tdurakov has joined #openstack-nova | 15:41 | |
| bauzas | johnthetubaguy: thoughts about providing a reno change for https://review.openstack.org/#/c/249013/ and https://review.openstack.org/#/c/211753/ ? | 15:42 |
| bauzas | johnthetubaguy: apart saying "please run nova-manage db sync", I don't really see a comment there | 15:43 |
| *** tdurakov has quit IRC | 15:43 | |
| bauzas | I mean, it's not really needing a reno file | 15:43 |
| *** otter768 has joined #openstack-nova | 15:43 | |
| *** tdurakov has joined #openstack-nova | 15:43 | |
| *** tjones has joined #openstack-nova | 15:43 | |
| *** PaulMurray has joined #openstack-nova | 15:43 | |
| ildikov | mriedem: I answered your API related concerns | 15:44 |
| *** yamahata has joined #openstack-nova | 15:44 | |
| sdague | dims: this still bugs me a little, because the part in the fork is actually a smaller amount of the runtime | 15:44 |
| *** akshai has joined #openstack-nova | 15:45 | |
| ildikov | mriedem: I think I had issues, during the modification of the translation function in the API and tempest was quite sensitive about a few things there | 15:46 |
| dims | sdague : wanted to avoid the print_leases in fork() guessing someone is already using that in their scripts or something | 15:46 |
| cdent | meh to the N and O names. | 15:46 |
| *** mtanino has joined #openstack-nova | 15:46 | |
| sdague | dims: ok, however the content in the fork is a cast | 15:47 |
| sdague | so it should be really fast | 15:47 |
| *** otter768 has quit IRC | 15:47 | |
| *** garyk has quit IRC | 15:49 | |
| *** dedery has quit IRC | 15:49 | |
| *** nkrinner has joined #openstack-nova | 15:50 | |
| tobasco | hm i need to access is_volume_backed_instance() defined in compute/api.py from scheduler/utils.py but i can't import it because that will cause a loop and just fail, i also don't want to move it or recreate a duplicate function in like compute/utils.py, my options are pretty much none... | 15:50 |
| *** eharney has quit IRC | 15:50 | |
| openstackgerrit | wuhao proposed openstack/nova: Add 'all_state' value to 'notify_on_state_change' option https://review.openstack.org/269720 | 15:51 |
| *** hemna has joined #openstack-nova | 15:51 | |
| *** markvoelker_ has quit IRC | 15:51 | |
| openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 15:51 |
| *** angdraug has quit IRC | 15:52 | |
| rlrossit | mriedem: I think it's because of lazy-loading. Because not set means "I need to go to the db to know what this is", and then if it feels like loading it from the database and it's null, then it's set. | 15:52 |
| rlrossit | where if we set it to default null, then it won't try to look it up in the db | 15:52 |
| openstackgerrit | ting wang proposed openstack/python-novaclient: Add debug testenv in tox https://review.openstack.org/266219 | 15:53 |
| *** efoley__ is now known as efoley | 15:53 | |
| mriedem | ildikov: yeah i meant like here https://review.openstack.org/#/c/193134/77/nova/api/openstack/compute/volumes.py - but now looking at that again, i guess it's not changing the response | 15:53 |
| mriedem | ildikov: it's taking the first attachment from the list and using the instance_uuid and mountpoint from that | 15:54 |
| ildikov | mriedem: yes | 15:54 |
| *** salv-orlando has quit IRC | 15:54 | |
| *** Marga_ has quit IRC | 15:54 | |
| ildikov | mriedem: it gives back the same response only the internally used structure is changed | 15:54 |
| sdague | mriedem: can you weigh in on https://review.openstack.org/#/c/268796/2/nova/cmd/dhcpbridge.py - I'm feeling really mixed right now, as I'm not sure I understand how it will actually fix things | 15:54 |
| mriedem | sdague: heh, idk either - turn on the vish signal? | 15:56 |
| ndipanov | ildikov, commented | 15:57 |
| *** burgerk has joined #openstack-nova | 15:57 | |
| ndipanov | johnthetubaguy, danpb https://review.openstack.org/#/c/269191/ | 15:57 |
| sdague | mriedem: I'm sure he drank away all those brain cells | 15:58 |
| *** tpatzig has left #openstack-nova | 15:58 | |
| sdague | I would have :) | 15:58 |
| *** houming has joined #openstack-nova | 15:58 | |
| *** bradjones has joined #openstack-nova | 15:58 | |
| *** bradjones has quit IRC | 15:58 | |
| *** bradjones has joined #openstack-nova | 15:58 | |
| mriedem | ndipanov: you and i had the same thought here https://review.openstack.org/#/c/193134/ in the rest api | 15:59 |
| *** achanda has joined #openstack-nova | 15:59 | |
| mriedem | with the keys order, but it does use an OrderedDict | 15:59 |
| mriedem | sdague: dims: so i guess the thinking in https://review.openstack.org/#/c/268796/ is we just fork off the calls to like add and remove a lease, so we're not blocking on those in a multi-tenant env and getting out of sync in the network manager code? | 16:01 |
| sdague | yeh | 16:01 |
| ildikov | mriedem: thanks, I'm writing the same comment to the patch | 16:01 |
| mriedem | i can't imagine dhcpbridge is blocking for long since it's doing an rpc cast for those operations | 16:01 |
| *** baoli has quit IRC | 16:01 | |
| *** lucasagomes is now known as lucas-brb | 16:01 | |
| sdague | right, I think the bigger issue is the amount of time spent in running the script overall | 16:02 |
| *** eharney has joined #openstack-nova | 16:02 | |
| sdague | mriedem: it is a race | 16:02 |
| sdague | and only seems to happen when 2 dhcp actions are hitting within a few msecs of each other | 16:02 |
| ndipanov | mriedem, hmmm | 16:03 |
| *** achanda has quit IRC | 16:03 | |
| *** boris-42 has joined #openstack-nova | 16:03 | |
| *** PaulMurray has quit IRC | 16:04 | |
| *** diogogmt has joined #openstack-nova | 16:04 | |
| markus_z | bauzas: I added a query to https://etherpad.openstack.org/p/nova-milestone-reno and took a look at the changes | 16:04 |
| dims | mriedem : right | 16:04 |
| *** aix has quit IRC | 16:05 | |
| markus_z | bauzas: I have to go earlier today, I think you will get my additions. | 16:05 |
| openstackgerrit | Sayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name https://review.openstack.org/263353 | 16:06 |
| ndipanov | mriedem, responded | 16:06 |
| *** jinxing has quit IRC | 16:06 | |
| *** mlavalle has joined #openstack-nova | 16:07 | |
| mlavalle | johnthetubaguy: ping | 16:07 |
| gibi | mikal: hi! I see your comments on https://review.openstack.org/#/c/247024/. Do I understand correclty that you have started fixing them or shall I go and respin the patch? | 16:07 |
| gibi | mikal: btw, thanks for the review | 16:07 |
| alaski | mriedem: https://review.openstack.org/#/c/266060 is a quick one for you | 16:10 |
| *** mjura has quit IRC | 16:11 | |
| *** markus_z has quit IRC | 16:11 | |
| ndipanov | lennyb, here? | 16:12 |
| tjones | thanks alaski for the reviews on ^^ | 16:12 |
| tjones | i hope to get rid of the last stubs.Set today | 16:13 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Avoid blocking dnsmasq by forking off RPC calls https://review.openstack.org/268796 | 16:13 |
| openstackgerrit | Chris Dent proposed openstack/nova: Tidy up scheduler_evolution.rst https://review.openstack.org/262561 | 16:13 |
| alaski | tjones: np. It's nice to see mox fade away | 16:13 |
| tjones | :-) | 16:14 |
| *** zenoway has quit IRC | 16:15 | |
| dims | sdague : mriedem : i've added as much info as i could to https://review.openstack.org/268796 | 16:15 |
| *** gongysh has joined #openstack-nova | 16:16 | |
| *** gtt116__ has joined #openstack-nova | 16:18 | |
| openstackgerrit | Tracy Jones proposed openstack/nova: Stop using mox stubs in test_configdrive https://review.openstack.org/265476 | 16:19 |
| *** smatzek has quit IRC | 16:19 | |
| *** zenoway has joined #openstack-nova | 16:19 | |
| mriedem | ildikov: ndipanov: went through it again, clarified the rest api part | 16:22 |
| mriedem | the new dict that's coming out of the volume api is causing confusion, but the code is working | 16:22 |
| *** gtt116_ has quit IRC | 16:22 | |
| *** RuiChen has quit IRC | 16:23 | |
| ildikov | mriedem: I added tests for that code to be sure | 16:23 |
| *** RuiChen has joined #openstack-nova | 16:23 | |
| *** mirrorbo1 is now known as mirrorbox | 16:23 | |
| ildikov | mriedem: I'm going through the comments now | 16:23 |
| *** zenoway has quit IRC | 16:23 | |
| *** smatzek has joined #openstack-nova | 16:24 | |
| mriedem | well, tempest would also fail if you changed the response, as you found out | 16:24 |
| *** mirrorbox has quit IRC | 16:24 | |
| *** mirrorbox has joined #openstack-nova | 16:24 | |
| *** fawadkhaliq has joined #openstack-nova | 16:24 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: change set_stubs to use stub_out in vmwareapi/stubs.py https://review.openstack.org/266060 | 16:26 |
| mriedem | alaski: got it | 16:26 |
| *** pbrooko_ has quit IRC | 16:27 | |
| *** Jeffrey4l has joined #openstack-nova | 16:27 | |
| *** lucas-brb is now known as lucasagomes | 16:28 | |
| *** bdrich has joined #openstack-nova | 16:28 | |
| *** Jeffrey4l has quit IRC | 16:28 | |
| *** garyk has joined #openstack-nova | 16:29 | |
| *** Jeffrey4l has joined #openstack-nova | 16:29 | |
| tjones | mriedem: thanks for fixing my alignment issue | 16:29 |
| mriedem | yw | 16:29 |
| mriedem | thanks for suffering my ocd | 16:29 |
| tjones | :-) | 16:29 |
| *** diana_clarke has joined #openstack-nova | 16:30 | |
| *** mdrabe has quit IRC | 16:30 | |
| tjones | 2 down - 2 to go… | 16:30 |
| tjones | with removing mox i mean | 16:31 |
| bdrich | Hi, looking for some help. Running a test which spins up vms, however the vms are not loading all data. For instance, "availability zones". I have logs for viewing, if anyone would like to see them. | 16:31 |
| mriedem | #success nova liberty 12.0.1 released http://lists.openstack.org/pipermail/openstack-announce/2016-January/000922.html | 16:34 |
| openstackstatus | mriedem: Added success to Success page | 16:34 |
| *** baoli has joined #openstack-nova | 16:35 | |
| ndipanov | mriedem, respnded to your response to my response to your respooooaaaa | 16:35 |
| *** markvoelker has joined #openstack-nova | 16:36 | |
| mriedem | :) | 16:36 |
| *** irenab has quit IRC | 16:36 | |
| ndipanov | mriedem, https://review.openstack.org/#/c/230919/ <- check this one when you get a chance | 16:36 |
| *** teju has joined #openstack-nova | 16:37 | |
| *** salv-orlando has joined #openstack-nova | 16:37 | |
| mriedem | do we need that given we have https://review.openstack.org/#/c/252565/ ? | 16:38 |
| edleafe | mriedem: not sure why https://review.openstack.org/#/c/269240/ is failing. The log at http://logs.openstack.org/40/269240/2/check/gate-grenade-dsvm/ff1377b/logs/old/screen-n-cpu.txt.gz?level=WARNING show that the compute node record was not found. No idea why that would be, though. | 16:39 |
| edleafe | mriedem: would appreciate your log-reading skills | 16:39 |
| *** alejandrito has quit IRC | 16:41 | |
| mriedem | edleafe: did you check the end of grenade.sh.txt? | 16:41 |
| mriedem | oh nvm | 16:42 |
| mriedem | http://logs.openstack.org/40/269240/2/check/gate-grenade-dsvm/ff1377b/console.html#_2016-01-19_15_37_50_525 | 16:42 |
| *** irenab has joined #openstack-nova | 16:42 | |
| mriedem | edleafe: test_volume_boot_pattern + ssh failed is like the top bug in the system | 16:42 |
| mriedem | so just recheck | 16:42 |
| *** gszasz has quit IRC | 16:42 | |
| mriedem | http://status.openstack.org/elastic-recheck/index.html#1355573 | 16:42 |
| edleafe | mriedem: ok, thanks | 16:42 |
| edleafe | mriedem: already rechecked once, with the same result. Wanted to make sure I wasn't missing something. | 16:43 |
| mriedem | edleafe: only other thing i'd check on that type of change is the n-net logs, but i didn't see any errors there | 16:44 |
| *** Marga_ has joined #openstack-nova | 16:44 | |
| mriedem | if you messed up the config options there would be lots of failures in all of the jobs probably (all of the n-net jobs that is) | 16:44 |
| edleafe | mriedem: yeah, I looked through all of those - didn't want to be embarrassed by you finding a bug that I missed again :) | 16:45 |
| *** hemna has quit IRC | 16:45 | |
| mriedem | in my 1:1 today i was told that at times i use a hammer when i should be using soft warm mittens and giving hugs | 16:45 |
| mriedem | edleafe: so never fear | 16:45 |
| *** mgoddard_ has joined #openstack-nova | 16:46 | |
| mriedem | it's a new year and a new, cuddlier mriedem | 16:46 |
| *** mdrabe has joined #openstack-nova | 16:46 | |
| *** annegentle has quit IRC | 16:46 | |
| kashyap | mriedem: When you get a sec later, for this bug - https://bugs.launchpad.net/nova/+bug/1524898, is it possible to run that test job with QEMU 2.3 ? QEMU 2.0 is 2 years older. | 16:46 |
| openstack | Launchpad bug 1524898 in OpenStack Compute (nova) "Volume based live migration aborted unexpectedly" [High,Confirmed] | 16:46 |
| kashyap | My guess is 'not at the moment' | 16:47 |
| *** zakora has quit IRC | 16:47 | |
| edleafe | mriedem: somehow I find that much scarier | 16:47 |
| *** mgoddard__ has quit IRC | 16:49 | |
| dims | mriedem : alaski : who is responsible for "Citrix XenServer CI"? seeing some "Hash Sum mismatch" errors | 16:49 |
| mriedem | kashyap: we have a fedora (21?) job in the experimental queue, i'm not sure what version of qemu is on that though | 16:50 |
| *** annegentle has joined #openstack-nova | 16:50 | |
| mriedem | that's the only way i know of though to test newer libvirt/qemu is on the fc job | 16:50 |
| mriedem | dims: BobBall | 16:50 |
| kashyap | mriedem: Afraid, F21 is End-Of-Life :-) | 16:50 |
| mriedem | someone at one point was working on an fc22 job | 16:50 |
| mriedem | or maybe fc23 | 16:50 |
| mriedem | checking | 16:50 |
| kashyap | Okay, I'll check with Infra tomorrow | 16:50 |
| *** irenab has quit IRC | 16:51 | |
| *** nelsnelson has quit IRC | 16:51 | |
| mriedem | kashyap: oh, but | 16:51 |
| *** salv-orlando has quit IRC | 16:51 | |
| kashyap | ? | 16:51 |
| mriedem | that's a test that fails in a multi-node live migration job | 16:51 |
| *** yamahata has quit IRC | 16:51 | |
| mriedem | which is only ubuntu images right now | 16:51 |
| mriedem | so no dice with fc being in that job | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type https://review.openstack.org/262584 | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr https://review.openstack.org/262585 | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs https://review.openstack.org/262586 | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver https://review.openstack.org/262583 | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Make sure that we always have a parent_addr set https://review.openstack.org/269191 | 16:52 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: use context when performing oprations of pci devices https://review.openstack.org/269764 | 16:52 |
| kashyap | mriedem: Doesn't have to be Fedora. If those Ubuntu imges can manage to have newest stable QEMU that'd be useful | 16:52 |
| *** nelsnelson has joined #openstack-nova | 16:52 | |
| mriedem | you'd have to probably hook in the cloud archive or something | 16:52 |
| BobBall | dims: Which changeset? | 16:53 |
| kashyap | Okay, I made a note to follow up who can do that. | 16:53 |
| *** rcernin has quit IRC | 16:53 | |
| mriedem | http://ubuntu-cloud.archive.canonical.com/ubuntu/dists/trusty-updates/liberty/main/binary-i386/Packages | 16:53 |
| dims | BobBall : https://review.openstack.org/#/c/268796/ | 16:54 |
| mriedem | qemu-kvm Version: 1:2.3+dfsg-5ubuntu9~cloud0 | 16:54 |
| *** nkrinner has quit IRC | 16:54 | |
| dims | BobBall : direct link http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/96/268796/3/3473/index.html | 16:54 |
| mriedem | kashyap: so if you could get the cloud archive enabled you could update libvirt/qemu | 16:54 |
| *** apoorvad has joined #openstack-nova | 16:54 | |
| BobBall | dims: I believe that's triggered when the ubuntu archive is in the process of being updated? | 16:55 |
| *** matrohon has quit IRC | 16:55 | |
| kashyap | mriedem: Noted, I don't know who can do that - maybe Ubuntu Virt maintainers (the name that pops up in my head is Serge Hallyn) | 16:55 |
| *** annegentle has quit IRC | 16:55 | |
| mriedem | kashyap: you might be better off starting a thread in the ML | 16:55 |
| dims | BobBall : so just a recheck? | 16:55 |
| BobBall | dims: i.e. we download the metadata first, it gets updated, then we download some of the package listings and check the new hash against the old metadata | 16:55 |
| BobBall | dims: Yup | 16:55 |
| dims | BobBall : ack thanks | 16:55 |
| mriedem | kashyap: sdague would probably have quick answers to why we don't use the cloud archive in the gate | 16:55 |
| *** teju has quit IRC | 16:55 | |
| kashyap | mriedem: Okay, will go do that | 16:55 |
| *** hemna has joined #openstack-nova | 16:57 | |
| *** vishwanathj has joined #openstack-nova | 16:57 | |
| *** scheuran has quit IRC | 16:57 | |
| *** david-lyle has quit IRC | 16:58 | |
| *** houming has quit IRC | 16:59 | |
| *** dslevin has joined #openstack-nova | 16:59 | |
| *** gongysh has quit IRC | 16:59 | |
| *** mgoddard_ has quit IRC | 17:00 | |
| *** mgoddard has joined #openstack-nova | 17:00 | |
| *** SridharG has joined #openstack-nova | 17:00 | |
| *** claudiub has joined #openstack-nova | 17:00 | |
| *** e0ne has quit IRC | 17:01 | |
| *** apoorvad has quit IRC | 17:02 | |
| *** sahid has quit IRC | 17:03 | |
| *** salv-orlando has joined #openstack-nova | 17:03 | |
| *** david-lyle has joined #openstack-nova | 17:06 | |
| *** jlanoux has quit IRC | 17:07 | |
| kashyap | (I made a typo above: latest stable QEMU is 2.5, not 2.3) | 17:08 |
| *** rcernin has joined #openstack-nova | 17:09 | |
| *** yamahata has joined #openstack-nova | 17:09 | |
| *** PaulMurray has joined #openstack-nova | 17:11 | |
| *** Daisy has joined #openstack-nova | 17:15 | |
| mriedem | ndipanov: i'm not sure what to do about check_detach here https://review.openstack.org/#/c/193134/77/nova/volume/cinder.py | 17:17 |
| mriedem | i added some notes, it looks like if you pass the wrong attachment_id, cinder doesn't error out | 17:17 |
| mriedem | would be nice if some cinder people, cough hemna scottda cough, would look at that | 17:17 |
| hemna | hey | 17:17 |
| hemna | sorry had the day off yesterday | 17:17 |
| * hemna checks | 17:18 | |
| mriedem | yeah, bankers hours at HPE | 17:18 |
| mriedem | hemna: the check_detach discussion here https://review.openstack.org/#/c/193134/77/nova/volume/cinder.py | 17:18 |
| hemna | :) | 17:18 |
| *** yassine__ has quit IRC | 17:18 | |
| ildikov | mriedem: another question to check_detach | 17:18 |
| mriedem | although really i was just looking at attachment not found | 17:19 |
| *** Daisy has quit IRC | 17:19 | |
| ildikov | mriedem: if I change that VolumeUnattached exception there there are tests I need to change which was not added by me meaning that it changes already existing behavior | 17:19 |
| ildikov | mriedem: not behavior just the exception | 17:19 |
| ildikov | mriedem: is it acceptable or should I leave it for now? | 17:19 |
| mriedem | ildikov: maybe just put a todo in this change to add a better exception at some point | 17:20 |
| ildikov | mriedem: ok, I will change it back then, tnx | 17:20 |
| mriedem | where is the actual detach_volume method for the lvm backend in cinder? | 17:21 |
| *** shyama has quit IRC | 17:21 | |
| *** ssurana has joined #openstack-nova | 17:21 | |
| *** Jeffrey4l has quit IRC | 17:22 | |
| scottda | Sorry, bankers hours as well...I'll have a look in a little while. | 17:23 |
| *** derekh has quit IRC | 17:23 | |
| dims | mriedem : sdague : seen this? message:"libvirtError: unsupported configuration: guest and host CPU are not compatible:" AND voting:1 | 17:25 |
| dims | mriedem : sdague : http://logs.openstack.org/96/268796/3/check/gate-tempest-dsvm-multinode-full/7587dc3/logs/screen-n-cpu.txt.gz?level=ERROR#_2016-01-19_16_54_33_330 | 17:25 |
| *** diogogmt has quit IRC | 17:25 | |
| mriedem | dims: yeah | 17:25 |
| hemna | so fwiw, the multi attach attribute has been part of the Cinder API since https://github.com/openstack/cinder/commit/10d54216871fde27172fbcb1a3c9bfec59b824c2 | 17:25 |
| mriedem | dims: https://bugs.launchpad.net/openstack-gate/+bug/1535799 | 17:26 |
| openstack | Launchpad bug 1535799 in devstack "internap doesn't support the same cpu flags as other providers" [Undecided,In progress] | 17:26 |
| dims | mriedem : ah thanks, you are ahead of me :) | 17:26 |
| openstackgerrit | Chris Dent proposed openstack/nova: Add ResourceClassList versioned object https://review.openstack.org/263498 | 17:26 |
| openstackgerrit | Chris Dent proposed openstack/nova: Add resource_classes table to api database https://review.openstack.org/263496 | 17:26 |
| openstackgerrit | Chris Dent proposed openstack/nova: Versioned objects support for ResourceClass https://review.openstack.org/263497 | 17:26 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter https://review.openstack.org/189279 | 17:30 |
| mriedem | so i guess only like 3 volume drivers actually use the attachment in detach_volume | 17:30 |
| mriedem | hemna: yeah we know multiattach has been in cinder for a long time, the question i had in check_detach there was how wise it is to not validate the instance uuid vs the attachments in the volume | 17:31 |
| hemna | I put my $0.02 in | 17:31 |
| mriedem | ok | 17:31 |
| hemna | at this point we shouldn't boil the ocean | 17:31 |
| hemna | mriedem, you are correct | 17:33 |
| mriedem | ok, i tend to agree with you on leaving it in | 17:35 |
| mriedem | and cleaning up later | 17:35 |
| hemna | yah subsequent patch if anything | 17:35 |
| mriedem | i tend to think check_detach should be using begin_detaching instead of it's own status checking, we could avoid that - let cinder do the status checking since it's holding the current data | 17:36 |
| *** diogogmt has joined #openstack-nova | 17:36 | |
| mriedem | but that's a later nova cleanup imo | 17:36 |
| mriedem | and nova can deal with validating the instance uuid vs the volume attachments list | 17:36 |
| *** davideagnello has joined #openstack-nova | 17:37 | |
| *** dslevin has quit IRC | 17:37 | |
| ildikov | mriedem: that looks like a good way to go | 17:37 |
| *** carolynv_ has quit IRC | 17:37 | |
| *** apoorvad has joined #openstack-nova | 17:37 | |
| *** Marga_ has quit IRC | 17:37 | |
| johnthetubaguy | ndipanov: ah, good good, that fix is +W now, were there two bugs you said? | 17:37 |
| *** Marga_ has joined #openstack-nova | 17:38 | |
| johnthetubaguy | bauzas: looking | 17:38 |
| ndipanov | yes - the next fix after that - but I think vladikr is going to resping | 17:38 |
| ndipanov | johnthetubaguy, ^ | 17:38 |
| *** sfinucan has quit IRC | 17:39 | |
| johnthetubaguy | bauzas: yeah, agreed there isn't too much to say for those two, probably skip them | 17:39 |
| *** _RuiChen has joined #openstack-nova | 17:40 | |
| johnthetubaguy | mriedem: just wanting to ping about how things are looking CI wise, in terms of tagging mitaka-2? | 17:40 |
| johnthetubaguy | mriedem: I am trying to track any blockers in here, in case you spot any: https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking | 17:40 |
| *** RuiChen has quit IRC | 17:42 | |
| *** pratikma_ has quit IRC | 17:42 | |
| mriedem | for thursday? | 17:43 |
| mriedem | there is a fix going through devstack for a problem in the multinode jobs | 17:43 |
| mriedem | otherwise i haven't heard of anything | 17:43 |
| johnthetubaguy | mriedem: well, usually try to pick today or tomorrow for the release | 17:44 |
| *** otter768 has joined #openstack-nova | 17:44 | |
| mriedem | oh blockers as in like rc potential? | 17:44 |
| johnthetubaguy | mriedem: the PCI breakage ndipanov was talking about, kinda feels bad enough to wait for | 17:44 |
| mriedem | yeah | 17:44 |
| mriedem | got it | 17:44 |
| johnthetubaguy | yeah, more stuff like that, sometimes the CI breakages point at them I guess | 17:44 |
| ndipanov | johnthetubaguy, well it's on it's way to the gate now | 17:45 |
| johnthetubaguy | ndipanov: ack, yeah, glad to see that | 17:45 |
| johnthetubaguy | ndipanov: did you say there was another one? | 17:45 |
| ndipanov | johnthetubaguy, and the other thing is something vladik picked up on when he was doing functional tests for the PF feature | 17:45 |
| *** nic has joined #openstack-nova | 17:45 | |
| ndipanov | and I think it's only hit when actually using it | 17:45 |
| johnthetubaguy | ndipanov: ah, OK | 17:46 |
| ndipanov | but moshele commented on one of the patches that there is _another_ CI fail | 17:46 |
| ndipanov | but I was not able to grab any of the CI folks today | 17:47 |
| johnthetubaguy | ah, OK, will keep an eye out for that | 17:47 |
| mriedem | markus_z isn't around, but i thought we had another bug triage person this week | 17:47 |
| mriedem | which would be auggy | 17:48 |
| auggy | that's me! | 17:48 |
| *** jistr has quit IRC | 17:48 | |
| mriedem | auggy: i guess be on the lookup for critical regressions that we should hold up m-2 for | 17:49 |
| *** lpetrut has quit IRC | 17:49 | |
| *** otter768 has quit IRC | 17:49 | |
| *** ZZelle has quit IRC | 17:49 | |
| auggy | should i bring them to people's attention here? | 17:49 |
| *** ZZelle has joined #openstack-nova | 17:50 | |
| *** burgerk_ has joined #openstack-nova | 17:50 | |
| auggy | it's been pretty slow on the bug front, mostly "i got an api error that told me to file a bug" and i'm still working on reproducing some of the others to verify them | 17:50 |
| *** burgerk has quit IRC | 17:51 | |
| mriedem | tjones: can you see why the vmware nsx ci isn't reporting back on https://review.openstack.org/#/c/168024/ ? i rechecked that yesterday | 17:51 |
| openstackgerrit | Andrey Pavlov proposed openstack/nova: remove EC2 legacy code https://review.openstack.org/266425 | 17:51 |
| *** angdraug has joined #openstack-nova | 17:52 | |
| *** unicell has quit IRC | 17:53 | |
| tjones | sure | 17:53 |
| tjones | @mriedem sure i'll check | 17:53 |
| *** cdent has quit IRC | 17:53 | |
| johnthetubaguy | auggy: that sounds great, mostly tracking the blocking things in here: https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking | 17:54 |
| *** cdent has joined #openstack-nova | 17:54 | |
| mriedem | auggy: really anything that like merges this week and all of a sudden you can't boot an instance or start the compute service | 17:54 |
| mriedem | major regressions which we should hold the milestone release for | 17:55 |
| auggy | ok cool, haven't seen anything like that | 17:55 |
| *** ljxiash_ has quit IRC | 17:55 | |
| auggy | most of these so far when i've tried to repro and then searched for more info have just looked like config issues | 17:55 |
| auggy | bug triaging is very educational! | 17:56 |
| *** rmart04_ has joined #openstack-nova | 17:59 | |
| *** rmart04_ has quit IRC | 17:59 | |
| *** rmart04 has quit IRC | 18:00 | |
| ildikov | mriedem: is there a way to test the lower version of detach_volume with rpc api without rewriting _test_compute_api? | 18:00 |
| *** mrkz has quit IRC | 18:02 | |
| mriedem | ildikov: in the past i've just written a new test case using mock for the version wrinkles rather than trying to shoe-horn the change into the common code | 18:02 |
| *** busterswt has quit IRC | 18:02 | |
| *** mrkz has joined #openstack-nova | 18:02 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: doc: remove detail about extensions https://review.openstack.org/267370 | 18:02 |
| mriedem | ildikov: e.g. https://review.openstack.org/#/c/192396/7/nova/tests/unit/network/test_rpcapi.py | 18:03 |
| mriedem | brb | 18:03 |
| mlavalle | johnthetubaguy: ping | 18:04 |
| *** diogogmt has quit IRC | 18:04 | |
| mlavalle | alaski: tomorrow, what time is the cells v2 meeting? 1700 or 2100 UTC? | 18:05 |
| ildikov | mriedem: thanks for the pointer, only item on the list that's missing | 18:05 |
| *** diogogmt has joined #openstack-nova | 18:05 | |
| *** zenoway has joined #openstack-nova | 18:06 | |
| *** fawadkhaliq has quit IRC | 18:08 | |
| alaski | mlavalle: tomorrow is 1700 | 18:08 |
| mlavalle | alaski: thanks. Looking to get up to speed on the porgress so far | 18:09 |
| mlavalle | progress^^^^ | 18:09 |
| *** pratikmallya has joined #openstack-nova | 18:10 | |
| *** zenoway has quit IRC | 18:11 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: WIP: os-vif: convert libvirt driver to use os-vif library https://review.openstack.org/269672 | 18:12 |
| *** PaulMurray has quit IRC | 18:12 | |
| *** BobBall is now known as BobBall_AWOL | 18:13 | |
| *** danpb has quit IRC | 18:16 | |
| tjones | mriedem: NSX CI is running but behind. we bumped up your job so it should run next | 18:17 |
| *** e0ne has joined #openstack-nova | 18:17 | |
| mriedem | ok | 18:17 |
| mriedem | thanks | 18:17 |
| *** diana_clarke has quit IRC | 18:17 | |
| *** eil397 has joined #openstack-nova | 18:18 | |
| *** pradk has quit IRC | 18:19 | |
| *** bdrich has quit IRC | 18:19 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications https://review.openstack.org/263788 | 18:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 18:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Generate doc for versioned notifications https://review.openstack.org/265151 | 18:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 18:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 18:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 18:21 |
| *** knikolla has joined #openstack-nova | 18:21 | |
| *** salv-orlando has quit IRC | 18:23 | |
| *** efoley has quit IRC | 18:25 | |
| *** rotbeard has quit IRC | 18:25 | |
| *** pradk has joined #openstack-nova | 18:26 | |
| *** pradk has quit IRC | 18:26 | |
| *** unicell has joined #openstack-nova | 18:27 | |
| *** rdopiera has quit IRC | 18:28 | |
| *** baoli has quit IRC | 18:29 | |
| *** knikolla has quit IRC | 18:29 | |
| *** paul-carlton2 has quit IRC | 18:29 | |
| *** zhiyan has quit IRC | 18:33 | |
| *** tpeoples has quit IRC | 18:34 | |
| *** auggy has quit IRC | 18:34 | |
| *** belliott has quit IRC | 18:35 | |
| *** pumarani- has quit IRC | 18:35 | |
| *** zhiyan has joined #openstack-nova | 18:36 | |
| *** tpeoples has joined #openstack-nova | 18:36 | |
| *** belliott has joined #openstack-nova | 18:36 | |
| *** auggy has joined #openstack-nova | 18:37 | |
| *** annegentle has joined #openstack-nova | 18:38 | |
| *** angdraug has quit IRC | 18:38 | |
| *** mgoddard_ has joined #openstack-nova | 18:39 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 18:41 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass attachment_id to Cinder when detach a volume https://review.openstack.org/193134 | 18:41 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: comp: Allow volume multiattach https://review.openstack.org/267587 | 18:41 |
| *** salv-orlando has joined #openstack-nova | 18:41 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 18:41 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass host when call attach to Cinder https://review.openstack.org/256273 | 18:41 |
| *** rlrossit has quit IRC | 18:41 | |
| *** mgoddard has quit IRC | 18:42 | |
| ildikov | mriedem: new version is up ^ | 18:45 |
| *** rlrossit_ has joined #openstack-nova | 18:46 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 18:46 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass attachment_id to Cinder when detach a volume https://review.openstack.org/193134 | 18:46 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: comp: Allow volume multiattach https://review.openstack.org/267587 | 18:46 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 18:46 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass host when call attach to Cinder https://review.openstack.org/256273 | 18:46 |
| mriedem | ildikov: yup, was just reading through the next one on passing the host | 18:46 |
| mriedem | and trying to sort out what's in the connector dict | 18:46 |
| mriedem | and feeling sad that we don't validate any of that information | 18:47 |
| *** vishwanathj has quit IRC | 18:47 | |
| ildikov | mriedem: I only rebased as your tempest patch failed again with merge issues | 18:47 |
| ildikov | mriedem: I hear ya | 18:48 |
| ildikov | at least for the Cinder volume I can check the API docs and hope it's correct | 18:48 |
| ildikov | connector is more tricky :( | 18:48 |
| *** pradk has joined #openstack-nova | 18:49 | |
| vladikr | jaypipes, when you'll have a moment, please look at the libosinfo series. It has danpb's +2 https://review.openstack.org/#/q/topic:bp/libvirt-hardware-policy-from-libosinfo | 18:51 |
| *** boris-42 has quit IRC | 18:53 | |
| *** salv-orlando has quit IRC | 18:54 | |
| mriedem | ildikov: yeah for libvirt the connector comes from os-brick | 18:55 |
| mriedem | the ComputeDriver docstring does say what should be in the dict | 18:55 |
| ildikov | mriedem: ah, ok, got it | 18:55 |
| ildikov | mriedem: I got the hints from hemnafk for that patch :) | 18:56 |
| *** chhavi has quit IRC | 18:59 | |
| *** alex_xu has quit IRC | 19:04 | |
| *** gonzalo2kx has joined #openstack-nova | 19:04 | |
| *** salv-orlando has joined #openstack-nova | 19:04 | |
| *** jichen has joined #openstack-nova | 19:04 | |
| *** lpetrut has joined #openstack-nova | 19:06 | |
| *** alex_xu has joined #openstack-nova | 19:07 | |
| *** eliqiao has quit IRC | 19:11 | |
| *** eliqiao has joined #openstack-nova | 19:13 | |
| *** rmart04 has joined #openstack-nova | 19:13 | |
| *** vilobhmm11 has joined #openstack-nova | 19:14 | |
| *** bdrich has joined #openstack-nova | 19:14 | |
| *** rmart04_ has joined #openstack-nova | 19:15 | |
| *** tdurakov has quit IRC | 19:15 | |
| *** tdurakov has joined #openstack-nova | 19:16 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L165-L166 | 19:17 |
| *** angdraug has joined #openstack-nova | 19:17 | |
| mriedem | how does subtracting a dict from a set work? | 19:17 |
| mriedem | oh derp | 19:18 |
| rlrossit_ | silly mriedem | 19:18 |
| *** rmart04 has quit IRC | 19:18 | |
| *** rmart04_ is now known as rmart04 | 19:18 | |
| *** ihrachys has quit IRC | 19:18 | |
| jaypipes | vladikr: sorry, meeting hell day... will try to get to that series later tonight (I noted it yesterday but couldn't get to it) | 19:19 |
| sdague | mriedem: although, that use of inline set is so unused, it's confusing when it shows up | 19:19 |
| vladikr | jaypipes, thanks! | 19:19 |
| mriedem | sdague: +1 | 19:19 |
| *** SridharG has quit IRC | 19:22 | |
| *** jaosorior has quit IRC | 19:25 | |
| *** jaosorior has joined #openstack-nova | 19:25 | |
| *** rmart04 has quit IRC | 19:26 | |
| *** diana_clarke has joined #openstack-nova | 19:27 | |
| *** dedery has joined #openstack-nova | 19:33 | |
| mriedem | doffm: https://review.openstack.org/#/c/206735/ | 19:34 |
| mriedem | doffm: nova api showing neutron quotas is a long-standing bug that no one was ever working on (ctrath had a spec up for it) | 19:34 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests https://review.openstack.org/261045 | 19:35 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests https://review.openstack.org/262083 | 19:35 |
| mriedem | doffm: https://bugs.launchpad.net/nova/+bug/1186354 | 19:35 |
| openstack | Launchpad bug 1186354 in OpenStack Compute (nova) "Limits API doesn't work with Neutron" [Medium,In progress] - Assigned to Cale Rath (ctrath) | 19:35 |
| *** paul-carlton2 has joined #openstack-nova | 19:43 | |
| *** otter768 has joined #openstack-nova | 19:45 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: Compute API: omit disk/container formats when creating images of snapshots https://review.openstack.org/226069 | 19:47 |
| *** dslev has joined #openstack-nova | 19:47 | |
| sdague | dims: do you have logs that pinpoint the failure due to the dhcpbridge issue? | 19:47 |
| sdague | so I can convince myself the fork is going to help | 19:47 |
| dims | sdague : i'll dig one up | 19:47 |
| *** krtaylor has quit IRC | 19:49 | |
| sdague | dims: thanks | 19:49 |
| *** otter768 has quit IRC | 19:50 | |
| jaypipes | vladikr: done. | 19:50 |
| vladikr | jaypipes, thanks | 19:50 |
| *** eharney has quit IRC | 19:52 | |
| *** salv-orlando has quit IRC | 19:54 | |
| *** zenoway has joined #openstack-nova | 19:55 | |
| *** PsionTheory has joined #openstack-nova | 19:56 | |
| *** rfolco has quit IRC | 19:56 | |
| *** ctrath has quit IRC | 19:58 | |
| *** aysyd has quit IRC | 19:59 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type https://review.openstack.org/262584 | 20:02 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr https://review.openstack.org/262585 | 20:02 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs https://review.openstack.org/262586 | 20:02 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: store context when creating pci devices https://review.openstack.org/269764 | 20:02 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 20:02 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver https://review.openstack.org/262583 | 20:02 |
| *** tonytan4ever has quit IRC | 20:02 | |
| *** lucasagomes is now known as lucas-pto | 20:03 | |
| *** krtaylor has joined #openstack-nova | 20:03 | |
| *** salv-orlando has joined #openstack-nova | 20:03 | |
| *** mrkz has quit IRC | 20:04 | |
| *** dave-mccowan has joined #openstack-nova | 20:04 | |
| *** e0ne has quit IRC | 20:04 | |
| *** dave-mcc_ has joined #openstack-nova | 20:06 | |
| *** mrkz has joined #openstack-nova | 20:06 | |
| bauzas | mriedem: you okay if I forward port your relnote for the OSSA issues ? :D | 20:06 |
| *** jaosorior has quit IRC | 20:08 | |
| mriedem | forward port? | 20:08 |
| *** salv-orlando has quit IRC | 20:09 | |
| *** dave-mccowan has quit IRC | 20:09 | |
| *** abitha has joined #openstack-nova | 20:11 | |
| *** ociuhandu has quit IRC | 20:11 | |
| bauzas | mriedem: https://review.openstack.org/#/c/267178/ | 20:11 |
| bauzas | correct me if I'm wrong, but all of the changes are also in master, right? | 20:11 |
| mriedem | bauzas: yeah, those were already announced though | 20:12 |
| mriedem | separately | 20:12 |
| bauzas | mriedem: but they're missing a relnote hence my question | 20:13 |
| tonyb | bauzas: Yeah they're there (on master) | 20:13 |
| mriedem | bauzas: oh missing the release note on master, i get it | 20:13 |
| mriedem | yeah go nuts | 20:13 |
| tonyb | bauzas: yeah you're right, they'll need somethign like hat review on master | 20:14 |
| bauzas | mriedem: tonyb: yeah not speaking about the patches themselves, just the reno files | 20:14 |
| bauzas | I'm just adding a bunch of reno files now we're about to cutr | 20:15 |
| bauzas | cut | 20:15 |
| bauzas | https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking and https://etherpad.openstack.org/p/nova-milestone-reno | 20:15 |
| sdague | auggy: I wonder if we can respin this so that we instantiate the test class without inheriting from it - https://review.openstack.org/#/c/263440/7 | 20:15 |
| *** tonytan4ever has joined #openstack-nova | 20:15 | |
| sdague | that should also handle some of the testscenarios oddness | 20:15 |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode https://review.openstack.org/265521 | 20:17 |
| *** diana_clarke has quit IRC | 20:17 | |
| *** ctrath has joined #openstack-nova | 20:18 | |
| *** Sukhdev has joined #openstack-nova | 20:18 | |
| *** salv-orlando has joined #openstack-nova | 20:19 | |
| dims | sdague : see some of the time drifts between when DHCPACK is in syslog and we have an entry in dhcpbridge - https://www.evernote.com/l/AZymPWaeEkRJmLKtkO9gx1f3-kWa25PPcb0 - picked from a recent run - http://logs.openstack.org/30/263430/5/check/gate-tempest-dsvm-full/d67d96f/logs/ | 20:21 |
| *** e0ne has joined #openstack-nova | 20:22 | |
| *** claudiub has quit IRC | 20:22 | |
| *** e0ne has quit IRC | 20:22 | |
| *** tdurakov has quit IRC | 20:23 | |
| sdague | ok, will look at post TC meeting | 20:23 |
| auggy | sdague: sure i can try to figure out how to do that | 20:24 |
| auggy | i tried to do it as an instance within the class but couldn't get it working | 20:24 |
| sdague | auggy: yeh... I'm realizing it might not be super straight forward ... let me figure out if there is a good way to handle the bootstrapping | 20:25 |
| auggy | sdague: this was more me just trying to get something working but i figured we'd need to fix that inheritance issue | 20:25 |
| sdague | auggy: yeh, the reset is good, the inheritance makes me nervous | 20:26 |
| *** gtt116_ has joined #openstack-nova | 20:26 | |
| sdague | s/reset/rest/ | 20:27 |
| auggy | sdague: also let me know if you notice any gaps in test coverage that could be important | 20:27 |
| auggy | i mainly just went off the logical branches in the method | 20:27 |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Use extra_data_func to get fingerprints of objects https://review.openstack.org/263915 | 20:28 |
| sdague | yeh, I think everything there is good, one of the important things I want to get tested after that is the messages when things fail | 20:28 |
| sdague | because they are often pretty surprising | 20:28 |
| auggy | yes, i found that and put some comments in the tests | 20:28 |
| auggy | there were some things that should have been caught well before it got to where it got in the code | 20:28 |
| auggy | and i think that's contributing to the unhelpful errors | 20:29 |
| *** gtt116__ has quit IRC | 20:29 | |
| auggy | sdague: i'll revisit how i tried to this initially without inheritance and let you know the results i had, it's possible it's something really obvious i just missed | 20:29 |
| sdague | yeh, test class instantiation is actually a bit tricky | 20:30 |
| *** diana_clarke has joined #openstack-nova | 20:32 | |
| *** salv-orlando has quit IRC | 20:32 | |
| *** READ10 has quit IRC | 20:34 | |
| *** ZZelle_ has joined #openstack-nova | 20:34 | |
| *** Yingxin has quit IRC | 20:36 | |
| *** diogogmt has quit IRC | 20:36 | |
| *** tdurakov has joined #openstack-nova | 20:36 | |
| *** Yingxin has joined #openstack-nova | 20:36 | |
| bauzas | mriedem: meh, nevermind my point, I can't forward port https://review.openstack.org/#/c/267178/1/releasenotes/notes/12.0.1-cve-bugs-7b04b2e34a3e9a70.yaml | 20:37 |
| bauzas | mriedem: because of your prelude <3 | 20:37 |
| mriedem | bauzas: well, you could and then just modify it | 20:38 |
| mriedem | or just write a new change with the same change id maybe, but different prelude | 20:38 |
| mriedem | or no prelude | 20:38 |
| bauzas | mriedem: yeah, was thinking about that (forward port and cut the prelude) | 20:38 |
| bauzas | but it's a bit weirdo IMHO | 20:38 |
| bauzas | just for some doc strings :) | 20:38 |
| auggy | sdague: this is the error i got when i tried instantiating it and calling the _compare_result method on the instance https://gist.github.com/missaugustina/59d378bfe465690eed39 | 20:39 |
| *** xyang1 has joined #openstack-nova | 20:39 | |
| mriedem | bauzas: or just copy the text and write a new change in master | 20:39 |
| mriedem | doesn't really matter to me | 20:39 |
| bauzas | yeah, was just for bugging you :p | 20:39 |
| mriedem | <head explodes> | 20:40 |
| *** diogogmt has joined #openstack-nova | 20:40 | |
| bauzas | :) | 20:41 |
| *** boris-42 has joined #openstack-nova | 20:43 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/193135 | 20:47 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: comp: Allow volume multiattach https://review.openstack.org/267587 | 20:47 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 20:47 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Pass host when call attach to Cinder https://review.openstack.org/256273 | 20:47 |
| sdague | auggy: ok, I got something super hacky | 20:48 |
| auggy | sdague: alright i'm all eyes | 20:48 |
| sdague | http://paste.openstack.org/show/484340/ | 20:48 |
| auggy | sdague: alright that looks pretty much like what people on stack overflow were telling people to do in a similar situation | 20:49 |
| auggy | i was tempted to give it a try but i didn't want to be laughed at | 20:49 |
| auggy | so i'm glad you put yourself out there :D haha | 20:49 |
| auggy | i'll give it a try and see, i'm pretty sure that's gonna fix it | 20:49 |
| auggy | i understand that the api test class is derived from some python test class that does all this fancy shmancy stuff under the hood so thanks for helping to make some sense out of that :) | 20:50 |
| ildikov | mriedem: got the tests fixed or at least checnged and locally still green :) | 20:51 |
| ildikov | mriedem: thank you for all the reviews and help with this! I really appreciate! | 20:52 |
| sdague | you can totally blame me | 20:52 |
| sdague | we can also ask lifeless if he knows a better way, he knows test loader internals deeply | 20:52 |
| lifeless | hi, I have a queue right now, but in 20m I should be free | 20:53 |
| *** dslev has quit IRC | 20:55 | |
| auggy | lifeless: its cool, we were just blaming you for something | 20:55 |
| lifeless | auggy: its all my fault | 20:56 |
| *** dave-mcc_ has quit IRC | 20:57 | |
| auggy | sdague: lifeless: i aspire some day to know the magical test loader incantations as well as you all do | 20:57 |
| auggy | yay that worked | 20:58 |
| auggy | sdague: lifeless: i will update my current patch shortly (with comments) so review at your leisure | 20:58 |
| *** daemontool_ has quit IRC | 20:59 | |
| auggy | https://review.openstack.org/#/c/263440/ | 20:59 |
| auggy | (not updated yet just posted for reference) | 20:59 |
| *** jdurgin1 has joined #openstack-nova | 20:59 | |
| rlrossit_ | dims: any chance you could take a look at https://review.openstack.org/#/c/266960/ ? I would like to get this in before FF (and I feel terrible for begging) | 21:00 |
| *** annegentle has quit IRC | 21:00 | |
| *** cdent has quit IRC | 21:02 | |
| *** jschlueter has quit IRC | 21:02 | |
| *** jschlueter has joined #openstack-nova | 21:03 | |
| dims | rlrossit_ : +1 from me. that's the max karma for me :) | 21:03 |
| lifeless | auggy: sdague: so whats the question you have? | 21:05 |
| auggy | lifeless: we're creating test coverage for some of the functional tests in Api Samples Base Class | 21:06 |
| auggy | i'm working on the first stab at this for _compare_results | 21:06 |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: Fix deleted non-public flavor lookups for non-admin users https://review.openstack.org/211809 | 21:06 |
| auggy | and we want to instantiate the Api Samples Base Class in order to call the _compare_results method on it, but have to navigate around some of the test magic | 21:06 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: virt: introduce libosinfo library to set hardware policy https://review.openstack.org/149625 | 21:06 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: use osinfo when configuring network model https://review.openstack.org/149627 | 21:06 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: adding a class to retrieve hardware properties https://review.openstack.org/149626 | 21:06 |
| auggy | so sdague proposed a way to do it but we want to make sure there isn't a better way | 21:06 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: use osinfo when configuring the disk bus https://review.openstack.org/149628 | 21:06 |
| auggy | lifeless: http://paste.openstack.org/show/484340/ | 21:07 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Add test coverage to functional api tests _compare_result method https://review.openstack.org/263440 | 21:07 |
| auggy | lifeless: ^^ | 21:07 |
| vladikr | jaypipes, I've updated the libosinfo patches, took a while to figure out the PropertyMock bit.. | 21:08 |
| openstackgerrit | Chuck Carmack proposed openstack/nova: REST API changes for user settable server description https://review.openstack.org/254950 | 21:08 |
| tjones | alaski: would you mind taking a look at https://review.openstack.org/#/c/265476/. I added more complete param verification but got feedback to remove it. So i would like your take since i added them due to a comment you made on the completeness (or lack of) the coverage. | 21:09 |
| lifeless | auggy: sdague: so, thats a patch - a better way for /what/ - like, what do you have in mind / what bits don't you like ? | 21:09 |
| alaski | tjones: sure | 21:09 |
| *** dslevin has joined #openstack-nova | 21:09 | |
| auggy | lifeless: well it just feels kind of hacky, i think we want to make sure that it's a good way to deal with the problem of instantiating a test class and then testing the methods in it | 21:09 |
| *** diana_clarke has quit IRC | 21:10 | |
| lifeless | ok, so the goal is: exercise the test helpers that are methods on (a test class) | 21:10 |
| lifeless | you can instantiate a test class with Class('methodname') | 21:10 |
| auggy | yes, and make sure they have test coverage so we can refactor them | 21:10 |
| lifeless | ok, so exercise it without changing the existing code, as a prelude to changing it | 21:11 |
| sdague | lifeless: yes, exactly that | 21:11 |
| lifeless | methodname has to exist, but won't be run - tests are instantiated, then run later | 21:11 |
| lifeless | so t = Class('anymethodatall') | 21:11 |
| lifeless | is valud | 21:11 |
| lifeless | bah | 21:11 |
| lifeless | valid | 21:11 |
| sdague | lifeless: oh, ok | 21:11 |
| sdague | I just looked at the unittest code, saw it wanted runTests, made that method | 21:12 |
| lifeless | it won't run any code at that point - __init__ on TestCase is very minimal | 21:12 |
| auggy | i thought i tried that and had the same problem with it not finding the "test" method | 21:12 |
| auggy | but i'll see if that works | 21:12 |
| lifeless | yes, you need to use an existing method, but it can be one of the existing tests | 21:12 |
| lifeless | or a helper method | 21:12 |
| sdague | ok, good to know | 21:12 |
| lifeless | or whatever. You won't be actually running the test, so - shrug. | 21:12 |
| sdague | right, was just trying to do this in the least weird way. | 21:12 |
| lifeless | if you do want to be able to run it, there's some helpful scaffolding + some juidicious mocking, but IIRC your tests don't actually run it anyhow | 21:13 |
| sdague | right, this is not going to run the test class, it's just going to run a set of internal methods which are going to later come out of the test hierarchy and into their own class (which is not a test class) | 21:13 |
| lifeless | yeah | 21:14 |
| lifeless | I'd use Class('somemethodname') | 21:14 |
| sdague | ok, cool | 21:14 |
| lifeless | subclassing it is indeed weird with the intent you have | 21:14 |
| auggy | ok i'll give that a try | 21:14 |
| sdague | so Class('setUp') | 21:14 |
| lifeless | since you'd also end up running all the base classes tests | 21:14 |
| lifeless | and I don't think you want that | 21:14 |
| lifeless | I added a small review of some of the tests too | 21:14 |
| sdague | lifeless: ok, you said any method :) | 21:14 |
| lifeless | a patch set back or so | 21:15 |
| *** tdurakov has quit IRC | 21:15 | |
| lifeless | sdague: setUp is fine. Just be sure to have a comment :) | 21:15 |
| lifeless | I'd put it in a helpper | 21:15 |
| sdague | yeh, agreed | 21:15 |
| lifeless | def get_SampleTestInstance(self): | 21:15 |
| lifeless | # .... | 21:15 |
| lifeless | return api...('setUp') | 21:15 |
| lifeless | bbiab | 21:16 |
| sdague | is runTest part of python testing interface, all test runners will have that? the current pass method there might be as clean as anything honestly. | 21:16 |
| lifeless | no, its a TemplateMethod pattern | 21:16 |
| lifeless | basically there to confuse the hell out of everyone | 21:17 |
| *** tdurakov has joined #openstack-nova | 21:17 | |
| auggy | lifeless: yeah i saw your comment, thanks for that suggestion | 21:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: vmware: cleanup unused volume connector 'instance' key https://review.openstack.org/269863 | 21:17 |
| *** gyee has joined #openstack-nova | 21:17 | |
| *** tdurakov has quit IRC | 21:17 | |
| *** eharney has joined #openstack-nova | 21:18 | |
| *** paul-carlton2 has quit IRC | 21:18 | |
| auggy | sdague: so i went ahead and did what lifeless suggested and i'm getting the error about not having the api version set | 21:20 |
| auggy | how do i set attributes on an object when calling it that way? | 21:20 |
| auggy | AttributeError: 'ApiSampleTestBase' object has no attribute 'api_major_version' | 21:21 |
| *** vladikr has quit IRC | 21:21 | |
| *** ijw_ has joined #openstack-nova | 21:21 | |
| auggy | i'll update my gist | 21:21 |
| *** ijw has quit IRC | 21:21 | |
| sdague | auggy: we still need that | 21:22 |
| auggy | i'm guessing it's something in setUp, so i'll poke around | 21:22 |
| sdague | api_major_version is used inside the comparitors | 21:23 |
| *** tdurakov has joined #openstack-nova | 21:23 | |
| *** ijw has joined #openstack-nova | 21:23 | |
| auggy | sdague: https://gist.github.com/missaugustina/59d378bfe465690eed39 | 21:23 |
| sdague | https://github.com/openstack/nova/blob/770666f8766074fc7df99c87a0ed9fc86e249b9f/nova/tests/functional/api_samples_test_base.py#L355 | 21:23 |
| sdague | which is also why I had to mock the self.compute out | 21:23 |
| *** e0ne has joined #openstack-nova | 21:23 | |
| auggy | ok so i'll see if i can do self.ast.api_major_version = 2 | 21:24 |
| sdague | I think we probably actually should stick with the wrapper, because that's only defined in the subclass with testscenarios iirc | 21:24 |
| *** jichen has quit IRC | 21:25 | |
| auggy | ok, i was able to set the attribute and the tests passed | 21:25 |
| sdague | ok, then that's fine | 21:25 |
| *** Sukhdev has quit IRC | 21:25 | |
| *** smatzek has quit IRC | 21:26 | |
| auggy | i am just a little confused by that syntax, so i want to try to put some comments in to clarify for future people encountering it | 21:26 |
| *** ijw_ has quit IRC | 21:26 | |
| sdague | auggy: ++ | 21:27 |
| sdague | I also think it needs to be "v2" | 21:27 |
| auggy | yeah that was me shorthanding | 21:27 |
| auggy | i'll update my gist with the line i added | 21:28 |
| auggy | alright updated - https://gist.github.com/missaugustina/59d378bfe465690eed39 | 21:28 |
| auggy | i'll update the rest of the code and also see about using the ExpectedException thing lifeless recommended | 21:29 |
| *** mriedem has quit IRC | 21:29 | |
| auggy | and add comments around what we're doing so it's clear to others | 21:29 |
| sdague | so I think I'd add all the modification to self.ast to the get_.... method | 21:29 |
| sdague | so you have the class fully formed from it | 21:29 |
| *** mdnadeem has joined #openstack-nova | 21:29 | |
| auggy | ok that makes sense | 21:30 |
| sdague | but, then I think we're good to go | 21:31 |
| auggy | yeah i think i just wasn't sure what all was going on there but then realized oh it's just being assigned to a varaible | 21:31 |
| sdague | yep | 21:31 |
| auggy | anyways yeah don't mind me, the magic was blinding me | 21:32 |
| sdague | heh, no worries | 21:32 |
| sdague | ok, time to call it a day, I'll look in the morning | 21:33 |
| *** e0ne has quit IRC | 21:33 | |
| auggy | sdague: no problem | 21:34 |
| auggy | sdague: i'll be on a plane in the afternoon hopefully with wifi en route to amsterdam | 21:34 |
| sdague | ok, cool | 21:35 |
| auggy | i'm going to spend a couple days in amsterdam visiting friends and getting time zone adjusted pre-midcycle | 21:35 |
| auggy | i was so jet lagged during the summit, i was like no, not making that mistake again | 21:35 |
| *** ihrachys has joined #openstack-nova | 21:35 | |
| sdague | like I said, I think this is close, so I think after doing this, it's probably ready to go | 21:35 |
| auggy | ok cool, let me know if there are other methods that need coverage and i can start working on those too | 21:35 |
| sdague | will do, I can leave those as comments for follow on patch | 21:36 |
| auggy | alright have a good evening and thanks for the help! | 21:36 |
| *** dslevin has quit IRC | 21:38 | |
| *** baoli has joined #openstack-nova | 21:38 | |
| *** baoli_ has joined #openstack-nova | 21:39 | |
| *** thangp has left #openstack-nova | 21:40 | |
| *** mdnadeem has quit IRC | 21:41 | |
| *** penick has joined #openstack-nova | 21:42 | |
| *** tdurakov has quit IRC | 21:42 | |
| *** baoli has quit IRC | 21:43 | |
| *** smatzek has joined #openstack-nova | 21:44 | |
| *** dslev has joined #openstack-nova | 21:45 | |
| *** otter768 has joined #openstack-nova | 21:46 | |
| *** ihrachys_ has joined #openstack-nova | 21:46 | |
| *** ihrachys has quit IRC | 21:46 | |
| *** baoli_ has quit IRC | 21:49 | |
| *** baoli has joined #openstack-nova | 21:49 | |
| *** baoli has quit IRC | 21:50 | |
| *** otter768 has quit IRC | 21:50 | |
| *** baoli has joined #openstack-nova | 21:50 | |
| *** diana_clarke has joined #openstack-nova | 21:52 | |
| *** vladik-train has joined #openstack-nova | 21:53 | |
| *** angdraug has quit IRC | 21:55 | |
| *** cburgess has quit IRC | 21:56 | |
| lifeless | auggy: just assign to it | 21:57 |
| lifeless | sdague: testscenarios doesn't subclass itself | 21:57 |
| *** cburgess has joined #openstack-nova | 21:57 | |
| lifeless | sdague: it does a copy + attribute assignment | 21:57 |
| auggy | lifeless: yeah thanks, i figured it out :) i was just overthinking cuz i do that | 21:57 |
| auggy | i was thinking that code was returning a ref to a function | 21:57 |
| *** eil397 has quit IRC | 21:57 | |
| auggy | not an instance | 21:57 |
| lifeless | if only it was haskell, you'd be right :) | 21:58 |
| auggy | see you UNDERSTAND MEEE | 21:58 |
| *** salv-orlando has joined #openstack-nova | 21:58 | |
| *** rk4n has joined #openstack-nova | 21:59 | |
| *** Guest51217 is now known as med_ | 22:00 | |
| *** med_ has quit IRC | 22:00 | |
| *** med_ has joined #openstack-nova | 22:00 | |
| *** pratikmallya has quit IRC | 22:01 | |
| *** baoli has quit IRC | 22:01 | |
| *** baoli has joined #openstack-nova | 22:01 | |
| *** lpetrut has quit IRC | 22:01 | |
| *** vladik-train_ has joined #openstack-nova | 22:04 | |
| *** vladik-train has quit IRC | 22:04 | |
| *** alejandrito has joined #openstack-nova | 22:05 | |
| *** vladik-train_ has joined #openstack-nova | 22:06 | |
| *** vladik-train_ has left #openstack-nova | 22:06 | |
| *** vladik-train_ has joined #openstack-nova | 22:06 | |
| rlrossit_ | dims: thanks for the review :). I just need your approval as leverage to hit mriedem harder :) | 22:09 |
| *** su_zhang has joined #openstack-nova | 22:11 | |
| *** Sukhdev has joined #openstack-nova | 22:11 | |
| *** smatzek has quit IRC | 22:12 | |
| *** eliqiao has quit IRC | 22:12 | |
| *** ivase has quit IRC | 22:13 | |
| *** baoli has quit IRC | 22:13 | |
| *** ivase has joined #openstack-nova | 22:13 | |
| *** eliqiao has joined #openstack-nova | 22:13 | |
| *** baoli has joined #openstack-nova | 22:14 | |
| *** nic has left #openstack-nova | 22:18 | |
| *** ivase has quit IRC | 22:18 | |
| *** nic has joined #openstack-nova | 22:18 | |
| *** thorst has quit IRC | 22:19 | |
| *** pratikmallya has joined #openstack-nova | 22:19 | |
| *** smatzek has joined #openstack-nova | 22:20 | |
| *** rcernin has quit IRC | 22:21 | |
| *** thorst has joined #openstack-nova | 22:22 | |
| *** Sukhdev has quit IRC | 22:22 | |
| *** rlrossit_ has quit IRC | 22:23 | |
| *** Sukhdev has joined #openstack-nova | 22:23 | |
| *** akshai has quit IRC | 22:24 | |
| *** baoli has quit IRC | 22:25 | |
| *** baoli has joined #openstack-nova | 22:26 | |
| *** thorst has quit IRC | 22:26 | |
| *** ctrath has quit IRC | 22:28 | |
| *** irenab has joined #openstack-nova | 22:28 | |
| *** baoli has quit IRC | 22:31 | |
| *** vladik-train_ has quit IRC | 22:33 | |
| *** ctrath has joined #openstack-nova | 22:34 | |
| *** zenoway has quit IRC | 22:34 | |
| *** jamielennox|away is now known as jamielennox | 22:35 | |
| *** akshai has joined #openstack-nova | 22:35 | |
| *** baoli has joined #openstack-nova | 22:36 | |
| *** davidlenwell has quit IRC | 22:37 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter https://review.openstack.org/189279 | 22:38 |
| *** tonytan4ever has quit IRC | 22:38 | |
| *** smatzek has quit IRC | 22:38 | |
| *** davidlenwell has joined #openstack-nova | 22:38 | |
| *** pratikmallya has quit IRC | 22:40 | |
| *** thorst has joined #openstack-nova | 22:40 | |
| openstackgerrit | Chuck Carmack proposed openstack/nova: config options: centralize 'spice' options https://review.openstack.org/264271 | 22:41 |
| *** eil397 has joined #openstack-nova | 22:42 | |
| *** bdrich has quit IRC | 22:43 | |
| andrewbogott | Can I get a +2 for https://review.openstack.org/#/c/261108/ ? Or is there some other process I should follow other than just periodically asking here? | 22:45 |
| *** thorst has quit IRC | 22:45 | |
| *** zenoway has joined #openstack-nova | 22:46 | |
| *** baoli_ has joined #openstack-nova | 22:46 | |
| edleafe | andrewbogott: send cash usually helps :) | 22:46 |
| *** baoli_ has quit IRC | 22:48 | |
| *** baoli_ has joined #openstack-nova | 22:49 | |
| *** baoli has quit IRC | 22:49 | |
| openstackgerrit | David Edery proposed openstack/nova: Fix create snapshot failure on VMs with SRIOV https://review.openstack.org/262341 | 22:50 |
| *** zenoway has quit IRC | 22:50 | |
| *** alejandrito has quit IRC | 22:51 | |
| *** rk4n has quit IRC | 22:55 | |
| *** dedery has quit IRC | 22:58 | |
| *** garyk has quit IRC | 22:58 | |
| *** garyk has joined #openstack-nova | 23:00 | |
| *** baoli_ has quit IRC | 23:00 | |
| *** baoli has joined #openstack-nova | 23:01 | |
| *** rk4n has joined #openstack-nova | 23:04 | |
| andrewbogott | edleafe: so just keep nagging, huh? | 23:04 |
| *** diana_clarke has quit IRC | 23:04 | |
| edleafe | andrewbogott: works as well as anything else! :) | 23:07 |
| *** dslev has quit IRC | 23:07 | |
| *** edtubill has quit IRC | 23:08 | |
| *** edtubill has joined #openstack-nova | 23:08 | |
| *** edtubill has quit IRC | 23:08 | |
| *** mragupat has quit IRC | 23:08 | |
| *** mdrabe has quit IRC | 23:09 | |
| *** annegentle has joined #openstack-nova | 23:10 | |
| openstackgerrit | Chuck Carmack proposed openstack/nova: config options: centralize 'spice' options https://review.openstack.org/269910 | 23:12 |
| *** mrkz has quit IRC | 23:12 | |
| *** baoli has quit IRC | 23:12 | |
| *** dimtruck is now known as zz_dimtruck | 23:12 | |
| *** ihrachys has joined #openstack-nova | 23:14 | |
| *** burt has quit IRC | 23:15 | |
| *** rk4n has quit IRC | 23:15 | |
| *** baoli has joined #openstack-nova | 23:15 | |
| *** ajayaa has quit IRC | 23:15 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack/nova: Log retries at INFO level per guidelines https://review.openstack.org/269915 | 23:16 |
| *** ihrachys_ has quit IRC | 23:16 | |
| *** ihrachys has quit IRC | 23:20 | |
| *** baoli has quit IRC | 23:25 | |
| *** thorst has joined #openstack-nova | 23:28 | |
| *** rk4n has joined #openstack-nova | 23:28 | |
| *** alex_xu has quit IRC | 23:30 | |
| *** alex_xu has joined #openstack-nova | 23:31 | |
| *** rk4n has quit IRC | 23:32 | |
| *** rk4n has joined #openstack-nova | 23:33 | |
| *** xyang1 has quit IRC | 23:37 | |
| *** doug-fish has quit IRC | 23:39 | |
| openstackgerrit | Vilobh Meshram proposed openstack/nova: ServiceGroup Refactoring: Add is_up to Service Obj https://review.openstack.org/269929 | 23:39 |
| *** thorst has quit IRC | 23:41 | |
| *** thorst has joined #openstack-nova | 23:42 | |
| *** thorst has quit IRC | 23:46 | |
| *** diana_clarke has joined #openstack-nova | 23:46 | |
| *** otter768 has joined #openstack-nova | 23:47 | |
| *** pratikmallya has joined #openstack-nova | 23:48 | |
| *** doug-fish has joined #openstack-nova | 23:49 | |
| *** ducttape_ has quit IRC | 23:50 | |
| *** irenab has quit IRC | 23:51 | |
| *** pumaranikar has quit IRC | 23:51 | |
| *** otter768 has quit IRC | 23:51 | |
| *** pumaranikar has joined #openstack-nova | 23:52 | |
| *** doug-fish has quit IRC | 23:54 | |
| *** pumaranikar has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
