| *** jerrygb has quit IRC | 00:00 | |
| *** jerrygb has joined #openstack-nova | 00:02 | |
| *** tonytan4ever has joined #openstack-nova | 00:02 | |
| *** salv-orl_ has quit IRC | 00:03 | |
| *** jamielennox|away is now known as jamielennox | 00:05 | |
| *** takedakn has quit IRC | 00:07 | |
| *** takedakn has joined #openstack-nova | 00:07 | |
| *** s-moriya has joined #openstack-nova | 00:08 | |
| *** salv-orlando has joined #openstack-nova | 00:09 | |
| *** aginwala has quit IRC | 00:11 | |
| zhenq1 | when running command nova --os-compute-api-version 2.0 list, it still shows calling v2.1 api, can anyone tell me why this happened? | 00:13 |
|---|---|---|
| *** mirrorbox has quit IRC | 00:16 | |
| *** Jeffrey4l has quit IRC | 00:17 | |
| *** aginwala has joined #openstack-nova | 00:17 | |
| *** mirrorbox has joined #openstack-nova | 00:17 | |
| *** jerrygb has quit IRC | 00:18 | |
| *** jerrygb has joined #openstack-nova | 00:18 | |
| *** ianbrown has quit IRC | 00:20 | |
| *** ianbrown has joined #openstack-nova | 00:20 | |
| *** smatzek has quit IRC | 00:20 | |
| *** ljxiash has joined #openstack-nova | 00:23 | |
| *** jerrygb has quit IRC | 00:23 | |
| *** Jeffrey4l has joined #openstack-nova | 00:23 | |
| *** tonytan4ever has quit IRC | 00:23 | |
| *** ljxiash_ has joined #openstack-nova | 00:24 | |
| *** ianbrown has quit IRC | 00:25 | |
| *** ianbrown_ has joined #openstack-nova | 00:25 | |
| *** mirrorbox has quit IRC | 00:27 | |
| *** ljxiash has quit IRC | 00:27 | |
| *** ljxiash_ has quit IRC | 00:28 | |
| *** zenoway has quit IRC | 00:29 | |
| *** betherly has quit IRC | 00:32 | |
| *** patrickeast has quit IRC | 00:32 | |
| *** mtanino has quit IRC | 00:33 | |
| *** dougwig has quit IRC | 00:35 | |
| *** chenli has joined #openstack-nova | 00:35 | |
| *** dougwig has joined #openstack-nova | 00:35 | |
| alex_xu | today is Nova API doc sprint! | 00:38 |
| alex_xu | gmann: oomichi tangchen ^ | 00:38 |
| *** aginwala has quit IRC | 00:39 | |
| *** mc_nair_ has joined #openstack-nova | 00:40 | |
| *** mc_nair has quit IRC | 00:40 | |
| *** ducttape_ has quit IRC | 00:40 | |
| *** ducttape_ has joined #openstack-nova | 00:40 | |
| notmorgan | so | 00:41 |
| *** otter768 has joined #openstack-nova | 00:41 | |
| *** yonglihe has quit IRC | 00:41 | |
| *** shaohe_feng has joined #openstack-nova | 00:42 | |
| *** takedakn has quit IRC | 00:43 | |
| *** ijw has joined #openstack-nova | 00:44 | |
| *** alejandrito has quit IRC | 00:46 | |
| gmann | alex_xu: yea, Thanks | 00:47 |
| gmann | alex_xu: so we start working on API etherpad right | 00:48 |
| alex_xu | gmann: yea | 00:48 |
| gmann | alex_xu: cool, i will start :) | 00:48 |
| alex_xu | gmann: cool, thanks :) | 00:48 |
| *** ijw has quit IRC | 00:51 | |
| *** ijw has joined #openstack-nova | 00:53 | |
| *** aginwala has joined #openstack-nova | 00:53 | |
| *** mirrorbox has joined #openstack-nova | 00:54 | |
| *** aginwala has quit IRC | 00:55 | |
| *** EinstCrazy has joined #openstack-nova | 00:56 | |
| *** RichardRaseley has quit IRC | 00:56 | |
| *** Sukhdev has joined #openstack-nova | 00:56 | |
| *** jinxing has joined #openstack-nova | 00:56 | |
| *** Sukhdev has quit IRC | 00:57 | |
| *** ijw has quit IRC | 00:57 | |
| *** thorst has joined #openstack-nova | 00:57 | |
| *** otter768 has quit IRC | 00:59 | |
| *** takashin has joined #openstack-nova | 00:59 | |
| *** changbl has quit IRC | 01:00 | |
| *** wyang has joined #openstack-nova | 01:02 | |
| *** hemna is now known as hemnafk | 01:04 | |
| *** thorst has quit IRC | 01:05 | |
| *** andrewbogott has joined #openstack-nova | 01:05 | |
| *** ljxiash has joined #openstack-nova | 01:08 | |
| *** andrewbogott has quit IRC | 01:08 | |
| *** andrewbogott has joined #openstack-nova | 01:08 | |
| oomichi | alex_xu: yeah, nice day to do that! | 01:09 |
| alex_xu | oomichi: yeah! | 01:09 |
| oomichi | alex_xu: gmann: how about https://review.openstack.org/#/c/253417/ ? | 01:09 |
| alex_xu | oomichi: I'm trying the microversion one. I'm not sure I picked a right one | 01:09 |
| oomichi | alex_xu: api-wg guideline? | 01:10 |
| alex_xu | oomichi: our concept doc | 01:10 |
| alex_xu | oomichi: we have section for it http://docs-draft.openstack.org/13/253513/1/check/gate-compute-api-guide/c0fa091//api-guide/build/html/microversions.html | 01:10 |
| oomichi | alex_xu: ah, I see. microversion concept is really necessary for us | 01:11 |
| alex_xu | oomichi: review guide, that is cool | 01:11 |
| alex_xu | oomichi: thanks for doing that! | 01:11 |
| gmann | oomichi: that nice. | 01:12 |
| gmann | alex_xu: yea, that will be nice. So you will update about more on how to use microversion from user perspective right | 01:12 |
| oomichi | alex_xu: thanks, nice to share a part of api-wg guideline | 01:12 |
| *** ljxiash_ has joined #openstack-nova | 01:13 | |
| oomichi | alex_xu: that comes from johnthetubaguy | 01:13 |
| *** changbl has joined #openstack-nova | 01:13 | |
| alex_xu | gmann: yea, let me try a build structure, then I will ask you guys help me review, if that is right, then let's put more detail | 01:13 |
| alex_xu | gmann: I guess we probably copy some use-case from sdague's blog https://dague.net/tag/microversions/ | 01:14 |
| gmann | alex_xu: yea, Thanks | 01:14 |
| *** changbl has quit IRC | 01:14 | |
| *** ZZelle_ has quit IRC | 01:14 | |
| *** ljxiash__ has joined #openstack-nova | 01:14 | |
| *** ljxias___ has joined #openstack-nova | 01:15 | |
| *** ljxiash has quit IRC | 01:15 | |
| *** suro-patz has quit IRC | 01:16 | |
| *** ljxias___ has quit IRC | 01:16 | |
| *** armax has quit IRC | 01:17 | |
| tangchen | Hi alex_xu, oomichi | 01:17 |
| alex_xu | tangchen: hi | 01:17 |
| *** ljxiash has joined #openstack-nova | 01:17 | |
| tangchen | alex_xu, oomichi: I just got to my office | 01:17 |
| oomichi | tangchen: morning | 01:17 |
| alex_xu | tangchen: cool, morning :) | 01:17 |
| tangchen | alex_xu: morning | 01:17 |
| alex_xu | tangchen: which city you are based? | 01:18 |
| *** penick has quit IRC | 01:18 | |
| *** ljxiash_ has quit IRC | 01:18 | |
| tangchen | alex_xu: Nanjing, china | 01:18 |
| alex_xu | tangchen: ah, cool, I'm at Beijing | 01:18 |
| *** ljxiash__ has quit IRC | 01:18 | |
| tangchen | alex_xu: Oh, I thought you are abroad. | 01:19 |
| tangchen | alex_xu: Seeing your conversation just now. Was that about the API doc ? | 01:20 |
| *** betherly has joined #openstack-nova | 01:20 | |
| alex_xu | tangchen: yeh, I'm not, still enjoy the Beijing's air pollution | 01:20 |
| alex_xu | tangchen: yes, today is doc sprint | 01:20 |
| *** ianbrown_ has quit IRC | 01:20 | |
| *** nithyag_ has joined #openstack-nova | 01:21 | |
| *** ijw has joined #openstack-nova | 01:21 | |
| *** jyuso1 has joined #openstack-nova | 01:21 | |
| *** NithyaG has quit IRC | 01:23 | |
| tangchen | alex_xu: Sorry I didn't pay much time on it. Will start to investigate the one I signed up for. | 01:23 |
| openstackgerrit | Andrew Bogott proposed openstack/nova: Prevent scheduling of instances on full hosts. https://review.openstack.org/242251 | 01:23 |
| *** coolsvap has quit IRC | 01:23 | |
| *** jyuso1 has quit IRC | 01:23 | |
| *** jyuso1 has joined #openstack-nova | 01:23 | |
| *** nikhil_k has joined #openstack-nova | 01:23 | |
| *** zhenguo has joined #openstack-nova | 01:23 | |
| alex_xu | tangchen: no worry, free to take task from https://etherpad.openstack.org/p/nova-v2.1-api-doc | 01:23 |
| *** tonytan4ever has joined #openstack-nova | 01:24 | |
| tangchen | alex_xu: Sure. Thanks.:) | 01:24 |
| tangchen | oomichi: Good, morning. Thanks again for reviewing and pushing the NMI BP. :) | 01:24 |
| alex_xu | tangchen: np :) | 01:25 |
| *** nikhil has quit IRC | 01:25 | |
| *** salv-orlando has quit IRC | 01:25 | |
| *** thorst has joined #openstack-nova | 01:25 | |
| *** thorst has quit IRC | 01:25 | |
| *** coolsvap has joined #openstack-nova | 01:25 | |
| oomichi | tangchen: welcome, nmi is one of the APIs I prefer ;) | 01:25 |
| *** ducttape_ has quit IRC | 01:25 | |
| *** yangyapeng has joined #openstack-nova | 01:26 | |
| *** links has joined #openstack-nova | 01:27 | |
| *** Sukhdev has joined #openstack-nova | 01:28 | |
| *** tonytan4ever has quit IRC | 01:28 | |
| oomichi | alex_xu: gmann: now nova repo contains multiple microversion docs like "how to bump", "how to implement" and basic design | 01:29 |
| oomichi | alex_xu: gmann: what will we put microversion thing as concept doc? | 01:30 |
| alex_xu | oomichi: that is for developer | 01:30 |
| gmann | yea | 01:30 |
| alex_xu | oomichi: johnthetubaguy gives suggestion put the use-case | 01:30 |
| gmann | oomichi: we need more on how to use microversion with some example | 01:30 |
| alex_xu | oomichi: like sdague's blog mentioned | 01:30 |
| alex_xu | gmann: +1 | 01:30 |
| alex_xu | gmann: I guess that will be in the api-ref? | 01:31 |
| openstackgerrit | Ryan McNair proposed openstack/nova: Add retry logic for detaching device using LibVirt https://review.openstack.org/227851 | 01:31 |
| gmann | alex_xu: example ? | 01:31 |
| oomichi | alex_xu: gmann: OK, concept doc should be use-case, right? | 01:31 |
| oomichi | alex_xu: gmann: basically | 01:31 |
| alex_xu | oomichi: yes | 01:31 |
| gmann | yea | 01:31 |
| oomichi | alex_xu: for all docs? or only for microversions? | 01:32 |
| alex_xu | gmann: probably a top section at http://developer.openstack.org/api-ref-compute-v2.1.html | 01:32 |
| alex_xu | gmann: if we said concept doc only for use-case, I only found that is for how-to | 01:32 |
| *** yangyapeng has quit IRC | 01:33 | |
| alex_xu | oomichi: concept doc? yes, concept doc is more about use-case | 01:33 |
| *** ducttape_ has joined #openstack-nova | 01:33 | |
| oomichi | alex_xu: I see, nice to contain the purpose of concept doc also in nova repo | 01:34 |
| *** changbl has joined #openstack-nova | 01:34 | |
| alex_xu | oomichi: good idea | 01:34 |
| gmann | alex_xu: yea, so with 'how to' + use case (like new feature can be get with microversion etc) right | 01:34 |
| *** rook has joined #openstack-nova | 01:34 | |
| gmann | oomichi: alex_xu yea, so at high level somewhere we can explain what doc is for what (concept guide, api ref) | 01:35 |
| oomichi | alex_xu: gmann: basically, I don't want to put the similar docs on different places because they easily get old and difficult to maintain | 01:35 |
| gmann | oomichi: True | 01:35 |
| alex_xu | oomichi: yes | 01:35 |
| alex_xu | oomichi: gmann there is 'Intended audience' in http://docs-draft.openstack.org/13/253513/1/check/gate-compute-api-guide/c0fa091//api-guide/build/html/ | 01:36 |
| *** baoli has joined #openstack-nova | 01:36 | |
| *** yasu has joined #openstack-nova | 01:39 | |
| *** patrickeast has joined #openstack-nova | 01:39 | |
| *** aginwala has joined #openstack-nova | 01:39 | |
| oomichi | alex_xu: nice pointing | 01:39 |
| oomichi | alex_xu: I am reading... | 01:39 |
| alex_xu | oomichi: probably we can put something at there to clear the scope | 01:40 |
| * oomichi much time is necessary for reading English doc :( | 01:40 | |
| oomichi | alex_xu: nice idea ! | 01:40 |
| * alex_xu have same English problem :( | 01:40 | |
| gmann | alex_xu: Thanks, yea that helps people | 01:41 |
| *** ssurana has quit IRC | 01:41 | |
| alex_xu | gmann: np | 01:41 |
| *** ssurana has joined #openstack-nova | 01:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/253911 | 01:42 |
| *** ducttape_ has quit IRC | 01:42 | |
| openstackgerrit | Vilobh Meshram proposed openstack/nova: Introduce Flavor Classes https://review.openstack.org/253306 | 01:43 |
| *** smoriya has joined #openstack-nova | 01:43 | |
| *** r-daneel has quit IRC | 01:43 | |
| *** unicell1 has joined #openstack-nova | 01:43 | |
| *** unicell has quit IRC | 01:45 | |
| *** unicell1 has quit IRC | 01:45 | |
| *** unicell has joined #openstack-nova | 01:45 | |
| *** ssurana has quit IRC | 01:45 | |
| *** s-moriya has quit IRC | 01:47 | |
| *** changbl has quit IRC | 01:47 | |
| oomichi | alex_xu: in the doc, words are inconsistent. eg: operator vs. administrator | 01:47 |
| *** ianbrown_ has joined #openstack-nova | 01:48 | |
| oomichi | I worked for news-paper company project before, and I tend to find this kind of conner cases.. | 01:49 |
| alex_xu | oomichi: I thought we should use the user which described at https://review.openstack.org/#/c/249812/4/api-guide/source/users.rst | 01:49 |
| *** Yingxin_ has joined #openstack-nova | 01:49 | |
| alex_xu | oomichi: wow, you have many different experience :) | 01:50 |
| *** akshai has quit IRC | 01:51 | |
| oomichi | alex_xu: thanks for the link. the patch doesn't mention the difference between operator vs. administrator | 01:51 |
| *** apoorvad has quit IRC | 01:51 | |
| oomichi | alex_xu: -1 even if johnthetubaguy's patch ;) | 01:52 |
| *** Yingxin has quit IRC | 01:53 | |
| *** Yingxin_ is now known as Yingxin | 01:53 | |
| *** jyuso1 has quit IRC | 01:53 | |
| alex_xu | oomichi: :) | 01:53 |
| openstackgerrit | Tony Breeds proposed openstack/nova: Mask the token used to allow access to consoles https://review.openstack.org/220622 | 01:54 |
| *** wyang has quit IRC | 01:55 | |
| *** rfolco_ has quit IRC | 01:56 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Remove required project_id from functional test templates https://review.openstack.org/254465 | 01:57 |
| *** 7F1AA32U1 has joined #openstack-nova | 01:58 | |
| *** changbl has joined #openstack-nova | 02:00 | |
| *** 7F1AA32U1 has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-nova | 02:01 | |
| *** XuZhixing has joined #openstack-nova | 02:01 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Make "ReSTful service" consistent https://review.openstack.org/254466 | 02:02 |
| openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Introduce Disk and Memory Monitor Plugin for Compute https://review.openstack.org/254467 | 02:03 |
| *** tjones has quit IRC | 02:04 | |
| *** yalie has joined #openstack-nova | 02:05 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix the endpoint of /v2 on concept doc https://review.openstack.org/254473 | 02:07 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix the endpoint of /v2 on concept doc https://review.openstack.org/254473 | 02:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/253901 | 02:09 |
| *** Sukhdev has quit IRC | 02:11 | |
| *** wyang has joined #openstack-nova | 02:11 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Generate api sample data without project id's to support v2.13 https://review.openstack.org/254484 | 02:13 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Update functional tests to support optional project id https://review.openstack.org/254485 | 02:13 |
| *** Jeffrey4l has quit IRC | 02:13 | |
| *** terryyao_ has joined #openstack-nova | 02:13 | |
| *** Jeffrey4l has joined #openstack-nova | 02:14 | |
| *** jerrygb has joined #openstack-nova | 02:14 | |
| *** yonglihe has joined #openstack-nova | 02:15 | |
| *** terryyao_ is now known as terry_yao | 02:16 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Update functional tests to support optional project id https://review.openstack.org/254485 | 02:16 |
| *** jerrygb has quit IRC | 02:16 | |
| *** terry_yao is now known as yterry | 02:16 | |
| *** yterry is now known as terry_yao | 02:17 | |
| *** zhenq1 has quit IRC | 02:17 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Calculate block_migration in virt drivers if it's None https://review.openstack.org/254101 | 02:21 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Return host and block_migration in task_api._execute() https://review.openstack.org/254102 | 02:21 |
| openstackgerrit | Alex Xu proposed openstack/nova: docs: add microversions description in the concept doc https://review.openstack.org/254490 | 02:21 |
| *** yangyape_ has joined #openstack-nova | 02:22 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Update functional tests to support optional project id https://review.openstack.org/254485 | 02:22 |
| *** thorst has joined #openstack-nova | 02:24 | |
| *** thorst has quit IRC | 02:25 | |
| *** thorst has joined #openstack-nova | 02:25 | |
| *** suro-patz has joined #openstack-nova | 02:27 | |
| alex_xu | gmann: oomichi let me know if this is ok for microversion https://review.openstack.org/#/c/254490/1 , and forgive me if it looks like terible... | 02:28 |
| * alex_xu spends an hour just write such few lines... | 02:28 | |
| oomichi | alex_xu: the content seems nice. nice coverage | 02:29 |
| alex_xu | oomichi: thanks :) | 02:29 |
| oomichi | alex_xu: but -1 for small points, sorry | 02:29 |
| alex_xu | oomichi: no, thanks for any -1, that will help me | 02:30 |
| oomichi | alex_xu: I finished to review patches on https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/complete-todo-in-api-concept-doc,n,z | 02:30 |
| alex_xu | oomichi: thanks, I saw that, will check with my patch | 02:31 |
| oomichi | alex_xu: yeah, please. I will re-check them soon after your post new patches | 02:31 |
| alex_xu | oomichi: ok, got it | 02:31 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/253901 | 02:32 |
| oomichi | alex_xu: the cache memory of my brain is not big, so nice to re-spin them quickly before forgetting the points ;) | 02:32 |
| alex_xu | oomichi: :) | 02:32 |
| *** otter768 has joined #openstack-nova | 02:32 | |
| *** thorst has quit IRC | 02:34 | |
| *** ijuwang has quit IRC | 02:38 | |
| *** browne has quit IRC | 02:39 | |
| *** jinxing has quit IRC | 02:40 | |
| *** vilobhmm11 has quit IRC | 02:41 | |
| *** vilobhmm11 has joined #openstack-nova | 02:41 | |
| *** ducttape_ has joined #openstack-nova | 02:41 | |
| *** houming has joined #openstack-nova | 02:42 | |
| oomichi | alex_xu: can you take a look at https://review.openstack.org/#/c/254466/ and https://review.openstack.org/#/c/254473/ ? | 02:42 |
| oomichi | alex_xu: both are easy for you | 02:43 |
| alex_xu | oomichi: ok, got it | 02:43 |
| oomichi | alex_xu: both changes a single line on each, thanks | 02:44 |
| chenli | hi, anyone can help review https://review.openstack.org/#/c/252237/ | 02:46 |
| *** shihanzhang has joined #openstack-nova | 02:46 | |
| *** shz has quit IRC | 02:49 | |
| *** yamahata has quit IRC | 02:51 | |
| *** baoli has quit IRC | 02:55 | |
| *** jgjhgsonchn88523 has joined #openstack-nova | 02:56 | |
| *** ianbrown_ has quit IRC | 02:57 | |
| *** Marga_ has quit IRC | 02:57 | |
| gmann | alex_xu: nice start, just few comments. | 03:00 |
| *** ducttape_ has quit IRC | 03:00 | |
| alex_xu | gmann: thanks | 03:00 |
| *** suro-patz has quit IRC | 03:00 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-nova | 03:01 | |
| *** aginwala has quit IRC | 03:03 | |
| *** akshai has joined #openstack-nova | 03:04 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Add separated section for extra specs and image properties https://review.openstack.org/253512 | 03:04 |
| openstackgerrit | Alex Xu proposed openstack/nova: Add more concepts for servers https://review.openstack.org/253292 | 03:04 |
| openstackgerrit | Alex Xu proposed openstack/nova: Add separated section for configure guest os https://review.openstack.org/253513 | 03:04 |
| alex_xu | oomichi: ^ just updated | 03:04 |
| oomichi | alex_xu: gmann: one small question: How about updating "updated" on "list versions" API when bumping a microversion? | 03:05 |
| oomichi | I am checking http://developer.openstack.org/api-ref-compute-v2.1.html#listVersionsv2.1 | 03:05 |
| oomichi | but the updated seems strange for me because of "2013-07-23T11:33:21Z" | 03:06 |
| oomichi | alex_xu: ok, will recheck soon | 03:06 |
| *** suro-patz has joined #openstack-nova | 03:07 | |
| *** aginwala has joined #openstack-nova | 03:07 | |
| *** edmondsw has quit IRC | 03:07 | |
| *** aginwala has quit IRC | 03:07 | |
| gmann | oomichi: i see, yea, we can update but that can be done by regenerating the sample file right | 03:08 |
| gmann | oomichi: alex_xu currently functional tests create new sample file (under /doc/api_sample) only if they donot exist | 03:09 |
| *** shaohe_feng has quit IRC | 03:09 | |
| oomichi | gmann: nice point. yeah, and new valid sample files are blocked to be created by the existing malformed sample files sometimes due to the behavior. | 03:10 |
| *** aginwala has joined #openstack-nova | 03:11 | |
| gmann | oomichi: yea, | 03:11 |
| *** ljxiash has quit IRC | 03:11 | |
| gmann | oomichi: i remember sdague added new env in tox.ini for sample file creation, let me search the patch | 03:12 |
| *** ljxiash has joined #openstack-nova | 03:12 | |
| *** unicell has quit IRC | 03:13 | |
| oomichi | gmann: that is interesting one :) | 03:13 |
| gmann | oomichi: https://review.openstack.org/#/c/253239/ | 03:13 |
| gmann | oomichi: yea, very simple way to generate | 03:13 |
| *** ljxiash_ has joined #openstack-nova | 03:13 | |
| gmann | oomichi: but your point is that we should have always updated one on api ref right? | 03:14 |
| *** ljxiash has quit IRC | 03:14 | |
| *** haomaiwang has quit IRC | 03:15 | |
| oomichi | alex_xu: done on your patches again, please see https://review.openstack.org/#/c/253513/ | 03:15 |
| *** haomaiwang has joined #openstack-nova | 03:15 | |
| *** haomaiwang has quit IRC | 03:16 | |
| *** haomaiwang has joined #openstack-nova | 03:16 | |
| *** haomaiwang has quit IRC | 03:17 | |
| oomichi | gmann: now we are genarating sample files by putting some values on the corresponding tpl files. | 03:17 |
| oomichi | gmann: and sometimes tpl files are malformed against JSON | 03:17 |
| oomichi | gmann: then malformed JSON sample files were generated | 03:18 |
| *** haomaiwang has joined #openstack-nova | 03:18 | |
| oomichi | gmann: ideally, it is nice to genarate valid JSON sample files with using python json library. | 03:18 |
| *** haomaiwang has quit IRC | 03:19 | |
| *** 17WAA5E9R has joined #openstack-nova | 03:19 | |
| *** 17WAA5E9R has quit IRC | 03:20 | |
| *** ijw has quit IRC | 03:20 | |
| *** haomaiwang has joined #openstack-nova | 03:20 | |
| *** haomaiwang has quit IRC | 03:21 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Update functional tests to support optional project id https://review.openstack.org/254485 | 03:21 |
| *** shuquan has joined #openstack-nova | 03:23 | |
| alex_xu | oomichi: emm..I should use deployed in line 600 also? | 03:24 |
| *** browne has joined #openstack-nova | 03:24 | |
| *** haomaiwang has joined #openstack-nova | 03:24 | |
| *** haomaiwang has quit IRC | 03:25 | |
| *** haomaiwang has joined #openstack-nova | 03:25 | |
| *** vladikr has joined #openstack-nova | 03:25 | |
| *** haomaiwang has quit IRC | 03:26 | |
| *** haomaiwang has joined #openstack-nova | 03:26 | |
| *** haomaiwang has quit IRC | 03:27 | |
| *** haomaiwang has joined #openstack-nova | 03:27 | |
| *** haomaiwang has quit IRC | 03:28 | |
| *** shuquan has quit IRC | 03:28 | |
| *** ducttape_ has joined #openstack-nova | 03:28 | |
| *** haomaiwang has joined #openstack-nova | 03:28 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Ensure consistency of ENV_REQUEST_ID https://review.openstack.org/254529 | 03:28 |
| *** haomaiwang has quit IRC | 03:29 | |
| *** salv-orlando has joined #openstack-nova | 03:29 | |
| *** haomaiwang has joined #openstack-nova | 03:29 | |
| *** haomaiwang has quit IRC | 03:30 | |
| openstackgerrit | Vilobh Meshram proposed openstack/nova: Introduce Flavor Classes https://review.openstack.org/253306 | 03:30 |
| *** 7F1AA34GJ has joined #openstack-nova | 03:30 | |
| *** 7F1AA34GJ has quit IRC | 03:31 | |
| *** shuquan has joined #openstack-nova | 03:31 | |
| *** ccard__ has joined #openstack-nova | 03:31 | |
| *** haomaiwang has joined #openstack-nova | 03:31 | |
| *** thorst has joined #openstack-nova | 03:32 | |
| *** haomaiwang has quit IRC | 03:32 | |
| alex_xu | oomichi: re: https://review.openstack.org/#/c/253513/2/api-guide/source/server_concepts.rst after reread those words, deploying server and deployed server are right, they describe different time | 03:33 |
| *** haomaiwa_ has joined #openstack-nova | 03:33 | |
| *** haomaiwa_ has quit IRC | 03:34 | |
| *** salv-orlando has quit IRC | 03:34 | |
| *** ccard_ has quit IRC | 03:34 | |
| *** haomaiwang has joined #openstack-nova | 03:34 | |
| *** haomaiwang has quit IRC | 03:35 | |
| *** jerrygb has joined #openstack-nova | 03:35 | |
| *** haomaiwa_ has joined #openstack-nova | 03:38 | |
| *** thorst has quit IRC | 03:39 | |
| *** vilobhmm11 has quit IRC | 03:42 | |
| *** terry_yao has quit IRC | 03:42 | |
| *** ccard_ has joined #openstack-nova | 03:44 | |
| *** unicell has joined #openstack-nova | 03:45 | |
| *** ccard__ has quit IRC | 03:46 | |
| openstackgerrit | javeme proposed openstack/nova: update task state for the confirm_resize https://review.openstack.org/244433 | 03:48 |
| *** jgjhgsonchn88523 has quit IRC | 03:49 | |
| gmann | oomichi: yea nice point | 03:50 |
| *** ducttape_ has quit IRC | 03:54 | |
| *** ssurana has joined #openstack-nova | 03:54 | |
| *** ducttape_ has joined #openstack-nova | 03:54 | |
| *** ianbrown has joined #openstack-nova | 03:55 | |
| *** jgjhgsonchn88523 has joined #openstack-nova | 03:57 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id and user-id when list server-groups https://review.openstack.org/209018 | 03:57 |
| *** haomaiwa_ has quit IRC | 04:01 | |
| *** baoli has joined #openstack-nova | 04:01 | |
| *** haomaiwang has joined #openstack-nova | 04:01 | |
| *** jgjhgsonchn88523 has quit IRC | 04:04 | |
| *** tonytan4ever has joined #openstack-nova | 04:05 | |
| *** darrenc is now known as darrenc_afk | 04:06 | |
| *** eliqiao has joined #openstack-nova | 04:06 | |
| *** eliqiao_ has quit IRC | 04:06 | |
| openstackgerrit | Jinxing Fang proposed openstack/nova: remove the qpid message driver https://review.openstack.org/254535 | 04:07 |
| *** mc_nair_ has quit IRC | 04:09 | |
| *** tonytan4ever has quit IRC | 04:09 | |
| *** aginwala has quit IRC | 04:13 | |
| *** Jeffrey4l has quit IRC | 04:14 | |
| *** aginwala has joined #openstack-nova | 04:16 | |
| *** ducttape_ has quit IRC | 04:17 | |
| *** chenli has quit IRC | 04:19 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: docs: add concept guide for certificate https://review.openstack.org/254537 | 04:20 |
| *** aginwala has quit IRC | 04:20 | |
| gmann | alex_xu: oomichi ^^ for certificate, please have look | 04:20 |
| *** shuquan has quit IRC | 04:25 | |
| *** shuquan has joined #openstack-nova | 04:26 | |
| *** otter768 has quit IRC | 04:27 | |
| *** tpatil has quit IRC | 04:34 | |
| *** mdrabe has joined #openstack-nova | 04:34 | |
| *** cfarquhar has quit IRC | 04:34 | |
| *** ianbrown has quit IRC | 04:35 | |
| *** baoli has quit IRC | 04:37 | |
| *** thorst has joined #openstack-nova | 04:38 | |
| *** darrenc_afk is now known as darrenc | 04:42 | |
| *** boris-42_ has quit IRC | 04:43 | |
| *** pratikmallya has joined #openstack-nova | 04:43 | |
| *** thorst has quit IRC | 04:44 | |
| openstackgerrit | javeme proposed openstack/python-novaclient: remove the default arguments "[]" https://review.openstack.org/254171 | 04:45 |
| *** masayukig has quit IRC | 04:47 | |
| *** terryyao_ has joined #openstack-nova | 04:47 | |
| *** shuquan has quit IRC | 04:50 | |
| *** chenli has joined #openstack-nova | 04:52 | |
| openstackgerrit | NanZhang proposed openstack/nova: live-migration: Update instance availability_zone https://review.openstack.org/254041 | 04:52 |
| *** yamahata has joined #openstack-nova | 04:53 | |
| *** cfarquhar has joined #openstack-nova | 04:54 | |
| *** cfarquhar has quit IRC | 04:54 | |
| *** cfarquhar has joined #openstack-nova | 04:54 | |
| *** masayukig has joined #openstack-nova | 04:54 | |
| *** dave-mccowan has quit IRC | 04:55 | |
| *** dave-mccowan has joined #openstack-nova | 04:57 | |
| *** abhishekk has joined #openstack-nova | 05:00 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-nova | 05:01 | |
| *** ianbrown has joined #openstack-nova | 05:02 | |
| *** suro-patz1 has joined #openstack-nova | 05:03 | |
| *** suro-patz has quit IRC | 05:05 | |
| *** fawadkhaliq has joined #openstack-nova | 05:12 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Add separated section for configure guest os https://review.openstack.org/253513 | 05:14 |
| *** dave-mccowan has quit IRC | 05:14 | |
| *** tbh has joined #openstack-nova | 05:14 | |
| *** sudipto has joined #openstack-nova | 05:15 | |
| *** dave-mccowan has joined #openstack-nova | 05:17 | |
| oomichi | gmann: I send a mail related to http203: http://lists.openstack.org/pipermail/openstack-dev/2015-December/081690.html | 05:19 |
| gmann | oomichi: nice Thanks. | 05:20 |
| *** amotoki has joined #openstack-nova | 05:20 | |
| *** Marga_ has joined #openstack-nova | 05:20 | |
| alex_xu | oomichi: just reploy some comments for https://review.openstack.org/#/c/254490/1/api-guide/source/microversions.rst | 05:20 |
| *** akshai has quit IRC | 05:22 | |
| oomichi | alex_xu: replied again ;) | 05:24 |
| alex_xu | oomichi: thanks, learned :) | 05:24 |
| *** Marga_ has quit IRC | 05:25 | |
| *** Sukhdev has joined #openstack-nova | 05:26 | |
| *** ankit_ag has quit IRC | 05:28 | |
| *** cfriesen has quit IRC | 05:28 | |
| *** shuquan has joined #openstack-nova | 05:30 | |
| *** Marga_ has joined #openstack-nova | 05:32 | |
| *** Marga_ has quit IRC | 05:32 | |
| *** Marga_ has joined #openstack-nova | 05:33 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Make admin consistent https://review.openstack.org/254549 | 05:37 |
| tbh | Hi, I am new to nova, I am following https://wiki.openstack.org/wiki/Nova/Mentoring, I am interested in https://bugs.launchpad.net/nova/+bug/1357751 | 05:40 |
| openstack | Launchpad bug 1357751 in OpenStack Compute (nova) "nova.tests.network.test_manager.AllocateTestCase should use mock" [Low,Confirmed] - Assigned to Aniruddha Singh Gautam (aniruddha-gautam) | 05:40 |
| tbh | as there is no activity for that bug, can I assign that bug to myself | 05:40 |
| *** aginwala has joined #openstack-nova | 05:41 | |
| oomichi | alex_xu: question about https://etherpad.openstack.org/p/nova-v2.1-api-doc | 05:41 |
| *** thorst has joined #openstack-nova | 05:42 | |
| *** claudiub has quit IRC | 05:42 | |
| oomichi | alex_xu: the etherpad seems to concentrate on api-site without concept guideline, right? | 05:42 |
| *** ljxiash_ has quit IRC | 05:42 | |
| *** ljxiash has joined #openstack-nova | 05:43 | |
| oomichi | alex_xu: when we found a problem on concept guideline(under api-guide/source/), where should we put patches? | 05:43 |
| *** dave-mccowan has quit IRC | 05:45 | |
| *** shuquan has quit IRC | 05:46 | |
| *** ljxiash has quit IRC | 05:47 | |
| *** shuquan has joined #openstack-nova | 05:47 | |
| *** amotoki has quit IRC | 05:48 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove XML description from extension concept https://review.openstack.org/254551 | 05:48 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Remove version hardcoding for 'show' method https://review.openstack.org/228578 | 05:49 |
| *** thorst has quit IRC | 05:49 | |
| *** jerrygb has quit IRC | 05:50 | |
| *** mdrabe has quit IRC | 05:51 | |
| *** jaosorior has joined #openstack-nova | 05:51 | |
| openstackgerrit | NanZhang proposed openstack/nova: live-migration: Update instance availability_zone https://review.openstack.org/254041 | 05:53 |
| *** ianbrown has quit IRC | 05:57 | |
| *** jaypipes has joined #openstack-nova | 05:57 | |
| *** ianbrown has joined #openstack-nova | 05:57 | |
| *** ianbrown_ has joined #openstack-nova | 05:57 | |
| *** ianbrown_ has quit IRC | 05:57 | |
| *** dims has quit IRC | 05:57 | |
| *** yamahata has quit IRC | 05:58 | |
| *** yamahata has joined #openstack-nova | 05:58 | |
| *** ljxiash has joined #openstack-nova | 05:59 | |
| *** ianbrown_ has joined #openstack-nova | 06:00 | |
| *** ianbrown has quit IRC | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-nova | 06:01 | |
| *** pradipta has joined #openstack-nova | 06:02 | |
| *** wolsen has quit IRC | 06:04 | |
| *** yamahata has quit IRC | 06:04 | |
| alex_xu | oomichi: yea, we didn't have place for concept guideline, probably if it is a todo, just add a patch for it. | 06:04 |
| *** wolsen has joined #openstack-nova | 06:05 | |
| *** chinmaya has joined #openstack-nova | 06:06 | |
| alex_xu | oomichi: but if you put in the etherpad, sounds ok also | 06:06 |
| oomichi | alex_xu: maybe no problem without the otherpad. https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/complete-todo-in-api-concept-doc,n,z works fine | 06:07 |
| *** moshele_1 has joined #openstack-nova | 06:07 | |
| openstackgerrit | Alex Xu proposed openstack/nova: docs: add microversions description in the concept doc https://review.openstack.org/254490 | 06:08 |
| *** moshele_1 has quit IRC | 06:08 | |
| *** donghao has joined #openstack-nova | 06:09 | |
| *** yamahata has joined #openstack-nova | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/252197 | 06:10 |
| *** shuquan has quit IRC | 06:15 | |
| *** ildikov has quit IRC | 06:16 | |
| *** ianbrown_ has quit IRC | 06:17 | |
| *** pratikmallya has quit IRC | 06:18 | |
| *** Sukhdev has quit IRC | 06:20 | |
| *** dims has joined #openstack-nova | 06:20 | |
| *** Sukhdev has joined #openstack-nova | 06:20 | |
| alex_xu | oomichi: ok, thanks | 06:20 |
| *** ianbrown has joined #openstack-nova | 06:23 | |
| *** Sukhdev has quit IRC | 06:25 | |
| *** moshele has joined #openstack-nova | 06:25 | |
| *** esracelik has joined #openstack-nova | 06:26 | |
| *** suro-patz1 has quit IRC | 06:28 | |
| *** suro-patz has joined #openstack-nova | 06:28 | |
| *** otter768 has joined #openstack-nova | 06:28 | |
| *** yangyape_ is now known as Yangyapeng | 06:28 | |
| *** takashin has left #openstack-nova | 06:29 | |
| *** XuZhixing has quit IRC | 06:31 | |
| *** haomaiwang has quit IRC | 06:32 | |
| *** otter768 has quit IRC | 06:33 | |
| *** 18WABB396 has joined #openstack-nova | 06:33 | |
| *** rook has quit IRC | 06:34 | |
| *** rook has joined #openstack-nova | 06:34 | |
| *** ljxiash has quit IRC | 06:34 | |
| *** ljxiash has joined #openstack-nova | 06:35 | |
| *** donghao has quit IRC | 06:37 | |
| *** garyk has joined #openstack-nova | 06:37 | |
| *** shuquan has joined #openstack-nova | 06:38 | |
| *** e0ne has joined #openstack-nova | 06:38 | |
| *** Jeffrey4l has joined #openstack-nova | 06:39 | |
| *** ljxiash has quit IRC | 06:40 | |
| *** ianbrown has quit IRC | 06:40 | |
| *** sahid has joined #openstack-nova | 06:40 | |
| *** ianbrown has joined #openstack-nova | 06:40 | |
| *** ianbrown has quit IRC | 06:41 | |
| *** ianbrown_ has joined #openstack-nova | 06:41 | |
| *** suro-patz has quit IRC | 06:43 | |
| *** ljxiash has joined #openstack-nova | 06:43 | |
| *** aginwala has quit IRC | 06:43 | |
| *** ianbrown__ has joined #openstack-nova | 06:43 | |
| *** ianbrown_ has quit IRC | 06:43 | |
| *** e0ne has quit IRC | 06:45 | |
| *** aginwala has joined #openstack-nova | 06:46 | |
| *** eliqiao has quit IRC | 06:48 | |
| *** thorst has joined #openstack-nova | 06:48 | |
| *** salv-orlando has joined #openstack-nova | 06:49 | |
| *** smoriya has quit IRC | 06:49 | |
| *** e0ne has joined #openstack-nova | 06:49 | |
| *** vilobhmm11 has joined #openstack-nova | 06:50 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/253901 | 06:50 |
| *** e0ne has quit IRC | 06:52 | |
| *** aginwala has quit IRC | 06:52 | |
| *** salv-orlando has quit IRC | 06:54 | |
| *** thorst has quit IRC | 06:54 | |
| *** unicell has quit IRC | 06:57 | |
| *** unicell has joined #openstack-nova | 06:58 | |
| *** ankit_ag has joined #openstack-nova | 07:00 | |
| *** 18WABB396 has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-nova | 07:01 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova: Use stevedore for scheduler host manager https://review.openstack.org/246476 | 07:01 |
| *** e0ne has joined #openstack-nova | 07:02 | |
| *** mjura has joined #openstack-nova | 07:03 | |
| *** ljxiash has quit IRC | 07:04 | |
| *** ljxiash has joined #openstack-nova | 07:05 | |
| *** eliqiao has joined #openstack-nova | 07:07 | |
| *** houming has quit IRC | 07:08 | |
| *** haomaiwang has quit IRC | 07:09 | |
| *** haomaiwang has joined #openstack-nova | 07:09 | |
| *** dims has quit IRC | 07:11 | |
| *** houming has joined #openstack-nova | 07:11 | |
| *** scheuran has joined #openstack-nova | 07:14 | |
| *** houming has quit IRC | 07:16 | |
| *** vilobhmm11 has quit IRC | 07:18 | |
| *** e0ne has quit IRC | 07:20 | |
| *** e0ne has joined #openstack-nova | 07:21 | |
| *** terryyao_ has quit IRC | 07:21 | |
| *** shuquan has quit IRC | 07:22 | |
| *** nkrinner has joined #openstack-nova | 07:22 | |
| *** aginwala has joined #openstack-nova | 07:25 | |
| *** terryyao_ has joined #openstack-nova | 07:25 | |
| *** shuquan has joined #openstack-nova | 07:25 | |
| *** haomaiwang has quit IRC | 07:28 | |
| *** haomaiwa_ has joined #openstack-nova | 07:28 | |
| *** dims has joined #openstack-nova | 07:31 | |
| *** ljxiash has quit IRC | 07:31 | |
| *** terryyao_ has quit IRC | 07:31 | |
| *** ljxiash has joined #openstack-nova | 07:33 | |
| *** doron_afk has joined #openstack-nova | 07:36 | |
| *** terryyao_ has joined #openstack-nova | 07:39 | |
| *** fawadkhaliq has quit IRC | 07:41 | |
| *** fawadkhaliq has joined #openstack-nova | 07:42 | |
| *** houming has joined #openstack-nova | 07:42 | |
| *** jaypipes has quit IRC | 07:44 | |
| *** lpetrut has joined #openstack-nova | 07:45 | |
| tangchen | Hi alex_xu, oomichi, I think we can start to push the NMI (crash dump) work. Would you please review this patch when you are free ? | 07:48 |
| tangchen | alex_xu, oomichi: https://review.openstack.org/#/c/208794/ | 07:48 |
| tangchen | alex_xu, oomichi: It is an improvement for the merged libvirt inject_nmi() API. | 07:49 |
| tangchen | alex_xu, oomichi: Thanks. | 07:49 |
| *** jichen has joined #openstack-nova | 07:51 | |
| *** dims has quit IRC | 07:52 | |
| *** shuquan has quit IRC | 07:53 | |
| *** thorst has joined #openstack-nova | 07:53 | |
| *** shuquan has joined #openstack-nova | 07:54 | |
| *** wyang has quit IRC | 07:55 | |
| *** e0ne has quit IRC | 07:56 | |
| *** thorst has quit IRC | 07:58 | |
| openstackgerrit | Michal Pryc proposed openstack/nova: Implements proper UUID format for the ComputeAPITestCase https://review.openstack.org/254398 | 08:00 |
| *** zenoway has joined #openstack-nova | 08:00 | |
| openstackgerrit | Cindia-blue proposed openstack/nova: VMware: Enable Fault tolerance on VM https://review.openstack.org/251807 | 08:02 |
| *** ildikov has joined #openstack-nova | 08:03 | |
| *** jerrygb has joined #openstack-nova | 08:06 | |
| *** matrohon has joined #openstack-nova | 08:07 | |
| *** rk4n has joined #openstack-nova | 08:07 | |
| BobBall_AWOL | mordred edleafe: Seems like a temporary failure to download some packages - has resolved itself. | 08:09 |
| *** BobBall_AWOL is now known as BobBall | 08:09 | |
| *** jerrygb has quit IRC | 08:12 | |
| *** rdopiera has joined #openstack-nova | 08:13 | |
| openstackgerrit | NanZhang proposed openstack/nova: live-migration: Update instance availability_zone https://review.openstack.org/254041 | 08:13 |
| *** eliqiao_ has joined #openstack-nova | 08:15 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Compute: Adds driver disk_gb instance overhead estimation https://review.openstack.org/234283 | 08:15 |
| openstackgerrit | Cindia-blue proposed openstack/nova: VMware: Enable Fault tolerance on VM https://review.openstack.org/251807 | 08:17 |
| *** rook has quit IRC | 08:18 | |
| *** eliqiao has quit IRC | 08:18 | |
| *** rook has joined #openstack-nova | 08:18 | |
| *** klkumar has joined #openstack-nova | 08:23 | |
| *** liverpooler has joined #openstack-nova | 08:26 | |
| *** liverpooler has quit IRC | 08:26 | |
| *** gcb has joined #openstack-nova | 08:27 | |
| *** otter768 has joined #openstack-nova | 08:29 | |
| *** liverpooler has joined #openstack-nova | 08:30 | |
| *** mpavone has joined #openstack-nova | 08:30 | |
| *** moshele has quit IRC | 08:33 | |
| *** otter768 has quit IRC | 08:34 | |
| *** markus_z has joined #openstack-nova | 08:37 | |
| *** klkumar has quit IRC | 08:38 | |
| *** yonglihe has quit IRC | 08:41 | |
| *** yamahata has quit IRC | 08:43 | |
| *** jlanoux has joined #openstack-nova | 08:44 | |
| *** lyanchih has joined #openstack-nova | 08:48 | |
| *** aginwala has quit IRC | 08:49 | |
| *** klkumar has joined #openstack-nova | 08:52 | |
| *** aginwala has joined #openstack-nova | 08:53 | |
| *** eliqiao_ is now known as eliqiao | 08:54 | |
| *** rk4n has quit IRC | 08:54 | |
| *** links has quit IRC | 08:55 | |
| *** browne has quit IRC | 08:56 | |
| *** thorst has joined #openstack-nova | 08:56 | |
| *** paul-carlton2 has joined #openstack-nova | 08:58 | |
| bauzas | good morning Nova | 09:00 |
| *** aginwala has quit IRC | 09:01 | |
| *** aginwala has joined #openstack-nova | 09:01 | |
| markus_z | good morning bauzas | 09:02 |
| oomichi | bauzas: morning | 09:02 |
| bauzas | markus_z: are you better ? :) | 09:02 |
| markus_z | bauzas: Yeah, it will do I guess, thanks for asking | 09:03 |
| oomichi | johnthetubaguy: bauzas: can you take a look at https://review.openstack.org/#/c/253417 ? | 09:03 |
| markus_z | bauzas: We already have hit spec-freeze, right? | 09:03 |
| *** mpavone has quit IRC | 09:03 | |
| *** e0ne has joined #openstack-nova | 09:03 | |
| bauzas | markus_z: yeah | 09:03 |
| oomichi | johnthetubaguy: bauzas: it is nice to know reviewing points related to api thing | 09:04 |
| *** thorst has quit IRC | 09:04 | |
| bauzas | oomichi: reviewing it now | 09:04 |
| markus_z | bauzas: Because my blueprint is still open: https://review.openstack.org/#/c/234291/ | 09:04 |
| bauzas | oomichi: alex_xu: correct me if I'm wrong but it's doc day? | 09:04 |
| oomichi | bauzas: yeah, right. doc day | 09:05 |
| bauzas | well, it's end of the day for folks living in an earlier TZ :p | 09:05 |
| bauzas | oomichi: okay, any pointers I should look to ? I saw some etherpad | 09:05 |
| oomichi | bauzas: patches are ready to be reviewed: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/complete-todo-in-api-concept-doc,n,z | 09:05 |
| *** mpavone has joined #openstack-nova | 09:05 | |
| bauzas | \o/ | 09:05 |
| oomichi | bauzas: the etherpad is https://etherpad.openstack.org/p/nova-v2.1-api-doc | 09:05 |
| bauzas | oomichi: okay, I'll pick those too | 09:06 |
| oomichi | bauzas: cool! :) | 09:06 |
| markus_z | bauzas: I guess I did the status wrong again: https://blueprints.launchpad.net/nova/+spec/libvirt-virtlogd | 09:06 |
| esracelik | markus_z: hi markus, i hope you're better | 09:06 |
| markus_z | esracelik: Hi esra, yes I am, thanks for asking. | 09:07 |
| esracelik | markus_z: markus could you check https://review.openstack.org/#/c/254092/ | 09:07 |
| bauzas | markus_z: I guess johnthetubaguy had no time to look thru all the open specs yet | 09:07 |
| markus_z | esracelik: yepp, checking it right now | 09:07 |
| esracelik | markus_z: ok, i will have some questions then | 09:07 |
| *** links has joined #openstack-nova | 09:09 | |
| *** aginwala_ has joined #openstack-nova | 09:10 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests https://review.openstack.org/249017 | 09:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: do not filter out any SRIOV Physical Functions https://review.openstack.org/249016 | 09:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 09:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: db: adding columns to PciDevice table https://review.openstack.org/249013 | 09:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: adding a parent_addr field to the PciDevice object https://review.openstack.org/249015 | 09:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: db: querry to retrieve all pci device by parent address https://review.openstack.org/249014 | 09:11 |
| *** rgerganov has joined #openstack-nova | 09:11 | |
| markus_z | esracelik: looks good! I have to double-check the help text. It would also be good to separate the work into two patches. One does the movement and the second patch enhances the help text. It easier to grasp what happened when doing a review. | 09:12 |
| *** ndipanov has quit IRC | 09:12 | |
| markus_z | esracelik: Which open questions do you have? | 09:12 |
| esracelik | markus_z: ok should also I seperate this one? | 09:13 |
| *** ndipanov has joined #openstack-nova | 09:13 | |
| markus_z | esracelik: Yes, that would be helpful. | 09:13 |
| *** shakamunyi has joined #openstack-nova | 09:13 | |
| rgerganov | johnthetubaguy: could you please take a look at https://review.openstack.org/#/c/228778/ ? it is trivial to implement and very important for the VM console story; it also has a lot of +1s | 09:13 |
| bauzas | oomichi: I'm reviewing https://review.openstack.org/#/c/253417/3/doc/source/code-review.rst,cm but I need more understanding | 09:14 |
| *** aginwala has quit IRC | 09:14 | |
| oomichi | bauzas: ok, please go ahead | 09:14 |
| bauzas | oomichi: is that you saw some API changes not enforcing https://review.openstack.org/#/c/253417/3/doc/source/code-review.rst,cm ? | 09:14 |
| oomichi | bauzas: yeah, many times | 09:15 |
| bauzas | oomichi: I guess it's also for new changes, right? not a clear enforcement for the existing code? | 09:15 |
| *** aginwala_ has quit IRC | 09:15 | |
| esracelik | markus_z: ok, i will.. my first question is: there are lots of config files in different directories, but we are merging them in one directory. I mean wouldn't it better to create subdirectories in /nova/conf | 09:15 |
| oomichi | bauzas: only for new API or new API changes | 09:15 |
| esracelik | markus_z: like /nova/conf/virt/configdrive.py | 09:15 |
| bauzas | oomichi: so I guess adding an hacking check wouldn't help because we would fail because of the existing bits? | 09:15 |
| oomichi | bauzas: yeah, right. | 09:16 |
| *** ildikov has quit IRC | 09:16 | |
| *** eglynn has joined #openstack-nova | 09:16 | |
| markus_z | esracelik: What would you move to the folder "virt"? | 09:16 |
| bauzas | oomichi: are you planning to have some consistency eventually ? I know mitaka prios so I wonder if it could be a Nutella stuff | 09:16 |
| esracelik | markus_z: nova/conf/virt/configdrive.py,netutils.py,agent.py so on | 09:17 |
| bauzas | oomichi: see, you said "reviewers should read all of the guidelines, but they are very long", so my concern is maybe to see how we could automatically prevent that | 09:18 |
| *** ildikov has joined #openstack-nova | 09:18 | |
| bauzas | oomichi: because indeed, I have to admit that I'm very not familiar with the API-WG rules | 09:18 |
| bauzas | (that's also why I should refrain to +W an API change :) ) | 09:18 |
| esracelik | markus_z: or just one virt.py in nova/conf that includes all options in /nova/virt directory | 09:19 |
| oomichi | bauzas: and it is difficult to apply this guideline to the existing APIs | 09:19 |
| oomichi | bauzas: then, as you said, difficult to have some pep8 rules for blocking invalid api changes. | 09:20 |
| *** shuquan has quit IRC | 09:20 | |
| markus_z | esracelik: Let me rephrase it, what would be the grouping criteria of "nova/conf/virt"? | 09:20 |
| oomichi | bauzas: so that is a reason why I required you also to see it ;) | 09:20 |
| markus_z | esracelik: The first usage of an option? | 09:20 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 09:20 |
| oomichi | bauzas: I don't ask you +A for that ;) | 09:20 |
| esracelik | markus_z: just the current location of the option. for example all options in nova/virt directory | 09:21 |
| *** yassine__ has joined #openstack-nova | 09:21 | |
| bauzas | oomichi: true thing, hence me not +W'ing that change :) | 09:21 |
| oomichi | bauzas: that is very nice way as reviewer! | 09:22 |
| *** tonytan4ever has joined #openstack-nova | 09:22 | |
| oomichi | bauzas: thanks much! | 09:22 |
| markus_z | esracelik: Are you worried about the number of modules in "nova/conf" or do you want to have a "location indicator" or another reasoning? | 09:22 |
| *** shakamunyi has quit IRC | 09:23 | |
| *** shuquan has joined #openstack-nova | 09:23 | |
| *** sfinucan has joined #openstack-nova | 09:23 | |
| esracelik | markus_z yes actually the number of modules in nova/conf.. maybe not that important | 09:23 |
| *** danpb has joined #openstack-nova | 09:24 | |
| markus_z | esracelik: I wouldn't worry about that right now, to be honest. If we want to introduce subfolders in the future, then it can be easily done within the "nova/conf/" folder and its "__init__.py" without anyone noticing it outside. | 09:26 |
| *** pradipta has quit IRC | 09:26 | |
| markus_z | because they "outside" world imports "nova.conf" | 09:26 |
| *** tonytan4ever has quit IRC | 09:26 | |
| markus_z | that's the abstraction layer and interface here | 09:27 |
| esracelik | markus_z: yes right.. second question: for my following patches, will I add my previous works as a dependency | 09:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Change logging level for 'oslo_db' https://review.openstack.org/240271 | 09:28 |
| esracelik | markus_z: like this one https://review.openstack.org/#/c/252687/ | 09:29 |
| markus_z | esracelik: Yes, that would be the best. In Gerrit you will see them as "related changes". | 09:29 |
| markus_z | tracy builds unrelated dependencies there, I wouldn't recommend it. I will talk to her. | 09:30 |
| openstackgerrit | esracelik proposed openstack/nova: Config options: centralize "configdrive" options https://review.openstack.org/254092 | 09:30 |
| esracelik | markus_z: i removed help texts for now | 09:31 |
| markus_z | They way she is doing it will prevent that the volume changes will merge before the guestfs changes are merged. But they are unrelated. | 09:31 |
| *** rotbeard has joined #openstack-nova | 09:32 | |
| markus_z | esracelik: cool, I have to admit you're pretty fast | 09:32 |
| esracelik | markus_z: oh, I meant adding unrelated dependencies as she did.. i will not then. | 09:32 |
| *** tbh has quit IRC | 09:33 | |
| esracelik | markus_z: :) thanks, i hope it allways goes that way | 09:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise PCI options https://review.openstack.org/253732 | 09:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci_passthrough_whitelist' documentation https://review.openstack.org/243335 | 09:33 |
| *** pratikmallya has joined #openstack-nova | 09:34 | |
| *** chenli has quit IRC | 09:34 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: enginefacade: 'migration' https://review.openstack.org/243496 | 09:34 |
| markus_z | esracelik: The workflow doesn't change that much after this task, that's the cool thing about it. | 09:35 |
| esracelik | markus_z: this work is pretty fun for me. and instructive too | 09:37 |
| alex_xu | bauzas: yea, today is doc sprint :) | 09:37 |
| *** macsz has quit IRC | 09:39 | |
| ankit_ag | ndipanov: hi | 09:40 |
| ndipanov | hi ankit_ag | 09:40 |
| ankit_ag | ndipanov: Could you please check my reply on https://review.openstack.org/#/c/221162/ | 09:40 |
| ndipanov | ankit_ag, good question | 09:41 |
| sfinucan | sdague: Morning. Could you cast an eye over this change once more. Interested in your take on it, given my feedback https://review.openstack.org/#/c/240271/ | 09:41 |
| ankit_ag | ndipanov: :D | 09:41 |
| *** terryyao_ has quit IRC | 09:41 | |
| ankit_ag | ndipanov: The only issue with previous PS I see is an additional DB call | 09:42 |
| ndipanov | ankit_ag, yeah | 09:42 |
| ndipanov | that and the fact that it is going to be an inaccurate list of instances that it uses | 09:42 |
| openstackgerrit | Paul Carlton proposed openstack/nova: Mask the token used to allow access to consoles https://review.openstack.org/220622 | 09:43 |
| alex_xu | bauzas: free to review those patch https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/complete-todo-in-api-concept-doc,n,z and free to pick any one you are expert on that. | 09:43 |
| *** ildikov has quit IRC | 09:45 | |
| openstackgerrit | garyk proposed openstack/nova: Scheduler: honor the glance metadata for hypervisor details https://review.openstack.org/254206 | 09:45 |
| *** macsz has joined #openstack-nova | 09:46 | |
| ankit_ag | ndipanov: do you have any quick solution in mind | 09:47 |
| *** ljxiash has quit IRC | 09:48 | |
| *** tbh has joined #openstack-nova | 09:48 | |
| alex_xu | For the people they just wakeup, today is nova api doc sprint! | 09:48 |
| *** ljxiash has joined #openstack-nova | 09:49 | |
| *** ljxiash_ has joined #openstack-nova | 09:50 | |
| ndipanov | ankit_ag, will comment in a sec | 09:50 |
| ankit_ag | ndipanov: sure, thank you | 09:51 |
| *** moshele has joined #openstack-nova | 09:51 | |
| *** ljxiash_ has quit IRC | 09:52 | |
| *** ljxiash has quit IRC | 09:54 | |
| *** pratikmallya has quit IRC | 09:54 | |
| bauzas | alex_xu: sure, that's what I'm doing | 09:54 |
| *** StevenK has quit IRC | 09:56 | |
| bauzas | oomichi: still around ? | 09:56 |
| bauzas | oomichi: https://review.openstack.org/#/c/254551/1/api-guide/source/extensions.rst,cm removes all the section, not only about XML | 09:56 |
| bauzas | oomichi: including the headers doc, etc. | 09:57 |
| *** moshele has quit IRC | 09:57 | |
| *** StevenK has joined #openstack-nova | 09:57 | |
| oomichi | bauzas: yep, untill the end of nova-api meeting ;-) I got +A from my family for overtime work today | 09:57 |
| alex_xu | bauzas: thanks :) | 09:57 |
| *** moshele has joined #openstack-nova | 09:57 | |
| *** markmc has joined #openstack-nova | 09:57 | |
| alex_xu | oomichi: heh :) | 09:57 |
| oomichi | bauzas: yeah, that seems confused. actually I removed the first part on my env. but actually, the section mentioned about XML thing | 09:58 |
| bauzas | oomichi: hah | 09:58 |
| *** ildikov has joined #openstack-nova | 09:59 | |
| eliqiao | hi what the problem with xen ci? | 09:59 |
| *** houming has quit IRC | 09:59 | |
| oomichi | bauzas: In JSON, there is not any namespace. | 09:59 |
| eliqiao | why can not access ci logs http://logs.openstack.xenproject.org/02/254102/2/check/dsvm-tempest-xen/71cf9fb | 10:00 |
| *** macsz has quit IRC | 10:00 | |
| *** aix has joined #openstack-nova | 10:01 | |
| *** macsz has joined #openstack-nova | 10:01 | |
| *** wyang has joined #openstack-nova | 10:01 | |
| oomichi | eliqiao: oops, I am not sure the reason | 10:02 |
| oomichi | eliqiao: do you face the same problem even after rechecks? | 10:02 |
| openstackgerrit | jichenjc proposed openstack/nova: Add hypervisor, aggregates, migration description https://review.openstack.org/250737 | 10:02 |
| eliqiao | oomichi: I have 2 patches facing this issue, just did recheck, will see it later. | 10:03 |
| *** zhenguo has quit IRC | 10:03 | |
| ankit_ag | ndipanov: Thanks for the time and your valuable comments | 10:04 |
| oomichi | eliqiao: the first xen job succeeded and we can see the log | 10:04 |
| *** thorst has joined #openstack-nova | 10:04 | |
| oomichi | eliqiao: on your patch | 10:05 |
| bauzas | oomichi: right, but it was saying "In JSON, the alias must be used" so I felt that "The volumes element is defined in the ``RS-CBS`` namespace" was referring to the alias, not the namespace with JSON | 10:05 |
| ndipanov | ankit_ag, thanks for the kind words :) | 10:05 |
| bauzas | oomichi: that said, I totally get we can't just cut one phrase :) | 10:05 |
| eliqiao | oomichi: okay, I will double check it again. | 10:05 |
| oomichi | eliqiao: nice to do just "xen: recheck" | 10:05 |
| eliqiao | oomichi: sure, thanks. | 10:06 |
| oomichi | eliqiao: welcome :) | 10:06 |
| oomichi | bauzas: ok, I need to dig it more ;) | 10:07 |
| bauzas | oomichi: that said, that whole sentence is just japanese to me, so maybe I'm wrong | 10:07 |
| *** tbh has quit IRC | 10:08 | |
| openstackgerrit | jichenjc proposed openstack/nova: Change some wording on server_concepts.rst https://review.openstack.org/248063 | 10:09 |
| *** thorst has quit IRC | 10:09 | |
| oomichi | bauzas: heh.. yeah, that seems French for me instead :) | 10:09 |
| oomichi | bauzas: anyways, I need to add the reason why we can remove the sentence on the commit message | 10:10 |
| markus_z | alex_xu: Where will I see the result of the api doc sprint? At http://developer.openstack.org/api-ref-compute-v2.1.html ? | 10:13 |
| alex_xu | markus_z: there is etherpad to check the work https://etherpad.openstack.org/p/nova-v2.1-api-doc | 10:13 |
| alex_xu | markus_z: and there are two api doc need improve, one is concept doc, another one is api-ref http://developer.openstack.org/api-ref-compute-v2.1.html | 10:14 |
| *** jistr has joined #openstack-nova | 10:14 | |
| markus_z | alex_xu: Ah, cool. And it's not yet swagger, right? | 10:15 |
| alex_xu | markus_z: this is the link for concept doc http://developer.openstack.org/api-guide/compute/ | 10:15 |
| alex_xu | markus_z: yes, it's not yet swagger. whatever we have swagger or not, we still need those content for docs | 10:16 |
| alex_xu | so current the api team focus on the doc content improvement | 10:16 |
| *** ljxiash has joined #openstack-nova | 10:16 | |
| openstackgerrit | jichenjc proposed openstack/nova: Change some wording on server_concepts.rst https://review.openstack.org/248063 | 10:16 |
| markus_z | alex_xu: still awesome! It was always a bit hard for me to understand the rest api in detail. | 10:17 |
| alex_xu | markus_z: yeh, the current api ref is really need more detail | 10:18 |
| *** usdsd has joined #openstack-nova | 10:21 | |
| *** fawadkhaliq has quit IRC | 10:21 | |
| *** ljxiash has quit IRC | 10:21 | |
| *** aix has quit IRC | 10:21 | |
| *** fawadkhaliq has joined #openstack-nova | 10:21 | |
| johnthetubaguy | rgerganov: I am not sure I understood the big picture with how those tokens get used, seemed to be assuming code out of the Nova tree was using the tokens, which seems confusing. But we are frozen for new specs and blueprints now, so I have added it to the exception request list | 10:24 |
| *** salv-orlando has joined #openstack-nova | 10:25 | |
| *** ssurana has quit IRC | 10:26 | |
| johnthetubaguy | rgerganov: actually I get it now, you just get the connection info from the token | 10:27 |
| *** usdsd has left #openstack-nova | 10:28 | |
| *** gcb has quit IRC | 10:29 | |
| *** salv-orlando has quit IRC | 10:30 | |
| *** otter768 has joined #openstack-nova | 10:30 | |
| *** gcb has joined #openstack-nova | 10:31 | |
| *** rk4n has joined #openstack-nova | 10:32 | |
| *** aix has joined #openstack-nova | 10:33 | |
| *** otter768 has quit IRC | 10:35 | |
| garyk | danpb: can you please look at https://review.openstack.org/254206 | 10:36 |
| openstackgerrit | huan proposed openstack/nova: XenAPI: Do not rely on XenAPI to get device names https://review.openstack.org/213112 | 10:37 |
| *** cdent has joined #openstack-nova | 10:37 | |
| *** links has quit IRC | 10:37 | |
| tangchen | johnthetubaguy: Hi John, since the NMI (crash dump) BP has been approved, and the spec was also merged, would you please help to remove the -2 of these patches ? | 10:38 |
| tangchen | https://review.openstack.org/#/c/202617/ | 10:39 |
| tangchen | https://review.openstack.org/#/c/202605/ | 10:39 |
| tangchen | https://review.openstack.org/#/c/234691/ | 10:39 |
| tangchen | johnthetubaguy: I'll restart this work from this week. | 10:39 |
| tangchen | johnthetubaguy: Thanks. | 10:39 |
| johnthetubaguy | tangchen: must have missed those, will go check that out | 10:40 |
| tangchen | johnthetubaguy: Not in a hurry. Please take your time. Thanks a lot. :) | 10:41 |
| openstackgerrit | Adelina Tuvenie proposed openstack/nova: Moves OVS related code to a common location https://review.openstack.org/179727 | 10:41 |
| johnthetubaguy | tangchen: no worries, doing it now before I forget, should have all gone now | 10:42 |
| tangchen | johnthetubaguy: Yes. Thank you:) | 10:43 |
| ndipanov | johnthetubaguy, what am I missing here https://review.openstack.org/#/c/199205/ | 10:43 |
| *** ljxiash has joined #openstack-nova | 10:44 | |
| ndipanov | johnthetubaguy, iiuc how major versions work we should currently support 4. and 5. with the proxy class, and then drop 4 on both client and server in Nandos right? | 10:45 |
| johnthetubaguy | ndipanov: I have basically got bauzas not to bump the major version, as there is no need to that, and its easier to do that at the end of the release | 10:45 |
| ndipanov | johnthetubaguy, my thoughts exactly | 10:45 |
| johnthetubaguy | yeah, its overly complicated as we add extra stuff to do it now | 10:45 |
| bauzas | ndipanov: johnthetubaguy: yeah I need to respon | 10:46 |
| bauzas | respin | 10:46 |
| johnthetubaguy | cools | 10:46 |
| ndipanov | bauzas, OK let me just comment so that there's no confusion | 10:46 |
| johnthetubaguy | sorry, I may not have updated my comments after changing | 10:46 |
| johnthetubaguy | chatting | 10:46 |
| johnthetubaguy | ndipanov: cool, thanks | 10:46 |
| *** mpavone has quit IRC | 10:47 | |
| ndipanov | did we decide on the N name? | 10:47 |
| bauzas | Nutella ! | 10:47 |
| ndipanov | is it Nandos? | 10:47 |
| bauzas | Nando is fair | 10:47 |
| johnthetubaguy | ndipanov: not sure we did the vote yet, but I may have just missed it | 10:47 |
| johnthetubaguy | either of those, an I am going to be hungry for a whole 6 months | 10:48 |
| bauzas | https://wiki.openstack.org/wiki/Release_Naming nothing yet | 10:48 |
| bauzas | Nachos ! | 10:48 |
| *** zhenq has joined #openstack-nova | 10:48 | |
| *** ljxiash has quit IRC | 10:48 | |
| ndipanov | bauzas, not sure why the bottom patch doesn't want to recheck | 10:49 |
| ndipanov | you may actually have to re-push the series | 10:49 |
| bauzas | ndipanov: lemme see | 10:49 |
| bauzas | ndipanov: I saw you rechecking this morning | 10:49 |
| *** rook has quit IRC | 10:49 | |
| *** rook has joined #openstack-nova | 10:50 | |
| *** shuquan has quit IRC | 10:51 | |
| ndipanov | bauzas, I don't think it did anything | 10:51 |
| *** rfolco_ has joined #openstack-nova | 10:54 | |
| *** shihanzhang has quit IRC | 10:55 | |
| *** shz has joined #openstack-nova | 10:56 | |
| johnthetubaguy | bauzas: ndipanov: I think that might really need a reverify rather than recheck, but its usually easier to just rebase at this point | 10:57 |
| openstackgerrit | Adelina Tuvenie proposed openstack/nova: Adds Hyper-V OVS ViF driver https://review.openstack.org/140045 | 10:57 |
| bauzas | johnthetubaguy: reverify = recheck now | 10:57 |
| *** links has joined #openstack-nova | 10:58 | |
| bauzas | but lemme doublecheck the zuul layout | 10:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise PCI options https://review.openstack.org/253732 | 10:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci_passthrough_whitelist' documentation https://review.openstack.org/243335 | 10:58 |
| johnthetubaguy | bauzas: hmm, yeah, I remember something about that now | 10:58 |
| johnthetubaguy | bauzas: you have pep8 failures on the follow up patch now, somehow? | 10:58 |
| *** Yangyapeng has quit IRC | 10:58 | |
| ndipanov | yeah I thought that too | 10:58 |
| johnthetubaguy | bauzas: it says: ./nova/scheduler/filters/numa_topology_filter.py:48:41: F821 undefined name 'instance' | 10:58 |
| bauzas | johnthetubaguy: yeah it's due to an automatic rebase when testing | 10:58 |
| bauzas | johnthetubaguy: so gerrit doesn't show the mere | 10:59 |
| bauzas | merge | 10:59 |
| johnthetubaguy | yeah | 10:59 |
| johnthetubaguy | bauzas: if you refresh it, I can fast approve it for you | 10:59 |
| bauzas | johnthetubaguy: but I was wanting to land the metrics stuff | 10:59 |
| * bauzas interesting... | 10:59 | |
| johnthetubaguy | yeah, I would just refresh the lot | 10:59 |
| *** EinstCrazy has quit IRC | 10:59 | |
| openstackgerrit | Alex Xu proposed openstack/nova: docs: update old stuff in version section https://review.openstack.org/254687 | 10:59 |
| bauzas | unless I'm blind, I no longer see a recheck way for the check pipeline | 10:59 |
| bauzas | https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml | 11:00 |
| *** lyanchih has quit IRC | 11:01 | |
| bauzas | nvm, I *am* blind https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L20 | 11:01 |
| *** openstackgerrit has quit IRC | 11:02 | |
| bauzas | ndipanov: so Zuul was probably ill this morning | 11:02 |
| *** openstackgerrit has joined #openstack-nova | 11:03 | |
| bauzas | ndipanov: I just did a recheck and it works | 11:03 |
| ndipanov | I don't yaml bauzas | 11:03 |
| *** lucas-dinner is now known as lucasagomes | 11:04 | |
| bauzas | it just says that you can trigger again a new jenkins call if a comment is left using the above regex :) | 11:04 |
| bauzas | for the check pipeline | 11:04 |
| bauzas | johnthetubaguy: and if you see the yaml file, you'll see that reverify triggers the check pipeline, and no longer the gate pipeline | 11:05 |
| johnthetubaguy | cools | 11:05 |
| *** salv-orlando has joined #openstack-nova | 11:06 | |
| *** john5223 is now known as zz_john5223 | 11:06 | |
| *** haomaiwa_ has quit IRC | 11:06 | |
| *** mgoddard has joined #openstack-nova | 11:07 | |
| *** thorst has joined #openstack-nova | 11:08 | |
| *** aysyd has joined #openstack-nova | 11:09 | |
| *** ljxiash has joined #openstack-nova | 11:11 | |
| *** paul-carlton2 has quit IRC | 11:11 | |
| *** tbh has joined #openstack-nova | 11:12 | |
| *** sahid has quit IRC | 11:13 | |
| *** thorst has quit IRC | 11:13 | |
| *** dguitarbite has quit IRC | 11:13 | |
| *** Kennan has quit IRC | 11:14 | |
| *** ljianbj has quit IRC | 11:14 | |
| *** ljxiash has quit IRC | 11:14 | |
| *** salv-orlando has quit IRC | 11:14 | |
| *** ljianbj has joined #openstack-nova | 11:14 | |
| *** Jeffrey4l has quit IRC | 11:15 | |
| *** Kennan has joined #openstack-nova | 11:17 | |
| *** sahid has joined #openstack-nova | 11:21 | |
| openstackgerrit | Dina Belova proposed openstack/python-novaclient: Add profiling support to novaclient https://review.openstack.org/254699 | 11:23 |
| tbh | Hi, I am new to nova, I am following https://wiki.openstack.org/wiki/Nova/Mentoring, I am interested in https://bugs.launchpad.net/nova/+bug/1357751 | 11:23 |
| openstack | Launchpad bug 1357751 in OpenStack Compute (nova) "nova.tests.network.test_manager.AllocateTestCase should use mock" [Low,Confirmed] - Assigned to Aniruddha Singh Gautam (aniruddha-gautam) | 11:23 |
| tbh | as there is no activity for that bug, can I assign that bug to myself | 11:23 |
| tbh | or do you have any suggestions for the beginners? | 11:24 |
| *** EinstCrazy has joined #openstack-nova | 11:24 | |
| *** paul-carlton2 has joined #openstack-nova | 11:25 | |
| *** dguitarbite has joined #openstack-nova | 11:26 | |
| *** sahid has quit IRC | 11:26 | |
| *** gszasz has joined #openstack-nova | 11:27 | |
| *** jlanoux has quit IRC | 11:27 | |
| *** jlanoux has joined #openstack-nova | 11:27 | |
| *** smatzek has joined #openstack-nova | 11:28 | |
| openstackgerrit | Dina Belova proposed openstack/python-novaclient: Add profiling support to novaclient https://review.openstack.org/254699 | 11:28 |
| *** Kennan has quit IRC | 11:29 | |
| *** ljianbj has quit IRC | 11:29 | |
| *** ptm_away is now known as PaulMurray | 11:29 | |
| *** ljianbj has joined #openstack-nova | 11:29 | |
| sfinucan | tbh: I don't know what the "official" stance is, but I normally count a three month period to mean you can take it | 11:30 |
| sfinucan | Two months is still long enough however as the bug doesn't look like a significant one. I'd say you can start working on it (Ask forgiveness, not permission etc.) | 11:31 |
| *** ociuhandu has quit IRC | 11:31 | |
| rgerganov | alaski, mikal: could you please review https://review.openstack.org/#/c/228778/ ? it already has +2 and I believe it's straightforward | 11:31 |
| rgerganov | johnthetubaguy, thanks a lot for the review | 11:32 |
| *** Kennan has joined #openstack-nova | 11:32 | |
| tbh | sfinucan, I have already sent the mail to the assignee, but no reply yet, so asking in IRC for guidelines | 11:33 |
| openstackgerrit | Alex Xu proposed openstack/nova: docs: update old stuff in version section https://review.openstack.org/254687 | 11:34 |
| sfinucan | tbh: Yes, so you have. IMO it's been long enough: work away and just apologise if necessary (which is v. unlikely) | 11:34 |
| tbh | sfinucan, sure, I will mention in the bug comments, thanks for the suggestion. | 11:35 |
| sfinucan | tbh: No problem. Best of luck | 11:36 |
| *** nagyz has joined #openstack-nova | 11:36 | |
| nagyz | danpb, are you around? | 11:36 |
| danpb | nagyz: hi | 11:37 |
| *** ljxiash has joined #openstack-nova | 11:39 | |
| *** Kennan has quit IRC | 11:39 | |
| *** ljianbj has quit IRC | 11:39 | |
| *** ljxiash has quit IRC | 11:39 | |
| *** ljianbj has joined #openstack-nova | 11:40 | |
| openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 11:40 |
| *** jlanoux has quit IRC | 11:40 | |
| *** tbh has quit IRC | 11:40 | |
| *** jinxing has joined #openstack-nova | 11:40 | |
| *** jlanoux has joined #openstack-nova | 11:41 | |
| sfinucan | alex_xu: Question on the doc sprint? | 11:41 |
| alex_xu | sfinucan: yup | 11:41 |
| sfinucan | alex_xu: The etherpad refers to 'https://github.com/openstack/nova/tree/master/doc/source/v2' to find TODOs | 11:42 |
| *** sahid has joined #openstack-nova | 11:42 | |
| sfinucan | I was expecting a TODO.rst file or similar, but the link is dead | 11:42 |
| sfinucan | Stupid question, but do I just grep the docs folder for 'TODO'? :) | 11:42 |
| *** Kennan has joined #openstack-nova | 11:42 | |
| openstackgerrit | jichenjc proposed openstack/python-novaclient: Allow command line for virtual-interface-list https://review.openstack.org/254707 | 11:43 |
| *** ljianbj has quit IRC | 11:43 | |
| *** Kennan has quit IRC | 11:43 | |
| *** moorryan has quit IRC | 11:44 | |
| *** abhishekk has quit IRC | 11:44 | |
| alex_xu | sfinucan: oops, the api concept doc was moved before, let me correct the link, thanks for point it out | 11:44 |
| alex_xu | sfinucan: there is the right link https://github.com/openstack/nova/tree/master/api-guide/source | 11:44 |
| openstackgerrit | Dina Belova proposed openstack/python-novaclient: Add profiling support to novaclient https://review.openstack.org/254699 | 11:44 |
| openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 11:44 |
| garyk | johnthetubaguy: bauzas: any chance that you guys can please look at https://review.openstack.org/254206. this breaks stable/liberty | 11:45 |
| sfinucan | alex_xu: OK, thanks. Do I just grep for TODOs and make sure they're not already in progress? | 11:45 |
| *** mikal has quit IRC | 11:46 | |
| sdague | BobBall: gah, in python 2.4 urlparse is not a named tuple it's just a tuple | 11:46 |
| sfinucan | Again, sorry if it's a stupid question heh | 11:46 |
| *** ljianbj has joined #openstack-nova | 11:46 | |
| alex_xu | sfinucan: yes, you can, but you should check https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/complete-todo-in-api-concept-doc,n,z also, maybe there is patch for some TODO already | 11:46 |
| *** Kennan has joined #openstack-nova | 11:46 | |
| *** yassine__ has quit IRC | 11:46 | |
| *** mikal has joined #openstack-nova | 11:47 | |
| alex_xu | sfinucan: there also have patch add more todo, like this https://review.openstack.org/253292 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce freeze filesystems https://review.openstack.org/249140 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce thaw filesystems https://review.openstack.org/249141 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: replace direct libvirt's call AbortJobBlock https://review.openstack.org/249138 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: move find_disk to Guest's object https://review.openstack.org/249139 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "snapshot" to Guest's object https://review.openstack.org/249353 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce block_stats to return device stats https://review.openstack.org/251288 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "pause" to Guest's object https://review.openstack.org/249834 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: wrapper list_guests to Host's object https://review.openstack.org/249835 | 11:47 |
| *** ljianbj has quit IRC | 11:47 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "shutdown" to Guest's object https://review.openstack.org/249833 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce get_job_info to Guest's object https://review.openstack.org/250740 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: configure migrate max downtime https://review.openstack.org/250739 | 11:47 |
| *** Kennan has quit IRC | 11:47 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "abort_job" to Guest's object https://review.openstack.org/250738 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "migrate" to Guest's object https://review.openstack.org/250365 | 11:47 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: check graphic/serial consoles at pre_live_migration step https://review.openstack.org/254709 | 11:47 |
| *** yasu has quit IRC | 11:47 | |
| sfinucan | alex_xu: OK, I'll see if I can find something I can do. Thanks for the help :) | 11:47 |
| *** ljianbj has joined #openstack-nova | 11:47 | |
| alex_xu | sfinucan: and free to update any part of the doc if you found the info is old, or something missed | 11:49 |
| sfinucan | alex_xu: Yup, I have a few ideas | 11:50 |
| *** Kennan has joined #openstack-nova | 11:50 | |
| bauzas | garyk: sorry I missed your bugfix | 11:51 |
| bauzas | I'll have to take some PTO this afternoon but I'll be back by the EU evening | 11:52 |
| bauzas | \o | 11:52 |
| alex_xu | sfinucan: thanks for idea and help :) | 11:52 |
| openstackgerrit | Paul Murray proposed openstack/nova: Drop JSON decoding for supported_instances https://review.openstack.org/254231 | 11:56 |
| *** tbh has joined #openstack-nova | 11:56 | |
| openstackgerrit | Sean Dague proposed openstack/nova: retool xen glance plugin to work with urls https://review.openstack.org/254331 | 11:56 |
| garyk | bauzas: np | 11:57 |
| *** pratikmallya has joined #openstack-nova | 11:57 | |
| * alex_xu reminders api meeting in 2mins | 11:58 | |
| *** houming has joined #openstack-nova | 11:59 | |
| ankit_ag | Hi Cores: can someone please help reviewing https://review.openstack.org/#/c/185549/ | 12:02 |
| *** e0ne has quit IRC | 12:03 | |
| BobBall | 'fraid so sdague :) | 12:04 |
| *** dedery_ has joined #openstack-nova | 12:04 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Add ppc to supported arch for NUMA https://review.openstack.org/245765 | 12:05 |
| sdague | BobBall: ok, well that new version hopefully works | 12:05 |
| sdague | BobBall: it would be really nice if there was a way to test that stuff without having to wait for xenci full runs | 12:06 |
| *** jerrygb has joined #openstack-nova | 12:09 | |
| BobBall | I know. | 12:10 |
| BobBall | johnthetubaguy has some WIP patches for unit testing the plugins | 12:10 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: config options: Centralise PCI options https://review.openstack.org/253732 | 12:10 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci_passthrough_whitelist' documentation https://review.openstack.org/243335 | 12:10 |
| *** e0ne has joined #openstack-nova | 12:11 | |
| *** thorst has joined #openstack-nova | 12:12 | |
| *** Kevin_Zheng has joined #openstack-nova | 12:13 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Adds HostCapabilities object model and updates ComputeNode object https://review.openstack.org/228280 | 12:13 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Adds host_capabilities conf options group https://review.openstack.org/250166 | 12:13 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: driver: Adds get_hypervisor_capabilities method https://review.openstack.org/254124 | 12:13 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: Adds get_hypervisor_capabilities implementation https://review.openstack.org/254125 | 12:13 |
| *** jerrygb has quit IRC | 12:13 | |
| nagyz | danpb, regarding the qemu patches you're planning - is there anything we can help with? is the code available somewhere in git or accessible form? | 12:14 |
| *** fawadkhaliq has quit IRC | 12:14 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Add ppc to supported arch for NUMA https://review.openstack.org/245765 | 12:17 |
| kashyap | nagyz: This is probably what is you're looking for - https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html | 12:17 |
| nagyz | kashyap, ah thanks | 12:17 |
| kashyap | nagyz: I have setup locally a tree to test it, been meaning to diligently test it, but got distracted. | 12:19 |
| *** thorst has quit IRC | 12:19 | |
| *** Kennan has quit IRC | 12:20 | |
| *** tbh has quit IRC | 12:21 | |
| *** tbh has joined #openstack-nova | 12:23 | |
| paul-carlton2 | is Microsoft Hyper-V CI check voting for nova? | 12:24 |
| *** Kennan has joined #openstack-nova | 12:27 | |
| markus_z | paul-carlton2: According to https://wiki.openstack.org/wiki/ThirdPartySystems/Hyper-V_CI it is not. But that could be out-dated. | 12:28 |
| markus_z | paul-carlton2: but there is a yaml file which configures that, let me look for a sec | 12:28 |
| paul-carlton2 | ta | 12:31 |
| *** otter768 has joined #openstack-nova | 12:31 | |
| *** ankit_ag has quit IRC | 12:33 | |
| markus_z | paul-carlton2: I thought it's hidden in here https://git.openstack.org/cgit/openstack-infra/project-config/tree/zuul/layout.yaml but I don't find the specific bit, sorry. | 12:33 |
| paul-carlton2 | thanks, no worries | 12:34 |
| *** EinstCra_ has joined #openstack-nova | 12:35 | |
| *** sudipto has quit IRC | 12:35 | |
| *** links has quit IRC | 12:36 | |
| *** otter768 has quit IRC | 12:36 | |
| *** shuquan has joined #openstack-nova | 12:36 | |
| *** fawadkhaliq has joined #openstack-nova | 12:37 | |
| *** snikitin has quit IRC | 12:37 | |
| *** EinstCrazy has quit IRC | 12:37 | |
| ndipanov | moshele, lbelivea hey I might be a bit late for the meeting today | 12:38 |
| ndipanov | feel free to start without me | 12:39 |
| ndipanov | or we can start at 20 past | 12:39 |
| lbelivea | ndipanov: np | 12:39 |
| lbelivea | ndipanov: better start with all of us, will wait | 12:40 |
| *** fawadkhaliq has quit IRC | 12:40 | |
| *** jaosorior has quit IRC | 12:40 | |
| *** fawadkhaliq has joined #openstack-nova | 12:40 | |
| *** shuquan has quit IRC | 12:41 | |
| *** jaosorior has joined #openstack-nova | 12:42 | |
| *** thorst has joined #openstack-nova | 12:44 | |
| *** Kennan has quit IRC | 12:48 | |
| *** yassine__ has joined #openstack-nova | 12:49 | |
| *** mgoddard has quit IRC | 12:52 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix the endpoint of /v2 on concept doc https://review.openstack.org/254473 | 12:54 |
| *** Kennan has joined #openstack-nova | 12:54 | |
| *** hparekh2 has joined #openstack-nova | 12:56 | |
| moshele | ndipanov: ok | 12:57 |
| esracelik | markus_z: markus, i want to start working on hyperv options, is it ok? | 12:57 |
| markus_z | esracelik: Yeah, sure, go ahead! | 12:58 |
| *** ducttape_ has joined #openstack-nova | 12:58 | |
| markus_z | esracelik: Any further open questions to this point? | 12:59 |
| *** yangyapeng has joined #openstack-nova | 12:59 | |
| esracelik | markus_z: so i need a base repository, do you checkout nova in another directory or open a branch in the current? | 12:59 |
| markus_z | esracelik: I open a new branch in the current repository. That's the best way imo. | 12:59 |
| markus_z | esracelik: Git makes it super easy to switch among those branches. | 13:00 |
| *** gmann_ has joined #openstack-nova | 13:00 | |
| esracelik | markus_z: but with git checkout -b newbranch I get all previous changes in the new branch | 13:00 |
| sdague | alex_xu / gmann ok api_samples discussion time | 13:00 |
| gmann_ | sdague: yup | 13:00 |
| alex_xu | sdague: yup | 13:00 |
| markus_z | esracelik: You have to specify that the base is remote/master branch | 13:01 |
| alex_xu | sdague: so that will add 2.xx for all the apis? | 13:01 |
| sdague | ok, so first up lets talk about doc samples location | 13:01 |
| *** ducttape_ has quit IRC | 13:02 | |
| sdague | we're like to have a set of doc samples which don't have project_id in them so that we can test with the existing api_samples mechanism | 13:02 |
| gmann_ | sdague: so we will maintain both with and without project-id sample? | 13:03 |
| sdague | and not change all the existing docs, because it should still work with project id | 13:03 |
| danpb | nagyz: most recent posting of patches was https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html | 13:03 |
| sdague | gmann_: right | 13:03 |
| sdague | so my thought is we're adding a microversion for this | 13:03 |
| sdague | we can build a whole new doc set at that microversion | 13:03 |
| markus_z | esracelik: something like this: git checkout -b bp/centralize-config-options remotes/origin/master | 13:03 |
| gmann_ | sdague: humm, i thought we will remove that from latest samples so that people can start using without project-id | 13:03 |
| danpb | nagyz: i keep my repo here https://github.com/berrange/qemu/tree/qcrypto-secrets-luks-1 | 13:04 |
| sdague | gmann_: well, they are going to need a cloud that's at least got v2.13 for that to work | 13:04 |
| gmann_ | sdague: oh, with microversion. then yes | 13:04 |
| danpb | nagyz: what is most beneficial would be getting review comments on qemu patches | 13:04 |
| sdague | so from a documentation perspective, it doesn't feel like we can just delete it | 13:04 |
| gmann_ | sdague: yup | 13:04 |
| sdague | any cloud with v2.13+ will support it on any API revision | 13:05 |
| sdague | because of where it is on the processing | 13:05 |
| danpb | and after i post a newer version, probably need some kind of functional testing to ensure that it is fully interoperable with dm-crypt | 13:05 |
| markus_z | esracelik: although, maybe it makes sense to name the local branch like "bp/centralize-config-options_hyperv" or similar | 13:05 |
| sdague | however, that's the signaling to know it's ok | 13:05 |
| gmann_ | yea | 13:05 |
| gmann_ | sdague: alex_xu so current structure for version sample is resource/vx_y/ | 13:05 |
| sdague | right | 13:05 |
| *** mwagner_lap has quit IRC | 13:05 | |
| *** ducttape_ has joined #openstack-nova | 13:06 | |
| alex_xu | sdague: do you mean you want to keep two sets of api samples, one for with project id, one for without project id? | 13:06 |
| sdague | alex_xu: yes | 13:06 |
| esracelik | markus_z: i tried git checkout -b hypervopt remotes/origin/master but that branch but i can still see my previous configdrive.py in nova/conf | 13:06 |
| sdague | alex_xu: otherwise you can't test both | 13:06 |
| sdague | the samples are the verification | 13:06 |
| gmann_ | sdague: i feel instead of having api_sample/resource/v2_13 we have all under api_sample/v2_13 ? | 13:06 |
| sdague | gmann_: I would be ok if we flipped the version like that | 13:06 |
| sdague | it would make some things easier | 13:07 |
| gmann_ | sdague: alex_xu yea for all before 2.13 we need with project id also | 13:07 |
| alex_xu | sdague: we support regax one some field validation I remember, we can test both case I guess | 13:07 |
| alex_xu | s/one/on/ | 13:07 |
| sdague | alex_xu: we can with 1 set of templates | 13:07 |
| sdague | but we still need 2 sets of doc samples | 13:07 |
| markus_z | esracelik: Hm, that's odd, let me think for a second | 13:08 |
| gmann_ | sdague: yea flipped looks nice idea | 13:08 |
| sdague | also, from a documentation to the user perspective, having the second set of examples makes a lot of sense | 13:08 |
| gmann_ | sdague: initially that was one of the option for microversion sample structure | 13:08 |
| *** mwagner_lap has joined #openstack-nova | 13:08 | |
| sdague | gmann_: yeh, I think until this point, either was fine, but getting a whole additional set of samples makes it clear it would be better with the version first in our directory | 13:09 |
| alex_xu | ok, I didn't get other idea except have two set docs | 13:09 |
| sdague | gmann_: is that a patch you could work up | 13:09 |
| gmann_ | sdague: sure | 13:09 |
| sdague | ok, second question | 13:09 |
| sdague | https://github.com/openstack/nova/blob/7c02bde804434dfd769fdaf7fb6d1ccbcb946d66/nova/tests/functional/api_sample_tests/api_sample_base.py#L32 | 13:10 |
| esracelik | markus_z: oww sorry sorry that was nova/conf/configdrive.pyc, everything seems good | 13:10 |
| sdague | https://github.com/openstack/nova/blob/7c02bde804434dfd769fdaf7fb6d1ccbcb946d66/nova/tests/functional/api_sample_tests/api_sample_base.py#L59 - when can _test not be defined? | 13:10 |
| *** tonytan4ever has joined #openstack-nova | 13:10 | |
| sdague | because I didn't think that was really a thing | 13:10 |
| gmann_ | sdague: alex_xu and that gives more clear idea for what all changed in that version from top folder itself | 13:10 |
| sdague | gmann_: yep | 13:10 |
| markus_z | esracelik: Ah, ok :) In such cases you could also do a "git reset --hard" <= resets any changes | 13:10 |
| esracelik | markus_z: ok, thanks a lot | 13:11 |
| gmann_ | sdague: that is for microversion tests class | 13:11 |
| sdague | gmann_: can you explain more? | 13:11 |
| gmann_ | sdague: https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_keypairs.py#L118 | 13:11 |
| * gmann_ checking detail | 13:13 | |
| PaulMurray | ndipanov, do you have anything to say about https://review.openstack.org/#/c/215483/3 - looks like it will come up in the live migration meeting later | 13:13 |
| alex_xu | it is for distinguish different behaviour for different scenarios in baseclass | 13:13 |
| ndipanov | PaulMurray, ah well | 13:14 |
| *** tonytan4ever has quit IRC | 13:14 | |
| sdague | ah, ok, so the scenario list is overwritten in some subclasses | 13:14 |
| sdague | gmann_: how many more hours are you online today? | 13:15 |
| gmann_ | sdague: yea for all microversion tests | 13:15 |
| alex_xu | but sounds like for v2.1 we have two value | 13:15 |
| *** amotoki has joined #openstack-nova | 13:15 | |
| sdague | because I'd like to refactor this a bit for clarity | 13:15 |
| gmann_ | sdague: :) may be 20 more min | 13:15 |
| sdague | ok, so I'll have a patch for you tomorrow to look at | 13:15 |
| gmann_ | sdague: cool | 13:16 |
| sdague | when you wake up, because I think we should do the testscenarios a bit differently | 13:16 |
| ndipanov | PaulMurray, the thing is - I don't think the fix that was proposed is a good way to go | 13:16 |
| *** ducttape_ has quit IRC | 13:16 | |
| sdague | instead of setting some constant like _test | 13:16 |
| ndipanov | for the related security fix | 13:16 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Adds HostCapabilities object model and updates ComputeNode object https://review.openstack.org/228280 | 13:16 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Adds host_capabilities conf options group https://review.openstack.org/250166 | 13:16 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: driver: Adds get_hypervisor_capabilities method https://review.openstack.org/254124 | 13:16 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Adds host_capabilities to HostState https://review.openstack.org/254747 | 13:16 |
| *** dims has joined #openstack-nova | 13:16 | |
| sdague | we should be setting the things the test cares about | 13:16 |
| ndipanov | so I hate to see even more code that "legitimizes" it | 13:16 |
| sdague | like _api_version | 13:16 |
| sdague | _middleware | 13:17 |
| sdague | etc | 13:17 |
| * alex_xu probably learned something from sdague again | 13:17 | |
| sdague | basically call out all the attributes we are changing per test | 13:17 |
| openstackgerrit | John Garbutt proposed openstack/nova: docs: add test strategy and feature classification https://review.openstack.org/215664 | 13:17 |
| gmann_ | sdague: yea that better idea. | 13:17 |
| sdague | instead of going through a global constant and having our own if block | 13:17 |
| sdague | gmann_: ok, cool | 13:17 |
| sdague | I'll put up a patch during my day, and will be interested to see what you think | 13:17 |
| PaulMurray | ndipanov, at the moment you and I hae -1 on it, but you have a better understanding than I do - I just wasn't sure about the use of error vs fail. | 13:18 |
| sdague | gmann_: thanks much for the info | 13:18 |
| gmann_ | sdague: sure, so you will refactor for _test right | 13:18 |
| sdague | gmann_: yes | 13:18 |
| PaulMurray | so I will probably just direct him to you | 13:18 |
| ndipanov | OK | 13:18 |
| gmann_ | sdague: and for me refactoring the sample structure with version at top folder | 13:18 |
| ndipanov | I will look into that one more closely too | 13:18 |
| sdague | gmann_: yes | 13:18 |
| gmann_ | sdague: cool | 13:18 |
| sdague | gmann_: great, thanks much | 13:19 |
| gmann_ | sdague: alex_xu Thanks. | 13:19 |
| gmann_ | sdague: alex_xu hanging up if nothing else? | 13:19 |
| alex_xu | gmann_: yeh, see you tomorrow | 13:20 |
| gmann_ | alex_xu: see you. i will put that up in morning so that you can look early | 13:21 |
| alex_xu | gmann_: yeh, I will help for review, thanks for the work | 13:21 |
| *** rpodolyaka has quit IRC | 13:21 | |
| *** baoli has joined #openstack-nova | 13:22 | |
| *** tlbr has quit IRC | 13:22 | |
| *** ianbrown__ has quit IRC | 13:22 | |
| *** ianbrown_ has joined #openstack-nova | 13:22 | |
| gmann_ | alex_xu: thanks, | 13:23 |
| *** gmann_ has quit IRC | 13:23 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api-guide: add a doc on users https://review.openstack.org/249812 | 13:24 |
| *** baoli_ has joined #openstack-nova | 13:25 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Fixes disk overhead claim issue https://review.openstack.org/246307 | 13:26 |
| * johnthetubaguy goes to get some food | 13:26 | |
| yalie | ping alex_xu | 13:26 |
| *** baoli has quit IRC | 13:28 | |
| yalie | ping johnthetubaguy | 13:28 |
| *** ljxiash has joined #openstack-nova | 13:28 | |
| sdague | BobBall: so, out of curiosity, is there any plan for xenserver to update to not ancient base os any time soon? | 13:29 |
| BobBall | Yes - tech preview currently out is on CentOS 7.1 | 13:30 |
| *** baoli_ has quit IRC | 13:31 | |
| *** edmondsw has joined #openstack-nova | 13:31 | |
| *** ljxiash_ has joined #openstack-nova | 13:32 | |
| *** baoli has joined #openstack-nova | 13:32 | |
| *** ljxiash has quit IRC | 13:34 | |
| openstackgerrit | Adelina Tuvenie proposed openstack/nova: Test patch for nova CI https://review.openstack.org/254756 | 13:35 |
| *** jaypipes has joined #openstack-nova | 13:35 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: virt: Allow multiple volume attachments https://review.openstack.org/193135 | 13:36 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments https://review.openstack.org/193134 | 13:36 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 13:36 |
| *** chinmaya has quit IRC | 13:36 | |
| *** baoli has quit IRC | 13:37 | |
| *** baoli has joined #openstack-nova | 13:37 | |
| sdague | BobBall: ok, cool | 13:38 |
| *** mgoddard has joined #openstack-nova | 13:38 | |
| BobBall | It's been a long time coming, but it's progress. At this rate, I expect XenServer to use Python 3 by 2027. | 13:38 |
| openstackgerrit | Andrew Bogott proposed openstack/nova: Prevent scheduling of instances on full hosts. https://review.openstack.org/242251 | 13:39 |
| sdague | heh | 13:41 |
| markus_z | :D | 13:42 |
| *** baoli has quit IRC | 13:42 | |
| lxsli | Please could I get reviews of https://review.openstack.org/#/c/215613/ ? | 13:42 |
| *** terryyao has joined #openstack-nova | 13:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation https://review.openstack.org/243335 | 13:42 |
| sdague | BobBall: is xenci running the last patch? | 13:42 |
| BobBall | 1 sec - will double check | 13:42 |
| BobBall | | 18535 | openstack/nova | refs/changes/31/254331/3 | Collecting | 104.130.210.213 | | 0.05 | 0.91 | | 13:43 |
| BobBall | Expect the vote in a few minutes ;) | 13:43 |
| *** tbh has quit IRC | 13:44 | |
| *** jerrygb has joined #openstack-nova | 13:44 | |
| *** eliqiao has quit IRC | 13:45 | |
| sdague | BobBall: ok, follow on question, let me push a broken patch and get your opinion on it | 13:45 |
| BobBall | don't push it to that changeset yet | 13:45 |
| openstackgerrit | Sean Dague proposed openstack/nova: WIP: convert to download/upload vhd2 which uses url https://review.openstack.org/254760 | 13:46 |
| *** eliqiao has joined #openstack-nova | 13:46 | |
| sdague | no, it's above it | 13:46 |
| BobBall | it'll abort the current run just as it's finishing | 13:46 |
| *** ociuhandu has joined #openstack-nova | 13:46 | |
| BobBall | ah right - cool | 13:46 |
| sdague | oh, I guess I mixed the last patch a little with the vhd2 functions | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce freeze filesystems https://review.openstack.org/249140 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: check graphic/serial consoles at pre_live_migration step https://review.openstack.org/254709 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce thaw filesystems https://review.openstack.org/249141 | 13:46 |
| *** eliqiao has quit IRC | 13:46 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: retrive root block device https://review.openstack.org/249139 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "snapshot" to Guest's object https://review.openstack.org/249353 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce block_stats to return device stats https://review.openstack.org/251288 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "pause" to Guest's object https://review.openstack.org/249834 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: wrapper list_guests to Host's object https://review.openstack.org/249835 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "shutdown" to Guest's object https://review.openstack.org/249833 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce get_job_info to Guest's object https://review.openstack.org/250740 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: configure migrate max downtime https://review.openstack.org/250739 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "abort_job" to Guest's object https://review.openstack.org/250738 | 13:46 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduce "migrate" to Guest's object https://review.openstack.org/250365 | 13:46 |
| BobBall | Did you forget to add the plugin? | 13:46 |
| *** eliqiao has joined #openstack-nova | 13:46 | |
| *** ljxiash_ has quit IRC | 13:47 | |
| BobBall | oh my bad | 13:47 |
| BobBall | that was in the original change - sorry | 13:47 |
| sdague | right, so this is the actually cut over to the new function, how do we want to handled that? | 13:48 |
| BobBall | Just like that's fine. | 13:48 |
| BobBall | But we need to update the plugin version numbers in the two changes | 13:48 |
| openstackgerrit | dstepanenko proposed openstack/nova: WIP: This is 3rd part of changes according to pci-generate-stats https://review.openstack.org/247692 | 13:48 |
| sdague | where is the plugin version number indicated? | 13:48 |
| sdague | I guess I haven't stumbled over that yet | 13:48 |
| *** pratikmallya has quit IRC | 13:48 | |
| BobBall | So the first change needs to update https://git.openstack.org/cgit/openstack/nova/tree/plugins/xenserver/xenapi/etc/xapi.d/plugins/nova_plugin_version#n31 | 13:48 |
| sdague | ok | 13:49 |
| sdague | can you -1 with that info, and I'll fix it | 13:49 |
| BobBall | And the second change needs to update https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/client/session.py#n84 | 13:49 |
| BobBall | Will do | 13:49 |
| *** ljxiash has joined #openstack-nova | 13:49 | |
| sdague | thanks | 13:49 |
| BobBall | XS CI gave it a +1 | 13:49 |
| sdague | nice! | 13:49 |
| sdague | ok, I'm going to work through these unit tests to get the vhd2 bits passing | 13:50 |
| BobBall | awesome | 13:50 |
| sdague | so, I guess the only question is with the versioning is it ok to change change the signature on vhd functions? | 13:50 |
| sdague | or is this vhd2 path the prefered one | 13:50 |
| openstackgerrit | dstepanenko proposed openstack/nova: WIP: This is 4th patch of changes according to pci-generate-stats blueprint. https://review.openstack.org/250757 | 13:51 |
| BobBall | Can't change the signature without a major version update (cuz it'd be incompatible). Really _really_ want to have the function deprecated for at least 1 cycle otherwise ppl deploying it must update compute + plugins in sync and have a fixed restart time of the compute | 13:51 |
| sdague | yep, that's fine | 13:52 |
| sdague | so, I'm going to just flip the unit tests to using vhd2 | 13:53 |
| * BobBall stands back | 13:53 | |
| sdague | if you want to still test vhd functions, I'll leave to to you to fill back in | 13:53 |
| BobBall | Unit tests don't call through to plugins currently - so you're just testing nova code, which will only be using vhd2 | 13:54 |
| sdague | yep | 13:56 |
| *** dave-mccowan has joined #openstack-nova | 13:56 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Edit the text to be more native-English sounding https://review.openstack.org/254766 | 13:57 |
| sdague | yeh, so I guess that's sensible | 13:57 |
| yalie | johnthetubaguy: ping | 13:57 |
| *** diogogmt has quit IRC | 13:58 | |
| *** diogogmt has joined #openstack-nova | 13:58 | |
| johnthetubaguy | yalie: sorry, was having lunch, how can I help? | 13:59 |
| sdague | BobBall: also, I had mox :) | 14:00 |
| sdague | s/had/hate/ | 14:00 |
| *** sudipto has joined #openstack-nova | 14:01 | |
| *** mgoddard_ has joined #openstack-nova | 14:02 | |
| yalie | johnthetubaguy: thanks john, I have a bp about removing the nova's verification on port with IP and network with subnet when booting a VM | 14:02 |
| *** lykinsbd has joined #openstack-nova | 14:02 | |
| *** mgoddard has quit IRC | 14:02 | |
| andrearosa | nova-live-migration subteam meeting is now | 14:02 |
| *** wyang has quit IRC | 14:02 | |
| esracelik | markus_z: markus i have a question. sorry for disturbing frequently | 14:02 |
| *** derekh has joined #openstack-nova | 14:02 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Remove version hardcoding for 'show' method https://review.openstack.org/228578 | 14:02 |
| markus_z | esracelik: nah, no worries | 14:02 |
| yalie | johnthetubaguy: https://review.openstack.org/#/c/239276/ I am not sure if it could get a exception of nova bp | 14:03 |
| *** jinxing has quit IRC | 14:03 | |
| esracelik | markus_z: can I merge all options in directory nova/conf/hyperv in one file | 14:04 |
| *** akshai has joined #openstack-nova | 14:04 | |
| yalie | johnthetubaguy: I disscussed with kevin benton in neutron, this feature has been supported in neutron, it would not depend some feature in neutron. | 14:04 |
| esracelik | markus_z: i am asking this because if I create nova/conf/vif.py it is not clear if it is nova/virt/hyperv/vif.py or nova/virt/vmwareapi/vif.py | 14:05 |
| *** ankit has joined #openstack-nova | 14:05 | |
| *** rook-desktop has joined #openstack-nova | 14:05 | |
| johnthetubaguy | yalie: we can add that to the list in the etherpad, and see how it goes | 14:05 |
| *** nikhil_k is now known as nikhil | 14:05 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova: Use stevedore for scheduler driver https://review.openstack.org/254768 | 14:05 |
| markus_z | esracelik: let me check the code, one second | 14:06 |
| yalie | johnthetubaguy: thanks johnthetubaguy | 14:06 |
| *** mgoddard has joined #openstack-nova | 14:06 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Clean up filter_properties/availability_zone in boot https://review.openstack.org/254434 | 14:06 |
| *** claudiub has joined #openstack-nova | 14:06 | |
| *** mgoddard_ has quit IRC | 14:06 | |
| *** atuvenie has joined #openstack-nova | 14:07 | |
| *** rlrossit has joined #openstack-nova | 14:07 | |
| markus_z | esracelik: I think it's sane to have a "nova/conf/hyperv.py" which contains config opt "vswitch_name" and "nova/conf/vmware" which contains "vlan_interface" and "intergration_bridge". | 14:08 |
| *** hparekh2 has quit IRC | 14:08 | |
| *** ducttape_ has joined #openstack-nova | 14:08 | |
| markus_z | esracelik: Is that what you meant with merging them into one file? | 14:08 |
| *** ctrath has joined #openstack-nova | 14:08 | |
| *** pratikmallya has joined #openstack-nova | 14:10 | |
| *** changbl has quit IRC | 14:10 | |
| esracelik | markus_z: so maybe current position of options are not relevant, right? | 14:10 |
| esracelik | markus_z: when creating nova/conf/new.py file I should collect all related options together? | 14:11 |
| markus_z | esracelik: The semantic of them has priority over the location. | 14:11 |
| markus_z | esracelik: yes, they should build a group of related options. | 14:11 |
| esracelik | markus_z: allright, got it, thanks | 14:11 |
| markus_z | esracelik: finding the group is especially funny in the "DEFAULT" section. | 14:12 |
| markus_z | esracelik: If you think that a current grouping doesn't make sense and should be re-evaluated, add it at the end of etherpad https://etherpad.openstack.org/p/config-options | 14:13 |
| *** tlbr has joined #openstack-nova | 14:14 | |
| *** ducttape_ has quit IRC | 14:15 | |
| *** rpodolyaka has joined #openstack-nova | 14:15 | |
| *** Daisy has joined #openstack-nova | 14:16 | |
| esracelik | markus_z: ok, it seem like it won't be that easy :) for example there are two vlan_interface options, one in DEFAULT section one in vmware section. | 14:16 |
| *** cfriesen has joined #openstack-nova | 14:18 | |
| *** breitz has quit IRC | 14:18 | |
| *** breitz has joined #openstack-nova | 14:19 | |
| markus_z | esracelik: yeah, that's one of those things. We have the code, cloud admins don't have it. How should they decide here? | 14:19 |
| sdague | BobBall: ok, I've got what I think is the stack supporting this about ready to go, just doing one more check on unit tests before pushing | 14:20 |
| esracelik | markus_z: yes, I am getting familiar.. thanks | 14:21 |
| markus_z | esracelik: Not sure if you already know it, but we still have the service "nova-network" in use. So some of the options will configure this service. | 14:21 |
| esracelik | markus_z: yes I used nova-network. when will it be removed completely? | 14:22 |
| markus_z | esracelik: I was discussed during the last summit, but I don't remember the conclusion, sorry. | 14:23 |
| markus_z | *It | 14:23 |
| esracelik | markus_z: ok, removal approach would bu fun as well :) | 14:23 |
| *** ijuwang has joined #openstack-nova | 14:24 | |
| markus_z | esracelik: I guess people much smarter than me have to do that :) | 14:24 |
| *** diogogmt has quit IRC | 14:25 | |
| esracelik | markus_z: oh, dont think like that. we have a sentence in turkish for this case, but i don't know how to say it in english , anyway:) | 14:26 |
| *** mdrabe has joined #openstack-nova | 14:27 | |
| openstackgerrit | dstepanenko proposed openstack/nova: WIP: This is 4th patch of changes according to pci-generate-stats blueprint. https://review.openstack.org/250757 | 14:27 |
| *** mriedem has joined #openstack-nova | 14:28 | |
| *** dane-fichter has joined #openstack-nova | 14:28 | |
| *** yalie has quit IRC | 14:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Add additional logs for NUMA scheduling https://review.openstack.org/254783 | 14:30 |
| *** zhangjn has joined #openstack-nova | 14:32 | |
| *** zhangjn has quit IRC | 14:32 | |
| *** otter768 has joined #openstack-nova | 14:32 | |
| *** busterswt has joined #openstack-nova | 14:32 | |
| *** zhangjn has joined #openstack-nova | 14:32 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Convert xenapi driver to using up/down vhd2 https://review.openstack.org/254760 | 14:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: retool xen glance plugin to work with urls https://review.openstack.org/254331 | 14:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: Implement GlanceEndpoint object https://review.openstack.org/254214 | 14:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: always create clients with GlanceEndpoint https://review.openstack.org/254306 | 14:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: Add upload/download vhd2 interfaces https://review.openstack.org/254785 | 14:33 |
| sdague | BobBall: ok, the last 3 patches in that stack should be reviewed by you | 14:34 |
| sdague | to make sure I got that right | 14:34 |
| *** otter768 has quit IRC | 14:37 | |
| *** smatzek has quit IRC | 14:38 | |
| *** eglynn has quit IRC | 14:38 | |
| *** Daisy has quit IRC | 14:38 | |
| *** Daisy has joined #openstack-nova | 14:39 | |
| *** tonytan4ever has joined #openstack-nova | 14:41 | |
| *** lucasagomes is now known as lucas-hungry | 14:42 | |
| *** coreycb has joined #openstack-nova | 14:45 | |
| *** tonytan4ever has quit IRC | 14:45 | |
| *** fawadkhaliq has quit IRC | 14:45 | |
| *** fawadkhaliq has joined #openstack-nova | 14:46 | |
| coreycb | will there be a liberty point release in the near future? | 14:46 |
| *** ankit has quit IRC | 14:47 | |
| *** edmondsw has quit IRC | 14:48 | |
| *** armax has joined #openstack-nova | 14:50 | |
| *** dims_ has joined #openstack-nova | 14:52 | |
| nagyz | danpb, we'll engage our qemu team and check with them | 14:52 |
| *** derekh is now known as derekh_afk | 14:53 | |
| nagyz | danpb, would setting up a CI system that tests dm-crypt -> in-qemu migration be helpful? | 14:53 |
| *** Daisy has quit IRC | 14:55 | |
| *** yalie has joined #openstack-nova | 14:55 | |
| *** dims has quit IRC | 14:55 | |
| *** eharney has joined #openstack-nova | 14:56 | |
| *** mrkz has joined #openstack-nova | 14:56 | |
| sdague | flaper87 / johnthetubaguy how important is it to *not* send keystone headers for glanceclient? | 14:57 |
| *** Daisy has joined #openstack-nova | 14:57 | |
| *** baoli has joined #openstack-nova | 14:58 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Edit the text to be more native-English sounding https://review.openstack.org/254766 | 14:58 |
| *** esracelik has quit IRC | 14:58 | |
| flaper87 | sdague: mmh, not sure I understand your question (or what it relates to) but I'd assume it refers to the patches you just pushed for review | 14:58 |
| *** ducttape_ has joined #openstack-nova | 14:59 | |
| sdague | flaper87: https://review.openstack.org/#/c/254306/2/nova/image/glance.py,cm | 14:59 |
| dansmith | This set on live migration data objectification could use eyes: https://review.openstack.org/#/c/247719/ | 15:00 |
| *** yonglihe has joined #openstack-nova | 15:00 | |
| danpb | nagyz: not sure we need a full on CI system, but certainly will want some kind of functional test suite integrated into QEMU to test it | 15:00 |
| *** mgoddard has quit IRC | 15:00 | |
| danpb | QEMU's I/O layer has a fairly extensive test harness to build on | 15:00 |
| openstackgerrit | Dave McCowan proposed openstack/nova: Check context before returning cached value https://review.openstack.org/254358 | 15:00 |
| *** zhangjn has quit IRC | 15:01 | |
| nagyz | danpb, I more meant it in an OpenStack setting, for example to live migrate between a host running the current encryptor path and the new one | 15:01 |
| *** dustins|gone is now known as dustins | 15:01 | |
| nagyz | danpb, as I guess that's something that would need to be supported to replace the current IO path? | 15:01 |
| *** yangyapeng has quit IRC | 15:01 | |
| danpb | nagyz: oh i see what you mean | 15:02 |
| danpb | yeah, that could well be something that's useful now we can do migration testing in CI | 15:02 |
| *** mgoddard has joined #openstack-nova | 15:03 | |
| *** ducttape_ has quit IRC | 15:03 | |
| *** ducttape_ has joined #openstack-nova | 15:03 | |
| *** Jeffrey4l has joined #openstack-nova | 15:03 | |
| nagyz | danpb, ok, I'll need to talk to our internal folks but sounds like a plan from my side | 15:04 |
| *** inc0 has quit IRC | 15:05 | |
| *** pratikmallya has quit IRC | 15:05 | |
| *** Jeffrey4l_ has joined #openstack-nova | 15:07 | |
| *** baoli has quit IRC | 15:08 | |
| *** inc0 has joined #openstack-nova | 15:08 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Fix help message in case of microversions https://review.openstack.org/254335 | 15:09 |
| *** jerrygb has quit IRC | 15:09 | |
| *** jerrygb has joined #openstack-nova | 15:10 | |
| *** artom has joined #openstack-nova | 15:10 | |
| *** yarkot has joined #openstack-nova | 15:13 | |
| *** Daisy has quit IRC | 15:13 | |
| *** atuvenie has quit IRC | 15:13 | |
| *** zenoway has quit IRC | 15:13 | |
| *** rdopiera has quit IRC | 15:13 | |
| *** edmondsw has joined #openstack-nova | 15:13 | |
| *** paul-carlton_ has joined #openstack-nova | 15:13 | |
| *** smatzek has joined #openstack-nova | 15:14 | |
| mriedem | coreycb: i think so | 15:14 |
| mriedem | there have been some high priority regression fixes going into stable/liberty in the last week or so | 15:14 |
| *** Daisy has joined #openstack-nova | 15:14 | |
| mriedem | coreycb: we're trying to round up release notes for a liberty release | 15:14 |
| mriedem | garyk: had another one that has to go in that too | 15:14 |
| *** jerrygb has quit IRC | 15:15 | |
| *** jinxing has joined #openstack-nova | 15:15 | |
| *** zenoway has joined #openstack-nova | 15:15 | |
| *** sneti has joined #openstack-nova | 15:15 | |
| garyk | mriedem: sorry do not follow | 15:16 |
| mriedem | https://review.openstack.org/#/c/254206 | 15:16 |
| coreycb | mriedem, ok good to hear, I'll keep an eye out for it | 15:16 |
| mriedem | that will go back to liberty right? | 15:16 |
| *** READ10 has joined #openstack-nova | 15:16 | |
| garyk | mriedem: yes, planning to backport that when the gate recovers | 15:16 |
| *** fawadkhaliq has quit IRC | 15:16 | |
| mriedem | was there a gate outage? | 15:17 |
| *** lucas-hungry is now known as lucasagomes | 15:17 | |
| lxsli | claudiub: I removed https://review.openstack.org/#/c/234283/ from the trivial patch list because 1) it's your patch, not supposed to propose your own; 2) it's not that trivial. Hope that's OK | 15:17 |
| andreykurilin | johnthetubaguy, sdague, mriedem, alex_xu, melwitt: hi! Can you look at update for novaclient's spec(https://review.openstack.org/#/c/211206/ )? Also, it can be moved to implemented... | 15:18 |
| *** Daisy has quit IRC | 15:19 | |
| *** zenoway has quit IRC | 15:19 | |
| mriedem | dansmith: hit me up on https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/objectify-live-migrate-data,n,z when things settle down a bit, i want to get https://review.openstack.org/#/c/254428/ done first | 15:19 |
| *** Jeffrey4l has quit IRC | 15:20 | |
| andreykurilin | mriedem: I know you want to release novaclient this week. When you will do? I want to get merge several patches in this release:) | 15:20 |
| *** atuvenie has joined #openstack-nova | 15:20 | |
| dansmith | mriedem: ... are you asking me to remind you to look at that set, or that you will look after you look at that other patch? | 15:20 |
| mriedem | dansmith: just to get on me about reviewing it | 15:21 |
| dansmith | mriedem: okay | 15:21 |
| mriedem | i was planning on it anyway | 15:21 |
| mriedem | but need the whip | 15:21 |
| *** _ducttape_ has joined #openstack-nova | 15:21 | |
| mriedem | andreykurilin: we're waiting on https://review.openstack.org/#/c/245200/ | 15:21 |
| dansmith | mriedem, you yella-belly, no-good, trough-drinkin lowlife... review that set | 15:22 |
| dansmith | mriedem: good? ^^ | 15:22 |
| mriedem | thems are right proper fightin words, but not what i had in mind | 15:22 |
| *** moshele has quit IRC | 15:22 | |
| dansmith | heh | 15:23 |
| *** jerrygb has joined #openstack-nova | 15:24 | |
| andreykurilin | mriedem: got it. thanks | 15:24 |
| *** ducttape_ has quit IRC | 15:24 | |
| openstackgerrit | dstepanenko proposed openstack/nova: Duplicated the logic of nova.pci.stats.PciDevStats.supports_request() method into the nova.objects.PciDevicePoolList object. https://review.openstack.org/242087 | 15:25 |
| openstackgerrit | dstepanenko proposed openstack/nova: Duplicated the logic of nova.pci.stats.PciDevStats.supports_request() method into the nova.objects.PciDevicePoolList object. https://review.openstack.org/242087 | 15:26 |
| *** atuvenie has quit IRC | 15:26 | |
| *** gszasz has quit IRC | 15:27 | |
| flaper87 | sdague: As you mentioned it in your comment on that patch, I don't think sending them hurts at all. I'd just do what you did there. | 15:28 |
| * flaper87 <- brb | 15:28 | |
| sdague | flaper87: ok, cool, there is one test later that tests for not sending those headers, but I think it's mostly silly | 15:30 |
| *** gszasz has joined #openstack-nova | 15:30 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 15:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 15:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 15:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 15:30 |
| *** claudiub has quit IRC | 15:32 | |
| mriedem | this is confusing, | 15:32 |
| mriedem | stable/liberty reno job, liberty series release notes are blank http://docs-draft.openstack.org/24/253224/4/check/gate-nova-releasenotes/46de2bb//releasenotes/build/html/liberty.html | 15:32 |
| mriedem | the stable/liberty reno change's notes are in the 'current series' section: http://docs-draft.openstack.org/24/253224/4/check/gate-nova-releasenotes/46de2bb//releasenotes/build/html/unreleased.html | 15:32 |
| mriedem | dhellmann: ^ is that right? | 15:32 |
| *** mtanino has joined #openstack-nova | 15:33 | |
| *** xyang1 has joined #openstack-nova | 15:33 | |
| *** sneti has quit IRC | 15:35 | |
| *** sneti has joined #openstack-nova | 15:35 | |
| dansmith | markus_z: can you re-review this? https://review.openstack.org/#/c/243335/8 | 15:36 |
| *** diogogmt has joined #openstack-nova | 15:36 | |
| markus_z | dansmith: yepp, looking | 15:36 |
| *** erhudy has joined #openstack-nova | 15:36 | |
| *** thangp has joined #openstack-nova | 15:37 | |
| *** thumpba has joined #openstack-nova | 15:39 | |
| *** terryyao has quit IRC | 15:40 | |
| *** mjura has quit IRC | 15:41 | |
| openstackgerrit | Sean Dague proposed openstack/nova: drop _create_glance_client function https://review.openstack.org/254827 | 15:41 |
| openstackgerrit | Sean Dague proposed openstack/nova: convert GlanceClientWrapper to endpoint https://review.openstack.org/254828 | 15:41 |
| *** doron_afk has left #openstack-nova | 15:41 | |
| *** rpodolyaka has quit IRC | 15:41 | |
| *** tlbr has quit IRC | 15:41 | |
| sdague | mriedem: are there fixes up for liberty volumes regressions somewhere? | 15:43 |
| *** tonytan4ever has joined #openstack-nova | 15:43 | |
| mriedem | liberty volumes regressions? | 15:43 |
| *** jistr is now known as jistr|mtg | 15:43 | |
| *** pratikmallya has joined #openstack-nova | 15:44 | |
| sdague | mriedem: it seems that's the typically grenade multinode fail now | 15:46 |
| sdague | http://status.openstack.org//elastic-recheck/ | 15:46 |
| sdague | bugs 2 - 6 are all volumes | 15:46 |
| *** andrewbogott has quit IRC | 15:46 | |
| mriedem | sdague: so something must have changed in tempest if we're getting regressions on all branches all of a sudden | 15:46 |
| mriedem | which is what i was getting at least week | 15:47 |
| sdague | mriedem: well, maybe, maybe not | 15:47 |
| sdague | we've now got ovh and bluebox in our node rotation | 15:47 |
| sdague | and they are both slower than hp or rax | 15:47 |
| mriedem | so thinking slower nodes causing issues? | 15:48 |
| sdague | yeh, could be | 15:48 |
| mriedem | i also don't know how much i trust at 12/1 date in logstash | 15:48 |
| sdague | anyway, mostly wondering if there are any cinder people that are looking into any of these? | 15:48 |
| mriedem | not that i'm aware of | 15:48 |
| mriedem | sdague: this was the thing i spent all of yesterday on https://review.openstack.org/#/c/254428/ | 15:49 |
| mriedem | still need to clean it up and add tests | 15:49 |
| sdague | ah, gotcha | 15:50 |
| mriedem | anyway, that's a clear race and an easy change for backporting, and that ebs test is hitting all branches | 15:51 |
| mriedem | as is whatever the ec2 volume tests are doing | 15:51 |
| mriedem | basically doing boot from volume + quick server delete exposes this race | 15:51 |
| *** derekh_afk has quit IRC | 15:51 | |
| *** mc_nair has joined #openstack-nova | 15:52 | |
| *** nkrinner has quit IRC | 15:53 | |
| mriedem | dansmith: you might want to weigh in here, but i think this is too complicated for a latent perf bug to backport to stable/liberty https://review.openstack.org/#/c/245656/ | 15:53 |
| mriedem | plus it has an object version bump in it | 15:54 |
| dansmith | mriedem: oh yeah, definitely not for backport.. I'll comment | 15:54 |
| *** burt has quit IRC | 15:57 | |
| *** gokrokve has joined #openstack-nova | 15:59 | |
| sdague | hmmm... so the grenade-dsvm-multinode test is > 50% fail right now, largely for volumes fails on liberty | 16:01 |
| sdague | no every nova change is currently a coin flip | 16:02 |
| sdague | which is why the gate is backed up as bad as it is | 16:02 |
| dansmith | sdague: so I just saw one that was ssh timeout | 16:02 |
| *** Vek has quit IRC | 16:02 | |
| sdague | right | 16:02 |
| dansmith | sdague: on the old side.. is that how it manifests? | 16:02 |
| sdague | dansmith: all my spot checking is that it's on the old side | 16:02 |
| dansmith | okay | 16:03 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Add ppc to supported arch for NUMA https://review.openstack.org/245765 | 16:03 |
| sdague | honestly, I haven't looked much yet, because I had this other context stack in my head | 16:03 |
| mriedem | there was a big ssh change series in tempest | 16:03 |
| mriedem | last week | 16:03 |
| *** salv-orlando has joined #openstack-nova | 16:03 | |
| *** salv-orlando has quit IRC | 16:03 | |
| sdague | mriedem: did it land? | 16:03 |
| mriedem | yeah | 16:03 |
| *** lpetrut has quit IRC | 16:03 | |
| *** salv-orlando has joined #openstack-nova | 16:03 | |
| mriedem | https://review.openstack.org/#/c/225575/ | 16:04 |
| sdague | ok, I've got another couple of things to look at before I can shift gears here and dig deeper | 16:04 |
| mriedem | https://review.openstack.org/#/q/status:merged+project:openstack/tempest+branch:master+topic:bp/ssh-auth-strategy,n,z | 16:04 |
| mriedem | i don't see any stable/liberty regressions in nova | 16:04 |
| *** smurke has joined #openstack-nova | 16:05 | |
| BobBall | Will do sdague - ta | 16:05 |
| *** smurke has joined #openstack-nova | 16:05 | |
| sdague | yeh, I think the difference is that when we're running smoke these 2 volume tests often happen at the same time | 16:05 |
| *** tlbr has joined #openstack-nova | 16:05 | |
| *** hemnafk is now known as hemna | 16:06 | |
| markus_z | sfinucan: I'm reviewing your patch https://review.openstack.org/#/c/243335/8/nova/conf/pci.py,cm right now and would like to ask you a question. Have a minute? | 16:06 |
| mriedem | guess it wouldn't just be ceph since it's also multinode | 16:06 |
| sdague | mriedem: yeh | 16:07 |
| *** smurke has quit IRC | 16:07 | |
| *** tjones has joined #openstack-nova | 16:07 | |
| sdague | anyway, if we are lacking people to dig into this, we should consider flipping back to non-voting | 16:07 |
| *** smurke has joined #openstack-nova | 16:07 | |
| edleafe | markus_z: got a question for you about the config opt changes | 16:07 |
| sdague | because right now it's just getting in the way of anything else non related landing | 16:07 |
| *** mariusv has joined #openstack-nova | 16:07 | |
| *** mariusv has quit IRC | 16:07 | |
| *** mariusv has joined #openstack-nova | 16:07 | |
| dansmith | sdague: if we do that we lose all upgrade gating, right? | 16:08 |
| *** aix has quit IRC | 16:08 | |
| edleafe | markus_z: looking at https://review.openstack.org/#/c/248963/8/nova/virt/opts.py,cm as an example of the issue | 16:08 |
| markus_z | edleafe: looking | 16:08 |
| sdague | we do, but right now people are going to just recheck grind on these fails anyway. | 16:08 |
| sdague | well, we lose the partial upgrade -1 | 16:09 |
| markus_z | edleafe: What's the issue with that? | 16:09 |
| mriedem | sdague: do we have any idea when this started? or only the 12/1? | 16:09 |
| *** smatzek has quit IRC | 16:09 | |
| dansmith | sdague: I kinda don't want to turn that off... | 16:09 |
| *** gszasz has quit IRC | 16:09 | |
| *** rpodolyaka has joined #openstack-nova | 16:09 | |
| edleafe | markus_z: won't list_opts() return something like (('DEFAULT', [bunch of opts]), ('DEFAULT', [more opts]), ('hyper-v', [hyper opts]), ...) | 16:09 |
| sdague | the fail rate is drifting up pretty continuously - http://tinyurl.com/qhdwtuz | 16:09 |
| edleafe | markus_z: IOW, multiple tuples with 'DEFAULT' as the first element | 16:10 |
| sdague | dansmith: I hear you, but 50% failure rate in the gate is pretty much untenable | 16:10 |
| mriedem | are these all ssh failures? | 16:10 |
| sdague | unless you are ready to -2 all nova patches until this is solved | 16:10 |
| mriedem | or other timeouts? | 16:10 |
| edleafe | markus_z: oops, that wasn't the one | 16:10 |
| dansmith | sdague: sure, but we wouldn't turn off the main devstack test.. | 16:10 |
| edleafe | markus_z: since 'guestfs' is its own section | 16:10 |
| *** tlbr has quit IRC | 16:10 | |
| sdague | mriedem: like I said, this is all the info I've got. And I can't look into it until later today | 16:10 |
| dansmith | http://logs.openstack.org/32/253732/4/check/gate-grenade-dsvm-multinode/9f726ed/logs/old/screen-n-api.txt.gz?level=TRACE | 16:10 |
| *** stackdump has joined #openstack-nova | 16:11 | |
| dansmith | sdague: mriedem: maybe we have a new deadlock we need to retry? | 16:11 |
| mriedem | sdague: ok, i can poke on it after cleaning up my fix for one of those volume things (the rbd one) | 16:11 |
| dansmith | haven't we been merging some oslo db stuff that might be causing that? | 16:11 |
| edleafe | markus_z: but others have list_opts() return a tuple with 'DEFAULT' - I can dig one up | 16:11 |
| mriedem | dansmith: that was in mitaka | 16:11 |
| mriedem | but oslo.db releases.... | 16:11 |
| dansmith | yeah | 16:11 |
| *** ccarmack has joined #openstack-nova | 16:11 | |
| markus_z | edleafe: I guess I know what you mean, let me look it up | 16:11 |
| *** vilobhmm11 has joined #openstack-nova | 16:12 | |
| edleafe | markus_z: foound it: https://review.openstack.org/#/c/252687/6/nova/opts.py,cm | 16:12 |
| edleafe | the 'wsgi' opts are all 'DEFAULT' | 16:12 |
| mriedem | dansmith: looks like that old side devstack installed oslo.db 3.1.0 http://logs.openstack.org/32/253732/4/check/gate-grenade-dsvm-multinode/9f726ed/logs/old/devstacklog.txt.gz#_2015-12-08_14_41_32_149 | 16:12 |
| *** fawadkhaliq has joined #openstack-nova | 16:12 | |
| mriedem | which was released on 10/19 | 16:12 |
| mriedem | let's check logstash for that db trace though | 16:12 |
| dansmith | well, | 16:12 |
| dansmith | it's also possible that we're not retrying something that we're suddenly hitting or something | 16:13 |
| dansmith | this is a pymysql exception too | 16:13 |
| markus_z | edleafe: yeah, that's the one I wasn't sure but didn't yet double-check. Let me check it | 16:13 |
| *** tlbr has joined #openstack-nova | 16:13 | |
| dansmith | mriedem: like, if we're not catching the pymysql version of this exception | 16:13 |
| mriedem | dansmith: hmm, yeah, maybe due to slower nodes | 16:13 |
| mriedem | causing the deadlock hit | 16:14 |
| mriedem | oslo.db is converting that for us | 16:14 |
| dansmith | I don't see version tags in the oslo.db repo | 16:14 |
| mriedem | https://github.com/openstack/oslo.db/tree/3.1.0 | 16:14 |
| markus_z | edleafe: The result in the docs job makes me believe the oslo's sample config generator can handle this: http://docs-draft.openstack.org/87/252687/6/check/gate-nova-docs/13acb07//doc/build/html/sample_config.html | 16:15 |
| *** changbl has joined #openstack-nova | 16:15 | |
| markus_z | edleafe: checking oslo's sample config generator though | 16:15 |
| dansmith | oh, nevermind I'm dumb | 16:15 |
| dansmith | mriedem: so we're getting an actual pymysql exception not an oslo.db one, which looks like it wouldn't be retried by that wrapper | 16:16 |
| dansmith | dims_: who do we ask about oslo.db stuff? | 16:16 |
| *** browne has joined #openstack-nova | 16:16 | |
| mriedem | rpodolyaka: ^ | 16:17 |
| *** ianbrown_ has quit IRC | 16:17 | |
| mriedem | that db deadlock actually shows up a lot http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22DBDeadlock:%20(pymysql.err.InternalError)%20(1213,%20u'Deadlock%20found%20when%20trying%20to%20get%20lock;%20try%20restarting%20transaction')%20%5BSQL:%20u'SELECT%20reservations.created_at%5C%22%20AND%20tags:%5C%22screen-n-api.txt%5C%22%20AND%20voting:%5C%221%5C%22 | 16:18 |
| edleafe | markus_z: ah, so even if there are duplicate names, the generator chains them together? | 16:18 |
| rpodolyaka | mriedem: hmm, interesting | 16:18 |
| mriedem | 154 hits in 7 days, but they are mostly in successful runs | 16:18 |
| *** stackdump has quit IRC | 16:18 | |
| edleafe | markus_z: still, it seems shaky | 16:18 |
| mriedem | so we must be retrying on deadlock | 16:18 |
| markus_z | edleafe: looks so, yes. But I have to read the generator code to be sure. | 16:18 |
| *** pradk has joined #openstack-nova | 16:18 | |
| markus_z | edleafe: What's the shaky part here? | 16:19 |
| dansmith | mriedem: but we don't raise/log unless we give up or get something unexpected right? | 16:19 |
| *** pratikmallya has quit IRC | 16:19 | |
| openstackgerrit | Ryan Moore proposed openstack/nova: Add better help to rdp options https://review.openstack.org/253556 | 16:19 |
| dansmith | er, no we do | 16:19 |
| mriedem | dansmith: no, oslo.db logs every one it hits i think | 16:19 |
| mriedem | the neutron server logs were always full of these | 16:19 |
| mriedem | but in mostly successful runs b/c of the retry | 16:19 |
| mriedem | it'd be nice if oslo.db would only trace on the last failure before giving up | 16:20 |
| edleafe | markus_z: the value returned by nova/opts.py's list_opts() | 16:20 |
| edleafe | markus_z: with the double 'DEFAULT' tuples. | 16:20 |
| edleafe | markus_z: it fells shaky to generate a bad structure knowing that something else will clean it up | 16:20 |
| dansmith | yeah | 16:20 |
| *** gszasz has joined #openstack-nova | 16:21 | |
| edleafe | markus_z: I'd rather it be correct to start with | 16:21 |
| mriedem | i looked into this once, i think it's actually something lower in the stack that is logging it | 16:21 |
| edleafe | markus_z: in case the generator ever changes | 16:21 |
| mriedem | in oslo.db | 16:21 |
| mriedem | it gets logged here though https://github.com/openstack/oslo.db/blob/3.1.0/oslo_db/api.py#L169 | 16:21 |
| dansmith | yeah | 16:21 |
| dansmith | so I think the instance is started | 16:21 |
| dansmith | and tempest gets back "instance not found" | 16:21 |
| dansmith | started: http://logs.openstack.org/32/253732/4/check/gate-grenade-dsvm-multinode/9f726ed/logs/grenade.sh.txt.gz#_2015-12-08_15_11_33_630 | 16:22 |
| edleafe | markus_z: since the nova/conf/wsgi.py's list_opts is only called from nova/opts.py, why not have it just return the list, and put that in the itertools.chain? | 16:22 |
| *** pumaranikar has joined #openstack-nova | 16:22 | |
| edleafe | markus_z: or even skip the list_opts(), and just add nova.conf.wsgi.ALL_OPTS to the itertools.chain | 16:22 |
| sfinucan | markus_z: Sure. What's up? | 16:23 |
| *** baoli has joined #openstack-nova | 16:23 | |
| *** mriedem is now known as rodermang | 16:23 | |
| *** rodermang is now known as mriedem | 16:23 | |
| dansmith | I guess the not found is bogus fail after the ssh fails.. | 16:24 |
| markus_z | edleafe: Yepp, I've seen how you did it for the scheduler opts. My initial intention was to keep the knowledge of the group name in one place. The place where the config options got declared. | 16:24 |
| mriedem | the not found is on cleanup | 16:24 |
| *** gszasz has quit IRC | 16:24 | |
| dansmith | mriedem: yeah, that's confusing | 16:24 |
| mriedem | dansmith: i don't think this is one of the volume failures | 16:24 |
| mriedem | the build error is: | 16:25 |
| mriedem | Details: {u'message': u"[Errno 2] No such file or directory: '/opt/stack/data/nova/instances/bdbcf072-c793-4f85-931f-14b169d54b13/disk'", u'code': 500, u'created': u'2015-12-08T15:05:22Z'} | 16:25 |
| edleafe | markus_z: I did that with the scheduler opts because, well, that's the way it already was :) | 16:25 |
| dansmith | mriedem: really? we get the console dump, which means the instance started | 16:25 |
| rpodolyaka | mriedem: dansmith: agreed, we should not really log every exception before we give up :( but it's properly wrapped in DBDeadlock and it's *not* a raw pymysql exception right? | 16:25 |
| mriedem | dansmith: which is this http://status.openstack.org/elastic-recheck/index.html#1521823 | 16:25 |
| *** changbl has quit IRC | 16:25 | |
| mriedem | dansmith: yeah, this is a reboot test | 16:26 |
| edleafe | markus_z: but I think that nova/opts should be the place where grouping is declared, not the individual files | 16:26 |
| *** changbl has joined #openstack-nova | 16:26 | |
| mriedem | so it starts, and then i think we try to reboot and kaboom | 16:26 |
| markus_z | sfinucan: I updated your review with the questions I had. I just needed to think a bit more about it. | 16:26 |
| *** salv-orl_ has joined #openstack-nova | 16:26 | |
| sfinucan | ndipanov: Question on one of your review comments? | 16:26 |
| mriedem | dansmith: 2015-12-08 15:05:22,667 29753 INFO [tempest.common.waiters] State transition "HARD_REBOOT/rebooting_hard" ==> "ERROR/reboot_started_hard" after 1 second wait | 16:26 |
| dansmith | mriedem: hmm | 16:26 |
| sfinucan | markus_z: cool - I'll check it out | 16:27 |
| markus_z | edleafe: Oh, why is that so? Those "opts.py" files are "only" for the generation of the sample conf file. | 16:27 |
| markus_z | edleafe: The "real" grouping which impacts the usage in the code is done in "register_opts" within the individual files. | 16:27 |
| markus_z | edleafe: But I might misunderstand what you say. | 16:27 |
| mriedem | dansmith: anyway, not volume related so i don't think that's one of the ones sean was talking about | 16:28 |
| dansmith | mriedem: ah, I forgot this is multinode | 16:28 |
| mriedem | still a high percent failure in the multinode job though | 16:28 |
| edleafe | markus_z: hmmm, then why specify the sections in nova/opts.py list_opts? | 16:28 |
| sfinucan | actually, anyone can answer this: is this not allowed --> 'from nova.objects.field import X'? If so, how come? | 16:28 |
| dansmith | mriedem: well, it's a volume test that fails to ssh, which is I think the only data he had, no? | 16:28 |
| dansmith | sfinucan: because you don't import things inside a module you import a module | 16:28 |
| mriedem | rpodolyaka: i'm not even sure how this is logged https://github.com/openstack/oslo.db/blob/3.1.0/oslo_db/api.py#L169 | 16:29 |
| *** ianbrown_ has joined #openstack-nova | 16:29 | |
| dansmith | sfinucan: should be all over the developer docs | 16:29 |
| *** markmc has quit IRC | 16:29 | |
| *** salv-orlando has quit IRC | 16:29 | |
| mriedem | rpodolyaka: oh wait, yeah i do | 16:29 |
| mriedem | b/c it's the pymysql error | 16:29 |
| *** mariusv_ has joined #openstack-nova | 16:29 | |
| sfinucan | dansmith: Damn. None of the tests picked it up :( OK, I'll fix | 16:29 |
| dansmith | mriedem: http://logs.openstack.org/32/253732/4/check/gate-grenade-dsvm-multinode/9f726ed/logs/subnode-2/old/screen-n-cpu.txt.gz?level=TRACE | 16:29 |
| mriedem | rpodolyaka: well, it's the deadlock error i gues | 16:29 |
| dansmith | sfinucan: hacking should fail | 16:29 |
| mriedem | dansmith: yup | 16:30 |
| *** pratikmallya has joined #openstack-nova | 16:30 | |
| sfinucan | dansmith: Nope. Something to do with objects, Nikola thinks https://review.openstack.org/#/c/202648/23/nova/virt/hardware.py | 16:30 |
| mriedem | dansmith: that's what we're tracking in http://status.openstack.org/elastic-recheck/index.html#1521823 | 16:30 |
| *** changbl has quit IRC | 16:30 | |
| dansmith | mriedem: gotcha.. kinda seems like the old two-computes-one-hostname bug | 16:30 |
| rpodolyaka | mriedem: hmm, I was sure DBDeadlock is 'our' exception. or there is one with the same name in pymysql too? | 16:30 |
| markus_z | edleafe: The oslo generator cannot determine this from the registering of the config opts. I don't know why. | 16:31 |
| *** jdurgin1 has joined #openstack-nova | 16:31 | |
| mriedem | rpodolyaka: no it's the DBDeadlock from oslo.db | 16:31 |
| mriedem | dansmith: hmm, i never heard how that was sorted out | 16:31 |
| ndipanov | sfinucan, shoot | 16:31 |
| mriedem | thought it was some infra thing? | 16:31 |
| rpodolyaka | mriedem: ah,ok, that's better, at least we wrap it :P | 16:31 |
| markus_z | edleafe: I don't see a use case where I want this to be different. | 16:31 |
| dansmith | mriedem: it was, but we have new clouds | 16:31 |
| mriedem | rpodolyaka: yeah, so i'm going to push a change to remove that logging | 16:31 |
| rpodolyaka | mriedem: cool! send me a link when you do | 16:31 |
| mriedem | rpodolyaka: since if we are done retrying, we log here https://github.com/openstack/oslo.db/blob/3.1.0/oslo_db/api.py#L143 | 16:31 |
| *** mariusv has quit IRC | 16:31 | |
| *** dedery_ has quit IRC | 16:31 | |
| edleafe | markus_z: that's what I was assuming, and why I think the grouping has to be explicit in nova/opts.py | 16:32 |
| sfinucan | ndipanov: It's OK - dansmith explained the error of my ways ^^^ | 16:32 |
| markus_z | edleafe: A "popular" issue is fixed by this: https://review.openstack.org/#/c/235396/ | 16:32 |
| mriedem | and if its unexpected, we'd reraise here https://github.com/openstack/oslo.db/blob/3.1.0/oslo_db/api.py#L141 | 16:32 |
| *** smatzek has joined #openstack-nova | 16:32 | |
| ndipanov | sfinucan, he's been know to do that | 16:32 |
| dansmith | mriedem: yeah, hostname is "ubuntu" on this one I think | 16:33 |
| edleafe | markus_z: that reinforces my thought that the individual files shouldn't be determining the grouping | 16:33 |
| *** otter768 has joined #openstack-nova | 16:33 | |
| edleafe | markus_z: just nova/opts.py | 16:33 |
| dansmith | mriedem: lemme go to -infra | 16:33 |
| markus_z | edleafe: Oh, I interpret it differently. The change which moved the vnc options to their own group did not change the "opts.py" because the grouping was in two different locations. | 16:34 |
| edleafe | markus_z: the reason it had to change in nova/opts.py is because that's what determines what gets generated | 16:36 |
| edleafe | markus_z: without that change there was no 'vnc' section, even with the register_opts specifying the vnc group | 16:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add service status notification https://review.openstack.org/245678 | 16:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add infra for versioned notifications https://review.openstack.org/247024 | 16:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications https://review.openstack.org/248167 | 16:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable https://review.openstack.org/247564 | 16:37 |
| openstackgerrit | jichenjc proposed openstack/nova: Remove flavor.extra_spec on hw_watchdog_action https://review.openstack.org/254852 | 16:37 |
| *** otter768 has quit IRC | 16:38 | |
| markus_z | edleafe: That's the change which moved the vnc options to their own group. https://review.openstack.org/#/c/193923/2/nova/vnc/__init__.py,cm I believe if there would have been a "list_opts" method the issue I linked earlier wouldn't have happended. | 16:38 |
| edleafe | markus_z: so ideally there would be no groupings in nova/opts.py, and simply a series of list_opts() calls to each section of opts? | 16:40 |
| markus_z | edleafe: yes, exactly | 16:40 |
| markus_z | edleafe: I want to refactor those "opts.py" in a last step when all options are moved. | 16:40 |
| markus_z | edleafe: They are spread in the tree and you have to *know* that they are there and have to be changed. | 16:41 |
| markus_z | edleafe: I didn't make that clear I guess, sorry. | 16:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add hv testing for ImageMetaProps._legacy_property_map https://review.openstack.org/254856 | 16:41 |
| mriedem | garyk: ^ added testing for your change | 16:41 |
| edleafe | markus_z: that was why I preferred one place to name them and group them | 16:41 |
| edleafe | markus_z: but spreading them out among all the files will work, too, once they are in the same directory | 16:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add hv testing for ImageMetaProps._legacy_property_map https://review.openstack.org/254856 | 16:42 |
| markus_z | edleafe: I'm missing something, sorry. What did you mean with "one place to name them"? | 16:43 |
| *** changbl has joined #openstack-nova | 16:43 | |
| edleafe | markus_z: nova/opts.py, as opposed to doing that in many nova/conf/*py files | 16:44 |
| *** boris-42_ has joined #openstack-nova | 16:44 | |
| *** armax has quit IRC | 16:44 | |
| markus_z | edleafe: Ah. And that "nova/opts.py" has all config options we have? | 16:44 |
| *** unicell has quit IRC | 16:45 | |
| markus_z | edleafe: If "yes", there were concerns about merge conflicts and that file would be overwhelming. | 16:45 |
| edleafe | markus_z: it certainly appears that it does, although I haven't gone through each one :) | 16:45 |
| *** unicell has joined #openstack-nova | 16:45 | |
| *** yarkot has quit IRC | 16:46 | |
| edleafe | markus_z: since each individual option isn't spelled out | 16:46 |
| edleafe | markus_z: just the list from each file | 16:46 |
| *** jichen has quit IRC | 16:46 | |
| edleafe | markus_z: e.g., nova.db.api.db_opts | 16:47 |
| edleafe | markus_z: not each individual db opt | 16:47 |
| *** openstackgerrit has quit IRC | 16:47 | |
| *** openstackgerrit has joined #openstack-nova | 16:47 | |
| edleafe | markus_z: so that if another db opt is added, nova/opts.py would pick it up | 16:47 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: virt: Allow multiple volume attachments https://review.openstack.org/193135 | 16:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach https://review.openstack.org/153038 | 16:48 |
| *** Daisy has joined #openstack-nova | 16:48 | |
| *** yarkot has joined #openstack-nova | 16:49 | |
| markus_z | edleafe: Isn't that the same when adding a new option to "nova/conf/<module>.py" and adding it to the "ALL_OPTS" list? | 16:50 |
| *** armax has joined #openstack-nova | 16:51 | |
| *** zhenq has quit IRC | 16:51 | |
| edleafe | markus_z: well, if the ALL_OPTS is then returned by list_opts() | 16:51 |
| markus_z | edleafe: yes, true | 16:51 |
| edleafe | markus_z: the point was trying to understand why you thought there would be merge conflicts | 16:52 |
| *** Daisy has quit IRC | 16:52 | |
| markus_z | edleafe: It seems that we made bad experiences with the exceptions.py module which contains all of our exception classes. | 16:53 |
| edleafe | markus_z: ah | 16:54 |
| edleafe | markus_z: I think that a series of .py files for each logical opt grouping, and a central place for gathering them makes a lot of sense | 16:55 |
| edleafe | as long as the central place isn't listing them one-by-one | 16:55 |
| edleafe | but getting them from each .py file | 16:55 |
| *** ianbrown__ has joined #openstack-nova | 16:55 | |
| *** alejandrito has joined #openstack-nova | 16:55 | |
| *** unicell1 has joined #openstack-nova | 16:56 | |
| *** apoorvad has joined #openstack-nova | 16:56 | |
| *** apoorvad has quit IRC | 16:56 | |
| *** unicell has quit IRC | 16:57 | |
| markus_z | edleafe: yepp. I didn't yet try it but I think there will be a "nova/conf/opts.py" file which calls all of the "list_opts" methods. The other "opts.py" in the tree would then be obsolete. | 16:57 |
| *** ianbrown_ has quit IRC | 16:57 | |
| edleafe | markus_z: that sounds sane. | 16:58 |
| markus_z | edleafe: I forget to put some important words in my sentences... I'm not yet 100% fit. | 16:58 |
| *** yamahata has joined #openstack-nova | 16:58 | |
| markus_z | edleafe: It does? Or did I filibuster you? | 16:58 |
| *** mgoddard has quit IRC | 16:59 | |
| edleafe | markus_z: I'm perfectly healthy and I forget to make my thoughts clear :) | 16:59 |
| *** danpb has quit IRC | 16:59 | |
| edleafe | markus_z: no, it's along the lines of how I see it. Whether the central place is nova/opts.py or nova/conf/opts.py isn't as important | 17:00 |
| dansmith | sdague: so can you link me to one of the logs where we're failing a volume test with the ssh failure that isn't the same as the one where I noticed the hostname thing? | 17:00 |
| markus_z | edleafe: True. As long as simple bugs like this get prevented: https://bugs.launchpad.net/nova/+bug/1506356 | 17:00 |
| openstack | Launchpad bug 1506356 in OpenStack Compute (nova) "There is no "[vnc]" option group in nova.conf.sample" [Low,In progress] - Assigned to shunya kitada (skitada) | 17:00 |
| dansmith | sdague: I would assume that if this is happening, any number of tests would fail for various reasons as calls get directed to the wrong compute node(s) | 17:01 |
| *** vishwanathj has joined #openstack-nova | 17:01 | |
| markus_z | edleafe: OK, cool, we have a conclusion, right? | 17:02 |
| *** ildikov has quit IRC | 17:02 | |
| sdague | dansmith: sure, let me look | 17:03 |
| edleafe | markus_z: not sure - do you now agree that a central place for defining the groups is the way to go? | 17:03 |
| edleafe | markus_z: i.e., nova/conf/opts.py? | 17:03 |
| *** vilobhmm11 has quit IRC | 17:03 | |
| *** busterswt has quit IRC | 17:04 | |
| *** jlanoux has quit IRC | 17:04 | |
| *** alex_xu has quit IRC | 17:04 | |
| markus_z | edleafe: let me write some (pseudo) code, one sec | 17:04 |
| *** yalie has quit IRC | 17:04 | |
| sdague | dansmith: yeh - http://logs.openstack.org/92/253792/7/check/gate-grenade-dsvm-multinode/d52d36a/logs/old/screen-n-cond.txt.gz#_2015-12-07_20_42_59_531 | 17:04 |
| *** Yingxin has quit IRC | 17:04 | |
| *** gzhai3 has quit IRC | 17:04 | |
| sdague | host = ubuntu | 17:04 |
| dansmith | sdague: yeah | 17:04 |
| sdague | good catch | 17:04 |
| dansmith | \o/ | 17:04 |
| sdague | it will be good to see what the fail rate settles into once this fix is out there | 17:05 |
| dansmith | indeed | 17:05 |
| markus_z | edleafe: I'm putting it at the end of this etherpad: https://etherpad.openstack.org/p/config-options | 17:05 |
| *** apoorvad has joined #openstack-nova | 17:06 | |
| *** zhenq has joined #openstack-nova | 17:06 | |
| *** Kennan has quit IRC | 17:06 | |
| *** houming has quit IRC | 17:07 | |
| edleafe | markus_z: cool | 17:07 |
| dansmith | markus_z: you should -1 that pci doc patch.. hard to tell there are pending comments otherwise | 17:07 |
| *** Kennan has joined #openstack-nova | 17:07 | |
| markus_z | dansmith: ah, ok, I'll do that | 17:07 |
| dansmith | markus_z: thanks | 17:08 |
| cfriesen | ndipanov: you've been looking at sfinucan's threading policy patches, but the spec change is still in progress...any chance we can get https://review.openstack.org/#/c/244198/ approved? | 17:08 |
| *** sudipto has quit IRC | 17:09 | |
| *** gzhai3 has joined #openstack-nova | 17:09 | |
| sdague | BobBall: I can fix the registration, but https://review.openstack.org/#/c/254760/2 failure is pretty opaque to me | 17:09 |
| *** busterswt has joined #openstack-nova | 17:09 | |
| ndipanov | cfriesen, let's land patches first? | 17:10 |
| *** alex_xu has joined #openstack-nova | 17:10 | |
| *** Yingxin has joined #openstack-nova | 17:11 | |
| markus_z | edleafe: I added the code as I understand it. Would you change it to show what you mean? | 17:12 |
| ndipanov | cfriesen, I think actual patches are more important and the BP is approved | 17:12 |
| rlrossit | dansmith: prepare for me bugging you some more... if possible, could you take a look at https://review.openstack.org/#/c/252594/ to let me know if I'm on the right track before the nova notifications meeting this afternoon? | 17:12 |
| edleafe | markus_z: sure | 17:12 |
| rlrossit | I will be eternally grateful :) | 17:12 |
| sfinucan | cfriesen: I don't think we need the spec reworked to get code in, per earlier discussion with ndipanov. Suits me as there's enough work in the code alone :) | 17:13 |
| dansmith | rlrossit: does tuple support += ? | 17:13 |
| sfinucan | However, I'm off home so I'll let you discuss it among yourselves, if necessary | 17:13 |
| rlrossit | dansmith: it did for me when I was testing at least | 17:13 |
| dansmith | rlrossit: doesn't for me just now | 17:13 |
| dansmith | rlrossit: er wait, it does | 17:14 |
| dansmith | hmm, that's weird | 17:14 |
| rlrossit | :) | 17:14 |
| *** amotoki has quit IRC | 17:14 | |
| rlrossit | did you try to append something like (stuff) instead of (stuff,) ? | 17:14 |
| dansmith | yeah, but tuples are supposed to be immutable | 17:14 |
| dansmith | so whatever | 17:14 |
| *** ccarmack has quit IRC | 17:15 | |
| rlrossit | dansmith: depends on what you mean by "immutable" | 17:15 |
| rlrossit | they still are her | 17:15 |
| rlrossit | here | 17:15 |
| dansmith | rlrossit: well, clearly | 17:15 |
| *** yalie has joined #openstack-nova | 17:16 | |
| *** salv-orl_ has quit IRC | 17:16 | |
| *** RichardRaseley has joined #openstack-nova | 17:17 | |
| *** unicell1 has quit IRC | 17:18 | |
| rlrossit | dansmith: :) | 17:18 |
| rlrossit | http://www.smbc-comics.com/index.php?id=3907 | 17:19 |
| markus_z | rlrossit: rofl :D | 17:20 |
| rpodolyaka | mriedem: btw, I completely forgot about this one - https://review.openstack.org/#/c/222783/4 | 17:21 |
| rpodolyaka | mriedem: maybe you could simply update it | 17:21 |
| *** jistr|mtg is now known as jistr | 17:21 | |
| *** paul-carlton_ has quit IRC | 17:22 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allow saving empty pci_device_pools in ComputeNode object https://review.openstack.org/216049 | 17:23 |
| edleafe | markus_z: ok, changed it to centralize the groups in nova/conf/opts.py | 17:23 |
| markus_z | edleafe: Ah, ok, I did understand you correctly. My issue with that approach is that the group name "vnc" is spread over two files and one has to know that these two must be the same. | 17:24 |
| *** matrohon has quit IRC | 17:25 | |
| edleafe | markus_z: yeah, I see that | 17:25 |
| *** rfolco_ has quit IRC | 17:25 | |
| edleafe | markus_z: let me change it once again... | 17:25 |
| *** Yingxin has quit IRC | 17:26 | |
| mriedem | rpodolyaka: i can clean that up, i don't like the kwarg though, | 17:26 |
| mriedem | rpodolyaka: b/c that menas nova has to pass LOG.DEBUG wherever the retry decorator is used | 17:26 |
| *** mrkz has quit IRC | 17:26 | |
| mriedem | rpodolyaka: oslo.db should just be sane and not trace exceptions for things it expects to hit in a retry decorator | 17:27 |
| *** yassine__ has quit IRC | 17:27 | |
| edleafe | markus_z: how about now? | 17:27 |
| mriedem | rpodolyaka: i have a nova change to cleanup first and then i'll update kevinbenton's change | 17:27 |
| *** rotbeard has quit IRC | 17:27 | |
| markus_z | edleafe: yepp, that's very good imo. | 17:28 |
| edleafe | markus_z: IOW, make the grouping explicit, and that can be a pattern for all conf/*.py files | 17:28 |
| kevinbenton | mriedem: my oslo db patch? | 17:28 |
| mriedem | yeah https://review.openstack.org/#/c/222783/ | 17:28 |
| *** rfolco_ has joined #openstack-nova | 17:28 | |
| mriedem | i'd rather not have to pass the log level kwarg in | 17:28 |
| kevinbenton | mriedem: yeah, feel free to take over that. i'm swamped | 17:28 |
| mriedem | oslo.db should just be smarter | 17:28 |
| mriedem | k | 17:28 |
| rpodolyaka | mriedem: I'm ok with .debug() | 17:28 |
| markus_z | edleafe: yes. that's better than my first version. Let me change it one more time :) | 17:28 |
| mriedem | #success: a small handful of people agree on sanity! | 17:29 |
| openstackstatus | mriedem: Added success to Success page | 17:29 |
| rpodolyaka | :) | 17:29 |
| mriedem | kevinbenton: btw, i watched your mitaka summit session on perf profiling in neutron db stuff, very nice | 17:29 |
| kevinbenton | thanks! glad someone else saw it. the room had like 15 people in it :) | 17:30 |
| mriedem | i watched on youtube | 17:30 |
| mriedem | but yeah | 17:30 |
| markus_z | edleafe: what about now? | 17:30 |
| *** Yingxin has joined #openstack-nova | 17:31 | |
| mriedem | dansmith: i forget, does x in y where y is a nova object trigger lazy load? | 17:31 |
| *** tonytan4ever has quit IRC | 17:31 | |
| edleafe | markus_z: how will that work with DEFAULT? | 17:31 |
| *** mrkz has joined #openstack-nova | 17:31 | |
| dansmith | mriedem: shouldn't if it's using obj_attr_is_set, which is what you did right? | 17:31 |
| mriedem | this is in the bdm object | 17:31 |
| johnthetubaguy | mriedem: talking of which, we have this os-profiler spec and patches submitted: https://blueprints.launchpad.net/nova/+spec/osprofiler-support-in-nova | 17:31 |
| markus_z | edleafe: hmm... I guess it doesn't. But with all the other groups. | 17:32 |
| mriedem | johnthetubaguy: i don't think kevinbenton used any of the osprofiler stuff | 17:32 |
| edleafe | markus_z: that's why I thought a constant with the group name would be cleaner | 17:32 |
| *** sahid has quit IRC | 17:32 | |
| johnthetubaguy | mriedem: interesting, I was curious about that | 17:32 |
| edleafe | markus_z: if you're using DEFAULT | 17:32 |
| kevinbenton | osprofiler would have been nice, this was just based on measuring response times of calls over the AMQP bus | 17:33 |
| markus_z | edleafe: Yes, If you're using DEFAULT than your example was the better approach, yes. | 17:33 |
| mriedem | https://www.openstack.org/summit/tokyo-2015/videos/presentation/performance-improvements-to-the-neutron-management-and-control-plane-apis | 17:33 |
| mriedem | johnthetubaguy: ^ | 17:33 |
| mriedem | that was the session | 17:33 |
| johnthetubaguy | cools | 17:33 |
| edleafe | markus_z: and at least for now, most are in DEFAULT | 17:33 |
| mriedem | the funny thing was the parts where 'we added x to improve performance and it degraded performance somehow' | 17:34 |
| markus_z | edleafe: A lot, true | 17:34 |
| kevinbenton | yeah, like whackamole | 17:34 |
| rpodolyaka | heh :) | 17:34 |
| kevinbenton | improved one call and punished another | 17:34 |
| ndipanov | dansmith, move this to +0 at least? https://review.openstack.org/#/c/148277/ | 17:35 |
| johnthetubaguy | mriedem: kevinbenton: totally went through that with the scheduler, turning off my original enhancement idea improved the performance | 17:35 |
| rpodolyaka | kevinbenton: yeah, such 'improvements' without proper benchmarking are profiling are often painful | 17:35 |
| rpodolyaka | *and | 17:35 |
| *** scheuran has quit IRC | 17:36 | |
| *** aginwala has joined #openstack-nova | 17:36 | |
| *** pratikmallya has quit IRC | 17:36 | |
| kevinbenton | the challenge is that the different agents need things grouped in different ways. so turning on a joined load would help the one but then slow down one that didn't need the extra info | 17:37 |
| dansmith | ndipanov: you asked me to -1 this in the first place and now you want me to remove it? | 17:37 |
| dansmith | ndipanov: as I said before, I think we should get bauzas' read on it | 17:37 |
| *** gmann has quit IRC | 17:38 | |
| dansmith | given that bauzas' set is, IMHO, more important, I surely don't care about jeopardizing this notifications set while making his work harder | 17:38 |
| *** smatzek has quit IRC | 17:39 | |
| dane-fichter | Can anyone give me some pointers on getting the py34 test environment to work correctly locally? It does not run my tests even though they are included in tests-py3.txt | 17:39 |
| mriedem | dane-fichter: there is a blacklist | 17:39 |
| *** klkumar has quit IRC | 17:39 | |
| markus_z | edleafe: how about the conclusion at the end in the etherpad? | 17:40 |
| *** gmann has joined #openstack-nova | 17:40 | |
| dansmith | ndipanov: oh, he did rebase on bauzas' set, right? you're just asking me to clear the -1 since jenkins re-added it? | 17:40 |
| mriedem | dane-fichter: https://github.com/openstack/nova/blob/master/tests-py3.txt | 17:40 |
| mriedem | dane-fichter: https://github.com/openstack/nova/blob/master/tox.ini#L50 | 17:40 |
| *** lykinsbd has quit IRC | 17:40 | |
| mriedem | so you have to remove the tests from the blacklist if you want to run them with the py34 target | 17:40 |
| dane-fichter | mriedem: ah ok. why does the gate on Gerrit run them then? | 17:41 |
| ndipanov | dansmith, yes | 17:41 |
| dansmith | I'm not sure why it re-added that after a rebase | 17:41 |
| ndipanov | well the patch was not affected | 17:42 |
| *** aginwala has quit IRC | 17:42 | |
| ndipanov | it was a clean rebase | 17:42 |
| dansmith | well, I know, but usually it does | 17:42 |
| dansmith | there must be some detail I'm missing about when it does and doesn't | 17:42 |
| dansmith | anyway | 17:42 |
| ndipanov | for a clean rebase it won't clear reviews | 17:42 |
| dansmith | well, it does clear mine when I rebase cleanly on master and resubmit | 17:43 |
| ndipanov | really? | 17:43 |
| dansmith | yes | 17:43 |
| dansmith | all the time | 17:43 |
| ndipanov | it clears jenkins but not humans | 17:43 |
| *** garyk has quit IRC | 17:43 | |
| dansmith | maybe there are multiple levels of clean-ness | 17:43 |
| ndipanov | humans > jenkinses | 17:43 |
| edleafe | markus_z: updated the etherpad | 17:44 |
| ndipanov | alleged humans I should say | 17:44 |
| markus_z | edleafe: absolutely sane that way | 17:44 |
| dane-fichter | mriedem: does the gate-nova-python34 gate run all tests regardless of the tests-py3.txt blacklist? | 17:44 |
| edleafe | markus_z: ok, I'll update the scheduler option bits | 17:44 |
| *** aginwala has joined #openstack-nova | 17:45 | |
| tjones | markus_z: i'll break the dependency on my other patches from the volume one. was just trying to avoid the rebase on __init__ but it's trivial. :-) | 17:45 |
| *** ccarmack has joined #openstack-nova | 17:45 | |
| markus_z | edleafe: cool, thanks | 17:45 |
| *** Redcavalier has joined #openstack-nova | 17:45 | |
| markus_z | tjones: ok, great, I wanted to talk to you about that. Thanks for that! Please also upload follow up patches which describe the options more in detail. | 17:46 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Support configuration of multiple pci_alias within an array https://review.openstack.org/242555 | 17:47 |
| tjones | yep will do | 17:47 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Replace os.path.join() for URLs https://review.openstack.org/218309 | 17:47 |
| markus_z | tjones: awesome, thanks! | 17:47 |
| mriedem | dane-fichter: no | 17:48 |
| mriedem | it's the same as local | 17:48 |
| Redcavalier | Hi guys, got a question about the nova network code and how it interacts with openvswitch. We notice that nova creates two veth and a linux bridge. We're trying yo find where exactly the second veth is linked to the OVS port. I'm pretty sure it's in the nova code, but please correct me if I'm wrong. | 17:48 |
| mriedem | dane-fichter: the gate jobs wouldn't / shouldn't be running them | 17:48 |
| mriedem | dane-fichter: i'd need the actual test id though | 17:49 |
| dane-fichter | mriedem: https://review.openstack.org/#/c/189843/ | 17:49 |
| mriedem | dane-fichter: so nova.tests.unit.image.test_glance.TestDownloadNoDirectUri.test_download_with_signature_verification_fail | 17:50 |
| dane-fichter | so my tests in test_glance are failing, even though they are part of the TestDownloadNoDirectURI | 17:50 |
| dane-fichter | correct | 17:50 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Only consider requested_destination https://review.openstack.org/248833 | 17:50 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Factor _rebuild_pick_host out of rebuild_instance https://review.openstack.org/254887 | 17:50 |
| *** e0ne has quit IRC | 17:50 | |
| mriedem | dane-fichter: so that test class isn't blacklisted | 17:51 |
| mriedem | so you should be able to run it locally fine | 17:51 |
| edleafe | markus_z: question on the scheduler opts. How does the generator find that? | 17:51 |
| mriedem | tox -r -e py34 -- nova.tests.unit.image.test_glance.TestDownloadNoDirectUri.test_download_with_signature_verification_fail | 17:51 |
| cfriesen | sfinucan: ndipanov: sorry for the lag, wasn't paying attention. I guess I'm a bit confused because some of the proposed patches are only valid if we approve the modifications to the spec. | 17:51 |
| *** ianbrown__ has quit IRC | 17:52 | |
| markus_z | edleafe: There is the file "etc/nova/nova-config-generator.conf". | 17:52 |
| markus_z | edleafe: the namespace is a folder which must contain a "opts.py" module with a "list_opts" function | 17:52 |
| edleafe | markus_z: ah, so just remove the reference from there | 17:52 |
| cfriesen | sfinucan: ndipanov: otherwise the spec won't reflect the implementation, leading to confusion later on when people read the spec and not the code | 17:52 |
| dane-fichter | mriedem: it looks blacklisted to me | 17:53 |
| edleafe | markus_z: so we can move them into nova/conf | 17:53 |
| mriedem | dane-fichter: nova.tests.unit.image.test_glance is not blacklisted | 17:54 |
| mriedem | it doesn't show up in https://github.com/openstack/nova/blob/master/tests-py3.txt | 17:54 |
| dane-fichter | mriedem: I guess I locally have an old version of tests-py3 (?) I just cloned this repo from github though | 17:54 |
| markus_z | edleafe: You want to delete the "nova/scheduler/opts.py" file? If "yes", than you have to delete the reference in "nova-config-generator" I guess. As I said, I didn't yet try it. | 17:55 |
| mriedem | dane-fichter: could be an old os-testr? | 17:55 |
| edleafe | markus_z: ok | 17:55 |
| dane-fichter | mriedem: perhaps. thanks for your help | 17:55 |
| mriedem | dane-fichter: it uses os-testr to trim the tests https://github.com/openstack/nova/blob/master/tox.ini#L50 | 17:55 |
| cdent | mordred++ that letter to the tc list is excellent | 17:56 |
| *** ianbrown__ has joined #openstack-nova | 17:56 | |
| markus_z | edleafe: I have to leave for today. See you tomorrow. | 17:56 |
| edleafe | markus_z: ok - enjoy your evening | 17:57 |
| *** busterswt has quit IRC | 17:57 | |
| markus_z | edleafe: thanks, have a nice day | 17:57 |
| *** markus_z has quit IRC | 17:57 | |
| *** yarkot has quit IRC | 17:58 | |
| mordred | cdent: thanks! | 17:58 |
| *** suro-patz has joined #openstack-nova | 17:58 | |
| *** shz has quit IRC | 18:00 | |
| *** jaosorior has quit IRC | 18:00 | |
| *** vishwanathj has quit IRC | 18:00 | |
| *** Vek has joined #openstack-nova | 18:01 | |
| *** shz has joined #openstack-nova | 18:01 | |
| *** smatzek has joined #openstack-nova | 18:02 | |
| *** yalie1 has joined #openstack-nova | 18:05 | |
| *** jistr has quit IRC | 18:05 | |
| *** PaulMurray is now known as ptm_away | 18:06 | |
| *** pratikmallya has joined #openstack-nova | 18:07 | |
| *** yalie has quit IRC | 18:09 | |
| *** gzhai has joined #openstack-nova | 18:09 | |
| *** unicell has joined #openstack-nova | 18:10 | |
| *** gzhai3 has quit IRC | 18:12 | |
| *** derekh has joined #openstack-nova | 18:14 | |
| mriedem | ndipanov: when converting a BlockDeviceDict to a nova.virt.block_device.DriverBlockDevice, that wraps a bdm object (creates one if the bdm passed in isn't a NovaObject), where do we ever set the context on the internal bdm nova object that we create? | 18:15 |
| mriedem | since bdm.save() requires a context | 18:15 |
| *** tonytan4ever has joined #openstack-nova | 18:16 | |
| *** derekh has quit IRC | 18:16 | |
| mriedem | the nova.tests.virt.test_block_device tests just mock out bdm.save() like this: | 18:16 |
| mriedem | self.mox.StubOutWithMock(driver_bdm._bdm_obj, 'save') | 18:16 |
| mriedem | so i'm not sure if we're just working in devstack b/c the DriverBlockDevice is always constructed with a BlockDeviceMapping object (that has a context in it), or if i'm missing something | 18:17 |
| *** salv-orlando has joined #openstack-nova | 18:17 | |
| ndipanov | mriedem, not sure might be a bug | 18:18 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Support configuration of multiple pci_alias within an array https://review.openstack.org/242555 | 18:18 |
| ndipanov | probably it's always constructed from an object meaning we should remove the other option <- mriedem | 18:18 |
| mriedem | ndipanov: yeah....i'm thinking so | 18:18 |
| sfinucan | cfriesen: That would make sense, but assuming the enum gets +2d, the only possible changes could be with wording | 18:19 |
| sfinucan | so not really that important | 18:19 |
| sfinucan | at least that's my take :) | 18:19 |
| *** alejandrito has quit IRC | 18:19 | |
| mriedem | ndipanov: bdm.save() does take a context, so we could pass that in, if we wanted to preserve the old transformation code, but it's probably not worht it | 18:19 |
| mriedem | *worth | 18:19 |
| *** alejandrito has joined #openstack-nova | 18:19 | |
| sfinucan | now I'm *really* going home :) | 18:19 |
| *** sfinucan has quit IRC | 18:19 | |
| mriedem | dansmith: am i misremembering the stance on passing context to objects CRUD methods, but was save(context) still ok? | 18:19 |
| mriedem | no, BlockDeviceMapping.save() doesn't take context anymore, even if the parent class does | 18:20 |
| dansmith | mriedem: if it's remotable (not classmethod) then it should not take a context | 18:20 |
| mriedem | @base.remotable | 18:21 |
| mriedem | def save(self): | 18:21 |
| mriedem | ok | 18:21 |
| *** tonytan4ever has quit IRC | 18:21 | |
| *** ccarmack has quit IRC | 18:21 | |
| *** ssurana has joined #openstack-nova | 18:21 | |
| *** salv-orlando has quit IRC | 18:21 | |
| mriedem | ndipanov: so i'm going to remove this https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L128-L131 | 18:21 |
| mriedem | since it's busted | 18:21 |
| mriedem | ever since we did https://review.openstack.org/#/c/164268/ | 18:22 |
| mriedem | we just papered over the fact in the tests | 18:22 |
| mriedem | by mocking out save() | 18:22 |
| *** ctrath has quit IRC | 18:23 | |
| cfriesen | sfinucan: fair enough. I just thought it was sort of backwards to approve code changes before approving the spec driving the changes. :) | 18:24 |
| *** gokrokve has quit IRC | 18:24 | |
| ndipanov | mriedem, sounds good | 18:24 |
| ndipanov | ping me for a +2 if in next 45 minutes as I have a call so will be around | 18:25 |
| *** vilobhmm11 has joined #openstack-nova | 18:25 | |
| *** thangp has quit IRC | 18:25 | |
| *** shakamunyi has joined #openstack-nova | 18:25 | |
| *** gokrokve has joined #openstack-nova | 18:25 | |
| mriedem | ndipanov: this will be tomorrow | 18:25 |
| mriedem | i have to hack around it for now to get some tests passing | 18:26 |
| mriedem | i opened a bug for tracking though https://bugs.launchpad.net/nova/+bug/1524035 | 18:26 |
| openstack | Launchpad bug 1524035 in OpenStack Compute (nova) "nova.virt.block_device.DriverBlockDevice cannot save to DB if bdm passed in was not already an object" [Undecided,New] | 18:26 |
| *** mgoddard has joined #openstack-nova | 18:26 | |
| ndipanov | mriedem, cool | 18:27 |
| *** jaypipes has quit IRC | 18:27 | |
| *** ctrath has joined #openstack-nova | 18:28 | |
| *** pumaranikar has quit IRC | 18:29 | |
| *** ccarmack has joined #openstack-nova | 18:29 | |
| *** gokrokve has quit IRC | 18:30 | |
| *** dims_ has quit IRC | 18:30 | |
| *** ijw has joined #openstack-nova | 18:30 | |
| *** ircuser-1 has quit IRC | 18:30 | |
| *** xyang1 has quit IRC | 18:31 | |
| *** xyang1 has joined #openstack-nova | 18:31 | |
| *** gokrokve has joined #openstack-nova | 18:31 | |
| *** ijw_ has joined #openstack-nova | 18:32 | |
| *** ijw has quit IRC | 18:32 | |
| *** gokrokve has quit IRC | 18:33 | |
| *** otter768 has joined #openstack-nova | 18:34 | |
| *** gokrokve has joined #openstack-nova | 18:34 | |
| *** tonytan4ever has joined #openstack-nova | 18:35 | |
| *** paul-carlton2 has quit IRC | 18:37 | |
| *** tjones has quit IRC | 18:37 | |
| *** xyang1 has quit IRC | 18:38 | |
| *** smurke has quit IRC | 18:38 | |
| *** smurke has joined #openstack-nova | 18:38 | |
| *** otter768 has quit IRC | 18:39 | |
| *** jerrygb has quit IRC | 18:39 | |
| *** e0ne has joined #openstack-nova | 18:39 | |
| *** gzhai1 has joined #openstack-nova | 18:41 | |
| *** tjones has joined #openstack-nova | 18:42 | |
| *** pumaranikar has joined #openstack-nova | 18:43 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests https://review.openstack.org/249017 | 18:43 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment https://review.openstack.org/249018 | 18:43 |
| *** Kennan has quit IRC | 18:43 | |
| *** Kennan has joined #openstack-nova | 18:44 | |
| *** gzhai has quit IRC | 18:44 | |
| *** cdent has quit IRC | 18:45 | |
| *** ljxiash has quit IRC | 18:45 | |
| *** jerrygb has joined #openstack-nova | 18:46 | |
| *** rlrossit has quit IRC | 18:46 | |
| *** aginwala has quit IRC | 18:47 | |
| *** david-ly_ has joined #openstack-nova | 18:50 | |
| *** rook has quit IRC | 18:51 | |
| *** david-ly_ is now known as david-lyle_ | 18:52 | |
| *** rlrossit has joined #openstack-nova | 18:52 | |
| *** eliqiao has quit IRC | 18:52 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova: Update functional tests to support optional project id https://review.openstack.org/254485 | 18:53 |
| *** david-lyle has quit IRC | 18:54 | |
| *** eliqiao has joined #openstack-nova | 18:55 | |
| *** ildikov has joined #openstack-nova | 18:55 | |
| *** ctrath has quit IRC | 18:56 | |
| openstackgerrit | Tracy Jones proposed openstack/nova: config options: centralize section "volume" https://review.openstack.org/253747 | 18:56 |
| rlrossit | gibi: what's the plan for developer documentation for the notification work? | 18:57 |
| openstackgerrit | Sean Dague proposed openstack/nova: tighten regex on objectify https://review.openstack.org/254909 | 18:57 |
| sdague | dansmith: because your fingerprints remain in api_samples I expect some blood money / review of that ^^^ | 18:58 |
| sdague | don't worry, it's small | 18:58 |
| *** penick has joined #openstack-nova | 18:58 | |
| sdague | and almost entirely a comment explaining wtf is going on | 18:59 |
| *** READ10 has quit IRC | 18:59 | |
| *** penick_ has joined #openstack-nova | 19:00 | |
| * dansmith runs | 19:00 | |
| openstackgerrit | Vilobh Meshram proposed openstack/nova: Introduce Flavor Classes https://review.openstack.org/253306 | 19:00 |
| *** openstackgerrit has quit IRC | 19:02 | |
| dansmith | sdague: doesn't that change integers into strings? | 19:02 |
| *** openstackgerrit has joined #openstack-nova | 19:03 | |
| *** salv-orlando has joined #openstack-nova | 19:04 | |
| *** penick has quit IRC | 19:04 | |
| *** penick_ is now known as penick | 19:04 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Remove version hardcoding for 'show' method https://review.openstack.org/228578 | 19:04 |
| *** ctrath has joined #openstack-nova | 19:05 | |
| dansmith | sdague: I guess there is some magic in the int: bit but I don't know where that comes from | 19:06 |
| sdague | dansmith: so that's always been there | 19:06 |
| sdague | I'm just changing the anchor on the sub regex | 19:06 |
| dansmith | sdague: yeah, I just don't really know how this is really safe and/or why we're doing this | 19:07 |
| sdague | from ! " to ': ' | 19:07 |
| sdague | so if you don't have it, you can't load the templates as json | 19:07 |
| sdague | because it's a parse error | 19:07 |
| dansmith | oh, I see, I see because we've got these raw things | 19:07 |
| sdague | yep | 19:07 |
| dansmith | guh, yuck | 19:07 |
| *** gokrokve has quit IRC | 19:08 | |
| sdague | yeh, well, blame vishy :) | 19:08 |
| dansmith | yeah | 19:08 |
| sdague | there is only so much unwind we can do here, but I'm trying to simplify an upper layer, and this just got in the way of it | 19:08 |
| dansmith | yeah | 19:08 |
| sdague | at least I payed it forward with more comments | 19:08 |
| *** Sukhdev has joined #openstack-nova | 19:09 | |
| *** lpetrut has joined #openstack-nova | 19:10 | |
| *** salv-orlando has quit IRC | 19:11 | |
| *** burt has joined #openstack-nova | 19:13 | |
| *** david-lyle_ is now known as david-lyle | 19:14 | |
| *** aginwala has joined #openstack-nova | 19:15 | |
| *** gokrokve has joined #openstack-nova | 19:16 | |
| *** rook has joined #openstack-nova | 19:17 | |
| *** garyk has joined #openstack-nova | 19:26 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Allow virt driver to define binding:host_id https://review.openstack.org/194413 | 19:28 |
| *** hblixt has joined #openstack-nova | 19:28 | |
| *** ZZelle_ has joined #openstack-nova | 19:29 | |
| *** aginwala has quit IRC | 19:29 | |
| *** aginwala has joined #openstack-nova | 19:30 | |
| *** gokrokve has quit IRC | 19:31 | |
| *** whenry_ has joined #openstack-nova | 19:31 | |
| *** pratikmallya has quit IRC | 19:33 | |
| *** pratikmallya has joined #openstack-nova | 19:36 | |
| *** harlowja has quit IRC | 19:38 | |
| *** harlowja has joined #openstack-nova | 19:38 | |
| gibi | rlrossit: notification samples as in the forth patch, devref about how to add a new versioned notification | 19:40 |
| *** erhudy has quit IRC | 19:40 | |
| gibi | rlrossit: and also agreed to do some user facing documentation, like a list of notifications, maybe with swagger | 19:41 |
| *** irenab has quit IRC | 19:42 | |
| rlrossit | gibi: I guess my question was more directed at: if I want to make a new notification, what are the steps needed? | 19:42 |
| rlrossit | like how do I make the schema work | 19:42 |
| gibi | rlrossit: that is what we will cover with a devref | 19:43 |
| gibi | rlrossit: at least in my plans :) | 19:44 |
| rlrossit | gibi: oh, I read your message before wrong. I thought you meant we'll be using the json samples as devref. My bad | 19:44 |
| *** burt has quit IRC | 19:45 | |
| gibi | rlrossit: sorry I wasn't clear enough | 19:45 |
| *** mc_nair_ has joined #openstack-nova | 19:51 | |
| *** mc_nair has quit IRC | 19:52 | |
| *** penick has quit IRC | 19:52 | |
| *** jichen has joined #openstack-nova | 19:55 | |
| migi | dansmith, Hi | 19:56 |
| dansmith | migi: o/ | 19:56 |
| *** aysyd has quit IRC | 19:57 | |
| migi | dansmith, o/ = ? | 19:57 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Allow virt driver to define binding:host_id https://review.openstack.org/194413 | 19:57 |
| jroll | migi: o/ = https://media.giphy.com/media/JGKwzgpKXVYaY/giphy.gif | 19:58 |
| dansmith | right, that ^ | 19:58 |
| dansmith | except less dorky | 19:58 |
| migi | :) | 19:59 |
| *** lbelivea has quit IRC | 20:00 | |
| migi | so I am doing that quite easy change and wondering if it's right... in short does all id's needs to be uuids? Example number 1 was given to fixed_ip | 20:01 |
| dansmith | migi: we have ids and uuids.. ids are integers and uuids are ... uuids, so you should only change the latter | 20:02 |
| openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 20:03 |
| *** ctrath has quit IRC | 20:03 | |
| *** rfolco_ has quit IRC | 20:03 | |
| migi | dansmith, right, just the logic makes them same in few tests | 20:04 |
| migi | so will rewrite those parts | 20:05 |
| dansmith | yeah | 20:05 |
| *** aginwala has quit IRC | 20:05 | |
| dansmith | migi: have you pushed any patches up yet? | 20:05 |
| *** lbelivea has joined #openstack-nova | 20:05 | |
| *** artom has quit IRC | 20:05 | |
| dansmith | again, I'd recommend not waiting until it's all done before pushing up early pieces :) | 20:05 |
| migi | dansmith, just one: | 20:06 |
| migi | https://review.openstack.org/#/c/254398/ | 20:06 |
| dansmith | cool | 20:07 |
| migi | today got more, but prefer to fix few things before push | 20:07 |
| *** ctrath has joined #openstack-nova | 20:07 | |
| dansmith | cool | 20:09 |
| *** aginwala has joined #openstack-nova | 20:09 | |
| *** ctrath has quit IRC | 20:09 | |
| *** ociuhandu has quit IRC | 20:09 | |
| *** pece has joined #openstack-nova | 20:09 | |
| *** lbelivea has quit IRC | 20:10 | |
| *** ctrath has joined #openstack-nova | 20:12 | |
| *** lucasagomes is now known as lucas-dinner | 20:13 | |
| *** mariusv_ has quit IRC | 20:13 | |
| *** mariusv has joined #openstack-nova | 20:15 | |
| *** mariusv has quit IRC | 20:15 | |
| *** mariusv has joined #openstack-nova | 20:15 | |
| *** yarkot has joined #openstack-nova | 20:18 | |
| dansmith | migi: commented on one thing I think is inconsistent (but I may be wrong). otherwise that looks good to me | 20:18 |
| dansmith | migi: also, that's about the right (i.e. max) amount of change for one patch, IMHO | 20:18 |
| dansmith | migi: it's not a 36-char string field in the DB: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L247-L247 | 20:21 |
| migi | dansmith, running test to show exception, will reply to comment | 20:21 |
| dansmith | sdague: mriedem: do you know if Instance.image_ref can be anything other than the image uuid? | 20:21 |
| dansmith | migi: okay cool | 20:21 |
| migi | that is why I've asked if all should be uuids as I was getting errors in places where I shouldn't (not real uuids imo) | 20:22 |
| sdague | dansmith: so, in the glance code image_ref is allowed to be a full url | 20:22 |
| dansmith | sdague: orly | 20:22 |
| mriedem | dansmith: i wouldn't want to guess | 20:22 |
| sdague | in the nova glance code that I've been unwinding | 20:22 |
| sdague | when it can be that, is not super clear | 20:22 |
| sdague | but the code supports it | 20:22 |
| dansmith | sdague: okay thanks | 20:22 |
| dansmith | sdague: it's a varchar(255) in the database (like everything else), which is probably rather dangerous for a url | 20:23 |
| sdague | it might not be from the db | 20:23 |
| dansmith | right, I mean we could truncate it | 20:23 |
| dansmith | in the db | 20:23 |
| *** ociuhandu has joined #openstack-nova | 20:23 | |
| sdague | yeh, I can look more tomorrow, tc meeting now and then I have a hard stop | 20:23 |
| dansmith | sdague: migi is cleaning up our tests to remove all cases where we use "fake-uuid", etc for instance uuids, in advance of making the Instance object actually enforce that | 20:24 |
| mriedem | dansmith: also https://github.com/openstack/nova/blob/master/nova/cloudpipe/pipelib.py#L69 | 20:24 |
| openstackgerrit | Samuel Matzek proposed openstack/nova: glance: secure https when getting client version https://review.openstack.org/254944 | 20:24 |
| mriedem | used here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1621 | 20:24 |
| dansmith | mriedem: ah | 20:25 |
| dansmith | so probably either id or uuid | 20:25 |
| dansmith | because we hate ourselves and our users | 20:25 |
| mriedem | yeah man | 20:25 |
| mriedem | i suppress those feelings | 20:25 |
| *** mariusv has quit IRC | 20:26 | |
| sdague | dansmith: yeh, so we should be a little cautious there on the image_ref side | 20:26 |
| sdague | though, honestly, some code simplifies if we don't let it ever be a url | 20:26 |
| dansmith | sdague: well, for the moment it sounds like not assuming it's a uuid is the safe bet.. not really related to his cleanups anyway, | 20:27 |
| dansmith | since it's not a uuidfield on the instance | 20:27 |
| RichardRaseley | Can anyone provide some detail around the mechanism nova-consoleauth uses to validate tokens which are passed to it? | 20:27 |
| mriedem | jgriffith: http://logs.openstack.org/07/251407/2/check/gate-tempest-dsvm-full/144f7fc/logs/libvirt/qemu/instance-00000066.txt.gz | 20:27 |
| mriedem | does this mean anything to you? | 20:27 |
| mriedem | qemu-system-x86_64: /build/qemu-5LgLIn/qemu-2.0.0+dfsg/block.c:3491: bdrv_error_action: Assertion `error >= 0' failed. | 20:27 |
| *** lykinsbd has joined #openstack-nova | 20:27 | |
| mriedem | kashyap: ^ | 20:27 |
| *** rhagarty has quit IRC | 20:30 | |
| openstackgerrit | Dina Belova proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 20:30 |
| *** rhagarty has joined #openstack-nova | 20:30 | |
| migi | dansmith, replied to comment | 20:33 |
| dansmith | migi: I don't see it | 20:33 |
| *** otter768 has joined #openstack-nova | 20:35 | |
| *** apoorvad has quit IRC | 20:35 | |
| migi | dansmith, my comment is (draft) | 20:36 |
| migi | where the heck is save btn | 20:36 |
| dansmith | migi: you have to reply again at the main patch screen to commit it | 20:36 |
| dansmith | migi: i.e. vote again | 20:37 |
| migi | done | 20:37 |
| migi | pretty user friendly | 20:37 |
| dansmith | migi: ah, I see | 20:38 |
| migi | similar type for number of networking stuff | 20:38 |
| dansmith | migi: so danpb already made the assumption about the image uuid on ImageMeta | 20:38 |
| migi | and one field so far where uuid is None (which may be valid for some types) | 20:39 |
| *** mariusv_ has joined #openstack-nova | 20:39 | |
| migi | yes, but I am looking here for ideas if we want to fix it not only in tests | 20:39 |
| *** otter768 has quit IRC | 20:40 | |
| migi | or keep tests working and then if necessary change image to non-uuid | 20:40 |
| *** mariusv has joined #openstack-nova | 20:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Make sure bdm.volume_id is set after auto-creating volumes https://review.openstack.org/254428 | 20:41 |
| *** mariusv_ has quit IRC | 20:41 | |
| migi | dansmith, see http://paste.openstack.org/show/481231/ | 20:43 |
| *** ircuser-1 has joined #openstack-nova | 20:43 | |
| bauzas | mriedem: have you seen that ? https://jenkins03.openstack.org/job/gate-nova-python34/3088/console | 20:44 |
| *** markmc has joined #openstack-nova | 20:44 | |
| migi | I am just unsure if this won't brake nova (not only tests), cause as in the previous examle db may allow int rather then full uuids | 20:44 |
| bauzas | mriedem: "mox3.mox.UnexpectedMethodCallError: Unexpected method call function.__call__(<nova.virt.xenapi.client.session.XenAPISession object at 0x7fa86a6a4c18>, 'test', False) -> None"" | 20:44 |
| bauzas | nova.tests.unit.virt.xenapi.test_vmops.BootableTestCase.test_set_not_bootable | 20:45 |
| dansmith | migi: we treat instance uuids and ids different by query at the DB layer, so those tests are just wrong I think | 20:45 |
| dansmith | migi: so you're good to change I think | 20:45 |
| mriedem | bauzas: not specifically, but there is some race with mox and neutronv2.api unit tests in nova on py34 | 20:45 |
| vilobhmm11 | alaski : ping | 20:45 |
| migi | dansmith, ok | 20:45 |
| bauzas | mriedem: lemme see logstash | 20:45 |
| alaski | vilobhmm11: hi | 20:45 |
| *** xyang1 has joined #openstack-nova | 20:45 | |
| alaski | vilobhmm11: I'm commenting on the patch right now btw | 20:45 |
| vilobhmm11 | https://review.openstack.org/#/c/253306/ I still feel it should be a listofString or listofObjects | 20:45 |
| vilobhmm11 | alaski : ok :) | 20:46 |
| openstackgerrit | Chuck Carmack proposed openstack/nova: REST API changes for user settable server description https://review.openstack.org/254950 | 20:46 |
| vilobhmm11 | thanks! | 20:46 |
| *** haypo_ has joined #openstack-nova | 20:46 | |
| *** yarkot has quit IRC | 20:49 | |
| mriedem | i've re-opened this old qemu bug that's actually associated to fc20 | 20:49 |
| mriedem | https://bugzilla.redhat.com/show_bug.cgi?id=1147282 | 20:49 |
| openstack | bugzilla.redhat.com bug 1147282 in qemu "qemu vm guests hard shutdown unexpectedly" [Medium,New] - Assigned to virt-maint | 20:49 |
| mriedem | but it's a thing we hit upstream | 20:49 |
| mriedem | dansmith: kashyap: ^ not sure how that should be redirected | 20:50 |
| openstackgerrit | jichenjc proposed openstack/nova: Change some wording on server_concepts.rst https://review.openstack.org/248063 | 20:50 |
| mriedem | they had closed it b/c fc20 went EOL | 20:50 |
| mriedem | it showed up in a test_volume_boot_pattern ssh failure | 20:50 |
| openstackgerrit | Chuck Carmack proposed openstack/nova: REST API changes for user settable server description https://review.openstack.org/254950 | 20:52 |
| *** suro-patz has quit IRC | 20:53 | |
| *** suro-patz has joined #openstack-nova | 20:54 | |
| *** haypo_ has quit IRC | 20:54 | |
| migi | dansmith, as for the second question - do you really think we should go across all the files and change the appropriate fields for consistency - if yes this is something I was proposing yesterday, but it was said the change will be too massive, so focus only of getting 100% running | 20:55 |
| *** rook has quit IRC | 20:55 | |
| *** fawadkhaliq has quit IRC | 20:55 | |
| migi | I am fine doing any way | 20:55 |
| dansmith | migi: define "change the appropriate fields for consistency" more clearly | 20:56 |
| *** suro-patz has quit IRC | 20:56 | |
| *** suro-patz has joined #openstack-nova | 20:57 | |
| *** suro-patz has quit IRC | 20:57 | |
| dansmith | migi: I think it would be ideal if you can make the test changes you need to survive the o.vo change, without changing any fields on the actual objects | 20:57 |
| dansmith | migi: but I don't think you should change things you don't need to change | 20:57 |
| migi | not all of them, but just idea of how many (~50%) will require changes: | 20:58 |
| dansmith | migi: meaning, I don't think you should include the image_ref='fake-uuid' change since it's not necessary (and you didn't) | 20:58 |
| migi | # grep image_ref unit/compute/test_compute.py|wc -l | 20:58 |
| migi | 90 | 20:58 |
| *** ljxiash has joined #openstack-nova | 20:58 | |
| dansmith | right, but those are not needed right now, correct? | 20:58 |
| *** suro-patz has joined #openstack-nova | 20:58 | |
| migi | no, but you gave -1 with comment those should be changed as well | 20:59 |
| dansmith | well, no, | 20:59 |
| dansmith | I -1d because I thought that you were changing some and not others.. I was missing the difference between image_href passed to create and the image_ref property as set on the Instance object | 20:59 |
| migi | ok see it's +1 now :) | 20:59 |
| dansmith | I was conflating the two into the latter | 20:59 |
| migi | haven't seen that | 20:59 |
| migi | everything is fine then | 21:00 |
| dansmith | it's +2 actually | 21:00 |
| dansmith | but yeah :) | 21:00 |
| migi | cool | 21:00 |
| migi | thanks | 21:00 |
| dansmith | mriedem: kashyap is probably a good person to chase that down | 21:00 |
| *** thumpba has quit IRC | 21:02 | |
| *** ljxiash has quit IRC | 21:03 | |
| *** aginwala has quit IRC | 21:05 | |
| migi | away | 21:05 |
| *** rk4n has quit IRC | 21:08 | |
| *** Sukhdev has quit IRC | 21:08 | |
| bauzas | meh, the py34 job is bad for logstash... | 21:09 |
| *** aginwala has joined #openstack-nova | 21:09 | |
| sdague | dansmith: the gate fail rate for multinode is definitely falling, will know more in the morning what's still left on the fails | 21:09 |
| *** zenoway has joined #openstack-nova | 21:09 | |
| sdague | this python 34 unit test fail is problematic though - https://jenkins04.openstack.org/job/gate-nova-python34/3086/console | 21:11 |
| *** liverpooler has quit IRC | 21:11 | |
| dansmith | Cool | 21:12 |
| *** rfolco_ has joined #openstack-nova | 21:13 | |
| *** zenoway has quit IRC | 21:14 | |
| mriedem | bauzas: yeah, the py34 output is terrible for logstash | 21:15 |
| mriedem | sdague: the py34 failures on nova.tests.unit.network.test_neutronv2.TestNeutronv2.test_deallocate_for_instance_2* are known issues | 21:16 |
| bauzas | mriedem: just wonder how we could help that | 21:16 |
| mriedem | fix logging in py34? | 21:16 |
| bauzas | yup | 21:17 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1521599 | 21:17 |
| openstack | Launchpad bug 1521599 in OpenStack Compute (nova) "py34 unit tests fail randomly for network.test_neutronv2" [Medium,Confirmed] | 21:17 |
| mriedem | is the tracking bu | 21:17 |
| mriedem | *bug | 21:17 |
| *** zenoway has joined #openstack-nova | 21:18 | |
| sdague | mriedem: then where is the patch to put them in the blacklist? | 21:18 |
| sdague | because leaving known racing unit tests enabled is just not ok | 21:18 |
| mriedem | because it's not failing that often from what i can tell | 21:19 |
| *** rfolco_ has quit IRC | 21:19 | |
| *** burt has joined #openstack-nova | 21:19 | |
| *** ianbrown__ has quit IRC | 21:19 | |
| mriedem | the blacklist is more for 'these just don't work with py34' | 21:19 |
| mriedem | at least that was my understanding | 21:19 |
| sdague | racing unit tests aren't ok to keep enabled | 21:19 |
| *** rook has joined #openstack-nova | 21:20 | |
| bauzas | mriedem: IIUC, that's this builder which has a unicode problem https://github.com/openstack-infra/project-config/blob/552521848a4a856eb9bbdd2369fbf589e2a26bf4/jenkins/jobs/macros.yaml#L490 | 21:20 |
| *** claudiub has joined #openstack-nova | 21:20 | |
| bauzas | mriedem: tbc, probably that one https://github.com/openstack/nova/blob/master/tox.ini#L50 | 21:21 |
| mriedem | not following - to blacklist those tests? | 21:22 |
| mriedem | i know where to do that | 21:22 |
| mriedem | with a fail rate of 12 hits in 7 days, i didn't think it was high priority | 21:22 |
| sdague | mriedem: http://tinyurl.com/pmx7cel - note, gate-nova-python27 has 0% failure rate in the gate, and that's where we really need to keep it | 21:22 |
| *** ianbrown has joined #openstack-nova | 21:23 | |
| *** cdelatte has quit IRC | 21:23 | |
| bauzas | mriedem: no, was speaking of the bad logging output sorry | 21:23 |
| mriedem | bauzas: ok, so you think ostestr? | 21:23 |
| bauzas | mriedem: which creates a logstash problem | 21:23 |
| bauzas | mriedem: yeah | 21:23 |
| *** smatzek has quit IRC | 21:23 | |
| mriedem | bauzas: we actually have a query for that one in e-r https://review.openstack.org/#/c/251868/ | 21:23 |
| mriedem | but for some reason we don't have any hits | 21:23 |
| sdague | mriedem: yeh, I think we should blacklist them, because they just cause people to go recheck grind | 21:23 |
| mriedem | here http://status.openstack.org/elastic-recheck/index.html | 21:24 |
| sdague | and any additional gate fails are really bad at our current load and fail level | 21:24 |
| mriedem | but i do have hits here http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22Client.delete_port('my_portid1')%5C%22%20AND%20build_name:%5C%22gate-nova-python34%5C%22%20AND%20tags:%5C%22console%5C%22 | 21:24 |
| bauzas | well, since the ouput is busted, I'm not really trusting logstash | 21:24 |
| mriedem | sdague: we could make that argument for just skipping test_volume_boot_pattern | 21:24 |
| sdague | this seems like a good one to just blacklist given that no one is fixing it, so it can be looked at without chewing up all the resources | 21:24 |
| *** yarkot has joined #openstack-nova | 21:24 | |
| bauzas | because the output is only one line | 21:24 |
| sdague | unit tests should always pass | 21:24 |
| bauzas | for the whole output | 21:24 |
| bauzas | sdague: +1 | 21:24 |
| sdague | we control the whole system | 21:24 |
| sdague | I think the bar has to be higher there | 21:25 |
| mriedem | blurg, that's fine, whatevs, i can push that up | 21:25 |
| * mriedem kind of feels like he's being yelled at | 21:25 | |
| mriedem | btw, this should fix a gate failure https://review.openstack.org/#/c/254428/ | 21:25 |
| mriedem | it's actually 3-4 LOC for the fix | 21:26 |
| mriedem | also i have a revert for gmr stuff here https://review.openstack.org/#/c/253821/ | 21:26 |
| mriedem | that we should probably get on | 21:26 |
| *** ianbrown has quit IRC | 21:27 | |
| *** ianbrown has joined #openstack-nova | 21:28 | |
| *** dane-fichter has quit IRC | 21:28 | |
| *** doug-fis_ has joined #openstack-nova | 21:30 | |
| *** earlephilhower has quit IRC | 21:30 | |
| *** dims has joined #openstack-nova | 21:31 | |
| *** doug-fish has quit IRC | 21:32 | |
| *** vishwanathj has joined #openstack-nova | 21:32 | |
| dansmith | sdague: it'd be kinda scary if sending 50% of the requests down the pipe to the wrong compute host _didn't_ make a big impact on the fails :) | 21:32 |
| mriedem | mtreinish: the ostestr blacklist takes test ids down to the test case, right? | 21:33 |
| *** aginwala has quit IRC | 21:33 | |
| *** ianbrown_ has joined #openstack-nova | 21:33 | |
| *** ianbrown has quit IRC | 21:34 | |
| *** lbelivea has joined #openstack-nova | 21:34 | |
| *** apoorvad has joined #openstack-nova | 21:34 | |
| *** lbelivea has quit IRC | 21:35 | |
| *** lbeliveau has joined #openstack-nova | 21:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/253901 | 21:35 |
| *** xymind has joined #openstack-nova | 21:35 | |
| *** lbeliveau has quit IRC | 21:36 | |
| *** lbeliveau has joined #openstack-nova | 21:36 | |
| *** ianbrown has joined #openstack-nova | 21:41 | |
| *** Marga_ has quit IRC | 21:45 | |
| mtreinish | mriedem: it's a regex match, it just constructs an exclude regex like what people were doing manually | 21:46 |
| *** ljxiash has joined #openstack-nova | 21:47 | |
| mtreinish | mriedem: https://github.com/openstack/os-testr/blob/master/os_testr/os_testr.py#L136 | 21:47 |
| *** cdelatte has joined #openstack-nova | 21:49 | |
| *** lpetrut has quit IRC | 21:50 | |
| *** salv-orlando has joined #openstack-nova | 21:50 | |
| *** ljxiash has quit IRC | 21:51 | |
| *** salv-orlando has quit IRC | 21:55 | |
| sneti | hi..can anyone suggest me how to run tests on python3.4. I get the below error: | 21:56 |
| sneti | InvocationError: '/opt/stack/nova/.tox/py34/bin/ostestr --blacklist_file tests-py3.txt' | 21:56 |
| sneti | ERROR: py34: commands failed | 21:56 |
| mriedem | sneti: tox -r -e py34 | 21:56 |
| mriedem | as for why they fail, that would require more details | 21:57 |
| *** rk4n has joined #openstack-nova | 21:58 | |
| sneti | mriedem: thank you. But I still get the same error with tox -r -e py34 | 21:59 |
| thomasem | So, trying unit tests on a 40 core box | 21:59 |
| *** dims has quit IRC | 21:59 | |
| thomasem | keep seeing the API tests seeming to step on eachother since another test is running attached to 0.0.0.0:8774 | 21:59 |
| mtreinish | sneti: can you paste the full traceback on paste.openstack.org | 21:59 |
| sneti | sure | 21:59 |
| *** suro-patz has quit IRC | 22:01 | |
| thomasem | lets try this with concurrency=2 | 22:03 |
| *** suro-patz has joined #openstack-nova | 22:04 | |
| sneti | mriedem: http://paste.openstack.org/show/481238/ | 22:05 |
| *** salv-orlando has joined #openstack-nova | 22:05 | |
| *** rk4n has quit IRC | 22:05 | |
| *** gokrokve has joined #openstack-nova | 22:05 | |
| *** rk4n has joined #openstack-nova | 22:06 | |
| *** rk4n has quit IRC | 22:06 | |
| *** jogo has quit IRC | 22:07 | |
| *** gokrokve has quit IRC | 22:07 | |
| *** gokrokve has joined #openstack-nova | 22:07 | |
| *** Marga_ has joined #openstack-nova | 22:08 | |
| *** vilobhmm11 has quit IRC | 22:10 | |
| *** david-ly_ has joined #openstack-nova | 22:10 | |
| *** vilobhmm11 has joined #openstack-nova | 22:10 | |
| mtreinish | sneti: you ran python2 testr first: https://bugs.launchpad.net/testrepository/+bug/1212909 | 22:10 |
| openstack | Launchpad bug 1212909 in Testrepository "times.dbm incompatible based on Python version it was created with" [Critical,Triaged] | 22:10 |
| *** pratikma_ has joined #openstack-nova | 22:10 | |
| mtreinish | sneti: you can wipe out your .testrepository directory and then re-run the tests | 22:10 |
| mtreinish | it'll make a new times.dbm file and it should work fine | 22:11 |
| *** lykinsbd has quit IRC | 22:11 | |
| *** rk4n has joined #openstack-nova | 22:11 | |
| mtreinish | sneti: if you run py34 tests first it creates a dbm file in a format that works on py2 and py3 | 22:11 |
| mtreinish | but a py2 created one doesn't work on py3... :( | 22:12 |
| *** jogo has joined #openstack-nova | 22:12 | |
| sneti | mtreinish, thank you! will try that | 22:12 |
| *** david-lyle has quit IRC | 22:13 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: neutron: skip test_deallocate_for_instance_2* in py34 job https://review.openstack.org/254979 | 22:13 |
| mriedem | sdague: bauzas: ^ | 22:13 |
| *** david-ly_ is now known as david-lyle | 22:13 | |
| *** gonzalo2kx has joined #openstack-nova | 22:13 | |
| *** pratikmallya has quit IRC | 22:14 | |
| *** jichen has quit IRC | 22:14 | |
| *** pratikma_ has quit IRC | 22:15 | |
| *** belmoreira has joined #openstack-nova | 22:19 | |
| *** inc0 has quit IRC | 22:20 | |
| *** BadCub has left #openstack-nova | 22:20 | |
| *** ndipanov has quit IRC | 22:21 | |
| belmoreira | bauzas: still here? | 22:22 |
| belmoreira | I have some questions regarding the scheduler host_manager and a very weird behaviour | 22:22 |
| *** ccarmack has quit IRC | 22:23 | |
| belmoreira | when the scheduler starts it calls: _async_init_instance_info() | 22:23 |
| belmoreira | this includes all deleted instances! Why they are needed? | 22:24 |
| sdague | mriedem: thanks for that | 22:24 |
| belmoreira | in a cell with >200 nodes I have per node >6000 instances (deleted) registered in the DB | 22:26 |
| *** e0ne has quit IRC | 22:26 | |
| *** dustins is now known as dustins|gone | 22:27 | |
| belmoreira | the scheduler is loading all this info when it starts (several GBs), breaking at some point | 22:27 |
| *** gonzalo2kx has quit IRC | 22:28 | |
| *** mgoddard has quit IRC | 22:29 | |
| edleafe | belmoreira: not sure why it's loading deleted instances | 22:30 |
| *** changbl has quit IRC | 22:31 | |
| belmoreira | edleafe: I don't see why... | 22:32 |
| edleafe | belmoreira: it's just using the InstanceList.get_by_filters(), and I don't see anything about read_deleted=True | 22:32 |
| *** thorst has quit IRC | 22:33 | |
| belmoreira | edleafe: it uses: instance_get_all_by_filters_sort | 22:33 |
| *** rk4n has quit IRC | 22:33 | |
| openstackgerrit | Sean Dague proposed openstack/nova: convert GlanceClientWrapper to endpoint https://review.openstack.org/254828 | 22:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: retool xen glance plugin to work with urls https://review.openstack.org/254331 | 22:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: drop _create_glance_client function https://review.openstack.org/254827 | 22:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: Implement GlanceEndpoint object https://review.openstack.org/254214 | 22:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: Clean up glance url handling https://review.openstack.org/254213 | 22:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: always create clients with GlanceEndpoint https://review.openstack.org/254306 | 22:33 |
| openstackgerrit | Sean Dague proposed openstack/nova: Add upload/download vhd2 interfaces https://review.openstack.org/254785 | 22:33 |
| belmoreira | and "Deleted instances will be returned by default, unless there's a filter that says otherwise" | 22:33 |
| edleafe | belmoreira: ugh | 22:34 |
| belmoreira | edleafe: I just tested adding the filter: "deleted": False | 22:35 |
| *** smurke has quit IRC | 22:35 | |
| belmoreira | in _async_init_instance_info() | 22:35 |
| *** pumaranikar has quit IRC | 22:35 | |
| *** otter768 has joined #openstack-nova | 22:35 | |
| belmoreira | and it didn't query deleted instances... However not sure about the consequences for the scheduler | 22:36 |
| edleafe | belmoreira: should deleted instances affect affinity decisions? | 22:36 |
| *** thorst has joined #openstack-nova | 22:37 | |
| *** _ducttape_ has quit IRC | 22:38 | |
| *** rk4n has joined #openstack-nova | 22:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add a note about fixing "db type could not be determined" with py34 https://review.openstack.org/254989 | 22:38 |
| belmoreira | edleafe: previous scheduling decisions (on deleted instances) should not influence new ones. At least I'm not seeing any use case | 22:39 |
| *** yarkot has quit IRC | 22:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add a note about fixing "db type could not be determined" with py34 https://review.openstack.org/254989 | 22:39 |
| mriedem | mtreinish: ^ you're my inspiration | 22:39 |
| *** gokrokve has quit IRC | 22:39 | |
| vilobhmm11 | alaski : https://blueprints.launchpad.net/nova/+spec/flavor-classes-unifying-flavors | 22:40 |
| mtreinish | mriedem: heh, ok | 22:40 |
| edleafe | belmoreira: the only one I can think of is if there was an anti-affinity decison that placed the new instance on a host with a deleted instance, and then that instance is undeleted | 22:40 |
| *** otter768 has quit IRC | 22:40 | |
| *** thorst has quit IRC | 22:41 | |
| *** rlrossit has quit IRC | 22:42 | |
| *** aginwala has joined #openstack-nova | 22:42 | |
| edleafe | belmoreira: can you enter a bug for this and assign it to me? | 22:42 |
| edleafe | belmoreira: I have to run to pick up the kid, but I'll discuss with bauzas tomorrow. | 22:42 |
| *** pratikmallya has joined #openstack-nova | 22:43 | |
| belmoreira | yes, I'm filling the bug | 22:43 |
| *** zenoway has quit IRC | 22:43 | |
| belmoreira | edleafe: ping me as well | 22:44 |
| openstackgerrit | Cale Rath proposed openstack/nova: Purge soft-deleted instances cmd https://review.openstack.org/203751 | 22:45 |
| *** gokrokve has joined #openstack-nova | 22:49 | |
| *** gokrokve has quit IRC | 22:50 | |
| *** sneti has quit IRC | 22:52 | |
| *** gokrokve has joined #openstack-nova | 22:53 | |
| *** ctrath has quit IRC | 22:53 | |
| *** zenoway has joined #openstack-nova | 22:53 | |
| *** salv-orlando has quit IRC | 22:53 | |
| *** salv-orlando has joined #openstack-nova | 22:54 | |
| *** ianbrown_ has quit IRC | 22:55 | |
| *** gokrokve_ has joined #openstack-nova | 22:55 | |
| *** gokrokve has quit IRC | 22:56 | |
| *** eharney has quit IRC | 22:56 | |
| *** cp16net has quit IRC | 22:56 | |
| *** samueldmq has quit IRC | 22:56 | |
| *** ianbrown_ has joined #openstack-nova | 22:57 | |
| *** devananda has quit IRC | 22:57 | |
| *** hblixt has quit IRC | 22:58 | |
| openstackgerrit | Sean Dague proposed openstack/nova: convert GlanceClientWrapper to endpoint https://review.openstack.org/254828 | 22:58 |
| openstackgerrit | Sean Dague proposed openstack/nova: retool xen glance plugin to work with urls https://review.openstack.org/254331 | 22:58 |
| openstackgerrit | Sean Dague proposed openstack/nova: drop _create_glance_client function https://review.openstack.org/254827 | 22:58 |
| openstackgerrit | Sean Dague proposed openstack/nova: Implement GlanceEndpoint object https://review.openstack.org/254214 | 22:58 |
| openstackgerrit | Sean Dague proposed openstack/nova: Clean up glance url handling https://review.openstack.org/254213 | 22:58 |
| openstackgerrit | Sean Dague proposed openstack/nova: always create clients with GlanceEndpoint https://review.openstack.org/254306 | 22:58 |
| openstackgerrit | Sean Dague proposed openstack/nova: Add upload/download vhd2 interfaces https://review.openstack.org/254785 | 22:58 |
| *** burgerk has quit IRC | 22:58 | |
| *** ctrath has joined #openstack-nova | 22:59 | |
| *** suro-patz has quit IRC | 23:00 | |
| *** apoorvad has quit IRC | 23:02 | |
| *** rook has quit IRC | 23:02 | |
| *** thorst has joined #openstack-nova | 23:02 | |
| *** ianbrown has quit IRC | 23:02 | |
| *** gokrokve_ has quit IRC | 23:03 | |
| mriedem | man, sdague burning the early evening oil | 23:04 |
| sdague | yeh, well, some of those patches need xenserver to run on them, so I wanted to post them before leaving the terminal for the day | 23:04 |
| sdague | mriedem: an unrelated and hopefully not too yucky one I'd like in to unblock some clarifying patches in api_samples - https://review.openstack.org/#/c/254909/ | 23:05 |
| sdague | which I've got in a branch locally and will push tomorrow | 23:05 |
| mriedem | "This is terrible." | 23:06 |
| mriedem | i don't think i can grok that one tonight, have to leave soon | 23:07 |
| *** thorst has quit IRC | 23:07 | |
| *** xyang1 has quit IRC | 23:08 | |
| *** mriedem is now known as mriedem_away | 23:09 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Fix config option types https://review.openstack.org/168481 | 23:13 |
| *** mkoderer has quit IRC | 23:15 | |
| *** stackdump has joined #openstack-nova | 23:15 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Fix config option types https://review.openstack.org/168481 | 23:15 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Allow virt driver to define binding:host_id https://review.openstack.org/194413 | 23:16 |
| *** mkoderer has joined #openstack-nova | 23:17 | |
| *** baoli has quit IRC | 23:18 | |
| *** edmondsw has quit IRC | 23:21 | |
| *** mdrabe has quit IRC | 23:23 | |
| *** ijuwang has quit IRC | 23:24 | |
| *** rook has joined #openstack-nova | 23:28 | |
| *** burgerk has joined #openstack-nova | 23:29 | |
| *** suro-patz has joined #openstack-nova | 23:31 | |
| *** baoli has joined #openstack-nova | 23:32 | |
| *** pradk has quit IRC | 23:35 | |
| *** baoli has quit IRC | 23:35 | |
| *** hblixt has joined #openstack-nova | 23:35 | |
| *** Sukhdev has joined #openstack-nova | 23:35 | |
| *** baoli has joined #openstack-nova | 23:36 | |
| *** burt has quit IRC | 23:36 | |
| *** alex_xu has quit IRC | 23:36 | |
| *** aginwala has quit IRC | 23:37 | |
| *** Daisy has joined #openstack-nova | 23:41 | |
| *** alex_xu has joined #openstack-nova | 23:41 | |
| *** Daisy has quit IRC | 23:41 | |
| *** Daisy has joined #openstack-nova | 23:42 | |
| *** pece has quit IRC | 23:44 | |
| notmorgan | brought this up in -infra but for XenProject CI check on change https://review.openstack.org/#/c/253792/ a "failed" run produces no logs | 23:44 |
| notmorgan | BobBall: ^ cc | 23:44 |
| notmorgan | sdague: mriedem_away ^ cc as well | 23:44 |
| notmorgan | i am getting a 404 instead of something useful. | 23:45 |
| notmorgan | sdague:, mriedem_away, mordred: for what it's worth https://review.openstack.org/#/c/253792/ is really just in transient (unrelated) error states now afaict. | 23:45 |
| notmorgan | everything is looking good. | 23:45 |
| notmorgan | BobBall: sorry didn't mean to ping you, was mis-informed who ran the xen one. | 23:46 |
| *** mrkz has quit IRC | 23:48 | |
| *** Yingxin_ has joined #openstack-nova | 23:53 | |
| *** baoli has quit IRC | 23:54 | |
| *** jerrygb has quit IRC | 23:55 | |
| *** aginwala has joined #openstack-nova | 23:55 | |
| *** jerrygb has joined #openstack-nova | 23:56 | |
| *** burgerk has quit IRC | 23:56 | |
| openstackgerrit | Tracy Jones proposed openstack/nova: config options: centralize section "guestfs" https://review.openstack.org/248963 | 23:56 |
| *** Daisy has quit IRC | 23:56 | |
| *** Yingxin has quit IRC | 23:56 | |
| *** Yingxin_ is now known as Yingxin | 23:56 | |
| *** takedakn has joined #openstack-nova | 23:56 | |
| *** Daisy has joined #openstack-nova | 23:57 | |
| *** andrewbogott has joined #openstack-nova | 23:57 | |
| *** smoriya has joined #openstack-nova | 23:57 | |
| *** andrewbogott has quit IRC | 23:58 | |
| *** andrewbogott has joined #openstack-nova | 23:58 | |
| *** zenoway has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
