| *** shaohe_feng has quit IRC | 02:02 | |
| *** shaohe_feng has joined #openstack-nimble | 02:02 | |
| *** Kevin_Zheng has joined #openstack-nimble | 02:44 | |
| *** Kevin_Zheng has quit IRC | 05:26 | |
| *** lei-zh has joined #openstack-nimble | 06:07 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Set instance info before do validate check https://review.openstack.org/387190 | 06:52 |
|---|---|---|
| openstackgerrit | Merged openstack/nimble: Set instance info before do validate check https://review.openstack.org/387190 | 06:59 |
| shaohe_feng | zhenguo: hi | 07:26 |
| shaohe_feng | zhenguo: I have check the ironic-client code and nimble code for API version | 07:27 |
| shaohe_feng | zhenguo: in nimble code, we set a hard code IRONIC_API_VERSION = (1, 21) | 07:27 |
| shaohe_feng | zhenguo: then nimbe set kwargs['os_ironic_api_version'] from IRONIC_API_VERSION | 07:29 |
| shaohe_feng | zhenguo: kwargs['os_ironic_api_version'] = '%d.%d' % IRONIC_API_VERSION | 07:29 |
| shaohe_feng | zhenguo: This os_ironic_api_version will pass to ironic | 07:29 |
| shaohe_feng | zhenguo: I suggest to set IRONIC_API_VERSION as configable. | 07:30 |
| shaohe_feng | zhenguo: the default version is the latest version. | 07:31 |
| zhenguo | shaohe_feng: that's copied from Nova | 07:32 |
| shaohe_feng | zhenguo: so, if the ironic upgrade to v1.22, what should nova do? | 07:32 |
| zhenguo | shaohe_feng: and seems it updated as long as ironic updated | 07:33 |
| shaohe_feng | zhenguo: does nova need to chage the hard code IRONIC_API_VERSION = (1, 22) ? | 07:33 |
| zhenguo | shaohe_feng: let me check | 07:33 |
| shaohe_feng | zhenguo: then ironic upgrade to v1.23? then chage the hard code IRONIC_API_VERSION = (1, 23) ? | 07:33 |
| shaohe_feng | zhenguo: OK. | 07:33 |
| *** openstackgerrit has quit IRC | 07:34 | |
| *** openstackgerrit has joined #openstack-nimble | 07:35 | |
| shaohe_feng | zhenguo: you can run this command: $ git whatchanged -p nova/virt/ironic/client_wrapper.py | 07:36 |
| shaohe_feng | zhenguo: in nova. | 07:36 |
| shaohe_feng | zhenguo: and then search IRONIC_API_VERSION | 07:37 |
| shaohe_feng | zhenguo: you can find nova really change IRONIC_API_VERSION by manually | 07:37 |
| zhenguo | shaohe_feng: yes indeed | 07:38 |
| zhenguo | shaohe_feng: but seems only update when it is required | 07:38 |
| shaohe_feng | zhenguo: nova first support 1.8, then bump to 1.20, then bump 1.21 | 07:38 |
| zhenguo | shaohe_feng: yes, if no new functionalities get in, they won't upgrade it | 07:39 |
| shaohe_feng | zhenguo: so how about user want to use the version between v1.9-v.19？ | 07:40 |
| zhenguo | shaohe_feng: seems it can't be used. | 07:41 |
| zhenguo | shaohe_feng: I think nova bump to 1.20 as it needs some functionalities only 1.20 supported | 07:41 |
| zhenguo | shaohe_feng: so old version may break Nova, | 07:41 |
| zhenguo | shaohe_feng: for example ironic add portgroup API support in 1.xx and Nova change to uses it, then old version will not work. | 07:43 |
| shaohe_feng | zhenguo: yes. | 07:44 |
| zhenguo | shaohe_feng: so I think it's ok to just follow Nova's way | 07:45 |
| zhenguo | shaohe_feng: make it configurable will bring new problems in | 07:45 |
| shaohe_feng | zhenguo: but that nova's problem. | 07:45 |
| shaohe_feng | zhenguo: I just wonder why not set the api_version in configurable, and give a sugesstion version to user. | 07:47 |
| zhenguo | shaohe_feng: I don't see any value to give the API version option to users | 07:47 |
| zhenguo | shaohe_feng: I think they should never care about this. | 07:48 |
| shaohe_feng | zhenguo: if the developer has test higher ironic api can works well, the developer can manually change it in configue file. | 07:48 |
| shaohe_feng | zhenguo: no, you should know, every code may be has bug. | 07:48 |
| shaohe_feng | zhenguo: for example, nov nova support v1.21 | 07:49 |
| shaohe_feng | zhenguo: if some bugs user test in v1.21 | 07:49 |
| shaohe_feng | zhenguo: in their enviroment | 07:50 |
| shaohe_feng | zhenguo: how does they do? | 07:50 |
| shaohe_feng | zhenguo: 1. maybe they add patch for this v1.21 | 07:50 |
| shaohe_feng | zhenguo: maybe they can downgrade to v1.8 | 07:51 |
| shaohe_feng | zhenguo: but that means other features that nova support, they can not used. | 07:51 |
| shaohe_feng | druing 1.9-1.19 | 07:52 |
| shaohe_feng | for users do not care the functionalities that ironic supports, such as your example portgroup API support in 1.xx. | 07:53 |
| zhenguo | shaohe_feng: that's would break nova I mean. | 07:54 |
| zhenguo | shaohe_feng: Nova already call portgroup API in ironic driver | 07:54 |
| shaohe_feng | I know, you just give me one of the reason, why nova use hardcode. | 07:55 |
| zhenguo | shaohe_feng: no better way I think | 07:55 |
| shaohe_feng | zhenguo: but this is just a guess. We do not know the really reason why hardcode. | 07:56 |
| zhenguo | shaohe_feng: configurable client version seems not used in any project, like Horizon uses all client but it's not configurable. | 07:57 |
| zhenguo | shaohe_feng: and client is already in the requirement file. | 07:58 |
| shaohe_feng | zhenguo: do you means python-ironicclient>=1.6.0? | 07:59 |
| zhenguo | shaohe_feng: No, it has been removed from requirement | 08:00 |
| zhenguo | shaohe_feng: Ironicclient is anot a dependecy for Nova | 08:01 |
| shaohe_feng | zhenguo: OK. we can hardcode it. if no ironic configure, nimble can use hardcode. if ironic_version in configure, then use this one. | 08:06 |
| zhenguo | shaohe_feng: yes, the hardcode should be the base requirement, lower version will not be supported. | 08:07 |
| zhenguo | shaohe_feng: we can upgrade it if new fuctionalities introduced from higher version, but it should never be downgraded. | 08:08 |
| zhenguo | shaohe_feng: as if there are problems with the current hardcode version, a new higher version will address it, and then we will upgrade to the new version. | 08:10 |
| *** yuntongjin has joined #openstack-nimble | 09:07 | |
| *** yuntongjin has quit IRC | 09:59 | |
| openstackgerrit | Lei Zhang proposed openstack/nimble: Add instance list and detail api https://review.openstack.org/377418 | 11:21 |
| openstackgerrit | Merged openstack/nimble: Updated from global requirements https://review.openstack.org/387143 | 11:40 |
| *** lei-zh has quit IRC | 12:03 | |
| *** shihanzhang has quit IRC | 14:27 | |
| *** shihanzhang has joined #openstack-nimble | 14:28 | |
| *** shz has joined #openstack-nimble | 14:35 | |
| *** shihanzhang has quit IRC | 14:36 | |
| openstackgerrit | Merged openstack/nimble: Add api-ref for instance power state https://review.openstack.org/380734 | 16:03 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Following up patch of I85a1d177754c29fe331df5f6119ade1ac64f2939 https://review.openstack.org/387554 | 16:20 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add missed ValidationError exception https://review.openstack.org/387555 | 16:23 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add missed ValidationError exception https://review.openstack.org/387555 | 16:48 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Following up patch of I85a1d177754c29fe331df5f6119ade1ac64f2939 https://review.openstack.org/387554 | 16:50 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Fix changing instance power state exception https://review.openstack.org/387565 | 16:56 |
| openstackgerrit | Merged openstack/nimble: Add missed ValidationError exception https://review.openstack.org/387555 | 17:00 |
| openstackgerrit | Merged openstack/nimble: Following up patch of I85a1d177754c29fe331df5f6119ade1ac64f2939 https://review.openstack.org/387554 | 17:02 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Fix changing instance power state exception https://review.openstack.org/387565 | 17:03 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Fix msg format err when raising InvalidActionParameterValue https://review.openstack.org/387571 | 17:06 |
| openstackgerrit | Merged openstack/nimble: Fix changing instance power state exception https://review.openstack.org/387565 | 17:34 |
| openstackgerrit | Merged openstack/nimble: Fix msg format err when raising InvalidActionParameterValue https://review.openstack.org/387571 | 17:34 |
| openstackgerrit | Merged openstack/nimble: Add instance list and detail api https://review.openstack.org/377418 | 17:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!