| sairam | hi | 05:31 |
|---|---|---|
| pdeore | #startmeeting glance | 13:59 |
| opendevmeet | Meeting started Thu Jul 20 13:59:23 2023 UTC and is due to finish in 60 minutes. The chair is pdeore. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:59 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:59 |
| opendevmeet | The meeting name has been set to 'glance' | 13:59 |
| pdeore | #topic roll call | 13:59 |
| pdeore | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 13:59 |
| pdeore | o/ | 13:59 |
| mrjoshi | o/ | 13:59 |
| pdeore | abhishek is not going to attend due to some emergency | 14:00 |
| pdeore | let's wait for others to join | 14:00 |
| croelandt | o/ | 14:01 |
| pdeore | let's start | 14:01 |
| pdeore | #topic release/periodic jobs updates | 14:01 |
| pdeore | we have tagged m2 last week, it was got delayed due to random gate failures but finally we could do it as decided.. | 14:02 |
| pdeore | M3 is 6 weeks from now | 14:02 |
| pdeore | and our targets for m3 would be new location apis, sorting locations based on store weight & having missing cli support for all image & metadef apis in OSC | 14:02 |
| pdeore | patches are up for review for all these ^ which we are going to see in next topics | 14:03 |
| pdeore | Periodic jobs are all green except intermittent TIME_OUTs on fips jobs | 14:03 |
| pdeore | moving to next | 14:03 |
| pdeore | #topic Important Reviews | 14:03 |
| pdeore | As said earlier, we have some important patches up for review, | 14:04 |
| pdeore | but there are some random CI failures for almost all of these patches | 14:04 |
| pdeore | mostly some cinder related different tempest tests are failing & time outs, not sure how to handle this :/ | 14:04 |
| croelandt | The good way to do this would be to understand why CIs are always failing with issues unrelated to the patches themselves | 14:05 |
| croelandt | but it's hard work, it takes time, and has no direct business value | 14:05 |
| dansmith | sorry, I'm here | 14:05 |
| pdeore | yeah | 14:05 |
| dansmith | fixing CI has no direct business value? | 14:06 |
| dansmith | as someone who spends a lot of time fixing CI, that attitude irks me :( | 14:06 |
| croelandt | well it has value | 14:06 |
| croelandt | it would help us merge patches faster | 14:06 |
| croelandt | test features etc. | 14:06 |
| dansmith | and the tests aren't usually the buggy thing, FWIW | 14:06 |
| croelandt | but I think if we were to go to all our companies and say "hey, could we invest $$$ to not recheck all the time hoping for the best" | 14:06 |
| croelandt | they would not be happy | 14:06 |
| croelandt | but I might be mistaken! | 14:07 |
| croelandt | (I hope so) | 14:07 |
| dansmith | we don't fix CI to avoid having to recheck, we should be fixing it to either fix the actual product, or fix our ability to show that the product works instead of letting the customers tell us if it doesn't | 14:07 |
| croelandt | yes | 14:08 |
| croelandt | but as a dev, I feel a bit powerless when trying to merge a patch | 14:08 |
| croelandt | I feel like it's timing out and... not much I can do about it, so I'll click the button | 14:08 |
| dansmith | you are power*ful*.. go figure out why it's failing, try to fix it.. you'll learn more about the components involved in the process | 14:08 |
| croelandt | well, when it's randomly timing out, it's quite a tough process to even know whether you fixed it | 14:10 |
| dansmith | anyway, we should move on | 14:10 |
| pdeore | but these time outs are also for different jobs everytime :/ | 14:10 |
| pdeore | :) | 14:10 |
| dansmith | pdeore: which shows that they're all related | 14:10 |
| dansmith | pdeore: yesterday your location patch was failing for reasons related to your code | 14:10 |
| dansmith | looks like you've updated it? | 14:10 |
| pdeore | yeah i have updated it | 14:10 |
| croelandt | dansmith: now I'm gonna end up bothering you next time there is a failure so you can walk me through your debugging process :) | 14:11 |
| dansmith | croelandt: as long as you're putting forth a real effort and not asking me for an answer, that's fine.. there are lots of people to lean on in that regard | 14:11 |
| croelandt | good, maybe I'm not that powerless after all \o/ | 14:12 |
| croelandt | but anyway, I was not implying it's useless to work on the CI | 14:12 |
| croelandt | just to be clear | 14:12 |
| dansmith | you pretty much said that exactly | 14:12 |
| dansmith | let's move on and I can continue being annoyed after the meeting in -glance | 14:12 |
| croelandt | ok so it did not come across properly, sorry about that | 14:12 |
| pdeore | :D | 14:13 |
| croelandt | pdeore: you have the floor :) | 14:13 |
| pdeore | ok, so as per the discussion, I have separated out new location api changes in multiple patches and updated as per the suggestions on implemtation part, | 14:13 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/886749/8 - Location Import task flow | 14:13 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/881940/22 - Add Location API core changes | 14:13 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/886947/2 - Fucntional tests for new Add location api | 14:13 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/882498/14 - New Get location API | 14:13 |
| pdeore | I will submit the documentation + api-reference & version bump patches by tomorrow EOD or Monday | 14:14 |
| pdeore | moving to next | 14:15 |
| pdeore | #topic OSC & SDK side reviews (mrjoshi) | 14:15 |
| pdeore | mrjoshi wants to highlight some OSC & sdk patches which needs attention | 14:15 |
| pdeore | mrjoshi, ^ | 14:15 |
| mrjoshi | There are few patches on the openstack SDK and Openstackclient which needs review | 14:16 |
| mrjoshi | #link https://review.opendev.org/c/openstack/python-openstackclient/+/878631 - Add cache commands | 14:17 |
| mrjoshi | #link https://review.opendev.org/c/openstack/openstacksdk/+/881939 - Adding Support for image upload | 14:17 |
| mrjoshi | #link https://review.opendev.org/c/openstack/python-openstackclient/+/882086 - Adding ``image delete --store`` and ``image import info`` commands | 14:17 |
| pdeore | mrjoshi, there are some metadef api related patches as well, right? | 14:18 |
| mrjoshi | croelandt, you have a comment regarding raising exception on https://review.opendev.org/c/openstack/python-openstackclient/+/882086 ? | 14:19 |
| croelandt | hm | 14:20 |
| croelandt | yes, I was wondering if that was the only way of doing this | 14:20 |
| croelandt | because error messages can change in the future | 14:21 |
| croelandt | and this might end up breaking | 14:21 |
| croelandt | can't we check whether multi store is enabled some other way? | 14:21 |
| mrjoshi | pdeore, yes #link https://review.opendev.org/c/openstack/openstacksdk/+/858350 , this patch has some review comments on which I'm working and will upload the updated patch by tomorrow | 14:22 |
| pdeore | mrjoshi, ok | 14:22 |
| mrjoshi | croelandt, I'll look into it if there's any other way | 14:24 |
| croelandt | maybe ask Stephen about that | 14:25 |
| mrjoshi | but afaik that's how they are doing it in osc , but I'll still confirm it once again | 14:25 |
| mrjoshi | ack | 14:25 |
| pdeore | mrjoshi, cool, anything else you want to highlight ? | 14:26 |
| pdeore | shall we move to open discussions ? | 14:27 |
| mrjoshi | yes, there is one question, do we need the output format similar to glanceclient for all the commands | 14:28 |
| croelandt | I think it should mostly be consistent with other OSC commands | 14:29 |
| pdeore | not sure but I think according to osc rules we have to showcase | 14:29 |
| croelandt | is there a particular example you had in mind? | 14:29 |
| mrjoshi | yes | 14:29 |
| mrjoshi | https://review.opendev.org/c/openstack/python-openstackclient/+/883494 | 14:30 |
| mrjoshi | So the output for stores-info in osc is displayed in a list-format | 14:30 |
| croelandt | yeah I think Stephen is right | 14:31 |
| croelandt | we should aim for consistency inside OSC | 14:31 |
| croelandt | not between OSC and glanceclient | 14:31 |
| mrjoshi | ok | 14:31 |
| pdeore | +1 | 14:31 |
| croelandt | OSC is not going to be a drop-in replacement for glanceclient | 14:31 |
| croelandt | well, for interactive use, it will be | 14:31 |
| croelandt | but for scripting, no, basically | 14:31 |
| mrjoshi | ok | 14:33 |
| pdeore | ok, moving ahead | 14:34 |
| pdeore | #topic Open Discussions | 14:34 |
| dansmith | pdeore: can you explain why the changes you made to your second patch affected the tempest run? | 14:35 |
| dansmith | AFAICT, nothing should be plumbed through the external API until the last patch, | 14:35 |
| dansmith | yet tempest tests were failing and you made some changes so that they didnt | 14:35 |
| pdeore | dansmith, honestly I also not sure | 14:36 |
| dansmith | ... seriously? | 14:36 |
| dansmith | because I'm thinking if any of your code is actually being called in the current flow, | 14:36 |
| dansmith | but is starting a task or something, then any of your new timeouts or new behavior could potentially be related to this code | 14:37 |
| dansmith | so how do you justify the changes you made? Looks like you removed something from the response body and maybe added or changed a result code to 202? | 14:37 |
| dansmith | potentially the latter might make a client library stop (or start) waiting for something I guess, but that could certainly affect the overall thing | 14:38 |
| pdeore | yeah earlier as decided i was returning the updated location url & the validation data since the update location operation was sync but after moving to async, we can not return the same, hence 202 | 14:40 |
| dansmith | right, but nothing should be calling this code yet, other than unit/functional tests, so I don't see how those changes would have fixed the failures we saw before | 14:40 |
| pdeore | dansmith, need to verify it again, may be earlier failure was not related to my changes | 14:42 |
| dansmith | kinda hard to imagine they weren't related since they all seemed to involve image ops, but... okay | 14:43 |
| dansmith | ... BasicOperationsImagesTest | 14:43 |
| pdeore | will check it again .. | 14:45 |
| pdeore | anyone has anything else to discuss? | 14:47 |
| * croelandt has nothing | 14:48 | |
| mrjoshi | nothing from me | 14:48 |
| pdeore | ok, then let's conclude for today ! | 14:49 |
| pdeore | Thanks everyone for joining!! | 14:49 |
| pdeore | #endmeeting | 14:49 |
| opendevmeet | Meeting ended Thu Jul 20 14:49:44 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:49 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2023/glance.2023-07-20-13.59.html | 14:49 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2023/glance.2023-07-20-13.59.txt | 14:49 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2023/glance.2023-07-20-13.59.log.html | 14:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!