| pdeore | #startmeeting glance | 13:59 |
|---|---|---|
| opendevmeet | Meeting started Thu Apr 20 13:59:36 2023 UTC and is due to finish in 60 minutes. The chair is pdeore. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:59 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:59 |
| opendevmeet | The meeting name has been set to 'glance' | 13:59 |
| pdeore | #topic roll call | 13:59 |
| pdeore | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 13:59 |
| pdeore | o/ | 13:59 |
| mrjoshi | o/ | 13:59 |
| pdeore | we have very short agenda for today, let's wait for few mins for others to join | 14:00 |
| dansmith | o/ | 14:00 |
| pdeore | let's start, others may join in between :) | 14:01 |
| pdeore | #topic release/periodic jobs updates | 14:01 |
| pdeore | M1 is 3 weeks away from now | 14:02 |
| pdeore | Periodic job all green except failure on some functional py38 tests may be due to castellan version conflict | 14:02 |
| pdeore | #link https://5e09181bcc1a50499619-17764b56a5c622705c872e3c7dca2597.ssl.cf2.rackcdn.com/periodic/opendev.org/openstack/glance/master/glance-tox-functional-py38-cursive-tips/32bbbc2/tox/functional-py38/functional-py38-siblings.txt | 14:02 |
| pdeore | Not exactly sure but seems that castellan failure might be bcz of moving py3.8 support to py3.10 | 14:02 |
| pdeore | #link https://review.opendev.org/c/openstack/castellan/+/879932 | 14:02 |
| pdeore | so do we need to move these periodic jobs to py3.10 ? | 14:03 |
| croelandt | Py3.8 sounds like a thing of the past to me :) | 14:03 |
| pdeore | #link https://review.opendev.org/c/openstack/governance/+/872232 | 14:03 |
| dansmith | 3.8 is in focal yeah? | 14:03 |
| croelandt | but I think people still use 3.8 | 14:03 |
| pdeore | As per this, within 2023.2 python version 3.9 and 3.10 are the supported python runtimes | 14:04 |
| croelandt | pdeore: oh that is a good point | 14:04 |
| dansmith | yeah, was just looking for that because I couldn't remember if we dropped focal yet | 14:05 |
| pdeore | yeah it's in focal | 14:05 |
| dansmith | right, so nova is only running 39 and 310 now | 14:06 |
| pdeore | ohk ok, so can we move these jobs to py310? | 14:07 |
| dansmith | actually, nova has a 38 functional job, but I'm not sure why | 14:08 |
| dansmith | but yeah the governance patch means you don't *have* to test 3.8 anymore, so if something is broken there specifically, we can drop it | 14:08 |
| croelandt | If it's a setup issue, that should not really affect distros either, right? | 14:09 |
| croelandt | as they'll be using their own packages rather than recreating virtual envs | 14:09 |
| dansmith | I'm not really seeing *why* castellan is breaking on 38 though, but if it's confirmed it did something to break support (like using importlib.resources or something) then it makes sense to move on | 14:10 |
| croelandt | on master, python_requires is now set to >=3.9 | 14:11 |
| croelandt | in setup.cfg | 14:12 |
| croelandt | I'm not sure whether that is actually enforced by setuptools, but it shows they won't try to support 3.8 anymore anyway | 14:12 |
| dansmith | master castellan right? | 14:13 |
| dansmith | that might be why it's just failing to install then yeah | 14:13 |
| dansmith | and yeah, it will be enforced, AFAIK, I just expected a better error message :) | 14:13 |
| croelandt | master castellan, yes | 14:13 |
| croelandt | dansmith: yeah I've given up on error messages being useful :-( | 14:14 |
| pdeore | yeah exactly | 14:15 |
| croelandt | So, let's move to py310? | 14:15 |
| pdeore | yeah doesn't seem any other option for now :) | 14:15 |
| croelandt | It's settled then | 14:16 |
| pdeore | it would be nice if other members would also ack on this :) | 14:17 |
| abhishekk | what about our default jobs in tox should we drop py38 from there as well? | 14:17 |
| croelandt | We might want to keep unit tests as some distros are lagging behind (Debian cough cough) | 14:19 |
| pdeore | I think thats what other projects have done ? | 14:19 |
| croelandt | but functional tests 1) are a pain to debug 2) will require installing a lot more stuff (like castellan) | 14:19 |
| abhishekk | Ideally we should move | 14:20 |
| croelandt | +1 | 14:21 |
| abhishekk | I think rosmaita already submitted one patch, https://review.opendev.org/c/openstack/glance/+/880685 | 14:21 |
| pdeore | can we move these py38 job to 310 in the same patch then ? | 14:22 |
| dansmith | ah yep, that's the patch we need | 14:22 |
| abhishekk | pdeore, no that should be different one | 14:22 |
| dansmith | although it kept 38 fips | 14:22 |
| croelandt | do we get rid of all the 38 tests? | 14:23 |
| dansmith | oh and several others | 14:23 |
| dansmith | hmm, I wonder why he didn't convert those | 14:23 |
| dansmith | ah fips requires 38 still, in the commit message | 14:23 |
| croelandt | well Brian's patch is keeping functional-38 though | 14:23 |
| abhishekk | he just moved functional tests | 14:23 |
| dansmith | right but there are other 38 functional jobs that can probably go | 14:24 |
| croelandt | oh but the functional-38 is only local ok | 14:24 |
| dansmith | functional-py38-glance_store-tips for example | 14:24 |
| abhishekk | ack | 14:24 |
| croelandt | dansmith: do you wish to review his patch and suggest a second patchset? | 14:24 |
| dansmith | oh are those defined in glance_store? | 14:24 |
| dansmith | I think we should just approve this and follow up with more | 14:25 |
| abhishekk | I am just confused, with his patch | 14:25 |
| dansmith | unless it will fail on the job that requires castellan now? | 14:25 |
| abhishekk | what is the difference between line 45~47 and 49 onwards | 14:26 |
| abhishekk | if I run tox -e functional-py39 it will refer line 46 or 56? | 14:26 |
| croelandt | hm | 14:27 |
| dansmith | 45 | 14:27 |
| croelandt | functional-py39 and functional-py39-rbac are not the same thing | 14:27 |
| dansmith | 55 is the rbac | 14:27 |
| dansmith | right | 14:27 |
| abhishekk | hmm, dumb me :/ | 14:27 |
| abhishekk | we can define similar for rbac as well and reduce some lines :D | 14:27 |
| croelandt | I kind of like the patch, but I think dansmith wants more agressive cleaning up | 14:27 |
| croelandt | abhishekk: right | 14:28 |
| croelandt | this would be good feedback | 14:28 |
| abhishekk | yep anyone can add that feedback | 14:28 |
| dansmith | croelandt: no, I said we should merge this now and follow up with more :) | 14:29 |
| dansmith | the cleanup is not relevant to the actual work of the patch though, which is to change the jobs in zuul | 14:29 |
| dansmith | which requires the 311 to be added, which is why he's converting the existing functional targets to the pattern | 14:30 |
| croelandt | ok ok | 14:30 |
| dansmith | if we're going to convert the rbac 38 to 311 as well, then sure, but I'm just saying, we might as well iterate and get this going, IMHO | 14:30 |
| abhishekk | works either way for me | 14:30 |
| * dansmith +2d | 14:31 | |
| croelandt | +2+1d | 14:31 |
| abhishekk | cool, just remember someone has to work on migrating other tests as well | 14:31 |
| pdeore | ack | 14:31 |
| pdeore | croelandt, is it possible for you to submit the patch ? otherwise I will start that tmrw morning :) | 14:33 |
| croelandt | for rbac 38->311, yes | 14:33 |
| pdeore | ok | 14:33 |
| pdeore | let's move ahead | 14:34 |
| pdeore | #topic Specs | 14:34 |
| pdeore | there are few specs up for review, so kindly have a look | 14:34 |
| pdeore | #link https://review.opendev.org/c/openstack/glance-specs/+/880627 | 14:34 |
| pdeore | I have reproposed the image encryption spec to the current cycle | 14:35 |
| pdeore | I have also submitted bobcat project priorities | 14:35 |
| pdeore | #link https://review.opendev.org/c/openstack/glance-specs/+/880637 | 14:35 |
| pdeore | moving ahead | 14:36 |
| pdeore | #topic Important Bugs | 14:36 |
| pdeore | croelandt, ^ | 14:36 |
| croelandt | yep | 14:36 |
| croelandt | so the glanceclient gate is blocked | 14:36 |
| croelandt | if we could merge this https://review.opendev.org/c/openstack/python-glanceclient/+/880765 that would be great | 14:37 |
| croelandt | some tox4 magic I guess | 14:37 |
| croelandt | Then the glance-download plugin does not work well in the glanceclient, because we're trying to get attributes with invalid names | 14:37 |
| croelandt | see https://review.opendev.org/c/openstack/python-glanceclient/+/880696 | 14:37 |
| croelandt | there is a follow-up patch that I don't really like, but sent to get input from the bug reporter, I'll try to rework this ASAP | 14:38 |
| pdeore | ohh ok | 14:40 |
| pdeore | so this skipsdist thing we have already removed from glance | 14:40 |
| croelandt | and glance_store, yes | 14:40 |
| pdeore | yeah | 14:41 |
| * croelandt has given up on understanding the underlying details | 14:41 | |
| * croelandt is shoving up code in there, pushing it with his boots until it works | 14:41 | |
| pdeore | ohk let's wait for the reporter to test it | 14:42 |
| croelandt | yeah the first patch is defintily good | 14:42 |
| croelandt | getattr(x, 'foo-bar') cannot work | 14:43 |
| croelandt | since 'foo-bar' is not a valid attribute | 14:43 |
| croelandt | --foo-bar is converted to "foo_bar" by argparse | 14:43 |
| pdeore | not sure how it missed while implementing this :/ | 14:44 |
| croelandt | other than that, there were a few bugs on Launchpad with not enough info so I'm not gonna bother you with this :) | 14:45 |
| croelandt | yeah it happens | 14:45 |
| pdeore | cool, let's move to open discussions then :) | 14:45 |
| pdeore | #topic Open Discussions | 14:45 |
| pdeore | Artem has added abhishekk & croelandt into the openstacksdk-service-core group | 14:46 |
| croelandt | \o/ | 14:46 |
| pdeore | so yeah that's it from me for today | 14:46 |
| * croelandt has nothing more | 14:47 | |
| abhishekk | added? | 14:47 |
| pdeore | #link https://review.opendev.org/admin/groups/33c03b5e000a75ffc476c51d484c5111648d399c,members | 14:47 |
| pdeore | yes | 14:47 |
| pdeore | I thought you must have got that notification | 14:47 |
| abhishekk | ack | 14:47 |
| pdeore | ok, let's conclude for today then :) | 14:48 |
| abhishekk | Wait | 14:48 |
| pdeore | ohh | 14:48 |
| abhishekk | I had something | 14:48 |
| pdeore | yeah plz go ahead | 14:48 |
| abhishekk | any update from the author which added new proposal last week? | 14:48 |
| abhishekk | whether he is going to work on it or not | 14:49 |
| pdeore | no updates yet | 14:49 |
| abhishekk | also cyril is working on migrating rbac jobs,so periodic jobs will be still pending | 14:49 |
| abhishekk | ack, I guess you can try to reach him by mail if no reply till next week | 14:50 |
| pdeore | yeah that I will start working on tmrw | 14:50 |
| abhishekk | AND, last is there is slight change in new Location API work, rajat will submit the spec | 14:50 |
| pdeore | yeah I will try to ping him | 14:50 |
| abhishekk | so all reviewers please kindly have a look at it | 14:50 |
| abhishekk | done from me | 14:51 |
| pdeore | he has not yet updated the spec | 14:51 |
| abhishekk | he will submit the updated spec | 14:51 |
| pdeore | ahh missed that :/ | 14:51 |
| pdeore | cool | 14:52 |
| pdeore | let's wrap up then | 14:52 |
| pdeore | Thanks evryone for joining | 14:52 |
| pdeore | #endmeeting | 14:52 |
| opendevmeet | Meeting ended Thu Apr 20 14:52:52 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:52 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2023/glance.2023-04-20-13.59.html | 14:52 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2023/glance.2023-04-20-13.59.txt | 14:52 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2023/glance.2023-04-20-13.59.log.html | 14:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!