| *** soniya29|rover is now known as soniya29|rover|lunch | 09:29 | |
| *** soniya29|rover|lunch is now known as soniya29|rover | 10:16 | |
| *** soniya29|rover is now known as soniya29|rover|afk | 10:29 | |
| *** soniya29|rover|afk is now known as soniya29|rover | 10:35 | |
| *** soniya29|rover is now known as soniya29|rover|afk | 12:55 | |
| *** soniya29|rover|afk is now known as soniya29|rover | 13:21 | |
| pranali | #startmeeting glance | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Nov 17 14:00:40 2022 UTC and is due to finish in 60 minutes. The chair is pranali. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'glance' | 14:00 |
| pranali | #topic roll call | 14:00 |
| pranali | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:00 |
| pranali | o/ | 14:00 |
| rosmaita | o/ | 14:00 |
| abhishekk | o/ | 14:01 |
| pranali | lets wait few minutes for others to join | 14:01 |
| mrjoshi | o/ | 14:02 |
| pranali | I think we should start, others can join in between | 14:03 |
| pranali | #topic release/periodic job updates | 14:03 |
| pranali | This is milestone 1 release week | 14:03 |
| pranali | we have released glanceclient 4.2.0 | 14:03 |
| rosmaita | \o/ | 14:04 |
| pranali | and skipped glance m1 tag as we didn't have anything important merged | 14:04 |
| pranali | Periodic job all green except TIME_OUT for fips jobs | 14:05 |
| pranali | moving to next | 14:05 |
| pranali | #topic Catching up with reviews and specs | 14:05 |
| pranali | #link https://review.opendev.org/c/openstack/glance-specs/+/863209 - Repropose new location APIs spec | 14:05 |
| abhishekk | I have added some comments on new location spec | 14:06 |
| pranali | abhishkk has added some suggestions on this but i think whoami-rajat wants to discuss this for more details | 14:06 |
| abhishekk | also as this has dependency on service role implementation so submitted a PoC there as well | 14:06 |
| rosmaita | abhishekk: ++ | 14:06 |
| pranali | Thanks abhishekk | 14:07 |
| rosmaita | has that keystone spec been approved? | 14:07 |
| abhishekk | rosmaita, if you could take a look at that then we can move forward | 14:07 |
| abhishekk | not yet | 14:07 |
| rosmaita | abhishekk: will do | 14:07 |
| abhishekk | but I don't see there will be major changes in implementation/design anymore | 14:07 |
| abhishekk | rosmaita, thanks | 14:07 |
| rosmaita | i think whoami-rajat's questions are the same ones I had on the locations spec | 14:07 |
| rosmaita | they show up at the top of the latest patch set | 14:08 |
| pranali | yes | 14:08 |
| rosmaita | i didn't remember from the PTG what the deal is about the do_checksum parameter and the http store | 14:09 |
| abhishekk | need to wait for jokke_ to get his views | 14:09 |
| rosmaita | ok | 14:09 |
| rosmaita | i think that's the only holdup at this point | 14:09 |
| abhishekk | for point 2 http does not compute hash | 14:10 |
| jokke_ | I'm looking | 14:10 |
| rosmaita | jokke_: ty | 14:10 |
| pranali | jokke_, Thanks ! | 14:12 |
| pranali | there is one more spec needs some attention | 14:12 |
| pranali | #link https://review.opendev.org/c/openstack/glance-specs/+/787179 - Speedup upload images for Swift backend | 14:12 |
| pranali | the owner has updated the new patch set, and need our attention on this, so kindly please have a look | 14:12 |
| whoami-rajat | pranali, sorry i was away, thanks for discussing | 14:14 |
| whoami-rajat | as rosmaita said, I wanted to highlight the questions on the spec and get some reviews | 14:14 |
| pranali | whoami-rajat, np | 14:14 |
| pranali | yes, jokke_ is looking into that, i think we can continue the discussion on the patch itself so that we can move to our next topic | 14:16 |
| pranali | moving ahead | 14:17 |
| pranali | #topic SRBAC job failure for stable/wallaby | 14:17 |
| pranali | #link https://review.opendev.org/c/openstack/glance-tempest-plugin/+/864005 | 14:17 |
| pranali | rosmaita, as per the suggestions I tried with tag 0.2.1 at commit 380f871, #link https://review.opendev.org/c/openstack/glance-tempest-plugin/+/864843 | 14:18 |
| pranali | and also tried with 0.3.0 #link https://review.opendev.org/c/openstack/glance-tempest-plugin/+/864844 | 14:18 |
| pranali | but still failing with the same issue, #link https://review.opendev.org/c/openstack/glance/+/864865 | 14:18 |
| rosmaita | looks like it skipped all the tests again | 14:19 |
| pranali | yes | 14:19 |
| abhishekk | have you tested with depending on this, https://review.opendev.org/c/openstack/glance-tempest-plugin/+/864843 | 14:20 |
| pranali | abhishekk, yes i tried with both | 14:20 |
| abhishekk | where are the results of above change? | 14:20 |
| abhishekk | on glance side? | 14:21 |
| pranali | https://zuul.opendev.org/t/openstack/builds?job_name=glance-secure-rbac-protection-functional&project=openstack/glance | 14:21 |
| pranali | I checked on zuul status for patch 3 results and when i noticed it failed I updated the patchset 4 | 14:21 |
| pranali | so I think zuul didn't updated the result on that patch for patchset 3 | 14:22 |
| abhishekk | not getting it | 14:22 |
| rosmaita | that's weird ... the job on PS3 skipped 18 tests, i've usually seen this job skip 9 | 14:22 |
| rosmaita | PS3 results: https://zuul.opendev.org/t/openstack/build/100e34f88693495f9a304eec1442ea14 | 14:22 |
| *** dasm|off is now known as dasm | 14:22 | |
| pranali | rosmaita, yeah exactly, it should only run the images tests with that tag | 14:23 |
| abhishekk | you have submitted two DNM patches in plugin one is for 0.2.1 and one is for 0.3.0 and I can see only patch tested at glance side with 0.3.0 | 14:23 |
| pranali | abhishekk, if you check the above link, the SRBAC job ran 2 times , one for PS3, and second one for PS$ | 14:25 |
| pranali | s/PS$/PS4 | 14:25 |
| abhishekk | pranali, PS3 on https://review.opendev.org/c/openstack/glance/+/864865 , right? | 14:25 |
| pranali | yes | 14:25 |
| abhishekk | ok | 14:26 |
| rosmaita | how important is this job for stable/wallaby? | 14:27 |
| abhishekk | on PS3 job log I don't see I232bc47b77314f6fc4cb192530897cadd75a5426 of tempest plugin is applied, so how can we make sure this has been tested with expected code base? | 14:28 |
| jokke_ | rosmaita: I don't think it is, for any but Zed stable tbh | 14:29 |
| pranali | we have project persona support for images apis in wallaby, so I think it is imp | 14:29 |
| abhishekk | not any more since we are not backporting major changes now | 14:30 |
| abhishekk | but we should definitely need to know reason for this behavior | 14:30 |
| pranali | abhishekk, how you checked plugin patch is not applied on PS3 ? | 14:31 |
| abhishekk | just searched depends on hash inside job log | 14:32 |
| rosmaita | if you look at job-output.txt at time 2022-11-17 11:57:03.069890 | 14:32 |
| abhishekk | 2022-11-17 11:57:14.858401 | controller | opendev.org/openstack/glance-tempest-plugin checked out to: | 14:32 |
| abhishekk | 2022-11-17 11:57:14.858487 | controller | 0ffd874486966181b3653d447a7bb242ea27608d [DNM] Test with tag 0.2.1 at commit 380f871 for wallaby | 14:32 |
| abhishekk | 2022-11-17 11:57:14.858586 | controller | ok: Item: Runtime: 0:00:00.019453 | 14:32 |
| abhishekk | rosmaita, ack | 14:35 |
| pranali | so, what should we do ? should we remove this job ? | 14:35 |
| rosmaita | we may need some advice from fungi on this ... we need the cinder-tempest-plugin checked out at the hash we want to test on, but the code at that hash changes the zuul.yaml and says we want to use cinder-tempest-plugin at a different hash | 14:36 |
| rosmaita | looks like the first checkout wins | 14:36 |
| abhishekk | ++ I am against removing it without knowing the route cause | 14:36 |
| abhishekk | once we remove it, we will not go back and look why it was failing | 14:37 |
| abhishekk | and this may happen in future as well | 14:37 |
| rosmaita | the alternative would be to go back and re-define the job for stable/wallaby in the old config style, using tag 0.2.0 | 14:37 |
| fungi | is there an example? | 14:37 |
| rosmaita | fungi: thanks ... let me try to explain | 14:38 |
| rosmaita | we want to checkout cinder-tempest-plugin at a particular hash in a job that is defined in cinder-tempest-plugin's .zuul.yaml | 14:39 |
| fungi | "a particular hash" that is an already merged change? | 14:39 |
| rosmaita | yes, and that's this patch: https://review.opendev.org/c/openstack/glance-tempest-plugin/+/864843/2/.zuul.yaml | 14:39 |
| rosmaita | line 47 | 14:39 |
| rosmaita | and then to test that, we have a stable/wallaby glance patch | 14:40 |
| rosmaita | (which i have lost a ref to) | 14:40 |
| fungi | interesting. is this because the branch has already been eol'd/deleted? | 14:41 |
| pranali | https://review.opendev.org/c/openstack/glance/+/864865/4 | 14:41 |
| pranali | this is the test patch | 14:41 |
| rosmaita | no, it's not even at em yet, i don't think | 14:41 |
| abhishekk | rosmaita, cinder or glance? or cinder has similar problem as glance? | 14:41 |
| rosmaita | sorry, i call everything cinder these days | 14:42 |
| fungi | in that case, why not propose a change which reverts to the state in that commit and use depends-on to the change? | 14:42 |
| abhishekk | I was confused :D | 14:42 |
| rosmaita | i meant glance-tempest-plugin | 14:42 |
| rosmaita | oh, ok, you mean revert glance-tempest-plugin to the hash we want | 14:43 |
| rosmaita | and then the stable/wallaby glance patch can just depend on that without checking out anything special | 14:43 |
| fungi | not necessarily merge the revert, just propose it so you can rely on a depends-on in the change you're testing it from | 14:43 |
| rosmaita | (because master will be rolled back to the hash we want in the plubing) | 14:43 |
| rosmaita | fungi: right | 14:44 |
| rosmaita | i meant "revert on a gerrit patch" | 14:44 |
| rosmaita | pranali: does that make sense to you? | 14:44 |
| pranali | yes, will try that | 14:45 |
| rosmaita | thanks fungi! | 14:45 |
| fungi | i'm starting to understand. you're trying to work out a test regression for a glance stable branch but glance-tempest-plugin isn't branched? | 14:45 |
| rosmaita | fungi: exactly | 14:45 |
| rosmaita | we think we need to tag it in a different place, but want to test before proposing the tag | 14:45 |
| fungi | yeah, so if you assume the likely solution is reverting the regressive changes in glance-tempest-plugin anyway, proposing that revert so you can test with it via depends-on seems like the most straightforward approach | 14:46 |
| rosmaita | you have me convinced! | 14:46 |
| fungi | keep in mind that zuul isn't going to take job configuration from the tag, it only reads configuration from branches, so if what you're trying to address is in the job config itself then it will need actual reverting on master | 14:46 |
| pranali | fungi, ack | 14:47 |
| rosmaita | i didn't quite get that, but as long as pranali did, sounds good | 14:47 |
| fungi | but if you're just trying to deal with a regression in a tempest test routine or something, then yes retroactively tagging something old might solve it | 14:47 |
| fungi | (assuming the job on master overrides the tempest plugin checkout to the older tag for stable branch tests) | 14:49 |
| rosmaita | well, let's see what happens ... the wallaby-em is a bit flexible, we can ask the release team to hold off on tagging glance wallaby-em until we get this figured out | 14:49 |
| rosmaita | (because i think that deadline is soon?) | 14:50 |
| fungi | likely, it was tentatively due at the begining of november | 14:50 |
| * abhishekk last 10 minutes | 14:51 | |
| pranali | yeah, so I will try as per the suggestions, let's see how it goes | 14:52 |
| rosmaita | thanks! | 14:52 |
| pranali | moving to next | 14:52 |
| pranali | #topic DB migration constant | 14:52 |
| pranali | abhishekk, it's you | 14:53 |
| pranali | #link https://review.opendev.org/c/openstack/glance/+/861752 | 14:53 |
| abhishekk | Modified the test, but I think better we remove it and make a note to change the constant at the beginning at every release | 14:53 |
| abhishekk | If we define the constant as defined in above patch then we don't need major changes in our alembic migration | 14:55 |
| abhishekk | So have a look and let decide | 14:56 |
| pranali | yes, please add your comments on the patch and let's decide there | 14:56 |
| pranali | moving to open discussions | 14:56 |
| rosmaita | abhishekk: feel free to bug me in IRC if you don't see a comment on your patch by monday evening your time | 14:56 |
| pranali | #topic Open Discussions | 14:57 |
| abhishekk | rosmaita, ack, thank you | 14:57 |
| abhishekk | Nothing from me, will ping keystone/gmann on monday for service role review | 14:57 |
| pranali | I will not be around next week, will be on PTO | 14:57 |
| abhishekk | on Monday as well? | 14:57 |
| pranali | abhishekk, ack | 14:57 |
| pranali | most probably | 14:58 |
| pranali | ok, that's it from me | 14:59 |
| pranali | Thank you so much for joining !! | 14:59 |
| rosmaita | bye! | 14:59 |
| pranali | Bye | 14:59 |
| pranali | #endmeeting | 14:59 |
| opendevmeet | Meeting ended Thu Nov 17 14:59:58 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2022/glance.2022-11-17-14.00.html | 14:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2022/glance.2022-11-17-14.00.txt | 14:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2022/glance.2022-11-17-14.00.log.html | 14:59 |
| jokke_ | thanks all | 15:00 |
| *** dasm is now known as dasm|off | 22:47 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!