Tuesday, 2022-09-13

yasufumHi tacker team08:01
manpreetkHi08:01
takahashi-tschi08:01
uehahi08:02
masaki-uenohi08:02
yuta-kazatohi08:02
h_asahinahi08:02
hirofumi-noguchihi08:02
ma-ooyamahi08:02
yasufum#startmeeting tacker08:02
opendevmeetMeeting started Tue Sep 13 08:02:59 2022 UTC and is due to finish in 60 minutes.  The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot.08:02
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.08:02
opendevmeetThe meeting name has been set to 'tacker'08:02
yasufum#link https://etherpad.opendev.org/p/tacker-meeting08:03
yasufumThere are two items on the etherpad08:04
yasufumfrom ma-ooyama for both.08:04
yasufumSo, can we start from the first item?08:04
ma-ooyamaSure, first topic is about the review request for a db migration tool .08:05
yasufum#topic review request for a db migration tool08:05
ma-ooyamasorry for being late, but we would like you to review it.08:05
ma-ooyamaIt is in WIP state now, but is going to be done today. we would be grateful if you check the tool.08:05
yasufumIs there any reason why WIP is still remained?08:07
ma-ooyamaSome test patterns are left.08:08
yasufumDo you mean some more tests will be added to current WIP patch?08:09
ma-ooyamaNo. We are going to test some case in our environment. If some problems occurs, the patch may be fixed.08:11
yasufumI'd like to know how many line of codes can be changed from the current patch.08:15
yasufumin the next update08:15
ma-ooyamaEach UT works, so there will be not so many changes, I guess.08:16
yasufumOK, I understand it's not clear for now.08:19
yasufumAny other comment?08:19
ma-ooyamaYes. Sorry for not being clear. 08:19
yasufumAs you may know, it's just three days left for the end of R-308:24
yasufum#link https://releases.openstack.org/zed/schedule.html08:24
yasufumThe size of your patch is about 2500 lines, and it's more than I've expected actually...08:25
yasufumIt might not be able to complete possibly in this release08:27
ma-ooyamaI know... sorry for being late08:28
yasufumAnyway, please update your patch asap, thanks.08:29
ma-ooyamaSure. Thanks.08:29
yasufumOK, move on to the next item.08:31
yasufum#topic About stack_name compatibility08:31
ma-ooyamasure, second topic is about  stack_name compatibility.08:31
ma-ooyamaWhile implementing a db migration tool, we found that lcm operataion for v2 instance migrated by the tool doesn't work, because the stack names are different between v1 api and v2 api08:32
ma-ooyamaIn v2 api, the get_stack_name function in heat_utils.py returns stack name as "vnf-<vnf_id>".08:32
ma-ooyamahttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/heat_utils.py#L19608:32
ma-ooyamaBut stack name used in v1 api is like "vnflcm_<vnf_id>" or "<vnf_name>_<vnf_id>".08:32
ma-ooyamaRefering to the heat document, stack name can't be renamed after it has been launched.08:32
ma-ooyamahttps://docs.openstack.org/heat/latest/getting_started/create_a_stack.html#launching-a-stack08:33
ma-ooyamaConsidering future api refactoring, we think the get_stack_name function should be fixed to be compatible with v1 api.08:33
ma-ooyamaI would like to know your opinion.08:33
yasufumthanks08:35
yasufumI'd like to confirm about your suggestion.08:36
yasufumDo you want to change which of behavior of API if it's needed? Or any other way to keep the compatibility?08:38
yasufumI'm not sure about your concern exactly.08:39
ma-ooyamaI proposed the get_stack_name function should search the correct name. Because the name of "vnf-<vnf_id>" doesn't match in v1 api.08:42
ma-ooyamaIf the function get correct stack name, I think other process in v2 will work. 08:43
hirofumi-noguchiIs get_stack_name function in Tacker implementation?08:44
ma-ooyamaYes. 08:44
ma-ooyamahttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/heat_utils.py#L19608:44
hirofumi-noguchiYou mean some Tacker's functions regarding to get the vnf instance information needs to be modified.08:45
hirofumi-noguchiIs my understanding correct?08:45
ma-ooyamaYes.08:46
hirofumi-noguchiThanks, I got it.08:46
hirofumi-noguchiI agree with your suggestion because as you mentioned, the stack-name cannot be changed by Heat specification.08:47
hirofumi-noguchiTacker has to handle difference between the v1 and v2 stack-name.08:48
hirofumi-noguchiNow, I have no other idea. If someone have another ideas. please share.08:50
ma-ooyamaI think the function should be changed to search both v2 and v1 stack name patterns to heat, and return the hit name. 08:53
yasufumThanks.08:57
yasufumma-ooyama: Could you make a request on our launchpad? We can continue to discussion how we fix the issue on that.08:58
ma-ooyamaSure.08:58
yasufumAnd a patch for the fix will be uploaded then hopefully.08:58
uehaJust information, the following patch changes `stack_id` to be stored in VnfInstantiatedInfo.metadata.08:59
uehahttps://review.opendev.org/c/openstack/tacker/+/855444/12/tacker/sol_refactored/infra_drivers/openstack/heat_utils.py#20408:59
uehaSimilarly, if you have `stack_name` in it during db migration, I think you can use it. It's just an idea, so it may not go well..09:00
uehaI hope it helps you. thanks.09:01
ma-ooyamaIt looks useful. I'll confirm the patch later. Thanks!09:01
ueha:)09:01
yasufumOK09:04
yasufumIt seems enough for the topic.09:05
ma-ooyamaYes, thanks.09:05
yasufumSo, let's close this meeting if there're no comments or topics.09:06
uehaRegarding the releasenote coverage of topic last week, we (FJ) have posted all the releasenote patches for the ones that need releasenote.09:07
yasufumThanks.09:07
uehathanks for your reviewing too. :)09:07
yasufumOK, thanks for joining, bye!09:09
uehaThanks, bye09:09
manpreetkBye09:09
ma-ooyamathanks, bye09:09
yuta-kazatobye09:10
masaki-uenobye09:10
hirofumi-noguchibye09:10
yasufum#endmeeting09:10
opendevmeetMeeting ended Tue Sep 13 09:10:14 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)09:10
opendevmeetMinutes:        https://meetings.opendev.org/meetings/tacker/2022/tacker.2022-09-13-08.02.html09:10
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/tacker/2022/tacker.2022-09-13-08.02.txt09:10
opendevmeetLog:            https://meetings.opendev.org/meetings/tacker/2022/tacker.2022-09-13-08.02.log.html09:10
takahashi-tscbye09:10
*** dasm|off is now known as dasm13:21
*** dasm is now known as dasm|off22:28
*** dasm|off is now known as Guest30523:03

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!