| yasufum | hi team | 08:01 |
|---|---|---|
| manpreetk | hi | 08:01 |
| masaki_ueno | hi | 08:01 |
| ueha | hi | 08:01 |
| takahashi-tsc | hi | 08:01 |
| hamano | hi | 08:01 |
| h_asahina | hi | 08:01 |
| yasufum | #startmeeting tacker | 08:01 |
| opendevmeet | Meeting started Tue Nov 30 08:01:44 2021 UTC and is due to finish in 60 minutes. The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:01 |
| opendevmeet | The meeting name has been set to 'tacker' | 08:01 |
| yasufum | #link https://etherpad.opendev.org/p/tacker-meeting | 08:02 |
| yasufum | hi | 08:02 |
| yasufum | There are six items on the etherpad today. | 08:03 |
| yasufum | ueha: Can you start from your topic? | 08:03 |
| ueha | sure | 08:04 |
| ueha | My topic is just information sharing about current CI error. | 08:04 |
| ueha | The previously shared `tox -e docs` error has been cleared. However new errors are occurring one after another.. | 08:04 |
| ueha | Some errors have been fixed, but I and yasufum-san are currently trying to fix errors related to python-aodhclient. | 08:05 |
| ueha | * my patch: https://review.opendev.org/c/openstack/tacker/+/819554 (zuul+1 now) | 08:05 |
| ueha | * yasufum-san's patch: https://review.opendev.org/c/openstack/tacker/+/819666 | 08:05 |
| ueha | Because my patch only solves the problem on zuul, yasufum-san is trying to fix if there is any other better way to resolve it. | 08:06 |
| ueha | Please wait for a while until it is resolved. | 08:06 |
| ueha | That's all from me, any comment or question? | 08:06 |
| yasufum | My fix is the same as some previous trouble because of tosca-parser and heat-translator. | 08:07 |
| yasufum | Install aodhclient from git repo. | 08:07 |
| yasufum | The reason of current issue is because the aodhclient on git repo was already fixed, but not so on the pip package. | 08:09 |
| yasufum | We don't need to install client libs from pip actually for devstack, so it's better to use the libs on the latest git repo. | 08:10 |
| yasufum | Now I'm trying to fix some error on my patch. If it cannot be fixed, I'd suggest to merge ueha's patch as a temporary fix. | 08:11 |
| yasufum | Any question? | 08:11 |
| ueha | Thank you for the supplementary explanation. | 08:13 |
| ueha | python-aodhclient is not a package to be used directly by Tacker, but I think it is better if your fix succeed. | 08:13 |
| ueha | Thanks yasufum-san!:) | 08:14 |
| yasufum | ueha: many thanks too for your recent fixes for agte tests! | 08:14 |
| yasufum | Can we go to the next topic, masaki-ueno? | 08:15 |
| ueha | Your welcome! | 08:15 |
| masaki_ueno | Sure | 08:15 |
| masaki_ueno | My topic is maintaining .pylintrc in the repository for coding and reviewing | 08:15 |
| masaki_ueno | .pylintrc is a configuration file of Pylint (well-known linter for Python) | 08:16 |
| masaki_ueno | Current Tacker repository contains this file, but it is not well maintained. | 08:16 |
| masaki_ueno | The last update of this file is 8 years ago, so it contains some out-of-date configurations. | 08:17 |
| masaki_ueno | For the convenience in coding for each contributors and reviewing for each reviewers, I'd like to maintain .pylintrc to introduce Pylint as a development assist tool. | 08:18 |
| yasufum | The last update was in 2014! | 08:18 |
| masaki_ueno | Yes, so it is too old to use. | 08:18 |
| masaki_ueno | I think there are two steps for maintaining it in the community. | 08:18 |
| masaki_ueno | The first step is updating out-of-date configurations. | 08:19 |
| masaki_ueno | In this step, some settings will be removed because they've been obsoleted. | 08:19 |
| masaki_ueno | And if needed, I'd like to add the description about Pylint settings in the project README. | 08:20 |
| masaki_ueno | The second step is improving the configuration. I mean that I'd like to hear you which rule should be added/removed for coding and reviewing, or whether or not other settings should be updated. | 08:20 |
| masaki_ueno | Note that I don't mean that I'd like to introduce Pylint checking in Zuul tests. | 08:21 |
| masaki_ueno | Current Zuul test contains flake8 checkers, you know. I think it is enough in the test phase. | 08:22 |
| masaki_ueno | I'd like to introduce and maintain it only for the convenience for all contributors in Tacker project. | 08:22 |
| masaki_ueno | That's all for my suggestion. Thank you. | 08:23 |
| masaki_ueno | Any comments? | 08:23 |
| yasufum | I agree to start to maintain pylintrc again. | 08:25 |
| yasufum | It must be helpful for someone else. | 08:26 |
| masaki_ueno | Thanks. I forget to write the plan for the first step. I will upload a PatchSet that updates .pylintrc soon, so please review it. | 08:26 |
| ueha | I agree too. Is there any other project that maintains the Pylint setting? You may refer to it if it exists. | 08:27 |
| masaki_ueno | Yes. For example, cinder project seems maintaining .pylintrc well (the last update is 8 months ago). | 08:28 |
| masaki_ueno | But the config file in Cinder project disables so many check targets, so I think it is not useful for checking codes well. | 08:29 |
| takahashi-tsc | Neutron's last update is about 1 years ago. I think pylintrc is not updated so frequently. | 08:31 |
| ueha | I see, we should organize it once by ourselves. | 08:31 |
| takahashi-tsc | But...Tacker is too old. | 08:31 |
| takahashi-tsc | I agree that we should maintain once. | 08:32 |
| masaki_ueno | Thanks. But too strict rules also disturb the developing, so it is difficult to determine the best rule sets for this project. | 08:33 |
| takahashi-tsc | Agree, strict rules is unnecessary and difficult to make. | 08:33 |
| masaki_ueno | So, I'd like to hear contributors and reviewers the items that should be removed from the current rule sets in the end of Yoga development. | 08:35 |
| yasufum | sounds good | 08:35 |
| yasufum | or next PTG, not virtual at Berlin hopefully. | 08:36 |
| masaki_ueno | :) | 08:37 |
| yasufum | I think it seems enough discussed today for the topic. | 08:37 |
| masaki_ueno | Thank you! | 08:38 |
| yasufum | thnaks | 08:38 |
| yasufum | h-asahina: can you share your topic? | 08:38 |
| h_asahina | sure | 08:38 |
| h_asahina | I'd like to let you know that I added the SOL003 cancel API and a corresponding cancel command to fix bug https://bugs.launchpad.net/tacker/+bug/1924917 | 08:38 |
| h_asahina | A patch for the tacker-server, and a blueprint and a patch for the python-tackerclient have already been pushed. | 08:39 |
| h_asahina | Server: https://review.opendev.org/c/openstack/tacker/+/815416 | 08:39 |
| h_asahina | Client: https://review.opendev.org/c/openstack/python-tackerclient/+/818520 | 08:39 |
| h_asahina | BP: https://blueprints.launchpad.net/openstack/?searchtext=support-cancel | 08:39 |
| h_asahina | After Zuul is fixed, I'll send a review request, but if you have any comments now, please let me know. | 08:40 |
| h_asahina | That's all from my side. Thanks. | 08:41 |
| yasufum | thanks, any comment? | 08:41 |
| takahashi-tsc | Thank you so much. Bug report is from me but sorry that our development has no progress. We'll confirm this fix is enough to solve bug we report. | 08:42 |
| h_asahina | Thankss. I'll add you to the reviewer. | 08:43 |
| takahashi-tsc | Thanks | 08:44 |
| yasufum | OK | 08:46 |
| yasufum | go to the next topic if no more comments. | 08:47 |
| yasufum | from hamano | 08:48 |
| yasufum | hamano: can you share your topic? | 08:49 |
| hamano | yes | 08:49 |
| hamano | I report on the Test case of v2 error handling operation. | 08:49 |
| hamano | First, about UT | 08:49 |
| hamano | UT uses Mock and implements the minimum required, so it does not affect the execution time of CI in particular. | 08:50 |
| hamano | When measured in a local environment, the execution time of all the added test cases was very short. | 08:50 |
| hamano | If you have any concerns, please comment on these patches below. | 08:50 |
| hamano | retry-> https://review.opendev.org/c/openstack/tacker/+/816115 | 08:51 |
| hamano | rollback-> https://review.opendev.org/c/openstack/tacker/+/816116 | 08:51 |
| hamano | fail->※Scheduled to contribute patch after merging the above patches | 08:51 |
| hamano | Next, about FT | 08:51 |
| hamano | We are considering to use the mgmt_driver script to make the transition to FAILED_TEMP in FT. | 08:52 |
| hamano | For example, if you use the following SampleScript, you can easily transition to the FAILED_TEMP state by creating a file under tmp. | 08:52 |
| hamano | SampleScript-> https://review.opendev.org/c/openstack/tacker/+/816300/6/tacker/tests/functional/sol_v2/samples/sample_error/contents/Scripts/sample_script.py | 08:53 |
| hamano | Do you have any comments or concerns? | 08:53 |
| hamano | It's okay to comment on the patch later. | 08:53 |
| hamano | That's all from my side. | 08:55 |
| yasufum | Thanks | 08:55 |
| yasufum | I'd like to review later. | 08:55 |
| hamano | Thanks | 08:55 |
| yasufum | OK, go to the next topic proposing a new spec from edagawa_kc | 08:57 |
| edagawa_kc | Sure. | 08:58 |
| edagawa_kc | I would like to discuss two topics regarding support handling large query results. | 08:58 |
| edagawa_kc | The spec has been already discussed in Xena vPTG, and I want to ask your opinion about details. | 08:59 |
| edagawa_kc | About topic 1, I described existing behavior and new feature by this spec. | 09:01 |
| edagawa_kc | I think there is no concern about yours, but I would like to confirm if it is OK for you. | 09:03 |
| edagawa_kc | As for topic 2, this is new feature I would like to add, so probably it needs some discussion. | 09:05 |
| yasufum | is that all? | 09:09 |
| yasufum | OK, thanks for your suggestion. | 09:11 |
| yasufum | Please give your comment on the patch if you have any concerns. | 09:12 |
| yasufum | so, go to the final topic. | 09:12 |
| yasufum | oyama: can you start? | 09:12 |
| ma-ooyama | Sure. My topics are about a sample vnf package I explained in PTG. | 09:12 |
| ma-ooyama | First, I would like to ask you to review my spec. Please do that when you have a time. | 09:13 |
| ma-ooyama | And second, I need some advice about where I should write documentation. | 09:13 |
| ma-ooyama | I'm going to make sample vnf package itself and documentation that explains how to use the sample. | 09:14 |
| ma-ooyama | I think "Getting Started" or "Use Case Guide" in User Guide are good to place the documentation. | 09:14 |
| ma-ooyama | Would you give me some advice about that? | 09:14 |
| yasufum | getting started is expected to be simle with minimum usecase. | 09:17 |
| takahashi-tsc | In my opinion, "Use Case Guide" is better because Getting started shoule be for beginner. But this is just my opinion. | 09:17 |
| yasufum | agree | 09:17 |
| takahashi-tsc | Ah... probably similar opinion as yasufum | 09:17 |
| yasufum | Or it's OK to add a new section for dedicating more practical usecases. | 09:18 |
| yasufum | tacker docs is still under revising, so I'm very welcome your poposal for the docs. | 09:19 |
| yasufum | #link https://etherpad.opendev.org/p/tacker-wallaby-revise-docs | 09:19 |
| yasufum | I'd appreciate if you update this etherpad for your suggestion. | 09:19 |
| ma-ooyama | I understood. The sample is for user who want to deploy VNF in commercial environment. So Use Case Guide is better than Getting Started. | 09:21 |
| yasufum | OK, any other comment? | 09:22 |
| ma-ooyama | And I understood updating the etherpad is needed. Thanks. | 09:23 |
| yasufum | thanks | 09:23 |
| yasufum | Thanks everyone for discussion for so many items :) | 09:25 |
| yasufum | Let's close this meeting if you have no more comments. | 09:26 |
| yasufum | Thank you for joining, bye! | 09:27 |
| takahashi-tsc | Thanks, bye! | 09:27 |
| ueha | Thanks, bye | 09:27 |
| ma-ooyama | Thanks, bye | 09:27 |
| edagawa_kc | bye. | 09:27 |
| hamano | bye | 09:27 |
| masaki_ueno | bye | 09:27 |
| yasufum | #endmeeting | 09:27 |
| opendevmeet | Meeting ended Tue Nov 30 09:27:41 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:27 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-11-30-08.01.html | 09:27 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-11-30-08.01.txt | 09:27 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-11-30-08.01.log.html | 09:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!