Thursday, 2012-05-31

*** milner has quit IRC00:06
*** blamar has quit IRC00:15
*** troytoman is now known as troytoman-away00:18
*** anderstj has joined #openstack-meeting00:19
*** milner has joined #openstack-meeting00:20
*** jakedahn is now known as jakedahn_zz00:21
*** anderstj has quit IRC00:36
*** johnpostlethwait has quit IRC00:39
*** edygarcia has joined #openstack-meeting00:40
*** s0mik has quit IRC00:43
*** matwood has quit IRC00:44
*** mnewby_ has joined #openstack-meeting00:52
*** mnewby has quit IRC00:55
*** mnewby_ has quit IRC00:56
*** jdurgin has quit IRC00:56
*** edygarcia has quit IRC01:12
*** anderstj has joined #openstack-meeting01:20
*** Gordonz has joined #openstack-meeting01:28
*** ayoung has quit IRC01:28
*** Gordonz has quit IRC01:34
*** _adjohn has joined #openstack-meeting01:37
*** ywu has joined #openstack-meeting01:37
*** maoy has joined #openstack-meeting01:37
*** PotHix has quit IRC01:39
*** adjohn has quit IRC01:39
*** _adjohn is now known as adjohn01:39
*** jakedahn_zz is now known as jakedahn01:40
*** jakedahn is now known as jakedahn_zz01:47
*** adjohn has quit IRC01:48
*** adjohn has joined #openstack-meeting01:49
*** adjohn has quit IRC01:50
*** anderstj has quit IRC02:03
*** jog0 has quit IRC02:04
*** bencherian has quit IRC02:18
*** bencherian has joined #openstack-meeting02:19
*** dwcramer has joined #openstack-meeting02:20
*** bencherian has quit IRC02:23
*** ijw has quit IRC02:28
*** ijw has joined #openstack-meeting02:28
*** WilliamHerry has joined #openstack-meeting02:36
*** ywu has quit IRC02:39
*** maoy has quit IRC02:39
*** novas0x2a|lapto1 has quit IRC02:48
*** Gordonz has joined #openstack-meeting02:50
*** anderstj has joined #openstack-meeting02:58
*** anderstj has quit IRC03:00
*** dwcramer has quit IRC03:06
*** garyk has quit IRC03:20
*** dwcramer has joined #openstack-meeting03:21
*** garyk has joined #openstack-meeting03:22
*** dwcramer has quit IRC03:26
*** dendro-afk is now known as dendrobates03:33
*** dendrobates has joined #openstack-meeting03:33
*** edygarcia has joined #openstack-meeting03:39
*** dwcramer has joined #openstack-meeting03:40
*** Gordonz has quit IRC03:42
*** dwcramer has quit IRC03:45
*** ohnoimdead has quit IRC03:52
*** Mandell has joined #openstack-meeting03:54
*** dwcramer has joined #openstack-meeting03:58
*** dwcramer has quit IRC04:04
*** bencherian has joined #openstack-meeting04:07
*** Gordonz has joined #openstack-meeting04:20
*** garyk has quit IRC04:31
*** matwood has joined #openstack-meeting04:34
*** matwood has joined #openstack-meeting04:35
*** edygarcia has quit IRC04:44
*** Gordonz has quit IRC04:50
*** dolphm has joined #openstack-meeting04:52
*** Mandell has quit IRC04:54
*** littleidea has quit IRC05:04
*** anderstj has joined #openstack-meeting05:18
*** joearnold has joined #openstack-meeting05:19
*** matwood has quit IRC05:23
*** dendrobates is now known as dendro-afk05:25
*** jakedahn_zz is now known as jakedahn05:26
*** dayou has joined #openstack-meeting05:27
*** anderstj has quit IRC05:47
*** bencherian has quit IRC05:48
*** dtroyer is now known as dtroyer_zzz05:56
*** sdague_ has joined #openstack-meeting06:04
*** sdague has quit IRC06:06
*** GheAway has quit IRC06:06
*** GheAway has joined #openstack-meeting06:07
*** dolphm has quit IRC06:10
*** joearnold has quit IRC06:15
*** vincentricci_ has joined #openstack-meeting06:20
*** vincentricci_ has left #openstack-meeting06:20
*** vincentricci_ has joined #openstack-meeting06:21
*** garyk has joined #openstack-meeting06:36
*** vincentricci_ has quit IRC06:47
*** cloudfly has quit IRC07:04
*** dhellmann_ has joined #openstack-meeting07:36
*** dhellmann has quit IRC07:36
*** dhellmann_ is now known as dhellmann07:36
*** ttrifonov_zZzz is now known as ttrifonov08:02
*** DuncanT1 has joined #openstack-meeting08:06
*** GheAway is now known as GheRivero08:11
*** derekh has joined #openstack-meeting08:14
*** GheRivero has quit IRC08:17
*** GheRivero has joined #openstack-meeting08:29
*** sandywalsh has quit IRC08:34
*** troytoman-away is now known as troytoman09:29
*** jakedahn is now known as jakedahn_zz09:41
*** ijw has quit IRC10:17
*** ijw has joined #openstack-meeting10:18
*** littleidea has joined #openstack-meeting10:43
*** dwcramer has joined #openstack-meeting11:28
*** markvoelker has joined #openstack-meeting11:30
*** dwcramer has quit IRC11:50
*** sandywalsh has joined #openstack-meeting12:15
*** dprince has joined #openstack-meeting12:18
*** WilliamHerry has quit IRC12:20
*** dwcramer has joined #openstack-meeting12:26
*** dwcramer has quit IRC12:44
*** rash has quit IRC12:47
*** dolphm has joined #openstack-meeting12:51
*** GheRivero is now known as GheAway12:59
*** mdomsch has quit IRC13:02
*** sandywalsh has quit IRC13:07
*** sdague_ is now known as sdague13:08
*** edygarcia has joined #openstack-meeting13:11
*** tongli|2 has joined #openstack-meeting13:16
*** ayoung has joined #openstack-meeting13:24
*** matwood has joined #openstack-meeting13:29
*** edygarcia has quit IRC13:29
*** jamespage has quit IRC13:39
*** jamespage has joined #openstack-meeting13:41
*** GheRivero has joined #openstack-meeting13:46
*** dwcramer has joined #openstack-meeting13:52
*** AlanClark has joined #openstack-meeting13:58
*** edygarcia has joined #openstack-meeting14:02
*** jaypipes is now known as jaypipes-afk14:03
*** nikhil_ has joined #openstack-meeting14:11
*** nikhil_ is now known as Guest9678614:11
*** troytoman is now known as troytoman-away14:14
*** dayou has quit IRC14:16
*** dtroyer_zzz is now known as dtroyer14:21
*** primeministerp has quit IRC14:21
*** jgriffith-away is now known as jgriffith14:22
*** Guest96786 has quit IRC14:24
*** nikhil__ has joined #openstack-meeting14:24
*** dtroyer is now known as dtroyer_zzz14:44
*** troytoman-away is now known as troytoman14:45
*** ryanpetrello has joined #openstack-meeting14:47
*** rnirmal has joined #openstack-meeting14:48
*** jd____ has joined #openstack-meeting14:49
*** jd___ has quit IRC14:52
*** jd____ is now known as jd___14:52
*** blamar has joined #openstack-meeting14:55
*** dtroyer_zzz is now known as dtroyer14:56
*** ayoung has quit IRC15:02
*** ayoung has joined #openstack-meeting15:05
*** shang has quit IRC15:10
*** shang has joined #openstack-meeting15:10
*** Gordonz has joined #openstack-meeting15:14
*** vincentricci has joined #openstack-meeting15:14
*** thatsdone has joined #openstack-meeting15:15
*** Gordonz has quit IRC15:16
*** jkoelker has quit IRC15:16
*** jkoelker has joined #openstack-meeting15:18
*** mattray has joined #openstack-meeting15:20
*** Gordonz has joined #openstack-meeting15:21
*** DuncanT1 has left #openstack-meeting15:26
*** derekh has quit IRC15:32
*** maoy has joined #openstack-meeting15:40
*** PotHix has joined #openstack-meeting15:45
*** Gordonz has quit IRC15:45
*** Gordonz has joined #openstack-meeting15:45
*** derekh has joined #openstack-meeting15:46
*** jgriffith has quit IRC15:51
*** jgriffith has joined #openstack-meeting15:51
*** garyk has quit IRC15:55
*** mdomsch has joined #openstack-meeting15:55
*** flacoste has joined #openstack-meeting15:59
dhellmannhi, flacoste16:00
nijabahello dhellmann, flacoste16:00
*** dachary has joined #openstack-meeting16:01
flacostehi dhellmann16:01
*** semyazz has joined #openstack-meeting16:01
flacostehi nijaba16:01
dhellmannhow's the event at enovance going nijaba & dachary?16:01
dacharydhellmann: awesome  :-)16:01
*** semyazz has left #openstack-meeting16:01
dacharyhttp://www.slideshare.net/enovance are the slides (most of them)16:01
* dhellmann is sad he missed out16:01
jd___hi16:01
nijabadhellmann: it wa great. 120 attended.  full room16:02
dhellmannthat's good turn out!16:02
dacharydhellmann: next event you'll talk about ceilometer ?16:02
dhellmannany excuse to come to paris :-)16:02
dacharyahah16:02
nijabadachary: I already did a bit :)16:02
jd___#startmeeting16:02
jd___#meetingname ceilometer16:02
jd___#link https://lists.launchpad.net/openstack/msg12501.html16:02
openstackMeeting started Thu May 31 16:02:40 2012 UTC.  The chair is jd___. Information about MeetBot at http://wiki.debian.org/MeetBot.16:02
jd___16:02
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:02
openstackThe meeting name has been set to 'ceilometer'16:02
*** edygarcia has quit IRC16:02
jd___#chair nijaba dachary16:03
openstackCurrent chairs: dachary jd___ nijaba16:03
jd___#topic actions from previous meetings16:03
*** openstack changes topic to "actions from previous meetings"16:03
*** edygarcia has joined #openstack-meeting16:03
jd___#info jd___ and dhellmann opened a bunch of bugs on Launchpad to track things https://bugs.launchpad.net/ceilometer16:03
jd___I don't think they were any other actions planned16:03
jd___but if someone wants to add something, please say so16:04
nijabaThanks for your great work on the testing framework, dhellmann & jd___16:04
*** thatsdone has quit IRC16:04
jd___thanks nijaba :)16:04
dhellmannthat caught me a little off guard, but I'm glad we have that going now16:04
jd___dhellmann: that's part of the fun ;)16:04
nijabaI am very happy that we are laying the ground nicely for a stable and reliable project16:05
dhellmannjd___, I told my manager "If it was easy, anyone could do it."16:05
*** jdurgin has joined #openstack-meeting16:05
jd___:-)16:05
*** lloydde has joined #openstack-meeting16:05
dhellmannI have a demo later this afternoon showing ceilometer as part of DreamHost's alpha 1 milestone. I appreciate the help everyone has provided in making it possible to do that. :-)16:05
nijabadhellmann: amazing!16:06
jd___nice16:06
dhellmannit's a small, internal demo, as part of our sprint process, but a HUGE milestone for me (and us)16:06
jd___you'll have to tell the result ;)16:07
dhellmannI'll definitely let you know how it goes16:07
dhellmann#action dhellmann to report on outcome of demo at DreamHost16:07
jd___:-)16:07
jd___#action dhellmann to report on outcome of demo at DreamHost16:07
jd___(not sure it works otherwise)16:08
jd___ok so let's move on16:08
jd___#topic API message format16:08
*** openstack changes topic to "API message format"16:08
dhellmannI have a gist prepared with the existing message format: https://gist.github.com/284441016:08
dhellmannthis is based on the work done so far, and is how the agent sends messages to the collector16:08
dhellmannit's there for reference, but there are definitely things I want to change about it before we call it "done"16:09
nijabadhellmann: based on the ml discussion, I think we should add something to cast the meter (delta, gauge,...)16:09
dhellmannthe first being the RPC wrapper, since the metering messages feel a lot more like notifications than RPC calls16:09
dhellmannyes, good point16:09
dhellmannI'll open a ticket for that16:10
flacostenijaba, dhellmann: isn't it part of the event_type field?16:10
flacoste 'event_type': '%s.%s' % (cfg.CONF.metering_topic,16:10
flacoste               counter.type)16:10
flacostecounter.type?16:10
dhellmannheh, there's already a bug open for that16:10
nijabadhellmann: should we also have something that identify the emiting host, or is this part of the envelope?16:10
dhellmannthe existing counter.type value is the id or name from the table in the wiki16:11
dhellmannbug #1006425 talks about changing that16:11
uvirtbotLaunchpad bug 1006425 in ceilometer "add counter type field" [Undecided,New] https://launchpad.net/bugs/100642516:11
dhellmannhey, nice bot action!16:11
*** Mandell has joined #openstack-meeting16:12
dhellmannnijaba, yes, I think the emitting host is in there somewhere as part of the event metadata, but we should add an explicit field16:12
dhellmannsee bug #100698916:12
uvirtbotLaunchpad bug 1006989 in ceilometer "add emitting host field to meter messages" [Undecided,New] https://launchpad.net/bugs/100698916:12
nijabadhellmann: nice.  we can also add something on the collector that does anti spoofing then16:12
jd___we can rely on signature for that if we have a key for each host16:13
dhellmannsee bug #100699016:13
uvirtbotLaunchpad bug 1006990 in ceilometer "the collector should verify the signature of incoming metering data" [Undecided,New] https://launchpad.net/bugs/100699016:13
dhellmannjd___ the way the signature works now is a single shared secret value. do you mean to have a separate secret for each host?16:14
jd___dhellmann: that would be the best way to do anti spoofing on a per-host basis if we want that16:14
nijabadhellmann: I will add a comment on the bug to check host field with envelop as well, as private keys can be eventually stolen16:14
jd___I don't think I want that but maybe nijaba wants16:14
dhellmannok, I can see that16:15
*** dwcramer has quit IRC16:15
*** dwalleck has joined #openstack-meeting16:15
nijaba#action nijaba to comment on bug 1006990 for anti spoofing of messages16:15
uvirtbotLaunchpad bug 1006990 in ceilometer "the collector should verify the signature of incoming metering data" [Undecided,New] https://launchpad.net/bugs/100699016:15
dhellmannwe will need to figure out how to share those configuration values with the collector and the agent, but it's possible16:15
*** Mandell has quit IRC16:16
jd___maybe for now a unique key for everyone is enough16:16
*** Padi has joined #openstack-meeting16:16
dhellmannI think that satisfies my needs, but I'm sure we can implement it in a way that hosts can have their own keys, too16:16
jd___sure16:16
nijabaI would vote for a key per agent16:17
nijabato maintain indepence of agents16:17
zykes-ceilometer ?16:17
dhellmannnijaba, do you want to open a ticket or blueprint to work out how to implement it?16:17
nijabadhellmann: I take the action16:17
jd___zykes-: yes16:17
nijaba#action nijaba to define a configuration mechanism on a per agent basis16:18
jd___dhellmann: so event_type will be removed IIUC ?16:19
zykes-will there be a basic folsom integration?16:19
nijabazykes-: we are targeting folsom for 1st delivery16:20
dhellmannjd___ we have some redundant information now, with event_type appearing as a top-level item and as part of the metadata added by the instance counter. so one copy can go away16:20
jd___dhellmann: that's what I though, ok16:21
*** s0mik has joined #openstack-meeting16:21
jd___if it's only needed by the rpc mechanism, it'll go away16:21
dhellmannwell, it's not needed by the rpc mechanism. I added it because tools/notificationclient.py was expecting to find it :-)16:21
jd___oh ok16:22
*** Mandell has joined #openstack-meeting16:22
dhellmannbut it can probably still go away16:22
jd___yeah :)16:22
dhellmannthe current format is a bit of a mixup of notification and rpc16:22
dhellmannI expected to clean it up when we get to the point of actually storing the data16:22
jd___fair enough16:23
*** joearnold has joined #openstack-meeting16:23
dhellmannsee bug #100699516:23
uvirtbotLaunchpad bug 1006995 in ceilometer "clean up redundant metering message fields" [Undecided,New] https://launchpad.net/bugs/100699516:23
nijabaare we still in agreement that these messages will go through a separate queue from the nova queue, while still using the openstack common queue functions?16:24
jd___I think so16:25
dhellmannI think so. Each message is going to 2 queues right now: "metering" and "metering.type" where type is "instance", "disk", "floatingip", etc.16:25
nijabanice16:25
dhellmannI want to keep the names, but use something closer to the nofiy() function instead of cast() to send the messages16:26
dhellmannthat will mean creating a new type of consumer in the rpc library, though :-/16:26
nijabawould that be a problem?16:27
dhellmannno, I just need to do the work.16:27
dhellmannthey are pretty close to having that code ready to move out of nova into openstack-common, so it might make sense to wait a iittle while16:27
nijabadhellmann: let's hope that flacoste will soon have a team to supplement you and jd___ here16:27
dhellmannunless they're not as close as I think16:28
flacostenijaba: we are still a few weeks away from that unfortunately :-(16:28
dhellmannit would be good to have a few more hands :-)16:28
jd___anyway we already need the consumer type dhellmann, if it can be compatible with nova notifications16:28
dhellmannah, well, we'll still have plenty of work for them to do then16:28
nijabaflacoste: should we send CVs to you?16:28
dhellmannexactly, jd___16:28
flacostenijaba: please do actually!16:29
nijabaI will!16:29
*** dwcramer has joined #openstack-meeting16:29
dhellmannis there any other feedback on the message format or contents?16:31
*** mattray has quit IRC16:32
jd___not from my point16:32
*** darraghb has joined #openstack-meeting16:32
nijabanor here16:32
flacosteneither here16:33
dhellmanngood. I'm sure we will find other things to change as we go along, but this should work for now.16:33
*** Mandell has quit IRC16:33
dhellmannnext week is the "storage backend" discussion, right?16:34
*** sleepsonzzz is now known as sleepsonthefloor16:34
nijabadhellmann: yes16:35
jd___yep16:35
nijabashould we mark your proposal as agreed, pending the discussed changes?16:35
dhellmannI am looking forward to reading the proposals for that on the mailing list. :-)16:35
dhellmannif everyone is comfortable with it, I am16:36
nijabadhellmann: same here.  Sound like a mongoDB vs Riak vs ... flamewar to start16:36
nijabajd___: vote maybe?16:36
nijabajust to check?16:36
flacostewhat, nobody is considering PostgreSQL? :-)16:36
dhellmannnijaba, I think we'll probably have another plugin point for storage backends :-)16:37
nijabadhellmann: true, but not SQLAlchemy!16:37
dhellmannI will leave that up to the implementer. :-)16:38
nijabahehe16:38
jd___if you want :)16:38
nijabaso, should we vote on the API message format or just mark it as agreed?16:40
dhellmannlet's do the vote and make it official16:41
nijabajd___: go ahead and open the vote then :)16:41
jd___anything else?16:42
dhellmannnot from me16:43
nijabanor here (apart from the vote)16:43
*** ohnoimdead has joined #openstack-meeting16:44
nijabaok, I'll open the vote then16:45
jd___go ahead16:45
nijaba#vote agreement on the proposal from dhellmann https://gist.github.com/2844410 for API messaging format, pending the 2 modifications discussed during the meeting16:45
nijaba+116:46
flacoste+116:46
dhellmann+116:46
*** adjohn has joined #openstack-meeting16:46
dachary+116:46
*** ohnoimdead has quit IRC16:46
jd___+116:46
nijabaok, I guess we can mark this as agreed then16:46
nijaba#agreed on the proposal from dhellmann https://gist.github.com/2844410 for API messaging format, pending the 2 modifications discussed during the meeting16:47
dhellmanngood16:47
dhellmannif we're done, it's time for some lunch here16:48
nijaba#topic other topics16:49
*** openstack changes topic to "other topics"16:49
nijabaanyone?16:49
flacostedhellmann: +116:49
nijabaok, I guess some bellys need to get filled :)16:49
nijababellies maybe?16:50
nijabaanyway... thanks everyone!16:50
dhellmannthanks!16:50
flacostethanks!16:50
dacharynijaba: thanks !16:50
nijaba#endmeeting16:50
dacharyand thanks everyone :-)16:50
*** openstack changes topic to "OpenStack meeting channel. See http://wiki.openstack.org/Meetings for schedule and http://eavesdrop.openstack.org/meetings/openstack-meeting/ for meeting logs"16:50
openstackMeeting ended Thu May 31 16:50:36 2012 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:50
openstackMinutes:        http://eavesdrop.openstack.org/meetings/openstack-meeting/2012/openstack-meeting.2012-05-31-16.02.html16:50
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/openstack-meeting/2012/openstack-meeting.2012-05-31-16.02.txt16:50
openstackLog:            http://eavesdrop.openstack.org/meetings/openstack-meeting/2012/openstack-meeting.2012-05-31-16.02.log.html16:50
*** flacoste has left #openstack-meeting16:50
*** Ravikumar_hp has joined #openstack-meeting16:55
*** maoy has quit IRC16:59
*** GheRivero has quit IRC17:01
*** donaldngo_hp has joined #openstack-meeting17:01
*** rohitk has joined #openstack-meeting17:02
*** edygarcia has quit IRC17:02
*** Padi has quit IRC17:02
*** edygarcia has joined #openstack-meeting17:02
*** dwcramer has quit IRC17:02
davidkranzQA meeting?17:05
Ravikumar_hpready.17:06
rohitkhi17:06
dwallecksure17:06
davidkranzIs Jay here?17:06
*** JoseSwiftQA has joined #openstack-meeting17:06
*** maoy has joined #openstack-meeting17:07
*** rohit-k has joined #openstack-meeting17:07
davidkranzI guess not. Does any one else know the status of tempest gating?17:08
dwallecknope, not involved with that17:09
rohit-kme neither, but jenkins build history doesnt look very stable at first glance17:10
*** rohitk has quit IRC17:10
davidkranzrohit-k: What is the URL for that?17:10
rohit-khttps://jenkins.openstack.org/view/Tempest/builds17:10
davidkranzI see.17:11
rohit-k'nodes getting offline' now and then17:12
davidkranzI think we are going to need another rotating captain to monitor the nightly tempest run once it is working.17:12
Ravikumar_hp++ looks like17:12
davidkranzJoseSwiftQA: What's up with the swift tests?17:13
JoseSwiftQAOther than final pep8 checks, it's code complete.  I want to run it through some more tests before I submit.17:13
davidkranzJoseSwiftQA: OK, amy thoughts on when that will be?17:14
JoseSwiftQAMy devstack instance blew up over the weekend, and i stubbornly tried to fix it instead of rebuilding it :D17:14
*** derekh has quit IRC17:14
JoseSwiftQAI can get the last testing done today and hopefully have it submitted today as well.17:14
davidkranzJoseSwiftQA: Great.17:14
Ravikumar_hplooks like code submitted Gerrit review - expired17:14
JoseSwiftQAI'll have to add another test for the container list method, but that won't take any time.17:14
*** darraghb has quit IRC17:15
JoseSwiftQAYeah, Jay emailed me about it and had me un-abandon it17:15
davidkranzI saw an (unused) 'from unittest.case import SkipTest' in one of the newer test files that does not work with Python 2.6. It can be removed but are we trying to support 2.6?17:16
davidkranzThe other files use nose.SkipTest17:16
JoseSwiftQAcoolbeans, if i haven't cleaned it up I will.17:17
rohit-krather unittest2.skipTest?17:17
davidkranzrohit-k: Yes. It was aliased to unittest17:17
rohit-kok17:17
rohit-kmeaning we're standardised on the unittest implementation right?17:18
davidkranzrohit-k: Not sure what you mean. I was wondering whether we are requiring code to work with 2.6.17:19
davidkranzThe file was test_volumes_get.py17:19
*** garyk has joined #openstack-meeting17:19
rohit-kdavidkranz: oh ok17:19
davidkranzdwalleck: Daryl, you  put out two issues a little while ago. You want to start that?17:20
dwalleckSure17:20
dwalleckWhile doing code reviews the last few days, I've really noticed that's we're accomplishing the same task in different areas of the code17:21
*** dachary has quit IRC17:21
dwalleckFor example, how we expect exceptions and how we cleanup resources17:22
dwalleckFor clarity's sake, it would be nice if we were consistent17:22
dwalleckSo for example....for testing for asserts, we use try/except, assertRaises, and the expect exception decarator17:23
rohit-kdwalleck: For checking exceptions, how about using try: self.assertRaises() except: self.fail("failure message")17:23
dwalleckCould we just decide on one method and (unless circumstances deem it necessary) stick with that?17:23
rohit-k?17:23
dwalleckrohit-k: I don't follow. Why would we need a try/except around assertRaises?17:24
rohit-kdwalleck: that would allow one to throw a failure message with the failed status17:24
dwalleckrohit-k: You can add a failure message as an extra param...17:25
davidkranzI like assertRaises. It minimizes boilerplate code.17:25
dwalleckWe should really be doing that everywhere, it's just gotten away from us17:25
rohit-khmmm17:25
rohit-kdoes assertRaises accept a msg argument?17:26
*** GheRivero has joined #openstack-meeting17:27
dwalleckrohit-k: it should. That's the standard pattern for python unittest17:27
dwalleckI'm not sure why that assert would be different17:27
rohit-kAll the assert methods (except assertRaises(), assertRaisesRegexp()) accept a msg argument that, if specified, is used as the error message on failure (see also longMessage).17:27
rohit-khttp://docs.python.org/library/unittest.html#unittest.TestCase.assertRaises17:27
dwalleckHuh, I see that too...that's bizzare17:28
rohit-k yes17:28
dwalleckHmm....well they're odd. I'd vote for writing a util method to encapsulate the logic you just mentioned17:29
davidkranz++17:29
rohit-kdwalleck++17:29
dwalleckThat way we get all of the functionality and avoid any extra boilerplate code17:29
davidkranzWe could put it as a method in BaseComputeTest17:30
dwalleckdavidkranz: ++17:30
donaldngo_hpdoes this have to be specific to compute?17:31
rohit-kwhy BaseComputeTest? ideally it should be available to all api test17:31
rohit-ktests*17:31
*** mdomsch has quit IRC17:31
rohit-ktempest/utils.py17:31
donaldngo_hpshould be BaseTest17:31
dwalleckTrue, perhaps even a generic TempestTestCase class instead (that each base class can inherit from?)\17:31
davidkranzYeah, I guess there should really be another class above BaseComputeTest17:31
rohit-kwe don't have a TempestTestCase base class, that would call for changes in a lot of files17:32
rohit-kthought it's the right approach17:32
davidkranzThe only change would be in the inheritance clause and files would not have to be changed to use the new class until their code was changed to use the new method.17:33
rohit-kdavidkranz: true17:34
*** Ravikumar_hp has quit IRC17:34
davidkranzActually I think only a few files would be changed. The tests would still inherit from the same existing BaseComputeTest, etc.17:34
*** Ravikumar_hp has joined #openstack-meeting17:35
davidkranzSo I think we are in agreement that there should be a new class defining at least a wrapper for assertRaises and that we will use this new method for handling expected exceptions.17:36
rohit-k+117:36
dwalleck++17:37
davidkranzAbout resource allocation. I have advocated that resource-allocating methods keep track of the resources in their classes and have a method to clean them up.17:37
davidkranzThere would also be a keyword argument to the creation calls that would say not do do this in case the test needs to manually manage the resources for that test.17:38
dwalleckdavidkranz: I would have to see an implementation. I just want to make sure we're not doing too much behind the scenes magic17:39
rohit-kdavidkranz: that would help, for example, list servers and list images setUp 3 resources as a class Fixture17:39
*** GheRivero has quit IRC17:39
rohit-ksome test methods require no resoureces at all17:39
rohit-klike I want to check for a blank list17:39
*** mnewby has joined #openstack-meeting17:40
dwalleckThere already is an addCleanup method built into the unittest class17:40
davidkranzdwalleck: I agree. It is like garbage collection instead of malloc/free. You have to be careful with non-virtualized resources.17:40
rohit-kdwallkeck++ I love that method17:40
davidkranzdwalleck: I will make a proposal.17:41
rohit-kso tests can add their own cleanup logic to the tearDown() code17:41
*** mattray has joined #openstack-meeting17:41
JoseSwiftQAaddCleanup: http://docs.python.org/library/unittest.html#unittest.TestCase.addCleanup17:42
davidkranzNote this method is new in 2.7 so we really need to decide if we are supporting 2.6.17:43
dwalleckAhh...in that case, that might be an easy17:43
dwallecknix what I just said. That makes no sense. Haven't slept enough :)17:43
davidkranzI'm fine with dropping 2.6 but I don't think OpenStack as a whole seems ready to do that.17:44
dwalleckWhat I was trying to say is that perhaps we can do the same thing as we are doing for assertRaises. Having a default behavior for this in the base test class is also fine17:44
rohit-kI think nova's unit test framework does something similar17:45
rohit-khttps://github.com/openstack/nova/blob/master/nova/test.py#L14617:47
rohit-kdwalleck: we should be having a BaseTest class I think now17:47
dwalleck++. We just have to add a way to register resources and we're set17:48
rohit-kgoing forward with Jay's refactoring branch, it might be very useful17:48
rohit-kdavidkranz?17:50
rohit-kwhat do you think?17:51
*** mdomsch has joined #openstack-meeting17:51
davidkranzThat seems OK. We need to modify the resource creators.17:52
davidkranzMy thought was that the resources are accumulated in the client class because only it knows how to free them17:53
davidkranzThat is, the class with the allocation method is the one that knows how to free it.17:54
rohit-kdavidkranz: you mean add the resource cleanup code per client?17:55
davidkranzYes. Is there another way?17:55
rohit-knot sure why I would want to see cleanups in the client classes17:56
dwalleckdavidkranz: If we ever move back towards using objects instead of just raw json for entities in Tempest, an entity would know to delete itself (which would be clean)17:56
davidkranzdwalleck: True.17:57
rohit-kdwalleck++17:57
*** mattray has quit IRC17:57
davidkranzdwalleck: But the client would still have to collect the objects.17:58
*** Ravikumar_hp has quit IRC17:58
davidkranzI think we are about out of time.17:58
dwalleckby the way, first round of multiprocessor configs are up for review: https://review.openstack.org/#/c/7984/17:59
dwalleckWill be pushing them in batches throughout the week18:00
davidkranzdwalleck: How do you decide which classes need this attribute?18:00
dwalleckdavidkranz: every class does. The attribs tell the class how to execute when the multiprocess plugin is used18:01
dwalleckSome test classes may need to be refactored because they were not designed to be executed concurrently18:02
davidkranzOK, so you just changed the ones that didn't?18:02
dwalleckdavidkranz: Not yet. Every test class is going to need these vars. For the ones that obviously won't work as is, I've passed over them for now18:03
davidkranzdwalleck: OK.18:03
dwalleckDebugging these in smaller batches is far easier than configuring them all at the same time18:03
davidkranzSee you all next week. I guess no one officially started the meeting so there won't be a log.18:03
*** dwalleck has quit IRC18:04
rohit-kBye!18:04
*** rohit-k has quit IRC18:04
*** donaldngo_hp has quit IRC18:04
*** JoseSwiftQA has quit IRC18:05
*** jakedahn_zz is now known as jakedahn18:11
*** troytoman is now known as troytoman-away18:20
*** johnpostlethwait has joined #openstack-meeting18:22
*** bfcohen2 has joined #openstack-meeting18:24
*** dwcramer has joined #openstack-meeting18:32
*** huats has joined #openstack-meeting18:32
*** Mandell has joined #openstack-meeting18:37
*** adjohn has quit IRC18:37
*** sandywalsh has joined #openstack-meeting18:40
*** Ravikumar_hp has joined #openstack-meeting18:41
*** jakedahn is now known as jakedahn_zz18:46
*** GheRivero has joined #openstack-meeting19:01
*** Ravikumar_hp has quit IRC19:03
*** sandywalsh has quit IRC19:07
*** jakedahn_zz is now known as jakedahn19:10
*** sandywalsh has joined #openstack-meeting19:12
*** hggdh has quit IRC19:14
*** jakedahn is now known as jakedahn_zz19:15
*** hggdh has joined #openstack-meeting19:18
*** dolphm has quit IRC19:23
*** novas0x2a|laptop has joined #openstack-meeting19:25
*** mdomsch has quit IRC19:31
*** dwcramer has quit IRC19:35
*** dwcramer has joined #openstack-meeting19:53
*** n0ano has joined #openstack-meeting19:58
*** mdomsch has joined #openstack-meeting20:02
*** rnirmal has quit IRC20:02
n0anoanyone here for orchestration?20:05
*** dwcramer has quit IRC20:23
*** ttrifonov is now known as ttrifonov_zZzz20:25
*** n0ano has left #openstack-meeting20:25
*** mnaser has quit IRC20:27
*** ttrifonov_zZzz is now known as ttrifonov20:28
*** ttrifonov is now known as ttrifonov_zZzz20:29
*** dwcramer has joined #openstack-meeting20:36
*** jd___ has quit IRC20:41
*** jakedahn_zz is now known as jakedahn20:42
*** jd___ has joined #openstack-meeting20:42
*** dwcramer has quit IRC20:45
*** joearnold has quit IRC20:48
*** GheRivero has quit IRC20:50
*** dprince has quit IRC20:55
*** markvoelker has quit IRC21:00
*** tongli|2 has quit IRC21:06
*** dachary has joined #openstack-meeting21:12
*** sandywalsh has quit IRC21:18
*** ncode has joined #openstack-meeting21:19
*** mnaser has joined #openstack-meeting21:33
*** dachary has quit IRC21:37
*** ayoung has quit IRC22:03
*** Gordonz has quit IRC22:12
*** dwcramer has joined #openstack-meeting22:14
*** maoy has quit IRC22:17
*** nikhil__ has quit IRC22:21
*** dwcramer has quit IRC22:25
*** ywu has joined #openstack-meeting22:25
*** bfcohen2 has quit IRC22:30
*** dwcramer has joined #openstack-meeting22:36
*** ywu has quit IRC22:40
*** adjohn has joined #openstack-meeting22:40
*** dwcramer has quit IRC22:47
*** AlanClark has quit IRC22:49
*** joearnold has joined #openstack-meeting22:55
*** lloydde has quit IRC23:00
*** hggdh has quit IRC23:01
*** dtroyer is now known as dtroyer_zzz23:07
*** jakedahn is now known as jakedahn_zz23:09
*** blamar has quit IRC23:10
*** anderstj has joined #openstack-meeting23:21
*** edygarcia has quit IRC23:22
*** dwcramer has joined #openstack-meeting23:27
*** blamar has joined #openstack-meeting23:29
*** jgriffith is now known as jgriffith_away23:29
*** ozstacker has quit IRC23:46
*** ozstacker has joined #openstack-meeting23:46
*** jdurgin has quit IRC23:46
*** jdurgin has joined #openstack-meeting23:47
*** hggdh has joined #openstack-meeting23:55
*** johnpostlethwait has quit IRC23:56
*** jdurgin has quit IRC23:57
*** bfcohen has joined #openstack-meeting23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!