Wednesday, 2022-04-13

*** whoami-rajat__ is now known as whoami-rajat08:53
*** dviroel|out is now known as dviroel11:11
*** dasm|off is now known as dasm13:12
whoami-rajat#startmeeting cinder14:00
opendevmeetMeeting started Wed Apr 13 14:00:47 2022 UTC and is due to finish in 60 minutes.  The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'cinder'14:00
whoami-rajat#topic roll call14:00
simondodsleyhi14:00
enriquetasohi14:00
jungleboyjo/14:01
eharneyhi14:01
geguileohi! o/14:01
toskyhi14:02
whoami-rajatlet's wait a couple of minutes for other people to join14:02
nahimsouza[m]o/14:02
rosmaitao/14:02
andrebeltrami[m]o/14:03
whoami-rajatok, let's get started!14:04
whoami-rajatWelcome everyone to the first cinder meeting of Zed development cycle14:04
whoami-rajat#link https://etherpad.openstack.org/p/cinder-zed-meetings14:04
jungleboyj\o/14:04
whoami-rajatgood to see everyone here shortly after the PTG :)14:04
felipe_rodrigueso/14:04
whoami-rajatwe've a lot of announcements, so let's start14:04
whoami-rajat#topic announcements14:04
whoami-rajatfirst, Add IRC nick to courtesy reminder14:05
whoami-rajatI've already added the IRC nicks from the yoga meetings etherpad but if there are new people that would like to add their names, they can add it to the courtesy reminder list on the etherpad on L#3314:05
whoami-rajatI will remind about the meeting in the #openstack-cinder channel few minutes before the meeting starts here14:05
whoami-rajatso make sure, you've joined both the channels14:06
whoami-rajatmoving on14:06
whoami-rajatnext announcements, stable/victoria moving to EM14:06
whoami-rajatso there's a mail from Elod (release PTL) that stable/victoria will be moving to EM soon14:06
whoami-rajatstable/victoria is going to EM on 27th April, 2022, so if there are any patches you would like to get released with the last victoria release, start backporting them now14:06
whoami-rajat#link http://lists.openstack.org/pipermail/openstack-discuss/2022-April/028013.html14:07
whoami-rajatmore about this we will discuss in the next announcement14:07
whoami-rajatnext, Release liaison14:07
whoami-rajatso some of you might know, I've been managing the stable releases for the last 3-4 cycles but since now I've taken up the role of PTL, if anyone is interesting in doing stable releases, they can contact me or Brian and we can guide you through the process14:08
whoami-rajatIt has to be done every couple of months and if we have enough changes to release so not a big burden, and also you don't have to be a core reviewer to do it14:08
whoami-rajatThis glance doc is a good starting point for the role and responsibilities http://docs.qstack.com.cn/glance/latest/contributor/release-cpl.html14:09
whoami-rajatwe can think about adding this to our documentation as well14:09
whoami-rajatnext, Bug squad deputy14:10
whoami-rajatenriquetaso has been handling the bug triaging and reporting and she has been doing an excellent work!14:10
whoami-rajatIf she would like to continue, it would be great but also if she wants to move on from the responsibility, we can discuss if anyone else would like to take that role14:10
whoami-rajatfor now, i will leave the decision to enriquetaso14:11
enriquetasoi haven't though of that :P14:11
whoami-rajatnext, Release schedule14:11
whoami-rajatsure, you can take your time!14:11
whoami-rajatI've proposed the Zed release schedule, you can check the patch and html rendering on the etherpad14:12
whoami-rajat#link https://review.opendev.org/c/openstack/releases/+/83749414:12
whoami-rajat#link https://58140b717b0fd2108807-1424e0f18ed1d65bb7e7c00bb059b2d8.ssl.cf2.rackcdn.com/837494/1/check/openstack-tox-docs/6b018f1/docs/zed/schedule.html14:12
rosmaitathe only thing i noticed is that monday of the week of milestone 2 is a holiday in the USA14:12
rosmaitaor maybe not14:13
rosmaitathe lack of grid lines on the HTML schedule may be confusing me14:13
geguileoooooooh, ninja release then?14:13
whoami-rajatoh ok, but i guess we've time till friday for any deadline so only monday holiday should be fine?14:13
rosmaitai take it back, m-2 is week of 14 july14:13
jungleboyjRight, it is the week after the 4th of July.14:14
whoami-rajatalso Brian has a suggestion to include mid cycle events in the schedule which i think would be useful for us, I will add them and see if the release team complaints14:14
whoami-rajatgreat, no conflicts!14:14
jungleboyjThat is a great idea!14:14
geguileo+1 to include all events, mid cycle, ptg, everything14:15
whoami-rajatsounds good, i will add them14:15
whoami-rajatso check out the release schedule and add comments regarding date conflicts and if we should move things around14:15
whoami-rajatnext announcement, April Festival of XS Reviews rescheduled14:16
whoami-rajatso we've Good Friday holiday coming up this week for most of the people14:16
jungleboyj++14:16
whoami-rajatbut this is also the 3rd week of April i.e. Festival of XS reviews week14:16
whoami-rajatso we're planning to move it to next or next to next friday14:16
whoami-rajat(i was surprised to know we've 5 fridays in April)14:16
whoami-rajatthe best way to decide is to get the team votes in for it14:17
enriquetaso29th?14:17
enriquetaso+114:17
whoami-rajatLets vote for festival of XS reviews date14:17
whoami-rajatoptions are:14:17
whoami-rajatA 22nd April, 202214:17
whoami-rajatB 29th April, 202214:17
whoami-rajatC either one of the above14:17
whoami-rajatD need more options14:17
whoami-rajat#startvote time for the festival of XS reviews ? A, B, C, D14:17
opendevmeetBegin voting on: time for the festival of XS reviews ? Valid vote options are A, B, C, D.14:17
opendevmeetVote using '#vote OPTION'. Only your last vote counts.14:17
enriquetaso#vote C14:18
whoami-rajat#vote C14:18
rosmaita#vote C14:18
eharney#vote C14:18
sfernand#vote C14:19
jungleboyj#vote C14:19
whoami-rajatlet's wait 2 more minutes for everyone to get their votes in14:20
lucasmoliveira059#vote C14:20
geguileo#vote C14:20
ecsantos[m]#vote C14:20
rfluisa_#vote C14:21
rosmaitawhoami-rajat: looks like you will get to choose!14:21
whoami-rajatok, i guess we already have majority14:21
whoami-rajat#endvote14:21
opendevmeetVoted on "time for the festival of XS reviews ?" Results are14:21
opendevmeetC (10): geguileo, rosmaita, lucasmoliveira059, rfluisa_, whoami-rajat, sfernand, eharney, enriquetaso, ecsantos[m], jungleboyj14:21
whoami-rajatrosmaita, :D yeah, voting wasn't much helpful here14:22
rosmaitawell, at least we know everyone can make it, whichever day you pick14:22
whoami-rajatso i propose 29th April since we're still too close to PTG and people might not like attending another 2 hour meeting this early14:22
rosmaitaworks for me14:23
jungleboyjMakes sense.14:23
whoami-rajatrosmaita, yep, that helped14:23
whoami-rajatgreat, so 29th April it is14:23
whoami-rajatthat's all i had for announcements14:23
whoami-rajatlet's move on to topics14:23
whoami-rajat#topic Remove legacy oslo.db enginefacade14:23
whoami-rajatrosmaita, thats you14:23
rosmaitathanks!14:24
rosmaitaok, Stephen Finucane, a Hero of Cinder has proposed a bunch of patches14:24
rosmaitato update our session usage in the sqlachemy/api.py14:24
enriquetaso\o/14:25
rosmaitait helps in 2 ways14:25
rosmaitawe are using an oslo.db legacy enginefacade that the oslo project has deprecated way back and wants to remove14:25
rosmaitaand we may be the only ones left using it14:25
rosmaitaand, this change also helps us get ready for SQLAlechemy 2.014:25
rosmaitawhich is coming very soon14:26
rosmaitastephen broke this into a bunch of patches so each review isn't too big14:26
rosmaitaalso, the line of code count in gerrit is not very accurate because a large part of this is un-indenting python code14:26
rosmaitathe quick explanation of what the change is, is here:14:27
rosmaita#link https://docs.openstack.org/oslo.db/latest/reference/api/oslo_db.sqlalchemy.html#module-oslo_db.sqlalchemy.session14:27
rosmaitai put together a dashboard, but i don't know how useful it will be14:27
rosmaitai thought there were about 15 patches in the patch set14:27
rosmaitabut there are actually more like 3414:28
geguileo34!!!!14:28
rosmaitayes, it is almost a geguileo-sized set of patches!14:28
geguileoit's waaaaay beyond my longest patch series   lol14:28
rosmaitaactually, 34 is a bit excessive, even for geguileo14:28
rosmaita:D14:28
geguileotrue14:28
rosmaitayeah, so best thing is to start at the bottom, and get used to the pattern, and it gets easier as you go14:29
toskyso wait for the devstack fix to land, merge everything, wait for explosions and fix everything in the next weeks?14:29
rosmaitawhich devstack fix?14:29
whoami-rajatI think this makes sense as we're already long overdue for the alembic work which is complete but we need to get this in to safeguard our migrations against SQLAlchemy update14:29
rosmaitaok, my proposal is that we should not merge any DB changes before we get this set merged14:30
rosmaitabecause i really don't want to review this multiple times14:30
toskyrosmaita: devstack fix because devstack was broken by a git security fix (see openstack-discuss)14:31
rosmaitatosky: that's what i get for not reading my email this morning14:31
whoami-rajatI will take a look once I'm done with the PTG summary (it does take time to write)14:32
geguileofyi I have this patch that I need to update... https://review.opendev.org/c/openstack/cinder/+/81574614:32
rosmaitahere's the devstack bug link:14:32
rosmaita#link https://bugs.launchpad.net/devstack/+bug/196879814:32
geguileobecause we lost that with the alembic changes14:32
rosmaitathanks tosky14:33
toskygeguileo: should that be merged before or after merging the other patches? 14:34
rosmaitatosky: i was about to ask that14:34
geguileotosky: there are probably no conflicts between the 2 things14:34
geguileoand if there are, we should merge the others first14:35
geguileobecause resolving a merge conflict in a 34 patch series would kill our CI14:35
toskygeguileo: but could  it be used to check if the other patches introduce regressions?14:35
rosmaitai guess my question is, what is a good way to get these all reviewed?14:35
geguileotosky: not really, the check is for new features and changes to the actual DB model, which the new code should not be touching14:36
rosmaitai am committed to reviewing all of them, but i am insane14:36
whoami-rajati see geguileo has a series of patches where some may conflict with stephen's chain https://review.opendev.org/q/topic:die-quota-die-base14:37
geguileowhoami-rajat: those can wait14:37
geguileoSince I have to make additional changes14:38
geguileoI'll just rebase them on top of his 34 patches14:38
whoami-rajatok, so let's review stephen's patches as priority (at least as much as we can get in from them)14:38
whoami-rajatand other DB changes can be reviewed/merged later14:38
rosmaitalet's revisit this next week, if there's not a lot of review action, i will set up a spreadsheet or something and we can "volunteer" specific people to review subsets of patches14:39
whoami-rajatthat sounds like a good idea14:39
rosmaitathat's all from me, unless people think 1 week is too long to wait14:39
whoami-rajati guess they can review changes anyway!14:40
whoami-rajatso let's move on to next topic14:40
rosmaitayep14:40
whoami-rajat#topic Disable c-bak by default in CI jobs14:40
whoami-rajatrosmaita, that's you again14:40
rosmaita#link https://review.opendev.org/c/openstack/devstack/+/83763014:40
tosky(sorry) I thought it was disabled long ago, we explicitly enable it in a few cinder jobs14:41
rosmaitaapparently it's enabled by default in devstack14:41
rosmaitai guess as long as we have test coverage, it doesnt' need to be enabled by default?14:42
whoami-rajatthere's a comment by Dan saying it's causing OOM failures frequently in ceph multistore job (i assume that's in glance)14:42
rosmaitahas anyone had time to look at David Caro's patch: https://review.opendev.org/c/openstack/cinder/+/83452714:42
toskywell, they can also disable it in the specific jobs which shows resource issues14:43
eharneyrosmaita: i looked over it a bit, it makes sense conceptually14:43
rosmaitai don't have any more to say, just wanted people to be aware14:45
rosmaitaclarkb put a -W on the devstack patch14:46
whoami-rajatso should c-bak be disabled/enabled by default? what is our take on this14:46
eharneyby default in CI jobs, you mean14:46
rosmaitaright14:46
whoami-rajatyes14:46
toskywhoami-rajat: for the record, it was disabled some time ago14:46
toskyby default; I don't remember where and when it was reenabled, maybe when the signle integrated job was split into more integrated job (integrated-storage in our case)14:47
whoami-rajatok, i need to followup on the history of it then14:48
rosmaitawell, i'll leave a comment that we are looking at a possible fix14:48
eharneyi don't think it matters too much whether it's on in jobs by default, but it does mean we have to go make sure this doesn't reduce test coverage for us, or if we need to change our jobs14:48
whoami-rajateharney +114:48
rosmaitai think clark -W'd because the logs showed that somethign was using c-back14:48
rosmaitaok, thanks, we can see what happens14:49
rosmaitain the meantime, would be good to look at https://review.opendev.org/c/openstack/cinder/+/83452714:49
eharneyi'm not sure if the 834527 patch would even help if it's in Ceph jobs, would need to see what those are running exactly14:49
eharneyin general, if people are having OOM issues, we need bug reports14:50
rosmaitathat's a good point14:50
whoami-rajatrosmaita, so i guess we've enough points to hold the patch as of now until we accurately know if it's a good idea or not14:51
rosmaitasounds good to me14:51
whoami-rajatas eharney pointed out, it shouldn't reduce our test coverage14:51
whoami-rajatgreat14:51
whoami-rajatlet's move on to next topic then14:52
whoami-rajat#topic vote on NetApp proposal to backport ONTAP REST API support14:52
whoami-rajatso people who have attended the PTG on Thursday might be familiar with NetApp's proposal about changing their ZAPI calls to REST API calls14:52
whoami-rajattheir ask is to allow the change to be backported to the active stable branches14:53
geguileowhoami-rajat: I don't feel good voting for this without e0ne being present (major opposition to doing it)14:53
sfernandgeguileo: ++14:53
jungleboyj++14:53
whoami-rajatoh, i didn't notice, that's a good point by geguileo 14:53
sfernandI think we can recap today14:53
sfernandAnd do the votes next week14:54
rosmaitai'm on board with e0ne, i think14:54
whoami-rajatsfernand, that also sounds good, would you like to provide a summary of it?14:54
sfernandYes give me a minute to type14:54
jungleboyjMakes sense.14:54
whoami-rajatsure14:54
sfernandOk, so during the ptg we discussed the possibility of backporting our old xml based calls to rest, the reason for this is because zapis will be deprecated on 2023, which means customers wouldn’t be able to upgrade ontap arrays in any older version then zed (if me merge in zed)14:56
sfernandSo the debate was around if that should be considered a new feature14:57
sfernandOr a Bug we are trying to antecipate14:57
whoami-rajat#link https://etherpad.opendev.org/p/zed-ptg-cinder#L43114:57
sfernandSince it is going to directly affect rhosp deployments which currently relies on train..14:57
sfernandDuring the discussion we agreed that there is no chance for train14:58
sfernandBut that could be considered for the versions we still provide new releases14:58
sfernandLike yoga, xena, wallaby14:59
sfernandOur idea is to backport to the active stable branches and make it possible for rhosp 1714:59
simondodsleyThe next RHOSP release will be based on Wallaby so that would be the oldest version you would have to backport to (if allowed...)15:00
whoami-rajatthat's a good summary and people can also follow the PTG discussion and recording to get more familiar with it, netapp had a nice presentation as well15:00
whoami-rajatwe're out of time15:00
sfernandYep, and that would be enough since we could at least advice our customers to upgrade15:00
simondodsleyAlthough I believe RH have already frozen 17.015:00
whoami-rajatthe last topic is by ganso requesting reviews for his backports, so check them out on the etherpad15:01
whoami-rajatwe can continue discussion next week15:01
gansoyes please review15:01
whoami-rajatthanks all!15:01
whoami-rajat#endmeeting15:01
opendevmeetMeeting ended Wed Apr 13 15:01:47 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:01
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-04-13-14.00.html15:01
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-04-13-14.00.txt15:01
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-04-13-14.00.log.html15:01
*** dviroel is now known as dviroel|lunch15:28
*** dviroel|lunch is now known as dviroel16:35
*** dviroel is now known as dviroel|afk20:22
*** dasm is now known as dasm|off21:36

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!