| *** melwitt is now known as Guest5508 | 10:12 | |
| *** dviroel|out is now known as dviroel | 11:16 | |
| *** senrique__ is now known as enriquetaso | 13:36 | |
| rosmaita | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Nov 10 14:00:14 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| rosmaita | #topic roll call | 14:00 |
| whoami-rajat__ | Hi | 14:00 |
| fabiooliveira | o/ | 14:00 |
| shoffmann | hi | 14:00 |
| *** whoami-rajat__ is now known as whoami-rajat | 14:00 | |
| enriquetaso | hi | 14:00 |
| eharney | hi | 14:00 |
| sfernand | hi | 14:00 |
| walshh_ | hi | 14:00 |
| smore | hi | 14:00 |
| e0ne | hi | 14:01 |
| angiolucci | o/ | 14:01 |
| rosmaita | good turnout! | 14:01 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-yoga-meetings | 14:02 |
| rosmaita | ok, let's get started | 14:02 |
| LeoCampelo | o/ | 14:02 |
| rosmaita | this one isn't on the agenda, but Yoga Milestone 1 is next week | 14:02 |
| jungleboyj | o/ | 14:03 |
| rosmaita | after this meeting, there is another continuation of the secure RBAC goal for Yoga | 14:03 |
| rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-November/025666.html | 14:03 |
| rosmaita | if you are interested ^^ | 14:03 |
| rosmaita | we are having an impromptu Festival of RBD driver reviews tomorrow | 14:04 |
| rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-November/025683.html | 14:04 |
| rosmaita | it will work like the other review festival, that is, we'll "meet" in video but work separately doing reviews | 14:04 |
| rosmaita | using the video to ask questions or tell people something was just +2d and could use another look | 14:05 |
| rosmaita | i am trying out google hangouts, which i became aware yesterday may not work for everyone | 14:05 |
| rosmaita | so, you can always join and just open the etherpad and ask questions that way | 14:05 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-festival-of-driver-reviews | 14:06 |
| rosmaita | ok, final thing i want to mention is that there's been a discussion on the ML about release cadence | 14:06 |
| rosmaita | that is, should we continue to release openstack every 6 months, or try something else | 14:07 |
| rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-November/025684.html | 14:07 |
| rosmaita | that's the start of the thread ^^ | 14:07 |
| rosmaita | so if you are interested in such stuff and/or have an opinion, you may want to get in on the action | 14:07 |
| rosmaita | ok, i mentioned earlier that M-1 is next week | 14:08 |
| rosmaita | a key priority for early in the cycle is to get the sqlalchemy-migrate -> alembic work done | 14:09 |
| rosmaita | #link https://review.opendev.org/q/topic:%2522bp/remove-sqlalchemy-migrate%2522+(status:open+OR+status:merged)+project:openstack/cinder | 14:09 |
| rosmaita | so that is what i am going to be mostly reviewing over the next few days | 14:09 |
| rosmaita | of course, others need to review also | 14:09 |
| enriquetaso | sure, i'll review as well | 14:10 |
| rosmaita | but my point is, asking for reviews of anything other than critical bugs is unlikely to result in action | 14:10 |
| rosmaita | thanks enriquetaso! | 14:10 |
| rosmaita | that's it from me, is there anything else going on that the team should be aware of? | 14:10 |
| rosmaita | i know several people have had recent holidays in various locations, so welcome back and i hope you are refreshed! | 14:11 |
| rosmaita | ok, looks like everything has been announced ... moving on | 14:12 |
| rosmaita | #topic Reviews need for NVMe multipathing spec | 14:12 |
| rosmaita | quick comment before you get started simondodsley | 14:13 |
| rosmaita | this is for everyone putting up specs | 14:13 |
| rosmaita | we write them in restructured text/sphinx, but end users will read them in HTML | 14:13 |
| eharney | fg | 14:13 |
| rosmaita | so it's important that they render in a way that makes sense | 14:13 |
| eharney | (wrong window, sorry) | 14:13 |
| rosmaita | :) | 14:13 |
| rosmaita | you can check this yourself when putting together the spec by using your tox environment to build the docs and then open your spec in a browser | 14:14 |
| whoami-rajat | running tox -edocs and checking the rendered html file is a good practice before pushing patch ^^ | 14:14 |
| jungleboyj | ++ | 14:15 |
| rosmaita | or, if you are reviewing, the zuul job builds the html and you can look at it there | 14:15 |
| rosmaita | it's a little hard to find, so here are directions | 14:16 |
| rosmaita | take this patch for example: https://review.opendev.org/c/openstack/governance/+/815158 | 14:16 |
| rosmaita | go to the "Zuul Summary" tab | 14:16 |
| rosmaita | click on "openstack-tox-docs" | 14:16 |
| rosmaita | there you will see an "Artifacts" tab ... click it | 14:16 |
| rosmaita | last item in the list is "Docs preview site" ... click it | 14:17 |
| enriquetaso | cool | 14:17 |
| rosmaita | then you need to know how to find your doc ... this example is a community goal, so you will scroll to community goals, find accepted, find yoga | 14:17 |
| rosmaita | for our specs, it's much easier because they're all basically listed on the first page that opens | 14:18 |
| rosmaita | anyway, same process can be used when you are reviewing a docs change or a release note | 14:18 |
| whoami-rajat | I usually go to View log -> docs but good to know the alternative | 14:19 |
| rosmaita | and if you are really stuck with some weird formatting that you can't fix, you can ask in the cinder channel, someone may be able to help | 14:19 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder-specs/+/815613 | 14:20 |
| rosmaita | my other point is that reviewers tend to ignore patches that have -1 from zuul | 14:20 |
| rosmaita | so it's kind of important to make sure your spec is getting a +1 if you want some review action | 14:21 |
| rosmaita | ok, that's it from me ... i think simondodsley's point is that that spec is available and can use some reviews | 14:21 |
| rosmaita | :) | 14:21 |
| rosmaita | spec freeze is R-15 | 14:21 |
| rosmaita | (this week is R-20) | 14:22 |
| rosmaita | ok, guess there's no more to say about that one | 14:24 |
| rosmaita | #topic Pure driver patch reviews needed | 14:24 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/817085 | 14:24 |
| rosmaita | looks like a code simplification based on backend capabilities | 14:25 |
| rosmaita | anyway, i left a question on the patch | 14:25 |
| rosmaita | ok, big topic for this week | 14:25 |
| rosmaita | #link ussuri final release | 14:26 |
| rosmaita | whoami-rajat: you have the floor | 14:26 |
| whoami-rajat | hi | 14:26 |
| whoami-rajat | so we've the final ussuri release targeted for 12th Nov | 14:26 |
| whoami-rajat | and an etherpad to keep track of patches that needs to get in it | 14:26 |
| whoami-rajat | #link https://etherpad.opendev.org/p/ussuri-final-release | 14:26 |
| whoami-rajat | but looks like 2 of the os-brick patches haven't even merged in master yet | 14:27 |
| whoami-rajat | I wanted to know if we have an option to delay the release since they look important or just release with whatever we have merged? | 14:27 |
| whoami-rajat | The ML has this line which i guess implies for whole openstack so not sure if we can change release date for cinder specifically "In a month Ussuri is planned to transition to Extended Maintenance phase | 14:28 |
| whoami-rajat | [1] (planned date: 2021-11-12)." | 14:28 |
| rosmaita | let's discuss whether the 2 brick patches need to get into a release | 14:28 |
| rosmaita | 1. NVMe multipath enabled kernels | 14:29 |
| rosmaita | we haven't had that functionality, so i am not sure that it needs to be released in ussuri | 14:29 |
| rosmaita | it would be good to hear from NVMe users/deployers, however, if anyone is here | 14:29 |
| rosmaita | anyone know who put it on the etherpad? that color is 'unamed' | 14:31 |
| whoami-rajat | maybe Zohar did since he's the author but not sure | 14:31 |
| rosmaita | good reminder ... please "sign in" to an etherpad when you leave comments so we know it's you | 14:31 |
| rosmaita | could be | 14:32 |
| rosmaita | i think the nvme connector in ussuri can remain as good as it has always been in ussuri, then | 14:32 |
| jungleboyj | ++ | 14:32 |
| rosmaita | ok, so that one is not needed | 14:32 |
| rosmaita | the file locks, though, i think is kind of important | 14:32 |
| simondodsley | Here now. Got delayed | 14:33 |
| eharney | yes, would be good to get that one in | 14:33 |
| rosmaita | doesn't show up in our test environments, but looks like it cna be a problem for a not uncommon deployment configuration | 14:33 |
| rosmaita | ok, my -1 on that has to do with documenting the lock path in the release note, so should be pretty easy to address (or talk me out of) | 14:34 |
| whoami-rajat | possible in a scenario where 2 volumes from 2 different cinder backend are going through attachment related operation | 14:34 |
| rosmaita | ok, so let's get "Use file locks in connectors" into the release | 14:35 |
| rosmaita | i think the code and tests are fine on that one, i need someone to look at my comment about the release note | 14:36 |
| rosmaita | gorka has been on away, i don't think he will mind someone revising the release note for him | 14:36 |
| rosmaita | ok, so that's brick | 14:37 |
| rosmaita | cinderclient patch has merged | 14:37 |
| rosmaita | cinderlib doesn't have anything open | 14:37 |
| jungleboyj | rosmaita: Do you want to update the release note then and we can help get it merged? | 14:37 |
| rosmaita | i can, but what i'm looking for is some assurance that my comment there is correct | 14:38 |
| rosmaita | :) | 14:38 |
| rosmaita | while people are looking, there are 2 items for cinder | 14:38 |
| rosmaita | first one is "Add libcgroup related packages in bindep.txt" | 14:39 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/815883 | 14:39 |
| rosmaita | not sure why that is a WIP | 14:39 |
| rosmaita | it's kind of a nice-to-have, but people have gotten along without it, so i guess it's not essential | 14:40 |
| eharney | qemu-img is in there? need to refresh myself on this... | 14:40 |
| eharney | oh. bad cherry-pick | 14:40 |
| rosmaita | the other one fixes a regression in the rbd driver | 14:40 |
| rosmaita | eharney: ok, that explains it | 14:41 |
| enriquetaso | the cherry picked everything.. even the qemu-img | 14:41 |
| rosmaita | is anyone motivated enough to correct that patch, or should we just let it go? | 14:42 |
| whoami-rajat | rosmaita, I'm not sure if we should pass the lock_path via os-brick (in code along with external=True) or use the configured one in cinder/nova/glance using os-brick | 14:42 |
| enriquetaso | can correct the patch and resubmit | 14:44 |
| rosmaita | whoami-rajat: i think we want to use the configured one for the service that is doing the attaching? | 14:45 |
| rosmaita | ok, so for cinder, enriquetaso is going to fix the c-p for the bindep.txt change | 14:47 |
| rosmaita | the rbd one i think is uncontroversial, it's in the victoria gate now | 14:47 |
| rosmaita | so this brings us to whoami-rajat's question about when we release | 14:47 |
| rosmaita | i think we can do it when we are ready ... i don't see any release patches proposed for ussuri-em yet | 14:48 |
| whoami-rajat | rosmaita, yeah, makes sense since os-brick isn't aware about the deployment tool/distro so won't be able to tell correct path for the locks | 14:48 |
| rosmaita | ok | 14:48 |
| whoami-rajat | rosmaita, should we ask release team regarding the same? just to be sure | 14:49 |
| rosmaita | yeah, that's a good idea | 14:49 |
| rosmaita | https://review.opendev.org/q/project:openstack/releases+status:open | 14:49 |
| whoami-rajat | ack, i will ask Elod since he sent out the mail for ussuri EM | 14:49 |
| rosmaita | looks like a few projects have proposed patches, but i don't see the generate ones yet | 14:50 |
| rosmaita | whoami-rajat: thanks ... tell him that we have a specific list of what we need to get in there, so it's not like it will drag on forever | 14:50 |
| rosmaita | we just need probably one more week | 14:50 |
| whoami-rajat | ack, will do, thanks for the feedback | 14:51 |
| rosmaita | ok, looking good for ussuri final release (more or less) | 14:51 |
| rosmaita | #topic volume driver API | 14:51 |
| rosmaita | need a solidfire driver maintainer to vote on https://review.opendev.org/c/openstack/cinder/+/814898 | 14:52 |
| rosmaita | that's because we are removing a pair of functions that no other drivers used | 14:52 |
| rosmaita | i'd like an ack on the patch since it will leave stale metadata in the backend (possibly) | 14:52 |
| rosmaita | the other patch has to do with merging 2 functions into a single call | 14:53 |
| rosmaita | it touches a bunch of drivers | 14:53 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/815659 | 14:53 |
| rosmaita | i'm not going to hold the patch for acks from everyone, but i would like to at least have a few | 14:54 |
| rosmaita | also, gorka did some minor refactoring as he was fixing tests | 14:54 |
| rosmaita | some good test patterns that you should be aware of | 14:54 |
| rosmaita | so that's all for the volume driver API ... hopefully we can get the reviews completed and merged before next meeting, and then start on another function | 14:55 |
| rosmaita | actually one other patch to look at: | 14:55 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/815660/ | 14:55 |
| rosmaita | that changes the documentation for some functions | 14:55 |
| rosmaita | i have a formatting quibble | 14:56 |
| rosmaita | but it would be good to get feedback on that, because it will be the template on how we'll be documenting these from now on | 14:56 |
| rosmaita | so act now if you want your opinion taken into account | 14:56 |
| rosmaita | #topic mypy patch of the week | 14:57 |
| rosmaita | i am happy to announce that last week's patch is merged | 14:57 |
| rosmaita | along with a bonus mypy patch | 14:57 |
| jungleboyj | \o/ | 14:57 |
| rosmaita | so we are moving right along! | 14:57 |
| rosmaita | this week's patch: | 14:57 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/733622 | 14:57 |
| eharney | yay | 14:58 |
| rosmaita | i need 2 core and on non-core volunteer to look this one over | 14:58 |
| rosmaita | i am willing to be 1 core, but i don't want to hog all the glory here | 14:58 |
| whoami-rajat | i can take a look | 14:58 |
| fabiooliveira | i could take a look also | 14:59 |
| rosmaita | great! ty | 14:59 |
| rosmaita | ok, i guess i will be the other core while i am in a mypy state of mind | 15:00 |
| rosmaita | all right, we are out of time | 15:00 |
| rosmaita | thanks everyone, and don't forget the RBD Festival of Reviews tomorrow | 15:00 |
| rosmaita | #endmeeting | 15:00 |
| opendevmeet | Meeting ended Wed Nov 10 15:00:57 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-11-10-14.00.html | 15:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-11-10-14.00.txt | 15:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-11-10-14.00.log.html | 15:00 |
| *** dviroel is now known as dviroel|out | 21:15 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!