| *** qwebirc89791 is now known as akawai | 04:57 | |
| *** jbadiapa is now known as jbadiapa|afk | 10:48 | |
| *** jbadiapa|afk is now known as jbadiapa | 12:35 | |
| rosmaita | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Jun 16 14:00:05 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| sfernand | hi | 14:00 |
| rosmaita | #topic roll call | 14:00 |
| rosmaita | (#topic doesn't work, but i will use it anyway) | 14:00 |
| eharney | hi | 14:00 |
| walshh_ | hi | 14:00 |
| e0ne | hi | 14:00 |
| enriquetaso | hi | 14:01 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-xena-meetings | 14:01 |
| rosmaita | ok, that doesn't work either | 14:01 |
| tbarron | hi | 14:01 |
| rosmaita | a lot on the agenda today, so let's get started | 14:02 |
| rosmaita | #topic announcements | 14:02 |
| rosmaita | cinder-tempest-plugin-lvm-lio-barbican job is failing because sqlalchemy 1.4 broke barbican's alembic migration | 14:02 |
| rosmaita | this is now fixed, courtesy of geguileo | 14:03 |
| rosmaita | https://review.opendev.org/c/openstack/barbican/+/796284/ | 14:03 |
| rosmaita | barbican isn't currently included in the requirements check job | 14:03 |
| rosmaita | https://review.opendev.org/c/openstack/requirements/+/796647 | 14:03 |
| rosmaita | ^^ proposes a barbican crosscheck job | 14:04 |
| rosmaita | are there any other projects we depend on that should be checked? | 14:04 |
| jungleboyj | o/ | 14:04 |
| * jungleboyj sneaks in late | 14:04 | |
| geguileo | rosmaita: I don't think that would have detected this issue | 14:04 |
| geguileo | rosmaita: isn't that the unit tests? | 14:05 |
| rosmaita | geguileo: it would have caught the ut failures you fixed | 14:05 |
| rosmaita | not the migration, though | 14:05 |
| geguileo | rosmaita: which was the one that blocked our gate | 14:05 |
| geguileo | they need something like our cinder/tests/unit/db/test_migrations.py | 14:06 |
| rosmaita | we can suggest that, but the barbican team seems to be under staffed these days | 14:07 |
| geguileo | good to know :-( | 14:08 |
| rosmaita | also, i noticed that the nova functional tests are run | 14:08 |
| rosmaita | could add ours, not sure how much that would help detect problems | 14:08 |
| rosmaita | we should keep this in mind for the next time sqlalchemy is updated to 1.5 or 2.0 | 14:09 |
| rosmaita | next item: vulnerability:managed tag accepted for os-brick | 14:10 |
| rosmaita | which doesn't really change anything because we all thought it was already managed | 14:10 |
| rosmaita | next item: request from jungleboyj | 14:10 |
| rosmaita | Help me vote for the Y release name: https://twitter.com/jungleboyj/status/1404464680349929474 | 14:11 |
| rosmaita | jungleboyj: when is the deadline for that? | 14:11 |
| jungleboyj | Yes. :-) Just a note that I have a naming poll out there for the Y release. Have had good participation. | 14:11 |
| jungleboyj | I need to submit by vote today, so, if you want to help me pick the name. Please vote. | 14:11 |
| rosmaita | my personal favorite is "You" | 14:12 |
| rosmaita | so that no one will know what release you are talking about | 14:12 |
| * jungleboyj isn't surprised | 14:12 | |
| rosmaita | next item: reminder about festival of reviews on Friday | 14:12 |
| eharney | Yoghurt but no Yogurt? i dunno... | 14:12 |
| jungleboyj | Enter the Chaos Monkey | 14:12 |
| rosmaita | info here: http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023100.html | 14:12 |
| rosmaita | friday is a holiday in some locations, but not enough to reschedule | 14:13 |
| rosmaita | at least that's my impression? | 14:13 |
| rosmaita | hearing nothing to the contrary, next item: | 14:14 |
| rosmaita | cinder-coresec: need comments on https://bugs.launchpad.net/bugs/1929223 before 23:59 UTC on Friday | 14:14 |
| rosmaita | so please comment at your earliest convenience | 14:14 |
| rosmaita | finally, reminder that the spec freeze is next friday | 14:14 |
| rosmaita | so we need to review specs in a responsive manner, that is, right away | 14:15 |
| rosmaita | #link https://review.opendev.org/q/project:openstack%252Fcinder-specs+status:open | 14:15 |
| rosmaita | that's it for announcements, unless someone else has something to share? | 14:16 |
| rosmaita | ok, moving on | 14:16 |
| rosmaita | #topic Two cinder patches blocking glance feature | 14:17 |
| rosmaita | whoami-rajat: that's you | 14:17 |
| rosmaita | not sure whoami-rajat is around | 14:18 |
| rosmaita | but he left enough info in the agenda | 14:18 |
| rosmaita | he's been working on hardening the glance_store cinder driver | 14:18 |
| rosmaita | and found a cinder issue that needs to be addressed | 14:18 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/783389 | 14:18 |
| rosmaita | i think ^^ is fine and corrects a mistake when the validation schema stuff was added to cinder | 14:19 |
| rosmaita | see my comment on the patch | 14:19 |
| rosmaita | the other one is a cinderclient change | 14:19 |
| rosmaita | #link https://review.opendev.org/c/openstack/python-cinderclient/+/783628 | 14:19 |
| rosmaita | i think that one addresses a similar problem in the cinderclient, that is, it is requiring an optional parameter | 14:20 |
| rosmaita | anyway, please review so rajat can get that glance_store patch out of his life, which will allow him to concentrate on cinder | 14:21 |
| eharney | makes sense | 14:21 |
| rosmaita | ok, next topic is a big one | 14:21 |
| rosmaita | #topic some concerns about the frequency of Cinder failures in the gate | 14:21 |
| rosmaita | jungleboyj is getting pressure from other members of the TC | 14:21 |
| rosmaita | and in turn, is passing some pressure onto us | 14:21 |
| jungleboyj | :-) Yes. | 14:22 |
| eharney | is there anything going on here other than the known issues with LVM crashing? | 14:22 |
| jungleboyj | Based on the discussion yesterday it appears that that is the likely cause for concern. | 14:22 |
| rosmaita | eharney: it's hard to tell | 14:22 |
| whoami-rajat | rosmaita: sorry was afk, thanks for covering it | 14:22 |
| jungleboyj | But it is hard to tell. | 14:22 |
| eharney | well it should be easy to quantify the LVM issues with elastic-recheck, has anyone tried that? | 14:22 |
| rosmaita | eharney: "should be" and "no" | 14:23 |
| enriquetaso | LVM issues is https://bugs.launchpad.net/cinder/+bug/1901783/ ? | 14:23 |
| eharney | yes but it fails on more operations than just volume delete | 14:24 |
| rosmaita | short-term, i would like to propose no more naked rechecks | 14:24 |
| jungleboyj | rosmaita: ++ | 14:24 |
| rosmaita | for one thing, the first two items i looked at weren't cinder's fault | 14:24 |
| jungleboyj | We should also work on getting the LVM crashes fixed. | 14:26 |
| rosmaita | yes, i agree | 14:26 |
| jungleboyj | And fix the barbican issues. | 14:26 |
| eharney | we know how to work around them in a messy way, i think we don't have a way to properly fix them | 14:26 |
| eharney | the barbican issues are already fixed AFAIK | 14:26 |
| rosmaita | anyway, short term i propose that when you issuue a recheck, do this: | 14:26 |
| rosmaita | recheck <job> <failed test name> | 14:26 |
| rosmaita | and maybe some info about the failure if relevant | 14:27 |
| rosmaita | and you can add info here: | 14:27 |
| rosmaita | https://etherpad.opendev.org/p/cinder-xena-ci-tracking | 14:27 |
| rosmaita | but if someone has time to set up an elasticsearch query to automate this, that would be better | 14:27 |
| rosmaita | but short term it would be good to get some quick data about what is going on | 14:27 |
| rosmaita | i thought that most of the failures are in teardown, and not related to actual tests, but i am not sure whether that's true or not | 14:28 |
| rosmaita | any questions about our short term data collection? | 14:29 |
| whoami-rajat | from personal standpoint, gates were passing consistently before this barbican issue and now also it's working, maybe failure is more often seen in other project gates | 14:30 |
| jungleboyj | And the teardown failures are often due to volumes being left around due to something like the LVM crash. | 14:30 |
| jungleboyj | whoami-rajat: That is a concern. | 14:30 |
| rosmaita | well, i think it's mostly in tempest-integrated-storage | 14:31 |
| rosmaita | so nova, glance, and cinder | 14:31 |
| *** geguileo is now known as Guest2396 | 14:32 | |
| rosmaita | anyway, no more naked rechecks ... at least pretend you care | 14:33 |
| rosmaita | and i guess, review the lvm patches | 14:33 |
| eharney | i think we still need to write more lvm patches | 14:33 |
| eharney | lvdisplay is not covered, not sure what else | 14:33 |
| Guest2396 | rosmaita: could we somehow keep that kind of info in the cinder wiki or something? | 14:36 |
| rosmaita | Guest2396: which kind of info? | 14:36 |
| *** Guest2396 is now known as geguileo | 14:36 | |
| rosmaita | btw, everyone keep an eye on https://review.opendev.org/c/openstack/cinder/+/772126 (it's in recheck now) | 14:36 |
| geguileo | rosmaita: the etherpad link for ci trakcing, and the recheck job failedtestname thingy | 14:36 |
| eharney | 722126 doesn't fix the crash (which was the initial hope) | 14:37 |
| rosmaita | geguileo: glad you asked, i think i want to put it into the channel topic | 14:37 |
| rosmaita | and the wiki, that is a good idea | 14:37 |
| geguileo | rosmaita: having the etherpads we are currently using in the wiki could be useful | 14:37 |
| geguileo | (for those of us with fish memory) | 14:37 |
| rosmaita | #action rosmaita check with opendev team about getting topic changed | 14:38 |
| rosmaita | #action rosmaita add current etherpads to wiki | 14:38 |
| eharney | 722126 needs a follow-up to retry on crash | 14:38 |
| rosmaita | geguileo: there's also the spotlight links on the meeting agenda | 14:38 |
| jungleboyj | rosmaita: We used to have that list in the Wiki. Needs to be updated. | 14:39 |
| rosmaita | eharney: what's the best way to track these? use https://launchpad.net/bugs/1901783 or other bugs? | 14:40 |
| rosmaita | jungleboyj: noted | 14:40 |
| rosmaita | #action rosmaita publicize the ci-tracking effort in all available methods | 14:40 |
| eharney | we should probably write a new bug for retrying all of the other lvm commands that can segfault that weren't covered by 1901783, since that bug already has backports spanning a few branches | 14:41 |
| enriquetaso | i can help with that eharney | 14:41 |
| rosmaita | ok, let's discuss that during the upcoming bug squad meeting | 14:41 |
| enriquetaso | sure | 14:41 |
| eharney | ok | 14:41 |
| rosmaita | ok, sounds like we have some strategy to address our CI problems | 14:42 |
| rosmaita | #topic Community goal proposal: Test with TLS (formerly SSL) by Default | 14:42 |
| rosmaita | enriquetaso: that's you | 14:42 |
| enriquetaso | Hello, just a quick question around TLS. As this is sort of a community-goal and I'm not familiar with TLS, I wonder if enabling TLS is a problem for us? | 14:43 |
| enriquetaso | Or should we priority this XS review? maybe for our XS meeting next friday. | 14:43 |
| rosmaita | well, the review will not pass | 14:43 |
| * enriquetaso reading brian's comments on the etherpad | 14:43 | |
| rosmaita | yeah, i looked into this a bit yesterday | 14:43 |
| rosmaita | not sure how big a deal it is if CI can't reliably use TLS for this one test job | 14:44 |
| rosmaita | my impression is that there's something going on in the botocore library | 14:45 |
| rosmaita | since 2014 | 14:45 |
| enriquetaso | oops | 14:45 |
| enriquetaso | OK | 14:45 |
| tosky | I see a reference to an aws-cli issue, but is it relevant for that different S3 implementation? | 14:45 |
| rosmaita | tosky: i don't know, you wouldn't think so | 14:45 |
| rosmaita | but i think the cli also uses botocore | 14:45 |
| rosmaita | it's weird that we would also see it in a fake s3 implementation | 14:46 |
| tosky | alternative, not fake :) | 14:46 |
| rosmaita | well, apparently it is so close to the original that it is causing the same problem | 14:47 |
| rosmaita | :) | 14:47 |
| rosmaita | i guess at this point, i can leave a comment on ricolin's etherpad about this and send a note to the ML for anyone interested in the s3 backup service to please take a look? | 14:48 |
| enriquetaso | +1 | 14:48 |
| rosmaita | i guess file a bug as well if there isn't one already for this | 14:48 |
| enriquetaso | #action(enriquetaso): reply to ricolin's and fill a bug | 14:48 |
| rosmaita | enriquetaso: thanks! | 14:49 |
| rosmaita | ok, next topic | 14:49 |
| rosmaita | #topic Finishing up snapshotting in-use volumes spec | 14:49 |
| rosmaita | eharney: that's you | 14:49 |
| eharney | geguileo found one complication i needed to cover here, wanted to make sure people were generally on-board as we get close to the specs deadline | 14:50 |
| eharney | my initial spec left out what should happen for people who are, for whatever reason, passing force=False as a parameter to snapshot create | 14:50 |
| eharney | since i'm not sure those people exist, i'm leaning toward just not allowing that going forward, as part of this change | 14:51 |
| geguileo | eharney: not allowing the force parameter in general, or just the force=false? | 14:51 |
| eharney | hrm | 14:51 |
| eharney | the spec at the moment says the latter, but you have me wondering if we should do the former now | 14:52 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder-specs/+/781914 | 14:53 |
| eharney | i outlined some of the options (apparently not including that one) in comments on the previous patchset version | 14:54 |
| eharney | rosmaita: right, thanks | 14:54 |
| rosmaita | what's the use case for force=false ? just to remind yourself that the volume is attached? | 14:55 |
| eharney | i'm not sure there is a very good use case for it | 14:55 |
| eharney | it's more just that you could do it.. | 14:55 |
| eharney | geguileo: thoughts? | 14:56 |
| geguileo | rosmaita: the case is where you have code and you are unconditionally passing the parameter, but use a variable to pass it to true or false | 14:57 |
| geguileo | eharney: I like the removal of the force parameter | 14:57 |
| geguileo | but failing on force=false is probably less code | 14:57 |
| eharney | the downside of just removing it altogether is that it's more of a hurdle for people who had just added force=True (which would be the common case) | 14:57 |
| geguileo | yeah, that's a big one | 14:57 |
| geguileo | they may be using the highest microversion and just passing it like you say | 14:58 |
| geguileo | that's a big reason for accepting it | 14:58 |
| rosmaita | ok, we are about out of time ... let's discuss on the spec | 14:58 |
| rosmaita | thanks everyone, join the bug squad meeting in #openstack-cinder | 15:00 |
| rosmaita | #endmeeting | 15:00 |
| opendevmeet | Meeting ended Wed Jun 16 15:00:22 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-06-16-14.00.html | 15:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-06-16-14.00.txt | 15:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-06-16-14.00.log.html | 15:00 |
| *** ricolin_ is now known as ricolin | 17:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!