| *** tosky has quit IRC | 00:00 | |
| *** jinyuanliu has quit IRC | 00:03 | |
| *** jinyuanliu has joined #openstack-meeting-alt | 00:03 | |
| *** felipe_rodrigues has quit IRC | 00:14 | |
| *** jhouser has quit IRC | 00:50 | |
| *** sfernand has quit IRC | 00:56 | |
| *** macz_ has quit IRC | 01:11 | |
| *** macz_ has joined #openstack-meeting-alt | 01:26 | |
| *** macz_ has quit IRC | 01:31 | |
| *** tmazur has quit IRC | 01:39 | |
| *** rratnaka has joined #openstack-meeting-alt | 01:47 | |
| *** ricolin_ has joined #openstack-meeting-alt | 01:55 | |
| *** rcernin has quit IRC | 02:06 | |
| *** macz_ has joined #openstack-meeting-alt | 02:07 | |
| *** ricolin_ has quit IRC | 02:09 | |
| *** macz_ has quit IRC | 02:11 | |
| *** zzzeek has quit IRC | 02:23 | |
| *** zzzeek has joined #openstack-meeting-alt | 02:24 | |
| *** rcernin has joined #openstack-meeting-alt | 02:38 | |
| *** zzzeek has quit IRC | 02:44 | |
| *** zzzeek has joined #openstack-meeting-alt | 02:46 | |
| *** zzzeek has quit IRC | 02:51 | |
| *** zzzeek has joined #openstack-meeting-alt | 02:53 | |
| *** zzzeek has quit IRC | 03:13 | |
| *** zzzeek has joined #openstack-meeting-alt | 03:15 | |
| *** SpamapS has quit IRC | 03:47 | |
| *** SpamapS has joined #openstack-meeting-alt | 03:51 | |
| *** whoami-rajat has joined #openstack-meeting-alt | 04:18 | |
| *** dviroel has quit IRC | 04:45 | |
| *** gyee has quit IRC | 05:20 | |
| *** macz_ has joined #openstack-meeting-alt | 05:27 | |
| *** macz_ has quit IRC | 05:32 | |
| *** ajitha has joined #openstack-meeting-alt | 05:35 | |
| *** enriquetaso has quit IRC | 05:59 | |
| *** ralonsoh has joined #openstack-meeting-alt | 06:01 | |
| *** jinyuanliu has quit IRC | 06:20 | |
| *** jinyuanliu has joined #openstack-meeting-alt | 06:20 | |
| *** subbareddy has quit IRC | 06:50 | |
| *** rratnaka has quit IRC | 06:50 | |
| *** rratnaka has joined #openstack-meeting-alt | 06:58 | |
| *** macz_ has joined #openstack-meeting-alt | 07:08 | |
| *** slaweq has joined #openstack-meeting-alt | 07:12 | |
| *** macz_ has quit IRC | 07:13 | |
| *** lpetrut has joined #openstack-meeting-alt | 07:19 | |
| *** slaweq has quit IRC | 07:19 | |
| *** rcernin has quit IRC | 07:22 | |
| *** slaweq has joined #openstack-meeting-alt | 07:23 | |
| *** macz_ has joined #openstack-meeting-alt | 07:24 | |
| *** macz_ has quit IRC | 07:29 | |
| *** rratnaka has quit IRC | 07:42 | |
| *** rratnaka has joined #openstack-meeting-alt | 07:50 | |
| *** rcernin has joined #openstack-meeting-alt | 07:52 | |
| *** rratnaka has quit IRC | 08:01 | |
| *** tosky has joined #openstack-meeting-alt | 08:38 | |
| *** macz_ has joined #openstack-meeting-alt | 08:58 | |
| *** macz_ has quit IRC | 09:03 | |
| *** e0ne has joined #openstack-meeting-alt | 09:30 | |
| *** macz_ has joined #openstack-meeting-alt | 09:46 | |
| *** macz_ has quit IRC | 09:51 | |
| *** lpetrut_ has joined #openstack-meeting-alt | 09:54 | |
| *** rdopiera has joined #openstack-meeting-alt | 09:55 | |
| *** jhesketh_ has joined #openstack-meeting-alt | 09:57 | |
| *** macz_ has joined #openstack-meeting-alt | 10:02 | |
| *** lpetrut has quit IRC | 10:03 | |
| *** zzzeek has quit IRC | 10:03 | |
| *** jhesketh has quit IRC | 10:03 | |
| *** irclogbot_0 has quit IRC | 10:03 | |
| *** zzzeek has joined #openstack-meeting-alt | 10:05 | |
| *** macz_ has quit IRC | 10:06 | |
| *** irclogbot_1 has joined #openstack-meeting-alt | 10:07 | |
| *** Dantalion has quit IRC | 10:27 | |
| *** Dantalion has joined #openstack-meeting-alt | 10:30 | |
| *** carloss has joined #openstack-meeting-alt | 10:57 | |
| *** dviroel has joined #openstack-meeting-alt | 11:03 | |
| *** macz_ has joined #openstack-meeting-alt | 12:05 | |
| *** macz_ has quit IRC | 12:09 | |
| *** macz_ has joined #openstack-meeting-alt | 12:21 | |
| *** macz_ has quit IRC | 12:25 | |
| *** zoharm has joined #openstack-meeting-alt | 12:31 | |
| *** macz_ has joined #openstack-meeting-alt | 12:52 | |
| *** enriquetaso has joined #openstack-meeting-alt | 12:53 | |
| *** macz_ has quit IRC | 12:56 | |
| *** jinyuanliu has quit IRC | 12:58 | |
| *** jinyuanliu has joined #openstack-meeting-alt | 12:59 | |
| *** Luzi has joined #openstack-meeting-alt | 13:01 | |
| *** jinyuanliu has quit IRC | 13:05 | |
| *** jinyuanliu has joined #openstack-meeting-alt | 13:06 | |
| *** lpetrut__ has joined #openstack-meeting-alt | 13:14 | |
| *** lpetrut_ has quit IRC | 13:16 | |
| *** gshippey has joined #openstack-meeting-alt | 13:57 | |
| *** Luzi has quit IRC | 14:28 | |
| *** miniroy has joined #openstack-meeting-alt | 14:33 | |
| *** miniroy has quit IRC | 14:36 | |
| *** whoami-rajat has quit IRC | 14:38 | |
| *** zzzeek has quit IRC | 14:51 | |
| *** zzzeek has joined #openstack-meeting-alt | 14:53 | |
| *** andrebeltrami has joined #openstack-meeting-alt | 14:55 | |
| *** felipe_rodrigues has joined #openstack-meeting-alt | 14:59 | |
| *** kiwi_36_ has joined #openstack-meeting-alt | 15:01 | |
| gouthamr | #startmeeting manila | 15:01 |
|---|---|---|
| openstack | Meeting started Thu Feb 25 15:01:42 2021 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| *** openstack changes topic to " (Meeting topic: manila)" | 15:01 | |
| openstack | The meeting name has been set to 'manila' | 15:01 |
| dviroel | o/ | 15:01 |
| carloss | o/ | 15:01 |
| felipe_rodrigues | o/ | 15:01 |
| kiwi_36_ | o/ | 15:01 |
| gouthamr | courtesy ping: ganso vkmc lseki tbarron andrebeltrami esantos | 15:02 |
| *** chuan137 has joined #openstack-meeting-alt | 15:02 | |
| almir-okato | hi | 15:03 |
| gouthamr | hi everyone, looks like we have a smaller than usual group today | 15:03 |
| andrebeltrami | o/ | 15:03 |
| chuan137 | o/ | 15:04 |
| gouthamr | here's the agenda for this meeting: https://wiki.openstack.org/wiki/Manila/Meetings#Next_Meeting | 15:04 |
| gouthamr | #topic Announcements | 15:04 |
| *** openstack changes topic to "Announcements (Meeting topic: manila)" | 15:04 | |
| gouthamr | nothing pressing at the moment, we're 2 weeks away from feature freeze | 15:05 |
| vkmc | o/ | 15:05 |
| carthaca | hi | 15:05 |
| gouthamr | #link https://releases.openstack.org/wallaby/schedule.html | 15:05 |
| gouthamr | this also happens to be the client library release deadline | 15:06 |
| gouthamr | which for us is python-manilaclient | 15:06 |
| *** ecsantos has joined #openstack-meeting-alt | 15:06 | |
| *** e0ne has quit IRC | 15:06 | |
| gouthamr | so if you have changes that require manilaclient integration, please ensure they're in shape within the next couple of weeks | 15:06 |
| gouthamr | any other announcements? | 15:07 |
| gouthamr | #topic M-3 Bugs | 15:08 |
| *** openstack changes topic to "M-3 Bugs (Meeting topic: manila)" | 15:08 | |
| andrebeltrami | I have one gouthamr | 15:08 |
| gouthamr | #undo | 15:08 |
| openstack | Removing item from minutes: #topic M-3 Bugs | 15:08 |
| gouthamr | go ahead andrebeltrami! | 15:08 |
| andrebeltrami | Today is my last manila meeting as developer of FIT/NetApp. I would like to thanks everyone of this amazing community, I learnt a lot with you. I will try keep in touch and provide some bugfixes haha. | 15:10 |
| gouthamr | oh :( | 15:10 |
| dviroel | :( | 15:10 |
| carloss | :/ | 15:10 |
| ecsantos | :( | 15:10 |
| gouthamr | thanks for all your work andrebeltrami! we'll miss you around here... | 15:11 |
| andrebeltrami | thank you, be sure I`ll participated in some meetings. I really appreciated be part of this. | 15:12 |
| gouthamr | do try to keep in touch, we'll be sure to farm out the hard bugs for you :) | 15:12 |
| andrebeltrami | +1 | 15:12 |
| dviroel | andrebeltrami: thanks for all the hard work man | 15:13 |
| carloss | it was nice working with you andrebeltrami! wish you the best in your joruney | 15:14 |
| carloss | journey* | 15:14 |
| gouthamr | ++ | 15:15 |
| gouthamr | any other announcements? | 15:15 |
| gouthamr | #topic M-3 bugs | 15:16 |
| *** openstack changes topic to "M-3 bugs (Meeting topic: manila)" | 15:16 | |
| gouthamr | #link https://launchpad.net/manila/+milestone/wallaby-3 | 15:16 |
| gouthamr | so there's a lot that's targeted for M-3 in this list | 15:17 |
| vkmc | andrebeltrami, :( | 15:17 |
| gouthamr | and since the bot integration is broken atm, we'll need to manually update the status of these bugs | 15:17 |
| gouthamr | meanwhile, if any of these bugfixes isn't ready yet, please retarget them if you can | 15:17 |
| gouthamr | consider targeting them to rc-1, which is 4 weeks from now | 15:18 |
| gouthamr | there are no "high" importance bugs in this list - that makes vhari happy :) | 15:20 |
| gouthamr | any questions/concerns about these m-3 bugs? | 15:21 |
| *** macz_ has joined #openstack-meeting-alt | 15:22 | |
| gouthamr | #topic Wallaby Release Bug Squash | 15:22 |
| *** openstack changes topic to "Wallaby Release Bug Squash (Meeting topic: manila)" | 15:22 | |
| gouthamr | as we planned to do at the Wallaby cycle PTG, we'll have our second bugsquash event after M-3 | 15:23 |
| gouthamr | vhari has been farming out bugs for this | 15:24 |
| gouthamr | (she's not around atm, a conflict on her calendar) | 15:24 |
| gouthamr | the idea is to have a 1-hour bug scrubbing meeting on 15th or 16th March | 15:25 |
| gouthamr | between 1400-1700 UTC | 15:25 |
| *** macz_ has quit IRC | 15:26 | |
| gouthamr | and follow up with status during our regular IRC meeting on 18th March | 15:26 |
| gouthamr | how does that sound? | 15:28 |
| dviroel | great idea | 15:28 |
| kiwi_36_ | sounds good | 15:29 |
| gouthamr | the 1400-1700 slot on either days is too late/early in the day for some of our contributors - but, since it's a bugsquash that runs monday-thursday, we will have some opportunity to speak and share ideas outside of that bug scrub meeting | 15:29 |
| carloss | sounds good | 15:30 |
| gouthamr | we hope to have a good list of bugs to dive into, but ofcourse, you can bring-your-own-bugs to squash :) | 15:30 |
| vkmc | sounds good! | 15:31 |
| vkmc | ++ | 15:31 |
| gouthamr | amazing :) thanks for the feedback | 15:31 |
| gouthamr | vhari and I will do some final planning and send out more information on the ML | 15:32 |
| gouthamr | if you would like to help with the planning, lets discuss on #openstack-manila | 15:32 |
| gouthamr | any other feedback regarding this bug squash? | 15:33 |
| gouthamr | #topic Reviews needing feedback | 15:35 |
| *** openstack changes topic to "Reviews needing feedback (Meeting topic: manila)" | 15:35 | |
| gouthamr | #link https://etherpad.opendev.org/p/manila-wallaby-review-focus (Wallaby cycle review focus etherpad) | 15:35 |
| gouthamr | we had a collab review session regarding the secure rbac patches, and a lot of content has been reviewed since then | 15:36 |
| gouthamr | #link https://youtu.be/rvVPmniVoCE (Secure RBAC Collab Review) | 15:37 |
| dviroel | :) | 15:38 |
| * gouthamr my computer's acting up this am | 15:38 | |
| gouthamr | #chair carloss dviroel | 15:39 |
| openstack | Current chairs: carloss dviroel gouthamr | 15:39 |
| gouthamr | ^ sorry for throwing the chair at you, that’s in case I get disconnected and you don’t hear from me :) | 15:39 |
| dviroel | still 2 likes in the video, and one is mine | 15:40 |
| dviroel | :( | 15:40 |
| ecsantos | 1 is mine o/ haha | 15:40 |
| dviroel | gouthamr: ack | 15:41 |
| gouthamr | lol, our fault we didn’t have any cats in the video | 15:41 |
| carloss | haha | 15:41 |
| dviroel | haha | 15:41 |
| vkmc | great session gouthamr, thanks for recording :) | 15:41 |
| vkmc | I didn't put a like on it, I'm afraid you will forget us once famous | 15:41 |
| dviroel | lol | 15:42 |
| gouthamr | :’) I’ll never forget you guys | 15:42 |
| gouthamr | This meeting was quite adhoc (entirely my bad, last minute planning), but the next one needn’t be | 15:42 |
| gouthamr | There are at least two other review meetings that we need around security service updates, and the cephfs driver | 15:43 |
| dviroel | yes! | 15:43 |
| dviroel | i'm planning to schedule a collab review session for security service update feature, at March 3th, 17:00 UTC | 15:43 |
| vkmc | ++ | 15:43 |
| gouthamr | If there are others, let me know - however don’t let me bottleneck you on the scheduling - feel free to make up a date and time (like dviroel just did :D) | 15:44 |
| vkmc | March 10th is too late for cephfs, or would that work? | 15:44 |
| gouthamr | And send out an invite to folks on the mailing list and #openstack-manila | 15:44 |
| gouthamr | vkmc: probably, since 11th is our merge deadline - maybe have it on 8th? | 15:45 |
| vkmc | gouthamr, let's do 8th :) | 15:47 |
| vkmc | thanks | 15:47 |
| gouthamr | Great! | 15:47 |
| dviroel | ++ | 15:48 |
| carloss | ++ | 15:48 |
| gouthamr | alright, about the other items on the review focus etherpad - are there any concerns that we need to discuss? | 15:49 |
| gouthamr | If you’ve signed up to review something, but haven’t gotten to it yet, please consider doing a first pass at such changes today/tomorrow | 15:49 |
| gouthamr | review fatigue is real, and it helps to break tasks down into smaller chunks, and look at them at different times | 15:50 |
| *** lpetrut__ has quit IRC | 15:51 | |
| gouthamr | anything else regarding $topic | 15:53 |
| gouthamr | cool, we've very little time for bugs today | 15:54 |
| gouthamr | but there are a couple of new ones | 15:54 |
| gouthamr | #topic Bugs (vhari) | 15:55 |
| *** openstack changes topic to "Bugs (vhari) (Meeting topic: manila)" | 15:55 | |
| * gouthamr pretends to be vhari :) | 15:55 | |
| gouthamr | #link https://bugs.launchpad.net/manila/+bug/1916534 | 15:55 |
| openstack | Launchpad bug 1916534 in OpenStack Shared File Systems Service (Manila) "NetApp driver doesn't configure LDAP clients properly" [Undecided,New] - Assigned to Douglas Viroel (dviroel) | 15:55 |
| dviroel | yep, ldap client aren't been properly configured in netapp driver | 15:55 |
| vkmc | seems we can triage it | 15:55 |
| gouthamr | ack, is this a low/medium? | 15:56 |
| dviroel | doesn't work at all with AD LDAP servers | 15:56 |
| vkmc | high | 15:56 |
| dviroel | may work with LDAP Unix/LInux servers (may) | 15:57 |
| dviroel | we can go with medium, not sure | 15:57 |
| dviroel | but you can assign to me :) | 15:57 |
| gouthamr | i see, vkmc - since it doesn't affect all users, i wouldn't tag this as high | 15:57 |
| carloss | medium sounds more accurate to me | 15:57 |
| vkmc | k | 15:57 |
| gouthamr | okay, lets do that | 15:58 |
| gouthamr | thanks for reporting and for working on the fix, dviroel | 15:58 |
| dviroel | set it to m3 too | 15:58 |
| gouthamr | #link https://bugs.launchpad.net/manila/+bug/1916102 | 15:58 |
| openstack | Launchpad bug 1916102 in OpenStack Shared File Systems Service (Manila) "Unable to allow non-admins with policy: security_services:get_all_security_services" [Undecided,New] | 15:58 |
| gouthamr | oh, this one is me - while writing some tests for our existing rbac i noticed that you can't allow a non-admin access to this policy at all | 15:59 |
| gouthamr | because we have a check in the code beyond the oslo policy enforcement | 15:59 |
| * gouthamr forgot to add links in the description | 16:00 | |
| gouthamr | oh, time checking myself | 16:01 |
| gouthamr | so this is i think a low bug, because we have many instances of checks like this one: #link https://bugs.launchpad.net/manila/+bug/1916102 | 16:01 |
| openstack | Launchpad bug 1916102 in OpenStack Shared File Systems Service (Manila) "Unable to allow non-admins with policy: security_services:get_all_security_services" [Undecided,New] | 16:01 |
| gouthamr | grr | 16:01 |
| gouthamr | https://github.com/openstack/manila/blob/14d3e268a05265db53b5cfd19d9a85a3ba73a271/manila/api/v1/security_service.py#L110 | 16:01 |
| gouthamr | i'll table discussion on this bug here | 16:01 |
| gouthamr | lets clear out, thank you all for attending today | 16:01 |
| gouthamr | lets take any further discussion to #openstack-manila | 16:02 |
| vkmc | ++ | 16:02 |
| *** macz_ has joined #openstack-meeting-alt | 16:02 | |
| gouthamr | #endmeeting | 16:02 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 16:02 | |
| openstack | Meeting ended Thu Feb 25 16:02:21 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-02-25-15.01.html | 16:02 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-02-25-15.01.txt | 16:02 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-02-25-15.01.log.html | 16:02 |
| priteau | #startmeeting blazar | 16:02 |
| openstack | Meeting started Thu Feb 25 16:02:56 2021 UTC and is due to finish in 60 minutes. The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:02 |
| *** openstack changes topic to " (Meeting topic: blazar)" | 16:02 | |
| openstack | The meeting name has been set to 'blazar' | 16:03 |
| priteau | #topic Roll call | 16:03 |
| *** openstack changes topic to "Roll call (Meeting topic: blazar)" | 16:03 | |
| *** diurnalist has joined #openstack-meeting-alt | 16:04 | |
| diurnalist | o7 | 16:04 |
| diurnalist | hi priteau | 16:04 |
| priteau | Hello diurnalist | 16:04 |
| priteau | #topic Usage enforcement patch | 16:06 |
| *** openstack changes topic to "Usage enforcement patch (Meeting topic: blazar)" | 16:06 | |
| priteau | So I've been looking at this patch | 16:06 |
| priteau | Let me pull the link | 16:07 |
| priteau | https://review.opendev.org/c/openstack/blazar/+/736993 | 16:07 |
| priteau | There's something I don't quite understand, which is the semantics of the length limit window | 16:08 |
| priteau | The code is at https://review.opendev.org/c/openstack/blazar/+/736993/7/blazar/enforcement/filters/max_lease_duration_filter.py | 16:08 |
| priteau | The help code says: | 16:08 |
| priteau | Gives users a window towards the end of a lease to extend it again for the max lease duration. A value of -1 will allow users to extend leases beyond the maximum lease duration. | 16:09 |
| diurnalist | yeah, I see what you mean now. that clearly doesn't work w/ this code | 16:09 |
| priteau | I understand what is intended for the first part, e.g. allow extension only for the last 24 hours | 16:09 |
| priteau | But I really don't see what was the goal for this -1 value | 16:09 |
| priteau | Additionally, I don't see where in the code -1 is handled | 16:10 |
| diurnalist | this is simply a bug, I think. we need an additional check for when the value is -1 (or 0, whichever we want to do). i think the intent was if it's -1 then the check always passes. but in this case, it stands to reason you could simply remove the filter entirely from the chain | 16:10 |
| priteau | Well, there is the -1 for the max_lease_duration option | 16:11 |
| priteau | That's fine, it means unlimited | 16:11 |
| priteau | It's having a special case for the window that is strange | 16:11 |
| priteau | My suggestion would be to remove that part of the code for now. We can put it back as a separate patch | 16:12 |
| diurnalist | oh yeah, hah. yeah, i'm not sure what is up with having it work "beyond the maximum length window" | 16:12 |
| priteau | I've got a local patch with unit tests for this filter | 16:13 |
| diurnalist | i'd say, a value of -1 would maybe mean that you can extend the lease at _any_ point during the lease? | 16:13 |
| priteau | I suppose so, that's would be the default behaviour | 16:13 |
| diurnalist | that's what it does, effectively. maybe just the help text needs updating. although there is also an 'if' guarding that behavior entirely, so it would seem that 0 is really the value that does this | 16:14 |
| priteau | And 0 would prevent extending it, which might be a feature? | 16:14 |
| diurnalist | ah, good point, turning it off might be desirable | 16:14 |
| priteau | Although it gets more complicated if you think about leases that were not created at the max to start with | 16:15 |
| priteau | Say the length limit is 7 days | 16:15 |
| priteau | I create a 1 day lease | 16:15 |
| priteau | I should be able to extend it to 7 days no matter what is the value of the extension window | 16:15 |
| diurnalist | up until that 7 days, you mean? | 16:17 |
| diurnalist | that makes sense | 16:17 |
| priteau | yes, up until it is 7 day long | 16:18 |
| priteau | And, even beyond really, because: | 16:19 |
| priteau | For active leases being updated, the limit applies between now and the new end date. | 16:19 |
| priteau | So, if you extend after 0.5 day of activity, you're suppose to be able to reach 7.5 | 16:19 |
| diurnalist | i'm not sure of the semantics of -1 vs 0, either one can be used. so maybe it makes sense to have the rules like (a) if window is set, lease can be extended (for another period of <=max_len) within window of lease end. (b) if window is 0, lease can be extended at any time for another period of <=max_len. (c) window only applies to requests to extend past original start_date+max_len | 16:20 |
| priteau | Why don't we create an Etherpad with a few examples and we agree on the semantics? | 16:22 |
| diurnalist | ok | 16:22 |
| priteau | Is it a filter that you would use in Chameleon? | 16:23 |
| *** chuan13764 has joined #openstack-meeting-alt | 16:26 | |
| *** chuan137 has quit IRC | 16:26 | |
| diurnalist | priteau: yes, we currently use it | 16:27 |
| diurnalist | in combination w/ the external service filter | 16:27 |
| priteau | So we may as well make it match your semantics | 16:29 |
| priteau | It's quite a big patch, I've been thinking about how to make it easier to review | 16:31 |
| priteau | I can see a few separate units | 16:31 |
| priteau | 1) some refactoring that is independent of the implementation itself | 16:31 |
| priteau | (or bug fixes) | 16:31 |
| priteau | 2) refactor of the allocation query methods and its addition to all plugins | 16:32 |
| priteau | 3) the common layer for enforcement | 16:32 |
| priteau | 4) max lease duration | 16:32 |
| priteau | 5) external service | 16:32 |
| priteau | I'll see if splitting is more work than actually reviewing it all in one go | 16:33 |
| priteau | I've also noticed the patch has a dependency on the soft delete functionality | 16:33 |
| priteau | So I am thinking of reviving it first | 16:33 |
| priteau | There were other things that I wanted to mention… | 16:34 |
| priteau | For the external service, have you tested what happens if it is unreachable? | 16:35 |
| priteau | And should we have timeouts? | 16:37 |
| priteau | For example, if it accepts queries but without replying, could it block Blazar? | 16:38 |
| diurnalist | It should fail closed, as in, proceed w/o blocking the lease. i don't believe there are configurable timeouts on it. maybe there are some common oslo options we could leverage for the client that gcalls the service | 16:38 |
| diurnalist | i didn't think about it depending on soft-delete. does it really? | 16:38 |
| diurnalist | i know there were some refactorings as part of (1) that were around lease deletion but i recall it was more about deleing events vs. leases | 16:39 |
| priteau | Only as a hidden dependency, not explicitly | 16:39 |
| priteau | For example here: https://review.opendev.org/c/openstack/blazar/+/736993/7/blazar/db/sqlalchemy/utils.py#111 | 16:39 |
| priteau | And also in the long standing bug you mention in the commit message | 16:40 |
| priteau | In upstream Blazar, events are deleted with the lease so it doesn't matter that the state isn't changed | 16:40 |
| diurnalist | ah, i see | 16:42 |
| diurnalist | so it's only a long-standing bug in combo w/ soft-delete | 16:42 |
| priteau | yes | 16:43 |
| diurnalist | right, that deleted_at filter :facepalm:. do we have a patch for soft-delete already in there? | 16:43 |
| priteau | An old one | 16:45 |
| priteau | https://review.opendev.org/c/openstack/blazar/+/585807 | 16:45 |
| priteau | Outdated since it doesn't cover floating IPs | 16:45 |
| diurnalist | yep, ok | 16:45 |
| priteau | The main issue with it was around handling compute hosts that would be recreated | 16:46 |
| priteau | Because their primary key is the Nova hypervisor ID | 16:46 |
| priteau | So I think we wanted to un-soft-delete them | 16:47 |
| priteau | The other comment was about handling DB purge, but we can worry about it in another patch | 16:47 |
| priteau | If you have a newer local patch for this, feel free to upload on top | 16:48 |
| diurnalist | ok | 16:48 |
| diurnalist | i think i may actually. at some point i was doing some more git rewriting to try to push more of these patches down so they don't all depend on eachother so much | 16:48 |
| priteau | The more we get merged, the easier it will be | 16:50 |
| priteau | Are you using the external service for enforcement in Chameleon or still the build-in code I wrote ages ago? | 16:50 |
| diurnalist | we're using the external service | 16:53 |
| priteau | Great! Is the code open? | 16:54 |
| diurnalist | for the external service itself, or the plugin? i thought the plugin was part of that gerrit patch | 16:56 |
| priteau | For the external service itself | 16:57 |
| diurnalist | it is not. though, i'm not sure there's a great reason for why | 16:57 |
| diurnalist | i think you would have access though, I'll ping you a link | 16:58 |
| priteau | Thanks | 16:58 |
| priteau | Last question, do you think the term "filter" is appropriate? It's not quite like a Nova filter which lets some hosts pass but not all | 16:59 |
| priteau | They're really policy modules | 17:00 |
| priteau | Though it's not a great name either | 17:00 |
| diurnalist | true, it's not really a filter in the strict sense | 17:00 |
| diurnalist | more like a chain or something | 17:00 |
| priteau | Something we can think about until next time | 17:01 |
| priteau | We're out of time already | 17:01 |
| priteau | Thanks Jason, useful chat | 17:01 |
| priteau | #endmeeting | 17:01 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 17:01 | |
| openstack | Meeting ended Thu Feb 25 17:01:53 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:01 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/blazar/2021/blazar.2021-02-25-16.02.html | 17:01 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/blazar/2021/blazar.2021-02-25-16.02.txt | 17:01 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/blazar/2021/blazar.2021-02-25-16.02.log.html | 17:01 |
| *** zoharm has quit IRC | 17:35 | |
| *** rdopiera has quit IRC | 17:36 | |
| *** diurnalist has quit IRC | 17:43 | |
| *** ecsantos has quit IRC | 18:05 | |
| *** andrebeltrami has quit IRC | 19:14 | |
| *** chuan13764 has quit IRC | 19:15 | |
| *** ralonsoh has quit IRC | 19:24 | |
| *** zzzeek has quit IRC | 19:29 | |
| *** zzzeek has joined #openstack-meeting-alt | 19:29 | |
| *** ajitha has quit IRC | 20:25 | |
| *** senrique_ has joined #openstack-meeting-alt | 20:35 | |
| *** geguileo has quit IRC | 20:35 | |
| *** geguileo has joined #openstack-meeting-alt | 20:35 | |
| *** lbragstad_ has joined #openstack-meeting-alt | 20:35 | |
| *** beekneemech has joined #openstack-meeting-alt | 20:35 | |
| *** mugsie_ has joined #openstack-meeting-alt | 20:36 | |
| *** persia_ has joined #openstack-meeting-alt | 20:36 | |
| *** benj_- has joined #openstack-meeting-alt | 20:36 | |
| *** early has quit IRC | 20:36 | |
| *** benj_ has quit IRC | 20:36 | |
| *** Dantalion has quit IRC | 20:36 | |
| *** zigo has quit IRC | 20:36 | |
| *** slaweq has quit IRC | 20:36 | |
| *** persia has quit IRC | 20:36 | |
| *** melwitt has quit IRC | 20:36 | |
| *** mugsie has quit IRC | 20:36 | |
| *** early has joined #openstack-meeting-alt | 20:36 | |
| *** melwitt has joined #openstack-meeting-alt | 20:36 | |
| *** benj_- is now known as benj_ | 20:37 | |
| *** tosky_ has joined #openstack-meeting-alt | 20:37 | |
| *** strigazi has quit IRC | 20:38 | |
| *** jinyuanliu has quit IRC | 20:38 | |
| *** stevthedev has quit IRC | 20:38 | |
| *** Dantalion has joined #openstack-meeting-alt | 20:39 | |
| *** jinyuanliu has joined #openstack-meeting-alt | 20:39 | |
| *** stevthedev has joined #openstack-meeting-alt | 20:39 | |
| *** zzzeek has quit IRC | 20:40 | |
| *** tosky has quit IRC | 20:40 | |
| *** trident has quit IRC | 20:40 | |
| *** kevinz has quit IRC | 20:40 | |
| *** ricolin has quit IRC | 20:40 | |
| *** bnemec has quit IRC | 20:40 | |
| *** enriquetaso has quit IRC | 20:40 | |
| *** mnasiadka has quit IRC | 20:41 | |
| *** zzzeek has joined #openstack-meeting-alt | 20:41 | |
| *** tosky_ is now known as tosky | 20:42 | |
| *** lifeless_ has joined #openstack-meeting-alt | 20:42 | |
| *** markmcclain has quit IRC | 20:42 | |
| *** mnasiadka has joined #openstack-meeting-alt | 20:42 | |
| *** trident has joined #openstack-meeting-alt | 20:42 | |
| *** kiwi_36_ has quit IRC | 20:43 | |
| *** lifeless has quit IRC | 20:43 | |
| *** lbragstad has quit IRC | 20:43 | |
| *** rcernin has quit IRC | 21:12 | |
| *** rcernin has joined #openstack-meeting-alt | 22:09 | |
| *** rcernin has quit IRC | 22:15 | |
| *** rcernin has joined #openstack-meeting-alt | 22:15 | |
| *** lbragstad_ is now known as lbragstad | 22:26 | |
| *** gshippey has quit IRC | 23:33 | |
| *** carloss has quit IRC | 23:46 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!