| *** yamamoto has quit IRC | 00:03 | |
| *** macza has quit IRC | 00:13 | |
| *** tetsuro has joined #openstack-meeting-alt | 00:19 | |
| *** hongbin has quit IRC | 00:22 | |
| *** TxGirlGeek has quit IRC | 00:29 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 00:40 | |
| *** dklyle has quit IRC | 00:42 | |
| *** igordc has quit IRC | 00:51 | |
| *** tetsuro has quit IRC | 01:29 | |
| *** TxGirlGeek has quit IRC | 01:39 | |
| *** whoami-rajat has joined #openstack-meeting-alt | 01:53 | |
| *** hongbin has joined #openstack-meeting-alt | 02:08 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 02:09 | |
| *** hongbin_ has joined #openstack-meeting-alt | 02:35 | |
| *** bhavikdbavishi has quit IRC | 02:37 | |
| *** hongbin has quit IRC | 02:38 | |
| *** iyamahat has quit IRC | 02:50 | |
| *** yamahata has quit IRC | 02:51 | |
| *** yamamoto has joined #openstack-meeting-alt | 02:59 | |
| *** dklyle has joined #openstack-meeting-alt | 03:07 | |
| *** tetsuro has joined #openstack-meeting-alt | 03:10 | |
| *** tetsuro has quit IRC | 03:12 | |
| *** apetrich has quit IRC | 03:15 | |
| *** dklyle has quit IRC | 03:21 | |
| *** baojg has quit IRC | 03:24 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 03:27 | |
| *** bhavikdbavishi has quit IRC | 03:31 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 03:35 | |
| *** baojg has joined #openstack-meeting-alt | 03:43 | |
| *** tetsuro has joined #openstack-meeting-alt | 03:57 | |
| *** tetsuro has quit IRC | 03:57 | |
| *** dklyle has joined #openstack-meeting-alt | 04:20 | |
| *** irclogbot_1 has quit IRC | 04:35 | |
| *** hongbin_ has quit IRC | 04:35 | |
| *** hongbin has joined #openstack-meeting-alt | 04:35 | |
| *** ijw has quit IRC | 04:37 | |
| *** hongbin has quit IRC | 04:40 | |
| *** yamahata has joined #openstack-meeting-alt | 04:44 | |
| *** lbragstad has quit IRC | 04:57 | |
| *** gyee has quit IRC | 05:01 | |
| *** sridharg has joined #openstack-meeting-alt | 05:02 | |
| *** baojg has quit IRC | 05:02 | |
| *** e0ne has joined #openstack-meeting-alt | 05:03 | |
| *** e0ne has quit IRC | 05:03 | |
| *** baojg has joined #openstack-meeting-alt | 05:04 | |
| *** baojg has quit IRC | 05:04 | |
| *** baojg has joined #openstack-meeting-alt | 05:05 | |
| *** vishalmanchanda has joined #openstack-meeting-alt | 05:44 | |
| *** jbadiapa has joined #openstack-meeting-alt | 06:13 | |
| *** markvoelker has joined #openstack-meeting-alt | 06:16 | |
| *** ccamacho has quit IRC | 06:26 | |
| *** markvoelker has quit IRC | 06:45 | |
| *** ccamacho has joined #openstack-meeting-alt | 07:12 | |
| *** apetrich has joined #openstack-meeting-alt | 07:12 | |
| *** baojg has quit IRC | 07:15 | |
| *** baojg has joined #openstack-meeting-alt | 07:16 | |
| *** baojg has quit IRC | 07:16 | |
| *** baojg has joined #openstack-meeting-alt | 07:17 | |
| *** tetsuro has joined #openstack-meeting-alt | 07:18 | |
| *** kopecmartin|off is now known as kopecmartin | 07:19 | |
| *** tetsuro has quit IRC | 07:19 | |
| *** baojg has quit IRC | 07:25 | |
| *** baojg has joined #openstack-meeting-alt | 07:25 | |
| *** e0ne has joined #openstack-meeting-alt | 07:35 | |
| *** markvoelker has joined #openstack-meeting-alt | 07:42 | |
| *** ttsiouts has joined #openstack-meeting-alt | 08:14 | |
| *** ttsiouts has quit IRC | 08:14 | |
| *** markvoelker has quit IRC | 08:15 | |
| *** ttsiouts has joined #openstack-meeting-alt | 08:28 | |
| *** rcernin has quit IRC | 08:29 | |
| *** yamamoto has quit IRC | 08:42 | |
| *** baojg has quit IRC | 08:43 | |
| *** baojg has joined #openstack-meeting-alt | 08:45 | |
| *** ttsiouts has quit IRC | 08:46 | |
| *** ttsiouts has joined #openstack-meeting-alt | 08:47 | |
| *** ttsiouts has quit IRC | 08:51 | |
| *** yamamoto has joined #openstack-meeting-alt | 08:54 | |
| *** ianychoi has quit IRC | 08:55 | |
| *** iyamahat has joined #openstack-meeting-alt | 08:56 | |
| *** ttsiouts has joined #openstack-meeting-alt | 09:21 | |
| *** derekh has joined #openstack-meeting-alt | 09:29 | |
| *** ttsiouts has quit IRC | 09:32 | |
| *** ttsiouts has joined #openstack-meeting-alt | 09:32 | |
| *** ttsiouts has quit IRC | 09:36 | |
| *** e0ne has quit IRC | 09:41 | |
| *** ttsiouts has joined #openstack-meeting-alt | 09:43 | |
| *** tssurya has joined #openstack-meeting-alt | 09:51 | |
| *** erlon_ has joined #openstack-meeting-alt | 09:52 | |
| *** jrbalderrama has joined #openstack-meeting-alt | 09:55 | |
| *** e0ne has joined #openstack-meeting-alt | 09:56 | |
| *** masahito has joined #openstack-meeting-alt | 10:04 | |
| *** tssurya has quit IRC | 10:05 | |
| *** tssurya has joined #openstack-meeting-alt | 10:06 | |
| *** masahito has quit IRC | 10:09 | |
| *** markvoelker has joined #openstack-meeting-alt | 10:12 | |
| *** bhavikdbavishi has quit IRC | 10:22 | |
| *** helenafm has joined #openstack-meeting-alt | 10:41 | |
| *** markvoelker has quit IRC | 10:46 | |
| *** ttsiouts has quit IRC | 11:15 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:16 | |
| *** ttsiouts has quit IRC | 11:20 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 11:36 | |
| *** markvoelker has joined #openstack-meeting-alt | 11:43 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:56 | |
| *** markvoelker has quit IRC | 12:16 | |
| *** panda is now known as panda|lunch | 12:17 | |
| *** jesusaur has quit IRC | 12:48 | |
| *** panda|lunch is now known as panda | 12:55 | |
| *** e0ne has quit IRC | 12:59 | |
| *** bhavikdbavishi has quit IRC | 12:59 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 13:00 | |
| *** armstrong has joined #openstack-meeting-alt | 13:01 | |
| *** yamamoto has quit IRC | 13:09 | |
| *** markvoelker has joined #openstack-meeting-alt | 13:13 | |
| *** e0ne has joined #openstack-meeting-alt | 13:20 | |
| *** markvoelker has quit IRC | 13:23 | |
| *** markvoelker has joined #openstack-meeting-alt | 13:23 | |
| *** derekh has quit IRC | 13:26 | |
| *** baojg has quit IRC | 13:28 | |
| *** ttsiouts has quit IRC | 13:35 | |
| *** ttsiouts has joined #openstack-meeting-alt | 13:35 | |
| *** liuyulong has joined #openstack-meeting-alt | 13:38 | |
| *** ttsiouts has quit IRC | 13:39 | |
| *** ttsiouts has joined #openstack-meeting-alt | 13:39 | |
| *** yamamoto has joined #openstack-meeting-alt | 13:40 | |
| *** lujinluo has joined #openstack-meeting-alt | 13:43 | |
| *** jrbalderrama has quit IRC | 13:56 | |
| *** derekh has joined #openstack-meeting-alt | 13:58 | |
| *** jcoufal has joined #openstack-meeting-alt | 13:59 | |
| lujinluo | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu Jan 24 14:00:30 2019 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| *** ttsiouts has quit IRC | 14:01 | |
| lujinluo | This would be the first meeting we start in a new channel! But honestly I am not sure how many of my team mates would join today, so I will wait for a few minutes | 14:01 |
| *** ttsiouts has joined #openstack-meeting-alt | 14:01 | |
| lujinluo | If no one showed up, I will just briefly list the patches ready for review, just in case people come back and read logs | 14:02 |
| *** helenafm has left #openstack-meeting-alt | 14:02 | |
| lujinluo | #topic OVO | 14:02 |
| *** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:02 | |
| lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:02 |
| lujinluo | ^ these are the patches open for review now | 14:03 |
| lujinluo | and among them, #link https://review.openstack.org/#/c/544206/ port binding OVO is ready | 14:03 |
| lujinluo | others need more work | 14:03 |
| *** njohnston has joined #openstack-meeting-alt | 14:04 | |
| njohnston | sorry I am late | 14:04 |
| lujinluo | hi njohnston ! no problem at all | 14:04 |
| lujinluo | so I am go through the patches we have now | 14:04 |
| lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:04 |
| *** jrbalderrama has joined #openstack-meeting-alt | 14:04 | |
| lujinluo | No many updates recently and I apologies for that :( | 14:05 |
| njohnston | I'm just as much to blame :-) | 14:05 |
| *** ttsiouts has quit IRC | 14:05 | |
| lujinluo | I am looking at your #link https://review.openstack.org/#/c/624815/ patch though | 14:06 |
| lujinluo | recently, and I am thinking about your email | 14:06 |
| lujinluo | I have not come to a final decision, but for now, i think we may not want to use port OVO in those registries | 14:06 |
| lujinluo | registry calls, i mean | 14:07 |
| lujinluo | the main concern i have is if we use them in those calls, will it affect other ML2 plugins? I happened to write some codes for networking-fujitsu, which receives the pre_commit notifications from Neutron and run its own switch command accordingly | 14:09 |
| *** ttsiouts has joined #openstack-meeting-alt | 14:09 | |
| njohnston | Hmm, the data should be converted to a dict before it is sent to the registry using _make_port_dict | 14:10 |
| njohnston | I was hoping that would be sufficient to maintain compatibility | 14:10 |
| *** yamamoto has quit IRC | 14:11 | |
| lujinluo | i see. if so, i guess my current concern would be resolved | 14:11 |
| lujinluo | i will look more into the related codes and get back to you soon! | 14:12 |
| njohnston | thank you! | 14:13 |
| lujinluo | also, it would be really appreciated if you could review #link https://review.openstack.org/#/c/544206/ when you are available :-) | 14:13 |
| *** yamamoto has joined #openstack-meeting-alt | 14:13 | |
| *** yamamoto has quit IRC | 14:13 | |
| njohnston | I will definitely take a look at it! | 14:13 |
| lujinluo | do you have any specific patch you want to discuss in the list here? #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:14 |
| lujinluo | thank you! | 14:14 |
| *** e0ne has quit IRC | 14:14 | |
| njohnston | No, https://review.openstack.org/#/c/624815/ is consuming my world as I start feeling like I need to change more and more plumbing :-( | 14:14 |
| lujinluo | understood, hopefully we can get it in a good shape soon! | 14:15 |
| njohnston | I am hoping I will conquer it and be released to other things soon | 14:15 |
| *** yamamoto has joined #openstack-meeting-alt | 14:15 | |
| lujinluo | :-) that will happen, and all we need is time haha | 14:15 |
| lujinluo | then let's wrap it up earlier today and do more hacking this week! | 14:16 |
| njohnston | thanks! | 14:16 |
| lujinluo | thank you! njohnston | 14:16 |
| lujinluo | have a good day! | 14:16 |
| njohnston | thank you as always lujinluo | 14:16 |
| lujinluo | :) | 14:16 |
| lujinluo | #endmeeting | 14:16 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:16 | |
| openstack | Meeting ended Thu Jan 24 14:16:54 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:16 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2019/neutron_upgrades.2019-01-24-14.00.html | 14:16 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2019/neutron_upgrades.2019-01-24-14.00.txt | 14:16 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2019/neutron_upgrades.2019-01-24-14.00.log.html | 14:17 |
| *** yamamoto has quit IRC | 14:20 | |
| *** lbragstad has joined #openstack-meeting-alt | 14:20 | |
| *** helenafm has joined #openstack-meeting-alt | 14:25 | |
| *** baojg has joined #openstack-meeting-alt | 14:31 | |
| *** ccamacho has quit IRC | 14:32 | |
| *** helenafm has left #openstack-meeting-alt | 14:34 | |
| *** e0ne has joined #openstack-meeting-alt | 14:34 | |
| *** ccamacho has joined #openstack-meeting-alt | 14:35 | |
| *** carthaca has joined #openstack-meeting-alt | 14:38 | |
| *** lujinluo has quit IRC | 14:39 | |
| *** lujinluo has joined #openstack-meeting-alt | 14:40 | |
| *** lujinluo has quit IRC | 14:45 | |
| *** jgrosso has joined #openstack-meeting-alt | 14:51 | |
| *** ganso has joined #openstack-meeting-alt | 14:56 | |
| *** hongbin has joined #openstack-meeting-alt | 14:58 | |
| *** jrbalderrama has quit IRC | 14:59 | |
| *** jrbalderrama has joined #openstack-meeting-alt | 15:00 | |
| tbarron | #startmeeting manila | 15:00 |
| openstack | Meeting started Thu Jan 24 15:00:39 2019 UTC and is due to finish in 60 minutes. The chair is tbarron. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: manila)" | 15:00 | |
| openstack | The meeting name has been set to 'manila' | 15:00 |
| vkmc | o/ | 15:00 |
| tbarron | ping ganso | 15:00 |
| tbarron | ping xyang | 15:00 |
| tbarron | vkmc hi | 15:00 |
| tbarron | ping gouthamr | 15:01 |
| toabctl | o/ | 15:01 |
| tbarron | ping jgrosso | 15:01 |
| tbarron | hi toabctl | 15:01 |
| jgrosso | hi tbarron | 15:01 |
| tbarron | ping bswartz | 15:01 |
| tbarron | ping erlon | 15:01 |
| tbarron | pint tpsilva :) | 15:01 |
| tbarron | ping amito | 15:01 |
| tbarron | if anyone else wants to be added to the ping list you can do it yourself at https://wiki.openstack.org/w/index.php?title=Manila/Meetings&action=edit§ion=1 | 15:02 |
| tbarron | oe AK MW RO SO IR | 15:02 |
| tbarron | :) | 15:02 |
| tbarron | or ask me to do it | 15:02 |
| xyang | hi | 15:02 |
| tbarron | that was rot something on querty with caps :) | 15:02 |
| tbarron | hi xyang | 15:02 |
| ganso | hello | 15:03 |
| tbarron | let's wait a couple more minutes | 15:03 |
| gouthamr | o/ | 15:03 |
| tbarron | hi gouthamr | 15:03 |
| gouthamr | hi tbarron! | 15:04 |
| * tbarron wonders if bswartz is around | 15:04 | |
| tbarron | OK, we've got quorum, let's start. | 15:04 |
| tbarron | hi everyone! | 15:04 |
| tbarron | #topic agenda | 15:05 |
| *** openstack changes topic to "agenda (Meeting topic: manila)" | 15:05 | |
| tbarron | #link https://wiki.openstack.org/wiki/Manila/Meetings | 15:05 |
| *** carlos_silva has joined #openstack-meeting-alt | 15:05 | |
| tbarron | if you update it give me a nudge so i can refresh my browser | 15:05 |
| tbarron | #topic announcements | 15:05 |
| *** openstack changes topic to "announcements (Meeting topic: manila)" | 15:05 | |
| tbarron | I don't have any. Anyone else? | 15:05 |
| tbarron | ok, hearing none ... | 15:06 |
| tbarron | we've got a fair number of topics but let's try to move right along, i want to have time for the bugs topic | 15:06 |
| tbarron | #topic scheduler speedup | 15:06 |
| *** openstack changes topic to "scheduler speedup (Meeting topic: manila)" | 15:06 | |
| tbarron | #link https://review.openstack.org/#/c/619576/ | 15:07 |
| tbarron | carthaca: you around? | 15:07 |
| ganso | there is something wrong with the numbering on the agenda | 15:07 |
| tbarron | ganso, yeah I see that now :) | 15:07 |
| tbarron | We'll go top to bottom and I'll fix it after unless you want to do it now :) | 15:08 |
| tbarron | feel free | 15:08 |
| tbarron | So review 619576 has two plus 2s but it touches some important code so I haven't workflowed it yet | 15:09 |
| tbarron | I plan to do that tomorrow if there aren't any downvotes | 15:09 |
| ganso | tbarron: done | 15:09 |
| tbarron | Please take a look if you care about the manila scheduler | 15:09 |
| tbarron | ganso: ty | 15:09 |
| tbarron | #topic AZ work | 15:10 |
| *** openstack changes topic to "AZ work (Meeting topic: manila)" | 15:10 | |
| gouthamr | ack, was looking if we can automate testing it somehow | 15:10 |
| tbarron | There are three patches listed in the agenda | 15:11 |
| tbarron | They are pretty significant -- exercise AZs in a way we haven't done before | 15:11 |
| tbarron | We agreed in principle to the approach at spec time and I think it makes sense. | 15:11 |
| tbarron | But expect that there may be some fallout. | 15:12 |
| tbarron | Third party folks please look as well. | 15:12 |
| tbarron | gouthamr: do you have something you want to share on these? | 15:12 |
| gouthamr | ty tbarron | 15:12 |
| gouthamr | yes, one more set of patches is due: Share type AZ support - i'm still working on the tests for these | 15:13 |
| gouthamr | but the others listed: | 15:13 |
| gouthamr | #LINK: https://review.openstack.org/#/c/629958/ | 15:13 |
| gouthamr | #LINK: https://review.openstack.org/#/c/630886/ | 15:13 |
| gouthamr | #LINK: https://review.openstack.org/#/c/630039/ | 15:13 |
| gouthamr | are complete and needy for attention, thanks for teh reviews tbarron toabctl | 15:13 |
| toabctl | only the last one is not merged yet | 15:13 |
| toabctl | I already workflowed 629958 and 630886 and both are already merged. | 15:14 |
| gouthamr | ooh, thanks! | 15:14 |
| tbarron | i think we can merge them but want people to be aware of the changes in case there's any unanticipated fallout we need to repair | 15:14 |
| gouthamr | ++ | 15:15 |
| toabctl | yeah. sure. | 15:15 |
| tbarron | it's hard to test all this fully I think | 15:15 |
| tbarron | like what happens to netapp replication | 15:15 |
| gouthamr | all third party CIs that use: ENABLED_BACKENDS should automatically have an AZ assigned to each of their enabled backends | 15:15 |
| tbarron | etc | 15:15 |
| tbarron | so heads up | 15:15 |
| toabctl | and imo https://review.openstack.org/#/c/630039/ can be merged, too. just somebody needs to press the workflow button :) | 15:16 |
| tbarron | It's good stuff, just have your eyes open. | 15:16 |
| tbarron | toabctl: yup | 15:16 |
| tbarron | OK, anything else on this topic? | 15:16 |
| gouthamr | yes | 15:16 |
| gouthamr | while we're here, please help by reviewing | 15:17 |
| gouthamr | #LINK: https://review.openstack.org/#/q/topic:bp/export-locations-az+(status:open+OR+status:merged) | 15:17 |
| gouthamr | :) | 15:17 |
| gouthamr | that's trying to introduce new experimental APIs and clean up the export locations API a bit | 15:17 |
| tbarron | gouthamr: plug .... | 15:17 |
| gouthamr | :D | 15:17 |
| tbarron | gouthamr: thanks for your work in this important area and toabctl thanks for your quality reviews. | 15:18 |
| tbarron | #topic pylint | 15:18 |
| *** openstack changes topic to "pylint (Meeting topic: manila)" | 15:18 | |
| tbarron | ganso you're up | 15:18 |
| ganso | okay | 15:18 |
| ganso | thanks | 15:18 |
| ganso | so, I am not sure if everyone has noticed, but lately our pylint job has been broken | 15:19 |
| ganso | here is one example: #LINK http://logs.openstack.org/58/629958/2/check/openstack-tox-pylint/d3056f6/job-output.txt.gz#_2019-01-23_19_20_57_403442 | 15:19 |
| ganso | hold on I am trying to get the gerrit link for the patch that broke it | 15:20 |
| tbarron | So we used to run with a very old version of pylint but had a "ratchet" - the job only failed if there were *new* pylint warnings introduced by your patch | 15:20 |
| ganso | there we go https://review.openstack.org/#/c/609791/ | 15:20 |
| ganso | #LINK https://review.openstack.org/#/c/609791/ | 15:20 |
| tbarron | we ported over changes from cinder to support newer pyling | 15:20 |
| tbarron | pylint | 15:20 |
| tbarron | and there's no longer a "ratchet" | 15:21 |
| tbarron | the (nonvoting) job will say "FAIL" if you touched a file that has warnings | 15:21 |
| tbarron | Talking to the cinder folks, the idea is to over time address the backlog of warnings. | 15:22 |
| gouthamr | seesh: https://review.openstack.org/#/c/609791/1/tools/coding-checks.sh@7 | 15:22 |
| *** bhavikdbavishi has quit IRC | 15:22 | |
| gouthamr | we can't run cinder's checks - they'll fail of course :P | 15:22 |
| ganso | tbarron: there are multiple problems, 1) if fails to import some dependencies. tbarron fixed it this morning. #LINK https://review.openstack.org/632992 and 2) it will fail if you add code, complaining about the way we mock and assert code in unit tests | 15:22 |
| tbarron | If you get "FAIL" look at the report and see if you can fix some of the issues or fix pylint if it's doing the wrong thing. | 15:22 |
| * gouthamr was kidding :P | 15:22 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 15:22 | |
| tbarron | gouthamr: yeah my patch changes that too :) | 15:23 |
| gouthamr | ah: https://review.openstack.org/#/c/632992/1/tools/coding-checks.sh | 15:23 |
| ganso | tbarron: so, I'll give one practical example and raise some questions | 15:23 |
| tbarron | I noticed that cinder's .pylintrc and ours don't exactly match | 15:23 |
| tbarron | we may be able to make some mods there to reduce noise | 15:23 |
| tbarron | ganso: +1 | 15:24 |
| ganso | I am working on Manage/Unmanage of Share servers. And as I finished coding, along with unit tests, and everything is working, pylint is printing hundreds of warnings | 15:24 |
| ganso | there is really nothing wrong with the code, because it is exactly as we used to do, the mocks and asserts | 15:24 |
| ganso | but pylint doesn't like it that way | 15:25 |
| ganso | our previous version of pylint didn't complain about mocks and asserts | 15:25 |
| ganso | so, it would be good to get agreement here as to: | 15:25 |
| tbarron | ganso: I'd like to filter those out, this issue seems to be https://github.com/PyCQA/pylint/issues/697 | 15:26 |
| gouthamr | ganso: installing test_requirements should have gotten rid of those specific errors? or do the errors not appear always? | 15:26 |
| ganso | tbarron: yea that's the error | 15:26 |
| tbarron | gouthamr: this is a different issue I think | 15:26 |
| ganso | tbarron: so, looking at the git discussion | 15:27 |
| ganso | tbarron: they don't plan on fixing it | 15:27 |
| ganso | tbarron: so we would need to filter those out | 15:27 |
| ganso | tbarron: although, filtering those, could potentially filter real problem | 15:27 |
| ganso | tbarron: s/problem/problems | 15:27 |
| tbarron | ganso: right, we'd need to post-process. Cause in general that kind of thing is worth catching. | 15:27 |
| ganso | so what I would like to ask is how we would approach: | 15:28 |
| tbarron | We'd need a smart filter that just exempts mock | 15:28 |
| ganso | 1) would we keep pylint as a non-voting job, look at its warning and decide if it is relevant or not | 15:28 |
| ganso | or 2) would we enforce that people submit code that does not generatet pylint warnings | 15:28 |
| tbarron | well #1 for now I think | 15:28 |
| * ganso needs to increase the keyboard repeat interval | 15:29 | |
| tbarron | it's criteria for pass/fail isn't good enough yet | 15:29 |
| tbarron | its | 15:29 |
| tbarron | (possesive, not the contraction) | 15:29 |
| ganso | #1 requires more work, if we intend to do it in the long term | 15:30 |
| tbarron | ganso: I think we've raised awareness and maybe people will seize the day and make improvements as we go forwards. | 15:30 |
| ganso | as we need to check the job result | 15:30 |
| tbarron | #2 is great but it assumes we know how to achieve it. | 15:30 |
| ganso | and validate if the code being proposed is good or not | 15:31 |
| tbarron | ganso: if you know how to achieve #2 please propose a patch; otherwise we are stuck making incremental improvements and reminding people to look at the output and think about the results | 15:31 |
| ganso | tbarron: we kinda do. Pylint is only checking the changes, so let's say, if we start coding it in a way that does not generate warnings as soon as Train cycle starts, we will not have problems | 15:31 |
| tbarron | ganso: we'll still have warnings about asserts in mocks | 15:32 |
| ganso | tbarron: at least on my changes, I can just mock it in a different way and the warnings go away | 15:32 |
| tbarron | for one example | 15:32 |
| ganso | tbarron: but I don't want to rewrite all my 1000 lines of unit tests before Stein's feature freeze | 15:32 |
| tbarron | ganso: well I suspect there are things we don't know how to code around yet | 15:33 |
| tbarron | ganso: agree | 15:33 |
| ganso | tbarron: the main problem I see is: people will get confused because of those warnings | 15:33 |
| tbarron | ganso if you change one line in Train it will report on the whole file | 15:33 |
| ganso | tbarron: as I was when I saw then, and the thing it is complaining about is everywhere in the code, but I can't just code in a similar way to what's already there | 15:34 |
| tbarron | so yes, there is danger of confusion but I don't see a fix yet | 15:34 |
| ganso | tbarron: oh yea I forgot about that | 15:34 |
| ganso | tbarron: if someone changes one line in test_manager, that person will never be able to get pylint job to pass haha | 15:34 |
| tbarron | OK, unless there's a slam dunk solution now let's settle for raised awareness now. | 15:35 |
| gouthamr | is it sane for us to revert the pylint change, and re-introduce it after fixing such issues? | 15:35 |
| ganso | gouthamr: it will take us a very long time and a lot of effort to fix all those issues... | 15:35 |
| gouthamr | once we revert, we can run it on the whole tree instead of one commit and catch these errors and fix them | 15:35 |
| tbarron | gouthamr: who is "we" that is going to do the fix? | 15:35 |
| tbarron | gouthamr: whoever that is can propose the revert and fix patches together | 15:36 |
| tbarron | in the mean time we live with this imperfection | 15:36 |
| ganso | tbarron: whoever that is will need to rewrite thousands of lines in test_manager :P | 15:36 |
| gouthamr | ganso: yes, but what was once nearly okay is now failing | 15:36 |
| tbarron | it's not the only imperfect thing in our world, nor IMO the most important | 15:36 |
| tbarron | gouthamr: well IMO it's not a matter of RED or GREEN but of degreee | 15:37 |
| ganso | we could revert the change and and stick to old pylint? | 15:37 |
| gouthamr | ack, but i was under the impression we deleted a bunch of checks/ignores and this was incremental work | 15:37 |
| tbarron | ok, you guys propose it and we'll see | 15:37 |
| gouthamr | but OP is probably busy and didn't follow up on the patches | 15:37 |
| tbarron | well he's busy in cinder, we *asked* him to bring the change over here | 15:38 |
| tbarron | ok, moving on | 15:38 |
| tbarron | #toppic gate issues | 15:38 |
| ganso | *topic | 15:39 |
| tbarron | #topic gate issues | 15:39 |
| *** openstack changes topic to "gate issues (Meeting topic: manila)" | 15:39 | |
| tbarron | ganso: ty | 15:39 |
| * gouthamr is guilty - thanks for raising awareness tbarron ganso | 15:39 | |
| tbarron | here's a fix for the failure to publish the service images when we change them | 15:39 |
| tbarron | it also will bring capability to ssh w/o password | 15:40 |
| tbarron | #link https://review.openstack.org/#/c/631846/ | 15:40 |
| tbarron | please review | 15:40 |
| tbarron | any questions on this one? | 15:40 |
| tbarron | kk | 15:41 |
| tbarron | #topic bugs | 15:41 |
| *** openstack changes topic to "bugs (Meeting topic: manila)" | 15:41 | |
| jgrosso | Hi all | 15:41 |
| gouthamr | o/ jgrosso | 15:41 |
| tbarron | jgrosso has been working to systematize our bug backlog | 15:41 |
| tbarron | and here he is! | 15:41 |
| tbarron | to tell us about it. | 15:41 |
| *** dklyle has quit IRC | 15:41 | |
| jgrosso | ok well let me start byt saying I spent a few days looking at the upstream bus | 15:42 |
| jgrosso | bugs :) | 15:42 |
| jgrosso | my goal is to make the bugs more visible and organize them in a way that makes it easier for the upstream manila community to process and fix bugs more efficiently. | 15:42 |
| jgrosso | I have read bugs that need to be fixed because they were working on a master thesis :) , to high bugs that are not assigned | 15:42 |
| * ganso wants to catch a ride in the upstream bus | 15:43 | |
| jgrosso | so basically I think the upstream bus needs a driver :) | 15:43 |
| jgrosso | I first kept the same triage pad the same https://etherpad.openstack.org/p/manila-bug-triage-pad | 15:43 |
| jgrosso | for now and added high lights to show the existing bugs | 15:43 |
| jgrosso | On a side note I was able to go through about 100 manila bugs and create a google sheet | 15:44 |
| jgrosso | My question is do we have an order to how bugs are triaged, confirmed and assigned? | 15:44 |
| *** ianychoi has joined #openstack-meeting-alt | 15:44 | |
| jgrosso | I am seeing high bugs that are not assigned, some high status bug that were fix committed and not assigned | 15:45 |
| tbarron | jgrosso: we lack systematic process :) | 15:45 |
| tbarron | and welcome your approach | 15:45 |
| jgrosso | I know OpenStack releases hang a long time in some cases, but I would like a plan a system for dealing with bugs so I need some input...I would also like some email so I can send a google doc sheet for people to look at | 15:46 |
| tbarron | jgrosso: i can get you the emails of cores and active reviewers | 15:47 |
| jgrosso | that would be great | 15:47 |
| tbarron | jgrosso: but there's nothing secret so you can also share your sheet here and I can put it in the agenda | 15:47 |
| jgrosso | sounds good | 15:47 |
| jgrosso | so are there any defects from the triage pad that can be talkerd about I would like to understand why we have so many unassigned | 15:48 |
| jgrosso | is it we just dont have the time to work on them? | 15:48 |
| tbarron | jgrosso: there is no manager, there are no employees | 15:48 |
| tbarron | bugs are "assigned" by people taking them | 15:48 |
| tbarron | I think your presenting a fresh, systematic view will help a lot | 15:49 |
| tbarron | but I should shut up | 15:49 |
| jgrosso | ok so are there any bugs that need to be addressed in https://etherpad.openstack.org/p/manila-bug-triage-pad | 15:50 |
| tbarron | ganso: xyang: toabctl: etc may have other or better answers to your questions | 15:50 |
| jgrosso | no that is fine Tom like I said just learning the ropes | 15:50 |
| gouthamr | tremendous work jgrosso! | 15:51 |
| jgrosso | I think organizing this into an easier way to choose bugs may be a better solution, I think taking some of the bugs that have been sitting for years need to be archived some how | 15:51 |
| tbarron | jgrosso: let's have a meeting to go over your sheet and do some clean up of stale bugs | 15:52 |
| jgrosso | I think seeing 300 + bugs makes it hard to choose what bugs to work on. I want to keep going try to organize | 15:52 |
| jgrosso | thanks Gouthamr | 15:52 |
| tbarron | jgrosso: when you are ready I'll get you a list of emails for invitees :) | 15:52 |
| jgrosso | tbarron: thanks that would be helpful | 15:53 |
| gouthamr | we welcome new/sporadic contributions/fixes to these bugs, and when we pick up the bugs ourselves we tend to prioritize and fix stuff on a distributed manner - i've let stuff fall through the cracks over time as you'll notice :D | 15:53 |
| gouthamr | tbarron: +1 | 15:53 |
| * gouthamr uses wrong smiley | 15:53 | |
| jgrosso | :) | 15:53 |
| tbarron | We'll close most of the bugs older than ocata with a note that if the issue is reproducible in supported releases please re-open. | 15:54 |
| jgrosso | Oh yeah I also want to look at Storyboard :) | 15:54 |
| tbarron | but we need to look and see if there are old serious issues that we know are still valid. | 15:54 |
| jgrosso | I like that tbarron | 15:54 |
| jgrosso | agreed | 15:54 |
| tbarron | divide and conquer | 15:54 |
| jgrosso | :) | 15:54 |
| jgrosso | Thanks so much all | 15:55 |
| tbarron | jgrosso: thank you! | 15:55 |
| tbarron | #topic open discussion | 15:55 |
| *** openstack changes topic to "open discussion (Meeting topic: manila)" | 15:55 | |
| tbarron | anything else for today? | 15:55 |
| toabctl | I wanted to ask what we want to do with the open reviews for the netapp driver | 15:55 |
| toabctl | who is the maintainer for that driver? | 15:55 |
| ganso | toabctl: I am | 15:56 |
| toabctl | ganso, could you have a look at https://review.openstack.org/#/c/558465/ and https://review.openstack.org/#/c/619573/ then please? | 15:56 |
| ganso | toabctl: I will as soon as I have some time | 15:56 |
| *** liuyulong has quit IRC | 15:57 | |
| toabctl | ok. theses are already month old and not to complicated. thanks! | 15:57 |
| carthaca | ganso: thanks :) | 15:57 |
| tbarron | carthaca: thanks for your work, you guys should get a discount from netapp :) | 15:58 |
| gouthamr | #freeONTAP | 15:58 |
| *** TxGirlGeek has joined #openstack-meeting-alt | 15:58 | |
| gouthamr | heh, #freeBeer | 15:58 |
| toabctl | lol | 15:58 |
| tbarron | Well let's end smiling today. | 15:59 |
| tbarron | Thanks everyone! See you in #openstack-manila .... | 15:59 |
| tbarron | #endmeeting | 15:59 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:59 | |
| openstack | Meeting ended Thu Jan 24 15:59:55 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-01-24-15.00.html | 15:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-01-24-15.00.txt | 16:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-01-24-15.00.log.html | 16:00 |
| *** carthaca has left #openstack-meeting-alt | 16:01 | |
| *** dave-mccowan has joined #openstack-meeting-alt | 16:04 | |
| *** dklyle has joined #openstack-meeting-alt | 16:04 | |
| *** jrbalderrama has quit IRC | 16:06 | |
| *** gyee has joined #openstack-meeting-alt | 16:06 | |
| *** tssurya has quit IRC | 16:08 | |
| *** e0ne has quit IRC | 16:09 | |
| *** dave-mccowan has quit IRC | 16:09 | |
| *** ttsiouts has quit IRC | 16:11 | |
| *** gyee has quit IRC | 16:14 | |
| *** efried has joined #openstack-meeting-alt | 16:18 | |
| *** efried is now known as efried_2dmtg | 16:18 | |
| *** ccamacho has quit IRC | 16:23 | |
| *** gyee has joined #openstack-meeting-alt | 16:25 | |
| *** macza has joined #openstack-meeting-alt | 16:33 | |
| *** panda is now known as panda|off | 16:40 | |
| *** lujinluo has joined #openstack-meeting-alt | 17:00 | |
| *** bhavikdbavishi has quit IRC | 17:01 | |
| *** yamamoto has joined #openstack-meeting-alt | 17:13 | |
| *** kopecmartin is now known as kopecmartin|off | 17:18 | |
| *** yamamoto has quit IRC | 17:18 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 17:20 | |
| *** ccamacho has joined #openstack-meeting-alt | 17:28 | |
| *** dklyle has quit IRC | 17:40 | |
| *** whoami-rajat has quit IRC | 17:43 | |
| *** dims has quit IRC | 17:43 | |
| *** dims has joined #openstack-meeting-alt | 17:48 | |
| *** dklyle has joined #openstack-meeting-alt | 17:50 | |
| *** ganso has left #openstack-meeting-alt | 17:51 | |
| *** dims has quit IRC | 17:54 | |
| *** dims has joined #openstack-meeting-alt | 17:55 | |
| *** lujinluo has quit IRC | 17:57 | |
| *** e0ne has joined #openstack-meeting-alt | 17:59 | |
| *** yamahata has quit IRC | 18:03 | |
| *** iyamahat has quit IRC | 18:03 | |
| *** igordc has joined #openstack-meeting-alt | 18:04 | |
| *** derekh has quit IRC | 18:09 | |
| *** e0ne has quit IRC | 18:13 | |
| *** lujinluo has joined #openstack-meeting-alt | 18:13 | |
| *** lujinluo has quit IRC | 18:14 | |
| *** sridharg has quit IRC | 18:14 | |
| *** iyamahat has joined #openstack-meeting-alt | 18:17 | |
| *** whoami-rajat has joined #openstack-meeting-alt | 18:20 | |
| *** iyamahat_ has joined #openstack-meeting-alt | 18:21 | |
| *** iyamahat has quit IRC | 18:24 | |
| *** e0ne has joined #openstack-meeting-alt | 18:27 | |
| *** yamahata has joined #openstack-meeting-alt | 18:36 | |
| *** ccamacho has quit IRC | 18:38 | |
| *** armstrong has quit IRC | 18:40 | |
| *** efried_2dmtg1 has joined #openstack-meeting-alt | 18:57 | |
| *** efried_2dmtg has quit IRC | 18:59 | |
| *** efried_2dmtg1 is now known as efried_2dmtg | 18:59 | |
| *** TxGirlGe_ has joined #openstack-meeting-alt | 18:59 | |
| *** TxGirlGeek has quit IRC | 19:00 | |
| *** e0ne has quit IRC | 19:02 | |
| *** ijw has joined #openstack-meeting-alt | 19:07 | |
| *** bhavikdbavishi has quit IRC | 19:11 | |
| *** hongbin has quit IRC | 19:20 | |
| *** hongbin has joined #openstack-meeting-alt | 19:22 | |
| *** hongbin has quit IRC | 19:22 | |
| *** baojg has quit IRC | 19:22 | |
| *** hongbin has joined #openstack-meeting-alt | 19:25 | |
| *** e0ne has joined #openstack-meeting-alt | 19:26 | |
| *** TxGirlGe_ has quit IRC | 19:32 | |
| *** dklyle has quit IRC | 19:37 | |
| *** iyamahat__ has joined #openstack-meeting-alt | 19:40 | |
| *** isq_ has joined #openstack-meeting-alt | 19:41 | |
| *** iyamahat_ has quit IRC | 19:42 | |
| *** yamahata has quit IRC | 19:42 | |
| *** isq has quit IRC | 19:42 | |
| *** e0ne has quit IRC | 19:54 | |
| *** jgrosso has quit IRC | 19:55 | |
| *** yamahata has joined #openstack-meeting-alt | 19:56 | |
| *** yamamoto has joined #openstack-meeting-alt | 20:00 | |
| *** erlon_ has quit IRC | 20:02 | |
| *** dklyle has joined #openstack-meeting-alt | 20:15 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 20:26 | |
| *** whoami-rajat has quit IRC | 20:43 | |
| *** rcernin has joined #openstack-meeting-alt | 21:02 | |
| *** baojg has joined #openstack-meeting-alt | 21:23 | |
| *** carlos_silva has quit IRC | 21:23 | |
| *** baojg has quit IRC | 21:27 | |
| *** jesusaur has joined #openstack-meeting-alt | 21:45 | |
| *** slaweq has quit IRC | 22:10 | |
| *** rcernin has quit IRC | 22:11 | |
| *** rcernin has joined #openstack-meeting-alt | 22:12 | |
| *** bswartz has quit IRC | 22:14 | |
| *** slaweq has joined #openstack-meeting-alt | 22:17 | |
| *** jcoufal has quit IRC | 22:36 | |
| *** dklyle has quit IRC | 22:52 | |
| *** baojg has joined #openstack-meeting-alt | 22:53 | |
| *** hongbin has quit IRC | 22:54 | |
| *** slaweq has quit IRC | 23:04 | |
| *** masahito has joined #openstack-meeting-alt | 23:10 | |
| *** dklyle has joined #openstack-meeting-alt | 23:11 | |
| *** slaweq has joined #openstack-meeting-alt | 23:11 | |
| *** masahito has quit IRC | 23:15 | |
| *** TxGirlGeek has quit IRC | 23:15 | |
| *** slaweq has quit IRC | 23:15 | |
| *** dklyle has quit IRC | 23:19 | |
| *** dave-mccowan has joined #openstack-meeting-alt | 23:31 | |
| *** erlon has joined #openstack-meeting-alt | 23:36 | |
| *** dklyle has joined #openstack-meeting-alt | 23:51 | |
| *** baojg has quit IRC | 23:55 | |
| *** dave-mccowan has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!