| opendevreview | tspyderboy proposed openstack/python-manilaclient master: "--wait" option added for managing/unmanaging a share snapshot https://review.opendev.org/c/openstack/python-manilaclient/+/913201 | 03:36 |
|---|---|---|
| AachalSaxena[m] | hello, I am actually new to open source, please guide me as I want to contribute for outreachy | 04:50 |
| ccokeke[m] | <AachalSaxena[m]> "hello, I am actually new to open..." <- Aachal Saxena: you can find these links helpful for setting up devstack on your environment: | 05:05 |
| ccokeke[m] | https://medium.com/@shuvamkumarsk1/setup-devstack-in-virtualbox-e09d9f9e2d84 --- use this in conjunction with the local.conf from https://docs.openstack.org/manila/latest/contributor/development-environment- | 05:05 |
| AachalSaxena[m] | Am on linux system, it is necessary to work with vm ware? | 07:23 |
| ccokeke[m] | AachalSaxena[m]: Use virtualbox unless your host OS is window | 07:26 |
| AachalSaxena[m] | sure! thanks | 07:31 |
| opendevreview | christian okeke proposed openstack/manila master: Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 12:38 |
| opendevreview | christian okeke proposed openstack/manila master: Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 12:41 |
| ccokeke[m] | carloss_: please review Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 13:45 |
| opendevreview | Merged openstack/puppet-manila master: Add max_over_subscription_ratio parameter https://review.opendev.org/c/openstack/puppet-manila/+/913469 | 15:27 |
| * ccokeke[m] sent a code block: https://matrix.org/_matrix/media/v3/download/matrix.org/fvRVXZYmfLpLYXVeGEChdEzC | 16:49 | |
| ccokeke[m] | Hi gouthamr: I just to clarify, I suppose I also need to pass the admin context in this command. I believe that is why the test failed here | 16:50 |
| gouthamr | ccokeke[m]: is this failure on the CI? | 16:51 |
| gouthamr | ccokeke[m]: was asking to see if its code i can look at on gerrit; but it looks like you're using a fake string for the context, instead of a mocked context object | 16:52 |
| gouthamr | ccokeke[m]: there must be examples in teh tests for mocking context correctly.. | 16:53 |
| ccokeke[m] | gouthamr: yes | 16:53 |
| ccokeke[m] | gouthamr: I am mocking the admin context with `admin_ctxt` | 16:55 |
| ccokeke[m] | https://review.opendev.org/c/openstack/manila/+/911694/12/manila/tests/cmd/test_manage.py#452 | 16:57 |
| gouthamr | ccokeke[m]: yeah, you're invoking a real db method; that might be an issue - here's an example on how to create a fake context object: https://github.com/openstack/manila/blob/0c8cc2333b881af3cb3206d2a45f52aab5e77ff5/manila/tests/test_context.py#L22-L23 ; try this instead.. | 17:01 |
| opendevreview | Merged openstack/manila master: Fix the link to get the next share replica https://review.opendev.org/c/openstack/manila/+/911709 | 17:46 |
| tspyderboy[m] | Hi gouthamr to get the changes merged, do I have to do something more? | 17:48 |
| gouthamr | tspyderboy[m]: i presume you're referring to https://review.opendev.org/c/openstack/python-manilaclient/+/913201 ? | 18:03 |
| tspyderboy[m] | <gouthamr> "tspyderboy: i presume you're..." <- Yup | 18:09 |
| gouthamr | tspyderboy[m]: you need another review; i've copied carloss ... | 18:09 |
| * carloss on it | 18:09 | |
| gouthamr | thanks carloss | 18:10 |
| tspyderboy[m] | gouthamr: Thanks, for correcting Topic name, will follow the specified format from next time | 18:10 |
| gouthamr | tspyderboy[m]: no worries; it just helps us track stuff; what's your launchpad ID? | 18:11 |
| gouthamr | nvm, found it.. assigning the bug to you | 18:12 |
| tspyderboy[m] | Thank You carloss and gouthamr | 18:53 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/2024.1: Fix the link to get the next share replica https://review.opendev.org/c/openstack/manila/+/913803 | 18:57 |
| opendevreview | Merged openstack/python-manilaclient master: "--wait" option added for managing/unmanaging a share snapshot https://review.opendev.org/c/openstack/python-manilaclient/+/913201 | 19:03 |
| carloss | yw | 19:05 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [doc] Admin only modifiable metadata https://review.opendev.org/c/openstack/manila/+/913845 | 20:50 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [doc] Mount options in the ceph native driver https://review.opendev.org/c/openstack/manila/+/913846 | 20:50 |
| opendevreview | jayaanand borra proposed openstack/manila master: Human readable export location documentation https://review.opendev.org/c/openstack/manila/+/913709 | 21:27 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [doc] add instructions regarding healthchecks https://review.opendev.org/c/openstack/manila/+/913852 | 23:14 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [doc] add instructions regarding healthchecks https://review.opendev.org/c/openstack/manila/+/913852 | 23:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!