| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp]: Fix issues with managed snapshot https://review.opendev.org/c/openstack/manila/+/857627 | 01:34 |
|---|---|---|
| opendevreview | Felipe Rodrigues proposed openstack/manila master: Fix Create From Snapshot with Server Limits https://review.opendev.org/c/openstack/manila/+/857628 | 02:34 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp]: Fix issues with managed snapshot https://review.opendev.org/c/openstack/manila/+/857627 | 02:35 |
| opendevreview | Merged openstack/manila-tempest-plugin master: Use ddt.named_data decorator to avoid random test names https://review.opendev.org/c/openstack/manila-tempest-plugin/+/855813 | 03:53 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [RBAC] Return 404 if share is inaccessible https://review.opendev.org/c/openstack/manila/+/857807 | 05:14 |
| opendevreview | kiran pawar proposed openstack/manila master: Add defaultadsite to security service https://review.opendev.org/c/openstack/manila/+/855220 | 06:54 |
| opendevreview | kiran pawar proposed openstack/python-manilaclient master: Add defaultadsite to security service https://review.opendev.org/c/openstack/python-manilaclient/+/855690 | 07:14 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Replace period to underscore https://review.opendev.org/c/openstack/manila-tempest-plugin/+/857826 | 08:22 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Add S-RBAC tests for manila https://review.opendev.org/c/openstack/manila-tempest-plugin/+/805938 | 09:55 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: Change to use iproute2 instead of brctl https://review.opendev.org/c/openstack/manila/+/852006 | 10:39 |
| *** dviroel|afk is now known as dviroel | 11:31 | |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp] Fix DHSS mode fails to create share on a new pool https://review.opendev.org/c/openstack/manila/+/834503 | 11:53 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [RBAC] Retain legacy admin behaviour https://review.opendev.org/c/openstack/manila/+/856394 | 15:35 |
| opendevreview | Ashley Rodriguez proposed openstack/manila-tempest-plugin master: [WIP] share group type create validation check https://review.opendev.org/c/openstack/manila-tempest-plugin/+/842216 | 15:49 |
| opendevreview | Ashley Rodriguez proposed openstack/manila master: Add group spec validation to share group types https://review.opendev.org/c/openstack/manila/+/809004 | 15:50 |
| *** dviroel is now known as dviroel|lunch | 15:59 | |
| opendevreview | kiran pawar proposed openstack/manila master: [NetApp] check snapshot presence after creation https://review.opendev.org/c/openstack/manila/+/840673 | 16:07 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Expect 404 for unauthorized share access https://review.opendev.org/c/openstack/manila-tempest-plugin/+/857933 | 16:36 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [RBAC] Return 404 if share is inaccessible https://review.opendev.org/c/openstack/manila/+/857807 | 16:41 |
| gouthamr | felipe_rodrigues: o/ regarding https://review.opendev.org/c/openstack/manila/+/840673 --- i think i'm okay with that extra call to check for the snapshot - it's better to be sure and give the user another opportunity to create a snapshot rather than realize later that the snap wasn't ever created | 16:53 |
| gouthamr | am i missing any harm in that check? | 16:53 |
| gouthamr | like is there a way the storage is still processing the snapshot request but doesn't find a record, but creates the snapshot anyway? | 16:54 |
| felipe_rodrigues | I got it. | 17:02 |
| felipe_rodrigues | the main problem is about adding more one extra call to the storage that is not required. Is there any possibility to the API to return as created and it was not created ? It seems more like " i dont trust on my API response".. If we don't trust to the snapshot, why is it trusting to the other create/modify operations ? | 17:07 |
| gouthamr | ack; but in this case, unlike shares, the resource (snapshot) may not be used right away | 17:08 |
| felipe_rodrigues | it sounds more like a guess from the customer that the snapshot disappear because it was not created during the API call... We need to understand it deeply | 17:08 |
| felipe_rodrigues | that's my point, can we reproduce it ? | 17:08 |
| felipe_rodrigues | I received an email from them, explaining that they found that the snapshot disappear because it was manually deleted | 17:09 |
| gouthamr | totally worth asking - but on the bug i see this happened on "busy" clusters | 17:09 |
| *** dviroel|lunch is now known as dviroel | 17:09 | |
| felipe_rodrigues | I got it.. | 17:10 |
| gouthamr | i see, can you check if they are okay marking this bug invalid? | 17:10 |
| gouthamr | kiran may be the one responding, we can kick this off of the bugsquash and see if we can get some more data | 17:11 |
| felipe_rodrigues | We need to understand the issue better... | 17:11 |
| felipe_rodrigues | I want to see if the bug is on the ONTAP API.. If so, we need to report it as a burt | 17:11 |
| felipe_rodrigues | I'd be okay of adding this extra call, but we need to make totally sure that it makes sense.. that it is required.. at least from my side, it seems more like a guess.. | 17:12 |
| gouthamr | ack | 17:14 |
| felipe_rodrigues | The e-mail that I received: | 17:15 |
| felipe_rodrigues | SAP reported “missing” snapshots on the storage while they are still showing up in the OpenStack / manila repository. | 17:15 |
| felipe_rodrigues | 17:15 | |
| felipe_rodrigues | Although they’ve found an explanation in the meantime (the snapshots were deleted manually) | 17:15 |
| gouthamr | felipe_rodrigues: do post these thoughts on the review and add the deletion thingy that they mentioned | 17:15 |
| felipe_rodrigues | not yet | 17:16 |
| felipe_rodrigues | I'll add more info | 17:16 |
| gouthamr | thanks felipe_rodrigues | 17:17 |
| felipe_rodrigues | yw | 17:17 |
| opendevreview | Ashley Rodriguez proposed openstack/manila-tempest-plugin master: [WIP] share group type create validation check https://review.opendev.org/c/openstack/manila-tempest-plugin/+/842216 | 18:01 |
| opendevreview | Merged openstack/manila master: Change to use iproute2 instead of brctl https://review.opendev.org/c/openstack/manila/+/852006 | 18:16 |
| gouthamr | felipe_rodrigues: i posted on the patch, take a look when you get a chance | 18:23 |
| felipe_rodrigues | nice, thanks :) | 18:23 |
| gouthamr | wow https://bugs.launchpad.net/manila/+bug/1936648 | 18:27 |
| gouthamr | :P | 18:27 |
| gouthamr | its an interesting bug at the confluence of features | 18:28 |
| gouthamr | maybe we should add a scenario test with the reproduction steps felipe_rodrigues | 18:28 |
| felipe_rodrigues | you mean, add a tempest test ? or add on our internal tempest tests ? | 19:09 |
| felipe_rodrigues | We lost the reference between manila and storage | 19:10 |
| gouthamr | the test could be generic | 19:10 |
| felipe_rodrigues | I don't know if this is a problem with NetApp snapshot revert process only, or it is the common behavior with other vendors too | 19:10 |
| gouthamr | create share, write data, create snapshot, rename snapshot, unmanage/remanage snapshot, revert to snapshot, delete everything | 19:11 |
| felipe_rodrigues | rename snapshot ? can the Manila force it ? | 19:11 |
| gouthamr | ah | 19:11 |
| gouthamr | good point | 19:11 |
| felipe_rodrigues | I see that other vendors dont rename during manage process | 19:12 |
| felipe_rodrigues | dell doesn't rename.. huawei does.. like NetApp | 19:15 |
| felipe_rodrigues | At least on NetApp end, the snapshot is just a file inside the share. So, reverting to a point of the share, also means reverting the snapshot name itself | 19:16 |
| felipe_rodrigues | btw, good catch goutham: https://review.opendev.org/c/openstack/manila/+/857627/2//COMMIT_MSG#15 | 19:19 |
| gouthamr | ++ | 19:33 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: DNM: test manila https://review.opendev.org/c/openstack/manila/+/857951 | 20:15 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: [RBAC] Enforce check for share updates https://review.opendev.org/c/openstack/manila/+/857980 | 20:57 |
| opendevreview | Merged openstack/manila master: [NetApp] Fix lack of retry HTTP requests https://review.opendev.org/c/openstack/manila/+/840431 | 21:18 |
| *** dviroel is now known as dviroel|out | 21:45 | |
| opendevreview | Merged openstack/manila master: [RBAC] Retain legacy admin behaviour https://review.opendev.org/c/openstack/manila/+/856394 | 22:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!