| opendevreview | Goutham Pacha Ravi proposed openstack/python-manilaclient master: WIP: Metadata for all user facing resources https://review.opendev.org/c/openstack/python-manilaclient/+/803424 | 06:37 |
|---|---|---|
| opendevreview | Archana Kumari proposed openstack/python-manilaclient master: [OSC] Implement Share Group Commands https://review.opendev.org/c/openstack/python-manilaclient/+/801740 | 07:49 |
| fzzf | carloss: I get it. thank you very much! | 11:10 |
| carloss | fzzf: you're welcome | 11:11 |
| *** dviroel|out is now known as dviroel | 11:25 | |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp] Add readable replication type support https://review.opendev.org/c/openstack/manila/+/803621 | 15:09 |
| opendevreview | Felipe Rodrigues proposed openstack/manila master: [NetApp] Add FlexGroup volume support https://review.opendev.org/c/openstack/manila/+/803622 | 15:10 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Share server migration enhancements https://review.opendev.org/c/openstack/manila/+/803623 | 15:16 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [NetApp] Share server migration through SVM migrate https://review.opendev.org/c/openstack/manila/+/803624 | 15:18 |
| opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add cleanup_source_server to share server migration start https://review.opendev.org/c/openstack/python-manilaclient/+/803626 | 15:25 |
| dviroel | o.O | 15:32 |
| opendevreview | kiran pawar proposed openstack/manila master: Early validate for CIFS without security service. https://review.opendev.org/c/openstack/manila/+/776875 | 15:33 |
| vkmc | hi all, I could use some reviews in https://review.opendev.org/c/openstack/manila/+/801336 | 15:54 |
| vkmc | I saw ashrodri already reviewed :) thx | 15:54 |
| ashrodri | happy to help | 15:55 |
| opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add cleanup_source_server to share server migration start https://review.opendev.org/c/openstack/python-manilaclient/+/803626 | 17:12 |
| ganso__ | carloss: apologies in advance as I didn't read the spec or participate in the discussion about share server migration, but I'm curious on why would you need an option to choose whether to remove the source share server after migration, since the operation is a "migration", not a clone, copy, or replicate. It sounds more semantically correct to me to make all the validations possible (or even a --confirm as a last step) to make sure the destination | 17:19 |
| ganso__ | share server is functioning properly and the source share server is safely cleaned up at the end of a server migration, if that's the concern | 17:19 |
| ganso__ | in other words I'm just saying that IMO it should be a mandatory step and not optional | 17:20 |
| carloss | o/ ganso__ :) | 17:39 |
| carloss | this operation is more to allow administrators to define whether the share server should immediately be deleted after the share server migration. In the current design, the source share server has its status set to inactive after the share server migration gets completed, and it will remain there for some time, until the administrator decides to trigger the deletion of the share server, or the periodic job to remove | 17:42 |
| carloss | unused share servers is executed | 17:42 |
| carloss | so in this case, we'd need to force the share server to be completely deleted after the administrator triggers `share-server-migration-complete` | 17:43 |
| * carloss realized he didn't add the part where the share server is actually deleted in share/manager in the change submitted upstream | 17:44 | |
| ganso__ | carloss: what was the concern that led to this decision of setting it to inactive instead of deleting it as soon as share server is functional at the destination? | 17:44 |
| carloss | I can't remember from the top of my head... will take a look in the spec and the comments in the main change | 17:48 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [NetApp] Share server migration through SVM migrate https://review.opendev.org/c/openstack/manila/+/803624 | 17:50 |
| ganso__ | carloss: I'm looking at https://review.opendev.org/c/openstack/manila/+/747043/10/manila/share/manager.py#5289 | 17:57 |
| ganso__ | carloss: from that patch it doesn't seem like it wouldn't be deleted | 18:02 |
| ganso__ | looking at the master code now, it is the same | 18:03 |
| ganso__ | carloss: the only reason I see to have the option is in case if CONF.delete_share_server_with_last_share is false | 18:04 |
| ganso__ | because in that case it would never be deleted | 18:04 |
| carloss | yep... that is the case | 18:05 |
| carloss | so this new parameter would be forcing share servers to be deleted even if CONF.delete_share_server_with_last_share is set to False | 18:06 |
| ganso__ | carloss: https://review.opendev.org/c/openstack/manila/+/803623/1/manila/share/driver.py#2913 why is it in the driver level? It seems redundant with the manager's functionality. I believe you could override the CONF in the manager in that particular scenario and then call delete_share_server just like _check_delete_share_server does | 18:09 |
| opendevreview | Merged openstack/manila master: Deprecate create snapshot from share group in CephFS https://review.opendev.org/c/openstack/manila/+/801336 | 18:24 |
| carloss | your suggestion would work properly as well | 18:26 |
| carloss | ganso: could you please add these concerns in the change? :) | 18:26 |
| carloss | so we can have them documented and we keep track of the discussion history in the change | 18:26 |
| ganso__ | carloss: sure, I thought about this it here first because I thought I was missing context or previous discussions so I wouldn't pollute the gerrit change, but seems to not be entirely the case =) | 18:28 |
| opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add cleanup_source_server to share server migration start https://review.opendev.org/c/openstack/python-manilaclient/+/803626 | 19:14 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org is going down for a quick restart to adjust its database connection configuration, and should return to service momentarily | 20:03 | |
| opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add cleanup_source_server to share server migration start https://review.opendev.org/c/openstack/python-manilaclient/+/803626 | 20:38 |
| opendevreview | kiran pawar proposed openstack/manila master: Early validate for CIFS without security service. https://review.opendev.org/c/openstack/manila/+/776875 | 20:41 |
| opendevreview | kiran pawar proposed openstack/manila master: Early validate for CIFS without security service. https://review.opendev.org/c/openstack/manila/+/776875 | 20:45 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [NetApp] Share server migration through SVM migrate https://review.opendev.org/c/openstack/manila/+/803624 | 20:59 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Share server migration enhancements https://review.opendev.org/c/openstack/manila/+/803623 | 22:03 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [NetApp] Share server migration through SVM migrate https://review.opendev.org/c/openstack/manila/+/803624 | 22:03 |
| opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add cleanup_source_server to share server migration start https://review.opendev.org/c/openstack/python-manilaclient/+/803626 | 22:34 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!