Friday, 2021-07-02

opendevreviewGoutham Pacha Ravi proposed openstack/manila stable/wallaby: Fix ipaddress issues in the infinidat driver  https://review.opendev.org/c/openstack/manila/+/79913600:08
opendevreviewMerged openstack/manila master: Fix ipaddress issues in the infinidat driver  https://review.opendev.org/c/openstack/manila/+/79910700:54
opendevreviewTakashi Kajinami proposed openstack/manila master: Migrate all quota parameters to [quota] section.  https://review.opendev.org/c/openstack/manila/+/79913001:46
opendevreviewGoutham Pacha Ravi proposed openstack/manila stable/wallaby: TrivialFix: Fix the filter name in config helper  https://review.opendev.org/c/openstack/manila/+/79913704:54
opendevreviewTakashi Kajinami proposed openstack/manila master: Migrate all quota parameters to [quota] section.  https://review.opendev.org/c/openstack/manila/+/79913005:49
*** dviroel|out is now known as dviroel11:34
opendevreviewMerged openstack/manila stable/wallaby: Fix ipaddress issues in the infinidat driver  https://review.opendev.org/c/openstack/manila/+/79913612:02
opendevreviewTom Barron proposed openstack/manila stable/wallaby: Adds a clear error message to operator-set limits  https://review.opendev.org/c/openstack/manila/+/79888212:14
opendevreviewTom Barron proposed openstack/manila stable/wallaby: Add Ceph version check  https://review.opendev.org/c/openstack/manila/+/79795512:14
felipe_rodrigueshi guys, I am getting an error while running the test `test_add_multiple_share_replicas` [1], I dont have enough pools for creating 2 replicas. In fact, I would expect that the test is skipped in that scenario. There is a skip condition in the test [2]. The problem is: the skip is looking if I have 3 pools using the REPLICATION DOMAIN (I have) , but the test is creating the replicas using the AVAILABILITY ZONE. 12:21
felipe_rodriguesShould the skip be checking the number of pools in the replication domain within the target az ?! 12:21
felipe_rodrigues[1] https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/test_replication.py#L23812:21
felipe_rodrigues[2]  https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/api/test_replication.py#L24412:21
dviroelhey felipe_rodrigues, i remember that issue :)12:26
dviroelthe test don't check if there is 2 pools in the destination az, indeed12:27
dviroelit only checks the total number of pools12:27
dviroelthe way that was working in netapp ci, was to have 2 pools in each AZ12:27
dviroelor12:27
dviroelyou can fiz the test to check if there is more than one pool in the destination az, and skip the test in case if that check fails12:28
dviroelwould be better to fix the test ;)12:28
dviroelonly netapp driver currently test that, i don't think that there is another driver running this test12:29
dviroelthe netapp setup was: 2 pools in backend A, 1 pool in backend B and another pool in backend C. Backends B and C were in the same cluster.12:30
dviroelsomthing like that12:30
dviroelto increase the possibilities of create share from snapshot in another pool/backend, iirc12:31
felipe_rodriguesthank you Douglas! NetApp tests are passing, the only problem was that one of the pools in the replica AZ could not get it up (some issues in the netapp CI). Then, this test failed.. I spent a time thinking that my patch is doing something.. debugging it.. while whether the skip is coded correctly, I did not need to spend that time... So, I'm just confirming that this is a wrong test implementation,  so I can 12:47
felipe_rodriguesprovide a fix for avoiding that misunderstanding while reading the test logs.12:47
dviroelfelipe_rodrigues++ thanks12:51
dviroelthe code to filter pools by backend or azs is already at some other tests12:52
felipe_rodriguesgood.. i'll have a look at it! thks13:00
dviroel++13:02
opendevreviewMerged openstack/manila master: Handle service client authorization errors  https://review.opendev.org/c/openstack/manila/+/78390414:08
*** dviroel is now known as dviroel|lunch14:51
batrickgouthamr: vkmc: tbarron: did the volume_prefix passed to CephFSVolumeClient change in manila?16:12
batrickdid you ever set it?16:12
batrickfrankly i'm confused how this code wasn't always stat'ing an empty string which should result in a fault16:14
gouthamrbatrick: o/ nope, it was always /volumes 16:15
batrickit's a mystery then16:15
batrickanyway, i have a fix in the works16:15
*** dviroel|lunch is now known as dviroel16:16
gouthamrbatrick: awesome - i've an environment where this doesn't break, that we can trace the empty stat on it16:16
batrickactually you can apply my patch in the container to see if it resolves the issue for you?16:17
batrickit just changes ceph_volume_client.py16:17
batrickhttps://github.com/ceph/ceph/pull/4215916:18
batricki'll have a nautilus backport up shortly16:18
batrickrraja: let's chat here 16:20
rrajabatrick, sure16:24
gouthamrbatrick: ack; lemme give it a shot16:24
batrickyes i suspected that nautilus qa would have instances of the empty path stat16:25
rrajathanks for the fix, batrick16:25
batricki don't know why this is a problem only for manila16:25
batrickbrb16:25
rrajayeah, recent testing of v14.2.22 's ceph_volume_client on centos also passed16:33
batrickgouthamr: https://github.com/ceph/ceph/pull/4216216:43
rrajabatrick, https://github.com/ceph/ceph/pull/42159#issuecomment-873130064 what do you think?17:06
gouthamrbatrick++ no more aborts on volume creation; doing some more tests17:07
rrajagreat!!17:07
batrickrraja: thanks, i forgot that17:07
rrajabatrick, thanks for root causing and sending the fix17:08
gouthamrcrud works like a charm17:09
gouthamrwill get some functional tests running to verify17:09
gouthamro/ vhari: need some help17:17
gouthamrvhari: i've manually created/deleted shares on sealusa19 after applying batrick's fix; i was wondering if you could take a look for sanity17:18
* gouthamr ¯\_(ツ)_/¯ wrong network 17:18
vharigouthamr,  aye good news .. sure will do 17:20
dviroel(⊙‿⊙)17:27
opendevreviewGoutham Pacha Ravi proposed openstack/manila stable/victoria: Fix ipaddress issues in the infinidat driver  https://review.opendev.org/c/openstack/manila/+/79924917:38
gouthamr^ last branch where we support py3817:46
opendevreviewMerged openstack/manila stable/wallaby: TrivialFix: Fix the filter name in config helper  https://review.opendev.org/c/openstack/manila/+/79913719:07
opendevreviewGoutham Pacha Ravi proposed openstack/manila stable/victoria: TrivialFix: Fix the filter name in config helper  https://review.opendev.org/c/openstack/manila/+/79925019:08
simondodsleygouthamr: I've set up a seperate tempest environment and it appears that the test instances created have no routes set so there is no way for the nfs mounts to ever work19:37
simondodsleyno routes to the correct subnet where the share is, that is19:38
simondodsleygouthamr: I suspect the tempest config file is incorrect somehow. Who can help me debug it as I'm not sure I'm up to that from a networking perspective19:41
gouthamrsimondodsley: i see, can you share your tempest.conf; i'll look at the default config in the meantime19:48
*** dviroel is now known as dviroel|brb19:50
simondodsleygouthamr: this is it https://www.irccloud.com/pastebin/7x7icmn8/19:53
gouthamrthanks19:54
simondodsleygouthamr: the instances can ping the tempest host, but nothing else beyond that19:58
gouthamrthe networking section in that config looks correct19:59
gouthamrhttps://github.com/openstack/tempest/blob/5dcdd41ddafa2e455ab0dd0ce0b1d3f3e32caa04/tempest/lib/common/dynamic_creds.py#L365-L36719:59
gouthamrthe router created will be connected to whatever the "public_network_id" points to19:59
* gouthamr looks at the last run of the pure storage ci for tempest log20:00
gouthamr        Body: {"router": {"name": "tempest-TestShareExtendNFS-2101733040-router", "tenant_id": "61e09201775747d38f43ae76073cca15", "external_gateway_info": {"network_id": "f1eef55e-f950-4cf6-ba80-17560460714b"}}}20:01
gouthamrin tempest.conf's [network] section, you have: public_network_id = f1eef55e-f950-4cf6-ba80-17560460714b ; so that's doing the right thing20:02
simondodsleyso that  will explain why the instance can ping the tempest host I guess, but why can't it get out any further20:03
opendevreviewMerged openstack/manila stable/wallaby: Add Ceph version check  https://review.opendev.org/c/openstack/manila/+/79795520:09
*** dviroel|brb is now known as dviroel20:34
* gouthamr is on a call - will be slow to respond for a bit20:34
*** dviroel is now known as dviroel|out21:03

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!