| opendevreview | haixin proposed openstack/manila-specs master: Manila share support Recycle Bin https://review.opendev.org/c/openstack/manila-specs/+/790320 | 02:20 |
|---|---|---|
| opendevreview | haixin proposed openstack/manila-specs master: Manila share support Recycle Bin https://review.opendev.org/c/openstack/manila-specs/+/790320 | 02:42 |
| fzzf1 | Can driver unit test use devstack Queen? Which version is recommended? | 02:48 |
| opendevreview | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Enable http response extraction https://review.opendev.org/c/openstack/manila-tempest-plugin/+/788248 | 04:03 |
| fzzf1 | Can driver unit test use devstack Queen? Which version is recommended? Can anyone help. | 09:23 |
| vkmc | fzzf1, hey! | 09:25 |
| vkmc | fzzf1, what do you mean? | 09:25 |
| vkmc | fzzf1, do you want to run unit tests for manila in stable/queen? | 09:25 |
| vkmc | queens* | 09:26 |
| fzzf1 | vkmc,I'm using devstack queen,I have completed test_drver.py,I am going to perform unit testing | 09:27 |
| vkmc | fzzf1, you should be able to run unit tests with tox | 09:28 |
| fzzf1 | yes,I'm using tox with tox -epy3,but there are conflict here | 09:29 |
| fzzf1 | when I run tox with "-epy3". | 09:30 |
| fzzf1 | "jinja2 2.10 depends on MarkupSafe>=0.23 | 09:31 |
| fzzf1 | The user requested (constraint) markupsafe===1.0" | 09:31 |
| vkmc | fzzf1, can you paste the issue you are seeing on paste.openstack.org? | 09:31 |
| vkmc | fzzf1, let me run this on the CI, see if we can reproduce the same issue | 09:32 |
| fzzf1 | I run tox in my virtual machine. I hava question ,Now I hava finish driver.py and test_driver.py ,Where should I run test | 09:33 |
| fzzf1 | Another question is, am I going to perform unit testing and CI testing? | 09:34 |
| fzzf1 | I'm I am implementing a new driver | 09:34 |
| vkmc | fzzf1, did you already submit the new driver you are implementing for review? | 09:45 |
| vkmc | fzzf1, one thing though, if this is a new driver, it should go to master | 09:46 |
| vkmc | stable/queens is an stable branch and cannot be modified | 09:46 |
| fzzf1 | Not yet, I don’t know what the process is, do I have to test it myself first | 09:46 |
| vkmc | fzzf1, it's ok | 09:47 |
| fzzf1 | I do not understand. What should I do next | 09:48 |
| vkmc | let me get you some docs | 09:51 |
| fzzf1 | Ok thank you so much | 09:51 |
| fzzf1 | vkmc,I downloaded the code from git and added the driver. This should be the latest. My virtual machine is installed devstack queen. | 09:55 |
| vkmc | fzzf1, so if your vm has devstack queens, by default you will have the manila repo in that branch as well | 09:56 |
| vkmc | fzzf1, instead, you should be working on the master branch (devstack master) | 09:56 |
| vkmc | fzzf1, since this is a new driver addition | 09:57 |
| vkmc | fzzf1, does that make sense? | 09:58 |
| tosky | my qyuestion for yesterday is: is queens even supposed to work with py3? | 09:58 |
| tosky | you most likely want to test it with py2 | 09:58 |
| tosky | but be prepared to adapt the code for py3 later (with master) | 09:59 |
| fzzf1 | vkmc,I downloaded the code from master. I do want to submit the code on the master | 09:59 |
| vkmc | fzzf1, I understand, but I'm afraid that the cycle we follow for our development process is like that... new drivers code goes to master | 10:00 |
| vkmc | stable branches only get backports for specific bug fixes | 10:01 |
| vkmc | that way we make sure stable branches are, indeed, stable | 10:01 |
| vkmc | so, even though you can get the tests passing, when you submit it for review, stable maintainers won't approve it | 10:01 |
| vkmc | hope that makes sense | 10:03 |
| fzzf1 | vkmc,I want to submit the code to the master.what should I do, do I need to test it myself, and what is the process? | 10:03 |
| vkmc | cannot find the "how to add a driver section" for manila, but the cinder one might help | 10:03 |
| vkmc | https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver | 10:03 |
| vkmc | I'll keep looking for the manila docs, but that can give you some initial information | 10:05 |
| fzzf1 | Ok, let me check the cinder document, thank you | 10:06 |
| vkmc | fzzf1, anytime | 10:07 |
| opendevreview | Paul Ali proposed openstack/manila master: Adds a clear error message to operator-set limits https://review.opendev.org/c/openstack/manila/+/782856 | 11:56 |
| opendevreview | Paul Ali proposed openstack/manila master: Adds a clear error message to operator-set limits https://review.opendev.org/c/openstack/manila/+/782856 | 12:08 |
| *** dviroel is now known as dviroel|lunch | 16:03 | |
| *** dviroel|lunch is now known as dviroel | 17:08 | |
| *** dviroel is now known as dviroel|out | 21:22 | |
| opendevreview | Merged openstack/manila master: Adds a clear error message to operator-set limits https://review.opendev.org/c/openstack/manila/+/782856 | 23:07 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!