| *** tosky has quit IRC | 00:22 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Filter storage protocol in the scheduler https://review.opendev.org/c/openstack/manila/+/781026 | 01:19 |
|---|---|---|
| *** Reepicheep has quit IRC | 01:23 | |
| *** Reepicheep has joined #openstack-manila | 01:23 | |
| openstackgerrit | Merged openstack/manila-ui master: API v2.44, added 'ou' field to security service https://review.opendev.org/c/openstack/manila-ui/+/774438 | 01:39 |
| *** ivan_lin has quit IRC | 03:04 | |
| *** LinPeiWen has quit IRC | 03:05 | |
| *** LinPeiWen has joined #openstack-manila | 04:47 | |
| *** ivan_lin has joined #openstack-manila | 04:48 | |
| *** vishalmanchanda has joined #openstack-manila | 04:50 | |
| *** sfernand has quit IRC | 05:56 | |
| *** lpetrut has joined #openstack-manila | 07:53 | |
| *** hoonetorg has joined #openstack-manila | 08:03 | |
| *** LinPeiWen has quit IRC | 08:34 | |
| *** tosky has joined #openstack-manila | 08:37 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Stop supporting microversion 2.23 and less https://review.opendev.org/c/openstack/manila-tempest-plugin/+/781074 | 08:53 |
| *** LinPeiWen has joined #openstack-manila | 08:54 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Stop supporting microversion 2.23 and less https://review.opendev.org/c/openstack/manila-tempest-plugin/+/781074 | 09:27 |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Stop supporting microversion 2.23 and less https://review.opendev.org/c/openstack/manila-tempest-plugin/+/781074 | 11:12 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-manilaclient stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/python-manilaclient/+/781381 | 11:22 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-manilaclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-manilaclient/+/781384 | 11:22 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-manilaclient master: Update master for stable/wallaby https://review.opendev.org/c/openstack/python-manilaclient/+/781385 | 11:22 |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-manilaclient master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/python-manilaclient/+/781388 | 11:22 |
| *** carloss has joined #openstack-manila | 11:49 | |
| openstackgerrit | Liron Kuchlani proposed openstack/manila-tempest-plugin master: Stop supporting microversion 2.23 and less https://review.opendev.org/c/openstack/manila-tempest-plugin/+/781074 | 12:40 |
| *** sfernand has joined #openstack-manila | 13:31 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-manila master: Bump requirement of puppetlabs-apache https://review.opendev.org/c/openstack/puppet-manila/+/781468 | 13:37 |
| *** ecsantos has joined #openstack-manila | 13:52 | |
| *** jmlowe has quit IRC | 13:53 | |
| *** jmlowe has joined #openstack-manila | 13:55 | |
| *** ivan_lin has quit IRC | 14:53 | |
| *** lpetrut has quit IRC | 14:53 | |
| *** ivan_lin has joined #openstack-manila | 14:54 | |
| *** felipe_rodrigues has joined #openstack-manila | 15:07 | |
| openstackgerrit | Tom Barron proposed openstack/manila master: Update cephfs drivers to use ceph-mgr client https://review.opendev.org/c/openstack/manila/+/779619 | 15:13 |
| *** lpetrut has joined #openstack-manila | 15:43 | |
| *** lpetrut has quit IRC | 15:55 | |
| eliaswimmer | About my generic share resize bug | 16:00 |
| eliaswimmer | I may need some help with the tests | 16:00 |
| eliaswimmer | As far as I see, there are no actual integration tests spinning up a server etc? | 16:06 |
| openstackgerrit | Merged openstack/python-manilaclient master: Fix test failures for "test_list_shares_by_{filter}" https://review.opendev.org/c/openstack/python-manilaclient/+/780963 | 16:41 |
| gouthamr | eliaswimmer: hi! nope there are no integration tests in the manila repo | 16:55 |
| gouthamr | eliaswimmer: the integration tests are here: https://github.com/openstack/manila-tempest-plugin | 16:55 |
| gouthamr | but those are written in a generic fashion, and can be run against your change | 16:56 |
| eliaswimmer | I think I have found the right spot where I can add my case | 17:04 |
| gouthamr | eliaswimmer: great! add me to review when you're ready | 17:04 |
| eliaswimmer | https://opendev.org/openstack/manila/src/branch/master/manila/tests/share/drivers/test_helpers.py#L366 | 17:04 |
| eliaswimmer | But I am not sure how @ddt.data and @ddt.unpack work | 17:05 |
| eliaswimmer | especially the Boolean at the end | 17:05 |
| eliaswimmer | I am a pytest guy ;) | 17:06 |
| gouthamr | eliaswimmer: unpack is just syntactic sugar - the ddt inputs will ensure the test is repeated once for each of those data parameters, and the unpack puts the two parts of each tuple into the two variables: output, hosts_match | 17:11 |
| eliaswimmer | But it's four parts?! | 17:17 |
| eliaswimmer | oh, two | 17:18 |
| gouthamr | Yes, some of those are long strings broken into multiple lines | 17:18 |
| gouthamr | tripped me up when I looked too :) | 17:18 |
| eliaswimmer | Where are these strings used? I only see it in assert has calls | 17:20 |
| eliaswimmer | but how is output set s.t. it is used in self._helper.disable_access_for_maintenance( | 17:21 |
| eliaswimmer | this test are quite cryptic to me | 17:21 |
| eliaswimmer | ok, think I get it now | 17:23 |
| eliaswimmer | mock is mocking al lot :) | 17:23 |
| eliaswimmer | monkey patching everything | 17:24 |
| gouthamr | yeah we do that to probably keep the boundaries of testing the "unit" in question | 17:24 |
| gouthamr | in this case, we've mocked out the ssh_exec (https://opendev.org/openstack/manila/src/branch/master/manila/tests/share/drivers/test_helpers.py#L378) to a function which responds with the share paths from the ddt inputs | 17:25 |
| eliaswimmer | how can I run a single test? | 17:28 |
| tbarron | tox -epy3 -- manila.tests.share.drivers.cephfs.test_driver.CephFSDriverTestCase.test_delete_share for example | 17:32 |
| eliaswimmer | thx | 17:32 |
| tbarron | Use the directory path for the first part and the last part is class name and test case name | 17:32 |
| openstackgerrit | Merged openstack/manila master: Fix inconsistent ordering caused by low datetime precision. https://review.opendev.org/c/openstack/manila/+/721807 | 17:42 |
| openstackgerrit | Tom Barron proposed openstack/manila master: Update cephfs drivers to use ceph-mgr client https://review.opendev.org/c/openstack/manila/+/779619 | 17:51 |
| eliaswimmer | what do I have to do, to get access to gerrit | 17:52 |
| eliaswimmer | I just uploaded my key there but can't access | 17:53 |
| gouthamr | eliaswimmer: what's the error? | 17:53 |
| eliaswimmer | ssh://eliaswimmer@review.opendev.org:29418/openstack/manila.git did not work. Description: eliaswimmer@review.opendev.org: Permission denied (publickey). | 17:54 |
| gouthamr | eliaswimmer: i did have an issue recently where my "git-review" package had to be updated | 17:55 |
| eliaswimmer | hm, just installed it :) | 17:55 |
| gouthamr | eliaswimmer: git review -v would give you a more detailed log | 17:55 |
| gouthamr | git review -vvv | 17:55 |
| gouthamr | meh, same thing as "git review -v" | 17:56 |
| eliaswimmer | you wrote me that you found some pub key in gerrit already | 17:57 |
| eliaswimmer | but today there was none | 17:58 |
| gouthamr | eliaswimmer: nope, not on gerrit - on launchpad | 17:58 |
| eliaswimmer | ah, and it worked | 17:58 |
| eliaswimmer | even I used my laptop now | 17:59 |
| gouthamr | eliaswimmer: sorry for the social engineering - i got your email from one of your gerrit reviews, and your public keys on your launchpad id | 17:59 |
| eliaswimmer | That was fine | 17:59 |
| *** jv_ has quit IRC | 18:16 | |
| *** ecsantos has quit IRC | 18:35 | |
| *** trident has quit IRC | 19:01 | |
| *** trident has joined #openstack-manila | 19:19 | |
| *** openstackgerrit has quit IRC | 19:34 | |
| *** ewimmer_ has joined #openstack-manila | 19:59 | |
| ewimmer_ | I really don't get it, ssh does not like any of my setup keys | 20:00 |
| gouthamr | ewimmer_: ah very weird | 20:01 |
| gouthamr | Did you sign the ICLA? | 20:01 |
| ewimmer_ | yes | 20:01 |
| gouthamr | although I wonder the error message would say that if you didn’t | 20:01 |
| gouthamr | is the gerrit user name matching your git username? (If it doesn’t, do you have a gerrit config override locally?) | 20:03 |
| gouthamr | another thing to check would be “ssh -vv -p 29418 GERRITUSER@review.opendev.org” | 20:05 |
| gouthamr | and see if the error message there gives you a clue | 20:05 |
| ewimmer_ | I have done so before | 20:06 |
| ewimmer_ | Oh, I should read the actual message! "send_pubkey_test: no mutual signature algorithm" | 20:07 |
| gouthamr | ^ hey this is the error I had with an older git-review | 20:07 |
| gouthamr | Also thanks for sending a screenshot of the gerrit page, I’m comparing it with mine | 20:07 |
| ewimmer_ | I will no try using an ec key | 20:09 |
| ewimmer_ | PubkeyAcceptedKeyTypes +ssh-rsa in client config solves the problem! | 20:11 |
| *** openstackgerrit has joined #openstack-manila | 20:12 | |
| openstackgerrit | Elias Wimmer proposed openstack/manila master: Fix generic share resize with 0.0.0.0/24 access https://review.opendev.org/c/openstack/manila/+/781556 | 20:12 |
| ewimmer_ | Yeah! | 20:12 |
| gouthamr | \o/ | 20:12 |
| gouthamr | good stuff, thank you ewimmer_ - I’ll take a look in a bit, please look out for comments and update your change if necessary | 20:14 |
| gouthamr | I see it’s missing a release note: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html | 20:14 |
| ewimmer_ | I will update it | 20:15 |
| gouthamr | Awesome! | 20:15 |
| gouthamr | http://104.130.124.113/irclogs/%23openstack-infra/%23openstack-infra.2020-10-13.log.html | 20:26 |
| gouthamr | now I recall tbarron and vkmc hitting this when they upgraded their Fedora | 20:27 |
| ewimmer_ | I am on fedora too! | 20:29 |
| *** jv_ has joined #openstack-manila | 20:46 | |
| tbarron | yeah, sorry I wasn't watching this ssh stuff go by here, glad you got it working | 20:56 |
| openstackgerrit | Tom Barron proposed openstack/manila master: Add create share from snapshot in CephFS https://review.opendev.org/c/openstack/manila/+/741560 | 21:03 |
| openstackgerrit | Elias Wimmer proposed openstack/manila master: Fix generic share resize with 0.0.0.0/24 access https://review.opendev.org/c/openstack/manila/+/781556 | 21:04 |
| openstackgerrit | Elias Wimmer proposed openstack/manila master: Fix generic share resize with 0.0.0.0/24 access https://review.opendev.org/c/openstack/manila/+/781556 | 21:08 |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: Add create share from snapshot in CephFS https://review.opendev.org/c/openstack/manila-tempest-plugin/+/778188 | 21:09 |
| *** openstackstatus has quit IRC | 21:26 | |
| *** openstack has joined #openstack-manila | 21:38 | |
| *** ChanServ sets mode: +o openstack | 21:38 | |
| *** openstack has joined #openstack-manila | 22:03 | |
| *** ChanServ sets mode: +o openstack | 22:03 | |
| *** iurygregory has quit IRC | 22:09 | |
| *** iurygregory has joined #openstack-manila | 22:09 | |
| *** ewimmer_ has quit IRC | 22:46 | |
| *** felipe_rodrigues has quit IRC | 23:17 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!