| *** jmlowe has joined #openstack-manila | 00:05 | |
| *** ganso has joined #openstack-manila | 00:05 | |
| openstackgerrit | Zihao Wang proposed openstack/manila master: Remove six.PY3 and six.PY2 https://review.opendev.org/755207 | 01:58 |
|---|---|---|
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient master: Add a waiter to share create/delete https://review.opendev.org/755667 | 02:09 |
| *** jmlowe has quit IRC | 03:21 | |
| *** ganso has quit IRC | 03:21 | |
| *** jmlowe has joined #openstack-manila | 03:49 | |
| *** ganso has joined #openstack-manila | 03:49 | |
| *** tosky has joined #openstack-manila | 07:43 | |
| *** tkajinam has quit IRC | 08:29 | |
| *** tkajinam has joined #openstack-manila | 08:29 | |
| *** tkajinam has quit IRC | 09:18 | |
| *** lpetrut has joined #openstack-manila | 11:44 | |
| *** raildo has joined #openstack-manila | 11:46 | |
| *** eharney has quit IRC | 12:08 | |
| openstackgerrit | Merged openstack/manila stable/ussuri: [NetApp] Fix CIFS promote back issue https://review.opendev.org/753293 | 13:23 |
| openstackgerrit | Carlos Eduardo proposed openstack/manila stable/train: [NetApp] Fix CIFS promote back issue https://review.opendev.org/755787 | 13:25 |
| *** eharney has joined #openstack-manila | 13:56 | |
| *** felipe_rodrigues has joined #openstack-manila | 14:07 | |
| *** dviroel has quit IRC | 14:26 | |
| *** dviroel has joined #openstack-manila | 14:26 | |
| *** vkmc has quit IRC | 14:27 | |
| *** vkmc has joined #openstack-manila | 14:29 | |
| *** jmlowe has quit IRC | 14:40 | |
| *** ganso has quit IRC | 14:40 | |
| *** jmlowe has joined #openstack-manila | 14:40 | |
| *** ganso has joined #openstack-manila | 14:40 | |
| tosky | is there a specific reason why a few manila_tempest_plugin tests use ddt.data(*set([...]) instead of ddt.data([...]) ? | 15:30 |
| tosky | the latter should produce a more stable list of items (because ddt always add the index of the test as part of the name) | 15:31 |
| *** lpetrut has quit IRC | 15:31 | |
| openstackgerrit | zhoulinhui proposed openstack/python-manilaclient master: Use importlib to take place of imp module https://review.opendev.org/748849 | 15:38 |
| openstackgerrit | zhoulinhui proposed openstack/python-manilaclient master: Use importlib to take place of imp module https://review.opendev.org/748849 | 15:40 |
| tbarron | tosky: good question, maybe someone will answer who knows more than I do but I"ll observe that | 15:53 |
| tbarron | there are also test cases where we do a simple tuple of microversions and they seem to work, | 15:54 |
| tosky | yep | 15:54 |
| tbarron | e.g. @ddt.data('1.0', '2.9', LATEST_MICROVERSION) | 15:54 |
| *** eharney has quit IRC | 16:04 | |
| *** eharney has joined #openstack-manila | 16:41 | |
| *** raissa has joined #openstack-manila | 16:50 | |
| gouthamr | "tosky: is there a specific reason why a few manila_tempest_plugin tests use ddt.data(*set([...]) instead of ddt.data([...]) -> | 16:53 |
| gouthamr | to deduplicate the explicit version for the test and the latest microversion - if you see *set, it should always include the "latest microversion" configured for the tests to run with | 16:55 |
| gouthamr | ex: *set(['2.5', '2.9', LATEST_MICROVERSION]) => this just helps us avoid the test case being run thrice (instead of twice) when the LATEST_MICROVERSION is also 2.9 | 16:57 |
| tosky | gouthamr: right, but then I'd say there should be a way to deduplicate by keeping the order | 17:34 |
| tosky | I just realized that would solve most of the issues we discussed about randomness | 17:34 |
| tosky | it's not ddt itself; it's the usage of set, and the usage of random values in ddt.data in a few tests | 17:34 |
| *** raissa has quit IRC | 18:11 | |
| openstackgerrit | Luigi Toscano proposed openstack/manila-tempest-plugin master: Preserve the items order when calling ddt.data() https://review.opendev.org/755859 | 18:11 |
| *** raissa has joined #openstack-manila | 18:11 | |
| *** raissa has quit IRC | 18:11 | |
| tosky | gouthamr, tbarron: ^ well, let's see | 18:12 |
| *** raissa has joined #openstack-manila | 18:12 | |
| *** raissa has quit IRC | 18:12 | |
| tbarron | gouthamr: i see (dedupe) | 18:13 |
| gouthamr | tosky: nice, this looks more readable | 18:17 |
| *** vhari has quit IRC | 19:10 | |
| openstackgerrit | Luigi Toscano proposed openstack/manila-tempest-plugin master: Preserve the items order when calling ddt.data() https://review.opendev.org/755859 | 19:27 |
| *** tosky has quit IRC | 19:57 | |
| *** tosky has joined #openstack-manila | 19:57 | |
| *** raissa has joined #openstack-manila | 19:58 | |
| *** tosky has quit IRC | 20:19 | |
| *** raissa has quit IRC | 20:27 | |
| *** raildo has quit IRC | 20:30 | |
| *** raissa has joined #openstack-manila | 20:31 | |
| *** eharney has quit IRC | 21:21 | |
| *** raissa has quit IRC | 22:01 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient master: Add a waiter to share create/delete https://review.opendev.org/755667 | 22:37 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!