Monday, 2020-02-10

openstackgerrithaixin proposed openstack/manila master: WIP:Support query user message by timestamp  https://review.opendev.org/70643800:32
*** openstackstatus has joined #openstack-manila01:16
*** ChanServ sets mode: +v openstackstatus01:16
*** brinzhang has joined #openstack-manila01:36
*** jmlowe has joined #openstack-manila02:21
*** jmlowe has quit IRC02:28
*** hoonetorg has quit IRC02:35
*** dviroel has quit IRC02:52
*** jcollin has quit IRC03:36
*** brinzhang has quit IRC04:51
*** brinzhang has joined #openstack-manila04:52
*** brinzhang_ has joined #openstack-manila04:53
*** brinzhang__ has joined #openstack-manila04:56
*** brinzhang has quit IRC04:57
*** brinzhang has joined #openstack-manila04:58
*** brinzhang has quit IRC04:59
*** brinzhang_ has quit IRC04:59
*** brinzhang__ has quit IRC05:00
*** maaritamm has joined #openstack-manila06:53
*** tosky has joined #openstack-manila07:35
openstackgerritMohammed Naser proposed openstack/manila stable/train: Use StrOpt for instance type  https://review.opendev.org/70674808:36
openstackgerritMohammed Naser proposed openstack/manila stable/train: generic: Refactor network functions to l3_init  https://review.opendev.org/70674908:36
openstackgerritMohammed Naser proposed openstack/manila stable/train: clear_outdated_routes: reduce neutron calls  https://review.opendev.org/70675008:36
openstackgerritMohammed Naser proposed openstack/manila stable/train: Refactor route clearing to linux interface  https://review.opendev.org/70675108:36
openstackgerritMohammed Naser proposed openstack/manila stable/train: Introduce noop interface driver  https://review.opendev.org/70675208:36
openstackgerritMohammed Naser proposed openstack/manila stable/train: Use psycopg2-binary for test-requirements  https://review.opendev.org/70675308:36
openstackgerritMohammed Naser proposed openstack/manila stable/train: Add opt doc and reno for noop interface driver  https://review.opendev.org/70675408:36
*** maaritamm has quit IRC09:07
*** maaritamm has joined #openstack-manila09:18
openstackgerritTom Barron proposed openstack/manila master: Test fixing bug 1848278  https://review.opendev.org/70439311:54
openstackbug 1848278 in Manila "tempest extend/shrink tests may use wrong share export location" [Low,In progress] https://launchpad.net/bugs/1848278 - Assigned to Tom Barron (tpb)11:54
*** dviroel has joined #openstack-manila12:27
*** brinzhang has joined #openstack-manila12:27
openstackgerritMerged openstack/manila stable/train: Use StrOpt for instance type  https://review.opendev.org/70674813:05
openstackgerritMerged openstack/manila stable/train: generic: Refactor network functions to l3_init  https://review.opendev.org/70674913:12
*** enriquetaso has joined #openstack-manila13:21
*** rraja has joined #openstack-manila13:24
openstackgerritVictoria Martinez de la Cruz proposed openstack/python-manilaclient master: [DNM] Testing functional gate  https://review.opendev.org/70682813:43
mnasertbarron: thanks for your reviews -- mind kicking https://review.opendev.org/#/c/706750/ over so the rest of the stack can enter the gate? :)13:51
tbarronmnaser: done13:53
mnasertbarron: thank you so much :)13:53
tbarronmnaser: and thanks again for these  contributions13:53
mnasertbarron: np! :) i'm sure a few others will show up here and there13:53
*** lpetrut has joined #openstack-manila13:55
*** brinzhang has quit IRC14:06
*** brinzhang has joined #openstack-manila14:10
*** jvisser has joined #openstack-manila14:21
*** brinzhang has quit IRC14:57
*** brinzhang has joined #openstack-manila14:58
*** brinzhang has quit IRC15:01
*** brinzhang has joined #openstack-manila15:01
*** eharney has joined #openstack-manila15:04
*** lpetrut has quit IRC15:08
openstackgerritMerged openstack/manila stable/train: clear_outdated_routes: reduce neutron calls  https://review.opendev.org/70675015:09
openstackgerritMerged openstack/manila stable/train: Refactor route clearing to linux interface  https://review.opendev.org/70675115:18
openstackgerritMerged openstack/manila stable/train: Introduce noop interface driver  https://review.opendev.org/70675215:18
openstackgerritMerged openstack/manila stable/train: Use psycopg2-binary for test-requirements  https://review.opendev.org/70675315:18
*** rraja has quit IRC15:22
*** jmlowe has joined #openstack-manila15:33
vkmco/15:34
vkmctosky, maybe you can tell us15:34
vkmcwe are looking to add more test coverage for the osc implementation maaritamm is working on15:35
vkmcat first sight, it makes sense to add more functional tests to the python-manilaclient component15:35
toskybut?15:35
* tosky senses a but comint15:36
toskycoming*15:36
vkmctempest is integration testing and not sure if we can add integration tests for osc, is it?15:36
vkmcno no, we will add the functional tests15:36
vkmcbut wondering if it makes sense to add tempest coverage15:36
toskywhat do you mean by "tempest coverage"?15:36
vkmclike, with tempest we hit the apis directly, we don't test shell clients15:36
vkmcis that accurate?15:37
toskynot completely15:37
toskythere is a class for testing CLI clients15:37
vkmcthat's what I wanted to get to :D15:37
toskyat least python-cinderclient and sahara-tests contain tests which use it15:37
toskyhttps://opendev.org/openstack/sahara-tests/src/branch/master/sahara_tempest_plugin/tests/cli/base.py15:39
toskyhttps://opendev.org/openstack/python-cinderclient/src/branch/master/cinderclient/tests/functional/base.py15:39
toskythere is some almost common code (look for _get_clients and credentials() respectively) that could be moved to tempest/lib at some point15:40
toskybut it can be copied/adapted for a start15:40
toskywell, they are not the same (the cinderclient version get the credentials from a separate configuration file, sahara-tests tries to be smart and gets them from tempest), but the idea is that you need some code for the credentials15:41
vkmccool15:44
vkmcso we can look into those examples and see if we can add some tempest coverage as well15:44
vkmcin manila-tempest-plugin15:44
vkmcwith tempest coverage I mean using the tempest suite to write some integration tests for the client15:44
vkmcmaaritamm, ^15:45
vkmcmaaritamm, we can start with functional testing on the client side and then we look into tempest15:45
vkmcso you get some experience working with them all15:45
maaritammok so I start in python-manilaclient and try to follow these two examples, yes?15:49
vkmcsounds good15:50
vkmc:)15:51
maaritammhttps://github.com/openstack/python-manilaclient/tree/master/manilaclient/tests/functional15:51
maaritammthe code should go there?15:51
vkmcmaaritamm, exactly... we might need to organize stuff a bit and see how we were testing the old cli client and where should we put the new cli client tests15:51
vkmclet me check the code and I'll get back to you with some ideas15:52
vkmcof course you can also check yourself and tell me where you think it would work better15:52
vkmcin the meantime, start by running the functional tests that are already there15:52
maaritammok, cool :)15:53
vkmcthanks tosky :)15:57
*** jmlowe has quit IRC16:39
*** tosky has quit IRC16:48
*** openstackstatus has quit IRC17:57
*** openstack has joined #openstack-manila18:00
*** ChanServ sets mode: +o openstack18:00
*** jmlowe has joined #openstack-manila18:12
*** jmlowe has quit IRC19:00
*** jmlowe has joined #openstack-manila19:03
*** eharney has quit IRC19:07
*** eharney has joined #openstack-manila19:09
*** jmlowe has quit IRC19:11
openstackgerritCarlos Eduardo proposed openstack/manila master: [WIP] Remove experimental flag from share groups feature  https://review.opendev.org/70695919:14
*** jmlowe has joined #openstack-manila19:20
*** jmlowe has quit IRC19:38
*** jmlowe has joined #openstack-manila19:40
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Create wrapper client for ceph clients  https://review.opendev.org/70696820:21
*** eharney has quit IRC20:22
*** jmlowe has quit IRC20:22
gouthamrone client to rule them all20:23
*** jmlowe has joined #openstack-manila20:36
*** jmlowe has quit IRC20:54
*** enriquetaso has quit IRC21:06
vkmc:D21:11
openstackgerritMerged openstack/manila stable/train: Add opt doc and reno for noop interface driver  https://review.opendev.org/70675421:17
gouthamrmaaritamm: there are some comments you've left in https://review.opendev.org/#/c/704157 - didn't know what they meant?21:31
gouthamrmaaritamm: my concern was about these specifically: https://review.opendev.org/#/c/704157/5/manila_ui/dashboards/project/shares/tables.py21:31
gouthamrmaaritamm/vkmc: do lemme know if we need to hold that patch for any reason21:32
*** maaritamm has quit IRC21:33
*** maaritamm has joined #openstack-manila21:35
maaritammhi gouthamr, I was asking about translation support there, I didn’t understand Akihiros comments at first.21:39
gouthamrmaaritamm: oh.. makes sense; you're okay separating that concern and addressing it in another change?21:43
maaritammyes, of course :)21:45
gouthamrmaaritamm: cool ty maaritamm21:45
maaritammsure np21:46
openstackgerritGoutham Pacha Ravi proposed openstack/manila-ui master: Raise python-manilaclient req to 1.29.0  https://review.opendev.org/70698822:01
openstackgerritGoutham Pacha Ravi proposed openstack/manila-ui master: Raise python-manilaclient req to 1.29.0  https://review.opendev.org/70698822:03
*** maaritamm has quit IRC22:28
*** openstackgerrit has quit IRC22:46
*** eharney has joined #openstack-manila23:02
*** openstackgerrit has joined #openstack-manila23:03
openstackgerritCarlos Eduardo proposed openstack/manila master: [WIP] Remove experimental flag from share groups feature  https://review.opendev.org/70695923:03
openstackgerritMerged openstack/manila-ui master: Update API version to 2.33  https://review.opendev.org/70415723:16

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!