Monday, 2019-02-18

*** erlon has joined #openstack-manila00:07
*** enriquetaso has quit IRC00:45
*** enriquetaso has joined #openstack-manila00:49
*** erlon has quit IRC02:19
*** enriquetaso has quit IRC03:31
*** e0ne has joined #openstack-manila06:41
*** e0ne has quit IRC06:47
*** e0ne has joined #openstack-manila07:35
*** e0ne has quit IRC07:38
*** pcaruana has joined #openstack-manila07:43
*** tosky has joined #openstack-manila08:33
*** pcaruana|afk| has joined #openstack-manila09:01
*** pcaruana has quit IRC09:02
*** e0ne has joined #openstack-manila09:08
*** trident has joined #openstack-manila09:38
*** pcaruana|afk| has quit IRC10:01
*** pcaruana has joined #openstack-manila10:07
openstackgerritMerged openstack/manila stable/rocky: [LVM] Run filesystem check before assigning UUID  https://review.openstack.org/63737810:33
*** luizbag has joined #openstack-manila11:08
*** erlon has joined #openstack-manila11:23
openstackgerritTom Barron proposed openstack/manila master: Suppress pylint warnings from dell_emc drivers  https://review.openstack.org/63673911:29
openstackgerritTom Barron proposed openstack/manila master: Suppress pylint warnings from dell_emc drivers  https://review.openstack.org/63673911:30
*** thgcorrea has joined #openstack-manila12:22
openstackgerritTom Barron proposed openstack/manila stable/queens: add tripleo scenario004 to experimental queue  https://review.openstack.org/63753212:34
*** enriquetaso has joined #openstack-manila13:13
*** eharney has joined #openstack-manila13:20
*** kaisers has quit IRC13:42
*** jmlowe has quit IRC13:43
*** kaisers has joined #openstack-manila13:49
*** ganso has joined #openstack-manila13:51
*** thgcorrea has quit IRC14:20
*** eharney has quit IRC14:23
*** thgcorrea has joined #openstack-manila14:34
*** jmlowe has joined #openstack-manila14:41
openstackgerritTom Barron proposed openstack/manila stable/queens: Fix service image boot issues  https://review.openstack.org/63756515:09
openstackgerritTom Barron proposed openstack/manila stable/queens: [LVM] Run filesystem check before assigning UUID  https://review.openstack.org/63756615:10
*** jmlowe has quit IRC15:20
*** jmlowe has joined #openstack-manila15:21
*** e0ne has quit IRC15:42
*** e0ne has joined #openstack-manila15:48
*** pcaruana has quit IRC16:10
*** e0ne has quit IRC16:34
*** eharney has joined #openstack-manila16:40
openstackgerritTom Barron proposed openstack/manila stable/queens: [LVM] Run filesystem check before assigning UUID  https://review.openstack.org/63756616:57
*** jmlowe has quit IRC17:02
*** carlos_silva has joined #openstack-manila17:19
*** jmlowe has joined #openstack-manila17:20
*** jmlowe has quit IRC17:31
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Deploy manila with uwsgi on devstack  https://review.openstack.org/63133817:37
*** jmlowe has joined #openstack-manila17:45
openstackgerritMerged openstack/puppet-manila master: Dell EMC Manila Driver- rebranding changes  https://review.openstack.org/63701618:07
openstackgerritMerged openstack/puppet-manila master: Service_token_roles_required missing in the server config file  https://review.openstack.org/63709818:20
*** e0ne has joined #openstack-manila18:24
gansogouthamr: ping18:52
gouthamrhey ganso o/18:52
gansogouthamr: hey Goutham! I have reviewed your patch https://review.openstack.org/#/c/63315518:55
gansogouthamr: shouldn't it have the APIImpact flag?18:55
gansogouthamr: in the commit mss18:56
gansogouthamr: *msg18:56
gouthamrganso: it should, i've not been using that flag very consistently, my bad... but it has DocImpact though, because i am missing docs, and would like to track and get them up18:57
gouthamrganso: i'll add notes to the API-Ref if necessary when i close the resulting doc bug18:57
gansogouthamr: ok, I'll add it along with my other comment19:00
gouthamrganso: thanks!19:00
gansogouthamr: done19:00
gansogouthamr: wait, sorry, I may have misinterpreted what you just said19:01
gansogouthamr: did you say that it is ok to miss the APIImpact flag because you will add notes to the API-Ref?19:02
gansogouthamr: "APIImpact - Use this tag when the code change modifies a public HTTP API interface. This tag indicates that the patch creates, changes, or deletes a public API interface or changes its behavior. The tag may be followed by a reason beginning on the next line. If you are touching manila’s API layer and you are unsure if your change has an impact on the API, use this tag anyway."19:02
gouthamrganso: yes, we used to add the APIImpact flag to ask for API reviews from the API SIG, we haven't been doing that for the last few releases... right now, i tend to use that flag to only call out real impact (potentially backwards affecting compatibility - with reasonoing) that i want reviewers' attention on... not changes that preserve backwards compatibility19:04
gouthamrganso: sorta like forgetting "TrivialFix" in teh commit messages :) i.e, it's a convention, but we don't enforce it19:06
gansogouthamr: oh ok19:06
gansogouthamr: so if you think it there is no problem I can just workflow it19:06
gouthamrganso: yes, responded to your other comment in line..19:07
gansogouthamr: ok, so I will workflow it19:07
gouthamrthanks ganso19:08
openstackgerritRodrigo Barbieri proposed openstack/manila-tempest-plugin master: Temporarily disable test_manage_invalid  https://review.openstack.org/63588519:19
gansogouthamr, bswartz, toabctl: Hi folks! Friendly reminder that Manage/Unmanage in DHSS=True patches are ready in gerrit waiting for your reviews: https://wiki.openstack.org/wiki/Manila/SteinCycle#Manage.2FUnmanage_Share_Servers Thanks in advance! =)19:20
gansoI see tbarron has started reviewing the code. Thanks! =D19:20
bswartzganso: Today is US holiday19:20
bswartzNobody in office19:20
gansobswartz: oh, my bad! didn't know19:21
gouthamrme neither :D /kidding19:21
gansobswartz: looking forward for your review tomorrow then hah. enjoy the holiday! =D19:21
gouthamrganso: where be the tempest tests? i started looking at the code too, would be nice to see the test cases in parallel19:22
gouthamrthere's a ton of LOCs of change, and i bet the unit tests were a pain to write, but, we mock out way too much good stuff in the unit tests that only end-to-end tests finally catch :) case-in-point, my patch you just workflowed :D19:23
gansogouthamr: yup there will be, we are finishing them and will probably submit them by the end of the day tomorrow19:26
gouthamrganso: nice, thanks19:28
*** e0ne has quit IRC19:30
*** e0ne has joined #openstack-manila19:37
bswartzgouthamr: you're not taking the day off?19:57
bswartzThing must have gone downhill since the acquisition ;-)19:57
gouthamrbswartz: nope, not a day off for me/tbarron :)19:57
gouthamrmaybe they don't like the current president or something :D19:58
bswartzI think president's day is for the dead ones19:58
*** thgcorrea has quit IRC20:00
gouthamrbswartz: makes sense, my humor is on vacation today :P20:02
bswartzI was trying to make a joke about IBM20:07
*** luizbag has quit IRC20:19
*** eharney has quit IRC20:29
openstackgerritMerged openstack/manila stable/queens: Fix service image boot issues  https://review.openstack.org/63756520:38
openstackgerritMerged openstack/manila stable/queens: [LVM] Run filesystem check before assigning UUID  https://review.openstack.org/63756620:38
openstackgerritMerged openstack/manila master: Allow configuring availability_zones in share types  https://review.openstack.org/63315520:38
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: [ZFSOnLinux] Log ZFS options as they are retrieved  https://review.openstack.org/63762620:47
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: [ZFSOnLinux] Log ZFS options as they are retrieved  https://review.openstack.org/63762620:48
*** jmlowe has quit IRC20:56
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: Add policy to create/update public shares  https://review.openstack.org/63486420:56
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: Fix typo in test name  https://review.openstack.org/63762920:59
* gouthamr --20:59
*** erlon has quit IRC21:04
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Deploy manila with uwsgi on devstack  https://review.openstack.org/63133821:12
*** ganso has quit IRC21:50
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: [pylint] Stop linting usage of 'mock.Mock' module  https://review.openstack.org/63763421:54
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: [pylint] - DNM - Run pylint on the whole tree  https://review.openstack.org/63763721:57
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: [pylint] - DNM - Run pylint on the whole tree  https://review.openstack.org/63763721:59
*** e0ne has quit IRC22:03
*** e0ne has joined #openstack-manila22:04
*** carlos_silva has quit IRC22:09
*** enriquetaso has quit IRC22:26
openstackgerritGoutham Pacha Ravi proposed openstack/manila master: Fix sshpool.remove  https://review.openstack.org/63764422:32
*** jmlowe has joined #openstack-manila22:32
*** S0ru has joined #openstack-manila22:43
*** eharney has joined #openstack-manila22:45
S0ruHi everyone! I'm Sol, I've just joined Outreachy and I'd like to participate on Sofia Enriquez's project. Nice to meet you!22:51
*** eharney has quit IRC22:58
*** e0ne has quit IRC23:12
gouthamrS0ru: hey Sol!23:16
gouthamrS0ru: glad to have you here! Welcome23:17
gouthamrS0ru: this channel is usually buzzing during US work-time since a bulk of the contributors align with the US East Coast timezone.. that said, most of us have IRC bouncers so we can always answer your questions when we're back in front of our keyboards23:19
*** e0ne has joined #openstack-manila23:23
*** e0ne has quit IRC23:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!